| ronaldv | |
| ngraham |
| KNewStuff |
When the server does not support certain commands (such as voting), don't be quite so loud about it. It is not a critical error, and we should accept it when we are told so.
Also, the same bug report covers votes being sent out during listing of items. This is caused by the rating being set sometime after setting up a signal chain, and then changing the rating of the widget. So, block signals when we're simply updating the rating's internal state.
BUG:391111
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/ui/itemsviewdelegate.cpp | ||
|---|---|---|
| 287 | Why do we need to do this twice? | |
| src/ui/itemsviewdelegate.cpp | ||
|---|---|---|
| 287 | ehrm... we don't, we need to undo it, and i forgot to swap that true for a false ;) Thanks! | |
Thanks! Makes sense, and fixes the bug. :)
Of course the underlying issue is still present. If you can't vote from the GHNS dialogs, there shouldn't be a UI for let you try; it should be strictly read-only. I suppose that's a separate matter though.
Yeah, first step being to not make things look critically broken is good, and then we can work out the larger thing of making it behave pleasantly and disallow voting for servers which don't, well, allow it :)