Thanks for the patches! You can add Closes T9050 to one of those to make it automatically close this ticket once it's landed.
- Queries
- All Stories
- Search
- Advanced Search
All Stories
Jun 20 2018
FWIW when I enabled borderless windows for these patches to test out the first time ever, I once tried to click in the dead zone to activate the window below and then was for a moment annoyed that it didn't work.
In D13631#280723, @heikobecker wrote:Cool idea and patch!
patch icon name https://phabricator.kde.org/D13637
Right. That's not a workflow I think I've ever seen anyone do with a windowed game. For anyone who wants to do that, they can always turn the borders back on. Or just resize one of the windows slightly so the dead zone doesn't overlap the game window. Or not try to play a windowed game right next to a window that's explicitly marked as always on top. Or any number of other very simple tweaks.
patch plasma theme icons: https://phabricator.kde.org/D13636
Update to Heiko's first feedback
Cool idea and patch!
The dead zone exists if you have a focussed lower stacked client.
What is the problem with an FPS in windowed mode? If anything, the potential problem would be a windowed RTS or other game where you're expected to move the view by touching a window edge. But even in this case, the "dead zone" is outside the window rather than inside it, so that critical pixel is always available to the game, and I don't see what the issue is. I sometimes plan Endless Sky windowed with No Borders and I've never encountered a single issue related to the dead zone. Can you clarify which potential issues you're worried about?
Update to Jos' first feedback
I'll get back to work on this. I've got a current open patch I need to finish up first, then I'll resume work on this. Should be a couple days at most.
@vandenoever Thanks for quick turn-around review. No comment on the ODF side of things? :) That's what I hoped for, if there was anything else that could be added (or is wrong). Besides making an ODF fellow aware of this new ODF related feature ;)
In D13481#279575, @davidedmundson wrote:There are two visual hints when the mouse is inside the deadzone.
You would still get the different cursor The client gets the mouse left event and would not show any hover effect on whatever control might be there.
Updating tools.xml <annotation> elements color attributes to incorporate #AARRGGBB color formats
- Lays' Suggestion
Nice addition! You might want to apply some of the suggested changes.
Ping.
Ping.
Ping.
also de folder isn't plugins with lower letter case?
@croick Will see to give this a look later this week/on the WE.
@dkardarakos Hi, "your" = "mine"? :) I sadly cannot give valuable feedback other than explaining how the current plasma weather applet & dataengine code works. I have no insight in the application model concepts with Plasma Mobile and where it thus is different from what we have with widgets in the Plasma Desktop shell.
I can see Marco's point, so I can't be the tie-breaker. Other opinions?
Mainly inspired from the PDF variant.
Filtered out devices that are not paired
- ArrayList<ListAdapter.Item> commandItems; renamed to deviceItems
- Coding style
I think I'll just leave this here :
New revision with remaining tasks: D12498
In T8569#148166, @ngraham wrote:Hmm, I think maybe I confused you, @sharvey. I was referring to this project, and I was wondering why you seemed to have abandoned it! ;-)
Thank you all! For my part, using Kubuntu 18.04: my performed tests went alright; some files (inside an iso file) that could not be seen, now can be seen correctly. Other people can do their checks.