zzag (Vlad Zagorodniy)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Dec 16 2017, 8:25 AM (39 w, 5 d)
Availability
Available

Recent Activity

Tue, Sep 18

zzag added inline comments to D15595: Rework InputDeviceHandler focus tracking.
Tue, Sep 18, 9:02 PM · KWin
zzag added a comment to D14919: [effects/dialogparent] Fix flickering of parent windows.

I think this patch should be rebased on the fullscreen patch.

Tue, Sep 18, 1:04 PM · KWin
zzag updated the summary of D14919: [effects/dialogparent] Fix flickering of parent windows.
Tue, Sep 18, 1:03 PM · KWin
zzag added inline comments to D14561: [kcmkwin/compositing] Rename Candy category to Eye Candy.
Tue, Sep 18, 1:02 PM · KWin

Mon, Sep 17

zzag added a comment to T5218: Use QtQuick for EffectFrames.

Also I've tried to keep it generic so that rendering a frame + text is just one implementation of a more generic way for effects to render arbitrary QML.

Mon, Sep 17, 6:18 PM · KWin
zzag updated the diff for D15372: [effects] Make scripted effects GHNS-able.

Add missing Q_OBJECT macro

Mon, Sep 17, 3:34 PM · KWin
zzag updated the diff for D15372: [effects] Make scripted effects GHNS-able.

Edit file names

Mon, Sep 17, 3:29 PM · KWin
zzag updated the diff for D15372: [effects] Make scripted effects GHNS-able.

More cleaner keys

Mon, Sep 17, 3:21 PM · KWin
zzag updated the diff for D15372: [effects] Make scripted effects GHNS-able.

Address inline comments

Mon, Sep 17, 3:17 PM · KWin
zzag added a comment to D15372: [effects] Make scripted effects GHNS-able.

It's a bit weird to use kpackage here but not in ScriptedEffect itself but we can deal with that later.

Mon, Sep 17, 2:05 PM · KWin
zzag added inline comments to D14561: [kcmkwin/compositing] Rename Candy category to Eye Candy.
Mon, Sep 17, 1:42 PM · KWin
zzag added a comment to D14868: RFC: Keep Deleted transients above old parents.

That's pretty ugly solution, but somehow it works. :/

Mon, Sep 17, 1:16 PM · KWin
zzag updated the diff for D14868: RFC: Keep Deleted transients above old parents.

Support group transients

Mon, Sep 17, 1:15 PM · KWin
zzag added a comment to D14561: [kcmkwin/compositing] Rename Candy category to Eye Candy.

Ping.

Mon, Sep 17, 10:38 AM · KWin
zzag committed R108:91ddeea7503f: [effects/coverswitch] Port to TimeLine (authored by zzag).
[effects/coverswitch] Port to TimeLine
Mon, Sep 17, 10:35 AM
zzag closed D15302: [effects/coverswitch] Port to TimeLine.
Mon, Sep 17, 10:35 AM · KWin
zzag added a comment to D10750: wayland: Add support for zwp_linux_dmabuf.

Any update on this?

Mon, Sep 17, 8:08 AM · KWin
zzag added a comment to D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX.

Ping.

Mon, Sep 17, 6:45 AM · Frameworks

Sat, Sep 15

zzag committed R31:3a06f1e1fdab: [kstyle] Upload rounded blur region (authored by zzag).
[kstyle] Upload rounded blur region
Sat, Sep 15, 2:19 PM

Fri, Sep 14

zzag updated the diff for D15514: [libbreezecommon] Use box blur instead of FFT approach.

Simplify code, also delete unrelated changes

Fri, Sep 14, 9:23 PM · Plasma
zzag planned changes to D15514: [libbreezecommon] Use box blur instead of FFT approach.

Simplify it further.

Fri, Sep 14, 9:03 PM · Plasma
zzag updated the diff for D15514: [libbreezecommon] Use box blur instead of FFT approach.

Code formatting

Fri, Sep 14, 8:56 PM · Plasma
zzag added a comment to D15514: [libbreezecommon] Use box blur instead of FFT approach.

Yeah, I also can't tell the difference. If this new way is computationally cheaper, then +1 from me.

Fri, Sep 14, 8:53 PM · Plasma
zzag updated the diff for D15514: [libbreezecommon] Use box blur instead of FFT approach.

Call reserve method

Fri, Sep 14, 8:42 PM · Plasma
zzag updated the diff for D15514: [libbreezecommon] Use box blur instead of FFT approach.

Edit comments

Fri, Sep 14, 8:35 PM · Plasma
zzag requested review of D15514: [libbreezecommon] Use box blur instead of FFT approach.
Fri, Sep 14, 8:12 PM · Plasma
zzag committed R31:a0492cc9486e: [libbreezecommon] Use box blur instead of FFT approach (authored by zzag).
[libbreezecommon] Use box blur instead of FFT approach
Fri, Sep 14, 7:07 PM
zzag added a comment to D15496: [effects/cubeslide] Fix "sticky" windows detection on Wayland.

@davidedmundson Should this patch wait for a Plasma::Dialog fix?

Fri, Sep 14, 4:07 PM · KWin
zzag added a comment to D15175: [effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect.

I'll make readability changes you've mentioned in a separate commit then.

Fri, Sep 14, 9:55 AM · KWin
zzag added a comment to D15496: [effects/cubeslide] Fix "sticky" windows detection on Wayland.

Please rebase this change on master.

Fri, Sep 14, 9:52 AM · KWin
zzag added a comment to D15175: [effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect.

BTW, should it be backported to 5.15 or something?

Fri, Sep 14, 9:50 AM · KWin
zzag committed R108:9043c092f9ff: [effects/cubeslide] Always slide desktop window (authored by zzag).
[effects/cubeslide] Always slide desktop window
Fri, Sep 14, 9:48 AM
zzag added a comment to D15175: [effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect.

@poboiko Did you address my inline comments on push?

Fri, Sep 14, 9:43 AM · KWin
zzag added a comment to D15496: [effects/cubeslide] Fix "sticky" windows detection on Wayland.

This diff has supposed to replace !w->isManaged with w->isSpecialWindow. As @davidedmundson said, we work around KDE's code. The desktop switch OSD has to set appropriate window type (see scripts/desktopchangeosd).

Fri, Sep 14, 9:15 AM · KWin
zzag added inline comments to D7038: [server] Respect input region of sub-surfaces on pointer surface focus.
Fri, Sep 14, 8:57 AM · Frameworks, Plasma on Wayland
zzag accepted D15175: [effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect.

Looks good to me. Change FIXED-IN to 5.15.0

Fri, Sep 14, 8:49 AM · KWin
zzag added a comment to D15175: [effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect.

Yeah, sure, I can separate that one-line change. Should I post it on Phabricator as well?

Fri, Sep 14, 7:33 AM · KWin
zzag added inline comments to D7038: [server] Respect input region of sub-surfaces on pointer surface focus.
Fri, Sep 14, 7:18 AM · Frameworks, Plasma on Wayland

Thu, Sep 13

zzag added a comment to D14688: [libkwineffects] Expose getting/setting activeFullScript to scripted effects.

Frankly, I prefer the old approach (with tristate). Now, we have two very similar properties.

Thu, Sep 13, 5:11 PM · KWin
zzag added inline comments to D15175: [effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect.
Thu, Sep 13, 5:04 PM · KWin
zzag added inline comments to D15175: [effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect.
Thu, Sep 13, 5:04 PM · KWin
zzag added a comment to D15175: [effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect.

This diff addresses two 2 different problems:

  • visual artifacts caused by the blur and the background contrast effect;
  • usage of isManaged for Wayland clients.
Thu, Sep 13, 4:46 PM · KWin
zzag abandoned D15480: [wayland] Dismiss popups when they lose focus.

OK, then.

Thu, Sep 13, 4:18 PM · KWin
zzag updated the summary of D15480: [wayland] Dismiss popups when they lose focus.
Thu, Sep 13, 2:21 PM · KWin
zzag requested review of D15480: [wayland] Dismiss popups when they lose focus.
Thu, Sep 13, 2:16 PM · KWin
zzag committed R108:213239a0ea0a: [shadow] Rebuild quads after creation of shadow (authored by zzag).
[shadow] Rebuild quads after creation of shadow
Thu, Sep 13, 1:20 PM
zzag closed D15475: [shadow] Rebuild quads after creation of shadow.
Thu, Sep 13, 1:20 PM · KWin
zzag updated the summary of D15475: [shadow] Rebuild quads after creation of shadow.
Thu, Sep 13, 1:19 PM · KWin
zzag accepted D15473: [effects/fadedesktop] Port to explicit animate API.
Thu, Sep 13, 11:57 AM · KWin
zzag accepted D15476: [effects/fadedesktop] Fade to the correct opacity.
Thu, Sep 13, 11:56 AM · KWin
zzag requested review of D15475: [shadow] Rebuild quads after creation of shadow.
Thu, Sep 13, 11:15 AM · KWin
zzag added a comment to D15474: [effects/fadedesktop] Set animation as a fullscreen effect.

I didn't test this patch but I'm pretty sure we have to "force" WindowForceBackgroundContrastRole and WindowForceBlurRole.

Thu, Sep 13, 10:46 AM · KWin
zzag added inline comments to D15473: [effects/fadedesktop] Port to explicit animate API.
Thu, Sep 13, 10:44 AM · KWin

Wed, Sep 12

zzag added a comment to D14536: [scripting] Port ScriptedEffects to QJSEngine.

My other options I've considered are:

Wed, Sep 12, 5:38 PM · KWin
zzag committed R108:74994a7fbda0: [effects/trackmouse] Allow to use both modifiers and shortcut (authored by zzag).
[effects/trackmouse] Allow to use both modifiers and shortcut
Wed, Sep 12, 1:37 PM
zzag closed D15272: [effects/trackmouse] Allow to use both modifiers and shortcut.
Wed, Sep 12, 1:37 PM · KWin
zzag updated the diff for D15272: [effects/trackmouse] Allow to use both modifiers and shortcut.

Don't fall through

Wed, Sep 12, 1:19 PM · KWin
zzag updated the diff for D15272: [effects/trackmouse] Allow to use both modifiers and shortcut.

Fix on Wayland

Wed, Sep 12, 1:17 PM · KWin
zzag added inline comments to D15272: [effects/trackmouse] Allow to use both modifiers and shortcut.
Wed, Sep 12, 12:49 PM · KWin
zzag added inline comments to D15272: [effects/trackmouse] Allow to use both modifiers and shortcut.
Wed, Sep 12, 12:46 PM · KWin

Tue, Sep 11

zzag added a comment to D15272: [effects/trackmouse] Allow to use both modifiers and shortcut.

Ping?

Tue, Sep 11, 6:42 PM · KWin
zzag committed R108:cc1f30b43d16: [effects/showpaint] Modernize code (authored by zzag).
[effects/showpaint] Modernize code
Tue, Sep 11, 2:01 PM
zzag closed D15424: [effects/showpaint] Modernize code.
Tue, Sep 11, 2:01 PM · KWin
zzag updated the diff for D15424: [effects/showpaint] Modernize code.

Add alpha const

Tue, Sep 11, 1:10 PM · KWin
zzag updated the diff for D15424: [effects/showpaint] Modernize code.

Constify alpha in paintXrender

Tue, Sep 11, 1:06 PM · KWin
zzag added a comment to D15424: [effects/showpaint] Modernize code.

This is diff is a squashed version of https://github.com/zzag/kwin/commits/effects-showpaint-modernize

Tue, Sep 11, 1:00 PM · KWin
zzag requested review of D15424: [effects/showpaint] Modernize code.
Tue, Sep 11, 1:00 PM · KWin
zzag added inline comments to D15020: [xwl] Move Xwayland parts into separate class.
Tue, Sep 11, 11:28 AM · KWin
zzag committed R108:113ebe9bc225: [effects] Fix type of X-KWin-Video-Url (authored by zzag).
[effects] Fix type of X-KWin-Video-Url
Tue, Sep 11, 11:13 AM
zzag closed D15373: [effects] Fix type of X-KWin-Video-Url.
Tue, Sep 11, 11:13 AM · KWin
zzag added inline comments to D15020: [xwl] Move Xwayland parts into separate class.
Tue, Sep 11, 10:23 AM · KWin
zzag added inline comments to D14536: [scripting] Port ScriptedEffects to QJSEngine.
Tue, Sep 11, 9:05 AM · KWin

Mon, Sep 10

zzag committed R108:03a2a05fc7f2: [effects/dialogparent] Fix strict mode issues (authored by zzag).
[effects/dialogparent] Fix strict mode issues
Mon, Sep 10, 7:49 PM
zzag closed D15413: [effects/dialogparent] Fix strict mode issues.
Mon, Sep 10, 7:49 PM · KWin
zzag requested review of D15413: [effects/dialogparent] Fix strict mode issues.
Mon, Sep 10, 7:20 PM · KWin
zzag added a comment to D14536: [scripting] Port ScriptedEffects to QJSEngine.

As an alternative approach, we could wrap EffectsHandler and EffectWindow.

Mon, Sep 10, 7:20 PM · KWin
zzag committed R108:617b4d92fa54: [effects/magnifier] Fix 1 px gap between magnified area and frame (authored by zzag).
[effects/magnifier] Fix 1 px gap between magnified area and frame
Mon, Sep 10, 10:19 AM
zzag closed D15275: [effects/magnifier] Fix 1 px gap between magnified area and frame.
Mon, Sep 10, 10:19 AM · KWin
zzag added a comment to D15275: [effects/magnifier] Fix 1 px gap between magnified area and frame.

I'll adjust the commit message on push.

Mon, Sep 10, 10:06 AM · KWin
zzag updated the diff for D15275: [effects/magnifier] Fix 1 px gap between magnified area and frame.

Use QRectF

Mon, Sep 10, 10:02 AM · KWin
zzag added a comment to D15275: [effects/magnifier] Fix 1 px gap between magnified area and frame.

I struggle to see how

QRectF areaF = area;
inside the one block where we make the vertices is a "can of worms". It's scarcely even one worm.

but you have this approved, do whichever.

Mon, Sep 10, 9:54 AM · KWin
zzag added a comment to D15275: [effects/magnifier] Fix 1 px gap between magnified area and frame.

As you're doing the common fix for QRect::right/bottom fix would it be cleaner to just use a QRectF for the area and then kill all the +1s?

Mon, Sep 10, 9:29 AM · KWin
zzag added a comment to D15272: [effects/trackmouse] Allow to use both modifiers and shortcut.

Ping.

Mon, Sep 10, 8:35 AM · KWin
zzag added a comment to D15275: [effects/magnifier] Fix 1 px gap between magnified area and frame.

Ping.

Mon, Sep 10, 8:34 AM · KWin

Sun, Sep 9

zzag added a comment to D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX.

I'm not a KWindowSystem developer so take this with a grain of salt, but maybe it makes sense to still support the old name in case someone is really using it and add the new one as a synonym?

Sun, Sep 9, 7:10 PM · Frameworks
zzag updated the diff for D15372: [effects] Make scripted effects GHNS-able.

Fix typo in my last name

Sun, Sep 9, 3:32 PM · KWin
zzag updated the diff for D15372: [effects] Make scripted effects GHNS-able.

Don't use rawData

Sun, Sep 9, 3:29 PM · KWin
zzag added inline comments to D15357: [Bookmarks Runner] Remove duplicate results for bookmarks.
Sun, Sep 9, 1:35 PM · Plasma
zzag added inline comments to D15357: [Bookmarks Runner] Remove duplicate results for bookmarks.
Sun, Sep 9, 1:32 PM · Plasma
zzag added inline comments to D15357: [Bookmarks Runner] Remove duplicate results for bookmarks.
Sun, Sep 9, 1:01 PM · Plasma
zzag updated the summary of D15372: [effects] Make scripted effects GHNS-able.
Sun, Sep 9, 11:29 AM · KWin
zzag updated the summary of D15372: [effects] Make scripted effects GHNS-able.
Sun, Sep 9, 11:28 AM · KWin
zzag retitled D15372: [effects] Make scripted effects GHNS-able from [effects] Make scripted effect GHNS-able to [effects] Make scripted effects GHNS-able.
Sun, Sep 9, 11:27 AM · KWin
zzag requested review of D15373: [effects] Fix type of X-KWin-Video-Url.
Sun, Sep 9, 11:26 AM · KWin
zzag requested review of D15372: [effects] Make scripted effects GHNS-able.
Sun, Sep 9, 11:26 AM · KWin

Sat, Sep 8

zzag added a comment to D15175: [effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect.

Which OSDs specifically?

Sat, Sep 8, 9:53 PM · KWin
zzag requested review of D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX.
Sat, Sep 8, 4:43 PM · Frameworks

Fri, Sep 7

zzag added a comment to D8388: Do not hardcode unhovered windows brightness on present windows effect.

From KWin side: PresentWindows is actually in change freeze since a long time. The code is fragile and I don't like to see it being changed again. The code is straight forward and I don't think it would cause issue, but I'm looking at the bigger picture here with having blocked changes for years because the code is fragile.

Fri, Sep 7, 1:32 PM · KWin
zzag committed R127:3c128a612c1f: [autotests] Compare booleans to booleans (authored by zzag).
[autotests] Compare booleans to booleans
Fri, Sep 7, 1:01 PM
zzag closed D15330: [autotests] Compare booleans to booleans.
Fri, Sep 7, 1:01 PM · Frameworks