zzag (Vlad Zahorodnii)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 16 2017, 8:25 AM (92 w, 1 d)
Availability
Available

Recent Activity

Fri, Sep 20

zzag committed R108:4c7dd52728ee: Delete pointless GRAB_SERVER_DURING_CONTEXT macro (authored by zzag).
Delete pointless GRAB_SERVER_DURING_CONTEXT macro
Fri, Sep 20, 7:45 PM
zzag closed D24119: Delete pointless GRAB_SERVER_DURING_CONTEXT macro.
Fri, Sep 20, 7:45 PM · KWin
zzag committed R108:5e71c2a608c4: Move supported window type masks to matching cpp files (authored by zzag).
Move supported window type masks to matching cpp files
Fri, Sep 20, 7:45 PM
zzag closed D24120: Move supported window type masks to matching cpp files.
Fri, Sep 20, 7:45 PM · KWin
zzag updated the diff for D24120: Move supported window type masks to matching cpp files.

Edit summary.

Fri, Sep 20, 7:41 PM · KWin
zzag added a comment to D24119: Delete pointless GRAB_SERVER_DURING_CONTEXT macro.

Relevant commit: b36b242f1236c907ae3b14b0dc35ed27e5882d6d

Fri, Sep 20, 7:19 PM · KWin
zzag requested review of D24120: Move supported window type masks to matching cpp files.
Fri, Sep 20, 7:12 PM · KWin
zzag requested review of D24119: Delete pointless GRAB_SERVER_DURING_CONTEXT macro.
Fri, Sep 20, 7:11 PM · KWin
zzag added a comment to D23514: [platforms/x11] Never block on retrace, always present after paint.
Fri, Sep 20, 4:48 PM · KWin
zzag added inline comments to D23511: Remove vsync detection and configurability.
Fri, Sep 20, 4:20 PM · KWin
zzag added inline comments to D23511: Remove vsync detection and configurability.
Fri, Sep 20, 11:21 AM · KWin

Thu, Sep 19

zzag committed R108:b8a6fd7c4678: Don't initialize QFlags<T> with nullptr (authored by zzag).
Don't initialize QFlags<T> with nullptr
Thu, Sep 19, 6:42 PM
zzag closed D24086: Don't initialize QFlags<T> with nullptr.
Thu, Sep 19, 6:42 PM · KWin
zzag added inline comments to D23618: Use nullptr everywhere.
Thu, Sep 19, 4:08 PM · KWin
zzag updated the diff for D24086: Don't initialize QFlags<T> with nullptr.

apol's suggestion.

Thu, Sep 19, 4:02 PM · KWin
zzag accepted D22887: Load animation speed from new global animation speed controller.
Thu, Sep 19, 3:52 PM · KWin
zzag added inline comments to D24075: [kcmkwin/compositing] Hide animation speed slider on Plasma.
Thu, Sep 19, 3:50 PM · KWin
zzag accepted D24084: Migrate kwin animation speed to kdeglobals.
Thu, Sep 19, 3:41 PM · KWin
zzag requested review of D24086: Don't initialize QFlags<T> with nullptr.
Thu, Sep 19, 3:19 PM · KWin
zzag added inline comments to D23618: Use nullptr everywhere.
Thu, Sep 19, 2:51 PM · KWin
zzag committed R108:d18fa5217bde: Merge branch 'Plasma/5.17' (authored by zzag).
Merge branch 'Plasma/5.17'
Thu, Sep 19, 2:50 PM
zzag committed R108:62a7db702814: Use nullptr everywhere (authored by zzag).
Use nullptr everywhere
Thu, Sep 19, 2:50 PM
zzag closed D23618: Use nullptr everywhere.
Thu, Sep 19, 2:50 PM · KWin
zzag added a comment to D23618: Use nullptr everywhere.

I have to admit in hindsight that I was maybe wrong on this one not being in 5.17. Since only having the change on master but not in the 5.17 branch could complicate porting back bug fixes. Would you guys agree to that? And since we are still at the beginning of beta phase shall we apply it also to 5.17 branch?

Thu, Sep 19, 12:35 PM · KWin
zzag updated the diff for D23618: Use nullptr everywhere.

Rebase.

Thu, Sep 19, 12:27 PM · KWin

Wed, Sep 18

zzag added a comment to D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).

Thanks for the patch Jason. So the GSendStr(nullptr) is called on m_password.isNull() because this aborts the current PAM session? If this is correct, patch looks good to me.

Wed, Sep 18, 7:45 PM · Plasma
zzag added a comment to D22887: Load animation speed from new global animation speed controller.

@davidedmundson Is this 5.17 stuff?

Wed, Sep 18, 3:18 PM · KWin
zzag committed R108:fec0ab818d24: Emphasize minimization in MinimizeAll script (authored by smerkov).
Emphasize minimization in MinimizeAll script
Wed, Sep 18, 3:12 PM
zzag closed D24044: Emphasize minimization in MinimizeAll script.
Wed, Sep 18, 3:12 PM · KWin
zzag added a comment to D24044: Emphasize minimization in MinimizeAll script.

Sorry but i don't know how to do it. Can you commit?

Wed, Sep 18, 3:03 PM · KWin
zzag added a comment to D24044: Emphasize minimization in MinimizeAll script.

Nitpick: please use imperative mood in the subject line.

Wed, Sep 18, 2:50 PM · KWin
zzag accepted D24044: Emphasize minimization in MinimizeAll script.

Do you have commit access?

Wed, Sep 18, 2:45 PM · KWin
zzag committed R108:2ad37c449fd6: Port away from deprecated QString::sprintf (authored by zzag).
Port away from deprecated QString::sprintf
Wed, Sep 18, 1:29 PM
zzag closed D24045: Port away from deprecated QString::sprintf.
Wed, Sep 18, 1:29 PM · KWin
zzag committed R108:5ad3c0ee13e5: Port away from deprecated qVariantFromValue (authored by zzag).
Port away from deprecated qVariantFromValue
Wed, Sep 18, 1:29 PM
zzag closed D24042: Port away from deprecated qVariantFromValue.
Wed, Sep 18, 1:29 PM · KWin
zzag committed R108:09b47b5250db: Undo some recent cmake changes (authored by zzag).
Undo some recent cmake changes
Wed, Sep 18, 1:29 PM
zzag added a comment to D24051: [platforms/drm] introduce env var to select GPU.

I'm ok with having this as a short-term fix but long-term this env var should go away again and be replaced with a better selection mechanism. So no guarantee that it will be available after 5.18 LTS.

Wed, Sep 18, 1:21 PM · KWin
zzag added a reviewer for D24044: Emphasize minimization in MinimizeAll script: KWin.

What about simplifying it a bit as well? e.g.

Wed, Sep 18, 11:00 AM · KWin
zzag requested review of D24045: Port away from deprecated QString::sprintf.
Wed, Sep 18, 8:46 AM · KWin
zzag requested review of D24042: Port away from deprecated qVariantFromValue.
Wed, Sep 18, 8:09 AM · KWin

Tue, Sep 17

zzag committed R108:dcf91d4321a4: Cleanup style in CMakeLists.txt files (authored by zzag).
Cleanup style in CMakeLists.txt files
Tue, Sep 17, 1:45 PM
zzag accepted D24014: [KWayland] Port away from deprecated API in Qt 5.14.
Tue, Sep 17, 12:12 PM · Frameworks
zzag committed R108:c8aa258ebaa1: Keep things sorted alphabetically in CMakeLists.txt (authored by zzag).
Keep things sorted alphabetically in CMakeLists.txt
Tue, Sep 17, 8:43 AM
zzag closed D24018: Keep things sorted alphabetically in CMakeLists.txt.
Tue, Sep 17, 8:43 AM · KWin
zzag requested review of D24018: Keep things sorted alphabetically in CMakeLists.txt.
Tue, Sep 17, 8:08 AM · KWin
zzag added a comment to D23909: Pass area by const reference to placeFoo methods.

Please next time besides a title add a meaningful description if you push a patch with more than a trivial change and without review. I assume it was just a mistake that you also didn't link back to the review in the commit bccbb8f3a5f8.

Tue, Sep 17, 7:45 AM · KWin
zzag closed D23909: Pass area by const reference to placeFoo methods.
Tue, Sep 17, 7:31 AM · KWin
zzag accepted D24002: Sort files alphabetically in cmake list.
Tue, Sep 17, 7:30 AM · Frameworks
zzag added inline comments to D24014: [KWayland] Port away from deprecated API in Qt 5.14.
Tue, Sep 17, 7:27 AM · Frameworks

Mon, Sep 16

zzag added a comment to D24003: kwaylandScanner produce version enum per class.

FYI, https://phabricator.kde.org/D22362#493722

Mon, Sep 16, 7:44 PM · Frameworks
zzag added inline comments to D24002: Sort files alphabetically in cmake list.
Mon, Sep 16, 7:33 PM · Frameworks
zzag committed R108:9d83a4d3654d: Delete unused forward declaration of Client class (authored by zzag).
Delete unused forward declaration of Client class
Mon, Sep 16, 1:31 PM
zzag committed R108:b66dfc315678: Drop checkArea helper (authored by zzag).
Drop checkArea helper
Mon, Sep 16, 1:28 PM
zzag closed D23923: Drop checkArea helper.
Mon, Sep 16, 1:28 PM · KWin
zzag committed R108:9bbbf1c51f4b: Pass correct area to placeCascaded in cascadeDesktop (authored by zzag).
Pass correct area to placeCascaded in cascadeDesktop
Mon, Sep 16, 1:28 PM
zzag closed D23921: Pass correct area to placeCascaded in cascadeDesktop.
Mon, Sep 16, 1:28 PM · KWin
zzag committed R108:bccbb8f3a5f8: Pass area by const reference to placeFoo methods (authored by zzag).
Pass area by const reference to placeFoo methods
Mon, Sep 16, 1:28 PM
zzag added a comment to D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).

@jfranklin Ping me if you don't get any feedback in a day or two.

Mon, Sep 16, 1:25 PM · Plasma
zzag added a comment to D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access).

This change looks good to me, however I know only general bits of KScreenLocker.

Mon, Sep 16, 1:12 PM · Plasma
zzag added a comment to T4440: Render decoration into OpenGL.

Well, it would be great to get rid of intermediate raster buffer between Aurorae decoration engine and OpenGL scene, however it's a low priority task right now.

Mon, Sep 16, 12:47 PM · KWin
zzag added a comment to T4430: Export ShellClient to Scripting.

In general, yes.

Mon, Sep 16, 12:45 PM · KWin
zzag added a comment to T4441: [kwin] WindowQuads for SubSurface.

@zzag is this task still pending? Can you add some more detail to the description what it is about?

Mon, Sep 16, 11:23 AM · KWin, Plasma on Wayland

Sun, Sep 15

zzag added a comment to D23978: Make Desktop Effects KCM desktop file consistent.

Oh nvm then.

Sun, Sep 15, 10:06 PM · KWin
zzag added a comment to D23978: Make Desktop Effects KCM desktop file consistent.

I think you should have waited for another +1 from vdg.

Sun, Sep 15, 10:05 PM · KWin
zzag accepted D23978: Make Desktop Effects KCM desktop file consistent.
Sun, Sep 15, 10:03 PM · KWin
zzag added a comment to D18000: Tweak slidingpopups effect to make animation smoother.

So, I've been running your patch for a while and have to admit that disappearing animation looks better. However, I advise you and VDG to analyze (perhaps update hig as well?) our choice of easing curves in default effects, e.g. morphing popups, sliding popups, fade, etc, and based on that pick better curves.

Sun, Sep 15, 9:38 PM · KWin
zzag accepted D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar.

@GB_2 thanks for testing; a desktop UUID is obviously not friendly to show to the user, so there needs to be some sort of X11/Wayland runtime check here.

Sun, Sep 15, 7:38 PM · Plasma

Sat, Sep 14

zzag added a comment to D23918: RFC: Drop Outputs class.

Agree, the private structs in the AbstractEglBackend children are called the same though making it harder to distinguish. And since we have no consumers of public API it's also without benefit. I talked to David at Akademy about the idea of splitting out Platform and Outputs into a lib independent of KWin such that on the one side we have KWayland and on the other side the platform lib allowing to write compositors in the middle of both of them. In this case renaming this class would make sense. Before that it's just a finger exercise costing us time.

Sat, Sep 14, 9:39 PM · KWin
zzag committed R108:726e6c1567cf: Don't initialize QFlags<T> with 0 value (authored by zzag).
Don't initialize QFlags<T> with 0 value
Sat, Sep 14, 9:18 PM
zzag closed D23948: Don't initialize QFlags<T> with 0 value.
Sat, Sep 14, 9:18 PM · KWin
zzag committed R108:02209aa8a446: [platforms/x11] Get rid of some code duplication in windowed backend (authored by zzag).
[platforms/x11] Get rid of some code duplication in windowed backend
Sat, Sep 14, 9:18 PM
zzag closed D23947: [platforms/x11] Get rid of some code duplication in windowed backend.
Sat, Sep 14, 9:17 PM · KWin
zzag updated the diff for D23923: Drop checkArea helper.

Frederik's suggestions.

Sat, Sep 14, 8:44 PM · KWin
zzag added inline comments to D23909: Pass area by const reference to placeFoo methods.
Sat, Sep 14, 8:32 PM · KWin
zzag added a dependent revision for D23948: Don't initialize QFlags<T> with 0 value: D23618: Use nullptr everywhere.
Sat, Sep 14, 7:50 PM · KWin
zzag added a dependency for D23618: Use nullptr everywhere: D23948: Don't initialize QFlags<T> with 0 value.
Sat, Sep 14, 7:50 PM · KWin
zzag requested review of D23948: Don't initialize QFlags<T> with 0 value.
Sat, Sep 14, 7:50 PM · KWin
zzag updated the diff for D23918: RFC: Drop Outputs class.

Remove unused forward declaration.

Sat, Sep 14, 7:18 PM · KWin
zzag updated the summary of D23947: [platforms/x11] Get rid of some code duplication in windowed backend.
Sat, Sep 14, 7:09 PM · KWin
zzag added a comment to D23918: RFC: Drop Outputs class.

How would it be to only keep one vector of AbstractOutputs in Platform? Then there is no vector copying. A cast should in my opinion not be a memory intense operation in the first place, but just a change of how types are interpreted.
In the sub-classes the outputs could then actually be cast as needed (in a convenience function, in case it's more than one or two places). Hopefully this would also reduce code duplication. Of course it only works if there is only one platform in use at a time (I assume that is the case right now already).

Sat, Sep 14, 7:05 PM · KWin
zzag updated the diff for D23918: RFC: Drop Outputs class.

We don't actually need to cast vectors in standalone X11 backend.

Sat, Sep 14, 7:00 PM · KWin
zzag requested review of D23947: [platforms/x11] Get rid of some code duplication in windowed backend.
Sat, Sep 14, 6:56 PM · KWin
zzag updated the diff for D23918: RFC: Drop Outputs class.

Rename qvector_cast to vector_cast.

Sat, Sep 14, 5:03 PM · KWin
zzag requested changes to D23415: Improve comprehensibility and consistency of window placement mode names.
In D23415#530822, @GB_2 wrote:

Is someone from KWin finally ok with this?

Sat, Sep 14, 11:58 AM · Documentation, KWin
zzag added a comment to D23918: RFC: Drop Outputs class.

You don't need virtual destructor when you don't have at least one virtual method, since you don't have at least one that method you don't want to delete object by its pointer to base. You use it to extend its functionality since that you declare objects by derived type, also you can add virtual destructor to derived class then extend with virtual methods and keep pointer to middle one.

Sat, Sep 14, 11:24 AM · KWin
zzag added a comment to D23918: RFC: Drop Outputs class.

Nope, it does because vector is not truly polymorphic.

Sat, Sep 14, 10:51 AM · KWin
zzag added a comment to D23918: RFC: Drop Outputs class.

You need to provide sources for such generic statements.

Sat, Sep 14, 10:18 AM · KWin
zzag accepted D23936: Fix invalid tabstop.
Sat, Sep 14, 8:47 AM · KWin
zzag accepted D23917: Use const_iterator.
Sat, Sep 14, 8:44 AM · Frameworks
zzag accepted D23069: Remove disabled TabGroup feature.
Sat, Sep 14, 8:44 AM · Documentation, KWin

Fri, Sep 13

zzag added a comment to D23931: Add kwayland-integration to kwin dependencies.

Code-wise, kwin doesn't need any bit of kwayland-integration.

Fri, Sep 13, 3:57 PM
zzag accepted D23930: Set XCB to required if building the X backend.
Fri, Sep 13, 3:37 PM · Frameworks
zzag added a comment to D23918: RFC: Drop Outputs class.

I haven't received any strong arguments why we need a subclass of QVector<AbstractOutput *>. Outputs overloads constructor to implement some sort of covariance. However, that doesn't qualify as a good argument because the right solution would be to add a helper function that could perform these conversions.

Fri, Sep 13, 3:22 PM · KWin
zzag added a comment to D23918: RFC: Drop Outputs class.

Doesn't solve anything and now we have casts all over the place.

Fri, Sep 13, 11:04 AM · KWin
zzag added inline comments to D23918: RFC: Drop Outputs class.
Fri, Sep 13, 10:59 AM · KWin
zzag updated the diff for D23918: RFC: Drop Outputs class.

Use std::copy().

Fri, Sep 13, 10:59 AM · KWin
zzag updated the diff for D23923: Drop checkArea helper.

Edit summary.

Fri, Sep 13, 10:53 AM · KWin
zzag updated the diff for D23921: Pass correct area to placeCascaded in cascadeDesktop.

Remove unrelated changes.

Fri, Sep 13, 10:48 AM · KWin
zzag added a comment to D23921: Pass correct area to placeCascaded in cascadeDesktop.

I squashed two changes deliberately because dealing with patch series in phabricator is not very pleasant thing to do. I'll leave "logic change" parth.

Fri, Sep 13, 10:45 AM · KWin