zzag (Vlad Zagorodniy)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Dec 16 2017, 8:25 AM (47 w, 3 d)
Availability
Available

Recent Activity

Today

zzag added a comment to D16865: Unbreak AbstractClient::setDesktop.

Doesn't D16703 fix it as well?

Tue, Nov 13, 3:15 PM · KWin
zzag updated the summary of D16858: [effects] Move Fade, Glide, and Scale effect into exclusive group.
Tue, Nov 13, 10:20 AM · KWin
zzag added a dependent revision for D16836: [effects] Split the Fade effect: D16858: [effects] Move Fade, Glide, and Scale effect into exclusive group.
Tue, Nov 13, 10:19 AM · KWin
zzag added a dependency for D16858: [effects] Move Fade, Glide, and Scale effect into exclusive group: D16836: [effects] Split the Fade effect.
Tue, Nov 13, 10:19 AM · KWin
zzag requested review of D16858: [effects] Move Fade, Glide, and Scale effect into exclusive group.
Tue, Nov 13, 10:18 AM · KWin
zzag committed R108:406b70b04e09: [wayland] Don't crash when resizing windows (authored by zzag).
[wayland] Don't crash when resizing windows
Tue, Nov 13, 8:35 AM
zzag committed R108:7e73ad230a8a: Merge branch 'Plasma/5.14' (authored by zzag).
Merge branch 'Plasma/5.14'
Tue, Nov 13, 8:35 AM
zzag closed D16846: [wayland] Don't crash when resizing windows.
Tue, Nov 13, 8:35 AM · KWin

Yesterday

zzag added a comment to D16836: [effects] Split the Fade effect.

Mon, Nov 12, 7:26 PM · KWin
zzag added a comment to D16836: [effects] Split the Fade effect.

I was thinking about creating a whole new category for open/close animations.

Mon, Nov 12, 6:56 PM · KWin
zzag updated the summary of D16846: [wayland] Don't crash when resizing windows.
Mon, Nov 12, 6:34 PM · KWin
zzag requested review of D16846: [wayland] Don't crash when resizing windows.
Mon, Nov 12, 6:17 PM · KWin
zzag added a reviewer for D16836: [effects] Split the Fade effect: VDG.

Have we given any thought to how to better present the exclusive groups in the KCM? Right now it's not as clear as it could be.

As far as I know, no. I'm open for suggestions.

Mon, Nov 12, 3:31 PM · KWin
zzag committed R108:688d946ffb08: [libkwineffects] Gracefully release previous window pixmap (authored by zzag).
[libkwineffects] Gracefully release previous window pixmap
Mon, Nov 12, 10:54 AM
zzag closed D16391: [libkwineffects] Gracefully release previous window pixmap.
Mon, Nov 12, 10:54 AM · KWin
zzag committed R108:93abb9a27318: Don't cache value of popupWindow property in EffectWindow (authored by zzag).
Don't cache value of popupWindow property in EffectWindow
Mon, Nov 12, 10:48 AM
zzag closed D16835: Don't cache value of popupWindow property in EffectWindow.
Mon, Nov 12, 10:48 AM · KWin
zzag updated the test plan for D16836: [effects] Split the Fade effect.
Mon, Nov 12, 10:29 AM · KWin
zzag updated the summary of D16836: [effects] Split the Fade effect.
Mon, Nov 12, 10:24 AM · KWin
zzag updated the test plan for D16836: [effects] Split the Fade effect.
Mon, Nov 12, 10:15 AM · KWin
zzag added a comment to D16835: Don't cache value of popupWindow property in EffectWindow.

FWIW, long term I want to change plasma popups to use XDGPopups as a base.

Mon, Nov 12, 10:10 AM · KWin
zzag added a dependent revision for D16835: Don't cache value of popupWindow property in EffectWindow: D16836: [effects] Split the Fade effect.
Mon, Nov 12, 10:08 AM · KWin
zzag added a dependency for D16836: [effects] Split the Fade effect: D16835: Don't cache value of popupWindow property in EffectWindow.
Mon, Nov 12, 10:08 AM · KWin
zzag requested review of D16836: [effects] Split the Fade effect.
Mon, Nov 12, 10:08 AM · KWin
zzag requested review of D16835: Don't cache value of popupWindow property in EffectWindow.
Mon, Nov 12, 10:07 AM · KWin
zzag added a comment to D16834: Explicitly link and disable kcrash on kwin_wayland.

We should add a comment then to the macro.

Mon, Nov 12, 9:53 AM · KWin
zzag added a comment to D16834: Explicitly link and disable kcrash on kwin_wayland.

What does Q_CONSTRUCTOR_FUNCTION do? Documentation?

Mon, Nov 12, 9:33 AM · KWin

Sat, Nov 10

zzag updated the diff for D16452: [effects/dimscreen] Port to JavaScript.

Fix bad math.

Sat, Nov 10, 11:33 AM · KWin
zzag added inline comments to D16452: [effects/dimscreen] Port to JavaScript.
Sat, Nov 10, 11:33 AM · KWin

Fri, Nov 9

zzag requested changes to D16704: [wayland] add enter/leave virtual desktop API.

isOnAllDesktops() is broken.

Fri, Nov 9, 8:15 PM · KWin
zzag added inline comments to D16704: [wayland] add enter/leave virtual desktop API.
Fri, Nov 9, 7:56 PM · KWin
zzag added inline comments to D16704: [wayland] add enter/leave virtual desktop API.
Fri, Nov 9, 7:07 PM · KWin
zzag added inline comments to D16704: [wayland] add enter/leave virtual desktop API.
Fri, Nov 9, 6:50 PM · KWin
zzag added inline comments to D16452: [effects/dimscreen] Port to JavaScript.
Fri, Nov 9, 5:53 PM · KWin
zzag accepted D16777: Add a TESTING.md document describing how to run the unit test suite.

Good stuff! :-)

Fri, Nov 9, 1:31 PM · KWin
zzag accepted D16762: Build KF5IdleTimeKWinWaylandPrivatePlugin in correct directory.
Fri, Nov 9, 12:35 PM · KWin
zzag added a comment to D16762: Build KF5IdleTimeKWinWaylandPrivatePlugin in correct directory.

Noob question: do we use KIdleTime in KWin?

Fri, Nov 9, 11:16 AM · KWin

Thu, Nov 8

zzag accepted D16765: Support starting the rules_dialog from build dir.
Thu, Nov 8, 9:16 PM · KWin
zzag accepted D16763: Support starting the killer_helper from build dir.
Thu, Nov 8, 9:14 PM · KWin
zzag accepted D16761: Copy the aurorae decoration qml plugin to bin dir in build directory.

Let's hope that's the last attempt to fix the test.

Thu, Nov 8, 9:13 PM · KWin
zzag committed R108:bf19c41bc740: [effects/translucency] Use strict mode for the whole script (authored by zzag).
[effects/translucency] Use strict mode for the whole script
Thu, Nov 8, 12:39 PM
zzag committed R108:26e67f61e284: [effects/windowaperture] Use strict mode for the whole script (authored by zzag).
[effects/windowaperture] Use strict mode for the whole script
Thu, Nov 8, 12:35 PM
zzag committed R108:abf6c6927cbf: [autotests] Fix maximize test (authored by zzag).
[autotests] Fix maximize test
Thu, Nov 8, 12:11 PM
zzag closed D16755: [autotests] Fix maximize test.
Thu, Nov 8, 12:11 PM · KWin
zzag requested review of D16755: [autotests] Fix maximize test.
Thu, Nov 8, 11:26 AM · KWin
zzag accepted D16753: [aurorae] Print qml errors during instantiation of qml based deco.
Thu, Nov 8, 9:04 AM · KWin
zzag added inline comments to D16753: [aurorae] Print qml errors during instantiation of qml based deco.
Thu, Nov 8, 8:53 AM · KWin
zzag accepted D16752: Build plastik plugin at correct location in build tree.
Thu, Nov 8, 8:37 AM · KWin
zzag accepted D16748: Add more debug output around starting the x clipboard syncer process.
Thu, Nov 8, 8:30 AM · KWin

Wed, Nov 7

zzag added a comment to T9996: Improve Thumbnail Aside effect.
In T9996#166683, @paulb wrote:

Oh. I don't read it. I just see out of the corner of my eye when it stops scrolling. Then I know I have to switch over and check if it has bombed out our needs an input.

Wed, Nov 7, 9:55 PM · KDE Promo, VDG, KWin
zzag accepted D16745: Copy plastik window decoration to build directory.
Wed, Nov 7, 9:20 PM · KWin
zzag added a comment to T9996: Improve Thumbnail Aside effect.
In T9996#166680, @paulb wrote:

Follow a long shell process, such s as a compile or dd copy out of the corner of your eye. I have used it recently to follow a long AUR installation and have known when to switch to konsole when I needed to input my user password.

Wed, Nov 7, 9:18 PM · KDE Promo, VDG, KWin
zzag updated subscribers of T9996: Improve Thumbnail Aside effect.

Even if you can't interact with the content, isn't is still potentially useful for other reasons?

Wed, Nov 7, 9:04 PM · KDE Promo, VDG, KWin
zzag committed R108:f4663072774e: [libkwineffects] Use correct type for the desktops property (authored by zzag).
[libkwineffects] Use correct type for the desktops property
Wed, Nov 7, 7:06 PM
zzag closed D16743: [libkwineffects] Use correct type for the desktops property.
Wed, Nov 7, 7:06 PM · KWin
zzag updated the diff for D16743: [libkwineffects] Use correct type for the desktops property.

Use WINDOW_HELPER macro

Wed, Nov 7, 7:04 PM · KWin
zzag updated the summary of D16743: [libkwineffects] Use correct type for the desktops property.
Wed, Nov 7, 6:50 PM · KWin
zzag requested review of D16743: [libkwineffects] Use correct type for the desktops property.
Wed, Nov 7, 6:47 PM · KWin
zzag committed R108:7b08886e71c4: Merge branch 'Plasma/5.14' (authored by zzag).
Merge branch 'Plasma/5.14'
Wed, Nov 7, 5:37 PM
zzag committed R108:ad28da84e78c: [effects/slidingpopups] Don't crash when sliding virtual desktops (authored by zzag).
[effects/slidingpopups] Don't crash when sliding virtual desktops
Wed, Nov 7, 5:37 PM
zzag closed D16731: [effects/slidingpopups] Don't crash when sliding virtual desktops.
Wed, Nov 7, 5:37 PM · KWin
zzag added a comment to D16736: [wayland] Move AbstractClient::desktops from QList to QVector.

You forgot to update EffectWindow::desktops().

Wed, Nov 7, 5:36 PM · KWin
zzag accepted D16741: Remove potential endless loop from XClipboardSyncTest.
Wed, Nov 7, 5:17 PM · KWin
zzag added inline comments to D16739: [autotests] Handle async maximisation in quick tiling test.
Wed, Nov 7, 4:51 PM · KWin
zzag accepted D16740: [wayland] Fix arguments to clientMaximizedStateChanged(bool, bool).
Wed, Nov 7, 4:25 PM · KWin
zzag added a comment to D16704: [wayland] add enter/leave virtual desktop API.

Some additional corner cases:

Wed, Nov 7, 3:48 PM · KWin
zzag added a comment to D16731: [effects/slidingpopups] Don't crash when sliding virtual desktops.

Set animation speed to "Very slow"

Wed, Nov 7, 1:04 PM · KWin
zzag accepted D16732: Start xclipboard sync process from build dir if available.

Maybe it would be worth to leave a comment why we search for org_kde_kwin_xclipboard_syncer in the directory that contains kwin's executable.

Wed, Nov 7, 12:34 PM · KWin
zzag added a comment to D16731: [effects/slidingpopups] Don't crash when sliding virtual desktops.

So how does it end up in m_animations?

Wed, Nov 7, 12:27 PM · KWin
zzag updated the diff for D16731: [effects/slidingpopups] Don't crash when sliding virtual desktops.

Use for loop

Wed, Nov 7, 12:23 PM · KWin
zzag requested review of D16731: [effects/slidingpopups] Don't crash when sliding virtual desktops.
Wed, Nov 7, 10:45 AM · KWin
zzag added a comment to T9996: Improve Thumbnail Aside effect.

What is a "typical PiP"?

Wed, Nov 7, 10:04 AM · KDE Promo, VDG, KWin
zzag requested review of D16729: [autotests] Fix testSlidingPopups when running in CI.
Wed, Nov 7, 9:44 AM · KWin

Tue, Nov 6

zzag added a comment to T9996: Improve Thumbnail Aside effect.

FWIW, Google Chrome supports PiP on Linux.

Tue, Nov 6, 7:56 PM · KDE Promo, VDG, KWin
zzag added a comment to T9996: Improve Thumbnail Aside effect.

Also, I have another question: such effect would be most likely useful only for videos. How KWin will detect them?

Tue, Nov 6, 7:19 PM · KDE Promo, VDG, KWin
zzag added a comment to T9996: Improve Thumbnail Aside effect.

IMHO, It won't change things too much, that still will be Thumbnails Aside, only with a different name.

Tue, Nov 6, 7:13 PM · KDE Promo, VDG, KWin
zzag added a comment to T9996: Improve Thumbnail Aside effect.

the name, default settings, and whether or not it's enabled by default

Tue, Nov 6, 7:11 PM · KDE Promo, VDG, KWin
zzag added a comment to T9996: Improve Thumbnail Aside effect.

In general, I like the idea.

Tue, Nov 6, 6:23 PM · KDE Promo, VDG, KWin
zzag accepted D16701: Correct version of newly added PlasmaVirtualDesktop interface.
Tue, Nov 6, 5:58 PM · Frameworks
zzag accepted D16708: [server] Text input content hint and purpose per protocol version.
Tue, Nov 6, 4:05 PM · Frameworks
zzag added inline comments to D16704: [wayland] add enter/leave virtual desktop API.
Tue, Nov 6, 3:57 PM · KWin
zzag added inline comments to D16708: [server] Text input content hint and purpose per protocol version.
Tue, Nov 6, 1:53 PM · Frameworks
zzag added a comment to D16704: [wayland] add enter/leave virtual desktop API.

The removal is a little bit confusing.

Tue, Nov 6, 1:13 PM · KWin
zzag added a comment to D16704: [wayland] add enter/leave virtual desktop API.

Noob question: What would happen if the client is already on all desktops and you call enterDesktop for the first desktop?

Tue, Nov 6, 1:09 PM · KWin
zzag added inline comments to D16704: [wayland] add enter/leave virtual desktop API.
Tue, Nov 6, 12:58 PM · KWin
zzag added inline comments to D16704: [wayland] add enter/leave virtual desktop API.
Tue, Nov 6, 12:53 PM · KWin
zzag accepted D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes.
Tue, Nov 6, 12:25 PM · Frameworks
zzag added inline comments to D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes.
Tue, Nov 6, 11:54 AM · Frameworks
zzag accepted D16675: [server] Put set surrounding text callback with uint in v0 class.
Tue, Nov 6, 11:47 AM · Frameworks
zzag added a comment to D16675: [server] Put set surrounding text callback with uint in v0 class.

Could the renaming be problematic in regards to binary compatibility? All are private interfaces though.

Tue, Nov 6, 11:40 AM · Frameworks
zzag added inline comments to D16701: Correct version of newly added PlasmaVirtualDesktop interface.
Tue, Nov 6, 10:06 AM · Frameworks

Mon, Nov 5

zzag committed R108:b6fe7dc11572: [effects/eyeonscreen] Move "use strict" to the beginning of the script (authored by zzag).
[effects/eyeonscreen] Move "use strict" to the beginning of the script
Mon, Nov 5, 8:06 PM
zzag added a comment to D16228: Raise window group together with group transient.

That's my point: like in the effects kcm case I doubt the group transients are the intention of the authors.

Mon, Nov 5, 3:20 PM · KWin
zzag committed R108:47c84053888f: [effects/snaphelper] Do massive overhaul (authored by zzag).
[effects/snaphelper] Do massive overhaul
Mon, Nov 5, 2:59 PM
zzag closed D15695: [effects/snaphelper] Do massive overhaul.
Mon, Nov 5, 2:59 PM · KWin
zzag updated the diff for D15695: [effects/snaphelper] Do massive overhaul.
  • Delete superfluous 'private' access modifier;
  • Make m_lineColor and m_lineWidth static;
  • Use linear easing curve.
Mon, Nov 5, 2:58 PM · KWin
zzag accepted D16683: Fix FadeTest and TranslucencyTest when started without install.
Mon, Nov 5, 2:37 PM · KWin
zzag accepted D16682: Fix test of scriptedeffectsloader when run from build directory without install.

I wrecked my local installation, testScriptedEffectLoaded is now passes without running make install.

Mon, Nov 5, 2:35 PM · KWin
zzag added a comment to T9988: KWin cannot find it's effects in autotests.

I asked similar question some time ago in #plasma. IIRC, the tests fail because CI run them uninstalled.

Mon, Nov 5, 11:36 AM · build.kde.org
zzag committed R108:c081f2224fdd: [effects/squash] Put "use strict" at the beginning of the script (authored by zzag).
[effects/squash] Put "use strict" at the beginning of the script
Mon, Nov 5, 9:51 AM