- User Since
- Dec 16 2017, 8:25 AM (92 w, 1 d)
Fri, Sep 20
Relevant commit: b36b242f1236c907ae3b14b0dc35ed27e5882d6d
Thu, Sep 19
Wed, Sep 18
@davidedmundson Is this 5.17 stuff?
Nitpick: please use imperative mood in the subject line.
Do you have commit access?
What about simplifying it a bit as well? e.g.
Tue, Sep 17
Mon, Sep 16
@jfranklin Ping me if you don't get any feedback in a day or two.
This change looks good to me, however I know only general bits of KScreenLocker.
Well, it would be great to get rid of intermediate raster buffer between Aurorae decoration engine and OpenGL scene, however it's a low priority task right now.
In general, yes.
Sun, Sep 15
Oh nvm then.
I think you should have waited for another +1 from vdg.
So, I've been running your patch for a while and have to admit that disappearing animation looks better. However, I advise you and VDG to analyze (perhaps update hig as well?) our choice of easing curves in default effects, e.g. morphing popups, sliding popups, fade, etc, and based on that pick better curves.
Sat, Sep 14
Remove unused forward declaration.
We don't actually need to cast vectors in standalone X11 backend.
Rename qvector_cast to vector_cast.
Nope, it does because vector is not truly polymorphic.
You need to provide sources for such generic statements.
Fri, Sep 13
Code-wise, kwin doesn't need any bit of kwayland-integration.
I haven't received any strong arguments why we need a subclass of QVector<AbstractOutput *>. Outputs overloads constructor to implement some sort of covariance. However, that doesn't qualify as a good argument because the right solution would be to add a helper function that could perform these conversions.
Remove unrelated changes.
I squashed two changes deliberately because dealing with patch series in phabricator is not very pleasant thing to do. I'll leave "logic change" parth.