- User Since
- Dec 16 2017, 8:25 AM (66 w, 3 d)
Could you please provide more context?
Is it a good idea to expose AbstractClient::setMaximize anyway? As far as I know, xdg-shell doesn't define maximized vertically or maximized horizontally states.
Sat, Mar 23
Fri, Mar 22
I've tried this effect and in general it looks okay to me. The only thing that I don't like is the default color palette but that's probably matter of personal taste.
Wed, Mar 20
What about plasma::dialog?
Tue, Mar 19
Oh, looks like I missed this one, thank you for fixing it. :-)
Does this revision depend on D19731?
It seems like there are still some issues with rotatino :(
I don't have any NVIDIA GPU to test, but code-wise this change makes sense.
Mon, Mar 18
Fri, Mar 15
Wed, Mar 13
Code-wise this change looks okay to me, though after thinking for a bit I'm not sure whether this change makes sense logically. Maybe David could weigh in (we have plenty time before 5.15.4 is released).
backported to 5.12
Tue, Mar 12
Well, it's just for better git history. As I said previously, I won't insist on this (though it would be great to have full name :-)). The most important part is email anyway.
Just to be clear, I'm not against good defaults. I don't like that the defaults are adjusted in such way that icons look sharp only with one particular font size and one particular button size. After all, KDE Plasma is configurable. If we focus only on making defaults look good, then what's the point of making everything configurable?
What's not worth what?
It doesn't. GTK doesn't support xdg-decoration. :D
I won't strongly insist on this but it would be great if you could provide your real name for better git history. If there is commit whose author is "vlad <....>", the only thing that comes to mind: Vlad? Which one?
I'm still not quite sure what exactly we have to do when a client is unmapped. Should we send a configure event?
Could you please add a test case?
Not really, I still think it's not worth that.
Mon, Mar 11
Could you please provide your real name and email?
Do you have commit access? If so, please backport this change to 5.15.
Fri, Mar 8
Oh, I see. You can do better. :-) Just create a test table, e.g.
On X11, gtk isn't selecting the backdrop class. Probably because kwin doesn't support one of their new activation flags which would be a GTK bug for not following their fallback correctly.
This patch makes buttons sharp only for one particular button size and font size.
(also, it would be enough just to add a group reviewer)
What's the reason for removing the linear gradient?
Thu, Mar 7
Tue, Mar 5
Hmm, looks like windowUnderCursor was left out in D3367. Anyway, this patch looks good to me.
Well, you don't have to restart the compositor each time you enable/disable tooltips, it should just work. On my machine it works as expected.
I'll backport it to Plasma/5.15.
Just to be sure, did you restart kwin?