zzag (Vlad Zagorodniy)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Dec 16 2017, 8:25 AM (75 w, 2 d)
Availability
Available

Recent Activity

Today

zzag added a comment to D21076: ICC Color Correction Effect.

See https://doc.qt.io/qt-5/qscopedpointer.html#custom-cleanup-handlers

Mon, May 27, 11:37 AM · KWin
zzag requested changes to D21076: ICC Color Correction Effect.

I'm not sure about inclusion because:

Mon, May 27, 11:11 AM · KWin

Fri, May 24

zzag added a comment to D21371: [scripts] Drop enforcedeco script.

The proposed script contains a hack that is not suitable for upstream.

Fri, May 24, 1:31 PM · KWin
zzag added a comment to D21371: [scripts] Drop enforcedeco script.

(not sure about removing that property since it's somewhat public API isn't it?)

Fri, May 24, 10:46 AM · KWin

Thu, May 23

zzag abandoned D17096: [scripting] Port the remaining bits of API to AbstractClient.

Hmm, looks like arc diff forgot to update commit message. In either case, this change is in master.

Thu, May 23, 9:41 PM · KWin
zzag committed R108:4bbef8d128ce: [scripting] Emit clientAdded for Wayland clients (authored by zzag).
[scripting] Emit clientAdded for Wayland clients
Thu, May 23, 9:37 PM
zzag closed D17097: [scripting] Emit clientAdded for Wayland clients.
Thu, May 23, 9:37 PM · KWin
zzag committed R108:689d89ae4ead: [scripting] Port the remaining bits of API to AbstractClient (authored by zzag).
[scripting] Port the remaining bits of API to AbstractClient
Thu, May 23, 9:37 PM
zzag updated the diff for D21370: [effects/screenshot] Upload data to xpixmap in chunks.

Reword a comment.

Thu, May 23, 9:18 PM · KWin
zzag updated the diff for D21370: [effects/screenshot] Upload data to xpixmap in chunks.
  • Fix coding style: align references to right
Thu, May 23, 9:02 PM · KWin
zzag added a comment to D21370: [effects/screenshot] Upload data to xpixmap in chunks.
Thu, May 23, 8:39 PM · KWin
zzag updated the test plan for D21370: [effects/screenshot] Upload data to xpixmap in chunks.
Thu, May 23, 8:33 PM · KWin
zzag requested review of D21371: [scripts] Drop enforcedeco script.
Thu, May 23, 8:28 PM · KWin
zzag added a comment to D21370: [effects/screenshot] Upload data to xpixmap in chunks.

I'm targeting 5.16.X.

Thu, May 23, 8:27 PM · KWin
zzag requested review of D21370: [effects/screenshot] Upload data to xpixmap in chunks.
Thu, May 23, 8:27 PM · KWin
zzag added a comment to D17097: [scripting] Emit clientAdded for Wayland clients.

The solution would be to store the plugins configuration encrypted (or in general to allow for encrypted config sections)

Thu, May 23, 1:20 PM · KWin

Wed, May 22

zzag added a dependency for D21345: Backport Night Color feature to X11: D19208: [platforms/x11/standalone] Port to AbstractOutput.
Wed, May 22, 6:02 PM · KWin
zzag added a dependent revision for D19208: [platforms/x11/standalone] Port to AbstractOutput: D21345: Backport Night Color feature to X11.
Wed, May 22, 6:02 PM · KWin
zzag added a reviewer for D21346: [libcolorcorrect] Allow color correction on X: Plasma.
Wed, May 22, 5:59 PM · Plasma
zzag added a reviewer for D21347: [Night Light KCM] Display the kcm on X11 platform: Plasma.
Wed, May 22, 5:59 PM · Plasma
zzag requested review of D21347: [Night Light KCM] Display the kcm on X11 platform.
Wed, May 22, 5:58 PM · Plasma
zzag requested review of D21346: [libcolorcorrect] Allow color correction on X.
Wed, May 22, 5:58 PM · Plasma
zzag requested review of D21345: Backport Night Color feature to X11.
Wed, May 22, 5:58 PM · KWin

Tue, May 21

zzag committed R108:2cff5cb70a9e: [tabbox] Properly determine depressed modifiers on X11 (authored by zzag).
[tabbox] Properly determine depressed modifiers on X11
Tue, May 21, 1:06 PM
zzag closed D21302: [tabbox] Properly determine depressed modifiers on X11.
Tue, May 21, 1:06 PM · KWin
zzag updated the diff for D21302: [tabbox] Properly determine depressed modifiers on X11.

remove no longer actual comment

Tue, May 21, 11:58 AM · KWin
zzag updated the diff for D21302: [tabbox] Properly determine depressed modifiers on X11.

prettify

Tue, May 21, 11:57 AM · KWin
zzag updated the diff for D21302: [tabbox] Properly determine depressed modifiers on X11.

XInput is not a mandatory dependency. :'(

Tue, May 21, 11:44 AM · KWin
zzag accepted D20890: Close screen grabbing effect when screensaver starts.
Tue, May 21, 9:59 AM · KWin
achauvel awarded D21302: [tabbox] Properly determine depressed modifiers on X11 a Like token.
Tue, May 21, 1:16 AM · KWin

Mon, May 20

zzag updated the summary of D21302: [tabbox] Properly determine depressed modifiers on X11.
Mon, May 20, 12:44 PM · KWin
zzag requested review of D21302: [tabbox] Properly determine depressed modifiers on X11.
Mon, May 20, 11:52 AM · KWin

Fri, May 17

zzag committed R108:7f593a67adbd: Send axis_source, axis_discrete, and axis_stop (authored by zzag).
Send axis_source, axis_discrete, and axis_stop
Fri, May 17, 9:07 AM
zzag closed D19000: Send axis_source, axis_discrete, and axis_stop.
Fri, May 17, 9:07 AM · KWin
zzag committed R127:ddff2c06d17a: Allow compositors to send discrete axis values (authored by zzag).
Allow compositors to send discrete axis values
Fri, May 17, 8:54 AM
zzag closed D18933: Allow compositors to send discrete axis values.
Fri, May 17, 8:54 AM · Frameworks
zzag committed R108:81cdfd2ebfa0: Keep internal clients in the unmanaged layer (authored by zzag).
Keep internal clients in the unmanaged layer
Fri, May 17, 8:45 AM
zzag closed D21116: Keep internal clients in the unmanaged layer.
Fri, May 17, 8:45 AM · KWin

Wed, May 15

zzag added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.

Before merging this feature I urge you to look through the support information attached to our bug reports and check how many users actually change anything in the effects.

Wed, May 15, 1:47 PM · KWin
zzag requested changes to D21083: [effects/presentwindows] Allow closing windows on middle-click.

So let's rewrite it

Wed, May 15, 1:44 PM · KWin
zzag committed R108:d94eb29d07c8: [effects/thumbnailaside] Specify screen projection matrix (authored by zzag).
[effects/thumbnailaside] Specify screen projection matrix
Wed, May 15, 9:35 AM
zzag closed D21224: [effects/thumbnailaside] Specify screen projection matrix.
Wed, May 15, 9:35 AM · KWin
zzag retitled D21224: [effects/thumbnailaside] Specify screen projection matrix from [effects/thumbnailaside] Specify projection matrix to [effects/thumbnailaside] Specify screen projection matrix.
Wed, May 15, 9:14 AM · KWin
zzag requested review of D21224: [effects/thumbnailaside] Specify screen projection matrix.
Wed, May 15, 9:11 AM · KWin
zzag committed R108:67b2746ecdfd: Compute correct boundaries in checkWorkspacePosition (authored by zzag).
Compute correct boundaries in checkWorkspacePosition
Wed, May 15, 8:07 AM
zzag closed D20987: Compute correct boundaries in checkWorkspacePosition.
Wed, May 15, 8:07 AM · KWin
zzag committed R108:0aa288bfae79: Port away from deprecated qFind (authored by zzag).
Port away from deprecated qFind
Wed, May 15, 8:03 AM
zzag closed D21217: Port away from deprecated qFind.
Wed, May 15, 8:03 AM · KWin
zzag added inline comments to D21220: [Touchpad KCM] Fix libinput-less build and warnings.
Wed, May 15, 7:23 AM · Plasma

Tue, May 14

zzag requested review of D21217: Port away from deprecated qFind.
Tue, May 14, 3:23 PM · KWin
zzag added inline comments to D20890: Close screen grabbing effect when screensaver starts.
Tue, May 14, 12:48 PM · KWin
zzag accepted D20595: Implement set_window_geometry.
Tue, May 14, 10:16 AM · Frameworks

Mon, May 13

zzag added inline comments to D13284: [decorations] Let KDecoration plugins recommend a border size per default.
Mon, May 13, 2:30 PM · KWin
zzag added a comment to D21076: ICC Color Correction Effect.

The rabbit hole goes a bit deeper. On X11, all screens are rendered in a single pass, which means that per screen color correction is a huge pita.

Mon, May 13, 9:27 AM · KWin
zzag accepted D19262: Delayed focus updates for Toplevels without surface.

Naming nitpick: I suggest to rename m_at.at to m_at.toplevel in order to avoid repetition.

Mon, May 13, 9:20 AM · KWin

Fri, May 10

zzag updated the diff for D18933: Allow compositors to send discrete axis values.

Small cleanup.

Fri, May 10, 4:56 PM · Frameworks
zzag updated the diff for D18933: Allow compositors to send discrete axis values.

@since 5.XX becomes @since 5.59

Fri, May 10, 4:37 PM · Frameworks
zzag updated the diff for D19000: Send axis_source, axis_discrete, and axis_stop.

Make some parts of code more visually appealing.

Fri, May 10, 4:29 PM · KWin
zzag updated the diff for D19000: Send axis_source, axis_discrete, and axis_stop.

Move PointerAxisSource enum to InputRedirection class.

Fri, May 10, 4:24 PM · KWin
zzag accepted D20937: Handle XdgShell window geometry in configure request sizes.
Fri, May 10, 3:11 PM · KWin
zzag accepted D20804: RFC: Try getting the X keyboard grab multiple times.
Fri, May 10, 2:42 PM · Plasma
zzag accepted D19613: Support NET_WM_STATE_FOCUSED.

On one hand, we have broken clients. On the other hand, we have our promise to keep KWin/X11 feature frozen.

Fri, May 10, 2:29 PM · KWin
zzag updated the diff for D21116: Keep internal clients in the unmanaged layer.

Adjust doxygen comment style.

Fri, May 10, 10:08 AM · KWin
zzag updated the summary of D21116: Keep internal clients in the unmanaged layer.
Fri, May 10, 10:06 AM · KWin
zzag requested review of D21116: Keep internal clients in the unmanaged layer.
Fri, May 10, 10:06 AM · KWin
zzag added a comment to D19000: Send axis_source, axis_discrete, and axis_stop.

Seems a shame for this to get blocked over a tiny comment over about where an enum should be.

Fri, May 10, 7:11 AM · KWin

Wed, May 8

zzag added a comment to T10867: XDG WindowGeometry.

The difference of opinion is do we write code patching rendering and input or write code patching the window management.

Wed, May 8, 8:44 PM · Plasma on Wayland
zzag accepted D21085: Fix crash due to dangling reference.
Wed, May 8, 5:13 PM · KWin
zzag added a comment to T10867: XDG WindowGeometry.

As I said previously, I'd prefer a solution where Toplevel::geometry() is logical geometry of the client. This way we don't have to adjust lots of code and if we implement this in more or less "generic" way then it should be quite easy to add support for a bit controversial _GTK_FRAME_EXTENTS (distros could patch kwin for example). xdg-surface::set_window_geometry and _GTK_FRAME_EXTENTS look quite the same, except that the former provides us absolute values.

Wed, May 8, 2:43 PM · Plasma on Wayland
zzag updated the summary of D20987: Compute correct boundaries in checkWorkspacePosition.
Wed, May 8, 9:13 AM · KWin

Tue, May 7

zzag committed R108:e8b45cce1168: [effects/cubeslide] Cancel active animation when number of desktops has changed (authored by zzag).
[effects/cubeslide] Cancel active animation when number of desktops has changed
Tue, May 7, 12:14 PM
zzag closed D21064: [effects/cubeslide] Cancel active animation when number of desktops has changed.
Tue, May 7, 12:14 PM · KWin
zzag requested review of D21064: [effects/cubeslide] Cancel active animation when number of desktops has changed.
Tue, May 7, 9:21 AM · KWin

Sat, May 4

zzag added inline comments to D20937: Handle XdgShell window geometry in configure request sizes.
Sat, May 4, 10:35 AM · KWin
zzag added inline comments to D20937: Handle XdgShell window geometry in configure request sizes.
Sat, May 4, 10:24 AM · KWin

Fri, May 3

zzag updated the diff for D21005: [wayland] Update tabbox when a client is added or closed.

Leave a todo comment.

Fri, May 3, 8:06 PM · KWin
zzag updated the diff for D21005: [wayland] Update tabbox when a client is added or closed.

Don't handle unmapped clients for now.

Fri, May 3, 7:34 PM · KWin
zzag requested review of D21005: [wayland] Update tabbox when a client is added or closed.
Fri, May 3, 7:21 PM · KWin
zzag committed R108:c438ecbb702e: Don't crash when highlighted tabbox client is closed (authored by zzag).
Don't crash when highlighted tabbox client is closed
Fri, May 3, 6:25 PM
zzag closed D20916: Don't crash when highlighted tabbox client is closed.
Fri, May 3, 6:25 PM · KWin
zzag committed R108:0fb09cf41313: Make session loading/saving helpers local to sm.cpp (authored by zzag).
Make session loading/saving helpers local to sm.cpp
Fri, May 3, 6:24 PM
zzag closed D20783: Make session loading/saving helpers local to sm.cpp.
Fri, May 3, 6:24 PM · KWin
zzag added inline comments to D20937: Handle XdgShell window geometry in configure request sizes.
Fri, May 3, 4:24 PM · KWin
zzag requested review of D20987: Compute correct boundaries in checkWorkspacePosition.
Fri, May 3, 3:33 PM · KWin

Thu, May 2

zzag accepted D20943: Update tests cmake to WebEngine port.
Thu, May 2, 7:38 AM · Plasma
zzag accepted D20951: Track surface creation/destruction inside wayland window effects.
Thu, May 2, 7:36 AM · Plasma

Tue, Apr 30

zzag retitled D20916: Don't crash when highlighted tabbox client is closed from Switch to the next tabbox item before currently highlighted client is removed from stacking order to Don't crash when highlighted tabbox client is closed.
Tue, Apr 30, 10:53 AM · KWin
zzag added a comment to D20804: RFC: Try getting the X keyboard grab multiple times.

Arguably it won't help us with all cases because the clients would have to voluntarily participate in the protocol.

Tue, Apr 30, 10:32 AM · Plasma
zzag requested review of D20916: Don't crash when highlighted tabbox client is closed.
Tue, Apr 30, 10:02 AM · KWin

Mon, Apr 29

zzag added inline comments to D20890: Close screen grabbing effect when screensaver starts.
Mon, Apr 29, 1:18 PM · KWin
zzag added a comment to D20895: Provide alternatives for Show Desktop and Minimize All Windows widgets.
Mon, Apr 29, 1:13 PM · Plasma
zzag added inline comments to D20890: Close screen grabbing effect when screensaver starts.
Mon, Apr 29, 10:36 AM · KWin

Apr 26 2019

zzag accepted D14910: Pass a dedicated fd to each keyboard for the xkb keymap.
Apr 26 2019, 2:31 PM · Frameworks
zzag added a comment to D20804: RFC: Try getting the X keyboard grab multiple times.

Wrote relevant matching kwin patch to close effects

Apr 26 2019, 2:17 PM · Plasma
zzag added a comment to D19296: Allow to set quarter tiling separately.

What's the use case? Why would someone want to enable only half tiling, but not quarter tiling?

Apr 26 2019, 2:13 PM · KWin
zzag accepted D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer.
Apr 26 2019, 2:03 PM · KWin
zzag accepted D20627: Introduce CriticalNotificationType.

Hmm, in general this is quite delicate case because KWin/X11 is feature frozen...

Apr 26 2019, 1:27 PM · Frameworks
zzag added a comment to D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer.

Could you please address my inline comments?

Apr 26 2019, 1:13 PM · KWin
zzag added a comment to D20628: Add CriticalNotification window type to PlasmaShellSurface protocol.

Please land together with other revisions.

Apr 26 2019, 1:04 PM · Frameworks
zzag accepted D20628: Add CriticalNotification window type to PlasmaShellSurface protocol.
Apr 26 2019, 1:04 PM · Frameworks