zzag (Vlad Zagorodniy)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Dec 16 2017, 8:25 AM (66 w, 3 d)
Availability
Available

Recent Activity

Today

zzag added a comment to D20056: Fix crash when using kwin on windowed mode.

Could you please provide more context?

Tue, Mar 26, 7:17 AM · KWin
zzag accepted D20057: Enable blurbehind also for panel controls only if theme sets it.
Tue, Mar 26, 7:15 AM · Plasma

Yesterday

zzag accepted D20017: Update URLs to use https.
Mon, Mar 25, 6:23 PM · Documentation, KWin
zzag added a comment to D20044: Expose AbstractClient::setMaximize to scripting.

Is it a good idea to expose AbstractClient::setMaximize anyway? As far as I know, xdg-shell doesn't define maximized vertically or maximized horizontally states.

Mon, Mar 25, 5:58 PM · KWin
zzag added a comment to D18579: Rework Sensor Browser.

Fix code style

Mon, Mar 25, 10:40 AM · Plasma
zzag added inline comments to D20017: Update URLs to use https.
Mon, Mar 25, 9:12 AM · Documentation, KWin

Sat, Mar 23

zzag accepted D19955: Don't show the OrientationSensor if it's not supported.
Sat, Mar 23, 4:21 PM · KWin

Fri, Mar 22

zzag added a comment to D17884: [effects] Enable touchpoints by default.

I've tried this effect and in general it looks okay to me. The only thing that I don't like is the default color palette but that's probably matter of personal taste.

Fri, Mar 22, 9:39 PM · KWin
zzag updated the diff for D12055: Remove border around menubars.

rebase

Fri, Mar 22, 8:52 PM · Plasma
zzag requested review of D19971: Fix compilation error when SA_TRACE is 1.
Fri, Mar 22, 12:10 PM · Plasma

Wed, Mar 20

zzag added a comment to D19909: Enable blurbehind for panels only if theme sets it.

What about plasma::dialog?

Wed, Mar 20, 11:47 AM · Plasma
zzag requested review of D19905: [platforms/drm] Rework ScopedDrmPointer.
Wed, Mar 20, 9:41 AM · KWin

Tue, Mar 19

zzag added a comment to R108:d51070223b0a: There's no qml folder here anymore.

Oh, looks like I missed this one, thank you for fixing it. :-)

Tue, Mar 19, 9:21 PM
zzag added a comment to D19860: Software rotation: orient the screen regardless of whether drm accepted it.

Does this revision depend on D19731?

Tue, Mar 19, 6:03 PM · KWin
zzag added a comment to D19860: Software rotation: orient the screen regardless of whether drm accepted it.

It seems like there are still some issues with rotatino :(

Tue, Mar 19, 6:00 PM · KWin
zzag committed R108:c5a3b4705063: Get rid of Deleted's properties (authored by zzag).
Get rid of Deleted's properties
Tue, Mar 19, 4:06 PM
zzag closed D19722: Get rid of Deleted's properties.
Tue, Mar 19, 4:06 PM · KWin
zzag committed R108:380c93ac19f5: [platforms/drm] Add DPI connector type (authored by zzag).
[platforms/drm] Add DPI connector type
Tue, Mar 19, 4:05 PM
zzag closed D19781: [platforms/drm] Add DPI connector type.
Tue, Mar 19, 4:05 PM · KWin
zzag updated the diff for D19886: [wayland] Make sure that only the fading popups effect animates outline.

another wording

Tue, Mar 19, 3:40 PM · KWin
zzag updated the diff for D19886: [wayland] Make sure that only the fading popups effect animates outline.

edit comment

Tue, Mar 19, 3:30 PM · KWin
zzag requested review of D19886: [wayland] Make sure that only the fading popups effect animates outline.
Tue, Mar 19, 3:21 PM · KWin
zzag requested review of D19879: Make Compositor::finish more generic.
Tue, Mar 19, 10:14 AM · KWin
zzag accepted D19867: [X11] Force glXSwapBuffers to block with NVIDIA driver.

I don't have any NVIDIA GPU to test, but code-wise this change makes sense.

Tue, Mar 19, 9:20 AM · KWin

Mon, Mar 18

zzag committed R108:56b24f959f0b: [kcmkwin] Properly load effects (authored by zzag).
[kcmkwin] Properly load effects
Mon, Mar 18, 11:42 AM
zzag closed D18728: [kcmkwin] Properly load effects.
Mon, Mar 18, 11:42 AM · KWin
zzag committed R108:dc0b11eea77f: [kcmkwin] Rename EffectsModel::m_effectsList to EffectsModel::m_effects (authored by zzag).
[kcmkwin] Rename EffectsModel::m_effectsList to EffectsModel::m_effects
Mon, Mar 18, 11:42 AM
zzag committed R108:b91cfae3080b: [kcmkwin] Rename EffectModel to EffectsModel (authored by zzag).
[kcmkwin] Rename EffectModel to EffectsModel
Mon, Mar 18, 11:42 AM
zzag closed D18713: [kcmkwin] Rename EffectsModel::m_effectsList to EffectsModel::m_effects.
Mon, Mar 18, 11:42 AM · KWin
zzag closed D18712: [kcmkwin] Rename EffectModel to EffectsModel.
Mon, Mar 18, 11:42 AM · KWin
zzag committed R108:dc3bc5f7b72b: [kcmkwin] Remove some name duplication in EffectModel (authored by zzag).
[kcmkwin] Remove some name duplication in EffectModel
Mon, Mar 18, 11:42 AM
zzag committed R108:7a28a7442ecd: [kcmkwin] Simplify EffectModel::save (authored by zzag).
[kcmkwin] Simplify EffectModel::save
Mon, Mar 18, 11:42 AM
zzag closed D18707: [kcmkwin] Remove some name duplication in EffectModel.
Mon, Mar 18, 11:42 AM · KWin
zzag closed D18706: [kcmkwin] Simplify EffectModel::save.
Mon, Mar 18, 11:42 AM · KWin
zzag committed R108:bc34a9d65379: [kcmkwin] Don't discard unsaved changes when reloading effects model (authored by zzag).
[kcmkwin] Don't discard unsaved changes when reloading effects model
Mon, Mar 18, 11:42 AM
zzag closed D18705: [kcmkwin] Don't discard unsaved changes when reloading effects model.
Mon, Mar 18, 11:42 AM · KWin
zzag closed D18704: [kcmkwin] Add requestConfigure to effects model.
Mon, Mar 18, 11:42 AM · KWin
zzag committed R108:1faa861bd58e: [kcmkwin] Add requestConfigure to effects model (authored by zzag).
[kcmkwin] Add requestConfigure to effects model
Mon, Mar 18, 11:42 AM
zzag committed R108:2211a951e795: [kcmkwin] Split out Desktop Effects KCM (authored by zzag).
[kcmkwin] Split out Desktop Effects KCM
Mon, Mar 18, 11:42 AM
zzag closed D18703: [kcmkwin] Split out Desktop Effects KCM.
Mon, Mar 18, 11:42 AM · KWin
zzag added a comment to D18703: [kcmkwin] Split out Desktop Effects KCM.

https://bugs.kde.org/show_bug.cgi?id=405588

Mon, Mar 18, 9:34 AM · KWin
zzag added a comment to D18703: [kcmkwin] Split out Desktop Effects KCM.

Can you file a bug report (or phab task or whatever)

Mon, Mar 18, 8:49 AM · KWin

Fri, Mar 15

zzag added inline comments to D19781: [platforms/drm] Add DPI connector type.
Fri, Mar 15, 7:03 PM · KWin
zzag requested review of D19781: [platforms/drm] Add DPI connector type.
Fri, Mar 15, 11:09 AM · KWin
zzag committed R108:d0604f99f286: Remove unused constant (authored by zzag).
Remove unused constant
Fri, Mar 15, 10:47 AM

Wed, Mar 13

zzag added a comment to D19721: [effects] Drop Thumbnail Aside effect.

You know this will yield negative PR, right? There will be complaints that we're becoming "GNOME-like".

Wed, Mar 13, 2:44 PM · KWin
zzag added a comment to D19705: Force server-side decoration if no borders are forced by user.

Code-wise this change looks okay to me, though after thinking for a bit I'm not sure whether this change makes sense logically. Maybe David could weigh in (we have plenty time before 5.15.4 is released).

Wed, Mar 13, 1:05 PM · KWin
zzag requested review of D19723: [effects/fallapart] Override scale, fade, and glide effect.
Wed, Mar 13, 11:29 AM · KWin
zzag requested review of D19722: Get rid of Deleted's properties.
Wed, Mar 13, 11:11 AM · KWin
zzag requested review of D19721: [effects] Drop Thumbnail Aside effect.
Wed, Mar 13, 11:03 AM · KWin
zzag added a comment to D19520: Properly restore current desktop from session.

backported to 5.12

Wed, Mar 13, 9:49 AM · KWin
zzag committed R108:8f1b24639695: Merge branch 'Plasma/5.15' (authored by zzag).
Merge branch 'Plasma/5.15'
Wed, Mar 13, 9:48 AM
zzag committed R108:084728379327: Merge branch 'Plasma/5.12' into Plasma/5.15 (authored by zzag).
Merge branch 'Plasma/5.12' into Plasma/5.15
Wed, Mar 13, 9:48 AM
zzag committed R108:f7af113261f7: Properly restore current desktop from session (authored by zzag).
Properly restore current desktop from session
Wed, Mar 13, 9:48 AM
zzag committed R108:99f7be6ddd11: Merge branch 'Plasma/5.15' (authored by zzag).
Merge branch 'Plasma/5.15'
Wed, Mar 13, 8:56 AM
zzag committed R108:93b7eea67db4: [platforms/fbdev] Use a better way to correct activating framebuffer devices (authored by nerdopolist).
[platforms/fbdev] Use a better way to correct activating framebuffer devices
Wed, Mar 13, 8:56 AM
zzag closed D19663: [platforms/fbdev] Use a better way to correct activating framebuffer devices.
Wed, Mar 13, 8:56 AM · KWin

Tue, Mar 12

zzag added inline comments to D19710: Rotate cursors also on portrait mode.
Tue, Mar 12, 8:21 PM · KWin
zzag added a comment to D19663: [platforms/fbdev] Use a better way to correct activating framebuffer devices.

Well, it's just for better git history. As I said previously, I won't insist on this (though it would be great to have full name :-)). The most important part is email anyway.

Tue, Mar 12, 8:12 PM · KWin
zzag added a comment to D19613: Support NET_WM_STATE_FOCUSED.

https://gitlab.gnome.org/GNOME/gtk/issues/499

Tue, Mar 12, 8:09 PM · KWin
zzag added a comment to D19705: Force server-side decoration if no borders are forced by user.

It does.

Tue, Mar 12, 7:07 PM · KWin
zzag resigned from D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons.

Just to be clear, I'm not against good defaults. I don't like that the defaults are adjusted in such way that icons look sharp only with one particular font size and one particular button size. After all, KDE Plasma is configurable. If we focus only on making defaults look good, then what's the point of making everything configurable?

Tue, Mar 12, 1:53 PM · Plasma
zzag added a comment to D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons.

What's not worth what?

Tue, Mar 12, 1:27 PM · Plasma
zzag added a comment to D19705: Force server-side decoration if no borders are forced by user.

It doesn't. GTK doesn't support xdg-decoration. :D

Tue, Mar 12, 1:25 PM · KWin
zzag added a comment to D19663: [platforms/fbdev] Use a better way to correct activating framebuffer devices.

I won't strongly insist on this but it would be great if you could provide your real name for better git history. If there is commit whose author is "vlad <....>", the only thing that comes to mind: Vlad? Which one?

Tue, Mar 12, 12:11 PM · KWin
zzag added a comment to D19708: [wayland] Finish active move-resize op when client is destroyed or unmapped.

I'm still not quite sure what exactly we have to do when a client is unmapped. Should we send a configure event?

Tue, Mar 12, 11:56 AM · KWin
zzag requested review of D19708: [wayland] Finish active move-resize op when client is destroyed or unmapped.
Tue, Mar 12, 11:54 AM · KWin
zzag added a comment to D19705: Force server-side decoration if no borders are forced by user.

Could you please add a test case?

Tue, Mar 12, 11:18 AM · KWin
zzag added a comment to D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons.

Not really, I still think it's not worth that.

Tue, Mar 12, 9:16 AM · Plasma

Mon, Mar 11

zzag added inline comments to D19690: Improve SNI text.
Mon, Mar 11, 6:59 PM · KWin
zzag added a comment to D19663: [platforms/fbdev] Use a better way to correct activating framebuffer devices.

Could you please provide your real name and email?

Mon, Mar 11, 2:40 PM · KWin
zzag committed R108:b106579d0ffe: Move package structure plugins to plugins dir (authored by zzag).
Move package structure plugins to plugins dir
Mon, Mar 11, 9:05 AM
zzag closed D18685: Move package structure plugins to plugins dir.
Mon, Mar 11, 9:05 AM · KWin
zzag committed R108:db1035fa4732: Merge branch 'Plasma/5.15' (authored by zzag).
Merge branch 'Plasma/5.15'
Mon, Mar 11, 7:25 AM
zzag committed R108:38e22ce6d18c: [platforms/x11] Properly unload effects on X11 (authored by zzag).
[platforms/x11] Properly unload effects on X11
Mon, Mar 11, 7:25 AM
zzag closed D19178: [platforms/x11] Properly unload effects on X11.
Mon, Mar 11, 7:25 AM · KWin
zzag added a comment to D19663: [platforms/fbdev] Use a better way to correct activating framebuffer devices.

Do you have commit access? If so, please backport this change to 5.15.

Mon, Mar 11, 7:21 AM · KWin
zzag accepted D19663: [platforms/fbdev] Use a better way to correct activating framebuffer devices.
Mon, Mar 11, 7:19 AM · KWin

Fri, Mar 8

zzag added inline comments to D19617: Support NET_WM_STATE_FOCUSED.
Fri, Mar 8, 5:45 PM · Frameworks
zzag accepted D19603: Fix colours of header bar for active and inactive windows.
Fri, Mar 8, 2:28 PM · Plasma
zzag added a comment to D19052: Fix captions with non-BMP characters.

Oh, I see. You can do better. :-) Just create a test table, e.g.

Fri, Mar 8, 12:53 PM · KWin
zzag added inline comments to D19603: Fix colours of header bar for active and inactive windows.
Fri, Mar 8, 11:48 AM · Plasma
zzag added a comment to D19603: Fix colours of header bar for active and inactive windows.

On X11, gtk isn't selecting the backdrop class. Probably because kwin doesn't support one of their new activation flags which would be a GTK bug for not following their fallback correctly.

Fri, Mar 8, 11:29 AM · Plasma
zzag added a comment to D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons.

This patch makes buttons sharp only for one particular button size and font size.

Fri, Mar 8, 9:33 AM · Plasma
zzag added a comment to D19603: Fix colours of header bar for active and inactive windows.

(also, it would be enough just to add a group reviewer)

Fri, Mar 8, 9:12 AM · Plasma
zzag added a comment to D19603: Fix colours of header bar for active and inactive windows.

What's the reason for removing the linear gradient?

Fri, Mar 8, 9:11 AM · Plasma
zzag committed R108:a9e469bf13f6: Properly restore current desktop from session (authored by zzag).
Properly restore current desktop from session
Fri, Mar 8, 8:49 AM
zzag committed R108:0984f6ccfd28: Merge branch 'Plasma/5.15' (authored by zzag).
Merge branch 'Plasma/5.15'
Fri, Mar 8, 8:49 AM
zzag closed D19520: Properly restore current desktop from session.
Fri, Mar 8, 8:49 AM · KWin
zzag updated the diff for D19411: [wayland] Apply window rules only to xdg-shell clients.

inline comment

Fri, Mar 8, 8:19 AM · KWin
zzag added inline comments to D19052: Fix captions with non-BMP characters.
Fri, Mar 8, 8:12 AM · KWin

Thu, Mar 7

zzag requested review of D19582: [effects/fade] RFC: Don't fade windows when switching between desktops.
Thu, Mar 7, 9:46 AM · KWin

Tue, Mar 5

zzag added a comment to D19552: [effects/screenshot] Set m_windowMode in screenshotWindowUnderCursor.

Hmm, looks like windowUnderCursor was left out in D3367. Anyway, this patch looks good to me.

Tue, Mar 5, 9:55 PM · KWin
zzag added a comment to D19152: Resurrect show tooltips option.

Well, you don't have to restart the compositor each time you enable/disable tooltips, it should just work. On my machine it works as expected.

Tue, Mar 5, 5:22 PM · KWin
zzag accepted D19544: Send blur/background contrast in device pixels.
Tue, Mar 5, 5:19 PM · Frameworks
zzag committed R114:a5a6590cfa85: Merge branch 'Plasma/5.15' (authored by zzag).
Merge branch 'Plasma/5.15'
Tue, Mar 5, 4:57 PM
zzag committed R114:d7237df172e5: Consistent arrow key handling in the Informative Alt+Tab skin (authored by Zren).
Consistent arrow key handling in the Informative Alt+Tab skin
Tue, Mar 5, 4:57 PM
zzag added a comment to D16093: Consistent arrow key handling in the Informative Alt+Tab skin.

I'll backport it to Plasma/5.15.

Tue, Mar 5, 4:52 PM · Plasma
zzag added a comment to D19152: Resurrect show tooltips option.

Just to be sure, did you restart kwin?

Tue, Mar 5, 3:46 PM · KWin
zzag added inline comments to D19544: Send blur/background contrast in device pixels.
Tue, Mar 5, 3:41 PM · Frameworks