zzag (Vlad Zagorodniy)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Dec 16 2017, 8:25 AM (57 w, 3 d)
Availability
Available

Recent Activity

Today

zzag accepted D18293: Set rows in virtualdesktop protocol.
Tue, Jan 22, 9:40 AM · KWin
zzag committed R127:0a2c807ad21e: [client] Wrap wl_shell_surface_set_{class,title} (authored by zzag).
[client] Wrap wl_shell_surface_set_{class,title}
Tue, Jan 22, 8:54 AM
zzag closed D18440: [client] Wrap wl_shell_surface_set_{class,title}.
Tue, Jan 22, 8:54 AM · Frameworks

Yesterday

zzag added a comment to D18440: [client] Wrap wl_shell_surface_set_{class,title}.

ShellSurface is super-duper deprecated. I wouldn't invest too much time on it.

Mon, Jan 21, 9:54 PM · Frameworks
zzag requested review of D18440: [client] Wrap wl_shell_surface_set_{class,title}.
Mon, Jan 21, 9:44 PM · Frameworks
zzag added a comment to D18436: [platform/virtual] Swap buffers in EGL GBM backend.

98% tests passed

Mon, Jan 21, 8:44 PM · KWin
zzag committed R108:7477a411ae66: Fix "context objects" in VirtualDesktopManager::setVirtualDesktopManagement (authored by zzag).
Fix "context objects" in VirtualDesktopManager::setVirtualDesktopManagement
Mon, Jan 21, 6:15 PM
zzag committed R108:7ddd5afe6442: Merge branch 'Plasma/5.15' (authored by zzag).
Merge branch 'Plasma/5.15'
Mon, Jan 21, 6:15 PM
zzag closed D18374: Fix "context objects" in VirtualDesktopManager::setVirtualDesktopManagement.
Mon, Jan 21, 6:15 PM · KWin
zzag committed R108:47e9e52df387: Set desktop name "atomically" when using the plasma virtual desktop protocol (authored by zzag).
Set desktop name "atomically" when using the plasma virtual desktop protocol
Mon, Jan 21, 6:15 PM
zzag committed R108:bae21154ea71: Generate desktop ids without curly braces (authored by zzag).
Generate desktop ids without curly braces
Mon, Jan 21, 6:15 PM
zzag closed D18373: Set desktop name "atomically" when using the plasma virtual desktop protocol.
Mon, Jan 21, 6:15 PM · KWin
zzag committed R108:737bb2ec8601: Make sure that new virtual desktops can be activated by using plasma virtual… (authored by zzag).
Make sure that new virtual desktops can be activated by using plasma virtual…
Mon, Jan 21, 6:15 PM
zzag closed D18355: Generate desktop ids without curly braces.
Mon, Jan 21, 6:15 PM · KWin
zzag closed D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol.
Mon, Jan 21, 6:15 PM · KWin
zzag committed R108:7274aed544aa: Fix VirtualDesktopManager::createVirtualDesktop (authored by zzag).
Fix VirtualDesktopManager::createVirtualDesktop
Mon, Jan 21, 6:15 PM
zzag closed D18328: Fix VirtualDesktopManager::createVirtualDesktop.
Mon, Jan 21, 6:15 PM · KWin
zzag updated the diff for D18328: Fix VirtualDesktopManager::createVirtualDesktop.

Use bounded position

Mon, Jan 21, 5:54 PM · KWin
zzag added inline comments to D18293: Set rows in virtualdesktop protocol.
Mon, Jan 21, 5:30 PM · KWin
zzag added inline comments to D17691: Add rows info to the plasma virtual desktop protocol.
Mon, Jan 21, 5:08 PM · Frameworks
zzag added inline comments to D18293: Set rows in virtualdesktop protocol.
Mon, Jan 21, 4:42 PM · KWin
zzag added inline comments to D18293: Set rows in virtualdesktop protocol.
Mon, Jan 21, 4:38 PM · KWin
zzag added inline comments to D18368: [effects] Port to new connect syntax.
Mon, Jan 21, 10:20 AM · KWin

Sun, Jan 20

zzag requested review of D18421: [autotests] Stabilize testWindowmanagement.
Sun, Jan 20, 10:46 PM · Frameworks
zzag added a comment to D18416: [kcmkwin/effects] Relocate KCM to implement new Appearance section layout.

Please remove [3/3] part from the subject line.

Sun, Jan 20, 9:28 PM · KWin
zzag accepted D18405: Switch ThumbnailItem to internal uuid instead of WId.

Other switchers seem to work fine as well.

Sun, Jan 20, 5:53 PM · KWin
zzag added a comment to D18406: Silence warnings in TabBoxHandler.

Yeah, I saw it before.

Sun, Jan 20, 4:57 PM · KWin
zzag created P290 Fix -Wsuggest-override patch in the S1 KDE Community space.
Sun, Jan 20, 4:48 PM
zzag added a comment to D18406: Silence warnings in TabBoxHandler.

I don't see any warnings. Could you please provide the warning message?

Sun, Jan 20, 2:23 PM · KWin
zzag committed R108:cd0f954ab13d: [libkwineffects] Port AnimationEffect to new connect syntax (authored by zzag).
[libkwineffects] Port AnimationEffect to new connect syntax
Sun, Jan 20, 12:15 PM
zzag closed D18393: [libkwineffects] Port AnimationEffect to new connect syntax.
Sun, Jan 20, 12:15 PM · KWin
zzag committed R108:6740db7a6c72: [autotests] Use unloadAllEffects (authored by zzag).
[autotests] Use unloadAllEffects
Sun, Jan 20, 12:02 PM
zzag closed D18383: [autotests] Use unloadAllEffects.
Sun, Jan 20, 12:02 PM · KWin
zzag committed R108:8877dff7157e: [autotests] Update tests to use stable version of xdg-shell (authored by zzag).
[autotests] Update tests to use stable version of xdg-shell
Sun, Jan 20, 12:02 PM
zzag closed D18292: [autotests] Update tests to use stable version of xdg-shell.
Sun, Jan 20, 12:02 PM · KWin

Sat, Jan 19

zzag requested review of D18393: [libkwineffects] Port AnimationEffect to new connect syntax.
Sat, Jan 19, 6:28 PM · KWin
zzag updated the diff for D18383: [autotests] Use unloadAllEffects.

Preserve the order.

Sat, Jan 19, 2:36 PM · KWin
zzag requested review of D18383: [autotests] Use unloadAllEffects.
Sat, Jan 19, 2:34 PM · KWin
zzag updated the diff for D18292: [autotests] Update tests to use stable version of xdg-shell.

Re-title

Sat, Jan 19, 2:15 PM · KWin

Fri, Jan 18

zzag retitled D18374: Fix "context objects" in VirtualDesktopManager::setVirtualDesktopManagement from Use correct "context objects" in VirtualDesktopManager::setVirtualDesktopManagement to Fix "context objects" in VirtualDesktopManager::setVirtualDesktopManagement.
Fri, Jan 18, 10:45 PM · KWin
zzag requested review of D18374: Fix "context objects" in VirtualDesktopManager::setVirtualDesktopManagement.
Fri, Jan 18, 10:42 PM · KWin
zzag added a dependency for D18373: Set desktop name "atomically" when using the plasma virtual desktop protocol: D18355: Generate desktop ids without curly braces.
Fri, Jan 18, 10:16 PM · KWin
zzag added a dependent revision for D18355: Generate desktop ids without curly braces: D18373: Set desktop name "atomically" when using the plasma virtual desktop protocol.
Fri, Jan 18, 10:16 PM · KWin
zzag requested review of D18373: Set desktop name "atomically" when using the plasma virtual desktop protocol.
Fri, Jan 18, 10:15 PM · KWin
zzag updated the diff for D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol.

Remove unused captures

Fri, Jan 18, 10:00 PM · KWin
zzag committed R108:a1e5650fd0af: Merge branch 'Plasma/5.15' (authored by zzag).
Merge branch 'Plasma/5.15'
Fri, Jan 18, 9:53 PM
zzag committed R108:fbb30bb863cf: Delete names of removed desktops from kwinrc (authored by zzag).
Delete names of removed desktops from kwinrc
Fri, Jan 18, 9:53 PM
zzag closed D18372: Delete names of removed desktops from kwinrc.
Fri, Jan 18, 9:53 PM · KWin
zzag added a dependency for D18355: Generate desktop ids without curly braces: D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol.
Fri, Jan 18, 9:52 PM · KWin
zzag added a dependent revision for D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol: D18355: Generate desktop ids without curly braces.
Fri, Jan 18, 9:52 PM · KWin
zzag requested review of D18372: Delete names of removed desktops from kwinrc.
Fri, Jan 18, 9:46 PM · KWin
zzag committed R108:95ccb6c1700f: Merge branch 'Plasma/5.15' (authored by zzag).
Merge branch 'Plasma/5.15'
Fri, Jan 18, 7:42 PM
zzag committed R108:253f954e3101: [scenes/opengl] Destroy the lanczos filter when the backend is still alive (authored by zzag).
[scenes/opengl] Destroy the lanczos filter when the backend is still alive
Fri, Jan 18, 7:42 PM
zzag closed D18367: [scenes/opengl] Destroy the lanczos filter when the backend is still alive.
Fri, Jan 18, 7:42 PM · KWin
zzag added a comment to D18368: [effects] Port to new connect syntax.

I know it's a huge patch, but I hope it would be okay to merge. We have a big time frame to test the patch.

Fri, Jan 18, 7:34 PM · KWin
zzag updated the diff for D18368: [effects] Port to new connect syntax.

Make arc linter happier

Fri, Jan 18, 7:19 PM · KWin
zzag committed R108:2458b95e8c86: Remove executable bit from presentwindows.cpp (authored by zzag).
Remove executable bit from presentwindows.cpp
Fri, Jan 18, 7:17 PM
zzag requested review of D18368: [effects] Port to new connect syntax.
Fri, Jan 18, 7:14 PM · KWin
zzag requested review of D18367: [scenes/opengl] Destroy the lanczos filter when the backend is still alive.
Fri, Jan 18, 7:07 PM · KWin
zzag added a comment to D18365: Add a flag to keep a window on top.

Looks good to me.

Fri, Jan 18, 2:39 PM · Frameworks
zzag committed R108:392c2b878e8a: Merge branch 'Plasma/5.15' (authored by zzag).
Merge branch 'Plasma/5.15'
Fri, Jan 18, 1:47 PM
zzag committed R108:204a05fef82e: Compile the virtual backend with older Mesa (authored by zzag).
Compile the virtual backend with older Mesa
Fri, Jan 18, 1:47 PM
zzag closed D18353: Compile the virtual backend with older Mesa.
Fri, Jan 18, 1:47 PM · KWin
zzag accepted D18359: [build] Search for kirigami as a runtime dependency.
Fri, Jan 18, 1:43 PM · KWin
zzag added a reviewer for D18359: [build] Search for kirigami as a runtime dependency: KWin.
Fri, Jan 18, 1:39 PM · KWin
zzag requested changes to D18293: Set rows in virtualdesktop protocol.

Martin's comment.

Fri, Jan 18, 12:36 PM · KWin
zzag added a reviewer for D18293: Set rows in virtualdesktop protocol: KWin.
Fri, Jan 18, 12:30 PM · KWin
zzag added a comment to D17691: Add rows info to the plasma virtual desktop protocol.

David's comment is still not done.

Fri, Jan 18, 12:23 PM · Frameworks
zzag added inline comments to D17122: Add option to use wl_display_add_socket_auto.
Fri, Jan 18, 10:58 AM · Frameworks
zzag requested review of D18355: Generate desktop ids without curly braces.
Fri, Jan 18, 10:24 AM · KWin
zzag requested review of D18353: Compile the virtual backend with older Mesa.
Fri, Jan 18, 9:48 AM · KWin
zzag added a comment to D18344: Make use of doxygen markers consistent in AbstractClient.

I think only the opening /** bit is relevant?

Fri, Jan 18, 9:35 AM · KWin
zzag updated the diff for D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol.

Rebase

Fri, Jan 18, 9:25 AM · KWin
zzag updated the diff for D18328: Fix VirtualDesktopManager::createVirtualDesktop.

Pass zero-based position in VirtualDesktopManagerDBusInterface::createDesktop

Fri, Jan 18, 9:24 AM · KWin

Thu, Jan 17

zzag planned changes to D18328: Fix VirtualDesktopManager::createVirtualDesktop.
Thu, Jan 17, 11:43 PM · KWin
zzag accepted D18339: Fix DesktopGrid drag on X11.
Thu, Jan 17, 11:32 PM · KWin
zzag added a comment to D18339: Fix DesktopGrid drag on X11.

When can a client end up on several desktops? (on X11)

Thu, Jan 17, 10:46 PM · KWin
zzag retitled D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol from Make sure that new virtual desktops can be activated to Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol.
Thu, Jan 17, 10:40 PM · KWin
zzag retitled D18328: Fix VirtualDesktopManager::createVirtualDesktop from Fix VirtualDesktopManager::createvirtualDesktop to Fix VirtualDesktopManager::createVirtualDesktop.
Thu, Jan 17, 10:31 PM · KWin
zzag retitled D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol from Make new virtual desktops "activatable" to Make sure that new virtual desktops can be activated.
Thu, Jan 17, 10:31 PM · KWin
zzag updated the diff for D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol.

Rebase

Thu, Jan 17, 10:30 PM · KWin
zzag updated the diff for D18328: Fix VirtualDesktopManager::createVirtualDesktop.

foobar

Thu, Jan 17, 10:29 PM · KWin
zzag updated the diff for D18328: Fix VirtualDesktopManager::createVirtualDesktop.

wrong diff

Thu, Jan 17, 10:28 PM · KWin
zzag updated the diff for D18328: Fix VirtualDesktopManager::createVirtualDesktop.

edit comment

Thu, Jan 17, 10:27 PM · KWin
zzag retitled D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol from Make newly created virtual desktops "activatable" to Make new virtual desktops "activatable".
Thu, Jan 17, 10:24 PM · KWin
zzag added a dependent revision for D18328: Fix VirtualDesktopManager::createVirtualDesktop: D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol.
Thu, Jan 17, 10:21 PM · KWin
zzag added a dependency for D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol: D18328: Fix VirtualDesktopManager::createVirtualDesktop.
Thu, Jan 17, 10:21 PM · KWin
zzag requested review of D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol.
Thu, Jan 17, 10:21 PM · KWin
zzag updated the diff for D18328: Fix VirtualDesktopManager::createVirtualDesktop.

Split the commit.

Thu, Jan 17, 10:20 PM · KWin
zzag planned changes to D18328: Fix VirtualDesktopManager::createVirtualDesktop.
Thu, Jan 17, 9:25 PM · KWin
zzag updated the diff for D18328: Fix VirtualDesktopManager::createVirtualDesktop.

Overhaul plasma virtual desktop interface creation (it's broken right now).

Thu, Jan 17, 9:24 PM · KWin
zzag planned changes to D18328: Fix VirtualDesktopManager::createVirtualDesktop.

Hmm, no, that's a problem on KWin side.

Thu, Jan 17, 8:17 PM · KWin
zzag updated the summary of D18328: Fix VirtualDesktopManager::createVirtualDesktop.
Thu, Jan 17, 6:24 PM · KWin
zzag added a comment to D18328: Fix VirtualDesktopManager::createVirtualDesktop.

It doesn't look like a KWin issue.

Thu, Jan 17, 6:23 PM · KWin
zzag updated subscribers of D18328: Fix VirtualDesktopManager::createVirtualDesktop.

@hein The Pager applet can have "dead" virtual desktops after repeating "add virtual desktop - remove virtual desktop" cycle for several times.

Thu, Jan 17, 6:21 PM · KWin
zzag updated the summary of D18328: Fix VirtualDesktopManager::createVirtualDesktop.
Thu, Jan 17, 6:15 PM · KWin
zzag requested review of D18328: Fix VirtualDesktopManager::createVirtualDesktop.
Thu, Jan 17, 6:10 PM · KWin
zzag added a comment to D18307: Call frameRendered for undamaged Wayland surfaces.

@ekurzinger Do you have commit access?

Thu, Jan 17, 10:29 AM · KWin

Wed, Jan 16

zzag accepted D18286: Export path of installed color-schemes in BreezeConfig cmake.
Wed, Jan 16, 1:52 PM · Plasma
zzag accepted D18244: Check for python-cairo.
Wed, Jan 16, 1:46 PM · Plasma