zzag (Vlad Zahorodnii)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Dec 16 2017, 8:25 AM (99 w, 5 d)
Availability
Available

Recent Activity

Yesterday

zzag added a comment to D24457: [wayland] Ensure that repaints_region is in frame-local coordinates.

Let me try and explain my point again.

[...]

In another invocation of TopLevel::addDamage the argument is relative to the frame (when we're in the overridden implementation calling the base implementation)

Wed, Nov 13, 6:36 PM · KWin
zzag added inline comments to D25292: [effects] Forward wheel events.
Wed, Nov 13, 6:26 PM · KWin
zzag added inline comments to D25292: [effects] Forward wheel events.
Wed, Nov 13, 6:24 PM · KWin
zzag accepted D25207: [libkwineffects] Construct correct mouse event when forwarding to QtQuickView.
Wed, Nov 13, 6:07 PM · KWin
zzag added inline comments to D25207: [libkwineffects] Construct correct mouse event when forwarding to QtQuickView.
Wed, Nov 13, 5:59 PM · KWin
zzag added a comment to D24457: [wayland] Ensure that repaints_region is in frame-local coordinates.

When we call

Toplevel::addDamage(damage);

TopLevel::addDamage is relative to the frame

Wed, Nov 13, 5:37 PM · KWin

Tue, Nov 12

zzag added inline comments to D25207: [libkwineffects] Construct correct mouse event when forwarding to QtQuickView.
Tue, Nov 12, 7:23 PM · KWin
zzag abandoned D20572: RFC: Add .clang-format.
Tue, Nov 12, 12:43 PM · KWin

Thu, Nov 7

zzag updated the summary of D25201: Don't set X-Plasma-MainScript for wallpaper plugins.
Thu, Nov 7, 10:05 PM · Plasma
zzag edited reviewers for D25201: Don't set X-Plasma-MainScript for wallpaper plugins, added: Plasma; removed: KWin.
Thu, Nov 7, 10:03 PM · Plasma
zzag requested review of D25201: Don't set X-Plasma-MainScript for wallpaper plugins.
Thu, Nov 7, 10:00 PM · Plasma
zzag abandoned D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper.

Okay, I see.

Thu, Nov 7, 12:19 PM · Frameworks
zzag retitled D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper from Add property definition for "X-Plasma-MainScript" for Plasma/Wallpaper to Define property X-Plasma-MainScript for Plasma/Wallpaper.
Thu, Nov 7, 12:58 AM · Frameworks
zzag requested review of D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper.
Thu, Nov 7, 12:13 AM · Frameworks

Fri, Nov 1

zzag added inline comments to D24862: Port one of session management connections state to a custom API.
Fri, Nov 1, 10:12 AM · KWin
zzag added inline comments to D24862: Port one of session management connections state to a custom API.
Fri, Nov 1, 10:11 AM · KWin

Thu, Oct 31

zzag requested review of D25092: [tabbox] Drop TabBoxClient::window() method.
Thu, Oct 31, 1:05 PM · KWin
zzag committed R119:45439589181e: Merge branch 'Plasma/5.17' (authored by zzag).
Merge branch 'Plasma/5.17'
Thu, Oct 31, 9:17 AM
zzag committed R119:59e3003943da: [Night Color KCM] Reset seconds and milliseconds in provided timings (authored by zzag).
[Night Color KCM] Reset seconds and milliseconds in provided timings
Thu, Oct 31, 9:17 AM
zzag closed D25047: [Night Color KCM] Reset seconds and milliseconds in provided timings.
Thu, Oct 31, 9:17 AM · Plasma

Wed, Oct 30

zzag added a comment to T11944: drm.

What's this task about?

Wed, Oct 30, 7:33 PM · Plasma
zzag added a comment to D25022: Add some const &.
In D25022#556512, @zzag wrote:

Yeah, but we also use QSharedPointer, which is not movable.

https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qsharedpointer_impl.h#n332

It seems it is?

Wed, Oct 30, 10:17 AM · KWin
zzag added a comment to D25022: Add some const &.

What do you mean they are not movable?

https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qshareddata.h?h=5.13#n222
Wed, Oct 30, 9:57 AM · KWin
zzag accepted D25022: Add some const &.

For shared pointers instead of adding const & we move them into the destination variable saving some cpu usage but at the same time making clear the pointer is being stored by not being const &

Wed, Oct 30, 9:37 AM · KWin
zzag accepted D25065: [effects/startupfeedback] Fallback to small icon size when no cursor size is configured.
Wed, Oct 30, 9:10 AM · KWin

Tue, Oct 29

zzag accepted D25056: Add support for virgl in GLPlatform.
Tue, Oct 29, 8:06 PM · KWin
zzag added a comment to D24455: [wayland] Implement window geometry more properly.

Please give this diff a more telling name what it is about. You introduce a new cached buffer size value and redefine geom via window geometry. What this does and how it relates to all the other sizes we have is not clear to me.

What would help: Create some images where the different areas of a window and what our sizes relate to are described. I mean it's clear from the specs what window and buffer geometry are supposed to be but we have/had geometry, client size, requested client size and so on.

Tue, Oct 29, 5:37 PM · KWin
zzag updated the summary of D25047: [Night Color KCM] Reset seconds and milliseconds in provided timings.
Tue, Oct 29, 4:47 PM · Plasma
zzag requested review of D25047: [Night Color KCM] Reset seconds and milliseconds in provided timings.
Tue, Oct 29, 4:41 PM · Plasma
zzag added inline comments to D24461: Fix coding style issues in Scene::paintSimpleScreen.
Tue, Oct 29, 3:49 PM · KWin
zzag added inline comments to D25022: Add some const &.
Tue, Oct 29, 10:09 AM · KWin

Mon, Oct 28

zzag committed R108:df614e218d4a: Delete some redundant checks (authored by zzag).
Delete some redundant checks
Mon, Oct 28, 12:10 PM
zzag closed D24473: Delete some redundant checks.
Mon, Oct 28, 12:10 PM · KWin
zzag committed R108:2e453c31dcec: Delete some commented code (authored by zzag).
Delete some commented code
Mon, Oct 28, 12:10 PM
zzag closed D24472: Delete some commented code.
Mon, Oct 28, 12:10 PM · KWin
zzag added a comment to T11903: KWayland for KF6.

or directly into KWin.

Mon, Oct 28, 10:19 AM · KWin, KF6
zzag added a comment to T11903: KWayland for KF6.

Should KWayland (Server part) be moved out of Frameworks into a Plasma lib?

Mon, Oct 28, 10:15 AM · KWin, KF6
zzag retitled D24988: [kcmkwin/desktop] Elide "Show animation when switching" checkbox text from [kcmkwin/kwinvirtualdesktops] Elide "Show animation when switching" checkbox text to [kcmkwin/desktop] Elide "Show animation when switching" checkbox text.
Mon, Oct 28, 9:51 AM · KWin
zzag accepted D24988: [kcmkwin/desktop] Elide "Show animation when switching" checkbox text.
Mon, Oct 28, 9:50 AM · KWin
zzag accepted D24954: Dmabuf recovery on EGL reset.
Mon, Oct 28, 9:46 AM · KWin

Fri, Oct 25

zzag accepted D24862: Port one of session management connections state to a custom API.

Some remaining nitpicks.

Fri, Oct 25, 9:12 PM · KWin
zzag accepted D24864: [effects] Add effect to hold the desktop window static after plasmashell quits.
Fri, Oct 25, 9:10 PM · KWin
zzag updated the summary of D24950: Drop some custom list typedefs.
Fri, Oct 25, 6:39 PM · KWin
zzag requested review of D24950: Drop some custom list typedefs.
Fri, Oct 25, 6:28 PM · KWin
zzag added a comment to D24864: [effects] Add effect to hold the desktop window static after plasmashell quits.

Could you please update this revision?

Fri, Oct 25, 3:04 PM · KWin
zzag committed R108:69a3517e0244: Merge branch 'Plasma/5.17' (authored by zzag).
Merge branch 'Plasma/5.17'
Fri, Oct 25, 2:51 PM
zzag committed R108:a738ecce85c1: [scripting] Provide conversion functions for AbstractClient (authored by zzag).
[scripting] Provide conversion functions for AbstractClient
Fri, Oct 25, 2:51 PM
zzag closed D24944: [scripting] Provide conversion functions for AbstractClient.
Fri, Oct 25, 2:51 PM · KWin
zzag updated the diff for D24944: [scripting] Provide conversion functions for AbstractClient.

QStringLiteral("/contents/") -> QLatin1String("/contents/")

Fri, Oct 25, 2:27 PM · KWin
zzag requested review of D24944: [scripting] Provide conversion functions for AbstractClient.
Fri, Oct 25, 2:02 PM · KWin

Thu, Oct 24

zzag committed R108:54ca0dfe12db: Merge branch 'Plasma/5.17' (authored by zzag).
Merge branch 'Plasma/5.17'
Thu, Oct 24, 3:58 PM
zzag committed R108:8e176c8b0d97: Don't use MESA_EGL_NO_X11_HEADERS (authored by zzag).
Don't use MESA_EGL_NO_X11_HEADERS
Thu, Oct 24, 3:58 PM
zzag added inline comments to D24862: Port one of session management connections state to a custom API.
Thu, Oct 24, 12:34 PM · KWin
zzag added a comment to D24906: [KCMs/Night Color] Explain Night Color feature inline.

[KCMs/Night Color]

Thu, Oct 24, 8:59 AM · Plasma
zzag accepted D24906: [KCMs/Night Color] Explain Night Color feature inline.
Thu, Oct 24, 8:57 AM · Plasma
zzag added a comment to D23514: [platforms/x11] Never block on retrace, always present after paint.

You know that the show fps effect is not a benchmark, right? I mean it says so just below it.

Thu, Oct 24, 8:21 AM · KWin
zzag added a comment to D24878: [x11] Check pending release when mapping.

Go for it.

Thu, Oct 24, 7:53 AM · KWin

Wed, Oct 23

zzag added a comment to D24878: [x11] Check pending release when mapping.

Do you have commit access?

Wed, Oct 23, 3:25 PM · KWin
zzag accepted D24878: [x11] Check pending release when mapping.
Wed, Oct 23, 3:13 PM · KWin
zzag updated the summary of D24878: [x11] Check pending release when mapping.
Wed, Oct 23, 3:13 PM · KWin
zzag added inline comments to D23514: [platforms/x11] Never block on retrace, always present after paint.
Wed, Oct 23, 1:47 PM · KWin
zzag added a comment to D23514: [platforms/x11] Never block on retrace, always present after paint.

Not syncing to vblank is not per se a performance issue as in lower framerate. It just means the latency is not optimized.

Wed, Oct 23, 1:20 PM · KWin
zzag added a comment to D23514: [platforms/x11] Never block on retrace, always present after paint.

I'm talking about this. The fps is around 40 to 50 even though I have only one client open (Konsole).

Wed, Oct 23, 1:04 PM · KWin
zzag added a comment to D23514: [platforms/x11] Never block on retrace, always present after paint.

This patch can't go in as is because of the performance issues.

Wed, Oct 23, 9:33 AM · KWin
zzag added a comment to D23514: [platforms/x11] Never block on retrace, always present after paint.

What solution do you propose?

Wed, Oct 23, 9:31 AM · KWin
zzag added a comment to D24878: [x11] Check pending release when mapping.

That's a good discovery! Do you have a test client by any chance?

Wed, Oct 23, 9:17 AM · KWin
zzag added a comment to D23514: [platforms/x11] Never block on retrace, always present after paint.

My concerns about performance regression introduced by this patch haven't been addressed. The time span during which kwin records rendering commands slides gradually over time, it's not aligned to vblank.

Wed, Oct 23, 8:41 AM · KWin

Tue, Oct 22

zzag added inline comments to D24862: Port one of session management connections state to a custom API.
Tue, Oct 22, 4:34 PM · KWin
zzag added inline comments to D24864: [effects] Add effect to hold the desktop window static after plasmashell quits.
Tue, Oct 22, 2:48 PM · KWin
zzag added inline comments to D24864: [effects] Add effect to hold the desktop window static after plasmashell quits.
Tue, Oct 22, 2:43 PM · KWin
zzag added a comment to D24862: Port one of session management connections state to a custom API.

Sweet. I like the SessionManager class. I wonder though whether we could put more responsibility on it, e.g. loading and storing session. I don't ask you to implement that or anything. I'm just trying to digest the idea of having a class responsible for session management and what potential code improvements/simplifications the class brings with itself.

Tue, Oct 22, 2:25 PM · KWin
zzag claimed T10530: Redesign Scene for subsurfaces.
Tue, Oct 22, 12:08 PM · KWin
zzag moved T10530: Redesign Scene for subsurfaces from Backlog to Work In Progress on the KWin board.
Tue, Oct 22, 12:07 PM · KWin
zzag renamed T10530: Redesign Scene for subsurfaces from [BRAINSTORM] Redesign Scene to Redesign Scene for subsurfaces.
Tue, Oct 22, 12:07 PM · KWin
zzag added a comment to T9600: Improve internal window code.

I don't have a strong opinion on this one, however I thought that it's better to keep tasks open when they are moved to "Done" because that way one could have a look at what features were implemented previously, etc.

Tue, Oct 22, 11:49 AM · KWin
zzag added a comment to T11886: Split KWin for Wayland and X11 at build level.

While I'm all for building KWin w/o X11 stuff, I think it's way to early to split kwin code into different libraries. X11 is used in many places. We need to take care of that first. Once we have distinct line between X11 stuff, Wayland stuff, and stuff that doesn't use any of those two, we can proceed with discussing this task.

Tue, Oct 22, 11:40 AM · KWin
zzag moved T9600: Improve internal window code from Under Review to Done on the KWin board.
Tue, Oct 22, 11:31 AM · KWin
zzag added a comment to T10867: XDG WindowGeometry.

In addition to the above, notice that KWin must put server-side decoration around the window geometry, not the main surface.

Tue, Oct 22, 11:24 AM · KWin, Plasma on Wayland
zzag added a comment to T10867: XDG WindowGeometry.

Alright, let's go quickly over the proposed solution...

Tue, Oct 22, 11:17 AM · KWin, Plasma on Wayland
zzag accepted D24850: [xwl] Return c++ version of true in method.
Tue, Oct 22, 8:23 AM · KWin
zzag committed R108:6dd2d6f16980: Merge branch 'Plasma/5.17' (authored by zzag).
Merge branch 'Plasma/5.17'
Tue, Oct 22, 8:22 AM
zzag committed R108:982fefd38974: [aurorae] Fix visibility of Context Help button (authored by zzag).
[aurorae] Fix visibility of Context Help button
Tue, Oct 22, 8:22 AM
zzag closed D24851: [aurorae] Fix visibility of Context Help button.
Tue, Oct 22, 8:22 AM · KWin
zzag requested review of D24851: [aurorae] Fix visibility of Context Help button.
Tue, Oct 22, 8:19 AM · KWin
zzag accepted D24829: Fix non-atomic output init.

Plasma 5.17

Tue, Oct 22, 7:32 AM · KWin

Mon, Oct 21

zzag accepted D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox.

Uh, I don't use Ukrainian locale. However, it doesn't matter that much. We format numbers practically the same way as in en_US.

Mon, Oct 21, 7:56 PM · Plasma
zzag committed R108:e06f83717c6d: Don't use MESA_EGL_NO_X11_HEADERS (authored by zzag).
Don't use MESA_EGL_NO_X11_HEADERS
Mon, Oct 21, 7:18 PM
zzag closed D24840: Don't use MESA_EGL_NO_X11_HEADERS.
Mon, Oct 21, 7:18 PM · KWin
zzag removed a reviewer for D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox: zzag.
Mon, Oct 21, 6:48 PM · Plasma
zzag requested review of D24840: Don't use MESA_EGL_NO_X11_HEADERS.
Mon, Oct 21, 6:34 PM · KWin
zzag accepted D24835: [effects/presentwindows] Fix newly introduced memory leak.
Mon, Oct 21, 3:58 PM · KWin
zzag updated the summary of D24473: Delete some redundant checks.
Mon, Oct 21, 3:39 PM · KWin
zzag added a comment to T11903: KWayland for KF6.

Drop ShellClient

Mon, Oct 21, 3:38 PM · KWin, KF6
zzag added inline comments to D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration.
Mon, Oct 21, 3:32 PM · Plasma
zzag added a comment to D24826: Enforce 100 chars line width.

I suggest to set ColumnLimit to 0 by default and allow projects to override it.

Mon, Oct 21, 12:55 PM · Build System, Frameworks
zzag removed a dependency for D24660: [x11] Add support for _GTK_FRAME_EXTENTS: D24657: Add support for _GTK_FRAME_EXTENTS.
Mon, Oct 21, 12:06 PM · KWin
zzag removed a dependent revision for D24657: Add support for _GTK_FRAME_EXTENTS: D24660: [x11] Add support for _GTK_FRAME_EXTENTS.
Mon, Oct 21, 12:06 PM · Frameworks
zzag updated the summary of D24660: [x11] Add support for _GTK_FRAME_EXTENTS.
Mon, Oct 21, 12:06 PM · KWin
GB_2 awarded D24660: [x11] Add support for _GTK_FRAME_EXTENTS a Love token.
Mon, Oct 21, 10:17 AM · KWin
zzag added a comment to D24663: Use ECMGenerateExportHeader to manage deprecated API better.

@zzag Hi. Any chance you can have time to review this today/the WE? One of the last ECMGenerateExportHeader patches.

Mon, Oct 21, 9:09 AM · Frameworks