zzag (Vlad Zagorodniy)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Dec 16 2017, 8:25 AM (30 w, 2 d)
Availability
Available

Recent Activity

Today

zzag added inline comments to D14152: Remove ref from returned QString.
Mon, Jul 16, 7:52 AM · Plasma
zzag requested review of D14150: [kdecoration] Delete unused includes.
Mon, Jul 16, 7:30 AM · Plasma
zzag added a comment to D11198: [libbreezecommon] Add box shadow helper.

@rikmills Should build now.

Mon, Jul 16, 6:46 AM · Plasma
zzag committed R31:b7abb46ee7bf: [libbreezecommon] Fix build when qreal is float (authored by zzag).
[libbreezecommon] Fix build when qreal is float
Mon, Jul 16, 6:44 AM
zzag closed D14090: [libbreezecommon] Fix build when qreal is float.
Mon, Jul 16, 6:44 AM · Plasma
zzag updated subscribers of D14090: [libbreezecommon] Fix build when qreal is float.

@anthonyfieroni Hugo stepped down as Breeze maintainer.

Mon, Jul 16, 6:41 AM · Plasma

Yesterday

zzag committed R108:dc541452f11b: Merge branch 'Plasma/5.13' (authored by zzag).
Merge branch 'Plasma/5.13'
Sun, Jul 15, 8:07 PM
zzag committed R108:1e4703a71959: [wayland] Confine pointer to screen geometry (authored by zzag).
[wayland] Confine pointer to screen geometry
Sun, Jul 15, 8:07 PM
zzag closed D14036: [wayland] Confine pointer to screen geometry.
Sun, Jul 15, 8:07 PM · KWin
zzag updated the summary of D14036: [wayland] Confine pointer to screen geometry.
Sun, Jul 15, 8:04 PM · KWin
zzag added inline comments to D14143: Make the action selector OSD independent of the other OSDs.
Sun, Jul 15, 7:35 PM · Plasma
zzag added inline comments to D14143: Make the action selector OSD independent of the other OSDs.
Sun, Jul 15, 7:27 PM · Plasma
zzag added a comment to D14090: [libbreezecommon] Fix build when qreal is float.

Ping? I'll land it tomorrow if no one has objections.

Sun, Jul 15, 4:56 PM · Plasma
zzag committed R31:02519ad921d3: [kdecoration] Make shadows lighter (authored by zzag).
[kdecoration] Make shadows lighter
Sun, Jul 15, 4:52 PM
zzag closed D14133: [kdecoration] Make shadows lighter.
Sun, Jul 15, 4:52 PM · Plasma
zzag added a comment to D14036: [wayland] Confine pointer to screen geometry.

@graesslin Where should it go? Plasma/5.13(and master) or just master?

Sun, Jul 15, 3:58 PM · KWin
zzag updated the summary of D14133: [kdecoration] Make shadows lighter.
Sun, Jul 15, 3:34 PM · Plasma
zzag updated the summary of D14133: [kdecoration] Make shadows lighter.
Sun, Jul 15, 3:30 PM · Plasma
zzag updated the diff for D14133: [kdecoration] Make shadows lighter.

Tweak small and medium shadows

Sun, Jul 15, 3:28 PM · Plasma
zzag added a comment to D14133: [kdecoration] Make shadows lighter.

Sun, Jul 15, 2:50 PM · Plasma
zzag updated the diff for D14133: [kdecoration] Make shadows lighter.

Make key shadow lighter for Large and Very large shadows

Sun, Jul 15, 2:48 PM · Plasma
zzag added a comment to D14133: [kdecoration] Make shadows lighter.

Maybe, we should make contrast/ambiance shadows lighter...

Sun, Jul 15, 2:43 PM · Plasma
zzag added a comment to D14133: [kdecoration] Make shadows lighter.
  1. Slightly moved box shadows
Sun, Jul 15, 2:37 PM · Plasma
zzag updated the diff for D14133: [kdecoration] Make shadows lighter.

Move box shadows up

Sun, Jul 15, 2:35 PM · Plasma
zzag retitled D14133: [kdecoration] Make shadows lighter from [kdecoration] Make shadows lighter to WIP: [kdecoration] Make shadows lighter.
Sun, Jul 15, 2:07 PM · Plasma
zzag updated the summary of D14133: [kdecoration] Make shadows lighter.
Sun, Jul 15, 2:06 PM · Plasma
zzag updated the summary of D14133: [kdecoration] Make shadows lighter.
Sun, Jul 15, 2:04 PM · Plasma
zzag requested review of D14133: [kdecoration] Make shadows lighter.
Sun, Jul 15, 2:02 PM · Plasma

Sat, Jul 14

zzag committed R108:4aa19c2e9189: [effects/magiclamp] Eliminate unnecessary reallocations (authored by zzag).
[effects/magiclamp] Eliminate unnecessary reallocations
Sat, Jul 14, 10:41 PM
zzag closed D14117: [effects/magiclamp] Eliminate unnecessary reallocations.
Sat, Jul 14, 10:41 PM · KWin
zzag added a comment to D14117: [effects/magiclamp] Eliminate unnecessary reallocations.

If this is an issue, we could try looking into setting a Q_DECLARE_TYPEINFO on the WindowQuadList.
Right now QList still allocates a second set of memory for complex types separate from the internal void* list that we're pre-allocating here.

Sat, Jul 14, 10:40 PM · KWin
zzag updated the summary of D14117: [effects/magiclamp] Eliminate unnecessary reallocations.
Sat, Jul 14, 9:23 PM · KWin
zzag requested review of D14117: [effects/magiclamp] Eliminate unnecessary reallocations.
Sat, Jul 14, 9:08 PM · KWin
zzag committed R108:049c6e0966ce: [effects/slidingpopups] Use range-based for loops (authored by zzag).
[effects/slidingpopups] Use range-based for loops
Sat, Jul 14, 7:06 PM
zzag closed D14086: [effects/slidingpopups] Use range-based for loops.
Sat, Jul 14, 7:06 PM · KWin
zzag committed R108:a63c9ab319b9: [effects/slidingpopups] Reserve enough memory for filtered quads (authored by zzag).
[effects/slidingpopups] Reserve enough memory for filtered quads
Sat, Jul 14, 7:05 PM
zzag closed D14085: [effects/slidingpopups] Reserve enough memory for filtered quads.
Sat, Jul 14, 7:04 PM · KWin
zzag added inline comments to D14081: Fix types, improve readability.
Sat, Jul 14, 7:45 AM · Plasma

Fri, Jul 13

zzag committed R108:461aace55f71: [effects/slidingpopups] Fix possible segfault (authored by zzag).
[effects/slidingpopups] Fix possible segfault
Fri, Jul 13, 4:56 PM
zzag closed D14087: [effects/slidingpopups] Fix possible segfault.
Fri, Jul 13, 4:56 PM · KWin
zzag updated the diff for D14096: [effects/slidingpopups] Use single QHash to store animations.

Oops, wrong diff.

Fri, Jul 13, 12:42 PM · KWin
zzag requested review of D14096: [effects/slidingpopups] Use single QHash to store animations.
Fri, Jul 13, 12:36 PM · KWin
zzag committed R108:4e1e22c76d5b: [effects/slidingpopups] Simplify math in setupAnimData (authored by zzag).
[effects/slidingpopups] Simplify math in setupAnimData
Fri, Jul 13, 11:32 AM
zzag closed D14088: [effects/slidingpopups] Simplify math in setupAnimData.
Fri, Jul 13, 11:32 AM · KWin
zzag added a comment to D14086: [effects/slidingpopups] Use range-based for loops.

Would have expected some fancy std::remove_if from you

Fri, Jul 13, 11:01 AM · KWin
zzag requested review of D14092: [effects/slidingpopups] Unconditionally force background contrast.
Fri, Jul 13, 8:39 AM · KWin
zzag committed R108:2d1afb809cda: [effects/slidingpopups] Delete unused prePaintScreen method (authored by zzag).
[effects/slidingpopups] Delete unused prePaintScreen method
Fri, Jul 13, 8:10 AM
zzag closed D14091: [effects/slidingpopups] Delete unused prePaintScreen method.
Fri, Jul 13, 8:10 AM · KWin
zzag requested review of D14091: [effects/slidingpopups] Delete unused prePaintScreen method.
Fri, Jul 13, 8:02 AM · KWin
zzag added inline comments to D14088: [effects/slidingpopups] Simplify math in setupAnimData.
Fri, Jul 13, 7:41 AM · KWin
zzag requested review of D14090: [libbreezecommon] Fix build when qreal is float.
Fri, Jul 13, 7:28 AM · Plasma
zzag added a comment to D11198: [libbreezecommon] Add box shadow helper.

Gosh, I forgot that qreal can be also a float.

Fri, Jul 13, 7:18 AM · Plasma
zzag requested review of D14088: [effects/slidingpopups] Simplify math in setupAnimData.
Fri, Jul 13, 7:12 AM · KWin
zzag requested review of D14087: [effects/slidingpopups] Fix possible segfault.
Fri, Jul 13, 7:02 AM · KWin
zzag requested review of D14086: [effects/slidingpopups] Use range-based for loops.
Fri, Jul 13, 7:01 AM · KWin
zzag requested review of D14085: [effects/slidingpopups] Reserve enough memory for filtered quads.
Fri, Jul 13, 6:59 AM · KWin

Thu, Jul 12

zzag added inline comments to D14065: Be strict about implicit string casts.
Thu, Jul 12, 8:17 AM · Plasma
zzag added inline comments to D14060: Clean up string casts.
Thu, Jul 12, 7:08 AM · Plasma

Wed, Jul 11

zzag added inline comments to D13887: use the new plasma virtual desktop protocol.
Wed, Jul 11, 8:19 PM · KWin
zzag added inline comments to D14050: Fwupd Backend For Review and Improvement.
Wed, Jul 11, 7:52 PM · Discover Software Store, Plasma
zzag added inline comments to D14024: Move KCM to UI file.
Wed, Jul 11, 3:30 PM · Plasma
januz awarded D14046: [effects/desktopgrid] Don't change activities a Party Time token.
Wed, Jul 11, 2:30 PM · KWin
zzag committed R108:d0ceaf4c7025: [effects/slide] Clean up (authored by zzag).
[effects/slide] Clean up
Wed, Jul 11, 2:07 PM
zzag closed D13979: [effects/slide] Clean up.
Wed, Jul 11, 2:07 PM · KWin
zzag committed R108:0c3047a8f1d4: [effects/desktopgrid] Don't change activities (authored by zzag).
[effects/desktopgrid] Don't change activities
Wed, Jul 11, 2:06 PM
zzag committed R108:c69a16b914cc: Merge branch 'Plasma/5.13' (authored by zzag).
Merge branch 'Plasma/5.13'
Wed, Jul 11, 2:06 PM
zzag closed D14046: [effects/desktopgrid] Don't change activities.
Wed, Jul 11, 2:06 PM · KWin
zzag requested review of D14046: [effects/desktopgrid] Don't change activities.
Wed, Jul 11, 1:23 PM · KWin
zzag added inline comments to D14044: Simplify getting edid in xrandr backend.
Wed, Jul 11, 10:49 AM · Plasma
zzag updated the diff for D14036: [wayland] Confine pointer to screen geometry.

Check startPos

Wed, Jul 11, 8:22 AM · KWin
zzag abandoned D13456: [wayland] Make it possible to reach screen edges.

See D14036

Wed, Jul 11, 7:58 AM · KWin
zzag commandeered D13456: [wayland] Make it possible to reach screen edges.
Wed, Jul 11, 7:58 AM · KWin
zzag updated the diff for D14036: [wayland] Confine pointer to screen geometry.

Setup screen layout in the test

Wed, Jul 11, 7:47 AM · KWin

Tue, Jul 10

zzag committed R108:91e69e3fbd67: [libkwineffects] Use more std::transform in implementation part (authored by zzag).
[libkwineffects] Use more std::transform in implementation part
Tue, Jul 10, 11:43 PM
zzag closed D14002: [libkwineffects] Use more std::transform in implementation part.
Tue, Jul 10, 11:43 PM · KWin
zzag requested review of D14036: [wayland] Confine pointer to screen geometry.
Tue, Jul 10, 11:36 PM · KWin
zzag added a comment to D13456: [wayland] Make it possible to reach screen edges.

That setup should not be allowed. If you were able to create it, that would be a bug. One of the basic design decisions I did for the input and output handling was to disallow space between screens.

Tue, Jul 10, 5:39 PM · KWin
zzag committed R108:81d851f6aa73: [libkwineffects] Use std::copy (authored by zzag).
[libkwineffects] Use std::copy
Tue, Jul 10, 2:22 PM
zzag closed D14004: [libkwineffects] Use std::copy.
Tue, Jul 10, 2:22 PM · KWin
zzag changed the visibility for D14027: [kwinrules] Added option to enable and disable blur.
Tue, Jul 10, 2:15 PM · KWin
zzag removed a reviewer for D14027: [kwinrules] Added option to enable and disable blur: zzag.

Using KWindowEffects inside of KWin is wrong. Also, it would work only on X11. I think it would be better to add blurBehind(or something like that) property to toplevel and use it later in the blur effect.

Tue, Jul 10, 2:14 PM · KWin
zzag added a comment to D13456: [wayland] Make it possible to reach screen edges.

So, it seems to be a little bit complicated: if there are gaps between screens, p should be bounded by screens()->geometry(). Otherwise, p should be bounded by geometry of the current screen. The problem is the case when pointer moves really fast.

Tue, Jul 10, 1:19 PM · KWin
zzag added a comment to D13456: [wayland] Make it possible to reach screen edges.

I believe updatePosition should do the following:

Tue, Jul 10, 9:45 AM · KWin
zzag added a comment to D13456: [wayland] Make it possible to reach screen edges.

Also, it looks like this code doesn't handle a case when user moves pointer really-really fast. In that case, the pointer can bypass whole screens and end up in offscreen area.

Tue, Jul 10, 8:26 AM · KWin

Mon, Jul 9

zzag added inline comments to D14009: [Plasma PluginLoader] Cache plugins during startup.
Mon, Jul 9, 7:01 PM · Frameworks
zzag requested review of D14004: [libkwineffects] Use std::copy.
Mon, Jul 9, 12:41 PM · KWin
zzag requested review of D14002: [libkwineffects] Use more std::transform in implementation part.
Mon, Jul 9, 12:08 PM · KWin

Sun, Jul 8

zzag updated the summary of D13979: [effects/slide] Clean up.
Sun, Jul 8, 6:00 PM · KWin
zzag requested review of D13979: [effects/slide] Clean up.
Sun, Jul 8, 5:47 PM · KWin

Fri, Jul 6

zzag added a comment to D13927: autotests: Compare doubles to doubles.

Seems Phabricator decided it's the same commit due to being an identical patch?

Fri, Jul 6, 8:49 PM · Plasma
zzag requested review of D13927: autotests: Compare doubles to doubles.
Fri, Jul 6, 8:32 PM · Plasma
zzag added a comment to D13338: [effects] Rewrite the Glide effect.

Ping.

Fri, Jul 6, 5:22 PM · KWin
zzag added a comment to D11198: [libbreezecommon] Add box shadow helper.

If there are serious problems, we still can revert it. Also, there is a chance that we need to notify sysadmins about new dependency.

Fri, Jul 6, 3:02 PM · Plasma
zzag committed R31:5a15e8ed40e1: [kstyle] Refine shadows (authored by zzag).
[kstyle] Refine shadows
Fri, Jul 6, 3:01 PM
zzag committed R31:bffe8faa8706: [libbreezecommon] Add box shadow helper (authored by zzag).
[libbreezecommon] Add box shadow helper
Fri, Jul 6, 3:01 PM
zzag closed D11175: [kstyle] Refine shadows.
Fri, Jul 6, 3:01 PM · Plasma
zzag committed R31:54b75015eda8: [kdecoration] Refine shadows (authored by zzag).
[kdecoration] Refine shadows
Fri, Jul 6, 3:01 PM
zzag closed D11198: [libbreezecommon] Add box shadow helper.
Fri, Jul 6, 3:01 PM · Plasma
zzag closed D11069: [kdecoration] Refine shadows.
Fri, Jul 6, 3:01 PM · Plasma
zzag added a comment to D11198: [libbreezecommon] Add box shadow helper.

Landing it...

Fri, Jul 6, 3:00 PM · Plasma