zzag (Vlad Zahorodnii)
KWin developer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 16 2017, 8:25 AM (110 w, 3 d)
Availability
Available

Recent Activity

Today

zzag added a comment to D26978: [kstyle] Use QX11Info::isCompositingManagerRunning().

monitors compositing manager selections

Wed, Jan 29, 1:59 AM · Plasma
zzag added a reviewer for D26978: [kstyle] Use QX11Info::isCompositingManagerRunning(): hpereiradacosta.
Wed, Jan 29, 1:53 AM · Plasma
zzag requested review of D26978: [kstyle] Use QX11Info::isCompositingManagerRunning().
Wed, Jan 29, 1:51 AM · Plasma

Yesterday

zzag requested review of D26975: s/m_xdgShellSurface/m_xdgShellToplevel/g.
Tue, Jan 28, 10:23 PM · KWin
zzag requested review of D26974: [wayland] Get rid of some duplicated code.
Tue, Jan 28, 10:06 PM · KWin
zzag updated the diff for D26830: [wayland] Honor xdg-toplevel size constraints.

Check window rules only once.

Tue, Jan 28, 9:50 PM · KWin
zzag committed R108:3399a7db8a32: Document AbstractClient::isResize() and AbstractClient::isMove() (authored by zzag).
Document AbstractClient::isResize() and AbstractClient::isMove()
Tue, Jan 28, 8:30 PM
zzag committed R108:c36a5bf42371: Merge branch 'Plasma/5.18' (authored by zzag).
Merge branch 'Plasma/5.18'
Tue, Jan 28, 8:05 PM
zzag committed R108:34fc962ff1a0: Move definition of X11Client::damageNotifyEvent() to x11client.cpp (authored by zzag).
Move definition of X11Client::damageNotifyEvent() to x11client.cpp
Tue, Jan 28, 8:05 PM
zzag committed R108:68ef6bcd7aaa: Rename X11Client::getSyncRequest() to X11Client::syncRequest() (authored by zzag).
Rename X11Client::getSyncRequest() to X11Client::syncRequest()
Tue, Jan 28, 8:05 PM
zzag requested review of D26971: Drop Toplevel::decorationRect().
Tue, Jan 28, 6:50 PM · KWin
zzag committed R108:a073a79a974a: Merge branch 'Plasma/5.18' (authored by zzag).
Merge branch 'Plasma/5.18'
Tue, Jan 28, 4:44 PM
zzag committed R108:bd52b6791e8b: Schedule a decoration repaint when client is resized (authored by zzag).
Schedule a decoration repaint when client is resized
Tue, Jan 28, 4:44 PM
zzag closed D26927: Schedule a decoration repaint when client is resized.
Tue, Jan 28, 4:44 PM · KWin
zzag committed R108:827578577ff9: [decoration] Implement the size property (authored by zzag).
[decoration] Implement the size property
Tue, Jan 28, 4:44 PM
zzag closed D26939: [decoration] Implement the size property.
Tue, Jan 28, 4:44 PM · KWin
zzag committed R129:181f3ecb00ff: Merge branch 'Plasma/5.18' (authored by zzag).
Merge branch 'Plasma/5.18'
Tue, Jan 28, 4:38 PM
zzag committed R129:13e6459a3bae: Add a convenience property to retrieve the size of the decorated client (authored by zzag).
Add a convenience property to retrieve the size of the decorated client
Tue, Jan 28, 4:38 PM
zzag closed D26937: Add a convenience property to retrieve the size of the decorated client.
Tue, Jan 28, 4:38 PM · Plasma
zzag committed R31:cf12bf4a077d: [kstyle] Unregister a shadow when it's destroyed (authored by zzag).
[kstyle] Unregister a shadow when it's destroyed
Tue, Jan 28, 4:12 PM
zzag closed D26966: [kstyle] Unregister a shadow when it's destroyed.
Tue, Jan 28, 4:12 PM · Plasma
zzag closed D26967: [kstyle] Unregister a shadow when it's destroyed.
Tue, Jan 28, 4:12 PM · Plasma
zzag committed R113:120fb3e01f22: [kstyle] Unregister a shadow when it's destroyed (authored by zzag).
[kstyle] Unregister a shadow when it's destroyed
Tue, Jan 28, 4:12 PM
zzag updated the summary of D26967: [kstyle] Unregister a shadow when it's destroyed.
Tue, Jan 28, 4:02 PM · Plasma
zzag updated the diff for D26966: [kstyle] Unregister a shadow when it's destroyed.

Edit summary.

Tue, Jan 28, 4:00 PM · Plasma
zzag updated the diff for D26966: [kstyle] Unregister a shadow when it's destroyed.

Re-title and edit summary.

Tue, Jan 28, 3:53 PM · Plasma
zzag updated the diff for D26967: [kstyle] Unregister a shadow when it's destroyed.

Clean up _shadows upon a shadow emitting QObject::destroyed()

Tue, Jan 28, 3:21 PM · Plasma
zzag added inline comments to D26966: [kstyle] Unregister a shadow when it's destroyed.
Tue, Jan 28, 3:19 PM · Plasma
zzag updated the diff for D26966: [kstyle] Unregister a shadow when it's destroyed.

Connect to QObject::destroyed

Tue, Jan 28, 3:14 PM · Plasma
zzag added a reviewer for D26967: [kstyle] Unregister a shadow when it's destroyed: Plasma.
Tue, Jan 28, 3:02 PM · Plasma
zzag requested review of D26967: [kstyle] Unregister a shadow when it's destroyed.
Tue, Jan 28, 3:02 PM · Plasma
zzag requested review of D26966: [kstyle] Unregister a shadow when it's destroyed.
Tue, Jan 28, 2:59 PM · Plasma
zzag accepted D26960: RFC: [KWindowShadows] Check for X connection.
Tue, Jan 28, 11:46 AM · Frameworks
zzag updated the diff for D26927: Schedule a decoration repaint when client is resized.

Use the newly added sizeChanged signal

Tue, Jan 28, 11:19 AM · KWin
zzag added a comment to D26638: WIP Tablet protocol support.

Is this change actual? We another similar change D26859

Tue, Jan 28, 11:09 AM · KWin
zzag added a reviewer for D26859: Implement the tablet wayland protocol in kwin: davidedmundson.
Tue, Jan 28, 11:02 AM · KWin
zzag accepted D26859: Implement the tablet wayland protocol in kwin.

Please wait for a +1 from @davidedmundson

Tue, Jan 28, 11:01 AM · KWin
zzag accepted D26858: Provide an implementation for the tablet interface.

Code-wise, this change looks good. I don't have a tablet device to test this patch so you may want to wait for a +1 from @davidedmundson.

Tue, Jan 28, 10:53 AM · Frameworks

Mon, Jan 27

zzag accepted D26942: Fix kwin.upd not running if python 2 not installed.
Mon, Jan 27, 3:02 PM · KWin
zzag created P530 (An Untitled Masterwork) in the S1 KDE Community space.
Mon, Jan 27, 2:18 PM
zzag added a comment to D26858: Provide an implementation for the tablet interface.

Looks good to me. There are still many coding style issues. I suggest to run clang-format over individual files in this patch and then adjust the most problematic places (I don't think there are that many).

Mon, Jan 27, 2:07 PM · Frameworks
zzag added inline comments to D26927: Schedule a decoration repaint when client is resized.
Mon, Jan 27, 1:39 PM · KWin
zzag requested review of D26939: [decoration] Implement the size property.
Mon, Jan 27, 1:20 PM · KWin
zzag requested review of D26937: Add a convenience property to retrieve the size of the decorated client.
Mon, Jan 27, 1:02 PM · Plasma
zzag added inline comments to D26927: Schedule a decoration repaint when client is resized.
Mon, Jan 27, 1:00 PM · KWin
zzag created P529 (An Untitled Masterwork) in the S1 KDE Community space.
Mon, Jan 27, 12:28 PM
zzag added inline comments to D26927: Schedule a decoration repaint when client is resized.
Mon, Jan 27, 12:19 PM · KWin
zzag updated the diff for D26927: Schedule a decoration repaint when client is resized.

Schedule a full repaint in markImageSizesDirty

Mon, Jan 27, 12:17 PM · KWin
zzag updated the summary of D26927: Schedule a decoration repaint when client is resized.
Mon, Jan 27, 9:11 AM · KWin

Sun, Jan 26

baberts awarded T10530: Redesign Scene for subsurfaces a Love token.
Sun, Jan 26, 9:20 PM · KWin
zzag retitled D26927: Schedule a decoration repaint when client is resized from Repaint decoration borders when client is resized to Schedule a decoration repaint when client is resized.
Sun, Jan 26, 1:44 PM · KWin
zzag added a comment to D26927: Schedule a decoration repaint when client is resized.

I'm targeting branch Plasma/5.18.

Sun, Jan 26, 1:29 PM · KWin
zzag requested review of D26927: Schedule a decoration repaint when client is resized.
Sun, Jan 26, 1:29 PM · KWin

Sat, Jan 25

zzag committed R108:ad10a2500199: Merge branch 'Plasma/5.18' (authored by zzag).
Merge branch 'Plasma/5.18'
Sat, Jan 25, 9:17 PM
zzag closed D26922: Port away from a deprecated signal.
Sat, Jan 25, 9:17 PM · KWin
zzag committed R108:bc0fbf137d09: Port away from a deprecated signal (authored by zzag).
Port away from a deprecated signal
Sat, Jan 25, 9:17 PM
zzag requested review of D26922: Port away from a deprecated signal.
Sat, Jan 25, 8:36 PM · KWin
zzag added a comment to D26914: [x11] Fix visual artifacts during interactive resize.

This change should also fix screen tearing in Dolphin when it's being resized.

Sat, Jan 25, 1:05 PM · KWin
zzag added a comment to D26914: [x11] Fix visual artifacts during interactive resize.

I know it's terrible, maybe there is another nicer way to fix interactive resizing on X11.

Sat, Jan 25, 12:34 PM · KWin
zzag updated subscribers of D26914: [x11] Fix visual artifacts during interactive resize.

@fredrik If you have time, could you please take a look at this change?

Sat, Jan 25, 12:33 PM · KWin
zzag updated the summary of D26914: [x11] Fix visual artifacts during interactive resize.
Sat, Jan 25, 12:29 PM · KWin
zzag added a comment to D26914: [x11] Fix visual artifacts during interactive resize.

I wish we could do xcb_composite_allocate_window_pixmap(xcb_connection_t *connection, xcb_window_t window); or something along the line in doResizeSync().

Sat, Jan 25, 12:26 PM · KWin
zzag added a comment to D26914: [x11] Fix visual artifacts during interactive resize.

Before:

Sat, Jan 25, 12:25 PM · KWin
zzag requested review of D26914: [x11] Fix visual artifacts during interactive resize.
Sat, Jan 25, 12:24 PM · KWin
zzag added a comment to D26500: Change project name to "KWin".

Now of course the most correct pronunciation is "Kay win." :) "Quinn" would require it to be spelled "Kwin" :)

Sat, Jan 25, 11:29 AM · KWin
zzag closed D26500: Change project name to "KWin".
Sat, Jan 25, 1:05 AM · KWin
zzag committed R108:03ae441e23ef: Change project name to "KWin" (authored by zzag).
Change project name to "KWin"
Sat, Jan 25, 1:05 AM
zzag added a dependency for D26909: [effects/snaphelper] Use windowFrameGeometryChanged: D26864: Expose frameGeometryChanged signal to effects.
Sat, Jan 25, 12:52 AM · KWin
zzag added a dependent revision for D26864: Expose frameGeometryChanged signal to effects: D26909: [effects/snaphelper] Use windowFrameGeometryChanged.
Sat, Jan 25, 12:52 AM · KWin
zzag requested review of D26909: [effects/snaphelper] Use windowFrameGeometryChanged.
Sat, Jan 25, 12:52 AM · KWin
zzag added a dependent revision for D26864: Expose frameGeometryChanged signal to effects: D26908: [effects/desktopgrid] Use windowFrameGeometryChanged.
Sat, Jan 25, 12:50 AM · KWin
zzag added a dependency for D26908: [effects/desktopgrid] Use windowFrameGeometryChanged: D26864: Expose frameGeometryChanged signal to effects.
Sat, Jan 25, 12:50 AM · KWin
zzag requested review of D26908: [effects/desktopgrid] Use windowFrameGeometryChanged.
Sat, Jan 25, 12:50 AM · KWin
zzag added a dependent revision for D26864: Expose frameGeometryChanged signal to effects: D26907: [effects/presentwindows] Use windowFrameGeometryChanged.
Sat, Jan 25, 12:48 AM · KWin
zzag added a dependency for D26907: [effects/presentwindows] Use windowFrameGeometryChanged: D26864: Expose frameGeometryChanged signal to effects.
Sat, Jan 25, 12:48 AM · KWin
zzag requested review of D26907: [effects/presentwindows] Use windowFrameGeometryChanged.
Sat, Jan 25, 12:48 AM · KWin
zzag added a dependent revision for D26864: Expose frameGeometryChanged signal to effects: D26906: [effects/thumbnailaside] Use windowFrameGeometryChanged.
Sat, Jan 25, 12:45 AM · KWin
zzag added a dependency for D26906: [effects/thumbnailaside] Use windowFrameGeometryChanged: D26864: Expose frameGeometryChanged signal to effects.
Sat, Jan 25, 12:45 AM · KWin
zzag requested review of D26906: [effects/thumbnailaside] Use windowFrameGeometryChanged.
Sat, Jan 25, 12:45 AM · KWin
zzag added a dependency for D26905: [effects/maximize] Use windowFrameGeometryChanged: D26864: Expose frameGeometryChanged signal to effects.
Sat, Jan 25, 12:41 AM · KWin
zzag added a dependent revision for D26864: Expose frameGeometryChanged signal to effects: D26905: [effects/maximize] Use windowFrameGeometryChanged.
Sat, Jan 25, 12:41 AM · KWin
zzag requested review of D26905: [effects/maximize] Use windowFrameGeometryChanged.
Sat, Jan 25, 12:40 AM · KWin

Fri, Jan 24

zzag updated subscribers of T12437: Investigate Dynamic Disabling of Floating Docks/Panels screen gap.

and I've just seen you commented on the Latte page on KDE Store, I guess you use Latte,

Fri, Jan 24, 8:55 PM · Latte Dock
zzag added inline comments to D26894: Enable publication of API dox on api.kde.org.
Fri, Jan 24, 12:36 PM · Plasma
zzag added a comment to D26894: Enable publication of API dox on api.kde.org.

So, is kdecoration still a non-deprecated lib?

Fri, Jan 24, 12:33 PM · Plasma
zzag committed R31:1e04ce2e2c99: Update my last name (authored by zzag).
Update my last name
Fri, Jan 24, 1:08 AM
zzag committed R127:7ce8963e4bae: Update my last name (authored by zzag).
Update my last name
Fri, Jan 24, 1:08 AM

Thu, Jan 23

zzag committed R108:6db34379b5f9: Merge branch 'Plasma/5.18' (authored by zzag).
Merge branch 'Plasma/5.18'
Thu, Jan 23, 11:15 PM
zzag committed R108:d079f5daed4f: [wayland] Keep the opposite corner still when resizing a window (authored by zzag).
[wayland] Keep the opposite corner still when resizing a window
Thu, Jan 23, 11:15 PM
zzag closed D26886: [wayland] Keep the opposite corner still when resizing a window.
Thu, Jan 23, 11:15 PM · KWin
zzag committed R108:72ca9268cef8: [wayland] Provide correct input geometry for client-side decorated clients (authored by zzag).
[wayland] Provide correct input geometry for client-side decorated clients
Thu, Jan 23, 11:15 PM
zzag closed D26716: [wayland] Provide correct input geometry for client-side decorated clients.
Thu, Jan 23, 11:15 PM · KWin
zzag added a comment to T12578: Expose stackingOrder as read-only Q_PROPERTY in kwin/x11client.h.

sessionStackingOrder() contains restored stacking order. Could you please explain why you need to have access to the Client's stacking order?

Thu, Jan 23, 10:13 PM · KWin
zzag requested review of D26886: [wayland] Keep the opposite corner still when resizing a window.
Thu, Jan 23, 10:01 PM · KWin
zzag requested review of D26883: Turn AbstractClient::move() into a convenience method.
Thu, Jan 23, 8:17 PM · KWin
zzag added a comment to D26864: Expose frameGeometryChanged signal to effects.

On a related note, can you make sure the properties of EffectWindow are up to date with these geometry changes. It only has 2 geometries, which isn't nearly enough!

Thu, Jan 23, 1:03 PM · KWin
zzag requested changes to D26858: Provide an implementation for the tablet interface.
Thu, Jan 23, 12:58 PM · Frameworks
zzag requested changes to D26859: Implement the tablet wayland protocol in kwin.
Thu, Jan 23, 12:30 PM · KWin
zzag updated the diff for D26863: Introduce Toplevel::frameGeometryChanged signal.

Edit description.

Thu, Jan 23, 10:56 AM · KWin
zzag committed R108:4d161bec4835: Use less Toplevel::isClient() (authored by zzag).
Use less Toplevel::isClient()
Thu, Jan 23, 10:29 AM