zzag (Vlad Zagorodniy)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Dec 16 2017, 8:25 AM (82 w, 2 d)
Availability
Available

Recent Activity

Yesterday

zzag added inline comments to D22295: Remove scene check on repaints.
Mon, Jul 15, 2:56 PM · KWin
zzag added a comment to D22474: Install KPackages with kpackage_install_package.

how is having only one directory and one CMakeLists.txt better?

Mon, Jul 15, 2:35 PM · KWin
zzag added a comment to D22474: Install KPackages with kpackage_install_package.

Is it possible to use kpackage_install_package inside of each effect's CMakeLists.txt file? The problem is that now "toplevel" effect directories contain only one directory - package.

Mon, Jul 15, 2:31 PM · KWin
zzag committed R108:60ef45164363: Merge branch 'Plasma/5.12' into Plasma/5.16 (authored by zzag).
Merge branch 'Plasma/5.12' into Plasma/5.16
Mon, Jul 15, 2:02 PM
zzag committed R108:4637ff2ac3a7: Merge branch 'Plasma/5.16' (authored by zzag).
Merge branch 'Plasma/5.16'
Mon, Jul 15, 2:02 PM
zzag committed R108:d948d247fe43: Don't crash when highlighted tabbox client is closed (authored by zzag).
Don't crash when highlighted tabbox client is closed
Mon, Jul 15, 2:02 PM
zzag added inline comments to D22295: Remove scene check on repaints.
Mon, Jul 15, 2:00 PM · KWin
zzag added inline comments to D22295: Remove scene check on repaints.
Mon, Jul 15, 1:32 PM · KWin
zzag added inline comments to D22295: Remove scene check on repaints.
Mon, Jul 15, 1:25 PM · KWin
zzag added inline comments to D22195: Split Compositor class in Wayland and X11 child classes.
Mon, Jul 15, 1:19 PM · KWin
zzag added inline comments to D22195: Split Compositor class in Wayland and X11 child classes.
Mon, Jul 15, 12:38 PM · KWin
zzag updated the summary of D19414: [wayland] Implement maximize rules.
Mon, Jul 15, 9:35 AM · KWin

Sun, Jul 14

zzag added a comment to D22452: Fix text color in non-selected tabs in Firefox.

We should not style server-side decorated Firefox windows. They are fine.

Sun, Jul 14, 7:21 PM · Plasma
zzag added a comment to D22452: Fix text color in non-selected tabs in Firefox.

I'm not a Breeze GTK maintainer or developer, but perhaps you need to create separate folder for application specific styles, e.g.

Sun, Jul 14, 9:01 AM · Plasma

Sat, Jul 13

zzag added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

I already played with ColumnLimit and all other options from the docs and various sources. IMO the result is disappointing and clang-format is not capable to do things right :-(

Sat, Jul 13, 4:31 PM
zzag edited reviewers for D22418: wayland: make automatic backend selection truly automatic, added: KWin; removed: zzag.
Sat, Jul 13, 10:47 AM · KWin

Thu, Jul 11

zzag added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

Will formatter ruin beautiful multi-line formatting into single line?

Thu, Jul 11, 8:07 PM

Wed, Jul 10

zzag updated the summary of D22388: Fix case-sensitivity typo in libinput configuration function.
Wed, Jul 10, 9:18 PM · KWin
zzag committed R108:09f2d95a9ccf: Don't use deprecated QDesktopWidget (authored by zzag).
Don't use deprecated QDesktopWidget
Wed, Jul 10, 7:58 PM
zzag committed R108:28a4337ad5d2: Don't use deprecated toAscii() method (authored by zzag).
Don't use deprecated toAscii() method
Wed, Jul 10, 7:58 PM
zzag closed D22379: Don't use deprecated QDesktopWidget.
Wed, Jul 10, 7:58 PM · KWin
zzag closed D22374: Don't use deprecated toAscii() method.
Wed, Jul 10, 7:58 PM · KWin
zzag committed R108:4f76e5f6c5a5: Don't use deprecated QPalette::background() (authored by zzag).
Don't use deprecated QPalette::background()
Wed, Jul 10, 7:58 PM
zzag closed D22373: Don't use deprecated QPalette::background().
Wed, Jul 10, 7:58 PM · KWin
zzag committed R108:2b3e679b0f74: Don't use deprecated QAbstractItemModel::reset() (authored by zzag).
Don't use deprecated QAbstractItemModel::reset()
Wed, Jul 10, 7:58 PM
zzag closed D22372: Don't use deprecated QAbstractItemModel::reset().
Wed, Jul 10, 7:58 PM · KWin
zzag updated the diff for D22379: Don't use deprecated QDesktopWidget.

Don't use availableGeometry.

Wed, Jul 10, 2:43 PM · KWin
zzag added inline comments to D22379: Don't use deprecated QDesktopWidget.
Wed, Jul 10, 2:33 PM · KWin
zzag added inline comments to D22379: Don't use deprecated QDesktopWidget.
Wed, Jul 10, 2:12 PM · KWin
zzag requested review of D22379: Don't use deprecated QDesktopWidget.
Wed, Jul 10, 2:12 PM · KWin
zzag requested review of D22374: Don't use deprecated toAscii() method.
Wed, Jul 10, 1:06 PM · KWin
zzag requested review of D22373: Don't use deprecated QPalette::background().
Wed, Jul 10, 12:47 PM · KWin
zzag requested review of D22372: Don't use deprecated QAbstractItemModel::reset().
Wed, Jul 10, 12:38 PM · KWin
zzag updated the summary of D22371: Run clang-tidy with modernize-use-override check.
Wed, Jul 10, 11:04 AM · KWin
zzag added a comment to D22371: Run clang-tidy with modernize-use-override check.
Wed, Jul 10, 10:53 AM · KWin
zzag requested review of D22371: Run clang-tidy with modernize-use-override check.
Wed, Jul 10, 10:52 AM · KWin
zzag added inline comments to D22195: Split Compositor class in Wayland and X11 child classes.
Wed, Jul 10, 10:25 AM · KWin
zzag added a comment to D22195: Split Compositor class in Wayland and X11 child classes.

Will support properties stay in the Compositor class?

Wed, Jul 10, 9:20 AM · KWin
zzag committed R108:50c89d485870: Fix -Wdeprecated-copy (authored by zzag).
Fix -Wdeprecated-copy
Wed, Jul 10, 9:08 AM
zzag committed R108:cccb3456f302: Use QColor::darker/lighter instead of QColor::dark/light (authored by zzag).
Use QColor::darker/lighter instead of QColor::dark/light
Wed, Jul 10, 9:07 AM
zzag closed D22361: Fix -Wdeprecated-copy.
Wed, Jul 10, 9:07 AM · KWin
zzag closed D22360: Use QColor::darker/lighter instead of QColor::dark/light.
Wed, Jul 10, 9:07 AM · KWin
zzag committed R108:0be5bc45a717: Don't use deprecated QAbstractItemModel::setRoleNames (authored by zzag).
Don't use deprecated QAbstractItemModel::setRoleNames
Wed, Jul 10, 9:07 AM
zzag committed R108:5e0e708a769e: Port away from deprecated QImage::byteCount (authored by zzag).
Port away from deprecated QImage::byteCount
Wed, Jul 10, 9:07 AM
zzag closed D22358: Don't use deprecated QAbstractItemModel::setRoleNames.
Wed, Jul 10, 9:07 AM · KWin
zzag closed D22355: Port away from deprecated QImage::byteCount.
Wed, Jul 10, 9:07 AM · KWin

Tue, Jul 9

zzag requested review of D22361: Fix -Wdeprecated-copy.
Tue, Jul 9, 10:49 PM · KWin
zzag updated the diff for D22360: Use QColor::darker/lighter instead of QColor::dark/light.

I missed one.

Tue, Jul 9, 10:19 PM · KWin
zzag requested review of D22360: Use QColor::darker/lighter instead of QColor::dark/light.
Tue, Jul 9, 10:17 PM · KWin
zzag committed R108:4e5d3d0010a0: Port away from QRegion::rects (authored by zzag).
Port away from QRegion::rects
Tue, Jul 9, 10:03 PM
zzag closed D22353: Port away from QRegion::rects.
Tue, Jul 9, 10:03 PM · KWin
zzag committed R108:e839c7067ee9: Port away from deprecated Qt::escape (authored by zzag).
Port away from deprecated Qt::escape
Tue, Jul 9, 10:00 PM
zzag closed D22356: Port away from deprecated Qt::escape.
Tue, Jul 9, 10:00 PM · KWin
zzag requested review of D22358: Don't use deprecated QAbstractItemModel::setRoleNames.
Tue, Jul 9, 9:57 PM · KWin
zzag committed R108:d0865f2163dc: Fix -Wredundant-move (authored by zzag).
Fix -Wredundant-move
Tue, Jul 9, 9:31 PM
zzag closed D22357: Fix -Wredundant-move.
Tue, Jul 9, 9:31 PM · KWin
zzag requested review of D22357: Fix -Wredundant-move.
Tue, Jul 9, 9:30 PM · KWin
zzag requested review of D22356: Port away from deprecated Qt::escape.
Tue, Jul 9, 9:25 PM · KWin
zzag requested review of D22355: Port away from deprecated QImage::byteCount.
Tue, Jul 9, 9:16 PM · KWin
zzag committed R108:c7639fd7edf5: Port away from deprecated headers (authored by zzag).
Port away from deprecated headers
Tue, Jul 9, 9:04 PM
zzag closed D22351: Port away from deprecated headers.
Tue, Jul 9, 9:04 PM · KWin
zzag committed R108:927f579df9db: Port away from deprecated qSort function (authored by zzag).
Port away from deprecated qSort function
Tue, Jul 9, 9:01 PM
zzag closed D22354: Port away from deprecated qSort function.
Tue, Jul 9, 9:01 PM · KWin
zzag requested review of D22354: Port away from deprecated qSort function.
Tue, Jul 9, 8:52 PM · KWin
zzag requested review of D22353: Port away from QRegion::rects.
Tue, Jul 9, 8:47 PM · KWin
zzag updated the test plan for D22351: Port away from deprecated headers.
Tue, Jul 9, 7:44 PM · KWin
zzag added a comment to D22351: Port away from deprecated headers.

Relevant resources:

Tue, Jul 9, 7:32 PM · KWin
zzag requested review of D22351: Port away from deprecated headers.
Tue, Jul 9, 7:31 PM · KWin
zzag updated the diff for D19414: [wayland] Implement maximize rules.

Rebase.

Tue, Jul 9, 6:37 PM · KWin
zzag updated the diff for D19413: [wayland] Implement size and position window rules.

Better wording in a comment.

Tue, Jul 9, 6:36 PM · KWin
zzag added a comment to D22292: drm: Save scaling and position of displays at shutdown.

In the Drm backend still a code path exists to read output configuration from a KWin specific configuration file (for Plasma Mobile I believe). That is being used here. However the main way to configure outputs is through KScreen interface and the idea was to more to remove the alternative code path instead of expanding its usage.

An alternative approach to solving the flicker would be to delay showing the first frame until KScreen has provided the config (or a timeout occurs). This would then also work if a screen has been disconnected in between. However we could still use this patch here as a flicker fix in between.

Tue, Jul 9, 6:33 PM · KWin
zzag added a comment to D22292: drm: Save scaling and position of displays at shutdown.

If Roman is okay with this change, feel free to push it.

Tue, Jul 9, 6:28 PM · KWin
zzag updated the diff for D19414: [wayland] Implement maximize rules.

Adjust the patch to recent ShellClient changes.

Tue, Jul 9, 6:22 PM · KWin
zzag updated the diff for D19413: [wayland] Implement size and position window rules.

Adjust to recent ShellClient changes.

Tue, Jul 9, 5:58 PM · KWin
zzag added a comment to D22342: Fix potential lockups with swap events.

Hmm, so m_bufferSwapPending can be false when bufferSwapComplete is called, right?

Tue, Jul 9, 4:48 PM · KWin
zzag committed R108:b18351669af9: [colorcorrection] Introduce toggle Night Color shortcut (authored by zzag).
[colorcorrection] Introduce toggle Night Color shortcut
Tue, Jul 9, 3:43 PM
zzag closed D22287: [colorcorrection] Introduce toggle Night Color shortcut.
Tue, Jul 9, 3:43 PM · KWin
zzag updated the diff for D22287: [colorcorrection] Introduce toggle Night Color shortcut.

Use bool instead of int in showStatusOsd.

Tue, Jul 9, 2:45 PM · KWin
zzag updated the diff for D22287: [colorcorrection] Introduce toggle Night Color shortcut.

Show an OSD when the active state is toggled.

Tue, Jul 9, 2:43 PM · KWin
zzag added a comment to D22287: [colorcorrection] Introduce toggle Night Color shortcut.

This put would plasmashell as a dependency of kwin. I'd rather go with using the internal osd service. Once we finish porting our QPA away from Wayland, the OSD service should become available on X11.

Tue, Jul 9, 2:14 PM · KWin
zzag added a comment to D22287: [colorcorrection] Introduce toggle Night Color shortcut.

We can display an OSD on Wayland, but not on X11.

Tue, Jul 9, 2:01 PM · KWin
zzag abandoned D22193: [effects] Mark effect classes as final.

Given that I'm not insisting on this change and it got slight resistance, I'll abandon the patch.

Tue, Jul 9, 1:00 PM · KWin
zzag added a comment to D22193: [effects] Mark effect classes as final.

You can't subclass an effect by accident.

Tue, Jul 9, 12:48 PM · KWin
zzag added a comment to D22193: [effects] Mark effect classes as final.

You can't subclass an effect by accident.

Tue, Jul 9, 12:37 PM · KWin
zzag committed R108:99abfe4e2893: [wayland] Discard Force Temporarily rules for shell clients (authored by zzag).
[wayland] Discard Force Temporarily rules for shell clients
Tue, Jul 9, 12:16 PM
zzag committed R108:6f7bea3acdfe: [wayland] Make clients with forced minimize state unminimizeable (authored by zzag).
[wayland] Make clients with forced minimize state unminimizeable
Tue, Jul 9, 12:16 PM
zzag closed D18494: [wayland] Discard Force Temporarily rules for shell clients.
Tue, Jul 9, 12:16 PM · KWin
zzag closed D18496: [wayland] Make clients with forced minimize state unminimizeable.
Tue, Jul 9, 12:16 PM · KWin
zzag committed R108:18844f59259b: [wayland] Apply window rules only to xdg-shell clients (authored by zzag).
[wayland] Apply window rules only to xdg-shell clients
Tue, Jul 9, 12:16 PM
zzag closed D19411: [wayland] Apply window rules only to xdg-shell clients.
Tue, Jul 9, 12:16 PM · KWin
zzag committed R108:be48d36349e5: [autotests] Rewrite testShellClientRules (authored by zzag).
[autotests] Rewrite testShellClientRules
Tue, Jul 9, 12:16 PM
zzag closed D18464: [autotests] Rewrite testShellClientRules.
Tue, Jul 9, 12:16 PM · KWin
zzag added a comment to D18496: [wayland] Make clients with forced minimize state unminimizeable.
Tue, Jul 9, 11:38 AM · KWin
zzag added a comment to D22193: [effects] Mark effect classes as final.

If there are no objections, I'm going to push it.

Tue, Jul 9, 11:37 AM · KWin
zzag added inline comments to D22195: Split Compositor class in Wayland and X11 child classes.
Tue, Jul 9, 9:44 AM · KWin
zzag accepted D18185: Rework Client fullscreen control.
Tue, Jul 9, 9:34 AM · KWin
zzag retitled D22337: Fix check for SCHED_RESET_ON_FORK feature in clean build from fix check for SCHED_RESET_ON_FORK feature in clean build to Fix check for SCHED_RESET_ON_FORK feature in clean build.
Tue, Jul 9, 8:27 AM · KWin

Mon, Jul 8

zzag accepted D18157: Remove Client fullscreen hack.

Argh, never mind. Those patches are already in master.

Mon, Jul 8, 6:06 PM · KWin
zzag added a comment to D18157: Remove Client fullscreen hack.

The patch looks okay, but it still depends on the coding style patches.

Mon, Jul 8, 5:09 PM · KWin
zzag committed R108:3e1b61664224: Merge branch 'Plasma/5.16' (authored by zzag).
Merge branch 'Plasma/5.16'
Mon, Jul 8, 9:46 AM