zzag (Vlad Zagorodniy)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 16 2017, 8:25 AM (18 w, 1 d)
Availability
Available

Recent Activity

Today

zzag added a comment to D12452: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer.

On X kwin doesn't do any scaling s_virtualScreenScale will always be 1.

Sun, Apr 22, 5:56 PM · KWin
zzag added a comment to D12452: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer.

And this is how Kickoff looks when screen is scaled (on X11)

Sun, Apr 22, 5:39 PM · KWin
zzag added a comment to D12452: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer.

No, it fixes only ::blitFromFramebuffer.

Sun, Apr 22, 5:30 PM · KWin
zzag retitled D12452: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer from [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 to [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer.
Sun, Apr 22, 4:17 PM · KWin
zzag added a reviewer for D12452: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer: fredrik.
Sun, Apr 22, 4:15 PM · KWin
zzag updated the test plan for D12452: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer.
Sun, Apr 22, 4:12 PM · KWin
zzag requested review of D12452: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer.
Sun, Apr 22, 4:11 PM · KWin
zzag added a comment to T7914: Use a prettier background for the lock & login screens.

Would this slow down the bootup process?

Sun, Apr 22, 2:46 PM · VDG
zzag added a comment to D12404: Improve tooltips behavior.

Forget what I said in inline comments, that was wrong.

Sun, Apr 22, 2:42 PM · KWin
zzag added inline comments to D12404: Improve tooltips behavior.
Sun, Apr 22, 2:12 PM · KWin
zzag added inline comments to D12404: Improve tooltips behavior.
Sun, Apr 22, 2:09 PM · KWin
zzag updated the diff for D11198: [libbreezecommon] add box shadow helper.

Fix invalid read of size 1

Sun, Apr 22, 11:43 AM · Plasma

Fri, Apr 20

zzag added inline comments to D12388: Output device color curves correction.
Fri, Apr 20, 8:10 PM · Frameworks
zzag committed R108:48d30fa4fe17: [effects/presentwindows] Fix -Wint-in-bool-context (authored by zzag).
[effects/presentwindows] Fix -Wint-in-bool-context
Fri, Apr 20, 6:19 PM
zzag closed D12209: [effects/presentwindows] Fix -Wint-in-bool-context.
Fri, Apr 20, 6:19 PM · KWin
zzag committed R108:3fcce012c02f: [effects/minimizeanimation] Don't reset timeline (authored by zzag).
[effects/minimizeanimation] Don't reset timeline
Fri, Apr 20, 6:16 PM
zzag closed D12254: [effects/minimizeanimation] Don't reset timeline.
Fri, Apr 20, 6:16 PM · KWin
zzag committed R108:913f92ae9aa8: [effects/magiclamp] Don't reset timeline (authored by zzag).
[effects/magiclamp] Don't reset timeline
Fri, Apr 20, 6:11 PM
zzag closed D12253: [effects/magiclamp] Don't reset timeline.
Fri, Apr 20, 6:11 PM · KWin
zzag committed R108:75fff1761264: Fix unused param warnings (authored by zzag).
Fix unused param warnings
Fri, Apr 20, 6:07 PM
zzag closed D12208: Fix unused param warnings.
Fri, Apr 20, 6:07 PM · KWin

Wed, Apr 18

zzag added inline comments to D12322: Add environment variable to force sw cursor.
Wed, Apr 18, 6:34 PM · KWin

Tue, Apr 17

zzag added a comment to D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin.

This is master-only code, right?

Tue, Apr 17, 1:21 PM · Plasma
zzag updated subscribers of D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin.

Do you have any objections to bumping minimum required version of KF5FrameworkIntegration?

Tue, Apr 17, 11:49 AM · Plasma
zzag added a comment to D12277: Fix build with Qt 4.

OK, nvmd.

Tue, Apr 17, 11:30 AM · Plasma
zzag added a comment to D12277: Fix build with Qt 4.

Oh, God, I forgot to check Q_CC_CLANG in Qt 4.

Tue, Apr 17, 11:18 AM · Plasma
zzag added a comment to D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin.

Don't you need to raise the requirement to a new Frameworks version, or #ifdefs if it's not possible (as it should probably be coordinated with the rest of the Plasma team)?

Tue, Apr 17, 11:00 AM · Plasma

Mon, Apr 16

zzag added inline comments to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Mon, Apr 16, 11:31 PM · Plasma
zzag added a comment to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..

These defaults are really big, especially height. What about folks with 1366x768 screen resolution? http://gs.statcounter.com/screen-resolution-stats/desktop/worldwide

Mon, Apr 16, 11:10 PM · Plasma
zzag added a comment to T8497: Banner for 18.04 Website, social media.

Also, I would like to point out that most people read from left to right, so maybe Kubuntu should be on the left hand side ...And for me, that's really weird to see "Kubuntu" label on the right hand side.

Mon, Apr 16, 9:38 PM · Kubuntu
zzag added a comment to T8497: Banner for 18.04 Website, social media.

Mon, Apr 16, 9:32 PM · Kubuntu
zzag added a dependency for D12263: [kstyle] don't suppress deprecation warnings: D12261: [kstyle] drop QStyleOptionFrameV3 in Qt 5 style plugin.
Mon, Apr 16, 8:34 PM · Plasma
zzag added a dependent revision for D12261: [kstyle] drop QStyleOptionFrameV3 in Qt 5 style plugin: D12263: [kstyle] don't suppress deprecation warnings.
Mon, Apr 16, 8:34 PM · Plasma
zzag added dependencies for D12263: [kstyle] don't suppress deprecation warnings: D12262: [kstyle] drop QStyleOptionDockWidgetV2 in Qt 5 style plugin, D12260: [kstyle] drop QStyleOptionFrameV2 in Qt 5 style plugin, D12259: [kstyle] drop QStyleOptionViewItemV4 in Qt 5 style plugin, D12258: [kstyle] drop QStyleOptionTabWidgetFrameV2 in Qt 5 style plugin, D12257: [kstyle] drop QStyleOptionTabV3 in Qt 5 style plugin, D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin.
Mon, Apr 16, 8:33 PM · Plasma
zzag added a dependent revision for D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin: D12263: [kstyle] don't suppress deprecation warnings.
Mon, Apr 16, 8:33 PM · Plasma
zzag added a dependent revision for D12258: [kstyle] drop QStyleOptionTabWidgetFrameV2 in Qt 5 style plugin: D12263: [kstyle] don't suppress deprecation warnings.
Mon, Apr 16, 8:33 PM · Plasma
zzag added a dependent revision for D12257: [kstyle] drop QStyleOptionTabV3 in Qt 5 style plugin: D12263: [kstyle] don't suppress deprecation warnings.
Mon, Apr 16, 8:33 PM · Plasma
zzag added a dependent revision for D12260: [kstyle] drop QStyleOptionFrameV2 in Qt 5 style plugin: D12263: [kstyle] don't suppress deprecation warnings.
Mon, Apr 16, 8:33 PM · Plasma
zzag added a dependent revision for D12259: [kstyle] drop QStyleOptionViewItemV4 in Qt 5 style plugin: D12263: [kstyle] don't suppress deprecation warnings.
Mon, Apr 16, 8:33 PM · Plasma
zzag added a dependent revision for D12262: [kstyle] drop QStyleOptionDockWidgetV2 in Qt 5 style plugin: D12263: [kstyle] don't suppress deprecation warnings.
Mon, Apr 16, 8:33 PM · Plasma
zzag claimed T8056: kstyle/CMakeLists.txt: -Wno-deprecated-declarations is incompatible with MSVC.
Mon, Apr 16, 8:18 PM · Breeze
zzag added a comment to T8056: kstyle/CMakeLists.txt: -Wno-deprecated-declarations is incompatible with MSVC.

D12263 should fix that.

Mon, Apr 16, 8:17 PM · Breeze
zzag requested review of D12263: [kstyle] don't suppress deprecation warnings.
Mon, Apr 16, 8:17 PM · Plasma
zzag requested review of D12262: [kstyle] drop QStyleOptionDockWidgetV2 in Qt 5 style plugin.
Mon, Apr 16, 8:16 PM · Plasma
zzag requested review of D12261: [kstyle] drop QStyleOptionFrameV3 in Qt 5 style plugin.
Mon, Apr 16, 8:16 PM · Plasma
zzag requested review of D12260: [kstyle] drop QStyleOptionFrameV2 in Qt 5 style plugin.
Mon, Apr 16, 8:15 PM · Plasma
zzag requested review of D12259: [kstyle] drop QStyleOptionViewItemV4 in Qt 5 style plugin.
Mon, Apr 16, 8:15 PM · Plasma
zzag requested review of D12258: [kstyle] drop QStyleOptionTabWidgetFrameV2 in Qt 5 style plugin.
Mon, Apr 16, 8:14 PM · Plasma
zzag requested review of D12257: [kstyle] drop QStyleOptionTabV3 in Qt 5 style plugin.
Mon, Apr 16, 8:14 PM · Plasma
zzag requested review of D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin.
Mon, Apr 16, 8:13 PM · Plasma
zzag updated the summary of D12254: [effects/minimizeanimation] Don't reset timeline.
Mon, Apr 16, 5:56 PM · KWin
zzag added a comment to T8056: kstyle/CMakeLists.txt: -Wno-deprecated-declarations is incompatible with MSVC.

We could disable deprecated warnings only for GCC, Clang, I guess.

Mon, Apr 16, 5:46 PM · Breeze
zzag requested review of D12254: [effects/minimizeanimation] Don't reset timeline.
Mon, Apr 16, 5:16 PM · KWin
zzag updated the summary of D12253: [effects/magiclamp] Don't reset timeline.
Mon, Apr 16, 5:15 PM · KWin
zzag updated the diff for D12253: [effects/magiclamp] Don't reset timeline.

Wrong diff.

Mon, Apr 16, 5:13 PM · KWin
zzag added a comment to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..

What if sizeHint() returns a size which is bigger than screen size? Please use QSize::boundedTo.

Mon, Apr 16, 5:07 PM · Plasma
zzag requested review of D12253: [effects/magiclamp] Don't reset timeline.
Mon, Apr 16, 5:00 PM · KWin
zzag reclaimed D12055: Remove border around menubars.

Oh, I misunderstood you.

Mon, Apr 16, 4:25 PM · Plasma

Sun, Apr 15

zzag committed R108:c44788889c50: [platforms/virtual] Make VirtualOutput non-copyable (authored by zzag).
[platforms/virtual] Make VirtualOutput non-copyable
Sun, Apr 15, 11:49 PM
zzag closed D12214: [platforms/virtual] Make VirtualOutput non-copyable.
Sun, Apr 15, 11:49 PM · KWin
zzag updated the diff for D12214: [platforms/virtual] Make VirtualOutput non-copyable.

Delete private access modifier.

Sun, Apr 15, 11:48 PM · KWin
zzag added a comment to D12214: [platforms/virtual] Make VirtualOutput non-copyable.

Thanks for the patch. Forgot to clean this up. Just one of the two "private" labels in the header file (the above one) is enough.

Sun, Apr 15, 11:43 PM · KWin
zzag abandoned D12055: Remove border around menubars.

In fact, we've got an open request to add this line to the Breeze theme for Qt apps...

https://bugs.kde.org/show_bug.cgi?id=386306

Sun, Apr 15, 11:37 PM · Plasma
zzag retitled D12055: Remove border around menubars from Delete border around menubars to Remove border around menubars.
Sun, Apr 15, 8:12 PM · Plasma
zzag added a comment to D11909: properly use kpackage_install_package.

Ping.

Sun, Apr 15, 7:08 PM · Plasma
zzag added a comment to D12055: Remove border around menubars.

Ping.

Sun, Apr 15, 7:08 PM · Plasma
zzag added inline comments to D12208: Fix unused param warnings.
Sun, Apr 15, 6:55 PM · KWin
zzag updated the diff for D12208: Fix unused param warnings.

Delete unused windowShape param.

Sun, Apr 15, 6:54 PM · KWin
zzag added a comment to D10811: [scenes/opengl] fix overlapping shadow tiles.

Friendly ping.

Sun, Apr 15, 5:57 PM · KWin

Sat, Apr 14

zzag requested review of D12214: [platforms/virtual] Make VirtualOutput non-copyable.
Sat, Apr 14, 9:07 PM · KWin
zzag requested review of D12209: [effects/presentwindows] Fix -Wint-in-bool-context.
Sat, Apr 14, 8:11 PM · KWin
zzag requested review of D12208: Fix unused param warnings.
Sat, Apr 14, 7:56 PM · KWin

Thu, Apr 12

zzag committed R108:3224202f1838: [effects] Use multisampling (authored by zzag).
[effects] Use multisampling
Thu, Apr 12, 12:32 AM
zzag committed R108:0b3c4fd77e18: [scenes/opengl] Render scene into a multisampled render buffer (authored by zzag).
[scenes/opengl] Render scene into a multisampled render buffer
Thu, Apr 12, 12:32 AM
zzag committed R108:6d91f8e71465: [libkwineffects] Fix GLRenderTarget::blitFromFramebuffer (authored by zzag).
[libkwineffects] Fix GLRenderTarget::blitFromFramebuffer
Thu, Apr 12, 12:32 AM
zzag committed R108:d064a7faa254: [libkwineffects] Use renderbuffers as render targets (authored by zzag).
[libkwineffects] Use renderbuffers as render targets
Thu, Apr 12, 12:32 AM
zzag committed R108:360bca07d226: [libkwineffects] Fix coding style in GLRenderTarget (authored by zzag).
[libkwineffects] Fix coding style in GLRenderTarget
Thu, Apr 12, 12:32 AM
zzag committed R108:93a724a70a3c: [libkwineffects] Delete unused stuff in GLRenderTarget (authored by zzag).
[libkwineffects] Delete unused stuff in GLRenderTarget
Thu, Apr 12, 12:32 AM
zzag committed R108:56b2d3ce4f77: [libkwineffects] Add render buffer wrapper (authored by zzag).
[libkwineffects] Add render buffer wrapper
Thu, Apr 12, 12:32 AM

Wed, Apr 11

zzag requested review of D11198: [libbreezecommon] add box shadow helper.
Wed, Apr 11, 12:18 AM · Plasma
zzag updated the diff for D11198: [libbreezecommon] add box shadow helper.

Because this patch hasn't been landed yet, I would like to post here
my recent work on optimizing the box shadow helper...

Wed, Apr 11, 12:10 AM · Plasma

Tue, Apr 10

zzag updated the summary of D10811: [scenes/opengl] fix overlapping shadow tiles.
Tue, Apr 10, 1:19 PM · KWin
zzag updated the test plan for D10811: [scenes/opengl] fix overlapping shadow tiles.
Tue, Apr 10, 1:16 PM · KWin
zzag abandoned D11850: modernize: use auto.
Tue, Apr 10, 12:57 PM · Plasma
zzag updated the diff for D11175: [kstyle] refine shadows.

Rebase.

Tue, Apr 10, 12:55 PM · Plasma
zzag updated the diff for D11069: [kdecoration] refine shadows.

Rebase.

Tue, Apr 10, 12:54 PM · Plasma
zzag updated the diff for D11198: [libbreezecommon] add box shadow helper.

Rebase.

Tue, Apr 10, 12:54 PM · Plasma
zzag committed R31:a4131c5d4024: [kstyle] create shadow tiles more explicitly (authored by zzag).
[kstyle] create shadow tiles more explicitly
Tue, Apr 10, 12:45 PM
zzag closed D11533: [kstyle] create shadow tiles more explicitly.
Tue, Apr 10, 12:45 PM · Plasma
zzag updated the diff for D11533: [kstyle] create shadow tiles more explicitly.

Trigger creation of shadow tiles in loadConfig().

Tue, Apr 10, 12:24 PM · Plasma
zzag added a comment to D11533: [kstyle] create shadow tiles more explicitly.

Well, after thinking for a while, I think shadowTiles should be called in loadConfig. It doesn't make much sense to create something in reset method.

Tue, Apr 10, 1:47 AM · Plasma

Mon, Apr 9

zzag added a comment to D9792: even slimmer scrollbars.

I'm sorry, but these scrollbars have too thin sliders.

Mon, Apr 9, 11:12 PM · Kirigami, Plasma
zzag updated the diff for D11533: [kstyle] create shadow tiles more explicitly.

Call shadowTiles in the reset method.

Mon, Apr 9, 8:55 PM · Plasma
zzag added a comment to D11533: [kstyle] create shadow tiles more explicitly.

Hi Vlad,

Mon, Apr 9, 5:02 PM · Plasma
zzag added a reviewer for D12055: Remove border around menubars: Breeze.
Mon, Apr 9, 12:18 AM · Plasma
zzag requested review of D12055: Remove border around menubars.
Mon, Apr 9, 12:16 AM · Plasma

Fri, Apr 6

zzag added a comment to D9557: main_wayland: Don't hardcode /dev/fb0 anymore.
In D9557#241112, @rkflx wrote:
In D9557#241100, @zzag wrote:

FWIW, I had similar issue some time ago. I solved it by cherry-picking.

Hm, could you detail that, i.e. what are the exact commands you want @nerdopolist to type?

Fri, Apr 6, 12:28 PM · KWin
zzag added a comment to D9557: main_wayland: Don't hardcode /dev/fb0 anymore.

FWIW, I had similar issue some time ago. I solved it by cherry-picking.

Fri, Apr 6, 12:11 PM · KWin
zzag added a comment to T7856: Turn on Fade effect.

Isn't the fade effect already turned on?

Fri, Apr 6, 12:50 AM · Kubuntu

Thu, Apr 5

zzag added a comment to D11976: Change/improve default settings of glide effect.

Tilt nowadays may be too much wobbly , and being default the user might be put off immediatly. Btw tilt was not one of the original purposes of Glide. At least not when I developed it.

Thu, Apr 5, 11:56 PM · KWin