Differential D13496

FrameSvg: Update mask frame if image path has been changed
ClosedPublic
Actions

Authored by zzag on Jun 12 2018, 4:36 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Frameworks
Commits
R242:0c8dd9dc2b54: FrameSvg: Update mask frame if image path has been changed
Summary

A FrameSvg can have wrong mask frame if image path has been changed after
the mask frame was generated. Take image path into account when deciding
whether the mask frame should be updated to address that problem.

Depends on D13384

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jun 12 2018, 4:36 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 12 2018, 4:36 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
zzag requested review of this revision.Jun 12 2018, 4:36 PM
zzag updated this revision to Diff 36057.Jun 12 2018, 4:48 PM

Compare against frame->imagePath.

mart accepted this revision.Jun 27 2018, 11:38 AM
This revision is now accepted and ready to land.Jun 27 2018, 11:38 AM
Closed by commit R242:0c8dd9dc2b54: FrameSvg: Update mask frame if image path has been changed (authored by zzag). · Explain WhyJun 27 2018, 12:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/framesvg.cpp (4 lines)

Diff 36759

View Options

src/plasma/framesvg.cpp

Loading...