asensi (Toni Asensi Esteve)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 20 2016, 4:24 PM (182 w, 15 h)
Availability
Available

Recent Activity

Yesterday

asensi committed R167:db9797b643d6: Replace Q_WS_WIN with Q_OS_WIN in all the source code (authored by asensi).
Replace Q_WS_WIN with Q_OS_WIN in all the source code
Sun, Sep 15, 10:13 PM
asensi closed D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
Sun, Sep 15, 10:13 PM · Krusader
asensi added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.

I agree with you. Thanks Alex and Nikita! (and Moritz :-)

Sun, Sep 15, 10:12 PM · Krusader
asensi committed R167:7905b361c959: Identify the "vnd.comicbook+zip" and "vnd.comicbook-rar" MIME types in order to… (authored by asensi).
Identify the "vnd.comicbook+zip" and "vnd.comicbook-rar" MIME types in order to…
Sun, Sep 15, 9:57 PM
asensi closed D23549: Identify the "vnd.comicbook+zip" and "vnd.comicbook-rar" MIME types in order to allow some operations.
Sun, Sep 15, 9:57 PM · Krusader
asensi added a comment to D23549: Identify the "vnd.comicbook+zip" and "vnd.comicbook-rar" MIME types in order to allow some operations.

Thanks, Alex!

Sun, Sep 15, 9:56 PM · Krusader
asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

And thanks Nikita, Alex, and Moritz! (and Yuri :-)

Sun, Sep 15, 9:55 PM · Krusader
asensi committed R167:8c0bece064ac: Shift+Del can remove cruft from the history of the "Search for" comboBox in the… (authored by asensi).
Shift+Del can remove cruft from the history of the "Search for" comboBox in the…
Sun, Sep 15, 9:40 PM
asensi closed D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Sun, Sep 15, 9:40 PM · Krusader
asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Code looks good and still works!

Sun, Sep 15, 9:39 PM · Krusader
asensi accepted D23912: Respect .hidden files.
Sun, Sep 15, 9:36 PM · Krusader
asensi accepted D23924: Add QT::KeyMenu action to search results.
Sun, Sep 15, 9:36 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Alex's recommendations were applied in order to ease the reading of the source code (and the changes could be applied quickly :-) ).

Sun, Sep 15, 6:20 PM · Krusader
asensi committed R167:c264e2a3deed: Avoid that Krusader crashes when trying to view any archive using the ark part (authored by asensi).
Avoid that Krusader crashes when trying to view any archive using the ark part
Sun, Sep 15, 5:32 PM
asensi closed D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.
Sun, Sep 15, 5:32 PM · Krusader
asensi added a comment to D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.

Some tests were also performed by Moritz Bunkus (https://bugs.kde.org/show_bug.cgi?id=411446#c10) and he didn't see any problem.

Sun, Sep 15, 5:30 PM · Krusader
asensi closed D23885: Update build status icon.
Sun, Sep 15, 5:16 PM · Krusader
asensi committed R938:368310e08ac6: Update build status icon (authored by asensi).
Update build status icon
Sun, Sep 15, 5:16 PM
asensi added a comment to D23885: Update build status icon.

All right, Davide and Nikita, thanks!

Sun, Sep 15, 4:49 PM · Krusader
asensi committed R167:e229f9ba7301: Identify the "application/vnd.rar" MIME type in order to allow some operations (authored by asensi).
Identify the "application/vnd.rar" MIME type in order to allow some operations
Sun, Sep 15, 4:32 PM
asensi closed D23476: Identify the "application/vnd.rar" MIME type in order to allow some operations.
Sun, Sep 15, 4:32 PM · Krusader
asensi added a comment to D23476: Identify the "application/vnd.rar" MIME type in order to allow some operations.

Note: For the tests that I performed under Kubuntu 18.04, executing dpkg -l showed:
kio 5.44.0-0ubuntu1 amd64 Resource and network access abstraction

Sun, Sep 15, 4:30 PM · Krusader
asensi added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.

Some tests were also performed by Moritz Bunkus (https://bugs.kde.org/show_bug.cgi?id=411446#c10) and he didn't see any problem.

Sun, Sep 15, 4:21 PM · Krusader
asensi committed R167:07848cc8ebc8: Provide keyboard shortcuts in (de-)selection and (de-)filter dialogs (authored by asensi).
Provide keyboard shortcuts in (de-)selection and (de-)filter dialogs
Sun, Sep 15, 4:11 PM
asensi closed D23606: Provide two keyboard shortcuts in (de-)selection and filter dialogs.
Sun, Sep 15, 4:11 PM · Krusader
asensi added a comment to D23606: Provide two keyboard shortcuts in (de-)selection and filter dialogs.

Some tests were also performed by Moritz Bunkus (https://bugs.kde.org/show_bug.cgi?id=411446#c10) and he didn't see any problem.

Sun, Sep 15, 4:00 PM · Krusader
asensi added a comment to D23912: Respect .hidden files.

The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!

Sun, Sep 15, 3:44 PM · Krusader
asensi added a comment to D23924: Add QT::KeyMenu action to search results.

The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!

Sun, Sep 15, 3:38 PM · Krusader
asensi added a comment to D23880: Handle Ctrl+Left/Right not working in brief view.

The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!

Sun, Sep 15, 3:35 PM · Krusader

Wed, Sep 4

asensi added a comment to D23409: In the main page, add a very visible link asking people to help Krusader.

The baloon-like message presents strange behaviors when doing some resizing, if someone wants propose HTML+CSS code, or an image, or other way, in order to draw attention of more developers...

Wed, Sep 4, 10:49 PM · Krusader
asensi committed R938:5aa1bd67ff0c: An old, unused page was deleted (authored by asensi).
An old, unused page was deleted
Wed, Sep 4, 10:47 PM
asensi closed D23574: Erase an old page.
Wed, Sep 4, 10:47 PM · Krusader
asensi updated the diff for D23574: Erase an old page.

The disabled source code was removed, as nobody objected to it, and it's undoable.

Wed, Sep 4, 10:44 PM · Krusader
asensi added a comment to D23574: Erase an old page.

Sometimes people are aware that there's a git history, but leave code disabled on purpose. Anyway, this change can be undone, too :-)

Wed, Sep 4, 10:21 PM · Krusader

Mon, Sep 2

asensi added a comment to D23574: Erase an old page.

I also have seen it when I tested published changelog files and wanted to remove it. Thanks for bringing my thoughts to live. :)
It's not rendered but mentioned in old comment in the report-bugs/index.html - can you remove the comment as well?

Mon, Sep 2, 9:49 PM · Krusader
asensi added a comment to D23606: Provide two keyboard shortcuts in (de-)selection and filter dialogs.

Reviewed and tested - all good! Thanks for the fix, Toni!

Mon, Sep 2, 9:46 PM · Krusader

Sun, Sep 1

asensi added a comment to D22891: If an item that is going to be renamed is also going to be hidden by default, then warn the user.

Kindly ping

Sun, Sep 1, 6:53 PM · Krusader
asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Kindly ping

Sun, Sep 1, 6:29 PM · Krusader
asensi retitled D23118: Changed shortcut for the embedded terminal emulator from Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator to Changed shortcut for the embedded terminal emulator.
Sun, Sep 1, 5:42 PM · Krusader
asensi committed R167:083f5a8b3cdd: Changed shortcut for the embedded terminal emulator (authored by asensi).
Changed shortcut for the embedded terminal emulator
Sun, Sep 1, 5:40 PM
asensi closed D23118: Changed shortcut for the embedded terminal emulator.
Sun, Sep 1, 5:40 PM · Krusader
asensi added a comment to D23118: Changed shortcut for the embedded terminal emulator.

Thanks, Nikita! After asking in the krusader-users mailing list, no objections were made since Aug . 19. The commit will be made.

Sun, Sep 1, 5:38 PM · Krusader
asensi updated the test plan for D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.
Sun, Sep 1, 5:15 PM · Krusader

Sat, Aug 31

asensi requested review of D23606: Provide two keyboard shortcuts in (de-)selection and filter dialogs.
Sat, Aug 31, 4:35 PM · Krusader

Thu, Aug 29

asensi retitled D23574: Erase an old page from An old page was deleted to Erase an old page.
Thu, Aug 29, 9:15 PM · Krusader
asensi requested review of D23574: Erase an old page.
Thu, Aug 29, 9:14 PM · Krusader

Wed, Aug 28

asensi requested review of D23549: Identify the "vnd.comicbook+zip" and "vnd.comicbook-rar" MIME types in order to allow some operations.
Wed, Aug 28, 10:07 PM · Krusader
asensi committed R167:91cdbe64d5c3: Restore translations in "krarc.protocol" because of a SVN_SILENT change (authored by asensi).
Restore translations in "krarc.protocol" because of a SVN_SILENT change
Wed, Aug 28, 12:45 PM

Tue, Aug 27

asensi updated the diff for D23476: Identify the "application/vnd.rar" MIME type in order to allow some operations.

"application/vnd.rar" was incorporated to krArc/krarc.protocol, as suggested by N. Higa. Two reminders were also added.

Tue, Aug 27, 9:13 PM · Krusader
asensi added a comment to D23476: Identify the "application/vnd.rar" MIME type in order to allow some operations.

Should we also add application/vnd.rar to krArc/krarc.protocol?

Tue, Aug 27, 9:10 PM · Krusader
asensi committed R167:702d43a5a8cd: Add more compressed file types to the list of file types that krarc supports (authored by asensi).
Add more compressed file types to the list of file types that krarc supports
Tue, Aug 27, 9:00 PM
asensi closed D23276: Add more compressed file types to the list of file types that krarc supports.
Tue, Aug 27, 9:00 PM · Krusader
asensi added a comment to D23276: Add more compressed file types to the list of file types that krarc supports.

Note: The krarc.protocol file is also being talked about by N. Higa in https://phabricator.kde.org/D23476

Tue, Aug 27, 8:59 PM · Krusader

Mon, Aug 26

asensi requested review of D23476: Identify the "application/vnd.rar" MIME type in order to allow some operations.
Mon, Aug 26, 9:23 PM · Krusader

Sat, Aug 24

asensi requested review of D23409: In the main page, add a very visible link asking people to help Krusader.
Sat, Aug 24, 6:38 PM · Krusader

Thu, Aug 22

asensi added a comment to D23309: Change the document about helping Krusader, add other ways.

P.S.: Some steps still have to be done, like the ones that Nikita commented "It will be great to have starting steps for each type of work (for example, want to do Bug Triaging - go to the specific bugzilla link showing the list of not triaged bugs and try to repro bugs one by one, and then post your comments in the bugs)" or mentioning that a linked page is in English.

Thu, Aug 22, 9:31 PM · Documentation, Krusader
asensi updated the diff for D23309: Change the document about helping Krusader, add other ways.

I suppose that today you have received a "Invitation to participate in a survey" mail from Lydia Pintscher. It reminds of when she wrote in https://phabricator.kde.org/T9581 about Krusader on Windows and "have you thought about using this as an opportunity to recruit someone new? Maybe a blog post or mailing list post asking if there is someone with the will and knowledge to drive this forward?", which has something to do with the subject of the present code review.

Thu, Aug 22, 9:18 PM · Documentation, Krusader

Wed, Aug 21

asensi updated the diff for D23309: Change the document about helping Krusader, add other ways.

Changes that were suggested.

Wed, Aug 21, 9:30 PM · Documentation, Krusader
asensi added inline comments to D23309: Change the document about helping Krusader, add other ways.
Wed, Aug 21, 9:29 PM · Documentation, Krusader
asensi added a comment to D23309: Change the document about helping Krusader, add other ways.
In D23309#515717, @pino wrote:

TBH I'd just add the instructions to https://krusader.org/get-involved/, and not to the user documentation.

Wed, Aug 21, 6:32 AM · Documentation, Krusader

Tue, Aug 20

asensi updated the diff for D23276: Add more compressed file types to the list of file types that krarc supports.

Some spaces were added, as Yuri suggested.

Tue, Aug 20, 10:01 PM · Krusader
asensi added inline comments to D23276: Add more compressed file types to the list of file types that krarc supports.
Tue, Aug 20, 9:59 PM · Krusader
asensi requested review of D23309: Change the document about helping Krusader, add other ways.
Tue, Aug 20, 9:53 PM · Documentation, Krusader

Mon, Aug 19

asensi added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

How do you think a person is going to search whether kde4 version of krusader is getting updates? Will she likely go to a search engine and type something like "krusader kde4" where the mentioned repo will be in top positions due to good naming?

Mon, Aug 19, 9:17 PM · Documentation, Krusader
asensi updated the summary of D23276: Add more compressed file types to the list of file types that krarc supports.
Mon, Aug 19, 9:07 PM · Krusader
asensi requested review of D23276: Add more compressed file types to the list of file types that krarc supports.
Mon, Aug 19, 9:05 PM · Krusader

Sun, Aug 18

asensi accepted D23235: Released v2.7.2.

It looks OK for me, thanks for it, Nikita!

Sun, Aug 18, 8:30 PM · Krusader
asensi accepted D23236: Updates related to v2.7.2 release.

It looks OK for me, thanks for it, Nikita!

Sun, Aug 18, 8:30 PM · Krusader
asensi added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

For example, you can fork krusader on github or other platform [...]. What do you think about this idea, Toni?

Sun, Aug 18, 8:21 PM · Documentation, Krusader
asensi accepted D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

For my part, I accept the proposal, Thanks for it, Nikita!

Sun, Aug 18, 7:57 PM · Krusader
asensi added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Well, some months have passed since Davide's commit :-( , let's see when normal Krusader users can take profit.

Sun, Aug 18, 7:50 PM · Krusader
asensi added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
In D22957#513827, @nmel wrote:

This is a very serious change because now #ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN will include the code that previously was ignored. We must look at all those code paths and test features it affects. BTW, does it mean that some of those code paths do not work correctly in the current state?

Sun, Aug 18, 7:41 PM · Krusader
asensi updated the summary of D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
Sun, Aug 18, 7:33 PM · Krusader
asensi updated subscribers of D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.
Sun, Aug 18, 7:24 PM · Krusader
asensi requested review of D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.
Sun, Aug 18, 7:20 PM · Krusader

Aug 16 2019

asensi added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Thanks, Nikita! Because it's very handy, and it has been already tried a lot, it looks like a good idea to add the "Shortcuts to move tab" commit to the stable branch, and add to the ChangeLog file:

FIXED: [ 328937 ] Shortcuts for move tab
Aug 16 2019, 8:55 PM · Krusader

Aug 12 2019

asensi retitled D23118: Changed shortcut for the embedded terminal emulator from Because Ctrl+Alt+T is now a global shortcut, use another one for the embedded terminal emulator to Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator.
Aug 12 2019, 9:53 PM · Krusader
asensi requested review of D23118: Changed shortcut for the embedded terminal emulator.
Aug 12 2019, 9:52 PM · Krusader
asensi committed R167:2fb1d7febde8: Clarify the aim of two lines written recently by David Faure (authored by asensi).
Clarify the aim of two lines written recently by David Faure
Aug 12 2019, 9:24 PM
asensi closed D22883: Clarify the aim of two lines written recently by David Faure.
Aug 12 2019, 9:24 PM · Krusader
asensi added a comment to D22883: Clarify the aim of two lines written recently by David Faure.

Ok. Thanks, Alex and Davide!

Aug 12 2019, 9:24 PM · Krusader

Aug 10 2019

asensi edited the content of Release Howto.
Aug 10 2019, 6:38 AM · Krusader

Aug 9 2019

asensi edited the content of Release Howto.
Aug 9 2019, 10:20 PM · Krusader
asensi edited the content of Release Howto.
Aug 9 2019, 10:12 PM · Krusader
asensi accepted D22982: Updated release information in docs.

Thanks, Nikita!

Aug 9 2019, 5:57 AM · Krusader, Documentation
asensi updated subscribers of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Aug 9 2019, 5:42 AM · Krusader

Aug 8 2019

asensi updated subscribers of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

An article about it has been published recently:

About deprecation of QFontMetrics::width()
https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/

by @cfeck (Christoph Feck, who has commited some changes to the repository of Krusader).

Aug 8 2019, 10:20 PM · Krusader
asensi added a comment to D22982: Updated release information in docs.

Please also add the versioning data to the appdata file (maybe also add the information for the previous version this time):

Aug 8 2019, 8:48 PM · Krusader, Documentation

Aug 7 2019

asensi added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

Hi, Luigi! Well, I was referring to the virtual machines running prior operating systems (and physical machines, I remember that the LTS support of Ubuntu 14.04 ended at the end of April and I still saw some of those machines). Sometimes the reason is that some programs do not run in recent versions of operating systems, other causes may exist.
There's also the case of Lliurex 16, an operating system installed in thousands of computers, I had to work with it and there I could only build the "kde4" version of Krusader.

Aug 7 2019, 3:41 PM · Documentation, Krusader
asensi requested review of D23003: For the "kde4" branch: 10 - Avoid closing the tab when the user {presses Esc inside the Krusader internal editor in order to try to exit searching}; thanks to Martin Kotelnik.
Aug 7 2019, 3:12 PM · Krusader
asensi requested review of D23002: For the "kde4" branch: 09 - Make Alt+. the default shortcut for toggling hidden files.
Aug 7 2019, 3:12 PM · Documentation, Krusader
asensi requested review of D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.
Aug 7 2019, 3:12 PM · Documentation, Krusader
asensi requested review of D23000: For the "kde4" branch: 07 - In the synchronizer: until the bug 270150 is solved, stop using protocols like FISH, SFTP, SMB, etc. Check if the target or the source directory are empty.
Aug 7 2019, 3:11 PM · Krusader
asensi requested review of D22999: For the "kde4" branch: 06 - Reverse defaults for Synchronizer.
Aug 7 2019, 3:11 PM · Krusader
asensi requested review of D22998: For the "kde4" branch: 05 - Fix definition scope for Synchronizer in CMake.
Aug 7 2019, 3:11 PM · Krusader
asensi requested review of D22997: For the "kde4" branch: 04 - Update the main CMakeLists.txt to enable by default the building of synchronizer.
Aug 7 2019, 3:10 PM · Krusader
asensi requested review of D22996: For the "kde4" branch: 03 - Use the same font for file name and renamed file name; solved by Tobias BUG: 326649.
Aug 7 2019, 3:10 PM · Krusader
asensi requested review of D22995: For the "kde4" branch: 02 - Names of files are correctly seen when a zip file is opened, even if they are utf-8 encoded.
Aug 7 2019, 3:10 PM · Krusader
asensi requested review of D22994: For the "kde4" branch: 01 - Solve a bug that didn't allow Krusader to search files inside zip archives; thanks to Dawid Weiss BUG: 292867 REVIEW: 124343.
Aug 7 2019, 3:10 PM · Krusader

Aug 5 2019

asensi requested review of D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
Aug 5 2019, 9:06 PM · Krusader