asensi (Toni Asensi Esteve)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 20 2016, 4:24 PM (100 w, 5 d)
Availability
Available

Recent Activity

Today

asensi accepted D9041: Ability to ignore defined files and directories from search results.

I've changed delimiter to space and used KShell::splitArgs() method to allow using

  • quoted folder names
  • folder names with escaped spaces
Sat, Feb 24, 10:57 AM · Krusader
asensi committed R167:0e0f4ae6dd34: Changes in the "desktop" file to achieve that Krusader can be added to… (authored by asensi).
Changes in the "desktop" file to achieve that Krusader can be added to…
Sat, Feb 24, 9:31 AM
asensi closed D10746: Changes in the "desktop" file to achieve that Krusader can be added to favorites in Gnome Dock.
Sat, Feb 24, 9:31 AM · Krusader
asensi updated the diff for D10746: Changes in the "desktop" file to achieve that Krusader can be added to favorites in Gnome Dock.

Now the names of Jakub Buczak (Jakkubu) and Nate Graham are mentioned in the commit.

Sat, Feb 24, 9:07 AM · Krusader

Thu, Feb 22

asensi requested review of D10746: Changes in the "desktop" file to achieve that Krusader can be added to favorites in Gnome Dock.
Thu, Feb 22, 2:23 PM · Krusader
asensi added a comment to D9041: Ability to ignore defined files and directories from search results.

For more consistency, I'm thinking that, if in the "Search for:" text field, Krusader users space as a delimiter... maybe it would also use it in the same window, in the proposed «Exclude Folder Names» text field.

Thu, Feb 22, 9:46 AM · Krusader

Wed, Feb 21

asensi accepted D9041: Ability to ignore defined files and directories from search results.

Thank you! For my part, I accept this because I performed some tests and the new patch worked correctly (items inside the specified folders are excluded, files and folders that are shown are the expected ones, etc.), although when there was a folder with a ":" inside its name then the folder couldn't be excluded.

Wed, Feb 21, 5:40 PM · Krusader
asensi accepted D10608: Closing calculate occupied space window aborts the calculation.

Thanks Davide! The changes that Nikita (nmel) wrote are also improvements. For my part, I accept this because my performed tests (using Kubuntu 17.10) seemed to work correctly.

Wed, Feb 21, 11:33 AM · Krusader

Sat, Feb 17

asensi added a project to D10385: Fix setting new current item after file deletion: Krusader.
Sat, Feb 17, 11:44 AM · Krusader

Fri, Feb 16

asensi added a comment to D10352: Force Breeze icon theme..

Application specific icons should be provided by the application.

Fri, Feb 16, 1:24 PM
asensi accepted D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Thanks, Toni, for trying it out! :-)

Fri, Feb 16, 10:50 AM · Krusader
asensi added a comment to D10352: Force Breeze icon theme..

My favourite is 2A :).

Fri, Feb 16, 10:42 AM

Fri, Feb 9

asensi added a comment to D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Hi! I tried the patch, using Kubuntu 17.10, and everything seems to work correctly.

Fri, Feb 9, 9:12 AM · Krusader

Thu, Feb 8

asensi added a comment to D10385: Fix setting new current item after file deletion.

Note: This is related to

https://bugs.kde.org/show_bug.cgi?id=389869
Thu, Feb 8, 1:47 PM · Krusader
asensi added a comment to D10352: Force Breeze icon theme..

As Andreas Kainz has updated Oxygen icons (very good!), now Breeze and Oxygen have all the icons that Krusader needs, there are more details in:

https://bugs.kde.org/show_bug.cgi?id=388691
https://commits.kde.org/oxygen-icons5/857400cb1a51f2287e4b6b285bba0f897066a6f7
Thu, Feb 8, 9:51 AM

Jan 22 2018

asensi added a comment to D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Because you added this

Jan 22 2018, 9:27 PM · Krusader

Sep 29 2017

asensi accepted D7974: Fix mkdir and mkpath for krarc protocol.

For my part, I accept this because my performed tests (using Kubuntu 17.04) went alright.

Sep 29 2017, 10:00 PM · Krusader

Sep 1 2017

asensi accepted D7610: Support for "mkdir -p" re-added.

For my part, I accept this because my performed tests went alright. Other people can do their checks.

Sep 1 2017, 9:58 PM · Krusader
asensi accepted D5734: Fix lister unintended selection while scrolling.

For my part, I accept this because every of my performed tests has been successful, even the "selected characters" test :-). Other people can do their checks.

Sep 1 2017, 9:06 PM · Krusader

Aug 30 2017

asensi added a comment to D5734: Fix lister unintended selection while scrolling.

I've found one other issue myself today - zooming out would cause that there are too many characters on one line
not fitting the viewport width. This should now be fixed, too.

Aug 30 2017, 8:24 AM · Krusader

Aug 29 2017

asensi added a comment to D5734: Fix lister unintended selection while scrolling.

With the latest improvements, at least using Kubuntu 17.04, not everything was perfect :-) :

  • if the user utilizes Lister to see a file like the "bashrc" attached one and then presses PgDown a lot of times: the scroll doesn't stop at the end of the file.
  • if the user utilizes Lister to see a file like the "profile" attached one and then presses PgDown: the cursor does not move.
  • if the user utilizes Lister to see a file like the "profile" attached one and then presses Ctrl+End: the cursor does not move.
Aug 29 2017, 10:51 AM · Krusader

Aug 28 2017

asensi moved T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window) from In progress to Done on the Krusader board.
Aug 28 2017, 11:03 PM · Krusader
asensi moved T1971: Opening Big File Warning from In progress to Done on the Krusader board.
Aug 28 2017, 11:03 PM · Krusader
asensi closed T5716: New release: 2.6.0 as Resolved.

Marked as "Closed, Resolved". Thanks for the good work!

Aug 28 2017, 11:02 PM · Krusader
asensi closed T3770: New Release as Resolved.

Marked as "Closed, Resolved". Thanks for the good work!

Aug 28 2017, 11:01 PM · Krusader
asensi closed T6870: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader as Resolved.

After the changes:
This is the beginning of the README file as it's seen in https://phabricator.kde.org/source/krusader/:

Aug 28 2017, 10:57 PM · Krusader
asensi committed R167:093230e50750: Changes in the README to be better seen on https://phabricator.kde. (authored by asensi).
Changes in the README to be better seen on https://phabricator.kde.
Aug 28 2017, 10:42 PM
asensi closed D7557: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader by committing R167:093230e50750: Changes in the README to be better seen on https://phabricator.kde..
Aug 28 2017, 10:42 PM · Krusader

Aug 26 2017

asensi added a comment to T6870: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.

Note:
This is the beginning of the README file as it's seen nowadays in https://phabricator.kde.org/source/krusader/:

Aug 26 2017, 12:43 PM · Krusader
asensi added a task to D7557: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader: T6870: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.
Aug 26 2017, 12:42 PM · Krusader
asensi added a revision to T6870: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader: D7557: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.
Aug 26 2017, 12:42 PM · Krusader
asensi created T6870: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.
Aug 26 2017, 12:42 PM · Krusader
asensi added a comment to D7557: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.

This is the beginning of the README file as it's seen nowadays in https://phabricator.kde.org/source/krusader/:

Aug 26 2017, 12:38 PM · Krusader
asensi created D7557: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.
Aug 26 2017, 12:35 PM · Krusader

Aug 4 2017

asensi closed T3419: Rework of VFS (Now: FileSystem) as Resolved.

Marked as "Closed, Resolved" (it was "Open, Needs Triage"). Thanks for the good work!

Aug 4 2017, 8:20 PM · Krusader

Aug 2 2017

asensi accepted D6850: KrViewer looses focus - fixed.

It can be compiled and executed using Kubuntu 17.04, and everything seems to work correctly :-)

Aug 2 2017, 10:26 PM · Krusader

Jul 23 2017

asensi added a comment to T1971: Opening Big File Warning.

The improvement seems to work nicely (tried using Kubuntu 17.04). Congratulations!

Jul 23 2017, 11:44 AM · Krusader
asensi closed T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window) as Resolved.

The improvement seems to work nicely (tried using Kubuntu 17.04). Congratulations!

Jul 23 2017, 11:43 AM · Krusader

May 7 2017

asensi accepted D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

This patch is just a proposal to remove this feature and leave user's clipboard alone.

May 7 2017, 9:57 PM · Krusader

Mar 8 2017

asensi added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

I've just tried it in a clean Kubuntu 16.10 virtual machine, if anyone wants to try it too.

Mar 8 2017, 11:26 PM
asensi added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

Hi!
I executed

Mar 8 2017, 3:44 PM

Mar 4 2017

asensi added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

Hi!
Using Kubuntu 16.10: that patch works if the password has been typed recently, if it's not that way, if you already had an opened Kate, then you are asked for a password but after typing it nothing happens.
I'm available to perform more tests. Thanks.

Mar 4 2017, 10:38 AM

Feb 25 2017

asensi added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

If it may be helpful, as it was previously written, in the comments of https://blog.martin-graesslin.com/blog/2017/02/editing-files-as-root/ it's stated that for example if you are already using Kate, and then you execute sudoedit to use Kate to edit a file: the user sees an error message, he isn't really able to edit the file he wanted, etc.

Feb 25 2017, 12:18 PM

Feb 23 2017

asensi added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I am suggesting a third: make Krusader in root mode unnecessary because people can elevate for specific operations as opposed to constantly running in elevated mode.

Feb 23 2017, 3:12 PM
asensi added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

you shouldn't run graphical applications as root

Feb 23 2017, 11:53 AM

Feb 15 2017

asensi accepted D4609: Improved integration of (quick) search bar in panel.

Great! It gets compiled using Kubuntu 16.10 and also the bug 375639 seems to be solved, thank you very much, Alex!

Feb 15 2017, 8:57 AM
asensi accepted D4512: Rework of vfile and KrPermHandler class.

The code is cleaner now :-), it also gets compiled using Kubuntu 16.04 and seems to work correctly :-), thank you, Alex!

Feb 15 2017, 8:55 AM

Feb 11 2017

asensi added a comment to D2857: Use KRun for "Open with"->"Other..." dialog.

Is the working directory really important for (any) application?

Feb 11 2017, 2:36 PM
asensi accepted D4418: #314258 - Duplicate tab settings when duplicating tabs.

It can be compiled and executed using Kubuntu 16.04 or 16.10, and everything seems to work correctly :-), thanks Wladimir!

Feb 11 2017, 2:23 PM · Krusader

Feb 8 2017

asensi accepted D4146: ListPanel: don't go back in history if refresh failed.

This changes the refresh behavior of the list panel to stay at the URL which failed to refresh, instead of going back in
the panel's history until the refresh is successful.

Feb 8 2017, 9:06 AM · Krusader
asensi accepted D4420: #375894 - Use case-insensitive as default for text search.
Feb 8 2017, 8:58 AM · Krusader
asensi added a comment to D4420: #375894 - Use case-insensitive as default for text search.

As far as GUI tools go, I don't know any where case-sensitive search would be the default, and I wouldn't expect it either.

Feb 8 2017, 8:51 AM · Krusader

Feb 5 2017

asensi added a comment to T5062: Improve search results tab.

This mockup is great but implementation will certainly take time. Unless somebody plans to work on this really soon, maybe a simpler solution
is worth considering: when opening the viewer from the file search with non-empty text, do a search for this text in the viewer automatically.
So the first result line should be selected immediately and pressing F3 should bring up the other matches. That's what Total Commander does.
These proposals aren't mutually exclusive of course.

Feb 5 2017, 6:25 PM · Krusader
asensi added a comment to D4427: Update "get involved" page to indicate how one can register.

It's better this way, thanks, Wladimir!

Feb 5 2017, 8:03 AM · Websites, Krusader
asensi accepted D4433: #375994 - List kio-extras under dependencies as recommended package.

Very good! Thanks, Wladimir!

Feb 5 2017, 7:53 AM · Krusader
asensi accepted D4417: #375831 - Sort empty file extensions correctly.

Nice! Thanks, Wladimir!

Feb 5 2017, 7:50 AM · Krusader
asensi accepted D4419: #375830 - Don't send SIGINT to terminal emulator unnecessarily.

Great! Thanks, Wladimir!

Feb 5 2017, 7:47 AM · Krusader

Jan 29 2017

asensi added a comment to D4316: Panel/VFS: Rework of deletion/moveToTrash/virtualRemove of files and directories.

Thank you very much!

Jan 29 2017, 9:10 AM

Jan 28 2017

asensi committed R167:50562722fcf3: A line was split so that it followed the same style as the other lines. (authored by asensi).
A line was split so that it followed the same style as the other lines.
Jan 28 2017, 9:05 PM
asensi committed R167:f0afeb30267e: Added: 1) A change in order to accelerate the compilation process. 2) An… (authored by asensi).
Added: 1) A change in order to accelerate the compilation process. 2) An…
Jan 28 2017, 9:05 PM
asensi closed D4195: Changes in the installation documentation (2) - Web pages.
Jan 28 2017, 7:00 PM · Krusader, Websites
asensi closed D4194: Changes in the installation documentation (1) - INSTALL file.
Jan 28 2017, 6:59 PM · Websites, Krusader

Jan 18 2017

asensi abandoned D4008: A warning note, like the formerly used ones, was added to the installation section. .

Thanks for all the changes until now, it looks like it's better to follow the discussion in two new differentials:
https://phabricator.kde.org/D4194
https://phabricator.kde.org/D4195

Jan 18 2017, 10:43 PM · Krusader, Websites
asensi added a reviewer for D4195: Changes in the installation documentation (2) - Web pages: Krusader.
Jan 18 2017, 10:40 PM · Krusader, Websites
asensi retitled D4194: Changes in the installation documentation (1) - INSTALL file from Changes in the installation documentation to Changes in the installation documentation (1) - INSTALL file.
Jan 18 2017, 10:37 PM · Websites, Krusader
asensi updated the diff for D4194: Changes in the installation documentation (1) - INSTALL file.
Jan 18 2017, 10:36 PM · Websites, Krusader
asensi updated the diff for D4194: Changes in the installation documentation (1) - INSTALL file.
Jan 18 2017, 10:33 PM · Websites, Krusader
asensi added a reviewer for D4194: Changes in the installation documentation (1) - INSTALL file: Krusader.
Jan 18 2017, 10:31 PM · Websites, Krusader
asensi edited the content of Krusader.
Jan 18 2017, 10:25 PM · Krusader

Jan 17 2017

asensi added a comment to D4008: A warning note, like the formerly used ones, was added to the installation section. .

Thanks, there are solutions stated in the INSTALL file, I volunteer for adapting the web page :-)

Jan 17 2017, 8:34 PM · Krusader, Websites
asensi added a comment to D4008: A warning note, like the formerly used ones, was added to the installation section. .

the current instructions (5 commands) should work well for most users.

Jan 17 2017, 7:59 PM · Krusader, Websites
asensi added a comment to D4008: A warning note, like the formerly used ones, was added to the installation section. .

But why a single (big) one with different style?

Jan 17 2017, 7:22 AM · Krusader, Websites

Jan 16 2017

asensi added a comment to D4008: A warning note, like the formerly used ones, was added to the installation section. .

I understand the motivation behind the additional css now, so I'm also fine with your proposed changes.

Jan 16 2017, 12:37 AM · Krusader, Websites

Jan 10 2017

asensi added a comment to D4008: A warning note, like the formerly used ones, was added to the installation section. .

Hi, Martin, the changes that you propose are good. The css file was added to achieve that the note:

Note
Please read the INSTALL file of the Krusader sources, it contains all latest installation instructions.

was seen the same way as the same notes that are seen in the Krusader Handbook (in docs.kde.org), for example in: https://docs.kde.org/trunk5/en/extragear-utils/krusader/kde_lin_install.html , https://docs.kde.org/trunk5/en/extragear-utils/krusader/compilation.html , etc.:

Jan 10 2017, 11:15 PM · Krusader, Websites

Jan 8 2017

asensi retitled D4008: A warning note, like the formerly used ones, was added to the installation section. from to A warning note, like the formerly used ones, was added to the installation section. .
Jan 8 2017, 9:36 AM · Krusader, Websites

Jan 7 2017

asensi closed T5038: Update documentation links in order to point to the new Krusader 2.5.0 handbook as Resolved.

Alex Bikadorov solved it :-)

Jan 7 2017, 7:07 PM · Krusader
asensi abandoned D4004: Update documentation links in order to point to the new Krusader 2.5.0 handbook.

Alex Bikadorov solved it :-)

Jan 7 2017, 7:06 PM · Krusader
asensi added a revision to T5038: Update documentation links in order to point to the new Krusader 2.5.0 handbook: D4004: Update documentation links in order to point to the new Krusader 2.5.0 handbook.
Jan 7 2017, 6:17 PM · Krusader
asensi added a task to D4004: Update documentation links in order to point to the new Krusader 2.5.0 handbook: T5038: Update documentation links in order to point to the new Krusader 2.5.0 handbook.
Jan 7 2017, 6:17 PM · Krusader
asensi created T5038: Update documentation links in order to point to the new Krusader 2.5.0 handbook.
Jan 7 2017, 6:16 PM · Krusader
asensi added reviewers for D4004: Update documentation links in order to point to the new Krusader 2.5.0 handbook: Krusader, yurchor.
Jan 7 2017, 6:14 PM · Krusader
asensi committed R167:c95915d2ff81: The INSTALL file was updated after a Kubuntu 16.10 installation. The install. (authored by asensi).
The INSTALL file was updated after a Kubuntu 16.10 installation. The install.
Jan 7 2017, 1:55 PM
asensi closed D4002: The INSTALL file was updated after a Kubuntu 16.10 installation. The install.docbook was corrected to avoid seeing the text `krusader--profile` by committing R167:c95915d2ff81: The INSTALL file was updated after a Kubuntu 16.10 installation. The install..
Jan 7 2017, 1:55 PM · Krusader
asensi added reviewers for D4002: The INSTALL file was updated after a Kubuntu 16.10 installation. The install.docbook was corrected to avoid seeing the text `krusader--profile`: Krusader, yurchor.
Jan 7 2017, 1:45 PM · Krusader
asensi committed R167:4df7f97cdd2a: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file… (authored by asensi).
Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file…
Jan 7 2017, 12:03 PM
asensi closed T4999: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file of Krusader. as Resolved by committing R167:4df7f97cdd2a: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file….
Jan 7 2017, 12:03 PM · Krusader
asensi closed D3884: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file of Krusader by committing R167:4df7f97cdd2a: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file….
Jan 7 2017, 12:03 PM · Krusader

Jan 4 2017

asensi accepted D3938: VFS: cleaner code for refresh check on vfs operation without current directory.
Jan 4 2017, 10:30 AM
asensi added a comment to D3938: VFS: cleaner code for refresh check on vfs operation without current directory.

The source code gets compiled using Kubuntu 16.04, the free space information gets updated after a copy of a big file, and also Krusader seems to work correctly browsing folders and compressed archives. Thanks, Alex and everyone!

Jan 4 2017, 10:30 AM

Dec 31 2016

asensi added a comment to D3884: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file of Krusader.

Thanks, Luigi Toscano, definitely qCDebug is something worth looking for, and this task can be a first step because it simplifies the prior situation.

Dec 31 2016, 5:04 PM · Krusader
asensi added a task to D3884: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file of Krusader: T4999: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file of Krusader..
Dec 31 2016, 5:15 AM · Krusader
asensi added a revision to T4999: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file of Krusader.: D3884: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file of Krusader.
Dec 31 2016, 5:15 AM · Krusader
asensi created T4999: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file of Krusader..
Dec 31 2016, 5:15 AM · Krusader
asensi added a reviewer for D3884: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file of Krusader: Krusader.
Dec 31 2016, 5:11 AM · Krusader

Dec 18 2016

asensi closed D3722: Update the INSTALL file.
Dec 18 2016, 11:25 AM · Krusader
asensi committed R167:0400f58737f1: Update the INSTALL file (authored by asensi).
Update the INSTALL file
Dec 18 2016, 11:24 AM
asensi closed T4917: Update the INSTALL file as Resolved by committing R167:0400f58737f1: Update the INSTALL file.
Dec 18 2016, 11:24 AM · Krusader
asensi added a task to D3722: Update the INSTALL file: T4917: Update the INSTALL file.
Dec 18 2016, 10:50 AM · Krusader
asensi added a revision to T4917: Update the INSTALL file: D3722: Update the INSTALL file.
Dec 18 2016, 10:50 AM · Krusader
asensi added a reviewer for D3722: Update the INSTALL file: Krusader.
Dec 18 2016, 10:50 AM · Krusader