asensi (Toni Asensi Esteve)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 20 2016, 4:24 PM (109 w, 2 d)
Availability
Available

Recent Activity

Sun, Apr 22

asensi accepted D10352: Fix insufficient icon theme issues.

Toni, please accept this revision if you think it's good to merge with master.

Sun, Apr 22, 4:42 PM · Krusader
asensi added a comment to D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming.

Pinging @asensi on whether this would be a good addition to the Krusader project so then we can consider moving it to KIO).

Sun, Apr 22, 4:35 PM · Dolphin

Sat, Apr 21

asensi added a comment to D10352: Fix insufficient icon theme issues.

To reproduce this issue: set a dark colours theme and oxygen icons, close all tabs in one panel and observe disabled icon in Window menu's Close Current Tab action. Try this with master
branch and with fix-missing-icons branch.

Sat, Apr 21, 5:21 PM · Krusader
asensi accepted D12338: Panel: fixed invisible column issue.
Sat, Apr 21, 6:41 AM · Krusader

Fri, Apr 20

asensi added a comment to D10352: Fix insufficient icon theme issues.

More screenshots:

Fri, Apr 20, 8:17 PM · Krusader
asensi added a comment to D12338: Panel: fixed invisible column issue.

Using Ubuntu 18.04 daily build: I could reproduce the problem, and it was solved by the patch made by Nikita. Thanks, Nikita!

Fri, Apr 20, 5:40 PM · Krusader

Thu, Apr 19

asensi added a comment to D12338: Panel: fixed invisible column issue.

Hello! I can't reproduce the "fixed invisible column" issue, so I attach some screenshots and "krusaderrc" files, if it may help:

Thu, Apr 19, 10:20 AM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

With the latest improvements made by Nikita, In an Ubuntu 18.04 daily build virtual machine, the icons were shown as it was expected:

Thu, Apr 19, 8:05 AM · Krusader

Sun, Apr 15

asensi added a comment to D10352: Fix insufficient icon theme issues.

Regarding the greyed out icons in Krusader: I believe this is because "breeze" is set
as system theme (not "breeze-dark") and fallback is also set as "breeze", so
there is no "breeze-dark" to fallback to.

Sun, Apr 15, 1:55 PM · Krusader

Sat, Apr 14

asensi added a comment to D10352: Fix insufficient icon theme issues.

Then the appearance of Krusader is improved when using Ubuntu 18.04 daily build (without having Breeze nor Oxygen installed):

Sat, Apr 14, 5:02 PM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

Note: That "icon-missing.svgz" file can be downloaded from https://phabricator.kde.org/file/download/ieoxfxmcslybdhrcwkhf/PHID-FILE-zues6xeejyrafgjglyel/icon-missing.svgz

Sat, Apr 14, 3:58 PM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

Thanks, Nikita! A lot of work! I also wanted to say that, using Ubuntu 18.04 beta, I saw that error message when building Krusader (the "icon-missing.svgz" file was not found):

[ 84%] Built target krusader_autogen
make[2]: *** No hay ninguna regla para construir el objetivo '/home/user/krusader/krusader/icons/icon-missing.svgz', necesario para 'krusader/qrc_resources.cpp'.  Alto.
CMakeFiles/Makefile2:222: recipe for target 'krusader/CMakeFiles/krusader.dir/all' failed
make[1]: *** [krusader/CMakeFiles/krusader.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2
Sat, Apr 14, 3:34 PM · Krusader

Mon, Apr 9

asensi added a comment to D10352: Fix insufficient icon theme issues.

I'm fine with "emblem-unreadable" although my preference would rather be "image-missing" :).

Mon, Apr 9, 8:23 PM · Krusader

Sat, Apr 7

asensi committed R167:88d4080b368b: An update to the INSTALL file, in order to avoid a CMake error (authored by asensi).
An update to the INSTALL file, in order to avoid a CMake error
Sat, Apr 7, 6:08 PM
asensi closed D11975: An update to the INSTALL file, in order to avoid a CMake error.
Sat, Apr 7, 6:08 PM · Krusader

Fri, Apr 6

asensi added a comment to D10352: Fix insufficient icon theme issues.

When using Kubuntu 17.10:

Fri, Apr 6, 2:43 PM · Krusader
asensi updated the summary of D11975: An update to the INSTALL file, in order to avoid a CMake error.
Fri, Apr 6, 2:33 PM · Krusader

Thu, Apr 5

asensi updated the summary of D11975: An update to the INSTALL file, in order to avoid a CMake error.
Thu, Apr 5, 10:38 PM · Krusader
asensi requested review of D11975: An update to the INSTALL file, in order to avoid a CMake error.
Thu, Apr 5, 10:38 PM · Krusader
asensi accepted D11898: Implemented bookmark quick search.
Thu, Apr 5, 10:19 PM · Krusader

Wed, Apr 4

asensi accepted D11906: Fix casesensitive search for quicksearch-bookmark.

It worked as it is expected, OK!

Wed, Apr 4, 12:54 PM · Krusader
asensi added a comment to D11906: Fix casesensitive search for quicksearch-bookmark.

Hi! I'm using the "bookmark-quicksearch" branch, and I have applied the present diff, which is:

diff --git a/krusader/BookMan/krbookmarkhandler.cpp b/krusader/BookMan/krbookmarkhandler.cpp
--- a/krusader/BookMan/krbookmarkhandler.cpp
+++ b/krusader/BookMan/krbookmarkhandler.cpp
@@ -592,12 +592,12 @@
            return true;
        }
Wed, Apr 4, 12:29 PM · Krusader
asensi added a comment to D11903: Fix multirename shortcut.

Thanks for improving consistency!

I propose we add CHANGED: ... to commit message, so it goes to the ChangeLog.

Wed, Apr 4, 9:08 AM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

Toni, thanks a lot for testing this! Quick question: is Breeze installed in both of these cases or not?

Wed, Apr 4, 8:44 AM · Krusader

Tue, Apr 3

asensi added a comment to D10352: Fix insufficient icon theme issues.

After executing sudo apt install breeze (and applying the present differential, compiling, and installing Krusader), this is a screenshot of Krusader in the same Ubuntu 18.04 daily build virtual machine:

Tue, Apr 3, 11:53 PM · Krusader
asensi added a comment to D11898: Implemented bookmark quick search.

Thank you, all!

Tue, Apr 3, 3:49 PM · Krusader
asensi accepted D11903: Fix multirename shortcut.

I also added a "tag" named "Krusader" and so:

Tue, Apr 3, 2:55 PM · Krusader
asensi added a project to D11903: Fix multirename shortcut: Krusader.
Tue, Apr 3, 2:51 PM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

Mu upgrade looks like this:
Qt: 5.7.1 -> 5.9.4
KF: 5.40 -> 5.43
kde-apps: 17.08.3 -> 17.12.3

Tue, Apr 3, 8:10 AM · Krusader

Mon, Mar 26

asensi added a comment to D11593: Fixed warnings that appear when building release version.

BTW, it's not just my compiler settings, Toni also confirmed this earlier [...]

Mon, Mar 26, 6:10 PM · Krusader

Mar 11 2018

asensi accepted D11222: Fix activating a found item with hash in URL inside search dialog..

Thank you, Martin! For my part, my performed tests (using Kubuntu 17.10) went alright:

Mar 11 2018, 6:48 PM · Krusader
asensi accepted D11221: Fix current item selection after exiting a tar archive.

Thank you, Martin! For my part, my performed tests (using Kubuntu 17.10) went alright, including those tests that were already mentioned:

  • go up in standard local FS
  • go up outside an archive (with krarc protocol)
  • go up outside an archive (with tar protocol)
Mar 11 2018, 6:46 PM · Krusader

Mar 10 2018

asensi accepted D10307: Add Tab Pinning Feature.

Thank you, Martin! (and Nikita :-)! For my part, my performed tests (using Kubuntu 17.10) went alright, including those already mentioned tests:

  • pin a tab, browse in it, activate another tab in the same panel, reactivate pinned tab -> it should return to the pinned address
  • pin a tab, restart Krusader -> pinning should still be active, same for saved profiles
  • pin a tab, change directory in it, duplicate it -> check that original tab stays pinned and its title is not changed, check that duplicated tab is not pinned and its path is correct (meaning - not the pinned one)

Other people can do their checks :-)

Mar 10 2018, 6:58 PM · Krusader
asensi accepted D10987: Add action 'Open MountMan' to MountMan submenu.

Thank you, Martin! (and Nikita :-)! For my part, my performed tests (using Kubuntu 17.04) went alright. Other people can do their checks.

Mar 10 2018, 4:03 PM · Krusader

Feb 28 2018

asensi added a comment to D10817: Fix compiler warning on GCC <= 7.

Just to confirm, do you guys see the other 3 warnings with gcc < 7?

Feb 28 2018, 7:28 AM · Krusader

Feb 27 2018

asensi committed R167:ce6372fe25ee: In the INSTALL file: add an additional check (authored by asensi).
In the INSTALL file: add an additional check
Feb 27 2018, 11:22 PM
asensi closed D10898: In the INSTALL file: add an additional check.
Feb 27 2018, 11:22 PM · Krusader
asensi added a comment to D10817: Fix compiler warning on GCC <= 7.

It also works using gcc 5.4.0 under Ubuntu 16.04 LTS (its latest Long Term Service version). Thanks!

Feb 27 2018, 6:24 PM · Krusader
asensi requested review of D10898: In the INSTALL file: add an additional check.
Feb 27 2018, 6:14 PM · Krusader

Feb 24 2018

asensi accepted D9041: Ability to ignore defined files and directories from search results.

I've changed delimiter to space and used KShell::splitArgs() method to allow using

  • quoted folder names
  • folder names with escaped spaces
Feb 24 2018, 10:57 AM · Krusader
asensi committed R167:0e0f4ae6dd34: Changes in the "desktop" file to achieve that Krusader can be added to… (authored by asensi).
Changes in the "desktop" file to achieve that Krusader can be added to…
Feb 24 2018, 9:31 AM
asensi closed D10746: Changes in the "desktop" file to achieve that Krusader can be added to favorites in Gnome Dock.
Feb 24 2018, 9:31 AM · Krusader
asensi updated the diff for D10746: Changes in the "desktop" file to achieve that Krusader can be added to favorites in Gnome Dock.

Now the names of Jakub Buczak (Jakkubu) and Nate Graham are mentioned in the commit.

Feb 24 2018, 9:07 AM · Krusader

Feb 22 2018

asensi requested review of D10746: Changes in the "desktop" file to achieve that Krusader can be added to favorites in Gnome Dock.
Feb 22 2018, 2:23 PM · Krusader
asensi added a comment to D9041: Ability to ignore defined files and directories from search results.

For more consistency, I'm thinking that, if in the "Search for:" text field, Krusader users space as a delimiter... maybe it would also use it in the same window, in the proposed «Exclude Folder Names» text field.

Feb 22 2018, 9:46 AM · Krusader

Feb 21 2018

asensi accepted D9041: Ability to ignore defined files and directories from search results.

Thank you! For my part, I accept this because I performed some tests and the new patch worked correctly (items inside the specified folders are excluded, files and folders that are shown are the expected ones, etc.), although when there was a folder with a ":" inside its name then the folder couldn't be excluded.

Feb 21 2018, 5:40 PM · Krusader
asensi accepted D10608: Closing calculate occupied space window aborts the calculation.

Thanks Davide! The changes that Nikita (nmel) wrote are also improvements. For my part, I accept this because my performed tests (using Kubuntu 17.10) seemed to work correctly.

Feb 21 2018, 11:33 AM · Krusader

Feb 17 2018

asensi added a project to D10385: Fix setting new current item after file deletion: Krusader.
Feb 17 2018, 11:44 AM · Krusader

Feb 16 2018

asensi added a comment to D10352: Fix insufficient icon theme issues.

Application specific icons should be provided by the application.

Feb 16 2018, 1:24 PM · Krusader
asensi accepted D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Thanks, Toni, for trying it out! :-)

Feb 16 2018, 10:50 AM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

My favourite is 2A :).

Feb 16 2018, 10:42 AM · Krusader

Feb 9 2018

asensi added a comment to D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Hi! I tried the patch, using Kubuntu 17.10, and everything seems to work correctly.

Feb 9 2018, 9:12 AM · Krusader

Feb 8 2018

asensi added a comment to D10385: Fix setting new current item after file deletion.

Note: This is related to

https://bugs.kde.org/show_bug.cgi?id=389869
Feb 8 2018, 1:47 PM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

As Andreas Kainz has updated Oxygen icons (very good!), now Breeze and Oxygen have all the icons that Krusader needs, there are more details in:

https://bugs.kde.org/show_bug.cgi?id=388691
https://commits.kde.org/oxygen-icons5/857400cb1a51f2287e4b6b285bba0f897066a6f7
Feb 8 2018, 9:51 AM · Krusader

Jan 22 2018

asensi added a comment to D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Because you added this

Jan 22 2018, 9:27 PM · Krusader

Sep 29 2017

asensi accepted D7974: Fix mkdir and mkpath for krarc protocol.

For my part, I accept this because my performed tests (using Kubuntu 17.04) went alright.

Sep 29 2017, 10:00 PM · Krusader

Sep 1 2017

asensi accepted D7610: Support for "mkdir -p" re-added.

For my part, I accept this because my performed tests went alright. Other people can do their checks.

Sep 1 2017, 9:58 PM · Krusader
asensi accepted D5734: Fix lister unintended selection while scrolling.

For my part, I accept this because every of my performed tests has been successful, even the "selected characters" test :-). Other people can do their checks.

Sep 1 2017, 9:06 PM · Krusader

Aug 30 2017

asensi added a comment to D5734: Fix lister unintended selection while scrolling.

I've found one other issue myself today - zooming out would cause that there are too many characters on one line
not fitting the viewport width. This should now be fixed, too.

Aug 30 2017, 8:24 AM · Krusader

Aug 29 2017

asensi added a comment to D5734: Fix lister unintended selection while scrolling.

With the latest improvements, at least using Kubuntu 17.04, not everything was perfect :-) :

  • if the user utilizes Lister to see a file like the "bashrc" attached one and then presses PgDown a lot of times: the scroll doesn't stop at the end of the file.
  • if the user utilizes Lister to see a file like the "profile" attached one and then presses PgDown: the cursor does not move.
  • if the user utilizes Lister to see a file like the "profile" attached one and then presses Ctrl+End: the cursor does not move.
Aug 29 2017, 10:51 AM · Krusader

Aug 28 2017

asensi moved T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window) from In progress to Done on the Krusader board.
Aug 28 2017, 11:03 PM · Krusader
asensi moved T1971: Opening Big File Warning from In progress to Done on the Krusader board.
Aug 28 2017, 11:03 PM · Krusader
asensi closed T5716: New release: 2.6.0 as Resolved.

Marked as "Closed, Resolved". Thanks for the good work!

Aug 28 2017, 11:02 PM · Krusader
asensi closed T3770: New Release as Resolved.

Marked as "Closed, Resolved". Thanks for the good work!

Aug 28 2017, 11:01 PM · Krusader
asensi closed T6870: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader as Resolved.

After the changes:
This is the beginning of the README file as it's seen in https://phabricator.kde.org/source/krusader/:

Aug 28 2017, 10:57 PM · Krusader
asensi committed R167:093230e50750: Changes in the README to be better seen on https://phabricator.kde. (authored by asensi).
Changes in the README to be better seen on https://phabricator.kde.
Aug 28 2017, 10:42 PM
asensi closed D7557: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader by committing R167:093230e50750: Changes in the README to be better seen on https://phabricator.kde..
Aug 28 2017, 10:42 PM · Krusader

Aug 26 2017

asensi added a comment to T6870: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.

Note:
This is the beginning of the README file as it's seen nowadays in https://phabricator.kde.org/source/krusader/:

Aug 26 2017, 12:43 PM · Krusader
asensi added a task to D7557: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader: T6870: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.
Aug 26 2017, 12:42 PM · Krusader
asensi added a revision to T6870: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader: D7557: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.
Aug 26 2017, 12:42 PM · Krusader
asensi created T6870: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.
Aug 26 2017, 12:42 PM · Krusader
asensi added a comment to D7557: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.

This is the beginning of the README file as it's seen nowadays in https://phabricator.kde.org/source/krusader/:

Aug 26 2017, 12:38 PM · Krusader
asensi created D7557: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.
Aug 26 2017, 12:35 PM · Krusader

Aug 4 2017

asensi closed T3419: Rework of VFS (Now: FileSystem) as Resolved.

Marked as "Closed, Resolved" (it was "Open, Needs Triage"). Thanks for the good work!

Aug 4 2017, 8:20 PM · Krusader

Aug 2 2017

asensi accepted D6850: KrViewer looses focus - fixed.

It can be compiled and executed using Kubuntu 17.04, and everything seems to work correctly :-)

Aug 2 2017, 10:26 PM · Krusader

Jul 23 2017

asensi added a comment to T1971: Opening Big File Warning.

The improvement seems to work nicely (tried using Kubuntu 17.04). Congratulations!

Jul 23 2017, 11:44 AM · Krusader
asensi closed T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window) as Resolved.

The improvement seems to work nicely (tried using Kubuntu 17.04). Congratulations!

Jul 23 2017, 11:43 AM · Krusader

May 7 2017

asensi accepted D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

This patch is just a proposal to remove this feature and leave user's clipboard alone.

May 7 2017, 9:57 PM · Krusader

Mar 8 2017

asensi added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

I've just tried it in a clean Kubuntu 16.10 virtual machine, if anyone wants to try it too.

Mar 8 2017, 11:26 PM
asensi added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

Hi!
I executed

Mar 8 2017, 3:44 PM

Mar 4 2017

asensi added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

Hi!
Using Kubuntu 16.10: that patch works if the password has been typed recently, if it's not that way, if you already had an opened Kate, then you are asked for a password but after typing it nothing happens.
I'm available to perform more tests. Thanks.

Mar 4 2017, 10:38 AM

Feb 25 2017

asensi added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

If it may be helpful, as it was previously written, in the comments of https://blog.martin-graesslin.com/blog/2017/02/editing-files-as-root/ it's stated that for example if you are already using Kate, and then you execute sudoedit to use Kate to edit a file: the user sees an error message, he isn't really able to edit the file he wanted, etc.

Feb 25 2017, 12:18 PM

Feb 23 2017

asensi added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I am suggesting a third: make Krusader in root mode unnecessary because people can elevate for specific operations as opposed to constantly running in elevated mode.

Feb 23 2017, 3:12 PM
asensi added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

you shouldn't run graphical applications as root

Feb 23 2017, 11:53 AM

Feb 15 2017

asensi accepted D4609: Improved integration of (quick) search bar in panel.

Great! It gets compiled using Kubuntu 16.10 and also the bug 375639 seems to be solved, thank you very much, Alex!

Feb 15 2017, 8:57 AM
asensi accepted D4512: Rework of vfile and KrPermHandler class.

The code is cleaner now :-), it also gets compiled using Kubuntu 16.04 and seems to work correctly :-), thank you, Alex!

Feb 15 2017, 8:55 AM

Feb 11 2017

asensi added a comment to D2857: Use KRun for "Open with"->"Other..." dialog.

Is the working directory really important for (any) application?

Feb 11 2017, 2:36 PM
asensi accepted D4418: #314258 - Duplicate tab settings when duplicating tabs.

It can be compiled and executed using Kubuntu 16.04 or 16.10, and everything seems to work correctly :-), thanks Wladimir!

Feb 11 2017, 2:23 PM · Krusader

Feb 8 2017

asensi accepted D4146: ListPanel: don't go back in history if refresh failed.

This changes the refresh behavior of the list panel to stay at the URL which failed to refresh, instead of going back in
the panel's history until the refresh is successful.

Feb 8 2017, 9:06 AM · Krusader
asensi accepted D4420: #375894 - Use case-insensitive as default for text search.
Feb 8 2017, 8:58 AM · Krusader
asensi added a comment to D4420: #375894 - Use case-insensitive as default for text search.

As far as GUI tools go, I don't know any where case-sensitive search would be the default, and I wouldn't expect it either.

Feb 8 2017, 8:51 AM · Krusader

Feb 5 2017

asensi added a comment to T5062: Improve search results tab.

This mockup is great but implementation will certainly take time. Unless somebody plans to work on this really soon, maybe a simpler solution
is worth considering: when opening the viewer from the file search with non-empty text, do a search for this text in the viewer automatically.
So the first result line should be selected immediately and pressing F3 should bring up the other matches. That's what Total Commander does.
These proposals aren't mutually exclusive of course.

Feb 5 2017, 6:25 PM · Krusader
asensi added a comment to D4427: Update "get involved" page to indicate how one can register.

It's better this way, thanks, Wladimir!

Feb 5 2017, 8:03 AM · Websites, Krusader
asensi accepted D4433: #375994 - List kio-extras under dependencies as recommended package.

Very good! Thanks, Wladimir!

Feb 5 2017, 7:53 AM · Krusader
asensi accepted D4417: #375831 - Sort empty file extensions correctly.

Nice! Thanks, Wladimir!

Feb 5 2017, 7:50 AM · Krusader
asensi accepted D4419: #375830 - Don't send SIGINT to terminal emulator unnecessarily.

Great! Thanks, Wladimir!

Feb 5 2017, 7:47 AM · Krusader

Jan 29 2017

asensi added a comment to D4316: Panel/VFS: Rework of deletion/moveToTrash/virtualRemove of files and directories.

Thank you very much!

Jan 29 2017, 9:10 AM

Jan 28 2017

asensi committed R167:50562722fcf3: A line was split so that it followed the same style as the other lines. (authored by asensi).
A line was split so that it followed the same style as the other lines.
Jan 28 2017, 9:05 PM
asensi committed R167:f0afeb30267e: Added: 1) A change in order to accelerate the compilation process. 2) An… (authored by asensi).
Added: 1) A change in order to accelerate the compilation process. 2) An…
Jan 28 2017, 9:05 PM
asensi closed D4195: Changes in the installation documentation (2) - Web pages.
Jan 28 2017, 7:00 PM · Krusader, Websites