asensi (Toni Asensi Esteve)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 20 2016, 4:24 PM (117 w, 3 d)
Availability
Available

Recent Activity

Today

asensi accepted D13626: KIso: Fixed file offsets of the underlying IO device.

Thank you all! For my part, using Kubuntu 18.04: my performed tests went alright; some files (inside an iso file) that could not be seen, now can be seen correctly. Other people can do their checks.

Wed, Jun 20, 2:54 PM · Krusader

Sun, Jun 17

asensi accepted D13572: Panel: Always delete files by their URL.

Note: The tag "Krusader" was added to the present differential revision so that it's seen now at least in https://phabricator.kde.org/project/view/79/ and https://phabricator.kde.org/tag/krusader/ , and consequently more people may review this proposal.

Sun, Jun 17, 1:48 PM · Krusader
asensi added a project to D13572: Panel: Always delete files by their URL: Krusader.
Sun, Jun 17, 1:46 PM · Krusader
asensi abandoned D13497: Files fed to listbox can be deleted.

Nice! There's more information in https://phabricator.kde.org/D13572

Sun, Jun 17, 1:44 PM · Krusader

Thu, Jun 14

asensi added a comment to D13499: End a quicksearch after an item has been found.

Was it changed for a reason?

Thu, Jun 14, 11:20 AM · Krusader
asensi added a comment to D13497: Files fed to listbox can be deleted.

I confirm what Nikita tried.

Thu, Jun 14, 11:08 AM · Krusader

Wed, Jun 13

asensi added a comment to D13497: Files fed to listbox can be deleted.

Also, using Krusader 2.4.0-beta3, when "files fed to list box" are deleted... they are physically deleted.

Wed, Jun 13, 5:00 PM · Krusader
asensi added a comment to D13497: Files fed to listbox can be deleted.

> Removal of items from virtual lists is not a very handful feature after all...

Wed, Jun 13, 10:57 AM · Krusader
asensi added a comment to D13499: End a quicksearch after an item has been found.

I think the current behavior is useful as is, i.e. keep the search active unless the dir is changed. Let's discuss more and
consider implementing an option to keep current behavior.

Wed, Jun 13, 9:54 AM · Krusader

Tue, Jun 12

asensi requested review of D13499: End a quicksearch after an item has been found.
Tue, Jun 12, 6:31 PM · Krusader
asensi requested review of D13497: Files fed to listbox can be deleted.
Tue, Jun 12, 5:17 PM · Krusader

Mon, Jun 11

asensi accepted D13443: Fixed using Numeric Keypad in the quick search mode.

Many thanks, Nikita! For my part, my performed tests (using Kubuntu 18.04) went alright.

Mon, Jun 11, 6:50 PM · Krusader

May 19 2018

asensi closed D12906: Unselect all items when calculating occupied space on "..".

Thanks! Davide's commit is available for viewing at https://commits.kde.org/krusader/eb60c734b940063f61064c5bcd25ae448b8aa610

May 19 2018, 12:01 PM · Krusader

May 18 2018

asensi added a comment to D12904: Fixed ugly message dialog on Compare by Content error.

Thank you for your interest, Safa. Patches are welcome :-)

May 18 2018, 5:40 PM · Krusader

May 17 2018

asensi accepted D12906: Unselect all items when calculating occupied space on "..".

For my part, my performed tests went also OK!

May 17 2018, 9:27 PM · Krusader
asensi added a comment to D12904: Fixed ugly message dialog on Compare by Content error.

Just one minor suggestion: rename "Ugly message dialog on Compare by Content error" with "Fixed ugly message dialog on Compare by Content error" so others will know you haven't introduced anything ugly :)

May 17 2018, 9:03 PM · Krusader
asensi accepted D12904: Fixed ugly message dialog on Compare by Content error.

For my part, my performed tests went alright!

May 17 2018, 8:54 PM · Krusader
asensi accepted D12640: Replace default search bar search mode setting with dedicated shortcuts.

Ctrl+Shift+S is available, where S is for selection. I'm also fine with the default Ctrl+G. Since users can easily remap, it's not a big deal.

May 17 2018, 8:32 PM

May 11 2018

asensi accepted D12818: Updates related to v2.7 release.
May 11 2018, 8:24 PM · Krusader

May 9 2018

asensi accepted D12753: Released v2.7.0.

I accept the proposal. Thanks, Yuri and Nikita!

May 9 2018, 7:36 PM · Krusader

May 8 2018

asensi created T8662: In the developer documentation: add more files that have to be changed when a new Krusader version is released.
May 8 2018, 6:15 PM · Krusader
asensi created T8661: In the developer documentation: add how to know when a Krusader bug report is created (or changed).
May 8 2018, 5:59 PM · Krusader
asensi added a comment to D12640: Replace default search bar search mode setting with dedicated shortcuts.

With the proposed change: things would be better, although Nikita's way of working would be an additional advantage. Thanks!

May 8 2018, 5:52 PM
asensi added a comment to D12753: Released v2.7.0.

Check if anything else should be updated.

May 8 2018, 5:34 PM · Krusader

May 3 2018

asensi committed R938:3d5726caeedc: Updated some descriptions, web links, names, author and thanks lists (authored by asensi).
Updated some descriptions, web links, names, author and thanks lists
May 3 2018, 1:47 PM
asensi closed D12644: Updated some descriptions, web links, names, author and thanks lists.

The commit is available for viewing at https://commits.kde.org/websites/krusader-org/3d5726caeedc4fd544751202eb9e0f5930cfb218

May 3 2018, 9:01 AM · Krusader
asensi retitled D12644: Updated some descriptions, web links, names, author and thanks lists from Update several web pages because of 1) some changes that were pending 2) some other related changes to Updated some descriptions, web links, names, author and thanks lists.
May 3 2018, 8:51 AM · Krusader
asensi added a comment to D12644: Updated some descriptions, web links, names, author and thanks lists.

Indeed. Maybe something like "Updated descriptions, author and thanks lists". This is what you did, isn't it?

May 3 2018, 8:51 AM · Krusader

May 2 2018

asensi accepted D12640: Replace default search bar search mode setting with dedicated shortcuts.

Thank you, Alex! For my part, my performed tests using Kubuntu 18.04 went alright, and I find it easier now to filter, to search, and to select. Great!

May 2 2018, 11:53 AM
asensi committed R167:6e9de699d944: Updated the INSTALL file. Added some steps to follow if Krusader is already… (authored by asensi).
Updated the INSTALL file. Added some steps to follow if Krusader is already…
May 2 2018, 11:47 AM
asensi updated the diff for D12644: Updated some descriptions, web links, names, author and thanks lists.

Some changes (proposed by Nikita Melnichenko) were made:

May 2 2018, 11:37 AM · Krusader
asensi added a comment to D12600: Updated the INSTALL file. Added some steps to follow if Krusader is already installed.

Closed because of https://commits.kde.org/krusader/6e9de699d94414dd58d0ffe1aec3dc142705eb1b

May 2 2018, 11:30 AM · Krusader
asensi closed D12600: Updated the INSTALL file. Added some steps to follow if Krusader is already installed.
May 2 2018, 11:28 AM · Krusader
asensi added a comment to D12600: Updated the INSTALL file. Added some steps to follow if Krusader is already installed.

Ok!

May 2 2018, 11:23 AM · Krusader

May 1 2018

asensi updated the diff for D12644: Updated some descriptions, web links, names, author and thanks lists.

A reference to KDE Plasma 4 was changed.

May 1 2018, 9:24 PM · Krusader
asensi requested review of D12644: Updated some descriptions, web links, names, author and thanks lists.
May 1 2018, 7:19 PM · Krusader
asensi updated the diff for D12600: Updated the INSTALL file. Added some steps to follow if Krusader is already installed.

Some specifics were removed, in order to improve e.g. the maintainability.

May 1 2018, 8:48 AM · Krusader

Apr 30 2018

asensi updated the diff for D12600: Updated the INSTALL file. Added some steps to follow if Krusader is already installed.

Two texts were changed to save time to some readers.

Apr 30 2018, 8:54 PM · Krusader
asensi updated the diff for D12600: Updated the INSTALL file. Added some steps to follow if Krusader is already installed.

Two pages were created, and information was moved to those pages.

Apr 30 2018, 7:58 PM · Krusader
asensi edited the content of An output of make on Kubuntu 18.04.
Apr 30 2018, 7:50 PM · Krusader
asensi deleted An output of make on Kubuntu 18.04.
Apr 30 2018, 7:49 PM · Krusader
asensi renamed An output of cmake on Kubuntu 18.04 from Cmake-output to An output of cmake on Kubuntu 18.04.
Apr 30 2018, 7:47 PM · Krusader
asensi created An output of cmake on Kubuntu 18.04.
Apr 30 2018, 7:45 PM · Krusader
asensi created An output of make on Kubuntu 18.04.
Apr 30 2018, 7:41 PM · Krusader

Apr 29 2018

asensi requested review of D12600: Updated the INSTALL file. Added some steps to follow if Krusader is already installed.
Apr 29 2018, 5:08 PM · Krusader

Apr 27 2018

asensi added a comment to D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming.

Still giving a +1 for moving this into KIO so Gwenview and Krusader can use it too if they'd like.

Apr 27 2018, 4:32 PM · Dolphin
asensi accepted D12560: Updated release information in docs.

Thanks for the improvements, Nikita!

Apr 27 2018, 11:59 AM · Krusader
asensi committed R167:53a5e29ccc44: Changes in several files because, by default, F2 renames and F9 opens a… (authored by asensi).
Changes in several files because, by default, F2 renames and F9 opens a…
Apr 27 2018, 11:44 AM
asensi closed D12524: Changes in several files because, by default, F2 renames and F9 opens a terminal window.
Apr 27 2018, 11:44 AM · Krusader
asensi retitled D12524: Changes in several files because, by default, F2 renames and F9 opens a terminal window from Changes in several files because normally F2 renames and F9 opens a terminal window to Changes in several files because, by default, F2 renames and F9 opens a terminal window.
Apr 27 2018, 11:43 AM · Krusader

Apr 26 2018

asensi added a comment to D12524: Changes in several files because, by default, F2 renames and F9 opens a terminal window.
In D12524#254087, @nmel wrote:

Nice catch, Toni. [...]
[Do I recall correctly that Totcmd doesn't have any of these shortcuts: Rename, Terminal, Multirename? I don't remember exactly because I probably had defined them a long time ago as I use F2 and F9 without hassle. :) ]

Apr 26 2018, 8:28 AM · Krusader
asensi updated the diff for D12524: Changes in several files because, by default, F2 renames and F9 opens a terminal window.

The commit message was updated accordingly.

Apr 26 2018, 8:27 AM · Krusader
asensi updated the diff for D12524: Changes in several files because, by default, F2 renames and F9 opens a terminal window.

Some related changes were made, including one in a docbook file.

Apr 26 2018, 7:32 AM · Krusader
asensi added a comment to D12524: Changes in several files because, by default, F2 renames and F9 opens a terminal window.

(independent of the patch) IMO, what a bad name scheme is picked for the actions. Names shouldn't contain default values. A better naming could be` FN_Rename` if one would like to denote these belong to the functional keys bar.

Apr 26 2018, 7:30 AM · Krusader

Apr 25 2018

asensi accepted D12487: Updated git ignore file.

Thanks for the work you put on it!

Apr 25 2018, 9:32 PM · Krusader
asensi updated the test plan for D12524: Changes in several files because, by default, F2 renames and F9 opens a terminal window.
Apr 25 2018, 9:29 PM · Krusader
asensi accepted D12486: Cleaned up old auxiliary files, updated references and fixed layout in docs.

Thanks Nikita!

Apr 25 2018, 6:40 PM · Krusader
asensi requested review of D12524: Changes in several files because, by default, F2 renames and F9 opens a terminal window.
Apr 25 2018, 6:38 PM · Krusader

Apr 22 2018

asensi accepted D10352: Fix insufficient icon theme issues.

Toni, please accept this revision if you think it's good to merge with master.

Apr 22 2018, 4:42 PM · Krusader
asensi added a comment to D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming.

Pinging @asensi on whether this would be a good addition to the Krusader project so then we can consider moving it to KIO).

Apr 22 2018, 4:35 PM · Dolphin

Apr 21 2018

asensi added a comment to D10352: Fix insufficient icon theme issues.

To reproduce this issue: set a dark colours theme and oxygen icons, close all tabs in one panel and observe disabled icon in Window menu's Close Current Tab action. Try this with master
branch and with fix-missing-icons branch.

Apr 21 2018, 5:21 PM · Krusader
asensi accepted D12338: Panel: fixed invisible column issue.
Apr 21 2018, 6:41 AM · Krusader

Apr 20 2018

asensi added a comment to D10352: Fix insufficient icon theme issues.

More screenshots, using included icons in Kubuntu 17.10:

Apr 20 2018, 8:17 PM · Krusader
asensi added a comment to D12338: Panel: fixed invisible column issue.

Using Ubuntu 18.04 daily build: I could reproduce the problem, and it was solved by the patch made by Nikita. Thanks, Nikita!

Apr 20 2018, 5:40 PM · Krusader

Apr 19 2018

asensi added a comment to D12338: Panel: fixed invisible column issue.

Hello! I can't reproduce the "fixed invisible column" issue, so I attach some screenshots and "krusaderrc" files, if it may help:

Apr 19 2018, 10:20 AM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

With the latest improvements made by Nikita, In an Ubuntu 18.04 daily build virtual machine, and in a Kubuntu 17.10 virtual machine, the icons were shown as it was expected:

Apr 19 2018, 8:05 AM · Krusader

Apr 15 2018

asensi added a comment to D10352: Fix insufficient icon theme issues.

Regarding the greyed out icons in Krusader: I believe this is because "breeze" is set
as system theme (not "breeze-dark") and fallback is also set as "breeze", so
there is no "breeze-dark" to fallback to.

Apr 15 2018, 1:55 PM · Krusader

Apr 14 2018

asensi added a comment to D10352: Fix insufficient icon theme issues.

With the proposed changes:

Apr 14 2018, 5:02 PM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

Note: That "icon-missing.svgz" file can be downloaded from https://phabricator.kde.org/file/download/ieoxfxmcslybdhrcwkhf/PHID-FILE-zues6xeejyrafgjglyel/icon-missing.svgz

Apr 14 2018, 3:58 PM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

Thanks, Nikita! A lot of work! I also wanted to say that, after applying the diff file, using Ubuntu 18.04 daily build, I saw that error message when building Krusader (because the "icon-missing.svgz" file was not found):

[ 84%] Built target krusader_autogen
make[2]: *** No hay ninguna regla para construir el objetivo '/home/user/krusader/krusader/icons/icon-missing.svgz', necesario para 'krusader/qrc_resources.cpp'.  Alto.
CMakeFiles/Makefile2:222: recipe for target 'krusader/CMakeFiles/krusader.dir/all' failed
make[1]: *** [krusader/CMakeFiles/krusader.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2
Apr 14 2018, 3:34 PM · Krusader

Apr 9 2018

asensi added a comment to D10352: Fix insufficient icon theme issues.

I'm fine with "emblem-unreadable" although my preference would rather be "image-missing" :).

Apr 9 2018, 8:23 PM · Krusader

Apr 7 2018

asensi committed R167:88d4080b368b: An update to the INSTALL file, in order to avoid a CMake error (authored by asensi).
An update to the INSTALL file, in order to avoid a CMake error
Apr 7 2018, 6:08 PM
asensi closed D11975: An update to the INSTALL file, in order to avoid a CMake error.
Apr 7 2018, 6:08 PM · Krusader

Apr 6 2018

asensi added a comment to D10352: Fix insufficient icon theme issues.

When using Kubuntu 17.10:

Apr 6 2018, 2:43 PM · Krusader
asensi updated the summary of D11975: An update to the INSTALL file, in order to avoid a CMake error.
Apr 6 2018, 2:33 PM · Krusader

Apr 5 2018

asensi updated the summary of D11975: An update to the INSTALL file, in order to avoid a CMake error.
Apr 5 2018, 10:38 PM · Krusader
asensi requested review of D11975: An update to the INSTALL file, in order to avoid a CMake error.
Apr 5 2018, 10:38 PM · Krusader
asensi accepted D11898: Implemented bookmark quick search.
Apr 5 2018, 10:19 PM · Krusader

Apr 4 2018

asensi accepted D11906: Fix casesensitive search for quicksearch-bookmark.

It worked as it is expected, OK!

Apr 4 2018, 12:54 PM · Krusader
asensi added a comment to D11906: Fix casesensitive search for quicksearch-bookmark.

Hi! I'm using the "bookmark-quicksearch" branch, and I have applied the present diff, which is:

diff --git a/krusader/BookMan/krbookmarkhandler.cpp b/krusader/BookMan/krbookmarkhandler.cpp
--- a/krusader/BookMan/krbookmarkhandler.cpp
+++ b/krusader/BookMan/krbookmarkhandler.cpp
@@ -592,12 +592,12 @@
            return true;
        }
Apr 4 2018, 12:29 PM · Krusader
asensi added a comment to D11903: Fix multirename shortcut.

Thanks for improving consistency!

I propose we add CHANGED: ... to commit message, so it goes to the ChangeLog.

Apr 4 2018, 9:08 AM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

Toni, thanks a lot for testing this! Quick question: is Breeze installed in both of these cases or not?

Apr 4 2018, 8:44 AM · Krusader

Apr 3 2018

asensi added a comment to D10352: Fix insufficient icon theme issues.

In the same Ubuntu 18.04 daily build virtual machine, after applying the present differential:

Apr 3 2018, 11:53 PM · Krusader
asensi added a comment to D11898: Implemented bookmark quick search.

Thank you all!

Apr 3 2018, 3:49 PM · Krusader
asensi accepted D11903: Fix multirename shortcut.

I also added a "tag" named "Krusader" and so:

Apr 3 2018, 2:55 PM · Krusader
asensi added a project to D11903: Fix multirename shortcut: Krusader.
Apr 3 2018, 2:51 PM · Krusader
asensi added a comment to D10352: Fix insufficient icon theme issues.

My upgrade looks like this:
Qt: 5.7.1 -> 5.9.4
KF: 5.40 -> 5.43
kde-apps: 17.08.3 -> 17.12.3

Apr 3 2018, 8:10 AM · Krusader

Mar 26 2018

asensi added a comment to D11593: Fixed warnings that appear when building release version.

BTW, it's not just my compiler settings, Toni also confirmed this earlier [...]

Mar 26 2018, 6:10 PM · Krusader

Mar 11 2018

asensi accepted D11222: Fix activating a found item with hash in URL inside search dialog..

Thank you, Martin! For my part, my performed tests (using Kubuntu 17.10) went alright:

Mar 11 2018, 6:48 PM · Krusader
asensi accepted D11221: Fix current item selection after exiting a tar archive.

Thank you, Martin! For my part, my performed tests (using Kubuntu 17.10) went alright, including those tests that were already mentioned:

  • go up in standard local FS
  • go up outside an archive (with krarc protocol)
  • go up outside an archive (with tar protocol)
Mar 11 2018, 6:46 PM · Krusader

Mar 10 2018

asensi accepted D10307: Add Tab Pinning Feature.

Thank you, Martin! (and Nikita :-)! For my part, my performed tests (using Kubuntu 17.10) went alright, including those already mentioned tests:

  • pin a tab, browse in it, activate another tab in the same panel, reactivate pinned tab -> it should return to the pinned address
  • pin a tab, restart Krusader -> pinning should still be active, same for saved profiles
  • pin a tab, change directory in it, duplicate it -> check that original tab stays pinned and its title is not changed, check that duplicated tab is not pinned and its path is correct (meaning - not the pinned one)

Other people can do their checks :-)

Mar 10 2018, 6:58 PM · Krusader
asensi accepted D10987: Add action 'Open MountMan' to MountMan submenu.

Thank you, Martin! (and Nikita :-)! For my part, my performed tests (using Kubuntu 17.04) went alright. Other people can do their checks.

Mar 10 2018, 4:03 PM · Krusader

Feb 28 2018

asensi added a comment to D10817: Fix compiler warning on GCC <= 7.

Just to confirm, do you guys see the other 3 warnings with gcc < 7?

Feb 28 2018, 7:28 AM · Krusader

Feb 27 2018

asensi committed R167:ce6372fe25ee: In the INSTALL file: add an additional check (authored by asensi).
In the INSTALL file: add an additional check
Feb 27 2018, 11:22 PM
asensi closed D10898: In the INSTALL file: add an additional check.
Feb 27 2018, 11:22 PM · Krusader
asensi added a comment to D10817: Fix compiler warning on GCC <= 7.

It also works using gcc 5.4.0 under Ubuntu 16.04 LTS (its latest Long Term Service version). Thanks!

Feb 27 2018, 6:24 PM · Krusader
asensi requested review of D10898: In the INSTALL file: add an additional check.
Feb 27 2018, 6:14 PM · Krusader

Feb 24 2018

asensi accepted D9041: Ability to ignore defined files and directories from search results.

I've changed delimiter to space and used KShell::splitArgs() method to allow using

  • quoted folder names
  • folder names with escaped spaces
Feb 24 2018, 10:57 AM · Krusader
asensi committed R167:0e0f4ae6dd34: Changes in the "desktop" file to achieve that Krusader can be added to… (authored by asensi).
Changes in the "desktop" file to achieve that Krusader can be added to…
Feb 24 2018, 9:31 AM
asensi closed D10746: Changes in the "desktop" file to achieve that Krusader can be added to favorites in Gnome Dock.
Feb 24 2018, 9:31 AM · Krusader