vandenoever (Jos van den Oever)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 9 2015, 3:00 PM (188 w, 4 d)
Availability
Available

Recent Activity

Yesterday

vandenoever added inline comments to D19107: Write valid UTF8 characters without escaping..
Mon, Feb 18, 9:50 PM · Frameworks
vandenoever updated the diff for D19107: Write valid UTF8 characters without escaping..
  • Remove VALUE define.
  • Spelling fix.
Mon, Feb 18, 9:50 PM · Frameworks
vandenoever added a reviewer for D19107: Write valid UTF8 characters without escaping.: thiago.
Mon, Feb 18, 9:46 PM · Frameworks

Sun, Feb 17

vandenoever requested review of D19107: Write valid UTF8 characters without escaping..
Sun, Feb 17, 10:40 PM · Frameworks

Wed, Feb 13

vandenoever committed R881:10ddeda5cbc5: Add placeholder variable name in generated code (authored by vandenoever).
Add placeholder variable name in generated code
Wed, Feb 13, 7:37 AM
vandenoever committed R881:c522870b79bb: Update version and ChangeLog (authored by vandenoever).
Update version and ChangeLog
Wed, Feb 13, 7:37 AM

Sat, Feb 9

vandenoever added a comment to D18868: Switch from reading Cargo.toml to using a cli flag.

I think bug 404127 is fixed in 0.3.1. The bindings file states where the rust directory is. That directory contains Cargo.toml.

Sat, Feb 9, 9:25 AM

Fri, Feb 8

vandenoever committed R881:7e7d2f91ae82: Update version and ChangeLog (authored by vandenoever).
Update version and ChangeLog
Fri, Feb 8, 9:02 PM
vandenoever committed R881:bba4964e3180: Fix error where Cargo.toml could not be found (authored by vandenoever).
Fix error where Cargo.toml could not be found
Fri, Feb 8, 9:02 PM

Tue, Jan 22

vandenoever added a comment to D18456: actually look for mysql binaries in PATH.

On NixOS, all executables are under /nix/store/$HASH-$NAME/bin. These get linked into the PATH. Seeing that Akonadi was not respecting PATH previously I wonder how it could work there.
So I checked https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/kde/akonadi/akonadi-paths.patch

Tue, Jan 22, 3:25 PM · KDE PIM

Mon, Jan 21

vandenoever committed R881:ad94fb1036a3: cargo fmt (authored by vandenoever).
cargo fmt
Mon, Jan 21, 11:04 PM
vandenoever committed R881:1e4d769b32a9: Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator (authored by vandenoever).
Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator
Mon, Jan 21, 10:45 PM
vandenoever committed R881:0c67f8bc324f: Update version to 0.3.0 (authored by vandenoever).
Update version to 0.3.0
Mon, Jan 21, 10:45 PM
vandenoever committed R881:7c8bb6a5351c: Add function to choose what Qt modules to link to (authored by vandenoever).
Add function to choose what Qt modules to link to
Mon, Jan 21, 10:45 PM

Dec 30 2018

vandenoever committed R237:f403d09d0b49: Fix a regression introduced in 6a1852 (authored by vandenoever).
Fix a regression introduced in 6a1852
Dec 30 2018, 12:22 PM
vandenoever closed D17856: Fix a regression introduced in 6a1852.
Dec 30 2018, 12:22 PM · Frameworks

Dec 29 2018

vandenoever added reviewers for D17856: Fix a regression introduced in 6a1852: dfaure, arichardson, apol, aacid, ngraham.
Dec 29 2018, 5:29 PM · Frameworks
vandenoever added a comment to D17651: Escape bytes that are larger than or equal to 127 in config files.

Sure. It's here https://phabricator.kde.org/D17856

Dec 29 2018, 5:28 PM · Frameworks
vandenoever requested review of D17856: Fix a regression introduced in 6a1852.
Dec 29 2018, 5:27 PM · Frameworks
vandenoever added a comment to D17651: Escape bytes that are larger than or equal to 127 in config files.

Here is a patch that solves the problem:

diff --git a/src/core/kconfigini.cpp b/src/core/kconfigini.cpp
index 39e5936..b674973 100644
--- a/src/core/kconfigini.cpp
+++ b/src/core/kconfigini.cpp
@@ -673,7 +673,12 @@ QByteArray KConfigIniBackend::stringToPrintable(const QByteArray &aString, Strin
         switch (s[i]) {
         default:
             // The \n, \t, \r cases (all < 32) are handled below; we can ignore them here
-            if (((unsigned char)s[i]) < 32 || ((unsigned char)s[i]) >= 127) {
+            if (((unsigned char)s[i]) < 32) {
+                goto doEscape;
+            }
+            // GroupString and KeyString should be valid UTF-8, but ValueString
+            // can be a bytearray with non-UTF-8 bytes that should be escaped.
+            if (type == ValueString && ((unsigned char)s[i]) >= 127) {
                 goto doEscape;
             }
             *data++ = s[i];
Dec 29 2018, 5:05 PM · Frameworks
vandenoever added a comment to D17651: Escape bytes that are larger than or equal to 127 in config files.

Found it. This is the failing test.

FAIL!  : KConfigTest::testEncoding() Compared values are not the same
   Actual   (lines.first())                    : "[UTF-8:\\xc3\\xb6l]\n"
   Expected (QByteArray("[UTF-8:\xc3\xb6l]\n")): "[UTF-8:\xC3\xB6l]\n"
   Loc: [/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.11/autotests/kconfigtest.cpp(463)]
Dec 29 2018, 4:30 PM · Frameworks

Dec 28 2018

vandenoever added a comment to D17651: Escape bytes that are larger than or equal to 127 in config files.

Can you give some more details? I see no problem on Jenkins. https://build.kde.org/job/Frameworks/job/kconfig/

Dec 28 2018, 9:57 PM · Frameworks

Dec 18 2018

vandenoever added a comment to D17651: Escape bytes that are larger than or equal to 127 in config files.

I pushed two encore commits fixing the two raised issues.

Dec 18 2018, 11:37 PM · Frameworks
vandenoever committed R237:16eea19c5b79: Remove unneeded qWarning (authored by vandenoever).
Remove unneeded qWarning
Dec 18 2018, 11:35 PM
vandenoever committed R237:16691c2742a8: Deduplicate reference value (authored by vandenoever).
Deduplicate reference value
Dec 18 2018, 11:35 PM
vandenoever committed R237:6a185285ae44: Escape bytes that are larger than or equal to 127 in config files (authored by vandenoever).
Escape bytes that are larger than or equal to 127 in config files
Dec 18 2018, 8:34 PM
vandenoever closed D17651: Escape bytes that are larger than or equal to 127 in config files.
Dec 18 2018, 8:34 PM · Frameworks
vandenoever updated the diff for D17651: Escape bytes that are larger than or equal to 127 in config files.

Add a check for reading in the unit test.

Dec 18 2018, 6:57 PM · Frameworks
vandenoever updated the summary of D17651: Escape bytes that are larger than or equal to 127 in config files.
Dec 18 2018, 6:50 PM · Frameworks
vandenoever updated the diff for D17651: Escape bytes that are larger than or equal to 127 in config files.

Added a unit test and changed the code so that 0x7f (DEL) is also
escaped.

Dec 18 2018, 6:49 PM · Frameworks
vandenoever retitled D17651: Escape bytes that are larger than or equal to 127 in config files from Escape bytes that larger than 127 to Escape bytes that are larger than 127 in config files.
Dec 18 2018, 3:07 PM · Frameworks
vandenoever added reviewers for D17651: Escape bytes that are larger than or equal to 127 in config files: dfaure, arichardson.
Dec 18 2018, 1:55 PM · Frameworks
vandenoever updated the summary of D17651: Escape bytes that are larger than or equal to 127 in config files.
Dec 18 2018, 1:09 PM · Frameworks
vandenoever updated the summary of D17651: Escape bytes that are larger than or equal to 127 in config files.
Dec 18 2018, 12:57 PM · Frameworks
vandenoever requested review of D17651: Escape bytes that are larger than or equal to 127 in config files.
Dec 18 2018, 12:56 PM · Frameworks

Dec 9 2018

vandenoever committed R881:0fb6e84077f7: Increase version to 0.2.2 and update ChangeLog (authored by vandenoever).
Increase version to 0.2.2 and update ChangeLog
Dec 9 2018, 11:36 PM
vandenoever committed R881:ecd135f31132: Fix build with rust <= 1.30 (authored by vandenoever).
Fix build with rust <= 1.30
Dec 9 2018, 11:32 PM
vandenoever committed R881:86652e860562: Increase version to 0.2.1 and add ChangeLog (authored by vandenoever).
Increase version to 0.2.1 and add ChangeLog
Dec 9 2018, 11:22 PM
vandenoever committed R881:b41b1be3369c: Add anonymous parameter placeholders to generated code (authored by vandenoever).
Add anonymous parameter placeholders to generated code
Dec 9 2018, 11:22 PM
vandenoever committed R881:319991e77fa5: Add anonymous parameter placeholders to generated code (authored by vandenoever).
Add anonymous parameter placeholders to generated code
Dec 9 2018, 10:45 PM
vandenoever added a comment to D17447: Add support for Rust 2018 edition projects..

Thank you very much Owen! Hope you're enjoying Rust Qt Binding Generator.

Dec 9 2018, 10:36 PM
vandenoever committed R881:325ffc2a2c84: Add support for Rust 2018 edition projects. (authored by onelson).
Add support for Rust 2018 edition projects.
Dec 9 2018, 10:34 PM
vandenoever closed D17447: Add support for Rust 2018 edition projects..
Dec 9 2018, 10:34 PM
vandenoever added a comment to D17447: Add support for Rust 2018 edition projects..

It's a very clear patch and well documented. I'd prefer it to use an enum though. I've put a suggestion in the code.

Dec 9 2018, 9:28 PM
vandenoever added a comment to D17447: Add support for Rust 2018 edition projects..

I would prefer it if the patch would parse Cargo.toml to determine the edition of Rust. This can be done with the toml crate.

Dec 9 2018, 1:22 PM
vandenoever added a comment to D17447: Add support for Rust 2018 edition projects..

I've tried the patch. To get a 2018 project to compile, cargo needs to know about the 2018 edition feature:

rust_qt_binding_generator = { path = "../rust_qt_binding_generator", features = ["use-2018-edition"] }
Dec 9 2018, 1:09 PM
vandenoever added a comment to D17447: Add support for Rust 2018 edition projects..

Thank you for the simple patch. Is use-2018-edition a feature that is automatically set by Cargo when edition = "2018"? I've not found the documentation on that.

Dec 9 2018, 11:59 AM

Nov 24 2018

vandenoever committed R881:4acf7e3176c7: Resolve resource path relative to qrc path (authored by vandenoever).
Resolve resource path relative to qrc path
Nov 24 2018, 1:14 PM

Nov 11 2018

vandenoever committed R881:f678d441e9fe: Fix building with MSVC (authored by vandenoever).
Fix building with MSVC
Nov 11 2018, 4:05 PM

Nov 1 2018

vandenoever accepted D16576: Use more rust syntactic sugar.

Looks good. Thanks and welcome to Rust Qt Binding Generator.

Nov 1 2018, 10:16 AM
vandenoever requested changes to D16576: Use more rust syntactic sugar.

Nice work, Carl.

Nov 1 2018, 7:20 AM

Oct 29 2018

vandenoever committed R881:e6d220bc1808: Increase version number and add ChangeLog (authored by vandenoever).
Increase version number and add ChangeLog
Oct 29 2018, 9:41 PM
vandenoever committed R881:037322f27008: Cleanup code (authored by vandenoever).
Cleanup code
Oct 29 2018, 9:41 PM

Oct 28 2018

vandenoever committed R881:89c86642f8e3: Print the c++ library that cargo should link against (authored by vandenoever).
Print the c++ library that cargo should link against
Oct 28 2018, 9:05 PM

Oct 27 2018

vandenoever committed R881:ed2de054928d: Add a template that is built by Cargo (authored by vandenoever).
Add a template that is built by Cargo
Oct 27 2018, 7:19 PM

Oct 26 2018

vandenoever committed R881:c1a0bd7bfb63: Top processes have no parent (authored by vandenoever).
Top processes have no parent
Oct 26 2018, 9:29 AM
vandenoever committed R881:aa7e6c7e3b72: Remove unneeded enum value (authored by vandenoever).
Remove unneeded enum value
Oct 26 2018, 9:29 AM

Oct 25 2018

vandenoever committed R881:385ae17bb7bb: Pass the emitter as mutable. It is pointless otherwise. (authored by vandenoever).
Pass the emitter as mutable. It is pointless otherwise.
Oct 25 2018, 10:32 PM
vandenoever committed R881:fa337c37b1fb: Adapt code to changes in generator (authored by vandenoever).
Adapt code to changes in generator
Oct 25 2018, 10:01 PM
vandenoever committed R881:b603a2262b47: Only allow mutable objects to call back into C++ (authored by vandenoever).
Only allow mutable objects to call back into C++
Oct 25 2018, 10:01 PM

Oct 9 2018

vandenoever committed R881:a78f8c9b737b: Fix description and increase version number (authored by vandenoever).
Fix description and increase version number
Oct 9 2018, 10:46 PM
vandenoever committed R881:67c9cf122e7a: Add metadata to Cargo.toml (authored by vandenoever).
Add metadata to Cargo.toml
Oct 9 2018, 10:46 PM
vandenoever committed R881:4a3879388293: Add documentation and tweak function name (authored by vandenoever).
Add documentation and tweak function name
Oct 9 2018, 10:46 PM
vandenoever committed R881:5d5745bac0fb: Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator (authored by vandenoever).
Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator
Oct 9 2018, 4:13 PM
vandenoever committed R881:08876fd75754: Take changes in .h and .cpp files into account during build (authored by vandenoever).
Take changes in .h and .cpp files into account during build
Oct 9 2018, 4:13 PM
vandenoever committed R881:ea876ec81d7c: Add functions for building Qt applications with Cargo (authored by vandenoever).
Add functions for building Qt applications with Cargo
Oct 9 2018, 4:13 PM
vandenoever committed R881:59d0092e55da: Build even when CMAKE_DL_LIBS is not defined (authored by vandenoever).
Build even when CMAKE_DL_LIBS is not defined
Oct 9 2018, 4:13 PM

Oct 2 2018

vandenoever added a comment to D14634: Add moveable objects.

The implementation language of RQBG has changed from C++ to Rust. This affects the files src/cpp.cpp and src/rust.cpp which are now src/cpp.rs and src/rust.rs.

Oct 2 2018, 7:35 PM

Sep 29 2018

vandenoever committed R881:df9122697953: Expose function for reading the configuration (authored by vandenoever).
Expose function for reading the configuration
Sep 29 2018, 10:10 PM
vandenoever committed R881:fac04fd6d45f: Remove unneeded annotations (authored by vandenoever).
Remove unneeded annotations
Sep 29 2018, 10:09 PM
vandenoever committed R881:ca8f870e5e2f: Update generate file (authored by vandenoever).
Update generate file
Sep 29 2018, 10:09 PM
vandenoever committed R881:13d8d1cf1d13: Use AtomicPtr instead of Mutex (authored by vandenoever).
Use AtomicPtr instead of Mutex
Sep 29 2018, 10:09 PM
vandenoever committed R881:49f67ffc61d1: Slightly update sysinfo (authored by vandenoever).
Slightly update sysinfo
Sep 29 2018, 4:24 PM

Sep 28 2018

vandenoever committed R881:fe9731819fef: Use the version number from Cargo.toml (authored by vandenoever).
Use the version number from Cargo.toml
Sep 28 2018, 9:57 PM
vandenoever committed R881:6ee8ca626d01: Add function to create bindings from runtime Config object (authored by vandenoever).
Add function to create bindings from runtime Config object
Sep 28 2018, 9:38 PM
vandenoever committed R881:baaa8f230cf3: Use full include path to Qt headers (authored by vandenoever).
Use full include path to Qt headers
Sep 28 2018, 9:38 PM
vandenoever committed R881:cbf66a128ccd: Fix draggin of scrollbar in SplitView (authored by vandenoever).
Fix draggin of scrollbar in SplitView
Sep 28 2018, 7:48 PM
vandenoever committed R881:83e5f01fe0be: Specify the dependency differently to (try to) appease CMake 3.12 (authored by vandenoever).
Specify the dependency differently to (try to) appease CMake 3.12
Sep 28 2018, 5:29 PM
vandenoever committed R881:d7860d903196: Also check for module directory (authored by vandenoever).
Also check for module directory
Sep 28 2018, 4:45 PM
vandenoever committed R881:034e5526cfbb: Add missing ? (authored by vandenoever).
Add missing ?
Sep 28 2018, 4:08 PM
vandenoever committed R881:b3e43ae1d265: Handle result of write! and writeln! (authored by vandenoever).
Handle result of write! and writeln!
Sep 28 2018, 4:05 PM
vandenoever committed R881:cb27f4c5ce56: Add missing dependency (authored by vandenoever).
Add missing dependency
Sep 28 2018, 10:25 AM
vandenoever committed R881:d6e88b0ab62f: Add missing file (authored by vandenoever).
Add missing file
Sep 28 2018, 10:24 AM
vandenoever committed R881:d7e4f1362de3: Port rust_qt_binding_generator from C++ to Rust (authored by vandenoever).
Port rust_qt_binding_generator from C++ to Rust
Sep 28 2018, 10:14 AM

Sep 25 2018

vandenoever committed R881:0294ed948b45: Add a link to a presentation (authored by vandenoever).
Add a link to a presentation
Sep 25 2018, 7:49 PM
vandenoever committed R881:ad8dd3223593: Add two more links to tutorials (authored by vandenoever).
Add two more links to tutorials
Sep 25 2018, 7:47 PM

Sep 18 2018

vandenoever added a comment to D14634: Add moveable objects.

Sure, i can give comments via Phabricator.

Sep 18 2018, 8:29 PM
vandenoever added a comment to D14634: Add moveable objects.

This could certainly become a separate experimental branch. You have commit access and also the ability to make a new branch (I think). Note however, that branches are not easily deleted on KDE infrastructure. Creating a branch moveable_objects is fine with me.

Sep 18 2018, 7:58 PM
vandenoever added a comment to D14634: Add moveable objects.

Deleting the QObject is now no memory issue. That's good progress.
I'm still wondering about the Rust side of the replaceableObject. The Rust struct should be tied to the replaceableObject.
A good practice might be to use something like

rust
struct InnerObjectData {
    ...
}
type InnerObject = Arc<Mutex<InnerObjectData>>;
Sep 18 2018, 7:23 PM

Sep 16 2018

vandenoever accepted D15553: Use nullptr in generated C++ sources.
Sep 16 2018, 5:11 PM
vandenoever accepted D15552: Remove unused QWidget dependecy from Todo example app.
Sep 16 2018, 5:10 PM
vandenoever accepted D15545: Use Q_SIGNALS/Q_EMIT instead of signals/emit in generated sources.

Better safe than sorry. I was not familiar with this practice. I looked for some information on it and found these https://www.kdab.com/kdab-contributions-to-qt-5-0-part-5/ I found no qt.io docs on QT_NO_SIGNALS_SLOTS_KEYWORDS but using Q_SIGNALS is listed as a good idea at http://doc.qt.io/qt-5/qobject.html#Q_SIGNALS.

Sep 16 2018, 7:05 AM

Sep 15 2018

vandenoever accepted D15541: Add break; statements in the generated switch code for model::data().

Very good. Weirdly, my compiler did not complain about this.

Sep 15 2018, 7:59 PM

Sep 11 2018

vandenoever committed R881:0192124c7087: Fix some clippy issues in written and generated code (authored by vandenoever).
Fix some clippy issues in written and generated code
Sep 11 2018, 11:12 PM
vandenoever committed R881:9549c5021717: Automatically update index when calling layoutChanged (authored by vandenoever).
Automatically update index when calling layoutChanged
Sep 11 2018, 11:12 PM

Sep 8 2018

vandenoever committed R881:f0eb78457bbd: Make the model struct that emits model signals clonable (authored by vandenoever).
Make the model struct that emits model signals clonable
Sep 8 2018, 9:13 PM
vandenoever committed R881:96376517c699: Add bindings for layoutAboutToBeChanged and layoutChanged (authored by vandenoever).
Add bindings for layoutAboutToBeChanged and layoutChanged
Sep 8 2018, 8:49 PM
vandenoever committed R881:b702c980afc5: Add bindings for beginMoveRows and endMoveRows (authored by vandenoever).
Add bindings for beginMoveRows and endMoveRows
Sep 8 2018, 7:54 PM
vandenoever committed R881:2a3123eda3d5: Consistently use Option instead of two arguments (value and bool) (authored by vandenoever).
Consistently use Option instead of two arguments (value and bool)
Sep 8 2018, 7:54 PM
vandenoever committed R881:754214e7b48e: snapshot (authored by vandenoever).
snapshot
Sep 8 2018, 7:54 PM