vandenoever (Jos van den Oever)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 9 2015, 3:00 PM (154 w, 2 d)
Availability
Available

Recent Activity

Yesterday

vandenoever accepted D13631: Add metadata extraction plugin for ODF files.
Fri, Jun 22, 10:02 PM
vandenoever added a comment to D13631: Add metadata extraction plugin for ODF files.

Looks good. Certainly good enough. I think it's readable.

Fri, Jun 22, 4:02 PM

Thu, Jun 21

vandenoever added a comment to D13631: Add metadata extraction plugin for ODF files.

If you want to be really correct, you have to remove foreign elements first or parse in a way that you ignore foreign elements.

Thu, Jun 21, 5:38 PM
vandenoever added a comment to D13631: Add metadata extraction plugin for ODF files.

QDomDocument is lazy, you have to explicitly ask for namespace processing.

Thu, Jun 21, 5:00 PM

Wed, Jun 20

vandenoever added a comment to D13631: Add metadata extraction plugin for ODF files.

Don't feel bad. I'm not even sure what this patch will do. I guess KRename has some renaming rules where you can use extracted information.

Wed, Jun 20, 9:10 PM
vandenoever added a comment to D13631: Add metadata extraction plugin for ODF files.

Apart from that I do not see any bugs, just differences in taste which I commented on and you can take as you see fit.

Wed, Jun 20, 7:34 PM
vandenoever requested changes to D13631: Add metadata extraction plugin for ODF files.

I added a comment that was apparently lost in my first review.

Wed, Jun 20, 7:32 PM
vandenoever requested changes to D13631: Add metadata extraction plugin for ODF files.

Nice addition! You might want to apply some of the suggested changes.

Wed, Jun 20, 5:33 PM

Fri, Jun 8

vandenoever committed R881:916d59ac1640: Update generated source code (authored by vandenoever).
Update generated source code
Fri, Jun 8, 12:21 PM
vandenoever committed R881:7d4b55b90afc: Use "index" instead of "item" for the index in the model (authored by vandenoever).
Use "index" instead of "item" for the index in the model
Fri, Jun 8, 12:21 PM
vandenoever committed R881:d55eadb972c5: Simplifiy .gitignore (authored by vandenoever).
Simplifiy .gitignore
Fri, Jun 8, 12:21 PM

May 19 2018

vandenoever committed R881:b8fcb6711201: Add function to look up role number from role name (authored by vandenoever).
Add function to look up role number from role name
May 19 2018, 3:08 PM
vandenoever committed R881:9822dcef071f: Simplify the example by removing the optional roles property (authored by vandenoever).
Simplify the example by removing the optional roles property
May 19 2018, 2:47 PM
vandenoever committed R881:e3bfa85849a9: Make the roles property in the bindings.json optional (authored by vandenoever).
Make the roles property in the bindings.json optional
May 19 2018, 12:03 PM

May 18 2018

vandenoever committed R881:259015d8b538: Add line breaks (authored by vandenoever).
Add line breaks
May 18 2018, 6:07 PM
vandenoever committed R881:fb972b111923: Add an exception to the license: no copyright claim on generated code (authored by vandenoever).
Add an exception to the license: no copyright claim on generated code
May 18 2018, 6:05 PM
vandenoever committed R881:07517824ab07: Add screenshot of example application (authored by vandenoever).
Add screenshot of example application
May 18 2018, 4:51 PM
vandenoever committed R881:574440ba588b: Add example Todos application from FOSDEM presentation (authored by vandenoever).
Add example Todos application from FOSDEM presentation
May 18 2018, 4:37 PM
vandenoever committed R881:f4ffeeda9174: Fix typo (authored by vandenoever).
Fix typo
May 18 2018, 1:05 PM
vandenoever committed R881:c27e451066b4: Check conversion between c_int and usize (authored by vandenoever).
Check conversion between c_int and usize
May 18 2018, 7:38 AM

May 17 2018

vandenoever committed R881:8949026c63da: Make primitive types more precise and add test (authored by vandenoever).
Make primitive types more precise and add test
May 17 2018, 8:47 AM

May 16 2018

vandenoever committed R881:75d540694389: Add more tests (authored by vandenoever).
Add more tests
May 16 2018, 8:38 PM
vandenoever committed R881:e636d82da59f: More precise types (authored by vandenoever).
More precise types
May 16 2018, 5:19 PM

May 15 2018

vandenoever committed R881:392153f9a931: Allow optional primitive object properties (authored by vandenoever).
Allow optional primitive object properties
May 15 2018, 7:45 PM
vandenoever committed R881:a051556990de: Add more tests (authored by vandenoever).
Add more tests
May 15 2018, 3:09 PM

May 13 2018

vandenoever committed R881:57d557378ee6: Update template projects to not use struct qstring_t (authored by vandenoever).
Update template projects to not use struct qstring_t
May 13 2018, 1:11 PM
vandenoever committed R881:7fb53a8916f1: Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator (authored by vandenoever).
Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator
May 13 2018, 1:11 PM
vandenoever committed R881:6099ee3c3d0c: Add more integer types (authored by vandenoever).
Add more integer types
May 13 2018, 1:11 PM
vandenoever committed R881:12cebe88bb60: Make sure that the optional types in the bindings are POD types (authored by vandenoever).
Make sure that the optional types in the bindings are POD types
May 13 2018, 1:11 PM
vandenoever committed R881:848b472c3fc4: Use QVariant::fromValue and QVariant::setValue to avoid type conversion (authored by vandenoever).
Use QVariant::fromValue and QVariant::setValue to avoid type conversion
May 13 2018, 1:11 PM
vandenoever committed R881:c87339ed6a82: Add type check when converting QVariant in QAbstractItemModel::setData (authored by vandenoever).
Add type check when converting QVariant in QAbstractItemModel::setData
May 13 2018, 1:11 PM
vandenoever committed R881:4dba74acbd31: Beter whitespace (authored by vandenoever).
Beter whitespace
May 13 2018, 1:11 PM
vandenoever committed R881:8ccb2e519b76: cleanup (authored by vandenoever).
cleanup
May 13 2018, 1:11 PM
vandenoever committed R881:67e6e8a9bf4f: Convert test_functions (authored by vandenoever).
Convert test_functions
May 13 2018, 1:11 PM
vandenoever committed R881:5bcb96b56124: Convert test_object_list (authored by vandenoever).
Convert test_object_list
May 13 2018, 1:11 PM
vandenoever committed R881:af7b64b82d03: Convert demo (authored by vandenoever).
Convert demo
May 13 2018, 1:11 PM
vandenoever committed R881:18368ee14285: Convert test_object_types (authored by vandenoever).
Convert test_object_types
May 13 2018, 1:11 PM
vandenoever committed R881:fb6e2c933fda: Convert test_object (authored by vandenoever).
Convert test_object
May 13 2018, 1:11 PM

May 1 2018

vandenoever committed R881:d289bbdb6828: Add two tools to the Docker for convenience (authored by vandenoever).
Add two tools to the Docker for convenience
May 1 2018, 12:56 PM
vandenoever committed R881:f848b4f80f54: Add debug information to release builds of test and demo (authored by vandenoever).
Add debug information to release builds of test and demo
May 1 2018, 12:56 PM
vandenoever committed R881:b3f2afcd0d1a: snapshot (authored by vandenoever).
snapshot
May 1 2018, 12:56 PM

Apr 30 2018

vandenoever committed R881:56552a2d8626: Upgrade Docker image to latest Ubuntu version (authored by vandenoever).
Upgrade Docker image to latest Ubuntu version
Apr 30 2018, 2:50 PM
vandenoever committed R881:d3134229ae60: Add package ca-certificates (authored by vandenoever).
Add package ca-certificates
Apr 30 2018, 2:44 PM

Apr 29 2018

vandenoever committed R881:4cce277554ff: snapshot (authored by vandenoever).
snapshot
Apr 29 2018, 10:14 AM

Mar 17 2018

vandenoever accepted D11376: Install ca-certificates in docker image.

Looks good.

Mar 17 2018, 9:03 PM

Mar 11 2018

vandenoever added inline comments to D11232: Make qstring_t and qbytearray_t into POD types.
Mar 11 2018, 7:56 PM
vandenoever added inline comments to D11232: Make qstring_t and qbytearray_t into POD types.
Mar 11 2018, 7:27 PM
vandenoever added a comment to D11078: Fix crash stemming from mismatch of the C++ and Rust interfaces bug #389419.

See D11232 for a different approach.

Mar 11 2018, 2:28 PM
vandenoever updated the diff for D11232: Make qstring_t and qbytearray_t into POD types.

This patch now takes the opposite approach of what @illis proposes in D11078. The function on the rust side is sent as a pointer.

Mar 11 2018, 2:21 PM
vandenoever requested review of D11232: Make qstring_t and qbytearray_t into POD types.
Mar 11 2018, 1:31 PM
vandenoever committed R881:50ac9c3541c2: Add git to the docker image (authored by vandenoever).
Add git to the docker image
Mar 11 2018, 10:56 AM
vandenoever added a comment to D11078: Fix crash stemming from mismatch of the C++ and Rust interfaces bug #389419.

I'd have thought the same docker on the same hardware would give the same compiled code. I'll have a go at making a version of the patch where there are no qbytearray_t and no qstring_t.

Mar 11 2018, 10:52 AM

Mar 10 2018

vandenoever added a comment to D11078: Fix crash stemming from mismatch of the C++ and Rust interfaces bug #389419.

qbytearray_t and qstring_t are passed to C, so they should be PODs. This requires quite large changes.

Mar 10 2018, 11:26 PM
vandenoever added a comment to D11078: Fix crash stemming from mismatch of the C++ and Rust interfaces bug #389419.

After testing, I found that this patch crashes the demo in my docker on a 64 bit machine.

Mar 10 2018, 11:02 PM

Feb 7 2018

vandenoever committed R881:16f642ddc689: Add make to the Docker image (authored by vandenoever).
Add make to the Docker image
Feb 7 2018, 11:31 AM
vandenoever committed R881:36f92873720b: Run apt update before each apt command (authored by vandenoever).
Run apt update before each apt command
Feb 7 2018, 11:31 AM

Jan 31 2018

vandenoever committed R881:7345b9fada2c: Use ubuntu instead of neon as base for the docker image (authored by vandenoever).
Use ubuntu instead of neon as base for the docker image
Jan 31 2018, 2:17 PM
vandenoever committed R881:67abcae56410: Fix possible anchor loop (authored by vandenoever).
Fix possible anchor loop
Jan 31 2018, 2:17 PM

Jan 27 2018

vandenoever committed R881:e26ccbfd92d0: Add more tools to the docker environment (authored by vandenoever).
Add more tools to the docker environment
Jan 27 2018, 8:43 PM

Jan 26 2018

vandenoever committed R881:57f73256a2c1: Translate camelCase binding function names to snake_case (authored by vandenoever).
Translate camelCase binding function names to snake_case
Jan 26 2018, 8:52 PM

Dec 22 2017

vandenoever accepted D9357: Some fixes for CMakeLists.txt.

Ok, good to more customary use of ECM.

Dec 22 2017, 5:24 PM
vandenoever accepted D9359: Add note where to file issues to README.md.

Yes, good to show the communication channels prominently.

Dec 22 2017, 5:23 PM
vandenoever accepted D9356: Sync FindCargo.cmake with that of kdev-cargo.

Looks like a professional CMake file now!

Dec 22 2017, 5:22 PM
vandenoever accepted D9458: Fix i18n message catalog naming, add catalog for generator app.

Looks good!

Dec 22 2017, 5:20 PM

Dec 21 2017

vandenoever added a comment to D9357: Some fixes for CMakeLists.txt.

Why only test when there is no ECM?

Dec 21 2017, 3:18 PM

Dec 17 2017

vandenoever added a comment to D9368: Turn Jos' blog posts into a mdbook-based tutorial.

I did not see that you changed the text. Just merge and I'll read through it later today. Great to see that you managed to make something work with the text.

Dec 17 2017, 12:09 PM
vandenoever accepted D9368: Turn Jos' blog posts into a mdbook-based tutorial.

Nice!

Dec 17 2017, 12:03 PM

Nov 20 2017

vandenoever committed R881:531e4798fcf1: Do not overwrite implementation.rs in the tests. (authored by vandenoever).
Do not overwrite implementation.rs in the tests.
Nov 20 2017, 8:05 AM

Oct 15 2017

vandenoever accepted D8283: Added no-argument function generation.

Great patch, Pearce!

Oct 15 2017, 7:17 AM

Oct 14 2017

vandenoever added a comment to D8283: Added no-argument function generation.

Looking good. I tested with some simple functions with bool and QString and I'm happy to have this feature.

Oct 14 2017, 8:45 AM

Oct 3 2017

vandenoever committed R881:b89de50db3bb: Add links to two project blog posts (authored by vandenoever).
Add links to two project blog posts
Oct 3 2017, 8:30 PM
vandenoever committed R881:e63ca9e9246a: Added generators for remove_rows for lists (authored by vandenoever).
Added generators for remove_rows for lists
Oct 3 2017, 6:23 PM
vandenoever closed D8120: Added generators for remove_rows for lists.
Oct 3 2017, 6:23 PM
vandenoever accepted D8120: Added generators for remove_rows for lists.

This looks good. Please commit it.

Oct 3 2017, 9:39 AM
vandenoever committed R881:1de0533601e5: Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator (authored by vandenoever).
Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator
Oct 3 2017, 12:41 AM
vandenoever committed R881:7ea7dd1d5e98: Override QAbstractItemModel::insertRows so UI code can add rows (authored by vandenoever).
Override QAbstractItemModel::insertRows so UI code can add rows
Oct 3 2017, 12:41 AM

Sep 7 2017

vandenoever committed R881:117eddfa9e60: Kirigami also disables later QQC2 style choice (authored by vandenoever).
Kirigami also disables later QQC2 style choice
Sep 7 2017, 12:40 PM
vandenoever committed R881:57c94bbdc972: Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator (authored by vandenoever).
Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator
Sep 7 2017, 12:27 PM
vandenoever committed R881:3da6eecd845a: Choose between QQC2 styles (authored by vandenoever).
Choose between QQC2 styles
Sep 7 2017, 12:27 PM

Sep 6 2017

vandenoever committed R499:b2e67d7305a7: Add kdereview/rust-qt-binding-generator (authored by vandenoever).
Add kdereview/rust-qt-binding-generator
Sep 6 2017, 10:08 AM
vandenoever created D7704: add rust-qt-binding-generator to the CI system.
Sep 6 2017, 10:07 AM

Sep 5 2017

vandenoever committed R881:8b2e55cf945c: Add licenses to all files that not generated or template code (authored by vandenoever).
Add licenses to all files that not generated or template code
Sep 5 2017, 6:08 PM
vandenoever committed R881:ddab2e57f655: Add Kirigami qml (authored by vandenoever).
Add Kirigami qml
Sep 5 2017, 4:19 PM
vandenoever added a comment to R247:3e1a1f9c338a: Create new repository for the Rust Qt Bindings Generator. Ref T6922.

Ok. so fundamentally different rendering.

Sep 5 2017, 10:11 AM
vandenoever added a comment to R247:3e1a1f9c338a: Create new repository for the Rust Qt Bindings Generator. Ref T6922.
Sep 5 2017, 9:32 AM
vandenoever added a comment to R247:3e1a1f9c338a: Create new repository for the Rust Qt Bindings Generator. Ref T6922.

I noticed not all parts of the README.md are rendered. Embedded HTML and an image ![]().

Sep 5 2017, 8:51 AM
vandenoever added a comment to R247:3e1a1f9c338a: Create new repository for the Rust Qt Bindings Generator. Ref T6922.

The project has an icon in the repo: demo/rust_qt_binding_generator.svg. Can that be reference in the metadata here? I noticed all the icon fields that are not null are just a name. How does that work?

Sep 5 2017, 8:16 AM

Sep 3 2017

vandenoever committed R247:d1147a18db2b: Add new project rust_qt_binding_generator (authored by vandenoever).
Add new project rust_qt_binding_generator
Sep 3 2017, 12:31 PM

Aug 29 2017

vandenoever added a comment to D6963: Don't block starting notification service.

The patch looks clean, but I do not fully understand how is supposed to work. Perhaps an explanation of the different scenarios would help future readers of this code.

Aug 29 2017, 3:44 PM · Frameworks

Aug 25 2017

vandenoever added a comment to D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData.
Aug 25 2017, 9:50 PM

Aug 19 2017

vandenoever added a comment to D7327: Don't enter test subdirectories if BUILD_TESTING=OFF.

Yes. I was a but reluctant to say ship it because i'm not a core contributor.

Aug 19 2017, 11:45 AM · Calligra: 3.0

Aug 15 2017

vandenoever added a comment to D7327: Don't enter test subdirectories if BUILD_TESTING=OFF.

Ok, looks like a nice speedup for non-testing builds.

Aug 15 2017, 2:01 PM · Calligra: 3.0
vandenoever added a comment to D7327: Don't enter test subdirectories if BUILD_TESTING=OFF.

Does this make it possible to remove if(BUILD_TESTING) used in */tests/CMakeLists.txt?
Or is BUILD_TESTING not respected at the moment?

Aug 15 2017, 12:53 PM · Calligra: 3.0

Jul 31 2017

vandenoever added a comment to D6963: Don't block starting notification service.

Removing this call is in line with the advice in the dbus spec.

Jul 31 2017, 10:03 AM · Frameworks

Jul 27 2017

vandenoever committed R8:944b4237c752: Fix failing unit test (authored by vandenoever).
Fix failing unit test
Jul 27 2017, 10:04 AM

Jul 24 2017

vandenoever abandoned D6873: Make KoStoreDevice a concrete implementation instead of header only.

I've pushed without the override. I do not feel I understand it well enough to commit it.

Jul 24 2017, 9:07 PM · Calligra: 3.0
vandenoever closed D6882: clazy fixes.

applied

Jul 24 2017, 9:05 PM · Calligra: 3.0
vandenoever committed R8:1730d8477089: Make KoStoreDevice a concrete implementation instead of header only (authored by vandenoever).
Make KoStoreDevice a concrete implementation instead of header only
Jul 24 2017, 9:04 PM
vandenoever committed R8:703df9162bab: Clazy fixes (authored by vandenoever).
Clazy fixes
Jul 24 2017, 9:02 PM
vandenoever created D6882: clazy fixes.
Jul 24 2017, 4:09 PM · Calligra: 3.0