- User Since
- Jul 9 2015, 3:00 PM (154 w, 2 d)
Looks good. Certainly good enough. I think it's readable.
Thu, Jun 21
If you want to be really correct, you have to remove foreign elements first or parse in a way that you ignore foreign elements.
QDomDocument is lazy, you have to explicitly ask for namespace processing.
Wed, Jun 20
Don't feel bad. I'm not even sure what this patch will do. I guess KRename has some renaming rules where you can use extracted information.
Apart from that I do not see any bugs, just differences in taste which I commented on and you can take as you see fit.
I added a comment that was apparently lost in my first review.
Nice addition! You might want to apply some of the suggested changes.
Fri, Jun 8
May 19 2018
May 18 2018
May 17 2018
May 16 2018
May 15 2018
May 13 2018
May 1 2018
Apr 30 2018
Apr 29 2018
Mar 17 2018
Mar 11 2018
See D11232 for a different approach.
I'd have thought the same docker on the same hardware would give the same compiled code. I'll have a go at making a version of the patch where there are no qbytearray_t and no qstring_t.
Mar 10 2018
qbytearray_t and qstring_t are passed to C, so they should be PODs. This requires quite large changes.
After testing, I found that this patch crashes the demo in my docker on a 64 bit machine.
Feb 7 2018
Jan 31 2018
Jan 27 2018
Jan 26 2018
Dec 22 2017
Ok, good to more customary use of ECM.
Yes, good to show the communication channels prominently.
Looks like a professional CMake file now!
Dec 21 2017
Why only test when there is no ECM?
Dec 17 2017
I did not see that you changed the text. Just merge and I'll read through it later today. Great to see that you managed to make something work with the text.
Nov 20 2017
Oct 15 2017
Great patch, Pearce!
Oct 14 2017
Looking good. I tested with some simple functions with bool and QString and I'm happy to have this feature.
Oct 3 2017
This looks good. Please commit it.
Sep 7 2017
Sep 6 2017
Sep 5 2017
Ok. so fundamentally different rendering.
I noticed not all parts of the README.md are rendered. Embedded HTML and an image !().
The project has an icon in the repo: demo/rust_qt_binding_generator.svg. Can that be reference in the metadata here? I noticed all the icon fields that are not null are just a name. How does that work?
Sep 3 2017
Aug 29 2017
The patch looks clean, but I do not fully understand how is supposed to work. Perhaps an explanation of the different scenarios would help future readers of this code.
Aug 25 2017
Aug 19 2017
Yes. I was a but reluctant to say ship it because i'm not a core contributor.
Aug 15 2017
Ok, looks like a nice speedup for non-testing builds.
Does this make it possible to remove if(BUILD_TESTING) used in */tests/CMakeLists.txt?
Or is BUILD_TESTING not respected at the moment?
Jul 31 2017
Removing this call is in line with the advice in the dbus spec.
Jul 27 2017
Jul 24 2017
I've pushed without the override. I do not feel I understand it well enough to commit it.