vandenoever (Jos van den Oever)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 9 2015, 3:00 PM (223 w, 2 d)
Availability
Available

Recent Activity

Sun, Sep 29

vandenoever committed R881:b94a08227773: Widgets cargo template with UI support (authored by psbarra).
Widgets cargo template with UI support
Sun, Sep 29, 4:35 PM
vandenoever closed D24069: Widgets cargo template with UI support.
Sun, Sep 29, 4:35 PM
vandenoever added a comment to D24069: Widgets cargo template with UI support.

Thank you very much. The patch has landed.

Sun, Sep 29, 3:39 PM
vandenoever accepted D24069: Widgets cargo template with UI support.
Sun, Sep 29, 3:38 PM
vandenoever added a comment to D24069: Widgets cargo template with UI support.

This patch looks good now. I can land it for you.
To do so, I need you full name and email to amend the author information. Shall I use the name and mail from the mail that you sent me?

Sun, Sep 29, 8:53 AM

Sat, Sep 28

vandenoever added a comment to D24069: Widgets cargo template with UI support.

I like the new version.

Sat, Sep 28, 4:53 PM

Fri, Sep 27

vandenoever added a comment to D24069: Widgets cargo template with UI support.

This patch works fine. Support for .ui files is a great addition.

Fri, Sep 27, 9:09 PM

Sep 19 2019

vandenoever added a comment to D23967: template: fix undefined references when linking with cargo.

Done!

Sep 19 2019, 5:32 PM
vandenoever committed R881:f81d897b3dac: template: fix undefined references when linking with cargo (authored by vandenoever).
template: fix undefined references when linking with cargo
Sep 19 2019, 5:32 PM

Sep 16 2019

vandenoever accepted D23967: template: fix undefined references when linking with cargo.

Ok, this looks good. Please push it.

Sep 16 2019, 3:20 PM

Sep 15 2019

vandenoever added a comment to D23967: template: fix undefined references when linking with cargo.

Can you explain the reasoning for the patch?

Sep 15 2019, 2:01 PM

Aug 29 2019

vandenoever committed R881:abe2820145e9: Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator (authored by vandenoever).
Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator
Aug 29 2019, 11:26 PM
vandenoever committed R881:80e9067264f1: Refactor to reduce complexity (authored by vandenoever).
Refactor to reduce complexity
Aug 29 2019, 11:26 PM
vandenoever committed R881:8d12d78d48f2: Update generated interfaces (authored by vandenoever).
Update generated interfaces
Aug 29 2019, 11:26 PM
vandenoever committed R881:bc03e72a6a8e: Bugfix: write .into() for Option<> return types (authored by vandenoever).
Bugfix: write .into() for Option<> return types
Aug 29 2019, 11:26 PM
vandenoever committed R881:6cda447dadfe: Clippy fixes for generated code (authored by vandenoever).
Clippy fixes for generated code
Aug 29 2019, 11:26 PM
vandenoever committed R881:09b3ca954991: cargo fmt (authored by vandenoever).
cargo fmt
Aug 29 2019, 11:26 PM
vandenoever committed R881:1eac0d1100b6: Fix build warnings (authored by vandenoever).
Fix build warnings
Aug 29 2019, 11:26 PM
vandenoever committed R881:a4ee70423205: clippy fixes (authored by vandenoever).
clippy fixes
Aug 29 2019, 11:26 PM

Feb 25 2019

vandenoever committed R881:5c5126d84b87: Allow explicit adding of include directories and libraries to link (authored by vandenoever).
Allow explicit adding of include directories and libraries to link
Feb 25 2019, 10:48 PM
vandenoever committed R881:8691a9204bd6: Update version and ChangeLog (authored by vandenoever).
Update version and ChangeLog
Feb 25 2019, 10:48 PM
vandenoever committed R881:39adad3b5e58: Update version and ChangeLog (authored by vandenoever).
Update version and ChangeLog
Feb 25 2019, 10:48 PM

Feb 24 2019

vandenoever committed R216:8e643e245f0f: Update example.rmd.fold and test.markdown.fold with new numbers (authored by vandenoever).
Update example.rmd.fold and test.markdown.fold with new numbers
Feb 24 2019, 8:18 PM
vandenoever committed R216:10b3a941461e: Update example.rmd.fold and test.markdown.fold with new numbers (authored by vandenoever).
Update example.rmd.fold and test.markdown.fold with new numbers
Feb 24 2019, 8:18 PM
vandenoever committed R216:1653403267ed: Remove unused kconfig-code (authored by vandenoever).
Remove unused kconfig-code
Feb 24 2019, 8:08 PM
vandenoever added a comment to D19263: Add more highlighting for nested languages in markdown..

done

Feb 24 2019, 2:52 PM · Frameworks, Kate
vandenoever committed R216:08dea9a8c0ba: Update exampel.rmd.fold with new numbers (authored by vandenoever).
Update exampel.rmd.fold with new numbers
Feb 24 2019, 2:52 PM
vandenoever committed R216:35793ffcc6ab: Merge branch 'master' of git://anongit.kde.org/syntax-highlighting (authored by vandenoever).
Merge branch 'master' of git://anongit.kde.org/syntax-highlighting
Feb 24 2019, 2:52 PM
vandenoever added a comment to D19263: Add more highlighting for nested languages in markdown..

I see that one test fails after committing this patch. The example output was modified by /autotests/update-reference-data.sh but I did not submit it. I thought it was not related to the markdown change.

Feb 24 2019, 9:51 AM · Frameworks, Kate
vandenoever committed R881:ca98081000a5: Make it possible to specify C++ header files via mod build (authored by vandenoever).
Make it possible to specify C++ header files via mod build
Feb 24 2019, 9:27 AM
vandenoever committed R216:bbb5188d9e12: Add more highlighting for nested languages in markdown. (authored by vandenoever).
Add more highlighting for nested languages in markdown.
Feb 24 2019, 9:21 AM
vandenoever closed D19263: Add more highlighting for nested languages in markdown..
Feb 24 2019, 9:21 AM · Frameworks, Kate
vandenoever updated the diff for D19263: Add more highlighting for nested languages in markdown..

Increased kateversion to 5.0.

Feb 24 2019, 9:18 AM · Frameworks, Kate

Feb 23 2019

vandenoever added a comment to D19263: Add more highlighting for nested languages in markdown..

Even folding works inside fenced blocks.

Feb 23 2019, 9:27 PM · Frameworks, Kate
vandenoever updated the diff for D19263: Add more highlighting for nested languages in markdown..
  • added more languages,
  • updated language version
  • updated test files
Feb 23 2019, 9:24 PM · Frameworks, Kate
vandenoever retitled D19263: Add more highlighting for nested languages in markdown. from yAdd more highlighting for nested languages in markdown. to Add more highlighting for nested languages in markdown..
Feb 23 2019, 6:46 PM · Frameworks, Kate
vandenoever added a reviewer for D19263: Add more highlighting for nested languages in markdown.: Framework: Syntax Highlighting.
Feb 23 2019, 6:46 PM · Frameworks, Kate
vandenoever requested review of D19263: Add more highlighting for nested languages in markdown..
Feb 23 2019, 6:45 PM · Frameworks, Kate

Feb 20 2019

vandenoever committed R237:2cdcd4f30666: Write valid UTF8 characters without escaping. (authored by vandenoever).
Write valid UTF8 characters without escaping.
Feb 20 2019, 4:19 PM
vandenoever closed D19107: Write valid UTF8 characters without escaping..
Feb 20 2019, 4:19 PM · Frameworks
vandenoever added a comment to D19107: Write valid UTF8 characters without escaping..

So it's accepted?

Feb 20 2019, 8:50 AM · Frameworks

Feb 19 2019

vandenoever added inline comments to D19107: Write valid UTF8 characters without escaping..
Feb 19 2019, 6:51 PM · Frameworks
vandenoever updated the diff for D19107: Write valid UTF8 characters without escaping..

Clean up test by using QTest data.

Feb 19 2019, 6:49 PM · Frameworks
vandenoever updated the diff for D19107: Write valid UTF8 characters without escaping..

Remove duplicate if statement.

Feb 19 2019, 5:44 PM · Frameworks
vandenoever updated the diff for D19107: Write valid UTF8 characters without escaping..

Added tests and code fixes to deal with overlong sequences and content
above U+10FFFF.

Feb 19 2019, 5:41 PM · Frameworks
vandenoever added inline comments to D19107: Write valid UTF8 characters without escaping..
Feb 19 2019, 4:59 PM · Frameworks
vandenoever added inline comments to D19107: Write valid UTF8 characters without escaping..
Feb 19 2019, 4:23 PM · Frameworks

Feb 18 2019

vandenoever added inline comments to D19107: Write valid UTF8 characters without escaping..
Feb 18 2019, 9:50 PM · Frameworks
vandenoever updated the diff for D19107: Write valid UTF8 characters without escaping..
  • Remove VALUE define.
  • Spelling fix.
Feb 18 2019, 9:50 PM · Frameworks
vandenoever added a reviewer for D19107: Write valid UTF8 characters without escaping.: thiago.
Feb 18 2019, 9:46 PM · Frameworks

Feb 17 2019

vandenoever requested review of D19107: Write valid UTF8 characters without escaping..
Feb 17 2019, 10:40 PM · Frameworks

Feb 13 2019

vandenoever committed R881:10ddeda5cbc5: Add placeholder variable name in generated code (authored by vandenoever).
Add placeholder variable name in generated code
Feb 13 2019, 7:37 AM
vandenoever committed R881:c522870b79bb: Update version and ChangeLog (authored by vandenoever).
Update version and ChangeLog
Feb 13 2019, 7:37 AM

Feb 9 2019

vandenoever added a comment to D18868: Switch from reading Cargo.toml to using a cli flag.

I think bug 404127 is fixed in 0.3.1. The bindings file states where the rust directory is. That directory contains Cargo.toml.

Feb 9 2019, 9:25 AM

Feb 8 2019

vandenoever committed R881:7e7d2f91ae82: Update version and ChangeLog (authored by vandenoever).
Update version and ChangeLog
Feb 8 2019, 9:02 PM
vandenoever committed R881:bba4964e3180: Fix error where Cargo.toml could not be found (authored by vandenoever).
Fix error where Cargo.toml could not be found
Feb 8 2019, 9:02 PM

Jan 22 2019

vandenoever added a comment to D18456: actually look for mysql binaries in PATH.

On NixOS, all executables are under /nix/store/$HASH-$NAME/bin. These get linked into the PATH. Seeing that Akonadi was not respecting PATH previously I wonder how it could work there.
So I checked https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/kde/akonadi/akonadi-paths.patch

Jan 22 2019, 3:25 PM · KDE PIM

Jan 21 2019

vandenoever committed R881:ad94fb1036a3: cargo fmt (authored by vandenoever).
cargo fmt
Jan 21 2019, 11:04 PM
vandenoever committed R881:1e4d769b32a9: Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator (authored by vandenoever).
Merge branch 'master' of git://anongit.kde.org/rust-qt-binding-generator
Jan 21 2019, 10:45 PM
vandenoever committed R881:0c67f8bc324f: Update version to 0.3.0 (authored by vandenoever).
Update version to 0.3.0
Jan 21 2019, 10:45 PM
vandenoever committed R881:7c8bb6a5351c: Add function to choose what Qt modules to link to (authored by vandenoever).
Add function to choose what Qt modules to link to
Jan 21 2019, 10:45 PM

Dec 30 2018

vandenoever committed R237:f403d09d0b49: Fix a regression introduced in 6a1852 (authored by vandenoever).
Fix a regression introduced in 6a1852
Dec 30 2018, 12:22 PM
vandenoever closed D17856: Fix a regression introduced in 6a1852.
Dec 30 2018, 12:22 PM · Frameworks

Dec 29 2018

vandenoever added reviewers for D17856: Fix a regression introduced in 6a1852: dfaure, arichardson, apol, aacid, ngraham.
Dec 29 2018, 5:29 PM · Frameworks
vandenoever added a comment to D17651: Escape bytes that are larger than or equal to 127 in config files.

Sure. It's here https://phabricator.kde.org/D17856

Dec 29 2018, 5:28 PM · Frameworks
vandenoever requested review of D17856: Fix a regression introduced in 6a1852.
Dec 29 2018, 5:27 PM · Frameworks
vandenoever added a comment to D17651: Escape bytes that are larger than or equal to 127 in config files.

Here is a patch that solves the problem:

diff --git a/src/core/kconfigini.cpp b/src/core/kconfigini.cpp
index 39e5936..b674973 100644
--- a/src/core/kconfigini.cpp
+++ b/src/core/kconfigini.cpp
@@ -673,7 +673,12 @@ QByteArray KConfigIniBackend::stringToPrintable(const QByteArray &aString, Strin
         switch (s[i]) {
         default:
             // The \n, \t, \r cases (all < 32) are handled below; we can ignore them here
-            if (((unsigned char)s[i]) < 32 || ((unsigned char)s[i]) >= 127) {
+            if (((unsigned char)s[i]) < 32) {
+                goto doEscape;
+            }
+            // GroupString and KeyString should be valid UTF-8, but ValueString
+            // can be a bytearray with non-UTF-8 bytes that should be escaped.
+            if (type == ValueString && ((unsigned char)s[i]) >= 127) {
                 goto doEscape;
             }
             *data++ = s[i];
Dec 29 2018, 5:05 PM · Frameworks
vandenoever added a comment to D17651: Escape bytes that are larger than or equal to 127 in config files.

Found it. This is the failing test.

FAIL!  : KConfigTest::testEncoding() Compared values are not the same
   Actual   (lines.first())                    : "[UTF-8:\\xc3\\xb6l]\n"
   Expected (QByteArray("[UTF-8:\xc3\xb6l]\n")): "[UTF-8:\xC3\xB6l]\n"
   Loc: [/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.11/autotests/kconfigtest.cpp(463)]
Dec 29 2018, 4:30 PM · Frameworks

Dec 28 2018

vandenoever added a comment to D17651: Escape bytes that are larger than or equal to 127 in config files.

Can you give some more details? I see no problem on Jenkins. https://build.kde.org/job/Frameworks/job/kconfig/

Dec 28 2018, 9:57 PM · Frameworks

Dec 18 2018

vandenoever added a comment to D17651: Escape bytes that are larger than or equal to 127 in config files.

I pushed two encore commits fixing the two raised issues.

Dec 18 2018, 11:37 PM · Frameworks
vandenoever committed R237:16eea19c5b79: Remove unneeded qWarning (authored by vandenoever).
Remove unneeded qWarning
Dec 18 2018, 11:35 PM
vandenoever committed R237:16691c2742a8: Deduplicate reference value (authored by vandenoever).
Deduplicate reference value
Dec 18 2018, 11:35 PM
vandenoever committed R237:6a185285ae44: Escape bytes that are larger than or equal to 127 in config files (authored by vandenoever).
Escape bytes that are larger than or equal to 127 in config files
Dec 18 2018, 8:34 PM
vandenoever closed D17651: Escape bytes that are larger than or equal to 127 in config files.
Dec 18 2018, 8:34 PM · Frameworks
vandenoever updated the diff for D17651: Escape bytes that are larger than or equal to 127 in config files.

Add a check for reading in the unit test.

Dec 18 2018, 6:57 PM · Frameworks
vandenoever updated the summary of D17651: Escape bytes that are larger than or equal to 127 in config files.
Dec 18 2018, 6:50 PM · Frameworks
vandenoever updated the diff for D17651: Escape bytes that are larger than or equal to 127 in config files.

Added a unit test and changed the code so that 0x7f (DEL) is also
escaped.

Dec 18 2018, 6:49 PM · Frameworks
vandenoever retitled D17651: Escape bytes that are larger than or equal to 127 in config files from Escape bytes that larger than 127 to Escape bytes that are larger than 127 in config files.
Dec 18 2018, 3:07 PM · Frameworks
vandenoever added reviewers for D17651: Escape bytes that are larger than or equal to 127 in config files: dfaure, arichardson.
Dec 18 2018, 1:55 PM · Frameworks
vandenoever updated the summary of D17651: Escape bytes that are larger than or equal to 127 in config files.
Dec 18 2018, 1:09 PM · Frameworks
vandenoever updated the summary of D17651: Escape bytes that are larger than or equal to 127 in config files.
Dec 18 2018, 12:57 PM · Frameworks
vandenoever requested review of D17651: Escape bytes that are larger than or equal to 127 in config files.
Dec 18 2018, 12:56 PM · Frameworks

Dec 9 2018

vandenoever committed R881:0fb6e84077f7: Increase version to 0.2.2 and update ChangeLog (authored by vandenoever).
Increase version to 0.2.2 and update ChangeLog
Dec 9 2018, 11:36 PM
vandenoever committed R881:ecd135f31132: Fix build with rust <= 1.30 (authored by vandenoever).
Fix build with rust <= 1.30
Dec 9 2018, 11:32 PM
vandenoever committed R881:86652e860562: Increase version to 0.2.1 and add ChangeLog (authored by vandenoever).
Increase version to 0.2.1 and add ChangeLog
Dec 9 2018, 11:22 PM
vandenoever committed R881:b41b1be3369c: Add anonymous parameter placeholders to generated code (authored by vandenoever).
Add anonymous parameter placeholders to generated code
Dec 9 2018, 11:22 PM
vandenoever committed R881:319991e77fa5: Add anonymous parameter placeholders to generated code (authored by vandenoever).
Add anonymous parameter placeholders to generated code
Dec 9 2018, 10:45 PM
vandenoever added a comment to D17447: Add support for Rust 2018 edition projects..

Thank you very much Owen! Hope you're enjoying Rust Qt Binding Generator.

Dec 9 2018, 10:36 PM
vandenoever committed R881:325ffc2a2c84: Add support for Rust 2018 edition projects. (authored by onelson).
Add support for Rust 2018 edition projects.
Dec 9 2018, 10:34 PM
vandenoever closed D17447: Add support for Rust 2018 edition projects..
Dec 9 2018, 10:34 PM
vandenoever added a comment to D17447: Add support for Rust 2018 edition projects..

It's a very clear patch and well documented. I'd prefer it to use an enum though. I've put a suggestion in the code.

Dec 9 2018, 9:28 PM
vandenoever added a comment to D17447: Add support for Rust 2018 edition projects..

I would prefer it if the patch would parse Cargo.toml to determine the edition of Rust. This can be done with the toml crate.

Dec 9 2018, 1:22 PM
vandenoever added a comment to D17447: Add support for Rust 2018 edition projects..

I've tried the patch. To get a 2018 project to compile, cargo needs to know about the 2018 edition feature:

rust_qt_binding_generator = { path = "../rust_qt_binding_generator", features = ["use-2018-edition"] }
Dec 9 2018, 1:09 PM
vandenoever added a comment to D17447: Add support for Rust 2018 edition projects..

Thank you for the simple patch. Is use-2018-edition a feature that is automatically set by Cargo when edition = "2018"? I've not found the documentation on that.

Dec 9 2018, 11:59 AM

Nov 24 2018

vandenoever committed R881:4acf7e3176c7: Resolve resource path relative to qrc path (authored by vandenoever).
Resolve resource path relative to qrc path
Nov 24 2018, 1:14 PM

Nov 11 2018

vandenoever committed R881:f678d441e9fe: Fix building with MSVC (authored by vandenoever).
Fix building with MSVC
Nov 11 2018, 4:05 PM

Nov 1 2018

vandenoever accepted D16576: Use more rust syntactic sugar.

Looks good. Thanks and welcome to Rust Qt Binding Generator.

Nov 1 2018, 10:16 AM
vandenoever requested changes to D16576: Use more rust syntactic sugar.

Nice work, Carl.

Nov 1 2018, 7:20 AM

Oct 29 2018

vandenoever committed R881:e6d220bc1808: Increase version number and add ChangeLog (authored by vandenoever).
Increase version number and add ChangeLog
Oct 29 2018, 9:41 PM
vandenoever committed R881:037322f27008: Cleanup code (authored by vandenoever).
Cleanup code
Oct 29 2018, 9:41 PM