brauch (Sven Brauch)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2016, 10:25 AM (138 w, 6 d)
Availability
Available

Recent Activity

Yesterday

brauch committed R877:347930b1086d: KDevelop: build 5.3 beta tarballs (authored by brauch).
KDevelop: build 5.3 beta tarballs
Sun, Sep 23, 11:31 PM

Wed, Sep 19

brauch committed R32:997be66c7fc6: appimage: fix clang plugin from not loading (authored by brauch).
appimage: fix clang plugin from not loading
Wed, Sep 19, 9:13 PM

Wed, Sep 5

brauch accepted D14818: Fix ClassNameReferences..

I'm not really capable of doing an in-depth review here, since I don't know enough details of PHP nowadays. Style-wise I think it could still profit from reducing the block size of un-named (i.e. not a function with a name), uncommented complex code a bit, since it often requires quite some thinking to grasp what a certain conditional actually checks for. A simple comment like "// not a function" or whatever can do wonders there.
Feel free to merge this as-is or with a bit more comments, better get it in before the beta and still have a fix window before the release than merge it after the beta. Thanks for keeping kdev-php alive!

Wed, Sep 5, 5:42 PM · KDevelop
brauch added a comment to D14865: clang: include tooltips: fix range check.

I'm super confused by the diff phabricator shows below but the commited changes are correct (and different from the diff here) ... what's going on?

Wed, Sep 5, 7:56 AM · KDevelop
brauch added a comment to D7010: KSqueezedTextLabel: call updateGeometry() when text changes.

For the record, I tried writing a test for this but didn't succeed and eventually put it aside, although the difference is easily visible in a test application. There must be a reason why the naive test case behaves differently from an interactive application ... I could take another look, I guess.

Wed, Sep 5, 7:48 AM · Frameworks

Aug 21 2018

brauch committed R499:08c8604fc862: Set stable branch of KDevelop + plugins to 5.3 (authored by brauch).
Set stable branch of KDevelop + plugins to 5.3
Aug 21 2018, 11:28 AM

Aug 20 2018

brauch committed R32:c0e3d5248aa6: Add ExplicitlyTyped flag to Declaration. (authored by michalsrb).
Add ExplicitlyTyped flag to Declaration.
Aug 20 2018, 9:37 AM
brauch closed D14838: Add ExplicitlyTyped flag to Declaration..
Aug 20 2018, 9:37 AM · KDevelop
brauch committed R877:45127004671e: set version to 5.2.4 for KDevelop (authored by brauch).
set version to 5.2.4 for KDevelop
Aug 20 2018, 9:15 AM

Aug 19 2018

brauch committed R53:0a886a8b0c4e: Set version number to 5.2.4 (authored by brauch).
Set version number to 5.2.4
Aug 19 2018, 2:53 PM
brauch committed R52:5f9eed585d69: Set version number to 5.2.4 (authored by brauch).
Set version number to 5.2.4
Aug 19 2018, 2:51 PM
brauch committed R32:9a09ad18da80: Set version number to 5.2.4 (authored by brauch).
Set version number to 5.2.4
Aug 19 2018, 2:50 PM

Aug 17 2018

brauch added a comment to D14897: InlineNote: Pimpl inline note data without allocs.

Sorry, never mind -- that code I removed yesterday. All should be fine.

Aug 17 2018, 11:41 AM · Frameworks, Kate
brauch added a comment to D14897: InlineNote: Pimpl inline note data without allocs.

Looks ok to me, except one thing: the operator== is used to compare a note from the list to the "currently active" note in the view. If this compares also the "under mouse" state, this code might be broken now ...?

Aug 17 2018, 11:07 AM · Frameworks, Kate
brauch added a comment to D14818: Fix ClassNameReferences..

Good amount of tests :) For the actual implementation, I would suggest trying to make it a bit more readable by a) splitting it up into several functions and b) trying to reduce indent depth a bit by using continue instead of nested ifs.

Aug 17 2018, 9:48 AM · KDevelop
brauch accepted D14876: Improved type detection for object properties..

Maybe you make the the visitAssignment code a bit more readable by breaking it up into 2-3 functions?

Aug 17 2018, 9:41 AM · KDevelop
brauch accepted D14839: Improve resolution of namespaced identifiers..

As I said at Akademy already, I am neither familiar with the code of the PHP plugin nor with the later developments in the language itself, so I'm not a good reviewer for these patches. But since you want to get them in and nobody else seems to have time, I have read through this and I can't spot anything obviously wrong or stupid. We'll have a beta to try it out :)

Aug 17 2018, 9:31 AM · KDevelop
brauch added a comment to D14894: [RFC] Fix block mode for multi-cursor branch.

Thanks for the patch, the approach looks reasonable at a first glance. You might want to unite the up/down functions ...
It is too much of a WiP to merge it like this, though.

Aug 17 2018, 9:05 AM · Frameworks, Kate

Aug 16 2018

brauch committed R39:a534a608fa67: fix build: link against KF5::SyntaxHighlighting where needed (authored by brauch).
fix build: link against KF5::SyntaxHighlighting where needed
Aug 16 2018, 11:15 PM
brauch committed R39:4ea5fee0afe5: Add inline note interface (authored by brauch).
Add inline note interface
Aug 16 2018, 11:15 PM
brauch closed D14826: inline note interface wip #2.

commit 4ea5fee0afe5c76bbee07563c23ede808aa059de
Author: Sven Brauch <mail@svenbrauch.de>
Date: Tue Aug 14 12:31:31 2018 +0200

Aug 16 2018, 11:15 PM · Frameworks, Kate
brauch updated the diff for D14826: inline note interface wip #2.

update license text

Aug 16 2018, 9:53 PM · Frameworks, Kate
brauch updated the diff for D14826: inline note interface wip #2.

Implement Dominik's suggestions

Aug 16 2018, 9:49 PM · Frameworks, Kate
brauch added a comment to D14879: Fix VariableToolTip auto resizing..

The patches you submitted recently are all very nice, if you feel think you are going to contribute more things in the future, I'm sure we can give you the permission bit to write to the KDE repos yourself :)
Just let us know at any time if you want that.

Aug 16 2018, 3:21 PM · KDevelop
brauch committed R32:6b146066a491: Fix VariableToolTip auto resizing. (authored by michalsrb).
Fix VariableToolTip auto resizing.
Aug 16 2018, 3:18 PM
brauch closed D14879: Fix VariableToolTip auto resizing..
Aug 16 2018, 3:18 PM · KDevelop
brauch added a comment to D14870: Inject environment profile variables into debug process environment..

Of course arc is too stupid for the special characters in your name, sorry about that ...

Aug 16 2018, 12:19 PM · KDevelop
brauch committed R53:6b7846263088: Inject environment profile variables into debug process environment. (authored by Kebianizao).
Inject environment profile variables into debug process environment.
Aug 16 2018, 12:18 PM
brauch closed D14870: Inject environment profile variables into debug process environment..
Aug 16 2018, 12:18 PM · KDevelop
brauch added a comment to D14870: Inject environment profile variables into debug process environment..

No, you need special karma to push to the KDE repos. If you are not aware you have this, you have not ;)
I will submit this for you later.

Aug 16 2018, 12:05 PM · KDevelop
brauch accepted D14870: Inject environment profile variables into debug process environment..

This change looks very reasonable to me. Thank you!

Aug 16 2018, 6:45 AM · KDevelop

Aug 15 2018

brauch added a comment to D14710: Inject default environment group variables into debug process environment..

I'm actually fine with this approach, I just don't understand why the environment is set once on the process and once on the job. Why is this necessary, or do I misunderstand what it's doing ...?

Aug 15 2018, 9:57 PM · KDevelop
brauch updated the diff for D14826: inline note interface wip #2.

address Dominik's suggestion and split focus handling and click handling

Aug 15 2018, 9:55 PM · Frameworks, Kate
brauch committed R52:97235b1455c6: Merge branch 'master' into 5.3 (authored by brauch).
Merge branch 'master' into 5.3
Aug 15 2018, 9:33 PM
brauch added a comment to D14710: Inject default environment group variables into debug process environment..

I have infinite patience in watching other people do the work, so by all means, go ahead! :-)

Aug 15 2018, 9:03 PM · KDevelop
brauch added a comment to D14710: Inject default environment group variables into debug process environment..

Thanks for the patch!

Aug 15 2018, 8:43 PM · KDevelop
brauch requested review of D14865: clang: include tooltips: fix range check.
Aug 15 2018, 7:48 PM · KDevelop
brauch updated the diff for D14826: inline note interface wip #2.

I added the rest of the interaction interface (click, mouseover)
and reduced the API a bit by moving a few hints into the InlineNote
object.

Aug 15 2018, 6:26 PM · Frameworks, Kate

Aug 14 2018

Restricted Application added a project to D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights: Kate.

Can't we simply update our shipped schemas, and expect users with custom schemas to fix them?

Aug 14 2018, 9:21 PM · Kate, Frameworks
brauch committed R52:d4f4291bdf92: Merge branch 'master' into 5.3 (authored by brauch).
Merge branch 'master' into 5.3
Aug 14 2018, 8:21 PM
brauch committed R52:38d2dbfaee7e: Set version to 5.2.80 (authored by brauch).
Set version to 5.2.80
Aug 14 2018, 8:21 PM
brauch committed R32:aa167a2de736: Set version number to 5.2.80 (authored by brauch).
Set version number to 5.2.80
Aug 14 2018, 8:19 PM
brauch accepted D14840: Fix last > rowCount() assert in ClassModel Node dtor.

Somehow I find the code rather strange, with the destructor removing items from the item model ...
But ok, if you tried it out and it fixes the problem, I guess it's fine.

Aug 14 2018, 3:41 PM · KDevelop
brauch updated the diff for D14826: inline note interface wip #2.

add noteActivated notifier function

Aug 14 2018, 3:23 PM · Frameworks, Kate
brauch accepted D14838: Add ExplicitlyTyped flag to Declaration..

Looks good to me, even with unit test! :)
If nobody objects within the next few days, I'll merge this.

Aug 14 2018, 2:53 PM · KDevelop
brauch added a comment to D14826: inline note interface wip #2.

Thanks for the feedback! I will try doing a few more things with this interace and then maybe discuss again with the other kate people here at Akademy about which one they like better.

Aug 14 2018, 2:12 PM · Frameworks, Kate
brauch reassigned T3662: Multi-Cursor: block selection mode is broken from brauch to lepagevalleeemmanuel.
Aug 14 2018, 1:41 PM · KTextEditor
brauch updated the diff for D14826: inline note interface wip #2.

add missing files

Aug 14 2018, 1:08 PM · Frameworks, Kate
brauch added a comment to D14826: inline note interface wip #2.

Sample patch for KDevelop's problem highlighter plus screenshot:


Aug 14 2018, 11:44 AM · Frameworks, Kate
brauch updated the summary of D14826: inline note interface wip #2.
Aug 14 2018, 11:39 AM · Frameworks, Kate
brauch added reviewers for D14826: inline note interface wip #2: michalsrb, dhaumann, cullmann.
Aug 14 2018, 10:33 AM · Frameworks, Kate
brauch requested review of D14826: inline note interface wip #2.
Aug 14 2018, 10:32 AM · Frameworks, Kate

Aug 13 2018

brauch added a comment to D14479: Store sizeof and friends as numbers instead of comment..

Ok, fine with me, I don't care much about the type. I just stumbled upon the comment and then noticed the type as well. Thanks for the patch, all fine from my side :)

Aug 13 2018, 7:35 PM · KDevelop
brauch closed D14791: Fix assert in ClassModel::nodesRemoved.

Submitted with f30ef7c6f1376 to 5.2, sorry, I forgot to set the diff in the commit message.

Aug 13 2018, 1:49 PM · KDevelop
brauch committed R32:f30ef7c6f137: Fix assert in ClassModel::nodesRemoved (authored by buschinski).
Fix assert in ClassModel::nodesRemoved
Aug 13 2018, 1:48 PM
brauch committed R32:ea29d8404df9: Fix assert in ClassModel::nodesRemoved (authored by buschinski).
Fix assert in ClassModel::nodesRemoved
Aug 13 2018, 1:47 PM
brauch accepted D14791: Fix assert in ClassModel::nodesRemoved.

Good find, the previous code (remove item -> call beginRemoveRows() -> call endRemoveRows()) definitely looks wrong. Can you submit this yourself?
Otherwise, I'd need an email address to set as the commit author.

Aug 13 2018, 1:40 PM · KDevelop
brauch accepted D14789: Ignore file size limit for internal data files..

Now I would compute the fileInfo's canonicalPath only once (it might require a stat) and then this looks okay :)
I can't accept it apparently because the discussion is still open ...

Aug 13 2018, 1:34 PM · KDevelop
brauch accepted R52:45329c939edf: Properly get the DUChain lock for constant declarations..

Yes, that looks reasonable.

Aug 13 2018, 12:31 PM
brauch added a comment to D12662: Add InlineNoteInterface.

I'd like to play with this a bit wrt what can be done in KDevelop with it (I want the problem popups gone). Would you mind if I do some changes along the way? I would post an updated patch here, in case I actually come up with useful changes ...

Aug 13 2018, 12:29 PM · Frameworks, Kate
brauch requested changes to D14789: Ignore file size limit for internal data files..
Aug 13 2018, 12:22 PM · KDevelop
brauch added inline comments to D14479: Store sizeof and friends as numbers instead of comment..
Aug 13 2018, 12:09 PM · KDevelop
brauch committed R40:90f51f5830e3: quickopen: optimize: remove model from SortFilter proxy model during populate (authored by brauch).
quickopen: optimize: remove model from SortFilter proxy model during populate
Aug 13 2018, 8:54 AM
brauch closed D14761: quickopen: optimize: remove model from SortFilter proxy model during populate.
Aug 13 2018, 8:54 AM · Kate
brauch committed R39:5499a0df825c: completion widget: fix minimum header section size (authored by brauch).
completion widget: fix minimum header section size
Aug 13 2018, 8:47 AM
brauch closed D14773: completion widget: fix minimum header section size.
Aug 13 2018, 8:47 AM · Frameworks, Kate
brauch committed R39:2815fea7854f: Fix: Scroll view lines instead of real lines for wheel and touchpad scrolling (authored by brauch).
Fix: Scroll view lines instead of real lines for wheel and touchpad scrolling
Aug 13 2018, 8:47 AM
brauch closed D14758: use view lines for wheel scrolling, not real lines.
Aug 13 2018, 8:47 AM · Frameworks, Kate
brauch committed R39:d40056b534cb: Merge branch 'master' into multicursor (authored by brauch).
Merge branch 'master' into multicursor
Aug 13 2018, 8:44 AM
brauch committed R39:193bce4cc218: view: wheel scrolling: scroll by dynwrap line, not real line (authored by brauch).
view: wheel scrolling: scroll by dynwrap line, not real line
Aug 13 2018, 8:44 AM
brauch committed R39:841ad634b100: completion widget: fix minimum header section size (authored by brauch).
completion widget: fix minimum header section size
Aug 13 2018, 8:44 AM
brauch added a comment to D12662: Add InlineNoteInterface.

By the way, other people around here are very impressed by this patch as well, and we'd really like to get this merged :)
Moving e.g. KDevelop's warning markers into an inline note instead of the annoying popup would make a real difference for usability ...

Aug 13 2018, 8:25 AM · Frameworks, Kate
brauch added a comment to D12662: Add InlineNoteInterface.

Wow, that looks amazing! Really impressive.

Aug 13 2018, 8:24 AM · Frameworks, Kate
brauch added a comment to D14758: use view lines for wheel scrolling, not real lines.

The "overly sensitive touchpad" issue seems to be missing accumulation of scroll events, so this patch to my understanding should not have it.

Yeah, I don't think that's our bug, and we shouldn't work around it here. The reporter should file a bug against libinput.

Aug 13 2018, 8:07 AM · Frameworks, Kate

Aug 12 2018

brauch added a comment to D14758: use view lines for wheel scrolling, not real lines.

The "overly sensitive touchpad" issue seems to be missing accumulation of scroll events, so this patch to my understanding should not have it.

Aug 12 2018, 9:33 PM · Frameworks, Kate
brauch added a comment to D14758: use view lines for wheel scrolling, not real lines.

I will modify the commit message as suggested.

Aug 12 2018, 9:28 PM · Frameworks, Kate
brauch requested review of D14773: completion widget: fix minimum header section size.
Aug 12 2018, 5:20 PM · Frameworks, Kate
brauch added a comment to D14618: Create action to jump to the current execution line in debug mode..

Ok, I'll submit it later today then.

Aug 12 2018, 2:21 PM · KDevelop
brauch accepted D14618: Create action to jump to the current execution line in debug mode..

This looks good to me, feel free to submit it (can you?). Thanks!

Aug 12 2018, 2:18 PM · KDevelop
brauch accepted D14113: Reschedule parse jobs also when the parse queue is empty..

Yes, that makes sense to me.

Aug 12 2018, 2:16 PM · KDevelop
brauch requested review of D14761: quickopen: optimize: remove model from SortFilter proxy model during populate.
Aug 12 2018, 11:33 AM · Kate
brauch added a comment to D12662: Add InlineNoteInterface.

Hey there, what's happening to this? I think this is a really nice feature and it would be very sad if it would bitrot :(
Anything anyone can assist with? We are currently at Akademy, KDE's annual conference, so we would have time to discuss any issues right now.

Aug 12 2018, 9:54 AM · Frameworks, Kate
brauch requested review of D14758: use view lines for wheel scrolling, not real lines.
Aug 12 2018, 8:37 AM · Frameworks, Kate

Aug 6 2018

brauch accepted D14645: clang: Fix crash in completion on unexpectedly missing FunctionType.

We should try to figure out what code leads to creating a function declaration with no function type assigned, but this check makes sense in any case. Thank you!

Aug 6 2018, 10:36 AM · KDevelop

Jul 27 2018

brauch added a comment to D14408: SymbolView: Avoid unneeded update of current item.

That said, I can understand your mood (I've felt the same before with things I submitted somewhere, I think everyone has) and I'm sorry for it. But I agree with Kore that we should try to merge patches based on what objectively makes things better.

Jul 27 2018, 7:16 PM · Kate
brauch added a comment to D14408: SymbolView: Avoid unneeded update of current item.

Thanks for the hint.

Right now I'm not in the mood to do this, and a look at the hotspot dependencies in AUR make it even worse.

Jul 27 2018, 7:14 PM · Kate
brauch added a comment to D14408: SymbolView: Avoid unneeded update of current item.

Just install perf and hotspot, then compile in "RelWithDebInfo" mode and run

Jul 27 2018, 3:29 PM · Kate

Jun 23 2018

brauch committed R32:144ab70c5d40: Open konsole with the active document's project root or it's directory (authored by amhndu).
Open konsole with the active document's project root or it's directory
Jun 23 2018, 3:01 PM
brauch closed D13654: Open konsole tool with the single project's root directory.
Jun 23 2018, 3:01 PM · KDevelop
brauch added a comment to D13654: Open konsole tool with the single project's root directory.

Looks reasonable to me. Can you submit the patch yourself or should I do it?

Jun 23 2018, 2:46 PM · KDevelop
brauch accepted D13654: Open konsole tool with the single project's root directory.

No, this looks good to me. Thanks!

Jun 23 2018, 2:27 PM · KDevelop
brauch added inline comments to D13654: Open konsole tool with the single project's root directory.
Jun 23 2018, 11:29 AM · KDevelop
brauch added a comment to D13444: Update to display the name of the session in the "Delete Session" confirmation dialogue box.

Of course, nobody is exactly sitting here thinking "eeh, now I've been waiting for that guy for *weeks* to get his patch in" ;)
If you need advice, feel free to ask.

Jun 23 2018, 11:26 AM · KDevelop

Jun 21 2018

brauch added a comment to D13444: Update to display the name of the session in the "Delete Session" confirmation dialogue box.

No, I think you should introduce a way to get the session name before the colon is added. You can introduce a new role for the item model for example, have a look at QStandardItem::setData.

Jun 21 2018, 6:24 PM · KDevelop
brauch added a comment to D13444: Update to display the name of the session in the "Delete Session" confirmation dialogue box.

Try opening a few projects in the session. The names of these projects should follow the colon afterwards.

Jun 21 2018, 11:22 AM · KDevelop
brauch added a comment to D13444: Update to display the name of the session in the "Delete Session" confirmation dialogue box.

AFAIK that is followed by the names of the projects open in that session, and that is also where your approach with chopping of the chars will probably go wrong.

Jun 21 2018, 10:35 AM · KDevelop
brauch added a comment to D13444: Update to display the name of the session in the "Delete Session" confirmation dialogue box.

Can I get an instance when chopping off the last 3 letters won't work? Like, shouldn't the last 3 letters always be ": "
Or will it change if the name of the session's too big or something?

Jun 21 2018, 8:29 AM · KDevelop
brauch added a comment to D13444: Update to display the name of the session in the "Delete Session" confirmation dialogue box.

KDE only uses github as a read-only mirror. You will get a notification when it is submitted.

Jun 21 2018, 8:09 AM · KDevelop
brauch added inline comments to D13444: Update to display the name of the session in the "Delete Session" confirmation dialogue box.
Jun 21 2018, 7:33 AM · KDevelop
brauch accepted D13444: Update to display the name of the session in the "Delete Session" confirmation dialogue box.

Otherwise looks good, I can submit this later.

Jun 21 2018, 7:23 AM · KDevelop