brauch (Sven Brauch)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2016, 10:25 AM (108 w, 5 d)
Availability
Available

Recent Activity

Yesterday

brauch accepted D10311: Projects plugin: fix git file listing for umlauts such as äöü.

Looks good to me, also because null termination sounds better than \n (filenames can easily contain \n although they usually don't).

Sat, Feb 24, 11:56 PM · Kate

Jan 13 2018

brauch committed R32:71f7bed96dd0: fix crash when stopping process (authored by brauch).
fix crash when stopping process
Jan 13 2018, 9:58 PM
brauch closed D9858: dont crash when cancelling process.
Jan 13 2018, 9:57 PM
brauch updated the summary of D9858: dont crash when cancelling process.
Jan 13 2018, 3:41 PM

Jan 2 2018

brauch added reviewers for D9624: Install parser headers and cmake config files to support client packages: pprkut, kfunk, mtijink.

I'll add some people who have recently been working on kdev-php.

Jan 2 2018, 11:04 PM

Dec 30 2017

brauch accepted D9569: Fix wildcard matching for modelines.

Heh. Fix looks obviously correct to me (good find), and tests are always nice.

Dec 30 2017, 8:31 PM · Frameworks, Kate

Dec 24 2017

brauch committed R39:ee0d4a1009b9: Merge branch 'master' into multicursor (authored by brauch).
Merge branch 'master' into multicursor
Dec 24 2017, 9:44 PM

Dec 23 2017

brauch reopened D7660: Fix a regression caused by changing backspace key behavior.
Dec 23 2017, 10:44 PM · Frameworks
brauch added a comment to D7660: Fix a regression caused by changing backspace key behavior.

After this was submitted master doesn't compile for me, and if I fix the compile in the trivial way the test fails. Can you have another look?

Dec 23 2017, 10:40 PM · Frameworks
brauch accepted D9488: Fix appstream metadata filename and some content, and install it.

All the changes look sensible to me, thanks!

Dec 23 2017, 3:44 PM

Dec 21 2017

brauch accepted D9472: Format comments before setting them on the DUChain.

All three changes look good to me, although the formatting of comments is of course only useful until that clang bug is fixed ... but still, better than nothing and esp. when we already have the implentation in the codebase anyways.

Dec 21 2017, 11:58 PM

Dec 17 2017

brauch added a comment to D9363: Add support for __DIR__ and __TRAIT__..

String change is probably ok if there is enough time before the next release (a few weeks) AFAIU. My two cents about where to merge it would be, put it in 5.2 only if you consider it a bug fix -- i.e. if there are projects which do not parse properly because this feature is missing go for it, otherwise put it in master. There's nothing worse than adding regression bugs in patch releases because of minor features like this.

Dec 17 2017, 1:49 PM
brauch accepted D9363: Add support for __DIR__ and __TRAIT__..

I'm not up-to-date with the PHP standard, but guessing what the language feature does, code-wise this looks fine to me.

Dec 17 2017, 12:30 PM

Dec 14 2017

brauch accepted D9236: Fill lists of default-constructed types directly, not append any by value.

Not much is left of the original patch but this change makes sense to me ;) thanks!

Dec 14 2017, 9:09 AM

Dec 13 2017

brauch requested changes to D9316: Remove KF5::ItemModels from public interface of KDevPlatformUtil.

Yeah, sorry, I'm also against this. Linking an extra lib we depend on anyways is a problem a compuer has to deal with, extra code is a problem humans have to deal with. The former wins against the latter unless there is a very good reason why not.

Dec 13 2017, 10:38 PM
brauch committed R39:5deca9c7bed6: Merge branch 'master' into multicursor (authored by brauch).
Merge branch 'master' into multicursor
Dec 13 2017, 7:57 AM

Dec 12 2017

brauch added a comment to D9297: Fix #387391: Random responses from the C/C++ language support.

Hmm. There's a comment in the line above which states it explicitly uses canonicalFilePath to avoid issues with symlinks. If we resolve symlinks like you suggest, there will be situations like files which are part of a project but for which the project's root directory is not a prefix of the file path. Are we somewhat sure this doesn't break in other places?

Dec 12 2017, 2:53 PM · KDevelop

Dec 10 2017

brauch committed R39:3c86fe77cc01: implement "selection to aligned block" (authored by brauch).
implement "selection to aligned block"
Dec 10 2017, 8:42 PM
brauch committed R39:484013bb10a7: use multi-selection for "find all" (authored by brauch).
use multi-selection for "find all"
Dec 10 2017, 12:48 PM

Dec 7 2017

brauch added a comment to D9236: Fill lists of default-constructed types directly, not append any by value.

Is this actually faster? Why?

Dec 7 2017, 5:44 PM

Dec 4 2017

brauch added a comment to D9160: QList -> QVector where sizeof(T) > sizeof(void*).

Hmm, this will break build of all the plugins, no? Other than that, I'm in favour of this change, thanks for the work!

Dec 4 2017, 7:10 AM

Dec 3 2017

brauch committed R39:40685be38791: implement block select as a transform between block- and continuous selection (authored by brauch).
implement block select as a transform between block- and continuous selection
Dec 3 2017, 10:16 PM

Dec 1 2017

brauch committed R39:2ceedf47557f: fix selection being randomly cleared when drag-scrolling (authored by brauch).
fix selection being randomly cleared when drag-scrolling
Dec 1 2017, 6:56 PM

Nov 30 2017

brauch accepted D9074: Add "Open a Session" action for app jump list in task manager & Co..

Yes, cool feature, go for it!

Nov 30 2017, 7:59 PM
brauch committed R39:1967b78afaa7: rename "Mouse" selection mode to "Character" (authored by brauch).
rename "Mouse" selection mode to "Character"
Nov 30 2017, 1:09 PM
brauch committed R39:688b6ef1f3d1: implement two-anchor word select (authored by brauch).
implement two-anchor word select
Nov 30 2017, 12:32 PM
brauch committed R39:3bb6f6cb5b57: mostly fix word select: spaces handled properly now (authored by brauch).
mostly fix word select: spaces handled properly now
Nov 30 2017, 1:47 AM
brauch committed R39:0eee07f161ca: WIP: mouse select tests (authored by brauch).
WIP: mouse select tests
Nov 30 2017, 1:47 AM

Nov 29 2017

brauch accepted D9035: Properly launch Web Browser as detached process and handle errors if ocurred.

Thanks! I'll submit this as well.

Nov 29 2017, 1:39 PM
brauch added a comment to D9046: Update debug messages.

Ah, you don't have write access to KDE repos? Then I will submit this for you. Thanks!

Nov 29 2017, 12:18 PM
brauch committed R39:1f08c2613585: Merge branch 'master' into multicursor (authored by brauch).
Merge branch 'master' into multicursor
Nov 29 2017, 10:53 AM
brauch accepted D9034: Do not crash if there is still pending connections .

Alright, if you think it makes sense, submit it. It's certainly an improvement over the old situation. Thanks!

Nov 29 2017, 10:43 AM
brauch accepted D9046: Update debug messages.

Thanks, please submit!

Nov 29 2017, 10:31 AM

Nov 28 2017

brauch updated the diff for D9016: remove global statics.

Hmpf, right, QList compares its head to its tail which is certainly not atomic. I *think* for QVector this would be safe (it compares its size to zero), but better not take chances. Sorry that this is such a hassle.

Nov 28 2017, 10:58 PM
brauch accepted D9038: Bump cmake_qt5guiapp template to C++11 code, cmake 3.0 and QScopedPointer.

LGTM

Nov 28 2017, 9:59 PM
brauch updated the diff for D9016: remove global statics.

next try :D

Nov 28 2017, 5:21 PM
brauch added a comment to D9035: Properly launch Web Browser as detached process and handle errors if ocurred.

Yes, anyway I use that name because is consistent with the XDebugJob class (which uses the same mehtod name).

Nov 28 2017, 3:22 PM
brauch added a comment to D9034: Do not crash if there is still pending connections .

Ok, but can we not at least set the state to Ended when the connection breaks, or something like that?

Nov 28 2017, 3:14 PM
brauch added a comment to D9034: Do not crash if there is still pending connections .

Hm yes, ok, so it makes sense why this fixes the crash. I think we can keep this as a safety guard. However I think the actual problem is that the state is not set to EndedState when the debug session actually ends, which also has other undesirable consequences (e.g. KDevelop doesn't switch back to code view, etc.). Do you have an idea why this happens?

Nov 28 2017, 2:13 PM
brauch added a comment to D9035: Properly launch Web Browser as detached process and handle errors if ocurred.

To clarify my comment above, if what I said is correct, I would suggest to call the function "processFailedToStart"or so, and make it a non-slot.

Nov 28 2017, 2:08 PM
brauch requested changes to D9035: Properly launch Web Browser as detached process and handle errors if ocurred.
Nov 28 2017, 2:07 PM
brauch added a comment to D9034: Do not crash if there is still pending connections .

I think I hit this issue yesterday when testing kdev-xdebug, esp. the debugger wouldn't stop properly when stepping over the end of the program. I don't quite understand what issue exactly this change fixes and why, can you write a few lines?

Nov 28 2017, 2:00 PM
brauch accepted D9036: Updata signal/slot connect syntax to Qt5.

Very nice, thanks.

Nov 28 2017, 1:59 PM
brauch committed R67:8ff83dbcb2b7: allow configuring port as well (authored by brauch).
allow configuring port as well
Nov 28 2017, 11:07 AM

Nov 27 2017

brauch committed R67:6b6f89423cb0: make sure path starts with a slash (authored by brauch).
make sure path starts with a slash
Nov 27 2017, 10:53 PM
brauch added a comment to D9016: remove global statics.

Static Initializer Order Fiasco, i guess. You can keep Helper class make access through functions.

Nov 27 2017, 8:33 PM
brauch updated the diff for D9016: remove global statics.

Adress issues. Inline local statics where the wrapper function is not needed.

Nov 27 2017, 7:40 PM
brauch created D9016: remove global statics.
Nov 27 2017, 12:35 PM

Nov 23 2017

brauch committed R52:53b4b1fa2443: Set version number to 5.2.1 (authored by brauch).
Set version number to 5.2.1
Nov 23 2017, 12:17 PM
brauch committed R53:039856e47127: Set version number to 5.2.1 (authored by brauch).
Set version number to 5.2.1
Nov 23 2017, 12:17 PM
brauch committed R32:b060b4d3a871: Set version number to 5.2.1 (authored by brauch).
Set version number to 5.2.1
Nov 23 2017, 12:17 PM
brauch committed R32:f537d64007e1: fix compile warning (authored by brauch).
fix compile warning
Nov 23 2017, 12:16 PM
brauch added a comment to D8959: Make more signals non-const.

Well conceptually, a signal is only a signature. The const has no meaning conceptually (what would be the difference between a const and a non-const signal). So it makes sense to pick a normalized form -- the non-const one.

Nov 23 2017, 10:45 AM

Nov 22 2017

brauch added a comment to D8950: Remove source code of unused CVS support plugin..

Hmm, I'm not sure. The thing is, while it is of course an extremely niche feature in 2017, maybe we should look if it is easily fixable. Because *if* you are in the unfortunate situation that you have to interact with a CVS repo, I think you are all the happier if your IDE takes the pain of reading the CVS manual away from you ...

Nov 22 2017, 6:43 PM

Nov 20 2017

brauch closed D8913: compute itemrepository version from version plus KDEVELOP_VERSION.

Sorry, forgot to mention the review in the commit message ...

Nov 20 2017, 2:55 PM
brauch committed R32:53ec893e8271: compute itemrepository version from version plus KDEVELOP_VERSION (authored by brauch).
compute itemrepository version from version plus KDEVELOP_VERSION
Nov 20 2017, 2:53 PM
brauch added a comment to D8913: compute itemrepository version from version plus KDEVELOP_VERSION.

Do we want this in 5.2?

Nov 20 2017, 1:54 PM
brauch updated the diff for D8913: compute itemrepository version from version plus KDEVELOP_VERSION.
Nov 20 2017, 1:53 PM
brauch added a comment to D7995: KDevelop: address dirwatching inefficiency (WIP/PoC).

No, Queued means they are queued in the receiving object's thread's event loop, i.e. the slots are executed in that thread when it re-enters its event loop. Direct means the slots are called immediately, in the sender's thread. There are no other connection types.

Nov 20 2017, 1:33 PM · KDevelop
brauch created D8913: compute itemrepository version from version plus KDEVELOP_VERSION.
Nov 20 2017, 1:27 PM
brauch added a comment to D7995: KDevelop: address dirwatching inefficiency (WIP/PoC).

It's not "asynchronous and complex", it's just a queued connection. It posts an event to the receiving thread, and when that thread next runs its event loop, the slot gets invoked. As Milian says, it's not rocket science.

Nov 20 2017, 11:57 AM · KDevelop

Nov 19 2017

brauch added a comment to D8907: Suspend the background parser during Core initialization.

Ah yes, good point about Q_SIGNALS, makes sense.

Nov 19 2017, 6:46 PM
brauch accepted D8906: Do not create parse jobs while the background parser is suspended.

Nice, thanks.

Nov 19 2017, 6:44 PM
brauch accepted D8901: Add notes to BackgroundParser::resume/suspend.

I'll accept this too so milian is happy about the green tickmark :)

Nov 19 2017, 6:44 PM
brauch accepted D8907: Suspend the background parser during Core initialization.

Makes sense to me. Thanks for working on this issue!

Nov 19 2017, 6:06 PM
brauch added a comment to D8906: Do not create parse jobs while the background parser is suspended.

Can it happen that resume() is called before ThreadWeaver has finished suspending, causing it not to resume? Otherwise LGTM

Nov 19 2017, 5:56 PM
brauch accepted D8905: Add debug output to backgroundparser's resume function.

I'd propose something like "attempting to resume background parser, but it is not suspended" as the warning text, if I see "not suspended" in the output in a year I won't know what it's about

Nov 19 2017, 5:46 PM
brauch accepted D8904: Fix assertion while running testShutdownWithRunningJobs.

LGTM

Nov 19 2017, 5:45 PM
brauch accepted D8903: Cleanup: share code to add jobs to background parser in unit test.

LGTM

Nov 19 2017, 5:39 PM
brauch accepted D8902: Cleanup: Introduce isSuspended helper function.

don't see anything wrong

Nov 19 2017, 5:37 PM
brauch accepted D8900: Simplify code now that we use the new-style connect.

Technically it can fail, I think e.g. if ICore::self()->projectController() is null, but that doesn't happen of course. LGTM

Nov 19 2017, 5:36 PM
brauch accepted D8897: VCS History dialog: show commit message with clickable urls & fixed font.

Ah, alright. Thanks!

Nov 19 2017, 4:57 PM
brauch added a comment to D8897: VCS History dialog: show commit message with clickable urls & fixed font.

Very good to have somebody working on those dialogs, they really need some love. Thanks!

Nov 19 2017, 4:40 PM

Nov 17 2017

brauch committed R32:ab85e001bc69: Merge branch '5.2' (authored by brauch).
Merge branch '5.2'
Nov 17 2017, 7:02 PM
brauch committed R32:49b5df418539: Use Software scene graph backend for welcome page (authored by brauch).
Use Software scene graph backend for welcome page
Nov 17 2017, 7:00 PM
brauch closed D8872: Use software backend for welcome page.
Nov 17 2017, 7:00 PM
brauch added a comment to D8872: Use software backend for welcome page.

Yes, makes sense to me.

Nov 17 2017, 6:44 PM
brauch updated the diff for D8872: Use software backend for welcome page.
Nov 17 2017, 6:43 PM
brauch created D8872: Use software backend for welcome page.
Nov 17 2017, 5:34 PM
brauch closed D8857: work around clang bug 35333: don't crash when switching git branches.

Ok, REVIEW: doesn't close reviews ... submitted with a2712c8d969137 to 5.2. Thanks for the comments.

Nov 17 2017, 12:46 AM
brauch committed R32:a2712c8d9691: work around clang bug 35333: don't crash when switching git branches (authored by brauch).
work around clang bug 35333: don't crash when switching git branches
Nov 17 2017, 12:46 AM

Nov 16 2017

brauch created D8857: work around clang bug 35333: don't crash when switching git branches.
Nov 16 2017, 10:36 PM
brauch added a comment to D8852: Fix crash deep inside VcsOverlayProxyModel::data().

+1 from me, but let apol review it ;)

Nov 16 2017, 5:01 PM
brauch accepted D8842: app: Improve --project handling.

Fine with me.

Nov 16 2017, 2:00 PM

Nov 15 2017

brauch added a comment to D8831: gcclikecompiler: Fix execution of compiler qprocess under windows.

I understand what the patch does, but can you explain why this fixes your issue?

Nov 15 2017, 9:00 PM

Nov 8 2017

brauch committed R32:86bbc9ffe63b: fix templates not working on windows (authored by geetamc).
fix templates not working on windows
Nov 8 2017, 6:15 PM
brauch accepted D8727: fix templates not working on windows.

Good find, please submit to 5.2 :)

Nov 8 2017, 5:26 PM
brauch added inline comments to D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip.
Nov 8 2017, 4:30 PM
brauch added a comment to D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip.

40 characters or 25% of the view's width, whichever is smaller?

Nov 8 2017, 12:31 PM
brauch added a comment to D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip.

Random thought, not sure if useful/technically feasible: the border could also behave like a splitter, allowing to resize it.

Nov 8 2017, 12:13 PM
brauch added a comment to D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip.

Looks cool! The panel is extremely wide, maybe we want it to be a bit less wide ...?

Nov 8 2017, 11:53 AM

Nov 7 2017

brauch added a comment to D8688: Create annotation color from revision hash, not RNG number.

LGTM

Nov 7 2017, 12:46 AM
brauch added inline comments to D8688: Create annotation color from revision hash, not RNG number.
Nov 7 2017, 12:20 AM
brauch accepted D8688: Create annotation color from revision hash, not RNG number.

Looks good, thanks!

Nov 7 2017, 12:10 AM

Nov 5 2017

brauch committed R52:bf690b1a09af: Set version number to 5.2.0 (authored by brauch).
Set version number to 5.2.0
Nov 5 2017, 10:36 AM
brauch committed R53:517d7133f389: Set version number to 5.2.0 (authored by brauch).
Set version number to 5.2.0
Nov 5 2017, 10:36 AM
brauch committed R32:7ad7a7a3e1d5: Set version number to 5.2.0 (authored by brauch).
Set version number to 5.2.0
Nov 5 2017, 10:35 AM

Nov 3 2017

brauch added a comment to D8588: Make VCS data container classes implicitly shared.

No, no objections, it doesn't really do any harm. Thanks!

Nov 3 2017, 11:42 AM

Nov 1 2017

brauch added a comment to D8588: Make VCS data container classes implicitly shared.

In general looks like a good idea and I admire your persistence, but do we really want 3k lines of code of tests testing copy constructors? Does that add value? It seems like it just makes any future changes harder ... It only tests that the compiler-generated code actually does what the compiler claims it will do, no? ;)

Nov 1 2017, 10:05 AM

Oct 22 2017

brauch added a comment to D8300: Added the "save selection/cut selection to file" to Edit menu.

Yeah, the problem with kate plugins is that we have no way to distribute them. We don't have infrastructure for distributing binary plugins, and we don't really support script plugins, and nobody installs your plugin if you put it on github with compile instructions. I'm not sure what that means for this case, I'll leave that decision to the maintainers I think.

Oct 22 2017, 7:17 PM · Kate