brauch (Sven Brauch)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2016, 10:25 AM (86 w, 5 d)
Availability
Available

Recent Activity

Today

brauch committed R32:a5e00ea60419: CXType_Float128 is only available since clang version 38 (authored by brauch).
CXType_Float128 is only available since clang version 38
Sat, Sep 23, 12:01 PM

Yesterday

brauch accepted D7945: Revert automatic grep job execution from Find in Files history.

Looks good to me! The issue it (I think?) fixes is quite annoying, so go please submit and thanks :)

Fri, Sep 22, 10:41 PM

Thu, Sep 21

brauch accepted D7908: Parser: Normalize exception before reading values.

Looks good to me, thanks!

Thu, Sep 21, 11:26 AM

Mon, Sep 18

brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

The deferred starting of the parsing. The dirwatches, sure -- if they are that slow on mac, another solution is needed.

Mon, Sep 18, 8:27 PM · KDevelop
brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

Rene, did you actually read the comments I made on the other RR? I'm fairly sure that is the result an in-depth performance analysis will show too, and I'm faily sure your workaround is not needed if the performance *bugs* this code has are fixed ...

Mon, Sep 18, 3:44 PM · KDevelop

Sat, Sep 16

brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..
In D7745#146271, @rjvbb wrote:
Rene, maybe you want to look into this?

This sounds like it could well be something requiring a substantially deeper understanding of the underlying architecture than I have (and wouldn't normally seek out just for fun ;))

Sat, Sep 16, 12:54 PM · KDevelop
brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

Or rather, let me rephrase: The first point is IMO the much worse bug, since that is what will cause large project imports (think clang) be very slow in either case. For completely no reason whatsoever.

Sat, Sep 16, 10:51 AM · KDevelop
brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

Ok, here's the two things that are broken and need fixing:

Sat, Sep 16, 10:48 AM · KDevelop
brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

I just poked around a bit myself. It indeed takes ages to import the project, and I couldn't figure out why ... it is certainly not CPU load. I looked in perf, the CPU time spent in importing the project is quite low.
In fact, the code model generation (which seems to be the last step in the import AFAIU) finishes relatively quickly here (after something like 5 seconds), but then it still takes like 30 seconds for the import to finish. I don't know where that time is spent.

Sat, Sep 16, 10:09 AM · KDevelop

Fri, Sep 15

brauch added a comment to D7752: Make it possible for IBuildSystem to provide extra arguments to the parser.

Ok, you're right ... I looked some more. Try "-pipe", qmake passes that here, that seems to be what breaks things if I'm not mistaken.

Fri, Sep 15, 1:36 PM
brauch reopened D7752: Make it possible for IBuildSystem to provide extra arguments to the parser.

There are some arguments which we shouldn't pass on, for example I have a qmake project here which does QMAKE_CXXFLAGS += -Werror=return-type and that completely breaks everything (no highlighting any more whatsoever, parsing of all files fails, ...), Not even sure why, but I guess -Werror arguments should never be passed on in our case.

Fri, Sep 15, 10:57 AM
brauch committed R32:dc09a86b6990: qmake: compiler extra arguments: fix condition (authored by brauch).
qmake: compiler extra arguments: fix condition
Fri, Sep 15, 10:41 AM
brauch added inline comments to D7752: Make it possible for IBuildSystem to provide extra arguments to the parser.
Fri, Sep 15, 10:36 AM
brauch committed R32:12a10c601984: clang: fix "unhandled type: float128" warning (authored by brauch).
clang: fix "unhandled type: float128" warning
Fri, Sep 15, 10:22 AM

Thu, Sep 14

brauch added a comment to D7752: Make it possible for IBuildSystem to provide extra arguments to the parser.

Re. IRC: Yes, to 5.2 I would say. We didn't release our beta yet, and I even think this counts as a bug fix ...
Thanks a lot!

Thu, Sep 14, 9:38 AM

Wed, Sep 13

brauch accepted D7791: Open context for lambdas in ContextBuilder.

Looks sensible, thanks for investigating!

Wed, Sep 13, 12:01 AM

Fri, Sep 8

brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

Do you have some timing on how much loading time improves with this patch?

Fri, Sep 8, 11:40 PM · KDevelop
brauch accepted D7735: [KateFileTreeModel] Don't iterate over keys().

range-based for would detach ...?
If you had a reason not to use that, LGTM, thanks!

Fri, Sep 8, 2:09 PM

Tue, Sep 5

brauch added a comment to T6869: Create ktexteditor-addons repo.

Releasing with applications makes sense to me, I feel like it should be released in sync with kate.
If there is a hard dependency anyways then I agree with Dominik that we should move all plugins over. All of them are possibly useful for an embedding application, and with moving just some I see us moving plugins back and forth all the time for no real reason.

Tue, Sep 5, 7:36 PM · Kile, Kate, KDevelop, KTextEditor

Fri, Sep 1

brauch accepted D7643: Remove some unneeded parameters.

Looks good, thanks!

Fri, Sep 1, 3:28 PM

Tue, Aug 29

brauch committed R32:fb704c7745b5: Set version number to 5.1.2 (authored by brauch).
Set version number to 5.1.2
Tue, Aug 29, 8:13 PM

Mon, Aug 28

brauch accepted D7593: Find generator variables without fake early declarations.

Good solution I think, better than the hack from before (because it actually does the right thing, in a way). Feel free to put it into 5.2, we still have a few weeks to catch issues it causes. Thanks!

Mon, Aug 28, 9:52 PM
brauch committed R247:53904a088000: set KDevelop stable branch to 5.2, remove kdevplatform repo stable branch (authored by brauch).
set KDevelop stable branch to 5.2, remove kdevplatform repo stable branch
Mon, Aug 28, 9:38 PM
brauch committed R499:7739a112ef74: set KDevelop stable branch to 5.2 and remove kdevplatform stable branch (repo… (authored by brauch).
set KDevelop stable branch to 5.2 and remove kdevplatform stable branch (repo…
Mon, Aug 28, 9:37 PM

Aug 17 2017

brauch committed R32:17b0e9ac4b5c: Merge branch '5.1' into 5.2 (authored by brauch).
Merge branch '5.1' into 5.2
Aug 17 2017, 7:31 PM
brauch committed R32:1e1f1f6838f6: appimage script: fix copying of icons (authored by brauch).
appimage script: fix copying of icons
Aug 17 2017, 7:31 PM
brauch committed R32:da932380b2c9: Merge branch '5.1' (authored by brauch).
Merge branch '5.1'
Aug 17 2017, 4:48 PM
brauch committed R32:ff52dc234d64: Dockerfile: update llvm to 3.9.1; fix ninja installation (authored by brauch).
Dockerfile: update llvm to 3.9.1; fix ninja installation
Aug 17 2017, 4:48 PM

Aug 15 2017

brauch committed R33:fb704c7745b5: Set version number to 5.1.2 (authored by brauch).
Set version number to 5.1.2
Aug 15 2017, 9:26 AM
brauch committed R32:63694ce0e0fe: Set version number to 5.1.2 (authored by brauch).
Set version number to 5.1.2
Aug 15 2017, 9:23 AM
brauch committed R53:e45712d3b392: Set version number to 5.1.2 (authored by brauch).
Set version number to 5.1.2
Aug 15 2017, 9:23 AM
brauch committed R52:0346d9cbce3b: Set version number to 5.1.2 (authored by brauch).
Set version number to 5.1.2
Aug 15 2017, 9:23 AM

Aug 10 2017

brauch added a comment to D7010: KSqueezedTextLabel: call updateGeometry() when text changes.

I can write a test if you think this helps. I think reading the docs it is quite clear we must call updateGeometry() here: our sizeHint() changes when changing the text.

Aug 10 2017, 8:48 PM · Frameworks

Aug 8 2017

brauch committed R32:202a4fb6e9b1: file name label: fix window size limiting (authored by brauch).
file name label: fix window size limiting
Aug 8 2017, 5:14 PM
brauch committed R32:3e530e780b59: fix label with file name sometimes being invisble after recent change (authored by brauch).
fix label with file name sometimes being invisble after recent change
Aug 8 2017, 5:14 PM
brauch committed R32:58992c41c3b7: crash dialog: fix button names in description string (authored by brauch).
crash dialog: fix button names in description string
Aug 8 2017, 5:14 PM
brauch committed R32:b3c82b011ad9: clarify text on buttons to clear or keep cache (authored by brauch).
clarify text on buttons to clear or keep cache
Aug 8 2017, 5:14 PM
brauch committed R32:7370c7901057: show shortcut help label only when tab bar is hidden (authored by brauch).
show shortcut help label only when tab bar is hidden
Aug 8 2017, 5:14 PM
brauch committed R32:e1d2989eef90: Fix elision of document title with tabbar disabled (authored by brauch).
Fix elision of document title with tabbar disabled
Aug 8 2017, 5:13 PM
brauch committed R32:1df969288f03: fix strange alignment of document label for short file names (authored by brauch).
fix strange alignment of document label for short file names
Aug 8 2017, 5:13 PM
brauch committed R32:6c6329f2373e: make breakpoint "location" non-editable in item model (authored by brauch).
make breakpoint "location" non-editable in item model
Aug 8 2017, 5:13 PM
brauch committed R32:2d819a1478c1: fix TODO KF5 (authored by brauch).
fix TODO KF5
Aug 8 2017, 5:13 PM
brauch committed R32:106ddc11b4ce: KDevelop::MainWindow: use setWindowFilePath() (authored by rjvbb).
KDevelop::MainWindow: use setWindowFilePath()
Aug 8 2017, 5:13 PM
brauch committed R32:9f811e437d42: clear window file path when there's no active view (authored by brauch).
clear window file path when there's no active view
Aug 8 2017, 5:13 PM
brauch committed R32:10eb177efb28: Fix selection when only one project is in projects view (authored by bevendorff).
Fix selection when only one project is in projects view
Aug 8 2017, 5:12 PM
brauch committed R32:8e2ce1e96456: Update version number to 5.1.1 (authored by brauch).
Update version number to 5.1.1
Aug 8 2017, 5:12 PM
brauch committed R32:73c058a9f221: Revert "Update version number to .." (authored by brauch).
Revert "Update version number to .."
Aug 8 2017, 5:12 PM
brauch added a reverting commit for R32:622e5e11a77d: Update version number to ..: R32:73c058a9f221: Revert "Update version number to ..".
Aug 8 2017, 5:12 PM
brauch committed R32:622e5e11a77d: Update version number to .. (authored by brauch).
Update version number to ..
Aug 8 2017, 5:12 PM
brauch committed R32:1b33ea639196: Update version number to 5.1.0 (authored by brauch).
Update version number to 5.1.0
Aug 8 2017, 5:10 PM
brauch committed R32:a200280a9b5b: Add support for git worktrees (authored by tnorth).
Add support for git worktrees
Aug 8 2017, 5:10 PM
brauch committed R32:97237d4e6dd2: Update version number to 5.0.4 (authored by brauch).
Update version number to 5.0.4
Aug 8 2017, 5:08 PM
brauch committed R32:32c294c3330e: fix docstring (authored by brauch).
fix docstring
Aug 8 2017, 5:08 PM
brauch committed R32:9ac460dbbcc6: Merge branch '5.1' (authored by brauch).
Merge branch '5.1'
Aug 8 2017, 5:08 PM
brauch committed R32:4cf23720b123: container types: do not write lock when calling addContentType() (authored by brauch).
container types: do not write lock when calling addContentType()
Aug 8 2017, 5:07 PM
brauch committed R32:0301ff6b53f5: Merge branch '5.0' into 5.1 (authored by brauch).
Merge branch '5.0' into 5.1
Aug 8 2017, 5:07 PM
brauch committed R32:edb52cfd721f: Merge branch '5.1' (authored by brauch).
Merge branch '5.1'
Aug 8 2017, 5:07 PM
brauch committed R32:d42d07429929: Fix opening of remote URLs without filename (authored by brauch).
Fix opening of remote URLs without filename
Aug 8 2017, 5:07 PM
brauch committed R32:115cacb46905: fix progress widget flags (authored by brauch).
fix progress widget flags
Aug 8 2017, 5:07 PM
brauch committed R32:1d5dc813c744: Update version number to 5.0.80 (authored by brauch).
Update version number to 5.0.80
Aug 8 2017, 5:07 PM
brauch committed R32:ca85caca0674: script launcher config: use "python3" for python applications (authored by brauch).
script launcher config: use "python3" for python applications
Aug 8 2017, 5:07 PM
brauch committed R32:8f304c74ff9e: improve wording in tooltip of branch manager (authored by brauch).
improve wording in tooltip of branch manager
Aug 8 2017, 5:06 PM
brauch committed R32:760cc72826da: Update version number to 5.0.3 (authored by brauch).
Update version number to 5.0.3
Aug 8 2017, 5:06 PM
brauch committed R32:37884ec9558d: OpenProjectDialog: pass full opened file name to project manager (authored by enniob).
OpenProjectDialog: pass full opened file name to project manager
Aug 8 2017, 5:06 PM
brauch committed R32:657a5691d5cc: "flat" breakpoint pixmap -- I forgot to `git add` the pngs (authored by brauch).
"flat" breakpoint pixmap -- I forgot to `git add` the pngs
Aug 8 2017, 5:06 PM
brauch committed R32:e4fb596442fe: export IProblem (authored by rjvbb).
export IProblem
Aug 8 2017, 5:05 PM
brauch committed R32:5ba2408c80df: Merge branch '5.0' (authored by brauch).
Merge branch '5.0'
Aug 8 2017, 5:05 PM
brauch committed R32:3e4c15c9c88a: Do not use "script-error" icon for breakpoints (authored by brauch).
Do not use "script-error" icon for breakpoints
Aug 8 2017, 5:05 PM
brauch committed R32:385b70d4d4ec: Revert "export IProblem" (authored by brauch).
Revert "export IProblem"
Aug 8 2017, 5:05 PM
brauch added a reverting commit for R32:e4fb596442fe: export IProblem: R32:385b70d4d4ec: Revert "export IProblem".
Aug 8 2017, 5:05 PM
brauch committed R32:b52c376b38d8: Set version to 5.0.2 (authored by brauch).
Set version to 5.0.2
Aug 8 2017, 5:05 PM
brauch committed R32:cba54572bce5: Fix breakpoints view (authored by brauch).
Fix breakpoints view
Aug 8 2017, 5:05 PM
brauch committed R32:8cdd0ade6755: export IProblem (authored by rjvbb).
export IProblem
Aug 8 2017, 5:05 PM
brauch committed R32:0d9c33285e39: Merge branch '5.0' (authored by brauch).
Merge branch '5.0'
Aug 8 2017, 5:05 PM
brauch committed R32:fb0230e3b6f0: more helpful error message when failing to load project plugin (authored by brauch).
more helpful error message when failing to load project plugin
Aug 8 2017, 5:05 PM
brauch committed R32:77b83054f943: Remove mime type <-> extension cache (authored by brauch).
Remove mime type <-> extension cache
Aug 8 2017, 5:05 PM
brauch committed R32:7114783c189c: Set version to 5.0.1 (authored by brauch).
Set version to 5.0.1
Aug 8 2017, 5:05 PM
brauch committed R32:ff07af4eee27: Merge branch '5.0' (authored by brauch).
Merge branch '5.0'
Aug 8 2017, 5:05 PM
brauch committed R32:72be70ba43b5: Don't display "project is already open in a different session" dialog session… (authored by brauch).
Don't display "project is already open in a different session" dialog session…
Aug 8 2017, 5:05 PM
brauch committed R32:08f52838eb07: update highlight color as well when colors change (authored by brauch).
update highlight color as well when colors change
Aug 8 2017, 5:05 PM
brauch committed R32:f871ad77943e: Use search background color for highlighting in the view. (authored by brauch).
Use search background color for highlighting in the view.
Aug 8 2017, 5:05 PM
brauch committed R32:38d8ba13e8fd: port away from deprecated kate modeline "remove-trailing-space-save" (authored by brauch).
port away from deprecated kate modeline "remove-trailing-space-save"
Aug 8 2017, 5:04 PM
brauch committed R32:759cdc13564f: Fix accelerator keys on docks in windows vista style (authored by brauch).
Fix accelerator keys on docks in windows vista style
Aug 8 2017, 5:04 PM
brauch committed R32:8a4d490ee0f5: Do not crash on "fetch project" with the native dialog (authored by brauch).
Do not crash on "fetch project" with the native dialog
Aug 8 2017, 5:04 PM
brauch committed R32:e3d34c966a2b: make failure to open template archives a warning (authored by brauch).
make failure to open template archives a warning
Aug 8 2017, 5:04 PM
brauch committed R32:8343f66108bb: Set version to 5.0.0 (authored by brauch).
Set version to 5.0.0
Aug 8 2017, 5:04 PM
brauch committed R32:a7e7effbdf3a: remove spammy debug (authored by brauch).
remove spammy debug
Aug 8 2017, 5:04 PM
brauch committed R32:63266d34657f: Add a flag to the navigation widget to decide whether it's embedded or shown in… (authored by brauch).
Add a flag to the navigation widget to decide whether it's embedded or shown in…
Aug 8 2017, 5:03 PM
brauch committed R32:500c1b619e64: Revert "Do not apply highlighting if not holding the revision the context… (authored by brauch).
Revert "Do not apply highlighting if not holding the revision the context…
Aug 8 2017, 5:03 PM
brauch added a reverting commit for R32:939583495c04: Do not apply highlighting if not holding the revision the context belongs to.: R32:500c1b619e64: Revert "Do not apply highlighting if not holding the revision the context….
Aug 8 2017, 5:03 PM
brauch committed R32:939583495c04: Do not apply highlighting if not holding the revision the context belongs to. (authored by brauch).
Do not apply highlighting if not holding the revision the context belongs to.
Aug 8 2017, 5:03 PM
brauch committed R32:addfd2d0fc9d: assistant: remove dead code (fixes compiler warning) (authored by brauch).
assistant: remove dead code (fixes compiler warning)
Aug 8 2017, 5:03 PM
brauch committed R32:c9265847835d: Do not perform highlighting when the revision is not held. (authored by brauch).
Do not perform highlighting when the revision is not held.
Aug 8 2017, 5:03 PM
brauch committed R32:2cf99331edfe: add missing read locker (authored by brauch).
add missing read locker
Aug 8 2017, 5:03 PM
brauch committed R32:00f21bae5cee: Remove DUChain lock in AbstractNavigationWidget::anchorClicked() (authored by brauch).
Remove DUChain lock in AbstractNavigationWidget::anchorClicked()
Aug 8 2017, 5:03 PM
brauch committed R32:8a394c93ef22: remove stray qDebug() (?) (authored by brauch).
remove stray qDebug() (?)
Aug 8 2017, 5:03 PM
brauch committed R32:f1f21340510e: static assistants: rework problem display (authored by brauch).
static assistants: rework problem display
Aug 8 2017, 5:03 PM
brauch committed R32:4f5b6bc41d6d: fix wrong comment (authored by brauch).
fix wrong comment
Aug 8 2017, 5:03 PM
brauch committed R32:6c50c9f70546: Merge branch '5.0' (authored by brauch).
Merge branch '5.0'
Aug 8 2017, 5:03 PM
brauch committed R32:80bb2205945f: Project controller: make displaying project config dialog async (authored by brauch).
Project controller: make displaying project config dialog async
Aug 8 2017, 5:03 PM