brauch (Sven Brauch)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2016, 10:25 AM (77 w, 6 d)
Availability
Available

Recent Activity

Today

brauch committed R39:04f8a6a33936: fix crash in some cases when selecting text with mouse (authored by brauch).
fix crash in some cases when selecting text with mouse
Sun, Jul 23, 2:28 PM
brauch committed R39:d3e4ef7f263b: somewhat fix drag&drop (authored by brauch).
somewhat fix drag&drop
Sun, Jul 23, 1:59 PM
brauch added a comment to D6839: Remove unused vcsannotate_current_document action.

You can configure one in either the shortcut dialog or by right-clicking the menu entry, I use Meta+A ...
I agree with your thoughts in general, I just want to avoid breaking things and I'm really at loss about what this code is doing there ;)

Sun, Jul 23, 12:42 PM
brauch closed T3663: Multi-Cursor: overwrite mode is broken as Resolved.

seems fine now

Sun, Jul 23, 8:27 AM · KTextEditor
brauch committed R39:7f61aec0e934: fix basic drag/drop for the single-cursor case (authored by brauch).
fix basic drag/drop for the single-cursor case
Sun, Jul 23, 7:58 AM
brauch committed R39:d12ee835bd64: clear secondary cursors when inserting a template (authored by brauch).
clear secondary cursors when inserting a template
Sun, Jul 23, 7:58 AM
brauch committed R39:265d3ca76710: fix warning (authored by brauch).
fix warning
Sun, Jul 23, 7:58 AM
brauch added a comment to D6839: Remove unused vcsannotate_current_document action.

Hmm, I'm still confused why this code was there then. Looking at git history, it was also changed several times, fixing issues. Does invoking the action via its shortcut still work?

Sun, Jul 23, 6:29 AM

Yesterday

brauch added a comment to D6839: Remove unused vcsannotate_current_document action.

Huh, does right-click -> git -> show annotation still work after that? If yes, there needs to be a copy of this code somewhere.

Sat, Jul 22, 9:21 PM
brauch committed R39:c87bc84adba0: fix kill line (authored by brauch).
fix kill line
Sat, Jul 22, 2:28 PM
brauch committed R39:478e63fa1d82: fix warning (authored by brauch).
fix warning
Sat, Jul 22, 2:28 PM
brauch committed R39:f6df0a75db73: size_t -> int (authored by brauch).
size_t -> int
Sat, Jul 22, 6:43 AM
brauch committed R39:f5735b15c7d2: fix crash when rendering text preview (authored by brauch).
fix crash when rendering text preview
Sat, Jul 22, 6:43 AM

Fri, Jul 21

brauch committed R39:47317728cfa3: fix line and word select mode, at least the basic usage (authored by brauch).
fix line and word select mode, at least the basic usage
Fri, Jul 21, 5:31 PM
brauch committed R39:bca4e0f91626: fix cursorAtWordBoundary() (authored by brauch).
fix cursorAtWordBoundary()
Fri, Jul 21, 5:31 PM

Thu, Jul 20

brauch committed R39:3a16d61c2b78: fix highlight marked text feature (authored by brauch).
fix highlight marked text feature
Thu, Jul 20, 2:53 PM

Wed, Jul 19

brauch committed R39:b4a7dd13aabc: fix and re-enable one of the multicursor unit tests (authored by brauch).
fix and re-enable one of the multicursor unit tests
Wed, Jul 19, 11:13 PM
brauch committed R39:5384a9569adb: fix backspace / del with multiple selections (authored by brauch).
fix backspace / del with multiple selections
Wed, Jul 19, 10:24 PM
brauch closed T3659: Multi-Cursor: page up/down does not move the right amount of lines as Resolved.

shoooooooould be fixed.

Wed, Jul 19, 4:17 PM · KTextEditor
brauch committed R39:956ab3fed746: get rid of keepX parameter of viewLineOffset and the preservedX members (authored by brauch).
get rid of keepX parameter of viewLineOffset and the preservedX members
Wed, Jul 19, 4:07 PM
brauch committed R39:97ac67647f34: fix page up/down (authored by brauch).
fix page up/down
Wed, Jul 19, 4:04 PM
brauch committed R39:b44f05345d08: add validSelections() method (authored by brauch).
add validSelections() method
Wed, Jul 19, 1:33 PM
brauch committed R39:6746955305c5: fix Ctrl+A, remove unused top() and bottom() functions (authored by brauch).
fix Ctrl+A, remove unused top() and bottom() functions
Wed, Jul 19, 1:33 PM
brauch committed R39:c9355f7a7a09: fix weird use of , operator and other oddities (authored by brauch).
fix weird use of , operator and other oddities
Wed, Jul 19, 1:33 PM

Tue, Jul 18

brauch closed T3664: Multi-Cursor: multiple cursors can be placed at the same point as Resolved.
Tue, Jul 18, 9:10 PM · KTextEditor
brauch committed R39:eacdb67f819f: don't draw two cursors at the same place (authored by brauch).
don't draw two cursors at the same place
Tue, Jul 18, 8:33 PM
brauch committed R39:e7c79b5aa752: remove duplicate cursors when starting to type (authored by brauch).
remove duplicate cursors when starting to type
Tue, Jul 18, 8:27 PM
brauch added a comment to T3665: Multi-Cursor: crash when double-clicking under the end of the document.

fixed now, but dragging below document end with triple-click doesn't select the last line.

Tue, Jul 18, 8:03 PM · KTextEditor
brauch committed R39:4b4d4234b9d1: fix crash when triple-clicking below end of document (authored by brauch).
fix crash when triple-clicking below end of document
Tue, Jul 18, 7:55 PM
brauch committed R39:d1423b15796d: Merge branch 'master' into multicursor (authored by brauch).
Merge branch 'master' into multicursor
Tue, Jul 18, 7:24 PM
brauch committed R39:844066612729: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Tue, Jul 18, 7:24 PM
brauch committed R39:3e5d54854d14: Require CMake 3.0, as discussed on kde-frameworks-devel (authored by brauch).
Require CMake 3.0, as discussed on kde-frameworks-devel
Tue, Jul 18, 7:24 PM
brauch committed R39:7fea3e76fbd5: GIT_SILENT Fix ECM warning: use CMakePackageConfigHelpers instead of ECM variant (authored by brauch).
GIT_SILENT Fix ECM warning: use CMakePackageConfigHelpers instead of ECM variant
Tue, Jul 18, 7:24 PM
brauch committed R39:2605240f0920: Merge branch 'master' into multicursor (authored by brauch).
Merge branch 'master' into multicursor
Tue, Jul 18, 7:24 PM
brauch committed R39:01e661865d72: Fix build with CMP0048 set to NEW (authored by brauch).
Fix build with CMP0048 set to NEW
Tue, Jul 18, 7:24 PM
brauch committed R39:63120305f4dc: Upgrade KF5 version to 5.30.0. (authored by l10n daemon script <scripty@kde.org>).
Upgrade KF5 version to 5.30.0.
Tue, Jul 18, 7:24 PM
brauch committed R39:b757823357f4: Upgrade ECM and KF5 version requirements for 5.29.0 release. (authored by l10n daemon script <scripty@kde.org>).
Upgrade ECM and KF5 version requirements for 5.29.0 release.
Tue, Jul 18, 7:24 PM
brauch committed R39:7c032dede6fc: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
Tue, Jul 18, 7:24 PM
brauch committed R39:44483189f251: fix message extraction, syntax xml files moved to frameworks/syntaxhighlighting (authored by lueck).
fix message extraction, syntax xml files moved to frameworks/syntaxhighlighting
Tue, Jul 18, 7:24 PM
brauch committed R39:f79aa762da9a: Add FreeBSD to metainfo.yaml. (authored by tcberner).
Add FreeBSD to metainfo.yaml.
Tue, Jul 18, 7:24 PM
brauch committed R39:e34f497d3f5d: Amends 8927819857799553e1ec8bebec24cc611aacccc0 (authored by rjvbb).
Amends 8927819857799553e1ec8bebec24cc611aacccc0
Tue, Jul 18, 7:24 PM
brauch committed R39:2da97155bc49: Prevent Qt warnings about an unsupported clipboard mode on Mac (authored by rjvbb).
Prevent Qt warnings about an unsupported clipboard mode on Mac
Tue, Jul 18, 7:24 PM

Thu, Jul 13

brauch added a comment to D6680: Use return typehints in typebuilder for PHP language.

Looks sensible to me but I'm not really familiar with the php support.

Thu, Jul 13, 8:35 PM · KDevelop

Wed, Jul 12

brauch added a comment to R33:7cda7c95d5bf: Fix crashy dialogs (found by krazy and by hand).

Oh, sorry then.

Wed, Jul 12, 3:14 PM

Tue, Jul 11

brauch added a comment to R33:7cda7c95d5bf: Fix crashy dialogs (found by krazy and by hand).

Hmm. Why not use dialog->setAttribute(Qt::WA_DeleteOnClose) instead? That seems to be the standard way to do it, no?

It would not be possible to access elements of the dialog after exec(), which is required more often than not.

Tue, Jul 11, 8:33 PM
brauch added a comment to R33:7cda7c95d5bf: Fix crashy dialogs (found by krazy and by hand).

Hmm. Why not use dialog->setAttribute(Qt::WA_DeleteOnClose) instead? That seems to be the standard way to do it, no?

Tue, Jul 11, 5:13 PM

Thu, Jul 6

brauch added a comment to D6529: KDevelop::MainWindow: use setWindowFilePath().

Yes, I felt responsible for fixing it after pushing the broken version and did that wrong, too :/ my bad. Thanks for the patch.

Thu, Jul 6, 10:38 PM · KDevelop
brauch committed R33:9f811e437d42: clear window file path when there's no active view (authored by brauch).
clear window file path when there's no active view
Thu, Jul 6, 4:28 PM
brauch committed R33:106ddc11b4ce: KDevelop::MainWindow: use setWindowFilePath() (authored by rjvbb).
KDevelop::MainWindow: use setWindowFilePath()
Thu, Jul 6, 4:24 PM
brauch closed D6529: KDevelop::MainWindow: use setWindowFilePath() by committing R33:106ddc11b4ce: KDevelop::MainWindow: use setWindowFilePath() (authored by rjvbb).
Thu, Jul 6, 4:24 PM · KDevelop

Tue, Jul 4

brauch added a comment to D6316: Add codecompletion from embedded structs.

No, I was thinking that the next block with the openContext(...) should automatically re-use the internalContext() of the declaration if that is indeed the same. In any case, when looking at it like this, don't you need to set the new range on the context? Doesn't that become a problem when you extend the range during editing?

Tue, Jul 4, 6:29 PM · KDevelop
brauch accepted D6505: Fix external launch of executables with spaces in paths[windows].

Looks sensible to me.

Tue, Jul 4, 4:20 PM

Mon, Jul 3

brauch accepted D6316: Add codecompletion from embedded structs.

Can't spot anything obviously wrong -- go for it ;)
Sorry for taking so long!

Mon, Jul 3, 9:41 PM · KDevelop
brauch committed R59:fc75f2ccf68c: don't track .kdev4 project file (authored by brauch).
don't track .kdev4 project file
Mon, Jul 3, 6:05 PM

Thu, Jun 29

brauch accepted D6433: Hide qt_check_for_QGADGET_macro() from autocompletion.

LGTM, thanks!

Thu, Jun 29, 4:23 PM · KDevelop

Tue, Jun 27

brauch accepted D6412: Refactor and fix DU-Chain creation.

Seems sensible to me from a first look, certainly more than it was before ;)

Tue, Jun 27, 8:57 PM · KDevelop

Mon, Jun 26

brauch added a comment to D6316: Add codecompletion from embedded structs.

After some lookup I found that there are 2 declarations added somehow with same qualifiedIdentifier.
Also, looks like it my added test visitTypeSpec is somehow called twice thus in first call declaration is present once and it doesn't contain internal context and in second call there is 2 declarations where first one still doesn't have internal context and second have one.

I will have to look closer later, but typically the builders run twice per pass, and in the second pass the declaration created by the first pass should be *re-used*, i.e. openDeclaration() figures out which declaration was created by the first pass and re-uses that. It uses the scope identifier and the range to do that lookup. It might be that this fails. It definitely fails in some cases -- that is why your completion items sometimes disappear while the popup is visible.

Mon, Jun 26, 1:06 PM · KDevelop

Sun, Jun 25

brauch added a comment to D6316: Add codecompletion from embedded structs.

From a first look it might be you can just import the first struct's context into the second one:
second->addImportedParentContext(first)
where first and second are the internalContext()s of the declarations declaring the two stucts. Maybe that already does what you need. Otherwise we can see :)

Sun, Jun 25, 6:39 PM · KDevelop
brauch added a comment to D6316: Add codecompletion from embedded structs.

I wonder -- is this the right place for that logic? Does it work in highlighting, for example?

Sun, Jun 25, 5:20 PM · KDevelop

Jun 19 2017

brauch accepted D6272: Declare variables in parameters of function literals.

The highlighting still looks wrong but that's a different issue. Patch looks ok -- it has a test, it can't be bad ;)

Jun 19 2017, 1:10 PM · KDevelop

Jun 13 2017

brauch accepted D6218: Fix runes parsing..

looks good

Jun 13 2017, 5:53 PM · KDevelop

Jun 3 2017

brauch accepted D6084: Replace crashy dialogs by QPointer version (krazy2 analysis).

LGTM, I have actually seen crashes a few times which I would account to something related.

Jun 3 2017, 9:27 PM · KDevelop
brauch committed R33:10eb177efb28: Fix selection when only one project is in projects view (authored by bevendorff).
Fix selection when only one project is in projects view
Jun 3 2017, 1:41 PM
brauch closed D6019: Follow-up patch for D4665 (bug #379433). by committing R33:10eb177efb28: Fix selection when only one project is in projects view (authored by bevendorff).
Jun 3 2017, 1:41 PM
brauch added a comment to D6019: Follow-up patch for D4665 (bug #379433)..

Sorry. I clicked around a bit with just one project open and it seems fine, I'll submit it to master, then we have enough time to catch issues. Thanks!

Jun 3 2017, 1:38 PM

May 29 2017

brauch accepted D6019: Follow-up patch for D4665 (bug #379433)..

Looks good to me, thanks. Should I push it or do you have commit access?

May 29 2017, 10:24 PM
brauch committed R32:268c5550c720: Merge branch '5.1' (authored by brauch).
Merge branch '5.1'
May 29 2017, 6:18 PM

May 19 2017

brauch accepted D5915: Infer correct type from 'and' / 'or' expressions.

Looks good, thanks! Useful change.

May 19 2017, 9:25 PM · KDevelop

May 13 2017

brauch committed R52:d6ce30e0cc78: Update version number to 5.1.1 (authored by brauch).
Update version number to 5.1.1
May 13 2017, 10:09 AM
brauch committed R53:f6a393467d07: Update version number to 5.1.1 (authored by brauch).
Update version number to 5.1.1
May 13 2017, 10:09 AM
brauch committed R33:8e2ce1e96456: Update version number to 5.1.1 (authored by brauch).
Update version number to 5.1.1
May 13 2017, 10:09 AM
brauch committed R32:ad0b96a765d4: Update version number to 5.1.1 (authored by brauch).
Update version number to 5.1.1
May 13 2017, 10:08 AM
brauch committed R32:895d7b150a42: update release script in preparation of 5.1.1 release (authored by brauch).
update release script in preparation of 5.1.1 release
May 13 2017, 10:08 AM
brauch committed R33:73c058a9f221: Revert "Update version number to .." (authored by brauch).
Revert "Update version number to .."
May 13 2017, 10:06 AM
brauch added a reverting commit for R33:622e5e11a77d: Update version number to ..: R33:73c058a9f221: Revert "Update version number to ..".
May 13 2017, 10:06 AM
brauch committed R33:622e5e11a77d: Update version number to .. (authored by brauch).
Update version number to ..
May 13 2017, 10:06 AM

May 5 2017

brauch accepted D5719: Use https://www.google.com instead of http://www.google.de in google selection external script.

Yes, makes sense. Do you have commit access?

May 5 2017, 5:23 PM

May 4 2017

brauch committed R59:1305c7ab1b8a: fix cmake (authored by brauch).
fix cmake
May 4 2017, 7:33 PM

May 3 2017

brauch added a comment to D5707: Normalize line endings when creating ParseJob from background file..

I think this is pretty much the sane solution to the problem ... still, we might want to turn it off for languages that don't need it, it seems like a non-negligible overhead if you consider a whole project. Maybe introduce a new normalizeLineEndings() member function which is called explicitly by the parse job ...?

May 3 2017, 8:16 PM

May 1 2017

brauch committed R53:bd76175e7165: Merge branch '5.1' (authored by brauch).
Merge branch '5.1'
May 1 2017, 9:44 PM
brauch committed R53:6043407c4ee2: fix crash (authored by brauch).
fix crash
May 1 2017, 9:44 PM

Apr 29 2017

brauch accepted D5654: Move print from int to unsigned int.
Apr 29 2017, 2:36 PM
brauch added a comment to D5654: Move print from int to unsigned int.

Context? Reason? Effect?

Apr 29 2017, 2:33 PM

Apr 28 2017

brauch accepted D5644: Adds option to pass cursor line and column to external scripts.

LGTM

Apr 28 2017, 8:31 PM

Apr 17 2017

brauch committed R53:4268b8fef984: Revert "rename None to NoneType" (authored by brauch).
Revert "rename None to NoneType"
Apr 17 2017, 12:34 PM
brauch added a reverting commit for R53:157ec32c1891: rename None to NoneType: R53:4268b8fef984: Revert "rename None to NoneType".
Apr 17 2017, 12:34 PM
brauch committed R53:157ec32c1891: rename None to NoneType (authored by brauch).
rename None to NoneType
Apr 17 2017, 12:09 PM

Apr 14 2017

brauch accepted D5448: Enable numericMode for sorting document list in filetree.

+1, sounds good to me

Apr 14 2017, 10:04 AM
brauch accepted D5442: Get correct type when slicing tuple with constant parameters..

Looks fine to me! Thanks a lot once again :)

Apr 14 2017, 8:05 AM

Apr 12 2017

brauch added a comment to D5397: pep8: Make pep8 warnings less annoying.

I don't have a strong opinion on this, if you have, feel free to change it.

Apr 12 2017, 1:36 PM

Mar 26 2017

brauch added a comment to D5183: Reopen accidentally closed tab.

Looks good except what is noted below, thanks!

Mar 26 2017, 7:13 PM

Mar 25 2017

brauch accepted D5176: Adapt to kdevplatform changes..

Looks good, please push :)

Mar 25 2017, 7:17 PM

Mar 21 2017

brauch added a comment to D5122: Allow users to install via a custom root installation command.

Can you make the line edit disabled when something else than "custom command" is selected?
Otherwise, LGTM, thanks for the patch!

Mar 21 2017, 5:36 PM · KDevelop

Mar 19 2017

brauch added a comment to D4234: Change algorithm for autobrace..

Hm, I think the biggest problem is that we don't know how we want it to work ... so we can't write tests either ;)

Mar 19 2017, 10:30 PM · Frameworks

Mar 16 2017

brauch added a comment to D5042: Port away from QtWebKit into QtWebEngine.

Sorry that my comment is a rather philosophical one, and maybe a bit disconnected from reality, but ...
Do we really need a full web browser engine for this purpose? Effectively, we render text, links, and maybe ocassionaly a simple table and an image. Isn't there something simpler than a web browser engine (which is half an operating system these days) which provides us with these capabilities? What about the Qt Rich Text stuff?

Mar 16 2017, 12:19 AM

Mar 13 2017

brauch committed R52:7d8a6b5ceadf: Update version number to 5.1.0 (authored by brauch).
Update version number to 5.1.0
Mar 13 2017, 7:04 PM
brauch committed R33:1b33ea639196: Update version number to 5.1.0 (authored by brauch).
Update version number to 5.1.0
Mar 13 2017, 6:54 PM
brauch committed R32:97be794e00f2: Update version number to 5.1.0 (authored by brauch).
Update version number to 5.1.0
Mar 13 2017, 6:53 PM
brauch committed R32:ea90e0cb70e8: set version to 5.1 in release script (authored by brauch).
set version to 5.1 in release script
Mar 13 2017, 6:53 PM
brauch committed R53:c4c5d0fe7328: Update version number to 5.1.0 (authored by brauch).
Update version number to 5.1.0
Mar 13 2017, 6:52 PM