brauch (Sven Brauch)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2016, 10:25 AM (198 w, 2 d)
Availability
Available

Recent Activity

Jul 21 2019

brauch added a comment to D22595: implement text hint interface for automatic hover.

They have some more sophisticated tooltip that may be of interest in case the tooltip is not nice/good enough over time.

Jul 21 2019, 10:41 AM · Kate

Jul 17 2019

brauch accepted D22511: Minimap: Do not grab left mouse click over up/down arrows.

LGTM, thank you!

Jul 17 2019, 3:16 PM · Frameworks, Kate

Jul 16 2019

brauch added a comment to D22477: With auto completion don't show completions that don't match from beginning of typed word.

Also here, looks good to me, but I would wait for feedback from somebody else in addition. Thank you for working on this!

Jul 16 2019, 10:33 PM · Frameworks, Kate
brauch added inline comments to D22477: With auto completion don't show completions that don't match from beginning of typed word.
Jul 16 2019, 10:33 PM · Frameworks, Kate
brauch added inline comments to D22477: With auto completion don't show completions that don't match from beginning of typed word.
Jul 16 2019, 10:31 PM · Frameworks, Kate
brauch added a comment to D22500: Make keyword completion model return HideListIfAutomaticInvocation by default.

Independent of anything else I think this is a very sensible change, and seems like an oversight / bug.

Jul 16 2019, 10:29 PM · Frameworks, Kate
brauch added a comment to D22477: With auto completion don't show completions that don't match from beginning of typed word.

I'm not sure if this solves the right problem.

Jul 16 2019, 9:32 AM · Frameworks, Kate

Jun 10 2019

brauch added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Why did you replace the registry query by a fixed path?

Jun 10 2019, 5:19 PM · KDevelop

May 30 2019

brauch added a comment to D21485: Fix window activation on Windows.

Great to have this fixed, thank you!

May 30 2019, 11:09 AM · Kate

Apr 26 2019

brauch added a comment to D20852: Fix to show folding preview when move the mouse from bottom to top.

I guess the intention of the highlight delay is that when you move your mouse across the border, the view doesn't flicker. The 150ms does this well enough for me, I never see a flicker at least ;)

Apr 26 2019, 7:00 PM · Frameworks, Kate

Mar 30 2019

brauch accepted D19764: Fix Minimap with QtCurve style.

Looks sensible, and I think I've even seen this bug already somewhere.

Mar 30 2019, 12:26 AM · Frameworks, Kate

Mar 9 2019

brauch added a comment to D19621: ViewPrivate: Make deselection by arrow keys more handy.

Sorry, yeah, I misunderstood!

Mar 9 2019, 3:46 PM · Frameworks, Kate
brauch added a comment to D19621: ViewPrivate: Make deselection by arrow keys more handy.

Hm, so shift-selecting with Shift+Left 5 times, then pressing Shift+Right once clears the selection? Just for the statistics, deselecting one character is a feature I use all the time.

Mar 9 2019, 8:49 AM · Frameworks, Kate

Mar 6 2019

brauch added a comment to D19457: Resurrect kdev-java.

FWIW kdev-java was to my knowledge never really working. I think at some point a lot of the code started as effectively a fork of the old C++ plugin, which was then gradually (but not thoroughly) adapted to java ...

Mar 6 2019, 8:00 AM · KDevelop
brauch accepted D19457: Resurrect kdev-java.

Thanks, certainly better than bitrot. I can't really imagine it won't crash with any non-trivial project though :/

Mar 6 2019, 7:58 AM · KDevelop

Feb 13 2019

brauch added a comment to D18551: clang: Create preamble only on second parse.

This is not something that should be configurable. The follow-up to hard-to-understand options shouldn't be to add more of them.

Feb 13 2019, 12:12 AM · KDevelop

Jan 29 2019

brauch added a comment to D18551: clang: Create preamble only on second parse.

To clarify, the patch back then was less about the first-time delay, and more about the delay being there *every* time because of wrong usage of the API. Whether the delay occurs once is arguably a bit less important.

Jan 29 2019, 11:42 PM · KDevelop

Jan 9 2019

brauch added a comment to D17971: Revive External Tools plugin.

Thanks for working on this!
Something which would be quite powerful too would be to execute a tool on saving a file. This would e.g. allow integrating formatting tools such as golang's very easily.

Jan 9 2019, 9:10 PM · Kate
brauch added a reviewer for D18122: Fix Xdebug disconnecting after php finished if multiple connections are allowed: pprkut.
Jan 9 2019, 2:33 PM · KDevelop
brauch updated subscribers of D18122: Fix Xdebug disconnecting after php finished if multiple connections are allowed.

@pprkut can you look at this? I have not used PHP or its tooling for more than 10 years ...

Jan 9 2019, 2:33 PM · KDevelop

Jan 2 2019

brauch added a comment to D17915: Clang CodeCompletion: No auto-completion for numbers.

Hmm, maybe the better way to achieve this effect would be to disable *automatic* invocation of completion after numbers? I already noticed that this is mostly undesirable, too. This is probably something you don't want to fix in the Clang plugin, but in KTextEditor instead ...

Jan 2 2019, 1:18 PM · KDevelop

Dec 22 2018

brauch added a comment to D17582: Some tweaks to the appimage.

Looks ok to me! Maybe put it into master?

Dec 22 2018, 5:45 PM · KDevelop

Dec 10 2018

brauch added a comment to D17459: SearchBar: Add Cancel button to stop long running tasks.

I would also advise against calling processEvents() to keep UIs responsive in all cases. It's tempting, but it is near impossible to get it right. What about conflicting actions, close/resize events, dbus calls, etc etc that are handled here?

Dec 10 2018, 6:15 PM · Frameworks, Kate

Dec 7 2018

brauch committed R877:f00f3842a387: kdevelop: add 5.3.1 tarballs, set 5.3.1 as default target (authored by brauch).
kdevelop: add 5.3.1 tarballs, set 5.3.1 as default target
Dec 7 2018, 9:26 AM

Dec 6 2018

brauch committed R52:bd2f80843326: Version 5.3.1 (authored by brauch).
Version 5.3.1
Dec 6 2018, 9:45 AM
brauch committed R53:a58639ee0655: Version 5.3.1 (authored by brauch).
Version 5.3.1
Dec 6 2018, 9:45 AM
brauch committed R32:759642f7ea46: Version 5.3.1 (authored by brauch).
Version 5.3.1
Dec 6 2018, 9:29 AM

Dec 2 2018

brauch added a comment to D17255: KDevelop: support for installing into a non-standard parallel prefix.

On Linux quite possibly too, I think many packaging systems install into some temporary dir and then copy the deployment out of there for archiving.

Dec 2 2018, 10:06 AM · KDevelop

Nov 29 2018

brauch added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

Shouldn't this change simultaneously remove the line length limit ...?

Nov 29 2018, 8:04 PM · Frameworks, Kate

Nov 25 2018

brauch added a comment to D17145: Don't reverse order of files opened from the command line.

It has often been discussed whether bug 398525 is actually valid, without real conclusion. Since the tabs do not show all documents, but only the n most recently used ones, it to me makes a lot of sense that new documents are added at the left, and then "drop off the shelf" towards the right if they are not being used, into the dropdown-menu.

Nov 25 2018, 10:07 AM · Kate

Nov 24 2018

brauch added a comment to D17131: Fix problem model test on Windows. Make sure that when we create a path the root of that path is created according to what is expected on the current platform. E.g. C: on Windows..

Since it only touches a test, I don't see any issues with putting it into 5.3. Thanks!

Nov 24 2018, 2:13 PM · KDevelop
brauch accepted D17131: Fix problem model test on Windows. Make sure that when we create a path the root of that path is created according to what is expected on the current platform. E.g. C: on Windows..

Looks good, thanks!

Nov 24 2018, 9:27 AM · KDevelop

Nov 21 2018

brauch committed R53:6bf5c812a8bf: builtin docs: remove file and execfile, they are not in python 3 (authored by brauch).
builtin docs: remove file and execfile, they are not in python 3
Nov 21 2018, 9:58 PM

Nov 17 2018

brauch accepted D16942: CMakeCacheModel: avoid string memory duplication.

Looks ok to me, thanks!

Nov 17 2018, 5:13 PM · KDevelop

Nov 13 2018

brauch requested changes to D12746: KDevelop: alternative monolithic storage options for TopDUContexts (PoC).

Sorry, I don't see this going in in this or a similar form.

Nov 13 2018, 10:50 AM · KDevelop

Nov 4 2018

brauch added a comment to D16668: Remove document preview plugin: current technology harms workflow.

A solution might be to extend KXmlGui to somehow support such situations,
and decide who owns the shortcut by looking at the focus.

Nov 4 2018, 10:53 PM · Kate

Oct 31 2018

brauch added inline comments to D16484: Add scratchpad plugin.
Oct 31 2018, 2:24 PM · KDevelop

Oct 30 2018

brauch committed R877:9d47038339df: set default target to 5.3 branch for KDevelop (authored by brauch).
set default target to 5.3 branch for KDevelop
Oct 30 2018, 10:37 PM

Oct 29 2018

brauch added inline comments to D16484: Add scratchpad plugin.
Oct 29 2018, 3:28 PM · KDevelop
brauch added a comment to D16484: Add scratchpad plugin.

I'd have to use this for a while to see whether it works well in practice, but in general it seems like a cool idea.

Oct 29 2018, 3:11 PM · KDevelop

Oct 25 2018

brauch added a comment to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

Any help on the Windows version is greatly appreciated, whenever you find the time for it. :)

Oct 25 2018, 2:57 PM · KDevelop
brauch committed R52:177f473da1cd: Set version number to 5.3.0 (authored by brauch).
Set version number to 5.3.0
Oct 25 2018, 8:31 AM
brauch committed R53:05fbc4ee57eb: Set version number to 5.3.0 (authored by brauch).
Set version number to 5.3.0
Oct 25 2018, 8:30 AM
brauch committed R32:306a2a04a89b: Set version number to 5.3.0 (authored by brauch).
Set version number to 5.3.0
Oct 25 2018, 8:28 AM

Oct 23 2018

brauch accepted D16386: Place cursor after opening brace for function implementation.

Well, I guess adding line offsets is just the level of abstraction our code gen works at, anyways. Which is good enough. In my opinion, go for it ;)

Oct 23 2018, 2:48 PM · KDevelop
brauch added a comment to D16386: Place cursor after opening brace for function implementation.

Is the opening brace always on its own line, independent of the formatter selected?

Oct 23 2018, 2:17 PM · KDevelop

Oct 22 2018

brauch added a comment to D16315: Offer completion after user types the scope resolution operator..

I'm inclined to say this looks innocent enough to go into 5.3 ...

Oct 22 2018, 6:12 AM · KDevelop

Oct 21 2018

brauch added a comment to D16064: Fix memleaks in unittests.

Can go to 5.3 in my opinion. Thank you!

Oct 21 2018, 3:28 PM · KDevelop

Oct 17 2018

brauch added a comment to D16203: Context browser: fix handleRect for non-symbol tooltips.

I'm not a huge fan of tuples either, for the reason you mentioned; I usually just create a two-element struct instead. In this case I think it's fairly obvious what the elements do from the types, though; the QPair<int, int> is worse ;)
Up to you how you do this, I just wanted to point out that it is done differently in two similar places.

Oct 17 2018, 4:47 PM · KDevelop
brauch added a comment to D16203: Context browser: fix handleRect for non-symbol tooltips.

I think the change conceptually makes sense, and I am subconsciously aware of the bug it is trying to fix. If you say it works for you, it should be fine.

Oct 17 2018, 3:51 PM · KDevelop

Oct 15 2018

brauch added a comment to D16218: [KDevelop/Core]: safe signal-handler implementation.

If there is no solution which does not require two different code paths for handling this problem, I'm against merging this, non-conformant old behaviour or not, sorry.

Oct 15 2018, 10:35 AM · KDevelop

Oct 12 2018

brauch accepted D16123: windows: Detect VS2017 compiler and tools.

I also find this reasonably simple to read. The "type your compiler arch" thing is extremely 80s of course, but the whole concept is a hack :/

Oct 12 2018, 7:29 AM · KDevelop

Oct 11 2018

brauch added a comment to D15804: Fix Duplicates on Quick Open File.

Code-wise this looks fine to me otherwise.

Oct 11 2018, 9:00 AM · Kate
brauch added a comment to D15804: Fix Duplicates on Quick Open File.

I can try it out.

Oct 11 2018, 8:57 AM · Kate
brauch added a comment to D15804: Fix Duplicates on Quick Open File.

I think the main performance issue here was fixed in 90f51f5830e32998d41a710c448212e49e1be04a, in my profiles that took >95% of the time. It's still worth optimizing, but I think no matter what you do there should not be complaints like the one linked in the bug report any more ...

Oct 11 2018, 8:37 AM · Kate

Oct 9 2018

brauch accepted D16085: Improve support for 'with' statements..

Otherwise looks good! If you feel super ambitious you could add a test, should be very simple ;)

Oct 9 2018, 6:09 PM · KDevelop

Oct 5 2018

brauch accepted D15955: clang: Also detect Clang builtin dirs at runtime.

Looks good to me, and with little risk ... on Linux nothing changes, on Windows we test it anyways before shipping.

Oct 5 2018, 11:14 AM · KDevelop

Oct 3 2018

brauch added a comment to D15895: Use CLANG_INCLUDE_DIRS for clang include dir.

On Arch Linux, the latest version of the patch seems to work fine.

Oct 3 2018, 5:12 PM · KDevelop

Sep 26 2018

brauch committed R877:b0d4b8eced7d: unbreak kdevelop blueprint (stable -> unstable in URL scheme) (authored by brauch).
unbreak kdevelop blueprint (stable -> unstable in URL scheme)
Sep 26 2018, 8:21 AM

Sep 23 2018

brauch committed R877:347930b1086d: KDevelop: build 5.3 beta tarballs (authored by brauch).
KDevelop: build 5.3 beta tarballs
Sep 23 2018, 11:31 PM

Sep 19 2018

brauch committed R32:997be66c7fc6: appimage: fix clang plugin from not loading (authored by brauch).
appimage: fix clang plugin from not loading
Sep 19 2018, 9:13 PM

Sep 5 2018

brauch accepted D14818: Fix ClassNameReferences..

I'm not really capable of doing an in-depth review here, since I don't know enough details of PHP nowadays. Style-wise I think it could still profit from reducing the block size of un-named (i.e. not a function with a name), uncommented complex code a bit, since it often requires quite some thinking to grasp what a certain conditional actually checks for. A simple comment like "// not a function" or whatever can do wonders there.
Feel free to merge this as-is or with a bit more comments, better get it in before the beta and still have a fix window before the release than merge it after the beta. Thanks for keeping kdev-php alive!

Sep 5 2018, 5:42 PM · KDevelop
brauch added a comment to D14865: clang: include tooltips: fix range check.

I'm super confused by the diff phabricator shows below but the commited changes are correct (and different from the diff here) ... what's going on?

Sep 5 2018, 7:56 AM · KDevelop
brauch added a comment to D7010: KSqueezedTextLabel: call updateGeometry() when text changes.

For the record, I tried writing a test for this but didn't succeed and eventually put it aside, although the difference is easily visible in a test application. There must be a reason why the naive test case behaves differently from an interactive application ... I could take another look, I guess.

Sep 5 2018, 7:48 AM · Frameworks

Aug 21 2018

brauch committed R499:08c8604fc862: Set stable branch of KDevelop + plugins to 5.3 (authored by brauch).
Set stable branch of KDevelop + plugins to 5.3
Aug 21 2018, 11:28 AM

Aug 20 2018

brauch committed R32:c0e3d5248aa6: Add ExplicitlyTyped flag to Declaration. (authored by michalsrb).
Add ExplicitlyTyped flag to Declaration.
Aug 20 2018, 9:37 AM
brauch closed D14838: Add ExplicitlyTyped flag to Declaration..
Aug 20 2018, 9:37 AM · KDevelop
brauch committed R877:45127004671e: set version to 5.2.4 for KDevelop (authored by brauch).
set version to 5.2.4 for KDevelop
Aug 20 2018, 9:15 AM

Aug 19 2018

brauch committed R53:0a886a8b0c4e: Set version number to 5.2.4 (authored by brauch).
Set version number to 5.2.4
Aug 19 2018, 2:53 PM
brauch committed R52:5f9eed585d69: Set version number to 5.2.4 (authored by brauch).
Set version number to 5.2.4
Aug 19 2018, 2:51 PM
brauch committed R32:9a09ad18da80: Set version number to 5.2.4 (authored by brauch).
Set version number to 5.2.4
Aug 19 2018, 2:50 PM

Aug 17 2018

brauch added a comment to D14897: InlineNote: Pimpl inline note data without allocs.

Sorry, never mind -- that code I removed yesterday. All should be fine.

Aug 17 2018, 11:41 AM · Frameworks, Kate
brauch added a comment to D14897: InlineNote: Pimpl inline note data without allocs.

Looks ok to me, except one thing: the operator== is used to compare a note from the list to the "currently active" note in the view. If this compares also the "under mouse" state, this code might be broken now ...?

Aug 17 2018, 11:07 AM · Frameworks, Kate
brauch added a comment to D14818: Fix ClassNameReferences..

Good amount of tests :) For the actual implementation, I would suggest trying to make it a bit more readable by a) splitting it up into several functions and b) trying to reduce indent depth a bit by using continue instead of nested ifs.

Aug 17 2018, 9:48 AM · KDevelop
brauch accepted D14876: Improved type detection for object properties..

Maybe you make the the visitAssignment code a bit more readable by breaking it up into 2-3 functions?

Aug 17 2018, 9:41 AM · KDevelop
brauch accepted D14839: Improve resolution of namespaced identifiers..

As I said at Akademy already, I am neither familiar with the code of the PHP plugin nor with the later developments in the language itself, so I'm not a good reviewer for these patches. But since you want to get them in and nobody else seems to have time, I have read through this and I can't spot anything obviously wrong or stupid. We'll have a beta to try it out :)

Aug 17 2018, 9:31 AM · KDevelop
brauch added a comment to D14894: [RFC] Fix block mode for multi-cursor branch.

Thanks for the patch, the approach looks reasonable at a first glance. You might want to unite the up/down functions ...
It is too much of a WiP to merge it like this, though.

Aug 17 2018, 9:05 AM · Frameworks, Kate

Aug 16 2018

brauch committed R39:a534a608fa67: fix build: link against KF5::SyntaxHighlighting where needed (authored by brauch).
fix build: link against KF5::SyntaxHighlighting where needed
Aug 16 2018, 11:15 PM
brauch committed R39:4ea5fee0afe5: Add inline note interface (authored by brauch).
Add inline note interface
Aug 16 2018, 11:15 PM
brauch closed D14826: inline note interface wip #2.

commit 4ea5fee0afe5c76bbee07563c23ede808aa059de
Author: Sven Brauch <mail@svenbrauch.de>
Date: Tue Aug 14 12:31:31 2018 +0200

Aug 16 2018, 11:15 PM · Frameworks, Kate
brauch updated the diff for D14826: inline note interface wip #2.

update license text

Aug 16 2018, 9:53 PM · Frameworks, Kate
brauch updated the diff for D14826: inline note interface wip #2.

Implement Dominik's suggestions

Aug 16 2018, 9:49 PM · Frameworks, Kate
brauch added a comment to D14879: Fix VariableToolTip auto resizing..

The patches you submitted recently are all very nice, if you feel think you are going to contribute more things in the future, I'm sure we can give you the permission bit to write to the KDE repos yourself :)
Just let us know at any time if you want that.

Aug 16 2018, 3:21 PM · KDevelop
brauch committed R32:6b146066a491: Fix VariableToolTip auto resizing. (authored by michalsrb).
Fix VariableToolTip auto resizing.
Aug 16 2018, 3:18 PM
brauch closed D14879: Fix VariableToolTip auto resizing..
Aug 16 2018, 3:18 PM · KDevelop
brauch added a comment to D14870: Inject environment profile variables into debug process environment..

Of course arc is too stupid for the special characters in your name, sorry about that ...

Aug 16 2018, 12:19 PM · KDevelop
brauch committed R53:6b7846263088: Inject environment profile variables into debug process environment. (authored by Kebianizao).
Inject environment profile variables into debug process environment.
Aug 16 2018, 12:18 PM
brauch closed D14870: Inject environment profile variables into debug process environment..
Aug 16 2018, 12:18 PM · KDevelop
brauch added a comment to D14870: Inject environment profile variables into debug process environment..

No, you need special karma to push to the KDE repos. If you are not aware you have this, you have not ;)
I will submit this for you later.

Aug 16 2018, 12:05 PM · KDevelop
brauch accepted D14870: Inject environment profile variables into debug process environment..

This change looks very reasonable to me. Thank you!

Aug 16 2018, 6:45 AM · KDevelop

Aug 15 2018

brauch added a comment to D14710: Inject default environment group variables into debug process environment..

I'm actually fine with this approach, I just don't understand why the environment is set once on the process and once on the job. Why is this necessary, or do I misunderstand what it's doing ...?

Aug 15 2018, 9:57 PM · KDevelop
brauch updated the diff for D14826: inline note interface wip #2.

address Dominik's suggestion and split focus handling and click handling

Aug 15 2018, 9:55 PM · Frameworks, Kate
brauch committed R52:97235b1455c6: Merge branch 'master' into 5.3 (authored by brauch).
Merge branch 'master' into 5.3
Aug 15 2018, 9:33 PM
brauch added a comment to D14710: Inject default environment group variables into debug process environment..

I have infinite patience in watching other people do the work, so by all means, go ahead! :-)

Aug 15 2018, 9:03 PM · KDevelop
brauch added a comment to D14710: Inject default environment group variables into debug process environment..

Thanks for the patch!

Aug 15 2018, 8:43 PM · KDevelop
brauch requested review of D14865: clang: include tooltips: fix range check.
Aug 15 2018, 7:48 PM · KDevelop
brauch updated the diff for D14826: inline note interface wip #2.

I added the rest of the interaction interface (click, mouseover)
and reduced the API a bit by moving a few hints into the InlineNote
object.

Aug 15 2018, 6:26 PM · Frameworks, Kate

Aug 14 2018

Restricted Application added a project to D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights: Kate.

Can't we simply update our shipped schemas, and expect users with custom schemas to fix them?

Aug 14 2018, 9:21 PM · Kate, Frameworks
brauch committed R52:d4f4291bdf92: Merge branch 'master' into 5.3 (authored by brauch).
Merge branch 'master' into 5.3
Aug 14 2018, 8:21 PM
brauch committed R52:38d2dbfaee7e: Set version to 5.2.80 (authored by brauch).
Set version to 5.2.80
Aug 14 2018, 8:21 PM