brauch (Sven Brauch)
User

Projects

User Details

User Since
Jan 25 2016, 10:25 AM (60 w, 5 d)

Recent Activity

Tue, Mar 21

brauch added a comment to D5122: This patch fixes bug 374144, Basically it allows users to install via a custom root installation command.

Can you make the line edit disabled when something else than "custom command" is selected?
Otherwise, LGTM, thanks for the patch!

Tue, Mar 21, 5:36 PM · KDevelop

Sun, Mar 19

brauch added a comment to D4234: Change algorithm for autobrace..

Hm, I think the biggest problem is that we don't know how we want it to work ... so we can't write tests either ;)

Sun, Mar 19, 10:30 PM · Frameworks

Thu, Mar 16

brauch added a comment to D5042: Port away from QtWebKit into QtWebEngine.

Sorry that my comment is a rather philosophical one, and maybe a bit disconnected from reality, but ...
Do we really need a full web browser engine for this purpose? Effectively, we render text, links, and maybe ocassionaly a simple table and an image. Isn't there something simpler than a web browser engine (which is half an operating system these days) which provides us with these capabilities? What about the Qt Rich Text stuff?

Thu, Mar 16, 12:19 AM

Mon, Mar 13

brauch committed R52:7d8a6b5ceadf: Update version number to 5.1.0 (authored by brauch).
Update version number to 5.1.0
Mon, Mar 13, 7:04 PM
brauch committed R33:1b33ea639196: Update version number to 5.1.0 (authored by brauch).
Update version number to 5.1.0
Mon, Mar 13, 6:54 PM
brauch committed R32:97be794e00f2: Update version number to 5.1.0 (authored by brauch).
Update version number to 5.1.0
Mon, Mar 13, 6:53 PM
brauch committed R32:ea90e0cb70e8: set version to 5.1 in release script (authored by brauch).
set version to 5.1 in release script
Mon, Mar 13, 6:53 PM
brauch committed R53:c4c5d0fe7328: Update version number to 5.1.0 (authored by brauch).
Update version number to 5.1.0
Mon, Mar 13, 6:52 PM
brauch committed R53:991ca98d50a1: style checking: fix timeout; limit output to 32kB (authored by brauch).
style checking: fix timeout; limit output to 32kB
Mon, Mar 13, 5:54 PM

Sun, Mar 12

brauch accepted D5028: Replace calls to deprecated QModelIndex::child.

LGTM, don't remember why they changed this.

Sun, Mar 12, 8:58 PM

Sat, Mar 11

brauch committed R33:a200280a9b5b: Add support for git worktrees (authored by tnorth).
Add support for git worktrees
Sat, Mar 11, 2:55 PM
brauch closed D5014: Add support for git worktrees by committing R33:a200280a9b5b: Add support for git worktrees (authored by tnorth).
Sat, Mar 11, 2:55 PM
brauch accepted D5014: Add support for git worktrees.

Looks good to me. Should I submit this for you or do you have commit access yourself?

Sat, Mar 11, 2:45 PM
brauch added a comment to D5014: Add support for git worktrees.

Looks good except what is noted below, thanks!

Sat, Mar 11, 2:01 PM

Thu, Mar 9

brauch committed R32:4e99db4516c4: appimage: use KF5 5.32 (authored by brauch).
appimage: use KF5 5.32
Thu, Mar 9, 11:42 PM
brauch accepted D4988: Fix for kdevelop component names displayed in the shortcut editor.

LGTM, thanks

Thu, Mar 9, 3:51 PM

Sun, Mar 5

brauch added a comment to D4930: Add basic support for parsing OpenCL.

LGTM but I know nothing about neither clang nor opencl :/

Sun, Mar 5, 5:26 PM

Sat, Mar 4

brauch accepted D4936: Restore compile-time support for Python 3.4.3+.

Nice work, looks good to me -- didn't test with 3.4 though. Thank you very much!

Sat, Mar 4, 8:03 PM

Wed, Mar 1

brauch committed R32:744003c35eda: dockerfile for appimage: remove "wget wget" (???) (authored by brauch).
dockerfile for appimage: remove "wget wget" (???)
Wed, Mar 1, 11:39 PM

Sun, Feb 26

brauch accepted D4182: Remove decorator declarations.
Sun, Feb 26, 10:24 PM
brauch added a comment to D4182: Remove decorator declarations.

LGTM except what I noted above (no need to resubmit).
Should we remove the custom data class maybe, now that it does nothing any more ...?

Sun, Feb 26, 9:21 PM

Thu, Feb 23

brauch committed R138:08e20e76db99: update PCRE version to 8.39 (authored by brauch).
update PCRE version to 8.39
Thu, Feb 23, 11:19 PM

Feb 19 2017

brauch added a comment to D4490: WIP: Some KDevelop specific file templates.

I think I'm with Kevin here, if I imagine being a user I would prefer having one demo project which shows up all the things a lot over having lots of individual templates I have to piece together.

Feb 19 2017, 1:27 AM

Feb 18 2017

brauch added a comment to D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates.

Looks sensible to me, but can you check that it doesn't break KDevelop's navigation widget? I think that is the most visible use case for that interface right now.

Feb 18 2017, 6:51 PM · Frameworks, Plasma

Feb 16 2017

brauch added a comment to D4234: Change algorithm for autobrace..

Hm ok, I never hit that problem, I guess we're just different there. I have muscle memory which types f() or f(x) or "hi", but not for more than one level of closing parentheses.

Feb 16 2017, 10:52 PM · Frameworks
brauch added a comment to D4634: Disallow executing kate and kwrite as root on Linux.

Parallel of this patch we can provide a service file with 'EDITOR=kate sudoedit %u' as new solution of root actions, what it's used.

Feb 16 2017, 9:41 PM
brauch added a comment to D4634: Disallow executing kate and kwrite as root on Linux.

Yeah, I figured that was your intention, just saying ;)

Feb 16 2017, 7:51 PM
brauch added a comment to D4634: Disallow executing kate and kwrite as root on Linux.

I'm fine with it but there will be complaints. Lots of people open /etc/fstab with kate as root and edit it.

Feb 16 2017, 5:14 PM

Feb 14 2017

brauch added a comment to D4612: Avoid utimes() in custommake projects, remove unsermake support.

Thanks -- but IMO remove the unsermake stuff altogether while we're at it. It's dead.

Feb 14 2017, 8:49 PM
brauch added a comment to D4234: Change algorithm for autobrace..

You mean when we have 3 open when 1 is close to be inserted 2 more to balance counting ? It's not a good idea, about me.

Feb 14 2017, 8:45 PM · Frameworks

Feb 13 2017

brauch added a comment to D4585: Simple unreachable-code detection.

Ah, I see what you mean -- you are right, if you want that feature. I'm fine with both variants, I think it's useful even without being in the declaration builder.

Feb 13 2017, 3:55 PM
brauch added a comment to D4598: Fix BUG 374894 - KDevelop crashes when clicking on QuickOpen.

Why is it not the proper fix to initialize m_dirty to true instead?

Feb 13 2017, 3:50 PM

Feb 12 2017

brauch added a comment to D4234: Change algorithm for autobrace..

Sorry, I wanted to write a reply but failed. My idea was simply to have the algorithm always aim to make parentheses balanced when closing one.

Feb 12 2017, 11:39 PM · Frameworks
brauch added a comment to D4585: Simple unreachable-code detection.

Not sure; if the nonsense code is deteced and marked with a warning, is it really a problem when the type inferred for it by static analysis is inaccurate?

Feb 12 2017, 11:35 PM
brauch added a comment to D4585: Simple unreachable-code detection.

Even though we in principle have this kind of stuff in the control flow graph, this looks sane to me, tbh the control flow graph is a bit overdesigned for what one usually wants to do.

Feb 12 2017, 7:38 PM

Feb 9 2017

brauch accepted D4513: Allow to configure import commit message for all DVCS systems.

Looks fine to me, thanks!

Feb 9 2017, 5:36 PM

Jan 23 2017

brauch added a comment to D4234: Change algorithm for autobrace..

Let's discuss an alternative suggestion maybe: how about it just keeps track of the parenthesis balancing and removes them if doing so would make it unbalanced? It could stop counting at the next folding region, and exclude spellchecked parts.

Jan 23 2017, 11:36 PM · Frameworks

Jan 22 2017

brauch added a comment to D4250: Add :vsplit and :split support in kdevelop.

One question below, otherwise very nice change, and very compact :)

Jan 22 2017, 10:58 PM · KDevelop
brauch added a comment to D4234: Change algorithm for autobrace..

I'm a bit skeptical, this means I can't add closing braces when they are missing ...

Jan 22 2017, 4:22 PM · Frameworks

Jan 20 2017

brauch accepted D4216: Enable "Open Config"/"Close Project" always if just one project is loaded.
Jan 20 2017, 5:50 AM

Jan 18 2017

brauch added a comment to D4182: Remove decorator declarations.

Hmm, not sure. Don't you think it's useful to have decoratos attached to the functions? We could, for example, list them in the navigation popup -- wouldn't that be useful?
We can certainly remove this "additional information" stuff, though, that's right.

Jan 18 2017, 7:19 PM
brauch committed R52:fcb28ff65e5b: Update version number to 5.0.4 (authored by brauch).
Update version number to 5.0.4
Jan 18 2017, 5:39 PM
brauch committed R53:176da875b28d: Update version number to 5.0.4 (authored by brauch).
Update version number to 5.0.4
Jan 18 2017, 4:59 PM
brauch committed R33:97237d4e6dd2: Update version number to 5.0.4 (authored by brauch).
Update version number to 5.0.4
Jan 18 2017, 4:59 PM
brauch committed R32:886c0afc307d: Update version number to 5.0.4 (authored by brauch).
Update version number to 5.0.4
Jan 18 2017, 4:57 PM

Jan 17 2017

brauch committed R33:32c294c3330e: fix docstring (authored by brauch).
fix docstring
Jan 17 2017, 11:40 PM
brauch added inline comments to D4108: Partial Fix: display the plugins that failed to load.
Jan 17 2017, 8:24 PM
brauch requested changes to D4108: Partial Fix: display the plugins that failed to load.
Jan 17 2017, 8:23 PM
brauch added a comment to D4108: Partial Fix: display the plugins that failed to load.

Better than not displaying any info, I guess ;)

Jan 17 2017, 8:23 PM

Jan 14 2017

brauch committed R53:85e8016bcdd6: add #if around python3.6+ testcase (authored by brauch).
add #if around python3.6+ testcase
Jan 14 2017, 9:34 PM
brauch committed R53:6febf345d92d: QString::number -> QByteArray::number (authored by brauch).
QString::number -> QByteArray::number
Jan 14 2017, 4:31 PM
brauch committed R53:bda349d7d9e3: add warning when failing to lock the style checker mutex (authored by brauch).
add warning when failing to lock the style checker mutex
Jan 14 2017, 1:20 PM
brauch committed R53:a949dc9d57cc: Merge branch '5.1' (authored by brauch).
Merge branch '5.1'
Jan 14 2017, 1:12 PM
brauch committed R33:9ac460dbbcc6: Merge branch '5.1' (authored by brauch).
Merge branch '5.1'
Jan 14 2017, 1:12 PM
brauch committed R53:1e483026bc53: Fix OOM condition in style checking: move buffer processing out of read loop (authored by brauch).
Fix OOM condition in style checking: move buffer processing out of read loop
Jan 14 2017, 1:11 PM
brauch committed R53:07a4f7a2df00: style checking: read data from stdin as bytes, not in some encoding (authored by brauch).
style checking: read data from stdin as bytes, not in some encoding
Jan 14 2017, 1:11 PM
brauch committed R53:600f6b34d95e: completion: wrap expression visitor into a read lock (authored by brauch).
completion: wrap expression visitor into a read lock
Jan 14 2017, 12:22 PM
brauch committed R33:4cf23720b123: container types: do not write lock when calling addContentType() (authored by brauch).
container types: do not write lock when calling addContentType()
Jan 14 2017, 12:18 PM

Jan 13 2017

brauch added a comment to D4119: Show content types for tuples in tooltip.

Ah, cool. Then just go ahead and yes, let's fix those issues in master. Thanks!

Jan 13 2017, 4:53 PM
brauch added a comment to D4119: Show content types for tuples in tooltip.

Ah, cool. Then just go ahead and yes, let's fix those issues in master. Thanks!

Jan 13 2017, 4:53 PM
brauch added a comment to D4119: Show content types for tuples in tooltip.

BTW, i18n("%1 of ( %2 )") is copied from IndexedContainer::toString and isn't new.

I'd prefer it without spaces inside the parens (in both instances), but that would violate the string-freeze?

Jan 13 2017, 3:50 PM
brauch accepted D4119: Show content types for tuples in tooltip.

Nice change, except for what's marked. Thanks!

Jan 13 2017, 3:50 PM

Jan 10 2017

brauch added a comment to D4076: Kill the revision graph view.

+1 from my side, the feature is broken and I don't want to fix it. There's enough tools showing git history graphs on the world.

Jan 10 2017, 11:07 PM
brauch added a comment to D4061: Use categorized logging everywhere.

Hm the messages which files are being parsed should at least be in a different category, it is very useful to only have those. I'll change that, thanks for the rest!

Jan 10 2017, 5:44 PM · KDevelop

Jan 8 2017

brauch added a comment to D3999: Fix opening of remote URLs without filename .

In the Documents toolview, things like 'http://example.com/' appear with a directory for the URL and a nameless file underneath. This doesn't seem to cause any further problems.

Jan 8 2017, 12:19 PM
brauch committed R33:edb52cfd721f: Merge branch '5.1' (authored by brauch).
Merge branch '5.1'
Jan 8 2017, 12:13 PM
brauch committed R33:0301ff6b53f5: Merge branch '5.0' into 5.1 (authored by brauch).
Merge branch '5.0' into 5.1
Jan 8 2017, 12:13 PM
brauch committed R33:d42d07429929: Fix opening of remote URLs without filename (authored by brauch).
Fix opening of remote URLs without filename
Jan 8 2017, 12:09 PM
brauch closed D3999: Fix opening of remote URLs without filename by committing R33:d42d07429929: Fix opening of remote URLs without filename.
Jan 8 2017, 12:09 PM

Jan 7 2017

brauch added a reviewer for D3999: Fix opening of remote URLs without filename : flherne.
Jan 7 2017, 10:38 AM
brauch retitled D3999: Fix opening of remote URLs without filename from to Fix opening of remote URLs without filename .
Jan 7 2017, 10:37 AM

Jan 6 2017

brauch committed R53:0149dce09811: Merge branch '5.1' (authored by brauch).
Merge branch '5.1'
Jan 6 2017, 9:57 PM
brauch committed R53:2473105c0c6e: Disable FormattedValue visitor for now. (authored by brauch).
Disable FormattedValue visitor for now.
Jan 6 2017, 9:57 PM
brauch committed R53:09f08710afbe: Merge branch '5.1' (authored by brauch).
Merge branch '5.1'
Jan 6 2017, 9:43 PM
brauch committed R53:3e3603178317: update README.packagers (authored by brauch).
update README.packagers
Jan 6 2017, 9:20 AM
brauch added a comment to D3673: Outline: Sorted function list.

I was more wondering about the function always returning true ;) But I guess it makes some kind of sense semantically.

Jan 6 2017, 9:16 AM · KDevelop
brauch added a comment to D3673: Outline: Sorted function list.

Hmm, quite a diff :D
I have read through it, what I've seen looks sensible except the two places I commented. I think it's ok to put it into master now, and see if it breaks...

Jan 6 2017, 1:37 AM · KDevelop

Jan 4 2017

brauch added a comment to D3673: Outline: Sorted function list.

IMO with 5.1 branched off, you can now just push this to master, we will notice breakage fast enough.

Jan 4 2017, 10:04 AM · KDevelop
brauch requested changes to D3949: Filter -Wdocumentation Parser errors for KDevelop.

Yes sorry, -1 from me as well; look at your screenshot, the documentation is not proper doxygen (the : is wrong). It's a good diagnostics, the code is bad.

Jan 4 2017, 9:51 AM
brauch committed R317:29d43993068e: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:52 AM
brauch committed R313:f7b3ebd3957f: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:52 AM
brauch committed R316:cb899501d0b8: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:52 AM
brauch committed R314:5117e4378be0: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:52 AM
brauch committed R315:abdac4825587: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:51 AM
brauch committed R252:a4466bfeef1e: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:51 AM
brauch committed R239:f5912c86ef0d: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:51 AM
brauch committed R242:f98979955fc7: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:50 AM
brauch committed R263:c978cb15c41e: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:50 AM
brauch committed R312:752e54a9b77e: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:50 AM
brauch committed R310:794bbda970e3: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:50 AM
brauch committed R311:f1f68b4a7285: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:50 AM
brauch committed R308:dd714f79b309: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:50 AM
brauch committed R309:f614ca065973: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:49 AM
brauch committed R307:a8831ceafd62: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:49 AM
brauch committed R305:15f1f981e478: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:49 AM
brauch committed R306:6ab857f6fe2c: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:49 AM
brauch committed R241:054385c79ef6: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:48 AM
brauch committed R302:31d8a59be8f1: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:48 AM
brauch committed R304:3cbc198e8ec0: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:48 AM
brauch committed R268:637df6073a2e: GIT_SILENT add missing include(CMakeFindDependencyMacro) (authored by brauch).
GIT_SILENT add missing include(CMakeFindDependencyMacro)
Jan 4 2017, 12:47 AM