brauch (Sven Brauch)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2016, 10:25 AM (95 w, 2 d)
Availability
Available

Recent Activity

Yesterday

brauch added a comment to D8950: Remove source code of unused CVS support plugin..

Hmm, I'm not sure. The thing is, while it is of course an extremely niche feature in 2017, maybe we should look if it is easily fixable. Because *if* you are in the unfortunate situation that you have to interact with a CVS repo, I think you are all the happier if your IDE takes the pain of reading the CVS manual away from you ...

Wed, Nov 22, 6:43 PM

Mon, Nov 20

brauch closed D8913: compute itemrepository version from version plus KDEVELOP_VERSION.

Sorry, forgot to mention the review in the commit message ...

Mon, Nov 20, 2:55 PM
brauch committed R32:53ec893e8271: compute itemrepository version from version plus KDEVELOP_VERSION (authored by brauch).
compute itemrepository version from version plus KDEVELOP_VERSION
Mon, Nov 20, 2:53 PM
brauch added a comment to D8913: compute itemrepository version from version plus KDEVELOP_VERSION.

Do we want this in 5.2?

Mon, Nov 20, 1:54 PM
brauch updated the diff for D8913: compute itemrepository version from version plus KDEVELOP_VERSION.
Mon, Nov 20, 1:53 PM
brauch added a comment to D7995: KDevelop: address dirwatching inefficiency (WIP/PoC).

No, Queued means they are queued in the receiving object's thread's event loop, i.e. the slots are executed in that thread when it re-enters its event loop. Direct means the slots are called immediately, in the sender's thread. There are no other connection types.

Mon, Nov 20, 1:33 PM · KDevelop
brauch created D8913: compute itemrepository version from version plus KDEVELOP_VERSION.
Mon, Nov 20, 1:27 PM
brauch added a comment to D7995: KDevelop: address dirwatching inefficiency (WIP/PoC).

It's not "asynchronous and complex", it's just a queued connection. It posts an event to the receiving thread, and when that thread next runs its event loop, the slot gets invoked. As Milian says, it's not rocket science.

Mon, Nov 20, 11:57 AM · KDevelop

Sun, Nov 19

brauch added a comment to D8907: Suspend the background parser during Core initialization.

Ah yes, good point about Q_SIGNALS, makes sense.

Sun, Nov 19, 6:46 PM
brauch accepted D8906: Do not create parse jobs while the background parser is suspended.

Nice, thanks.

Sun, Nov 19, 6:44 PM
brauch accepted D8901: Add notes to BackgroundParser::resume/suspend.

I'll accept this too so milian is happy about the green tickmark :)

Sun, Nov 19, 6:44 PM
brauch accepted D8907: Suspend the background parser during Core initialization.

Makes sense to me. Thanks for working on this issue!

Sun, Nov 19, 6:06 PM
brauch added a comment to D8906: Do not create parse jobs while the background parser is suspended.

Can it happen that resume() is called before ThreadWeaver has finished suspending, causing it not to resume? Otherwise LGTM

Sun, Nov 19, 5:56 PM
brauch accepted D8905: Add debug output to backgroundparser's resume function.

I'd propose something like "attempting to resume background parser, but it is not suspended" as the warning text, if I see "not suspended" in the output in a year I won't know what it's about

Sun, Nov 19, 5:46 PM
brauch accepted D8904: Fix assertion while running testShutdownWithRunningJobs.

LGTM

Sun, Nov 19, 5:45 PM
brauch accepted D8903: Cleanup: share code to add jobs to background parser in unit test.

LGTM

Sun, Nov 19, 5:39 PM
brauch accepted D8902: Cleanup: Introduce isSuspended helper function.

don't see anything wrong

Sun, Nov 19, 5:37 PM
brauch accepted D8900: Simplify code now that we use the new-style connect.

Technically it can fail, I think e.g. if ICore::self()->projectController() is null, but that doesn't happen of course. LGTM

Sun, Nov 19, 5:36 PM
brauch accepted D8897: VCS History dialog: show commit message with clickable urls & fixed font.

Ah, alright. Thanks!

Sun, Nov 19, 4:57 PM
brauch added a comment to D8897: VCS History dialog: show commit message with clickable urls & fixed font.

Very good to have somebody working on those dialogs, they really need some love. Thanks!

Sun, Nov 19, 4:40 PM

Fri, Nov 17

brauch committed R32:ab85e001bc69: Merge branch '5.2' (authored by brauch).
Merge branch '5.2'
Fri, Nov 17, 7:02 PM
brauch committed R32:49b5df418539: Use Software scene graph backend for welcome page (authored by brauch).
Use Software scene graph backend for welcome page
Fri, Nov 17, 7:00 PM
brauch closed D8872: Use software backend for welcome page.
Fri, Nov 17, 7:00 PM
brauch added a comment to D8872: Use software backend for welcome page.

Yes, makes sense to me.

Fri, Nov 17, 6:44 PM
brauch updated the diff for D8872: Use software backend for welcome page.
Fri, Nov 17, 6:43 PM
brauch created D8872: Use software backend for welcome page.
Fri, Nov 17, 5:34 PM
brauch closed D8857: work around clang bug 35333: don't crash when switching git branches.

Ok, REVIEW: doesn't close reviews ... submitted with a2712c8d969137 to 5.2. Thanks for the comments.

Fri, Nov 17, 12:46 AM
brauch committed R32:a2712c8d9691: work around clang bug 35333: don't crash when switching git branches (authored by brauch).
work around clang bug 35333: don't crash when switching git branches
Fri, Nov 17, 12:46 AM

Thu, Nov 16

brauch created D8857: work around clang bug 35333: don't crash when switching git branches.
Thu, Nov 16, 10:36 PM
brauch added a comment to D8852: Fix crash deep inside VcsOverlayProxyModel::data().

+1 from me, but let apol review it ;)

Thu, Nov 16, 5:01 PM
brauch accepted D8842: app: Improve --project handling.

Fine with me.

Thu, Nov 16, 2:00 PM

Wed, Nov 15

brauch added a comment to D8831: gcclikecompiler: Fix execution of compiler qprocess under windows.

I understand what the patch does, but can you explain why this fixes your issue?

Wed, Nov 15, 9:00 PM

Wed, Nov 8

brauch committed R32:86bbc9ffe63b: fix templates not working on windows (authored by geetamc).
fix templates not working on windows
Wed, Nov 8, 6:15 PM
brauch accepted D8727: fix templates not working on windows.

Good find, please submit to 5.2 :)

Wed, Nov 8, 5:26 PM
brauch added inline comments to D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip.
Wed, Nov 8, 4:30 PM
brauch added a comment to D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip.

40 characters or 25% of the view's width, whichever is smaller?

Wed, Nov 8, 12:31 PM
brauch added a comment to D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip.

Random thought, not sure if useful/technically feasible: the border could also behave like a splitter, allowing to resize it.

Wed, Nov 8, 12:13 PM
brauch added a comment to D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip.

Looks cool! The panel is extremely wide, maybe we want it to be a bit less wide ...?

Wed, Nov 8, 11:53 AM

Tue, Nov 7

brauch added a comment to D8688: Create annotation color from revision hash, not RNG number.

LGTM

Tue, Nov 7, 12:46 AM
brauch added inline comments to D8688: Create annotation color from revision hash, not RNG number.
Tue, Nov 7, 12:20 AM
brauch accepted D8688: Create annotation color from revision hash, not RNG number.

Looks good, thanks!

Tue, Nov 7, 12:10 AM

Sun, Nov 5

brauch committed R52:bf690b1a09af: Set version number to 5.2.0 (authored by brauch).
Set version number to 5.2.0
Sun, Nov 5, 10:36 AM
brauch committed R53:517d7133f389: Set version number to 5.2.0 (authored by brauch).
Set version number to 5.2.0
Sun, Nov 5, 10:36 AM
brauch committed R32:7ad7a7a3e1d5: Set version number to 5.2.0 (authored by brauch).
Set version number to 5.2.0
Sun, Nov 5, 10:35 AM

Fri, Nov 3

brauch added a comment to D8588: Make VCS data container classes implicitly shared.

No, no objections, it doesn't really do any harm. Thanks!

Fri, Nov 3, 11:42 AM

Wed, Nov 1

brauch added a comment to D8588: Make VCS data container classes implicitly shared.

In general looks like a good idea and I admire your persistence, but do we really want 3k lines of code of tests testing copy constructors? Does that add value? It seems like it just makes any future changes harder ... It only tests that the compiler-generated code actually does what the compiler claims it will do, no? ;)

Wed, Nov 1, 10:05 AM

Oct 22 2017

brauch added a comment to D8300: Added the "save selection/cut selection to file" to Edit menu.

Yeah, the problem with kate plugins is that we have no way to distribute them. We don't have infrastructure for distributing binary plugins, and we don't really support script plugins, and nobody installs your plugin if you put it on github with compile instructions. I'm not sure what that means for this case, I'll leave that decision to the maintainers I think.

Oct 22 2017, 7:17 PM · Kate
brauch added a comment to D8300: Added the "save selection/cut selection to file" to Edit menu.

Hmm, I'm not sure -- this is quite a bit of code for a feature I personally wouldn't know how to make use of. Yes, I sometimes want to perform this action, but really, I just press Ctrl+C, Ctr+N, Ctrl+V and I have achieved the same thing -- and it's much easier to remember than another shortcut for specifically this ...

Oct 22 2017, 9:49 AM · Kate

Oct 17 2017

brauch committed R39:7c7ae9acfe6e: add autotests for D8333 (authored by brauch).
add autotests for D8333
Oct 17 2017, 9:34 AM

Oct 16 2017

brauch committed R39:aeebeadb5f59: fix some indenters from indenting on random characters (authored by brauch).
fix some indenters from indenting on random characters
Oct 16 2017, 7:35 PM
brauch closed D8333: fix some indenters from randomly invoking indent.
Oct 16 2017, 7:35 PM · Frameworks, Kate
brauch added a comment to D8333: fix some indenters from randomly invoking indent.

Yes, at least the ones I'm aware of. Thanks for the review, I'll push it in a moment.

Oct 16 2017, 7:33 PM · Frameworks, Kate
brauch added inline comments to D8333: fix some indenters from randomly invoking indent.
Oct 16 2017, 6:09 PM · Frameworks, Kate
brauch created D8333: fix some indenters from randomly invoking indent.
Oct 16 2017, 4:37 PM · Frameworks, Kate

Oct 12 2017

brauch committed R53:21aabdc67af8: debugger: fix default working directory if none specified (authored by brauch).
debugger: fix default working directory if none specified
Oct 12 2017, 10:28 PM

Oct 6 2017

brauch added a comment to D8158: KDevelop: decorate patch version string in development builds.

Future tags won't drop the v, because all KDE apps always have the v there.

Oct 6 2017, 11:02 AM · KDevelop
brauch requested changes to D8158: KDevelop: decorate patch version string in development builds.
  • This only works on UNIX
  • This adds a hard build-time-dependency on git, doesn't it?
Oct 6 2017, 10:45 AM · KDevelop

Oct 4 2017

brauch accepted D8139: Add missing X-KDevelop-Category entries to plugins' metadata.

I grepped around and I a) can see why not setting this key breaks things and b) don't see why it would be wrong. I think it's just an oversight that it wasn't. Thank you!

Oct 4 2017, 6:10 PM

Sep 30 2017

brauch accepted D7863: Add paste external script.

It's a hack but meh, why not. It's not like the "sort selection" script wouldn't have the same problem. While you're at it, probably #ifdef that one as well ...

Sep 30 2017, 7:35 AM

Sep 29 2017

brauch committed R32:af22e97089b5: fix version variable name (authored by brauch).
fix version variable name
Sep 29 2017, 1:47 PM
brauch committed R52:5ad9f0c2deee: Update version number to 5.1.80 (authored by brauch).
Update version number to 5.1.80
Sep 29 2017, 11:43 AM
brauch committed R53:1931dec19f07: Update version number to 5.1.80 (authored by brauch).
Update version number to 5.1.80
Sep 29 2017, 11:42 AM
brauch committed R32:3eef114e2c46: Update version number to 5.1.80 (authored by brauch).
Update version number to 5.1.80
Sep 29 2017, 11:27 AM

Sep 28 2017

brauch accepted D8045: plugins: Unify category names.

LGTM

Sep 28 2017, 10:38 PM
brauch committed R32:fe4d43887c3f: fix inserting ; when calling a void function in a non-empty line (authored by brauch).
fix inserting ; when calling a void function in a non-empty line
Sep 28 2017, 10:13 AM
brauch added a comment to D7995: KDevelop: address dirwatching inefficiency (WIP/PoC).

I also think by the way that this shouldn't go to 5.2, sorry ... 5.2 is fragile enough as it is on the platforms we already claim to be stable on. Let's put it in master and instead try to keep the time to 5.3 short-ish.

Sep 28 2017, 9:39 AM · KDevelop

Sep 26 2017

brauch added inline comments to D7979: Filter out warnings as error from parser's compile flags.
Sep 26 2017, 11:35 PM · KDevelop
brauch accepted D7979: Filter out warnings as error from parser's compile flags.

Looks good to me, thanks! Maybe wait for Milian to approve as well.

Sep 26 2017, 10:00 PM · KDevelop
brauch added a comment to D7995: KDevelop: address dirwatching inefficiency (WIP/PoC).

My position stays the same: are we really in a situation in 2017 where, from the kernel POV, we cannot get notified of changed files in a directory tree without 30+ seconds setup cost? Only if that is the case (and I'm quite sceptical) I'd say this approach is a good idea.

Sep 26 2017, 5:19 PM · KDevelop
brauch added a comment to D7979: Filter out warnings as error from parser's compile flags.

Otherwise, looks good to me, thanks a lot!

Sep 26 2017, 8:21 AM · KDevelop

Sep 25 2017

brauch added a comment to D7979: Filter out warnings as error from parser's compile flags.

Imo this should be done in the clang plugin. Other plugins may want to know the "full" args, so filtering in the IADM is too early. Only for the purpose of clang do we want to filter this out.

Sep 25 2017, 11:11 AM · KDevelop
brauch added a comment to D7979: Filter out warnings as error from parser's compile flags.

I was experimenting with a similar patch locally and yes, I think this should be done on the higher layer as well. Otherwise, you need the same patch for e.g. qmake.

Sep 25 2017, 9:17 AM · KDevelop

Sep 23 2017

brauch committed R32:a5e00ea60419: CXType_Float128 is only available since clang version 38 (authored by brauch).
CXType_Float128 is only available since clang version 38
Sep 23 2017, 12:01 PM

Sep 22 2017

brauch accepted D7945: Revert automatic grep job execution from Find in Files history.

Looks good to me! The issue it (I think?) fixes is quite annoying, so go please submit and thanks :)

Sep 22 2017, 10:41 PM

Sep 21 2017

brauch accepted D7908: Parser: Normalize exception before reading values.

Looks good to me, thanks!

Sep 21 2017, 11:26 AM

Sep 18 2017

brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

The deferred starting of the parsing. The dirwatches, sure -- if they are that slow on mac, another solution is needed.

Sep 18 2017, 8:27 PM · KDevelop
brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

Rene, did you actually read the comments I made on the other RR? I'm fairly sure that is the result an in-depth performance analysis will show too, and I'm faily sure your workaround is not needed if the performance *bugs* this code has are fixed ...

Sep 18 2017, 3:44 PM · KDevelop

Sep 16 2017

brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..
In D7745#146271, @rjvbb wrote:
Rene, maybe you want to look into this?

This sounds like it could well be something requiring a substantially deeper understanding of the underlying architecture than I have (and wouldn't normally seek out just for fun ;))

Sep 16 2017, 12:54 PM · KDevelop
brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

Or rather, let me rephrase: The first point is IMO the much worse bug, since that is what will cause large project imports (think clang) be very slow in either case. For completely no reason whatsoever.

Sep 16 2017, 10:51 AM · KDevelop
brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

Ok, here's the two things that are broken and need fixing:

Sep 16 2017, 10:48 AM · KDevelop
brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

I just poked around a bit myself. It indeed takes ages to import the project, and I couldn't figure out why ... it is certainly not CPU load. I looked in perf, the CPU time spent in importing the project is quite low.
In fact, the code model generation (which seems to be the last step in the import AFAIU) finishes relatively quickly here (after something like 5 seconds), but then it still takes like 30 seconds for the import to finish. I don't know where that time is spent.

Sep 16 2017, 10:09 AM · KDevelop

Sep 15 2017

brauch added a comment to D7752: Make it possible for IBuildSystem to provide extra arguments to the parser.

Ok, you're right ... I looked some more. Try "-pipe", qmake passes that here, that seems to be what breaks things if I'm not mistaken.

Sep 15 2017, 1:36 PM
brauch reopened D7752: Make it possible for IBuildSystem to provide extra arguments to the parser.

There are some arguments which we shouldn't pass on, for example I have a qmake project here which does QMAKE_CXXFLAGS += -Werror=return-type and that completely breaks everything (no highlighting any more whatsoever, parsing of all files fails, ...), Not even sure why, but I guess -Werror arguments should never be passed on in our case.

Sep 15 2017, 10:57 AM
brauch committed R32:dc09a86b6990: qmake: compiler extra arguments: fix condition (authored by brauch).
qmake: compiler extra arguments: fix condition
Sep 15 2017, 10:41 AM
brauch added inline comments to D7752: Make it possible for IBuildSystem to provide extra arguments to the parser.
Sep 15 2017, 10:36 AM
brauch committed R32:12a10c601984: clang: fix "unhandled type: float128" warning (authored by brauch).
clang: fix "unhandled type: float128" warning
Sep 15 2017, 10:22 AM

Sep 14 2017

brauch added a comment to D7752: Make it possible for IBuildSystem to provide extra arguments to the parser.

Re. IRC: Yes, to 5.2 I would say. We didn't release our beta yet, and I even think this counts as a bug fix ...
Thanks a lot!

Sep 14 2017, 9:38 AM

Sep 13 2017

brauch accepted D7791: Open context for lambdas in ContextBuilder.

Looks sensible, thanks for investigating!

Sep 13 2017, 12:01 AM

Sep 8 2017

brauch added a comment to D7745: KDevelop (full) project parsing: defer until all projects have been loaded..

Do you have some timing on how much loading time improves with this patch?

Sep 8 2017, 11:40 PM · KDevelop
brauch accepted D7735: [KateFileTreeModel] Don't iterate over keys().

range-based for would detach ...?
If you had a reason not to use that, LGTM, thanks!

Sep 8 2017, 2:09 PM

Sep 5 2017

brauch added a comment to T6869: Create ktexteditor-addons repo.

Releasing with applications makes sense to me, I feel like it should be released in sync with kate.
If there is a hard dependency anyways then I agree with Dominik that we should move all plugins over. All of them are possibly useful for an embedding application, and with moving just some I see us moving plugins back and forth all the time for no real reason.

Sep 5 2017, 7:36 PM · Kile, Kate, KDevelop, KTextEditor

Sep 1 2017

brauch accepted D7643: Remove some unneeded parameters.

Looks good, thanks!

Sep 1 2017, 3:28 PM

Aug 29 2017

brauch committed R32:fb704c7745b5: Set version number to 5.1.2 (authored by brauch).
Set version number to 5.1.2
Aug 29 2017, 8:13 PM

Aug 28 2017

brauch accepted D7593: Find generator variables without fake early declarations.

Good solution I think, better than the hack from before (because it actually does the right thing, in a way). Feel free to put it into 5.2, we still have a few weeks to catch issues it causes. Thanks!

Aug 28 2017, 9:52 PM
brauch committed R247:53904a088000: set KDevelop stable branch to 5.2, remove kdevplatform repo stable branch (authored by brauch).
set KDevelop stable branch to 5.2, remove kdevplatform repo stable branch
Aug 28 2017, 9:38 PM
brauch committed R499:7739a112ef74: set KDevelop stable branch to 5.2 and remove kdevplatform stable branch (repo… (authored by brauch).
set KDevelop stable branch to 5.2 and remove kdevplatform stable branch (repo…
Aug 28 2017, 9:37 PM

Aug 17 2017

brauch committed R32:17b0e9ac4b5c: Merge branch '5.1' into 5.2 (authored by brauch).
Merge branch '5.1' into 5.2
Aug 17 2017, 7:31 PM
brauch committed R32:1e1f1f6838f6: appimage script: fix copying of icons (authored by brauch).
appimage script: fix copying of icons
Aug 17 2017, 7:31 PM
brauch committed R32:da932380b2c9: Merge branch '5.1' (authored by brauch).
Merge branch '5.1'
Aug 17 2017, 4:48 PM
brauch committed R32:ff52dc234d64: Dockerfile: update llvm to 3.9.1; fix ninja installation (authored by brauch).
Dockerfile: update llvm to 3.9.1; fix ninja installation
Aug 17 2017, 4:48 PM