heikobecker (Heiko Becker)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 13 2015, 7:20 PM (233 w, 5 d)
Availability
Available

Recent Activity

Sun, Dec 1

heikobecker abandoned D25095: Include fixx11.h to fix the build with Qt 5.14.

218a5229348f7d131da7e91f25894231469654f6 did the same.

Sun, Dec 1, 9:13 PM

Tue, Nov 26

heikobecker committed R158:afb66bd1dc6a: Merge remote-tracking branch 'origin/release/19.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/19.12'
Tue, Nov 26, 11:07 PM
heikobecker committed R158:f11408fe3435: Merge branch 'fix-build-with-qt-5.14' into 'release/19.12' (authored by heikobecker).
Merge branch 'fix-build-with-qt-5.14' into 'release/19.12'
Tue, Nov 26, 11:00 PM
heikobecker committed R158:e17e37594619: Fix build with Qt 5.14 (authored by heikobecker).
Fix build with Qt 5.14
Tue, Nov 26, 11:00 PM

Sat, Nov 23

heikobecker committed R95:a94f48d2dcde: Merge remote-tracking branch 'origin/release/19.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/19.12'
Sat, Nov 23, 5:54 PM
heikobecker committed R92:64754457000e: Only build and install designer plugin if it's enabled (authored by heikobecker).
Only build and install designer plugin if it's enabled
Sat, Nov 23, 5:50 PM
heikobecker committed R92:5422b18bbba1: Merge remote-tracking branch 'origin/release/19.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/19.12'
Sat, Nov 23, 5:50 PM
heikobecker closed D25472: Only build and install designer plugin if it's enabled.
Sat, Nov 23, 5:50 PM · KDE PIM
heikobecker committed R89:4fdde0b695ea: Merge remote-tracking branch 'origin/release/19.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/19.12'
Sat, Nov 23, 5:49 PM
heikobecker committed R86:14f1bfb5b696: Merge remote-tracking branch 'origin/release/19.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/19.12'
Sat, Nov 23, 5:47 PM
heikobecker committed R86:aac011db8b2e: Only build and install designer plugin if it's enabled (authored by heikobecker).
Only build and install designer plugin if it's enabled
Sat, Nov 23, 5:46 PM
heikobecker closed D25469: Only build and install designer plugin if it's enabled.
Sat, Nov 23, 5:46 PM · KDE PIM
heikobecker committed R165:bc21732497b5: Merge remote-tracking branch 'origin/release/19.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/19.12'
Sat, Nov 23, 5:45 PM
heikobecker closed D25473: Only build and install designer plugin if it's enabled.
Sat, Nov 23, 5:28 PM · KDE PIM
heikobecker committed R95:926af109b58f: Only build and install designer plugin if it's enabled (authored by heikobecker).
Only build and install designer plugin if it's enabled
Sat, Nov 23, 5:28 PM
heikobecker committed R89:c5beb34178a3: Only build and install designer plugin if it's enabled (authored by heikobecker).
Only build and install designer plugin if it's enabled
Sat, Nov 23, 5:26 PM
heikobecker closed D25471: Only build and install designer plugin if it's enabled.
Sat, Nov 23, 5:26 PM · KDE PIM
heikobecker closed D25470: Only build and install designer plugin if it's enabled.
Sat, Nov 23, 5:25 PM · KDE PIM
heikobecker committed R165:81f30de7dc80: Only build and install designer plugin if it's enabled (authored by heikobecker).
Only build and install designer plugin if it's enabled
Sat, Nov 23, 5:25 PM

Fri, Nov 22

heikobecker requested review of D25473: Only build and install designer plugin if it's enabled.
Fri, Nov 22, 7:03 PM · KDE PIM
heikobecker requested review of D25472: Only build and install designer plugin if it's enabled.
Fri, Nov 22, 7:02 PM · KDE PIM
heikobecker requested review of D25471: Only build and install designer plugin if it's enabled.
Fri, Nov 22, 7:01 PM · KDE PIM
heikobecker updated the diff for D25470: Only build and install designer plugin if it's enabled.

Remove accidentally introduced empty line

Fri, Nov 22, 6:59 PM · KDE PIM
heikobecker requested review of D25470: Only build and install designer plugin if it's enabled.
Fri, Nov 22, 6:58 PM · KDE PIM
heikobecker requested review of D25469: Only build and install designer plugin if it's enabled.
Fri, Nov 22, 6:57 PM · KDE PIM
heikobecker committed R94:c717c6a53996: Merge remote-tracking branch 'origin/release/19.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/19.12'
Fri, Nov 22, 7:38 AM
heikobecker committed R94:332cd61896f6: Fix qca include (authored by heikobecker).
Fix qca include
Fri, Nov 22, 7:20 AM
heikobecker closed D25450: Fix qca include.
Fri, Nov 22, 7:20 AM · KDE PIM

Thu, Nov 21

heikobecker requested review of D25450: Fix qca include.
Thu, Nov 21, 9:32 PM · KDE PIM

Tue, Nov 19

heikobecker committed R40:2f3e0a68808d: Merge remote-tracking branch 'origin/release/19.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/19.12'
Tue, Nov 19, 10:02 PM
heikobecker added inline comments to D25411: Search for KF5I18n and KF5DocTools.
Tue, Nov 19, 10:01 PM · Kate
heikobecker committed R40:f177bd36372f: Fix tyop in find_package call (authored by heikobecker).
Fix tyop in find_package call
Tue, Nov 19, 9:59 PM
heikobecker committed R40:4c68d024c234: Merge branch 'release/19.12' (authored by heikobecker).
Merge branch 'release/19.12'
Tue, Nov 19, 9:51 PM
heikobecker committed R40:f3bb8f2b867e: Respect KF5_MIN_VER and QT_MIN_VER (authored by heikobecker).
Respect KF5_MIN_VER and QT_MIN_VER
Tue, Nov 19, 9:49 PM
heikobecker closed D25412: Respect KF5_MIN_VER and QT_MIN_VER.
Tue, Nov 19, 9:49 PM · Kate
heikobecker committed R40:565fd945b52a: Search for KF5I18n and KF5DocTools (authored by heikobecker).
Search for KF5I18n and KF5DocTools
Tue, Nov 19, 9:49 PM
heikobecker closed D25411: Search for KF5I18n and KF5DocTools.
Tue, Nov 19, 9:49 PM · Kate
heikobecker committed R40:ae8b83793859: Search for Qt5Widgets to make a version comparison work (authored by heikobecker).
Search for Qt5Widgets to make a version comparison work
Tue, Nov 19, 9:49 PM
heikobecker closed D25410: Search for Qt5Widgets to make a version comparison work.
Tue, Nov 19, 9:49 PM · Kate
heikobecker requested review of D25412: Respect KF5_MIN_VER and QT_MIN_VER.
Tue, Nov 19, 7:52 PM · Kate
heikobecker requested review of D25411: Search for KF5I18n and KF5DocTools.
Tue, Nov 19, 7:51 PM · Kate
heikobecker requested review of D25410: Search for Qt5Widgets to make a version comparison work.
Tue, Nov 19, 7:46 PM · Kate

Sun, Nov 17

heikobecker committed R165:c923ef3746a9: Merge remote-tracking branch 'origin/release/19.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/19.12'
Sun, Nov 17, 6:12 PM
heikobecker closed D25356: Fix build with Qt 5.14.
Sun, Nov 17, 6:06 PM · KDE PIM
heikobecker committed R165:1d4bb01a6054: Fix build with Qt 5.14 (authored by heikobecker).
Fix build with Qt 5.14
Sun, Nov 17, 6:06 PM
heikobecker requested review of D25356: Fix build with Qt 5.14.
Sun, Nov 17, 5:50 PM · KDE PIM

Nov 1 2019

heikobecker added a comment to D25098: Don't set QGraphicsView::DontClipPainter anymore.

Have you checked introducing DontSavePainterState doesn't cause any graphical issues? (your test plan doesn't say so)

Nov 1 2019, 9:36 AM

Oct 31 2019

heikobecker requested review of D25098: Don't set QGraphicsView::DontClipPainter anymore.
Oct 31 2019, 6:42 PM
heikobecker added a comment to D25095: Include fixx11.h to fix the build with Qt 5.14.
In D25095#557350, @pino wrote:

Strictly speaking, we just need the includes from KWindowSystem, as the library is not actually used (and when linking with as-needed KWindowSystem will not be required).

Oct 31 2019, 6:30 PM
heikobecker added a comment to D25095: Include fixx11.h to fix the build with Qt 5.14.

Not sure if that makes it worth to depend on KWindowSystem, or if it's maybe better to copy the header over.

Oct 31 2019, 5:25 PM
heikobecker updated the summary of D25095: Include fixx11.h to fix the build with Qt 5.14.
Oct 31 2019, 5:18 PM
heikobecker updated the diff for D25095: Include fixx11.h to fix the build with Qt 5.14.

Oh, I was looking for something else but I didn't found anything. Thanks!
Included fixx11.h

Oct 31 2019, 5:16 PM
heikobecker committed R849:f2d18e730cf8: Use QTEST_GUILESS_MAIN for some autotests (authored by heikobecker).
Use QTEST_GUILESS_MAIN for some autotests
Oct 31 2019, 5:03 PM
heikobecker closed D24949: Use QTEST_GUILESS_MAIN for some autotests.
Oct 31 2019, 5:03 PM
heikobecker requested review of D25095: Include fixx11.h to fix the build with Qt 5.14.
Oct 31 2019, 4:40 PM

Oct 25 2019

heikobecker requested review of D24949: Use QTEST_GUILESS_MAIN for some autotests.
Oct 25 2019, 6:01 PM
heikobecker committed R849:612badaa35e0: Move tests involving php behind ENABLE_PHP (authored by heikobecker).
Move tests involving php behind ENABLE_PHP
Oct 25 2019, 5:59 PM
heikobecker closed D24948: Move tests involving php behind ENABLE_PHP.
Oct 25 2019, 5:59 PM
heikobecker requested review of D24948: Move tests involving php behind ENABLE_PHP.
Oct 25 2019, 5:54 PM

Oct 21 2019

heikobecker added a comment to D24817: Restore scripting functionalities and Qt bindings..

Nice! I don't want to discourage you, but while QtScript is still there it has been deprecated. Perhaps this still makes sense as a intermediate step, but at some point this should be ported to the QJS* classes from Qt5Qml (e.g. like done for kio https://phabricator.kde.org/R241:4ad1902278f0fe20db3e10db40e922f015943964).

Oct 21 2019, 7:06 AM

Oct 20 2019

heikobecker added a comment to D24413: Fix Increase/Decrease Volume shortcuts.

Since the method is only one line long, why not using lambda instead here?

Because I couldn't get it to compile successfully, I got this error:
In lambda function passing 'const EngineController' as 'this' argument discards qualifiers

Oct 20 2019, 9:11 PM

Oct 3 2019

heikobecker accepted D24381: Register Play/Pause as global shortcut again.
Oct 3 2019, 6:58 PM
heikobecker accepted D24135: Fix missing directory separators when saving podcasts to disk.

Do you have commit access or should I push this for you?

Oct 3 2019, 6:58 PM

Sep 24 2019

heikobecker accepted D24103: CMake: Bump CMake minimum version to 3.5.

I don't think so and Frameworks also need 3.5 since quite some time.

Sep 24 2019, 6:43 AM · KDE Telepathy

Sep 19 2019

heikobecker committed R119:3569d0df1207: Merge remote-tracking branch 'origin/Plasma/5.17' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.17'
Sep 19 2019, 10:25 PM
heikobecker committed R119:3a27e8ceb53e: Remove unnecessary KF5People dependency (authored by heikobecker).
Remove unnecessary KF5People dependency
Sep 19 2019, 10:24 PM
heikobecker closed D24098: Remove unnecessary KF5People dependency.
Sep 19 2019, 10:24 PM · Plasma
heikobecker committed R99:3ac6c4b90d6c: Merge remote-tracking branch 'origin/Plasma/5.17' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.17'
Sep 19 2019, 10:19 PM
heikobecker closed D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists.
Sep 19 2019, 10:19 PM · Plasma
heikobecker committed R99:d3060530e8f8: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists (authored by heikobecker).
Create an empty config (.e.g ~/.gtkrc-2.0) if none exists
Sep 19 2019, 10:19 PM
heikobecker requested review of D24098: Remove unnecessary KF5People dependency.
Sep 19 2019, 8:15 PM · Plasma
heikobecker added a reverting change for R120:273969f07df7: Fix version for Plasma/5.17: R120:bd8dda6522db: Revert "Fix version for Plasma/5.17".
Sep 19 2019, 7:49 PM
heikobecker committed R120:bd8dda6522db: Revert "Fix version for Plasma/5.17" (authored by heikobecker).
Revert "Fix version for Plasma/5.17"
Sep 19 2019, 7:49 PM
heikobecker committed R120:273969f07df7: Fix version for Plasma/5.17 (authored by heikobecker).
Fix version for Plasma/5.17
Sep 19 2019, 7:45 PM
heikobecker committed R119:240d9c4751e8: Remove duplicate find_package call for LibNotificationManager (authored by heikobecker).
Remove duplicate find_package call for LibNotificationManager
Sep 19 2019, 7:34 PM
heikobecker updated the diff for D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists.

Used the ReadWrite flag to simplify

Sep 19 2019, 6:20 PM · Plasma
heikobecker accepted D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Sep 19 2019, 5:57 PM · KDE Telepathy
heikobecker added inline comments to D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Sep 19 2019, 5:02 PM · KDE Telepathy
heikobecker accepted D24040: Don't delete whole folder when deleting a track.

All those regressions from f1ab8128fdd6b2360bfea8b0bef9b5c46b8d5e68 :(

Sep 19 2019, 4:51 PM
heikobecker added a reviewer for D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists: gikari.
Sep 19 2019, 3:24 PM · Plasma
heikobecker updated the test plan for D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists.
Sep 19 2019, 3:23 PM · Plasma
heikobecker requested review of D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists.
Sep 19 2019, 3:22 PM · Plasma
heikobecker added a comment to D21524: Keep existing configurations' strings               .

This breaks the unit test locally as well as on build.kde.org, eg.: https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/51/console and https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/5/console

Sep 19 2019, 12:39 PM · Plasma
heikobecker added inline comments to D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Sep 19 2019, 6:18 AM · KDE Telepathy
heikobecker added a comment to D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).

I don't know much about python, but it works fine with python3 where it previously didn't. +1

Sep 19 2019, 6:16 AM · KDE Telepathy
heikobecker accepted D24067: CMake: Remove own FindLibXml2.
Sep 19 2019, 6:14 AM · KDE Telepathy

Sep 18 2019

heikobecker committed R499:5572810f121a: Don't depend on frameworks which are part of kf5umbrella (authored by heikobecker).
Don't depend on frameworks which are part of kf5umbrella
Sep 18 2019, 1:38 PM
heikobecker committed R499:f750496f72ac: kf5umbrella: Add new frameworks (authored by heikobecker).
kf5umbrella: Add new frameworks
Sep 18 2019, 1:38 PM
heikobecker committed R499:e0cf42009a17: kf5umbrella: Sort (authored by heikobecker).
kf5umbrella: Sort
Sep 18 2019, 1:38 PM

Sep 16 2019

heikobecker closed D23910: startplasma: Respect KDEWM again.
Sep 16 2019, 5:13 AM · Plasma
heikobecker committed R120:0fcd29399b9d: startplasma: Respect KDEWM again (authored by heikobecker).
startplasma: Respect KDEWM again
Sep 16 2019, 5:13 AM

Sep 12 2019

heikobecker requested review of D23910: startplasma: Respect KDEWM again.
Sep 12 2019, 4:15 PM · Plasma
heikobecker added a comment to D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.

Happy to help, but I don't understand yet.

kde-cli-tools doesn't use sessionmanagementbackend.h?

The only user is inside plasma-workspace source.

Sep 12 2019, 11:32 AM · Plasma
heikobecker committed R871:0f346886dc48: Use QTEST_GUILESS_MAIN for systeminformationtest (authored by heikobecker).
Use QTEST_GUILESS_MAIN for systeminformationtest
Sep 12 2019, 7:09 AM
heikobecker closed D23878: Use QTEST_GUILESS_MAIN for systeminformationtest.
Sep 12 2019, 7:09 AM · Plasma
heikobecker added a comment to D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.

Admittedly to solve a problem, which originates from our downstream packaging. kde-cli-tools is a dependency of some applications and frameworks, which might be interesting to non Plasma users but depends on libkworkspace. As a a source based distro we cannot easily split plasma-workspace into multiple packages (actually we could, kind of, but the user would still need to build p-w and all of its dependencies). Thus we have some patches to build libkworkspace separately. Given that I could add this one too, if it's inappropriate that it'll get merged.

Sep 12 2019, 7:08 AM · Plasma

Sep 11 2019

heikobecker committed R123:5ae59b645334: Also remove the dependency on libxcb (authored by heikobecker).
Also remove the dependency on libxcb
Sep 11 2019, 5:43 PM
heikobecker added a reviewer for D23883: libkworkspace: Install sessionmanagementbackend.h with other headers: Plasma.
Sep 11 2019, 5:27 PM · Plasma
heikobecker requested review of D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.
Sep 11 2019, 5:26 PM · Plasma
heikobecker committed R123:b6d6897bad6f: Remove unneeded dependencies on X11 and QtX11Extras (authored by heikobecker).
Remove unneeded dependencies on X11 and QtX11Extras
Sep 11 2019, 5:19 PM