218a5229348f7d131da7e91f25894231469654f6 did the same.

Remove accidentally introduced empty line

In D25098#557440, @aacid wrote:

Have you checked introducing DontSavePainterState doesn't cause any graphical issues? (your test plan doesn't say so)

In D25095#557350, @pino wrote:

Strictly speaking, we just need the includes from KWindowSystem, as the library is not actually used (and when linking with as-needed KWindowSystem will not be required).

Not sure if that makes it worth to depend on KWindowSystem, or if it's maybe better to copy the header over.

Oh, I was looking for something else but I didn't found anything. Thanks!
Included fixx11.h

Nice! I don't want to discourage you, but while QtScript is still there it has been deprecated. Perhaps this still makes sense as a intermediate step, but at some point this should be ported to the QJS* classes from Qt5Qml (e.g. like done for kio https://phabricator.kde.org/R241:4ad1902278f0fe20db3e10db40e922f015943964).

In D24413#542042, @wbauer wrote:

In D24413#542035, @ognarb wrote:

Since the method is only one line long, why not using lambda instead here?

Because I couldn't get it to compile successfully, I got this error:
In lambda function passing 'const EngineController' as 'this' argument discards qualifiers

Do you have commit access or should I push this for you?

I don't think so and Frameworks also need 3.5 since quite some time.

Used the ReadWrite flag to simplify

All those regressions from f1ab8128fdd6b2360bfea8b0bef9b5c46b8d5e68 :(

This breaks the unit test locally as well as on build.kde.org, eg.: https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/51/console and https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/5/console

I don't know much about python, but it works fine with python3 where it previously didn't. +1

In D23883#529898, @davidedmundson wrote:

Happy to help, but I don't understand yet.

kde-cli-tools doesn't use sessionmanagementbackend.h?

The only user is inside plasma-workspace source.

Admittedly to solve a problem, which originates from our downstream packaging. kde-cli-tools is a dependency of some applications and frameworks, which might be interesting to non Plasma users but depends on libkworkspace. As a a source based distro we cannot easily split plasma-workspace into multiple packages (actually we could, kind of, but the user would still need to build p-w and all of its dependencies). Thus we have some patches to build libkworkspace separately. Given that I could add this one too, if it's inappropriate that it'll get merged.