People heikobecker

heikobecker (Heiko Becker)
User

Projects

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 13 2015, 7:20 PM (276 w, 5 d)
Availability
Available

Recent Activity
View All

Sat, Sep 12

heikobecker added a comment to D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR.

How do we move this or https://phabricator.kde.org/D29136 forward? @ilic As a maintainer, do you have an opinion?

Sat, Sep 12, 12:32 PM · Frameworks

Jun 15 2020

heikobecker committed R37:b4fe0614addc: Merge branch 'fix-build-with-qt-5.15' into 'krita/4.2' (authored by heikobecker).
Merge branch 'fix-build-with-qt-5.15' into 'krita/4.2'
Jun 15 2020, 8:41 PM

May 20 2020

heikobecker committed R111:93763af289c1: Use new name for dbus interface (authored by heikobecker).
Use new name for dbus interface
May 20 2020, 11:15 AM

May 19 2020

heikobecker committed R106:86aef5ecde06: Use new name for dbus interface too (authored by heikobecker).
Use new name for dbus interface too
May 19 2020, 9:08 PM

May 10 2020

heikobecker added a comment to T13138: Consider adopting unmaintained libdbusmenu-qt.

Maybe worth adding that knotifications also depends on it.

May 10 2020, 8:10 PM · Plasma

May 5 2020

heikobecker committed R181:fd05592cd8d1: Merge branch 'freebsd_compil_mysql' into 'master' (authored by heikobecker).
Merge branch 'freebsd_compil_mysql' into 'master'
May 5 2020, 10:12 PM
heikobecker committed R181:ce9a5c776f9d: Merge branch 'remove-mpris1' into 'master' (authored by heikobecker).
Merge branch 'remove-mpris1' into 'master'
May 5 2020, 9:47 PM
heikobecker added a comment to D28662: KCM LookAndFeel check widgetStyle availability before applying it.

This breaks the lookandfeel-kcm test. I saw this with 5.18.5 but it also fails on build.kde.org for a while, e.g.:

May 5 2020, 7:46 PM · Plasma

May 1 2020

heikobecker reclaimed D29136: Use non-deprecated KDEInstallDir.
May 1 2020, 8:42 AM · Frameworks

Apr 30 2020

heikobecker abandoned D29136: Use non-deprecated KDEInstallDir.

Abandoned in favour of https://phabricator.kde.org/D29136

Apr 30 2020, 3:29 PM · Frameworks
heikobecker added a comment to D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR.

Fixes the problem I had with marble, which prompted the creation of https://phabricator.kde.org/D29136. Passing the destination as an parameter seems indeed like a better way, so +1 from me.

Apr 30 2020, 3:28 PM · Frameworks
heikobecker added a comment to D29136: Use non-deprecated KDEInstallDir.

Where would you see "that the macro already used KDEInstallDirs before"? When it comes to "LOCALE_INSTALL_DIR", that is set to a default is not set when calling the macro. Ideally would be documented though. (my first approach would be to also allow a soft dependency here on KDEInstallDirs, checking whether KDE_INSTALL_LOCALEDIR is defined and picking its value), similar with CMAKE_INSTALL_LOCALEDIR to support GnuInstallDirs automatically).

Apr 30 2020, 2:19 PM · Frameworks
heikobecker added a comment to D29136: Use non-deprecated KDEInstallDir.
In D29136#660270, @kossebau wrote:

using kdeinstalldirs variables needs to ensure that KDEInstallDirs has been included before, also introduces ahard dependency on ECM for any users of KI18n. While 99% of apps using KI18n might do this, by design idea of KDE Frameworks KI18n as tier1 should not pull in another dependency, even ECM (so someone using plain cmake & GnuInstallDirs should be still able to use tier1 stuff). This needs some more pondering then...

Apr 30 2020, 12:02 PM · Frameworks

Apr 23 2020

heikobecker updated the diff for D29136: Use non-deprecated KDEInstallDir.

Added missing parentheses

Apr 23 2020, 6:38 PM · Frameworks
heikobecker requested review of D29136: Use non-deprecated KDEInstallDir.
Apr 23 2020, 6:33 PM · Frameworks

Apr 22 2020

heikobecker committed R20:c15c57d0a16a: Remove no longer needed dependencies (authored by heikobecker).
Remove no longer needed dependencies
Apr 22 2020, 11:19 PM
heikobecker committed R21:c419934af2b6: Remove unused pkg-config dependency (authored by heikobecker).
Remove unused pkg-config dependency
Apr 22 2020, 8:21 PM
heikobecker committed R21:f290c50aea56: Actually require the desired Qt version (authored by heikobecker).
Actually require the desired Qt version
Apr 22 2020, 8:21 PM

Apr 20 2020

heikobecker committed R32:0570133b8713: Merge remote-tracking branch 'origin/5.5' (authored by heikobecker).
Merge remote-tracking branch 'origin/5.5'
Apr 20 2020, 8:38 PM
heikobecker committed R32:8abc96ce3b27: FindClang.cmake: Add 10 to the allowed versions (authored by heikobecker).
FindClang.cmake: Add 10 to the allowed versions
Apr 20 2020, 8:13 PM

Apr 18 2020

heikobecker committed R165:60fbe81d8d26: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 18 2020, 10:28 PM
heikobecker committed R165:4daa82775307: Try to fix compile against qt5.15 (authored by mlaurent).
Try to fix compile against qt5.15
Apr 18 2020, 10:28 PM

Apr 16 2020

heikobecker added a comment to R224:f1da4b4850cc: Use KDE_INSTALL_DATADIR.

Yeah, it should've been... /me fetches brown paper bag
Thanks for noticing.

Apr 16 2020, 4:28 PM
heikobecker committed R224:03a1357a243d: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 16 2020, 4:26 PM
heikobecker committed R224:fba0c2d55f67: Fix previous commit (authored by heikobecker).
Fix previous commit
Apr 16 2020, 4:26 PM
heikobecker committed R224:f1da4b4850cc: Use KDE_INSTALL_DATADIR (authored by heikobecker).
Use KDE_INSTALL_DATADIR
Apr 16 2020, 4:01 PM
heikobecker added inline comments to R493:bebd62878981: Just use tr().
Apr 16 2020, 6:57 AM

Apr 15 2020

heikobecker committed R493:bebd62878981: Just use tr() (authored by heikobecker).
Just use tr()
Apr 15 2020, 9:30 PM
heikobecker committed R493:29d24181a3a0: Port from toAscii to toLatin1 (authored by heikobecker).
Port from toAscii to toLatin1
Apr 15 2020, 9:30 PM
heikobecker committed R493:69ebb111a94b: Use non-deprecated KDE_INSTALL_* variables (authored by heikobecker).
Use non-deprecated KDE_INSTALL_* variables
Apr 15 2020, 9:30 PM
heikobecker committed R493:e4de8b9bd583: Port from QDesktopServices to QStandardPaths (authored by heikobecker).
Port from QDesktopServices to QStandardPaths
Apr 15 2020, 9:30 PM

Apr 14 2020

heikobecker committed R181:d996c8a78e95: Add override identifiers (authored by heikobecker).
Add override identifiers
Apr 14 2020, 8:50 PM
heikobecker committed R1032:48396da9cd56: Fix build with Qt < 5.14 (authored by heikobecker).
Fix build with Qt < 5.14
Apr 14 2020, 8:28 PM
Restricted Application added a project to D26008: Include the gmock prefix in the search path: Amarok.

e17a38b179197d9afa303de6e254fbc284c5fa9e did something similar, I suppose this can be closed?

Apr 14 2020, 7:58 PM · Amarok

Apr 13 2020

heikobecker added a comment to T11994: Project Moves to Gitlab.

It will (parts of it already have). "to Opt In" is the important part of the sentence. Soon everything will be moved to gitlab, see the thread on kde-devel for more details.

Apr 13 2020, 8:33 PM · Sysadmin

Apr 12 2020

heikobecker committed R181:87183927e210: Use desktop entry spec compliant X-KDE-ServiceTypes keys (authored by heikobecker).
Use desktop entry spec compliant X-KDE-ServiceTypes keys
Apr 12 2020, 9:35 PM
heikobecker committed R181:2884c29c0714: No need to set CMAKE_MODULE_PATH again (authored by heikobecker).
No need to set CMAKE_MODULE_PATH again
Apr 12 2020, 9:35 PM
heikobecker committed R181:5ce6dd2b4768: Make icons look sharp with HiDPI (authored by heikobecker).
Make icons look sharp with HiDPI
Apr 12 2020, 9:35 PM
heikobecker committed R181:a41a086e0564: Set StartupWMClass in desktop file (authored by heikobecker).
Set StartupWMClass in desktop file
Apr 12 2020, 9:35 PM
heikobecker committed R181:c7dc86335237: Use currentDateTimeUtc().toTime_t() (authored by heikobecker).
Use currentDateTimeUtc().toTime_t()
Apr 12 2020, 11:07 AM
heikobecker committed R181:fa9cae980836: Port from {from,to}Time_t to {from,to}SecsSinceEpoch (authored by heikobecker).
Port from {from,to}Time_t to {from,to}SecsSinceEpoch
Apr 12 2020, 11:07 AM
heikobecker committed R181:2cd1de69045b: Remove Phabricator's .arcconfig (authored by heikobecker).
Remove Phabricator's .arcconfig
Apr 12 2020, 9:58 AM
heikobecker committed R181:061dbe3f30e0: Remove nepmukcollection (authored by heikobecker).
Remove nepmukcollection
Apr 12 2020, 9:58 AM

Apr 11 2020

heikobecker added a comment to D28593: Fix copying and moving files to collection.

Oh, and although it was closed because of a missing backtrace it looks like this would fix: https://bugs.kde.org/show_bug.cgi?id=411716

Apr 11 2020, 11:03 AM · Qt 5 Porting, Amarok
heikobecker accepted D28593: Fix copying and moving files to collection.
Apr 11 2020, 11:00 AM · Qt 5 Porting, Amarok
heikobecker accepted D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.
Apr 11 2020, 10:31 AM · Amarok
heikobecker accepted D27949: Conclude porting of Last.fm to Amarok KF5.
Apr 11 2020, 10:04 AM · Amarok

Apr 10 2020

heikobecker committed R8:d3355f511fe5: Merge branch 'calligra/3.1' (authored by heikobecker).
Merge branch 'calligra/3.1'
Apr 10 2020, 10:30 AM

Apr 9 2020

heikobecker abandoned D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior.

Already done in 3fb633159ca4a1db166d5c54bbc025f71aba1652.

Apr 9 2020, 11:02 AM · Plasma

Apr 7 2020

heikobecker committed R228:fbda048247f0: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:50 PM
heikobecker committed R228:1ac41b6b2913: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 3:49 PM
heikobecker committed R351:9a0cfb378cfc: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:46 PM
heikobecker committed R351:b10791980083: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 3:45 PM
heikobecker committed R350:cca299bbb8cf: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:43 PM
heikobecker committed R350:536102db8cbd: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 3:42 PM
heikobecker committed R340:b79a0fa17095: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:41 PM
heikobecker committed R340:12c8e6b5cf28: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 3:40 PM
heikobecker committed R327:111a22559a63: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:36 PM
heikobecker committed R327:107628d6c4e1: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 3:35 PM
heikobecker committed R332:ef07e5843b65: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:34 PM
heikobecker committed R332:ae8546be8e5e: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 3:31 PM
heikobecker committed R158:4ab68cea04e5: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:28 PM
heikobecker committed R158:8984bf805c0d: Fix build with Qt 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt 5.15.0-beta3
Apr 7 2020, 3:25 PM
heikobecker committed R418:604982765811: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 11:35 AM
heikobecker committed R418:4ae7ae8f7816: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 11:33 AM
heikobecker committed R409:39cd6c055b40: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 11:11 AM
heikobecker committed R409:9034ef5c9ec3: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 11:10 AM
heikobecker committed R407:f47ec4da092b: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 11:03 AM
heikobecker committed R407:2b063917bb18: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 11:02 AM
heikobecker committed R405:affac9391323: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 10:57 AM
heikobecker committed R405:4fecfa1a9fc3: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 10:55 AM
heikobecker committed R425:eff035f85152: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 10:04 AM
heikobecker committed R425:bead1e9613eb: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 10:04 AM
heikobecker committed R81:e072f35a8fcd: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 9:34 AM
heikobecker committed R81:f74b0816350d: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 9:23 AM
heikobecker committed R199:6904a9947c6b: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 8:39 AM
heikobecker committed R199:423cc560303d: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 8:37 AM
heikobecker committed R168:c58f5da9ba7f: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 7:18 AM
heikobecker committed R168:b0fd83ba70de: Qt 5.15 undeprecated QComboBox::currentIndexChanged(int) (authored by dfaure).
Qt 5.15 undeprecated QComboBox::currentIndexChanged(int)
Apr 7 2020, 7:17 AM

Apr 6 2020

heikobecker committed R210:75772e32a1c6: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 6 2020, 11:08 PM
heikobecker committed R210:cc87c7fca52d: Fix building against Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix building against Qt >= 5.15.0-beta3
Apr 6 2020, 11:04 PM
heikobecker added a reverting change for R210:990e4bedbdb6: Make it compile against last qt5.15 without deprecated method: R210:cc87c7fca52d: Fix building against Qt >= 5.15.0-beta3.
Apr 6 2020, 11:04 PM
heikobecker committed R318:180b7cb376d8: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 6 2020, 9:13 PM
heikobecker committed R493:c8fcf6d722fe: Use auto (authored by heikobecker).
Use auto
Apr 6 2020, 8:51 PM
heikobecker committed R493:3526da6b5fb5: Use nullptr (authored by heikobecker).
Use nullptr
Apr 6 2020, 8:51 PM
heikobecker committed R493:01552627b3ed: Don't use deprecated headers (authored by heikobecker).
Don't use deprecated headers
Apr 6 2020, 8:51 PM
heikobecker committed R493:4feaa5df1dc8: Use override (authored by heikobecker).
Use override
Apr 6 2020, 8:51 PM
heikobecker committed R493:0319e6d4c13b: clang-format everything (authored by heikobecker).
clang-format everything
Apr 6 2020, 8:51 PM
heikobecker committed R493:0d9ce3ddabeb: Fix running devicestest after requiring >= ECM 5.38 (authored by heikobecker).
Fix running devicestest after requiring >= ECM 5.38
Apr 6 2020, 8:51 PM
heikobecker committed R493:a5f5bb8f451e: Remove X-DCOP-Service* entries from desktop file (authored by heikobecker).
Remove X-DCOP-Service* entries from desktop file
Apr 6 2020, 8:51 PM
heikobecker committed R493:ccb26fbd78b6: Add KDEClangFormat (authored by heikobecker).
Add KDEClangFormat
Apr 6 2020, 8:51 PM
heikobecker committed R493:bccba84363c5: build: Use project() to set the version (authored by heikobecker).
build: Use project() to set the version
Apr 6 2020, 8:51 PM
heikobecker committed R493:dfde5ad479ca: Set StartupWMClass in desktop file (authored by heikobecker).
Set StartupWMClass in desktop file
Apr 6 2020, 8:51 PM
heikobecker committed R493:7a6306e3f6a6: Install desktop file with exec flag (authored by heikobecker).
Install desktop file with exec flag
Apr 6 2020, 8:51 PM
heikobecker committed R493:73a2ca971c38: Use URLs with transport encryption (authored by heikobecker).
Use URLs with transport encryption
Apr 6 2020, 8:51 PM
heikobecker committed R493:49947b387f81: Use single quotes (authored by heikobecker).
Use single quotes
Apr 6 2020, 8:51 PM
heikobecker committed R318:d868568d81c7: Revert "Port deprecated signal (qt5.15)" (authored by apol).
Revert "Port deprecated signal (qt5.15)"
Apr 6 2020, 8:39 PM
heikobecker added a reverting change for R318:e545efee73a8: Port deprecated signal (qt5.15): R318:d868568d81c7: Revert "Port deprecated signal (qt5.15)".
Apr 6 2020, 8:39 PM

Apr 4 2020

heikobecker abandoned D28257: Defuse pontential future build errors.

Obsoleted by aab5b8808ba163552f0fac1a4992b167028863f3

Apr 4 2020, 9:30 PM

Mar 30 2020

heikobecker committed R875:c9aad1ec0a68: Merge remote-tracking branch 'origin/Falkon/3.1' (authored by heikobecker).
Merge remote-tracking branch 'origin/Falkon/3.1'
Mar 30 2020, 8:29 PM