heikobecker (Heiko Becker)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 13 2015, 7:20 PM (165 w, 3 d)
Availability
Available

Recent Activity

Mon, Aug 6

heikobecker committed R79:8351d76b75b1: Merge remote-tracking branch 'origin/Applications/18.08' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.08'
Mon, Aug 6, 9:18 PM
heikobecker committed R79:30b19d68d0c9: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Use QTEST_GUILESS_MAIN
Mon, Aug 6, 9:02 PM

Sun, Aug 5

heikobecker committed R235:3a82a775b1c3: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Use QTEST_GUILESS_MAIN
Sun, Aug 5, 5:59 PM
heikobecker closed D14008: Use QTEST_GUILESS_MAIN.
Sun, Aug 5, 5:59 PM · Frameworks
heikobecker added a comment to D14008: Use QTEST_GUILESS_MAIN.

Ping?

Sun, Aug 5, 9:20 AM · Frameworks

Wed, Aug 1

heikobecker committed R40:5aecab0cfeaa: Merge remote-tracking branch 'origin/Applications/18.08' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.08'
Wed, Aug 1, 7:52 PM
heikobecker committed R40:7a6e7342ef5a: Honor BUILD_TESTING (authored by heikobecker).
Honor BUILD_TESTING
Wed, Aug 1, 7:49 PM
heikobecker closed D14538: Honor BUILD_TESTING.
Wed, Aug 1, 7:49 PM · Kate
heikobecker committed R240:59b311bcc2ed: ECMOptionalAddSubdirectory: Provide a bit more detail (authored by heikobecker).
ECMOptionalAddSubdirectory: Provide a bit more detail
Wed, Aug 1, 7:01 PM
heikobecker closed D14541: ECMOptionalAddSubdirectory: Provide a bit more detail.
Wed, Aug 1, 7:01 PM · Build System, Frameworks
heikobecker requested review of D14541: ECMOptionalAddSubdirectory: Provide a bit more detail.
Wed, Aug 1, 6:01 PM · Build System, Frameworks
heikobecker requested review of D14539: Vt102EmulationTest: Use QTEST_GUILESS_MAIN.
Wed, Aug 1, 4:30 PM · Konsole
heikobecker requested review of D14538: Honor BUILD_TESTING.
Wed, Aug 1, 4:29 PM · Kate

Jul 15 2018

heikobecker committed R451:ff29ae09e6f6: Merge branch 'Applications/18.04' (authored by heikobecker).
Merge branch 'Applications/18.04'
Jul 15 2018, 1:55 PM
heikobecker committed R451:5869a5b294b0: Add .arcconfig (authored by heikobecker).
Add .arcconfig
Jul 15 2018, 1:50 PM
heikobecker committed R451:ef548842fac7: Find KF5I18n in the top-level CMakeLists.txt (authored by heikobecker).
Find KF5I18n in the top-level CMakeLists.txt
Jul 15 2018, 1:50 PM
heikobecker closed D14066: Find KF5I18n in the top-level CMakeLists.txt.
Jul 15 2018, 1:50 PM

Jul 12 2018

heikobecker requested review of D14066: Find KF5I18n in the top-level CMakeLists.txt.
Jul 12 2018, 8:34 AM

Jul 9 2018

heikobecker requested review of D14008: Use QTEST_GUILESS_MAIN.
Jul 9 2018, 3:52 PM · Frameworks
heikobecker added a comment to D12872: ScalableTest, add "scalable" plasma-browser-integration.

Btw, this is BUG: 393999

Jul 9 2018, 9:41 AM · Frameworks

Jul 7 2018

heikobecker committed R34:6ac5d9d01838: Merge remote-tracking branch 'origin/Applications/18.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.04'
Jul 7 2018, 2:28 PM
heikobecker committed R34:4c3740819af0: Fix build of tour-preview example (authored by heikobecker).
Fix build of tour-preview example
Jul 7 2018, 2:27 PM
heikobecker closed D12885: Fix build of tour-preview example.
Jul 7 2018, 2:27 PM · KDE Edu, Marble

Jun 29 2018

heikobecker committed R364:8861e0bc3a75: Remove outdated Qt definitions (authored by heikobecker).
Remove outdated Qt definitions
Jun 29 2018, 5:02 PM
heikobecker committed R364:f85d8407b980: Require at least Qt 5.4.0 (authored by heikobecker).
Require at least Qt 5.4.0
Jun 29 2018, 12:12 PM

Jun 24 2018

heikobecker accepted D13631: Add metadata extraction plugin for ODF files.
Jun 24 2018, 8:00 PM

Jun 21 2018

heikobecker accepted D13661: Random improvements, commit just for review.

All changes look fine to me.

Jun 21 2018, 7:11 PM
heikobecker added a comment to D13631: Add metadata extraction plugin for ODF files.

I would have clang-tidy & Co handy to do some simple common modernization, if you like (done already a few time elsewhere this year). Just tell me "Go" and I would run nullptr & override at least and commit to master (after manual check) :)

Jun 21 2018, 6:36 AM

Jun 20 2018

heikobecker added a comment to D13631: Add metadata extraction plugin for ODF files.

Cool idea and patch!

Jun 20 2018, 6:43 PM
heikobecker committed R758:11abc9b6877f: Close the app if the progress dialog is closed (authored by heikobecker).
Close the app if the progress dialog is closed
Jun 20 2018, 3:32 PM

Jun 7 2018

heikobecker committed R249:918e304f057b: KF5I18NMacros: Don't install an empty dir when no po files exist (authored by heikobecker).
KF5I18NMacros: Don't install an empty dir when no po files exist
Jun 7 2018, 3:34 PM
heikobecker closed D12905: KF5I18NMacros: Don't install an empty dir when no po files exist.
Jun 7 2018, 3:34 PM · Frameworks
heikobecker added a comment to D12885: Fix build of tour-preview example.

Ping?

Jun 7 2018, 12:40 PM · KDE Edu, Marble
heikobecker added a comment to D12905: KF5I18NMacros: Don't install an empty dir when no po files exist.

Considering the feedback I'll probably merge this in a few days if no objections turn up in the meantime.

Jun 7 2018, 12:38 PM · Frameworks
heikobecker accepted D13180: Switch to the Attica framework.
Jun 7 2018, 7:10 AM

May 29 2018

heikobecker closed T8163: Please add dependencies for amarok as Resolved.

All there for Linux and FreeBSD. Windows is postponed until amarok doesn't need mysqle anymore.

May 29 2018, 9:49 AM · build.kde.org, Windows, FreeBSD

May 23 2018

heikobecker accepted D13044: Fix build/test on FreeBSD.

Thanks!

May 23 2018, 10:16 AM

May 21 2018

heikobecker committed R838:3c04c430bd85: Merge branch 'Plasma/5.13' (authored by heikobecker).
Merge branch 'Plasma/5.13'
May 21 2018, 8:30 PM
heikobecker committed R838:659ae5f5981c: Check cmake <foo>_FOUND variables for existance (authored by heikobecker).
Check cmake <foo>_FOUND variables for existance
May 21 2018, 8:29 PM
heikobecker closed D12976: Check cmake <foo>_FOUND variables for existance.
May 21 2018, 8:29 PM · Plasma

May 19 2018

heikobecker added reviewers for D12976: Check cmake <foo>_FOUND variables for existance: Plasma, jgrulich.
May 19 2018, 9:18 AM · Plasma
heikobecker requested review of D12976: Check cmake <foo>_FOUND variables for existance.
May 19 2018, 8:08 AM · Plasma

May 15 2018

heikobecker abandoned D12118: Only install translations if they are available.
May 15 2018, 7:31 PM · Plasma
heikobecker added a comment to D12118: Only install translations if they are available.

I'd argue that ki18n_install should be fixed instead. It does not make sense to duplicate the if check for every call to ki18n_install.

May 15 2018, 7:30 PM · Plasma
heikobecker requested review of D12905: KF5I18NMacros: Don't install an empty dir when no po files exist.
May 15 2018, 7:28 PM · Frameworks
heikobecker added a comment to D12118: Only install translations if they are available.

This change should not be needed; ki18n_install is a noop operation if the directory does not exist - did you see any issue?

May 15 2018, 4:35 PM · Plasma
heikobecker added a comment to D12118: Only install translations if they are available.

Ping?

May 15 2018, 3:37 PM · Plasma
heikobecker requested review of D12885: Fix build of tour-preview example.
May 15 2018, 12:53 AM · KDE Edu, Marble

May 4 2018

heikobecker committed R181:bcf17d0c63d2: Use cmake_{push,pop}_check_state instead of manually resetting (authored by heikobecker).
Use cmake_{push,pop}_check_state instead of manually resetting
May 4 2018, 9:25 PM

May 2 2018

heikobecker closed D11887: No need to enable CMAKE_AUTOMOC manually.

Committed with 91102eee99a1e77f4671d3c1a19dcc203c64c7a3 but apparently I managed to remove the "Differential Revision" line, sorry.

May 2 2018, 6:25 AM · KDE PIM
heikobecker closed D11886: pkpassextractortest: Use QTEST_GUILESS_MAIN.
May 2 2018, 6:24 AM · KDE PIM
heikobecker added a comment to D11886: pkpassextractortest: Use QTEST_GUILESS_MAIN.

Committed with 09501ab26c4ec6e5608ba2c57c5e3bcdf0f35ab4 but apparently I managed to remove the "Differential Revision" line, sorry.

May 2 2018, 6:24 AM · KDE PIM

Apr 21 2018

heikobecker committed R758:6915c2c8cc52: Merge remote-tracking branch 'origin/5.0' (authored by heikobecker).
Merge remote-tracking branch 'origin/5.0'
Apr 21 2018, 5:04 PM
heikobecker committed R758:b504453bc294: Increase version to 5.0.1 (authored by heikobecker).
Increase version to 5.0.1
Apr 21 2018, 5:03 PM
heikobecker committed R758:d9f23bd5dc9e: Escape/unescape filenames with special characters (authored by heikobecker).
Escape/unescape filenames with special characters
Apr 21 2018, 4:39 PM
heikobecker committed R758:ee2686777b5a: Use multi .arg() instead of chaining them (authored by heikobecker).
Use multi .arg() instead of chaining them
Apr 21 2018, 4:39 PM
heikobecker committed R758:7978b6471ddb: Remove unused variable (authored by heikobecker).
Remove unused variable
Apr 21 2018, 4:39 PM
heikobecker added inline comments to D12342: Update CMakeLists.txt.
Apr 21 2018, 2:20 PM · Baloo

Apr 20 2018

heikobecker added a comment to D12374: libzipplugin: Add missing <memory> header.

I was able to reproduce the build failure now with Qt-5.9.5, but not on my other system with Qt-5.11.0_beta4...

Apr 20 2018, 9:16 PM · Ark

Apr 16 2018

heikobecker added a comment to D12216: Don't need to run previous iterations commands again.
In D12216#247225, @apol wrote:

I'm unsure if it's worth re-spinning ki18n.

Apr 16 2018, 12:09 PM · Frameworks
heikobecker committed R317:03d503362514: Also make installation of translated docs optional (authored by heikobecker).
Also make installation of translated docs optional
Apr 16 2018, 11:53 AM
heikobecker closed D12225: Also make installation of translated docs optional.
Apr 16 2018, 11:53 AM · Frameworks

Apr 15 2018

heikobecker requested review of D12225: Also make installation of translated docs optional.
Apr 15 2018, 2:39 PM · Frameworks

Apr 12 2018

heikobecker committed R224:4a4e8216aa68: Use OPTIONAL_COMPONENTS to search for KF5Wayland and DocTools (authored by heikobecker).
Use OPTIONAL_COMPONENTS to search for KF5Wayland and DocTools
Apr 12 2018, 10:37 AM
heikobecker closed D12141: Use OPTIONAL_COMPONENTS to search for KF5Wayland and DocTools.
Apr 12 2018, 10:37 AM · KDE Connect
heikobecker updated the diff for D12141: Use OPTIONAL_COMPONENTS to search for KF5Wayland and DocTools.

Combined the two find_package(KF5...) calls as suggested.

Apr 12 2018, 10:28 AM · KDE Connect
heikobecker requested review of D12141: Use OPTIONAL_COMPONENTS to search for KF5Wayland and DocTools.
Apr 12 2018, 9:03 AM · KDE Connect

Apr 11 2018

heikobecker requested review of D12118: Only install translations if they are available.
Apr 11 2018, 4:04 PM · Plasma
heikobecker committed R181:5886d821cb64: Try to fix the build for FreeBSD another way (authored by heikobecker).
Try to fix the build for FreeBSD another way
Apr 11 2018, 5:50 AM

Apr 10 2018

heikobecker committed R181:caf0094076b8: Remove bogus statement (authored by heikobecker).
Remove bogus statement
Apr 10 2018, 11:04 PM
heikobecker committed R181:bf2095f976e6: Don't concatenate two cmake variables to a list (authored by heikobecker).
Don't concatenate two cmake variables to a list
Apr 10 2018, 10:38 PM
heikobecker committed R181:9aa691be4a84: Strip whitespace (authored by heikobecker).
Strip whitespace
Apr 10 2018, 10:03 PM
heikobecker committed R181:cc4a0d3da87c: Fix build on FreeBSD (authored by heikobecker).
Fix build on FreeBSD
Apr 10 2018, 9:56 PM
heikobecker committed R181:64b4ea5b7334: Require at least libmygpo-qt 1.1.0 (authored by heikobecker).
Require at least libmygpo-qt 1.1.0
Apr 10 2018, 9:56 PM
heikobecker committed R181:4ff8151b21d4: Don't use {QList,QMap}::operator[] (authored by heikobecker).
Don't use {QList,QMap}::operator[]
Apr 10 2018, 9:56 PM

Apr 4 2018

heikobecker committed R1003:91102eee99a1: No need to enable CMAKE_AUTOMOC manually (authored by heikobecker).
No need to enable CMAKE_AUTOMOC manually
Apr 4 2018, 10:23 AM
heikobecker committed R1003:09501ab26c4e: pkpassextractortest: Use QTEST_GUILESS_MAIN (authored by heikobecker).
pkpassextractortest: Use QTEST_GUILESS_MAIN
Apr 4 2018, 10:23 AM
heikobecker committed R991:098e71af8d33: No need to enable CMAKE_AUTOMOC manually (authored by heikobecker).
No need to enable CMAKE_AUTOMOC manually
Apr 4 2018, 10:22 AM
heikobecker closed D11885: No need to enable CMAKE_AUTOMOC manually.
Apr 4 2018, 10:22 AM · KDE PIM

Apr 2 2018

heikobecker committed R1003:52ad5e6b5415: Add .arconfig (authored by heikobecker).
Add .arconfig
Apr 2 2018, 5:01 PM
heikobecker requested review of D11887: No need to enable CMAKE_AUTOMOC manually.
Apr 2 2018, 4:59 PM · KDE PIM
heikobecker requested review of D11886: pkpassextractortest: Use QTEST_GUILESS_MAIN.
Apr 2 2018, 4:58 PM · KDE PIM
heikobecker requested review of D11885: No need to enable CMAKE_AUTOMOC manually.
Apr 2 2018, 4:57 PM · KDE PIM

Mar 28 2018

heikobecker committed R199:f85330f0b45f: Merge remote-tracking branch 'origin/Applications/18.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.04'
Mar 28 2018, 9:03 PM
heikobecker committed R199:976367d30612: No need to set AKONADI_MIMELIB_VERSION anymore (authored by heikobecker).
No need to set AKONADI_MIMELIB_VERSION anymore
Mar 28 2018, 9:03 PM
heikobecker committed R459:31a780ef5f91: Merge remote-tracking branch 'origin/Applications/18.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.04'
Mar 28 2018, 8:27 PM
heikobecker committed R459:3f2b9a7ace34: No need to set AKONADI_MIME_VERSION anymore (authored by heikobecker).
No need to set AKONADI_MIME_VERSION anymore
Mar 28 2018, 8:27 PM

Mar 27 2018

heikobecker committed R177:a436d7976b68: Merge remote-tracking branch 'origin/Applications/18.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.04'
Mar 27 2018, 4:35 PM
heikobecker committed R177:1c5c9a2d7c12: Don't add a subdirectory which was removed (authored by heikobecker).
Don't add a subdirectory which was removed
Mar 27 2018, 4:33 PM

Mar 26 2018

heikobecker committed R181:7dc476a2a28a: Workaround for clang bug 23029 (authored by malteveerman).
Workaround for clang bug 23029
Mar 26 2018, 8:11 PM
heikobecker closed D11710: Workaround for clang bug 23029.
Mar 26 2018, 8:11 PM · Amarok
heikobecker accepted D11710: Workaround for clang bug 23029.

Thanks!

Mar 26 2018, 8:11 PM · Amarok

Mar 25 2018

heikobecker added inline comments to D11534: Some small changes and fixes.
Mar 25 2018, 5:58 PM · Amarok
heikobecker committed R474:6fe507ca52e8: Search for runtime components (authored by heikobecker).
Search for runtime components
Mar 25 2018, 5:28 PM
heikobecker closed D11676: Search for runtime components.
Mar 25 2018, 5:28 PM
heikobecker requested review of D11676: Search for runtime components.
Mar 25 2018, 11:19 AM
heikobecker committed R474:8e3bca84c29c: Merge remote-tracking branch 'origin/Applications/18.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.04'
Mar 25 2018, 11:18 AM
heikobecker committed R474:d47c0ec24fb6: Add .arconfig (authored by heikobecker).
Add .arconfig
Mar 25 2018, 11:18 AM
heikobecker added a comment to T8163: Please add dependencies for amarok.

Yes, builds on Suse and FreeBSD properly find it and build successfully.

Mar 25 2018, 7:29 AM · build.kde.org, Windows, FreeBSD

Mar 24 2018

heikobecker committed R758:ef9f0e6675c6: Remove deprecated Encoding=UTF-8 from desktop files (authored by heikobecker).
Remove deprecated Encoding=UTF-8 from desktop files
Mar 24 2018, 2:58 PM