People heikobecker

heikobecker (Heiko Becker)
User

Projects

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 13 2015, 7:20 PM (192 w, 4 d)
Availability
Available

Recent Activity
View All

Wed, Feb 13

heikobecker requested review of D18983: Use the python version found by cmake in build_theme.sh.
Wed, Feb 13, 4:04 PM · Plasma

Mon, Feb 11

heikobecker committed R8:f43cb54c71d7: Use check_symbol_exists instead of check_function_exists (authored by heikobecker).
Use check_symbol_exists instead of check_function_exists
Mon, Feb 11, 12:26 PM
heikobecker closed D18866: Use check_symbol_exists instead of check_function_exists.
Mon, Feb 11, 12:26 PM · Calligra: 3.0

Sun, Feb 10

heikobecker updated the diff for D18866: Use check_symbol_exists instead of check_function_exists.

Added missing "h". Thanks for noticing that.

Sun, Feb 10, 11:20 AM · Calligra: 3.0
heikobecker added a comment to D18866: Use check_symbol_exists instead of check_function_exists.
In D18866#408435, @danders wrote:

What about the other ​check_function_exists, should they also be changed?

Sun, Feb 10, 11:08 AM · Calligra: 3.0
heikobecker updated the diff for D18866: Use check_symbol_exists instead of check_function_exists.

Replaced other check_function_exists invocations

Sun, Feb 10, 11:04 AM · Calligra: 3.0
heikobecker committed R352:eef034d3efbf: Merge remote-tracking branch 'origin/Applications/18.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.12'
Sun, Feb 10, 10:26 AM
heikobecker committed R352:8df422b10b50: Add .arcconfig (authored by heikobecker).
Add .arcconfig
Sun, Feb 10, 10:22 AM
heikobecker committed R352:70fa1a80ce05: Don't include <fstab.h> anymore (authored by heikobecker).
Don't include <fstab.h> anymore
Sun, Feb 10, 10:21 AM
heikobecker closed D18780: Don't include <fstab.h> anymore.
Sun, Feb 10, 10:21 AM

Fri, Feb 8

heikobecker requested review of D18866: Use check_symbol_exists instead of check_function_exists.
Fri, Feb 8, 9:39 PM · Calligra: 3.0

Wed, Feb 6

heikobecker requested review of D18780: Don't include <fstab.h> anymore.
Wed, Feb 6, 8:53 AM

Sat, Feb 2

heikobecker accepted D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION.

Thanks!

Sat, Feb 2, 9:01 PM
heikobecker accepted D18674: Add missing QStandardPaths to fix build.

Yeah, that didn't happen for me as well, but QSP is actually used (line 75).

Sat, Feb 2, 8:49 PM

Fri, Jan 25

heikobecker committed R224:fab782d91c62: Use KAboutData to set information about the daemon (authored by heikobecker).
Use KAboutData to set information about the daemon
Fri, Jan 25, 11:02 PM
heikobecker closed D18542: Use KAboutData to set information about the daemon.
Fri, Jan 25, 11:02 PM · KDE Connect
heikobecker added a comment to D18542: Use KAboutData to set information about the daemon.

Didn't add any copyright information or any author because I just didn't know who to put there.

Fri, Jan 25, 10:03 PM · KDE Connect
heikobecker requested review of D18542: Use KAboutData to set information about the daemon.
Fri, Jan 25, 10:00 PM · KDE Connect

Jan 18 2019

heikobecker committed R115:a629c6257ff5: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.15'
Jan 18 2019, 2:38 PM
heikobecker committed R115:89992d14d696: [build] Search for kirigami as a runtime dependency (authored by heikobecker).
[build] Search for kirigami as a runtime dependency
Jan 18 2019, 2:37 PM
heikobecker closed D18363: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 2:37 PM · Plasma
heikobecker committed R120:27385ba173cf: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.15'
Jan 18 2019, 2:36 PM
heikobecker committed R120:129dfcfd69d6: [build] Search for kirigami as a runtime dependency (authored by heikobecker).
[build] Search for kirigami as a runtime dependency
Jan 18 2019, 2:36 PM
heikobecker closed D18362: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 2:36 PM · Plasma
heikobecker committed R119:9e9ca8828c87: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.15'
Jan 18 2019, 2:34 PM
heikobecker committed R119:779854fa6431: [build] Search for kirigami as a runtime dependency (authored by heikobecker).
[build] Search for kirigami as a runtime dependency
Jan 18 2019, 2:33 PM
heikobecker closed D18360: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 2:33 PM · Plasma
heikobecker committed R116:33a817ebd6d9: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.15'
Jan 18 2019, 1:51 PM
heikobecker committed R116:7793c31e0132: [build] Search for kirigami as a runtime dependency (authored by heikobecker).
[build] Search for kirigami as a runtime dependency
Jan 18 2019, 1:51 PM
heikobecker closed D18364: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:51 PM · Plasma
heikobecker committed R108:ad5700b8123e: Merge remote-tracking branch 'origin/Plasma/5.15' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.15'
Jan 18 2019, 1:50 PM
heikobecker closed D18359: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:49 PM · KWin
heikobecker committed R108:79eeea6b5822: [build] Search for kirigami as a runtime dependency (authored by heikobecker).
[build] Search for kirigami as a runtime dependency
Jan 18 2019, 1:49 PM
heikobecker requested review of D18364: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:27 PM · Plasma
heikobecker requested review of D18363: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:27 PM · Plasma
heikobecker requested review of D18362: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:23 PM · Plasma
heikobecker abandoned D18361: libkworkspace: Allow standalone build.

Sorry, accidentally uploaded.

Jan 18 2019, 1:22 PM · Plasma
heikobecker requested review of D18361: libkworkspace: Allow standalone build.
Jan 18 2019, 1:20 PM · Plasma
heikobecker requested review of D18360: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:20 PM · Plasma
heikobecker requested review of D18359: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 1:15 PM · KWin

Jan 17 2019

heikobecker abandoned D18310: Require breeze >= 5.14.90.

Superseded by 843bc1cc087451d6debd86fb9f21004c4ad1fbc7

Jan 17 2019, 12:28 PM · Plasma
heikobecker added a comment to D18310: Require breeze >= 5.14.90.

Should probably wait until the version in breeze is actually increased to 5.14.90.

Jan 17 2019, 7:57 AM · Plasma
heikobecker added a reviewer for D18310: Require breeze >= 5.14.90: Plasma.
Jan 17 2019, 7:56 AM · Plasma
heikobecker requested review of D18310: Require breeze >= 5.14.90.
Jan 17 2019, 7:56 AM · Plasma
heikobecker added a comment to D18309: don't set python exe to undefined.

+1
I have no cmake < 3.12.0 to test, but the changes are reasonable.

Jan 17 2019, 7:52 AM · Plasma

Jan 12 2019

heikobecker committed R493:9bb62f34878e: Initialize KCrash (authored by heikobecker).
Initialize KCrash
Jan 12 2019, 1:23 PM

Jan 11 2019

heikobecker committed R181:894a685319db: [build] Make KF5 list more read- and diffable (authored by heikobecker).
[build] Make KF5 list more read- and diffable
Jan 11 2019, 3:17 PM
heikobecker committed R181:f296b39c89ed: Migrate data from KDE4 times too (authored by heikobecker).
Migrate data from KDE4 times too
Jan 11 2019, 3:17 PM
heikobecker committed R181:3b750ad144c5: Migrate config files from ~/.${KDEHOME} (authored by heikobecker).
Migrate config files from ~/.${KDEHOME}
Jan 11 2019, 3:17 PM
heikobecker committed R181:7281ee31d844: Fix build after 9ab62fb867 (authored by heikobecker).
Fix build after 9ab62fb867
Jan 11 2019, 8:25 AM

Dec 21 2018

heikobecker added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.

no, it is only used in kio internally by klauncher to start io slaves.

Dec 21 2018, 9:52 AM · Frameworks

Dec 19 2018

heikobecker added a comment to D17650: Install kioslave.exe as kioslave5.exe under Windows.
In D17650#379396, @habacker wrote:

I think this is unrelated - this request is to fix an issue with an available package on a distribution, so can anyone accept this ?

Dec 19 2018, 1:01 PM · Frameworks

Dec 18 2018

heikobecker committed R1029:ceec93f6b64b: Add .arcconfig (authored by heikobecker).
Add .arcconfig
Dec 18 2018, 8:50 PM
heikobecker committed R1029:9913f88e53b1: Make libpanes a static library (authored by heikobecker).
Make libpanes a static library
Dec 18 2018, 8:49 PM
heikobecker closed D17633: Make libpanes a static library.
Dec 18 2018, 8:49 PM
heikobecker committed R341:d96b6dc483fe: Merge remote-tracking branch 'origin/Applications/18.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.12'
Dec 18 2018, 6:15 PM
heikobecker committed R341:2c2595222af4: Remove traces of KDE4 from the build system (authored by heikobecker).
Remove traces of KDE4 from the build system
Dec 18 2018, 6:08 PM
heikobecker committed R353:2565091f9d9b: Merge remote-tracking branch 'origin/Applications/18.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.12'
Dec 18 2018, 7:27 AM
heikobecker committed R353:dc4d541aec8d: Fix running the test after requiring ECM 5.46.0 (authored by heikobecker).
Fix running the test after requiring ECM 5.46.0
Dec 18 2018, 7:23 AM
heikobecker closed D17511: Fix running the test after requiring ECM 5.46.0.
Dec 18 2018, 7:23 AM

Dec 17 2018

heikobecker added a comment to D17633: Make libpanes a static library.
In D17633#378595, @svuorela wrote:

Who sets BUILD_SHARED_LIBS ? I don't see anything in this cmake stuff doing it.

Dec 17 2018, 8:37 PM
heikobecker committed R422:8afc4d088c68: Merge remote-tracking branch 'origin/Applications/18.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.12'
Dec 17 2018, 7:12 PM
heikobecker committed R422:a4631ffbd88f: Fix tab order in name dialog (authored by heikobecker).
Fix tab order in name dialog
Dec 17 2018, 7:04 PM

Dec 16 2018

heikobecker updated the test plan for D17633: Make libpanes a static library.
Dec 16 2018, 8:09 PM
heikobecker updated the diff for D17633: Make libpanes a static library.

Removed install line

Dec 16 2018, 8:07 PM
heikobecker updated the diff for D17633: Make libpanes a static library.

Made it a static lib

Dec 16 2018, 8:04 PM
heikobecker added a reviewer for D17633: Make libpanes a static library: svuorela.
Dec 16 2018, 7:42 PM
heikobecker requested review of D17633: Make libpanes a static library.
Dec 16 2018, 7:41 PM

Dec 11 2018

heikobecker requested review of D17511: Fix running the test after requiring ECM 5.46.0.
Dec 11 2018, 8:26 PM

Dec 10 2018

heikobecker committed R305:78a1dcc794f5: Fix build without Phonon (authored by heikobecker).
Fix build without Phonon
Dec 10 2018, 3:39 PM
heikobecker closed D17479: Fix build without phonon.
Dec 10 2018, 3:39 PM · Frameworks
heikobecker requested review of D17479: Fix build without phonon.
Dec 10 2018, 3:15 PM · Frameworks

Nov 27 2018

heikobecker committed R223:442cbfcfee73: Merge remote-tracking branch 'origin/Applications/18.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.12'
Nov 27 2018, 7:46 PM
heikobecker committed R223:140638a0b360: Explicitly import Qt 5.7's QtQuick for Connections.enabled (authored by heikobecker).
Explicitly import Qt 5.7's QtQuick for Connections.enabled
Nov 27 2018, 7:40 PM
heikobecker closed D17196: Explicitly import Qt 5.7's QtQuick for Connections.enabled.
Nov 27 2018, 7:40 PM · Okular
heikobecker requested review of D17196: Explicitly import Qt 5.7's QtQuick for Connections.enabled.
Nov 27 2018, 6:41 PM · Okular
heikobecker closed D17184: Explicitly import Qt 5.7's QtQuick for Connections.enabled.
Nov 27 2018, 2:06 PM · KDE PIM
heikobecker committed R1007:b867de409b04: Explicitly import Qt 5.7's QtQuick for Connections.enabled (authored by heikobecker).
Explicitly import Qt 5.7's QtQuick for Connections.enabled
Nov 27 2018, 2:06 PM
heikobecker requested review of D17184: Explicitly import Qt 5.7's QtQuick for Connections.enabled.
Nov 27 2018, 11:05 AM · KDE PIM

Nov 20 2018

heikobecker committed R345:b2f9810f38c6: Depend on KDE Frameworks 5.41 (authored by heikobecker).
Depend on KDE Frameworks 5.41
Nov 20 2018, 7:31 PM
heikobecker closed D16971: Depend on KDE Frameworks 5.41.
Nov 20 2018, 7:31 PM
heikobecker committed R758:e54a32c89a8e: Fix the previous commits and the build with exiv2<0.27 (authored by heikobecker).
Fix the previous commits and the build with exiv2<0.27
Nov 20 2018, 7:02 PM
heikobecker added inline comments to D16971: Depend on KDE Frameworks 5.41.
Nov 20 2018, 6:57 PM
heikobecker updated the diff for D16971: Depend on KDE Frameworks 5.41.

Additionally raised the Qt requirement

Nov 20 2018, 6:56 PM
heikobecker added a comment to D16971: Depend on KDE Frameworks 5.41.
In D16971#361440, @marten wrote:

The same applies to the included FindPulseAudio module. Will you submit a separate review for that (if you are able to test with PA)?

Nov 20 2018, 6:16 PM
heikobecker updated the diff for D16971: Depend on KDE Frameworks 5.41.

Removed FindPulseAudio.cmake as well

Nov 20 2018, 6:14 PM
heikobecker committed R758:ec90823494f5: Use #cmakedefine01 instead of macro_bool_to_01 (authored by heikobecker).
Use #cmakedefine01 instead of macro_bool_to_01
Nov 20 2018, 5:41 PM
heikobecker committed R758:b22de9135ba2: Fix building against exiv2-0.27 (authored by heikobecker).
Fix building against exiv2-0.27
Nov 20 2018, 5:41 PM

Nov 18 2018

heikobecker added a reviewer for D16971: Depend on KDE Frameworks 5.41: marten.
Nov 18 2018, 10:50 AM
heikobecker requested review of D16971: Depend on KDE Frameworks 5.41.
Nov 18 2018, 10:33 AM

Oct 29 2018

heikobecker committed R181:1049bef08812: Do not reset equalizer on clicking cancel if equalizer toggle is off. (authored by elbinp).
Do not reset equalizer on clicking cancel if equalizer toggle is off.
Oct 29 2018, 8:19 AM
heikobecker closed D16422: Do not reset equalizer on clicking cancel if equalizer toggle is off..
Oct 29 2018, 8:19 AM
heikobecker added a comment to D16422: Do not reset equalizer on clicking cancel if equalizer toggle is off..

I can push it for you, but I need your email address.

Oct 29 2018, 7:42 AM

Oct 28 2018

heikobecker accepted D16422: Do not reset equalizer on clicking cancel if equalizer toggle is off..

Thanks!

Oct 28 2018, 10:56 PM

Oct 13 2018

heikobecker accepted D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication.

I can confirm that the crash doesn't occur anymore.

Oct 13 2018, 8:32 PM · Frameworks

Oct 12 2018

heikobecker committed R425:07f3ab2b70ba: Silence CMake policy CMP0063 warning (authored by heikobecker).
Silence CMake policy CMP0063 warning
Oct 12 2018, 8:35 PM

Sep 28 2018

heikobecker committed R181:67c651bc6074: Initialize KCrash (authored by heikobecker).
Initialize KCrash
Sep 28 2018, 4:23 PM
heikobecker committed R181:217b33c7eadf: Increment version (authored by heikobecker).
Increment version
Sep 28 2018, 4:22 PM
heikobecker accepted D15810: Fix a typo in FindMySQL.cmake and add leniency for libmysqld on windows.

Thanks!

Sep 28 2018, 11:33 AM

Sep 8 2018

heikobecker added a comment to D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE.
In D15251#322168, @kossebau wrote:

...as well as request to finally enable BUILD_QCH on CI, so this is covered.

Sep 8 2018, 10:34 AM · Frameworks