heikobecker (Heiko Becker)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 13 2015, 7:20 PM (182 w, 3 d)
Availability
Available

Recent Activity

Yesterday

heikobecker requested review of D17511: Fix running the test after requiring ECM 5.46.0.
Tue, Dec 11, 8:26 PM

Mon, Dec 10

heikobecker committed R305:78a1dcc794f5: Fix build without Phonon (authored by heikobecker).
Fix build without Phonon
Mon, Dec 10, 3:39 PM
heikobecker closed D17479: Fix build without phonon.
Mon, Dec 10, 3:39 PM · Frameworks
heikobecker requested review of D17479: Fix build without phonon.
Mon, Dec 10, 3:15 PM · Frameworks

Tue, Nov 27

heikobecker committed R223:442cbfcfee73: Merge remote-tracking branch 'origin/Applications/18.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.12'
Tue, Nov 27, 7:46 PM
heikobecker committed R223:140638a0b360: Explicitly import Qt 5.7's QtQuick for Connections.enabled (authored by heikobecker).
Explicitly import Qt 5.7's QtQuick for Connections.enabled
Tue, Nov 27, 7:40 PM
heikobecker closed D17196: Explicitly import Qt 5.7's QtQuick for Connections.enabled.
Tue, Nov 27, 7:40 PM · Okular
heikobecker requested review of D17196: Explicitly import Qt 5.7's QtQuick for Connections.enabled.
Tue, Nov 27, 6:41 PM · Okular
heikobecker closed D17184: Explicitly import Qt 5.7's QtQuick for Connections.enabled.
Tue, Nov 27, 2:06 PM · KDE PIM
heikobecker committed R1007:b867de409b04: Explicitly import Qt 5.7's QtQuick for Connections.enabled (authored by heikobecker).
Explicitly import Qt 5.7's QtQuick for Connections.enabled
Tue, Nov 27, 2:06 PM
heikobecker requested review of D17184: Explicitly import Qt 5.7's QtQuick for Connections.enabled.
Tue, Nov 27, 11:05 AM · KDE PIM

Tue, Nov 20

heikobecker committed R345:b2f9810f38c6: Depend on KDE Frameworks 5.41 (authored by heikobecker).
Depend on KDE Frameworks 5.41
Tue, Nov 20, 7:31 PM
heikobecker closed D16971: Depend on KDE Frameworks 5.41.
Tue, Nov 20, 7:31 PM
heikobecker committed R758:e54a32c89a8e: Fix the previous commits and the build with exiv2<0.27 (authored by heikobecker).
Fix the previous commits and the build with exiv2<0.27
Tue, Nov 20, 7:02 PM
heikobecker added inline comments to D16971: Depend on KDE Frameworks 5.41.
Tue, Nov 20, 6:57 PM
heikobecker updated the diff for D16971: Depend on KDE Frameworks 5.41.

Additionally raised the Qt requirement

Tue, Nov 20, 6:56 PM
heikobecker added a comment to D16971: Depend on KDE Frameworks 5.41.

The same applies to the included FindPulseAudio module. Will you submit a separate review for that (if you are able to test with PA)?

Tue, Nov 20, 6:16 PM
heikobecker updated the diff for D16971: Depend on KDE Frameworks 5.41.

Removed FindPulseAudio.cmake as well

Tue, Nov 20, 6:14 PM
heikobecker committed R758:ec90823494f5: Use #cmakedefine01 instead of macro_bool_to_01 (authored by heikobecker).
Use #cmakedefine01 instead of macro_bool_to_01
Tue, Nov 20, 5:41 PM
heikobecker committed R758:b22de9135ba2: Fix building against exiv2-0.27 (authored by heikobecker).
Fix building against exiv2-0.27
Tue, Nov 20, 5:41 PM

Sun, Nov 18

heikobecker added a reviewer for D16971: Depend on KDE Frameworks 5.41: marten.
Sun, Nov 18, 10:50 AM
heikobecker requested review of D16971: Depend on KDE Frameworks 5.41.
Sun, Nov 18, 10:33 AM

Oct 29 2018

heikobecker committed R181:1049bef08812: Do not reset equalizer on clicking cancel if equalizer toggle is off. (authored by elbinp).
Do not reset equalizer on clicking cancel if equalizer toggle is off.
Oct 29 2018, 8:19 AM
heikobecker closed D16422: Do not reset equalizer on clicking cancel if equalizer toggle is off..
Oct 29 2018, 8:19 AM
heikobecker added a comment to D16422: Do not reset equalizer on clicking cancel if equalizer toggle is off..

I can push it for you, but I need your email address.

Oct 29 2018, 7:42 AM

Oct 28 2018

heikobecker accepted D16422: Do not reset equalizer on clicking cancel if equalizer toggle is off..

Thanks!

Oct 28 2018, 10:56 PM

Oct 13 2018

heikobecker accepted D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication.

I can confirm that the crash doesn't occur anymore.

Oct 13 2018, 8:32 PM · Frameworks

Oct 12 2018

heikobecker committed R425:07f3ab2b70ba: Silence CMake policy CMP0063 warning (authored by heikobecker).
Silence CMake policy CMP0063 warning
Oct 12 2018, 8:35 PM

Sep 28 2018

heikobecker committed R181:67c651bc6074: Initialize KCrash (authored by heikobecker).
Initialize KCrash
Sep 28 2018, 4:23 PM
heikobecker committed R181:217b33c7eadf: Increment version (authored by heikobecker).
Increment version
Sep 28 2018, 4:22 PM
heikobecker accepted D15810: Fix a typo in FindMySQL.cmake and add leniency for libmysqld on windows.

Thanks!

Sep 28 2018, 11:33 AM

Sep 8 2018

heikobecker added a comment to D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE.

...as well as request to finally enable BUILD_QCH on CI, so this is covered.

Sep 8 2018, 10:34 AM · Frameworks
heikobecker committed R249:7b2936a6d673: Fix autotests with -DBUILD_QCH:BOOL=TRUE (authored by heikobecker).
Fix autotests with -DBUILD_QCH:BOOL=TRUE
Sep 8 2018, 10:33 AM
heikobecker closed D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE.
Sep 8 2018, 10:33 AM · Frameworks
heikobecker added reviewers for D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE: kossebau, habacker.
Sep 8 2018, 9:28 AM · Frameworks

Sep 4 2018

heikobecker committed R358:243ec05e57be: Merge remote-tracking branch 'origin/Applications/18.08' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.08'
Sep 4 2018, 8:37 PM
heikobecker committed R358:eb5ab0a89533: Add .arcconfig (authored by heikobecker).
Add .arcconfig
Sep 4 2018, 8:37 PM
heikobecker committed R358:39cf5dc730e4: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Use QTEST_GUILESS_MAIN
Sep 4 2018, 8:35 PM
heikobecker closed D14886: Use QTEST_GUILESS_MAIN.
Sep 4 2018, 8:35 PM
heikobecker added a comment to D14886: Use QTEST_GUILESS_MAIN.

Ping?

Sep 4 2018, 7:10 PM

Sep 3 2018

heikobecker requested review of D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE.
Sep 3 2018, 6:57 PM · Frameworks

Aug 25 2018

heikobecker closed T688: Sweeper Qt5/KF5 port as Resolved.

Indeed! Thanks for the reminder.

Aug 25 2018, 4:59 PM · Qt 5 Porting

Aug 16 2018

heikobecker requested review of D14886: Use QTEST_GUILESS_MAIN.
Aug 16 2018, 4:04 PM
heikobecker committed R1003:f5b89bc4a0ad: Merge remote-tracking branch 'origin/Applications/18.08' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.08'
Aug 16 2018, 3:51 PM
heikobecker closed D14884: Make the pdfdocumenttest pass without Poppler.
Aug 16 2018, 3:50 PM · KDE PIM
heikobecker committed R1003:7af8526819ec: Make the pdfdocumenttest pass without Poppler (authored by heikobecker).
Make the pdfdocumenttest pass without Poppler
Aug 16 2018, 3:50 PM
heikobecker updated the summary of D14884: Make the pdfdocumenttest pass without Poppler.
Aug 16 2018, 3:37 PM · KDE PIM
heikobecker updated the diff for D14884: Make the pdfdocumenttest pass without Poppler.

Remove unrelated commit

Aug 16 2018, 3:37 PM · KDE PIM
heikobecker requested review of D14884: Make the pdfdocumenttest pass without Poppler.
Aug 16 2018, 3:34 PM · KDE PIM

Aug 6 2018

heikobecker committed R79:8351d76b75b1: Merge remote-tracking branch 'origin/Applications/18.08' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.08'
Aug 6 2018, 9:18 PM
heikobecker committed R79:30b19d68d0c9: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Use QTEST_GUILESS_MAIN
Aug 6 2018, 9:02 PM

Aug 5 2018

heikobecker committed R235:3a82a775b1c3: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Use QTEST_GUILESS_MAIN
Aug 5 2018, 5:59 PM
heikobecker closed D14008: Use QTEST_GUILESS_MAIN.
Aug 5 2018, 5:59 PM · Frameworks
heikobecker added a comment to D14008: Use QTEST_GUILESS_MAIN.

Ping?

Aug 5 2018, 9:20 AM · Frameworks

Aug 1 2018

heikobecker committed R40:5aecab0cfeaa: Merge remote-tracking branch 'origin/Applications/18.08' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.08'
Aug 1 2018, 7:52 PM
heikobecker committed R40:7a6e7342ef5a: Honor BUILD_TESTING (authored by heikobecker).
Honor BUILD_TESTING
Aug 1 2018, 7:49 PM
heikobecker closed D14538: Honor BUILD_TESTING.
Aug 1 2018, 7:49 PM · Kate
heikobecker committed R240:59b311bcc2ed: ECMOptionalAddSubdirectory: Provide a bit more detail (authored by heikobecker).
ECMOptionalAddSubdirectory: Provide a bit more detail
Aug 1 2018, 7:01 PM
heikobecker closed D14541: ECMOptionalAddSubdirectory: Provide a bit more detail.
Aug 1 2018, 7:01 PM · Build System, Frameworks
heikobecker requested review of D14541: ECMOptionalAddSubdirectory: Provide a bit more detail.
Aug 1 2018, 6:01 PM · Build System, Frameworks
heikobecker requested review of D14539: Vt102EmulationTest: Use QTEST_GUILESS_MAIN.
Aug 1 2018, 4:30 PM · Konsole
heikobecker requested review of D14538: Honor BUILD_TESTING.
Aug 1 2018, 4:29 PM · Kate

Jul 15 2018

heikobecker committed R451:ff29ae09e6f6: Merge branch 'Applications/18.04' (authored by heikobecker).
Merge branch 'Applications/18.04'
Jul 15 2018, 1:55 PM
heikobecker committed R451:5869a5b294b0: Add .arcconfig (authored by heikobecker).
Add .arcconfig
Jul 15 2018, 1:50 PM
heikobecker committed R451:ef548842fac7: Find KF5I18n in the top-level CMakeLists.txt (authored by heikobecker).
Find KF5I18n in the top-level CMakeLists.txt
Jul 15 2018, 1:50 PM
heikobecker closed D14066: Find KF5I18n in the top-level CMakeLists.txt.
Jul 15 2018, 1:50 PM

Jul 12 2018

heikobecker requested review of D14066: Find KF5I18n in the top-level CMakeLists.txt.
Jul 12 2018, 8:34 AM

Jul 9 2018

heikobecker requested review of D14008: Use QTEST_GUILESS_MAIN.
Jul 9 2018, 3:52 PM · Frameworks
heikobecker added a comment to D12872: ScalableTest, add "scalable" plasma-browser-integration.

Btw, this is BUG: 393999

Jul 9 2018, 9:41 AM · Frameworks

Jul 7 2018

heikobecker committed R34:6ac5d9d01838: Merge remote-tracking branch 'origin/Applications/18.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/18.04'
Jul 7 2018, 2:28 PM
heikobecker committed R34:4c3740819af0: Fix build of tour-preview example (authored by heikobecker).
Fix build of tour-preview example
Jul 7 2018, 2:27 PM
heikobecker closed D12885: Fix build of tour-preview example.
Jul 7 2018, 2:27 PM · KDE Edu, Marble

Jun 29 2018

heikobecker committed R364:8861e0bc3a75: Remove outdated Qt definitions (authored by heikobecker).
Remove outdated Qt definitions
Jun 29 2018, 5:02 PM
heikobecker committed R364:f85d8407b980: Require at least Qt 5.4.0 (authored by heikobecker).
Require at least Qt 5.4.0
Jun 29 2018, 12:12 PM

Jun 24 2018

heikobecker accepted D13631: Add metadata extraction plugin for ODF files.
Jun 24 2018, 8:00 PM

Jun 21 2018

heikobecker accepted D13661: Random improvements, commit just for review.

All changes look fine to me.

Jun 21 2018, 7:11 PM
heikobecker added a comment to D13631: Add metadata extraction plugin for ODF files.

I would have clang-tidy & Co handy to do some simple common modernization, if you like (done already a few time elsewhere this year). Just tell me "Go" and I would run nullptr & override at least and commit to master (after manual check) :)

Jun 21 2018, 6:36 AM

Jun 20 2018

heikobecker added a comment to D13631: Add metadata extraction plugin for ODF files.

Cool idea and patch!

Jun 20 2018, 6:43 PM
heikobecker committed R758:11abc9b6877f: Close the app if the progress dialog is closed (authored by heikobecker).
Close the app if the progress dialog is closed
Jun 20 2018, 3:32 PM

Jun 7 2018

heikobecker committed R249:918e304f057b: KF5I18NMacros: Don't install an empty dir when no po files exist (authored by heikobecker).
KF5I18NMacros: Don't install an empty dir when no po files exist
Jun 7 2018, 3:34 PM
heikobecker closed D12905: KF5I18NMacros: Don't install an empty dir when no po files exist.
Jun 7 2018, 3:34 PM · Frameworks
heikobecker added a comment to D12885: Fix build of tour-preview example.

Ping?

Jun 7 2018, 12:40 PM · KDE Edu, Marble
heikobecker added a comment to D12905: KF5I18NMacros: Don't install an empty dir when no po files exist.

Considering the feedback I'll probably merge this in a few days if no objections turn up in the meantime.

Jun 7 2018, 12:38 PM · Frameworks
heikobecker accepted D13180: Switch to the Attica framework.
Jun 7 2018, 7:10 AM

May 29 2018

heikobecker closed T8163: Please add dependencies for amarok as Resolved.

All there for Linux and FreeBSD. Windows is postponed until amarok doesn't need mysqle anymore.

May 29 2018, 9:49 AM · build.kde.org, Windows, FreeBSD

May 23 2018

heikobecker accepted D13044: Fix build/test on FreeBSD.

Thanks!

May 23 2018, 10:16 AM

May 21 2018

heikobecker committed R838:3c04c430bd85: Merge branch 'Plasma/5.13' (authored by heikobecker).
Merge branch 'Plasma/5.13'
May 21 2018, 8:30 PM
heikobecker committed R838:659ae5f5981c: Check cmake <foo>_FOUND variables for existance (authored by heikobecker).
Check cmake <foo>_FOUND variables for existance
May 21 2018, 8:29 PM
heikobecker closed D12976: Check cmake <foo>_FOUND variables for existance.
May 21 2018, 8:29 PM · Plasma

May 19 2018

heikobecker added reviewers for D12976: Check cmake <foo>_FOUND variables for existance: Plasma, jgrulich.
May 19 2018, 9:18 AM · Plasma
heikobecker requested review of D12976: Check cmake <foo>_FOUND variables for existance.
May 19 2018, 8:08 AM · Plasma

May 15 2018

heikobecker abandoned D12118: Only install translations if they are available.
May 15 2018, 7:31 PM · Plasma
heikobecker added a comment to D12118: Only install translations if they are available.

I'd argue that ki18n_install should be fixed instead. It does not make sense to duplicate the if check for every call to ki18n_install.

May 15 2018, 7:30 PM · Plasma
heikobecker requested review of D12905: KF5I18NMacros: Don't install an empty dir when no po files exist.
May 15 2018, 7:28 PM · Frameworks
heikobecker added a comment to D12118: Only install translations if they are available.

This change should not be needed; ki18n_install is a noop operation if the directory does not exist - did you see any issue?

May 15 2018, 4:35 PM · Plasma
heikobecker added a comment to D12118: Only install translations if they are available.

Ping?

May 15 2018, 3:37 PM · Plasma
heikobecker requested review of D12885: Fix build of tour-preview example.
May 15 2018, 12:53 AM · KDE Edu, Marble

May 4 2018

heikobecker committed R181:bcf17d0c63d2: Use cmake_{push,pop}_check_state instead of manually resetting (authored by heikobecker).
Use cmake_{push,pop}_check_state instead of manually resetting
May 4 2018, 9:25 PM

May 2 2018

heikobecker closed D11887: No need to enable CMAKE_AUTOMOC manually.

Committed with 91102eee99a1e77f4671d3c1a19dcc203c64c7a3 but apparently I managed to remove the "Differential Revision" line, sorry.

May 2 2018, 6:25 AM · KDE PIM
heikobecker closed D11886: pkpassextractortest: Use QTEST_GUILESS_MAIN.
May 2 2018, 6:24 AM · KDE PIM