- User Since
- Sep 27 2016, 1:59 PM (107 w, 2 d)
Tue, Oct 16
use Gcode enum
Remove unneeded code
Mon, Oct 15
- cleaner functions , added ref use in lambda
please See D16144 and expect to read your bed size from the view3d's bedsize property
fix property typo
remvoe debug line
- finalize (hopefully)
I think we would need to keep the older style menu area as an option as well (I also like #2). needed for thin titlebars, windows without them, users who do not want them in the title bar.
Sun, Oct 14
Some Issues i've fixed unrelated to this but should be landed first.
D16199 and D16200
Then in atcore::processQueue the one call of serialLayer->pushCommand that does not use translate (since that is the no plugin loaded case) needs to have \r\n appended to it. Then this should work correctly
- adjust logWidget documentation
Im not sure how exactly todo that maybe @patrickelectric can help here.
Not sure why but with this patch i get lines cut off and split across a few entries. Im not sure if this is related to auto detect failing for me.
Sat, Oct 13
How do we send commands now before connected to a firmware? M115 has to be sent before any firmware connection, It works on Grbl because were looking for the name. This does seam like progress in the correct direction we just need to smooth out this important case.
- Use int to avoid casts
Can you please "fix" the other plugins with \r\n so this does not break them
- Remove added new line
you store the new dimensions in the Viewer3D here and you replace the implementation of BedProperties so that its instances find their Viewer3D and read the dimensions from there.
Can you modify your patch for this that seams more sane since the 3dView is what the main application interacts with already
Fri, Oct 12
Much Nicer !
Check your Indentation you seam to have moved all your modified lines in a bit.
- remove empty lines
Thu, Oct 11
- Update bed when atcore instance changes size
I got as far as D16144 in connecting these.
Further work will be needed to account for how this will work with more then one machine connected.
Please connect this to the profile data within this commit.
Wed, Oct 10
This Looks Great!
- Target temperature can only be an int.
- Patrick's suggestions
- use std::max correctly
- use std::max