- User Since
- Sep 27 2016, 1:59 PM (73 w, 4 d)
- Patrick's suggestion
Added to T7468
I would suggest we bundle in our icons and use them as fallbacks this way if theme can not be used we get our fallback icon. We can have a dark / light prefix to seperate them like :/icon/dark/connect for instance or use a postfix like -light/-dark :/icon/connect-light . We will need todo this for any out of theme icons we ship anyway So lets just extend it and wrap it in our resource system. Let us Gather our icons.
- Clean up stop , emergencyStop , add stopSdPrint(internal use only)
- Do not attempt to stop sd card print on host disconnect
- Space the cases in gcodecommands a little to its easier to read
Looks good to me. Since patrick wrote this i would be more intrested in his review.
Needs rebase to master.
Wed, Feb 21
We place this item in the system tray by default. This being a place were users expect to be able to at a glance get some quick info about things their system is doing. While media is playing the play icon is what most users would expect to see. I do agree that this needs its own icon and should not reusing the play and pause actions.
I'm a breeze dark user and the current color is just way to strong on this theme as @ngraham said above. It was quite jarring to have this bright line on my window out of nowhere. If we can not find a more muted color then my vote its +1 disable no need to remove it its a low maintance
Tue, Feb 20
- update for new base
Mon, Feb 19
Diff needs to be cleaned of the stuff in master
- Update setting Name for D10648
- personal review