rizzitello (Chris Rizzitello)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 27 2016, 1:59 PM (98 w, 4 d)
Availability
Available

Recent Activity

Today

rizzitello updated the diff for D14136: Basic SD Write Support.
  • rebase
Sat, Aug 18, 6:33 PM · Atelier: AtCore
rizzitello updated the diff for D13576: Allow non reset on connect.
  • rebase
Sat, Aug 18, 6:32 PM · Atelier: AtCore
rizzitello committed R232:560169a6e4fb: - style adjustment (authored by rizzitello).
- style adjustment
Sat, Aug 18, 6:32 PM
rizzitello updated the diff for D14136: Basic SD Write Support.
  • Tomaz suggestions
Sat, Aug 18, 6:29 PM · Atelier: AtCore
rizzitello added inline comments to D14136: Basic SD Write Support.
Sat, Aug 18, 1:56 PM · Atelier: AtCore
rizzitello planned changes to D14136: Basic SD Write Support.

Updated to show progress with this. Its working but not as it crashes on starting the thread. Open to help on this as its been a back burner patch since day one.

Sat, Aug 18, 1:54 PM · Atelier: AtCore
rizzitello updated the diff for D14136: Basic SD Write Support.
  • Add a progress dialog
  • Add a copythread
Sat, Aug 18, 1:52 PM · Atelier: AtCore
rizzitello updated the diff for D13576: Allow non reset on connect.
  • rebase
Sat, Aug 18, 1:29 PM · Atelier: AtCore
rizzitello planned changes to D14136: Basic SD Write Support.

Still plan to add a progress dialog and possibly do the copy in a thread like printing is.

Sat, Aug 18, 1:25 PM · Atelier: AtCore
rizzitello updated the diff for D14136: Basic SD Write Support.
  • rebase
Sat, Aug 18, 1:24 PM · Atelier: AtCore
rizzitello updated the diff for D13576: Allow non reset on connect.
  • rebase
Sat, Aug 18, 1:24 PM · Atelier: AtCore
rizzitello committed R232:2ac7c29dc471: fix potentially bug on accessing global variable on instance of AtCore (authored by leandrosantiago).
fix potentially bug on accessing global variable on instance of AtCore
Sat, Aug 18, 1:22 PM
rizzitello committed R232:ea1061d4c686: fix potentially bug on accessing global variable on instance of AtCore (authored by leandrosantiago).
fix potentially bug on accessing global variable on instance of AtCore
Sat, Aug 18, 1:22 PM
rizzitello closed D14891: fix potentially bug on accessing global variable on instance of AtCore.
Sat, Aug 18, 1:22 PM
rizzitello accepted D14891: fix potentially bug on accessing global variable on instance of AtCore.

Yes, if someone is forcing a int is because he knows what he is doing (or
not).
In either case, if you are using a int as argument the compiler will not
accept.

Great point @patrickelectric, Move called with axis as an int will call the other move function. So that only helps with invalid Enums like AtCore::W and as you pointed out that will just fail to build.

Sat, Aug 18, 12:05 PM
rizzitello added inline comments to D14891: fix potentially bug on accessing global variable on instance of AtCore.
Sat, Aug 18, 11:54 AM
rizzitello requested changes to D14891: fix potentially bug on accessing global variable on instance of AtCore.
Sat, Aug 18, 11:48 AM
rizzitello updated the diff for D13576: Allow non reset on connect.
  • rebase
Sat, Aug 18, 12:16 AM · Atelier: AtCore
rizzitello requested changes to D12456: Enable a notification system.

For the print progress I think we would want to use KJob not a KNotification::event

Sat, Aug 18, 12:07 AM

Yesterday

rizzitello requested changes to D14891: fix potentially bug on accessing global variable on instance of AtCore.
Fri, Aug 17, 11:58 PM
rizzitello added a comment to D14891: fix potentially bug on accessing global variable on instance of AtCore.

For everything that's being said here:
register as QEnum
use the toStirng method?

Fri, Aug 17, 1:11 PM
rizzitello added a comment to D14891: fix potentially bug on accessing global variable on instance of AtCore.
Just imagine someone (like that eccentric rich cousin that everyone has :-)) using atcore to implement a client that is able to print to several printers at the same time. In order to AtCore to be used as a library, it needs to make no (or at least as few as possible) assumptions about how it is used (or at least document that it should not be used to control multiple printers).
Fri, Aug 17, 11:26 AM
rizzitello edited reviewers for D14891: fix potentially bug on accessing global variable on instance of AtCore, added: rizzitello, patrickelectric, laysrodrigues, tcanabrava; removed: Atelier: AtCore, Atelier.
Fri, Aug 17, 1:17 AM
rizzitello added a comment to D12456: Enable a notification system.

I think we should use better titles for the notification because if you look in the notification center they look off with Finshed! or Connected etc when all other notification titles are the name of the application that sent the notification or in the case of kde connect the device where the event happened. ( since we work with multiple devices i think we should use the kde connect title scheme)

Fri, Aug 17, 1:02 AM

Thu, Aug 16

rizzitello added a comment to D14891: fix potentially bug on accessing global variable on instance of AtCore.

It seams that the user would need to be calling this function at the same time on more then one instance. How likely is that to happen? How do you feel about the code below? It removes the need for that variable all together. and removes the default case that will never be called.

void AtCore::move(AtCore::AXES axis, int arg)
{
    switch (axis) {
    case AtCore::X:
        move(QLatin1Char('X'), arg);
        break;
    case AtCore::Y:
        move(QLatin1Char('Y'), arg);
        break;
    case AtCore::Z:
        move(QLatin1Char('Z'), arg);
        break;
    case AtCore::E:
        move(QLatin1Char('E'), arg);
        break;
    };
}
Thu, Aug 16, 9:04 PM
rizzitello added inline comments to D12456: Enable a notification system.
Thu, Aug 16, 8:29 PM
rizzitello requested changes to D12456: Enable a notification system.

I think now we just need to fix up the wording and see if we can do a progress dialog for the print job before landing

Thu, Aug 16, 8:02 PM
rizzitello added a comment to D14869: [RFC] Increase default font sizes by 1 pt.

How does your suggestion relate to both the DPI value of your hardware and what Xorg uses? Do we actually set a higher DPI value for Hi(gher)DPI hardware automatically, so the actual size to the eye is independent of the display in use? If not, why not?

Thu, Aug 16, 11:17 AM · Plasma

Wed, Aug 15

rizzitello added a comment to D14869: [RFC] Increase default font sizes by 1 pt.

The title bar with the bold font looks nice at both sizes.

Wed, Aug 15, 11:13 PM · Plasma
rizzitello requested changes to D12456: Enable a notification system.

i get this warning when i run the program now: Object::connect: No such slot MainWindow::configureNotifications() in /home/chris/Documents/Projects/Code/Kde/atelier/src/mainwindow.cpp:295

Wed, Aug 15, 9:34 PM
rizzitello added a comment to D14869: [RFC] Increase default font sizes by 1 pt.

Honestly if you look at the last before and after shot the text now looks worse then when it was 10 pt. I think the issue is more your hinting then the font size.

Wed, Aug 15, 9:17 PM · Plasma
rizzitello added a comment to D12456: Enable a notification system.

Add info the notifyrc file, because
I though that the lack of info there
wouldnt be a problem.
-> The configuration will only work with the installed
file. We dont have any way to use it as a qrc, as I said
before. Waiting to the guy from KNotification get back to me.

Wed, Aug 15, 10:27 AM
rizzitello added a comment to D14842: Check if file exists - ChooseFileDialog.

After a discussion here at Akademy, @ngraham convinced me to not open more than one file, at least until we have a queue of print jobs.

Wed, Aug 15, 10:25 AM
rizzitello added a comment to D14837: Reset dial on disconnect.

Well, I have seen this on this printer, and I have shown you an evidence, so you are going to block this patch just because you've not seen in other printers?

Wed, Aug 15, 10:24 AM
rizzitello added a comment to D14837: Reset dial on disconnect.

Tomaz printer resets on connection
But we have a garbage memory value, that shows up when I reconnect the printer.
So I do think that delay to reset our controls is a bad behavior.

Wed, Aug 15, 10:18 AM
rizzitello added a comment to D14837: Reset dial on disconnect.

That is a problem because the dial is updated with that memory garbage command, and I think that depending on the printer that can cause issues.
I just rather be safe than sorry.

Wed, Aug 15, 10:13 AM
rizzitello added a comment to D14842: Check if file exists - ChooseFileDialog.

-> Open a File
-> Move file to an another location
->Click to print

 -> If only the moved file is open, nothing happens
-> If is there more than one file open, it shows the moved file at dialog

So yes, moving that before the print command, would be better, but I would like to prevent on the dialog the paths of non valid files. I think that is a better solution.


The editor shows the open file that was moved (probably KTextEditor has a way to watch that)


File with non valid path shows up, if the user select it, nothing happens.

Wed, Aug 15, 10:10 AM
rizzitello added a comment to D12456: Enable a notification system.

after manually installing the rc file the config area looks like this..

Wed, Aug 15, 10:07 AM
rizzitello requested changes to D12456: Enable a notification system.

Does not work when installed Or when not installed. the notification.rc file doesn't seam to be installed.

Wed, Aug 15, 10:06 AM
rizzitello added a comment to D14837: Reset dial on disconnect.

I do not see a problem here. Its ok to have the few seconds of inaccurate dials just like when you connect for the first time and see 0 for a few seconds.

Wed, Aug 15, 9:45 AM

Tue, Aug 14

rizzitello added a comment to D14842: Check if file exists - ChooseFileDialog.

In order for a file to make it to this list we will have needed to open the file already so we know the file existed then. Im guessing your consern is that the file is deleted after the user has opened it but before they have printed it. We dont show it now as a selectable file but the user can see that its open in the editor and now we have a chance for this to confuse the user.

Tue, Aug 14, 8:19 PM
rizzitello accepted D14831: Add timer to control the emit change target temp.

Seams to work just fine now.

Tue, Aug 14, 8:13 PM
rizzitello requested changes to D14837: Reset dial on disconnect.

Can you provide an example of this happening.. I have tested several times with master and do not see the set target being retained. This will only happen if your machine doesn't reset on disconnect and in that case your still heating to the set temperature.

Tue, Aug 14, 8:10 PM
rizzitello updated the diff for D13576: Allow non reset on connect.
  • rebase
Tue, Aug 14, 8:01 PM · Atelier: AtCore
rizzitello added a comment to D14837: Reset dial on disconnect.

Seams good and I will test asap

Tue, Aug 14, 3:12 PM
rizzitello requested changes to D14831: Add timer to control the emit change target temp.

This breaks the cursor that provides the user hint they can type into the control. So you need some of that code in the focus out event. Im not at a machine so im not able to fully test its

Tue, Aug 14, 1:41 PM
rizzitello accepted D14827: Improve regex for temperatures.

Please squash commits so the test comes with the newer reg ex.

Tue, Aug 14, 1:08 PM
rizzitello added inline comments to D14827: Improve regex for temperatures.
Tue, Aug 14, 11:35 AM
rizzitello added inline comments to D14827: Improve regex for temperatures.
Tue, Aug 14, 11:24 AM
rizzitello added a comment to D14827: Improve regex for temperatures.

Just noticed that the Target Regex does not capture after decimal point . Fix inline :D

Tue, Aug 14, 11:16 AM
rizzitello requested changes to D14827: Improve regex for temperatures.

I guess just appending this to the previous revision was to much ?
The decodeTemp function is fine as i wrote and tested it last night.

Tue, Aug 14, 11:11 AM
rizzitello requested changes to D14792: Improve regex to get bed target tmp.

your regex change fixes the bed temperature reading but it breaks for APrinter because its bed first (basicly) . So now that we have a better regex that looks at the whole Bed block for the target lets also update our extruder target to take advantage of that. This allows us to correctly capture the extruder target now no matter its location as a result we can now remove all the nonsence about setting what comes first. Below is my fixed and working decodeTemp function. There are no errors and All test including the new one now pass. Please commit this change and the new test case in one commit since this commit fixes the error and adds a check to ensure its not broken again.

Tue, Aug 14, 12:36 AM

Mon, Aug 13

rizzitello requested changes to D14792: Improve regex to get bed target tmp.

Please Squash into one commit. Your test should use non 0 values to test. When you do that you will see it fails to get the bed Target for this firmware.

My Modified Test

 temperature->decodeTemp(QByteArray("ok T:23.6 /200.0 B:27.2 /80.0 T0:23.6 /0.0 @:0 B@:0"));
QVERIFY(temperature->extruderTemperature() == float(23.6));
QVERIFY(temperature->extruderTargetTemperature() == 200);
QVERIFY(temperature->bedTemperature() == float(27.2));
QVERIFY(temperature->bedTargetTemperature() == 80);
Mon, Aug 13, 2:22 PM

Wed, Aug 1

rizzitello added a comment to D10362: Swap reveal password button logic.

Would it be possible to implement this feature like in the Windows 10 lock screen? (i.e. don't toggle the state; reveal the password only as long as the button is pressed). I feel like it would remove the security issue in the first place (as there isn't anymore a persistent state where the password can be visible).

Wed, Aug 1, 9:02 PM · Frameworks, Plasma
rizzitello added a comment to M133: Fonts KCM simple vs advanced modes.

This appears to be missing the "Force DPI" option that is in our current KCM.

Wed, Aug 1, 8:48 PM · Plasma: KCM Redesign
rizzitello updated the diff for D13576: Allow non reset on connect.
  • rebase
Wed, Aug 1, 8:15 PM · Atelier: AtCore
rizzitello added a comment to D14136: Basic SD Write Support.

This process is slow and I would say the transfer speed might be 1MB/Minute.

Wed, Aug 1, 8:13 PM · Atelier: AtCore

Wed, Jul 25

rizzitello committed R231:079f36a3fb79: Atelier Aware if a file is modified on close/ print (authored by rizzitello).
Atelier Aware if a file is modified on close/ print
Wed, Jul 25, 7:37 PM
rizzitello committed R231:2d8e2bfa8451: Ask to save if trying to print a file that was modified (authored by rizzitello).
Ask to save if trying to print a file that was modified
Wed, Jul 25, 7:37 PM
rizzitello committed R231:695c8df89230: Add Icons for several new actions (authored by rizzitello).
Add Icons for several new actions
Wed, Jul 25, 7:37 PM
rizzitello committed R231:c111dc46a1b3: Ask to save if files open in gcodeview unsaved (authored by rizzitello).
Ask to save if files open in gcodeview unsaved
Wed, Jul 25, 7:37 PM
rizzitello committed R231:8c75b2e1f035: Add modifiedFiles to return list of modified files (authored by rizzitello).
Add modifiedFiles to return list of modified files
Wed, Jul 25, 7:37 PM
rizzitello committed R231:630c3b0e4e3e: Add public Save File (authored by rizzitello).
Add public Save File
Wed, Jul 25, 7:37 PM
rizzitello closed D13978: Atelier Aware if a file is modified on close/ print.
Wed, Jul 25, 7:37 PM · Atelier: General Development

Jul 19 2018

rizzitello updated the diff for D13978: Atelier Aware if a file is modified on close/ print.
  • Add public Save File
  • Add Icons for several new actions
  • Ask to save if files open in gcodeview unsaved
  • Ask to save if trying to print a file that was modified
Jul 19 2018, 12:10 AM · Atelier: General Development

Jul 17 2018

rizzitello added inline comments to D13978: Atelier Aware if a file is modified on close/ print.
Jul 17 2018, 11:59 AM · Atelier: General Development

Jul 16 2018

rizzitello committed R231:e46d8ac136ad: Change editor default view options (authored by rizzitello).
Change editor default view options
Jul 16 2018, 5:23 PM
rizzitello committed R231:68bb36e0e363: Change the editor default view options (authored by rizzitello).
Change the editor default view options
Jul 16 2018, 5:23 PM
rizzitello updated the test plan for D13978: Atelier Aware if a file is modified on close/ print.
Jul 16 2018, 4:59 PM · Atelier: General Development
rizzitello updated the diff for D13978: Atelier Aware if a file is modified on close/ print.
  • Rebase
Jul 16 2018, 4:56 PM · Atelier: General Development
rizzitello closed D13969: Change editor default view options.
Jul 16 2018, 4:55 PM · Atelier: General Development
rizzitello updated the diff for D13969: Change editor default view options.
  • readd line numbers
Jul 16 2018, 4:55 PM · Atelier: General Development
rizzitello added a comment to D13969: Change editor default view options.

I would like to have the line-numbers... the others modifications are fine.
Now based on @tcanabrava thoughts, this kind of profiling can be done on KTextEditor options on Atelier Settings->Configure Editor. Those can be just our 'default setup'.

Jul 16 2018, 4:52 PM · Atelier: General Development
rizzitello planned changes to D14136: Basic SD Write Support.

I plan to add a progress dialog and the ability to cancel.

Jul 16 2018, 1:07 PM · Atelier: AtCore

Jul 15 2018

rizzitello updated the diff for D14136: Basic SD Write Support.
  • fix base
Jul 15 2018, 3:52 PM · Atelier: AtCore
rizzitello updated the diff for D14136: Basic SD Write Support.
  • Remove unused QList include
  • Basic SD Write Support
  • Add Translate for M28 and M29, Add to83 function to get 8.3ish Names
Jul 15 2018, 3:43 PM · Atelier: AtCore
rizzitello added a project to D14136: Basic SD Write Support: Atelier: AtCore.
Jul 15 2018, 3:19 PM · Atelier: AtCore
rizzitello requested review of D14136: Basic SD Write Support.
Jul 15 2018, 3:17 PM · Atelier: AtCore

Jul 12 2018

rizzitello updated the diff for D13978: Atelier Aware if a file is modified on close/ print.
  • Rebase
Jul 12 2018, 1:08 AM · Atelier: General Development
rizzitello updated the diff for D13969: Change editor default view options.
  • Rebase
Jul 12 2018, 1:03 AM · Atelier: General Development
rizzitello committed R231:2b04c3dc5b54: Enable DnD for GcodeEditor (authored by rizzitello).
Enable DnD for GcodeEditor
Jul 12 2018, 1:02 AM
rizzitello closed T8913: Drag and Drop for GCodeEditorWidget as Resolved by committing R231:2b04c3dc5b54: Enable DnD for GcodeEditor.
Jul 12 2018, 1:02 AM · Atelier: General Development
rizzitello committed R231:2e6296ef5c77: Connect the gcodeWidgets droppedUrls (authored by rizzitello).
Connect the gcodeWidgets droppedUrls
Jul 12 2018, 1:02 AM
rizzitello committed R231:d283efc65017: Add signal to pass droppedUrls (authored by rizzitello).
Add signal to pass droppedUrls
Jul 12 2018, 1:02 AM
rizzitello closed D13929: Enable DnD for GcodeEditor.
Jul 12 2018, 1:02 AM · Atelier: General Development
rizzitello updated the diff for D13929: Enable DnD for GcodeEditor.
  • rebase
Jul 12 2018, 1:02 AM · Atelier: General Development
rizzitello committed R231:9adfc967b8be: Use Icon For Add Instance (authored by rizzitello).
Use Icon For Add Instance
Jul 12 2018, 1:01 AM
rizzitello committed R231:c854ce370268: Use the addTab icon and set its size correctly (authored by rizzitello).
Use the addTab icon and set its size correctly
Jul 12 2018, 1:01 AM
rizzitello committed R231:68e7b6ba67ed: Make the Icons In the AtCoreInstance Larger so they stand out better (authored by rizzitello).
Make the Icons In the AtCoreInstance Larger so they stand out better
Jul 12 2018, 1:01 AM
rizzitello committed R231:8fa216254d67: Make the Icons larger so they stand out better (authored by rizzitello).
Make the Icons larger so they stand out better
Jul 12 2018, 1:01 AM
rizzitello closed D13968: Use Icon For Add Instance.
Jul 12 2018, 1:01 AM · Atelier: General Development
rizzitello updated the diff for D13968: Use Icon For Add Instance.
  • rebase
Jul 12 2018, 1:01 AM · Atelier: General Development
rizzitello closed D13966: Make the Icons In the AtCoreInstance Larger so they stand out better.
Jul 12 2018, 1:00 AM · Atelier: General Development
rizzitello updated the diff for D13576: Allow non reset on connect.
  • rebase
Jul 12 2018, 12:57 AM · Atelier: AtCore
rizzitello committed R232:cac820ee98ca: Remove unused QList include (authored by rizzitello).
Remove unused QList include
Jul 12 2018, 12:57 AM
rizzitello committed R232:9c6ff95feaa1: Remove unused QList include (authored by rizzitello).
Remove unused QList include
Jul 12 2018, 12:57 AM
rizzitello closed D14014: Remove unused QList include.
Jul 12 2018, 12:57 AM · Atelier: AtCore

Jul 9 2018

rizzitello added a project to D14014: Remove unused QList include: Atelier: AtCore.
Jul 9 2018, 8:45 PM · Atelier: AtCore
rizzitello requested review of D14014: Remove unused QList include.
Jul 9 2018, 8:44 PM · Atelier: AtCore
rizzitello updated the diff for D13978: Atelier Aware if a file is modified on close/ print.
  • Tomaz' suggestions.
Jul 9 2018, 8:29 PM · Atelier: General Development