rizzitello (Chris Rizzitello)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 27 2016, 1:59 PM (107 w, 2 d)
Availability
Available

Recent Activity

Tue, Oct 16

rizzitello added inline comments to D16181: Move final terminator in firmware plugin side.
Tue, Oct 16, 11:47 AM
rizzitello added inline comments to D16200: Use SerialLayer()->pushCommand in only in processQueue.
Tue, Oct 16, 1:07 AM · Atelier: AtCore
rizzitello updated the diff for D16200: Use SerialLayer()->pushCommand in only in processQueue.

fix Typo

Tue, Oct 16, 12:58 AM · Atelier: AtCore
rizzitello updated the diff for D16200: Use SerialLayer()->pushCommand in only in processQueue.

use Gcode enum

Tue, Oct 16, 12:55 AM · Atelier: AtCore
rizzitello added inline comments to D16200: Use SerialLayer()->pushCommand in only in processQueue.
Tue, Oct 16, 12:42 AM · Atelier: AtCore
rizzitello updated the diff for D16200: Use SerialLayer()->pushCommand in only in processQueue.

Remove unneeded code

Tue, Oct 16, 12:42 AM · Atelier: AtCore
rizzitello updated the diff for D16144: Send bedSize to 3dviewer.
  • rebase
Tue, Oct 16, 12:38 AM · Atelier: General Development
rizzitello updated the diff for D16206: Use AtCore::pushedCommand.
  • rebase
Tue, Oct 16, 12:38 AM · Atelier: General Development
rizzitello added a comment to D16206: Use AtCore::pushedCommand.

Why this is in a different review if needs D16199 ?

Tue, Oct 16, 12:37 AM · Atelier: General Development
rizzitello committed R231:e6eb9f252170: Cleanup warning replace deprecated call to serialLayer (authored by rizzitello).
Cleanup warning replace deprecated call to serialLayer
Tue, Oct 16, 12:35 AM
rizzitello committed R231:6b6941545c92: Cleanup warning replace deprecated call to serialLayer (authored by rizzitello).
Cleanup warning replace deprecated call to serialLayer
Tue, Oct 16, 12:35 AM
rizzitello closed D16205: Cleanup warning replace deprecated call to serialLayer.
Tue, Oct 16, 12:35 AM · Atelier: General Development
rizzitello added a comment to D16199: Make SerialLayer completely private.

What is the logic behind this change ?

Tue, Oct 16, 12:31 AM · Atelier: AtCore

Mon, Oct 15

rizzitello updated the diff for D16144: Send bedSize to 3dviewer.

rebase

Mon, Oct 15, 10:09 PM · Atelier: General Development
rizzitello updated the diff for D16205: Cleanup warning replace deprecated call to serialLayer.

rebase

Mon, Oct 15, 10:08 PM · Atelier: General Development
rizzitello updated the diff for D16206: Use AtCore::pushedCommand.
  • rebase
Mon, Oct 15, 10:07 PM · Atelier: General Development
rizzitello updated the diff for D16144: Send bedSize to 3dviewer.
  • cleaner functions , added ref use in lambda
Mon, Oct 15, 4:50 PM · Atelier: General Development
rizzitello updated the summary of D16144: Send bedSize to 3dviewer.
Mon, Oct 15, 4:28 PM · Atelier: General Development
rizzitello requested changes to D16129: Allow to control the bed dimensions.

please See D16144 and expect to read your bed size from the view3d's bedsize property

Mon, Oct 15, 4:22 PM
rizzitello updated the diff for D16144: Send bedSize to 3dviewer.

fix property typo

Mon, Oct 15, 4:19 PM · Atelier: General Development
rizzitello updated the diff for D16144: Send bedSize to 3dviewer.

remvoe debug line

Mon, Oct 15, 4:18 PM · Atelier: General Development
rizzitello updated the diff for D16144: Send bedSize to 3dviewer.
  • finalize (hopefully)
Mon, Oct 15, 4:18 PM · Atelier: General Development
rizzitello added a comment to T9830: Application Menubar states and usability.

I think we would need to keep the older style menu area as an option as well (I also like #2). needed for thin titlebars, windows without them, users who do not want them in the title bar.

Mon, Oct 15, 2:56 PM · Plasma, VDG
rizzitello closed T8533: Movement Control / Axis Control as Resolved.
Mon, Oct 15, 2:52 PM · Atelier: AtCore
rizzitello removed a dependent revision for D16199: Make SerialLayer completely private: D16200: Use SerialLayer()->pushCommand in only in processQueue.
Mon, Oct 15, 9:59 AM · Atelier: AtCore
rizzitello removed a dependency for D16200: Use SerialLayer()->pushCommand in only in processQueue: D16199: Make SerialLayer completely private.
Mon, Oct 15, 9:59 AM · Atelier: AtCore
rizzitello removed a dependency for D16181: Move final terminator in firmware plugin side: D16200: Use SerialLayer()->pushCommand in only in processQueue.
Mon, Oct 15, 9:59 AM
rizzitello removed a dependent revision for D16200: Use SerialLayer()->pushCommand in only in processQueue: D16181: Move final terminator in firmware plugin side.
Mon, Oct 15, 9:59 AM · Atelier: AtCore
rizzitello updated the summary of D16200: Use SerialLayer()->pushCommand in only in processQueue.
Mon, Oct 15, 2:17 AM · Atelier: AtCore
rizzitello added a dependency for D16200: Use SerialLayer()->pushCommand in only in processQueue: D16199: Make SerialLayer completely private.
Mon, Oct 15, 2:16 AM · Atelier: AtCore
rizzitello added a dependent revision for D16199: Make SerialLayer completely private: D16200: Use SerialLayer()->pushCommand in only in processQueue.
Mon, Oct 15, 2:16 AM · Atelier: AtCore
rizzitello removed a dependency for D16199: Make SerialLayer completely private: D16200: Use SerialLayer()->pushCommand in only in processQueue.
Mon, Oct 15, 2:16 AM · Atelier: AtCore
rizzitello removed a dependent revision for D16200: Use SerialLayer()->pushCommand in only in processQueue: D16199: Make SerialLayer completely private.
Mon, Oct 15, 2:16 AM · Atelier: AtCore
rizzitello added a dependent revision for D16200: Use SerialLayer()->pushCommand in only in processQueue: D16181: Move final terminator in firmware plugin side.
Mon, Oct 15, 2:14 AM · Atelier: AtCore
rizzitello added a dependency for D16181: Move final terminator in firmware plugin side: D16200: Use SerialLayer()->pushCommand in only in processQueue.
Mon, Oct 15, 2:14 AM
rizzitello added a dependent revision for D16200: Use SerialLayer()->pushCommand in only in processQueue: D16199: Make SerialLayer completely private.
Mon, Oct 15, 2:13 AM · Atelier: AtCore
rizzitello added a dependency for D16199: Make SerialLayer completely private: D16200: Use SerialLayer()->pushCommand in only in processQueue.
Mon, Oct 15, 2:13 AM · Atelier: AtCore

Sun, Oct 14

rizzitello added a project to D16206: Use AtCore::pushedCommand: Atelier: General Development.
Sun, Oct 14, 6:40 PM · Atelier: General Development
rizzitello requested review of D16206: Use AtCore::pushedCommand.
Sun, Oct 14, 6:39 PM · Atelier: General Development
rizzitello added a project to D16205: Cleanup warning replace deprecated call to serialLayer: Atelier: General Development.
Sun, Oct 14, 6:36 PM · Atelier: General Development
rizzitello requested review of D16205: Cleanup warning replace deprecated call to serialLayer.
Sun, Oct 14, 6:36 PM · Atelier: General Development
rizzitello added a comment to D16181: Move final terminator in firmware plugin side.

Some Issues i've fixed unrelated to this but should be landed first.
D16199 and D16200
Then in atcore::processQueue the one call of serialLayer->pushCommand that does not use translate (since that is the no plugin loaded case) needs to have \r\n appended to it. Then this should work correctly

Sun, Oct 14, 5:08 PM
rizzitello updated the summary of D16199: Make SerialLayer completely private.
Sun, Oct 14, 5:06 PM · Atelier: AtCore
rizzitello added a project to D16200: Use SerialLayer()->pushCommand in only in processQueue: Atelier: AtCore.
Sun, Oct 14, 5:06 PM · Atelier: AtCore
rizzitello requested review of D16200: Use SerialLayer()->pushCommand in only in processQueue.
Sun, Oct 14, 5:04 PM · Atelier: AtCore
rizzitello updated the diff for D16199: Make SerialLayer completely private.
  • adjust logWidget documentation
Sun, Oct 14, 4:41 PM · Atelier: AtCore
rizzitello added a project to D16199: Make SerialLayer completely private: Atelier: AtCore.
Sun, Oct 14, 4:36 PM · Atelier: AtCore
rizzitello requested review of D16199: Make SerialLayer completely private.
Sun, Oct 14, 4:34 PM · Atelier: AtCore
rizzitello added a comment to D16144: Send bedSize to 3dviewer.

I can try, which way would be best to get back to the View3D I belong to? (didn't check yet but from your patch you might have an idea already)

Im not sure how exactly todo that maybe @patrickelectric can help here.

Sun, Oct 14, 12:00 PM · Atelier: General Development
rizzitello requested changes to D16181: Move final terminator in firmware plugin side.

Not sure why but with this patch i get lines cut off and split across a few entries. Im not sure if this is related to auto detect failing for me.

Sun, Oct 14, 2:50 AM

Sat, Oct 13

rizzitello requested changes to D16181: Move final terminator in firmware plugin side.

How do we send commands now before connected to a firmware? M115 has to be sent before any firmware connection, It works on Grbl because were looking for the name. This does seam like progress in the correct direction we just need to smooth out this important case.

Sat, Oct 13, 9:20 PM
rizzitello updated the diff for D16144: Send bedSize to 3dviewer.

rebase

Sat, Oct 13, 7:34 PM · Atelier: General Development
rizzitello committed R231:85194220a679: Warning Roundup (authored by rizzitello).
Warning Roundup
Sat, Oct 13, 7:32 PM
rizzitello committed R231:9dfaaeb02275: Clean warnings (authored by rizzitello).
Clean warnings
Sat, Oct 13, 7:32 PM
rizzitello committed R231:56cc90b60294: Remove Warnings (authored by rizzitello).
Remove Warnings
Sat, Oct 13, 7:32 PM
rizzitello committed R231:ca4deb032601: Clean up warnings (authored by rizzitello).
Clean up warnings
Sat, Oct 13, 7:32 PM
rizzitello committed R231:becc882d73a3: Clean up warnings (authored by rizzitello).
Clean up warnings
Sat, Oct 13, 7:32 PM
rizzitello committed R231:09749ed9168d: Set Version to 0.70.0 to reflect prerelease status (authored by rizzitello).
Set Version to 0.70.0 to reflect prerelease status
Sat, Oct 13, 7:32 PM
rizzitello committed R231:d280d82a550d: Use style icon as fallback for theme icon (authored by rizzitello).
Use style icon as fallback for theme icon
Sat, Oct 13, 7:32 PM
rizzitello committed R231:2e6a8847fd4c: Style adjust (authored by rizzitello).
Style adjust
Sat, Oct 13, 7:32 PM
rizzitello committed R231:63c33be56e67: Remove unused capture for lambda (authored by rizzitello).
Remove unused capture for lambda
Sat, Oct 13, 7:32 PM
rizzitello committed R231:59650098f102: Clean up type warnings (authored by rizzitello).
Clean up type warnings
Sat, Oct 13, 7:32 PM
rizzitello closed D15858: Warning Roundup.
Sat, Oct 13, 7:32 PM · Atelier: General Development
rizzitello accepted D16180: Switch to C++11 scoped enums.
Sat, Oct 13, 7:23 PM
rizzitello updated the diff for D15858: Warning Roundup.
  • Use int to avoid casts
Sat, Oct 13, 7:17 PM · Atelier: General Development
rizzitello committed R232:7665fdd0ee88: Clean Warnings, Sync application Name and title (authored by rizzitello).
Clean Warnings, Sync application Name and title
Sat, Oct 13, 7:05 PM
rizzitello committed R232:8b800e0aeedc: Warning Clean (authored by rizzitello).
Warning Clean
Sat, Oct 13, 7:05 PM
rizzitello committed R232:741c06d82c6e: Remove cast warning (authored by rizzitello).
Remove cast warning
Sat, Oct 13, 7:05 PM
rizzitello closed D15861: Warning Clean.
Sat, Oct 13, 7:05 PM · Atelier: AtCore
rizzitello requested changes to D16181: Move final terminator in firmware plugin side.

Can you please "fix" the other plugins with \r\n so this does not break them

Sat, Oct 13, 7:03 PM
rizzitello updated the diff for D15861: Warning Clean.
  • Remove added new line
Sat, Oct 13, 12:04 PM · Atelier: AtCore
rizzitello added a comment to D16129: Allow to control the bed dimensions.

Yes, I went for my own properties due to more precise naming, but I admit I don't mind either way on the technical level. So what should I do? Change it or stay as is? You guys seem to disagree a bit. :-)

i prefer the more precise naming. :)
Sith, i'm +1'ing this.

Sat, Oct 13, 11:41 AM
rizzitello added a comment to D16144: Send bedSize to 3dviewer.

you store the new dimensions in the Viewer3D here and you replace the implementation of BedProperties so that its instances find their Viewer3D and read the dimensions from there.

Can you modify your patch for this that seams more sane since the 3dView is what the main application interacts with already

Sat, Oct 13, 11:35 AM · Atelier: General Development

Fri, Oct 12

rizzitello accepted D16143: Change null pointer reference from zero to nullptr.

Much Nicer !

Fri, Oct 12, 8:01 PM · KDE Edu
rizzitello requested changes to D16143: Change null pointer reference from zero to nullptr.
Fri, Oct 12, 6:52 PM · KDE Edu
rizzitello requested changes to D16143: Change null pointer reference from zero to nullptr.
Fri, Oct 12, 5:20 PM · KDE Edu
rizzitello added inline comments to D16144: Send bedSize to 3dviewer.
Fri, Oct 12, 3:19 PM · Atelier: General Development
rizzitello added a comment to D16129: Allow to control the bed dimensions.

I belive q QSize is width / height so it would be weird to use for depth.

Fri, Oct 12, 11:04 AM
rizzitello added a comment to D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

Why should the login screen look different to the lock screen?

Fri, Oct 12, 1:42 AM · Plasma
rizzitello requested changes to D16143: Change null pointer reference from zero to nullptr.

Check your Indentation you seam to have moved all your modified lines in a bit.

Fri, Oct 12, 1:35 AM · KDE Edu
rizzitello updated the diff for D16144: Send bedSize to 3dviewer.
  • remove empty lines
Fri, Oct 12, 12:22 AM · Atelier: General Development

Thu, Oct 11

rizzitello updated the diff for D16144: Send bedSize to 3dviewer.
  • Update bed when atcore instance changes size
Thu, Oct 11, 11:49 PM · Atelier: General Development
rizzitello added a comment to D16129: Allow to control the bed dimensions.

I got as far as D16144 in connecting these.

Thu, Oct 11, 10:57 PM
rizzitello updated the summary of D16144: Send bedSize to 3dviewer.
Thu, Oct 11, 10:56 PM · Atelier: General Development
rizzitello added a project to D16144: Send bedSize to 3dviewer: Atelier: General Development.
Thu, Oct 11, 10:55 PM · Atelier: General Development
rizzitello requested review of D16144: Send bedSize to 3dviewer.
Thu, Oct 11, 10:53 PM · Atelier: General Development
rizzitello added a comment to D16129: Allow to control the bed dimensions.

I'm lacking time to do that, that's why I agreed with Lays she would do that connection. Besides I've no good way to test that stuff and it gives me the creeps, so better have someone with the necessary setup do that bit.

Thu, Oct 11, 3:31 PM
rizzitello added a comment to D16129: Allow to control the bed dimensions.

Further work will be needed to account for how this will work with more then one machine connected.

Thu, Oct 11, 2:58 PM
rizzitello added a comment to D16129: Allow to control the bed dimensions.

Please connect this to the profile data within this commit.

Thu, Oct 11, 2:54 PM
rizzitello added a comment to T9830: Application Menubar states and usability.

Personally I like the approach dolphin uses right now. I am no friend of having a global menu nor I like to have another button cluttering my title bar but the worst case would be to have the complete menubar shown in dolphin just becuase the other options does not suit me. I think it is a good idea to keeps the things clean and simple and this is was dolphin does. Instead of proposing to remove this feature just because is it not following the other applications we maybe could think the way around and implement such simpler menu structures inside the applications.

Thu, Oct 11, 11:22 AM · Plasma, VDG

Wed, Oct 10

rizzitello accepted D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required.

This Looks Great!

Wed, Oct 10, 11:29 PM · Plasma
rizzitello committed R73:998fcf68a128: Makes the Code Editor Widget tabs closable. (authored by Fernando Costa <fernandocr@id.uff.br>).
Makes the Code Editor Widget tabs closable.
Wed, Oct 10, 10:50 PM
rizzitello committed R73:1abeca0f5e43: Makes the Code Editor Widget tabs closable. (authored by Fernando Costa <fernandocr@id.uff.br>).
Makes the Code Editor Widget tabs closable.
Wed, Oct 10, 10:50 PM
rizzitello closed D15990: Makes the Code Editor Widget tabs closable..
Wed, Oct 10, 10:50 PM · KDE Edu
rizzitello updated the diff for D15858: Warning Roundup.
  • Target temperature can only be an int.
Wed, Oct 10, 9:07 PM · Atelier: General Development
rizzitello updated the diff for D15858: Warning Roundup.
  • Patrick's suggestions
Wed, Oct 10, 8:50 PM · Atelier: General Development
rizzitello updated the diff for D15861: Warning Clean.
  • use std::max correctly
Wed, Oct 10, 8:21 PM · Atelier: AtCore
rizzitello updated the diff for D15861: Warning Clean.
  • Rebase
Wed, Oct 10, 8:07 PM · Atelier: AtCore
rizzitello updated the diff for D15861: Warning Clean.
  • use std::max
Wed, Oct 10, 7:56 PM · Atelier: AtCore
rizzitello added a comment to T9830: Application Menubar states and usability.

Just to add a few things.

Wed, Oct 10, 3:12 PM · Plasma, VDG