KrusaderProject
ActivePublic

Recent Activity

Yesterday

nmel accepted D9041: Ability to ignore defined files and directories from search results.

I also tested and it seems to work fine. Thanks for the work to both Martins!

Sat, Feb 24, 11:10 PM · Krusader
asensi accepted D9041: Ability to ignore defined files and directories from search results.

I've changed delimiter to space and used KShell::splitArgs() method to allow using

  • quoted folder names
  • folder names with escaped spaces
Sat, Feb 24, 10:57 AM · Krusader
asensi closed D10746: Changes in the "desktop" file to achieve that Krusader can be added to favorites in Gnome Dock.
Sat, Feb 24, 9:31 AM · Krusader
asensi updated the diff for D10746: Changes in the "desktop" file to achieve that Krusader can be added to favorites in Gnome Dock.

Now the names of Jakub Buczak (Jakkubu) and Nate Graham are mentioned in the commit.

Sat, Feb 24, 9:07 AM · Krusader
nmel closed D10734: KrViewer: reenforce QTabWidget shortcuts for tab switching.
Sat, Feb 24, 6:13 AM · Krusader
martinkostolny accepted D10746: Changes in the "desktop" file to achieve that Krusader can be added to favorites in Gnome Dock.

Thanks!

Sat, Feb 24, 1:08 AM · Krusader
martinkostolny updated the diff for D9041: Ability to ignore defined files and directories from search results.

One more small update - fix include order.

Sat, Feb 24, 1:01 AM · Krusader
martinkostolny updated the diff for D9041: Ability to ignore defined files and directories from search results.

Thanks, Toni, for testing the patch and the pretty good idea to change colon to space!

Sat, Feb 24, 12:29 AM · Krusader

Fri, Feb 23

nmel closed D10608: Closing calculate occupied space window aborts the calculation.

It's pushed by Davide already.

Fri, Feb 23, 6:05 AM · Krusader
nmel added a comment to D10734: KrViewer: reenforce QTabWidget shortcuts for tab switching.

Thanks for testing, Martin!

Fri, Feb 23, 6:02 AM · Krusader
nmel accepted D10746: Changes in the "desktop" file to achieve that Krusader can be added to favorites in Gnome Dock.

The reporter's name is Jakub Buczak, according to his email address, in case you want to use his full name in the commit message.

Fri, Feb 23, 5:41 AM · Krusader
martinkostolny accepted D10734: KrViewer: reenforce QTabWidget shortcuts for tab switching.

Thanks, Nikita, for making this work!

Fri, Feb 23, 1:15 AM · Krusader

Thu, Feb 22

asensi requested review of D10746: Changes in the "desktop" file to achieve that Krusader can be added to favorites in Gnome Dock.
Thu, Feb 22, 2:23 PM · Krusader
asensi added a comment to D9041: Ability to ignore defined files and directories from search results.

For more consistency, I'm thinking that, if in the "Search for:" text field, Krusader users space as a delimiter... maybe it would also use it in the same window, in the proposed «Exclude Folder Names» text field.

Thu, Feb 22, 9:46 AM · Krusader
nmel accepted D10608: Closing calculate occupied space window aborts the calculation.

I also accept to prevent another code review iteration. Please integrate the requested changes into the final commit.

Thu, Feb 22, 8:30 AM · Krusader
nmel added a project to D10734: KrViewer: reenforce QTabWidget shortcuts for tab switching: Krusader.
Thu, Feb 22, 8:05 AM · Krusader
martinkostolny accepted D10608: Closing calculate occupied space window aborts the calculation.

Works nicely on Arch Linux. Thanks Davide! :)

Thu, Feb 22, 12:19 AM · Krusader

Wed, Feb 21

asensi accepted D9041: Ability to ignore defined files and directories from search results.

Thank you! For my part, I accept this because I performed some tests and the new patch worked correctly (items inside the specified folders are excluded, files and folders that are shown are the expected ones, etc.), although when there was a folder with a ":" inside its name then the folder couldn't be excluded.

Wed, Feb 21, 5:40 PM · Krusader
asensi accepted D10608: Closing calculate occupied space window aborts the calculation.

Thanks Davide! The changes that Nikita (nmel) wrote are also improvements. For my part, I accept this because my performed tests (using Kubuntu 17.10) seemed to work correctly.

Wed, Feb 21, 11:33 AM · Krusader

Mon, Feb 19

martinkostolny updated the test plan for D9041: Ability to ignore defined files and directories from search results.
Mon, Feb 19, 12:09 AM · Krusader

Sun, Feb 18

martinkostolny added a comment to D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Thank you both for informative answers!

Sun, Feb 18, 5:47 PM · Krusader
martinkostolny closed D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.
Sun, Feb 18, 5:18 PM · Krusader
martinkostolny added a project to D10307: Add Tab Pinning Feature: Krusader.
Sun, Feb 18, 12:05 PM · Krusader

Sat, Feb 17

nmel requested changes to D10608: Closing calculate occupied space window aborts the calculation.

Thanks for the bug fix. I checked the code and tested - it works nicely!

Sat, Feb 17, 9:38 PM · Krusader
gengisdave added a reviewer for D10608: Closing calculate occupied space window aborts the calculation: Krusader.
Sat, Feb 17, 4:09 PM · Krusader
gengisdave requested review of D10608: Closing calculate occupied space window aborts the calculation.
Sat, Feb 17, 4:08 PM · Krusader
asensi added a project to D10385: Fix setting new current item after file deletion: Krusader.
Sat, Feb 17, 11:44 AM · Krusader

Fri, Feb 16

asensi accepted D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Thanks, Toni, for trying it out! :-)

Fri, Feb 16, 10:50 AM · Krusader
nmel accepted D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Hi Martin,

Fri, Feb 16, 8:40 AM · Krusader

Tue, Feb 13

martinkostolny added a comment to D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

-Thanks, Toni, for trying it out! :-) I believe that cmake is installing into /user/local by default no matter KDE_INSTALL_USE_QT_SYS_PATHS is set or not. At least on Arch Linux it works out like that. Only after setting -DCMAKE_INSTALL_PREFIX=... the install prefix get changed. And that is persisted even if next cmake call is performed without this switch. Best practice for me is cleaning up build folder before calling cmake to have a predictable results. Again, it works like that in Arch Linux with cmake version 3.10.2, I'm not sure if other distributions behave the same.

Tue, Feb 13, 11:14 PM · Krusader

Sun, Feb 11

nmel added a watcher for Krusader: nmel.
Sun, Feb 11, 1:47 AM
nmel added a member for Krusader: nmel.
Sun, Feb 11, 1:45 AM

Fri, Feb 9

asensi added a comment to D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Hi! I tried the patch, using Kubuntu 17.10, and everything seems to work correctly.

Fri, Feb 9, 9:12 AM · Krusader

Wed, Feb 7

mjanczara added a watcher for Krusader: mjanczara.
Wed, Feb 7, 11:02 PM

Sat, Feb 3

martinkostolny updated the diff for D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Diff updated to show a waring if CMAKE_INSTALL_PREFIX is not standard with a hint how to force installing plugins to standard location.

Sat, Feb 3, 9:26 PM · Krusader

Jan 23 2018

martinkostolny added a comment to D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Thanks for the lot of good info!

Jan 23 2018, 12:33 AM · Krusader

Jan 22 2018

asensi added a comment to D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

Because you added this

Jan 22 2018, 9:27 PM · Krusader

Jan 21 2018

abika updated subscribers of D9975: Allow rootless 'make install' with non-standard CMAKE_INSTALL_PREFIX.

As I understand it, the problem is that plugins installed to PREFIX/lib/qt/plugins won't always be be found depending on PREFIX.
It will work for "/usr" and probably "/usr/local" (can you confirm the latter, Martin? I didn't test it).
But if I install e.g. to a directory in the Krusader source directory (a quick local installation for testing) the plugins won't work. And this will may be left unnoticed by the user.

Jan 21 2018, 4:18 PM · Krusader

Oct 7 2017

martinkostolny closed D7974: Fix mkdir and mkpath for krarc protocol.
Oct 7 2017, 12:12 AM · Krusader

Sep 29 2017

asensi accepted D7974: Fix mkdir and mkpath for krarc protocol.

For my part, I accept this because my performed tests (using Kubuntu 17.04) went alright.

Sep 29 2017, 10:00 PM · Krusader

Sep 24 2017

martinkostolny created D7974: Fix mkdir and mkpath for krarc protocol.
Sep 24 2017, 5:39 PM · Krusader

Sep 17 2017

abika edited the content of Krusader.
Sep 17 2017, 6:22 PM · Krusader
abika edited the content of Krusader.
Sep 17 2017, 3:13 PM · Krusader
abika edited the content of Krusader.
Sep 17 2017, 3:08 PM · Krusader
abika edited the content of Krusader.
Sep 17 2017, 3:08 PM · Krusader

Sep 10 2017

gengisdave abandoned D2603: Add advanced debugging to KIso.

Solved in https://cgit.kde.org/krusader.git/commit/?id=4df7f97cdd2a3a8234b54dcbb205c9e6349d564c

Sep 10 2017, 9:44 AM · Krusader

Sep 9 2017

martinkostolny added a comment to D7610: Support for "mkdir -p" re-added.

I've noticed a regression after this push. Creation of new directory no longer focused the new directory. This should now be fixed in git with commit https://phabricator.kde.org/R167:ac22d0fc4412cc9a2f9130ba85184817c1667094. I didn't want to bother you with another review request. If there are another issues with this, I'll be happy to fix them.

Sep 9 2017, 3:19 PM · Krusader
martinkostolny added a comment to D5734: Fix lister unintended selection while scrolling.

Thanks a lot for your thorough testing :).

Sep 9 2017, 2:38 PM · Krusader
martinkostolny closed D5734: Fix lister unintended selection while scrolling by committing R167:efd0e38a7a8c: Fix lister unintended selection while scrolling..
Sep 9 2017, 2:36 PM · Krusader

Sep 6 2017

martinkostolny added a comment to D7610: Support for "mkdir -p" re-added.

Thanks for testing. Committed without the commented code line mentioned by Toni, thanks for pointing that out!

Sep 6 2017, 12:22 AM · Krusader