Wed, Jul 19
Mon, Jul 17
- Please use Bugzilla and not Phabricator for bugs and feature requests, like stated here: https://krusader.org/report-bugs/index.html
- Krusader 2.4 is outdated. Please try again with 2.5/2.6
- Information is missing about what you are actually doing while getting the error messages. Browsing facebook with Krusader?
Sun, Jul 16
Tue, Jul 11
Merged. Thanks for the patch!
I would like to solve this issue
Sat, Jul 8
Update after review. DiskUsage dialog non-modal. Segmentation fault fixed.
Thu, Jul 6
I fixed the synchronizer dialog myself, wasn't that hard. -> 67c400b5
Sorry for my ignorance with the QDialog and memory leak issue, I've now learnt from it:). I believe the code now looks fine, and works. Although I'd rather remove the parent parameter (0) from new DiskUsageGUI call or replace with MAIN_VIEW like Alex was advising.
Wed, Jul 5
Update after review
Tue, Jul 4
is a good solution (StackOverflow is your friend:) https://stackoverflow.com/q/20491864/6286694) . You can do this inside the constructor.
Mon, Jul 3
Looks good to me and works. Thanks for your code! Please see one code comment.
Sun, Jul 2
I would like to solve this issue (patch already submitted)
@miroslavm Please submit the patch as differential (== review request) and link it to this task (if this is somehow possible).
Jun 5 2017
Finally mark this done.
Jun 3 2017
May 31 2017
May 12 2017
Thanks for checking on this. I'm using your suggestion because I agree, it should be fixed closest to the source of troubles.
I usually never user krViewer.
Thanks! Can confirm in Krusader and a toy application (https://github.com/abika/cpp-qt-kf5-file-browser). Yes, it is probably a bug in Qt.
May 8 2017
And you don't have to do everything we say.
I know :), but this time I really didn't care that much.
Yes, I can reproduce this. Looks like I solved an issue and created a new one.
Alex, please check if I understood right the code combining and code comment.
Thanks for feedback! Here is an update with the option.
My apologies, Alex, I must have missed your fix otherwise I'd test my workflow right away. Now I see You have fixed most of the issues. I've found only one edge-case. Loading a profile is reusing opened tabs, so if You already have a locked tab, it is locked before openUrl() is called. Here is the minimal exact steps to reproduce it:
- start fresh krusader (empty config)
- we will focus on left panel only for this test
- go to e.g. Downloads
- save profile (e.g. "p1")
- go back to home folder and lock the tab
- load profile p1 -> You should see 2 tabs now instead of one
May 7 2017
I vote for the option.
It was clearly intended as a feature and somebody is might using it. A checkbox can also advertise the feature to users who didn't even know it was there.
This patch is just a proposal to remove this feature and leave user's clipboard alone.
When one is loading a saved Panel profile, old tabs are removed and profile-saved tabs are restored from settings. But locked tabs are loaded twice with other problems.