KrusaderProject
ActivePublic

Recent Activity

Wed, Apr 12

martinkostolny added a comment to T5716: New release: 2.6.0.

Alex, thanks a lot for making the release and updating the corresponding wiki!

Wed, Apr 12, 8:51 PM · Krusader
abika moved T5716: New release: 2.6.0 from TODO to Done on the Krusader board.
Wed, Apr 12, 4:37 PM · Krusader
abika added a comment to T5716: New release: 2.6.0.

Done. Somebody has to add 2.6.0 to the release list on bugzilla. I still don't have permission.

Wed, Apr 12, 4:36 PM · Krusader

Tue, Apr 11

abika edited the content of Krusader.
Tue, Apr 11, 6:05 PM · Krusader
abika closed D5292: Fix for crash when closing currently refreshing panel.

I took the liberty and commited your patch.

Tue, Apr 11, 5:41 PM · Krusader

Sun, Apr 9

palant added a comment to T5716: New release: 2.6.0.

After considering "Developer," "Developer (retired)" and "Code contributor" I decided to wait until next release - if I manage to keep contributing :)

Sun, Apr 9, 5:50 PM · Krusader
abika updated subscribers of T5716: New release: 2.6.0.

Tomorrow or Tuesday - hopefully.
@palant If you want to be included in the author list, added yourself to the main.cpp.

Sun, Apr 9, 5:23 PM · Krusader
abika edited the content of Krusader.
Sun, Apr 9, 5:16 PM · Krusader
abika added a comment to D5292: Fix for crash when closing currently refreshing panel.

Actually the ListPanelFunc object is destroyed before the ListPanel, so when you do the check for this->panel, this points to already freed memory.

Sun, Apr 9, 4:37 PM · Krusader
janlepper added a comment to T5716: New release: 2.6.0.

Agreed :)

Sun, Apr 9, 4:20 PM · Krusader
janlepper added a comment to D5292: Fix for crash when closing currently refreshing panel.

Hmm, I can't update the diff (permissions?)

This is safer:

diff --git a/krusader/Panel/panelfunc.cpp b/krusader/Panel/panelfunc.cpp
index 3f2b184f7..c3dcaff41 100644
--- a/krusader/Panel/panelfunc.cpp
+++ b/krusader/Panel/panelfunc.cpp
@@ -310,11 +310,15 @@ void ListPanelFunc::doRefresh()
 
     // NOTE: this is blocking. Returns false on error or interruption (cancel requested or panel
     // was deleted)
+    QPointer<ListPanel> panelSave = panel;
     const bool refreshed = fileSystemP->refresh(url);
     if (refreshed) {
         // update the history and address bar, as the actual url might differ from the one requested
         history->setCurrentUrl(fileSystemP->currentDirectory());
         panel->setNavigatorUrl(fileSystemP->currentDirectory());
+    } else if (!panelSave) {
+        // panel was deleted while refreshing
+        return;
     }
 
     panel->view->setNameToMakeCurrent(QString());
Sun, Apr 9, 3:24 PM · Krusader
janlepper added a comment to D5292: Fix for crash when closing currently refreshing panel.

Hmm, I can't update the diff (permissions?)

Sun, Apr 9, 3:12 PM · Krusader
janlepper added a comment to D5292: Fix for crash when closing currently refreshing panel.

Sorry for the even later reaction ;)
Well, the QPointer doesn't hurt, but it doesn't fix the problem in this case.
Actually the ListPanelFunc object is destroyed before the ListPanel, so when you do the check for this->panel, this points to already freed memory.

Sun, Apr 9, 2:39 PM · Krusader

Sat, Apr 8

martinkostolny added a comment to T5716: New release: 2.6.0.

I like "Stiff Challenges" very much! Agreed, 2.6.0 version makes more sense.

Sat, Apr 8, 6:38 PM · Krusader
martinkostolny added a comment to D5292: Fix for crash when closing currently refreshing panel.

Sorry for my late reaction. Yes, this is nicer and working. Thanks, Alex! To avoid waiting of each other: You do the commit :).

Sat, Apr 8, 6:35 PM · Krusader
abika renamed T5716: New release: 2.6.0 from "New release: 2.5.1" to "New release: 2.6.0".
Sat, Apr 8, 4:38 PM · Krusader
abika added a comment to T5716: New release: 2.6.0.

I agree. Probably lame but how about "Job-Man Show"? :)

Sat, Apr 8, 4:38 PM · Krusader
abika added a comment to D5292: Fix for crash when closing currently refreshing panel.

Ok now?

Sat, Apr 8, 3:42 PM · Krusader
abika updated the diff for D5292: Fix for crash when closing currently refreshing panel.
  • Fix for crash when closing currently refreshing panel
  • Safer version of "Fix for crash when closing currently refreshing panel" (f01640db)
Sat, Apr 8, 3:40 PM · Krusader

Wed, Apr 5

abika added a comment to D5292: Fix for crash when closing currently refreshing panel.

The code was ugly, but accessing a deleted object results in undefinefd behaviour.

Wed, Apr 5, 9:01 PM · Krusader

Tue, Apr 4

janlepper added a comment to D5292: Fix for crash when closing currently refreshing panel.
In D5292#99747, @abika wrote:

There has been code in place to prevent this, but looking at PanelManager::deletePanel(), the panel is now unconditionally deleted.
So a proper fix would be to re-introduce the previous behaviour.

I removed the whole code together with the previous check

if (p && p->func && p->func->files() && !p->func->files()->vfs_canDelete()) {
    connect(p->func->files(), SIGNAL(deleteAllowed()), p, SLOT(deleteLater()));
    p->func->files()->vfs_requestDelete();
    return;

mainly because it doesn't follow the principle of encapsulation in OOP. The panel manager should not have to check the inner state of the filesystem refresh invoked by the panel function object.
This fix is totally fine imo.

Tue, Apr 4, 10:12 PM · Krusader
abika accepted D5292: Fix for crash when closing currently refreshing panel.

There has been code in place to prevent this, but looking at PanelManager::deletePanel(), the panel is now unconditionally deleted.
So a proper fix would be to re-introduce the previous behaviour.

Tue, Apr 4, 2:33 PM · Krusader
janlepper added a comment to D5292: Fix for crash when closing currently refreshing panel.

I'm sorry for the regression.
I assumed this situation (a panel was destroyed while still refreshing) wouldn't occur.
There has been code in place to prevent this, but looking at PanelManager::deletePanel(), the panel is now unconditionally deleted.
So a proper fix would be to re-introduce the previous behaviour.

Tue, Apr 4, 10:08 AM · Krusader

Mon, Apr 3

martinkostolny updated the summary of D5292: Fix for crash when closing currently refreshing panel.
Mon, Apr 3, 10:33 PM · Krusader
martinkostolny created D5292: Fix for crash when closing currently refreshing panel.
Mon, Apr 3, 10:32 PM · Krusader

Fri, Mar 31

ltoscano closed D5207: Port kde4_add_app_icon to ecm_add_app_icon by committing R167:e08b0c9bb0f9: Port kde4_add_app_icon to ecm_add_app_icon.
Fri, Mar 31, 8:39 PM · Krusader
abika accepted D5207: Port kde4_add_app_icon to ecm_add_app_icon.

Same here: can compile but not test. I guess, its fine.

Fri, Mar 31, 7:37 PM · Krusader
ltoscano added a comment to D5207: Port kde4_add_app_icon to ecm_add_app_icon.

Ping?

Fri, Mar 31, 3:28 PM · Krusader

Mon, Mar 27

ltoscano added a reviewer for D5207: Port kde4_add_app_icon to ecm_add_app_icon: Krusader.
Mon, Mar 27, 9:31 PM · Krusader

Mar 24 2017

martinkostolny added a comment to T5716: New release: 2.6.0.

I agree. Probably lame but how about "Job-Man Show"? :)

Mar 24 2017, 6:52 AM · Krusader

Mar 20 2017

abika created T5716: New release: 2.6.0.
Mar 20 2017, 10:10 PM · Krusader

Mar 16 2017

janlepper added a comment to T5673: Fix unsafe lambda usage.

That was fast - thanks!

Mar 16 2017, 12:32 PM · Krusader
abika closed T5673: Fix unsafe lambda usage as "Resolved".

Done with 5a26343a.

Mar 16 2017, 12:06 PM · Krusader
abika added a comment to T5673: Fix unsafe lambda usage.

Thanks for pointing this out! It's my code so I will fix it right away.

Mar 16 2017, 11:53 AM · Krusader
janlepper created T5673: Fix unsafe lambda usage.
Mar 16 2017, 10:55 AM · Krusader

Mar 12 2017

abika edited the content of Krusader.
Mar 12 2017, 8:11 PM · Krusader

Mar 10 2017

palant removed a member for Krusader: palant.
Mar 10 2017, 8:55 AM

Mar 7 2017

janlepper added a comment to T5062: Improve search results tab.

Right, I didn't really think this through.
So it's probably the lesser effort to embed Lister into the result view.

Mar 7 2017, 11:24 AM · Krusader

Mar 6 2017

palant added a comment to T5062: Improve search results tab.

Yes, I meant that it won't benefit too many people as long as the default viewer isn't the lister.

Mar 6 2017, 8:40 AM · Krusader

Mar 5 2017

janlepper closed D4146: ListPanel: don't go back in history if refresh failed by committing R167:184946fb4255: Merge branch 'my-listpanel_refresh_rework'.
Mar 5 2017, 7:41 PM · Krusader
janlepper raised the priority of T5017: Avoid nested event dispatching from "Normal" to "Needs Triage".
Mar 5 2017, 6:39 PM · Krusader
janlepper claimed T5057: Check usage of QDir::setCurrent().
Mar 5 2017, 6:39 PM · Krusader
janlepper added a comment to T5062: Improve search results tab.

Well, you could add
static void KViewer::viewWithLister(QUrl url, QString searchText)

Mar 5 2017, 6:30 PM · Krusader
aacid resigned from D4146: ListPanel: don't go back in history if refresh failed.

Krusader people, will someone please commit this?

Mar 5 2017, 6:20 PM · Krusader
janlepper updated the diff for D4146: ListPanel: don't go back in history if refresh failed.

rebased

Mar 5 2017, 6:04 PM · Krusader

Mar 3 2017

aacid requested changes to D4146: ListPanel: don't go back in history if refresh failed.

Patch doesn't seem to apply

Mar 3 2017, 8:37 PM · Krusader
janlepper removed a reviewer for D4146: ListPanel: don't go back in history if refresh failed: gengisdave.

I assume gengisdave won't comment on this (hasn't been active for a while)

Mar 3 2017, 2:31 PM · Krusader
janlepper added a comment to D4146: ListPanel: don't go back in history if refresh failed.
In D4146#84250, @abika wrote:

I personally prefer the old behavior. After restart going back to the "nearest" parent folder of a deleted path was pretty nice. And if it was a removable device I can mount it and go back to the folder with the history.

But whatever, another user setting for this would be too much. And yes, the while (true) loop wasn't nice.

Mar 3 2017, 2:25 PM · Krusader

Mar 1 2017

abika added a comment to D4146: ListPanel: don't go back in history if refresh failed.

FYI: https://bugs.kde.org/show_bug.cgi?id=298292

Mar 1 2017, 7:00 PM · Krusader
martinkostolny closed D4828: Duplicated tab should not be locked by committing R167:70bbac90cd0e: Duplicated tab should not be locked.
Mar 1 2017, 11:30 AM · Krusader