KrusaderProject
ActivePublic

Recent Activity

Today

gengisdave closed D21323: Shortcuts for move tab.

Forgot to add the reference to this revision in the commit message, closed with Shortcuts to move tab

Sun, Jun 16, 11:10 AM · Krusader
fbampaloukas added a watcher for Krusader: fbampaloukas.
Sun, Jun 16, 8:33 AM

Fri, Jun 14

nmel accepted D21323: Shortcuts for move tab.

New revision is also good - feel free to push to master.

Fri, Jun 14, 5:25 AM · Krusader

Sun, Jun 9

gengisdave updated the diff for D21323: Shortcuts for move tab.

Removed the single tab check in favor of a comment, like proposed by @abika

Sun, Jun 9, 6:20 AM · Krusader

Sun, Jun 2

abika added a comment to D21323: Shortcuts for move tab.

@gengisdave : A comment would be nice. Thanks.

Sun, Jun 2, 3:04 PM · Krusader

Wed, May 29

gengisdave added a comment to D21323: Shortcuts for move tab.

@abika : this is intentional to define that these two methods do nothing when the panel has just one tab, I can change them with a comment remarking this logic

Wed, May 29, 5:18 AM · Krusader

Sat, May 25

abika accepted D21323: Shortcuts for move tab.

Looks good. Thanks for the improvement!

Sat, May 25, 4:56 PM · Krusader
asensi accepted D21323: Shortcuts for move tab.

The new code works using Kubuntu 19.04. Other people can do their checks. Davide, using the same keys as Chromium, Firefox, Libreoffice Calc, etc. is a advantage. Thanks, Davide! (and Nikita :-) )

Sat, May 25, 7:09 AM · Krusader

Wed, May 22

nmel accepted D21323: Shortcuts for move tab.

Thanks Davide!

Wed, May 22, 6:58 AM · Krusader

Tue, May 21

yurchor added a comment to D21323: Shortcuts for move tab.

Tested to compile, install and work as expected.

Tue, May 21, 7:21 PM · Krusader
gengisdave requested review of D21323: Shortcuts for move tab.
Tue, May 21, 7:00 PM · Krusader

May 5 2019

abika added a comment to D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).

Thanks Nikita! Changes applied and pushed into maste.

May 5 2019, 7:24 PM · Krusader
Diffusion closed D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).
May 5 2019, 7:23 PM · Krusader
abika updated the diff for D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).
  • fixup! FileSystem: Fix using creation time from KIO as changed time (ctime)
May 5 2019, 7:18 PM · Krusader

Apr 27 2019

nmel accepted D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).

Thanks for the fix and refactoring, Alex! Compiles and works as expected. Please check my inline comments.

Apr 27 2019, 3:47 AM · Krusader

Apr 22 2019

abika added a project to D20741: FileSystem: Fix using creation time from KIO as changed time (ctime): Krusader.
Apr 22 2019, 3:58 PM · Krusader

Apr 15 2019

nmel added a comment to D20373: Updated minimal Qt version to the earliest supported version (5.9).

Thank you, Yuri and Alex!

Apr 15 2019, 6:51 AM · Krusader
nmel closed D20373: Updated minimal Qt version to the earliest supported version (5.9).
Apr 15 2019, 6:49 AM · Krusader

Apr 13 2019

abika accepted D20373: Updated minimal Qt version to the earliest supported version (5.9).

After rethinking this, I agree with you, Nikita. We should not impose the burden of supporting an outdated Qt version on ourself.

Apr 13 2019, 4:40 PM · Krusader

Apr 10 2019

yurchor accepted D20373: Updated minimal Qt version to the earliest supported version (5.9).
Apr 10 2019, 7:21 AM · Krusader
nmel added reviewers for D20373: Updated minimal Qt version to the earliest supported version (5.9): mchabrecek, abika, yurchor.
Apr 10 2019, 6:49 AM · Krusader

Apr 8 2019

nmel added a project to D20373: Updated minimal Qt version to the earliest supported version (5.9): Krusader.

QOverload is only available in Qt >= 5.7, and Qt 5.9 is the earliest supported version.
See also https://bugs.kde.org/show_bug.cgi?id=405212 .
I proposed this change in the discussion of D19623 and there were no objections for a month.

Apr 8 2019, 7:59 AM · Krusader

Mar 8 2019

Diffusion closed D19277: Create new text files with umask applied.
Mar 8 2019, 8:21 PM · Krusader
abika added a comment to D19277: Create new text files with umask applied.

Thanks! Landed (Hope this revision will close itself).

Mar 8 2019, 7:45 PM · Krusader

Mar 7 2019

nmel accepted D19277: Create new text files with umask applied.

Tested with various umasks and local / remote fs - works nicely. Please don't forget to fix the build (and possibly, the commit messages) before merging. Thanks!

Mar 7 2019, 6:54 AM · Krusader

Mar 4 2019

nmel added a comment to D19277: Create new text files with umask applied.

Alex, it looks good now - thanks! Let me test it and I'll get back to you in a few days.

Mar 4 2019, 7:44 AM · Krusader

Mar 3 2019

abika updated the summary of D19277: Create new text files with umask applied.
Mar 3 2019, 7:16 PM · Krusader
abika added a comment to D19277: Create new text files with umask applied.

You're right Nikita. I changed it now so that local files are created with QFile. Umask is applied here.

Mar 3 2019, 7:07 PM · Krusader
abika updated the diff for D19277: Create new text files with umask applied.
  • SQUASH_ME Panel: Create new local text files directly with QFile
Mar 3 2019, 7:05 PM · Krusader

Feb 25 2019

nmel added a comment to D19277: Create new text files with umask applied.

Refactoring code is fine, however setting 644 unconditionally introduces a security issue. The permissions for new files should follow umask setting. Otherwise users may unintentionally share their new files with other users.

Feb 25 2019, 6:49 AM · Krusader
nmel closed D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
Feb 25 2019, 6:32 AM · Krusader

Feb 24 2019

abika added a comment to D19104: Search: Improve right-click context menu.

Thanks for the reviews!

Feb 24 2019, 5:08 PM · Krusader
Diffusion closed D19104: Search: Improve right-click context menu.
Feb 24 2019, 5:07 PM · Krusader
abika accepted D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Thanks. Working fine.

Feb 24 2019, 4:17 PM · Krusader
abika added a project to D19277: Create new text files with umask applied: Krusader.
Feb 24 2019, 4:02 PM · Krusader

Feb 18 2019

nmel added reviewers for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert: abika, asensi, mchabrecek.
Feb 18 2019, 7:53 AM · Krusader
nmel accepted D19104: Search: Improve right-click context menu.

Nice fix and improvement. Thanks!

Feb 18 2019, 7:50 AM · Krusader
nmel updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
  • fixed build and formatting
Feb 18 2019, 7:13 AM · Krusader
nmel commandeered D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Due to no response from Davide, I'm taking over. I also see lots of deprecation warnings and would like to fix it. The most recent revision doesn't compile, however. I have a fix and will update shortly.

Feb 18 2019, 7:11 AM · Krusader

Feb 17 2019

yurchor added a comment to D19104: Search: Improve right-click context menu.

+1
Compiles, installs and works as expected.

Feb 17 2019, 8:31 PM · Krusader
abika added a project to D19104: Search: Improve right-click context menu: Krusader.
Feb 17 2019, 8:03 PM · Krusader

Nov 9 2018

mchabrecek added a comment to T2966: Code Cleaning.

Kindly ping.

Nov 9 2018, 9:16 AM · Krusader

Nov 6 2018

mchabrecek added a comment to T2966: Code Cleaning.

Hello All,

Nov 6 2018, 8:07 AM · Krusader

Oct 27 2018

nmel requested changes to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Kindly ping.

Oct 27 2018, 7:52 AM · Krusader

Oct 26 2018

mchabrecek added a comment to T2966: Code Cleaning.

Hello Guys,

Oct 26 2018, 10:00 AM · Krusader

Oct 21 2018

mchabrecek closed D16223: Replaced old connect() with QT5 style. Part 1.
Oct 21 2018, 9:46 PM · Krusader

Oct 20 2018

yurchor added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

OK, so will you provide me the necessary permissions for that? I suppose, it is this repository: git@git.kde.org:krusader.git

Oct 20 2018, 7:21 PM · Krusader

Oct 19 2018

mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#345641, @nmel wrote:

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Since this is a single change and not multiple related changes, I would squash your branch into a single commit, rebase on top of the master, add the CR link and push it. Thanks!

Oct 19 2018, 12:37 PM · Krusader
nmel added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Oct 19 2018, 6:30 AM · Krusader

Oct 17 2018

mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#344206, @nmel wrote:

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

For minor tweaks like this we usually approve and let author incorporate the fixes before pushing. Just to reduce turnaround time. Of course, if someone else pushes (or lands) the change, the author should send updated diff first.

Miroslav, are you going to push this change to the repo or you want us to do it? I think it's worth getting the permission as you're going to do several consecutive changes on this refactoring and, hopefully, other improvements. Please read our commit guidelines before pushing.

Oct 17 2018, 7:56 AM · Krusader