Mon, Apr 22
Mon, Apr 15
Thank you, Yuri and Alex!
Sat, Apr 13
After rethinking this, I agree with you, Nikita. We should not impose the burden of supporting an outdated Qt version on ourself.
Wed, Apr 10
Mon, Apr 8
QOverload is only available in Qt >= 5.7, and Qt 5.9 is the earliest supported version.
See also https://bugs.kde.org/show_bug.cgi?id=405212 .
I proposed this change in the discussion of D19623 and there were no objections for a month.
Mar 8 2019
Thanks! Landed (Hope this revision will close itself).
Mar 7 2019
Tested with various umasks and local / remote fs - works nicely. Please don't forget to fix the build (and possibly, the commit messages) before merging. Thanks!
Mar 4 2019
Alex, it looks good now - thanks! Let me test it and I'll get back to you in a few days.
Mar 3 2019
You're right Nikita. I changed it now so that local files are created with QFile. Umask is applied here.
- SQUASH_ME Panel: Create new local text files directly with QFile
Feb 25 2019
Refactoring code is fine, however setting 644 unconditionally introduces a security issue. The permissions for new files should follow umask setting. Otherwise users may unintentionally share their new files with other users.
Feb 24 2019
Thanks for the reviews!
Thanks. Working fine.
Feb 18 2019
Nice fix and improvement. Thanks!
- fixed build and formatting
Due to no response from Davide, I'm taking over. I also see lots of deprecation warnings and would like to fix it. The most recent revision doesn't compile, however. I have a fix and will update shortly.
Feb 17 2019
Compiles, installs and works as expected.
Nov 9 2018
Nov 6 2018
Oct 27 2018
Oct 26 2018
Oct 21 2018
Oct 20 2018
OK, so will you provide me the necessary permissions for that? I suppose, it is this repository: firstname.lastname@example.org:krusader.git
Oct 19 2018
Oct 17 2018
Oct 16 2018
- Fixed spacing
Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?
You have to make the changes requested by Nikita.
Thanks and welcome aboard Miroslav!
Looks much better, thanks!
Oct 15 2018
I only skim-read the changes, looks fine.
And Krusader seems to work with the changes.
I have submitted the first patch here regarding signals and slots. It doesn't solve all the connect() statements. There many hundreds of them. I want to do it in more patches. One reason is that this is my first patch to this project. So I didn't work at something for 6 months and then struggle to submit it. It is here, can you check it? https://phabricator.kde.org/D16223.
Oct 11 2018
I thought I had already committed that... changed to a more human macro name
Oct 9 2018
Thank you for help,
Oct 7 2018
Maybe a visual hint would be good so that the users know this feature exists.
Some changes were made after Alex Bikadorov made some propositions.