KrusaderProject
ActivePublic

Recent Activity

Yesterday

asensi accepted D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

(optional) I'd use QFontMetrics::horizontalAdvance(A) and QFontMetrics::width(A) for additional type check.

Tue, Jul 23, 10:11 PM · Krusader
asensi requested review of D22673: Set the focus on the first search result.
Tue, Jul 23, 6:38 AM · Krusader

Mon, Jul 22

asensi requested review of D22666: Achieve that Krusader searches correctly if the the "Follow links" checkbox is disabled.
Mon, Jul 22, 10:06 PM · Krusader
nmel accepted D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

Thanks Davide! It's cleaner and macro name is good. No issues with fonts were discovered when I tested.

Mon, Jul 22, 6:26 AM · Krusader
nmel closed D22602: Updated copyright years.
Mon, Jul 22, 6:15 AM · Krusader, Documentation

Sun, Jul 21

gengisdave accepted D22602: Updated copyright years.

No objections

Sun, Jul 21, 6:55 PM · Krusader, Documentation
gengisdave updated the diff for D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

Changed with macro, as suggested by @nmel; the code now is cleaner (and QFONTMETRICS_HORIZONTAL_ADVANCE seems a bit long)

Sun, Jul 21, 6:36 PM · Krusader
abika added a comment to D22177: Panel: Improve open actions in context menu.

Thanks for testing again!

Sun, Jul 21, 4:18 PM · Krusader
Diffusion closed D22177: Panel: Improve open actions in context menu.
Sun, Jul 21, 4:17 PM · Krusader
abika added a comment to D22174: Synchronizer: Set column headers to adjust widths automatically.

Thanks for testing everyone!

Sun, Jul 21, 3:59 PM · Krusader
Diffusion closed D22174: Synchronizer: Set column headers to adjust widths automatically.
Sun, Jul 21, 3:57 PM · Krusader
gengisdave closed D22443: Wrap text in copy/move confirmation dialog.
Sun, Jul 21, 3:46 PM · Krusader
gengisdave closed D22435: Remove obsolete qt version check.
Sun, Jul 21, 3:34 PM · Krusader
nmel added a comment to D22443: Wrap text in copy/move confirmation dialog.

If you'd like this fix to be included into v2.7.2, please merge by the end of the month.

Sun, Jul 21, 6:13 AM · Krusader
nmel added a comment to D22174: Synchronizer: Set column headers to adjust widths automatically.

If you'd like this fix to be included into v2.7.2, please merge by the end of the month.

Sun, Jul 21, 6:10 AM · Krusader
nmel added a project to D22602: Updated copyright years: Krusader.
Sun, Jul 21, 6:04 AM · Krusader, Documentation
asensi accepted D22435: Remove obsolete qt version check.

It's an improvement. Thanks!

Sun, Jul 21, 5:32 AM · Krusader

Sat, Jul 20

nmel accepted D22443: Wrap text in copy/move confirmation dialog.

It works fine but please fix coding style before pushing your changes. Thanks!

Sat, Jul 20, 6:44 AM · Krusader
nmel requested changes to D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

I agree we can substitute the width method with the horizontalAdvance, however I propose we use compat.h to eliminate code duplication here.

Sat, Jul 20, 6:35 AM · Krusader
nmel accepted D22435: Remove obsolete qt version check.

Reasonable!

Sat, Jul 20, 6:22 AM · Krusader
nmel added a comment to D22431: Fixed lost editor when file is updating and the list model to correctly handle next item.

Thanks for checking, Davide! :)

Sat, Jul 20, 6:20 AM · Krusader
nmel closed D22431: Fixed lost editor when file is updating and the list model to correctly handle next item.
Sat, Jul 20, 6:17 AM · Krusader

Fri, Jul 19

asensi accepted D22177: Panel: Improve open actions in context menu.
Fri, Jul 19, 10:32 PM · Krusader
asensi accepted D22174: Synchronizer: Set column headers to adjust widths automatically.

The new code works using Kubuntu 18.04. Although the final behavior of Synchronizer is not perfect, the patch improves the current situation, therefore: thanks, Alex! (and Yuri :-) )

Fri, Jul 19, 10:27 PM · Krusader

Thu, Jul 18

asensi added a comment to D22177: Panel: Improve open actions in context menu.

The new code works as expected using Kubuntu 18.04. Thanks, Alex! (and Yuri and Nikita :-) )

Thu, Jul 18, 9:36 PM · Krusader
gengisdave added a comment to D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

@yurchor : I follwed the guidelines from the documentation (https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width); I haven't tried to see where the difference really is, I think there could be some pixel overlapped or some extra space.

Thu, Jul 18, 6:29 PM · Krusader
yurchor added a comment to D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

Isn't it be easier to use boundingRect(text).width() as a replacement of horizontalAdvance(text) which does not require Qt 5.11 and is not deprecated?

Thu, Jul 18, 5:06 PM · Krusader
yurchor closed D22504: Get rid of some deprecated methods.
Thu, Jul 18, 2:54 PM · Krusader
gengisdave accepted D22504: Get rid of some deprecated methods.

Looking at Qt, all the new methods are present in version 5.9 so that no checks with preprocessor are needed.

Thu, Jul 18, 2:40 PM · Krusader

Wed, Jul 17

gengisdave added a project to D22504: Get rid of some deprecated methods: Krusader.
Wed, Jul 17, 10:15 AM · Krusader

Sat, Jul 13

gengisdave requested review of D22443: Wrap text in copy/move confirmation dialog.
Sat, Jul 13, 4:43 PM · Krusader
gengisdave requested review of D22435: Remove obsolete qt version check.
Sat, Jul 13, 12:13 PM · Krusader
gengisdave requested review of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Sat, Jul 13, 12:03 PM · Krusader
gengisdave accepted D22431: Fixed lost editor when file is updating and the list model to correctly handle next item.

Tested on Fedora 30; it compiles and the bug is not present anymore; during the same test, a Krusader version without this patch was having this problem while the patched one was able to rename the file.

Sat, Jul 13, 9:52 AM · Krusader
nmel added a comment to D22177: Panel: Improve open actions in context menu.

Reminder for git push :)

Sat, Jul 13, 7:04 AM · Krusader
nmel added a project to D22431: Fixed lost editor when file is updating and the list model to correctly handle next item: Krusader.
Sat, Jul 13, 6:59 AM · Krusader

Wed, Jul 3

yurchor added a comment to D22174: Synchronizer: Set column headers to adjust widths automatically.

Works fine for me (3-day testing). Thanks.

Wed, Jul 3, 5:02 PM · Krusader

Mon, Jul 1

nmel accepted D22177: Panel: Improve open actions in context menu.

Reviewed the code and tested — everything is great!

Mon, Jul 1, 6:32 AM · Krusader

Sun, Jun 30

yurchor added a comment to D22177: Panel: Improve open actions in context menu.

Tested to work as expected.

Sun, Jun 30, 7:07 PM · Krusader
abika added a project to D22177: Panel: Improve open actions in context menu: Krusader.
Sun, Jun 30, 6:11 PM · Krusader
abika added a project to D22174: Synchronizer: Set column headers to adjust widths automatically: Krusader.
Sun, Jun 30, 5:04 PM · Krusader

Jun 16 2019

gengisdave closed D21323: Shortcuts for move tab.

Forgot to add the reference to this revision in the commit message, closed with Shortcuts to move tab

Jun 16 2019, 11:10 AM · Krusader
fbampaloukas added a watcher for Krusader: fbampaloukas.
Jun 16 2019, 8:33 AM

Jun 14 2019

nmel accepted D21323: Shortcuts for move tab.

New revision is also good - feel free to push to master.

Jun 14 2019, 5:25 AM · Krusader

Jun 9 2019

gengisdave updated the diff for D21323: Shortcuts for move tab.

Removed the single tab check in favor of a comment, like proposed by @abika

Jun 9 2019, 6:20 AM · Krusader

Jun 2 2019

abika added a comment to D21323: Shortcuts for move tab.

@gengisdave : A comment would be nice. Thanks.

Jun 2 2019, 3:04 PM · Krusader

May 29 2019

gengisdave added a comment to D21323: Shortcuts for move tab.

@abika : this is intentional to define that these two methods do nothing when the panel has just one tab, I can change them with a comment remarking this logic

May 29 2019, 5:18 AM · Krusader

May 25 2019

abika accepted D21323: Shortcuts for move tab.

Looks good. Thanks for the improvement!

May 25 2019, 4:56 PM · Krusader
asensi accepted D21323: Shortcuts for move tab.

The new code works using Kubuntu 19.04. Other people can do their checks. Davide, using the same keys as Chromium, Firefox, Libreoffice Calc, etc. is a advantage. Thanks, Davide! (and Nikita :-) )

May 25 2019, 7:09 AM · Krusader

May 22 2019

nmel accepted D21323: Shortcuts for move tab.

Thanks Davide!

May 22 2019, 6:58 AM · Krusader