KrusaderProject
ActivePublic

Recent Activity

Nov 9 2018

mchabrecek added a comment to T2966: Code Cleaning.

Kindly ping.

Nov 9 2018, 9:16 AM · Krusader

Nov 6 2018

mchabrecek added a comment to T2966: Code Cleaning.

Hello All,

Nov 6 2018, 8:07 AM · Krusader

Oct 27 2018

nmel requested changes to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Kindly ping.

Oct 27 2018, 7:52 AM · Krusader

Oct 26 2018

mchabrecek added a comment to T2966: Code Cleaning.

Hello Guys,

Oct 26 2018, 10:00 AM · Krusader

Oct 21 2018

mchabrecek closed D16223: Replaced old connect() with QT5 style. Part 1.
Oct 21 2018, 9:46 PM · Krusader

Oct 20 2018

yurchor added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

OK, so will you provide me the necessary permissions for that? I suppose, it is this repository: git@git.kde.org:krusader.git

Oct 20 2018, 7:21 PM · Krusader

Oct 19 2018

mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#345641, @nmel wrote:

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Since this is a single change and not multiple related changes, I would squash your branch into a single commit, rebase on top of the master, add the CR link and push it. Thanks!

Oct 19 2018, 12:37 PM · Krusader
nmel added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Oct 19 2018, 6:30 AM · Krusader

Oct 17 2018

mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#344206, @nmel wrote:

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

For minor tweaks like this we usually approve and let author incorporate the fixes before pushing. Just to reduce turnaround time. Of course, if someone else pushes (or lands) the change, the author should send updated diff first.

Miroslav, are you going to push this change to the repo or you want us to do it? I think it's worth getting the permission as you're going to do several consecutive changes on this refactoring and, hopefully, other improvements. Please read our commit guidelines before pushing.

Oct 17 2018, 7:56 AM · Krusader

Oct 16 2018

nmel accepted D16223: Replaced old connect() with QT5 style. Part 1.

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

Oct 16 2018, 3:36 PM · Krusader
mchabrecek updated the diff for D16223: Replaced old connect() with QT5 style. Part 1.
  • Fixed spacing
Oct 16 2018, 10:26 AM · Krusader
shubham added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

You have to make the changes requested by Nikita.

Oct 16 2018, 10:07 AM · Krusader
mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#343997, @nmel wrote:

Thanks and welcome aboard Miroslav!

Oct 16 2018, 9:00 AM · Krusader
nmel accepted D16223: Replaced old connect() with QT5 style. Part 1.

Thanks and welcome aboard Miroslav!

Oct 16 2018, 7:21 AM · Krusader
nmel added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Looks much better, thanks!

Oct 16 2018, 6:27 AM · Krusader

Oct 15 2018

abika added inline comments to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Oct 15 2018, 7:04 PM · Krusader
abika accepted D16223: Replaced old connect() with QT5 style. Part 1.

I only skim-read the changes, looks fine.
And Krusader seems to work with the changes.

Oct 15 2018, 6:43 PM · Krusader
abika added a project to D16223: Replaced old connect() with QT5 style. Part 1: Krusader.
Oct 15 2018, 6:28 PM · Krusader
mchabrecek added a comment to T2966: Code Cleaning.

I have submitted the first patch here regarding signals and slots. It doesn't solve all the connect() statements. There many hundreds of them. I want to do it in more patches. One reason is that this is my first patch to this project. So I didn't work at something for 6 months and then struggle to submit it. It is here, can you check it? https://phabricator.kde.org/D16223.

Oct 15 2018, 1:43 PM · Krusader

Oct 11 2018

gengisdave updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

I thought I had already committed that... changed to a more human macro name

Oct 11 2018, 8:20 PM · Krusader

Oct 9 2018

mchabrecek added a comment to T2966: Code Cleaning.

Thank you for help,

Oct 9 2018, 9:35 AM · Krusader

Oct 7 2018

asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Maybe a visual hint would be good so that the users know this feature exists.

Oct 7 2018, 5:26 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Some changes were made after Alex Bikadorov made some propositions.

Oct 7 2018, 5:01 PM · Krusader
asensi added inline comments to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Oct 7 2018, 4:43 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Some changes were made after Alex Bikadorov made some propositions.

Oct 7 2018, 4:08 PM · Krusader

Oct 6 2018

abika added a comment to T2966: Code Cleaning.

Hi Miro,

Oct 6 2018, 3:28 PM · Krusader
mchabrecek placed T2966: Code Cleaning up for grabs.

Hello,
I started to work on replacing old connect() wih Qt5 syntax.
Alex wrote me that it would be the best to do automatically by some script, I don't see it realistic.
There are some tricky cases, which I don't know how to convert. May be you can help me.

Oct 6 2018, 8:20 AM · Krusader

Oct 4 2018

abika requested changes to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Deletion was working as expected during tests. Maybe a visual hint would be good so that the users know this feature exists.

Oct 4 2018, 7:22 PM · Krusader

Oct 2 2018

asensi added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Since INSERT becomes kind of "global" macro, I suggest we rename it to UDS_ENTRY_INSERT, since the insert word is too generic while the implementation is not. Thanks!

Oct 2 2018, 5:13 PM · Krusader
mchabrecek added a member for Krusader: mchabrecek.
Oct 2 2018, 4:25 PM

Sep 28 2018

asensi closed D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Sep 28 2018, 6:38 AM · Krusader

Sep 23 2018

asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Another address was updated

Sep 23 2018, 6:55 AM · Krusader

Sep 22 2018

asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

An address was updated

Sep 22 2018, 6:11 PM · Krusader
asensi requested review of D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Sep 22 2018, 4:22 PM · Krusader
asensi updated the diff for D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.

Thanks, Nikita, those lines will be added to the commit message:

FIXED: Memory leak in the Locate dialog
Differential Revision: https://phabricator.kde.org/D15678
Sep 22 2018, 3:57 PM · Krusader
asensi added a comment to D15400: Fix compile warnings on missing override declarations.

Confirmed by the build (https://build.kde.org/job/Extragear/job/krusader/job/kf5-qt5%20FreeBSDQt5.11/4/warnings12Result/), 51 warnings fixed and 'missing-override' is not in the remaining 57.

Sep 22 2018, 9:57 AM · Krusader
gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

Confirmed by the build (https://build.kde.org/job/Extragear/job/krusader/job/kf5-qt5%20FreeBSDQt5.11/4/warnings12Result/), 51 warnings fixed and 'missing-override' is not in the remaining 57.

Sep 22 2018, 9:03 AM · Krusader
gengisdave closed D15400: Fix compile warnings on missing override declarations.
Sep 22 2018, 8:54 AM · Krusader
nmel added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Thanks Davide! This looks less cluttered.

Sep 22 2018, 5:31 AM · Krusader
nmel accepted D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.

Thanks Toni!

Sep 22 2018, 5:18 AM · Krusader
nmel added a comment to D15400: Fix compile warnings on missing override declarations.

every user is a tester too.

More importantly, whenever we make a change after this is merged, we will see the warning and fix the code. We put an effort before v2.7 release to make Krusader warning-free and we should keep it this way. So now the -Wsuggest-override is on the list of warning directives that we track. Thanks Davide (and Toni ;) )!

Sep 22 2018, 5:04 AM · Krusader

Sep 21 2018

asensi updated the test plan for D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Sep 21 2018, 1:35 PM · Krusader
asensi requested review of D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Sep 21 2018, 1:28 PM · Krusader
asensi accepted D15400: Fix compile warnings on missing override declarations.

The new version works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide! (and Nikita :-) )

Sep 21 2018, 1:17 PM · Krusader

Sep 19 2018

gengisdave updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Changed in favor of a macro solution (as suggested by Nikita).

Sep 19 2018, 2:15 PM · Krusader
gengisdave added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

What do you think about creating a specialized version of UDSEntry, e.g. KrUDSEntry? This way the code:

Sep 19 2018, 12:15 PM · Krusader
gengisdave updated the diff for D15400: Fix compile warnings on missing override declarations.

Added flag for GCC as default

Sep 19 2018, 11:59 AM · Krusader
gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

I've looked at the Clang behaviour: the -Winconsistent-missing-override flag is always set (Debug, Release and none), so GCC should be set the same. My initial thought was to not users to be worried; on a second thought, every user is a tester too.

Sep 19 2018, 11:42 AM · Krusader

Sep 15 2018

nmel added a comment to D15400: Fix compile warnings on missing override declarations.

Why not to update the flags for both debug and release (CMAKE_CXX_FLAGS var)? What's your reasoning? Does it hurt the release build?

Sep 15 2018, 5:17 AM · Krusader

Sep 14 2018

gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

I've tested with clang compiler and no additional flags are needed, on a clean Fedora 28 I used:

Sep 14 2018, 8:25 AM · Krusader