KrusaderProject
ActivePublic

Recent Activity

Today

asensi accepted D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

For my part, I accept the proposal, Thanks for it, Nikita!

Sun, Aug 18, 7:57 PM · Krusader
asensi added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Well, some months have passed since Davide's commit :-( , let's see when normal Krusader users can take profit.

Sun, Aug 18, 7:50 PM · Krusader
asensi added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
In D22957#513827, @nmel wrote:

This is a very serious change because now #ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN will include the code that previously was ignored. We must look at all those code paths and test features it affects. BTW, does it mean that some of those code paths do not work correctly in the current state?

Sun, Aug 18, 7:41 PM · Krusader
asensi updated the summary of D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
Sun, Aug 18, 7:33 PM · Krusader
asensi updated subscribers of D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.
Sun, Aug 18, 7:24 PM · Krusader
asensi requested review of D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.
Sun, Aug 18, 7:20 PM · Krusader
nmel added a comment to D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

When I see the usage of the method, like

const float fontWidth = (fm.QFONTMETRICS_WIDTH("WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW") - fm.QFONTMETRICS_WIDTH("W")) / 99.0;

or

headerView->resizeSection(KrViewProperties::Ext, QFontMetrics(_viewFont).QFONTMETRICS_WIDTH("tar.bz2  "));
headerView->resizeSection(KrViewProperties::KrPermissions, QFontMetrics(_viewFont).QFONTMETRICS_WIDTH("rwx  "));
headerView->resizeSection(KrViewProperties::Size, QFontMetrics(_viewFont).QFONTMETRICS_WIDTH("9") * 10);

which are all dirty hacks, I doubt we need to care too much about the differences mentioned. This code needs to be refactored properly but it's not a goal of this change. QFONTMETRICS_WIDTH will actually become a good marker of the places that need review if someone will find time and courage to make it right one day...

Sun, Aug 18, 6:47 AM · Krusader
nmel added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.

This is a very serious change because now #ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN will include the code that previously was ignored. We must look at all those code paths and test features it affects. BTW, does it mean that some of those code paths do not work correctly in the current state?

Sun, Aug 18, 6:37 AM · Krusader
nmel added a comment to D23118: Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator.

Good catch, Toni! No objections for the new shortcut. Please look into

  1. Making the commit headline shorter. Something like "Changed shortcut for the embedded terminal emulator". It's easier to read in the graph view. Please keep everything else, it's very good to have a detailed explanation in the commit message!
  2. Specifying CHANGED: tag, so this is not missed in the ChangeLog on the next release.
Sun, Aug 18, 6:30 AM · Krusader
nmel added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

I have no problem when someone is trying to improve a dead branch. If the person finds this useful and wants to share their changes to others — he or she is welcome to do so. It's an Open Source after all. In the same time, I understand what Luigi is saying that it might send a wrong signal to users. In addition, commits we push to the official repo are reviewed and tested, and should be only pushed when approved by at least another dev and no objections from others (unfortunately, it's not enforced due to a weak infrastructure). It means someone needs to test the changes you propose in 10 code reviews. Personally, I have no interest in kde4 commits anymore and even have no environment to test it. I doubt you'll find another dev who has.

Sun, Aug 18, 6:21 AM · Krusader, Documentation
nmel added a project to D23236: Updates related to v2.7.2 release: Krusader.

Related review: D23197 (same changelog)

Sun, Aug 18, 5:59 AM · Krusader
nmel added a project to D23235: Released v2.7.2: Krusader.
Sun, Aug 18, 5:56 AM · Krusader

Yesterday

nmel added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Hi Toni,

Sat, Aug 17, 5:42 AM · Krusader

Fri, Aug 16

asensi added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Thanks, Nikita! Because it's very handy, and it has been already tried a lot, it looks like a good idea to add the "Shortcuts to move tab" commit to the stable branch, and add to the ChangeLog file:

FIXED: [ 328937 ] Shortcuts for move tab
Fri, Aug 16, 8:55 PM · Krusader
nmel edited the content of Release Howto.
Fri, Aug 16, 5:59 AM · Krusader
nmel added a project to D23197: Updated ChangeLog and NEWS with v2.7.2 changes: Krusader.
Fri, Aug 16, 5:38 AM · Krusader

Mon, Aug 12

asensi retitled D23118: Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator from Because Ctrl+Alt+T is now a global shortcut, use another one for the embedded terminal emulator to Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator.
Mon, Aug 12, 9:53 PM · Krusader
asensi requested review of D23118: Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator.
Mon, Aug 12, 9:52 PM · Krusader
asensi closed D22883: Clarify the aim of two lines written recently by David Faure.
Mon, Aug 12, 9:24 PM · Krusader
asensi added a comment to D22883: Clarify the aim of two lines written recently by David Faure.

Ok. Thanks, Alex and Davide!

Mon, Aug 12, 9:24 PM · Krusader
gengisdave accepted D22883: Clarify the aim of two lines written recently by David Faure.
Mon, Aug 12, 7:52 PM · Krusader
gengisdave updated subscribers of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Mon, Aug 12, 7:50 PM · Krusader
gengisdave updated subscribers of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Mon, Aug 12, 7:49 PM · Krusader
gengisdave updated subscribers of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

An article about it has been published recently:

About deprecation of QFontMetrics::width()
https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/

by @cfeck (Christoph Feck, who has commited some changes to the repository of Krusader).

Mon, Aug 12, 7:49 PM · Krusader

Sat, Aug 10

asensi edited the content of Release Howto.
Sat, Aug 10, 6:38 AM · Krusader

Fri, Aug 9

asensi edited the content of Release Howto.
Fri, Aug 9, 10:20 PM · Krusader
asensi edited the content of Release Howto.
Fri, Aug 9, 10:12 PM · Krusader
nmel closed D22982: Updated release information in docs.
Fri, Aug 9, 6:02 AM · Krusader, Documentation
asensi accepted D22982: Updated release information in docs.

Thanks, Nikita!

Fri, Aug 9, 5:57 AM · Krusader, Documentation
nmel edited the content of Krusader.
Fri, Aug 9, 5:55 AM · Krusader
asensi updated subscribers of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Fri, Aug 9, 5:42 AM · Krusader
nmel added a comment to D22982: Updated release information in docs.

Updated AppStream files. Thanks Luigi and Toni!

Fri, Aug 9, 5:41 AM · Krusader, Documentation
yurchor accepted D22982: Updated release information in docs.
Fri, Aug 9, 5:41 AM · Krusader, Documentation
nmel updated the diff for D22982: Updated release information in docs.
  • Updated AppStream files with previous and upcoming release info
Fri, Aug 9, 5:40 AM · Krusader, Documentation

Thu, Aug 8

asensi updated subscribers of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

An article about it has been published recently:

About deprecation of QFontMetrics::width()
https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/

by @cfeck (Christoph Feck, who has commited some changes to the repository of Krusader).

Thu, Aug 8, 10:20 PM · Krusader
asensi added a comment to D22982: Updated release information in docs.

Please also add the versioning data to the appdata file (maybe also add the information for the previous version this time):

Thu, Aug 8, 8:48 PM · Krusader, Documentation

Wed, Aug 7

asensi added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

Hi, Luigi! Well, I was referring to the virtual machines running prior operating systems (and physical machines, I remember that the LTS support of Ubuntu 14.04 ended at the end of April and I still saw some of those machines). Sometimes the reason is that some programs do not run in recent versions of operating systems, other causes may exist.
There's also the case of Lliurex 16, an operating system installed in thousands of computers, I had to work with it and there I could only build the "kde4" version of Krusader.

Wed, Aug 7, 3:41 PM · Krusader, Documentation
ltoscano added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

I'm not a Krusader developer, but from the global point of view, the kde4 branch is basically dead. It's not tracked for translations, it's not tracked by the sysadmin/repo-metadata repository.

Wed, Aug 7, 3:17 PM · Krusader, Documentation
asensi requested review of D23003: For the "kde4" branch: 10 - Avoid closing the tab when the user {presses Esc inside the Krusader internal editor in order to try to exit searching}; thanks to Martin Kotelnik.
Wed, Aug 7, 3:12 PM · Krusader
asensi requested review of D23002: For the "kde4" branch: 09 - Make Alt+. the default shortcut for toggling hidden files.
Wed, Aug 7, 3:12 PM · Documentation, Krusader
asensi requested review of D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.
Wed, Aug 7, 3:12 PM · Krusader, Documentation
asensi requested review of D23000: For the "kde4" branch: 07 - In the synchronizer: until the bug 270150 is solved, stop using protocols like FISH, SFTP, SMB, etc. Check if the target or the source directory are empty.
Wed, Aug 7, 3:11 PM · Krusader
asensi requested review of D22999: For the "kde4" branch: 06 - Reverse defaults for Synchronizer.
Wed, Aug 7, 3:11 PM · Krusader
asensi requested review of D22998: For the "kde4" branch: 05 - Fix definition scope for Synchronizer in CMake.
Wed, Aug 7, 3:11 PM · Krusader
asensi requested review of D22997: For the "kde4" branch: 04 - Update the main CMakeLists.txt to enable by default the building of synchronizer.
Wed, Aug 7, 3:10 PM · Krusader
asensi requested review of D22996: For the "kde4" branch: 03 - Use the same font for file name and renamed file name; solved by Tobias BUG: 326649.
Wed, Aug 7, 3:10 PM · Krusader
asensi requested review of D22995: For the "kde4" branch: 02 - Names of files are correctly seen when a zip file is opened, even if they are utf-8 encoded.
Wed, Aug 7, 3:10 PM · Krusader
asensi requested review of D22994: For the "kde4" branch: 01 - Solve a bug that didn't allow Krusader to search files inside zip archives; thanks to Dawid Weiss BUG: 292867 REVIEW: 124343.
Wed, Aug 7, 3:10 PM · Krusader
ltoscano added a comment to D22982: Updated release information in docs.

Please also add the versioning data to the appdata file (maybe also add the information for the previous version this time):
https://community.kde.org/ReleasingSoftware#Versioning_in_AppStream_files

Wed, Aug 7, 7:33 AM · Krusader, Documentation
nmel added a comment to D22982: Updated release information in docs.

@yurchor, this was fast! Thanks!

Wed, Aug 7, 6:06 AM · Krusader, Documentation