KrusaderProject
ActivePublic

Recent Activity

Wed, Jul 19

miroslavm added a revision to T1971: Opening Big File Warning: D6788: Resolves T1971 with no further code changes.
Wed, Jul 19, 8:52 PM · Krusader
miroslavm moved T1971: Opening Big File Warning from TODO to In progress on the Krusader board.
Wed, Jul 19, 8:03 PM · Krusader

Mon, Jul 17

abika closed T6514: kio_thumbnail errors as Invalid.
  1. Please use Bugzilla and not Phabricator for bugs and feature requests, like stated here: https://krusader.org/report-bugs/index.html
  2. Krusader 2.4 is outdated. Please try again with 2.5/2.6
  3. Information is missing about what you are actually doing while getting the error messages. Browsing facebook with Krusader?
Mon, Jul 17, 5:58 PM · Krusader

Sun, Jul 16

useretail updated the task description for T6514: kio_thumbnail errors.
Sun, Jul 16, 1:58 PM · Krusader
useretail updated the task description for T6514: kio_thumbnail errors.
Sun, Jul 16, 1:57 PM · Krusader
useretail created T6514: kio_thumbnail errors.
Sun, Jul 16, 1:55 PM · Krusader

Tue, Jul 11

abika added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Merged. Thanks for the patch!

Tue, Jul 11, 8:18 PM · Krusader
miroslavm closed D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)" by committing R167:6687fad746d2: Make "Disk Usage window" a regular window (authored by miroslavm).
Tue, Jul 11, 8:14 PM · Krusader
miroslavm claimed T1971: Opening Big File Warning.

I would like to solve this issue

Tue, Jul 11, 7:16 PM · Krusader

Sat, Jul 8

miroslavm added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
In D6471#122384, @abika wrote:

I fixed the synchronizer dialog myself, wasn't that hard. -> 67c400b5

Patch is ok. The double show() and useless 0 argument is still there.
@miroslavm you can merge if you have write access.

Sat, Jul 8, 1:03 PM · Krusader
miroslavm updated the diff for D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Update after review. DiskUsage dialog non-modal. Segmentation fault fixed.

Sat, Jul 8, 12:56 PM · Krusader

Thu, Jul 6

abika moved T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window) from TODO to In progress on the Krusader board.
Thu, Jul 6, 6:13 PM · Krusader
abika accepted D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

I fixed the synchronizer dialog myself, wasn't that hard. -> 67c400b5

Thu, Jul 6, 6:06 PM · Krusader
martinkostolny added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Sorry for my ignorance with the QDialog and memory leak issue, I've now learnt from it:). I believe the code now looks fine, and works. Although I'd rather remove the parent parameter (0) from new DiskUsageGUI call or replace with MAIN_VIEW like Alex was advising.

Thu, Jul 6, 4:58 PM · Krusader

Wed, Jul 5

miroslavm added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
In D6471#121701, @abika wrote:
setAttribute(Qt::WA_DeleteOnClose)

is a good solution (StackOverflow is your friend:) https://stackoverflow.com/q/20491864/6286694) . You can do this inside the constructor.

And a matter of taste is keeping the parent argument for the constructor (keep MAIN_VIEW instead of 0). This will make the dialog a child the mainwindow but with show() it will not block. If you don't like this (I don't care) the parent parameter should be removed.

For Search and Locate only one dialog instance is created. SynchronizerGUI has indeed the same problem (for the last 7+ years). And krusader/UserAction/expander.cpp:702 looks strange.

Wed, Jul 5, 9:37 PM · Krusader
miroslavm updated the diff for D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Update after review

Wed, Jul 5, 9:26 PM · Krusader
miroslavm added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
Wed, Jul 5, 9:06 PM · Krusader

Tue, Jul 4

abika added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
setAttribute(Qt::WA_DeleteOnClose)

is a good solution (StackOverflow is your friend:) https://stackoverflow.com/q/20491864/6286694) . You can do this inside the constructor.

Tue, Jul 4, 7:08 PM · Krusader
miroslavm added inline comments to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
Tue, Jul 4, 5:49 PM · Krusader
martinkostolny added inline comments to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
Tue, Jul 4, 9:25 AM · Krusader

Mon, Jul 3

abika added inline comments to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
Mon, Jul 3, 6:48 PM · Krusader
martinkostolny accepted D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Looks good to me and works. Thanks for your code! Please see one code comment.

Mon, Jul 3, 5:10 AM · Krusader

Sun, Jul 2

miroslavm claimed T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window).

I would like to solve this issue (patch already submitted)

Sun, Jul 2, 8:55 PM · Krusader
miroslavm created D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
Sun, Jul 2, 8:53 PM · Krusader
miroslavm added a member for Krusader: miroslavm.
Sun, Jul 2, 8:11 PM
abika added a comment to T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window).

@miroslavm Please submit the patch as differential (== review request) and link it to this task (if this is somehow possible).

Sun, Jul 2, 4:13 PM · Krusader
miroslavm added a watcher for Krusader: miroslavm.
Sun, Jul 2, 12:16 PM
miroslavm updated subscribers of T2047: Make "Disk Usage window" a regular window (if this takes too long, make it a modal window).

My opinion: Disk Usage window should be a regular window (like text editor - F3/F4). So user has the option to see more then one Disk Usage windows at the same time.

The current state is kind of half-way there. It is possible to see more then one Disk Usages but it is not a regular window.

But if it would be too difficult to rework, I'm fine with modal dialog.

Sun, Jul 2, 12:07 PM · Krusader

Jun 5 2017

abika moved T3419: Rework of VFS (Now: FileSystem) from In progress to Done on the Krusader board.

Finally mark this done.

Jun 5 2017, 2:58 PM · Krusader
abika renamed T3419: Rework of VFS (Now: FileSystem) from Rework of VFS to Rework of VFS (Now: FileSystem).
Jun 5 2017, 2:58 PM · Krusader

Jun 3 2017

abika edited the content of Krusader.
Jun 3 2017, 2:30 PM · Krusader

May 31 2017

abika created T6237: Replace virtual:/ protocol with KIO-Stash.
May 31 2017, 5:18 PM · Krusader

May 12 2017

martinkostolny closed D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename by committing R167:9617ba9c3f81: Prevent focusing tab-bar when Krusader window is activated after previous item….
May 12 2017, 10:06 PM · Krusader
martinkostolny updated the diff for D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename.

Thanks for checking on this. I'm using your suggestion because I agree, it should be fixed closest to the source of troubles.

May 12 2017, 10:06 PM · Krusader
abika added a comment to D5734: Fix lister unintended selection while scrolling.

I usually never user krViewer.

May 12 2017, 5:32 PM · Krusader
abika accepted D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename.

Thanks! Can confirm in Krusader and a toy application (https://github.com/abika/cpp-qt-kf5-file-browser). Yes, it is probably a bug in Qt.

May 12 2017, 5:20 PM · Krusader

May 8 2017

martinkostolny added a comment to D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

And you don't have to do everything we say.

I know :), but this time I really didn't care that much.

May 8 2017, 7:22 PM · Krusader
martinkostolny closed D5744: Fix loading a panel profile with locked tabs by committing R167:46f05d032be1: Fix loading a panel profile when existing panels are locked..
May 8 2017, 7:07 PM · Krusader
martinkostolny closed D5735: Do not change clipboard while opening a searched file in KrSearchDialog by committing R167:f03636000f03: Add an option (persistent checkbox) in KrSearchDialog for adding a search query….
May 8 2017, 7:07 PM · Krusader
abika accepted D5744: Fix loading a panel profile with locked tabs.

Yes, I can reproduce this. Looks like I solved an issue and created a new one.

May 8 2017, 5:42 PM · Krusader
abika edited the content of Krusader.
May 8 2017, 3:39 PM · Krusader
abika edited the content of Krusader.
May 8 2017, 3:21 PM · Krusader
abika edited the content of Krusader.
May 8 2017, 3:19 PM · Krusader
abika accepted D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

Alex, please check if I understood right the code combining and code comment.

May 8 2017, 2:42 PM · Krusader
martinkostolny created D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename.
May 8 2017, 1:28 PM · Krusader
martinkostolny updated the diff for D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

Thanks for feedback! Here is an update with the option.

May 8 2017, 9:57 AM · Krusader
martinkostolny updated the diff for D5744: Fix loading a panel profile with locked tabs.

My apologies, Alex, I must have missed your fix otherwise I'd test my workflow right away. Now I see You have fixed most of the issues. I've found only one edge-case. Loading a profile is reusing opened tabs, so if You already have a locked tab, it is locked before openUrl() is called. Here is the minimal exact steps to reproduce it:

  1. start fresh krusader (empty config)
    • we will focus on left panel only for this test
  2. go to e.g. Downloads
  3. save profile (e.g. "p1")
  4. go back to home folder and lock the tab
  5. load profile p1 -> You should see 2 tabs now instead of one
May 8 2017, 8:42 AM · Krusader

May 7 2017

abika added a comment to D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

I vote for the option.
It was clearly intended as a feature and somebody is might using it. A checkbox can also advertise the feature to users who didn't even know it was there.

May 7 2017, 10:12 PM · Krusader
asensi accepted D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

This patch is just a proposal to remove this feature and leave user's clipboard alone.

May 7 2017, 9:57 PM · Krusader
abika added a comment to D5744: Fix loading a panel profile with locked tabs.

When one is loading a saved Panel profile, old tabs are removed and profile-saved tabs are restored from settings. But locked tabs are loaded twice with other problems.

May 7 2017, 4:51 PM · Krusader