KrusaderProject
ActivePublic

Recent Activity

Today

mchabrecek updated the diff for D16223: Replaced old connect() with QT5 style. Part 1.
  • Fixed spacing
Tue, Oct 16, 10:26 AM · Krusader
shubham added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

You have to make the changes requested by Nikita.

Tue, Oct 16, 10:07 AM · Krusader
mchabrecek added a comment to D16223: Replaced old connect() with QT5 style. Part 1.
In D16223#343997, @nmel wrote:

Thanks and welcome aboard Miroslav!

Tue, Oct 16, 9:00 AM · Krusader
nmel accepted D16223: Replaced old connect() with QT5 style. Part 1.

Thanks and welcome aboard Miroslav!

Tue, Oct 16, 7:21 AM · Krusader
nmel added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Looks much better, thanks!

Tue, Oct 16, 6:27 AM · Krusader

Yesterday

abika added inline comments to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Mon, Oct 15, 7:04 PM · Krusader
abika accepted D16223: Replaced old connect() with QT5 style. Part 1.

I only skim-read the changes, looks fine.
And Krusader seems to work with the changes.

Mon, Oct 15, 6:43 PM · Krusader
abika added a project to D16223: Replaced old connect() with QT5 style. Part 1: Krusader.
Mon, Oct 15, 6:28 PM · Krusader
mchabrecek added a comment to T2966: Code Cleaning.

I have submitted the first patch here regarding signals and slots. It doesn't solve all the connect() statements. There many hundreds of them. I want to do it in more patches. One reason is that this is my first patch to this project. So I didn't work at something for 6 months and then struggle to submit it. It is here, can you check it? https://phabricator.kde.org/D16223.

Mon, Oct 15, 1:43 PM · Krusader

Thu, Oct 11

gengisdave updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

I thought I had already committed that... changed to a more human macro name

Thu, Oct 11, 8:20 PM · Krusader

Tue, Oct 9

mchabrecek added a comment to T2966: Code Cleaning.

Thank you for help,

Tue, Oct 9, 9:35 AM · Krusader

Sun, Oct 7

asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Maybe a visual hint would be good so that the users know this feature exists.

Sun, Oct 7, 5:26 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Some changes were made after Alex Bikadorov made some propositions.

Sun, Oct 7, 5:01 PM · Krusader
asensi added inline comments to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Sun, Oct 7, 4:43 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

After Alex Bikadorov made some propositions.

Sun, Oct 7, 4:08 PM · Krusader

Sat, Oct 6

abika added a comment to T2966: Code Cleaning.

Hi Miro,

Sat, Oct 6, 3:28 PM · Krusader
mchabrecek placed T2966: Code Cleaning up for grabs.

Hello,
I started to work on replacing old connect() wih Qt5 syntax.
Alex wrote me that it would be the best to do automatically by some script, I don't see it realistic.
There are some tricky cases, which I don't know how to convert. May be you can help me.

Sat, Oct 6, 8:20 AM · Krusader

Thu, Oct 4

abika requested changes to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Deletion was working as expected during tests. Maybe a visual hint would be good so that the users know this feature exists.

Thu, Oct 4, 7:22 PM · Krusader

Tue, Oct 2

asensi added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Since INSERT becomes kind of "global" macro, I suggest we rename it to UDS_ENTRY_INSERT, since the insert word is too generic while the implementation is not. Thanks!

Tue, Oct 2, 5:13 PM · Krusader
mchabrecek added a member for Krusader: mchabrecek.
Tue, Oct 2, 4:25 PM

Fri, Sep 28

asensi closed D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Fri, Sep 28, 6:38 AM · Krusader

Sun, Sep 23

asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Another address was updated

Sun, Sep 23, 6:55 AM · Krusader

Sat, Sep 22

asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

An address was updated

Sat, Sep 22, 6:11 PM · Krusader
asensi requested review of D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Sat, Sep 22, 4:22 PM · Krusader
asensi updated the diff for D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.

Those lines were added to the commit message:

FIXED: Memory leak in the Locate dialog
Differential Revision: https://phabricator.kde.org/D15678
Sat, Sep 22, 3:57 PM · Krusader
asensi added a comment to D15400: Fix compile warnings on missing override declarations.

Confirmed by the build (https://build.kde.org/job/Extragear/job/krusader/job/kf5-qt5%20FreeBSDQt5.11/4/warnings12Result/), 51 warnings fixed and 'missing-override' is not in the remaining 57.

Sat, Sep 22, 9:57 AM · Krusader
gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

Confirmed by the build (https://build.kde.org/job/Extragear/job/krusader/job/kf5-qt5%20FreeBSDQt5.11/4/warnings12Result/), 51 warnings fixed and 'missing-override' is not in the remaining 57.

Sat, Sep 22, 9:03 AM · Krusader
gengisdave closed D15400: Fix compile warnings on missing override declarations.
Sat, Sep 22, 8:54 AM · Krusader
nmel added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Thanks Davide! This looks less cluttered.

Sat, Sep 22, 5:31 AM · Krusader
nmel accepted D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.

Thanks Toni!

Sat, Sep 22, 5:18 AM · Krusader
nmel added a comment to D15400: Fix compile warnings on missing override declarations.

every user is a tester too.

More importantly, whenever we make a change after this is merged, we will see the warning and fix the code. We put an effort before v2.7 release to make Krusader warning-free and we should keep it this way. So now the -Wsuggest-override is on the list of warning directives that we track. Thanks Davide (and Toni ;) )!

Sat, Sep 22, 5:04 AM · Krusader

Fri, Sep 21

asensi updated the test plan for D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Fri, Sep 21, 1:35 PM · Krusader
asensi requested review of D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Fri, Sep 21, 1:28 PM · Krusader
asensi accepted D15400: Fix compile warnings on missing override declarations.

The new version works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide! (and Nikita :-) )

Fri, Sep 21, 1:17 PM · Krusader

Wed, Sep 19

gengisdave updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Changed in favor of a macro solution (as suggested by Nikita).

Wed, Sep 19, 2:15 PM · Krusader
gengisdave added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

What do you think about creating a specialized version of UDSEntry, e.g. KrUDSEntry? This way the code:

Wed, Sep 19, 12:15 PM · Krusader
gengisdave updated the diff for D15400: Fix compile warnings on missing override declarations.

Added flag for GCC as default

Wed, Sep 19, 11:59 AM · Krusader
gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

I've looked at the Clang behaviour: the -Winconsistent-missing-override flag is always set (Debug, Release and none), so GCC should be set the same. My initial thought was to not users to be worried; on a second thought, every user is a tester too.

Wed, Sep 19, 11:42 AM · Krusader

Sep 15 2018

nmel added a comment to D15400: Fix compile warnings on missing override declarations.

Why not to update the flags for both debug and release (CMAKE_CXX_FLAGS var)? What's your reasoning? Does it hurt the release build?

Sep 15 2018, 5:17 AM · Krusader

Sep 14 2018

gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

I've tested with clang compiler and no additional flags are needed, on a clean Fedora 28 I used:

Sep 14 2018, 8:25 AM · Krusader

Sep 13 2018

asensi added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Thanks Davide! (and Nikita :-) )

Sep 13 2018, 6:14 PM · Krusader
asensi accepted D15400: Fix compile warnings on missing override declarations.

It's nice to hear from you again, Davide!

Sep 13 2018, 4:34 PM · Krusader
nmel accepted D15400: Fix compile warnings on missing override declarations.

Indeed, all warnings of this type are fixed. Thanks Davide!

Sep 13 2018, 6:07 AM · Krusader
nmel added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Where to put the macro? The three files don't have a common header file and I haven't found a suitable .h file; any advice?

Sep 13 2018, 5:48 AM · Krusader

Sep 12 2018

gengisdave added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

The use of a Macro was my second way to solve this, but I thought it would add more complexity to the code; instead, this patch makes the code unclear to read.

Sep 12 2018, 8:51 AM · Krusader
gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

I updated the diff to v2 to fix spaces as requested.

Sep 12 2018, 8:40 AM · Krusader
gengisdave updated the diff for D15400: Fix compile warnings on missing override declarations.
Sep 12 2018, 8:31 AM · Krusader
nmel added a comment to D15400: Fix compile warnings on missing override declarations.

and reproducible adding -Wsuggest-override or -Winconsistent-missing-override (not sure, haven't tested with clang) to CMAKE_CXX_FLAGS

Should we add this into cmake config file to ensure that these flags are always on?

Sep 12 2018, 6:29 AM · Krusader
nmel requested changes to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

inline

Sep 12 2018, 6:21 AM · Krusader

Sep 10 2018

gengisdave requested review of D15400: Fix compile warnings on missing override declarations.
Sep 10 2018, 10:24 AM · Krusader