croick (Christoph Roick)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 3 2017, 7:27 PM (120 w, 15 h)
Availability
Available

Recent Activity

Aug 17 2019

croick committed R262:f86e46310425: Fix build with MQTT enabled (authored by croick).
Fix build with MQTT enabled
Aug 17 2019, 8:43 PM

Jul 9 2019

croick abandoned D18245: Create QApplication in a scope to work around possible deadlock.

I can no longer reproduce the deadlock, so I'll abandon this.

Jul 9 2019, 9:18 PM · Plasma
croick added a comment to D11234: [DrKonqi] Show debug button when KDevelop session is running.

Thanks for your review. It was the last in a series of patches and I'll try to advertise the whole "Debug your KDE application with KDevelop"-feature somewhere.

Jul 9 2019, 8:45 PM · Plasma
croick committed R871:95b6b8b613c2: Show debug button when KDevelop session is running (authored by croick).
Show debug button when KDevelop session is running
Jul 9 2019, 8:40 PM
croick closed D11234: [DrKonqi] Show debug button when KDevelop session is running.
Jul 9 2019, 8:40 PM · Plasma

Jul 8 2019

croick added a comment to D11234: [DrKonqi] Show debug button when KDevelop session is running.

Could you explain your thinking behind the adjustSize call please? The way I see it the window should scale up as necessary if the size hints are properly set (which they should be on master).

Jul 8 2019, 10:03 PM · Plasma
croick updated the diff for D11234: [DrKonqi] Show debug button when KDevelop session is running.
  • more style fixes
  • do not adjustSize after adding the button, since that is redundant now
Jul 8 2019, 9:58 PM · Plasma

Jun 11 2019

croick added a comment to D11234: [DrKonqi] Show debug button when KDevelop session is running.

Thanks for looking into this :D

Jun 11 2019, 10:32 PM · Plasma
croick updated the diff for D11234: [DrKonqi] Show debug button when KDevelop session is running.
  • Fix code style.
  • Save state of the debug button in a member variable.
  • Resize the dialog after inserting/removing the debug button.
Jun 11 2019, 10:24 PM · Plasma

Jun 8 2019

croick updated the diff for D18245: Create QApplication in a scope to work around possible deadlock.

Rebase to current master

Jun 8 2019, 11:55 AM · Plasma
croick updated the diff for D11234: [DrKonqi] Show debug button when KDevelop session is running.

Rebase to current master

Jun 8 2019, 11:50 AM · Plasma

May 12 2019

croick committed R262:fd63e283c3ba: Use enum to identify AbstractAspect (authored by croick).
Use enum to identify AbstractAspect
May 12 2019, 9:35 PM
croick closed D18420: Use enum to identify AbstractAspect.
May 12 2019, 9:35 PM · KDE Edu
croick committed R262:41c8d4b6e7c2: Revert unintended change in ROOT object version reader (authored by croick).
Revert unintended change in ROOT object version reader
May 12 2019, 5:45 PM
croick committed R262:05506b3a8d51: Check if setting the ROOT file is successful (authored by croick).
Check if setting the ROOT file is successful
May 12 2019, 3:19 PM
croick added inline comments to D18420: Use enum to identify AbstractAspect.
May 12 2019, 2:47 PM · KDE Edu
croick updated the diff for D18420: Use enum to identify AbstractAspect.
May 12 2019, 2:45 PM · KDE Edu
croick committed R262:3a2c6ef46980: Support ROOT directory structure (authored by croick).
Support ROOT directory structure
May 12 2019, 2:10 PM

May 5 2019

croick added a comment to D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files.
In D19420#460766, @apol wrote:

Looks good to me, have you checked that it's now not breaking what @broulik found?

May 5 2019, 1:43 PM · Frameworks
croick added a comment to D18420: Use enum to identify AbstractAspect.

Instead of an enum inside AbstractAspect, there now is an enum class outside of the class. This way, the items can be named properly.

May 5 2019, 10:52 AM · KDE Edu
croick updated the diff for D18420: Use enum to identify AbstractAspect.
  • Rearrange AbstractAspect type enums
  • Transform AspectType enum into global enum class, rename items
May 5 2019, 10:46 AM · KDE Edu

May 4 2019

croick added a comment to D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files.

Would you accept now @apol?

May 4 2019, 11:30 AM · Frameworks

Mar 31 2019

croick added a comment to D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files.

Would you accept now @apol?

Mar 31 2019, 9:01 PM · Frameworks
croick committed R40:3699973443f2: Use file mode in Preview add-on (authored by croick).
Use file mode in Preview add-on
Mar 31 2019, 8:46 PM
croick closed D12131: Use file mode in Preview add-on.
Mar 31 2019, 8:46 PM · Kate
croick added a comment to D12131: Use file mode in Preview add-on.

This will override 5d28eaaf9041 (fixing the same bug), but I'll apply it anyway.

Mar 31 2019, 1:33 PM · Kate

Feb 28 2019

croick added a comment to D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files.
In D19420#422043, @apol wrote:

With a unit test it would be much easier to accept the patch ;)

Feb 28 2019, 11:37 PM · Frameworks
croick updated the diff for D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files.

add unit test, reset bNeedHeader

Feb 28 2019, 11:34 PM · Frameworks
croick requested review of D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files.
Feb 28 2019, 1:32 PM · Frameworks
croick added a comment to R243:96083005e90e: Return KFilterBase::End if KGzipFilter::uncompress_noop() finished reading.

Oh, sorry for that, I thought it would comply with how Z_OK and Z_STREAM_END are used and therefore be a trivial change.
I will create a bug report instead.

Feb 28 2019, 10:12 AM

Feb 27 2019

croick committed R262:0ef1f3c9fcc5: Fix detection of compressed JSON files (authored by croick).
Fix detection of compressed JSON files
Feb 27 2019, 12:14 AM
croick committed R243:96083005e90e: Return KFilterBase::End if KGzipFilter::uncompress_noop() finished reading (authored by croick).
Return KFilterBase::End if KGzipFilter::uncompress_noop() finished reading
Feb 27 2019, 12:02 AM

Feb 26 2019

croick committed R262:fdb2f048182c: [FITS] Use squeeze() instead of shrink_to_fit() (Qt 5.6 compatibility) (authored by croick).
[FITS] Use squeeze() instead of shrink_to_fit() (Qt 5.6 compatibility)
Feb 26 2019, 10:32 PM
croick committed R262:8e4a09683381: [JSON] Clear filename in options widget when clearing model (authored by croick).
[JSON] Clear filename in options widget when clearing model
Feb 26 2019, 5:27 PM
croick committed R262:b9201974d0eb: [MQTT] Clean up connection manager, fix crash after deleting last connection (authored by croick).
[MQTT] Clean up connection manager, fix crash after deleting last connection
Feb 26 2019, 3:18 PM
croick committed R262:180276888553: Replace empty quotation marks "" by QString()/std::string() (authored by croick).
Replace empty quotation marks "" by QString()/std::string()
Feb 26 2019, 3:13 PM
croick committed R262:c9cc1e39220f: [FITS] Fix out of bound access and memory leaks (authored by croick).
[FITS] Fix out of bound access and memory leaks
Feb 26 2019, 2:34 PM

Feb 25 2019

croick added a comment to D18245: Create QApplication in a scope to work around possible deadlock.

I repeat: there's no indication in the backtrace that it is stuck. What's your evidence that it is? You wrote an application that shows nothing and never exits. Now it showed nothing and didn't exit. That's not stuck, that's the expected behaviour.

Feb 25 2019, 12:20 PM · Plasma
croick updated the diff for D18245: Create QApplication in a scope to work around possible deadlock.
  • add comment
Feb 25 2019, 12:09 PM · Plasma

Feb 24 2019

croick added a comment to D18245: Create QApplication in a scope to work around possible deadlock.

A backtrace where it gets stuck in the destructor of QApplication.

Feb 24 2019, 5:28 PM · Plasma
croick added a comment to D18245: Create QApplication in a scope to work around possible deadlock.

This last backtrace does not show anything stuck. Thread 1 was actively running, in fact (it's inside of malloc).

Also note your testcase has no window, since the widget is destroyed before app.exec().

Feb 24 2019, 5:17 PM · Plasma
croick added a comment to D18245: Create QApplication in a scope to work around possible deadlock.

The problem does not seem to be specific to DrKonqi. Once DrKonqi and KDevelop are stuck, any Qt program may have problems starting or quitting. A minimal example

#include <QApplication>
#include <QWidget>
Feb 24 2019, 5:02 PM · Plasma

Feb 22 2019

croick updated subscribers of D18245: Create QApplication in a scope to work around possible deadlock.

I dug in the history of KCrash and realized, that closing all the file descriptors was introduced (7bbf112e5e97d40b9a4f9fdd167b064a1019843b) to make the X11 window disappear.
Later @ossi added the X11 FD explicitly (7ac326ddb05eec296fdfbebd86d0d1320e579063), but kept closing the FDs by default.

Feb 22 2019, 10:21 PM · Plasma
croick added a comment to D18245: Create QApplication in a scope to work around possible deadlock.

The following steps allow creating the backtraces. Simply attaching to KDevelop does not work, since that sends a SIGSTOP to all threads (and releases the dead lock). Attaching to DrKonqi after closing the dialog does not work since the process already is defunct:

  • kill -SIGSEGV $(pidof kdevelop)
  • raise DrKonqi dialog
  • gdb -p $(pidof drkonqi), continue execution
  • close DrKonqi dialog
  • CTRL + C in gdb, which now is stuck
  • kill -SIGSTOP $(pidof kdevelop), gdb reacts again, generate backtrace for DrKonqi
  • gdb -p $(pidof kdevelop), generate backtrace for KDevelop
Feb 22 2019, 10:03 PM · Plasma

Feb 9 2019

croick committed R262:1084aae44d83: [SQL] Fix crash when deleting the last SQL connection and update preview… (authored by croick).
[SQL] Fix crash when deleting the last SQL connection and update preview…
Feb 9 2019, 10:38 PM
croick committed R262:03086f6de403: Fix crash when manipulating plot data without project (authored by croick).
Fix crash when manipulating plot data without project
Feb 9 2019, 10:38 PM

Feb 5 2019

croick committed R32:46a105b4bf13: Adapt indentation mode after a new project was opened (authored by croick).
Adapt indentation mode after a new project was opened
Feb 5 2019, 8:41 PM

Feb 3 2019

croick committed R262:f196ea9603ff: Improve LiveDataDock and import widget (authored by croick).
Improve LiveDataDock and import widget
Feb 3 2019, 10:26 PM
croick closed D18319: Improve LiveDataDock and import widget.
Feb 3 2019, 10:26 PM · KDE Edu

Jan 30 2019

croick added inline comments to D18319: Improve LiveDataDock and import widget.
Jan 30 2019, 9:53 AM · KDE Edu
croick updated the diff for D18319: Improve LiveDataDock and import widget.
  • re-insert check for existing hosts
Jan 30 2019, 9:52 AM · KDE Edu

Jan 27 2019

croick committed R262:62de0cc5cd68: Replace remaining "FileDataSource" by "LiveDataSource" (authored by croick).
Replace remaining "FileDataSource" by "LiveDataSource"
Jan 27 2019, 3:10 PM
croick updated the diff for D18319: Improve LiveDataDock and import widget.
  • suppose that casting is possible, add ifdef
Jan 27 2019, 3:00 PM · KDE Edu

Jan 26 2019

croick committed R32:7789fcd7be81: Provide debugger name and pid when registering a debugger to DrKonqi (authored by croick).
Provide debugger name and pid when registering a debugger to DrKonqi
Jan 26 2019, 11:01 PM
croick closed D18511: Provide debugger name and pid when registering a debugger to DrKonqi.
Jan 26 2019, 11:01 PM · KDevelop
croick updated the diff for D18420: Use enum to identify AbstractAspect.
  • switch (fix) raiseDockSetupConnect and raiseDockSetup
Jan 26 2019, 9:37 PM · KDE Edu
croick added a comment to D18420: Use enum to identify AbstractAspect.

If I had known in advance...

Jan 26 2019, 9:29 PM · KDE Edu
croick updated the diff for D18420: Use enum to identify AbstractAspect.
  • use enum to identify AbstractAspects and use it throughout the project
Jan 26 2019, 9:20 PM · KDE Edu

Jan 25 2019

croick added a comment to D11234: [DrKonqi] Show debug button when KDevelop session is running.

A few screenshots:

Jan 25 2019, 9:57 AM · Plasma
croick added a reviewer for D11234: [DrKonqi] Show debug button when KDevelop session is running: KDevelop.
Jan 25 2019, 9:53 AM · Plasma
croick added a comment to D18511: Provide debugger name and pid when registering a debugger to DrKonqi.

Do you think we should check for the version of Plasma to make a distinction between DrKonqi versions?
I think not, the Debug feature is not (yet) very popular, but I would like another opinion.

Jan 25 2019, 9:39 AM · KDevelop
croick requested review of D18511: Provide debugger name and pid when registering a debugger to DrKonqi.
Jan 25 2019, 9:36 AM · KDevelop
croick committed R871:9f3cfcff960c: Request change of ptrace scope from KCrash (authored by croick).
Request change of ptrace scope from KCrash
Jan 25 2019, 9:14 AM
croick closed D11235: Request change of ptrace scope from KCrash.
Jan 25 2019, 9:14 AM · Plasma
croick updated the summary of D11235: Request change of ptrace scope from KCrash.
Jan 25 2019, 9:07 AM · Plasma
croick committed R285:5be18135963e: Comment why changing the ptracer is required (authored by croick).
Comment why changing the ptracer is required
Jan 25 2019, 9:06 AM
croick committed R285:2af59ef51f8c: [KCrash] Establish socket to allow change of ptracer (authored by croick).
[KCrash] Establish socket to allow change of ptracer
Jan 25 2019, 8:57 AM
croick closed D11236: [KCrash] Establish socket to allow change of ptracer.
Jan 25 2019, 8:57 AM · Frameworks
croick updated the summary of D11236: [KCrash] Establish socket to allow change of ptracer.
Jan 25 2019, 8:53 AM · Frameworks

Jan 23 2019

croick added a comment to D18420: Use enum to identify AbstractAspect.

I still prefer my solution ;)

Jan 23 2019, 11:29 PM · KDE Edu
croick updated the summary of D11235: Request change of ptrace scope from KCrash.
Jan 23 2019, 11:07 PM · Plasma
croick added a comment to D11236: [KCrash] Establish socket to allow change of ptracer.

Ok, now I got it. After reading the YAMA doc again (more carefully) I realize that it really just is the parent that can be attached to the child by default and not the other way around.
I still wonder why I seem to recall that there was a working backtrace for the directly started DrKonqi in the tests, although the tracer was never set. Sorry about that.

Jan 23 2019, 11:07 PM · Frameworks
croick updated the summary of D11236: [KCrash] Establish socket to allow change of ptracer.
Jan 23 2019, 11:06 PM · Frameworks

Jan 20 2019

croick added a comment to D11236: [KCrash] Establish socket to allow change of ptracer.

the 3rd line is still wrong ...

Jan 20 2019, 9:45 PM · Frameworks
croick updated the summary of D11235: Request change of ptrace scope from KCrash.
Jan 20 2019, 9:43 PM · Plasma
croick updated the summary of D11236: [KCrash] Establish socket to allow change of ptracer.
Jan 20 2019, 9:43 PM · Frameworks
croick added a comment to D18420: Use enum to identify AbstractAspect.

Would you agree on such a change?
case "Worksheet"_hash: is still human-readable (compare to if (className == "Worksheet").
The very unlikely case of a hash collision would appear at compile time (if new dock widgets are introduced).
On the other hand the selection of the right dock is now more efficient than before.

Jan 20 2019, 9:35 PM · KDE Edu
croick requested review of D18420: Use enum to identify AbstractAspect.
Jan 20 2019, 9:25 PM · KDE Edu
croick added a comment to D18319: Improve LiveDataDock and import widget.

So would you agree, that qobject_cast is not required, since the class name is checked anyway?
The result of the cast isn't checked anywhere, so one could just use static_cast (and simply take the first element in the list).

Jan 20 2019, 3:15 PM · KDE Edu

Jan 17 2019

croick updated the test plan for D11236: [KCrash] Establish socket to allow change of ptracer.
Jan 17 2019, 2:09 PM · Frameworks
croick updated the test plan for D11235: Request change of ptrace scope from KCrash.
Jan 17 2019, 2:07 PM · Plasma
croick added a comment to D18319: Improve LiveDataDock and import widget.

The dock looks like this:

Jan 17 2019, 2:03 PM · KDE Edu
croick requested review of D18319: Improve LiveDataDock and import widget.
Jan 17 2019, 1:58 PM · KDE Edu
croick updated the diff for D11235: Request change of ptrace scope from KCrash.
  • swap variable declaration
Jan 17 2019, 1:39 PM · Plasma
croick added a comment to D11236: [KCrash] Establish socket to allow change of ptracer.

I think it's quite useful (see BUG 175362). Remaining threads remain quite busy otherwise, especially since KCrash is closing all file descriptors by default, which leads to a lot of polling of non-existant FDs in the background.
Maybe you would like to join the discussion in D18245 about this ;)

Jan 17 2019, 1:36 PM · Frameworks
croick committed R262:bf1084cc8543: Use QStringLiteral in GuiObserver (authored by croick).
Use QStringLiteral in GuiObserver
Jan 17 2019, 1:17 PM
croick updated the diff for D11236: [KCrash] Establish socket to allow change of ptracer.
  • invert debugger-debuggee hierarchy in comment
Jan 17 2019, 12:35 PM · Frameworks
croick added a comment to D11235: Request change of ptrace scope from KCrash.

you got the parent-child ordering wrong in the commit message. ^^

Jan 17 2019, 12:25 PM · Plasma
croick updated the diff for D11235: Request change of ptrace scope from KCrash.
  • swap lines, declare array for response message where needed
Jan 17 2019, 12:23 PM · Plasma
croick updated the summary of D11236: [KCrash] Establish socket to allow change of ptracer.
Jan 17 2019, 11:49 AM · Frameworks
croick updated the diff for D11235: Request change of ptrace scope from KCrash.
  • adjust warning and check for EINTR when polling
Jan 17 2019, 11:48 AM · Plasma

Jan 16 2019

croick added inline comments to D11235: Request change of ptrace scope from KCrash.
Jan 16 2019, 4:15 PM · Plasma
croick updated the diff for D11235: Request change of ptrace scope from KCrash.
  • emit warning if no socket is available
Jan 16 2019, 4:15 PM · Plasma
croick added a comment to D11236: [KCrash] Establish socket to allow change of ptracer.

that sounds suspicious. i don't think the kernel's behavior did changed, and the process hierarchy presumably didn't, either. the right is handed down the ancestry, and that's irrespective of whether the tracer is a "natural" ancestor or the tracee, or was set via prctl(). maybe your sysctl settings simply changed?

Jan 16 2019, 4:11 PM · Frameworks
croick updated the diff for D11236: [KCrash] Establish socket to allow change of ptracer.
  • modify comment and remove check for EAGAIN
Jan 16 2019, 4:07 PM · Frameworks
croick updated the diff for D11235: Request change of ptrace scope from KCrash.
  • change order and add comment to kdeinit option in crashtest
  • add warning if debuggee does not respond as expected
Jan 16 2019, 4:07 PM · Plasma
croick added a comment to D11235: Request change of ptrace scope from KCrash.

read() and write() were assumed to work right away, I added a loop around.

Jan 16 2019, 12:11 PM · Plasma
croick added a comment to D11236: [KCrash] Establish socket to allow change of ptracer.

please explicitly mark all handled issues as done - you'll notice on the way that you didn't address some of them.

Jan 16 2019, 12:04 PM · Frameworks
croick updated the diff for D11235: Request change of ptrace scope from KCrash.
  • use debuggee pid instead of DrKonqi pid for socket name
  • make sure to read/write all bytes from/to socket
Jan 16 2019, 11:56 AM · Plasma
croick updated the diff for D11236: [KCrash] Establish socket to allow change of ptracer.
  • unlink old sockets before binding
  • remove superfluous EAGAIN check
  • use debuggee pid instead of DrKonqi pid for socket name
  • fix comments
Jan 16 2019, 11:55 AM · Frameworks