- User Since
- Apr 15 2015, 8:03 AM (204 w, 6 d)
Looks perfect! Please push! :)
Sun, Mar 17
The patch looks fine, please push it!
Fri, Mar 15
The patch looks perfectly fine now! Please push :)
Wed, Mar 13
Tue, Mar 12
It should be fine now :)
The patch works fine. The only concern I have is the naming of the option. This very option exports "sequence", not "animation". Actually, we can either export a "video" or a "sequence". We have no term "animation" in the main dialog :)
Does it mean that the animation is exported with the "lastly used configuration"?
Mon, Mar 11
The patch looks and works fine. I'm okay with pushing it into master.
Sun, Mar 10
Did you try to compile your patch before uploading for review? It looks like it doesn't compile.
Sat, Mar 9
Hi, all! I'm sorry, I found out that I will not manage to come to the sprint this time :( If you happen to gather next winter, I might try to join though.
Sat, Mar 2
Thu, Feb 28
Sorry, but not all the changes are fixed yet
It would be preferable to use KIS_ASSERT_RECOVER and KIS_ASSERT_RECOVER_RETURN (and their _SAFE counterparts) here :)
Wed, Feb 27
Tue, Feb 26
Mon, Feb 25
Tue, Feb 19
bb2a943350 Fix crash when the small color selector has zero size
4f47eca44e Cleanup some forgotten lines
05d5915a5a Remove pure virtual from KisColorSelectorComponent::setColor()
98f0a51d62 Add GPL2+ license to new files
4181901f1c PNG converter doesn't need half.h anymore
0347350087 Enable HDR mode in the autobuild script
The original patch was reversed. This is the correct one.
Mon, Feb 18
The patch looks and work okay here :)
Feb 17 2019
Feb 14 2019
Feb 11 2019
Feb 8 2019
I'm sorry, but there are a few bugs in the patch:
The updated patch fixes the pixel grid problem. Though it breaks checkers rendering :(
I have pushed the fix with a minor change: setDirty() should always be called after the change has been done, not before that. Otherwise the patch was correct. Looks like I dropped the update part when refactoring this code to the strokes framework :)