wojnilowicz (Łukasz Wojniłowicz)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 1 2017, 5:16 PM (72 w, 3 d)
Availability
Available

Recent Activity

Today

wojnilowicz committed R877:1492723c47e0: Change blacklist of KMyMoney installer (authored by wojnilowicz).
Change blacklist of KMyMoney installer
Sat, Jun 23, 10:41 AM
wojnilowicz updated the diff for D13615: Move encryption settings to XML storage plugin.
Sat, Jun 23, 8:33 AM · KMyMoney
wojnilowicz committed R883:1518504: Update translations in kf5-trunk.
Update translations in kf5-trunk
Sat, Jun 23, 8:22 AM
wojnilowicz committed R877:0bd85f9d5e08: Blacklist more files in KMyMoney installer (authored by wojnilowicz).
Blacklist more files in KMyMoney installer
Sat, Jun 23, 6:34 AM
wojnilowicz committed R877:5cd8f01f1470: Make gpgme work on MinGW 64 (authored by wojnilowicz).
Make gpgme work on MinGW 64
Sat, Jun 23, 6:34 AM
wojnilowicz closed D13634: Make gpgme work on MinGW 64.
Sat, Jun 23, 6:34 AM · Craft
wojnilowicz requested review of D13687: Move reports drawing to reports view plugin.
Sat, Jun 23, 6:14 AM · KMyMoney

Wed, Jun 20

wojnilowicz requested review of D13634: Make gpgme work on MinGW 64.
Wed, Jun 20, 5:10 PM · Craft

Tue, Jun 19

wojnilowicz requested review of D13615: Move encryption settings to XML storage plugin.
Tue, Jun 19, 5:01 PM · KMyMoney

Sun, Jun 17

wojnilowicz requested review of D13581: Prepare for XML storage separation.
Sun, Jun 17, 1:12 PM · KMyMoney

Sat, Jun 16

wojnilowicz accepted D13519: Simplify signal handling between engine and models.

Beside trhee comments, it looks good to me.

Sat, Jun 16, 11:47 AM

Mon, Jun 11

wojnilowicz accepted D11450: Keep current scroll position when reloading page.

I didn't test it but it looks good to me.

Mon, Jun 11, 12:50 PM

Sun, Jun 10

wojnilowicz committed R261:bfa516d09143: Refactor file menu (authored by wojnilowicz).
Refactor file menu
Sun, Jun 10, 3:24 PM
wojnilowicz committed R261:7a3aba071f63: Remove redundant CMake statements (authored by wojnilowicz).
Remove redundant CMake statements
Sun, Jun 10, 3:24 PM
wojnilowicz closed D13408: Refactor file menu.
Sun, Jun 10, 3:24 PM · KMyMoney
wojnilowicz closed D13409: Remove redundant CMake statements.
Sun, Jun 10, 3:24 PM · KMyMoney
wojnilowicz committed R261:1183eaec5d26: Enable foreign keys support in SQLite (authored by wojnilowicz).
Enable foreign keys support in SQLite
Sun, Jun 10, 3:24 PM
wojnilowicz closed D13295: Enable foreign keys support in SQLite.
Sun, Jun 10, 3:24 PM · KMyMoney
wojnilowicz committed R261:8658b8eb6b1b: Use QVERIFY_EXCEPTION_THROWN in MyMoneyMoney test (authored by wojnilowicz).
Use QVERIFY_EXCEPTION_THROWN in MyMoneyMoney test
Sun, Jun 10, 3:24 PM
wojnilowicz updated the diff for D13408: Refactor file menu.
Sun, Jun 10, 12:39 PM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.
Sun, Jun 10, 5:20 AM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.

Fixed issues with Select All Transactions and Update All Accounts.

Sun, Jun 10, 5:16 AM · KMyMoney

Sat, Jun 9

wojnilowicz added a comment to D13408: Refactor file menu.
  • Category/New Category is never enabled

I did not change this behaviour. Category/New Category activates on categories view if you select one of the categories.

Then it might be a leftover from one of your recent changes. Anyway, it needs to be fixed. Otherwise you will not be able to create the first category ever in a new file (except loading templates). And this is new user experience.

Sat, Jun 9, 3:46 PM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.

Fixed icalendar crash.

Sat, Jun 9, 3:45 PM · KMyMoney
wojnilowicz updated subscribers of D13408: Refactor file menu.

Dear Thomas / Łukasz:

Could you try and see if you could reproduce this:

I opened an existing kmy/xml file, made some changes to it, and pressed Save.
It throws an error: "Unable to write changes to '[/path/to/file]' [...]\kmymoney\plugins\xml\xmlstorage.cpp:271"

(Interestingly when I hit Save a second time, the second time succeeds)

IMO this would really be a show stopper indeed coz file saving seems to be, in a sense, broken.

(Many thanks both of you for your efforts!) (I've nothing further to add regarding this patch)

Sat, Jun 9, 1:13 PM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.
Sat, Jun 9, 1:11 PM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.
Sat, Jun 9, 9:12 AM · KMyMoney
wojnilowicz added a comment to D13408: Refactor file menu.
  • When KMyMoney is started with the -n command line option
    • File export/Schedules to iCalendar is still available (you need to have this plugin enabled)
Sat, Jun 9, 9:12 AM · KMyMoney
wojnilowicz updated the diff for D13409: Remove redundant CMake statements.
Sat, Jun 9, 5:53 AM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.

Fixed all reported deficiencies.

Sat, Jun 9, 5:51 AM · KMyMoney
wojnilowicz added a comment to D13408: Refactor file menu.

Here are my findings:

    • I needed to apply the following patch to compile it:

      ` diff --git a/kmymoney/kmymoney.cpp b/kmymoney/kmymoney.cpp index a334f7df..c48b4157 100644
    • a/kmymoney/kmymoney.cpp +++ b/kmymoney/kmymoney.cpp @@ -1990,7 +1990,7 @@ void KMyMoneyApp::slotShowAllAccounts() #ifdef KMM_DEBUG void KMyMoneyApp::slotFileFileInfo() {
  • if (!d->m_fileOpen) { + if (!d->m_fileInfo.isOpened) { KMessageBox::information(this, i18n("No KMyMoneyFile open")); return; } `
    • When the backend is closed via File/Close or Ctrl+W:
      • the File/Import and File/Export menus and their entries are not disabled. Selecting them crashes the application.
      • the New credit transfer button is not disabled. Pressing it crashes the application
      • the Update all accounts button is not disabled. Pressing it crashes the application
      • the Tools/Performance test option is not disabled. Selecting it crashes the application
    • Having one XML file (GZIP) open and using File/Open recent to select another XML (GPG encrypted) shows the message Cannot open file as requested. Error was: No storage object attached to MyMoneyFile /home/thb/devel/kmymoney/kmymoney/mymoney/mymoneyfile.cpp:214 This maybe just a special case, see next entry.
    • Opening GPG encrypted files does not work at all. I started from the CLI with a filename provided. It always shows the message mentioned in the previous line. This is a show stopper!!
    • Open an XML file. Make changes. Don't save. Open another file and press Cancel on the Save changes dialog. This will result in the message Cannot open file as requested. Error was: Storage already attached /home/thb/devel/kmymoney/kmymoney/mymoney/mymoneyfile.cpp:335 It should just stop the action without message.
Sat, Jun 9, 5:50 AM · KMyMoney
wojnilowicz committed R883:1517599: Update translations in kf5-trunk.
Update translations in kf5-trunk
Sat, Jun 9, 4:21 AM
wojnilowicz committed R883:1517598: Update translations in kf5-stable.
Update translations in kf5-stable
Sat, Jun 9, 4:19 AM

Fri, Jun 8

wojnilowicz added a comment to D13409: Remove redundant CMake statements.

What about the target_compile_features in kmyoney/settings/CMakeLists.txt? Why were those instructions added in the first place? Are they possibly required on some platform? Did you check all of them?

Fri, Jun 8, 1:43 PM · KMyMoney

Thu, Jun 7

wojnilowicz committed R261:e41874994718: Fix some warnings (authored by wojnilowicz).
Fix some warnings
Thu, Jun 7, 7:18 PM
wojnilowicz requested review of D13414: Format reports headers according to the KDE guidelines.
Thu, Jun 7, 5:49 PM · KMyMoney
wojnilowicz requested review of D13413: Format widget headers according to the KDE guidelines.
Thu, Jun 7, 5:48 PM · KMyMoney
wojnilowicz requested review of D13409: Remove redundant CMake statements.
Thu, Jun 7, 3:49 PM · KMyMoney
wojnilowicz requested review of D13408: Refactor file menu.
Thu, Jun 7, 3:21 PM · KMyMoney
wojnilowicz committed R261:284a03319c2d: Refactor MyMoneyException class (authored by wojnilowicz).
Refactor MyMoneyException class
Thu, Jun 7, 11:01 AM

Sun, Jun 3

wojnilowicz committed R261:239b4f1568cb: Fix some build warnings (authored by wojnilowicz).
Fix some build warnings
Sun, Jun 3, 3:44 PM
wojnilowicz closed D13298: Fix some build warnings.
Sun, Jun 3, 3:44 PM · KMyMoney
wojnilowicz committed R261:724691bfdc3b: Use unsigned int for denominator in MyMoneyMoney (authored by wojnilowicz).
Use unsigned int for denominator in MyMoneyMoney
Sun, Jun 3, 3:44 PM
wojnilowicz closed D13296: Use unsigned int for denominator in MyMoneyMoney.
Sun, Jun 3, 3:44 PM · KMyMoney
wojnilowicz added a comment to D13279: Pluginize XML Storage.
  1. Open kmm (xml) file
  2. Disable xml storage plugin and close kmm
  3. Start kmm again [kmm tries to load last used (xml) file (and xml storage plugin disabled)]
  4. "Couldn't find suitable plugin to read your storage." Press "OK"
  5. Crash
Sun, Jun 3, 1:28 PM · KMyMoney
wojnilowicz requested review of D13298: Fix some build warnings.
Sun, Jun 3, 11:28 AM · KMyMoney
wojnilowicz added inline comments to D13296: Use unsigned int for denominator in MyMoneyMoney.
Sun, Jun 3, 11:27 AM · KMyMoney
wojnilowicz updated the diff for D13296: Use unsigned int for denominator in MyMoneyMoney.

I misused multi-arg overload but fixed it right now.

Sun, Jun 3, 11:27 AM · KMyMoney
wojnilowicz added inline comments to D13296: Use unsigned int for denominator in MyMoneyMoney.
Sun, Jun 3, 10:43 AM · KMyMoney
wojnilowicz requested review of D13296: Use unsigned int for denominator in MyMoneyMoney.
Sun, Jun 3, 9:49 AM · KMyMoney
wojnilowicz requested review of D13295: Enable foreign keys support in SQLite.
Sun, Jun 3, 8:39 AM · KMyMoney

Sat, Jun 2

wojnilowicz committed R261:84f0a9b92d41: Fix the build, try 3 (authored by wojnilowicz).
Fix the build, try 3
Sat, Jun 2, 2:43 PM
wojnilowicz committed R261:d881e431effe: Fix the build, try 2 (authored by wojnilowicz).
Fix the build, try 2
Sat, Jun 2, 2:34 PM
wojnilowicz committed R261:4be5ec00eace: Fix the build, try 1 (authored by wojnilowicz).
Fix the build, try 1
Sat, Jun 2, 2:24 PM
wojnilowicz committed R261:dc335bcaf0d9: Pluginize XML Storage (authored by wojnilowicz).
Pluginize XML Storage
Sat, Jun 2, 2:19 PM
wojnilowicz committed R261:61959371ce70: Format dialogs headers according to the KDE guidelines (authored by wojnilowicz).
Format dialogs headers according to the KDE guidelines
Sat, Jun 2, 2:19 PM
wojnilowicz closed D13279: Pluginize XML Storage.
Sat, Jun 2, 2:19 PM · KMyMoney
wojnilowicz closed D13161: Format dialogs headers according to the KDE guidelines.
Sat, Jun 2, 2:19 PM · KMyMoney
wojnilowicz committed R261:6e3e8f3d8250: Format models headers according to the KDE guidelines (authored by wojnilowicz).
Format models headers according to the KDE guidelines
Sat, Jun 2, 2:19 PM
wojnilowicz closed D13159: Format models headers according to the KDE guidelines.
Sat, Jun 2, 2:19 PM · KMyMoney
wojnilowicz committed R261:93df569eb8d6: Delete item after it has been removed (authored by wojnilowicz).
Delete item after it has been removed
Sat, Jun 2, 2:19 PM
wojnilowicz committed R261:af378c83b4ef: Fix reading online jobs in SQL storage (authored by wojnilowicz).
Fix reading online jobs in SQL storage
Sat, Jun 2, 2:19 PM
wojnilowicz committed R261:303e9a1e26f3: Move ibanbicdata to a plugin (authored by wojnilowicz).
Move ibanbicdata to a plugin
Sat, Jun 2, 2:19 PM
wojnilowicz closed D13242: Move ibanbicdata to a plugin.
Sat, Jun 2, 2:19 PM · KMyMoney
wojnilowicz added a comment to D13242: Move ibanbicdata to a plugin.

Works for me so far. Here's what I have tested:

  1. Loading XML file
  2. Make a change
  3. Save as XML file
  4. Quit and restart
  5. Load the XML file saved in step 3
  6. Verify that payeeidentifier are still present
  7. Verify that online job information is still present

    This looks good so far.
  8. Load XML file
  9. Save as database
  10. Quit and restart (loads the database)
  11. Verify that payeeidentifier are still present
  12. Verify that online job information is still present

    Except step 5. everything seems to work. I have to mention, that 5. also does not work on master, so it is not this patch which breaks the feature. Nevertheless, this is a bug that needs to be fixed before we can be sure that this change works as expected with databases.
Sat, Jun 2, 1:39 PM · KMyMoney
wojnilowicz added inline comments to D13279: Pluginize XML Storage.
Sat, Jun 2, 1:38 PM · KMyMoney
wojnilowicz updated the diff for D13242: Move ibanbicdata to a plugin.

Added some missing methods.

Sat, Jun 2, 9:57 AM · KMyMoney
wojnilowicz requested review of D13279: Pluginize XML Storage.
Sat, Jun 2, 6:33 AM · KMyMoney
wojnilowicz committed R883:1516962: Update translations in kf5-stable.
Update translations in kf5-stable
Sat, Jun 2, 5:21 AM
wojnilowicz committed R883:1516961: Update translations in kf5-trunk.
Update translations in kf5-trunk
Sat, Jun 2, 5:21 AM

Thu, May 31

wojnilowicz requested review of D13242: Move ibanbicdata to a plugin.
Thu, May 31, 6:11 PM · KMyMoney

Sun, May 27

wojnilowicz requested review of D13161: Format dialogs headers according to the KDE guidelines.
Sun, May 27, 6:29 PM · KMyMoney
wojnilowicz added a comment to D13159: Format models headers according to the KDE guidelines.

Nobody has been removed in models directory. It's well maintained directory :)

Sun, May 27, 5:46 PM · KMyMoney
wojnilowicz requested review of D13159: Format models headers according to the KDE guidelines.
Sun, May 27, 5:44 PM · KMyMoney
wojnilowicz abandoned D12979: Format mymoney headers according to the KDE guidelines.
Sun, May 27, 5:41 PM · KMyMoney
wojnilowicz committed R261:839feeb80f5f: Get rid of databaseStoreableObject (authored by wojnilowicz).
Get rid of databaseStoreableObject
Sun, May 27, 5:30 PM
wojnilowicz closed D13020: Get rid of databaseStoreableObject.
Sun, May 27, 5:29 PM · KMyMoney
wojnilowicz added a comment to D12979: Format mymoney headers according to the KDE guidelines.

I've committed it as there is no more feedback regarding missing authors.

Sun, May 27, 5:29 PM · KMyMoney
wojnilowicz added a comment to D13020: Get rid of databaseStoreableObject.

After fixing some DB related bugs in master, I applied this patch again. Saving a DB to SQLITE still fails, but now I get a different error on the console:

Failed to save onlineJob "O000001" Reson: Could not load sqlStoragePlugin 'org.kmymoney.creditTransfer.sepa.sqlStoragePlugin', (error: No service matching the requirements was found) /home/thb/devel/kmymoney/kmymoney/plugins/sql/mymoneystoragesql_p.h:2662

One line for each one of them, and I have a few.

I've fixed

No service matching the requirements was found

but saving still fails and it's not part of this patch, as it has failed before in the same spot as before the patch.

It's not the saving part, but it seems to be the reading part. After saving an XML file as database I see the online transaction data in the kmmSepaOrders table using an external browser. But opening the database leaves the view empty. The data of the kmmCostCenter table is not saved. The data is in the XML file and the table is empty, but that is not related to this patch.

Sun, May 27, 4:46 PM · KMyMoney
wojnilowicz added a comment to D13020: Get rid of databaseStoreableObject.

After fixing some DB related bugs in master, I applied this patch again. Saving a DB to SQLITE still fails, but now I get a different error on the console:

Failed to save onlineJob "O000001" Reson: Could not load sqlStoragePlugin 'org.kmymoney.creditTransfer.sepa.sqlStoragePlugin', (error: No service matching the requirements was found) /home/thb/devel/kmymoney/kmymoney/plugins/sql/mymoneystoragesql_p.h:2662

One line for each one of them, and I have a few.

Sun, May 27, 4:15 PM · KMyMoney
wojnilowicz updated the diff for D13020: Get rid of databaseStoreableObject.
Sun, May 27, 4:14 PM · KMyMoney

Fri, May 25

wojnilowicz committed R261:b979537747b1: Try to fix compilation on MinGW (authored by wojnilowicz).
Try to fix compilation on MinGW
Fri, May 25, 2:33 PM
wojnilowicz committed R261:724fad7d3e5e: Silence warnings from external libraries on MSVC (authored by mhubner).
Silence warnings from external libraries on MSVC
Fri, May 25, 2:33 PM
wojnilowicz updated the summary of D13020: Get rid of databaseStoreableObject.
Fri, May 25, 2:13 PM · KMyMoney
wojnilowicz updated the diff for D13020: Get rid of databaseStoreableObject.

createFromSqlDatabase methods are now moved to SQL storage plugin as well, so the only core area of KMM that requires SQL is ibanbicdata.

Fri, May 25, 2:13 PM · KMyMoney

May 24 2018

wojnilowicz committed R877:9d7380d2a876: Add missing dependency to KMyMoney (authored by wojnilowicz).
Add missing dependency to KMyMoney
May 24 2018, 12:57 PM

May 23 2018

wojnilowicz added a comment to R877:9fe39ab0b028: Try to fix Gwenhywfar on MinGW.

(Haven't studied the code yet...)
but it might be that you'd need to bump the patchLevel (like Hannah does in R877:8fa1d003f45a)
to (clear the cache and) trigger a rebuild in craft CI ...

May 23 2018, 1:05 PM
wojnilowicz committed R877:132530567025: Try to fix Gwenhywfar on MinGW (authored by wojnilowicz).
Try to fix Gwenhywfar on MinGW
May 23 2018, 1:03 PM

May 22 2018

wojnilowicz committed R877:9fe39ab0b028: Try to fix Gwenhywfar on MinGW (authored by wojnilowicz).
Try to fix Gwenhywfar on MinGW
May 22 2018, 6:42 PM

May 21 2018

wojnilowicz requested review of D13020: Get rid of databaseStoreableObject.
May 21 2018, 4:31 PM · KMyMoney

May 20 2018

wojnilowicz added a comment to D12979: Format mymoney headers according to the KDE guidelines.

Are you seriously questioning that people in distributed teams worked on software before the internet? I certainly remember passing sourcecode around on floppy disks and CDs myself. This was a pain in the neck and I'm sort of jealous of you if you didn't have to go through that. Just because you didn't does not mean noone did, though.

May 20 2018, 6:38 PM · KMyMoney
wojnilowicz added a comment to D12979: Format mymoney headers according to the KDE guidelines.

Hmm, isn't that logic flawed even for people who did have CVS though? Couldn't someone have sent patches (and therefore be a legit contributor) to a file before getting CVS access and never have touched the file again later on?

May 20 2018, 3:50 PM · KMyMoney
wojnilowicz updated the diff for D12979: Format mymoney headers according to the KDE guidelines.
  1. add Darren Gould name in every file he contributed,
  2. include contributions before 2001-03-07,
  3. include authors that were only in .h files and not in .cpp files.
May 20 2018, 12:40 PM · KMyMoney
wojnilowicz added a comment to D12979: Format mymoney headers according to the KDE guidelines.

While your assumption that people without traces in cvs or on the mailing list may not be valid authors is probably not the worst metric someone could come up with it is, in the end, still just speculation.

May 20 2018, 8:36 AM · KMyMoney
wojnilowicz added a comment to D12979: Format mymoney headers according to the KDE guidelines.

As this is not a really good forum for this type of discussion, I hope I can be sufficiently brief here, and perhaps we can continue the discussion on the dev mailing list.

May 20 2018, 8:35 AM · KMyMoney

May 19 2018

wojnilowicz added a comment to D12979: Format mymoney headers according to the KDE guidelines.

NOTE: I think it is important to have this discussion, but I do not intend for it to block or delay committing these changes. Even if there is eventual agreement for a different handling of author names, it can be handled with a separate commit at that time.

May 19 2018, 8:37 PM · KMyMoney
wojnilowicz added a comment to D12979: Format mymoney headers according to the KDE guidelines.

Wow. Don't you think that "kicking somebody off the project" seems a little harsh? In the end, those people claimed their authorship through adding their names to the headers (and that's what -when push comes to shove- really matters), not through comments on a mailing list or cvs commits. To me, removing someone who did potentially contribute (and, honestly speaking, why would someone add him/herself to the headers of the source files if they didn't?) in any form (technically this could have been verbally expressed advice, review or anything that happened offline before checking the code in) is (in lack of better words) morally questionable and, at the very least, just rude. How would you feel if in a year or two someone removes your name arguing that he or she doesn't see you as a valid author/contributor because of some kind of self defined metric (cvs commits, in this case)? In your opinion - what is the improvement (to the code, the application, the project, or anything) or gain resulting from removing those people?

May 19 2018, 8:37 PM · KMyMoney
wojnilowicz requested review of D12979: Format mymoney headers according to the KDE guidelines.
May 19 2018, 11:27 AM · KMyMoney
wojnilowicz committed R261:6aec43beb40a: Try to fix compilation on MacOS (authored by wojnilowicz).
Try to fix compilation on MacOS
May 19 2018, 5:55 AM
wojnilowicz committed R261:fc35ce3d7df5: Format CSV plugin headers according to the KDE guidelines (authored by wojnilowicz).
Format CSV plugin headers according to the KDE guidelines
May 19 2018, 5:55 AM