wojnilowicz (Łukasz Wojniłowicz)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 1 2017, 5:16 PM (193 w, 6 d)
Availability
Available

Recent Activity

Jun 14 2020

wojnilowicz closed D29258: Don't use notifybysnore.h on MSYS2.

It probably won't hurt

Jun 14 2020, 5:25 PM · Frameworks
wojnilowicz added a comment to D29257: Use std::isnan and std::isinf on MSYS2.

Bump.

Jun 14 2020, 3:47 PM
wojnilowicz added inline comments to D29258: Don't use notifybysnore.h on MSYS2.
Jun 14 2020, 3:47 PM · Frameworks
wojnilowicz updated the diff for D29258: Don't use notifybysnore.h on MSYS2.

Qt5Network added as required

Jun 14 2020, 3:45 PM · Frameworks
wojnilowicz committed R883:1571617: Update translations in kf5-trunk.
Update translations in kf5-trunk
Jun 14 2020, 7:12 AM

Jun 7 2020

wojnilowicz committed R883:1570747: Update translations in kf5-trunk.
Update translations in kf5-trunk
Jun 7 2020, 5:47 AM

Jun 6 2020

wojnilowicz added a comment to D29258: Don't use notifybysnore.h on MSYS2.

You could also just deploy the binary with msys.

Jun 6 2020, 12:51 PM · Frameworks
wojnilowicz added a comment to D29258: Don't use notifybysnore.h on MSYS2.

Thanks for looking into that matter.

Jun 6 2020, 12:48 PM · Frameworks

May 17 2020

wojnilowicz committed R883:1569687: Update translations in kf5-trunk.
Update translations in kf5-trunk
May 17 2020, 5:55 AM

May 16 2020

wojnilowicz added a comment to D29257: Use std::isnan and std::isinf on MSYS2.

Bump.

May 16 2020, 8:06 AM
wojnilowicz added a comment to D29258: Don't use notifybysnore.h on MSYS2.

Could anyone review my patch again?

May 16 2020, 8:06 AM · Frameworks
wojnilowicz committed R883:1569646: Update translations in kf5-stable.
Update translations in kf5-stable
May 16 2020, 7:03 AM
wojnilowicz committed R883:1569645: Update translations in kf5-trunk.
Update translations in kf5-trunk
May 16 2020, 7:02 AM
wojnilowicz committed R883:1569641: Contribution to kf5-stable by Grzegorz Szymaszek.
Contribution to kf5-stable by Grzegorz Szymaszek
May 16 2020, 6:15 AM
wojnilowicz committed R883:1569640: Contribution to kf5-trunk by Grzegorz Szymaszek.
Contribution to kf5-trunk by Grzegorz Szymaszek
May 16 2020, 6:15 AM

May 10 2020

wojnilowicz committed R883:1568975: Update translations in kf5-trunk.
Update translations in kf5-trunk
May 10 2020, 5:26 AM

May 3 2020

wojnilowicz committed R883:1568145: Update translations in kf5-trunk.
Update translations in kf5-trunk
May 3 2020, 5:16 AM

Apr 29 2020

wojnilowicz added a comment to D29258: Don't use notifybysnore.h on MSYS2.

SnoreToast fails to build on MSYS2 due to missing
which apparently is not available for this compiler.

I'm sorry, missing what exactly?

Apr 29 2020, 4:53 PM · Frameworks
wojnilowicz updated the diff for D29258: Don't use notifybysnore.h on MSYS2.

I see. I've updated the patch. Linking to downloaded library is now possible, and there is a fallback if no library is present.

Apr 29 2020, 4:52 PM · Frameworks

Apr 28 2020

wojnilowicz requested review of D29258: Don't use notifybysnore.h on MSYS2.
Apr 28 2020, 3:36 PM · Frameworks
wojnilowicz requested review of D29257: Use std::isnan and std::isinf on MSYS2.
Apr 28 2020, 3:21 PM

Apr 26 2020

wojnilowicz committed R883:1567672: Update translations in kf5-trunk.
Update translations in kf5-trunk
Apr 26 2020, 6:28 AM

Apr 22 2020

wojnilowicz committed R883:1567153: Update translations in kf5-trunk.
Update translations in kf5-trunk
Apr 22 2020, 11:49 PM
wojnilowicz committed R883:1567154: Update translations in kf5-stable.
Update translations in kf5-stable
Apr 22 2020, 11:49 PM

Apr 12 2020

wojnilowicz committed R883:1566497: Update translations in kf5-trunk.
Update translations in kf5-trunk
Apr 12 2020, 7:50 AM

Apr 5 2020

wojnilowicz committed R883:1565984: Update translations in kf5-stable.
Update translations in kf5-stable
Apr 5 2020, 5:49 AM
wojnilowicz committed R883:1565983: Update translations in kf5-trunk.
Update translations in kf5-trunk
Apr 5 2020, 5:49 AM

Mar 31 2020

wojnilowicz added a comment to D28441: Fix RSITimerTest::noPopupBreak.

Is this an actual problem with the app or just a test fix (i.e. do i need to make a release to fix a potential crash?)

Mar 31 2020, 5:48 AM

Mar 30 2020

wojnilowicz added a comment to D26498: Don't reset m_pauseCounter on short inputs.
In D26498#638035, @pino wrote:

Following patch fixes the issue


Is this solution good for you?

This patch fixes the rsibreak_tests crash, however the test still fails in RSITimerTest::triggerSimpleBigBreak(), in the way I already mentioned.

Mar 30 2020, 3:09 PM
wojnilowicz requested review of D28441: Fix RSITimerTest::noPopupBreak.
Mar 30 2020, 3:06 PM
wojnilowicz added a comment to D26498: Don't reset m_pauseCounter on short inputs.
In D26498#637506, @pino wrote:

Hi @aacid & @wojnilowicz:

unfortunately this commit breaks the rsibreak_tests:

  • in some states, m_shortInputCounter is a nullptr, so RSITimer::timeout() tries to ->tick() a null pointer
  • even doing a nullptr check for the code above, RSITimerTest::triggerSimpleBigBreak() fails: ` FAIL! : RSITimerTest::triggerSimpleBigBreak() Compared values are not the same Actual (spy1Relax.count()): 100 Expected (relaxCountExp) : 97 Loc: [SRCDIR/test/rsitimer_test.cpp(186)] `

    Can you please look into both the issues? Thanks!
Mar 30 2020, 12:21 PM

Mar 29 2020

wojnilowicz committed R883:1565394: Update translations in kf5-trunk.
Update translations in kf5-trunk
Mar 29 2020, 6:53 AM

Mar 22 2020

wojnilowicz committed R883:1564800: Update translations in kf5-trunk.
Update translations in kf5-trunk
Mar 22 2020, 7:07 AM

Mar 21 2020

wojnilowicz committed R456:ccdff871c9dd: Report full length for translational units (authored by wojnilowicz).
Report full length for translational units
Mar 21 2020, 8:37 AM

Mar 15 2020

wojnilowicz committed R883:1564010: Update translations in kf5-trunk.
Update translations in kf5-trunk
Mar 15 2020, 6:44 AM

Mar 8 2020

wojnilowicz committed R883:1563636: Update translations in kf5-stable.
Update translations in kf5-stable
Mar 8 2020, 7:36 AM
wojnilowicz committed R883:1563635: Update translations in kf5-trunk.
Update translations in kf5-trunk
Mar 8 2020, 7:36 AM

Mar 1 2020

wojnilowicz committed R883:1563140: Update translations in kf5-trunk.
Update translations in kf5-trunk
Mar 1 2020, 7:37 AM

Feb 23 2020

wojnilowicz committed R883:1562769: Update translations in kf5-stable.
Update translations in kf5-stable
Feb 23 2020, 8:18 AM
wojnilowicz committed R883:1562768: Update translations in kf5-trunk.
Update translations in kf5-trunk
Feb 23 2020, 8:18 AM

Feb 16 2020

wojnilowicz committed R883:1562362: Update translations in kf5-stable.
Update translations in kf5-stable
Feb 16 2020, 8:40 AM
wojnilowicz committed R883:1562361: Update translations in kf5-trunk.
Update translations in kf5-trunk
Feb 16 2020, 8:40 AM

Feb 8 2020

wojnilowicz committed R883:1561885: Update translations in kf5-trunk.
Update translations in kf5-trunk
Feb 8 2020, 9:33 AM

Feb 1 2020

wojnilowicz committed R883:1561482: Update translations in kf5-stable.
Update translations in kf5-stable
Feb 1 2020, 10:30 AM
wojnilowicz committed R883:1561481: Update translations in kf5-trunk.
Update translations in kf5-trunk
Feb 1 2020, 10:29 AM

Jan 31 2020

wojnilowicz committed R456:0f18cc5f248e: Ensure that length columns can be properly sorted (authored by wojnilowicz).
Ensure that length columns can be properly sorted
Jan 31 2020, 6:01 PM

Jan 26 2020

wojnilowicz committed R883:1561156: Update translations in kf5-trunk.
Update translations in kf5-trunk
Jan 26 2020, 8:41 AM

Jan 19 2020

wojnilowicz committed R883:1560793: Update translations in kf5-trunk.
Update translations in kf5-trunk
Jan 19 2020, 8:31 AM

Jan 18 2020

wojnilowicz committed R456:2ce7b6c4b6bd: Add length columns to CatalogModelColumns (authored by wojnilowicz).
Add length columns to CatalogModelColumns
Jan 18 2020, 8:29 AM
wojnilowicz closed D26477: Add length columns to CatalogModelColumns.
Jan 18 2020, 8:29 AM
wojnilowicz committed R883:1560537: Update translations in kf5-trunk.
Update translations in kf5-trunk
Jan 18 2020, 7:36 AM

Jan 12 2020

wojnilowicz added a comment to D26498: Don't reset m_pauseCounter on short inputs.

Thanks a lot for your contribution :)

Jan 12 2020, 10:18 AM
wojnilowicz committed R883:1559993: Update translations in kf5-trunk.
Update translations in kf5-trunk
Jan 12 2020, 9:48 AM

Jan 11 2020

wojnilowicz committed R883:1559924: Update translations in kf5-trunk.
Update translations in kf5-trunk
Jan 11 2020, 11:44 AM
wojnilowicz committed R883:1559923: Update translations in kf5-stable.
Update translations in kf5-stable
Jan 11 2020, 11:43 AM
wojnilowicz added a comment to D26498: Don't reset m_pauseCounter on short inputs.

Doesn't seem to really work for me.

I mean, yes it works in the sense that the timer doesn't go back to 20 seconds but at the end of my "you should rest" period i always get the "oh you've been bad my not resting" screen if i have used this feature of ignoring a few seconds.

Jan 11 2020, 10:38 AM

Jan 7 2020

wojnilowicz updated the diff for D26498: Don't reset m_pauseCounter on short inputs.

Did not forgot.

Jan 7 2020, 3:51 PM
wojnilowicz updated the diff for D26498: Don't reset m_pauseCounter on short inputs.

Forgot to reset m_shortInputCounter in RSITimer::doBreakNow.

Jan 7 2020, 3:48 PM
wojnilowicz requested review of D26498: Don't reset m_pauseCounter on short inputs.
Jan 7 2020, 3:43 PM

Jan 6 2020

wojnilowicz added a comment to D26477: Add length columns to CatalogModelColumns.

Here is how the new columns look like.

Jan 6 2020, 8:07 PM
wojnilowicz requested review of D26477: Add length columns to CatalogModelColumns.
Jan 6 2020, 8:03 PM

Dec 29 2019

wojnilowicz committed R883:1559142: Update translations in kf5-trunk.
Update translations in kf5-trunk
Dec 29 2019, 7:53 PM

Dec 25 2019

wojnilowicz committed R883:1558976: Update translations in kf5-stable.
Update translations in kf5-stable
Dec 25 2019, 5:17 PM
wojnilowicz committed R883:1558975: Update translations in kf5-trunk.
Update translations in kf5-trunk
Dec 25 2019, 5:16 PM

Dec 14 2019

wojnilowicz committed R883:1558305: Update translations in kf5-trunk.
Update translations in kf5-trunk
Dec 14 2019, 8:41 AM

Dec 10 2019

wojnilowicz committed R883:1557980: Update translations in kf5-trunk.
Update translations in kf5-trunk
Dec 10 2019, 2:20 PM
wojnilowicz committed R883:1557979: Update translations in kf5-stable.
Update translations in kf5-stable
Dec 10 2019, 2:19 PM

Dec 8 2019

wojnilowicz committed R883:1557868: Update translations in kf5-trunk.
Update translations in kf5-trunk
Dec 8 2019, 9:13 AM

Dec 7 2019

wojnilowicz committed R883:1557819: Update translations in kf5-trunk.
Update translations in kf5-trunk
Dec 7 2019, 6:21 AM

Dec 6 2019

wojnilowicz committed R883:1557765: Update translations in kf5-stable.
Update translations in kf5-stable
Dec 6 2019, 12:51 PM
wojnilowicz committed R883:1557764: Update translations in kf5-trunk.
Update translations in kf5-trunk
Dec 6 2019, 12:51 PM

Dec 3 2019

wojnilowicz committed R883:1557589: Update translations in kf5-stable.
Update translations in kf5-stable
Dec 3 2019, 5:02 PM
wojnilowicz committed R883:1557588: Update translations in kf5-trunk.
Update translations in kf5-trunk
Dec 3 2019, 5:02 PM

Dec 2 2019

wojnilowicz committed R883:1557513: Update translations in kf5-trunk.
Update translations in kf5-trunk
Dec 2 2019, 10:50 AM
wojnilowicz committed R883:1557512: Update translations in kf5-stable.
Update translations in kf5-stable
Dec 2 2019, 10:50 AM

Nov 30 2019

wojnilowicz committed R883:1557377: Update translations in kf5-trunk.
Update translations in kf5-trunk
Nov 30 2019, 9:41 AM
wojnilowicz committed R883:1557376: Update translations in kf5-stable.
Update translations in kf5-stable
Nov 30 2019, 9:41 AM

Nov 24 2019

wojnilowicz committed R883:1556826: Update translations in kf5-trunk.
Update translations in kf5-trunk
Nov 24 2019, 7:49 AM
wojnilowicz committed R883:1556825: Update translations in kf5-stable.
Update translations in kf5-stable
Nov 24 2019, 7:48 AM

Nov 11 2019

wojnilowicz committed R883:1555718: Update translations in kf5-trunk.
Update translations in kf5-trunk
Nov 11 2019, 8:05 AM
wojnilowicz committed R883:1555717: Update translations in kf5-stable.
Update translations in kf5-stable
Nov 11 2019, 8:05 AM

Nov 10 2019

wojnilowicz committed R883:1555659: Update translations in kf5-trunk.
Update translations in kf5-trunk
Nov 10 2019, 7:27 AM

Nov 9 2019

wojnilowicz committed R883:1555600: Update translations in kf5-trunk.
Update translations in kf5-trunk
Nov 9 2019, 6:35 AM
wojnilowicz committed R883:1555599: Update translations in kf5-stable.
Update translations in kf5-stable
Nov 9 2019, 6:35 AM

Nov 1 2019

wojnilowicz committed R883:1554842: Update translations in kf5-trunk.
Update translations in kf5-trunk
Nov 1 2019, 8:05 AM
wojnilowicz committed R883:1554840: Update translations in kf5-stable.
Update translations in kf5-stable
Nov 1 2019, 8:04 AM

Oct 26 2019

wojnilowicz committed R883:1554453: Update translations in kf5-trunk.
Update translations in kf5-trunk
Oct 26 2019, 6:39 AM
wojnilowicz committed R883:1554452: Update translations in kf5-stable.
Update translations in kf5-stable
Oct 26 2019, 6:38 AM

Oct 20 2019

wojnilowicz committed R883:1554100: Update translations in kf5-trunk.
Update translations in kf5-trunk
Oct 20 2019, 10:06 AM
wojnilowicz committed R883:1554099: Update translations in kf5-stable.
Update translations in kf5-stable
Oct 20 2019, 10:03 AM

Sep 23 2019

wojnilowicz committed R883:1552422: Update translations in kf5-trunk.
Update translations in kf5-trunk
Sep 23 2019, 8:08 AM
wojnilowicz committed R883:1552421: Update translations in kf5-stable.
Update translations in kf5-stable
Sep 23 2019, 8:07 AM

Sep 21 2019

wojnilowicz committed R883:1552241: Update translations in kf5-trunk.
Update translations in kf5-trunk
Sep 21 2019, 6:41 AM
wojnilowicz committed R883:1552240: Update translations in kf5-stable.
Update translations in kf5-stable
Sep 21 2019, 6:40 AM

Sep 15 2019

wojnilowicz committed R883:1551736: Update translations in kf5-trunk.
Update translations in kf5-trunk
Sep 15 2019, 8:49 AM
wojnilowicz committed R883:1551735: Update translations in kf5-stable.
Update translations in kf5-stable
Sep 15 2019, 8:48 AM

Sep 6 2019

wojnilowicz committed R883:1551232: Update translations in kf5-trunk.
Update translations in kf5-trunk
Sep 6 2019, 7:34 AM
wojnilowicz committed R883:1551231: Update translations in kf5-stable.
Update translations in kf5-stable
Sep 6 2019, 7:34 AM

Aug 15 2019

wojnilowicz committed R883:1549571: Update translations in kf5-stable.
Update translations in kf5-stable
Aug 15 2019, 5:21 AM
wojnilowicz committed R883:1549570: Update translations in kf5-trunk.
Update translations in kf5-trunk
Aug 15 2019, 5:20 AM