kossebau (Friedrich W. H. Kossebau)
User

Projects

User Details

User Since
Apr 18 2015, 11:52 AM (101 w, 1 h)

Recent Activity

Yesterday

kossebau committed R33:aa1baf6583cf: Fix include path for export header to also work when installed (authored by kossebau).
Fix include path for export header to also work when installed
Fri, Mar 24, 5:58 PM
kossebau committed R33:856b2e89ef14: Fix some include paths for export headers to also work when installed (authored by kossebau).
Fix some include paths for export headers to also work when installed
Fri, Mar 24, 5:33 PM
kossebau committed R33:6a3d6a8476e2: API dox: include also libs debugger, documentation, serialization & tests (authored by kossebau).
API dox: include also libs debugger, documentation, serialization & tests
Fri, Mar 24, 1:01 AM
kossebau committed R32:46d2f35b1c7a: Use {} as default value for zero-set flags, not nullptr (authored by kossebau).
Use {} as default value for zero-set flags, not nullptr
Fri, Mar 24, 12:31 AM
kossebau committed R32:7f59cdc4378c: Remove unused Qt::WindowFlags parameter (authored by kossebau).
Remove unused Qt::WindowFlags parameter
Fri, Mar 24, 12:31 AM
kossebau committed R33:10df844c9dfc: Use {} as default value for zero-set flags, not nullptr (authored by kossebau).
Use {} as default value for zero-set flags, not nullptr
Fri, Mar 24, 12:24 AM
kossebau closed D5161: Use {} as default value for zero-set flags, not nullptr by committing R33:10df844c9dfc: Use {} as default value for zero-set flags, not nullptr.
Fri, Mar 24, 12:24 AM
kossebau committed R33:19875d9916f2: Remove unused Qt::WindowFlags parameters from internal API (authored by kossebau).
Remove unused Qt::WindowFlags parameters from internal API
Fri, Mar 24, 12:24 AM
kossebau closed D5159: Remove unused Qt::WindowFlags parameters from internal API by committing R33:19875d9916f2: Remove unused Qt::WindowFlags parameters from internal API.
Fri, Mar 24, 12:23 AM
kossebau added a comment to D5159: Remove unused Qt::WindowFlags parameters from internal API.
In D5159#97250, @apol wrote:
In D5159#97239, @kfunk wrote:

I know why you did that! ;)

Now I want to know too.

Fri, Mar 24, 12:20 AM

Thu, Mar 23

kossebau created D5161: Use {} as default value for zero-set flags, not nullptr.
Thu, Mar 23, 9:25 PM
kossebau created D5159: Remove unused Qt::WindowFlags parameters from internal API.
Thu, Mar 23, 9:15 PM
kossebau closed D3987: Use nullptr in all Frameworks (just diff in KIO shown here).
Thu, Mar 23, 7:59 PM · Frameworks
kossebau accepted D3987: Use nullptr in all Frameworks (just diff in KIO shown here).
In D3987#96434, @kfunk wrote:
In D3987#95858, @kfunk wrote:

Closing. This Diff refactored the code technically correct.

Technically correct, as in: it builds.
But semantically it is incorrect and a regression when it comes to flags, especially as high level languages are made for humans in the first line, not compilers ;)

Not true, the patch does /not/ change behavior. See explanation in https://phabricator.kde.org/D3987#78426.

Thu, Mar 23, 7:55 PM · Frameworks
kossebau committed R33:5c681b15930f: Load Template From File dialogs: fix wrong filter strings usage (authored by kossebau).
Load Template From File dialogs: fix wrong filter strings usage
Thu, Mar 23, 3:37 PM
kossebau closed D5155: Load Template From File dialogs: fix wrong filter strings usage by committing R33:5c681b15930f: Load Template From File dialogs: fix wrong filter strings usage.
Thu, Mar 23, 3:37 PM
kossebau committed R32:c1f784b81db7: Remove now out-of-place comment (authored by kossebau).
Remove now out-of-place comment
Thu, Mar 23, 3:36 PM
kossebau created D5155: Load Template From File dialogs: fix wrong filter strings usage.
Thu, Mar 23, 3:00 PM
kossebau committed R185:d3e1c7fdf80f: Add (now) needed include (authored by kossebau).
Add (now) needed include
Thu, Mar 23, 4:37 AM
kossebau committed R222:7234d666c9a7: Add (now) needed includes (authored by kossebau).
Add (now) needed includes
Thu, Mar 23, 3:19 AM
kossebau committed R64:474471f9ab3c: Add (now) needed includes (authored by kossebau).
Add (now) needed includes
Thu, Mar 23, 3:19 AM
kossebau committed R60:96b948268005: Add (now) needed include (authored by kossebau).
Add (now) needed include
Thu, Mar 23, 2:54 AM
kossebau committed R58:e23234ca6be5: Add (now) needed includes (authored by kossebau).
Add (now) needed includes
Thu, Mar 23, 2:38 AM
kossebau committed R53:5bae1a2de134: Add (now) needed includes (authored by kossebau).
Add (now) needed includes
Thu, Mar 23, 2:18 AM
kossebau committed R52:b77eae0ebcf5: Add (now) needed includes (authored by kossebau).
Add (now) needed includes
Thu, Mar 23, 2:17 AM
kossebau committed R32:989a24418706: Remove unused/unneeded includes & forward declarations from kdevplatform (authored by kossebau).
Remove unused/unneeded includes & forward declarations from kdevplatform
Thu, Mar 23, 2:15 AM
kossebau committed R33:91d466fc1ea0: Remove unused/unneeded includes & forward declarations from kdevplatform (authored by kossebau).
Remove unused/unneeded includes & forward declarations from kdevplatform
Thu, Mar 23, 2:03 AM
kossebau added a comment to T5732: Appstreamcli Test fails sometimes with java.io.IOException (seemingly on copying the appdata file from the workspace to the build folder).

@scarlettclark The linked issues are from build.kde.org. Unless I missed something Kevin's CI is only on his private server, at kfunk.ddns.net and the port 8080, no?

Thu, Mar 23, 12:43 AM · Sysadmin, build.kde.org
kossebau created T5732: Appstreamcli Test fails sometimes with java.io.IOException (seemingly on copying the appdata file from the workspace to the build folder).
Thu, Mar 23, 12:25 AM · Sysadmin, build.kde.org

Wed, Mar 22

kossebau committed R33:97a40f748ff4: Find/Replace in files: Do not wrap content of tooltip for an output line (authored by kossebau).
Find/Replace in files: Do not wrap content of tooltip for an output line
Wed, Mar 22, 8:19 PM
kossebau closed D5135: Find/Replace in files: Do not wrap content of tooltip for an output line by committing R33:97a40f748ff4: Find/Replace in files: Do not wrap content of tooltip for an output line.
Wed, Mar 22, 8:19 PM
kossebau added a comment to D5135: Find/Replace in files: Do not wrap content of tooltip for an output line.

5.1 targetted

Wed, Mar 22, 6:49 PM
kossebau created D5135: Find/Replace in files: Do not wrap content of tooltip for an output line.
Wed, Mar 22, 6:48 PM
kossebau committed R33:8164dc9d98f8: More const ref with method arguments (authored by kossebau).
More const ref with method arguments
Wed, Mar 22, 6:33 PM
kossebau committed R33:14864ab3065f: Use export macro of library the header belongs to (even if self-contained) (authored by kossebau).
Use export macro of library the header belongs to (even if self-contained)
Wed, Mar 22, 6:33 PM
kossebau committed R33:c2534a572d38: Remove no longer used class RichTextPushButton (authored by kossebau).
Remove no longer used class RichTextPushButton
Wed, Mar 22, 6:33 PM
kossebau committed R52:083837116088: Initial port to StandardDocumentationView now being Web* neutral (authored by kossebau).
Initial port to StandardDocumentationView now being Web* neutral
Wed, Mar 22, 1:41 PM
kossebau removed a reviewer for D5127: Switch to newer KDevelop API: kossebau.
Wed, Mar 22, 1:10 PM · Plasma
kossebau removed a reviewer for D5127: Switch to newer KDevelop API: kossebau.

@jriddell : no use to have me as reviewer: I did not do the respective change of kdevplatform API, so cannot really tell if this is the correct usage here. Also have I never run plasmate, so cannot test this patch quickly.

Wed, Mar 22, 1:09 PM · Plasma

Mon, Mar 20

kossebau added a comment to D3987: Use nullptr in all Frameworks (just diff in KIO shown here).
In D3987#95858, @kfunk wrote:

Closing. This Diff refactored the code technically correct.

Mon, Mar 20, 4:46 PM · Frameworks
kossebau committed R32:303ffe8a0302: Hex editor: fix integration into menubar with single "Editor" now gone (authored by kossebau).
Hex editor: fix integration into menubar with single "Editor" now gone
Mon, Mar 20, 4:14 PM

Sat, Mar 18

kossebau committed R33:052ca433e7f9: Search tool: no big fonts and less cursive in output view (authored by kossebau).
Search tool: no big fonts and less cursive in output view
Sat, Mar 18, 5:58 PM
kossebau closed D5098: Search tool: no big fonts and less cursive in output view by committing R33:052ca433e7f9: Search tool: no big fonts and less cursive in output view.
Sat, Mar 18, 5:58 PM
kossebau added a comment to D5098: Search tool: no big fonts and less cursive in output view.
In D5098#95929, @kfunk wrote:

Can we git rid off the excessive line spacing, too? Can we enable the uniform row heights property on the view then?

Sat, Mar 18, 5:55 PM
kossebau committed R33:33f15abfa487: Merge branch '5.1' (authored by kossebau).
Merge branch '5.1'
Sat, Mar 18, 3:15 PM
kossebau added a comment to D5098: Search tool: no big fonts and less cursive in output view.

Before:


After:

Sat, Mar 18, 2:06 PM
kossebau created D5098: Search tool: no big fonts and less cursive in output view.
Sat, Mar 18, 2:04 PM
kossebau committed R33:06857e65fb52: Pass string replacement argument inside i18n call (authored by kossebau).
Pass string replacement argument inside i18n call
Sat, Mar 18, 1:41 PM
kossebau committed R33:2682c1d2544f: Remove unused method GrepOutputDelegate::blendColor(...) (authored by kossebau).
Remove unused method GrepOutputDelegate::blendColor(...)
Sat, Mar 18, 1:41 PM
kossebau committed R33:5872ff06c322: Use i18n(), not tr() (authored by kossebau).
Use i18n(), not tr()
Sat, Mar 18, 1:41 PM
kossebau committed R32:98945a1d7835: Use i18n(), not tr() (authored by kossebau).
Use i18n(), not tr()
Sat, Mar 18, 1:41 PM
kossebau committed R33:5b0858dceecb: Fix typo in test data (authored by kossebau).
Fix typo in test data
Sat, Mar 18, 12:14 AM
kossebau committed R33:43f46c7aa99f: Fix typos in API dox/comments (authored by kossebau).
Fix typos in API dox/comments
Sat, Mar 18, 12:14 AM

Fri, Mar 17

kossebau committed R32:6ed94d891a47: Fix typos in API dox (authored by kossebau).
Fix typos in API dox
Fri, Mar 17, 11:16 PM
kossebau committed R32:93d8398f2567: Remove dead and outdated code for handling KDEV_DISABLE_WELCOMEPAGE (authored by kossebau).
Remove dead and outdated code for handling KDEV_DISABLE_WELCOMEPAGE
Fri, Mar 17, 11:16 PM
kossebau committed R58:93163b410dfb: Let KDECompilerSettings change the policies in the project (authored by kossebau).
Let KDECompilerSettings change the policies in the project
Fri, Mar 17, 8:00 PM
kossebau committed R58:61d2291347c4: Remove non-existing include dir (authored by kossebau).
Remove non-existing include dir
Fri, Mar 17, 8:00 PM
kossebau committed R33:ec809d58e91a: Remove unused/unneeded includes & forward declarations (authored by kossebau).
Remove unused/unneeded includes & forward declarations
Fri, Mar 17, 6:57 PM
kossebau committed R499:bfe217688bc0: Add kdev-clang-tidy & kdev-verapp (authored by kossebau).
Add kdev-clang-tidy & kdev-verapp
Fri, Mar 17, 5:57 PM
kossebau created T5687: Add kdev-clang-tidy & kdev-verapp to build.kde.org.
Fri, Mar 17, 5:44 PM · KDevelop, build.kde.org
kossebau committed R60:0e669bf1cfd0: Add (now) needed include (authored by kossebau).
Add (now) needed include
Fri, Mar 17, 6:33 AM
kossebau committed R638:9328c5d5fca2: Fix build failures due to missing deps of test sources on generated ui headers (authored by kossebau).
Fix build failures due to missing deps of test sources on generated ui headers
Fri, Mar 17, 4:36 AM
kossebau committed R52:e0fddc5b2632: Add (now) needed include (authored by kossebau).
Add (now) needed include
Fri, Mar 17, 2:43 AM
kossebau committed R53:cbbfa416511d: Remove non-existing include dir (authored by kossebau).
Remove non-existing include dir
Fri, Mar 17, 1:55 AM
kossebau committed R53:caf19c3bc204: Add (now) needed include (authored by kossebau).
Add (now) needed include
Fri, Mar 17, 1:55 AM
kossebau committed R33:dfd348ed012a: More const ref with method arguments (authored by kossebau).
More const ref with method arguments
Fri, Mar 17, 12:44 AM
kossebau committed R33:15c6b4f09b38: More explicit constructors (authored by kossebau).
More explicit constructors
Fri, Mar 17, 12:44 AM
kossebau committed R32:d54cd683eec2: Remove unused/unneeded includes & forward declarations (authored by kossebau).
Remove unused/unneeded includes & forward declarations
Fri, Mar 17, 12:39 AM
kossebau committed R32:d6b2fa9d3307: Fix typo in API dox (authored by kossebau).
Fix typo in API dox
Fri, Mar 17, 12:39 AM
kossebau committed R32:5a4fc1051f99: More const ref with method arguments (authored by kossebau).
More const ref with method arguments
Fri, Mar 17, 12:39 AM
kossebau committed R32:d50cd97a26fb: More explicit constructors (authored by kossebau).
More explicit constructors
Fri, Mar 17, 12:39 AM

Thu, Mar 16

kossebau created D5071: Remove unused/unneeded includes & forward declarations.
Thu, Mar 16, 5:45 PM
kossebau added a comment to D5042: Port away from QtWebKit into QtWebEngine.

What about the Qt Rich Text stuff?

I agree that in a perfect world that should be enough. After all Qt Assistant has a QTextBrowser-only build variant already since ages.

Thu, Mar 16, 12:31 AM

Wed, Mar 15

kossebau added inline comments to D5044: Move "Analyze" menu items into "Code" menu.
Wed, Mar 15, 7:01 PM

Mon, Mar 13

kossebau committed R32:05cc5e8d6c93: Port ClangClassHelper to also fill the include_files var (authored by kossebau).
Port ClangClassHelper to also fill the include_files var
Mon, Mar 13, 1:46 AM
kossebau closed D4430: Port ClangClassHelper to also fill the include_files var by committing R32:05cc5e8d6c93: Port ClangClassHelper to also fill the include_files var.
Mon, Mar 13, 1:45 AM

Wed, Mar 8

kossebau added a comment to D4430: Port ClangClassHelper to also fill the include_files var.

Still no matching unit tests added for now. There are two things that could see tests:

  1. the exposed UnknownDeclarationProblem::findMatchingIncludeFiles(...) method
  2. the included_files variable properly filled with data

Both things will need me to invest some more time, as I yet have to grasp things around DUChain enough to write a proper test for the exposed method.
And classhelper code is without any testing approach so far, from what I found (also nothing seen in oldcpp), so that needs some more thinking how to do this properly.

Wed, Mar 8, 2:42 PM
kossebau retitled D4430: Port ClangClassHelper to also fill the include_files var from WIP: Port ClangClassHelper to also fill the include_files var to Port ClangClassHelper to also fill the include_files var.
Wed, Mar 8, 1:12 PM
kossebau updated the diff for D4430: Port ClangClassHelper to also fill the include_files var.

only export UnknownDeclarationProblem::findMatchingIncludeFiles,
keep custom logic for not-existing files specific to classhelper

Wed, Mar 8, 1:11 PM

Tue, Mar 7

kossebau updated subscribers of D4954: Fix "-Wsuggest-override" warnings.

Would be an improvement, thanks for the work, @antonanikin. Patch not tested myself though, assuming you have done well enough :)
@mwolff @ahartmetz Can you tell how much this patch might complicate any potential further patch imports from KDChart? That would be the only blocker here.

Tue, Mar 7, 1:48 PM
kossebau committed R455:261161390b2f: Fix creation of CMake config file, require libkomparediff2/ include prefix (authored by kossebau).
Fix creation of CMake config file, require libkomparediff2/ include prefix
Tue, Mar 7, 8:16 AM
kossebau committed R454:76d7e51b1350: Depend on LibKompareDiff2 5.1 with improved CMake config file (authored by kossebau).
Depend on LibKompareDiff2 5.1 with improved CMake config file
Tue, Mar 7, 3:37 AM

Mon, Mar 6

kossebau committed R32:16bcca260b1a: Remove QT_* definition additions duplicated from toplevel CMakeLists.txt (authored by kossebau).
Remove QT_* definition additions duplicated from toplevel CMakeLists.txt
Mon, Mar 6, 5:24 PM

Fri, Mar 3

kossebau committed R457:13ff976549cd: Do not use static QString objects (authored by kossebau).
Do not use static QString objects
Fri, Mar 3, 1:06 AM
kossebau committed R457:59c5d7a68369: For compared or concatenated strings use QLatin1String, not QStringLiteral (authored by kossebau).
For compared or concatenated strings use QLatin1String, not QStringLiteral
Fri, Mar 3, 1:06 AM
kossebau committed R457:aeaeaefae375: Compose string manually (authored by kossebau).
Compose string manually
Fri, Mar 3, 1:06 AM
kossebau committed R457:61402275ecf7: Avoid calling methods on a temporary object (authored by kossebau).
Avoid calling methods on a temporary object
Fri, Mar 3, 1:06 AM
kossebau committed R457:35bbfc170f21: Add missing emit keyword on signal call (authored by kossebau).
Add missing emit keyword on signal call
Fri, Mar 3, 1:06 AM
kossebau committed R457:0110fce7c161: Remove unused variables/instances (authored by kossebau).
Remove unused variables/instances
Fri, Mar 3, 1:06 AM
kossebau committed R457:8c34aa36e867: Add missing Q_OBJECT macro to QObject subclasses (authored by kossebau).
Add missing Q_OBJECT macro to QObject subclasses
Fri, Mar 3, 1:06 AM

Tue, Feb 28

kossebau committed R32:43c92e0f876e: Merge branch '5.1' (authored by kossebau).
Merge branch '5.1'
Tue, Feb 28, 4:56 PM
kossebau committed R32:eb628d9dd488: Select core dialog: stick dialog buttons to bottom (authored by kossebau).
Select core dialog: stick dialog buttons to bottom
Tue, Feb 28, 4:56 PM
kossebau added a comment to T5466: CI: Fix symbol clashes between llvm used by mesa and the custom one used by KDevelop.

Seems that worked out as intended, KDevelop autotests now fail normally :) (i.e. similar to how they fail locally) and the ball to fix the remaining is back in our court. Thanks, @bcooksley.

Tue, Feb 28, 11:38 AM · KDevelop, build.kde.org

Mon, Feb 27

kossebau committed R32:b5a4949aa77b: Attach-to-process dialog: add "Cancel" button, relabel "Ok" to "Attach" (authored by kossebau).
Attach-to-process dialog: add "Cancel" button, relabel "Ok" to "Attach"
Mon, Feb 27, 10:27 PM
kossebau committed R32:5c03dc5e4cb5: Merge branch '5.1' (authored by kossebau).
Merge branch '5.1'
Mon, Feb 27, 10:27 PM
kossebau closed D4815: Attach-to-process dialog: add "Cancel" button, relabel "Ok" to "Attach" by committing R32:b5a4949aa77b: Attach-to-process dialog: add "Cancel" button, relabel "Ok" to "Attach".
Mon, Feb 27, 10:27 PM
kossebau committed R32:ebe910253dd8: Disassemble/registers view: Remove outter margin, for consistent look (authored by kossebau).
Disassemble/registers view: Remove outter margin, for consistent look
Mon, Feb 27, 10:27 PM
kossebau committed R32:4ad294e30719: Debugger console view: Remove outter margin, for consistent look (authored by kossebau).
Debugger console view: Remove outter margin, for consistent look
Mon, Feb 27, 10:27 PM
kossebau committed R32:12c3bdd52909: Select core dialog: stick dialog buttons to bottom (authored by kossebau).
Select core dialog: stick dialog buttons to bottom
Mon, Feb 27, 10:27 PM
kossebau added inline comments to D4808: Find/Replace in files: fix tooltip omitting the matched text in Find mode.
Mon, Feb 27, 9:05 PM