kossebau (Friedrich W. H. Kossebau)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 11:52 AM (179 w, 23 h)
Availability
Available

Recent Activity

Today

kossebau commandeered D14710: Inject default environment group variables into debug process environment..
Sun, Sep 23, 11:52 AM · KDevelop
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

Thanks. Learned about ObjC++ this way... the world is full of strange things :)

Sun, Sep 23, 11:12 AM · KDevelop
kossebau added a comment to D15565: Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer).

New version also checks launch configuration type and starts analysis only for native applications.

Sun, Sep 23, 10:52 AM · KDevelop
kossebau added a comment to D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks.

@kossebau It seems you did something similar in D6301, maybe you can review this change. Should I also include qtcompat_p.h when Q_FALLTHROUGH is used?

Sun, Sep 23, 10:35 AM · KDevelop

Yesterday

kossebau committed R32:82063708999f: astyle: -Wno-zero-as-null-pointer-constant no more needed for libastyle (authored by kossebau).
astyle: -Wno-zero-as-null-pointer-constant no more needed for libastyle
Sat, Sep 22, 11:01 AM

Fri, Sep 21

kossebau updated the diff for D15606: Fix calling qdbus by using qt5-current name qdbus-qt5.
  • use custom explicit checkToolsInPath code for qdbus variants
  • avoid error print from "which" in kdevelop!
Fri, Sep 21, 4:19 PM · KDevelop
kossebau added a comment to D15606: Fix calling qdbus by using qt5-current name qdbus-qt5.

IMO it should just check for both and prefer qdbus-qt5 if available.

Yes, that was my starting patch, but then I got unsure about the great picture.
If going this route, any shell script wizard proposal how to change checkToolsInPath in kdevplatform_shell_environment.sh to check for both variants, without adding too much boilerplate code?

What about this:

qdbus_exe=$(which qdbus-qt5 qdbus 2>/dev/null | head -n1)

if [ -z "${qdbus_exe}" ]; then checkToolsInPath qdbus-qt5; fi

$qdbus_exe $KDEV_DBUS_ID etc.
Fri, Sep 21, 4:18 PM · KDevelop
kossebau added inline comments to D15625: Sublime: Fix crash caused when all tool view items are small.
Fri, Sep 21, 3:13 PM · KDevelop
kossebau accepted D15625: Sublime: Fix crash caused when all tool view items are small.

Thanks. Patch fine with me, feature still works.
(and now that I know about it I also see the unused modulo pixels from the maxheight calculation ;) something to be solved on a boring day in need for entertainment)

Fri, Sep 21, 3:01 PM · KDevelop
kossebau added inline comments to D15625: Sublime: Fix crash caused when all tool view items are small.
Fri, Sep 21, 1:06 PM · KDevelop
kossebau added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.

Would this be OK as a fix?

Fri, Sep 21, 11:59 AM · KDevelop
kossebau added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.

With asserts enabled, I get a crash with this on opening the settings or sometimes only when selecting Objective-C in the formatting settings

kdevelop: /home/koder/Kode/kdegit/kf5/extragear/kdevelop/kdevelop/plugins/astyle/3rdparty/libastyle/ASFormatter.cpp:3841: std::__cxx11::string astyle::ASFormatter::peekNextText(const string&, bool, std::shared_ptr<astyle::ASPeekStream>) const: Assertion `sourceIterator->getPeekStart() == 0 || streamArg != nullptr' failed.
Fri, Sep 21, 4:25 AM · KDevelop
kossebau added inline comments to D15532: [Astyle] Add Objective C to list of languages with formatters.
Fri, Sep 21, 4:16 AM · KDevelop
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
C is not a subset of C++ (let me point to Mr. Stroustrup who should know it :)

I wouldn't call it that either (it'd be degrading for C ;)), but C++ does inherit from C (and was a layer on top of C in its early days, IIRC with a sort of preprocessor).

In fact, Mr Stroustrup does say basically the same thing:

Except for a few examples [...], C++ is a superset of C.
Fri, Sep 21, 4:12 AM · KDevelop

Thu, Sep 20

kossebau added a comment to D15625: Sublime: Fix crash caused when all tool view items are small.

Please also fix the possibly actual bug, which is

const int maximumWidth = rect.width() / _items.size();

and its counterpart not taking the button spacing into account.

Thu, Sep 20, 6:24 PM · KDevelop
kossebau committed R32:ace3f20bdac1: Merge branch '5.3' (authored by kossebau).
Merge branch '5.3'
Thu, Sep 20, 2:32 PM
kossebau committed R32:fd6607d1ad04: astyle: revert string freeze break in JSON metadata (authored by kossebau).
astyle: revert string freeze break in JSON metadata
Thu, Sep 20, 2:19 PM
kossebau committed R32:c33071e2f064: Install qtlogo.svg as normal icon, so any QIconEngine can find it (authored by kossebau).
Install qtlogo.svg as normal icon, so any QIconEngine can find it
Thu, Sep 20, 2:01 PM
kossebau closed D15621: Install qtlogo.svg as normal icon, so any QIconEngine can find it.
Thu, Sep 20, 2:01 PM · KDevelop
kossebau requested review of D15621: Install qtlogo.svg as normal icon, so any QIconEngine can find it.
Thu, Sep 20, 1:48 PM · KDevelop
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
... shared-mime-info has this questionable inheritage for C++ and Objective-C from C.

I don't think that's so questionable; doesn't the C++ entry also inherit from C? That would be logical at least historically speaking (and properly written C can still be compiled as C++ AFAIK).

Thu, Sep 20, 12:30 PM · KDevelop
kossebau accepted D15532: [Astyle] Add Objective C to list of languages with formatters.

For some reason the preview uses the "C" highlighting mode for me when ObjC is selected, so the preview has some highlighting issues. That seems a bug with KTextEditor I have to explore more.

Nope, this is actually some bug in KDevelop which should be fixed first, somewhere in`SourceFormatterStyle::modeForMimetype(...)` the wrong mode is chosen. Still digging.

Thu, Sep 20, 10:52 AM · KDevelop

Wed, Sep 19

kossebau accepted D15532: [Astyle] Add Objective C to list of languages with formatters.
Code looks fine to me, modulo all the comments made, and works where I tested it. Please also update the summary text and title of the patch.

What title do you propose?

Wed, Sep 19, 9:32 PM · KDevelop
kossebau requested changes to D15532: [Astyle] Add Objective C to list of languages with formatters.

For some reason the preview uses the "C" highlighting mode for me when ObjC is selected, so the preview has some highlighting issues. That seems a bug with KTextEditor I have to explore more.

Wed, Sep 19, 8:24 PM · KDevelop
kossebau accepted D15532: [Astyle] Add Objective C to list of languages with formatters.

Code looks fine to me, modulo all the comments made, and works where I tested it. Please also update the summary text and title of the patch.

Wed, Sep 19, 8:02 PM · KDevelop
kossebau added a comment to D15606: Fix calling qdbus by using qt5-current name qdbus-qt5.

IMO it should just check for both and prefer qdbus-qt5 if available.

Wed, Sep 19, 6:33 PM · KDevelop
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

BTW, this change is still marked as approved, is it?

Wed, Sep 19, 6:29 PM · KDevelop
kossebau requested review of D15606: Fix calling qdbus by using qt5-current name qdbus-qt5.
Wed, Sep 19, 6:26 PM · KDevelop
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

Can the upgrade at least be done in the 5.3 branch, or if not, merged/cherry-picked ASAP after committing to the main branch?

Wed, Sep 19, 11:55 AM · KDevelop
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

I added ObjC previews as requested, and doing so I noticed I had to make a few more changes, justifying a ticket name change. I did mention the change was going to be a bit more elaborate than one might have thought, didn't I? :)

Wed, Sep 19, 11:10 AM · KDevelop

Tue, Sep 18

kossebau added a comment to D15591: Add Open Document thumbnailer.

Just FYI, as I was added, I currently have no time reserved for document related code work:

Tue, Sep 18, 9:53 PM · Frameworks, Dolphin
kossebau added inline comments to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.
Tue, Sep 18, 12:36 PM · KDevelop
kossebau added inline comments to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.
Tue, Sep 18, 12:34 PM · KDevelop
kossebau added a comment to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

I would like to first try to find the reason why the condition bool shrink = rect.width() < sizeHint().width(); seems to still lead us here into a situation where only "smallItems" exists?
I would suspect some rounding errors.

Tue, Sep 18, 12:13 PM · KDevelop

Mon, Sep 17

kossebau committed R293:bde628aa2f1c: Use QString's multi-arg with multiple string args (authored by kossebau).
Use QString's multi-arg with multiple string args
Mon, Sep 17, 11:25 PM
kossebau committed R293:8112f02db8a3: Avoid potential detach on range-loops with non-const Qt containers (authored by kossebau).
Avoid potential detach on range-loops with non-const Qt containers
Mon, Sep 17, 11:25 PM
kossebau requested review of D15582: Reference product "KF5" in widget metadata, instead of "KDE".
Mon, Sep 17, 11:23 PM · Frameworks
kossebau committed R265:2cedec687ad3: API dox: 0 -> nullptr (authored by kossebau).
API dox: 0 -> nullptr
Mon, Sep 17, 11:22 PM
kossebau committed R242:53a296035369: Avoid potential detach on range-loops with non-const Qt containers (authored by kossebau).
Avoid potential detach on range-loops with non-const Qt containers
Mon, Sep 17, 11:18 PM
kossebau committed R216:59d896b07c54: Use reference in for loop for type with non-trivial copy constructor (authored by kossebau).
Use reference in for loop for type with non-trivial copy constructor
Mon, Sep 17, 11:16 PM
kossebau committed R216:b0b51a25ab6b: Avoid potential detach on range-loops with non-const Qt containers (authored by kossebau).
Avoid potential detach on range-loops with non-const Qt containers
Mon, Sep 17, 11:16 PM
kossebau committed R216:3207de5d5ce1: Include KDEFrameworkCompilerSettings using NO_POLICY_SCOPE (authored by kossebau).
Include KDEFrameworkCompilerSettings using NO_POLICY_SCOPE
Mon, Sep 17, 11:16 PM
kossebau committed R246:59c330505892: Avoid potential detach on range-loops with non-const Qt containers (authored by kossebau).
Avoid potential detach on range-loops with non-const Qt containers
Mon, Sep 17, 11:14 PM
kossebau committed R275:d9f818def89f: Use reference in for loop for type with non-trivial copy constructor (authored by kossebau).
Use reference in for loop for type with non-trivial copy constructor
Mon, Sep 17, 11:14 PM
kossebau committed R245:f25235915c26: API dox: fix @note, to be used without trailing : (authored by kossebau).
API dox: fix @note, to be used without trailing :
Mon, Sep 17, 11:13 PM
kossebau committed R245:62de7dd789b7: Avoid potential detach on range-loops with non-const Qt containers (authored by kossebau).
Avoid potential detach on range-loops with non-const Qt containers
Mon, Sep 17, 11:13 PM
kossebau committed R245:ea22fa271741: Use QString's multi-arg with multiple string args (authored by kossebau).
Use QString's multi-arg with multiple string args
Mon, Sep 17, 11:13 PM
kossebau committed R244:4ede1d829247: Use QString's multi-arg with multiple string args (authored by kossebau).
Use QString's multi-arg with multiple string args
Mon, Sep 17, 11:10 PM
kossebau committed R278:fcf5676c1022: API dox: 0 -> nullptr (authored by kossebau).
API dox: 0 -> nullptr
Mon, Sep 17, 11:08 PM
kossebau committed R278:260839018799: Use QString's multi-arg with multiple string args (authored by kossebau).
Use QString's multi-arg with multiple string args
Mon, Sep 17, 11:08 PM
kossebau committed R236:7f872e135d1b: Use QString's multi-arg with multiple string args (authored by kossebau).
Use QString's multi-arg with multiple string args
Mon, Sep 17, 11:07 PM
kossebau committed R311:9cdac08adfe0: Use QString's multi-arg with multiple string args (authored by kossebau).
Use QString's multi-arg with multiple string args
Mon, Sep 17, 11:07 PM
kossebau committed R311:c30084b20b4c: Avoid potential detach on range-loops with non-const Qt containers (authored by kossebau).
Avoid potential detach on range-loops with non-const Qt containers
Mon, Sep 17, 11:07 PM
kossebau committed R308:55f346967663: Avoid potential detach on range-loops with non-const Qt containers (authored by kossebau).
Avoid potential detach on range-loops with non-const Qt containers
Mon, Sep 17, 11:04 PM
kossebau committed R308:570eb9f4ad5f: API dox: 0 -> nullptr (authored by kossebau).
API dox: 0 -> nullptr
Mon, Sep 17, 11:04 PM
kossebau committed R290:53920bc0eb3d: Use reference in for loop for type with non-trivial copy constructor (authored by kossebau).
Use reference in for loop for type with non-trivial copy constructor
Mon, Sep 17, 11:02 PM
kossebau committed R305:29506294859c: Fix UI file hint: KUrlRequester now has QWidget as base class (authored by kossebau).
Fix UI file hint: KUrlRequester now has QWidget as base class
Mon, Sep 17, 10:51 PM
kossebau committed R288:cf9f9f10579f: Use QString's multi-arg with multiple string args (authored by kossebau).
Use QString's multi-arg with multiple string args
Mon, Sep 17, 10:47 PM
kossebau committed R169:510fe37a6b29: Use more nullptr (authored by kossebau).
Use more nullptr
Mon, Sep 17, 10:39 PM
kossebau committed R169:67ac0ab7db40: Avoid potential detach on range-loops with non-const Qt containers (authored by kossebau).
Avoid potential detach on range-loops with non-const Qt containers
Mon, Sep 17, 10:39 PM
kossebau committed R241:6dc5d87bd17d: IKWS: use non-deprecated "X-KDE-ServiceTypes" in desktop file generation (authored by kossebau).
IKWS: use non-deprecated "X-KDE-ServiceTypes" in desktop file generation
Mon, Sep 17, 10:38 PM
kossebau committed R241:5626a5a81c33: Avoid potential detach on range-loops with non-const Qt containers (authored by kossebau).
Avoid potential detach on range-loops with non-const Qt containers
Mon, Sep 17, 10:38 PM
kossebau committed R241:69e44f4862da: Use QString's multi-arg with multiple string args (authored by kossebau).
Use QString's multi-arg with multiple string args
Mon, Sep 17, 10:38 PM
kossebau committed R175:9b05cacc1b27: Avoid potential detach on range-loops with non-const Qt containers (authored by kossebau).
Avoid potential detach on range-loops with non-const Qt containers
Mon, Sep 17, 10:33 PM
kossebau committed R268:44d268c63346: Use QString's multi-arg with multiple string args (authored by kossebau).
Use QString's multi-arg with multiple string args
Mon, Sep 17, 10:31 PM
kossebau committed R268:34a6c782b76f: Avoid potential detach on range-loops with non-const Qt containers (authored by kossebau).
Avoid potential detach on range-loops with non-const Qt containers
Mon, Sep 17, 10:31 PM
kossebau committed R296:16576febc6b6: Avoid potential detach on range-loops with non-const Qt containers (authored by kossebau).
Avoid potential detach on range-loops with non-const Qt containers
Mon, Sep 17, 10:28 PM
kossebau committed R237:217c0b00f531: API dox: 0 -> nullptr (authored by kossebau).
API dox: 0 -> nullptr
Mon, Sep 17, 10:24 PM
kossebau committed R284:f35f67eb4f7a: API dox: 0 -> nullptr (authored by kossebau).
API dox: 0 -> nullptr
Mon, Sep 17, 10:22 PM
kossebau committed R294:f9af723befcf: Use QString's multi-arg with multiple string args (authored by kossebau).
Use QString's multi-arg with multiple string args
Mon, Sep 17, 10:21 PM
kossebau committed R294:4ff8dcf2e163: API dox: 0 -> nullptr (authored by kossebau).
API dox: 0 -> nullptr
Mon, Sep 17, 10:21 PM
kossebau committed R283:8de54369eb9e: Remove unused variable (authored by kossebau).
Remove unused variable
Mon, Sep 17, 10:19 PM
kossebau committed R283:edbc8f623c96: Use QString's multi-arg with multiple string args (authored by kossebau).
Use QString's multi-arg with multiple string args
Mon, Sep 17, 10:19 PM
kossebau committed R243:750ebf21977d: Use QString's multi-arg with multiple string args (authored by kossebau).
Use QString's multi-arg with multiple string args
Mon, Sep 17, 10:12 PM
kossebau committed R499:5ddc52d4f533: Fix: let KSieve depend on the actual KF Purpose (authored by kossebau).
Fix: let KSieve depend on the actual KF Purpose
Mon, Sep 17, 9:36 PM
kossebau added a comment to D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.

What I would like to see is a comment // KF6: Merge KTextEditor::AnnotationViewInterfaceV2 into KTextEditor::AnnotationViewInterface (kossebau).
For me, this comment is really important, since this tells you that you will in 2-3 years (when Qt6 arrives) work on this and merge it down: Since there is only you (KDevelop) who is using this interface, so you have to maintain it ;)

Mon, Sep 17, 1:16 PM · Frameworks, Kate
kossebau updated the diff for D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.

also add todo about merging KTextEditor::AnnotationViewInterfaceV2 into KTextEditor::AnnotationViewInterface

Mon, Sep 17, 1:13 PM · Frameworks, Kate
kossebau added a comment to D15565: Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer).

Given this is a bug fix and thus should also go to 5.3 branch. could you try a version with no new strings that need translation? Is there a chance existing strings can be reused (from the same catalog, thus used elsewhere in the plugin)?
Otherwise we need to ask the translators for a string freeze exception.

Mon, Sep 17, 11:31 AM · KDevelop
kossebau accepted D15532: [Astyle] Add Objective C to list of languages with formatters.

If you have a chance/time, please considerupdating the patch by adding some samples for the new language types to AStylePlugin::previewText(SourceFormatterStyle, QMimeType).
Currently that one uses C++ code for the preview, which surely is a non-pleasing experience.

Mon, Sep 17, 11:01 AM · KDevelop
kossebau committed R287:1db1b946579a: [EPS] qWarning -> qCWarning (authored by kossebau).
[EPS] qWarning -> qCWarning
Mon, Sep 17, 10:09 AM
kossebau committed R287:98c65a438dfb: [EPS] Fix crash at app shutdown (being tried to persist clipboard image) (authored by kossebau).
[EPS] Fix crash at app shutdown (being tried to persist clipboard image)
Mon, Sep 17, 9:54 AM
kossebau closed D15405: [EPS] Fix crash at app shutdown (being tried to persist clipboard image).
Mon, Sep 17, 9:54 AM · Frameworks

Sun, Sep 16

kossebau updated the diff for D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.

Update to Dominik's first review

Sun, Sep 16, 9:20 PM · Frameworks, Kate
kossebau added inline comments to D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.
Sun, Sep 16, 9:19 PM · Frameworks, Kate
kossebau committed R881:d5029d7217b7: Use Q_SIGNALS/Q_EMIT instead of signals/emit in generated sources (authored by kossebau).
Use Q_SIGNALS/Q_EMIT instead of signals/emit in generated sources
Sun, Sep 16, 5:25 PM
kossebau closed D15545: Use Q_SIGNALS/Q_EMIT instead of signals/emit in generated sources.
Sun, Sep 16, 5:25 PM
kossebau committed R881:c970b1c4178a: Remove unused QWidget dependecy from Todo example app (authored by kossebau).
Remove unused QWidget dependecy from Todo example app
Sun, Sep 16, 5:18 PM
kossebau closed D15552: Remove unused QWidget dependecy from Todo example app.
Sun, Sep 16, 5:18 PM
kossebau committed R881:dff4e2a0d245: Use nullptr in generated C++ sources (authored by kossebau).
Use nullptr in generated C++ sources
Sun, Sep 16, 5:15 PM
kossebau closed D15553: Use nullptr in generated C++ sources.
Sun, Sep 16, 5:15 PM
kossebau updated the summary of D15545: Use Q_SIGNALS/Q_EMIT instead of signals/emit in generated sources.
Sun, Sep 16, 3:48 PM
kossebau updated the diff for D15545: Use Q_SIGNALS/Q_EMIT instead of signals/emit in generated sources.

update to also use Q_EMIT

Sun, Sep 16, 3:45 PM
kossebau requested review of D15553: Use nullptr in generated C++ sources.
Sun, Sep 16, 3:44 PM
kossebau requested review of D15552: Remove unused QWidget dependecy from Todo example app.
Sun, Sep 16, 3:44 PM
kossebau added a comment to D15545: Use Q_SIGNALS/Q_EMIT instead of signals/emit in generated sources.

Actually will update this patch to also include Q_EMIT, update coming soon here.

Sun, Sep 16, 10:09 AM
kossebau added a comment to D15545: Use Q_SIGNALS/Q_EMIT instead of signals/emit in generated sources.

Better safe than sorry. I was not familiar with this practice. I looked for some information on it and found these https://www.kdab.com/kdab-contributions-to-qt-5-0-part-5/ I found no qt.io docs on QT_NO_SIGNALS_SLOTS_KEYWORDS but using Q_SIGNALS is listed as a good idea at http://doc.qt.io/qt-5/qobject.html#Q_SIGNALS.

Sun, Sep 16, 10:09 AM

Sat, Sep 15

kossebau requested review of D15545: Use Q_SIGNALS/Q_EMIT instead of signals/emit in generated sources.
Sat, Sep 15, 11:36 PM
kossebau committed R881:1ce86bd5d58d: Add break; statements in the generated switch code for model::data() (authored by kossebau).
Add break; statements in the generated switch code for model::data()
Sat, Sep 15, 8:02 PM
kossebau closed D15541: Add break; statements in the generated switch code for model::data().
Sat, Sep 15, 8:02 PM
kossebau requested review of D15541: Add break; statements in the generated switch code for model::data().
Sat, Sep 15, 7:45 PM