kossebau (Friedrich W. H. Kossebau)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 11:52 AM (149 w, 18 h)
Availability
Available

Recent Activity

Today

kossebau committed R457:d5c8e1d22319: Bump version to 0.24.3 (authored by kossebau).
Bump version to 0.24.3
Sun, Feb 25, 3:11 AM

Yesterday

kossebau added a comment to D10795: [grouping applet] Use "object-group" as icon.

Request for dedicated icon just filed as: https://bugs.kde.org/show_bug.cgi?id=391009

Sat, Feb 24, 4:23 PM · Plasma
kossebau requested review of D10795: [grouping applet] Use "object-group" as icon.
Sat, Feb 24, 3:50 PM · Plasma
kossebau committed R114:1319b7bfe892: [grouping applet] Add missing Comment entry to metadata (authored by kossebau).
[grouping applet] Add missing Comment entry to metadata
Sat, Feb 24, 3:44 PM
kossebau closed D10793: [grouping applet] Add missing Comment entry to metadata.
Sat, Feb 24, 3:44 PM · Plasma
kossebau added a comment to D10793: [grouping applet] Add missing Comment entry to metadata.

Changing i18n in stable as a bug fix is allowed, but CC kde-i18n-doc.

Sat, Feb 24, 3:24 PM · Plasma
kossebau added a comment to D10793: [grouping applet] Add missing Comment entry to metadata.

Noticed the comment missing in the "Add widget.." picker, appstreamcli also complains about missing summary entry.

Sat, Feb 24, 2:17 PM · Plasma
kossebau requested review of D10793: [grouping applet] Add missing Comment entry to metadata.
Sat, Feb 24, 2:12 PM · Plasma

Fri, Feb 23

kossebau added a reviewer for D10757: Reset QLocale internals when we have a custom app language: ilic.
Fri, Feb 23, 9:53 PM · Frameworks
kossebau added a reviewer for D10758: Use QLocale instead of QLocale::system: ilic.
Fri, Feb 23, 9:52 PM · Frameworks
kossebau added a comment to D10759: Use QLocale instead of QLocale::system.

Might be an idea indeed to switch to default language instead of system one. Can you tell at which point the system one is estimated, and based on what?

Fri, Feb 23, 9:51 PM · Build System, Frameworks
kossebau added a reviewer for D10759: Use QLocale instead of QLocale::system: ilic.
Fri, Feb 23, 9:41 PM · Build System, Frameworks
kossebau committed R287:7aa5333a3fae: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file (authored by kossebau).
kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file
Fri, Feb 23, 6:09 PM
kossebau updated the diff for D10733: Help automoc to find metadata JSON files referenced in the code.

have each macro added only once (closer to current draft of ECM macro)

Fri, Feb 23, 6:07 PM · Frameworks
kossebau updated the diff for D10732: Help automoc to find metadata JSON files referenced in the code.

have each macro added only once (closer to current draft of ECM macro)

Fri, Feb 23, 5:57 PM · Frameworks
kossebau updated subscribers of D10659: [AppletConfiguration] Let applet override Return closing the dialog.

Can this property become something more official, with real documentation

Sure. If you tell me where the other features of the config dialog (e.g. the saveConfig() function ) is documented, I'd happily add it there.

Fri, Feb 23, 5:31 PM · Plasma
kossebau committed R244:2af64ee1e295: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file (authored by kossebau).
kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file
Fri, Feb 23, 1:17 PM
kossebau closed D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file.
Fri, Feb 23, 1:17 PM · Frameworks

Thu, Feb 22

kossebau committed R114:9382fa7d749e: [keyboardindicator] Add missing Messages.sh (authored by kossebau).
[keyboardindicator] Add missing Messages.sh
Thu, Feb 22, 10:46 PM
kossebau committed R244:7d642aec3a89: Help automoc to find metadata JSON files referenced in the code (authored by kossebau).
Help automoc to find metadata JSON files referenced in the code
Thu, Feb 22, 10:14 PM
kossebau closed D10724: Help automoc to find metadata JSON files referenced in the code.
Thu, Feb 22, 10:14 PM · Frameworks
kossebau added a comment to D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file.

@apol So +1 on this for pushing? (sorry for possibly confusing you with all the many related review requests :) )

Thu, Feb 22, 10:10 PM · Frameworks
kossebau updated the summary of D10749: [RFC] Add ECMSetupQtPluginMacroNames.
Thu, Feb 22, 5:54 PM · Build System, Frameworks
kossebau requested review of D10749: [RFC] Add ECMSetupQtPluginMacroNames.
Thu, Feb 22, 5:30 PM · Build System, Frameworks
kossebau accepted D10748: drop the setting of c++0x.

Builds here as before as well.

Thu, Feb 22, 3:16 PM · Frameworks, Plasma
kossebau committed R32:1f0f5ce63099: Merge branch '5.2' (authored by kossebau).
Merge branch '5.2'
Thu, Feb 22, 2:22 PM
kossebau committed R32:d4378dc31b95: Help automoc to find metadata JSON files referenced in the code (authored by kossebau).
Help automoc to find metadata JSON files referenced in the code
Thu, Feb 22, 1:43 PM
kossebau closed D10693: Help automoc to find metadata JSON files referenced in the code.
Thu, Feb 22, 1:43 PM
kossebau committed R114:66eb115a9300: [spellcheck runner] Make each suggestion copyable as separate item (authored by kossebau).
[spellcheck runner] Make each suggestion copyable as separate item
Thu, Feb 22, 12:09 PM
kossebau closed D10499: [spellcheck runner] Make each suggestion copyable as separate item.
Thu, Feb 22, 12:09 PM · Plasma
kossebau added a comment to D10732: Help automoc to find metadata JSON files referenced in the code.

Thanks for review.

Thu, Feb 22, 11:53 AM · Frameworks
kossebau added a comment to D10733: Help automoc to find metadata JSON files referenced in the code.

For more details see comments on D10724

Thu, Feb 22, 1:09 AM · Frameworks
kossebau requested review of D10733: Help automoc to find metadata JSON files referenced in the code.
Thu, Feb 22, 1:08 AM · Frameworks
kossebau added a comment to D10732: Help automoc to find metadata JSON files referenced in the code.

For more details see comments on D10724

Thu, Feb 22, 1:00 AM · Frameworks
kossebau requested review of D10732: Help automoc to find metadata JSON files referenced in the code.
Thu, Feb 22, 12:59 AM · Frameworks

Wed, Feb 21

kossebau added a comment to D10724: Help automoc to find metadata JSON files referenced in the code.

See related discussion on CMake issue tracker: https://gitlab.kitware.com/cmake/cmake/issues/17750

Wed, Feb 21, 6:38 PM · Frameworks
kossebau requested review of D10724: Help automoc to find metadata JSON files referenced in the code.
Wed, Feb 21, 6:31 PM · Frameworks
kossebau updated the diff for D10693: Help automoc to find metadata JSON files referenced in the code.
  • extend regexp rules to allow linebreaks
  • more details in the comment
Wed, Feb 21, 5:34 PM
kossebau committed R32:86b746ce5325: Clean up link interfaces of KDevPlatform libraries (authored by kossebau).
Clean up link interfaces of KDevPlatform libraries
Wed, Feb 21, 4:39 PM
kossebau closed D10696: Clean up link interfaces of KDevPlatform libraries.
Wed, Feb 21, 4:38 PM
kossebau added a comment to D10499: [spellcheck runner] Make each suggestion copyable as separate item.

Thanks for review.

Wed, Feb 21, 4:21 PM · Plasma
kossebau added a comment to D10693: Help automoc to find metadata JSON files referenced in the code.
In D10693#210602, @apol wrote:

I started to write some comment. but then felt I duplicate the cmake docs about CMAKE_AUTOMOC_DEPEND_FILTERS.
To your yet innocent eyes, what would you think a future reader might want to know with that code directly?

https://cmake.org/cmake/help/v3.10/variable/CMAKE_AUTOMOC_DEPEND_FILTERS.html

Why's there a regular expression? what's trying to catch?

Wed, Feb 21, 5:36 AM
kossebau added a comment to D10693: Help automoc to find metadata JSON files referenced in the code.
In D10693#210567, @apol wrote:

+1
The solution is scary. Maybe add some comment on what kind of things are needed?

Wed, Feb 21, 12:40 AM
kossebau added a comment to D10696: Clean up link interfaces of KDevPlatform libraries.
In D10696#210569, @apol wrote:

This is brilliant, I wonder why opensuse wouldn't send such patches upstream!

Wed, Feb 21, 12:36 AM

Tue, Feb 20

kossebau committed R32:1ac83660a695: Declare virtual destructor with interface classes (authored by kossebau).
Declare virtual destructor with interface classes
Tue, Feb 20, 8:36 PM
kossebau committed R32:ae057405b0c5: Use forward declaration (authored by kossebau).
Use forward declaration
Tue, Feb 20, 8:36 PM
kossebau added a comment to D10696: Clean up link interfaces of KDevPlatform libraries.

"Created helper files including all headers per library and linking against the library to test which libs need to be in the public link interface."
That had been done manually/ugly scripting. Ideally would be something that can be automatically tested by some cmake magic, no complete idea yet how to do that.

Tue, Feb 20, 7:46 PM
kossebau added a comment to D10696: Clean up link interfaces of KDevPlatform libraries.

Cmp. also downstream patch https://build.opensuse.org/package/view_file/KDE:Unstable:Extra/kdevelop5/reduce_dependencies.diff?expand=1 (which still has KF5Parts as well, even though that is transitive pulled in by KF5TextEditor)

Tue, Feb 20, 7:44 PM
kossebau requested review of D10696: Clean up link interfaces of KDevPlatform libraries.
Tue, Feb 20, 7:42 PM
kossebau updated the summary of D10693: Help automoc to find metadata JSON files referenced in the code.
Tue, Feb 20, 6:26 PM
kossebau added a comment to D10693: Help automoc to find metadata JSON files referenced in the code.

Based on reply https://gitlab.kitware.com/cmake/cmake/issues/17750#note_377396 on the given filed CMake issue.
While there are three questions added for now, by what I tested this patch seems to right thing. I just asked to get confirmation, as the documentation left me unsure

Tue, Feb 20, 6:24 PM
kossebau requested review of D10693: Help automoc to find metadata JSON files referenced in the code.
Tue, Feb 20, 6:21 PM
kossebau added a comment to D10337: First approach to a plasmoid that can display the state of caps lock.

Quick note before I forget again: doesn't this need some Messages.sh? There are some i18n calls in the QML.

Tue, Feb 20, 2:27 PM · Plasma
kossebau committed R32:531bfb8e8639: kdevplatform_add_plugin: remove effectless OBJECT_DEPENDS on json file (authored by kossebau).
kdevplatform_add_plugin: remove effectless OBJECT_DEPENDS on json file
Tue, Feb 20, 12:49 PM
kossebau closed D10666: kdevplatform_add_plugin: remove effectless OBJECT_DEPENDS on json file.
Tue, Feb 20, 12:48 PM
kossebau added a comment to D10666: kdevplatform_add_plugin: remove effectless OBJECT_DEPENDS on json file.
In D10666#209890, @apol wrote:

Port to the kcoreaddons macro?

Tue, Feb 20, 12:53 AM

Mon, Feb 19

kossebau added a comment to D10659: [AppletConfiguration] Let applet override Return closing the dialog.

Eek. Undocumented secret properties make my toe nails roll up.

Mon, Feb 19, 7:54 PM · Plasma
kossebau added a comment to D10660: [Weather applet] Let Return invoke search.

Not tested, but seems good to me by pure reading.

Mon, Feb 19, 7:50 PM · Plasma
kossebau committed R244:a9656a0e4542: kcoreaddons_desktop_to_json: note the generated file in the build log (authored by kossebau).
kcoreaddons_desktop_to_json: note the generated file in the build log
Mon, Feb 19, 7:41 PM
kossebau closed D10664: kcoreaddons_desktop_to_json: note the generated file in the build log.
Mon, Feb 19, 7:41 PM · Frameworks
kossebau added a comment to D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file.
In D10665#209765, @apol wrote:

:P could you look into an actual fix? :/

Mon, Feb 19, 7:36 PM · Frameworks
kossebau added a comment to D10666: kdevplatform_add_plugin: remove effectless OBJECT_DEPENDS on json file.

+1

I think what should actually ensure the moc file is regenerated is the AUTOGEN_TARGET_DEPENDS property, but we're setting that already (L141, now L124) and it doesn't seem to work.

Mon, Feb 19, 6:48 PM
kossebau updated the test plan for D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file.
Mon, Feb 19, 6:30 PM · Frameworks
kossebau requested review of D10666: kdevplatform_add_plugin: remove effectless OBJECT_DEPENDS on json file.
Mon, Feb 19, 6:27 PM
kossebau added a comment to D10450: Generate a custom target in kcoreaddons_desktop_to_json.

And given what I think I learned here; also created D10665 to remove the seemingly effectless rules for depending the source's object file on the JSON file.

Mon, Feb 19, 5:50 PM · Frameworks
kossebau requested review of D10665: kcoreaddons_add_plugin: remove effectless OBJECT_DEPENDS on json file.
Mon, Feb 19, 5:39 PM · Frameworks
kossebau requested review of D10664: kcoreaddons_desktop_to_json: note the generated file in the build log.
Mon, Feb 19, 4:53 PM · Frameworks
kossebau added a comment to D10450: Generate a custom target in kcoreaddons_desktop_to_json.

BTW, for the related issue of moc not being re-run on the regeneration of the JSON file, I managed to get some test case to narrow this to automoc possibly and just reported it as https://gitlab.kitware.com/cmake/cmake/issues/17750

Mon, Feb 19, 4:15 PM · Frameworks

Sun, Feb 18

kossebau committed R119:16979b97e2e1: Merge branch 'Plasma/5.12' (authored by kossebau).
Merge branch 'Plasma/5.12'
Sun, Feb 18, 10:59 PM
kossebau committed R119:f7fd71258f15: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2 (authored by kossebau).
[lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2
Sun, Feb 18, 10:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Sun, Feb 18, 10:50 PM · Plasma
kossebau added a comment to D10607: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2.

Taking the comments on D10450 about this patch as implicit +1 and going to push now, so there is 2 more days of build testing before the next release.

Sun, Feb 18, 10:48 PM · Plasma
kossebau committed R32:c888b7662611: [C++ CMake project template] Bump min cmake version to 3.0 (authored by kossebau).
[C++ CMake project template] Bump min cmake version to 3.0
Sun, Feb 18, 7:22 PM
kossebau committed R32:39f851d3e424: Template for C, with CMake (authored by Lucas A. V. Dantas <lucasdantas@yandex.com>).
Template for C, with CMake
Sun, Feb 18, 7:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Sun, Feb 18, 7:22 PM

Sat, Feb 17

kossebau added a comment to D10450: Generate a custom target in kcoreaddons_desktop_to_json.

Yes, I think I agree with @rakuco. Especially since the fix for D10485 ended up being reverted.

Sat, Feb 17, 9:27 PM · Frameworks
kossebau added inline comments to D10079: [Draft] Port baloo krunner plugin to KDBusRunner.
Sat, Feb 17, 7:13 PM · Plasma
kossebau added a comment to D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version.

Could not reproduce that error locally, and build.kde.org had also not reported any problems. But given it failed for at least two people and the neon CI (https://build.neon.kde.org/job/xenial_unstable_plasma_plasma-desktop_bin_amd64/528/consoleFull) there might be some other problem hidden somewhere.

Sat, Feb 17, 4:07 PM · Plasma
kossebau requested review of D10607: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2.
Sat, Feb 17, 3:55 PM · Plasma

Fri, Feb 16

kossebau committed R120:09f5305feb0f: Merge branch 'Plasma/5.12' (authored by kossebau).
Merge branch 'Plasma/5.12'
Fri, Feb 16, 9:55 PM
kossebau committed R120:4149b474d301: Remove uninstalled themerc files for no longer existing Qt themes (authored by kossebau).
Remove uninstalled themerc files for no longer existing Qt themes
Fri, Feb 16, 9:55 PM
kossebau closed D10596: Remove uninstalled themerc files for no longer existing Qt themes.
Fri, Feb 16, 9:55 PM · Plasma
kossebau requested review of D10596: Remove uninstalled themerc files for no longer existing Qt themes.
Fri, Feb 16, 9:43 PM · Plasma
kossebau committed R114:c2e7c6784569: Merge branch 'Plasma/5.12' (authored by kossebau).
Merge branch 'Plasma/5.12'
Fri, Feb 16, 5:25 PM
kossebau committed R114:145981b6bd48: Remove dead code & translation extraction from release branch (authored by kossebau).
Remove dead code & translation extraction from release branch
Fri, Feb 16, 5:14 PM
kossebau committed R114:cd25c7078ab2: [konsolesession runner] Rename to konsoleprofiles, no sessions here (authored by kossebau).
[konsolesession runner] Rename to konsoleprofiles, no sessions here
Fri, Feb 16, 4:58 PM
kossebau closed D10505: [konsolesession runner] Rename to konsoleprofiles, no sessions here.
Fri, Feb 16, 4:58 PM · Plasma
kossebau committed R119:b6d4d80a6425: Merge branch 'Plasma/5.12' (authored by kossebau).
Merge branch 'Plasma/5.12'
Fri, Feb 16, 12:24 AM
kossebau committed R119:6ab44dcb86b1: [Look and feel KCM] Fix copying color scheme data (authored by kossebau).
[Look and feel KCM] Fix copying color scheme data
Fri, Feb 16, 12:05 AM
kossebau closed D10259: [Look and feel KCM] Fix copying color scheme data.
Fri, Feb 16, 12:05 AM · Plasma

Thu, Feb 15

kossebau abandoned D10554: Change include namespace from KRunner/ to Plasma/, to match C++ ns.

Bummer, no straight namespace aliasing possible: "Plasma::" namespace prefixed is used in some signal/slot signatures, and Qt's string-based signal/slot gets in the way here, moc cannot know about any possible aliases, so there is no support in the string normalization.

Thu, Feb 15, 11:11 PM · Frameworks
kossebau added a comment to D10554: Change include namespace from KRunner/ to Plasma/, to match C++ ns.

I would actually prefer the class to be KRunner::AbstractRunner but that's obviously not something we could change.

Thu, Feb 15, 8:51 PM · Frameworks
kossebau added a comment to D10554: Change include namespace from KRunner/ to Plasma/, to match C++ ns.

Anpther option I considered was to promote instead KRunner:: as C++ namespace, using a namespace alias for the time until KF6.

Thu, Feb 15, 8:25 PM · Frameworks
kossebau requested review of D10554: Change include namespace from KRunner/ to Plasma/, to match C++ ns.
Thu, Feb 15, 7:58 PM · Frameworks
kossebau added a comment to D10259: [Look and feel KCM] Fix copying color scheme data.

Ping?

Thu, Feb 15, 4:21 PM · Plasma
kossebau committed R119:2fc98d5eb882: Use non-deprecated KDEInstallDirs variables (authored by kossebau).
Use non-deprecated KDEInstallDirs variables
Thu, Feb 15, 1:56 AM
kossebau committed R119:0343db5a2cc0: Do not include complete Qt modules (authored by kossebau).
Do not include complete Qt modules
Thu, Feb 15, 1:56 AM
kossebau committed R119:a13708391381: Remove module prefix from Qt includes (authored by kossebau).
Remove module prefix from Qt includes
Thu, Feb 15, 1:56 AM
kossebau committed R119:a9418f17b7a9: Port away from deprecated *::clickMessage property (authored by kossebau).
Port away from deprecated *::clickMessage property
Thu, Feb 15, 1:56 AM
kossebau committed R119:4609c34604c1: [kfontinst kcm] Link libkfontinst to Qt5::Gui for QFontDatabase enum (authored by kossebau).
[kfontinst kcm] Link libkfontinst to Qt5::Gui for QFontDatabase enum
Thu, Feb 15, 1:56 AM