kossebau (Friedrich W. H. Kossebau)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 11:52 AM (205 w, 2 d)
Availability
Available

Recent Activity

Today

kossebau committed R120:00dcb777918e: Enable blurbehind also for panel controls only if theme sets it (authored by kossebau).
Enable blurbehind also for panel controls only if theme sets it
Tue, Mar 26, 7:46 AM
kossebau closed D20057: Enable blurbehind also for panel controls only if theme sets it.
Tue, Mar 26, 7:46 AM · Plasma
kossebau requested review of D20057: Enable blurbehind also for panel controls only if theme sets it.
Tue, Mar 26, 6:47 AM · Plasma

Yesterday

kossebau requested review of D20051: Do not try to set shadows for panels if theme does not provide elements.
Mon, Mar 25, 9:51 PM · Plasma

Fri, Mar 22

kossebau added a comment to D19551: [knotifications] compile without foreach.

This sadly breaks build with at least older versions of Phonon, as they have foreach loop in their public headers.

Fri, Mar 22, 1:13 PM · Frameworks
kossebau committed R120:8ef6104a2d02: Enable blurbehind for panels only if theme sets it (authored by kossebau).
Enable blurbehind for panels only if theme sets it
Fri, Mar 22, 11:25 AM
kossebau closed D19909: Enable blurbehind for panels only if theme sets it.
Fri, Mar 22, 11:25 AM · Plasma
kossebau committed R119:34387d450ab2: [Desktop Theme KCM] "Normalize" margin around background in previews (authored by kossebau).
[Desktop Theme KCM] "Normalize" margin around background in previews
Fri, Mar 22, 10:39 AM
kossebau closed D19748: [Desktop Theme KCM] "Normalize" margin around background in previews.
Fri, Mar 22, 10:39 AM · Plasma
kossebau committed R242:5f4f88ad66f9: FrameSvgItem: catch margin changes of FrameSvg also outside own methods (authored by kossebau).
FrameSvgItem: catch margin changes of FrameSvg also outside own methods
Fri, Mar 22, 10:37 AM
kossebau closed D19743: FrameSvgItem: catch margin changes of FrameSvg also outside own methods.
Fri, Mar 22, 10:37 AM · Frameworks

Thu, Mar 21

kossebau committed R242:fb1a332948e3: Add Theme::blurBehindEnabled() (authored by kossebau).
Add Theme::blurBehindEnabled()
Thu, Mar 21, 6:37 PM
kossebau closed D19907: Add Theme::blurBehindEnabled().
Thu, Mar 21, 6:36 PM · Frameworks
kossebau added a comment to D19939: Avoid failing installation via temporary dir due to file name clashes.

So the solution would be to cache the calculated result. Which would also allow to have this as flag for some proper post-install cleanup once that is sorted out and defined.

Thu, Mar 21, 1:00 PM · Frameworks
kossebau planned changes to D19939: Avoid failing installation via temporary dir due to file name clashes.

Found a flaw: this will result in a different path on every call of the method for the same object, which can happen. Needs more thought.

Thu, Mar 21, 12:26 PM · Frameworks
kossebau added a reviewer for D19939: Avoid failing installation via temporary dir due to file name clashes: apol.
Thu, Mar 21, 11:51 AM · Frameworks
kossebau requested review of D19939: Avoid failing installation via temporary dir due to file name clashes.
Thu, Mar 21, 11:45 AM · Frameworks

Wed, Mar 20

kossebau added a comment to D19748: [Desktop Theme KCM] "Normalize" margin around background in previews.


Seems it does break things here (both with and without Qt scaling :/)

Wed, Mar 20, 6:07 PM · Plasma
kossebau updated the diff for D19907: Add Theme::blurBehindEnabled().

Remove sneaked-in code clean-up for repeated fetching of mask

Wed, Mar 20, 3:34 PM · Frameworks
kossebau updated the diff for D19907: Add Theme::blurBehindEnabled().

add missed-out application of the flag in PlasmaQuick::Dialog

Wed, Mar 20, 3:28 PM · Frameworks
kossebau added a comment to D19909: Enable blurbehind for panels only if theme sets it.
In D19909#435065, @zzag wrote:

What about plasma::dialog?

Wed, Mar 20, 12:14 PM · Plasma
kossebau added inline comments to D19907: Add Theme::blurBehindEnabled().
Wed, Mar 20, 12:06 PM · Frameworks
kossebau added a comment to D19909: Enable blurbehind for panels only if theme sets it.
In D19909#435065, @zzag wrote:

What about plasma::dialog?

Wed, Mar 20, 12:04 PM · Plasma
kossebau added a comment to D19909: Enable blurbehind for panels only if theme sets it.

Depends on D19907

Wed, Mar 20, 10:14 AM · Plasma
kossebau requested review of D19909: Enable blurbehind for panels only if theme sets it.
Wed, Mar 20, 10:13 AM · Plasma
kossebau requested review of D19907: Add Theme::blurBehindEnabled().
Wed, Mar 20, 10:12 AM · Frameworks

Tue, Mar 19

kossebau committed R242:0ffe183d71fd: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0 (authored by kossebau).
FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0
Tue, Mar 19, 11:55 PM
kossebau closed D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0.
Tue, Mar 19, 11:55 PM · Frameworks
kossebau added a comment to D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0.

So far I have not yet seen another tiled-border theme on store.kde.org, so restoring the Plasma4 behaviour should be fine.

Tue, Mar 19, 8:27 PM · Frameworks
kossebau added a comment to D19748: [Desktop Theme KCM] "Normalize" margin around background in previews.


Seems it does break things here (both with and without Qt scaling :/)

Tue, Mar 19, 11:12 AM · Plasma

Sat, Mar 16

kossebau added a comment to D19748: [Desktop Theme KCM] "Normalize" margin around background in previews.

Seems it does break things here (both with and without Qt scaling :/)

Sat, Mar 16, 11:19 AM · Plasma
kossebau updated the diff for D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0.

Update patch to restore initial logic without stretching, which also resembles Plasma4 one

Sat, Mar 16, 7:55 AM · Frameworks
kossebau added a comment to D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0.

After a first coffee, I realize this very logic actually already does upsampling all the time, given it takes the floor of the nodesize/samplesize expression, not the ceiling. And with eyes made sensitive, I see this now all the time.

Sat, Mar 16, 7:46 AM · Frameworks
kossebau updated the diff for D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0.

add documentation about wanted behaviour, so the next person does not change
it again

Sat, Mar 16, 6:24 AM · Frameworks
kossebau updated the diff for D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0.

Only prevent width/height of textureRect becoming 0, otherwise keep old
behaviour. Not changing to qround to prevent bad image quality due to
up-sampling.

Sat, Mar 16, 6:18 AM · Frameworks

Fri, Mar 15

kossebau added a comment to D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0.
In D19787#431712, @apol wrote:

Does this solve the fluffy bunny issue?

Fri, Mar 15, 7:17 PM · Frameworks
kossebau added a comment to D19748: [Desktop Theme KCM] "Normalize" margin around background in previews.

Personally I would consider this a bug fix and apply to 5.12. I always thought the openSUSE themes are broken just by their preview being so messy. It's a simple fix with no side-effects by what I can tell.
What do you think?

Fri, Mar 15, 6:09 PM · Plasma
kossebau added a comment to D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0.

An alternative approach might be to do instead

//if tiling horizontally
if (m_border == FrameSvg::TopBorder || m_border == FrameSvg::BottomBorder || m_border == FrameSvg::NoBorder) {
    textureRect.setWidth(qMax(1, nodeRect.width() / m_elementNativeSize.width()));
}
//if tiling vertically
if (m_border == FrameSvg::LeftBorder || m_border == FrameSvg::RightBorder || m_border == FrameSvg::NoBorder) {
    textureRect.setHeight(qMax(1, nodeRect.height() / m_elementNativeSize.height()));
}

i.e. to use 1 as minimum, and continue to use full multiples. That might help potential themes where the subparts should properly align on the subpart borders (think something like sine wave), at the cost of having things being shrunk to fit.

Fri, Mar 15, 3:29 PM · Frameworks
kossebau updated subscribers of D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0.

I have to admit I am not exactly sure what this code does (being a noob to openGL), so my assumptions about the effects I saw by try & error might be wrong. Thus please check properly someone who understands this code.

Fri, Mar 15, 2:41 PM · Frameworks
kossebau requested review of D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0.
Fri, Mar 15, 2:37 PM · Frameworks
kossebau updated the diff for D19748: [Desktop Theme KCM] "Normalize" margin around background in previews.

Clip the background to not overrun the item border and thus also the
selection/highlight markup

Fri, Mar 15, 6:44 AM · Plasma
kossebau committed R237:a3ed87ca7808: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension (authored by kossebau).
kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension
Fri, Mar 15, 5:58 AM
kossebau closed D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension.
Fri, Mar 15, 5:58 AM · Frameworks

Thu, Mar 14

kossebau added a comment to D19748: [Desktop Theme KCM] "Normalize" margin around background in previews.

Seems the broken openSUSEdark display was due to cached rendered pixmaps, at least I can no longer reproduce it. So for completeness, and do celebrate the initial recovery of good old Fluffy Bunny theme, here another After (beware, can harm sensitive eyes):

Thu, Mar 14, 1:21 PM · Plasma
kossebau updated the diff for D19748: [Desktop Theme KCM] "Normalize" margin around background in previews.

On a second look, of course the normalized margins should be also used for
the content shown in the widget

Thu, Mar 14, 5:58 AM · Plasma
kossebau added a comment to D19748: [Desktop Theme KCM] "Normalize" margin around background in previews.

The hack for "Air" was especially annoying as it fails for themes inheriting "Air" and reusing the widget background, like "Air openSUSE"
Before:


After:

Looks in average better IMHO, and makes things more comparaible, unless one is out to know the transparent margin size perhaps.
Something still strange with "openSUSE dark", but that might be an issue with the theme itself.

Thu, Mar 14, 5:49 AM · Plasma
kossebau requested review of D19748: [Desktop Theme KCM] "Normalize" margin around background in previews.
Thu, Mar 14, 5:45 AM · Plasma

Wed, Mar 13

kossebau requested review of D19743: FrameSvgItem: catch margin changes of FrameSvg also outside own methods.
Wed, Mar 13, 11:30 PM · Frameworks

Tue, Mar 12

kossebau added a comment to D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension.

@apol Thanks for review.

Tue, Mar 12, 6:00 PM · Frameworks

Mon, Mar 11

kossebau committed R457:5fb72614c895: Merge branch '0.26' (authored by kossebau).
Merge branch '0.26'
Mon, Mar 11, 3:15 PM
kossebau requested changes to D17760: astyle: support the system astyle library.
Mon, Mar 11, 2:50 PM · KDevelop
kossebau committed R457:4ba81a916463: Use KF over KF5 as include section label (authored by kossebau).
Use KF over KF5 as include section label
Mon, Mar 11, 3:41 AM
kossebau committed R454:eb6c1f9e78ab: Deploy ui.rc files via qrc files (authored by kossebau).
Deploy ui.rc files via qrc files
Mon, Mar 11, 1:42 AM
kossebau committed R457:93ecf7bba309: Bump version to 0.26.0 (authored by kossebau).
Bump version to 0.26.0
Mon, Mar 11, 1:09 AM
kossebau committed R457:a42598254fb3: Add README.packagers (authored by kossebau).
Add README.packagers
Mon, Mar 11, 1:09 AM

Sun, Mar 10

kossebau added a comment to T10597: Branding for Minishell.

"Pocket Plasma" - if only for the alliteration ;)

Sun, Mar 10, 11:56 PM · KDE Promo, VDG
kossebau committed R983:d60a888b8319: Improve app metadata (authored by kossebau).
Improve app metadata
Sun, Mar 10, 8:22 PM
kossebau closed D19658: Improve app metadata.
Sun, Mar 10, 8:22 PM
kossebau committed R983:168cf236cab0: Fix warning about hidden apply(const T&) method for subclasses of Option (authored by kossebau).
Fix warning about hidden apply(const T&) method for subclasses of Option
Sun, Mar 10, 8:21 PM
kossebau closed D19657: Fix warning about hidden apply(const T&) method for subclasses of Option.
Sun, Mar 10, 8:21 PM
kossebau added inline comments to D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering.
Sun, Mar 10, 8:10 PM · Frameworks, Dolphin
kossebau committed R983:24fb1979cfb0: KAboutData::setApplicationData() already set name, displayname, version & Co (authored by kossebau).
KAboutData::setApplicationData() already set name, displayname, version & Co
Sun, Mar 10, 6:54 PM
kossebau requested review of D19658: Improve app metadata.
Sun, Mar 10, 5:26 PM
kossebau committed R983:7952297c85aa: Set TRANSLATION_DOMAIN for kdiff3part sources (authored by kossebau).
Set TRANSLATION_DOMAIN for kdiff3part sources
Sun, Mar 10, 4:45 PM
kossebau committed R983:25dc0755c3dc: KAboutData::setupCommandLine() already adds version & help options (authored by kossebau).
KAboutData::setupCommandLine() already adds version & help options
Sun, Mar 10, 4:45 PM
kossebau committed R983:2f4a06d42c71: Use <gui> instead of deprecated <kpartgui> (authored by kossebau).
Use <gui> instead of deprecated <kpartgui>
Sun, Mar 10, 4:45 PM
kossebau committed R983:6b814473aba8: Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
Sun, Mar 10, 4:45 PM
kossebau added a comment to D19657: Fix warning about hidden apply(const T&) method for subclasses of Option.

Adding to public API in this patch as the method is also in the public API of the as public inherited Option<T> base class, so following the current design.

Sun, Mar 10, 4:05 PM
kossebau requested review of D19657: Fix warning about hidden apply(const T&) method for subclasses of Option.
Sun, Mar 10, 4:02 PM

Sat, Mar 9

kossebau committed R49:0c1a1d7bbfda: Ensure more modern Qt (authored by kossebau).
Ensure more modern Qt
Sat, Mar 9, 4:46 PM
kossebau committed R49:21945cde0368: Remove unused libs from kcachegrind's link list (authored by kossebau).
Remove unused libs from kcachegrind's link list
Sat, Mar 9, 4:46 PM
kossebau committed R49:f9ee3ef1cc81: Use CamelCase includes for KF headers (authored by kossebau).
Use CamelCase includes for KF headers
Sat, Mar 9, 4:46 PM
kossebau committed R49:0383e084e6fc: List icon files explicitly instead of using a GLOB (authored by kossebau).
List icon files explicitly instead of using a GLOB
Sat, Mar 9, 4:46 PM
kossebau committed R49:213b36abacea: Deploy ui.rc file via qrc (authored by kossebau).
Deploy ui.rc file via qrc
Sat, Mar 9, 4:46 PM
kossebau committed R49:4a291fbe8055: Use Q_SIGNALS/Q_SLOTS (authored by kossebau).
Use Q_SIGNALS/Q_SLOTS
Sat, Mar 9, 4:46 PM
kossebau committed R49:94aa7c1cb8e1: Remove explicit set of CMAKE_INCLUDE_CURRENT_DIR, done by KDECMakeSettings (authored by kossebau).
Remove explicit set of CMAKE_INCLUDE_CURRENT_DIR, done by KDECMakeSettings
Sat, Mar 9, 4:46 PM
kossebau committed R49:1f20dbbc6a26: Remove unneeded cmake macro includes (authored by kossebau).
Remove unneeded cmake macro includes
Sat, Mar 9, 4:46 PM
kossebau committed R49:4b0a4a0fb68c: Fix conflicting names of widgets in UI file (authored by kossebau).
Fix conflicting names of widgets in UI file
Sat, Mar 9, 4:46 PM

Fri, Mar 8

kossebau committed R428:044ebd5de6df: Appdata file: remove unneeded <provides/> translations (authored by kossebau).
Appdata file: remove unneeded <provides/> translations
Fri, Mar 8, 2:41 PM

Thu, Mar 7

kossebau committed R428:84673126353d: Improve appdata: proper casing of name, better homepage, set launchable (authored by kossebau).
Improve appdata: proper casing of name, better homepage, set launchable
Thu, Mar 7, 6:53 PM
kossebau committed R499:cf0468de08c4: breeze-gtk no longer in kdereview, covered by kde/workspace/* (authored by kossebau).
breeze-gtk no longer in kdereview, covered by kde/workspace/*
Thu, Mar 7, 4:38 PM
kossebau committed R499:7edda94cc77d: Remove outdated duplicate entry for labplot, no longer in kdereview (authored by kossebau).
Remove outdated duplicate entry for labplot, no longer in kdereview
Thu, Mar 7, 4:38 PM
kossebau committed R499:722565325c7f: kdots got moved to unmaintained (authored by kossebau).
kdots got moved to unmaintained
Thu, Mar 7, 4:38 PM
kossebau committed R499:b7a1c5e02c59: libqaccessibilityclient got moved to extragear/libs (authored by kossebau).
libqaccessibilityclient got moved to extragear/libs
Thu, Mar 7, 4:38 PM
kossebau committed R428:b6a234e1837f: Require libqaccessibilityclient 0.4 (authored by kossebau).
Require libqaccessibilityclient 0.4
Thu, Mar 7, 4:18 PM
kossebau committed R578:bb15ae533014: Set include dir for exported library target (authored by kossebau).
Set include dir for exported library target
Thu, Mar 7, 4:49 AM
kossebau committed R578:cffe054da2da: Create proper CMake Config file which also checks for deps (authored by kossebau).
Create proper CMake Config file which also checks for deps
Thu, Mar 7, 4:49 AM
kossebau committed R578:15c901c10716: Create and install also a QAccessibilityClientConfigVersion.cmake file (authored by kossebau).
Create and install also a QAccessibilityClientConfigVersion.cmake file
Thu, Mar 7, 4:49 AM
kossebau committed R578:d01385005c5d: Use imported targets for Qt libs, support BUILD_TESTING option (authored by kossebau).
Use imported targets for Qt libs, support BUILD_TESTING option
Thu, Mar 7, 4:08 AM
kossebau committed R578:1de33a6631cd: Remove usage of dead QT_USE_FAST_CONCATENATION (authored by kossebau).
Remove usage of dead QT_USE_FAST_CONCATENATION
Thu, Mar 7, 3:28 AM
kossebau committed R578:0134e71e859f: Use newer signature of cmake's add_test() (authored by kossebau).
Use newer signature of cmake's add_test()
Thu, Mar 7, 3:28 AM
kossebau committed R578:667073d133af: Remove duplicated cmake_minimum_required (authored by kossebau).
Remove duplicated cmake_minimum_required
Thu, Mar 7, 3:28 AM
kossebau committed R578:9800f3323cdd: Use override (authored by kossebau).
Use override
Thu, Mar 7, 3:28 AM
kossebau committed R578:31fd39c58547: Use nullptr (authored by kossebau).
Use nullptr
Thu, Mar 7, 3:28 AM
kossebau committed R428:9832c2543350: Remove 0.1 CONFIG from find_package(QAccessibilityClient) again (authored by kossebau).
Remove 0.1 CONFIG from find_package(QAccessibilityClient) again
Thu, Mar 7, 3:12 AM
kossebau committed R428:c97051bb680e: Enforce more modern Qt (authored by kossebau).
Enforce more modern Qt
Thu, Mar 7, 3:12 AM
kossebau committed R428:f365932cab80: Port away from foreach (authored by kossebau).
Port away from foreach
Thu, Mar 7, 3:12 AM
kossebau committed R428:f4dea91d2b09: Deploy kmagui.rc via qrc file (authored by kossebau).
Deploy kmagui.rc via qrc file
Thu, Mar 7, 3:12 AM
kossebau committed R428:e8314f84ae7e: Use <gui> instead of deprecated <kpartgui> (authored by kossebau).
Use <gui> instead of deprecated <kpartgui>
Thu, Mar 7, 3:12 AM
kossebau committed R428:a92c9c5691e8: Bump min cmake version to 3.0 (authored by kossebau).
Bump min cmake version to 3.0
Thu, Mar 7, 3:12 AM