- User Since
- Apr 18 2015, 11:52 AM (101 w, 1 h)
Thu, Mar 23
@scarlettclark The linked issues are from build.kde.org. Unless I missed something Kevin's CI is only on his private server, at kfunk.ddns.net and the port 8080, no?
Wed, Mar 22
@jriddell : no use to have me as reviewer: I did not do the respective change of kdevplatform API, so cannot really tell if this is the correct usage here. Also have I never run plasmate, so cannot test this patch quickly.
Mon, Mar 20
Sat, Mar 18
Fri, Mar 17
Thu, Mar 16
What about the Qt Rich Text stuff?
I agree that in a perfect world that should be enough. After all Qt Assistant has a QTextBrowser-only build variant already since ages.
Wed, Mar 15
Mon, Mar 13
Wed, Mar 8
Still no matching unit tests added for now. There are two things that could see tests:
- the exposed UnknownDeclarationProblem::findMatchingIncludeFiles(...) method
- the included_files variable properly filled with data
Both things will need me to invest some more time, as I yet have to grasp things around DUChain enough to write a proper test for the exposed method.
And classhelper code is without any testing approach so far, from what I found (also nothing seen in oldcpp), so that needs some more thinking how to do this properly.
only export UnknownDeclarationProblem::findMatchingIncludeFiles,
keep custom logic for not-existing files specific to classhelper
Tue, Mar 7
Would be an improvement, thanks for the work, @antonanikin. Patch not tested myself though, assuming you have done well enough :)
@mwolff @ahartmetz Can you tell how much this patch might complicate any potential further patch imports from KDChart? That would be the only blocker here.
Mon, Mar 6
Fri, Mar 3
Tue, Feb 28
Seems that worked out as intended, KDevelop autotests now fail normally :) (i.e. similar to how they fail locally) and the ball to fix the remaining is back in our court. Thanks, @bcooksley.