- User Since
- Apr 18 2015, 11:52 AM (105 w, 17 h)
Fri, Apr 21
Ping. Is there anything wrong that would need to be improved in the current patch, or can this go in as is?
Thu, Apr 20
Wed, Apr 19
Tue, Apr 18
Np. Thanks for review.
Sat, Apr 15
Fri, Apr 14
Actually, I simplified/ignored how i18n calls internally make the gettext call chose a locale name for which a catalog has been found, by temporarily setting the LANGUAGE variable.
What do you think, should this implementation detail be noted here as well, or would it only result in confused readers, who might already being challenged a lot by the complexity how to use the ki18n API?
See thread around https://phabricator.kde.org/D5439#102005 for related discussion.
- update example to not do i18n calls before qapplication instance
- improve KF6 TODO comments
Thu, Apr 13
Wed, Apr 12
Having slept over this one night, I still think that this change should be not the way to go to fix the seen issues.
Tue, Apr 11
Mon, Apr 10
Eek, I just learned that changing the doctype name to "kpartgui" breaks the XML standard, which requires this:
"The Name in the document type declaration MUST match the element type of the root element." (cmp. https://www.w3.org/TR/xml11/#dt-doctype)
Ping? If no-one has further comments or objects, will push around April 17th.
Sun, Apr 9
Will this not miss out the needed final \0 char, as it is will be added by the compiler for strings noted in ""?
Good job, thanks, that sounds/looks plausible.
Seems unneeded now and not much telling at least to me, but not familiar with context, so it might be on purpose?