kossebau (Friedrich W. H. Kossebau)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 11:52 AM (214 w, 1 d)
Availability
Available

Recent Activity

Yesterday

kossebau committed R457:6cb9e3759550: dialogs: port from exec() to open() to handle exit-while-open better (authored by kossebau).
dialogs: port from exec() to open() to handle exit-while-open better
Sun, May 26, 9:24 PM

Fri, May 24

kossebau added inline comments to D21313: Create specific directory for kdebugsettings categories file.
Fri, May 24, 2:44 PM · Build System, Frameworks
kossebau committed R296:d644659eed56: Fix qmldir files (authored by kossebau).
Fix qmldir files
Fri, May 24, 2:06 PM
kossebau closed D21355: Fix qmldir files.
Fri, May 24, 2:06 PM · Frameworks
kossebau updated the diff for D21344: Port to ECMAddQmlModule.

udate to latest master

Fri, May 24, 1:29 PM · Frameworks
kossebau updated the diff for D21356: Port to ECMAddQmlModule, add plugins.qmltypes files.

update to latest master

Fri, May 24, 1:29 PM · Frameworks
kossebau committed R242:e99f653113ec: plasmacore: fix qmldir, ToolTip.qml no longer part of module (authored by kossebau).
plasmacore: fix qmldir, ToolTip.qml no longer part of module
Fri, May 24, 1:11 PM
kossebau closed D21350: plasmacore: fix qmldir, ToolTip.qml no longer part of module.
Fri, May 24, 1:11 PM · Frameworks
kossebau added inline comments to D21328: Add qml import for KItemModels.
Fri, May 24, 12:28 PM · Frameworks

Thu, May 23

kossebau requested review of D21356: Port to ECMAddQmlModule, add plugins.qmltypes files.
Thu, May 23, 1:07 AM · Frameworks
kossebau requested review of D21355: Fix qmldir files.
Thu, May 23, 12:58 AM · Frameworks

Wed, May 22

kossebau committed R242:b0850b1f6fc7: Use simply configure_file to generate the plasmacomponents3 files (authored by kossebau).
Use simply configure_file to generate the plasmacomponents3 files
Wed, May 22, 10:18 PM
kossebau closed D21349: Use simply configure_file to generate the plasmacomponents3 files.
Wed, May 22, 10:18 PM · Frameworks
kossebau added a comment to D21349: Use simply configure_file to generate the plasmacomponents3 files.
In D21349#468698, @apol wrote:

Won't it need installing then?

Wed, May 22, 6:35 PM · Frameworks
kossebau requested review of D21350: plasmacore: fix qmldir, ToolTip.qml no longer part of module.
Wed, May 22, 6:19 PM · Frameworks
kossebau requested review of D21349: Use simply configure_file to generate the plasmacomponents3 files.
Wed, May 22, 6:12 PM · Frameworks
kossebau added a comment to D21344: Port to ECMAddQmlModule.

The diff between the generated qmldir files and the manually written ones looks good. And also showed the one of plasmacore has some left-over.

Wed, May 22, 6:10 PM · Frameworks
kossebau updated the summary of D20984: Add ECMAddQmlModule.
Wed, May 22, 6:05 PM · Build System, Frameworks
kossebau updated the diff for D21344: Port to ECMAddQmlModule.

also remove include of ECMGenerateQmlTypes, newer macros cover that as well

Wed, May 22, 5:57 PM · Frameworks
kossebau requested review of D21344: Port to ECMAddQmlModule.
Wed, May 22, 5:55 PM · Frameworks
kossebau updated the diff for D20984: Add ECMAddQmlModule.

Renamed to ECMAddQmlModule, with more helper macros for non-C++ parts

Wed, May 22, 5:51 PM · Build System, Frameworks

Mon, May 20

kossebau committed R216:e3a7922ae842: examples: move codeeditor also in own subdir (authored by kossebau).
examples: move codeeditor also in own subdir
Mon, May 20, 11:54 AM
kossebau closed D21299: examples: move codeeditor also in own subdir.
Mon, May 20, 11:54 AM · Frameworks, Kate
kossebau requested review of D21299: examples: move codeeditor also in own subdir.
Mon, May 20, 7:14 AM · Frameworks, Kate
kossebau committed R216:47e8ac891f91: Add example app for printing highlighted text to pdf (authored by kossebau).
Add example app for printing highlighted text to pdf
Mon, May 20, 7:11 AM
kossebau closed D21298: Add example app for printing highlighted text to pdf.
Mon, May 20, 7:11 AM · Frameworks, Kate
kossebau added a comment to D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting.

I can confirm that this fixes the thumbnail bug for me: when I change the color theme, get rid of current thumbnail process (killall thumbnail.so) and trigger a reload of text thumbnails in Dolphin, I now always get consistently same colors with enough contrast used.

Mon, May 20, 4:02 AM · Frameworks, Kate
kossebau requested review of D21298: Add example app for printing highlighted text to pdf.
Mon, May 20, 3:44 AM · Frameworks, Kate

Fri, May 17

kossebau added a comment to D21233: Fix use in cross compilation.

Yes, still works well.

Fri, May 17, 6:32 PM
kossebau closed D21098: Handle apps which set the desktopFileName property with filename suffix.
Fri, May 17, 5:07 PM · Frameworks
kossebau committed R289:eef093cd6adc: Handle apps which set the desktopFileName property with filename suffix (authored by kossebau).
Handle apps which set the desktopFileName property with filename suffix
Fri, May 17, 5:07 PM
kossebau committed R242:3b950f38ccd5: Update *.qmltypes to current API of QML modules (authored by kossebau).
Update *.qmltypes to current API of QML modules
Fri, May 17, 4:43 PM
kossebau closed D21001: Update *.qmltypes to current API of QML modules.
Fri, May 17, 4:43 PM · Frameworks
kossebau abandoned D20898: WIP: [kcms/desktoptheme] Switch knsrc to "Plasma 5 Theme" category.

There is no agreement that splitting off a separate category is the way to move forward, so discarding.

Fri, May 17, 4:00 PM · Plasma

Thu, May 16

kossebau added a comment to D21233: Fix use in cross compilation.

@pwojcik Thanks for your patch. BTW, I did two follow-up commits to clean up more of the cmake code. Please test and tell is this still works for your setup as well.

Thu, May 16, 2:58 PM
kossebau committed R578:7ec165c19887: Use only undeprecated KDEInstallDirs variables (authored by kossebau).
Use only undeprecated KDEInstallDirs variables
Thu, May 16, 2:42 PM
kossebau committed R578:4981a259c964: KDECMakeSettings already cares for CMAKE_AUTOMOC & BUILD_TESTING (authored by kossebau).
KDECMakeSettings already cares for CMAKE_AUTOMOC & BUILD_TESTING
Thu, May 16, 2:42 PM
kossebau committed R578:325d504faa25: Fix use in cross compilation (authored by pwojcik).
Fix use in cross compilation
Thu, May 16, 12:38 PM
kossebau closed D21233: Fix use in cross compilation.
Thu, May 16, 12:38 PM
kossebau closed T10893: Create & use separate "Plasma 5 Theme" category on store.kde.org as Invalid.

There is no agreement that splitting off a separate category is the way to move forward.

Thu, May 16, 12:31 PM · Plasma
kossebau added a comment to T8126: Figure out what to about all the content that doesn't work.

With a few more days of partially more thinking about all this, by what was said and tried I fear I do not see us agreeing on a solution soonish, and given I have already spent more of my free time on this than I planned, I have to drop out now of this discussion, to return to the other items on my personal todo list.

Thu, May 16, 12:28 PM · KDE Store
kossebau added a comment to D21233: Fix use in cross compilation.

Updated. How do I ship? I am new to contributing kde and thought this is already a merge request.

Thu, May 16, 11:48 AM

Wed, May 15

kossebau accepted D21233: Fix use in cross compilation.

Untested by me, but the changes all look sane to me (modulo the nitpicks I added). Feel free to fix and ship directly :)

Wed, May 15, 6:55 PM
kossebau added a comment to D21001: Update *.qmltypes to current API of QML modules.

Anyone else who could give this a check?
Have to tell that I am not sure where I could really test the changes, for now I just looked at the data of the files only. And also wonder if anyone really relies on these, given they were 2 years old and missed some changes in the API.

Wed, May 15, 3:55 PM · Frameworks
kossebau committed R135:0e50f23c4c43: Handle apps which set the desktopFileName property with filename suffix (authored by kossebau).
Handle apps which set the desktopFileName property with filename suffix
Wed, May 15, 3:49 PM
kossebau closed D21097: Handle apps which set the desktopFileName property with filename suffix.
Wed, May 15, 3:49 PM · Plasma
kossebau added a comment to D21226: search for a default wallpaper in lookandfeel.

BTW, there is also still code in place to support Plasma Themes defining a default wallpaper (or even deploy some more). Though the default & the further are not listed in the Image wallpaper config, also is the config not offering any hint about the default or to reset to using any default.

Wed, May 15, 3:47 PM · Plasma
kossebau committed R1044:4f3785cf1138: Include KDE CMake macros first, as they may influence others (authored by kossebau).
Include KDE CMake macros first, as they may influence others
Wed, May 15, 1:45 PM
kossebau committed R1044:9b980bfc3c64: Require Qt5Test only with BUILD_TESTING set (authored by kossebau).
Require Qt5Test only with BUILD_TESTING set
Wed, May 15, 1:45 PM
kossebau committed R1044:a9744b0895b3: CMAKE_AUTOMOC & BUILD_TESTING are done already by KDECMakeSettings (authored by kossebau).
CMAKE_AUTOMOC & BUILD_TESTING are done already by KDECMakeSettings
Wed, May 15, 1:45 PM
kossebau committed R1044:0a674a229af4: Do cmake_minimum_required as first thing, as recommended by cmake (authored by kossebau).
Do cmake_minimum_required as first thing, as recommended by cmake
Wed, May 15, 1:45 PM
kossebau added a comment to D14147: Port from GConf to GSettings.
Wed, May 15, 3:30 AM · Plasma
kossebau committed R115:fba8f7327aaf: Fix build where GObject & deps libraries are not in default library path (authored by kossebau).
Fix build where GObject & deps libraries are not in default library path
Wed, May 15, 3:27 AM

Tue, May 14

kossebau committed R994:cbe8249b8f31: mapstest: add missing include_directories for pulseaudio & glib2 (authored by kossebau).
mapstest: add missing include_directories for pulseaudio & glib2
Tue, May 14, 11:14 PM
kossebau added inline comments to D14147: Port from GConf to GSettings.
Tue, May 14, 6:53 PM · Plasma
kossebau committed R120:f8d5e1a24e97: PanelView: update mask on window on change of panelMask property (authored by kossebau).
PanelView: update mask on window on change of panelMask property
Tue, May 14, 3:44 PM
kossebau closed D21176: PanelView: update mask on window on change of panelMask property.
Tue, May 14, 3:44 PM · Plasma
kossebau committed R242:f008615e3710: FrameSvg: also clear mask cache on clearCache() (authored by kossebau).
FrameSvg: also clear mask cache on clearCache()
Tue, May 14, 3:13 PM
kossebau closed D21172: FrameSvg: also clear mask cache on clearCache().
Tue, May 14, 3:13 PM · Frameworks
kossebau committed R242:8899389c9f67: FrameSvg: make hasElementPrefix() also handle prefix with trailing - (authored by kossebau).
FrameSvg: make hasElementPrefix() also handle prefix with trailing -
Tue, May 14, 3:12 PM
kossebau closed D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -.
Tue, May 14, 3:12 PM · Frameworks
kossebau closed D21175: FrameSvgPrivate::generateBackground: generate background also if reqp != p.
Tue, May 14, 3:12 PM · Frameworks
kossebau committed R242:6af447a84867: FrameSvgPrivate::generateBackground: generate background also if reqp != p (authored by kossebau).
FrameSvgPrivate::generateBackground: generate background also if reqp != p
Tue, May 14, 3:12 PM
kossebau committed R242:1bc1994dfe6b: FrameSvgItem: emit maskChanged also from geometryChanged() (authored by kossebau).
FrameSvgItem: emit maskChanged also from geometryChanged()
Tue, May 14, 1:15 PM
kossebau closed D21201: FrameSvgItem: emit maskChanged also from geometryChanged().
Tue, May 14, 1:15 PM · Frameworks
kossebau committed R242:193775def6a0: FrameSvg: prevent crash when calling mask() with no frame yet created (authored by kossebau).
FrameSvg: prevent crash when calling mask() with no frame yet created
Tue, May 14, 1:15 PM
kossebau closed D21200: FrameSvg: prevent crash when calling mask() with no frame yet created.
Tue, May 14, 1:15 PM · Frameworks
kossebau accepted D21213: Introduce pulseaudio-qt branches.

LGTM

Tue, May 14, 1:01 PM
kossebau created T10928: Add log output if skipping a product in dependency build due to no build metadata.
Tue, May 14, 12:59 PM · build.kde.org
kossebau updated the task description for T10926: Add pulseaudio-qt to https://build.kde.org/job/Extragear/.
Tue, May 14, 12:56 PM · build.kde.org
kossebau created T10927: Blacklist pulseaudio-qt as dependency on Windows.
Tue, May 14, 12:53 PM · build.kde.org
kossebau created T10926: Add pulseaudio-qt to https://build.kde.org/job/Extragear/.
Tue, May 14, 12:51 PM · build.kde.org
kossebau added inline comments to D21213: Introduce pulseaudio-qt branches.
Tue, May 14, 12:46 PM

Mon, May 13

kossebau updated the diff for D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -.

Be verbose about behavioural adaption in API dox

Mon, May 13, 10:42 PM · Frameworks
kossebau requested review of D21201: FrameSvgItem: emit maskChanged also from geometryChanged().
Mon, May 13, 10:11 PM · Frameworks
kossebau requested review of D21200: FrameSvg: prevent crash when calling mask() with no frame yet created.
Mon, May 13, 9:56 PM · Frameworks
kossebau closed D21179: FrameSvgItem: emit maskChanged always from doUpdate().
Mon, May 13, 9:52 PM · Frameworks
kossebau committed R242:084ba0f886d1: FrameSvgItem: emit maskChanged always from doUpdate() (authored by kossebau).
FrameSvgItem: emit maskChanged always from doUpdate()
Mon, May 13, 9:52 PM
kossebau committed R242:9142155b5a5b: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-' (authored by kossebau).
API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'
Mon, May 13, 9:49 PM
kossebau closed D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'.
Mon, May 13, 9:49 PM · Frameworks
kossebau updated the diff for D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'.

appended -> at the end

Mon, May 13, 2:52 PM · Frameworks
kossebau added inline comments to D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -.
Mon, May 13, 2:38 PM · Frameworks
kossebau added inline comments to D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -.
Mon, May 13, 1:05 PM · Frameworks
kossebau updated the diff for D21176: PanelView: update mask on window on change of panelMask property.

keep old code for KF 5.58 compat

Mon, May 13, 6:33 AM · Plasma
kossebau requested review of D21179: FrameSvgItem: emit maskChanged always from doUpdate().
Mon, May 13, 6:25 AM · Frameworks
kossebau added a comment to D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -.

The other option would be to fix the places which call hasElementPrefix but given that the ones known all rely on prefix() and actualPrefix(), it seems less code to fix this in one place and change behaviour a bit to be more grateful with the argument passed.

Mon, May 13, 12:20 AM · Frameworks
kossebau requested review of D21176: PanelView: update mask on window on change of panelMask property.
Mon, May 13, 12:13 AM · Plasma
kossebau requested review of D21175: FrameSvgPrivate::generateBackground: generate background also if reqp != p.
Mon, May 13, 12:01 AM · Frameworks

Sun, May 12

kossebau requested review of D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -.
Sun, May 12, 11:41 PM · Frameworks
kossebau committed R242:0f65c95771eb: API dox: point to Plasma5 versions on techbase if avail (authored by kossebau).
API dox: point to Plasma5 versions on techbase if avail
Sun, May 12, 11:32 PM
kossebau requested review of D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'.
Sun, May 12, 11:31 PM · Frameworks
kossebau requested review of D21172: FrameSvg: also clear mask cache on clearCache().
Sun, May 12, 11:27 PM · Frameworks

Fri, May 10

kossebau added a comment to T8126: Figure out what to about all the content that doesn't work.

(Sigh, another long thingie, just no way found to cut short. I appreciate your efforts in still reading this :) Sorry, no cookie hidden in the end as reward)

Fri, May 10, 5:34 PM · KDE Store

Thu, May 9

kossebau committed R242:fca08ef241ef: FrameSvg: l & r borders or t & b don't need to have same height resp. width (authored by kossebau).
FrameSvg: l & r borders or t & b don't need to have same height resp. width
Thu, May 9, 11:22 PM
kossebau closed D21106: FrameSvg: l & r borders or t & b don't need to have same height resp. width.
Thu, May 9, 11:22 PM · Frameworks
kossebau requested review of D21106: FrameSvg: l & r borders or t & b don't need to have same height resp. width.
Thu, May 9, 8:20 PM · Frameworks
kossebau added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.

The interaction pattern Close-on-MMB can be also seen with tabs, like Firefox, Chromium, KDevelop, and surely more tabbed view shells. So the muscle memory of those used to this really calls to try this pattern here as well, given this is an overview list of window/view representing items. And this not working is rather experienced inconsistency.

Thu, May 9, 7:11 PM · KWin
kossebau added a comment to T8126: Figure out what to about all the content that doesn't work.

After talking with Dan Leinir, here is another approach:

  • Every file can be attached a tag, in this case "plasma-4" and "plasma-5" (or both or none).
  • These tags can be set by every developer for their product files themselves
  • If Dan does implement looking for the "plasma-5" tag actively set, the themes can stay in the category they are now, but only plasma-5 tagged themes will appear from Plasma 5.16 onwards, which from the end result should be like starting with an empty category.
Thu, May 9, 7:11 PM · KDE Store
kossebau requested review of D21098: Handle apps which set the desktopFileName property with filename suffix.
Thu, May 9, 1:09 PM · Frameworks
kossebau requested review of D21097: Handle apps which set the desktopFileName property with filename suffix.
Thu, May 9, 12:40 PM · Plasma