- User Since
- Apr 18 2015, 11:52 AM (169 w, 1 d)
I only bumped the min deps to be able to apply some coding standards and have better known build conditions, so the unit tests could be fixed to no longer fail.
Sat, Jul 14
Is there some tag which can be used to pull the people in who want to support that Closed Source Microsoft platform in such cases?
@bruns Please update all the "@since" to 5.49, as this will be only part of the next KF version now.
Fri, Jul 13
Wed, Jul 11
Sorry, but I am currently not active in Marble, so have no clue about things & needs, have to pull out here.
Tue, Jul 10
That unconditional reset of ECM_GLOBAL_FIND_VERSION is IMHO a flaw which should see some general fix. But no idea yet, so for now change on "our" side.
Looks like proper work from a quick reading glance at the patch, thanks for providing the patch, Again, not the maintainer and no time to properly review. Needs someone from the active Plasma team to get this in. If no-one responded in the next few days, please ping people again by making another comment here and perhaps trying to poke individual members from https://phabricator.kde.org/project/members/35/ by mentioning them in the comment.
Mon, Jul 9
Seems this was pushed only after the tagging of 5.48 was done on Saturday night, so too late for that release.
If this should be still part of 5.48, get in contact with dfaure so he could consider moving the tag/release pointer to include this commit, or please update the since tags to 5.49 in prepartion of the next release.
@rkflx I cannot remember anything which would need the init to be done that very point at setup, so if moving it to that later point and works for you, no objection from my side. Have not yet got around to testing things myself.
Sun, Jul 8
Sat, Jul 7
Thanks for offering this for inclusion. No time to test myself currently.
Fri, Jul 6
Pardon for having pushed a fix directly, as I was sure about this fix for the issue :) Seems Phabricator decided it's the same commit due to being an identical patch?
Thu, Jul 5
All updated no-meta samplefiles fail for me without the patch, but as wanted do not fail with the patch. So seems fine to me :) @astippich Thanks for picking up this patch and creating proper test files.
+1 though only, given I am no maintainer.
Target branch: 5.2
Wed, Jul 4
Any chance this change broke the unit test filemetadataitemcounttest, due to new items?