kossebau (Friedrich W. H. Kossebau)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 11:52 AM (127 w, 2 h)
Availability
Available

Recent Activity

Today

kossebau committed R306:783b03b163dc: API dox: don't hide parameter names in signature, use Q_UNUSED (authored by kossebau).
API dox: don't hide parameter names in signature, use Q_UNUSED
Sat, Sep 23, 12:49 AM

Yesterday

kossebau committed R383:879dd00a8210: Bump version to 1.1 given the new features (authored by kossebau).
Bump version to 1.1 given the new features
Fri, Sep 22, 11:22 PM
kossebau committed R383:d1ee5a0e3908: Support loading by stream and restoring state on reload (authored by kossebau).
Support loading by stream and restoring state on reload
Fri, Sep 22, 11:05 PM
kossebau closed D7580: Support loading by stream and restoring state on reload.
Fri, Sep 22, 11:05 PM
kossebau committed R383:f8ee697f5173: Fix .arcconfig (authored by kossebau).
Fix .arcconfig
Fri, Sep 22, 11:05 PM
kossebau updated the summary of D7580: Support loading by stream and restoring state on reload.
Fri, Sep 22, 10:58 PM
kossebau added a comment to D7580: Support loading by stream and restoring state on reload.

Thanks for quick reaction :) Will push now, even if we discovered another item which needs some more clarification. Would do a follow-up fix then if we find one is needed,

Fri, Sep 22, 10:55 PM
kossebau committed R166:5a78b8faa5e8: Merge branch 'Applications/17.08' (authored by kossebau).
Merge branch 'Applications/17.08'
Fri, Sep 22, 5:33 PM
kossebau committed R166:a476dd8eac5a: Fix .arcconfig (authored by kossebau).
Fix .arcconfig
Fri, Sep 22, 5:29 PM
kossebau committed R166:39ba6e4f50ac: Add .arcconfig (authored by kossebau).
Add .arcconfig
Fri, Sep 22, 5:23 PM
kossebau committed R166:652c4c547ac6: Hint to drop handlers we only want to offer copy of data, not move (authored by kossebau).
Hint to drop handlers we only want to offer copy of data, not move
Fri, Sep 22, 5:23 PM
kossebau committed R166:cedfdb40b80a: Fix: use autosaveFilename format also for files exported via DnD or menu (authored by kossebau).
Fix: use autosaveFilename format also for files exported via DnD or menu
Fri, Sep 22, 5:19 PM
kossebau closed D7725: Fix: use autosaveFilename format also for files exported via DnD or menu.
Fri, Sep 22, 5:19 PM
kossebau added a comment to D7725: Fix: use autosaveFilename format also for files exported via DnD or menu.

Thanks for testing, @alexeymin. Feels better to push with at least knowing one person having had a go at the patch, with positive results :)

Fri, Sep 22, 5:13 PM
kossebau committed R882:7b4929184f15: Preset "Git" as version in links to issue tracker (authored by kossebau).
Preset "Git" as version in links to issue tracker
Fri, Sep 22, 2:37 PM
kossebau added a comment to D7725: Fix: use autosaveFilename format also for files exported via DnD or menu.

Thanks for the offer, @alexeymin:

Fri, Sep 22, 2:22 PM
kossebau committed R882:dcb589c871fb: Update README.md: link to KParts, add Issues section (authored by kossebau).
Update README.md: link to KParts, add Issues section
Fri, Sep 22, 2:14 PM
kossebau committed R882:e12c35c2df89: Add bugtracker & donation urls to appdata file (authored by kossebau).
Add bugtracker & donation urls to appdata file
Fri, Sep 22, 2:14 PM
kossebau added a comment to D7725: Fix: use autosaveFilename format also for files exported via DnD or menu.

Given two weeks passed without a comment, I will follow KA release managers' okay to push on own responsibilities now (meh).

Fri, Sep 22, 1:47 PM
kossebau added a comment to D7455: [Feature] Live document preview plugin.

Thanks, so doing now already (have three bugs I need to file to myself already)

Fri, Sep 22, 1:44 PM
kossebau added a comment to D7455: [Feature] Live document preview plugin.

@cullmann, @dhaumann : okay if I add a component "plugin-preview" to product "kate" on bugs.kde.org already now, so issues are already tracked at the potential target place? (can do myself, jumped on a diamond once which gave me the powers ;) )

Fri, Sep 22, 1:41 PM
kossebau added a comment to D7580: Support loading by stream and restoring state on reload.

With the latest update then this patch would represent the blue-print for KParts plugins as I see it when it comes to supporting both state restoring and support for streams, at least for what is possible currently with the existing KParts API.

Any patterns which you see running against the ideas of the API? Or can this patch be applied as is, and be pointed to as template?

Fri, Sep 22, 1:39 PM
kossebau committed R874:ab0981763537: Add bugtracker & donation urls to appdata file (authored by kossebau).
Add bugtracker & donation urls to appdata file
Fri, Sep 22, 12:31 PM
kossebau added a comment to D7932: Fix broken reloading and broken layout changing due to lost filename.

KGraphViewer should get a 2.4.1 emergency release with this in (meh, did no-one do some pre-release feature test coverage run...)

Fri, Sep 22, 2:25 AM
kossebau created D7932: Fix broken reloading and broken layout changing due to lost filename.
Fri, Sep 22, 2:24 AM

Thu, Sep 21

kossebau committed R874:ca9e7c0f7291: Fix inverted logic on existing selection in contextmenu with QtWebEngine (authored by kossebau).
Fix inverted logic on existing selection in contextmenu with QtWebEngine
Thu, Sep 21, 5:13 PM
kossebau committed R874:887bdb32bc2d: Offer selectAll/copyText actions in more places (authored by kossebau).
Offer selectAll/copyText actions in more places
Thu, Sep 21, 5:13 PM
kossebau committed R874:d21b2fdcb62d: Extend KAboutData of kpart (authored by kossebau).
Extend KAboutData of kpart
Thu, Sep 21, 5:13 PM
kossebau committed R451:e24b528a9482: kuiviewer: Bump version to 0.3.0, add credits for myself (authored by kossebau).
kuiviewer: Bump version to 0.3.0, add credits for myself
Thu, Sep 21, 12:41 PM
kossebau committed R451:61bf8cb0366f: Merge branch 'Applications/17.08' (authored by kossebau).
Merge branch 'Applications/17.08'
Thu, Sep 21, 12:41 PM
kossebau committed R451:ab93ff1748f0: Use non-deprecated <gui> as root element in ui.rc file (authored by kossebau).
Use non-deprecated <gui> as root element in ui.rc file
Thu, Sep 21, 12:37 PM
kossebau committed R451:79adc315201c: Remove unused items from kuiviewer_part.rc (authored by kossebau).
Remove unused items from kuiviewer_part.rc
Thu, Sep 21, 12:37 PM
kossebau committed R491:b18ea16a2ab0: kgraphviewer_part.rc: set fallback text for toplevel menu entries (authored by kossebau).
kgraphviewer_part.rc: set fallback text for toplevel menu entries
Thu, Sep 21, 12:17 PM
kossebau committed R457:048bfa5e75f6: Bump version to 0.23.2 (authored by kossebau).
Bump version to 0.23.2
Thu, Sep 21, 3:24 AM

Tue, Sep 19

kossebau committed R874:9838939ad94f: Rename thumbnailer to kmarkdownwebviewthumbnail, for proper namespacing (authored by kossebau).
Rename thumbnailer to kmarkdownwebviewthumbnail, for proper namespacing
Tue, Sep 19, 4:58 PM
kossebau committed R882:47a8da5599f0: Default to non-auto-updates, given current kparts abilities (authored by kossebau).
Default to non-auto-updates, given current kparts abilities
Tue, Sep 19, 4:43 PM
kossebau committed R882:2305218e6f35: Update README.md: use CMAKE_INSTALL_PREFIX now, dump WIP state note (authored by kossebau).
Update README.md: use CMAKE_INSTALL_PREFIX now, dump WIP state note
Tue, Sep 19, 4:26 PM
kossebau added a comment to D7455: [Feature] Live document preview plugin.

Given no feedback my temptation now wins over me. So preparing some independent release(s) now for the start.

Good idea.

In any case: I think it is ok to merge this, given its an optional plugin, it can't hurt to have it in our git and out for people with nightly builds.

Tue, Sep 19, 2:57 PM
kossebau committed R874:e6e12ed13f20: Add Markdown thumbnailer (authored by kossebau).
Add Markdown thumbnailer
Tue, Sep 19, 1:50 PM

Sun, Sep 17

kossebau added a comment to D7725: Fix: use autosaveFilename format also for files exported via DnD or menu.

@bgupta ping?

Sun, Sep 17, 5:30 PM
kossebau committed R39:bb56bb4c5faf: Plugin template: fix name of Messages.sh (authored by kossebau).
Plugin template: fix name of Messages.sh
Sun, Sep 17, 4:36 PM

Fri, Sep 15

kossebau committed R874:9581eac33c13: Use /kmarkdownwebview as path prefix in qrc file, to match lib name (authored by kossebau).
Use /kmarkdownwebview as path prefix in qrc file, to match lib name
Fri, Sep 15, 6:03 PM
kossebau committed R874:fe0e269babc3: Use own QWebEngineProfile instance, to stay independent (authored by kossebau).
Use own QWebEngineProfile instance, to stay independent
Fri, Sep 15, 6:03 PM
kossebau committed R882:c09c6bbc7753: Update README.md a bit (authored by kossebau).
Update README.md a bit
Fri, Sep 15, 2:10 PM
kossebau committed R882:5e9b12136271: Add org.kde.ktexteditorpreviewplugin.appdata.xml (authored by kossebau).
Add org.kde.ktexteditorpreviewplugin.appdata.xml
Fri, Sep 15, 2:10 PM
kossebau committed R882:cecefe001b8f: Add license copy (authored by kossebau).
Add license copy
Fri, Sep 15, 2:10 PM
kossebau committed R882:246c77c791f3: Fix name of Messages.sh (authored by kossebau).
Fix name of Messages.sh
Fri, Sep 15, 2:10 PM

Thu, Sep 14

kossebau committed R32:dc79e5829aa1: Remove unused and no longer valid include directories (authored by kossebau).
Remove unused and no longer valid include directories
Thu, Sep 14, 9:30 PM

Wed, Sep 13

kossebau created T7002: Add kmarkdownwebview to Extragear builds.
Wed, Sep 13, 7:48 PM · build.kde.org
kossebau committed R499:d638fbccdab5: kmarkdownwebview moved to extragear/utils (authored by kossebau).
kmarkdownwebview moved to extragear/utils
Wed, Sep 13, 7:33 PM
kossebau committed R874:417466d7b4e0: Bump version to 0.1.0 (authored by kossebau).
Bump version to 0.1.0
Wed, Sep 13, 7:08 PM
kossebau added a comment to D7455: [Feature] Live document preview plugin.

Given KA 17.12 is still some months away, I am tempted to make some initial stand-alone release of the plugin for now, and have it then merged into the kate repo (or some ktexteditor-addons if people create that). That would also allow/motivate people to fix kparts already now, even if they do not run kate from master.

Wed, Sep 13, 6:53 PM
kossebau committed R32:8b74ffc1169d: App templates: update ui files to more recent Designer formatting style (authored by kossebau).
App templates: update ui files to more recent Designer formatting style
Wed, Sep 13, 2:40 PM

Tue, Sep 12

kossebau committed R874:176e2b33780e: Always create MarkdownBrowserExtension (authored by kossebau).
Always create MarkdownBrowserExtension
Tue, Sep 12, 9:43 PM
kossebau added a comment to D7580: Support loading by stream and restoring state on reload.

When I read this initially, I guessed this method is just about the view state. But is also bound to data-pulling by the kpart, given that the default implementation explicitely calls openUrl() with the url stored in the datastream. Which might make sense for simple-to-use API with the non-stream use cases. But leaves out the stream-based data-pushing usage.

It does indeed. Two incompatible features...

I think all we need is for the part to remember that it opened the URL via the stream api, and add that to the data saved by saveState(). Then in restoreState() we can skip openUrl() when that bool is true. It'll be up to the caller to redo the openStream/writeStream/closeStream sequence.

Tue, Sep 12, 3:20 PM
kossebau updated the diff for D7580: Support loading by stream and restoring state on reload.

add support for state restoring via BrowserExtension

Tue, Sep 12, 2:44 PM
kossebau committed R637:c8309c626e6a: Port creation of KGraphViewerPart, no longer done using an id (authored by kossebau).
Port creation of KGraphViewerPart, no longer done using an id
Tue, Sep 12, 5:47 AM
kossebau committed R637:933375412526: Build with current KDevPlatform master (authored by kossebau).
Build with current KDevPlatform master
Tue, Sep 12, 5:47 AM
kossebau committed R637:e8c00a27e87b: Use a few defines for more modern Qt, bump Qt dep to 5.5 as kdevplatform (authored by kossebau).
Use a few defines for more modern Qt, bump Qt dep to 5.5 as kdevplatform
Tue, Sep 12, 5:47 AM
kossebau committed R637:a69a065f8ff4: Call feature_summary, not just include the macro (authored by kossebau).
Call feature_summary, not just include the macro
Tue, Sep 12, 5:47 AM
kossebau committed R637:a61676f348f7: Use override (authored by kossebau).
Use override
Tue, Sep 12, 5:47 AM
kossebau committed R637:8ddce8303b47: Use nullptr (authored by kossebau).
Use nullptr
Tue, Sep 12, 5:47 AM
kossebau committed R637:c9784789431b: Port to method-pointer-based signal-slot connects (authored by kossebau).
Port to method-pointer-based signal-slot connects
Tue, Sep 12, 5:47 AM
kossebau committed R637:eddffab5218c: Build with current KDevPlatform master (authored by kossebau).
Build with current KDevPlatform master
Tue, Sep 12, 5:47 AM
kossebau committed R637:a6b30622a7a8: Do not crash on non-Qt filedialogs (authored by kossebau).
Do not crash on non-Qt filedialogs
Tue, Sep 12, 5:47 AM
kossebau committed R637:e6485397cf35: Add missing explicit tags (authored by kossebau).
Add missing explicit tags
Tue, Sep 12, 5:47 AM

Mon, Sep 11

kossebau committed R32:2002bc2f0bc4: Merge branch '5.2' (authored by kossebau).
Merge branch '5.2'
Mon, Sep 11, 9:55 PM
kossebau committed R32:f5c63a500b8f: Fix KDevPlatform cmake config file to include used find_dependency macro (authored by kossebau).
Fix KDevPlatform cmake config file to include used find_dependency macro
Mon, Sep 11, 9:28 PM

Sun, Sep 10

kossebau added a comment to D7580: Support loading by stream and restoring state on reload.

"how would zoom and other custom state properties be save and retrieved again" -> using BrowserExtension's saveState/restoreState as usual, no? I'm not 100% sure about the interaction with streaming, but normally that happens after opening the url anyway, so it should be unrelated.

Oh, somehow missed those methods. Possibly was blinded by KParts::OpenUrlArguments::xOffset()/yOffset() and since then assumed that state restoring was supposed to be done only via those arguments.

That's just the default implementation of BE::restoreState(), which loads url+offsets and calls setArguments before openUrl. But this is virtual, so more can be done.

Sun, Sep 10, 2:27 PM

Sat, Sep 9

kossebau updated the test plan for D7725: Fix: use autosaveFilename format also for files exported via DnD or menu.
Sat, Sep 9, 1:20 PM

Thu, Sep 7

kossebau updated the diff for D7725: Fix: use autosaveFilename format also for files exported via DnD or menu.

make temporary file readonly

Thu, Sep 7, 9:02 PM
kossebau created D7725: Fix: use autosaveFilename format also for files exported via DnD or menu.
Thu, Sep 7, 7:13 PM

Wed, Sep 6

kossebau added a comment to D7455: [Feature] Live document preview plugin.

BTW, this patch is as before just a maintained copy the same code in kde:scratch/kossebau/ktexteditorpreviewplugin. So for testing you can as before just clone and build that repo.

Wed, Sep 6, 4:42 PM
kossebau updated the diff for D7455: [Feature] Live document preview plugin.

add missing code commnent not synced to disk before creating diff

Wed, Sep 6, 4:40 PM
kossebau added a comment to D7455: [Feature] Live document preview plugin.

Thanks everyone for your feedback so far. I hope I have picked everything up, either as fix or as TODO item in the code. Please check again if any fix matches your expectations and any TODO item covers your needs.

Wed, Sep 6, 4:36 PM
kossebau retitled D7455: [Feature] Live document preview plugin from [WIP] [Feature] Live document preview plugin to [Feature] Live document preview plugin.
Wed, Sep 6, 3:57 PM
kossebau updated the diff for D7455: [Feature] Live document preview plugin.

update to latest version:

  • option to do manual preview updates instead of automatic ones
  • be inactive if being hidden
  • initial session restore support
  • namsespace for simple helper classes
  • small code shuffling for cleaner structure
Wed, Sep 6, 3:33 PM
kossebau committed R451:93d3c53ae084: KUiViewer part: support loading from stream (authored by kossebau).
KUiViewer part: support loading from stream
Wed, Sep 6, 2:33 AM
kossebau committed R451:ca5d088ffa65: KUIViewer: store view state on closing url and restore if reloading same (authored by kossebau).
KUIViewer: store view state on closing url and restore if reloading same
Wed, Sep 6, 2:33 AM
kossebau committed R451:9c4a8eed4571: KUIViewer: show all widget types in-pane, using QMdiArea (authored by kossebau).
KUIViewer: show all widget types in-pane, using QMdiArea
Wed, Sep 6, 2:33 AM

Tue, Sep 5

kossebau committed R247:27fd52e96c87: Move kmarkdownwebview from kdereview into extragear/utils (authored by kossebau).
Move kmarkdownwebview from kdereview into extragear/utils
Tue, Sep 5, 12:49 PM

Mon, Sep 4

kossebau committed R32:c06d3c5670f9: Merge branch '5.2' (authored by kossebau).
Merge branch '5.2'
Mon, Sep 4, 4:44 PM
kossebau committed R32:4df6b64ab522: Use QT_USE_QSTRINGBUILDER definition (authored by kossebau).
Use QT_USE_QSTRINGBUILDER definition
Mon, Sep 4, 3:50 PM
kossebau closed D7687: Use QT_USE_QSTRINGBUILDER definition by committing R32:4df6b64ab522: Use QT_USE_QSTRINGBUILDER definition.
Mon, Sep 4, 3:50 PM
kossebau created D7687: Use QT_USE_QSTRINGBUILDER definition.
Mon, Sep 4, 2:38 PM
kossebau added a comment to D7580: Support loading by stream and restoring state on reload.

Oops, yes, you're completely right. I got distracted by the word close, but it's a different meaning in closeStream and closeUrl. Apologies for the confusion.

Mon, Sep 4, 1:22 PM
kossebau updated the summary of D7580: Support loading by stream and restoring state on reload.
Mon, Sep 4, 1:03 AM
kossebau added a comment to D7580: Support loading by stream and restoring state on reload.

As I see it, it's *either* openUrl/closeUrl *or* openStream/writeStream/closeStream.

Mon, Sep 4, 1:01 AM

Sun, Sep 3

kossebau committed R451:f4d69f5d7343: Port deprecated QPixmap::grabWidget() -> QWidget::grab() (authored by kossebau).
Port deprecated QPixmap::grabWidget() -> QWidget::grab()
Sun, Sep 3, 3:30 AM
kossebau committed R451:7fc5681f3e21: kuiviewer: process only the one file argument officially supported (authored by kossebau).
kuiviewer: process only the one file argument officially supported
Sun, Sep 3, 3:30 AM
kossebau committed R451:03cb0e4694e3: Use function pointer connect style (authored by kossebau).
Use function pointer connect style
Sun, Sep 3, 3:30 AM
kossebau committed R451:2d87d5f7bf4c: Resolve conflict for -h cmdl arg, use --sh & --sw as short size args (authored by kossebau).
Resolve conflict for -h cmdl arg, use --sh & --sw as short size args
Sun, Sep 3, 3:30 AM
kossebau committed R451:2049b0aac93f: Don't use doxygen style comments for license header (authored by kossebau).
Don't use doxygen style comments for license header
Sun, Sep 3, 3:30 AM

Sat, Sep 2

kossebau committed R383:f7c7cbaa359f: use more strict Qt code definitions (authored by kossebau).
use more strict Qt code definitions
Sat, Sep 2, 3:43 PM
kossebau committed R383:ce2f2677e70a: Add .arcconfig (authored by kossebau).
Add .arcconfig
Sat, Sep 2, 3:38 PM
kossebau updated the diff for D7580: Support loading by stream and restoring state on reload.

handle repeated closeUrl call

Sat, Sep 2, 3:37 PM
kossebau committed R451:862cce7e5900: kuiviewer: use more strict Qt code definitions (authored by kossebau).
kuiviewer: use more strict Qt code definitions
Sat, Sep 2, 3:35 PM
kossebau committed R874:de70a9669b8b: Do not lose previous view state on repeated closeUrl() calls (authored by kossebau).
Do not lose previous view state on repeated closeUrl() calls
Sat, Sep 2, 3:00 PM
kossebau committed R457:fdf8c42ceda8: Bump version to 0.23.1 (authored by kossebau).
Bump version to 0.23.1
Sat, Sep 2, 4:59 AM
kossebau committed R874:6debff938cf6: Remove unneeded find_package(Qt5WebChannel) with webkit build (authored by kossebau).
Remove unneeded find_package(Qt5WebChannel) with webkit build
Sat, Sep 2, 3:17 AM