kossebau (Friedrich W. H. Kossebau)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 11:52 AM (248 w, 1 d)
Availability
Available

Recent Activity

Yesterday

kossebau committed R237:3e287d5fa29b: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler (authored by kossebau).
KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler
Sun, Jan 19, 10:31 AM
kossebau closed D26723: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler.
Sun, Jan 19, 10:31 AM · Frameworks

Fri, Jan 17

kossebau committed R32:8325944825d6: Fix reformat for long strings (authored by buschinski).
Fix reformat for long strings
Fri, Jan 17, 10:05 PM
kossebau committed R32:7a1edb7676d8: Introduce shell-embedded message area, to avoid dialog windows (authored by kossebau).
Introduce shell-embedded message area, to avoid dialog windows
Fri, Jan 17, 10:04 PM
kossebau committed R264:eae0cd8a6ed9: Unbreak module imports for Python2 (authored by kossebau).
Unbreak module imports for Python2
Fri, Jan 17, 1:11 PM
kossebau closed D26652: Unbreak module imports for Python2.
Fri, Jan 17, 1:11 PM · Documentation, Frameworks
kossebau committed R264:77a7a08abb6e: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org (authored by kossebau).
Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org
Fri, Jan 17, 1:10 PM
kossebau closed D26661: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org.
Fri, Jan 17, 1:10 PM · Documentation, Frameworks
kossebau added a reviewer for D26723: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler: Frameworks.
Fri, Jan 17, 10:35 AM · Frameworks
kossebau added a comment to D26202: Refactor KConfigXT .

where "full" would also need to mean "clean fresh build dirs" :) so that the codegenerator is triggered to be run, as the current cmake code seems to not inject a build dep between generator instance and generated files, so a new version does not trigger regeneration. Something that could also get a fix perhaps, IIRC other tools have such a dep.

Fri, Jan 17, 10:35 AM · Frameworks
kossebau requested review of D26723: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler.
Fri, Jan 17, 10:34 AM · Frameworks
kossebau added a comment to D26202: Refactor KConfigXT .

where "full" would also need to mean "clean fresh build dirs" :) so that the codegenerator is triggered to be run, as the current cmake code seems to not inject a build dep between generator instance and generated files, so a new version does not trigger regeneration. Something that could also get a fix perhaps, IIRC other tools have such a dep.

Fri, Jan 17, 9:03 AM · Frameworks
kossebau added a comment to D26202: Refactor KConfigXT .

This morning it was found e.g. on opensuse build server (but reproduced by me locally) that this change broke KMyMoney & KDevelop, who now start to fail e.g. with (using VERBOSE=1 make)

[ 38%] Generating kcfg_custombuildsystemconfig.h, kcfg_custombuildsystemconfig.cpp
cd /home/koder/Kode/kdegit/build/kf5/extragear/kdevelop/kdevelop/plugins/custom-buildsystem && /home/koder/System/opt/kf5/lib64/libexec/kf5/kconfig_compiler_kf5 /home/koder/Kode/kdegit/kf5/extragear/kdevelop/kdevelop/plugins/custom-buildsystem/kcfg_custombuildsystemconfig.kcfg /home/koder/Kode/kdegit/kf5/extragear/kdevelop/kdevelop/plugins/custom-buildsystem/kcfg_custombuildsystemconfig.kcfgc -d /home/koder/Kode/kdegit/build/kf5/extragear/kdevelop/kdevelop/plugins/custom-buildsystem/
No entries.
make[2]: *** [plugins/custom-buildsystem/CMakeFiles/kdevcustombuildsystem.dir/build.make:71: plugins/custom-buildsystem/kcfg_custombuildsystemconfig.h] Fehler 1

See https://phabricator.kde.org/source/kdevelop/browse/master/plugins/custom-buildsystem/ for the respecive kfg files.

Fri, Jan 17, 8:15 AM · Frameworks

Thu, Jan 16

kossebau committed R39:9499d28ba80b: KateMessageWidget: remove unused event filter installation (authored by kossebau).
KateMessageWidget: remove unused event filter installation
Thu, Jan 16, 4:28 PM
kossebau closed D26704: KateMessageWidget: remove unused event filter installation.
Thu, Jan 16, 4:28 PM · Frameworks, Kate
kossebau committed R242:1c608599991d: API dox: do not use ":" after "@since" (authored by kossebau).
API dox: do not use ":" after "@since"
Thu, Jan 16, 11:32 AM
kossebau committed R289:bc01688f99fc: API dox: do not use ":" after "@since" (authored by kossebau).
API dox: do not use ":" after "@since"
Thu, Jan 16, 11:29 AM
kossebau added a comment to D26602: Define K_DOXYGEN as macro to check if kapidox/doxygen is run.

No one any opinion? Guess most people have not run into the need to do pre-processor switches for the doc generation, and also never seen DOXYGEN_SHOULD_SKIP_THIS before.

Thu, Jan 16, 10:59 AM · Documentation, Frameworks
kossebau requested review of D26704: KateMessageWidget: remove unused event filter installation.
Thu, Jan 16, 10:17 AM · Frameworks, Kate
kossebau committed R289:c6eb72464f96: Exclude also private implementation of raiseWidget if not building (authored by kossebau).
Exclude also private implementation of raiseWidget if not building
Thu, Jan 16, 10:04 AM
kossebau added a comment to D26594: Deprecate raiseWidget.

Hi. When introducing the deprecation macros to a lib with ecm_generate_export_header, one also needs to help kapidox & ecm_add_qch. Sadly this was only discovered later, so it is also missing from the first set of such commits introducing the use of ecm_generate_export_headerwhich you might have taken as template :)

Thu, Jan 16, 9:54 AM · Frameworks
kossebau committed R289:191078e9387b: Add missing declaration of EXCLUDE_DEPRECATED_BEFORE_AND_AT (authored by kossebau).
Add missing declaration of EXCLUDE_DEPRECATED_BEFORE_AND_AT
Thu, Jan 16, 9:49 AM
kossebau committed R289:bdd8930cca99: API dox: teach kapidox & ecm_add_qch about new deprecation macros (authored by kossebau).
API dox: teach kapidox & ecm_add_qch about new deprecation macros
Thu, Jan 16, 9:49 AM

Wed, Jan 15

kossebau requested review of D26697: Message-related methods: Use more member-function-pointer-based connect.
Wed, Jan 15, 8:34 PM · Frameworks, Kate
kossebau added a comment to D26696: DocumentPrivate::postMessage: avoid multiple hash lookups.

Seen while forking the Message classes for KDevelop for some shell-level message area :) https://invent.kde.org/kde/kdevelop/merge_requests/87
Was confused initially by the old code, and then found it also less µ-optimized ;)

Wed, Jan 15, 8:12 PM · Frameworks, Kate
kossebau requested review of D26696: DocumentPrivate::postMessage: avoid multiple hash lookups.
Wed, Jan 15, 8:10 PM · Frameworks, Kate
kossebau added a comment to D26652: Unbreak module imports for Python2.

Last night's run of api.kde.org generation with kapidox locally patched with this change worked again,
So unless there are objections will push then latest next WE, though happy to have people give green light before :)

Wed, Jan 15, 7:32 AM · Documentation, Frameworks

Tue, Jan 14

kossebau added inline comments to D26670: ki18n_wrap_ui: error when file doesn't exist.
Tue, Jan 14, 7:45 PM · Frameworks
kossebau closed D26248: API dox: add since for KDE_INSTALL_KNSRCDIR, note backward-compatible variant.
Tue, Jan 14, 4:09 PM · Frameworks
kossebau committed R304:bd2e67ea61b5: API dox: add since for KDE_INSTALL_KNSRCDIR, note backward-compatible variant (authored by kossebau).
API dox: add since for KDE_INSTALL_KNSRCDIR, note backward-compatible variant
Tue, Jan 14, 4:09 PM
kossebau updated the diff for D26661: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org.

fix comment locale -> filesystem encoding

Tue, Jan 14, 12:55 PM · Documentation, Frameworks
kossebau added a comment to D26661: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org.

D22836 was tried before to fix this, but later it was found this still did not work on api.kde.org. At that time I had added some local patches on api.kde.org itself, but not getting further at one point forgot about things sadly.

Tue, Jan 14, 12:53 PM · Documentation, Frameworks
kossebau requested review of D26661: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org.
Tue, Jan 14, 12:48 PM · Documentation, Frameworks
kossebau updated the diff for D26652: Unbreak module imports for Python2.

Brown paper bag for me: if one changes code, they should also see to trigger
that code, in this case passing the --depdiagram-dot-dir arg to
kapidox_generate...

Tue, Jan 14, 12:01 PM · Documentation, Frameworks
kossebau added a comment to D26652: Unbreak module imports for Python2.

For now, given @bcooksley's comment going to try some simple change to 'from kapidox.depdiagram import gvutils', this is a pattern found elsewhere in the old code. Will do a local patch to the checkout on the server and see if this has any effect on next cron job run. So far that also worked for all the 3 situations I tested (local python3 & python2, python2 on server test env).

Tue, Jan 14, 11:33 AM · Documentation, Frameworks
kossebau added a comment to D26652: Unbreak module imports for Python2.

To add to my confusion, running the unpatched version works with my local 2.7.17 python interpreter (checked with print (sys.version)) and worse, running things manually on api.kde.org in some test subdir also works with its 2.7.15...

Tue, Jan 14, 11:05 AM · Documentation, Frameworks
kossebau added inline comments to D26652: Unbreak module imports for Python2.
Tue, Jan 14, 9:28 AM · Documentation, Frameworks
kossebau added a comment to D26652: Unbreak module imports for Python2.

Because the very user api.kde.org right now in production still uses python2 sadly. And replacing that server with something modern is sadly not a few-hours job, still waiting for someone to spend the weeks on getting a substitution done.

Tue, Jan 14, 9:06 AM · Documentation, Frameworks
kossebau added a comment to D25632: Fix module imports with Python3.

D26652 now up as proposal to fix this

Tue, Jan 14, 8:33 AM · Documentation, Frameworks
kossebau requested review of D26652: Unbreak module imports for Python2.
Tue, Jan 14, 8:33 AM · Documentation, Frameworks
kossebau added a comment to D25632: Fix module imports with Python3.

No python developer myself, but from patterns seen I guess the imports should have some

if sys.version_info.major < 3:
    // python2 import style
else:
    // python3 import style

?

Tue, Jan 14, 6:06 AM · Documentation, Frameworks
kossebau added a comment to D25632: Fix module imports with Python3.

Hi. Sadly api.kde.org failed to pick this change up until yesterday, as I had forgotten a change in the local checkout on my last work on the server, which then blocked the update via scripted git pull.
That I fixed partially yesterday, making sure latest KApiDox is run on api.kde.org, but that showed that gentoo(?) server running api.kde.org does not like yet this new code:

Traceback (most recent call last):
  File "/home/api/kapidox/src/kapidox_generate", line 110, in <module>
    main()
  File "/home/api/kapidox/src/kapidox_generate", line 106, in main
    copyright=kde_copyright)
  File "/home/api/kapidox/src/kapidox/hlfunctions.py", line 108, in do_it
    dot_files, tmp_dir)
  File "/home/api/kapidox/src/kapidox/generator.py", line 646, in generate_diagram
    with_qt=with_qt)
  File "/home/api/kapidox/src/kapidox/depdiagram/generate.py", line 156, in generate
    db.populate(dot_files, with_qt=with_qt)
  File "/home/api/kapidox/src/kapidox/depdiagram/frameworkdb.py", line 175, in populate
    fw = parser.parse(tier, dot_file)
  File "/home/api/kapidox/src/kapidox/depdiagram/frameworkdb.py", line 115, in parse
    dot_data =  preprocess(dot_file)
  File "/home/api/kapidox/src/kapidox/depdiagram/frameworkdb.py", line 75, in preprocess
    for node_handle in gvutils.get_node_list(graph_handle):
NameError: global name 'gvutils' is not defined

From https://api.kde.org/logs/api/frameworks/frameworks5.log

Tue, Jan 14, 5:53 AM · Documentation, Frameworks

Mon, Jan 13

kossebau added a comment to D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES.

While touching this file, you might want to fix this file and make it self-contained by also having a include(CMakeParseArguments) at the begin, could be done as direct commit, no review needed IMHO :)

Mon, Jan 13, 3:19 PM · Frameworks
kossebau added a comment to D26589: KIO: fix compilation with KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054200.

Hotfix pushed: bfcc2363174804160e7da06b47128b7bad10cf09

Mon, Jan 13, 8:32 AM
kossebau committed R241:bfcc23631748: Revert effective removal of KUrlPixmapProvider from API (authored by kossebau).
Revert effective removal of KUrlPixmapProvider from API
Mon, Jan 13, 8:30 AM
kossebau added a comment to D26589: KIO: fix compilation with KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054200.

Will do a quick hot fix then to unbreak builds, proper solution can be discussed later (only had my first coffee right now).

Mon, Jan 13, 8:13 AM
kossebau added a comment to D26589: KIO: fix compilation with KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054200.

By setting -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054200 for the build of the lib, you effectively disable KCOMPLETION_ENABLE_DEPRECATED_SINCE(5, 66)​, and thus hide this class from any builds. Which makes kdelibs4support fail e.g., cmp. https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/86/

Mon, Jan 13, 8:08 AM
kossebau added a comment to D15797: [kdev-clazy] : use canonical paths.

No further need, thanks. I got the assist in your previous reply already I was looking for :)

Mon, Jan 13, 7:55 AM · KDevelop
kossebau added a comment to T12526: Investigate KMessageBoxNotifyInterface.

Where is removing sound capabilities from KNotifications discussed? That would be a loss, as one does not always stare at the screen, but also walks around (think lab) and would like some audio options to be notified about certain things one set as important to get back to the device.
Not knowning the discussion I might misunderstand something, so please point me to that place :) Actually, given mobile phones also happily make use of sound to notify (given they share the same fate of not always being looked at), I expect to get this wrong ;) But just in case...

Mon, Jan 13, 12:26 AM · KF6

Sun, Jan 12

kossebau committed R32:86ff1f0dbf7c: Unbreak build with Qt 5.12: add missing include (authored by kossebau).
Unbreak build with Qt 5.12: add missing include
Sun, Jan 12, 11:33 PM
kossebau committed R32:ae56043f0d23: clazy, clang-tidy: share code via new private KDevCompileAnalyzerCommon (authored by kossebau).
clazy, clang-tidy: share code via new private KDevCompileAnalyzerCommon
Sun, Jan 12, 11:03 PM
kossebau added a comment to D25660: Decouple KBookmarksMenu from KActionCollection.

Some API (docs) nitpicks :)

Sun, Jan 12, 12:21 PM · Frameworks
kossebau accepted D25494: Make tar archives reproducible by setting Pax headers.

No insight myself, but would trust you you know what you are doing here :) and it also matches what I just read on https://reproducible-builds.org/docs/archives/

Sun, Jan 12, 11:28 AM · KDevelop
kossebau added a comment to D26602: Define K_DOXYGEN as macro to check if kapidox/doxygen is run.

Some similar macro definitions used by other projects, as I found by doing some random grepping over my system includes:

  • __GTK_DOC_IGNORE__
  • Q_QDOC & Q_CLANG_QDOC
  • DO_NOT_DOCUMENT
  • EIGEN_PARSED_BY_DOXYGEN
  • DOXYGEN
  • U_IN_DOXYGEN
  • BOOST_DOXYGEN_INVOKED & lots of similar
  • CV_DOXYGEN
  • DOXYGEN_ENABLED
Sun, Jan 12, 10:45 AM · Documentation, Frameworks
kossebau requested review of D26602: Define K_DOXYGEN as macro to check if kapidox/doxygen is run.
Sun, Jan 12, 10:40 AM · Documentation, Frameworks
kossebau committed R242:4d7ba16825c4: Fix some @since & PLASMA_ENABLE_DEPRECATED_SINCE of last commit (authored by kossebau).
Fix some @since & PLASMA_ENABLE_DEPRECATED_SINCE of last commit
Sun, Jan 12, 6:40 AM
kossebau added inline comments to D23682: Make use of KPluginMetaData where we can.
Sun, Jan 12, 6:26 AM · Frameworks

Sat, Jan 11

kossebau committed R263:6f08f7ae576a: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again (authored by kossebau).
KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again
Sat, Jan 11, 11:55 AM
kossebau closed D26501: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again.
Sat, Jan 11, 11:55 AM · Frameworks

Fri, Jan 10

kossebau committed R32:381aec18ce77: kdevplatform: remove About data feature (authored by kossebau).
kdevplatform: remove About data feature
Fri, Jan 10, 12:23 AM

Thu, Jan 9

kossebau added a comment to D15797: [kdev-clazy] : use canonical paths.

Thanks for having had a look again, and confirming that I was not seeing things wrongly half-asleep still :) I am about to touch this code in some days anyway, and would twist things then as needed.

Thu, Jan 9, 10:10 PM · KDevelop
kossebau added a comment to D15797: [kdev-clazy] : use canonical paths.

I just came across this logic (for reasons) and wonder if the logic does what you intended with the patch:
given the const auto canonicalPathToCheck = checkPathIsFile ? pathInfo.canonicalFilePath() : QStringLiteral("");, when checkPathIsFile is false, canonicalPathToCheck is an empty string.

Thu, Jan 9, 5:13 AM · KDevelop

Wed, Jan 8

kossebau added a comment to D25883: Find qdbus command correctly.

That however needs support in kglobalaccel and whatever handels jumplist actions right? Maybe you could add your thoughts to T12063 and/or T2050

Wed, Jan 8, 4:54 PM · Spectacle
kossebau added a comment to D25883: Find qdbus command correctly.

BTW, not invoking yet another process with the qdbus executable, but instead sending off the D-Bus message drectly might also increase reaction time.

Wed, Jan 8, 4:42 PM · Spectacle
kossebau added a comment to D25883: Find qdbus command correctly.

Do I correctly understand from the previous patches that spectacle should now be single instance application? In that case it might really make more sense to investigate to use the official D-Bus Activation part of the desktop file specification instead of manual D-Bus message sending hackery. That part had been designed for such use cases from what I can tell.

Wed, Jan 8, 4:25 PM · Spectacle
kossebau added a comment to D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile.

So what I need to change in this patch ? (if I need to change a code :) )

Wed, Jan 8, 3:00 PM · Frameworks
kossebau added a comment to D25883: Find qdbus command correctly.

Looking at the actual code being touched here: Is qdbus actually a good choice here? Can it be expected to be installed by default? Would dbus-send not be the better option, as it seems part of the normal D-Bus demon implementation package?

Wed, Jan 8, 2:32 PM · Spectacle
kossebau committed R32:301b74c482c0: Port away from deprecated LINK_PUBLIC/LINK_PRIVATE (authored by kossebau).
Port away from deprecated LINK_PUBLIC/LINK_PRIVATE
Wed, Jan 8, 2:23 AM
kossebau committed R32:639170b04e27: Add kdevelop_add_private_library for consistent private library naming (authored by kossebau).
Add kdevelop_add_private_library for consistent private library naming
Wed, Jan 8, 2:23 AM

Tue, Jan 7

kossebau added a comment to D26501: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again.

KMainWindowPrivate::CompressCalls being used here still exposes a small issue, as this opens a small time window where the state is not catched before a xmlgui client change happens, so some finalizeGUI might (in theory) still use old state data, as autoSaveSettings is not yet triggered on e.g. xmlgui client removal.
Something to look into next. But this here should improve things already a lot.

Tue, Jan 7, 4:55 PM · Frameworks
kossebau requested review of D26501: KMainWindow: fix autoSaveSettings to catch QDockWidgets being shown again.
Tue, Jan 7, 4:49 PM · Frameworks
kossebau committed R32:75f2e71c4c63: Port away from deprecated ::flush (authored by kossebau).
Port away from deprecated ::flush
Tue, Jan 7, 1:07 AM
kossebau committed R32:929a7a069239: Port away from deprecated ::endl (authored by kossebau).
Port away from deprecated ::endl
Tue, Jan 7, 1:07 AM
kossebau committed R32:23ed228694be: Stream '\n' over endl where no immediate flush needed (authored by kossebau).
Stream '\n' over endl where no immediate flush needed
Tue, Jan 7, 1:07 AM

Mon, Jan 6

kossebau committed R32:ab6ddf07268c: Merge branch '5.4' (authored by kossebau).
Merge branch '5.4'
Mon, Jan 6, 10:32 PM
kossebau committed R877:9d0129dac65b: KDevelop 5.4.6 (authored by kossebau).
KDevelop 5.4.6
Mon, Jan 6, 9:57 PM
kossebau committed R32:977a688ac4e7: appdata: add releases tag (authored by kossebau).
appdata: add releases tag
Mon, Jan 6, 9:16 PM
kossebau committed R32:04a35c59c5c2: appimage: bump kf/krs/plasma versions to 5.65.0/19.12.0/5.17.4 (authored by kossebau).
appimage: bump kf/krs/plasma versions to 5.65.0/19.12.0/5.17.4
Mon, Jan 6, 9:16 PM
kossebau committed R40:965421c2adcf: Merge branch 'release/19.12' (authored by kossebau).
Merge branch 'release/19.12'
Mon, Jan 6, 6:06 PM
kossebau committed R40:e0446fd5461f: Unbreak build with cmake < 3.7 (VERSION_GREATER_EQUAL only avail >= 3.7) (authored by kossebau).
Unbreak build with cmake < 3.7 (VERSION_GREATER_EQUAL only avail >= 3.7)
Mon, Jan 6, 6:00 PM

Sun, Jan 5

kossebau committed R32:e6135037fe4e: Consistently do not close with endl with qCDebug & Co. (authored by kossebau).
Consistently do not close with endl with qCDebug & Co.
Sun, Jan 5, 4:29 PM

Fri, Jan 3

kossebau added inline comments to D24466: Use ECMGenerateExportHeader to manage deprecated API better.
Fri, Jan 3, 9:39 PM · Frameworks

Thu, Jan 2

kossebau added a comment to D26349: Install the gwenview part into kf5/parts, embed JSON metadata.

Have not tested. Looks good code-wise, is what I would have done.

Thu, Jan 2, 8:10 PM · Gwenview
kossebau committed R53:5da400b91b3b: Set version number to 5.4.6 (authored by kossebau).
Set version number to 5.4.6
Thu, Jan 2, 4:42 PM
kossebau committed R52:32583f0baf85: Set version number to 5.4.6 (authored by kossebau).
Set version number to 5.4.6
Thu, Jan 2, 4:41 PM
kossebau added a comment to D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile.

Thanks. Okay, so the old symbol is still there, and with that info I looked some more, and indeed the ::endl symbol is not declared in the header qtextstream.h, but only defined (and exported) in the source file qtextstream.cpp. Having 3 variants now not make sense to me on first look, but perhaps a result of some incomplete approach in Qt 5.14... oh well...

Thu, Jan 2, 2:33 PM · Frameworks
kossebau committed R457:b66c21fc404f: Merge branch '0.26' (authored by kossebau).
Merge branch '0.26'
Thu, Jan 2, 2:14 PM
kossebau committed R32:c32187266703: Set version number to 5.4.6 (authored by kossebau).
Set version number to 5.4.6
Thu, Jan 2, 2:08 PM
kossebau committed R32:7d2ffc79a742: Extend copyright year span to 2020 (authored by kossebau).
Extend copyright year span to 2020
Thu, Jan 2, 2:08 PM
kossebau committed R457:64d1b83d1207: Port away from deprecated ::hex (authored by kossebau).
Port away from deprecated ::hex
Thu, Jan 2, 1:48 PM
kossebau committed R457:9c4cddeee965: Port away from deprecated ::endl (authored by kossebau).
Port away from deprecated ::endl
Thu, Jan 2, 1:48 PM
kossebau committed R457:6a6035718dd1: Checksum: add CRC-64 algorithm (authored by desmu).
Checksum: add CRC-64 algorithm
Thu, Jan 2, 1:48 PM

Wed, Jan 1

kossebau added a comment to D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile.

@mlaurent Hm, is there a chance ABI got broken by that respective code in Qt 5.15 when it comes to the non-Qt-namespaced variants of the methods? Unless I misread, those deprecated ones are now in the QTextStreamFunctions namespace. And which might be source compatible, due to the using namespace QTextStreamFunctions; in the header, but does that help with the namespace being reflected in the exported symbols?

Wed, Jan 1, 11:24 PM · Frameworks
kossebau added a comment to D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile.

Ah, I looked at the "dev" branch only and missed that it is possibly already pre-Qt6, no longer base for any future Qt5 branches, right?
Indeed things look differently in the 5.15 branch, where the old variant is tagged deprecated, I now see.

Wed, Jan 1, 2:18 PM · Frameworks
kossebau added a comment to D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile.

@mlaurent Bonne année :) Hm, are we sure that endl is namespaced with Qt:: in 5.15 already? Isn't that rather Qt6 only?

Wed, Jan 1, 3:15 AM · Frameworks

Sun, Dec 29

kossebau added a comment to D25877: [KColorschemeManager] Add option to reenable following global theme.

Some comments while flying over the code due to being triggered by phab message, but no in-detail review and analysis of approach done, lack of concentration currently, sorry.

Sun, Dec 29, 4:31 PM · Frameworks
kossebau added inline comments to D25877: [KColorschemeManager] Add option to reenable following global theme.
Sun, Dec 29, 3:04 PM · Frameworks

Sat, Dec 28

kossebau committed R32:c109a789ffe9: Install knsrc files to KDE_INSTALL_KNSRCDIR with newer KNewStuff (authored by kossebau).
Install knsrc files to KDE_INSTALL_KNSRCDIR with newer KNewStuff
Sat, Dec 28, 11:46 PM
kossebau closed D26262: Use BUILD_TESTING instead of additional ENABLE_TESTING.
Sat, Dec 28, 11:37 PM
kossebau committed R849:eca2cd32d273: Use BUILD_TESTING instead of additional ENABLE_TESTING (authored by kossebau).
Use BUILD_TESTING instead of additional ENABLE_TESTING
Sat, Dec 28, 11:37 PM