kossebau (Friedrich W. H. Kossebau)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 11:52 AM (169 w, 1 d)
Availability
Available

Recent Activity

Today

kossebau committed R304:6c4fe2cf761d: Fix DownloadDialog window margins to meet general theme margins (authored by kossebau).
Fix DownloadDialog window margins to meet general theme margins
Mon, Jul 16, 8:36 AM
kossebau closed D14095: Fix DownloadDialog window margins to meet general theme margins.
Mon, Jul 16, 8:36 AM · Frameworks

Yesterday

kossebau committed R457:4994f7287428: Fix to use .h extension for generated export headers (authored by kossebau).
Fix to use .h extension for generated export headers
Sun, Jul 15, 6:07 PM
kossebau committed R457:f4100b52a464: Use more nullptr (authored by kossebau).
Use more nullptr
Sun, Jul 15, 6:07 PM
kossebau committed R457:7f75972030be: Rely on generated target export id with Okteta CMake macros (authored by kossebau).
Rely on generated target export id with Okteta CMake macros
Sun, Jul 15, 5:56 PM
kossebau added a comment to D13583: KFormat: Allow usage of quantities beyond bytes and seconds.

You can add Windows to a review, however there still needs to be a degree of responsibility by those who are actually making commits to projects (especially in the case of Frameworks).

Sun, Jul 15, 1:33 PM · Frameworks
kossebau committed R286:40c78210c79f: API dox: add @file to functions-only header to have doxygen cover those (authored by kossebau).
API dox: add @file to functions-only header to have doxygen cover those
Sun, Jul 15, 12:33 PM
kossebau requested review of D14131: Add enum alias Property::Language for typo Property::Langauge.
Sun, Jul 15, 12:06 PM · Baloo, Frameworks
kossebau updated subscribers of D12443: fix bitrate unit.

I only bumped the min deps to be able to apply some coding standards and have better known build conditions, so the unit tests could be fixed to no longer fail.

Sun, Jul 15, 9:57 AM · Baloo

Sat, Jul 14

kossebau added a comment to D13583: KFormat: Allow usage of quantities beyond bytes and seconds.

Is there some tag which can be used to pull the people in who want to support that Closed Source Microsoft platform in such cases?

Sat, Jul 14, 9:45 PM · Frameworks
kossebau added a comment to D14111: Install MIME type definition for text/x-rst ourselves for now.
In D14111#291933, @pino wrote:

NACK.
Make sure that the request for shared-mime-info (https://bugs.freedesktop.org/show_bug.cgi?id=107227) is accepted, and that is enough.

Sat, Jul 14, 3:03 PM · Frameworks
kossebau requested review of D14111: Install MIME type definition for text/x-rst ourselves for now.
Sat, Jul 14, 2:48 PM · Frameworks
kossebau accepted D14110: KFormat: correct @since tag for new KFormat::formatValue.

Thanks

Sat, Jul 14, 2:20 PM · Frameworks
kossebau added a comment to D13583: KFormat: Allow usage of quantities beyond bytes and seconds.

@bruns Please update all the "@since" to 5.49, as this will be only part of the next KF version now.

Sat, Jul 14, 2:04 PM · Frameworks

Fri, Jul 13

kossebau committed R457:2179e88b86a9: Bump version to 0.25.1 (authored by kossebau).
Bump version to 0.25.1
Fri, Jul 13, 1:02 PM
kossebau committed R457:3e45343c9f1e: Merge branch '0.25' (authored by kossebau).
Merge branch '0.25'
Fri, Jul 13, 12:16 PM
kossebau committed R457:ad22a5f5a15f: Do SafeReferenceHolder destruction printf log only in debug builds (authored by kossebau).
Do SafeReferenceHolder destruction printf log only in debug builds
Fri, Jul 13, 12:08 PM
kossebau committed R304:cb4b960bc57c: Restore accidentally removed qCDebug (authored by kossebau).
Restore accidentally removed qCDebug
Fri, Jul 13, 11:12 AM
kossebau requested review of D14095: Fix DownloadDialog window margins to meet general theme margins.
Fri, Jul 13, 10:47 AM · Frameworks

Wed, Jul 11

kossebau resigned from D14054: No version number for the libs on Android.

Sorry, but I am currently not active in Marble, so have no clue about things & needs, have to pull out here.

Wed, Jul 11, 5:38 PM · KDE Edu, Marble
kossebau committed R375:e640d955e2b4: Remove unneeded QT definitions (authored by kossebau).
Remove unneeded QT definitions
Wed, Jul 11, 2:55 PM
kossebau committed R978:3bc860b08372: Remove unneeded QT definitions (authored by kossebau).
Remove unneeded QT definitions
Wed, Jul 11, 2:25 PM
kossebau committed R358:1e9a028c9b94: Remove unneeded QT definitions (authored by kossebau).
Remove unneeded QT definitions
Wed, Jul 11, 2:22 PM
kossebau committed R40:c1c447906814: Remove deprecated QT_USE_FAST_OPERATOR_PLUS (authored by kossebau).
Remove deprecated QT_USE_FAST_OPERATOR_PLUS
Wed, Jul 11, 2:16 PM

Tue, Jul 10

kossebau committed R104:615b0353f294: Move ECM & Co. macro includes before finding Qt & KF (authored by kossebau).
Move ECM & Co. macro includes before finding Qt & KF
Tue, Jul 10, 7:42 PM
kossebau closed D14031: Move ECM & Co. macro includes before finding Qt & KF.
Tue, Jul 10, 7:42 PM · Plasma
kossebau added a comment to D14031: Move ECM & Co. macro includes before finding Qt & KF.

That unconditional reset of ECM_GLOBAL_FIND_VERSION is IMHO a flaw which should see some general fix. But no idea yet, so for now change on "our" side.

Tue, Jul 10, 5:18 PM · Plasma
kossebau requested review of D14031: Move ECM & Co. macro includes before finding Qt & KF.
Tue, Jul 10, 5:16 PM · Plasma
kossebau resigned from D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address.

Looks like proper work from a quick reading glance at the patch, thanks for providing the patch, Again, not the maintainer and no time to properly review. Needs someone from the active Plasma team to get this in. If no-one responded in the next few days, please ping people again by making another comment here and perhaps trying to poke individual members from https://phabricator.kde.org/project/members/35/ by mentioning them in the comment.

Tue, Jul 10, 3:27 PM · Plasma

Mon, Jul 9

kossebau committed R104:946613df0aa8: Use include guard matching the file name (authored by kossebau).
Use include guard matching the file name
Mon, Jul 9, 10:00 PM
kossebau committed R104:5d8901385457: Remove duplicated include (authored by kossebau).
Remove duplicated include
Mon, Jul 9, 10:00 PM
kossebau committed R104:78eb5f09b86b: Use more explicit (authored by kossebau).
Use more explicit
Mon, Jul 9, 10:00 PM
kossebau committed R104:6fbc81454eef: Use consistently override (authored by kossebau).
Use consistently override
Mon, Jul 9, 10:00 PM
kossebau committed R104:7fbcfc41d1e7: Use more nullptr (authored by kossebau).
Use more nullptr
Mon, Jul 9, 10:00 PM
kossebau committed R104:3ccc098e09b6: Remove unneeded/no longer existing include dirs (authored by kossebau).
Remove unneeded/no longer existing include dirs
Mon, Jul 9, 10:00 PM
kossebau committed R104:55533e0cb465: Remove module prefixes from Qt includes (authored by kossebau).
Remove module prefixes from Qt includes
Mon, Jul 9, 10:00 PM
kossebau committed R104:d93a85cc7874: Use non-deprecated KDEInstallDirs variables (authored by kossebau).
Use non-deprecated KDEInstallDirs variables
Mon, Jul 9, 10:00 PM
kossebau committed R104:1cbe9d412ff5: Use add_test signature where target command gets resolved to binary path (authored by kossebau).
Use add_test signature where target command gets resolved to binary path
Mon, Jul 9, 10:00 PM
kossebau committed R104:b81e025c5110: Use KF5_MIN_VERSION also for ECM, now that it's part of KF (authored by kossebau).
Use KF5_MIN_VERSION also for ECM, now that it's part of KF
Mon, Jul 9, 10:00 PM
kossebau committed R104:f51fa99e34c0: Bump min cmake version to 3.0, move cmake_minimum_required to begin (authored by kossebau).
Bump min cmake version to 3.0, move cmake_minimum_required to begin
Mon, Jul 9, 10:00 PM
kossebau committed R104:36c521215afe: Require KDE Frameworks 5.42 and Qt 5.9 (authored by kossebau).
Require KDE Frameworks 5.42 and Qt 5.9
Mon, Jul 9, 10:00 PM
kossebau committed R110:2de7f50e3a70: Merge branch 'Plasma/5.13' (authored by kossebau).
Merge branch 'Plasma/5.13'
Mon, Jul 9, 8:10 PM
kossebau added a comment to D13698: Improve ECMAddAppIconMacro..

Seems this was pushed only after the tagging of 5.48 was done on Saturday night, so too late for that release.
If this should be still part of 5.48, get in contact with dfaure so he could consider moving the tag/release pointer to include this commit, or please update the since tags to 5.49 in prepartion of the next release.

Mon, Jul 9, 11:08 AM · Build System, Frameworks
kossebau added a comment to D13995: Fix external application menu occasionally slowing down startup.

@rkflx I cannot remember anything which would need the init to be done that very point at setup, so if moving it to that later point and works for you, no objection from my side. Have not yet got around to testing things myself.

Mon, Jul 9, 10:30 AM
kossebau committed R51:d67bece22d7b: Generate code that uses nullptr & override (authored by kossebau).
Generate code that uses nullptr & override
Mon, Jul 9, 9:02 AM
kossebau closed D13938: Generate code that uses nullptr & override.
Mon, Jul 9, 9:02 AM · KDevelop

Sun, Jul 8

kossebau committed R318:64f7108d83e9: Mark PHONON_INCLUDES dirs as SYSTEM, so compiler omits them for warnings (authored by kossebau).
Mark PHONON_INCLUDES dirs as SYSTEM, so compiler omits them for warnings
Sun, Jul 8, 12:14 PM
kossebau committed R52:b33dad4cef4e: Use more nullptr (authored by kossebau).
Use more nullptr
Sun, Jul 8, 10:08 AM
kossebau committed R51:d3af61b90288: Remove module prefixes from Qt includes, in own code and generated (authored by kossebau).
Remove module prefixes from Qt includes, in own code and generated
Sun, Jul 8, 5:06 AM
kossebau committed R51:d1721b885342: Use consistently CamelCase Qt includes (authored by kossebau).
Use consistently CamelCase Qt includes
Sun, Jul 8, 5:06 AM

Sat, Jul 7

kossebau requested review of D13938: Generate code that uses nullptr & override.
Sat, Jul 7, 11:19 PM · KDevelop
kossebau committed R32:2b169a8b2660: Use more nullptr, says clang-tidy (authored by kossebau).
Use more nullptr, says clang-tidy
Sat, Jul 7, 7:36 PM
kossebau committed R32:9d73b60799ae: Use more override, says clang-tidy (authored by kossebau).
Use more override, says clang-tidy
Sat, Jul 7, 7:36 PM
kossebau resigned from D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com.
Sat, Jul 7, 2:39 PM · Plasma
kossebau updated subscribers of D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com.

Thanks for offering this for inclusion. No time to test myself currently.

Sat, Jul 7, 2:38 PM · Plasma
kossebau committed R53:8bf9b1df26cc: Use more override (authored by kossebau).
Use more override
Sat, Jul 7, 1:33 PM
kossebau committed R53:6257464055f0: Use more nullptr (authored by kossebau).
Use more nullptr
Sat, Jul 7, 1:33 PM
kossebau committed R300:59366e4f3795: Port KRun::runUrl() & KRun::run() to undeprecated API (authored by kossebau).
Port KRun::runUrl() & KRun::run() to undeprecated API
Sat, Jul 7, 12:16 AM
kossebau committed R300:109fafd3a8cc: Port KIO::Job::ui() -> KIO::Job::uiDelegate() (authored by kossebau).
Port KIO::Job::ui() -> KIO::Job::uiDelegate()
Sat, Jul 7, 12:16 AM

Fri, Jul 6

kossebau committed R236:9020e0b53f5e: Use more nullptr (authored by kossebau).
Use more nullptr
Fri, Jul 6, 8:54 PM
kossebau added a comment to D13927: autotests: Compare doubles to doubles.

Pardon for having pushed a fix directly, as I was sure about this fix for the issue :) Seems Phabricator decided it's the same commit due to being an identical patch?

Fri, Jul 6, 8:43 PM · Plasma
kossebau committed R110:03aed13d9ff3: Fix unit tests for Qt5.9: QCOMPARE has no overload for double vs. int (authored by kossebau).
Fix unit tests for Qt5.9: QCOMPARE has no overload for double vs. int
Fri, Jul 6, 8:41 PM
kossebau closed D13927: autotests: Compare doubles to doubles.
Fri, Jul 6, 8:41 PM · Plasma
kossebau committed R311:9f2fec845556: Use more nullptr (authored by kossebau).
Use more nullptr
Fri, Jul 6, 7:20 PM
kossebau committed R311:dd3aedaa0f2d: Use more override (authored by kossebau).
Use more override
Fri, Jul 6, 7:20 PM
kossebau committed R283:7118d0b8a00e: Use more nullptr (authored by kossebau).
Use more nullptr
Fri, Jul 6, 6:59 PM
kossebau committed R175:08f5e2f353cd: Use more nullptr (authored by kossebau).
Use more nullptr
Fri, Jul 6, 5:03 PM
kossebau committed R272:edea80a888c5: Use more nullptr (authored by kossebau).
Use more nullptr
Fri, Jul 6, 4:52 PM
kossebau committed R284:4a02fc8a214d: Remove unneeded moc include (authored by kossebau).
Remove unneeded moc include
Fri, Jul 6, 4:38 PM
kossebau requested review of D13926: Avoid warnings for PolkitQt5-1 headers.
Fri, Jul 6, 4:30 PM · Frameworks
kossebau committed R269:d52c2284f90d: Update D-Bus xml files to use "Out*" for signal type Qt annotations (authored by kossebau).
Update D-Bus xml files to use "Out*" for signal type Qt annotations
Fri, Jul 6, 4:11 PM
kossebau committed R235:56d9113c8ecc: Use more nullptr (authored by kossebau).
Use more nullptr
Fri, Jul 6, 3:56 PM
kossebau added a comment to D13900: Disable class-memaccess compiler warnings where not wanted.

What was the exact warning message to begin with? Can't this be fixed differently (i.e. without using the PP)?

Fri, Jul 6, 2:03 PM · KDevelop
kossebau committed R286:90a9ff80ca3b: Avoid compiler warnings for taglib headers (authored by kossebau).
Avoid compiler warnings for taglib headers
Fri, Jul 6, 7:41 AM
kossebau closed D13914: Avoid compiler warnings for taglib headers.
Fri, Jul 6, 7:41 AM · Baloo, Frameworks
kossebau requested review of D13914: Avoid compiler warnings for taglib headers.
Fri, Jul 6, 7:38 AM · Baloo, Frameworks
kossebau committed R286:ff5ff68e814e: PopplerExtractor: use directly QByteArray() args instead of 0 pointers (authored by kossebau).
PopplerExtractor: use directly QByteArray() args instead of 0 pointers
Fri, Jul 6, 7:07 AM
kossebau committed R286:fff0fa26e765: Use more nullptr (authored by kossebau).
Use more nullptr
Fri, Jul 6, 7:07 AM

Thu, Jul 5

kossebau added a comment to D13885: taglibextractor: Restore extracting audio props without tags existing.

All updated no-meta samplefiles fail for me without the patch, but as wanted do not fail with the patch. So seems fine to me :) @astippich Thanks for picking up this patch and creating proper test files.
+1 though only, given I am no maintainer.

Thu, Jul 5, 8:22 PM · Baloo, Frameworks
kossebau added inline comments to D12527: Revert R33:e88da8274468 in TextDocument to fix event handler issues.
Thu, Jul 5, 6:15 PM
kossebau requested review of D13905: Fix KTextEditor::MainWindow to outlive the KTextEditor::View objects.
Thu, Jul 5, 6:14 PM · KDevelop
kossebau added inline comments to D12527: Revert R33:e88da8274468 in TextDocument to fix event handler issues.
Thu, Jul 5, 4:12 PM
kossebau added a comment to D13900: Disable class-memaccess compiler warnings where not wanted.

Target branch: 5.2

Thu, Jul 5, 10:08 AM · KDevelop
kossebau requested review of D13900: Disable class-memaccess compiler warnings where not wanted.
Thu, Jul 5, 10:06 AM · KDevelop

Wed, Jul 4

kossebau committed R318:85d7a8a2f60f: Use more nullptr (authored by kossebau).
Use more nullptr
Wed, Jul 4, 10:14 PM
kossebau committed R824:15f73f3ae544: Fix typos in comments (authored by kossebau).
Fix typos in comments
Wed, Jul 4, 10:05 PM
kossebau committed R824:7b4ceebe7d4e: Remove module prefixes from Qt includes (authored by kossebau).
Remove module prefixes from Qt includes
Wed, Jul 4, 10:05 PM
kossebau committed R824:d5a24e791a45: Use consistently override (authored by kossebau).
Use consistently override
Wed, Jul 4, 10:05 PM
kossebau committed R824:fe73d5d24c98: Use more explicit (authored by kossebau).
Use more explicit
Wed, Jul 4, 10:05 PM
kossebau committed R824:4e5ca0a7479e: Use nullptr (authored by kossebau).
Use nullptr
Wed, Jul 4, 10:05 PM
kossebau committed R824:95581e807a20: Bump min Qt/KF versions to those of dolphin (authored by kossebau).
Bump min Qt/KF versions to those of dolphin
Wed, Jul 4, 9:44 PM
kossebau closed D13886: Bump min Qt/KF versions to those of dolphin.
Wed, Jul 4, 9:44 PM · Baloo
kossebau added a comment to D13885: taglibextractor: Restore extracting audio props without tags existing.

I just checked all the no-meta files. The reason that they did not cause the tests to fail is that they still have at least one tag defined that is not read (encoder settings for example).

Wed, Jul 4, 8:37 PM · Baloo, Frameworks
kossebau added a comment to D11897: Expose group information to Dolphin's Information panel, tooltips, etc.

After investigating, it looks like this failure may be an installation issue on the build machine. The test is failing there because the new group property is inappropriately visible, but the approved change expressly covered this case by adding it to the baloofileinformationrc blacklist and bumping the version, which should have had the effect of not making the property visible. I suspect baloofileinformationrc did not get updated on the build machine the way it did on my local machine, where the test passes.

@bcooksley, any chance you can take a look at this?

Wed, Jul 4, 4:32 PM · Baloo
kossebau requested review of D13886: Bump min Qt/KF versions to those of dolphin.
Wed, Jul 4, 3:57 PM · Baloo
kossebau requested review of D13885: taglibextractor: Restore extracting audio props without tags existing.
Wed, Jul 4, 3:37 PM · Baloo, Frameworks
kossebau added a comment to D11897: Expose group information to Dolphin's Information panel, tooltips, etc.

Any chance this change broke the unit test filemetadataitemcounttest, due to new items?
See https://build.kde.org/view/Applications/job/Applications%20baloo-widgets%20kf5-qt5%20SUSEQt5.9/34/

Wed, Jul 4, 12:43 PM · Baloo
kossebau committed R457:793bacd1c439: Merge branch '0.25' (authored by kossebau).
Merge branch '0.25'
Wed, Jul 4, 12:08 PM
kossebau committed R457:9d69bdf88680: Set also QT_NO_NARROWING_CONVERSIONS_IN_CONNECT (authored by kossebau).
Set also QT_NO_NARROWING_CONVERSIONS_IN_CONNECT
Wed, Jul 4, 12:08 PM

Tue, Jul 3

kossebau accepted D13874: textplugin: Fix missing QTextStream include.
Tue, Jul 3, 8:58 PM · Plasma