- User Since
- Apr 18 2015, 11:52 AM (179 w, 23 h)
New version also checks launch configuration type and starts analysis only for native applications.
Fri, Sep 21
- use custom explicit checkToolsInPath code for qdbus variants
- avoid error print from "which" in kdevelop!
Thanks. Patch fine with me, feature still works.
(and now that I know about it I also see the unused modulo pixels from the maxheight calculation ;) something to be solved on a boring day in need for entertainment)
With asserts enabled, I get a crash with this on opening the settings or sometimes only when selecting Objective-C in the formatting settings
kdevelop: /home/koder/Kode/kdegit/kf5/extragear/kdevelop/kdevelop/plugins/astyle/3rdparty/libastyle/ASFormatter.cpp:3841: std::__cxx11::string astyle::ASFormatter::peekNextText(const string&, bool, std::shared_ptr<astyle::ASPeekStream>) const: Assertion `sourceIterator->getPeekStart() == 0 || streamArg != nullptr' failed.
Thu, Sep 20
Please also fix the possibly actual bug, which is
const int maximumWidth = rect.width() / _items.size();
and its counterpart not taking the button spacing into account.
Wed, Sep 19
Code looks fine to me, modulo all the comments made, and works where I tested it. Please also update the summary text and title of the patch.
Tue, Sep 18
Just FYI, as I was added, I currently have no time reserved for document related code work:
I would like to first try to find the reason why the condition bool shrink = rect.width() < sizeHint().width(); seems to still lead us here into a situation where only "smallItems" exists?
I would suspect some rounding errors.
Mon, Sep 17
also add todo about merging KTextEditor::AnnotationViewInterfaceV2 into KTextEditor::AnnotationViewInterface
Given this is a bug fix and thus should also go to 5.3 branch. could you try a version with no new strings that need translation? Is there a chance existing strings can be reused (from the same catalog, thus used elsewhere in the plugin)?
Otherwise we need to ask the translators for a string freeze exception.
If you have a chance/time, please considerupdating the patch by adding some samples for the new language types to AStylePlugin::previewText(SourceFormatterStyle, QMimeType).
Currently that one uses C++ code for the preview, which surely is a non-pleasing experience.
Sun, Sep 16
Update to Dominik's first review
update to also use Q_EMIT
Actually will update this patch to also include Q_EMIT, update coming soon here.