kossebau (Friedrich W. H. Kossebau)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 11:52 AM (221 w, 2 d)
Availability
Available

Recent Activity

Yesterday

kossebau updated the diff for D22424: TextDocument: remove actions from contextmenu on hide already.

update to first review feedback

Mon, Jul 15, 9:33 PM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

Thanks for first review & testing.

Mon, Jul 15, 9:33 PM · KDevelop
kossebau committed R450:3d753085a932: Add wrap text attribute in choice.ui (authored by kossebau).
Add wrap text attribute in choice.ui
Mon, Jul 15, 7:57 PM
kossebau closed D17100: Add wrap text attribute in choice.ui.
Mon, Jul 15, 7:57 PM
kossebau added a comment to D22477: Add a config to only show completions matching word beginning.

Default is false, so does not change behaviour unless someone toggles the switch, right?

Mon, Jul 15, 7:29 PM · Frameworks, Kate
kossebau abandoned D5210: Proper CUDA handling.

Closing due to lack of further interest by anyone for long time

Mon, Jul 15, 6:27 PM
kossebau commandeered D5210: Proper CUDA handling.
Mon, Jul 15, 6:23 PM
kossebau committed R32:a06faa198fa0: Merge branch '5.3' (authored by kossebau).
Merge branch '5.3'
Mon, Jul 15, 6:17 PM
kossebau committed R32:7f636275a2e4: sublime: fix crash on undocking toolviews with Qt 5.13 (authored by kossebau).
sublime: fix crash on undocking toolviews with Qt 5.13
Mon, Jul 15, 6:06 PM
kossebau committed R32:aad6790c7f3b: appimage: do not refetch appimagetool if already present (authored by kossebau).
appimage: do not refetch appimagetool if already present
Mon, Jul 15, 11:33 AM
kossebau committed R32:687f4255a147: appimage: fix typo in README.md (authored by kossebau).
appimage: fix typo in README.md
Mon, Jul 15, 11:33 AM

Sat, Jul 13

kossebau committed R32:e38e86fe74d3: Merge branch '5.3' (authored by kossebau).
Merge branch '5.3'
Sat, Jul 13, 1:52 PM
kossebau committed R32:e2bea1a148bd: kdevplatform/interfaces: fix missing explicit QVector include (authored by kossebau).
kdevplatform/interfaces: fix missing explicit QVector include
Sat, Jul 13, 1:51 PM
kossebau committed R32:fcd66afaf8a4: Fix kdevelopui.rc: bump version as required by string context changes (authored by kossebau).
Fix kdevelopui.rc: bump version as required by string context changes
Sat, Jul 13, 1:51 PM

Fri, Jul 12

kossebau committed R32:ef7e08f6b106: Merge branch '5.3' (authored by kossebau).
Merge branch '5.3'
Fri, Jul 12, 5:16 PM
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

Reasons why currently I favour this over D16882:

  • slightly less complex, as it does more what one expects, adding & removing actions on show & hide
  • no global static
Fri, Jul 12, 4:21 PM · KDevelop
kossebau added a comment to D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.

Please check the earlier discussion; IIRC there is a reliability problem with that signal, and I did try reverting to its use before coming up with the current solution.

Fri, Jul 12, 3:39 PM · KDevelop
kossebau added a comment to D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.

While trying to understand the problem, I found that perhaps we could still revert to using the aboutToHide signal, with proper boundaroes.
So alternative solution proposal up as D22424

Fri, Jul 12, 3:13 PM · KDevelop
kossebau requested review of D22424: TextDocument: remove actions from contextmenu on hide already.
Fri, Jul 12, 3:10 PM · KDevelop

Thu, Jul 11

kossebau committed R32:1a68e1e97bdb: appimage: bump versions of dependencies to newer, update howto (authored by kossebau).
appimage: bump versions of dependencies to newer, update howto
Thu, Jul 11, 5:03 PM
kossebau committed R32:efb70121bf0e: shell: overwrite katectagsplugin to be disabled by default (authored by kossebau).
shell: overwrite katectagsplugin to be disabled by default
Thu, Jul 11, 3:18 PM
kossebau added a comment to D22062: Addition of php script output patterns. Initial development..

Hm, seeing all this hardcoded code for optional plugins, this calls out for someone to look into making this something pulled in from the language plugins instead :) Not your fault, just mentioning the obvious. So should be fine to just add here.

Thu, Jul 11, 2:41 PM · KDevelop
kossebau added reviewers for D22062: Addition of php script output patterns. Initial development.: KDevelop, pprkut.
Thu, Jul 11, 2:33 PM · KDevelop

Wed, Jul 10

kossebau added inline comments to D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator.
Wed, Jul 10, 6:50 PM · Frameworks

Tue, Jul 9

kossebau committed R32:bee988a1b680: Translate relative paths of input files to absolute ones (authored by pprkut).
Translate relative paths of input files to absolute ones
Tue, Jul 9, 10:55 AM
kossebau committed R32:3b5b643f1d30: [welcome page] Port to QtQuick Controls 2 (authored by kossebau).
[welcome page] Port to QtQuick Controls 2
Tue, Jul 9, 9:03 AM
kossebau committed R32:4b5ff487f926: Document tree view close on middle button (authored by tristanp).
Document tree view close on middle button
Tue, Jul 9, 8:56 AM
kossebau closed D22160: Document tree view close on middle button.
Tue, Jul 9, 8:56 AM · KDevelop

Mon, Jul 8

kossebau resigned from D15814: show all borders for pop up windows in a dock.

No time for Plasma in the next months reserved, so withdrawing as reviewer/commenter to clear my todo list

Mon, Jul 8, 1:28 PM · Frameworks
kossebau added a comment to D16218: [KDevelop/Core]: safe signal-handler implementation.

Sh@@t, sorry, I allowed some unrelated (and potential future) changes to pollute this version. Will fix tomorrow.

Mon, Jul 8, 1:17 PM · KDevelop
kossebau added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Ping? Please keep hammering the iron while hot :)

Mon, Jul 8, 1:14 PM · KDevelop
kossebau added inline comments to D22158: Navigation context uses theme color..
Mon, Jul 8, 1:13 PM · KDevelop
kossebau added a comment to D8158: KDevelop: decorate patch version string in development builds.

@rjvbb Hi, please Abandon this review, as the reply has been that this should be solved on KDE Frameworks level, in KAboutData (as well as with respective new ECM module for getting the VCS/git revision info into the buildsystem).

Mon, Jul 8, 1:06 PM · KDevelop
kossebau added a comment to D5210: Proper CUDA handling.

Will close next week given no-one has cared for > 2 years.

Mon, Jul 8, 12:59 PM
kossebau added a comment to D5491: Improve detection of builtin defines from compiler command.

Will close next week given no-one has cared for 2 years and the affected code also changed.

Mon, Jul 8, 12:58 PM
kossebau added a comment to D6184: restore horizontal scrollbar in the project manager plugin.

@rjvbb Hi, please use the "Abandon this Revision" action, given that this patch/feature was not accepted, so the list of patches to review is not cluttered for everyone.

Mon, Jul 8, 12:54 PM · KDevelop
kossebau added a comment to D22160: Document tree view close on middle button.

@tristanp Hi. You do not have push rights for KDE code reposistories, correct? So someone else would need to push for you then. Okay to extend your author name in the commit message to "Tristan Porteries"?

Mon, Jul 8, 12:41 PM · KDevelop

Sun, Jul 7

kossebau committed R637:fdec0590dd22: Build with QT_NO_CAST_FROM_ASCII (authored by kossebau).
Build with QT_NO_CAST_FROM_ASCII
Sun, Jul 7, 1:12 PM
kossebau committed R637:c869f1091ade: Enforce some more modern Qt code (authored by kossebau).
Enforce some more modern Qt code
Sun, Jul 7, 1:11 PM
kossebau committed R637:481b2a817144: Bump Qt/KF/KDevPlatform min versions to those of KDevelop master (authored by kossebau).
Bump Qt/KF/KDevPlatform min versions to those of KDevelop master
Sun, Jul 7, 1:11 PM
kossebau committed R637:38c611396e3a: Build with QT_NO_URL_CAST_FROM_STRING (authored by kossebau).
Build with QT_NO_URL_CAST_FROM_STRING
Sun, Jul 7, 1:11 PM
kossebau committed R637:5f052245a808: No need to add ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH already (authored by kossebau).
No need to add ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH already
Sun, Jul 7, 1:11 PM
kossebau committed R637:0a4d78c2c977: Bump min cmake version to 3.0 (authored by kossebau).
Bump min cmake version to 3.0
Sun, Jul 7, 1:11 PM
kossebau committed R637:5434153f73c4: Remove unneeded QFileDialog::setConfirmOverwrite(true), default is true (authored by kossebau).
Remove unneeded QFileDialog::setConfirmOverwrite(true), default is true
Sun, Jul 7, 1:11 PM
kossebau committed R637:bd0269aa7798: Mark unused arguments as such (authored by kossebau).
Mark unused arguments as such
Sun, Jul 7, 1:11 PM

Sat, Jul 6

kossebau committed R32:6a5b5d0a3da0: Remove unused variable left-over from patch review changes (authored by kossebau).
Remove unused variable left-over from patch review changes
Sat, Jul 6, 6:23 PM
kossebau committed R32:b909af0a389e: Remove redundant std::move statement in return statement (authored by kossebau).
Remove redundant std::move statement in return statement
Sat, Jul 6, 6:23 PM
kossebau committed R32:33307072d87e: debuggercommon: have substructs of Value & Record set type via constructor (authored by kossebau).
debuggercommon: have substructs of Value & Record set type via constructor
Sat, Jul 6, 6:23 PM
kossebau committed R32:67c9846ebf78: Use reinterpret_cast<void+> for memcpy to show gcc memory access by design (authored by kossebau).
Use reinterpret_cast<void+> for memcpy to show gcc memory access by design
Sat, Jul 6, 2:00 PM
kossebau committed R32:0342ae5bfe42: Follow KTextEditor changes for hidpi rendering of icon border (authored by kossebau).
Follow KTextEditor changes for hidpi rendering of icon border
Sat, Jul 6, 2:00 PM
kossebau committed R32:5b7231b1a5ec: Fix destructive iterating over marks from KTextEditor::MarkInterface (authored by kossebau).
Fix destructive iterating over marks from KTextEditor::MarkInterface
Sat, Jul 6, 2:00 PM
kossebau updated subscribers of R39:00ee8f15e627: Fix bookmark icon display on icon border with low dpi.

@cullmann @dhaumann Hi, please pardon my direct pushing of this and the one before, this are emergency fixes for issues only found the last hour and due to tagging being done today/tomorrow, and I am pretty sure about these fixes.
Please post-push review :) Future changes should come as normal review requests again.

Sat, Jul 6, 1:10 PM
kossebau committed R39:00ee8f15e627: Fix bookmark icon display on icon border with low dpi (authored by kossebau).
Fix bookmark icon display on icon border with low dpi
Sat, Jul 6, 1:08 PM
kossebau committed R39:dcc996121da2: Fix action "Show Icon Border" to toggle border again (authored by kossebau).
Fix action "Show Icon Border" to toggle border again
Sat, Jul 6, 11:52 AM
kossebau added a comment to D20489: [KIO] Make it compile without foreach (Step 1).

@mlaurent Hi, sorry to default to you here, but given the risks with foreach porting (I have done my own share of mistakes in such despite all concentration :) ) https://bugs.kde.org/show_bug.cgi?id=408801 might be triggered by one of this here, have not yet investigated more.
With you mind perhaps still with memories about the code from the foreach porting work, could you given that bug a look where this might be due to containers being modified in a range-for loop?

Sat, Jul 6, 10:17 AM · Frameworks

Fri, Jul 5

kossebau closed T11177: ASan backtrace with FreeBSD CI builds does not show source line numbers as Resolved.

Thanks for your work, log now as wanted, thus closing as resolved

Fri, Jul 5, 10:35 PM · build.kde.org
kossebau added a comment to D22158: Navigation context uses theme color..

Not sure yet about all color mappings, that might need some more thinking, at least on a quick test across themes that resulted in quite some unreadable variants. Will play a bit during the upcoming WE.

Fri, Jul 5, 6:52 PM · KDevelop
kossebau added a comment to D22158: Navigation context uses theme color..

Interesting approach, might work out, thanks for doing this :)

Fri, Jul 5, 4:07 PM · KDevelop
kossebau added a comment to D22267: ContainmentAction: Fix loading from KPlugin.

FTR now that all dep builds are updated, the plasma-frameworks part of the Plasma product also all passed, so all as it should.

Fri, Jul 5, 1:49 PM · Frameworks
kossebau created T11177: ASan backtrace with FreeBSD CI builds does not show source line numbers.
Fri, Jul 5, 1:07 PM · build.kde.org
kossebau committed R32:b3dbf57a20a4: Note visibilty tag also with signature of friend-declared method (authored by kossebau).
Note visibilty tag also with signature of friend-declared method
Fri, Jul 5, 12:17 PM
kossebau committed R32:70feef1da5a4: Use reinterpret_cast<void+> for memcpy to show gcc memory access by design (authored by kossebau).
Use reinterpret_cast<void+> for memcpy to show gcc memory access by design
Fri, Jul 5, 11:26 AM
kossebau added a comment to D22267: ContainmentAction: Fix loading from KPlugin.

Hi. Seems CI is not happy about something here: https://build.kde.org/view/Failing/job/Plasma/job/plasma-framework/ please have a look.

Fri, Jul 5, 11:13 AM · Frameworks
kossebau committed R499:b4855c6f8cca: Note new deps for gwenview in correct file (authored by kossebau).
Note new deps for gwenview in correct file
Fri, Jul 5, 10:49 AM
kossebau added a comment to D22265: KPluginMetaData: use Q_DECLARE_METATYPE.

This runs the chance to break some 3rd-party software which also calls the Q_DECLARE_METATYPE(KPluginMetaData) macro.
Any chance this could be moved to the place that needs this for now, and perhaps add a KF6 TODO instead?

Fri, Jul 5, 10:38 AM · Frameworks
kossebau committed R499:b7cf8c3f80b9: Also note move of yakuake in branch definition file (authored by kossebau).
Also note move of yakuake in branch definition file
Fri, Jul 5, 10:33 AM
kossebau added a comment to D22267: ContainmentAction: Fix loading from KPlugin.

Hi. Seems CI is not happy about something here: https://build.kde.org/view/Failing/job/Plasma/job/plasma-framework/ please have a look.

Fri, Jul 5, 10:30 AM · Frameworks

Thu, Jul 4

kossebau committed R32:f322936fbf63: Merge branch '5.3' (authored by kossebau).
Merge branch '5.3'
Thu, Jul 4, 11:10 PM
kossebau committed R32:c5a9c51c7a28: quickopen: port foreach -> range-based for (authored by kossebau).
quickopen: port foreach -> range-based for
Thu, Jul 4, 11:10 PM
kossebau committed R32:8cb82487d59b: clang: port foreach -> range-based for (authored by kossebau).
clang: port foreach -> range-based for
Thu, Jul 4, 11:10 PM
kossebau committed R32:fdd06e1d67e8: Port from deprecated QComboBox::autoCompletion -> QComboBox::completer (authored by kossebau).
Port from deprecated QComboBox::autoCompletion -> QComboBox::completer
Thu, Jul 4, 11:10 PM
kossebau committed R32:afe0adbd387f: ScratchpadView: use this as context object in connection to lambdas (authored by kossebau).
ScratchpadView: use this as context object in connection to lambdas
Thu, Jul 4, 11:10 PM
kossebau committed R32:e8793ce3bafe: StatusbarProgressWidget: fallback to baseclass eventfilter to behave well (authored by kossebau).
StatusbarProgressWidget: fallback to baseclass eventfilter to behave well
Thu, Jul 4, 11:10 PM
kossebau committed R32:3e7b3655fa58: duchain: add some explicit default destructors to meet rule-of-three (authored by kossebau).
duchain: add some explicit default destructors to meet rule-of-three
Thu, Jul 4, 10:24 PM
kossebau committed R32:89621d1b2fcb: DUChainItemSystem: hide all constructors and class copy methods (authored by kossebau).
DUChainItemSystem: hide all constructors and class copy methods
Thu, Jul 4, 10:24 PM
kossebau committed R32:43ece7f7b365: Use "= delete" to get rid of copy constructor, not private section (authored by kossebau).
Use "= delete" to get rid of copy constructor, not private section
Thu, Jul 4, 10:24 PM
kossebau committed R32:95ea14ecdcc1: Item classes for ItemRepository: expl. delete copy-assignment operator (authored by kossebau).
Item classes for ItemRepository: expl. delete copy-assignment operator
Thu, Jul 4, 10:24 PM
kossebau committed R32:97aa5c2ce587: Use "= delete" to get rid of assignment operator, not private section (authored by kossebau).
Use "= delete" to get rid of assignment operator, not private section
Thu, Jul 4, 10:24 PM
kossebau committed R32:6ffb49f00998: duchain object classes: expl. delete copy-assignment operator (authored by kossebau).
duchain object classes: expl. delete copy-assignment operator
Thu, Jul 4, 10:24 PM
kossebau committed R32:2dea8fe29295: duchain type classes: expl. delete copy-assignment operator (authored by kossebau).
duchain type classes: expl. delete copy-assignment operator
Thu, Jul 4, 10:24 PM
kossebau committed R32:70dccaf704a4: Add some explicit default destructors (authored by kossebau).
Add some explicit default destructors
Thu, Jul 4, 10:24 PM
kossebau committed R32:aa5613b09d46: Explicitly disable copies for more classes (using Q_DISABLE_COPY) (authored by kossebau).
Explicitly disable copies for more classes (using Q_DISABLE_COPY)
Thu, Jul 4, 10:24 PM
kossebau committed R32:409e81f98746: Pass enum arg by value (authored by kossebau).
Pass enum arg by value
Thu, Jul 4, 10:24 PM
kossebau committed R32:5e05cf4f1a0f: More const ref with args with non-trivial types (authored by kossebau).
More const ref with args with non-trivial types
Thu, Jul 4, 10:24 PM
kossebau committed R32:93cb30d79380: Pass more QChar args as value (authored by kossebau).
Pass more QChar args as value
Thu, Jul 4, 10:24 PM
kossebau committed R32:861230e3aafb: KDevelop::IDocument: use via Q_INTERFACES (authored by kossebau).
KDevelop::IDocument: use via Q_INTERFACES
Thu, Jul 4, 9:43 PM
kossebau committed R32:d6139ff7c90f: KDevelop::IOutputViewModel: use via Q_INTERFACES (authored by kossebau).
KDevelop::IOutputViewModel: use via Q_INTERFACES
Thu, Jul 4, 9:43 PM
kossebau committed R32:307442fc8bbd: KDevelop::QuickOpenFileSetInterface: use via Q_INTERFACES (authored by kossebau).
KDevelop::QuickOpenFileSetInterface: use via Q_INTERFACES
Thu, Jul 4, 9:43 PM
kossebau committed R32:b9f19711381a: KDevelop::QuickOpenEmbeddedWidgetInterface: use via Q_INTERFACES (authored by kossebau).
KDevelop::QuickOpenEmbeddedWidgetInterface: use via Q_INTERFACES
Thu, Jul 4, 9:43 PM
kossebau committed R32:1f0bb4839fef: Use Q_OBJECT macro with more QObject subclasses (authored by kossebau).
Use Q_OBJECT macro with more QObject subclasses
Thu, Jul 4, 9:43 PM
kossebau committed R32:e2814a3c20c0: Use more qobject_cast with QObject subclasses (authored by kossebau).
Use more qobject_cast with QObject subclasses
Thu, Jul 4, 9:43 PM
kossebau committed R32:2b8a45fd0e05: Consistently use qobject_cast with declared interfaces for QObject subclasses (authored by kossebau).
Consistently use qobject_cast with declared interfaces for QObject subclasses
Thu, Jul 4, 9:43 PM
kossebau added a comment to D11234: [DrKonqi] Show debug button when KDevelop session is running.

Ping?

Thu, Jul 4, 2:09 PM · Plasma
kossebau resigned from D15503: Show photo orientation as icon.

No maintainer here, also no opinion :) Thus resigning to not keep wrong hopes for feedback from me.

Thu, Jul 4, 2:04 PM · Baloo
kossebau accepted D17100: Add wrap text attribute in choice.ui.

Hi. I am sorry, somehow missed this review request in the long list on phabricator before. Change looks good to me. Can you push this change yourself, or shall I? What author credentials would you like with the commit (name & email address)?

Thu, Jul 4, 2:03 PM
kossebau resigned from D19330: fix failing DMS-String parsing on windows.

Currently no time for Marble, so resigning.

Thu, Jul 4, 1:59 PM · KDE Edu, Marble

Tue, Jul 2

kossebau committed R32:2fa7d3e96203: welcome page: do not add currently unused qml pages to qrc data (authored by kossebau).
welcome page: do not add currently unused qml pages to qrc data
Tue, Jul 2, 11:30 PM
kossebau committed R32:bbd6966b262b: qmljs: silence deprecated-declarations warnings for qtcreator code copy (authored by kossebau).
qmljs: silence deprecated-declarations warnings for qtcreator code copy
Tue, Jul 2, 3:54 PM
kossebau committed R32:f607f6e47e8f: Remove unneeded duplicated connection to deprecated variant of signal (authored by kossebau).
Remove unneeded duplicated connection to deprecated variant of signal
Tue, Jul 2, 3:46 PM
kossebau committed R32:5bc41cc78ad6: Port deprecated QComboBox::currentIndexChanged(QString) -> currentTextChanged (authored by kossebau).
Port deprecated QComboBox::currentIndexChanged(QString) -> currentTextChanged
Tue, Jul 2, 3:46 PM