kossebau (Friedrich W. H. Kossebau)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 11:52 AM (196 w, 3 d)
Availability
Available

Recent Activity

Today

kossebau added a comment to T9356: AppImage Awarness in plasma Desktop.

Dolphin side panel to show AppImage information.

Tue, Jan 22, 10:33 AM · Baloo, VDG, Plasma, Dolphin
kossebau added a comment to D18450: Add extractor for AppImage files.

Example screenshot:

Tue, Jan 22, 9:57 AM · Baloo, Frameworks
kossebau requested review of D18450: Add extractor for AppImage files.
Tue, Jan 22, 9:55 AM · Baloo, Frameworks

Yesterday

kossebau committed R286:7527819caf14: Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
Mon, Jan 21, 6:54 PM
kossebau committed R286:30a7cec09e2e: Use more https in links (authored by kossebau).
Use more https in links
Mon, Jan 21, 6:54 PM
kossebau requested review of D18434: exiv2extractor: add support for bmp, gif, webp, tga.
Mon, Jan 21, 6:38 PM · Baloo, Frameworks
kossebau committed R39:ef652c0821a2: Consistently use override, not Q_DECL_OVERRIDE (authored by kossebau).
Consistently use override, not Q_DECL_OVERRIDE
Mon, Jan 21, 10:58 AM
kossebau added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

For done code this warning is pointless and negative. I invite you to work with a code base like KWin where it is more important to have a working git blame than protection for theoretical problems. Nobody will be able to guarantee that a 500+ change to add override won't break. Human errors happen, nobody will be able to review something like that. Addressing this warning by adding override all over our legacy code base has a serious risk.

I'm seriously pissed that this is forced on us and we have to change code.

I'm totally fine with this warning for new code and new projects. But let projects opt in for it instead of forcing it on legacy code bases.

Mon, Jan 21, 8:42 AM · Build System, Frameworks

Sun, Jan 20

kossebau committed R457:ba0c2a92b6fc: Install headers in additionally package namespaced dirs (authored by kossebau).
Install headers in additionally package namespaced dirs
Sun, Jan 20, 7:19 PM
kossebau committed R457:7f29c8ccfb1c: Merge branch '0.25' (authored by kossebau).
Merge branch '0.25'
Sun, Jan 20, 7:19 PM
kossebau committed R457:ed2a2d3935eb: Use enum Okteta::OffsetFormat::Hexadecimal, not a magic number (authored by kossebau).
Use enum Okteta::OffsetFormat::Hexadecimal, not a magic number
Sun, Jan 20, 5:46 PM
kossebau committed R32:324a50ff833e: Merge branch '5.3' (authored by kossebau).
Merge branch '5.3'
Sun, Jan 20, 12:57 PM
kossebau committed R32:932d0046ddc9: kdevplatform: fix missing installation of problemstore.h (authored by kossebau).
kdevplatform: fix missing installation of problemstore.h
Sun, Jan 20, 12:54 PM
kossebau committed R50:23d13c567d58: ui.rc files: use <gui> instead of deprecated <kpartgui> (authored by kossebau).
ui.rc files: use <gui> instead of deprecated <kpartgui>
Sun, Jan 20, 8:51 AM
kossebau committed R50:8471cee3a5ae: Merge branch '0.7' (authored by kossebau).
Merge branch '0.7'
Sun, Jan 20, 8:51 AM
kossebau committed R50:23491cb22320: Do not duplicate work done by KAboutData::setupCommandLine() (authored by kossebau).
Do not duplicate work done by KAboutData::setupCommandLine()
Sun, Jan 20, 8:51 AM
kossebau committed R50:94e6b7db61bf: Use override (authored by kossebau).
Use override
Sun, Jan 20, 8:51 AM
kossebau committed R50:a60256a8aa20: Use nullptr (authored by kossebau).
Use nullptr
Sun, Jan 20, 8:51 AM
kossebau committed R50:3a3469e6a1d2: Remove explicit enable_testing(), duplicated from KDECMakeSettings (authored by kossebau).
Remove explicit enable_testing(), duplicated from KDECMakeSettings
Sun, Jan 20, 8:51 AM
kossebau committed R50:4df8b1177beb: Bump min cmake version to 3.0 (authored by kossebau).
Bump min cmake version to 3.0
Sun, Jan 20, 8:51 AM
kossebau committed R50:e9e9fa467a1b: Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
Sun, Jan 20, 8:51 AM
kossebau committed R50:92e3cf6209ac: Properly support BUILD_TESTING (authored by kossebau).
Properly support BUILD_TESTING
Sun, Jan 20, 8:47 AM
kossebau committed R50:51788c6f2956: Fix window icon for non-desktopfile WM to own icon "massif-visualizer" (authored by kossebau).
Fix window icon for non-desktopfile WM to own icon "massif-visualizer"
Sun, Jan 20, 8:47 AM
kossebau committed R300:1b8bcda82423: Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
Sun, Jan 20, 7:48 AM
kossebau committed R313:f476e8b2d8bf: Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
Sun, Jan 20, 7:36 AM
kossebau committed R874:9d7c7fab6537: Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
Sun, Jan 20, 7:31 AM
kossebau committed R51:8752cb3e6a48: Move KDECMakeSettings & KDEInstallDirs before other cmake includes (authored by kossebau).
Move KDECMakeSettings & KDEInstallDirs before other cmake includes
Sun, Jan 20, 7:27 AM
kossebau committed R51:200884d13301: Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
Sun, Jan 20, 7:27 AM
kossebau committed R114:2a5461b480c5: [potd] Remove explicit use of ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH (authored by kossebau).
[potd] Remove explicit use of ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH
Sun, Jan 20, 7:10 AM
kossebau committed R39:6951f9d22262: Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
Sun, Jan 20, 7:07 AM
kossebau committed R308:a752a69bcd62: Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
Sun, Jan 20, 7:02 AM
kossebau committed R306:55a9516118be: Remove explicit include of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit include of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
Sun, Jan 20, 6:59 AM
kossebau committed R32:500d5a00efcf: meson: unbreak non-C++14 builds. use QOverload<>::of, not qOverload (authored by kossebau).
meson: unbreak non-C++14 builds. use QOverload<>::of, not qOverload
Sun, Jan 20, 5:48 AM

Sat, Jan 19

kossebau committed R230:ce72fd4265b4: Remove unneeded explicit ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH (authored by kossebau).
Remove unneeded explicit ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH
Sat, Jan 19, 8:31 PM
kossebau committed R230:0161d14dd63b: Bump min cmake dep to 3.0 (authored by kossebau).
Bump min cmake dep to 3.0
Sat, Jan 19, 8:31 PM
kossebau committed R242:fcfc201c8dc0: Use more https in links (& update a few urls) (authored by kossebau).
Use more https in links (& update a few urls)
Sat, Jan 19, 3:40 PM
kossebau committed R242:f423f65bfd5f: [Wallpaper templates] Add missing Comment= entry to desktop file (authored by kossebau).
[Wallpaper templates] Add missing Comment= entry to desktop file
Sat, Jan 19, 3:40 PM
kossebau committed R242:1eb3b7ccaac3: Remove explicit use of ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH
Sat, Jan 19, 3:40 PM
kossebau committed R437:c57e9bc5f421: Use more https in links (authored by kossebau).
Use more https in links
Sat, Jan 19, 3:02 PM
kossebau committed R437:3c63cf956369: Remove unneeded explicit use of ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH (authored by kossebau).
Remove unneeded explicit use of ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH
Sat, Jan 19, 3:02 PM
kossebau committed R437:2916395ea977: Remove Qt4 vars QT_DEFINITIONS & QT_QTDBUS_DEFINITIONS (authored by kossebau).
Remove Qt4 vars QT_DEFINITIONS & QT_QTDBUS_DEFINITIONS
Sat, Jan 19, 3:02 PM
kossebau committed R373:b00be30187f4: Use more override (authored by kossebau).
Use more override
Sat, Jan 19, 2:49 PM
kossebau committed R373:f47cc0753847: Use CamelCase kf includes (authored by kossebau).
Use CamelCase kf includes
Sat, Jan 19, 2:49 PM
kossebau committed R373:b9b0bb1a8dcd: Use more nullptr (authored by kossebau).
Use more nullptr
Sat, Jan 19, 2:49 PM
kossebau committed R373:7ace7ae5ea26: Remove explicit use of ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH
Sat, Jan 19, 2:49 PM
kossebau committed R383:d1c5b47d244b: Remove unneeded explicit ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH (authored by kossebau).
Remove unneeded explicit ECM_KDE_MODULE_DIR, part of ECM_MODULE_PATH
Sat, Jan 19, 2:33 PM
kossebau committed R49:4f42c1ee672e: Use <gui> instead of deprecated <kpartgui> (authored by kossebau).
Use <gui> instead of deprecated <kpartgui>
Sat, Jan 19, 2:22 PM
kossebau committed R436:ba0e45362675: Fix DOCTYPE root name of ui.rc file (authored by kossebau).
Fix DOCTYPE root name of ui.rc file
Sat, Jan 19, 2:21 PM
kossebau committed R436:3d8e8ed30505: Use more https in links (authored by kossebau).
Use more https in links
Sat, Jan 19, 2:17 PM
kossebau committed R436:21d4b9fd127c: Do not repeat work of KAboutData::setApplicationData (authored by kossebau).
Do not repeat work of KAboutData::setApplicationData
Sat, Jan 19, 2:17 PM
kossebau committed R436:cc5a7983d690: Do not repeat work of KAboutData::setupCommandLine (authored by kossebau).
Do not repeat work of KAboutData::setupCommandLine
Sat, Jan 19, 2:17 PM
kossebau committed R436:86e085cb4454: Call KLocalizedString::setApplicationDomain after qapp creation (authored by kossebau).
Call KLocalizedString::setApplicationDomain after qapp creation
Sat, Jan 19, 2:17 PM
kossebau committed R436:73f88968dfcc: Use consistently nullptr (authored by kossebau).
Use consistently nullptr
Sat, Jan 19, 2:17 PM
kossebau committed R436:957bfc229cd3: Use consistently override (authored by kossebau).
Use consistently override
Sat, Jan 19, 2:17 PM
kossebau committed R436:97cc8547d8bd: Improve order in toplevel CMakeLists.txt: first setup ECM, then do find (authored by kossebau).
Improve order in toplevel CMakeLists.txt: first setup ECM, then do find
Sat, Jan 19, 2:17 PM
kossebau committed R436:db6ac97ae995: Bump min cmake version to 3.0 (authored by kossebau).
Bump min cmake version to 3.0
Sat, Jan 19, 2:17 PM
kossebau committed R228:2577062869b2: Include KDECMakeSettings & KDEFrameworkCompilerSettings before the rest (authored by kossebau).
Include KDECMakeSettings & KDEFrameworkCompilerSettings before the rest
Sat, Jan 19, 1:38 PM
kossebau committed R228:9494fe991c5e: Bump min cmake version to 3.0 (authored by kossebau).
Bump min cmake version to 3.0
Sat, Jan 19, 1:38 PM
kossebau committed R227:c39335360180: Include KDECMakeSettings & KDEFrameworkCompilerSettings before the rest (authored by kossebau).
Include KDECMakeSettings & KDEFrameworkCompilerSettings before the rest
Sat, Jan 19, 1:33 PM
kossebau committed R227:7f75a95c6c05: Bump min cmake version to 3.0 (authored by kossebau).
Bump min cmake version to 3.0
Sat, Jan 19, 1:33 PM
kossebau committed R49:6b8a195684fa: Set window icon for non-desktopfile-aware wms (authored by kossebau).
Set window icon for non-desktopfile-aware wms
Sat, Jan 19, 1:18 PM
kossebau committed R49:f4ed350ecc68: No need to duplicate work of KAboutData::setupCommandLine() (authored by kossebau).
No need to duplicate work of KAboutData::setupCommandLine()
Sat, Jan 19, 1:18 PM
kossebau committed R49:ebb52a4ceb30: Use nullptr (authored by kossebau).
Use nullptr
Sat, Jan 19, 1:18 PM
kossebau committed R49:508e28bd6395: Use override consistently (authored by kossebau).
Use override consistently
Sat, Jan 19, 1:18 PM
kossebau committed R49:26eb84e09947: Bump min Qt to 5.6, KF to 5.18 (authored by kossebau).
Bump min Qt to 5.6, KF to 5.18
Sat, Jan 19, 1:18 PM
kossebau committed R49:b3ac79741127: Bump min cmake version to 3.0 (authored by kossebau).
Bump min cmake version to 3.0
Sat, Jan 19, 1:18 PM
kossebau committed R375:120aaf7ace00: Bump min cmake dep to 3.0 (authored by kossebau).
Bump min cmake dep to 3.0
Sat, Jan 19, 12:39 PM
kossebau committed R229:0bcd37fd5956: Use CamelCase includes for KF headers (authored by kossebau).
Use CamelCase includes for KF headers
Sat, Jan 19, 12:29 PM
kossebau committed R229:88d0071fc506: Ensure modern Qt code (authored by kossebau).
Ensure modern Qt code
Sat, Jan 19, 12:29 PM
kossebau committed R229:952c29237029: Bump min cmake dep to 3.0 (authored by kossebau).
Bump min cmake dep to 3.0
Sat, Jan 19, 12:29 PM

Thu, Jan 17

kossebau committed R499:01a183a0ae67: Breeze-gtk dependency on breeze now also for stable (authored by kossebau).
Breeze-gtk dependency on breeze now also for stable
Thu, Jan 17, 3:11 PM
kossebau added inline comments to D13870: Correct Folder View sizing and representation switch behavior.
Thu, Jan 17, 10:03 AM · Plasma

Sun, Jan 13

kossebau committed R226:988d866cca2b: Merge branch 'Applications/18.12' (authored by kossebau).
Merge branch 'Applications/18.12'
Sun, Jan 13, 10:22 PM
kossebau committed R226:d756df162f3d: webenginepart: remove unused variable (authored by kossebau).
webenginepart: remove unused variable
Sun, Jan 13, 10:22 PM
kossebau committed R226:98675c4feec0: webkitpart: add missing "emit"s (authored by kossebau).
webkitpart: add missing "emit"s
Sun, Jan 13, 10:22 PM
kossebau committed R226:2cf5494d3261: webkitpart: pass more big args as const ref (authored by kossebau).
webkitpart: pass more big args as const ref
Sun, Jan 13, 10:22 PM
kossebau committed R226:eb09362336f3: Fix license (authored by stefanocrocco).
Fix license
Sun, Jan 13, 10:16 PM
kossebau added a comment to D14233: Restore ability to view help pages from Konqueror.

I just submitted review D18227 with the license fixes. I believe I copied the license from some other Konqueror source file which uses GPL and didn't notice that WebEnginePart files use LGPL instead.

Sun, Jan 13, 9:59 PM

Fri, Jan 11

kossebau committed R32:2cb06891a412: appimage: bump KDE_APPLICATION_VERSION to 18.12.1 (authored by kossebau).
appimage: bump KDE_APPLICATION_VERSION to 18.12.1
Fri, Jan 11, 8:54 AM
kossebau committed R32:ff326bb2061a: appimage: skip unneeded cp of cmake, removed later again (authored by kossebau).
appimage: skip unneeded cp of cmake, removed later again
Fri, Jan 11, 8:52 AM
kossebau closed D18175: appimage: skip unneeded cp of cmake, removed later again.
Fri, Jan 11, 8:52 AM · KDevelop
kossebau requested review of D18175: appimage: skip unneeded cp of cmake, removed later again.
Fri, Jan 11, 7:46 AM · KDevelop

Thu, Jan 10

kossebau committed R226:1e4818c991f5: webenginepart: use categorized logging (authored by kossebau).
webenginepart: use categorized logging
Thu, Jan 10, 10:15 PM
kossebau added a task to R37:495e66f54af7: Reenable reports in Plan, using KReport: Unknown Object (Maniphest Task).
Thu, Jan 10, 8:42 PM
kossebau accepted D16982: Switch to tidy-html5 and use tidybuffio.h instead of buffio.h.

Header was renamed a few years ago.

Thu, Jan 10, 6:16 PM
kossebau added a comment to D14233: Restore ability to view help pages from Konqueror.

Hi @stefanocrocco. I just came across your nice fixes for webenginepart to improve kio support, Thanks for those.

Thu, Jan 10, 5:41 PM
kossebau committed R383:f977a7052ccb: Add JSON metadata to plugin binary (authored by kossebau).
Add JSON metadata to plugin binary
Thu, Jan 10, 6:45 AM
kossebau committed R383:dfa7cc217c7f: Bump min cmake dep to 3.0 (authored by kossebau).
Bump min cmake dep to 3.0
Thu, Jan 10, 6:45 AM
kossebau committed R383:b8a23167bdc8: Install kparts plugin to kf5/parts subdir (authored by kossebau).
Install kparts plugin to kf5/parts subdir
Thu, Jan 10, 6:45 AM
kossebau committed R451:50a96df98aff: Call cmake's feature_summary (authored by kossebau).
Call cmake's feature_summary
Thu, Jan 10, 6:37 AM
kossebau committed R451:8f8539a93afb: Bump min cmake dep to 3.0 (authored by kossebau).
Bump min cmake dep to 3.0
Thu, Jan 10, 6:37 AM
kossebau committed R451:3c00d18909a1: Add JSON metadata to plugin binary (authored by kossebau).
Add JSON metadata to plugin binary
Thu, Jan 10, 6:37 AM
kossebau committed R451:476348de3fd4: Install kparts consistently to kf5/parts subdir (authored by kossebau).
Install kparts consistently to kf5/parts subdir
Thu, Jan 10, 6:37 AM
kossebau committed R454:b6338880bc61: Add JSON metadata to plugin binaries (authored by kossebau).
Add JSON metadata to plugin binaries
Thu, Jan 10, 6:18 AM
kossebau committed R454:ffb3488dedd5: Install kparts plugins consistently to kf5/parts subdir (authored by kossebau).
Install kparts plugins consistently to kf5/parts subdir
Thu, Jan 10, 6:18 AM
kossebau committed R313:70a196f1c95f: Fix ui.rc files to use non-deprecated <gui> root (authored by kossebau).
Fix ui.rc files to use non-deprecated <gui> root
Thu, Jan 10, 5:58 AM
kossebau committed R313:2e50f6bb9d39: Add JSON metadata to khtmlpart plugin binary (authored by kossebau).
Add JSON metadata to khtmlpart plugin binary
Thu, Jan 10, 5:51 AM
kossebau committed R531:c5e020e6040e: set all properties in UI file if possible (authored by kossebau).
set all properties in UI file if possible
Thu, Jan 10, 5:41 AM
kossebau committed R531:4569021aa5b5: Remove unneeded virtual tag from method (authored by kossebau).
Remove unneeded virtual tag from method
Thu, Jan 10, 5:41 AM
kossebau committed R531:a8fe93889979: add JSON metadata to plugin binary (authored by kossebau).
add JSON metadata to plugin binary
Thu, Jan 10, 5:41 AM