dileepsankhla (Dileep Sankhla)
Google Summer of Code with KDE

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Dec 18 2017, 3:05 AM (134 w, 3 d)
Availability
Available

Recent Activity

Sep 7 2018

dileepsankhla added a comment to D15279: Store all annotation color attributes as ARGB string.

Thank you Tobias for making it landable. Please go ahead :)

Sep 7 2018, 12:05 PM · Okular

Sep 1 2018

dileepsankhla abandoned D13203: Add Typewriter annotation tool in Okular.
Sep 1 2018, 5:54 PM · Okular

Jul 19 2018

dileepsankhla updated the diff for D13203: Add Typewriter annotation tool in Okular.

Set flag HAVE_POPPLER_0_67 in generator/poppler

Jul 19 2018, 4:14 AM · Okular
dileepsankhla committed R223:16d259b2ece3: Set flag HAVE_POPPLER_0_67 in generator/poppler (authored by dileepsankhla).
Set flag HAVE_POPPLER_0_67 in generator/poppler
Jul 19 2018, 3:59 AM

Jul 18 2018

dileepsankhla added inline comments to D13203: Add Typewriter annotation tool in Okular.
Jul 18 2018, 7:59 PM · Okular

Jul 17 2018

dileepsankhla added inline comments to D13203: Add Typewriter annotation tool in Okular.
Jul 17 2018, 4:00 PM · Okular

Jul 8 2018

dileepsankhla updated the diff for D13203: Add Typewriter annotation tool in Okular.

Updated generator/poppler for text color

Jul 8 2018, 7:02 PM · Okular
dileepsankhla committed R223:19f86915059b: Updated generator/poppler for text color (authored by dileepsankhla).
Updated generator/poppler for text color
Jul 8 2018, 6:58 PM

Jul 7 2018

dileepsankhla updated the diff for D13203: Add Typewriter annotation tool in Okular.

Added font color in Okular

Jul 7 2018, 3:26 PM · Okular
dileepsankhla committed R223:80ecb0c51c1a: Implemented working font color (authored by dileepsankhla).
Implemented working font color
Jul 7 2018, 3:15 PM

Jun 29 2018

dileepsankhla committed R223:019104083b3e: Added font color selector and tool icon color in typewriter tool (authored by dileepsankhla).
Added font color selector and tool icon color in typewriter tool
Jun 29 2018, 12:38 PM

Jun 20 2018

dileepsankhla updated the diff for D13203: Add Typewriter annotation tool in Okular.

Updating tools.xml <annotation> elements color attributes to incorporate #AARRGGBB color formats

Jun 20 2018, 6:02 PM · Okular
dileepsankhla committed R223:286216413d77: Updating tools.xml <annotation> elements color attributes with ##AARRGGBB color… (authored by dileepsankhla).
Updating tools.xml <annotation> elements color attributes with ##AARRGGBB color…
Jun 20 2018, 5:54 PM
dileepsankhla added inline comments to D13203: Add Typewriter annotation tool in Okular.
Jun 20 2018, 5:45 PM · Okular
dileepsankhla updated the test plan for D13203: Add Typewriter annotation tool in Okular.
Jun 20 2018, 5:41 PM · Okular

Jun 19 2018

dileepsankhla updated the diff for D13203: Add Typewriter annotation tool in Okular.

Adapt CloseDialogHelper for use with QInputDialog.
Close typewriter input dialog with ok button and test for expected typewriter annotation.

Jun 19 2018, 9:30 AM · Okular
dileepsankhla committed R223:0d1cc611fe61: Adapt CloseDialogHelper for use with QInputDialog. Close typewriter input… (authored by dileepsankhla).
Adapt CloseDialogHelper for use with QInputDialog. Close typewriter input…
Jun 19 2018, 8:57 AM

Jun 18 2018

dileepsankhla committed R223:4cada4efcc77: Modified CloseDialogHelper (authored by dileepsankhla).
Modified CloseDialogHelper
Jun 18 2018, 7:17 PM

Jun 17 2018

dileepsankhla added inline comments to D13203: Add Typewriter annotation tool in Okular.
Jun 17 2018, 6:05 PM · Okular

Jun 10 2018

dileepsankhla updated the diff for D13203: Add Typewriter annotation tool in Okular.

Adding tests for typewriter annotation tool

Jun 10 2018, 10:28 PM · Okular
dileepsankhla committed R223:9fe4444db94d: Added test for typewriter annotation (authored by dileepsankhla).
Added test for typewriter annotation
Jun 10 2018, 10:13 PM
dileepsankhla committed R223:a9cb8aa96f4d: Added test to verify QInputDialog appears (authored by dileepsankhla).
Added test to verify QInputDialog appears
Jun 10 2018, 6:24 PM

Jun 8 2018

dileepsankhla committed R223:99ba39ad34c1: Added a test for typewriter toolbutton (authored by dileepsankhla).
Added a test for typewriter toolbutton
Jun 8 2018, 9:24 AM
dileepsankhla added inline comments to D13203: Add Typewriter annotation tool in Okular.
Jun 8 2018, 8:30 AM · Okular

Jun 4 2018

dileepsankhla updated the diff for D13203: Add Typewriter annotation tool in Okular.

Diff changed after commiting to gsoc2018_typewriter branch. Updating it.

Jun 4 2018, 7:05 AM · Okular
dileepsankhla reopened D13203: Add Typewriter annotation tool in Okular.
Jun 4 2018, 6:59 AM · Okular
dileepsankhla committed R223:66c70934b82c: popup window background color (authored by dileepsankhla).
popup window background color
Jun 4 2018, 6:58 AM
dileepsankhla closed D13203: Add Typewriter annotation tool in Okular.
Jun 4 2018, 6:58 AM · Okular

Jun 2 2018

dileepsankhla added a reviewer for D13203: Add Typewriter annotation tool in Okular: tobiasdeiminger.
Jun 2 2018, 9:54 AM · Okular
dileepsankhla updated the diff for D13203: Add Typewriter annotation tool in Okular.

Updating annotation popup window background color

Jun 2 2018, 3:45 AM · Okular
dileepsankhla reopened D13203: Add Typewriter annotation tool in Okular.
Jun 2 2018, 3:44 AM · Okular
dileepsankhla added a comment to D13203: Add Typewriter annotation tool in Okular.

The revision is closed. I'm unable to update it. Maybe someone with admin privileges should reopen it?

Jun 2 2018, 3:41 AM · Okular

Jun 1 2018

dileepsankhla removed 1 commit(s) for D13203: Add Typewriter annotation tool in Okular: R223:f0063e548b1b: Fixed initial typewriter width to 0.
Jun 1 2018, 1:49 PM · Okular
dileepsankhla removed an edge from R223:f0063e548b1b: Fixed initial typewriter width to 0: D13203: Add Typewriter annotation tool in Okular.
Jun 1 2018, 1:49 PM
dileepsankhla added a comment to D13203: Add Typewriter annotation tool in Okular.

Hell! Sorry for this mistake again. Whenever I update the revision, I push the commit to the gsoc2018_typewriter branch too and the revision landed in need review state by that commit (both have the same hash).
@ltoscano May you please reopen this revision?

Jun 1 2018, 1:34 PM · Okular
dileepsankhla committed R223:f0063e548b1b: Fixed initial typewriter width to 0 (authored by dileepsankhla).
Fixed initial typewriter width to 0
Jun 1 2018, 1:18 PM
dileepsankhla closed D13203: Add Typewriter annotation tool in Okular.
Jun 1 2018, 1:18 PM · Okular
dileepsankhla updated the diff for D13203: Add Typewriter annotation tool in Okular.

Fixed initial typewriter border width to 0

Jun 1 2018, 1:14 PM · Okular

May 31 2018

dileepsankhla added a comment to D13203: Add Typewriter annotation tool in Okular.

I didn't mean to change anything in Poppler. I meant it's the way it works in Poppler right now. I assume if both 'rg' operator and 'ca' entry are applied, alpha gets multiplied. Probably also depending on >blend mode. I don't know how this works exactly, it's a longer read through AnnotFreeText::generateFreeTextAppearance and the spec (e.g. 11.6.3 Specifying Blending Colour and Blend Mode). Maybe you >can figure it out on your own?

May 31 2018, 10:04 AM · Okular
dileepsankhla updated the diff for D13203: Add Typewriter annotation tool in Okular.

Fixed typewriter transparency in PagePainter

May 31 2018, 9:48 AM · Okular
dileepsankhla committed R223:165ba4b68827: Fixed white background in pagepainter (authored by dileepsankhla).
Fixed white background in pagepainter
May 31 2018, 7:54 AM
dileepsankhla added a comment to D13203: Add Typewriter annotation tool in Okular.

How about changing ui/pagepainter.cpp L668 to

acolor.setAlpha( a->style().opacity() * a->style().color().alpha() );

It gives us transparent background for new typewriter annotations. It should be backwards/forwards compatible with *.okular documents from other Okular versions. And I believe it's more consistent to what happens in Poppler, because I assume in Poppler color[alpha] and opacity will also get multiplied to determine the final alpha of background color for FreeText, if both values are set. But haven't verified this assumption yet.

May 31 2018, 7:12 AM · Okular

May 30 2018

dileepsankhla added a comment to D13203: Add Typewriter annotation tool in Okular.

If I use the new tool to typewrite onto a plain text file, I get opaque white background instead of transparent background. Transparency does work for PDF documents (i.e. rendered by poppler). In the former case the typewriter annotation is drawn in ui/pagepainter.cpp L.680. Can you checkout what's wrong there?

We should add something like "Transparent background working on any supported document type" to the testplan (or only test .pdf and .txt for a start, it's enough to test both generator and pagepainter drawing paths).

May 30 2018, 4:22 PM · Okular
dileepsankhla added a comment to D13203: Add Typewriter annotation tool in Okular.

The gsoc* branches are meant to share and log small junks of GSoC progress frequently (even daily), prior to publishing a ready-to-review patch on phabricator. But there haven't been any intermediate GSoC commits during the past two weeks on gsoc2018_typewriter. D13203 on phabricator is just the same as c344c5e31b6a in the branch. So both diffs have the same hash and therefore got automatically linked.

If you don't push your work-in-progress frequently to gsoc2018_typewriter, I doubt there's a point in having that extra branch branch at all. You could equally work on a local branch only and submit a patch after few weeks to phabricator.

May 30 2018, 4:10 PM · Okular
dileepsankhla committed R223:b3b3ebc5c534: Temporarily fixed typewriter annotation with transparent background in plain… (authored by dileepsankhla).
Temporarily fixed typewriter annotation with transparent background in plain…
May 30 2018, 4:01 PM
dileepsankhla committed R223:30cf1951a676: Force release of free memory (authored by aacid).
Force release of free memory
May 30 2018, 4:01 PM
dileepsankhla committed R223:e4063386fa4a: Add test for additional form actions (authored by aheinecke).
Add test for additional form actions
May 30 2018, 4:01 PM
dileepsankhla committed R223:4b19113acca8: Support additional widget actions in PDF Forms (authored by aheinecke).
Support additional widget actions in PDF Forms
May 30 2018, 4:01 PM

May 29 2018

dileepsankhla added a comment to D13203: Add Typewriter annotation tool in Okular.

@ngraham This is the part of my GSoC project: https://summerofcode.withgoogle.com/projects/#6053164340477952

May 29 2018, 5:05 PM · Okular
dileepsankhla committed R223:c344c5e31b6a: Added Typewriter annotation tool (authored by dileepsankhla).
Added Typewriter annotation tool
May 29 2018, 4:59 PM
dileepsankhla closed D13203: Add Typewriter annotation tool in Okular.
May 29 2018, 4:59 PM · Okular
dileepsankhla updated subscribers of D13203: Add Typewriter annotation tool in Okular.
May 29 2018, 4:52 PM · Okular
dileepsankhla requested review of D13203: Add Typewriter annotation tool in Okular.
May 29 2018, 4:49 PM · Okular

Apr 30 2018

dileepsankhla added a comment to D11051: Remembering side navigation panel state.

Currently I am working as a GSoC student and in discussion with my mentor, I have decided to pause the patch report during the GSoC period. BBL

Apr 30 2018, 12:35 PM · Okular

Apr 29 2018

dileepsankhla committed R954:b0340f334792: Add my blog (authored by dileepsankhla).
Add my blog
Apr 29 2018, 7:28 PM

Apr 4 2018

dileepsankhla added a comment to D11051: Remembering side navigation panel state.

The state can be saved whenever a sidebar item is clicked in Sidebar::itemClicked but again as discussed earlier, it will be asymmetrical as to save in sidebar.cpp. Should I implement a signal slot mechanism in part.cpp to achieve so or should I find another way?

Apr 4 2018, 4:36 AM · Okular

Apr 2 2018

dileepsankhla added a comment to D11051: Remembering side navigation panel state.

I tried but it is still giving me the segfault. The interesting thing, in my opinion, is whenever you open Okular and close it down without changing the sidebar state, it doesn't give a segfault whereas changing the sidebar state and closing it gives the error.
Should we stick to it or should we consider saving the stats in the Sidebar::~Sidebar()?

Apr 2 2018, 2:55 PM · Okular

Apr 1 2018

dileepsankhla added a comment to D11051: Remembering side navigation panel state.

The verbose output of valgrind is around 190,000 lines with the line numbers. Here is the output:

Apr 1 2018, 6:12 PM · Okular
dileepsankhla added a comment to D11051: Remembering side navigation panel state.

https://paste.kde.org/pepnfuzxq

Apr 1 2018, 2:56 AM · Okular

Mar 31 2018

dileepsankhla added a comment to D11051: Remembering side navigation panel state.

Following is the log of running valgrind on okular:

Mar 31 2018, 3:04 PM · Okular

Mar 27 2018

dileepsankhla updated the diff for D11051: Remembering side navigation panel state.

Updating: Remembring side navigation panel state
Changing the state to the one being discussed here in comments.

Mar 27 2018, 7:08 PM · Okular
dileepsankhla added a comment to D11051: Remembering side navigation panel state.

Actually I am getting the segmentation fault whenever I close Okular with a changed state of the side navigation panel and the code causing it is Okular::Settings::setHideSideContainer( m_sidebar->isCollapsed() ) inside the Part destructor. m_sidebar is not causing this problem as I misunderstood the earlier; it gives the segfault for any value as the argument of setHideSideContainer except for the boolean values True and False. It works fine for the absolute boolean values.
Running it with gdb, I got segfault in QAbstractScrollArea::horizontalScrollBarPolicy() const () from /usr/lib/libQt5Widgets.so.5 that is confusing for me. I need an idea regarding what can be done in this case?

Mar 27 2018, 6:58 PM · Okular

Mar 10 2018

dileepsankhla added a comment to D11051: Remembering side navigation panel state.

Also i'm not convinced it's a good idea to save the settings in sidebar.cpp but read them in part.cpp, seems a bit asymmetrical, can you explain your reasoning for it?

Mar 10 2018, 7:03 PM · Okular

Mar 5 2018

dileepsankhla updated the diff for D11051: Remembering side navigation panel state.

Updating: Remembering side navigation panel state
Removed the extra whitespace.

Mar 5 2018, 11:46 AM · Okular
dileepsankhla added a reviewer for D11051: Remembering side navigation panel state: Okular.
Mar 5 2018, 11:14 AM · Okular
dileepsankhla requested review of D11051: Remembering side navigation panel state.
Mar 5 2018, 11:12 AM · Okular

Mar 1 2018

dileepsankhla updated the diff for D10249: Option to exit after printing.

Updating D10249: Option to exit after printing

Mar 1 2018, 10:04 PM · Okular
dileepsankhla added a comment to D10249: Option to exit after printing.

Oops! As I was getting errors in the autotests/mainshelltest.cpp file while make okular, I assumed the autotest didn't compile and build successfully. I also assumed the make command runs the tests too. Now running with ./autotests/mainshelltest, I got the error. After rectifying and rebuilding, I run the autotest again and whenever the window opens for the showPrintDialogAndExit, it waits for the user input and exits on clicking either Print or Cancel button. The autotest also stops there without showing any information about the passed and failed tests.
I'm not getting what's going on and how to proceed from this point. I even don't whether it is some error or the std::exit function stops the running test too. Should I eliminate 'showPrintDialogAndExit' row along with externalProcessExpectPrintDialogAndExit column?

Mar 1 2018, 8:50 PM · Okular

Feb 22 2018

dileepsankhla added a comment to D10249: Option to exit after printing.

No I ran the tests too and it was a success.

Feb 22 2018, 2:31 AM · Okular

Feb 13 2018

dileepsankhla updated the diff for D10249: Option to exit after printing.

Updating D10249: Option to exit after printing
Tried my best to edit the data driven tests by adding appropriate data to the table using QTest::newRow function.

Feb 13 2018, 6:11 PM · Okular

Feb 11 2018

dileepsankhla added a comment to D10249: Option to exit after printing.

@aacid I have talked about using std::exit instead of QCoreApplication::exit here : https://phabricator.kde.org/D10249#200260

Feb 11 2018, 7:43 AM · Okular

Feb 8 2018

dileepsankhla updated the diff for D10249: Option to exit after printing.

Updating D10249: Option to exit after printing
renamed isError variable to success and changed the option with -print-and-exit.

Feb 8 2018, 5:19 PM · Okular

Feb 5 2018

dileepsankhla updated the diff for D10249: Option to exit after printing.

Updating D10249: Option to exit after printing
Initialized "isError" with false at the time of declaration.

Feb 5 2018, 5:59 PM · Okular
dileepsankhla updated the diff for D10249: Option to exit after printing.

Updating D10249: Option to exit after printing

Feb 5 2018, 12:07 AM · Okular

Feb 4 2018

dileepsankhla updated the diff for D10249: Option to exit after printing.

Updating D10249: Option to exit after printing

Feb 4 2018, 11:31 PM · Okular
dileepsankhla added a comment to D10249: Option to exit after printing.
Feb 4 2018, 6:25 AM · Okular

Feb 3 2018

dileepsankhla updated the diff for D10249: Option to exit after printing.

Updating D10249 : Option to exit after printing

Feb 3 2018, 6:28 PM · Okular
dileepsankhla added a comment to D10249: Option to exit after printing.

@aacid Agree that only one exit call is required but what about the exit status - EXIT_SUCCESS or EXIT_FAILURE? The issue description talked about the command line batch processing. For that purpose, should I set a bool "isError" when failing condition is encountered like "printing is not allowed" and then based on the isError's status, should I call either exit (EXIT_SUCCESS) or exit (EXIT_FAILURE)?

Feb 3 2018, 1:02 AM · Okular

Feb 2 2018

dileepsankhla added a reviewer for D10249: Option to exit after printing: ngraham.
Feb 2 2018, 3:58 PM · Okular
dileepsankhla updated the summary of D10249: Option to exit after printing.
Feb 2 2018, 12:50 PM · Okular
dileepsankhla added a reviewer for D10249: Option to exit after printing: Okular.
Feb 2 2018, 12:46 PM · Okular

Jan 31 2018

dileepsankhla added a comment to D10209: Use correct arrow cursor for Annotations' close buttons.

Thank you so much. I'm checking it out.

Jan 31 2018, 6:17 PM · Okular
dileepsankhla added a comment to D10209: Use correct arrow cursor for Annotations' close buttons.

Sure :)

Jan 31 2018, 6:04 PM · Okular
dileepsankhla added a comment to D10209: Use correct arrow cursor for Annotations' close buttons.

Lovely. Tested it out and it works as expected. Fix the BUG: string and I'll land this.

Jan 31 2018, 6:01 PM · Okular
dileepsankhla updated the summary of D10209: Use correct arrow cursor for Annotations' close buttons.
Jan 31 2018, 5:59 PM · Okular
dileepsankhla updated the summary of D10209: Use correct arrow cursor for Annotations' close buttons.
Jan 31 2018, 5:50 PM · Okular
dileepsankhla added a comment to D10209: Use correct arrow cursor for Annotations' close buttons.
Jan 31 2018, 5:50 PM · Okular
dileepsankhla added a comment to D10209: Use correct arrow cursor for Annotations' close buttons.

Thanks for the patch! Can you indicate your testing, and perhaps provide a screenshot that shows this working?

Also, the title of the revision is really better suited to being in the summary. For the title, try to briefly explain the overall purpose. Maybe something like "Use correct arrow cursor for Annotations' close buttons"

Jan 31 2018, 5:44 PM · Okular
dileepsankhla retitled D10209: Use correct arrow cursor for Annotations' close buttons from Added setCursor() call in the CloseButton constructor to Use correct arrow cursor for Annotations' close buttons.
Jan 31 2018, 5:42 PM · Okular