Differential D13402

FrameSvg: Simplify updateSizes
ClosedPublic
Actions

Authored by zzag on Jun 7 2018, 11:58 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Frameworks
Commits
R242:acdaefa221cc: FrameSvg: Simplify updateSizes
Summary
if (hintXXXMargin > -1) {
    // ...
} else {
    // ...
}

are redundant because fixedXXXMargin already hold correct margin values.

Test Plan

Manually

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jun 7 2018, 11:58 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 7 2018, 11:58 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
zzag requested review of this revision.Jun 7 2018, 11:58 AM
mart accepted this revision.Jun 27 2018, 11:37 AM
This revision is now accepted and ready to land.Jun 27 2018, 11:37 AM
Closed by commit R242:acdaefa221cc: FrameSvg: Simplify updateSizes (authored by zzag). · Explain WhyJun 27 2018, 12:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/framesvg.cpp (44 lines)

Diff 36757

View Options

src/plasma/framesvg.cpp

Loading...