mgallien (Matthieu Gallien)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 10 2015, 7:32 AM (187 w, 5 d)
Availability
Available

Recent Activity

Today

mgallien accepted D21859: [RFC] Use view-media-lyrics for Now Playing View.
Sun, Jun 16, 8:01 PM · Elisa

Yesterday

mgallien committed R255:465f4859cb33: simplify management of list and grid views and keep only one kind (authored by mgallien).
simplify management of list and grid views and keep only one kind
Sat, Jun 15, 10:06 PM
mgallien committed R255:e7b9644715bf: simplify management of list and grid views and keep only one kind (authored by mgallien).
simplify management of list and grid views and keep only one kind
Sat, Jun 15, 10:06 PM
mgallien committed R255:a639223fd213: fix display of single album list view (authored by mgallien).
fix display of single album list view
Sat, Jun 15, 10:06 PM
mgallien closed D21774: simplify management of list and grid views and keep only one kind.
Sat, Jun 15, 10:06 PM
mgallien committed R255:deca387b9ad7: simplify management of list and grid views and keep only one kind (authored by mgallien).
simplify management of list and grid views and keep only one kind
Sat, Jun 15, 10:06 PM
mgallien accepted D21806: Use existing settings storage for shuffle and repeat.

Thanks

Sat, Jun 15, 9:57 PM · Elisa

Fri, Jun 14

mgallien added a comment to D21525: Add support for radio streams.

Fixes:

  • rebase on current master branch
  • fixed swich-cases not taking in account radio
  • removed some comments and cleaned some code
  • enqueue and replace button for all the radios in the view does not appears for the Radios view (suggestion from the vdg discussion, as a stream never ends, so adding several radios into the playlist does not make sense).
Fri, Jun 14, 9:17 PM
mgallien added a comment to D21771: Polish Context View.

Thanks for your work.

Fri, Jun 14, 9:15 PM
mgallien added a comment to D21776: Implement new Header toolbar style for main view.

Thanks for your work.

Fri, Jun 14, 9:13 PM
mgallien added a comment to D21806: Use existing settings storage for shuffle and repeat.

I am looking at it.

Fri, Jun 14, 9:09 PM · Elisa
mgallien added a project to D21806: Use existing settings storage for shuffle and repeat: Elisa.
Fri, Jun 14, 9:09 PM · Elisa
mgallien added a watcher for Flatpak: mgallien.
Fri, Jun 14, 8:06 PM

Thu, Jun 13

mgallien accepted D21634: Remove custom styling from button component.

Thanks

Thu, Jun 13, 7:17 AM

Wed, Jun 12

mgallien requested review of D21774: simplify management of list and grid views and keep only one kind.
Wed, Jun 12, 8:16 PM
mgallien added a comment to D21608: improve accessibility by providing metadata for UI elements.

By the way: Thanks for care about accessibility! this is awsome :).

Wed, Jun 12, 4:30 PM
mgallien committed R255:ee49bfc0c554: improve accessibility by providing metadata for UI elements (authored by mgallien).
improve accessibility by providing metadata for UI elements
Wed, Jun 12, 3:36 PM
mgallien committed R255:4c71234d9426: improve accessibility by providing metadata for UI elements (authored by mgallien).
improve accessibility by providing metadata for UI elements
Wed, Jun 12, 3:24 PM
mgallien closed D21608: improve accessibility by providing metadata for UI elements.
Wed, Jun 12, 3:24 PM
mgallien accepted D21676: [RFC] Implement KDE-style header toolbars and statusbars for Playlist and Context view.

I really like the result.
I am a bit undecided for the margins around the cover image in context view.

In fact my next patch was actually going to be revamping the context view, including removing the album art slice. :) It's redundant, since the main headerbar already shows the album art for the currently playing song.

Wed, Jun 12, 3:22 PM

Tue, Jun 11

mgallien added a comment to D21676: [RFC] Implement KDE-style header toolbars and statusbars for Playlist and Context view.

I really like the result.
I am a bit undecided for the margins around the cover image in context view.

Tue, Jun 11, 9:36 PM
mgallien added a comment to D21608: improve accessibility by providing metadata for UI elements.

Should I make further modifications or land the current patch ?

Tue, Jun 11, 9:22 PM
mgallien added a comment to D21749: build elisa witl libvlc 3.0.7 version.

Thanks for the review.
I fail to push with this error:

Tue, Jun 11, 9:21 PM
mgallien requested review of D21749: build elisa witl libvlc 3.0.7 version.
Tue, Jun 11, 4:12 PM

Mon, Jun 10

mgallien moved T11063: Factor List Views from Backlog to In Progress on the Elisa board.
Mon, Jun 10, 9:31 PM · Elisa
mgallien created T11063: Factor List Views.
Mon, Jun 10, 9:31 PM · Elisa

Fri, Jun 7

mgallien updated the diff for D21608: improve accessibility by providing metadata for UI elements.
  • add Accessible.onPressAction handler to interact with screen readers
Fri, Jun 7, 6:56 PM
mgallien added a comment to D21608: improve accessibility by providing metadata for UI elements.

[...]

Blind people rarely click. Some a10y software has a way to trigger actions directly.

Accessible.onPressAction: onClicked

Would probably suffice.

Does this mean that every button with onClicked ideally also needs Accessible.onPressAction: onClicked too?

For Press this is not needed. I dont know where is the difference between press and click as the documentation tells the same.
https://doc.qt.io/qt-5/qml-qtquick-controls2-abstractbutton.html#pressed-signal
https://doc.qt.io/qt-5/qml-qtquick-controls2-abstractbutton.html#clicked-signal

I would feel better if pressed is used for buttons. As klick sounds more like mouse is required also the documentation says different.

Fri, Jun 7, 6:41 PM
mgallien added a comment to D21608: improve accessibility by providing metadata for UI elements.

i think you don't need the
"Accessible.onPressAction"
stuff when you use

  • onPressed insteed of :
  • onClicked

    i never used it with onPressed and it worked always just fine :). but it should work too. just curious for my own interest, is there a reason why always onClicked is used instead of onPressed? As for me it sounds more natural to press an button. does anyone know the exact difference? as i can read from the QT docu its the same? is it?
Fri, Jun 7, 6:32 PM
mgallien accepted D21636: Use full-height separators in ContentView.

Looks good to me

Fri, Jun 7, 6:15 PM

Thu, Jun 6

mgallien accepted D21582: Make Playlist items span full width.

Looks good to me. Thanks

Thu, Jun 6, 8:54 PM
mgallien added a comment to D21634: Remove custom styling from button component.

Thanks for taking care of that. It is really appreciated.
Please see my inline comment.

Thu, Jun 6, 8:47 PM
mgallien updated the diff for D21608: improve accessibility by providing metadata for UI elements.
  • add Accessible.onPressAction handler to interact with screen readers
Thu, Jun 6, 8:41 PM

Wed, Jun 5

mgallien planned changes to D21608: improve accessibility by providing metadata for UI elements.

Blind people rarely click. Some a10y software has a way to trigger actions directly.

Accessible.onPressAction: onClicked

Would probably suffice.

Wed, Jun 5, 8:38 PM
mgallien added inline comments to D21608: improve accessibility by providing metadata for UI elements.
Wed, Jun 5, 5:10 PM
mgallien moved T7567: Add support for radio streams from Backlog to In Progress on the Elisa board.
Wed, Jun 5, 3:51 PM · Elisa
mgallien closed T10847: Fix genre, composer and lyricist database insertion as Resolved.
Wed, Jun 5, 3:51 PM · Elisa
mgallien closed T10848: Fix layouts in RTL mode (Right to left) as Resolved.
Wed, Jun 5, 3:50 PM · Elisa
mgallien updated subscribers of D21582: Make Playlist items span full width.

The track title left borders are no longer aligned with the album title left border. That makes it harder to read.
In case it is needed, we could also get more feedback from people in VDG and @januz who did the design work for the current playlist layout.

Wed, Jun 5, 3:49 PM
mgallien added a comment to D21608: improve accessibility by providing metadata for UI elements.

Having recently read this https://raphaelhertzog.com/2011/06/24/people-behin-debian-sam-hartman-kerberos-package-maintainer/ got me motivated to improve Elisa with regard to screen reader accessibility.

Wed, Jun 5, 3:43 PM
mgallien added a comment to D21608: improve accessibility by providing metadata for UI elements.

Is there any accessibility dedicated review group ?

Wed, Jun 5, 3:42 PM
mgallien requested review of D21608: improve accessibility by providing metadata for UI elements.
Wed, Jun 5, 3:40 PM

Tue, Jun 4

mgallien accepted D21581: Detect valgrind, avoid database removal when using valgrind.

Very nice. Thank you

Tue, Jun 4, 4:28 PM · Baloo, Frameworks
mgallien committed R255:7dbdbc31c20a: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
Tue, Jun 4, 5:25 AM
mgallien committed R255:797a8b8777e0: fix focus rectangle not visible in single album view mode (authored by mgallien).
fix focus rectangle not visible in single album view mode
Tue, Jun 4, 5:11 AM
mgallien closed D21081: fix focus rectangle not visible in single album view mode.
Tue, Jun 4, 5:11 AM · Elisa

Mon, Jun 3

mgallien added a comment to D21525: Add support for radio streams.

For the radio icon, I tried to use one from the system icons, but I do not know yet why it is blue and where it comes from in the system.

It's blue because it's a mimetype icon and those tend to be colored. It could be copied and made into a monochrome device icon for you.

Mon, Jun 3, 9:46 PM
mgallien added a comment to D21525: Add support for radio streams.

I have also noticed that one can display the info dialog but it shows something else not related to the playing web radio.

Mon, Jun 3, 9:46 PM
mgallien added a comment to D21525: Add support for radio streams.

Thanks a lot for your work ! This is really nice !

Mon, Jun 3, 9:35 PM
mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.
  • emulate focus beahvior of list view as shown in feedback
  • fix views displaying tracks to have the same focus logic than playlist
  • fix keyboard focus issues whith NavigationActionBar and tab navigation
  • fix focus issues in ListView of single tracks
  • fix qml warning in FrequentlyPlayedTracks and RecentlyPlayedTracks views
  • fix small differences between list based views
  • Elisa sidebar with colored backgrounds
  • improve focus handling of view selector list
  • solve some keyboard focus issues
  • fix tab focus handling in some list views (playlist and album view)
  • for consistency, put the same behavior for generic grid views
  • add mostly the same focus behavior to file browser
Mon, Jun 3, 9:30 PM · Elisa

Fri, May 31

mgallien added a comment to D21081: fix focus rectangle not visible in single album view mode.

I think the leftmost sidebar list items with text and icons are just fine; no need for a fundamental change there. :) All I think needs to happen is that the selected list item should be indicated by giving it a blue or gray background like all other list items have, rather than changing its text color or drawing a frame around it.

Here's a patch for this patch that more or less does what I have in mind:

1diff --git a/src/qml/ViewSelector.qml b/src/qml/ViewSelector.qml
2diff --git a/src/qml/ViewSelector.qml b/src/qml/ViewSelector.qml
3index c391a34..a8f9a8c 100644
4--- a/src/qml/ViewSelector.qml
5+++ b/src/qml/ViewSelector.qml
6@@ -91,19 +91,18 @@ FocusScope {
7
8 Rectangle {
9
10- border {
11- color: ((viewModeView.currentIndex === index && rootFocusScope.activeFocus) ? myPalette.highlight : "transparent")
12- width: 1
13- }
14-
15- Behavior on border.color {
16- ColorAnimation {
17- duration: 300
18+ color: if (viewModeView.currentIndex === index) {
19+ if (rootFocusScope.activeFocus) {
20+ return myPalette.highlight
21+ } else {
22+ return myPalette.mid
23 }
24+ } else if (itemMouseArea.containsMouse) {
25+ return Qt.rgba(myPalette.highlight.r, myPalette.highlight.g, myPalette.highlight.b, 0.2)
26+ } else {
27+ return "transparent"
28 }
29
30- radius: 3
31-
32 anchors.fill: parent
33
34 Loader {
35@@ -197,14 +196,6 @@ FocusScope {
36 duration: 150
37 }
38 }
39-
40- color: (viewModeView.currentIndex === index || itemMouseArea.containsMouse ? myPalette.highlight : myPalette.text)
41-
42- Behavior on color {
43- ColorAnimation {
44- duration: 300
45- }
46- }
47 }
48 }

Fri, May 31, 12:31 PM · Elisa

Thu, May 30

mgallien added a comment to D21469: Port GridBrowser Delegate UI changes to FileBrowserDelegate too.

The file browser *mostly* works fine for me with the 0.4 release + this patch. I can file bugs if you'd like.

Thu, May 30, 10:49 AM

Wed, May 29

mgallien added a comment to D21081: fix focus rectangle not visible in single album view mode.

Humongous improvement so far! One thing that sticks out is that the left-most sidebar list still needs the new style for selected categories so that it matches other list-style items:

Wed, May 29, 8:10 PM · Elisa
mgallien accepted D21469: Port GridBrowser Delegate UI changes to FileBrowserDelegate too.

Thanks for having taken care of that.

Wed, May 29, 8:08 PM
mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.
  • emulate focus beahvior of list view as shown in feedback
  • fix views displaying tracks to have the same focus logic than playlist
  • fix keyboard focus issues whith NavigationActionBar and tab navigation
  • fix focus issues in ListView of single tracks
  • fix qml warning in FrequentlyPlayedTracks and RecentlyPlayedTracks views
  • fix small differences between list based views
Wed, May 29, 5:33 AM · Elisa

Sun, May 26

mgallien committed R255:6bf32ab9e271: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
Sun, May 26, 9:07 PM
mgallien committed R255:374e0e00a5f2: require cmake 3.8 and declare the version into a single place (authored by mgallien).
require cmake 3.8 and declare the version into a single place
Sun, May 26, 8:08 PM
mgallien closed D21404: require cmake 3.8 and declare the version into a single place.
Sun, May 26, 8:08 PM

Sat, May 25

mgallien added a comment to D21404: require cmake 3.8 and declare the version into a single place.
In D21404#469907, @pino wrote:

Instead of reusing config-upnp-qt.h (whose name seems a bit off, considering what that file contains), IMHO it is better to use a separate version header.
You can use the ECMSetupVersion module from ECM for this.

Sat, May 25, 3:04 PM
mgallien updated the diff for D21404: require cmake 3.8 and declare the version into a single place.
  • use ecm_setup_version to set the project version
Sat, May 25, 3:03 PM
mgallien committed R255:c538595ccdf7: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
Sat, May 25, 2:31 PM
mgallien requested review of D21404: require cmake 3.8 and declare the version into a single place.
Sat, May 25, 2:26 PM
mgallien added a comment to D21381: use org.freedesktop.appstream-glib package to validate appstream data.
In D21381#469617, @apol wrote:

How about we test against both?

Sat, May 25, 9:44 AM · Build System, Frameworks
mgallien updated the diff for D21381: use org.freedesktop.appstream-glib package to validate appstream data.
  • use appstream-util and appstreamcli to validate appdata file
Sat, May 25, 9:40 AM · Build System, Frameworks

Fri, May 24

mgallien requested review of D21381: use org.freedesktop.appstream-glib package to validate appstream data.
Fri, May 24, 1:22 PM · Build System, Frameworks
mgallien added a comment to D21243: add OARS rating and some release to appdata file.

I have identified at least several cases and related actions:

  • some applications already have a version indicated in the cmake project command. They are automatically managed through KDE_APPLICATIONS_... variables. A call to add the version also in the appdata file would fill in the release XML tags ;
  • some applications already have a version indicated in the cmake project command. They are manually managed through. When updating the KDE_APPLICATIONS_... variables, the specified version can be extracted and pushed to a new release XML tag ;
  • some applications do not have a version set in cmake project command. Should I add one and see if KDE_APPLICATIONS_... variables can be used. This would be the same as the first case ;
  • To allow use of empty content_rating tags, the cmake appdata test should use the same validator than flathub.
Fri, May 24, 8:27 AM

Thu, May 23

mgallien committed R234:749d7a809ed8: screenshot of Elisa 0.4.0 release (authored by mgallien).
screenshot of Elisa 0.4.0 release
Thu, May 23, 12:06 PM

Wed, May 22

mgallien committed R255:e23fdcb93a3c: improve wording of description of libvlc dependency (authored by mgallien).
improve wording of description of libvlc dependency
Wed, May 22, 3:27 PM
mgallien closed D21318: improve wording of description of libvlc dependency.
Wed, May 22, 3:27 PM
mgallien committed R255:bb7916757de3: fix cmake dependency to be 3.12 not 3.14 (authored by mgallien).
fix cmake dependency to be 3.12 not 3.14
Wed, May 22, 5:21 AM
mgallien committed R255:22661106f8f8: require cmake 3.12 (authored by mgallien).
require cmake 3.12
Wed, May 22, 5:21 AM
mgallien updated the diff for D21318: improve wording of description of libvlc dependency.
  • fix cmake description of libvlc
Wed, May 22, 5:14 AM

Tue, May 21

mgallien requested review of D21318: improve wording of description of libvlc dependency.
Tue, May 21, 3:25 PM
mgallien committed R255:af758c666eb1: Revert "give cmake more information in project command (version, ...)" (authored by mgallien).
Revert "give cmake more information in project command (version, ...)"
Tue, May 21, 3:18 PM
mgallien added a reverting change for R255:15577c799233: give cmake more information in project command (version, ...): R255:af758c666eb1: Revert "give cmake more information in project command (version, ...)".
Tue, May 21, 3:18 PM

Mon, May 20

mgallien committed R255:d31daf905b2a: master is where 0.4.80 version is being worked on (authored by mgallien).
master is where 0.4.80 version is being worked on
Mon, May 20, 5:43 AM
mgallien committed R255:4c9a2000f8c8: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
Mon, May 20, 5:43 AM
mgallien committed R255:15577c799233: give cmake more information in project command (version, ...) (authored by mgallien).
give cmake more information in project command (version, ...)
Mon, May 20, 5:39 AM
mgallien committed R234:2700a896522a: refresh screenshot of Elisa music player (authored by mgallien).
refresh screenshot of Elisa music player
Mon, May 20, 5:18 AM
mgallien committed R255:1799e834d0bf: prepare 0.4.0 version of Elisa (authored by mgallien).
prepare 0.4.0 version of Elisa
Mon, May 20, 5:12 AM
mgallien committed R255:3042289d23f6: add version 0.4.0 to appdata metadata file (authored by mgallien).
add version 0.4.0 to appdata metadata file
Mon, May 20, 5:12 AM

May 17 2019

mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.
  • use a rectangle around the current item with focus in view selector
  • use rectangle borders to show the active focus in most elements
May 17 2019, 6:42 PM · Elisa
mgallien committed R255:bc1e38eb5ad6: try to fix compile error in FreeBSD due to abs ambiguous call (authored by mgallien).
try to fix compile error in FreeBSD due to abs ambiguous call
May 17 2019, 5:35 AM
mgallien committed R255:60e5f348f4f2: try to fix compile error in FreeBSD due to abs ambiguous call (authored by mgallien).
try to fix compile error in FreeBSD due to abs ambiguous call
May 17 2019, 5:28 AM

May 16 2019

mgallien committed R255:14f555384381: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
May 16 2019, 8:08 PM
mgallien committed R255:47d329461c63: add new required tag to appstream metadata file (authored by mgallien).
add new required tag to appstream metadata file
May 16 2019, 8:08 PM
mgallien added inline comments to D21243: add OARS rating and some release to appdata file.
May 16 2019, 8:03 PM
mgallien added inline comments to D21243: add OARS rating and some release to appdata file.
May 16 2019, 7:53 PM
mgallien requested review of D21243: add OARS rating and some release to appdata file.
May 16 2019, 7:35 PM
mgallien requested review of D21242: add OARS rating and some release to appdata file.
May 16 2019, 7:28 PM

May 14 2019

mgallien accepted D21219: Don't try to index SQL database dumps.
May 14 2019, 9:12 PM · Baloo, Frameworks
mgallien committed R255:bbf9a4dd729e: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
May 14 2019, 5:31 AM
mgallien committed R255:c4c06554076b: compute correct sizes when using TextMetrics (authored by mgallien).
compute correct sizes when using TextMetrics
May 14 2019, 5:25 AM
mgallien closed D21198: compute correct sizes when using TextMetrics.
May 14 2019, 5:25 AM

May 13 2019

mgallien committed R255:dbc53064864b: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
May 13 2019, 9:03 PM
mgallien committed R255:3c8a07252d96: avoid calling in KFileMetaData::UserMetaData::userComment() on windows (authored by mgallien).
avoid calling in KFileMetaData::UserMetaData::userComment() on windows
May 13 2019, 9:03 PM
mgallien closed D21199: avoid calling in KFileMetaData::UserMetaData::userComment() on windows.
May 13 2019, 9:03 PM
mgallien added a comment to D21198: compute correct sizes when using TextMetrics.

Thanks, this fixes the problem in the playlist. I notice it's still there in the Frequently Played and Tracks lists, though:

May 13 2019, 9:02 PM
mgallien updated the diff for D21198: compute correct sizes when using TextMetrics.
  • fix views with list of tracks
May 13 2019, 9:01 PM
mgallien requested review of D21199: avoid calling in KFileMetaData::UserMetaData::userComment() on windows.
May 13 2019, 8:30 PM