mgallien (Matthieu Gallien)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 10 2015, 7:32 AM (162 w, 19 h)
Availability
Available

Recent Activity

Sun, Dec 16

mgallien committed R255:c563dc1b51fd: when showing albums from an artist from a genre also filter by genre (authored by mgallien).
when showing albums from an artist from a genre also filter by genre
Sun, Dec 16, 10:47 PM
mgallien committed R255:73eddef72039: use specific db requests instead of filtering in models (authored by mgallien).
use specific db requests instead of filtering in models
Sun, Dec 16, 10:47 PM
mgallien committed R255:073fa812f5f8: create and load data in models only on demand when the view is shown (authored by mgallien).
create and load data in models only on demand when the view is shown
Sun, Dec 16, 10:47 PM
mgallien committed R255:e818e8c8db58: remove no longer needed enqueue methods from MediaPlayList (authored by mgallien).
remove no longer needed enqueue methods from MediaPlayList
Sun, Dec 16, 10:47 PM
mgallien committed R255:2e88cbfaf5c5: no longer emit signals when reloading an existing database (authored by mgallien).
no longer emit signals when reloading an existing database
Sun, Dec 16, 10:47 PM
mgallien committed R255:8068a437b7d9: fix display of track durations in play list view (authored by mgallien).
fix display of track durations in play list view
Sun, Dec 16, 10:47 PM
mgallien committed R255:6c59a8d9408d: remove useless checks in MediaPlayList model (authored by mgallien).
remove useless checks in MediaPlayList model
Sun, Dec 16, 10:47 PM
mgallien committed R255:fc598bdc1994: fix display of single album view (authored by mgallien).
fix display of single album view
Sun, Dec 16, 10:47 PM
mgallien committed R255:be58b156bed5: fix genre navigation and actions of the inner views (authored by mgallien).
fix genre navigation and actions of the inner views
Sun, Dec 16, 10:47 PM
mgallien committed R255:9e6b3a02b327: fix single artist view to allow enqueue a single album (authored by mgallien).
fix single artist view to allow enqueue a single album
Sun, Dec 16, 10:47 PM
mgallien committed R255:adcc8395e301: fix single artist proxy model filtering (authored by mgallien).
fix single artist proxy model filtering
Sun, Dec 16, 10:47 PM
mgallien committed R255:184419ad1613: fix Javascript warnings in ViewManager (authored by mgallien).
fix Javascript warnings in ViewManager
Sun, Dec 16, 10:47 PM
mgallien committed R255:0827ca01c9a9: fix a few warnings of MediaPlayer2Player around numbers (authored by mgallien).
fix a few warnings of MediaPlayer2Player around numbers
Sun, Dec 16, 10:47 PM
mgallien committed R255:8b03c5095a21: fix most of issues with signle album view (authored by mgallien).
fix most of issues with signle album view
Sun, Dec 16, 10:47 PM
mgallien committed R255:846ff96b8d06: fix enqueue and replace from all main views (except genre) (authored by mgallien).
fix enqueue and replace from all main views (except genre)
Sun, Dec 16, 10:47 PM
mgallien committed R255:658049fc1a33: fix enqueue and replace of signle entries from main views (not genre) (authored by mgallien).
fix enqueue and replace of signle entries from main views (not genre)
Sun, Dec 16, 10:47 PM
mgallien committed R255:6f0dcf71d737: move global types from MediaPlayList to ElisaUtils (authored by mgallien).
move global types from MediaPlayList to ElisaUtils
Sun, Dec 16, 10:47 PM
mgallien committed R255:02adf19e58e0: remove some signals from MediaPlayList in favor of a generic one (authored by mgallien).
remove some signals from MediaPlayList in favor of a generic one
Sun, Dec 16, 10:47 PM
mgallien committed R255:dba025f39a0c: continue to modify playlist to have fewer enqueue methods and use ids (authored by mgallien).
continue to modify playlist to have fewer enqueue methods and use ids
Sun, Dec 16, 10:47 PM
mgallien committed R255:c61fc64c127a: replace more MediaPlayList::enque methods by the generic ones (authored by mgallien).
replace more MediaPlayList::enque methods by the generic ones
Sun, Dec 16, 10:47 PM
mgallien committed R255:aff0f4d7fcf7: make MediaPlayList::enqueue(QString) private and use generic one (authored by mgallien).
make MediaPlayList::enqueue(QString) private and use generic one
Sun, Dec 16, 10:47 PM
mgallien committed R255:d19d3370ee63: moves to a more generic way to enqueue element by id in playlist (authored by mgallien).
moves to a more generic way to enqueue element by id in playlist
Sun, Dec 16, 10:47 PM
mgallien committed R255:58ae69c1ec8b: remove debug prints in TracksListener (authored by mgallien).
remove debug prints in TracksListener
Sun, Dec 16, 10:47 PM
mgallien committed R255:6b4a6f8287af: makes PlayListView works with the new version of MediaPlayList (authored by mgallien).
makes PlayListView works with the new version of MediaPlayList
Sun, Dec 16, 10:47 PM
mgallien committed R255:fb061914da0e: remove ImageRole role: useless and duplicated (authored by mgallien).
remove ImageRole role: useless and duplicated
Sun, Dec 16, 10:47 PM
mgallien committed R255:71e8bc683a53: finish fixing all failed tests of MdeiaPlayList (authored by mgallien).
finish fixing all failed tests of MdeiaPlayList
Sun, Dec 16, 10:47 PM
mgallien committed R255:dcb135824b8c: more fixes to MediaPlayList to restore previous features (authored by mgallien).
more fixes to MediaPlayList to restore previous features
Sun, Dec 16, 10:47 PM
mgallien committed R255:f0631623f435: partially fix MediaPlayList (authored by mgallien).
partially fix MediaPlayList
Sun, Dec 16, 10:47 PM
mgallien committed R255:5b1f17126c45: fix database to have the track file as data when getting one track (authored by mgallien).
fix database to have the track file as data when getting one track
Sun, Dec 16, 10:47 PM
mgallien committed R255:baf6c0ad1ac1: uses string types for music data of different kinds (authored by mgallien).
uses string types for music data of different kinds
Sun, Dec 16, 10:47 PM
mgallien committed R255:3606cab7f2fe: fix MediaPlayList to partially works with data instead of objects (authored by mgallien).
fix MediaPlayList to partially works with data instead of objects
Sun, Dec 16, 10:47 PM
mgallien committed R255:ee26e6374d6f: add DatabaseInterface::trackDataFromDatabaseId to get track data (authored by mgallien).
add DatabaseInterface::trackDataFromDatabaseId to get track data
Sun, Dec 16, 10:47 PM
mgallien committed R255:7b45198d793e: upgrade the views to work with the new models (authored by mgallien).
upgrade the views to work with the new models
Sun, Dec 16, 10:47 PM
mgallien committed R255:675676b8cfe0: use DataListType for all kind of data changes signals in database (authored by mgallien).
use DataListType for all kind of data changes signals in database
Sun, Dec 16, 10:47 PM
mgallien committed R255:636066771418: remove ElisaUtils::ColumnsRoles after move to DatabaseInterface (authored by mgallien).
remove ElisaUtils::ColumnsRoles after move to DatabaseInterface
Sun, Dec 16, 10:47 PM
mgallien committed R255:a312cf1aa588: remove all usage of MusicArtist (authored by mgallien).
remove all usage of MusicArtist
Sun, Dec 16, 10:47 PM
mgallien committed R255:d9c1eb1d97d4: replace DatabaseInterface::allArtists() by DatabaseInterface::allData (authored by mgallien).
replace DatabaseInterface::allArtists() by DatabaseInterface::allData
Sun, Dec 16, 10:47 PM
mgallien committed R255:1a48a8a49e93: remove artistModified signal from DatabaseInterface: never used (authored by mgallien).
remove artistModified signal from DatabaseInterface: never used
Sun, Dec 16, 10:47 PM
mgallien committed R255:5f2cb624defe: remove methods to get all artists, composers and lyricists (authored by mgallien).
remove methods to get all artists, composers and lyricists
Sun, Dec 16, 10:47 PM
mgallien committed R255:61c7b34e35b6: remove ModelDataCache class that will never get used (authored by mgallien).
remove ModelDataCache class that will never get used
Sun, Dec 16, 10:47 PM

Thu, Dec 13

mgallien added a comment to D17500: Restore mobipocket extractor.

Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a straight port :(
Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail extractor actually be part of kio-extras? Seems quite kio-specific, and a quick look at lxr didn't reveal any usages of the thumbnailer.

Why would it be part of kio-extras? the beauty of plugins is that they can live wherever, no?

Do I understand that the answer to my "Is it possible to move the extractor to kdegraphics-mobipocket instead of having it in kfilemetadata? " question is no?

Thu, Dec 13, 7:42 AM · Baloo, Frameworks

Sun, Dec 9

mgallien committed R255:f97cce53a7d6: Display embedded cover images (authored by mgallien).
Display embedded cover images
Sun, Dec 9, 7:49 PM
mgallien closed D17163: Display embedded cover images.
Sun, Dec 9, 7:49 PM · Elisa

Wed, Nov 28

mgallien added a project to D17163: Display embedded cover images: Elisa.
Wed, Nov 28, 8:56 PM · Elisa

Tue, Nov 27

mgallien committed R256:02b2b62993cf: no longer bundle kdeclarative with elisa (authored by mgallien).
no longer bundle kdeclarative with elisa
Tue, Nov 27, 4:41 PM

Sun, Nov 25

mgallien requested review of D17163: Display embedded cover images.
Sun, Nov 25, 9:41 PM · Elisa
mgallien committed R255:fde30aa8c9df: improve database performance and reliability (authored by mgallien).
improve database performance and reliability
Sun, Nov 25, 7:27 PM
mgallien committed R255:28769a64efc2: fix import of tracks with paths containing particular character like { } (authored by mgallien).
fix import of tracks with paths containing particular character like { }
Sun, Nov 25, 7:27 PM
mgallien committed R255:e3cd920c63ca: really cache only artists and not the other people (authored by mgallien).
really cache only artists and not the other people
Sun, Nov 25, 7:27 PM
mgallien committed R255:40f275ae3ce5: allow tracks without artist (authored by mgallien).
allow tracks without artist
Sun, Nov 25, 7:27 PM
mgallien committed R255:7c4cfa460920: fix errors when inserting multiple albums with same title (authored by mgallien).
fix errors when inserting multiple albums with same title
Sun, Nov 25, 7:27 PM
mgallien committed R255:1163bb71e1e4: add albums and artists cache and improve cache usage (authored by mgallien).
add albums and artists cache and improve cache usage
Sun, Nov 25, 7:27 PM
mgallien committed R255:7cbe013afe91: improve management of files not modified since last scan of music files (authored by mgallien).
improve management of files not modified since last scan of music files
Sun, Nov 25, 7:27 PM
mgallien committed R255:f58bdd48ec15: add a test for DatabaseInterface::askRestoredTracks (authored by mgallien).
add a test for DatabaseInterface::askRestoredTracks
Sun, Nov 25, 7:27 PM
mgallien committed R255:f7990d3052bb: keep all files discovered from a source and fix a minor related issue (authored by mgallien).
keep all files discovered from a source and fix a minor related issue
Sun, Nov 25, 7:27 PM
mgallien committed R255:a45a570450c3: reduce overhead of AllAlbumsModel and make it synchronous (authored by mgallien).
reduce overhead of AllAlbumsModel and make it synchronous
Sun, Nov 25, 7:27 PM
mgallien committed R255:b33cc33224bd: do not list files too early from Baloo (authored by mgallien).
do not list files too early from Baloo
Sun, Nov 25, 7:27 PM
mgallien committed R255:67bce5909c93: remove TracksArtists Table (authored by mgallien).
remove TracksArtists Table
Sun, Nov 25, 7:27 PM
mgallien committed R255:e84ee95d94a5: reduce overhead from AllTracksModel (authored by mgallien).
reduce overhead from AllTracksModel
Sun, Nov 25, 7:27 PM
mgallien committed R255:e200b17ab6c5: [WIP] improve database performance and reliability (authored by mgallien).
[WIP] improve database performance and reliability
Sun, Nov 25, 7:27 PM
mgallien committed R255:6022598637ff: album artist name is directly a foreign key in Albums (authored by mgallien).
album artist name is directly a foreign key in Albums
Sun, Nov 25, 7:27 PM
mgallien committed R255:9fa5ca30958d: use the unique fields of Albums for foreign key in Tracks (authored by mgallien).
use the unique fields of Albums for foreign key in Tracks
Sun, Nov 25, 7:27 PM
mgallien committed R255:6f3e8125f51e: let fix warnings from QtCreator in database tests (authored by mgallien).
let fix warnings from QtCreator in database tests
Sun, Nov 25, 7:27 PM
mgallien committed R255:89bcd208ac7e: DatabaseInterface: does not emit track changed signals for newly added (authored by mgallien).
DatabaseInterface: does not emit track changed signals for newly added
Sun, Nov 25, 7:27 PM
mgallien committed R255:1eb854dcda97: let the numeric unique id starts at 1 instead of 2 (authored by mgallien).
let the numeric unique id starts at 1 instead of 2
Sun, Nov 25, 7:27 PM
mgallien committed R255:cd8062fb91c3: let database test addOneTrackWithoutAlbumArtist have a file database (authored by mgallien).
let database test addOneTrackWithoutAlbumArtist have a file database
Sun, Nov 25, 7:27 PM
mgallien closed D16302: improve database performance and reliability.
Sun, Nov 25, 7:27 PM · Elisa
mgallien updated the summary of D16302: improve database performance and reliability.
Sun, Nov 25, 7:25 PM · Elisa

Tue, Nov 20

mgallien added a comment to D16302: improve database performance and reliability.

Since this revision is quite large, it's probably difficult to review it properly. I'm going to let it run a little and report back in case I find any issues.

Tue, Nov 20, 9:43 PM · Elisa
mgallien updated the diff for D16302: improve database performance and reliability.
  • fix errors when inserting multiple albums with same title
  • really cache only artists and not the other people
  • fix import of tracks with paths containing particular character like { }
Tue, Nov 20, 9:35 PM · Elisa
mgallien accepted D17046: Use the new FindExiv2 module from ECM..

Please feel free to land this after solving my comment.

Tue, Nov 20, 1:02 PM · Baloo, Frameworks

Mon, Nov 19

mgallien requested changes to D16944: Port application menu to qqc2.

The menu is no longer a sub window manage by the windowing system. Is this really a good idea ?

Mon, Nov 19, 8:26 PM · Elisa

Nov 17 2018

mgallien added a comment to D16302: improve database performance and reliability.

Since this revision is quite large, it's probably difficult to review it properly. I'm going to let it run a little and report back in case I find any issues.

Nov 17 2018, 8:48 PM · Elisa
mgallien updated the diff for D16302: improve database performance and reliability.
  • allow tracks without artist
Nov 17 2018, 3:14 PM · Elisa
mgallien updated the diff for D16302: improve database performance and reliability.
  • reduce overhead from AllTracksModel
  • reduce overhead of AllAlbumsModel and make it synchronous
  • do not list files too early from Baloo
  • keep all files discovered from a source and fix a minor related issue
  • add a test for DatabaseInterface::askRestoredTracks
  • add albums and artists cache and improve cache usage
  • improve management of files not modified since last scan of music files
Nov 17 2018, 2:14 PM · Elisa
mgallien accepted D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.
Nov 17 2018, 8:38 AM · Elisa
mgallien accepted D16360: handle empty metadata more gracefully in metadataview.
Nov 17 2018, 8:37 AM
mgallien accepted D16362: use rating and comment stored in metadata tags.

Sorry for the delay

Nov 17 2018, 8:36 AM · Elisa

Nov 15 2018

mgallien abandoned D15965: allow subsequent cmake execution to not found libvlc (if not here).

Sorry

Nov 15 2018, 1:50 PM

Nov 13 2018

mgallien updated the summary of D16302: improve database performance and reliability.
Nov 13 2018, 6:39 AM · Elisa
mgallien retitled D16302: improve database performance and reliability from [WIP] improve database performance and reliability to improve database performance and reliability.
Nov 13 2018, 6:38 AM · Elisa
mgallien updated the diff for D16302: improve database performance and reliability.
  • reduce overhead from AllTracksModel
  • reduce overhead of AllAlbumsModel and make it synchronous
  • do not list files too early from Baloo
  • keep all files discovered from a source and fix a minor related issue
  • add a test for DatabaseInterface::askRestoredTracks
  • add albums and artists cache and improve cache usage
  • improve management of files not modified since last scan of music files
Nov 13 2018, 6:38 AM · Elisa

Nov 2 2018

mgallien accepted D16618: add explicit to constructors.
Nov 2 2018, 10:46 PM · Baloo, Frameworks
mgallien added inline comments to D16618: add explicit to constructors.
Nov 2 2018, 9:05 PM · Baloo, Frameworks
mgallien added a comment to D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.

see D16284

I have been working on this subject to help come this diff come to a conclusion. Thanks for your work on this as it is important.

I believe that we have been overusing ToolButton at places just to get a flat look instead of doing the proper job (i.e. customizing the look of a Button component).

I also better understand (thanks to D16284) why we get icon+text. I believe that this will not change as it is done on purpose to maximize compatibility with QWidget equivalent of ToolButton. We are the guilty ones here given we had used ToolButton components in places where we expected a custom behavior (i.e. no text).

I have a private (at the moment) branch with no QQCv1 components. There are several regressions. I had kept overusing ToolButton like in master branch.

I would like to try to come up with a long term and maintainable solution for each of our button cases:

  • flat button with text and icon ;
  • flat button with tooltip and icon ;
  • flat round button with icon ;

    The result should be fully usable with keyboard only, mouse+keyboard and touch screens. That means that ToolButton as is is not the solution because the focus behavior is not going to work for keyboard only usage. Our solution should work with org.kde.desktop and Fusion style (at least).

I've gone ahead and factored out the current button code that was copied all over in MediaPlayerControl. As it is now, it's mostly a refactoring only with the exception that actions are now used.
Imho we don't need a round button anymore.
If you agree on the implementation, I will roll this out to all qqc1 toolbuttons in the views and playlist.

Nov 2 2018, 9:37 AM · Elisa
mgallien added inline comments to D16362: use rating and comment stored in metadata tags.
Nov 2 2018, 9:14 AM · Elisa

Oct 31 2018

mgallien committed R255:3fb83255f94e: fix a few warnings from clazy and QtCreator (static analysis) (authored by mgallien).
fix a few warnings from clazy and QtCreator (static analysis)
Oct 31 2018, 12:16 PM

Oct 30 2018

mgallien added a comment to D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.

see D16284

Oct 30 2018, 11:09 AM · Elisa

Oct 26 2018

mgallien added inline comments to D16362: use rating and comment stored in metadata tags.
Oct 26 2018, 5:03 AM · Elisa

Oct 23 2018

mgallien requested changes to D16360: handle empty metadata more gracefully in metadataview.
Oct 23 2018, 3:51 PM
mgallien accepted D16193: add a test for tracks with empty artist tag in database.

Nice, thanks

Oct 23 2018, 3:26 PM · Elisa
mgallien committed R255:aca5110b92d9: put the test data in DatabaseTestData class (authored by mgallien).
put the test data in DatabaseTestData class
Oct 23 2018, 3:25 PM
mgallien closed D16233: put the test data in DatabaseTestData class.
Oct 23 2018, 3:25 PM
mgallien requested review of D16390: fix some layout limitations in media play list.
Oct 23 2018, 3:24 PM

Oct 18 2018

mgallien updated the diff for D16233: put the test data in DatabaseTestData class.

rebase

Oct 18 2018, 4:57 PM
mgallien updated the diff for D15015: initial support for android music indexer and a very small kirigami2 UI.
  • let kirigami be required only on Android
Oct 18 2018, 4:50 PM · Elisa
mgallien triaged T9896: Add support for music indexing on Android as High priority.
Oct 18 2018, 4:40 PM · Elisa
mgallien added a project to D15015: initial support for android music indexer and a very small kirigami2 UI: Elisa.
Oct 18 2018, 4:40 PM · Elisa
mgallien added a revision to T9896: Add support for music indexing on Android: D15015: initial support for android music indexer and a very small kirigami2 UI.
Oct 18 2018, 4:40 PM · Elisa
mgallien added a task to D15015: initial support for android music indexer and a very small kirigami2 UI: T9896: Add support for music indexing on Android.
Oct 18 2018, 4:40 PM · Elisa