mgallien (Matthieu Gallien)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 10 2015, 7:32 AM (179 w, 3 d)
Availability
Available

Recent Activity

Yesterday

mgallien requested review of D20670: automatically hide undo notification 3 seconds after it has been shown.
Thu, Apr 18, 3:41 PM
mgallien closed T5376: Allow to undo the clear actions on the playlist as Resolved.
Thu, Apr 18, 3:28 PM · Elisa
mgallien added a comment to D20502: Check for string lists and multi-values in property map.

I am missing time to investigate deep enough in KFileMetaData and Baloo but if D20526 lands, why this diff would still be needed ?

Thu, Apr 18, 6:03 AM
mgallien accepted D20531: Use artist when inserting a new album when album artist is not available.

This is used only when adding the album (insertAlbum function). It is not added to the tracks in the database, so I believe this change is correct. This is also done the same way a few lines above when checking for albums already in the database. I will change the title to make that clear.

Thu, Apr 18, 6:01 AM
mgallien added a comment to D20581: Revamp grid browser delegates to improve UI.

For user interfaces where you want single-click-to-open, but allow multi-item selection, I think a dedicated selection mode is generally the way to go. On mobile, entering this mode is accomplished by pressing -and-holding on an item (Android) or tapping the Select button on a toolbar somewhere (iOS). On the desktop, those would be supplemented by the typical ctrl+click selection method for expert users who use keyboards shortcuts.

I've been wanting to get this interface implemented in KDE software for a while now, see T9895: Improving single-click.

Thu, Apr 18, 5:53 AM

Wed, Apr 17

mgallien added a comment to D20636: allow to activate/deactivate the progress indicator on task bar entry.

Thanks! Given that Elisa has a settings window, I would recommend locating the setting there rather than having a menu item for it in the hamburger menu.

Wed, Apr 17, 3:44 PM
mgallien added a comment to D20581: Revamp grid browser delegates to improve UI.

I am working on a detailed feedback but I have already a few remarks.
I am no longer able to use Elisa with my touchscreen. Without your modifications, it is possible to touch an album to get the buttons and then act like if I had a mouse. With your patch, I am only able to enter into an album but not enqueue it.

This is a generic problem with using hover-based user interfaces that's sort of unsolvable. However, note that no features have been lost for touch users and it is still possible to perform these actions via the buttons above the grid view: first you tap an album to enter it, then you tap "Enqueue" or "Replace and Play". This is only two steps, which is the same number of steps previously required (tap album to display hover buttons, tap inline button corresponding to desired action).

Wed, Apr 17, 3:42 PM
mgallien updated subscribers of T10800: Send CI build mails of Elisa to the Elisa mailing list.

Thanks @bcooksley for your help.

Wed, Apr 17, 3:34 PM · Elisa, build.kde.org
mgallien requested review of D20636: allow to activate/deactivate the progress indicator on task bar entry.
Wed, Apr 17, 3:34 PM
mgallien committed R255:2634bb02f86f: compilation fixes for macOS (authored by mgallien).
compilation fixes for macOS
Wed, Apr 17, 5:29 AM

Tue, Apr 16

mgallien accepted D20577: Don't adjust the sidebar size with the window size, and reduce the text size a bit.

Nice !
Thanks

Tue, Apr 16, 3:42 PM
mgallien requested changes to D20531: Use artist when inserting a new album when album artist is not available.

Thanks for your work.
I believe that the way the tests are modified is correct.
The database part should instead modify the way data are read to fallback to the track artist without writing data to the database that does not really exist.
I can provide you pointers on how to achieve that if you want.

Tue, Apr 16, 3:38 PM
mgallien committed R255:62585267ff44: update the readme for packagers with the list of dependencies (authored by mgallien).
update the readme for packagers with the list of dependencies
Tue, Apr 16, 3:27 PM
mgallien committed R877:0fd5786b6db9: master branch of elisa requires kirigami dependency (authored by mgallien).
master branch of elisa requires kirigami dependency
Tue, Apr 16, 3:19 PM
mgallien committed R255:79ffb592e8d4: in fact after D19610, Kirigami2 is always required (authored by mgallien).
in fact after D19610, Kirigami2 is always required
Tue, Apr 16, 3:16 PM
mgallien renamed T10800: Send CI build mails of Elisa to the Elisa mailing list from Send BI build mails of Elisa to the Elisa mailing list to Send CI build mails of Elisa to the Elisa mailing list.
Tue, Apr 16, 8:20 AM · Elisa, build.kde.org
mgallien committed R255:ca5e2ab83999: fix one build issue on macOS (authored by mgallien).
fix one build issue on macOS
Tue, Apr 16, 5:49 AM
mgallien committed R255:a61960e6faaf: fix another compilation issue on macOS (authored by mgallien).
fix another compilation issue on macOS
Tue, Apr 16, 5:49 AM

Mon, Apr 15

mgallien requested changes to D20581: Revamp grid browser delegates to improve UI.
Mon, Apr 15, 8:33 PM
mgallien added a comment to D20581: Revamp grid browser delegates to improve UI.

I am working on a detailed feedback but I have already a few remarks.
I am no longer able to use Elisa with my touchscreen. Without your modifications, it is possible to touch an album to get the buttons and then act like if I had a mouse. With your patch, I am only able to enter into an album but not enqueue it. One possibility is maybe to use dedicated components for detecting touch interactions.

Mon, Apr 15, 8:33 PM
mgallien added inline comments to D20577: Don't adjust the sidebar size with the window size, and reduce the text size a bit.
Mon, Apr 15, 6:43 PM
mgallien created T10800: Send CI build mails of Elisa to the Elisa mailing list.
Mon, Apr 15, 5:19 PM · Elisa, build.kde.org
mgallien accepted D20578: Don't elide strings in the HeaderBar when there's plenty of space.

Thanks

Mon, Apr 15, 5:13 PM
mgallien committed R255:cca9f0b87d57: add windows.h include before winbase.h to try to fix Windows compilation (authored by mgallien).
add windows.h include before winbase.h to try to fix Windows compilation
Mon, Apr 15, 4:47 PM
mgallien added a comment to D20577: Don't adjust the sidebar size with the window size, and reduce the text size a bit.

I don't think it's my place to review this, but wanted to say I've been testing out Elisa these past few days and also felt like the sidebar text size would be better if it were smaller. Looks really nice in the screenshot!

Mon, Apr 15, 4:41 PM
mgallien added inline comments to D20577: Don't adjust the sidebar size with the window size, and reduce the text size a bit.
Mon, Apr 15, 4:40 PM
mgallien committed R255:58669d531a99: unbreak Windows compilation due to missing include (authored by mgallien).
unbreak Windows compilation due to missing include
Mon, Apr 15, 4:38 PM
mgallien committed R255:ae6b0a1b77a3: fix restore of play position when undo playlist clear (authored by mgallien).
fix restore of play position when undo playlist clear
Mon, Apr 15, 4:35 PM
mgallien committed R255:98a7a7ae4df6: start to add support for saved position during undo/redo of playlist (authored by mgallien).
start to add support for saved position during undo/redo of playlist
Mon, Apr 15, 4:01 PM
mgallien committed R255:25661f6b19f2: add a logging category for QtMultimedia support code (authored by mgallien).
add a logging category for QtMultimedia support code
Mon, Apr 15, 4:01 PM
mgallien closed T10330: Implement new context view from mockup as Resolved.
Mon, Apr 15, 5:51 AM · Elisa
mgallien closed T10360: Implement Power Management Sleep Inhibition while Playing Music as Resolved.
Mon, Apr 15, 5:51 AM · Elisa
mgallien moved T10360: Implement Power Management Sleep Inhibition while Playing Music from In Progress to Done on the Elisa board.
Mon, Apr 15, 5:51 AM · Elisa
mgallien moved T10330: Implement new context view from mockup from In Progress to Done on the Elisa board.
Mon, Apr 15, 5:51 AM · Elisa
mgallien closed D18351: Prevent the host computer to sleep while playing music.
Mon, Apr 15, 5:46 AM · Elisa
mgallien committed R255:a44ad7b41267: Prevent the host computer to sleep while playing music (authored by mgallien).
Prevent the host computer to sleep while playing music
Mon, Apr 15, 5:46 AM
mgallien updated the diff for D18351: Prevent the host computer to sleep while playing music.
  • implement more methods to inhibit sleep (support Gnome and Logind)
  • prevent sleep again on Plasma workspace
  • remove the calls to logind inhibit interface: does nothing right now
Mon, Apr 15, 5:36 AM · Elisa
mgallien committed R255:c3cb65b73996: Implement new context view with metadata (authored by mgallien).
Implement new context view with metadata
Mon, Apr 15, 5:20 AM
mgallien committed R255:3239643239b5: change the way lyrics and other metadata are shown and improve lyrics (authored by mgallien).
change the way lyrics and other metadata are shown and improve lyrics
Mon, Apr 15, 5:20 AM
mgallien committed R255:67042c8fcd8e: add support for fetching lyrics in TrackMetaDataModel and display it (authored by mgallien).
add support for fetching lyrics in TrackMetaDataModel and display it
Mon, Apr 15, 5:20 AM
mgallien committed R255:951771dbc620: ensure metadata is refreshed in context view when track changes (authored by mgallien).
ensure metadata is refreshed in context view when track changes
Mon, Apr 15, 5:20 AM
mgallien committed R255:7457ddfe956d: fix ContextView to no longer generate errors when shown (authored by mgallien).
fix ContextView to no longer generate errors when shown
Mon, Apr 15, 5:20 AM
mgallien committed R255:0e9abefea16a: add possibility to handle Lyrics KFileMetaData property (authored by mgallien).
add possibility to handle Lyrics KFileMetaData property
Mon, Apr 15, 5:20 AM
mgallien committed R255:8c75d1209692: fix update of metadata model when a track change (authored by mgallien).
fix update of metadata model when a track change
Mon, Apr 15, 5:20 AM
mgallien committed R255:5d1b080c3727: DatabaseInterface::trackHasStartedPlaying notify modified tracks (authored by mgallien).
DatabaseInterface::trackHasStartedPlaying notify modified tracks
Mon, Apr 15, 5:20 AM
mgallien committed R255:b92110827ee6: do not display disc number when only one disc (authored by mgallien).
do not display disc number when only one disc
Mon, Apr 15, 5:20 AM
mgallien committed R255:2bf9cc7c808f: adapt context view to tracks missing album name or artist name or both (authored by mgallien).
adapt context view to tracks missing album name or artist name or both
Mon, Apr 15, 5:20 AM
mgallien committed R255:a79247b6100c: add the filename at bottom of context view (authored by mgallien).
add the filename at bottom of context view
Mon, Apr 15, 5:20 AM
mgallien committed R255:4c74ea0bc24c: Implement new context view with metadata (authored by mgallien).
Implement new context view with metadata
Mon, Apr 15, 5:20 AM
mgallien committed R255:8ff4b7195ad8: when showing ContextView, fix width to not overflow (authored by mgallien).
when showing ContextView, fix width to not overflow
Mon, Apr 15, 5:20 AM
mgallien committed R255:ffe312f1bfd5: remove useless debug prints (authored by mgallien).
remove useless debug prints
Mon, Apr 15, 5:20 AM
mgallien committed R255:3645b1f3a244: provide new context view with metadata from currently playing track (authored by mgallien).
provide new context view with metadata from currently playing track
Mon, Apr 15, 5:20 AM
mgallien committed R255:1322313da888: fix size of the cover in context view (authored by mgallien).
fix size of the cover in context view
Mon, Apr 15, 5:20 AM
mgallien committed R255:90f77ec8da3f: fix TrackMetadataModel to not create multiple connections (authored by mgallien).
fix TrackMetadataModel to not create multiple connections
Mon, Apr 15, 5:20 AM
mgallien committed R255:0193e73cd742: introduce TrackContextMetadataModel to display metadata in context view (authored by mgallien).
introduce TrackContextMetadataModel to display metadata in context view
Mon, Apr 15, 5:20 AM
mgallien committed R255:83a262ab9825: do not always put a value for disc number when the metadata is not here (authored by mgallien).
do not always put a value for disc number when the metadata is not here
Mon, Apr 15, 5:20 AM
mgallien committed R255:c263529ed32e: allow to inherit from TrackMetadataModel to filter properties (authored by mgallien).
allow to inherit from TrackMetadataModel to filter properties
Mon, Apr 15, 5:20 AM
mgallien committed R255:d5bbc17e7f30: remove obsolete methods from TrackMetadataModel (authored by mgallien).
remove obsolete methods from TrackMetadataModel
Mon, Apr 15, 5:20 AM
mgallien committed R255:8687684e2ab3: enlarge the context view to fit new content (authored by mgallien).
enlarge the context view to fit new content
Mon, Apr 15, 5:20 AM
mgallien committed R255:b466fbab044d: in the detailed metadata view compose the property name with i18nc (authored by mgallien).
in the detailed metadata view compose the property name with i18nc
Mon, Apr 15, 5:20 AM
mgallien committed R255:bddd9d74d640: allow ManageHeaderBar to export a databaseId property for current track (authored by mgallien).
allow ManageHeaderBar to export a databaseId property for current track
Mon, Apr 15, 5:20 AM
mgallien closed D18679: Implement new context view with metadata.
Mon, Apr 15, 5:20 AM

Sun, Apr 14

mgallien updated the diff for D18679: Implement new context view with metadata.
  • adapt context view to tracks missing album name or artist name or both
  • do not display disc number when only one disc
  • DatabaseInterface::trackHasStartedPlaying notify modified tracks
  • fix update of metadata model when a track change
  • fix ContextView to no longer generate errors when shown
  • add possibility to handle Lyrics KFileMetaData property
  • add support for fetching lyrics in TrackMetaDataModel and display it
  • ensure metadata is refreshed in context view when track changes
  • change the way lyrics and other metadata are shown and improve lyrics
Sun, Apr 14, 9:30 PM
mgallien requested review of D20526: fix extracting of some properties to match what was writen.
Sun, Apr 14, 8:43 AM · Baloo, Frameworks

Sat, Apr 13

mgallien added a comment to T7567: Add support for radio streams.

Hello,

Hi,

According to the libvlc documentation, the method libvlc_media_new_location should be nice with some URL: https://www.videolan.org/developers/vlc/doc/doxygen/html/group__libvlc__media.html#gae1d3baee3f4610c6fe5818defcad3e6f .

I am motivated to take a look.

Sat, Apr 13, 8:12 PM · Elisa
mgallien accepted D20511: When not displaying rating, leave more room for song title in playlist.

Thanks

Sat, Apr 13, 8:09 PM
mgallien requested changes to D20502: Check for string lists and multi-values in property map.
Sat, Apr 13, 8:08 PM
mgallien added a comment to D20502: Check for string lists and multi-values in property map.

I will have a look thanks.
I will also have a look at your other suggestions.
I hope to be able to do it this week-end if time permits.

Sat, Apr 13, 9:12 AM

Fri, Apr 12

mgallien added a comment to D19610: Allow to undo the clear actions on the playlist.

Hi,

I am deeply sorry for the silence, I was quite busy these days and did not see the notifications going on.

Fri, Apr 12, 9:09 PM · Elisa
mgallien committed R255:c8a43561ae98: Allow to undo the clear actions on the playlist (authored by jguidon).
Allow to undo the clear actions on the playlist
Fri, Apr 12, 9:03 PM
mgallien closed D19610: Allow to undo the clear actions on the playlist.
Fri, Apr 12, 9:03 PM · Elisa
mgallien updated the diff for D18679: Implement new context view with metadata.
  • add support for fetching lyrics in TrackMetaDataModel and display it
  • ensure metadata is refreshed in context view when track changes
Fri, Apr 12, 8:55 PM
mgallien updated the diff for D18679: Implement new context view with metadata.
  • adapt context view to tracks missing album name or artist name or both
  • do not display disc number when only one disc
  • DatabaseInterface::trackHasStartedPlaying notify modified tracks
  • fix update of metadata model when a track change
  • fix ContextView to no longer generate errors when shown
  • add possibility to handle Lyrics KFileMetaData property
  • add support for fetching lyrics in TrackMetaDataModel
  • improve display of long lyrics by adding a vertical scroll bar
  • ensure metadata is refreshed in context view when track changes
Fri, Apr 12, 7:46 PM
mgallien added a comment to D19610: Allow to undo the clear actions on the playlist.

@jguidon I hope everything is fine for you. It would really great to have your contribution land in master branch. This is a really nice improvement.
It seems you are not yet a KDE contributor. I should land your branch but there is very small issues to fix. Do you want me to finish the work or are you able to do it ?

Fri, Apr 12, 5:16 AM · Elisa

Thu, Apr 11

mgallien committed R255:e803fba95bda: fix wrong index in automatic test of DataModel (authored by mgallien).
fix wrong index in automatic test of DataModel
Thu, Apr 11, 9:08 PM
mgallien requested review of D20476: [WIP] starts to make the list of renderers available and use it to play music.
Thu, Apr 11, 8:57 PM
mgallien committed R255:a5c577fb930f: fix tracks order in single album model when new tracks are added (authored by mgallien).
fix tracks order in single album model when new tracks are added
Thu, Apr 11, 7:54 PM

Wed, Apr 10

mgallien committed R255:2f3e5f104d8f: switch artist to the album one before displaying an album from an artist (authored by mgallien).
switch artist to the album one before displaying an album from an artist
Wed, Apr 10, 1:01 PM

Tue, Apr 9

mgallien updated the diff for D18679: Implement new context view with metadata.
  • adapt context view to tracks missing album name or artist name or both
  • do not display disc number when only one disc
  • DatabaseInterface::trackHasStartedPlaying notify modified tracks
  • fix update of metadata model when a track change
  • fix ContextView to no longer generate errors when shown
  • add possibility to handle Lyrics KFileMetaData property
  • add support for fetching lyrics in TrackMetaDataModel
Tue, Apr 9, 10:02 PM
mgallien committed R255:91f24645cdf4: improve naming of a variable to help understand the code (authored by mgallien).
improve naming of a variable to help understand the code
Tue, Apr 9, 9:27 PM
mgallien added a comment to T5375: Add Management of Ratings for Tracks from Local Files.

FYI, writing rating information was added to KF 5.57 via the TagLib writer plugin

Tue, Apr 9, 8:20 AM · Elisa

Mon, Apr 8

mgallien committed R255:144291ba724e: fix local file indexer not starting if Baloo is unavailable (authored by mgallien).
fix local file indexer not starting if Baloo is unavailable
Mon, Apr 8, 7:39 PM

Sat, Apr 6

mgallien accepted D20310: Use nullptr instead of NULL.

Thanks

Sat, Apr 6, 5:11 PM · Baloo, Frameworks

Thu, Apr 4

mgallien added a comment to D19610: Allow to undo the clear actions on the playlist.

Ping

Thu, Apr 4, 8:02 PM · Elisa

Wed, Apr 3

mgallien closed T9082: Add filtering by path in the Baloo support as Resolved.
Wed, Apr 3, 8:24 PM · Elisa
mgallien moved T9082: Add filtering by path in the Baloo support from In Progress to Done on the Elisa board.
Wed, Apr 3, 8:24 PM · Elisa
mgallien accepted D20219: Propose Stefan Bruns as KFileMetaData maintainer.

Thanks for all the work going on. I am really happy to see all the work done by @bruns

Wed, Apr 3, 4:22 AM · Baloo, Frameworks

Tue, Apr 2

mgallien added a comment to D18679: Implement new context view with metadata.

Pretty great. Could the context view also show the lyrics from the currently playing song's lyrics tag (if present?). That would make this a CCBUG: 401969 :)

Tue, Apr 2, 7:33 AM

Mon, Apr 1

mgallien updated the diff for D18679: Implement new context view with metadata.
  • do not display disc number when only one disc
  • DatabaseInterface::trackHasStartedPlaying notify modified tracks
  • fix update of metadata model when a track change
  • fix ContextView to no longer generate errors when shown
Mon, Apr 1, 9:14 PM

Sun, Mar 31

mgallien updated the diff for D18679: Implement new context view with metadata.
  • adapt context view to tracks missing album name or artist name or both
Sun, Mar 31, 9:16 AM
mgallien committed R255:d58813b7d7ff: unbreak TrackMetaDataModel model by setting the database in the helper (authored by mgallien).
unbreak TrackMetaDataModel model by setting the database in the helper
Sun, Mar 31, 9:09 AM
mgallien committed R255:46f2800a5cd0: Improve management of database at start of application (authored by mgallien).
Improve management of database at start of application
Sun, Mar 31, 8:51 AM
mgallien committed R255:7333e7860e84: Improve management of database at start of application (authored by mgallien).
Improve management of database at start of application
Sun, Mar 31, 8:51 AM
mgallien committed R255:401eaa485ee6: improve logging about database upgrades at start of Elisa (authored by mgallien).
improve logging about database upgrades at start of Elisa
Sun, Mar 31, 8:51 AM
mgallien committed R255:fc66785b48b1: checks database schema and resets it in case of errors (authored by mgallien).
checks database schema and resets it in case of errors
Sun, Mar 31, 8:51 AM
mgallien committed R255:9a22290bb45c: add smooth upgrade for users with database matching v0.3.0 of Elisa (authored by mgallien).
add smooth upgrade for users with database matching v0.3.0 of Elisa
Sun, Mar 31, 8:50 AM
mgallien closed D20134: Improve management of database at start of application.
Sun, Mar 31, 8:50 AM

Sat, Mar 30

mgallien requested review of D20134: Improve management of database at start of application.
Sat, Mar 30, 10:14 PM
mgallien committed R255:9712750ed019: provide fallback code path for freebsd in local file indexer test (authored by mgallien).
provide fallback code path for freebsd in local file indexer test
Sat, Mar 30, 7:09 PM

Fri, Mar 29

mgallien committed R255:22f390256dfc: bump requirement for c++17 given we require it (authored by mgallien).
bump requirement for c++17 given we require it
Fri, Mar 29, 9:48 PM