mgallien (Matthieu Gallien)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Nov 10 2015, 7:32 AM (205 w, 4 d)
Availability
Available

Recent Activity

Yesterday

mgallien committed R255:054778d704ab: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
Fri, Oct 18, 5:29 AM
mgallien committed R255:297552eafae5: Merge branch 'indexOnConfigChange' into '0.4' (authored by mgallien).
Merge branch 'indexOnConfigChange' into '0.4'
Fri, Oct 18, 5:25 AM
mgallien committed R255:da3dd69232fb: let indexing start when config is changed (authored by mgallien).
let indexing start when config is changed
Fri, Oct 18, 5:25 AM

Wed, Oct 16

mgallien added inline comments to D23402: Show tracks with empty titles.
Wed, Oct 16, 8:58 PM · Elisa
mgallien added a comment to D23402: Show tracks with empty titles.

I spent some time on this. It should be possible to at least cover the no metadata case with requests only on TracksData. What do you think?

Wed, Oct 16, 8:57 PM · Elisa
mgallien accepted D24598: Update elisa icon.

Thanks

Wed, Oct 16, 8:47 PM · Elisa, Frameworks

Sun, Oct 13

mgallien added a comment to T5375: Add Management of Ratings for Tracks from Local Files.
Sun, Oct 13, 11:52 AM · Elisa
mgallien added a comment to D24598: Update elisa icon.

I have no intention on taking over D12992 as I would like rather like to code for Elisa. I am no designer.
I was unsatisfied with the icon and @mgallien agreed on some slight adjustments to the current one.
D12992 has been around for ages. I hope that this incremental update can be agreed upon faster and land for next frameworks release. Especially I find the "Elisa" text ugly and worth removing it quickly.

Sun, Oct 13, 6:40 AM · Elisa, Frameworks

Fri, Oct 11

mgallien requested changes to D23402: Show tracks with empty titles.

I will continue to look at this.

Fri, Oct 11, 3:42 PM · Elisa
mgallien added inline comments to D23402: Show tracks with empty titles.
Fri, Oct 11, 3:39 PM · Elisa
mgallien committed R255:a2a6a2b75778: Merge branch 'fixPlayListInsertAlbum' into 'master' (authored by mgallien).
Merge branch 'fixPlayListInsertAlbum' into 'master'
Fri, Oct 11, 5:07 AM
mgallien committed R255:82b3236da788: insert music from an artist sorted by albums, disc and track numbers (authored by mgallien).
insert music from an artist sorted by albums, disc and track numbers
Fri, Oct 11, 5:07 AM
mgallien committed R255:cccafdff17a3: insert album tracks at the correct place instead of at the end (authored by mgallien).
insert album tracks at the correct place instead of at the end
Fri, Oct 11, 5:07 AM

Wed, Oct 9

mgallien committed R255:b3d0a2bdcca7: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
Wed, Oct 9, 5:00 AM
mgallien committed R255:2c3cc300a051: remove obsolete not working Gitlab CI configuration file (authored by mgallien).
remove obsolete not working Gitlab CI configuration file
Wed, Oct 9, 4:58 AM

Tue, Oct 8

mgallien abandoned D24148: [WIP] let one category be embedded in the ViewSelector.

Moved to gitlab merge request

Tue, Oct 8, 7:33 PM
mgallien abandoned D23360: [WIP] compatibility with newer version of upnp lib.

Moved to gitlab merge request

Tue, Oct 8, 7:32 PM
mgallien abandoned D20636: allow to activate/deactivate the progress indicator on task bar entry.

Moved to gitlab merge request

Tue, Oct 8, 7:31 PM
mgallien abandoned D20476: [WIP] starts to make the list of renderers available and use it to play music.

Moved to gitlab merge request

Tue, Oct 8, 7:31 PM
mgallien abandoned D18171: [WIP] ask libvlc to apply album replay gain metadata if available.

Moved to gitlab merge request

Tue, Oct 8, 7:30 PM · Elisa
mgallien abandoned D24271: insert album tracks at the correct place instead of at the end.

Moved to gitlab merge request

Tue, Oct 8, 7:29 PM
mgallien abandoned D24445: [WIP] mostly implements display of all tracks from an artist.

Moved to gitlab merge request

Tue, Oct 8, 7:26 PM
mgallien committed R255:204519d3561f: remove not working Gitlab CI configuration file (authored by mgallien).
remove not working Gitlab CI configuration file
Tue, Oct 8, 7:08 PM
mgallien added a revision to T9810: Add the possibility to output music to a ChromeCast device: D20476: [WIP] starts to make the list of renderers available and use it to play music.
Tue, Oct 8, 5:48 PM · Elisa
mgallien added a task to D20476: [WIP] starts to make the list of renderers available and use it to play music: T9810: Add the possibility to output music to a ChromeCast device.
Tue, Oct 8, 5:48 PM
mgallien committed R255:650781867822: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
Tue, Oct 8, 3:54 PM
mgallien committed R255:e535ef7ed125: ensure that baloo detection works (authored by mgallien).
ensure that baloo detection works
Tue, Oct 8, 3:49 PM
mgallien closed D24303: ensure that baloo detection works.
Tue, Oct 8, 3:49 PM
mgallien added a comment to D24303: ensure that baloo detection works.
In D24303#543481, @mthw wrote:

After the latest changes, it kind of works. It finds some of my music but not everything.
It looks like the database is created correctly as it contains 1891 tracks which I believe are all my tracks. Also Elisa in top right corner says "1891 tracks imported".

e.g. log says:

...
org.kde.elisa.database: artistsAdded 5
org.kde.elisa.database: albumsAdded 19
org.kde.elisa.database: tracksAdded 184

That is clearly wrong. It shows more items than that, but not everything. There are albums present in the DB that are not shown in Elisa.

Tue, Oct 8, 7:27 AM

Mon, Oct 7

mgallien added inline comments to D23402: Show tracks with empty titles.
Mon, Oct 7, 7:48 PM · Elisa
mgallien added a comment to D24303: ensure that baloo detection works.
In D24303#542653, @mthw wrote:

I have re-built with your latest patch, here is the log: https://pastebin.com/evHqy2Bh

Mon, Oct 7, 7:14 PM
mgallien updated the diff for D24303: ensure that baloo detection works.
  • should fix indexing stopping for no apparent reason
Mon, Oct 7, 7:13 PM
mgallien added a comment to D24100: add icons needed to handle the Windows Store publication.

Since D12992 seems to be stuck, I think we could improve the current icon a litte bit by removing the imho ugly "Elisa" text. What do you think?

Yes, it could be better this way. Do you plan to do it ?

Yes, I'm working on it.

Mon, Oct 7, 6:55 PM
mgallien updated the diff for D20636: allow to activate/deactivate the progress indicator on task bar entry.
  • use KConfig configuration to show/hide progress on task bar entries
Mon, Oct 7, 6:52 PM
mgallien updated the diff for D23360: [WIP] compatibility with newer version of upnp lib.
  • more or less able to add and remove UPnP servers that have been detected
  • react to network changes by querying again for all UPnP devices
  • fix some small issues after rebase
Mon, Oct 7, 5:12 AM
mgallien planned changes to D24445: [WIP] mostly implements display of all tracks from an artist.

@ngraham Thanks a lot for the feedback. I will work on it.

Mon, Oct 7, 5:07 AM
mgallien added a comment to D24303: ensure that baloo detection works.

FWIW this needs a rebase on current master.

Mon, Oct 7, 5:01 AM

Sun, Oct 6

mgallien added a comment to D24445: [WIP] mostly implements display of all tracks from an artist.

No need to hurry, I had started that a long time ago.

Sun, Oct 6, 3:29 PM
mgallien retitled D24445: [WIP] mostly implements display of all tracks from an artist from mostly implements display of all tracks from an artist to [WIP] mostly implements display of all tracks from an artist.
Sun, Oct 6, 3:29 PM
mgallien requested review of D24445: [WIP] mostly implements display of all tracks from an artist.
Sun, Oct 6, 3:28 PM
mgallien added a comment to D20476: [WIP] starts to make the list of renderers available and use it to play music.

I think this will break the gstreamer backend

Sun, Oct 6, 3:14 PM
mgallien updated the diff for D20476: [WIP] starts to make the list of renderers available and use it to play music.

rebase

Sun, Oct 6, 2:50 PM
mgallien updated the diff for D18171: [WIP] ask libvlc to apply album replay gain metadata if available.
  • load replay gain tags from file properties
  • alsmost allow replay gain to be configurable
Sun, Oct 6, 2:32 PM · Elisa
mgallien committed R255:5301e52973af: avoid metadata persisting in header bar when missing from playing track (authored by mgallien).
avoid metadata persisting in header bar when missing from playing track
Sun, Oct 6, 1:53 PM
mgallien closed D24231: avoid metadata persisting in header bar when missing from playing track.
Sun, Oct 6, 1:53 PM
mgallien added a comment to D24100: add icons needed to handle the Windows Store publication.

Since D12992 seems to be stuck, I think we could improve the current icon a litte bit by removing the imho ugly "Elisa" text. What do you think?

Sun, Oct 6, 1:33 PM
mgallien committed R255:2b01e6f91385: add icons needed to handle the Windows Store publication (authored by mgallien).
add icons needed to handle the Windows Store publication
Sun, Oct 6, 1:33 PM
mgallien closed D24100: add icons needed to handle the Windows Store publication.
Sun, Oct 6, 1:33 PM
mgallien updated the diff for D24303: ensure that baloo detection works.
  • improve logging of what happen during file system scan
  • ensure all tests are OK when built without KFileMetaData
  • do not index twice the files when starting Elisa
Sun, Oct 6, 1:28 PM

Fri, Oct 4

mgallien accepted D24406: Small performance improvements suggested by clang tidy.

Thanks

Fri, Oct 4, 6:18 AM · Baloo, Frameworks

Mon, Sep 30

mgallien added a comment to D24303: ensure that baloo detection works.

You have two ways to check if baloo index is looking correct:

Mon, Sep 30, 7:44 PM
mgallien added a comment to D24303: ensure that baloo detection works.
In D24303#539916, @mthw wrote:

@mgallien Is there anything interesting in those logs? What else can I provide to help?

Mon, Sep 30, 6:31 PM
mgallien added a comment to D24303: ensure that baloo detection works.
Mon, Sep 30, 3:25 PM
mgallien added a comment to D24303: ensure that baloo detection works.
In D24303#539850, @mthw wrote:

I am asking because I tried it and it doesn't help. I deleted ~/.config/elisarc, ~/.local/share/elisa/*and ~/.cache/elisa/*; built from source (tag 0.4.2 with this patch) and ran the build. It acts exacty the same as before. Am I doing something wrong? Baloo is running and working corectly (I guess, it's not crashing).

Mon, Sep 30, 3:24 PM
mgallien added a comment to D24303: ensure that baloo detection works.
In D24303#539700, @mthw wrote:

Is this supposed to fix 412210?

Mon, Sep 30, 11:40 AM
mgallien updated the summary of D24303: ensure that baloo detection works.
Mon, Sep 30, 11:39 AM
mgallien requested review of D24303: ensure that baloo detection works.
Mon, Sep 30, 5:16 AM

Sun, Sep 29

mgallien added inline comments to D23859: Radios: add support for images.
Sun, Sep 29, 6:50 PM

Sat, Sep 28

mgallien committed R255:d8d6d0377242: fix now playing view no longer updating to follow playing track (authored by mgallien).
fix now playing view no longer updating to follow playing track
Sat, Sep 28, 8:51 AM
mgallien closed D24274: fix now playing view no longer updating to follow playing track.
Sat, Sep 28, 8:51 AM
mgallien planned changes to D20636: allow to activate/deactivate the progress indicator on task bar entry.

I will add support for the configuration option without UI at first much like in D24148.

Sat, Sep 28, 8:01 AM
mgallien planned changes to D24271: insert album tracks at the correct place instead of at the end.

Oops, thanks for the review

Sat, Sep 28, 8:00 AM

Fri, Sep 27

mgallien requested review of D24274: fix now playing view no longer updating to follow playing track.
Fri, Sep 27, 9:12 PM
mgallien requested review of D24271: insert album tracks at the correct place instead of at the end.
Fri, Sep 27, 8:22 PM

Wed, Sep 25

mgallien requested review of D24231: avoid metadata persisting in header bar when missing from playing track.
Wed, Sep 25, 7:15 PM

Tue, Sep 24

mgallien added a comment to T9641: Publish Elisa in the Microsoft Store.

Hmm, I tried the Elisa Release Build from Binary Factory.

Has for me some issues like that the text of the left side actions like "Recently Played", ... is "white on white" until you highlight an action, then that one has some selection background and you can read something.

Tue, Sep 24, 8:23 PM · Elisa, Windows
mgallien added a comment to D23859: Radios: add support for images.

Sorry for the delay.
Thanks for that. The screen capture looks really nice with the images for radios.
I have to check another thing to complete my review but please find my inline comment.

Tue, Sep 24, 8:04 PM
mgallien committed R169:d2570246a555: fix compatibility with Qt5.11 (authored by mgallien).
fix compatibility with Qt5.11
Tue, Sep 24, 3:17 PM
mgallien closed D24147: fix compatibility with Qt5.11.
Tue, Sep 24, 3:17 PM · Kirigami

Mon, Sep 23

mgallien committed R877:2e2206582d04: add less mimetypes and more extension for Elisa package (authored by mgallien).
add less mimetypes and more extension for Elisa package
Mon, Sep 23, 7:48 PM
mgallien updated the diff for D24148: [WIP] let one category be embedded in the ViewSelector.
  • partially implement navigation from the extra items in views list
Mon, Sep 23, 7:40 PM
mgallien added inline comments to D24147: fix compatibility with Qt5.11.
Mon, Sep 23, 3:28 PM · Kirigami
mgallien updated the diff for D24147: fix compatibility with Qt5.11.

correct modifications from arrow function to a simple short one

Mon, Sep 23, 3:23 PM · Kirigami

Sun, Sep 22

mgallien added a comment to D24147: fix compatibility with Qt5.11.

It has been reported in debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=940939

Sun, Sep 22, 7:26 PM · Kirigami
mgallien accepted D23844: Factor out dataTypes from databaseinterface.

Good idea,
sorry for the delay, I had misread the description.

Sun, Sep 22, 7:21 PM · Elisa
mgallien requested review of D24148: [WIP] let one category be embedded in the ViewSelector.
Sun, Sep 22, 4:57 PM
mgallien requested review of D24147: fix compatibility with Qt5.11.
Sun, Sep 22, 4:51 PM · Kirigami
mgallien added a comment to D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action.

This patch breaks compatibility with Qt5.11 where Qt Quick Controls2 is in version 2.4.
I noticed it after Debian upgraded the package and I am unable to let Elisa run with it. I will try to work on a fix.

Sun, Sep 22, 3:45 PM · Kirigami
mgallien committed R877:4e6c6f9ede5d: add mimetypes configuration for elisa (authored by mgallien).
add mimetypes configuration for elisa
Sun, Sep 22, 10:03 AM
mgallien committed R877:71c67850422f: put elisa icons in the correct directory (authored by mgallien).
put elisa icons in the correct directory
Sun, Sep 22, 8:54 AM

Fri, Sep 20

mgallien committed R877:c769e94c112e: correct type in elisa.py (authored by mgallien).
correct type in elisa.py
Fri, Sep 20, 9:02 PM

Thu, Sep 19

mgallien requested review of D24100: add icons needed to handle the Windows Store publication.
Thu, Sep 19, 9:16 PM
mgallien updated the task description for T9641: Publish Elisa in the Microsoft Store.
Thu, Sep 19, 9:13 PM · Elisa, Windows
mgallien added a comment to D12992: New elisa icon.

Bumping @abetts

Thu, Sep 19, 9:12 PM · Frameworks, Elisa
mgallien committed R877:ac7426b792e0: add more Elisa icons and fix white background of ico icons (authored by mgallien).
add more Elisa icons and fix white background of ico icons
Thu, Sep 19, 9:05 PM
mgallien added a comment to T9641: Publish Elisa in the Microsoft Store.

We worked a bit more on the okular submission.
For Elisa: I would create the needed 44/150 icons like I did for okular in

https://phabricator.kde.org/R877:ee4afc97b91e

+

for future releases:
https://invent.kde.org/kde/okular/commit/8ca6b85c24d1a1fe3695a17dc2b4a5cfc7705fda

Thu, Sep 19, 7:41 PM · Elisa, Windows

Sep 18 2019

mgallien added a comment to D21525: Add support for radio streams.

Thank you for the information.

I created another diff last week about radios, D23859. Did anyone get some notification about it or did I forgot to put a flag on it ?

Sep 18 2019, 8:30 AM
mgallien added a comment to T9641: Publish Elisa in the Microsoft Store.
Sep 18 2019, 7:19 AM · Elisa, Windows
mgallien added a comment to T9641: Publish Elisa in the Microsoft Store.

We can just add appx generation to the https://binary-factory.kde.org/job/Elisa_Release_win64/ job.
Then you can try the sideload appx locally.

Sep 18 2019, 7:10 AM · Elisa, Windows
mgallien added a comment to T9641: Publish Elisa in the Microsoft Store.

I think we need to get craft to build an appx package for

https://binary-factory.kde.org/job/Elisa_Release_win64/

Perhaps Hannah can give feedback.

I have an account for the store now, too, and can help with the submission.

Sep 18 2019, 5:23 AM · Elisa, Windows

Sep 15 2019

mgallien added inline comments to D23402: Show tracks with empty titles.
Sep 15 2019, 7:36 AM · Elisa

Sep 12 2019

mgallien added a comment to T9575: Publish more of KDE's applications in the Microsoft Store.

I need to praise once more Hannah's work :=)
I think we need to document somewhere better how to get access to the account for publishing stuff and the process.
I hope the Kate submission get's approved in the next days, then we can take a look how well it is perceived, given it has a theoretically much larger user group as target than e.g. KStars.

Sep 12 2019, 1:02 PM · Goal: All About the Apps, Windows

Sep 11 2019

mgallien added a comment to D23402: Show tracks with empty titles.

I will try to provide a good review as soon as I can. Sorry for the delay.

Sep 11 2019, 5:33 AM · Elisa

Sep 10 2019

mgallien updated the diff for D20476: [WIP] starts to make the list of renderers available and use it to play music.

rebase

Sep 10 2019, 3:24 PM
mgallien committed R255:7d815c9fa380: Add global menu by using qml native menu components (authored by mgallien).
Add global menu by using qml native menu components
Sep 10 2019, 3:22 PM
mgallien closed D21006: Add global menu by using qml native menu components.
Sep 10 2019, 3:22 PM · Elisa

Sep 9 2019

mgallien updated the diff for D21006: Add global menu by using qml native menu components.
  • export the menu as "Application Menu"
Sep 9 2019, 8:54 PM · Elisa
mgallien added a comment to D23280: fix issues related to radio and view details in playlist.

Should be good to land now.
Let me know.

Yes, I do not see anything wrong :)

Sep 9 2019, 8:20 PM
mgallien committed R255:a1ca107d948f: fix issues related to radio and view details in playlist (authored by mgallien).
fix issues related to radio and view details in playlist
Sep 9 2019, 8:19 PM
mgallien closed D23280: fix issues related to radio and view details in playlist.
Sep 9 2019, 8:19 PM