mgallien (Matthieu Gallien)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 10 2015, 7:32 AM (213 w, 3 d)
Availability
Available

Recent Activity

Today

mgallien committed R255:0ad92f7d174b: use global menu only on linux due to behavior difference on Windows (authored by mgallien).
use global menu only on linux due to behavior difference on Windows
Fri, Dec 13, 9:44 AM
mgallien committed R255:42b2382bc0b2: Merge branch 'globalMenuOnLinuxOnly' into 'release/19.12' (authored by mgallien).
Merge branch 'globalMenuOnLinuxOnly' into 'release/19.12'
Fri, Dec 13, 9:44 AM
mgallien committed R877:c07cbe057247: switch elisa default build to 19.12.0 release (authored by mgallien).
switch elisa default build to 19.12.0 release
Fri, Dec 13, 8:42 AM

Yesterday

mgallien committed R286:9220e5045687: partial solution to accept accentuated characters on windows (authored by mgallien).
partial solution to accept accentuated characters on windows
Thu, Dec 12, 11:12 PM
mgallien closed D25622: partial solution to accept accentuated characters on windows.
Thu, Dec 12, 11:12 PM · Baloo, Frameworks

Wed, Dec 11

mgallien added a comment to D23859: Radios: add support for images.

@jguidon Thanks a lot for this new contribution. This is nice to see you continue to contribute on this part.

Wed, Dec 11, 9:10 PM
mgallien committed R255:826e1665b6c7: Merge branch 'disactivateBalooWhenNeeded' into 'master' (authored by mgallien).
Merge branch 'disactivateBalooWhenNeeded' into 'master'
Wed, Dec 11, 4:37 PM
mgallien committed R255:3ca6ab5e00fd: fix indexers state management in MusicListenersManager (authored by mgallien).
fix indexers state management in MusicListenersManager
Wed, Dec 11, 4:37 PM
mgallien committed R255:5b4992265f5c: exclude paths excluded in baloo configuration (authored by mgallien).
exclude paths excluded in baloo configuration
Wed, Dec 11, 4:37 PM
mgallien committed R255:c199deaceca3: fix local file indexer not to remove unmodified files after first scan (authored by mgallien).
fix local file indexer not to remove unmodified files after first scan
Wed, Dec 11, 4:37 PM
mgallien committed R255:aad7ad9ac880: properly detect if all paths can be handled by baloo (authored by mgallien).
properly detect if all paths can be handled by baloo
Wed, Dec 11, 4:37 PM
mgallien committed R255:5d3aaec3092b: almost working switch from baloo to files indexing on config changes (authored by mgallien).
almost working switch from baloo to files indexing on config changes
Wed, Dec 11, 4:37 PM
mgallien committed R255:ac103b9dead5: start baloo only if all paths are indexed by baloo (authored by mgallien).
start baloo only if all paths are indexed by baloo
Wed, Dec 11, 4:37 PM
mgallien committed R255:2956d9af6d5f: ignore baloo indexer when some paths are not indexed (authored by mgallien).
ignore baloo indexer when some paths are not indexed
Wed, Dec 11, 4:37 PM
mgallien added reviewers for D25894: properly detect local branches with slash (like release/19.12): Craft, vonreth.
Wed, Dec 11, 4:33 PM
mgallien requested review of D25894: properly detect local branches with slash (like release/19.12).
Wed, Dec 11, 4:33 PM

Sun, Dec 8

mgallien committed R234:ab359134994d: update elisa screenshot for 19.12 release (authored by mgallien).
update elisa screenshot for 19.12 release
Sun, Dec 8, 3:54 PM

Sat, Dec 7

mgallien committed R255:eab1591fa62a: Merge branch 'release/19.12' (authored by mgallien).
Merge branch 'release/19.12'
Sat, Dec 7, 5:45 PM
mgallien committed R255:ba3b822e390b: Merge branch 'fixClazyWarnings' into 'release/19.12' (authored by mgallien).
Merge branch 'fixClazyWarnings' into 'release/19.12'
Sat, Dec 7, 5:39 PM
mgallien committed R255:4ec4503d82e3: fix new issue introduced by !39 merge request (authored by mgallien).
fix new issue introduced by !39 merge request
Sat, Dec 7, 5:39 PM
mgallien committed R255:0c22a3e685f2: many clazy level 2 fixes (authored by mgallien).
many clazy level 2 fixes
Sat, Dec 7, 5:39 PM
mgallien committed R255:e87e2c60ee19: as requested during review, put back extra parameter in TracksListener… (authored by mgallien).
as requested during review, put back extra parameter in TracksListener…
Sat, Dec 7, 5:39 PM
mgallien committed R255:e1b17e32c495: correct clazy level 1 warnings from Elisa source code (authored by mgallien).
correct clazy level 1 warnings from Elisa source code
Sat, Dec 7, 5:39 PM

Fri, Dec 6

mgallien added a comment to D24563: Standardize the database upgrade mechanism.

Thanks so much for this very nice contribution, @jguidon!

Fri, Dec 6, 5:51 PM

Thu, Dec 5

mgallien added a comment to D24563: Standardize the database upgrade mechanism.

Can this land now?

Thu, Dec 5, 10:00 PM

Wed, Dec 4

mgallien committed R255:2b95d068f0e3: Merge branch 'release/19.12' (authored by mgallien).
Merge branch 'release/19.12'
Wed, Dec 4, 4:51 PM
mgallien committed R255:10e1201aa0eb: Merge branch 'fixIndexingOnWindows' into 'release/19.12' (authored by mgallien).
Merge branch 'fixIndexingOnWindows' into 'release/19.12'
Wed, Dec 4, 4:42 PM
mgallien committed R255:62e0513eca73: properly get the path in the kcm module and use it cleanly in indexers (authored by mgallien).
properly get the path in the kcm module and use it cleanly in indexers
Wed, Dec 4, 4:42 PM
mgallien committed R255:674d0ff4d0b4: should fix the infinite loop when config changed (authored by mgallien).
should fix the infinite loop when config changed
Wed, Dec 4, 4:42 PM

Mon, Dec 2

mgallien committed R256:936dc4fc9324: fix build of elisa by fetching libvlc from correct URL (authored by mgallien).
fix build of elisa by fetching libvlc from correct URL
Mon, Dec 2, 8:51 PM

Sat, Nov 30

mgallien added a comment to D25622: partial solution to accept accentuated characters on windows.

I forgot to maybe give some explanations.

Sat, Nov 30, 9:07 AM · Baloo, Frameworks

Fri, Nov 29

mgallien added a reviewer for D25622: partial solution to accept accentuated characters on windows: bruns.
Fri, Nov 29, 10:30 PM · Baloo, Frameworks
mgallien requested review of D25622: partial solution to accept accentuated characters on windows.
Fri, Nov 29, 10:29 PM · Baloo, Frameworks

Fri, Nov 22

mgallien committed R255:01fd8821e093: Merge branch 'fixContextView' into 'release/19.12' (authored by mgallien).
Merge branch 'fixContextView' into 'release/19.12'
Fri, Nov 22, 2:01 PM
mgallien committed R255:292b18e1f678: bring back a working ContextView (authored by mgallien).
bring back a working ContextView
Fri, Nov 22, 2:01 PM
mgallien committed R255:f9696f5ad9a0: add beta release 19.11.80 to appdata file (authored by mgallien).
add beta release 19.11.80 to appdata file
Fri, Nov 22, 6:04 AM
mgallien committed R255:2d43057cb539: Merge branch 'updateAppdata' into 'release/19.12' (authored by mgallien).
Merge branch 'updateAppdata' into 'release/19.12'
Fri, Nov 22, 6:04 AM

Thu, Nov 21

mgallien committed R993:ce52739c3386: switch nightly builds of elisa to release/19.12 branch (authored by mgallien).
switch nightly builds of elisa to release/19.12 branch
Thu, Nov 21, 4:38 AM

Wed, Nov 20

mgallien committed R255:5250f77b5d70: call KQuickAddons::QtQuickSettings::init() after QApplication is built (authored by mgallien).
call KQuickAddons::QtQuickSettings::init() after QApplication is built
Wed, Nov 20, 8:35 PM
mgallien committed R877:4af54d366ae8: update Elisa icons and add new release branch and set it as default (authored by mgallien).
update Elisa icons and add new release branch and set it as default
Wed, Nov 20, 6:14 PM
mgallien closed D25382: update Elisa icons and add new release branch and set it as default.
Wed, Nov 20, 6:14 PM
mgallien updated the diff for D25382: update Elisa icons and add new release branch and set it as default.
  • switch default to the latest stable tag (0.4.2 version) for elisa
  • remove all versions specified in elisa.py, only use version.ini
Wed, Nov 20, 6:13 PM
mgallien added inline comments to D25382: update Elisa icons and add new release branch and set it as default.
Wed, Nov 20, 4:56 PM
mgallien updated the diff for D25382: update Elisa icons and add new release branch and set it as default.
  • switch default to the latest stable tag (0.4.2 version) for elisa
Wed, Nov 20, 4:41 PM
mgallien committed R255:81afd9b43c8c: Merge branch 'release/19.12' (authored by mgallien).
Merge branch 'release/19.12'
Wed, Nov 20, 6:36 AM
mgallien committed R255:d134b2b6a720: use QtQuickSettings to get common default qml setting (authored by mgallien).
use QtQuickSettings to get common default qml setting
Wed, Nov 20, 6:28 AM
mgallien committed R255:fcf12c2fd742: Merge branch 'useDefaultQmlKDESettings' into 'release/19.12' (authored by mgallien).
Merge branch 'useDefaultQmlKDESettings' into 'release/19.12'
Wed, Nov 20, 6:28 AM

Tue, Nov 19

mgallien committed R256:8becf5c73f65: use v5.64.0 for elisa bundled frameworks (authored by mgallien).
use v5.64.0 for elisa bundled frameworks
Tue, Nov 19, 4:56 PM
mgallien added a comment to D25382: update Elisa icons and add new release branch and set it as default.

@vonreth Thanks for the review

Tue, Nov 19, 4:41 PM
mgallien updated the diff for D25382: update Elisa icons and add new release branch and set it as default.

set latest beta release version as default

Tue, Nov 19, 4:40 PM
mgallien committed R255:140ba51ef9a4: Merge branch 'clean-i18n' into 'release/19.12' (authored by mgallien).
Merge branch 'clean-i18n' into 'release/19.12'
Tue, Nov 19, 4:22 PM
mgallien committed R255:986d6831d540: ki18n_install is a noop when the directory does not exist (authored by mgallien).
ki18n_install is a noop when the directory does not exist
Tue, Nov 19, 4:22 PM

Mon, Nov 18

mgallien requested review of D25382: update Elisa icons and add new release branch and set it as default.
Mon, Nov 18, 9:40 PM
mgallien committed R877:629a4538b740: update Elisa icons and add new release branch and set it as default (authored by mgallien).
update Elisa icons and add new release branch and set it as default
Mon, Nov 18, 9:37 PM
mgallien committed R255:07ff6790fefa: Merge branch 'release/19.12' (authored by mgallien).
Merge branch 'release/19.12'
Mon, Nov 18, 9:19 PM
mgallien committed R255:19e101624da6: put back the cleaning of DataModel when database is cleared (authored by mgallien).
put back the cleaning of DataModel when database is cleared
Mon, Nov 18, 9:16 PM
mgallien committed R255:21b9e630150c: Merge branch 'fixDuplicateAlbumsWhenClearDatabase' into 'master' (authored by mgallien).
Merge branch 'fixDuplicateAlbumsWhenClearDatabase' into 'master'
Mon, Nov 18, 8:52 PM
mgallien committed R255:026b1c87ebdb: put back the cleaning of DataModel when database is cleared (authored by mgallien).
put back the cleaning of DataModel when database is cleared
Mon, Nov 18, 8:52 PM

Sat, Nov 16

mgallien accepted D24563: Standardize the database upgrade mechanism.

rebase on master

Running the tests, I still get an error but it is not dependent on the changes on this review. I ran also the tests on master branch in both cases I get:

QWARN  : DatabaseInterfaceTests::checkRestoredTracks() QSqlDatabasePrivate::addDatabase: duplicate connection name 'testDb', old connection removed.
QDEBUG : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: database open
QDEBUG : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: DatabaseInterface::init yes
QINFO  : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: begin creation of DatabaseVersion table
QINFO  : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: begin creation of v9 database schema
QINFO  : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: end creation of v9 database schema
QINFO  : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: begin update to v11 of database schema
QINFO  : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: finished update to v11 of database schema
QINFO  : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: begin update to v12 of database schema
QINFO  : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: finished update to v12 of database schema
QINFO  : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: begin update to v13 of database schema
QINFO  : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: finished update to v13 of database schema
QINFO  : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: begin update to v14 of database schema
QINFO  : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: finished update to v14 of database schema
QDEBUG : DatabaseInterfaceTests::checkRestoredTracks() org.kde.elisa.database: DatabaseInterface::insertTracksList 23
QSYSTEM: DatabaseInterfaceTests::checkRestoredTracks() Maximum amount of warnings exceeded. Use -maxwarnings to override.
PASS   : DatabaseInterfaceTests::checkRestoredTracks()
PASS   : DatabaseInterfaceTests::addOneTrackWithParticularPath()
PASS   : DatabaseInterfaceTests::readRecentlyPlayedTracksData()
PASS   : DatabaseInterfaceTests::readFrequentlyPlayedTracksData()
PASS   : DatabaseInterfaceTests::readAllGenresData()
PASS   : DatabaseInterfaceTests::clearDataTest()
FAIL!  : DatabaseInterfaceTests::upgradeFromStableVersion() Compared values are not the same
   Actual   (musicDb.allAlbumsData().count()): 0
   Expected (5)                              : 5
   Loc: [/home/jeje/kde/elisa/autotests/databaseinterfacetest.cpp(4848)]
Sat, Nov 16, 5:27 PM

Thu, Nov 14

mgallien committed R255:c914ab10e9ed: Merge branch 'release/19.12' (authored by mgallien).
Merge branch 'release/19.12'
Thu, Nov 14, 9:06 AM
mgallien committed R255:3fbe4ad61f37: Merge branch 'reallyRemoveMusicAudioTrack' into 'release/19.12' (authored by mgallien).
Merge branch 'reallyRemoveMusicAudioTrack' into 'release/19.12'
Thu, Nov 14, 8:50 AM
mgallien committed R255:56235515e621: really remove MusicAudioTrack (authored by mgallien).
really remove MusicAudioTrack
Thu, Nov 14, 8:50 AM

Nov 10 2019

mgallien committed R255:8bdc29455332: Merge branch 'enqueueUrlPlayList' into 'master' (authored by mgallien).
Merge branch 'enqueueUrlPlayList' into 'master'
Nov 10 2019, 5:33 PM
mgallien committed R255:e38db1d29f01: fix issues when enqueueing file in database with priority not 1 (authored by mgallien).
fix issues when enqueueing file in database with priority not 1
Nov 10 2019, 5:33 PM
mgallien committed R255:471d9efbafd7: do not modify metadata from file in TracksListener (authored by mgallien).
do not modify metadata from file in TracksListener
Nov 10 2019, 5:33 PM
mgallien committed R255:36ac4ba2194e: fix indentation in MediaPlayList (authored by mgallien).
fix indentation in MediaPlayList
Nov 10 2019, 5:33 PM
mgallien committed R255:c7076be8d889: when showing metadata of a filename, checks if it is database (authored by mgallien).
when showing metadata of a filename, checks if it is database
Nov 10 2019, 5:33 PM
mgallien committed R255:feeeba3263eb: fix display of metadata (authored by mgallien).
fix display of metadata
Nov 10 2019, 5:33 PM
mgallien committed R255:23eb1b3e9948: handle url from command line and allow to enqueue track and radio by URL (authored by mgallien).
handle url from command line and allow to enqueue track and radio by URL
Nov 10 2019, 5:33 PM
mgallien committed R255:8c2abfd009ca: siplify usage of FileScanner (authored by mgallien).
siplify usage of FileScanner
Nov 10 2019, 5:33 PM
mgallien committed R255:98b0620a50d4: Merge branch 'removeMusicAudioTrack' into 'master' (authored by mgallien).
Merge branch 'removeMusicAudioTrack' into 'master'
Nov 10 2019, 11:23 AM

Nov 7 2019

mgallien added inline comments to D23859: Radios: add support for images.
Nov 7 2019, 6:17 PM
mgallien committed R255:62c5af8702e4: use a pointer to manage data loader in DataModel (authored by mgallien).
use a pointer to manage data loader in DataModel
Nov 7 2019, 2:59 PM
mgallien committed R255:670f124d197f: Merge branch 'fixCrashSwitchView' into 'master' (authored by mgallien).
Merge branch 'fixCrashSwitchView' into 'master'
Nov 7 2019, 2:59 PM

Nov 4 2019

mgallien added a comment to T9575: Publish more of KDE's applications in the Microsoft Store.

In order to handle submission of next release of Elisa music player, I would be interested to get the needed access to the partner page.

Nov 4 2019, 4:22 PM · Goal: All About the Apps, Windows

Nov 3 2019

mgallien committed R255:9e10cc34de13: Merge branch 'fixMediaPlayListTest' into 'master' (authored by mgallien).
Merge branch 'fixMediaPlayListTest' into 'master'
Nov 3 2019, 4:09 PM
mgallien committed R255:20867047d615: prevent QRandomGenerator::global()->bounded from asserting when given 0 (authored by mgallien).
prevent QRandomGenerator::global()->bounded from asserting when given 0
Nov 3 2019, 4:09 PM
mgallien committed R255:d6de94702fd2: use the standard Application cmake variables to handle version of Elisa (authored by mgallien).
use the standard Application cmake variables to handle version of Elisa
Nov 3 2019, 3:20 PM
mgallien committed R255:7e5aca053f30: Merge branch 'applicationVersion' into 'master' (authored by mgallien).
Merge branch 'applicationVersion' into 'master'
Nov 3 2019, 3:20 PM
mgallien added a comment to D24563: Standardize the database upgrade mechanism.

When running the automatic tests I get the following error:

QDEBUG : DatabaseInterfaceTests::reloadDatabaseWithAllTracks() org.kde.elisa.database: database open
QDEBUG : DatabaseInterfaceTests::reloadDatabaseWithAllTracks() org.kde.elisa.database: DatabaseInterface::init yes
QDEBUG : DatabaseInterfaceTests::reloadDatabaseWithAllTracks() org.kde.elisa.database: DatabaseInterface::setDatabaseVersionInTable "INSERT INTO DatabaseVersion (Version) VALUES ( :version )"
QDEBUG : DatabaseInterfaceTests::reloadDatabaseWithAllTracks() org.kde.elisa.database: DatabaseInterface::setDatabaseVersionInTable QSqlError("19", "Unable to fetch row", "UNIQUE constraint failed: DatabaseVersion.Version")
QDEBUG : DatabaseInterfaceTests::reloadDatabaseWithAllTracks() org.kde.elisa.database: DatabaseInterface::reloadExistingDatabase
FAIL! : DatabaseInterfaceTests::reloadDatabaseWithAllTracks() Compared values are not the same

Actual   (musicDbDatabaseErrorSpy2.count()): 1
Expected (0)                               : 0
Loc: [../autotests/databaseinterfacetest.cpp(3540)]

I am running the tests with the environment variable :
export QT_LOGGING_RULES="*elisa*=true"

Nov 3 2019, 8:44 AM

Nov 2 2019

mgallien added a comment to D24563: Standardize the database upgrade mechanism.

When running the automatic tests I get the following error:

Nov 2 2019, 8:41 PM

Oct 26 2019

mgallien added a comment to D23859: Radios: add support for images.

What is the current status of this review?

Oct 26 2019, 10:28 AM
mgallien added a comment to D24563: Standardize the database upgrade mechanism.

Sorry for the delay. I will review it beginning of next week.

Oct 26 2019, 10:26 AM

Oct 25 2019

mgallien committed R255:fe840744eeb2: add logging in playlist with a new category (authored by mgallien).
add logging in playlist with a new category
Oct 25 2019, 8:05 AM
mgallien committed R255:7a8b97f7edbd: Merge branch 'multiDiscsAlbumInsert' into 'master' (authored by mgallien).
Merge branch 'multiDiscsAlbumInsert' into 'master'
Oct 25 2019, 8:05 AM

Oct 18 2019

mgallien committed R255:054778d704ab: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
Oct 18 2019, 5:29 AM
mgallien committed R255:297552eafae5: Merge branch 'indexOnConfigChange' into '0.4' (authored by mgallien).
Merge branch 'indexOnConfigChange' into '0.4'
Oct 18 2019, 5:25 AM
mgallien committed R255:da3dd69232fb: let indexing start when config is changed (authored by mgallien).
let indexing start when config is changed
Oct 18 2019, 5:25 AM

Oct 16 2019

mgallien added inline comments to D23402: Show tracks with empty titles.
Oct 16 2019, 8:58 PM · Elisa
mgallien added a comment to D23402: Show tracks with empty titles.

I spent some time on this. It should be possible to at least cover the no metadata case with requests only on TracksData. What do you think?

Oct 16 2019, 8:57 PM · Elisa
mgallien accepted D24598: Update elisa icon.

Thanks

Oct 16 2019, 8:47 PM · Frameworks, Elisa

Oct 13 2019

mgallien added a comment to T5375: Add Management of Ratings for Tracks from Local Files.
Oct 13 2019, 11:52 AM · Elisa
mgallien added a comment to D24598: Update elisa icon.

I have no intention on taking over D12992 as I would like rather like to code for Elisa. I am no designer.
I was unsatisfied with the icon and @mgallien agreed on some slight adjustments to the current one.
D12992 has been around for ages. I hope that this incremental update can be agreed upon faster and land for next frameworks release. Especially I find the "Elisa" text ugly and worth removing it quickly.

Oct 13 2019, 6:40 AM · Frameworks, Elisa

Oct 11 2019

mgallien requested changes to D23402: Show tracks with empty titles.

I will continue to look at this.

Oct 11 2019, 3:42 PM · Elisa
mgallien added inline comments to D23402: Show tracks with empty titles.
Oct 11 2019, 3:39 PM · Elisa
mgallien committed R255:a2a6a2b75778: Merge branch 'fixPlayListInsertAlbum' into 'master' (authored by mgallien).
Merge branch 'fixPlayListInsertAlbum' into 'master'
Oct 11 2019, 5:07 AM
mgallien committed R255:82b3236da788: insert music from an artist sorted by albums, disc and track numbers (authored by mgallien).
insert music from an artist sorted by albums, disc and track numbers
Oct 11 2019, 5:07 AM
mgallien committed R255:cccafdff17a3: insert album tracks at the correct place instead of at the end (authored by mgallien).
insert album tracks at the correct place instead of at the end
Oct 11 2019, 5:07 AM

Oct 9 2019

mgallien committed R255:b3d0a2bdcca7: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
Oct 9 2019, 5:00 AM
mgallien committed R255:2c3cc300a051: remove obsolete not working Gitlab CI configuration file (authored by mgallien).
remove obsolete not working Gitlab CI configuration file
Oct 9 2019, 4:58 AM