mgallien (Matthieu Gallien)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Nov 10 2015, 7:32 AM (197 w, 2 d)
Availability
Available

Recent Activity

Yesterday

mgallien updated the diff for D23280: fix issues related to radio and view details in playlist.
  • do not show delete button when creating a new radio
  • partially fix the radio modification case
  • final fix for radio modification
  • fix radio modification by querying all data of modified radio
Wed, Aug 21, 8:25 PM

Tue, Aug 20

mgallien added a comment to D23280: fix issues related to radio and view details in playlist.

I just have two questions about the behavior:

  • Does it make sense to display the Delete button while we are creating a radio ?
  • The Apply button is not disabled after the radio is saved, maybe the user is not sure if the data has been successfully saved? I tried to keep the same behavior as the System Settings for instance.
Tue, Aug 20, 7:37 PM
mgallien updated the diff for D23280: fix issues related to radio and view details in playlist.
  • fix radio deletion and warning messages
Tue, Aug 20, 3:48 PM
mgallien added a comment to D21525: Add support for radio streams.

@ngraham As far as I am concerned, I believe @jguidon would qualify as a KDE developer. In my mind, his two contributions would be enough. Is this correct ?

Two is low, but they are very high-quality contributions. Another criterion is commitment and intention to continue contributing. So an answer to this question would be welcome:

Tue, Aug 20, 7:32 AM

Mon, Aug 19

mgallien requested review of D23280: fix issues related to radio and view details in playlist.
Mon, Aug 19, 10:20 PM
mgallien committed R255:628e42a4921f: ensure TrackMetadataModelTests do not fail by initializing an attribute (authored by mgallien).
ensure TrackMetadataModelTests do not fail by initializing an attribute
Mon, Aug 19, 9:47 PM
mgallien committed R255:6254e03fdf85: fix failing test in autotests/mediaplaylisttest.cpp (authored by mgallien).
fix failing test in autotests/mediaplaylisttest.cpp
Mon, Aug 19, 8:37 PM
mgallien committed R255:caf86cbda92b: fix ViewManagerTests automatic tests (authored by mgallien).
fix ViewManagerTests automatic tests
Mon, Aug 19, 8:05 PM
mgallien committed R255:840019217f21: Add support for radio streams (authored by jguidon).
Add support for radio streams
Mon, Aug 19, 7:21 PM
mgallien closed D21525: Add support for radio streams.
Mon, Aug 19, 7:21 PM
mgallien added a comment to D21525: Add support for radio streams.

Should I land this patch for you or you have already a KDE developer account ?

As this is my second contribution to a KDE project, I do not have a KDE developer account to be able to land a patch. So it would be very kind if you can land it.

Mon, Aug 19, 7:17 PM

Sun, Aug 18

mgallien added a comment to D22770: Rework shuffle handling.

I am unable to get arc to properly download this review patch. I will be waiting for D22769 to land and a rebase. Sorry

Sun, Aug 18, 8:20 PM · Elisa
mgallien accepted D21525: Add support for radio streams.

I believe that the best approach would be to allow easy access to a list of user contributed radios (i.e. maybe via store.kde.org ). When testing, I have added one radio I often listen to and that was easy to do. We could easily delay that to a second stage. What do you think ?

I also think it would be a very nice improvement in the future, for now we should focus on the main functionality. Also, we could think about the possibility to classify radios by genre?

I will try to open a new diff with only the database stuff no later than this weekend.

Sun, Aug 18, 7:53 PM
mgallien accepted D22769: Make MediaPlayList responsible for remaining tracks.

OK, thanks

Sun, Aug 18, 7:46 PM · Elisa

Sat, Aug 17

mgallien accepted D23223: Remove all remnants of outdated notification system.

Let's go. I have not enough time for a proper review but a big +1

Sat, Aug 17, 4:40 PM · Elisa

Thu, Aug 15

mgallien added a comment to T7570: Investigate bugs where busy indicator spins forever.

Do you experience any problems yourself? Judging from the bug reports, the bugs have been fixed and this task should have been closed.
@mgallien are all bugs fixed?

Thu, Aug 15, 7:24 PM · Elisa

Wed, Aug 14

mgallien accepted D23132: Use Qt's highDPI scaling.

Really nice. Thank you

Wed, Aug 14, 7:12 AM · Elisa

Tue, Aug 13

mgallien added a comment to D22769: Make MediaPlayList responsible for remaining tracks.

I forgot to say that the very big reduction in line count is really good. Thanks for that

Tue, Aug 13, 5:45 AM · Elisa
mgallien added a comment to D22769: Make MediaPlayList responsible for remaining tracks.

Could you please add a general overview of what is the goal of this change ?

Tue, Aug 13, 5:24 AM · Elisa

Fri, Aug 9

mgallien committed R255:c07cbe45eecf: Fix fetching all albums from an artist even without album artist tag (authored by mgallien).
Fix fetching all albums from an artist even without album artist tag
Fri, Aug 9, 9:56 PM
mgallien closed D23053: Fix fetching all albums from an artist even without album artist tag.
Fri, Aug 9, 9:56 PM
mgallien requested review of D23053: Fix fetching all albums from an artist even without album artist tag.
Fri, Aug 9, 4:50 PM

Thu, Aug 8

mgallien added a comment to D22499: fix the compilation album insertion.

The artists view is not working properly now with a fresh database. The artists are correctly shown. But when clicking on them no albums show up

Thu, Aug 8, 8:46 AM
mgallien added a comment to D22772: Rework the mediaplayercontrol.

friendly ping @mgallien for the series

Thu, Aug 8, 8:13 AM · Elisa

Tue, Aug 6

mgallien added a comment to D22951: Make it easier to click on a new position for the playback and volume sliders.

Works much better thanks.

On the other hand, should any customization be removed to lower the maintenance cost ?

Ideally, it certainly would--and had the same thought while I was working with this. However I see why you implemented a custom styling: because the default blue slider appearance is quite distracting in a music player. It would be ideal if the QML slider had a way to only change the color without needing to re-implement the whole appearance. Or actually, maybe that would be something we could do in QQC2-style? Need to investigate.

Regardless, if we dropped our custom styling it would actually regress the usability compared to this patch, because with this patch the click area extends to the full height of the player bar; with the default un-styled slider, the click area is a bit taller than it is before this patch, but not as tall as it is with this patch. So I'd want that fixed too before we drop the custom styling.

My recommendation is to land this patch and work upstrream to implement those fixes to the QML slider, then later drop the custom styling. Does that make sense to you?

Tue, Aug 6, 8:32 PM
mgallien added a comment to D22499: fix the compilation album insertion.

This fixes the issue fully for me and I cannot find any regressions--after a full re-index. That did not happen automatically; maybe it should? Can it?

Tue, Aug 6, 8:26 PM
mgallien accepted D22951: Make it easier to click on a new position for the playback and volume sliders.

Works much better thanks.

Tue, Aug 6, 8:24 PM
mgallien committed R255:61f063362cde: fix the compilation album insertion (authored by mgallien).
fix the compilation album insertion
Tue, Aug 6, 8:10 PM
mgallien closed D22499: fix the compilation album insertion.
Tue, Aug 6, 8:10 PM
mgallien added a comment to D21525: Add support for radio streams.

Thank you a lot for your advice.

I actually would like to get it merged rather sooner than later as this revision touches various places and is probably a pain to rebase.
We could merge as a single big commit if you promise to stay around a little while in case some things need changing afterwards.

I agree, the later the revision is, the more time consuming is a rebase.
I will try to get most of the job done during this week, and I will be around until the end of August :).

Tue, Aug 6, 5:14 PM
mgallien updated the test plan for D22499: fix the compilation album insertion.
Tue, Aug 6, 4:57 PM
mgallien added a comment to D22499: fix the compilation album insertion.

It now shows duplicated artists in the albums view here

Tue, Aug 6, 4:55 PM
mgallien closed D22972: fix import of multi-valued data from existing Baloo db.
Tue, Aug 6, 4:54 PM
mgallien committed R255:c6e8f3e5a300: fix import of multi-valued data from existing Baloo db (authored by mgallien).
fix import of multi-valued data from existing Baloo db
Tue, Aug 6, 4:54 PM
mgallien updated the diff for D22499: fix the compilation album insertion.
  • more fixes for album discovery when album artist may be missing
  • correctly get the single common artists for albums without album artist
Tue, Aug 6, 4:52 PM
mgallien updated the diff for D22972: fix import of multi-valued data from existing Baloo db.

fix diff to inlucde only the correct changes

Tue, Aug 6, 3:46 PM
mgallien requested review of D22972: fix import of multi-valued data from existing Baloo db.
Tue, Aug 6, 3:43 PM

Mon, Aug 5

mgallien accepted D22949: Always use white color for headerbar text.

I am convinced. Thanks

Mon, Aug 5, 8:22 PM
mgallien added a comment to D22949: Always use white color for headerbar text.

Thanks. Is it not easier to read with the glow?
I realize it was not consistently used.
Could you test with it everywhere?

Mon, Aug 5, 5:34 PM

Sun, Aug 4

mgallien accepted D22921: Use standard icon names.

Looks fine to me.
Thanks

Sun, Aug 4, 1:46 PM

Mon, Jul 29

mgallien updated the diff for D22499: fix the compilation album insertion.
  • more fixes for album discovery when album artist may be missing
Mon, Jul 29, 9:18 PM

Sun, Jul 28

mgallien requested changes to D21525: Add support for radio streams.

Thanks for your big work. This will be a really nice contribution.

Sun, Jul 28, 5:17 PM
mgallien updated the diff for D20476: [WIP] starts to make the list of renderers available and use it to play music.

rebase before starting again work on this now that my local setup is fixed

Sun, Jul 28, 1:53 PM
mgallien added a reviewer for D20476: [WIP] starts to make the list of renderers available and use it to play music: Elisa.
Sun, Jul 28, 1:53 PM

Jul 16 2019

mgallien requested review of D22499: fix the compilation album insertion.
Jul 16 2019, 10:05 PM

Jul 10 2019

mgallien added a comment to D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.

Please see my comment and other comments

Jul 10 2019, 6:05 AM · Elisa
mgallien added a comment to D21776: Implement new Header toolbar style for main view.

Now that this had landed, I can reproducibly reproduce the anchor loop issue that @mgallien saw when navigating from GenreArtistalbum.

Fixed with https://commits.kde.org/elisa/1906e6e9d22102d7d491253ccb240281f13a438b.

Sorry about that!

Jul 10 2019, 6:00 AM

Jul 5 2019

mgallien accepted D22204: Large cleanup, fixes and tweaks for playlists.
Jul 5 2019, 7:46 PM · Elisa
mgallien added a comment to D22204: Large cleanup, fixes and tweaks for playlists.

I would very much prefer to merge the code as is and improve afterwards as it touches various place and would be a pain to rebase.

Jul 5 2019, 7:44 PM · Elisa

Jul 3 2019

mgallien added a comment to D21525: Add support for radio streams.

Added delete feature for a radio, delete button is in the editing window

Jul 3 2019, 7:37 PM
mgallien added a comment to D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.

So, do we find an agreement here?

Jul 3 2019, 7:34 PM · Elisa
mgallien added a comment to D21776: Implement new Header toolbar style for main view.

FYI, I am not able to get this binding loop. I am on frameworks 5.59 and Qt 5.12.2
One small nitpick inline. Additionally, the Back Navigation button was previously hidden for the top views, now it is just disabled. I find it a little bit hard to distinguish between both states.

Jul 3 2019, 7:33 PM

Jul 1 2019

mgallien committed R877:d86a077eefb2: add new releases of Elisa and default to build last bugfix (authored by mgallien).
add new releases of Elisa and default to build last bugfix
Jul 1 2019, 9:59 PM
mgallien committed R256:0bc1439ddc3e: bump elisa bundled libvlc to 3.0.7.1 (authored by mgallien).
bump elisa bundled libvlc to 3.0.7.1
Jul 1 2019, 8:53 PM
mgallien abandoned D21749: build elisa witl libvlc 3.0.7 version.

Thanks for the review.
I fail to push with this error:

remote: FATAL: W refs/heads/master flatpak-kde-applications mgallien DENIED by refs/.*
remote: error: hook declined to update refs/heads/master
To git.kde.org:flatpak-kde-applications

! [remote rejected] 23c07b37f80c4618bffd732181172013085fa256 -> master (hook declined)

error: failed to push some refs to 'git@git.kde.org:flatpak-kde-applications'

Do you know what could be the explanation ?

Jul 1 2019, 8:52 PM

Jun 29 2019

mgallien committed R255:fe161e45c69a: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
Jun 29 2019, 1:18 PM
mgallien accepted D21920: Port elisa kcm to qqc2.

Thanks

Jun 29 2019, 1:11 PM · Elisa
mgallien accepted D21912: Port notification to qqc2.

Thanks

Jun 29 2019, 1:10 PM
mgallien added a comment to D21943: Port the application menu to qqc2.

I will commit once the binary factory is on 5.60

Jun 29 2019, 1:09 PM · Elisa
mgallien committed R255:8202bdfef770: prepare for 0.4.2 release (authored by mgallien).
prepare for 0.4.2 release
Jun 29 2019, 1:03 PM
mgallien committed R255:8874a00d9bb8: fix fetching embedded cover (authored by mgallien).
fix fetching embedded cover
Jun 29 2019, 1:02 PM

Jun 28 2019

mgallien added a comment to T11155: Improve Elisa Configuration Module.
Jun 28 2019, 4:48 PM · Elisa
mgallien moved T11155: Improve Elisa Configuration Module from Backlog to Next release on the Elisa board.
Jun 28 2019, 4:41 PM · Elisa
mgallien triaged T11155: Improve Elisa Configuration Module as High priority.
Jun 28 2019, 4:40 PM · Elisa
mgallien committed R255:fb928e0fa5a9: fix ViewManager automatic tests (authored by mgallien).
fix ViewManager automatic tests
Jun 28 2019, 4:08 PM
mgallien committed R255:957506e99888: bring back disc headers for multi disc albums (authored by mgallien).
bring back disc headers for multi disc albums
Jun 28 2019, 4:00 PM
mgallien closed D22110: bring back disc headers for multi disc albums.
Jun 28 2019, 4:00 PM
mgallien moved T11154: Extend ViewSelector to browse one of the top level category from Backlog to In Progress on the Elisa board.
Jun 28 2019, 3:56 PM · Elisa
mgallien added a subtask for T5028: Improve UPnP/DLNA integration by fetching changes from MediaServer: T11154: Extend ViewSelector to browse one of the top level category.
Jun 28 2019, 3:56 PM · Elisa
mgallien added a parent task for T11154: Extend ViewSelector to browse one of the top level category: T5028: Improve UPnP/DLNA integration by fetching changes from MediaServer.
Jun 28 2019, 3:56 PM · Elisa
mgallien triaged T11154: Extend ViewSelector to browse one of the top level category as High priority.
Jun 28 2019, 3:55 PM · Elisa
mgallien claimed T5028: Improve UPnP/DLNA integration by fetching changes from MediaServer.
Jun 28 2019, 3:54 PM · Elisa
mgallien closed T11063: Factor List Views as Resolved.
Jun 28 2019, 3:53 PM · Elisa
mgallien added a comment to D21943: Port the application menu to qqc2.

Though since D21944 is in a framework, perhaps once it lands, we should increase Elisa's frameworks dependency version here, or else the menus will look ugly.

Jun 28 2019, 3:40 PM · Elisa
mgallien accepted D21943: Port the application menu to qqc2.

@mgallien QQC2 can be styled in multiple ways; the screenshot is just showing the desktop (aka Breeze) style. LGTM in conjunction with D21944.

Jun 28 2019, 2:57 PM · Elisa

Jun 27 2019

mgallien updated the diff for D22110: bring back disc headers for multi disc albums.

rebase on master and use i18n proper call

Jun 27 2019, 8:43 PM
mgallien committed R255:727371e95002: Merge branch '0.4' (authored by mgallien).
Merge branch '0.4'
Jun 27 2019, 4:06 PM
mgallien added a comment to D21943: Port the application menu to qqc2.

What is the reference of the patch for the desktop style ?

Jun 27 2019, 3:31 PM · Elisa
mgallien added inline comments to D21920: Port elisa kcm to qqc2.
Jun 27 2019, 3:30 PM · Elisa
mgallien added inline comments to D22110: bring back disc headers for multi disc albums.
Jun 27 2019, 5:59 AM
mgallien added a comment to D21912: Port notification to qqc2.

Thanks for your work. See my comment.

Jun 27 2019, 5:35 AM
mgallien requested review of D22110: bring back disc headers for multi disc albums.
Jun 27 2019, 5:26 AM

Jun 26 2019

mgallien added a comment to D12992: New elisa icon.

Using @abetts prototype: No blockers, incorporating the given teal and green colours given by mgallien is TODO.

Otherwise, the blocker would be to find what visual profile Elisa has so that we can work around that.

Jun 26 2019, 2:16 PM · Frameworks, Elisa
mgallien moved T5028: Improve UPnP/DLNA integration by fetching changes from MediaServer from Backlog to Next release on the Elisa board.
Jun 26 2019, 5:17 AM · Elisa
mgallien assigned T7567: Add support for radio streams to jguidon.
Jun 26 2019, 5:17 AM · Elisa
mgallien moved T11063: Factor List Views from In Progress to Done on the Elisa board.
Jun 26 2019, 5:16 AM · Elisa

Jun 25 2019

mgallien added a comment to D21776: Implement new Header toolbar style for main view.

@mgallien I am not able to reproduce the anchor loop warning. The new code I've added actually doesn't even set any anchors on the child items of the HeaderFooterToolbar components.

I will have another look tonight and report here. Sorry

Jun 25 2019, 9:05 PM
mgallien added a comment to D22086: the background of the view selector list should be transparent.

Thanks for the tests and the review.

Jun 25 2019, 3:36 PM
mgallien closed D22086: the background of the view selector list should be transparent.
Jun 25 2019, 3:26 PM
mgallien committed R255:4bee9b30c4b0: the background of the view selector list should be transparent (authored by mgallien).
the background of the view selector list should be transparent
Jun 25 2019, 3:26 PM
mgallien updated the diff for D22086: the background of the view selector list should be transparent.
  • remove the background rectangle that used to indicate the active focus
Jun 25 2019, 3:25 PM
mgallien added a comment to T11099: Service based multimedia desktop.

In fact, if you want to access web services to get multimedia data, there are no frameworks to do it. Plasma Media Center has a lot of those components. They could serve as a good way to bootstrap such a framework.
In order to have pervasive integration of DLNA or ChromeCast, there are no easy pervasive solution in KF5 frameworks.
A KDE wide goal could be to add such support to many KDE applications.

Jun 25 2019, 1:12 PM · Goal Setting 2019
mgallien added a comment to D21776: Implement new Header toolbar style for main view.

@mgallien I am not able to reproduce the anchor loop warning. The new code I've added actually doesn't even set any anchors on the child items of the HeaderFooterToolbar components.

Jun 25 2019, 9:21 AM
mgallien requested review of D22086: the background of the view selector list should be transparent.
Jun 25 2019, 5:44 AM

Jun 24 2019

mgallien added a comment to T7597: Add a progress bar under the current track in playlist.

Btw retried Elisa with my big music collection, and it works now. :)

Jun 24 2019, 9:08 PM · Elisa
mgallien added a comment to D21776: Implement new Header toolbar style for main view.

It has really evolved to be something very desirable. Congratulations on the very good work.

Jun 24 2019, 9:02 PM
mgallien added a comment to T11099: Service based multimedia desktop.

I would be very interested to hear more about your plans. You also may discover that Baloo already provides a lot in the area of multimedia files database.

Jun 24 2019, 8:54 PM · Goal Setting 2019
mgallien accepted D21771: Polish Context View.

Thanks for your work.

Jun 24 2019, 8:26 PM
mgallien committed R255:a3eb443d137b: fix restore of tracks with missing metadata in playlist (authored by mgallien).
fix restore of tracks with missing metadata in playlist
Jun 24 2019, 3:33 PM
mgallien closed D21900: fix restore of tracks with missing metadata in playlist.
Jun 24 2019, 3:33 PM · Elisa