mgallien (Matthieu Gallien)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 10 2015, 7:32 AM (150 w, 5 h)
Availability
Available

Recent Activity

Sun, Sep 23

mgallien added a comment to D8532: [WIP] Restrict file extractor with Seccomp.

I was asked in private about the current state of libseccomp integration and why there was no progress in a long time.
The current state is, that I have implemented seccomp support in kfilemetadata using this API:

bool setProcessReadOnly(uint32_t defaultAction, std::vector<SeccompFilter> addionalWhitelist)

But there are two blockers, related to external plugins:

  • External plugins based on interpreters like python/lua/perl etc. need a huge whitelist. This is problematic as I want to keep the list of allowed syscalls as small as possible (the list would be huge). Additionally, it would be difficult to get a list of all needed syscalls. Thus, we would break many external plugins.
  • Baloo is basically unmaintained. Thus, if something breaks, fixing it should be as easy as possible. But what if QT requires a new syscall and thus, the tests (and deployments) are failing? We need a way to know which syscall failed. This works for kfilemetadata plugins, but not for external plugins (because they are separate processes). The only way I can image, would be running the whole test with strace.

    So, if anyone is willing to continue this work, I would be happy to share my current state. Otherwise, if everyone agrees that we don't care about external plugins (users of external plugins can disable Seccomp support with an environment variable), I can finish the patches.
Sun, Sep 23, 9:14 PM · Baloo, Frameworks
mgallien committed R255:d69f6cd181c7: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Sun, Sep 23, 7:58 PM
mgallien committed R255:3f15d516b980: Gives immediate focus to the search entry control after pressing the shortcut… (authored by mgallien).
Gives immediate focus to the search entry control after pressing the shortcut…
Sun, Sep 23, 7:55 PM
mgallien closed D15607: Gives immediate focus to the search entry control after pressing the shortcut to show it.
Sun, Sep 23, 7:55 PM · Elisa
mgallien committed R255:a33a3795e94f: only watch changed files if they allow to build an audio track from them (authored by mgallien).
only watch changed files if they allow to build an audio track from them
Sun, Sep 23, 7:50 PM
mgallien added a comment to D15607: Gives immediate focus to the search entry control after pressing the shortcut to show it.

I think there is still one issue: when the view is not collapsed and you click on e.g. artist view, the search field also doesn't get focus immediately. but it's an improvement anyway

Sun, Sep 23, 7:47 PM · Elisa

Thu, Sep 20

mgallien added a comment to D15614: remove usage of own TString to QString conversion function.

The removal of the convertWCharsToQString function is safe, right? It was never exported

Thu, Sep 20, 8:35 AM · Baloo, Frameworks
mgallien accepted D15588: Fix compile with QT_NO_NARROWING_CONVERSIONS_IN_CONNECT flags.
Thu, Sep 20, 5:07 AM

Wed, Sep 19

mgallien accepted D15486: disable sorting for single album view.
Wed, Sep 19, 8:17 PM · Elisa
mgallien added a project to D15607: Gives immediate focus to the search entry control after pressing the shortcut to show it: Elisa.
Wed, Sep 19, 8:16 PM · Elisa
mgallien requested review of D15607: Gives immediate focus to the search entry control after pressing the shortcut to show it.
Wed, Sep 19, 8:12 PM · Elisa
mgallien committed R255:bbde9ff77bad: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Wed, Sep 19, 8:04 PM
mgallien committed R255:0a4b77a76e8f: hopefully fix OSX builds by using standard paths for libraries (authored by mgallien).
hopefully fix OSX builds by using standard paths for libraries
Wed, Sep 19, 8:04 PM
mgallien requested changes to D15588: Fix compile with QT_NO_NARROWING_CONVERSIONS_IN_CONNECT flags.

Thanks for your help.
Sorry for the noise with the wrong comment.
Please fix one inline comment.

Wed, Sep 19, 3:57 PM
mgallien added a comment to D13872: introduce ElisaToolButton and use it in MediaPlayerControl.

As an example, I did try this:

Wed, Sep 19, 3:44 PM · Elisa
mgallien added a comment to D15588: Fix compile with QT_NO_NARROWING_CONVERSIONS_IN_CONNECT flags.
Wed, Sep 19, 3:43 PM
mgallien added a comment to D13872: introduce ElisaToolButton and use it in MediaPlayerControl.

I have spent some more time looking at your patch and fail to see the rationale behind the way tooltips are added. Did you try the ToolTip attached property ? That would be the "good" way to do it.

Wed, Sep 19, 3:32 PM · Elisa
mgallien added a comment to D13872: introduce ElisaToolButton and use it in MediaPlayerControl.

I do not understand your intent with this patch. Especially the way you provide a special ToolButton with a lot of things in it.
Please explain better why each element in ElisaToolButton is here ?

Wed, Sep 19, 5:41 AM · Elisa
mgallien requested changes to D15486: disable sorting for single album view.
Wed, Sep 19, 5:35 AM · Elisa

Mon, Sep 17

mgallien committed R255:b380d80ce243: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Mon, Sep 17, 8:44 PM
mgallien committed R255:773c093b7206: add a track cache in database to reduce memory usage (authored by mgallien).
add a track cache in database to reduce memory usage
Mon, Sep 17, 8:43 PM
mgallien closed D15465: add a track cache in database to reduce memory usage.
Mon, Sep 17, 8:43 PM
mgallien committed R255:01c393ec2c0b: makes data classes be implicitely shared: decrease memory usage (authored by mgallien).
makes data classes be implicitely shared: decrease memory usage
Mon, Sep 17, 8:43 PM
mgallien closed D15456: makes data classes be implicitely shared: decrease memory usage.
Mon, Sep 17, 8:43 PM · Elisa
mgallien committed R255:938c1f5ab3b1: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Mon, Sep 17, 6:39 PM
mgallien committed R255:ec881c1c8329: try to fix the OS X build by providing correct installation path (authored by mgallien).
try to fix the OS X build by providing correct installation path
Mon, Sep 17, 6:39 PM
mgallien committed R255:38b82f9a02b9: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Mon, Sep 17, 6:35 PM
mgallien committed R255:152cbb81c080: allow ViewSelector to show icon only when the window is small (authored by mgallien).
allow ViewSelector to show icon only when the window is small
Mon, Sep 17, 6:35 PM
mgallien committed R255:34dc3e309209: allow ViewSelector to show icon only when the window is small (authored by mgallien).
allow ViewSelector to show icon only when the window is small
Mon, Sep 17, 6:34 PM
mgallien closed D15308: allow ViewSelector to show icon only when the window is small.
Mon, Sep 17, 6:34 PM

Sun, Sep 16

mgallien added a comment to T7184: Explore using VLC as an alternative to Qt Multimedia on desktop targets.

Digikam switched to QtAV once and they said it's better for cross-platform. It also has a QML interface and a similar API to Qt Multimedia. I think you should check that first before VLC.

Sun, Sep 16, 7:47 PM · Elisa
mgallien renamed T7184: Explore using VLC as an alternative to Qt Multimedia on desktop targets from Explore switching to Phonon on desktop targets to Explore using VLC as an alternative to Qt Multimedia on desktop targets.
Sun, Sep 16, 10:06 AM · Elisa
mgallien updated the task description for T9641: Publish Elisa in the Microsoft Store.
Sun, Sep 16, 10:01 AM · Elisa, Windows

Sat, Sep 15

mgallien committed R234:3b6e8c6b5c43: update screenshot of Elisa Music Player (authored by mgallien).
update screenshot of Elisa Music Player
Sat, Sep 15, 11:07 AM
mgallien committed R255:76260d89e4ea: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Sat, Sep 15, 7:33 AM
mgallien committed R255:dd6aceec33a7: fix a warning of FreeBSD KDE CI infrastructure (authored by mgallien).
fix a warning of FreeBSD KDE CI infrastructure
Sat, Sep 15, 7:32 AM
mgallien committed R255:1c78eebee0df: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Sat, Sep 15, 7:24 AM
mgallien committed R255:fa19873d0789: fix some issues reported by clazy (authored by mgallien).
fix some issues reported by clazy
Sat, Sep 15, 7:24 AM
mgallien committed R255:db1113e46db4: try again to fix a failing test on Windows (authored by mgallien).
try again to fix a failing test on Windows
Sat, Sep 15, 7:24 AM

Fri, Sep 14

mgallien committed R255:ddf68dc959e8: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Fri, Sep 14, 9:22 PM
mgallien committed R255:216b2c207d07: try to fix MediaPlayListTest on windows (authored by mgallien).
try to fix MediaPlayListTest on windows
Fri, Sep 14, 9:16 PM
mgallien committed R255:d7192153d2d2: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Fri, Sep 14, 9:12 PM
mgallien committed R255:13ea2defc01c: small documentation update (authored by mgallien).
small documentation update
Fri, Sep 14, 9:12 PM
mgallien committed R255:7928dd2f389c: master will become 0.3.80 (beta version of 0.4) (authored by mgallien).
master will become 0.3.80 (beta version of 0.4)
Fri, Sep 14, 8:36 PM
mgallien committed R255:3e3f5adfa635: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Fri, Sep 14, 8:36 PM
mgallien committed R255:a4573f159c67: small doc update (authored by mgallien).
small doc update
Fri, Sep 14, 8:34 PM
mgallien committed R255:b6434bcbfbf3: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Fri, Sep 14, 8:07 PM
mgallien committed R255:5539e98e9e3c: deactive the qml graphical automatic tests on Windows (authored by mgallien).
deactive the qml graphical automatic tests on Windows
Fri, Sep 14, 8:07 PM
mgallien committed R255:f4fdfd8971d9: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Fri, Sep 14, 7:56 PM
mgallien committed R255:a3dc2fb015d0: fix install of elisaLib on dll platforms (authored by mgallien).
fix install of elisaLib on dll platforms
Fri, Sep 14, 7:49 PM
mgallien accepted D15484: add margins for playing indicator.
Fri, Sep 14, 5:18 AM · Elisa

Thu, Sep 13

mgallien added inline comments to D15308: allow ViewSelector to show icon only when the window is small.
Thu, Sep 13, 9:09 PM
mgallien updated the diff for D15308: allow ViewSelector to show icon only when the window is small.
  • ViewSelector resize according to the maximum width set from ContentView
  • ensure that the filter part in NavigationActionBar can become small
  • remove unused property in BaseTheme component
Thu, Sep 13, 9:07 PM
mgallien added inline comments to D15308: allow ViewSelector to show icon only when the window is small.
Thu, Sep 13, 9:06 PM
mgallien committed R255:ee78a5679650: install elisa private library in a lib sub folder (authored by mgallien).
install elisa private library in a lib sub folder
Thu, Sep 13, 8:52 PM
mgallien committed R255:9a760cff5ac1: install elisa private library in a lib sub folder (authored by mgallien).
install elisa private library in a lib sub folder
Thu, Sep 13, 8:50 PM
mgallien committed R255:3f9793053875: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Thu, Sep 13, 7:50 PM
mgallien committed R255:77d5946c660f: fix handling of baloo starting after elisa (authored by mgallien).
fix handling of baloo starting after elisa
Thu, Sep 13, 7:50 PM
mgallien closed D15298: fix handling of baloo starting after elisa.
Thu, Sep 13, 7:50 PM · Elisa
mgallien requested changes to D15484: add margins for playing indicator.

The different titles are no longer aligned. Please fix that. It is important that the album title is aligned with tracks title.

Thu, Sep 13, 7:35 PM · Elisa
mgallien committed R255:8dc80f68bdd9: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Thu, Sep 13, 7:29 PM
mgallien committed R255:2b3b969aa4c9: clean some white space (authored by mgallien).
clean some white space
Thu, Sep 13, 7:28 PM
mgallien committed R255:b43f6bca44aa: fix wording of the license header to really be LGPLv3+ (authored by mgallien).
fix wording of the license header to really be LGPLv3+
Thu, Sep 13, 7:28 PM
mgallien updated the diff for D15465: add a track cache in database to reduce memory usage.

rebase on top of the 0.3 branch

Thu, Sep 13, 7:13 PM
mgallien updated the diff for D15456: makes data classes be implicitely shared: decrease memory usage.

rebase on top of 0.3 branch

Thu, Sep 13, 7:10 PM · Elisa
mgallien added a comment to D15298: fix handling of baloo starting after elisa.

I already did that, and in both cases tracks showed up. will try once more

Thu, Sep 13, 7:09 PM · Elisa
mgallien updated the diff for D15308: allow ViewSelector to show icon only when the window is small.
  • ViewSelector resize according to the maximum width set from ContentView
  • ensure that the filter part in NavigationActionBar can become small
Thu, Sep 13, 7:06 PM
mgallien committed R255:be6b602d437b: introduce BaseTheme to allow inheritage between platform themes (authored by mgallien).
introduce BaseTheme to allow inheritage between platform themes
Thu, Sep 13, 6:45 PM
mgallien closed D15437: introduce BaseTheme to allow inheritage between platform themes.
Thu, Sep 13, 6:45 PM
mgallien added a comment to D15298: fix handling of baloo starting after elisa.

I can't reproduce. What's the exact test plan?

Thu, Sep 13, 6:06 PM · Elisa

Wed, Sep 12

mgallien requested review of D15465: add a track cache in database to reduce memory usage.
Wed, Sep 12, 8:29 PM
mgallien added reviewers for D15456: makes data classes be implicitely shared: decrease memory usage: astippich, januz, ognarb.
Wed, Sep 12, 3:46 PM · Elisa
mgallien added a project to D15456: makes data classes be implicitely shared: decrease memory usage: Elisa.
Wed, Sep 12, 3:45 PM · Elisa
mgallien requested review of D15456: makes data classes be implicitely shared: decrease memory usage.
Wed, Sep 12, 3:42 PM · Elisa

Tue, Sep 11

mgallien planned changes to D15308: allow ViewSelector to show icon only when the window is small.

Once D15437 is landed, I will update this one on top of it.

Tue, Sep 11, 8:16 PM
mgallien requested review of D15437: introduce BaseTheme to allow inheritage between platform themes.
Tue, Sep 11, 8:15 PM
mgallien added a comment to D15308: allow ViewSelector to show icon only when the window is small.

Thanks again for your review.
The fact that everything has to be duplicated is a conception mistake. I will open a review to fix that.

Tue, Sep 11, 8:07 PM
mgallien added a comment to D15200: fix margins and size for playlist entry.

Yes, this is supposed to fix the issue with the album header. The removal of the brightness contrast is actually unrelated to this, but it seemed unnecessary while looking at it.

Imho if adding a simple margin setting to an item in an unrelated qml row leads to these bugs, this code is quite fragile. I also don't know what all the math is about for a simple layout margin of an image for the main icon.

I have created D15322 with a proper fix for the album header bad handling of different font sizes.
This is a general problem in many layout in Elisa, they do not play nicely with different font sizes.
I fail to see how this review deal with this.

Now I am a bit confused. Is this the root cause? Can 0d5fbd5474eb now be applied again? Because I think it looks more polished and consistent if the indicator has some margin like everything else.
I factored out the changes with the BrightnessContrast into D15434 since they are unrelated

Tue, Sep 11, 8:06 PM · Elisa
mgallien accepted D15434: remove brightness contrast in favor of opacity.

Thanks

Tue, Sep 11, 8:04 PM · Elisa

Mon, Sep 10

mgallien committed R877:5bb89d3599d3: switch elisa to build the 0.3 stable branch by default (authored by mgallien).
switch elisa to build the 0.3 stable branch by default
Mon, Sep 10, 10:01 PM
mgallien committed R255:624b7c4ba7ef: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Mon, Sep 10, 3:38 PM
mgallien committed R255:4ab02ebfef7d: try to fix ManageAudioPlayerTest::skipNextTrackWithRandomPlay on all Qt (authored by mgallien).
try to fix ManageAudioPlayerTest::skipNextTrackWithRandomPlay on all Qt
Mon, Sep 10, 3:29 PM
mgallien committed R255:492ac082732b: ensure headers in playlist are sized according to the font (authored by mgallien).
ensure headers in playlist are sized according to the font
Mon, Sep 10, 3:14 PM
mgallien closed D15322: ensure headers in playlist are sized according to the font.
Mon, Sep 10, 3:13 PM
mgallien committed R255:5b6dbbf95934: Merge branch '0.3' (authored by mgallien).
Merge branch '0.3'
Mon, Sep 10, 5:45 AM
mgallien committed R255:f3f4e1ffed76: fix failing tests with Qt 5.11 (authored by mgallien).
fix failing tests with Qt 5.11
Mon, Sep 10, 5:45 AM
mgallien committed R255:7f4ac1ebf872: fix failing tests with Qt 5.11 (authored by mgallien).
fix failing tests with Qt 5.11
Mon, Sep 10, 5:45 AM
mgallien closed D15007: fix failing tests with Qt 5.11.
Mon, Sep 10, 5:45 AM

Sun, Sep 9

mgallien committed R877:dd56d17c1e52: add 0.3 stable branch and switch by deault 0.2.80 tarball for elisa (authored by mgallien).
add 0.3 stable branch and switch by deault 0.2.80 tarball for elisa
Sun, Sep 9, 8:05 PM

Sat, Sep 8

mgallien accepted D13700: implement reading of the replaygain tags.
Sat, Sep 8, 7:22 AM · Baloo, Frameworks
mgallien added a comment to D13700: implement reading of the replaygain tags.

Thanks for your hard work. This is a really nice addition to audio tags.
I no longer have objections. Please finish to take into account feedback from @bruns.

Sat, Sep 8, 7:22 AM · Baloo, Frameworks
mgallien updated the diff for D15308: allow ViewSelector to show icon only when the window is small.
  • ViewSelector resize according to the maximum width set from ContentView
Sat, Sep 8, 7:12 AM
mgallien planned changes to D15308: allow ViewSelector to show icon only when the window is small.

I like the idea, but it still shows the elided text with about 3 visible characters.

Sat, Sep 8, 6:38 AM

Fri, Sep 7

mgallien committed R255:74cc2c558ad9: bump version in preparation for the next 0.4 beta (authored by mgallien).
bump version in preparation for the next 0.4 beta
Fri, Sep 7, 3:17 PM
mgallien committed R255:1cefcf1729f8: bump version to 0.3 in preparation for the next stable release (authored by mgallien).
bump version to 0.3 in preparation for the next stable release
Fri, Sep 7, 3:16 PM
mgallien added a comment to D15200: fix margins and size for playlist entry.

Yes, this is supposed to fix the issue with the album header. The removal of the brightness contrast is actually unrelated to this, but it seemed unnecessary while looking at it.

Imho if adding a simple margin setting to an item in an unrelated qml row leads to these bugs, this code is quite fragile. I also don't know what all the math is about for a simple layout margin of an image for the main icon.

Fri, Sep 7, 5:55 AM · Elisa
mgallien requested review of D15322: ensure headers in playlist are sized according to the font.
Fri, Sep 7, 5:50 AM
mgallien committed R255:7d8efafdaa6f: Revert "add margin around playing indicator" (authored by mgallien).
Revert "add margin around playing indicator"
Fri, Sep 7, 5:46 AM
mgallien added a reverting change for R255:0d5fbd5474eb: add margin around playing indicator: R255:7d8efafdaa6f: Revert "add margin around playing indicator".
Fri, Sep 7, 5:46 AM

Thu, Sep 6

mgallien updated the diff for D15007: fix failing tests with Qt 5.11.
  • fix allalbumsmodeltest that was checking the wrong number of albums
Thu, Sep 6, 8:10 PM