mgallien (Matthieu Gallien)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Nov 10 2015, 7:32 AM (136 w, 4 d)
Availability
Available

Recent Activity

Today

mgallien requested changes to D13685: allow metadata of tracks without title and album in database.

I have three main issues with this patch:

  • automatic tests related to this change are missing. This is especially important considering this is a big and scary change. You will need to test that all other classes are able to cope with title being empty (for example) ;
  • As is, the Sql is faulty (syntax error: SELECT tracks.ID, tracks.Title, artistAlbum.Name FROM Tracks tracks, LEFT JOIN Albums album ON album.ID = tracks.AlbumID LEFT JOIN AlbumsArtists artistAlbumMapping ON artistAlbumMapping.AlbumID = album.ID LEFT JOIN Artists artistAlbum ON artistAlbum.ID = artistAlbumMapping.ArtistID "

QDEBUG : DatabaseInterfaceTests::addOneTrackWithoutAlbumArtist() DatabaseInterface::initRequest QSqlError("1", "Unable to execute statement", "no such table: LEFT") ;

  • I am not convinced this is the right approach. I have the feeling that just deriving a title from the filename when there is no such metadata would fix most problems in a much simpler way.
Sat, Jun 23, 5:57 PM · Elisa

Yesterday

mgallien updated the diff for D13423: unmerge albums by using the paths of their tracks.
  • fix upgrade path from older database schema of Elisa
Fri, Jun 22, 9:31 PM
mgallien updated the task description for T7676: Add a mode where all the bottom part can be hidden.
Fri, Jun 22, 8:23 PM · Elisa
mgallien triaged T9069: Allow more flexibility in the application layout as Normal priority.
Fri, Jun 22, 8:20 PM · Elisa
mgallien added a project to T9069: Allow more flexibility in the application layout: Elisa.
Fri, Jun 22, 8:20 PM · Elisa
mgallien created T9069: Allow more flexibility in the application layout.
Fri, Jun 22, 8:20 PM · Elisa
mgallien triaged T7676: Add a mode where all the bottom part can be hidden as Normal priority.
Fri, Jun 22, 8:18 PM · Elisa
mgallien updated the task description for T6293: Fix HeaderBar for missing animations.
Fri, Jun 22, 8:18 PM · Elisa
mgallien committed R255:a1bc3bde65c5: Merge branch '0.2' (authored by mgallien).
Merge branch '0.2'
Fri, Jun 22, 7:48 PM
mgallien committed R255:033e5ce0841f: fix artist being empty when they are only used as album artists (authored by mgallien).
fix artist being empty when they are only used as album artists
Fri, Jun 22, 7:47 PM
mgallien closed D13681: fix artist being empty when they are only used as album artists.
Fri, Jun 22, 7:47 PM
mgallien closed T8695: Ensure user visible paths are looking native and easy to read as Resolved.
Fri, Jun 22, 3:51 PM · Elisa
mgallien raised the priority of T8953: Improve detection of different albums from Normal to High.
Fri, Jun 22, 3:50 PM · Elisa
mgallien lowered the priority of T8953: Improve detection of different albums from High to Normal.
Fri, Jun 22, 3:50 PM · Elisa
mgallien requested review of D13681: fix artist being empty when they are only used as album artists.
Fri, Jun 22, 3:48 PM

Thu, Jun 21

mgallien added a comment to D13639: move the playing indicator to be first on line and align titles.

+1 for @januz's idea about not following the alternating background color for header rows (i.e. make them always be white or gray). I think that would help to make albums more distinct from one another in the list.

@ngraham @januz What do you have in mind ? I could do album header in white and alternating colors for the tracks including the first one. I am affraid it would look odd if the previous album finished with a white track. Anyway, I will try that.

Thu, Jun 21, 8:45 PM
mgallien added a comment to D13639: move the playing indicator to be first on line and align titles.

+1 for @januz's idea about not following the alternating background color for header rows (i.e. make them always be white or gray). I think that would help to make albums more distinct from one another in the list.

Thu, Jun 21, 8:06 PM
mgallien added a comment to D13639: move the playing indicator to be first on line and align titles.

New version:

Thu, Jun 21, 7:57 PM
mgallien updated the diff for D13639: move the playing indicator to be first on line and align titles.
  • remove useless i18nc calls
  • only display track number if it is valid
  • all text for currently playing track is now bold
  • fix issues for reversed layout
  • align cover image with end of track number and add vertical margins
Thu, Jun 21, 7:56 PM
mgallien committed R255:cc1a1edb8df6: Merge branch '0.2' (authored by mgallien).
Merge branch '0.2'
Thu, Jun 21, 7:21 PM
mgallien committed R255:9a678f074866: Hide stars when there is no rating (authored by januz).
Hide stars when there is no rating
Thu, Jun 21, 7:21 PM
mgallien accepted D13464: unbreak windows platform integration.
Thu, Jun 21, 3:15 PM

Wed, Jun 20

mgallien updated the diff for D13639: move the playing indicator to be first on line and align titles.
  • remove useless i18nc calls
Wed, Jun 20, 9:16 PM
mgallien added a comment to D13639: move the playing indicator to be first on line and align titles.

It is heavily inspired by https://diegogangl.github.io/

Wed, Jun 20, 9:14 PM
mgallien requested review of D13639: move the playing indicator to be first on line and align titles.
Wed, Jun 20, 9:12 PM
mgallien accepted D12975: Hide stars when there is no rating.

Works fine thanks.
Sorry for the delay due to me being sick

Wed, Jun 20, 9:06 PM · Elisa
mgallien requested changes to D13463: resize metadata view dynamically.

It is still not resizable even if kwin adds a resize handle.
There is also problems with the close button being partially covered and the track path being partially hidden.

Wed, Jun 20, 9:03 PM
mgallien committed R286:aa90123a8c18: automatic tests: do not embed EmbeddedImageData already in the library (authored by mgallien).
automatic tests: do not embed EmbeddedImageData already in the library
Wed, Jun 20, 2:44 PM
mgallien closed D13630: automatic tests: do not embed EmbeddedImageData already in the library.
Wed, Jun 20, 2:44 PM · Baloo, Frameworks
mgallien added a comment to D12320: add ability to read embedded cover files.

D13630 should fix the Windows build. Sorry for not noticing this before. I was mostly away from keyboard for the last two weeks after having been sick.

Wed, Jun 20, 12:47 PM · Baloo, Frameworks
mgallien requested review of D13630: automatic tests: do not embed EmbeddedImageData already in the library.
Wed, Jun 20, 12:45 PM · Baloo, Frameworks

Sun, Jun 17

mgallien committed R877:8f2afd26205c: provide a custom definition of the 0.1.80 target for Elisa (authored by mgallien).
provide a custom definition of the 0.1.80 target for Elisa
Sun, Jun 17, 8:21 PM

Thu, Jun 14

mgallien committed R877:cf359c90c2d6: update Elisa blueprints: new branch and tarball and switch default to 0.1.80 (authored by mgallien).
update Elisa blueprints: new branch and tarball and switch default to 0.1.80
Thu, Jun 14, 5:57 AM
mgallien abandoned D12673: bump dependencies of Elisa to v5.45.0 for KDE frameworks and 5.10 for Qt.

No longer needed

Thu, Jun 14, 5:55 AM
mgallien committed R255:cc6c9a39fe62: Merge branch '0.2' (authored by mgallien).
Merge branch '0.2'
Thu, Jun 14, 5:43 AM
mgallien committed R255:289683b16f28: use new icons from Breeze to indicate pauses and playing status (authored by mgallien).
use new icons from Breeze to indicate pauses and playing status
Thu, Jun 14, 5:42 AM
mgallien closed D13324: use new icons from Breeze to indicate pauses and playing status.
Thu, Jun 14, 5:42 AM

Sat, Jun 9

mgallien requested verification of R255:82e3d9466917: fix first cover not shown when restoring a playlist at start of Elisa.
Sat, Jun 9, 2:49 PM
mgallien added a comment to R255:82e3d9466917: fix first cover not shown when restoring a playlist at start of Elisa.

This commit has really been intended to fix the fact that the first cover was not showing up when starting Elisa with a current playlist to be restored. I believe the title properly indicates this.

Sat, Jun 9, 2:48 PM
mgallien committed R255:713136199cf4: remove useless #include in trackdatahelper.cpp (authored by mgallien).
remove useless #include in trackdatahelper.cpp
Sat, Jun 9, 2:45 PM
mgallien committed R255:a5de98949ff8: put back MediaTrackMetadataView back to its previous state (authored by mgallien).
put back MediaTrackMetadataView back to its previous state
Sat, Jun 9, 2:45 PM
mgallien committed R255:ac8860e4056b: fix issues generated by 82e3d9466917a3f6ca7a7a9f5b6461c903471e9a in album view (authored by mgallien).
fix issues generated by 82e3d9466917a3f6ca7a7a9f5b6461c903471e9a in album view
Sat, Jun 9, 2:45 PM
mgallien committed R255:ae76b0e2a79c: fix management of the current item in album view (authored by mgallien).
fix management of the current item in album view
Sat, Jun 9, 2:45 PM
mgallien committed R255:0701a7c6a665: Merge branch '0.2' (authored by mgallien).
Merge branch '0.2'
Sat, Jun 9, 8:36 AM
mgallien committed R255:0b1cb8fa59d9: makes path returned by TrackDataHelper looks local when they are local (authored by mgallien).
makes path returned by TrackDataHelper looks local when they are local
Sat, Jun 9, 8:35 AM
mgallien closed D13337: makes path returned by TrackDataHelper looks local when they are local.
Sat, Jun 9, 8:35 AM
mgallien committed R255:82e3d9466917: fix first cover not shown when restoring a playlist at start of Elisa (authored by mgallien).
fix first cover not shown when restoring a playlist at start of Elisa
Sat, Jun 9, 8:35 AM

Fri, Jun 8

mgallien added a comment to D13423: unmerge albums by using the paths of their tracks.

When I tried this the first time I got this error and the loading animation running constantly.

transaction failed QSqlError("", "Unable to begin transaction", "cannot start a transaction within a transaction") "Unable to begin transaction"

However, once I nuked the DB it loaded just fine and I can confirm this fixes the bug. Great work!

Fri, Jun 8, 1:40 PM
mgallien committed R255:f28ce37c718f: add missing export macro for operators in MusicAlbum and MusicAudioTrack (authored by mgallien).
add missing export macro for operators in MusicAlbum and MusicAudioTrack
Fri, Jun 8, 5:28 AM

Thu, Jun 7

mgallien moved T6293: Fix HeaderBar for missing animations from Backlog to Junior Jobs on the Elisa board.
Thu, Jun 7, 9:47 PM · Elisa
mgallien triaged T8953: Improve detection of different albums as High priority.
Thu, Jun 7, 9:44 PM · Elisa
mgallien added a task to D13423: unmerge albums by using the paths of their tracks: T8953: Improve detection of different albums.
Thu, Jun 7, 9:43 PM
mgallien added a revision to T8953: Improve detection of different albums: D13423: unmerge albums by using the paths of their tracks.
Thu, Jun 7, 9:43 PM · Elisa
mgallien requested review of D13423: unmerge albums by using the paths of their tracks.
Thu, Jun 7, 9:38 PM
mgallien committed R286:461f8ec81b81: check for needed version of libavcode, libavformat and libavutil (authored by mgallien).
check for needed version of libavcode, libavformat and libavutil
Thu, Jun 7, 3:29 PM
mgallien closed D13302: check for needed version of libavcode, libavformat and libavutil.
Thu, Jun 7, 3:29 PM · Baloo, Frameworks

Wed, Jun 6

mgallien updated subscribers of D12673: bump dependencies of Elisa to v5.45.0 for KDE frameworks and 5.10 for Qt.

@apol @jgrulich Should I just land this ?

Wed, Jun 6, 8:35 PM
mgallien requested changes to D12978: move mpris interface to c++.
Wed, Jun 6, 8:31 PM · Elisa
mgallien added a comment to D12978: move mpris interface to c++.

I am unsure about the added value of this diff. At least, you should fiwx the reported issues. I would really prefer not to add many #ifdef in the c++ code in favor of platform specific qml files.

Wed, Jun 6, 8:31 PM · Elisa
mgallien added a comment to D12992: New elisa icon.

@abetts Yes, I've been concepting a little on different ideas but not really coming anywhere I feel would fit in.

Looks great!

As for the background, when I think of soundwaves I think of something that would be produced by a visualizer, or a sine wave.

Did you make the letters yourself or is it a font? I'm asking just in case the font is licensed.

The letters are from a font from Google Fonts. We should be OK to use it. We can also modify a bit if you want. Although I feel it looks good.

Wed, Jun 6, 8:26 PM · Elisa, Frameworks
mgallien added a comment to D13216: Overhaul the file index scheduler..

Sounds good to me. I will try to do a proper review as soon as I can. Sorry for the delay.

Wed, Jun 6, 8:20 PM · Baloo, Frameworks
mgallien updated the diff for D13302: check for needed version of libavcode, libavformat and libavutil.
  • checks if FFmpeg provides the new API and use it only in this case
Wed, Jun 6, 8:18 PM · Baloo, Frameworks
mgallien updated the summary of D12584: implement interface of Baloo to watch renamed files.
Wed, Jun 6, 6:40 PM
mgallien abandoned D11167: [WIP] move all the real models into a thread distinct from the UI thread to not block.
Wed, Jun 6, 6:38 PM

Mon, Jun 4

mgallien created T8953: Improve detection of different albums.
Mon, Jun 4, 4:15 PM · Elisa
mgallien requested changes to D12975: Hide stars when there is no rating.
Mon, Jun 4, 3:51 PM · Elisa
mgallien added a comment to D12841: Align view buttons vertically.

Here's a new solution for alignment. It should stay in mostly the same place with different fonts, unless you are using some weird fantasy font with bad metrics.

Mon, Jun 4, 3:48 PM · Elisa
mgallien added a comment to D12841: Align view buttons vertically.

Here's a new solution for alignment. It should stay in mostly the same place with different fonts, unless you are using some weird fantasy font with bad metrics.

Mon, Jun 4, 3:47 PM · Elisa
mgallien added a revision to T8695: Ensure user visible paths are looking native and easy to read: D13337: makes path returned by TrackDataHelper looks local when they are local.
Mon, Jun 4, 3:30 PM · Elisa
mgallien added a task to D13337: makes path returned by TrackDataHelper looks local when they are local: T8695: Ensure user visible paths are looking native and easy to read.
Mon, Jun 4, 3:30 PM
mgallien requested review of D13337: makes path returned by TrackDataHelper looks local when they are local.
Mon, Jun 4, 3:30 PM
mgallien committed R255:c4f98d834d9b: Merge branch '0.2' (authored by mgallien).
Merge branch '0.2'
Mon, Jun 4, 5:54 AM
mgallien committed R255:772ebc6d94cd: fix windows Theme component (authored by mgallien).
fix windows Theme component
Mon, Jun 4, 5:54 AM
mgallien committed R255:59e32f46627a: fix windows Theme component (authored by mgallien).
fix windows Theme component
Mon, Jun 4, 5:54 AM
mgallien added a task to D13324: use new icons from Breeze to indicate pauses and playing status: T8330: Update the playing indicator with new icons from breeze-icons v5.45.
Mon, Jun 4, 5:53 AM
mgallien added a revision to T8330: Update the playing indicator with new icons from breeze-icons v5.45: D13324: use new icons from Breeze to indicate pauses and playing status.
Mon, Jun 4, 5:53 AM · Elisa
mgallien requested review of D13324: use new icons from Breeze to indicate pauses and playing status.
Mon, Jun 4, 5:52 AM
mgallien claimed T8330: Update the playing indicator with new icons from breeze-icons v5.45.
Mon, Jun 4, 5:24 AM · Elisa
mgallien claimed T8695: Ensure user visible paths are looking native and easy to read.
Mon, Jun 4, 5:23 AM · Elisa
mgallien moved T8330: Update the playing indicator with new icons from breeze-icons v5.45 from Backlog to In Progress on the Elisa board.
Mon, Jun 4, 5:23 AM · Elisa
mgallien moved T8695: Ensure user visible paths are looking native and easy to read from Backlog to In Progress on the Elisa board.
Mon, Jun 4, 5:23 AM · Elisa
mgallien raised the priority of T7883: year and genre browser from High to Needs Triage.
Mon, Jun 4, 5:22 AM · Elisa

Sun, Jun 3

mgallien committed R255:31abfe2bbcc8: export FileBrowserModel to allow to use it from other parts (authored by mgallien).
export FileBrowserModel to allow to use it from other parts
Sun, Jun 3, 9:23 PM
mgallien committed R255:8d57d991a3c3: include our own header first in cpp file (as suggested by ebn.kde.org) (authored by mgallien).
include our own header first in cpp file (as suggested by ebn.kde.org)
Sun, Jun 3, 9:23 PM
mgallien committed R255:15180fd61715: increase the delay we wait for some signals in autotests (authored by mgallien).
increase the delay we wait for some signals in autotests
Sun, Jun 3, 9:23 PM
mgallien committed R255:333966cf239e: remove duplicated #include (authored by mgallien).
remove duplicated #include
Sun, Jun 3, 9:23 PM
mgallien committed R255:144651f6899e: fix include guard in elisaqmlplugin.h (authored by mgallien).
fix include guard in elisaqmlplugin.h
Sun, Jun 3, 9:23 PM
mgallien updated the diff for D13302: check for needed version of libavcode, libavformat and libavutil.
  • prefer usage of CHECK_STRUCT_HAS_MEMBER instead of having test code
Sun, Jun 3, 2:00 PM · Baloo, Frameworks
mgallien updated the test plan for D13302: check for needed version of libavcode, libavformat and libavutil.
Sun, Jun 3, 1:53 PM · Baloo, Frameworks
mgallien updated the diff for D13302: check for needed version of libavcode, libavformat and libavutil.
  • check AVStrean structure have codecpar member
Sun, Jun 3, 1:52 PM · Baloo, Frameworks
mgallien added a comment to R286:3415015e3d45: check that ffmpeg is at least version 3.1 that introduce the API we require.

The FindFFmpeg CMake module uses pkg-config modversions to determine the overall version. These don't match the notion of "FFmpeg release 3.1" because the libraries are versioned separately. For instance:

libavdevice 58.3.100
libavfilter 7.16.100
libavformat 58.12.100
libavutil 56.14.100
libpostproc 55.1.100
libswresample 3.1.100
libavcodec 58.18.100
libswscale 5.1.100

So what you really need to do is check for ffmpeg components with version-numbering corresponding to the API / library version that introduces them -- and/or check for the specific API you need via CheckSymbolExists

Sun, Jun 3, 1:30 PM
mgallien requested review of D13302: check for needed version of libavcode, libavformat and libavutil.
Sun, Jun 3, 1:29 PM · Baloo, Frameworks
mgallien added a comment to R286:3415015e3d45: check that ffmpeg is at least version 3.1 that introduce the API we require.

On Neon (Xenial based) FFmpeg version is 2.8.14. It still doesn't fail on CMake. It maybe compares 3.1 with the version numbers of the FFmpeg modules. Their major versions are >50. Then it fails on build, because AVCodecParameters is not defined (fails since 037208a787e0).

Sun, Jun 3, 11:56 AM

Sat, Jun 2

mgallien added a comment to D12320: add ability to read embedded cover files.

as the remaining issues are formatting only, this is an accept by me save the requested changes.
@mgallien - if i am late to accept, can you do it?

Sat, Jun 2, 6:26 PM · Baloo, Frameworks
mgallien committed R255:f804fd7ceb80: fix display of the all genres view (authored by mgallien).
fix display of the all genres view
Sat, Jun 2, 3:22 PM
mgallien committed R255:0cd034c92cc5: Merge branch 'file_browser' (authored by mgallien).
Merge branch 'file_browser'
Sat, Jun 2, 3:22 PM
mgallien added a comment to D12975: Hide stars when there is no rating.

Here's a test for the "columns" idea.

Sat, Jun 2, 8:25 AM · Elisa

Fri, Jun 1

mgallien added a comment to T7883: year and genre browser.

Thanks for the feedback so far. I have fixed some problems. One of them was a wrong size of genre metadata in database. It requires to remove it and index your music again.

Fri, Jun 1, 4:48 PM · Elisa
mgallien committed R255:5ce76af12254: filter by genre the list of albums from an artist when in genre browsing (authored by mgallien).
filter by genre the list of albums from an artist when in genre browsing
Fri, Jun 1, 4:45 PM
mgallien committed R255:f1421e3885ba: add genre filtering or genre data to all models and proxy (authored by mgallien).
add genre filtering or genre data to all models and proxy
Fri, Jun 1, 4:44 PM