sharvey (Scott Harvey)
Irritable genius.

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 29 2018, 2:52 AM (11 w, 6 d)
Availability
Available

Chicago.

_sharvey_ on IRC.

Recent Activity

Today

sharvey updated the diff for D11926: [WIP] Add "SkipSwitcher" to API.
  • Correct incorrect skipSwitcher hidden flag usage
Sun, Apr 22, 5:21 PM · KWin
sharvey added inline comments to D11926: [WIP] Add "SkipSwitcher" to API.
Sun, Apr 22, 5:15 PM · KWin
sharvey updated the diff for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
  • Remove scale factor entirely; set minimum size
Sun, Apr 22, 2:56 PM · Plasma
sharvey added a project to T8569: Redesign Policy Kit Authorization dialog: Plasma.
Sun, Apr 22, 12:18 AM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

FYI: I undid the wonky manual UI sizing that @broulik objected to. In hindsight, not the best approach.

Sun, Apr 22, 12:17 AM · Plasma
sharvey added a comment to T8569: Redesign Policy Kit Authorization dialog.

What to keep? What to eliminate? What to change? What CAN be changed?

Sun, Apr 22, 12:16 AM · Plasma
sharvey created T8569: Redesign Policy Kit Authorization dialog.
Sun, Apr 22, 12:15 AM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

Okay, this patch is back to where we started, with nothing changed except centering the icon. Hopefully we can commit it now. I'll move the discussion over how to redesign the dialog itself to a separate task.

Sun, Apr 22, 12:03 AM · Plasma
sharvey updated the diff for D12311: Align lock icon with bold message text; reduce overall size of dialog.
  • Merge branch 'master' into align-lock-icon
  • Undo manual resizing of ser combo box & password error box
Sun, Apr 22, 12:01 AM · Plasma

Fri, Apr 20

sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

Hmm, I was actually leaning the other way. Ditch the generic boilerplate and keep the app-specific text. I think it's helpful when the dialog tells you why it appeared and what app/function is requesting your password.

Fri, Apr 20, 9:21 PM · Plasma
sharvey updated subscribers of D12311: Align lock icon with bold message text; reduce overall size of dialog.

Semi-related bug from @stikonas, while I'm on dialog duty: https://bugs.kde.org/show_bug.cgi?id=393355

Fri, Apr 20, 9:00 PM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

The small-text boilerplate is definitely on the chopping block. @ltoscano makes a fine case for keeping the Details section.

Fri, Apr 20, 8:47 PM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

Reviewers: as part of my task to redesign and tidy up this dialog box, I'm considering removing the Details button in the bottom left corner, along with the small pop-open panel that shows additional information. My argument is that the info in the Details panel is quite technical (PID's of calling process and polkit process) and - in some circumstances - lucid information about the program needing authorization. Most of the time, what's coming through is in raw form, such as com.canonical.ubuntu.synaptic (more or less) instead of Synaptic Package Manager.

Fri, Apr 20, 5:48 PM · Plasma

Thu, Apr 19

sharvey updated subscribers of D11926: [WIP] Add "SkipSwitcher" to API.
Thu, Apr 19, 9:45 PM · KWin
sharvey updated subscribers of D11925: [WIP] Add "SkipSwitcher" to API.
Thu, Apr 19, 9:44 PM · Frameworks
sharvey updated subscribers of D11924: Add "SkipSwitcher" to API.
Thu, Apr 19, 9:44 PM · Frameworks
sharvey updated subscribers of D12363: Fix autotest regression after adding SkipSwitcher to API.
Thu, Apr 19, 9:44 PM · Frameworks
sharvey added a reviewer for D11926: [WIP] Add "SkipSwitcher" to API: graesslin.
Thu, Apr 19, 9:41 PM · KWin
sharvey added a comment to D11926: [WIP] Add "SkipSwitcher" to API.

Polite "bump" for my reviewers. Please see D12363 - the Kubuntu team has had to manually disable some autotests stemming from D11924.

Thu, Apr 19, 9:41 PM · KWin
sharvey added a comment to D11925: [WIP] Add "SkipSwitcher" to API.

Polite "bump" for my reviewers. Please see D12363 - the Kubuntu team has had to manually disable some autotests stemming from D11924.

Thu, Apr 19, 9:40 PM · Frameworks
sharvey added a comment to D12363: Fix autotest regression after adding SkipSwitcher to API.

Also, related patches D11925 and D11926 are still open and uncommitted. I'm unclear if those missing pieces are affecting the autotests.

Thu, Apr 19, 8:15 PM · Frameworks
sharvey added a comment to D12363: Fix autotest regression after adding SkipSwitcher to API.

I'm afraid to admit I don't understand it all that well myself. This is my first submission to KWindowSystem. It was supposed to be a straightforward case of "implement skipSwitcher just like skipTaskbar is implemented". I believe I noted the problems with the autotests in my original submission.

Thu, Apr 19, 8:09 PM · Frameworks
sharvey added a comment to D12321: Hide file preview when icon is too small.

(effective screencast)

Thu, Apr 19, 11:45 AM · Frameworks
sharvey added a comment to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.


This is what D. Faure's suggestion results in. I'd say it's of marginal value, but again, it's all we have to work with.

Thu, Apr 19, 12:02 AM

Wed, Apr 18

sharvey added a comment to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.

I searched and searched; read the API docs until my eyes ached. The first step (code-wise) in creating an action is adding an action-id to the ActionCollection. The next steps are adding a label, a shortcut key, and/or an icon.

Wed, Apr 18, 11:46 PM
sharvey added a comment to T8552: Polish Open/Save dialogs.
In T8552#138901, @rkflx wrote:

I'd suggest to not get distracted with any icon issues for the file dialog, as the icon topic also affects Dolphin and spans many more aspects, which don't fit here very well, e.g. consistency, HiDPI etc.

Wed, Apr 18, 11:34 PM · VDG
sharvey added a comment to D12077: Show view mode buttons in the open/save dialog's toolbar.

+1 for making things easier and prettier.

Wed, Apr 18, 11:28 PM · Frameworks
sharvey added a comment to T8552: Polish Open/Save dialogs.

While you're compiling an impressive to-do list, would you consider adding "Full-color (Breeze) icons at 16x16 size"? I think the monochrome line-art icons are awful, with all due respect to the VDG. I know it was done for readability and clarity, but they look primitive and overly technical. I might even fire up Inkscape and try my hand at creating a few.

Wed, Apr 18, 11:25 PM · VDG
sharvey added a comment to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.

I'd try to not add the second action to the actionCollection()

Wed, Apr 18, 10:47 PM
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

The bad news is that, due to the minimumSize we configured for System Settings, I can't get back to the bottom of the Display KCM to reset my screen scale. Had to set QT_SCALE_FACTOR=0.5 and launch systemsettings5 directly. Never a dull moment!

Wed, Apr 18, 9:22 PM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

I tried different fonts up to 15pt and all is okay. I even tried the nasty Windows-style widgets and it's still okay.

Wed, Apr 18, 8:59 PM · Plasma
sharvey updated the summary of D12311: Align lock icon with bold message text; reduce overall size of dialog.
Wed, Apr 18, 6:17 PM · Plasma
sharvey updated the diff for D12311: Align lock icon with bold message text; reduce overall size of dialog.
  • Correct initial Y placement for errorMessageWidget
Wed, Apr 18, 6:14 PM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

Here's the latest from the Pixel Conservation Society. I can't manage wholesale space-savings without breaking up the existing gridLayout and basically starting from scratch. It does resize a bit and does no harm.

Wed, Apr 18, 6:12 PM · Plasma
sharvey updated the diff for D12311: Align lock icon with bold message text; reduce overall size of dialog.
  • Reduce height of dialog by shrinking UI elements when not needed

Password error alert and user-choice combo box are reduced to 1px high when not needed, then restored to their original geometry when activated.

Wed, Apr 18, 5:57 PM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.
Wed, Apr 18, 5:55 PM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

Better already! Do we even need to reserve that space? Many other such dialogs dynamically allocate it when necessary by increasing the height of the box. Is that not possible here?

Wed, Apr 18, 4:07 PM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

Some of the white space is reserved for otherwise-invisible error messages (like an invalid password).

Wed, Apr 18, 3:08 PM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

I just realized I inadvertently shrank the spacing between the bold headline and the non-bold explanation text. There's a lot of white space in this dialog. Let me know if you want something adjusted...

Wed, Apr 18, 2:43 PM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

Before


After

Wed, Apr 18, 2:40 PM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

Probably fine, but can you attach a screenshot

Wed, Apr 18, 2:38 PM · Plasma
sharvey added reviewers for D12311: Align lock icon with bold message text; reduce overall size of dialog: davidedmundson, ngraham.
Wed, Apr 18, 2:37 PM · Plasma
sharvey requested review of D12311: Align lock icon with bold message text; reduce overall size of dialog.
Wed, Apr 18, 2:36 PM · Plasma

Tue, Apr 17

sharvey added inline comments to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Tue, Apr 17, 10:13 PM · Plasma
sharvey added a comment to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..

OMG, for whatever reason, I was assuming this is about the file dialog window size. You are working on too many things at once, Nathan :)

Tue, Apr 17, 10:08 PM · Plasma
sharvey updated the test plan for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Tue, Apr 17, 10:33 AM · Plasma
sharvey updated the test plan for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Tue, Apr 17, 10:25 AM · Plasma
sharvey updated the diff for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
  • Add checking & sizing calc for smaller or rotated screens

availableSize() returns size minus any size reserved by the window manager for taskbars, etc. Multiply by 0.9 to prevent systemsettings from going "full screen" and overlapping all other windows.

Tue, Apr 17, 10:21 AM · Plasma
sharvey updated the diff for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
  • Add const, revise scale factoring for Qt rounding
Tue, Apr 17, 12:49 AM · Plasma

Mon, Apr 16

sharvey updated the diff for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
  • Revert back to 700 for Y scale
Mon, Apr 16, 11:19 PM · Plasma
sharvey added a comment to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..

Heh, that wasn't a request targeted at you, but rather a question for others. :)

Mon, Apr 16, 10:54 PM · Plasma
sharvey added a comment to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..

Ah, so it is! Any objections to increasing the effective minimum size to 1024x768? It seems that this is the size that the KCMs were actually designed for, so it makes sense to me as a sensible default, but let's collect some more opinions first.

Mon, Apr 16, 10:47 PM · Plasma
sharvey updated the diff for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
  • Tweak size to 1024x768
Mon, Apr 16, 10:46 PM · Plasma
sharvey updated the test plan for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Mon, Apr 16, 10:37 PM · Plasma
sharvey added a comment to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..

All of this is already implemented and works as expected if you simply remove the resize() call. What needs to be done is to specify the default size without always calling resize(). Either that, or enforce 1024x700 as the minimum.

Mon, Apr 16, 10:35 PM · Plasma
sharvey added a comment to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..

Once that's fixed, there's still one more issue here: always calling resize() this means that once the user resizes the window, that custom size will be overridden on the next launch. We want to set a better default size, not enforce a mandatory size. I wonder if we should just remove the resize() call and change setMinimumSize() to enforce 1024x700? Most KCMs look pretty bad at smaller sizes anyway.

Mon, Apr 16, 10:23 PM · Plasma
sharvey updated the diff for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
  • Remove qBound and division by 96 for pixel ratio
Mon, Apr 16, 10:15 PM · Plasma
sharvey updated the diff for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
  • Use devicePixelRatio for base size instead of physicalDotsPerInch
Mon, Apr 16, 9:58 PM · Plasma
sharvey updated the diff for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
  • Adjust Y scale to 700
Mon, Apr 16, 7:34 PM · Plasma
sharvey added a comment to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..

Hmm, that's not the behavior I see at all. For me, factor appears to be 1 with not running a HiDPi scale factor, so I get an actual size that's essentially equal to the number it's multiplied by. (e.g. return QSize(1024*factor, 700*factor) yields window content that's actually 1024x700 ). If I run with QT_SCALE_FACTOR=1.3 systemsettings5, everything is scaled perfectly. Do you have some wonky DPI settings on your test box or something?

Mon, Apr 16, 7:30 PM · Plasma
sharvey added a comment to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..

Much better! I think I'd still prefer 700 for the height, since at 600, the following KCMs have vertical scrollbars, but lose them at 700:

Mon, Apr 16, 6:07 PM · Plasma
sharvey added a comment to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
In D12252#247508, @zzag wrote:

What if sizeHint() returns a size which is bigger than screen size? Please use QSize::boundedTo.

Mon, Apr 16, 5:45 PM · Plasma
sharvey updated the summary of D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Mon, Apr 16, 5:43 PM · Plasma
sharvey updated the summary of D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Mon, Apr 16, 5:43 PM · Plasma
sharvey updated the test plan for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Mon, Apr 16, 5:42 PM · Plasma
sharvey added inline comments to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Mon, Apr 16, 5:39 PM · Plasma
sharvey updated the diff for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
  • Adjust calculation; re-add minimumSize() property
Mon, Apr 16, 5:38 PM · Plasma
sharvey updated the diff for D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
  • Uncomment line left from testing
Mon, Apr 16, 5:01 PM · Plasma
sharvey added a comment to D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..

The calculation is aiming for a minimum width of 1200px, which seems to be the minimum size needed to display both sidebars. Since the original calculation uses physicalDotsPerInch, I'm only able to use my own laptop as a test subject. It's a 15" 1920x1080 screen. Checking physicalDotsPerInch gives me a value of ~1.47. That's how I derived the value of 815 to multiply by. The qBound function should keep the size to something reasonable, regardless of the screen size.

Mon, Apr 16, 5:00 PM · Plasma
sharvey requested review of D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width..
Mon, Apr 16, 4:51 PM · Plasma

Thu, Apr 12

sharvey added a comment to D11993: Tweak column widths in tree view of file open/save dialogs.

Merge errors tracked down and eradicated.

Thu, Apr 12, 7:36 PM · Frameworks
sharvey updated the diff for D11993: Tweak column widths in tree view of file open/save dialogs.
  • Repairing merge error
Thu, Apr 12, 7:35 PM · Frameworks
sharvey abandoned D12160: Rebase onto fresh master.

Created by mistake.

Thu, Apr 12, 7:19 PM · Frameworks
sharvey added a comment to D12160: Rebase onto fresh master.

Oops, did you mean to create a new revision? Let's just focus on the existing one.

Thu, Apr 12, 7:17 PM · Frameworks
sharvey requested review of D12160: Rebase onto fresh master.
Thu, Apr 12, 7:16 PM · Frameworks
sharvey added a comment to D11993: Tweak column widths in tree view of file open/save dialogs.

Rebased (I think). Had to manually resolve a conflict. Hopefully it'll land now.

Thu, Apr 12, 6:38 PM · Frameworks
sharvey updated the diff for D11993: Tweak column widths in tree view of file open/save dialogs.
  • Remove unneeded resize code; ensure other columns fill to contents
  • Remove leftover commented-out code; restore variable declaration
Thu, Apr 12, 6:37 PM · Frameworks

Wed, Apr 11

sharvey added a comment to T7116: Streamlined onboarding of new contributors.

Under the subheading of "Documentation", can we discuss code commenting? And ideally - encourage it? The API docs are good and generally well-maintained, but inside the applications themselves, the quantity and quality of code comments varies quite a bit. Some of our products are quite large and use many of the Frameworks together. It can be daunting at times to decipher how a block of code works and why it was constructed in the way it was.

Wed, Apr 11, 10:38 PM · Goal settings 2017
sharvey updated subscribers of T8484: Making settting up a development environment quick and easy.

I finally had an "ah-hah!" moment a few weeks ago (thanks to the patience of @hein) when I finally got my development setup properly configured. Eike's gentle but direct question of "didn't we cover this on your last patch?" made me sit back down and follow all the documented steps one by one. With the addition of the right environment variables, I can now download and compile virtually any source module I need.

Wed, Apr 11, 10:10 PM
sharvey added a comment to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.

I'm going to need some time to keep digging into this. I understand what is being requested; I have to see how to make it work within the existing menu/toolbar framework.

Wed, Apr 11, 7:35 PM
sharvey updated the diff for D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.
  • Update version of KPartGUI XML file; misc code formatting fixes
Wed, Apr 11, 5:32 PM
sharvey added a comment to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.

In fact, why do we need two of these to implement the feature?

Wed, Apr 11, 2:17 AM

Tue, Apr 10

sharvey added a comment to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.

Is there a way you can not rename edit_find?

Tue, Apr 10, 11:37 PM
sharvey updated the diff for D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.
  • Correct signature of signal sendSearchState() (returns void, not bool)
Tue, Apr 10, 11:07 PM
sharvey updated the test plan for D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.
Tue, Apr 10, 9:01 PM
sharvey updated the diff for D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.
  • Separate key shortcut & toolbar button into slightly different operations

CTRL+F once more sets search mode & focuses search bar, but only the toolbar button will toggle search mode on or off

Tue, Apr 10, 8:54 PM
sharvey added a comment to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.

However, Ctrl+F to focus the Find bar now does not work anymore, it closes the bar instead while it shouldn't (see D10246 for discussion).

Tue, Apr 10, 5:52 PM
sharvey added a comment to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.

In order to keep the issues separate (for now), I intentionally did not address the work begun in D10246 or tracked at https://git.reviewboard.kde.org/r/127054/

Tue, Apr 10, 5:21 PM
sharvey updated the summary of D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.
Tue, Apr 10, 5:17 PM
sharvey added a task to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views: T8473: Dolphin 'Find' button behavior.
Tue, Apr 10, 5:15 PM
sharvey added a revision to T8473: Dolphin 'Find' button behavior: D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.
Tue, Apr 10, 5:15 PM · Dolphin
sharvey added reviewers for D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views: ngraham, elvisangelaccio, Dolphin.
Tue, Apr 10, 5:14 PM
sharvey requested review of D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.
Tue, Apr 10, 5:13 PM
sharvey added a comment to D12034: Use the more appropriate "two sliders" icon for "configure".

Since I may or may not have been the one to bring this to @ngraham's attention, I'll offer my two cents and be done.

Tue, Apr 10, 5:31 AM · Frameworks

Mon, Apr 9

sharvey added a comment to T8473: Dolphin 'Find' button behavior.

Will do. I'll keep working on it. I thought it might be something worthy of discussion before submitting a [WIP] patch.

Mon, Apr 9, 8:05 PM · Dolphin
sharvey added a comment to T8473: Dolphin 'Find' button behavior.

The patch is only a few lines (a KToggleAction and a new slot), but I figured it was just as easy to show the situation than expect everyone to bother patching and recompiling something that's up for discussion.

Mon, Apr 9, 7:53 PM · Dolphin
sharvey created T8473: Dolphin 'Find' button behavior.
Mon, Apr 9, 7:51 PM · Dolphin

Sun, Apr 8

sharvey updated subscribers of D12036: Change "different user" icon on login screen.

PS: Credit to @sebas for making Cuttlefish!

Sun, Apr 8, 4:26 PM · Plasma
sharvey added a comment to D12036: Change "different user" icon on login screen.
In the Login screen, it lets you **//find//** other users not listed there to log in as.
Sun, Apr 8, 4:16 PM · Plasma
sharvey added a reviewer for D12036: Change "different user" icon on login screen: VDG.
Sun, Apr 8, 12:44 AM · Plasma