sharvey (Scott Harvey)
Developer

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jan 29 2018, 2:52 AM (28 w, 5 d)
Availability
Available

Chicago.

_sharvey_ on IRC.

Recent Activity

Tue, Jul 31

sharvey added a comment to D14520: Open `skipPager` functionality.

Hopefully .arclint is gone for good this time.

Tue, Jul 31, 8:15 PM · Frameworks
sharvey updated the diff for D14520: Open `skipPager` functionality.
  • Whitespace fix & remove .arclint
Tue, Jul 31, 8:13 PM · Frameworks
sharvey added a comment to D14520: Open `skipPager` functionality.

Okay, a clean copy. Apologies for the mess. I can do the coding, but the infrastructure is another story...

Tue, Jul 31, 5:14 PM · Frameworks
sharvey updated the diff for D14520: Open `skipPager` functionality.
  • Remove wrongly committed files
Tue, Jul 31, 5:13 PM · Frameworks
sharvey requested review of D14520: Open `skipPager` functionality.
Tue, Jul 31, 5:09 PM · Frameworks
sharvey abandoned D14516: Open `skipPager` functionality.
Tue, Jul 31, 4:42 PM · Frameworks
sharvey added a comment to D14516: Open `skipPager` functionality.

There's no functionality to remove files. I'll submit a new diff.

Tue, Jul 31, 4:41 PM · Frameworks
sharvey updated the diff for D14516: Open `skipPager` functionality.

Remove untracked .arclint and CMakeLists.txt.user

Tue, Jul 31, 4:39 PM · Frameworks
sharvey added a comment to D14516: Open `skipPager` functionality.

Changes to .arclint look unintended, and I'm not sure you meant to check in CMakeLists.txt.user.

Tue, Jul 31, 4:31 PM · Frameworks
sharvey added a comment to D14516: Open `skipPager` functionality.

Plasma team: Please help me review and fix the failing autotests. I'm not familiar enough with the internals of KWayland - or autotests - to successfully debug what's happening. The patch builds and compiles without error.

Tue, Jul 31, 4:27 PM · Frameworks
sharvey added a reviewer for D14516: Open `skipPager` functionality: Plasma on Wayland.
Tue, Jul 31, 4:25 PM · Frameworks
sharvey requested review of D14516: Open `skipPager` functionality.
Tue, Jul 31, 4:23 PM · Frameworks

Wed, Jul 25

sharvey added a comment to T9271: Attracting and Onboarding contributors from downstream distributions.

I think this has to be considered an "advanced" topic. We've first got to get the new people submitting patches and having them accepted. I've been banging away at patches and bugfixes for the past 8 months and have never even investigated how to package something for distribution. I'm working on a personal project that I'll want to distribute, but I've got plenty of coding before I get there.

Wed, Jul 25, 2:26 PM · Goal settings 2017
sharvey committed R166:9c07cae31955: Merge branch 'master' of git://anongit.kde.org/spectacle (authored by sharvey).
Merge branch 'master' of git://anongit.kde.org/spectacle
Wed, Jul 25, 12:26 PM
sharvey committed R166:f96a1af43771: Merge remote-tracking branch 'origin/Applications/18.08' (authored by sharvey).
Merge remote-tracking branch 'origin/Applications/18.08'
Wed, Jul 25, 12:26 PM
sharvey committed R166:f484ee979bed: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle (authored by sharvey).
Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle
Wed, Jul 25, 12:18 PM
sharvey closed D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.
Wed, Jul 25, 12:18 PM
sharvey added a comment to D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.

Thanks, can confirm that the issue with doubled resizing is fixed. Accepting for now, even though the code is not the most concise yet.

Please commit to the stable branch.

Wed, Jul 25, 12:15 PM
sharvey added a comment to D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.

a more general tip, it should be easier to branch off of the stable branch (Applications/18.08) if you are submitting a bugfix, like so:

git checkout Applications/18.08
git pull
arc feature fix-stuck-edges

Currently your patch is branched from master, which makes landing to stable more difficult, as it requires extra steps for rebasing and specifying the target branch.

Wed, Jul 25, 2:46 AM
sharvey added a comment to D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.

@rkflx - I fixed the double-size movement for Alt + (and Alt + + as well).

Wed, Jul 25, 2:37 AM
sharvey updated the diff for D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.
  • Fix doubled movement for Alt-Up and Alt-Shift-Up
Wed, Jul 25, 2:29 AM

Tue, Jul 24

sharvey added inline comments to D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.
Tue, Jul 24, 6:29 PM

Mon, Jul 23

sharvey added a comment to D12498: Fully remove `Application Name` from Details panel.

As soon as D12311: Align lock icon with bold message text; reduce overall size of dialog is landed, I'll change this string.

Mon, Jul 23, 10:48 PM · Plasma
sharvey added a comment to D12498: Fully remove `Application Name` from Details panel.

I'm still in favor of the brief but descriptive "Not Provided". This is an advanced developer field. I could add a tooltip with some additional information. My point is to convey the fact that "the vendor is supposed to provide this information, but did not."

Mon, Jul 23, 3:37 PM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

I believe it's done.

Mon, Jul 23, 2:26 PM · Plasma

Fri, Jul 20

sharvey added a comment to D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.

Here you go - a freshly rewritten arrow/rectangle handler. It's still got a fair bit of repetition, which I'd like to work on at some point. This version does not get "stuck" at the screen edges. It also stops resizing the rectangle to a minimum of 20x20px, the same as the initial mouse click to start the rectangle.

Fri, Jul 20, 5:39 PM
sharvey added inline comments to D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.
Fri, Jul 20, 5:34 PM
sharvey retitled D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle from Rework rectamgle/arrpw key handling to avoid "stuck edges" and 0x0px rectangle to Rework rectamgle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.
Fri, Jul 20, 5:31 PM
sharvey added reviewers for D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle: rkflx, ngraham, Spectacle.
Fri, Jul 20, 5:31 PM
sharvey requested review of D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.
Fri, Jul 20, 5:29 PM

Jul 19 2018

sharvey added a comment to T9243: Help the KDE PIM team with content for the new Kontact website.

First draft looks great! I like how bold the names of the apps appear on the slides. Really jumps out and looks like "confidence".

Jul 19 2018, 8:34 PM · KDE Promo
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

It seems you forgot to merge stable into master, which I now have done with

Jul 19 2018, 11:10 AM · Documentation
sharvey committed R166:48eacd1ba149: Add arrow keys to move and resize selection rectangle (authored by sharvey).
Add arrow keys to move and resize selection rectangle
Jul 19 2018, 10:38 AM
sharvey closed D13450: Add arrow keys to move and resize selection rectangle.
Jul 19 2018, 10:38 AM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Thanks, looking much better now.

Please make sure to commit to the stable branch, i.e. Applications/18.08 (let me know if you are unsure what that means).

Jul 19 2018, 10:36 AM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Minor whitespace cleanup
Jul 19 2018, 10:33 AM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Fix Alt + Down; Undo layout changes for help text; Reorder help text items
Jul 19 2018, 10:24 AM · Documentation

Jul 18 2018

sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Tagging is on Thursday at 23:59 UTC. I will accept the patch tomorrow so you can still land it in time (let me know if you are busy and I should commit on your behalf).

Jul 18 2018, 11:46 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Yeah, the magnifier shows up while dragging the selection rect (or not, depending on whether or not you've holding down ), but it currently doesn't show up when you're using Alt to resize the rect using the keyboard arrow keys.

IMHO, if you have the magnifier turned on in the settings, it should show up when you're in "fine tune" mode (holding down both and Alt and using the arrow keys to resize the rect by single pixels), because conceptually, if you're doing this, it's because you want a pixel-perfect rect.

Jul 18 2018, 3:12 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I still disagree regarding the default speed selection. We determined by looking at other apps that is the modifier to use, and I argued (in line with what I meant when triaging the bug) that for making the rectangle feature useful for keyboard users by default the movement should be fast. BTW, this is also what KWin is doing, and I see no reason at all why Spectacle should deviate from that standard. (See above for even more arguments.) I don't feel comfortable approving the current default, sorry.

Jul 18 2018, 2:21 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I'm noticing that the magnifier doesn't er show up while you're using the keyboard to resize the selection rect. Might wanna hook that up.

Jul 18 2018, 2:11 PM · Documentation
sharvey updated the test plan for D13450: Add arrow keys to move and resize selection rectangle.
Jul 18 2018, 2:01 PM · Documentation
sharvey added inline comments to D13450: Add arrow keys to move and resize selection rectangle.
Jul 18 2018, 1:59 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Change default adjustment to largeChange, uses smallChange for fine tuning
  • Numerous miscellaneous changes per reviewer comments, including:
    • Condensed adjustment calculations to use +=
    • Reverted help text box to match original layout
    • Revised docbook entry for clarity and consistency
Jul 18 2018, 1:56 PM · Documentation
sharvey added inline comments to D13450: Add arrow keys to move and resize selection rectangle.
Jul 18 2018, 12:57 PM · Documentation
sharvey added inline comments to D13450: Add arrow keys to move and resize selection rectangle.
Jul 18 2018, 12:33 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.
  • Selecting with the mouse sets a minimum size, however resizing with the arrow keys allows to resize to 0x0px.
Jul 18 2018, 12:40 AM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I will attempt to get these completed early tomorrow morning (my time). It's already the end of the day here and I know (from unfortunate experience) that I don't do my best work "after hours".

Jul 18 2018, 12:36 AM · Documentation

Jul 17 2018

sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Grammar consistency in docbook fixed
Jul 17 2018, 3:52 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

About the date: that's not the release date, but the date where the document was last updated.

Jul 17 2018, 3:47 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Correct revision date in docbook
Jul 17 2018, 3:46 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

There's only one remaining thing to do from my perspective: update the docbook to document this nice new feature! It would be great if you could do that in this patch. Keep in mind that 18.08 has already been branched and the freeze is in two days, so if you'd like to get this in for the next release, you'll have to work quickly. :)

Jul 17 2018, 3:41 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Edit docbook to include arrow key usage; update release number and date
Jul 17 2018, 3:34 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • String tweaks / Make smallChange and largeChange both "positive" for consistency
Jul 17 2018, 11:29 AM · Documentation

Jul 16 2018

sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I apologize for the delay in getting this finalized. It's been a tumultuous month in real life. Including emergency heart surgery for my father, a flare-up of my own illnesses (I'm on disability), and finally - a kernel upgrade that somehow failed, rendering my machine unbootable. Lots of reinstalling and reconfiguring.

Jul 16 2018, 8:02 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Change movement sizes to handle HiDPI screens
Jul 16 2018, 7:58 PM · Documentation

Jun 27 2018

sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Also, looks like the current policy for HiDPI is to "scale up" the moves, so if I set QT_SCALE_FACTOR=5, the smallest move is 5 real pixels. We probably want to change that, so that we move by factor / Screen.devicePixelRatio which would ensure we move by factor "real" pixels. Apart from that, 15px seems pretty good on my 2560x1440 monitor.

Jun 27 2018, 1:28 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Whitespace cleanup; remove unused variables
Jun 27 2018, 12:21 AM · Documentation

Jun 26 2018

sharvey added inline comments to D13450: Add arrow keys to move and resize selection rectangle.
Jun 26 2018, 9:37 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Why not make it a user configurable option?

Jun 26 2018, 9:05 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I probably need to do a little whitespace & indenting cleanup. I'll hold off until everyone's satisfied with the behavior. Just want you to know I'm aware of it.

Jun 26 2018, 8:58 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Hm, my intention when I triaged the bug was indeed to make it possible to set the selection rectangle from the keyboard. When I mentioned the separate patch, this was only about how to start the actual selection process. I don't think it makes sense to change the speed later again, we should get it right here.

Jun 26 2018, 8:55 PM · Documentation
sharvey removed a watcher for Plasma: Mobile: sharvey.
Jun 26 2018, 8:41 PM
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

@abalaji: I have to respectfully disagree with the idea of multi-directional movement. My intent behind this patch remains geared toward incremental adjustments to the original mouse-drawn rectangle, not a full-blown replacement for drawing a rectangle entirely from the keyboard and having to make dramatic changes.

Jun 26 2018, 8:33 PM · Documentation
sharvey updated the summary of D13450: Add arrow keys to move and resize selection rectangle.
Jun 26 2018, 12:10 PM · Documentation
sharvey updated the test plan for D13450: Add arrow keys to move and resize selection rectangle.
Jun 26 2018, 12:08 PM · Documentation
sharvey updated the test plan for D13450: Add arrow keys to move and resize selection rectangle.
Jun 26 2018, 12:06 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Okay, I've finally gotten a working, reusable, reasonably sensible function for keeping the rectangle constrained inside the screen.

Jun 26 2018, 12:05 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Revise modifier keys / Add boundary-checking function
Jun 26 2018, 12:04 PM · Documentation

Jun 25 2018

sharvey added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.
In D13415#282884, @hein wrote:

Can you have a look at the code in kdeclarative, specifically src/qmlcontrols/kcoreaddons/kuserproxy.cpp - that's where the KDirWatch monitoring the face.icon file is. I think you need to place some qDebug() there to see if the file change gets picked up on your system and the signal emitted. If this is working, then we know the problem has to be in the QML side.

Jun 25 2018, 7:45 PM · Plasma
sharvey added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.
In D13415#282860, @hein wrote:

Can you elaborate what you tried and what you wanted to happen and what didn't happen? I'm a bit confused now @ touch.

Jun 25 2018, 7:38 PM · Plasma
sharvey added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.

Trying to use touch made no difference. I called it manually between changes, and actually added it (temporarily) to the actual Kickoff code, so it "touched" every time Kickoff was opened. No change.

Jun 25 2018, 6:56 PM · Plasma

Jun 23 2018

sharvey added a comment to D13699: Fix Ctrl+Alt+T shortcut to open Konsole.

+1 from me as well. I knew this shortcut from, ahem, other desktops. I thought it was something KDE simply didn't do. Nice fix.

Jun 23 2018, 6:12 PM · Plasma

Jun 21 2018

sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

@rkflx : A question about coding style and/or reviewer (you) preferences... do we object to the use of temporary local variables inside Javascript functions? I'm working on keeping the rectangle inside the screen. I've set up var screenWidth = cropDisplayCanvas.width at the top of my function. It's just for ease of use and readability... I can do tests and checks against screenWidth instead of writing long if tests with cropDisplayCanvas.width ... just to keep the lines of code a bit shorter and easier to read through.

Jun 21 2018, 3:30 PM · Documentation

Jun 20 2018

sharvey added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.

Perhaps I can go into the UserManager KCM, let it change the avatar like always, then run a brief timer (250ms?), and then ‘touch’ the face file so the KDirWatch runs a second time.

Jun 20 2018, 9:41 PM · Plasma
sharvey added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.

@hein : Thanks for the time spent investigating. The User Manager KCM appears to write out proper (non-corrupt) files, at least in my testing. I know there's a KDirWatch in one of the included Frameworks (KCoreAddons, I think), but that seems to work properly. It does indeed copy the file to the other places where it belongs. I'm still at a loss as to why it goes blank, but works when plasmashell is restarted. So Kickoff is picking up on the fact that there's been a change, but the operation doesn't complete.

Jun 20 2018, 8:06 PM · Plasma
sharvey added a comment to D12498: Fully remove `Application Name` from Details panel.

I'll get back to work on this. I've got a current open patch I need to finish up first, then I'll resume work on this. Should be a couple days at most.

Jun 20 2018, 6:25 PM · Plasma
sharvey added a comment to T8569: Redesign Policy Kit Authorization dialog.

Hmm, I think maybe I confused you, @sharvey. I was referring to this project, and I was wondering why you seemed to have abandoned it! ;-)

Jun 20 2018, 3:05 PM · Plasma
sharvey added a comment to T8569: Redesign Policy Kit Authorization dialog.

@abetts - Nate has told me that there's a project in the works to redesign and standardize the entire collection of dialog boxes.

Jun 20 2018, 2:39 PM · Plasma

Jun 19 2018

sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Unmodified arrow keys: move/resize by single pixel
Arrow keys with shift held down: move/resize by large increment

Jun 19 2018, 11:14 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Okay then. will slow the movement/resizing down to 1px. Will probably use CTRL for mode switching.

Jun 19 2018, 10:14 PM · Documentation
sharvey added a comment to T9042: Kickoff improvements.

As an FYI... the way Kicker/Kickoff/Dashboard are coded is very clever. The individual icon entries are all created from the same code. Eike is very good at writing reusable code. The different launchers just sort and display them in different layouts. So if we add a "new" badge (an idea to which I give a +1), I believe it will show up in all the launchers. I don't see that as a bad thing, however.

Jun 19 2018, 7:39 PM · Plasma, VDG
sharvey added a comment to T9042: Kickoff improvements.

I'll pitch in if I can. I've spent enough time in the Kickoff code trying to make circular avatars... argh.

Jun 19 2018, 7:26 PM · Plasma, VDG
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Okay, so my short-term to-do list for this is:

  • move "large" by default (15 or 20 px, whichever feels: more comfortable)
  • Use + Arrows to move in single-pixel precision style
    • What modifider key do we want for resizing instead of moving? CTRL or ALT?
  • Write a boundary-checking function so the rectangle can't go past the screen edges
Jun 19 2018, 5:13 PM · Documentation

Jun 18 2018

sharvey added a comment to D13095: Scren brightness follow a quatratic progression.

A couple of random ideas:

Jun 18 2018, 9:20 PM · Plasma
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Strike everywhere I mentioned the new QML rectangle. The existing rectangle is QML. As I said, I'm a bit foggy at the moment.

Jun 18 2018, 8:14 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Although I haven't tested it, that patch sounds like it operates more quickly. If that's the case, it might make sense for me to hold off on this and refactor it based on the new & improved rectangle.

Jun 18 2018, 8:11 PM · Documentation

Jun 14 2018

sharvey added a comment to D13095: Scren brightness follow a quatratic progression.

It seems I have some system rebuilding to do first. I'm not up for tackling it tonight. I'll work on it in the morning and try to get you some more data.

Jun 14 2018, 12:26 AM · Plasma

Jun 13 2018

sharvey added a comment to D13095: Scren brightness follow a quatratic progression.

Hi Scott, thanks for the help!
If you can apply the patch, we could see if you have the same behavior than Nate with his hardware: when setting a very low value (for him, it's in the range 1 to 5) to /sys/class/backlight/<hardware>/brightness his screen does not turn on at all. I would like to know if /sys/class/backlight/<hardware>/actual_brightness is then saying something different than /sys/class/backlight/<your hardware>/brightness.
On my computer the backlight goes on as soon as I put 1 to /sys/class/backlight/<hardware>/brightness, so I cannot reproduce this.
I hope I'm clear enough :)

Jun 13 2018, 9:45 PM · Plasma
sharvey added a comment to D13095: Scren brightness follow a quatratic progression.

Hope you don't mind me jumping in - I'm another one of Nate's protegees... here's some data for you. These values are before your patch. Let me know if you'd like me to apply your patch and redo the testing.

Jun 13 2018, 8:12 PM · Plasma

Jun 11 2018

sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Whitespace cleanup
Jun 11 2018, 11:26 AM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.
  • Split bottom help text into two columns
Jun 11 2018, 11:24 AM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Split bottom help text into two columns
Jun 11 2018, 11:23 AM · Documentation

Jun 10 2018

sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Great! That's taken care of the string and technical issues I spotted. Now that I play around with it, I notice that the explanatory text box on the bottom is getting pretty tall. I wonder if it might make sense to instead add a second column (i.e. a second GridLayout next to the original one) for these new lines. That way, compared to the status quo, it would grow horizontally instead of vertically. This might also impose a pleasing separation, since one column would be exclusively about the move/resize actions, so they wouldn't get lost in the middle.

What do you think?

Jun 10 2018, 11:58 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Properly format i18n strings
Jun 10 2018, 11:44 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

The proper way to do this like so:i18n("Move selection rectangle %1 pixels", largeChange)

Jun 10 2018, 11:40 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

largeChange value plugged in for help text. Reformatted strings in normal case, not Title Case.

Jun 10 2018, 11:31 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • More string revisions; use largeChange value in bottom help box
Jun 10 2018, 11:28 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Very cool! Works nicely for me. I've got a few string change suggestions below:

Jun 10 2018, 11:22 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • String revisions
Jun 10 2018, 11:19 PM · Documentation