sharvey (Scott Harvey)
Developer

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jan 29 2018, 2:52 AM (20 w, 1 d)
Availability
Available

Chicago.

_sharvey_ on IRC.

Recent Activity

Yesterday

sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Unmodified arrow keys: move/resize by single pixel
Arrow keys with shift held down: move/resize by large increment

Tue, Jun 19, 11:14 PM
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Okay then. will slow the movement/resizing down to 1px. Will probably use CTRL for mode switching.

Tue, Jun 19, 10:14 PM
sharvey added a comment to T9042: Kickoff improvements.

As an FYI... the way Kicker/Kickoff/Dashboard are coded is very clever. The individual icon entries are all created from the same code. Eike is very good at writing reusable code. The different launchers just sort and display them in different layouts. So if we add a "new" badge (an idea to which I give a +1), I believe it will show up in all the launchers. I don't see that as a bad thing, however.

Tue, Jun 19, 7:39 PM · Plasma, VDG
sharvey added a comment to T9042: Kickoff improvements.

I'll pitch in if I can. I've spent enough time in the Kickoff code trying to make circular avatars... argh.

Tue, Jun 19, 7:26 PM · Plasma, VDG
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Okay, so my short-term to-do list for this is:

  • move "large" by default (15 or 20 px, whichever feels: more comfortable)
  • Use + Arrows to move in single-pixel precision style
    • What modifider key do we want for resizing instead of moving? CTRL or ALT?
  • Write a boundary-checking function so the rectangle can't go past the screen edges
Tue, Jun 19, 5:13 PM

Mon, Jun 18

sharvey added a comment to D13095: Scren brightness follow a quatratic progression.

A couple of random ideas:

Mon, Jun 18, 9:20 PM · Plasma
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Strike everywhere I mentioned the new QML rectangle. The existing rectangle is QML. As I said, I'm a bit foggy at the moment.

Mon, Jun 18, 8:14 PM
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Although I haven't tested it, that patch sounds like it operates more quickly. If that's the case, it might make sense for me to hold off on this and refactor it based on the new & improved rectangle.

Mon, Jun 18, 8:11 PM

Thu, Jun 14

sharvey added a comment to D13095: Scren brightness follow a quatratic progression.

It seems I have some system rebuilding to do first. I'm not up for tackling it tonight. I'll work on it in the morning and try to get you some more data.

Thu, Jun 14, 12:26 AM · Plasma

Wed, Jun 13

sharvey added a comment to D13095: Scren brightness follow a quatratic progression.

Hi Scott, thanks for the help!
If you can apply the patch, we could see if you have the same behavior than Nate with his hardware: when setting a very low value (for him, it's in the range 1 to 5) to /sys/class/backlight/<hardware>/brightness his screen does not turn on at all. I would like to know if /sys/class/backlight/<hardware>/actual_brightness is then saying something different than /sys/class/backlight/<your hardware>/brightness.
On my computer the backlight goes on as soon as I put 1 to /sys/class/backlight/<hardware>/brightness, so I cannot reproduce this.
I hope I'm clear enough :)

Wed, Jun 13, 9:45 PM · Plasma
sharvey added a comment to D13095: Scren brightness follow a quatratic progression.

Hope you don't mind me jumping in - I'm another one of Nate's protegees... here's some data for you. These values are before your patch. Let me know if you'd like me to apply your patch and redo the testing.

Wed, Jun 13, 8:12 PM · Plasma

Mon, Jun 11

sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Whitespace cleanup
Mon, Jun 11, 11:26 AM
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.
  • Split bottom help text into two columns
Mon, Jun 11, 11:24 AM
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Split bottom help text into two columns
Mon, Jun 11, 11:23 AM

Sun, Jun 10

sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Great! That's taken care of the string and technical issues I spotted. Now that I play around with it, I notice that the explanatory text box on the bottom is getting pretty tall. I wonder if it might make sense to instead add a second column (i.e. a second GridLayout next to the original one) for these new lines. That way, compared to the status quo, it would grow horizontally instead of vertically. This might also impose a pleasing separation, since one column would be exclusively about the move/resize actions, so they wouldn't get lost in the middle.

What do you think?

Sun, Jun 10, 11:58 PM
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Properly format i18n strings
Sun, Jun 10, 11:44 PM
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

The proper way to do this like so:i18n("Move selection rectangle %1 pixels", largeChange)

Sun, Jun 10, 11:40 PM
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

largeChange value plugged in for help text. Reformatted strings in normal case, not Title Case.

Sun, Jun 10, 11:31 PM
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • More string revisions; use largeChange value in bottom help box
Sun, Jun 10, 11:28 PM
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Very cool! Works nicely for me. I've got a few string change suggestions below:

Sun, Jun 10, 11:22 PM
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • String revisions
Sun, Jun 10, 11:19 PM
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I had plenty of extra time while dog-sitting for friends. I've added the resizing functions. I think the resizing "directions" feel natural with the arrow keys as defined. Please let me know if you agree or disagree.

Sun, Jun 10, 3:25 AM
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Fix mismatched brackets
Sun, Jun 10, 3:15 AM
sharvey updated the test plan for D13450: Add arrow keys to move and resize selection rectangle.
Sun, Jun 10, 3:09 AM
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Rewrite key handler; add rectangle resize functions

ALT + Arrows = resize rectangle
ALT{+++{key+CTRL + Arrows = larger resize of rectangle

Sun, Jun 10, 3:02 AM

Sat, Jun 9

sharvey updated subscribers of D13450: Add arrow keys to move and resize selection rectangle.
Sat, Jun 9, 10:54 PM
sharvey updated the test plan for D13450: Add arrow keys to move and resize selection rectangle.
Sat, Jun 9, 9:57 PM
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

The bug report is a bit unclear... the title is

Sat, Jun 9, 9:56 PM
sharvey updated the summary of D13450: Add arrow keys to move and resize selection rectangle.
Sat, Jun 9, 9:50 PM
sharvey added reviewers for D13450: Add arrow keys to move and resize selection rectangle: rkflx, ngraham, Spectacle.
Sat, Jun 9, 9:49 PM
sharvey requested review of D13450: Add arrow keys to move and resize selection rectangle.
Sat, Jun 9, 9:45 PM

Thu, Jun 7

sharvey added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.

I encounter the very same issue as in D13202: Changing the Avatar in System Settings results in a blank circle in Kickoff. Here's a clue though: it only happens on the first change for each image. For example, if I change the image to something else in the gallery, hit apply, and open Kickoff, I see a blank circle. If I go to System Settings and change the avatar again--but choose the very same gallery image--then it shows up in Kickoff.

Thu, Jun 7, 9:35 PM · Plasma
sharvey added inline comments to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.
Thu, Jun 7, 9:30 PM · Plasma
sharvey added reviewers for D13415: Reshape Kickoff avatar to a circle with Opacity Mask: ngraham, davidedmundson, mart, apol, abetts.
Thu, Jun 7, 5:57 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

I rewrote this patch using an OpacityMask and a second rounded Rectangle to draw the ring. It's a separate diff - D13415: Reshape Kickoff avatar to a circle with Opacity Mask.

Thu, Jun 7, 5:55 PM · Plasma
sharvey requested review of D13415: Reshape Kickoff avatar to a circle with Opacity Mask.
Thu, Jun 7, 5:53 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

I thought I had the blank circle problem fixed, but it appears I was wrong - must've done something incomplete in my testing.

Thu, Jun 7, 4:18 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

Worth noting that some values were tweaked here because of the smaller circle size.

Thu, Jun 7, 2:03 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

@ngraham - This now appears to function properly with no blank circles. Will you please confirm?

Thu, Jun 7, 1:48 PM · Plasma
sharvey updated the diff for D13202: Circular user avatar for Kickoff.
  • Remove explicit visible: true, as default == true
Thu, Jun 7, 1:43 PM · Plasma

Wed, Jun 6

sharvey added a comment to D13202: Circular user avatar for Kickoff.

@apol : My first pass at this used OpacityMask. It worked well. See below.

Wed, Jun 6, 12:39 AM · Plasma
sharvey added inline comments to D13202: Circular user avatar for Kickoff.
Wed, Jun 6, 12:34 AM · Plasma

Tue, Jun 5

sharvey updated the diff for D13202: Circular user avatar for Kickoff.
  • Reset QtQuick version to 2.4
Tue, Jun 5, 8:14 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

Let's try this...

Tue, Jun 5, 8:12 PM · Plasma
sharvey updated the diff for D13202: Circular user avatar for Kickoff.
  • Force icon to be visible, avoiding blank circle
Tue, Jun 5, 8:10 PM · Plasma

Fri, Jun 1

sharvey added a comment to D13202: Circular user avatar for Kickoff.

@davidedmundson - could use your input here, please. Your circle shader effect detects a user avatar change, partially - it goes blank. But it doesn't reload squareFace despite the fact that all three avatar locations (~.face, ~.face.icon, and /var/lib/AccountServices/icon/$USER all update immediately. Any idea why it doesn't refresh, or how to force it to refresh?

Fri, Jun 1, 11:30 AM · Plasma

Wed, May 30

sharvey added a comment to D13202: Circular user avatar for Kickoff.

I don't know if I need to edit user-manager to emit a signal of some kind, or if some trigger needs to go over the D-Bus... I'm wading into deep water here.

Wed, May 30, 5:31 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

I'm not clear why user-manager removes the previous avatar, but the new one isn't immediately available.

Wed, May 30, 5:22 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

Looks great now! Quite pleasing to the eye.

I've got a few blockers though:

  • When I change the icon in the user-manager KCM and re-open Kickoff, the new icon isn't displayed; instead I just see a blank circle with no image in it until I quit and restart plasmashell.
Wed, May 30, 9:20 AM · Plasma

Tue, May 29

sharvey updated the diff for D13202: Circular user avatar for Kickoff.
  • Whitespace once more
Tue, May 29, 11:20 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.


Best yet, I think.

Tue, May 29, 11:17 PM · Plasma
sharvey updated the summary of D13202: Circular user avatar for Kickoff.
Tue, May 29, 11:16 PM · Plasma
sharvey added inline comments to D13202: Circular user avatar for Kickoff.
Tue, May 29, 11:15 PM · Plasma
sharvey updated the diff for D13202: Circular user avatar for Kickoff.
  • Remove redundant OpacityMask; tweaked antialiasing
Tue, May 29, 11:12 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

It doesn't look any different to me. They are both the same. Maybe the screenshot is too small? I can see the pixels from far on both images.

Tue, May 29, 8:59 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

AA option not set

Tue, May 29, 8:55 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

Cool! But in your latest screenshot, the circle is aliased pretty badly....

Tue, May 29, 8:40 PM · Plasma
sharvey updated the diff for D13202: Circular user avatar for Kickoff.
  • Whitespace (again...)
Tue, May 29, 6:23 PM · Plasma
sharvey updated the test plan for D13202: Circular user avatar for Kickoff.
Tue, May 29, 6:20 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

I stuck with @davidedmundson 's use of PlasmaCore.ColorScope.textColor for the highlight ring. I tested it with a few different color themes and the whole thing comes out looking like a natural match. This shot is back to my personal choice of an openSUSE scheme.

Tue, May 29, 6:19 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

If you copy and paste the ShaderEffect from UserDelegate.qml colorBorder is a property you can change

Tue, May 29, 6:14 PM · Plasma
sharvey updated the diff for D13202: Circular user avatar for Kickoff.
  • Add theme-colored ring around avatar
Tue, May 29, 6:11 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

The one visual improvement I could think of is adding a thin light gray outline around the circle to help separate it from the background. This is done on the login and lock screens; might be able to mine those implementations for ideas, if it's not too hard. But even without that, this is looking good. :)

Tue, May 29, 4:43 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

I intentionally didn't tag Bug 386656, as it has some debate allowing the user to select between a round or square avatar. @ngraham voted for the circle, which is what I implemented. If we want it switchable, I'll add a toggle. If not, I'll add the BUG: tag.

Tue, May 29, 4:34 PM · Plasma
sharvey added a comment to D13202: Circular user avatar for Kickoff.

Tue, May 29, 4:31 PM · Plasma
sharvey updated the diff for D13202: Circular user avatar for Kickoff.
  • Remove whitespace
Tue, May 29, 4:29 PM · Plasma
sharvey requested review of D13202: Circular user avatar for Kickoff.
Tue, May 29, 4:27 PM · Plasma

Mon, May 28

sharvey added a comment to T8888: Integrate alternative input systems in Plasma.

+1 for this as a whole. If I can find a way to help, I will.

Mon, May 28, 4:27 PM · Plasma Accessibility

Sun, May 27

sharvey added a comment to D13122: Add second line of text for KickerDash item descriptions.

Message received and understood. Sorry for jumping the gun.

Sun, May 27, 1:51 PM · Plasma
sharvey added a comment to T8721: Make Color Picker in System Settings Color Module Pick Colors from Any Area on Screen.

Either I'm not understanding your request properly, or the color picker does work as you're requesting. See the following YouTube link - video is too large to upload directly to Phab.

Sun, May 27, 2:11 AM · Plasma, VDG

Sat, May 26

sharvey added a watcher for Plasma: Mobile: sharvey.
Sat, May 26, 3:56 AM
sharvey added a comment to T7770: Grow the number of developers and the community support for Plasma Mobile.

I had a rough day today (technically, it's not over yet), so I spent about $80 on a used LG V500 Android tablet that will run LineageOS. We have a wiki page for how to get PM up and running on a Lineage-powered device.

Sat, May 26, 3:54 AM · Plasma: Mobile, KDE Promo
sharvey added a comment to D13122: Add second line of text for KickerDash item descriptions.

Oh. I see. The Phab emails say "now ready to land", so I did what the machine told me to. But I clearly see your point.

Sat, May 26, 3:24 AM · Plasma
sharvey committed R119:cd7252e9fa07: Add second line of text for KickerDash item descriptions (authored by sharvey).
Add second line of text for KickerDash item descriptions
Sat, May 26, 3:19 AM
sharvey closed D13122: Add second line of text for KickerDash item descriptions.
Sat, May 26, 3:19 AM · Plasma
sharvey updated the diff for D13122: Add second line of text for KickerDash item descriptions.
  • - Remove trailing whitespace
Sat, May 26, 3:16 AM · Plasma
sharvey added a comment to D13122: Add second line of text for KickerDash item descriptions.

I forgot it was a bug. I thought it was an assignment. :-)

Sat, May 26, 3:13 AM · Plasma
sharvey updated the summary of D13122: Add second line of text for KickerDash item descriptions.
Sat, May 26, 3:12 AM · Plasma

Fri, May 25

sharvey added a comment to D13122: Add second line of text for KickerDash item descriptions.


Unfortunate line breaks in long file names. See line 98.

Fri, May 25, 9:42 PM · Plasma
sharvey added inline comments to D13122: Add second line of text for KickerDash item descriptions.
Fri, May 25, 9:37 PM · Plasma
sharvey updated the test plan for D13122: Add second line of text for KickerDash item descriptions.
Fri, May 25, 9:35 PM · Plasma
sharvey updated subscribers of D13122: Add second line of text for KickerDash item descriptions.
Fri, May 25, 9:35 PM · Plasma
sharvey requested review of D13122: Add second line of text for KickerDash item descriptions.
Fri, May 25, 9:33 PM · Plasma

Thu, May 24

sharvey added reviewers for D13098: Right-align all translation count columns in Project Overview: sharvey, ngraham.
Thu, May 24, 6:19 PM · Localization
sharvey committed R108:393af855c483: Revert "Revert "Add "SkipSwitcher" to API"" (authored by sharvey).
Revert "Revert "Add "SkipSwitcher" to API""
Thu, May 24, 4:36 AM
sharvey added a reverting change for R108:5ef119044df1: Revert "Add "SkipSwitcher" to API": R108:393af855c483: Revert "Revert "Add "SkipSwitcher" to API"".
Thu, May 24, 4:36 AM
sharvey added a comment to D12855: Move Widget search field to its own row so it doesn't get compressed.


Two quick injections of units.smallSpacing for margins and we have a nice sleek display with no overlap.

Thu, May 24, 3:40 AM · Plasma
sharvey updated the diff for D12855: Move Widget search field to its own row so it doesn't get compressed.
  • Add units.smallSpacing as margins around search bar row
Thu, May 24, 3:38 AM · Plasma
sharvey added a comment to D12855: Move Widget search field to its own row so it doesn't get compressed.
Thu, May 24, 1:13 AM · Plasma

Wed, May 23

sharvey added a comment to D12855: Move Widget search field to its own row so it doesn't get compressed.

@davidedmundson (and/or others) - what's the most-correct and most-effective QML method to add a bit of padding around these elements? I know we want to link "tops" to "bottoms" in row layouts, which makes perfect sense. But what's the right way to add a bit of margin? In this case, the descender in the g in Widgets is right up against the search text bar. Likewise, the icons for the available widgets run right up to the bottom of the text field.

Wed, May 23, 11:11 PM · Plasma
sharvey added inline comments to D12855: Move Widget search field to its own row so it doesn't get compressed.
Wed, May 23, 11:06 PM · Plasma
sharvey updated the diff for D12855: Move Widget search field to its own row so it doesn't get compressed.
  • Merge branch 'master' into new-search-row
  • Revise QML using relative sizing & spacing instead of fixed values
Wed, May 23, 11:05 PM · Plasma

Tue, May 22

sharvey added a comment to R127:10b00a219e9f: Add "SkipSwitcher" to API.

D11926: Add "SkipSwitcher" to API was already landed and closed several weeks ago. I believe everything is complete.

Tue, May 22, 3:32 PM
sharvey committed R127:10b00a219e9f: Add "SkipSwitcher" to API (authored by sharvey).
Add "SkipSwitcher" to API
Tue, May 22, 3:27 PM
sharvey closed D11925: Add "SkipSwitcher" to API.
Tue, May 22, 3:27 PM · Frameworks
sharvey added a reviewer for D12855: Move Widget search field to its own row so it doesn't get compressed: Plasma.
Tue, May 22, 3:01 PM · Plasma
sharvey added a comment to D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager.

As a side note, usage of the terms "kicker" and/or "kickoff" aren't user-friendly at all. They're basically internal names and aren't mentioned in any user-facing text. I'm not trying to hijack the issue; this is just one of those barriers to entry we should try to knock down for newcomers.

Tue, May 22, 1:53 PM · Plasma
sharvey added a comment to D11925: Add "SkipSwitcher" to API.

any update on this? It's just the version increase in registry.cpp which is missing...

Tue, May 22, 12:18 PM · Frameworks
sharvey updated the diff for D11925: Add "SkipSwitcher" to API.
  • Increate interface versions for PlasmaShell and PlasmaWindowManagement
Tue, May 22, 12:12 PM · Frameworks

May 17 2018

sharvey added a comment to T8686: Junior Jobs.

What constitutes a "junior job" does indeed vary immensely. The maintainers or "lead" developers need to flag bugs carefully and appropriately. I've worked on junior jobs that ranged from string and icon changes, to adding a new API call to KWin. These were all referred to as JJ's, but they're definitely on different levels.

May 17 2018, 6:53 PM · Goal settings 2017