sharvey (Scott Harvey)
Developer

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jan 29 2018, 2:52 AM (45 w, 6 d)
Availability
Available

Chicago.

_sharvey_ on IRC.

Recent Activity

Oct 31 2018

sharvey added a comment to T9956: KDE Promotional Stickers & More.

3"x3" die-cut stickers (the K-Gear) from StickerMule are $351 (308 euros) for 1000 stickers. As suggested, these should probably be held back as special giveaways or for a small donation.

Oct 31 2018, 1:09 PM
sharvey updated subscribers of T9956: KDE Promotional Stickers & More.
Oct 31 2018, 12:35 PM

Oct 30 2018

sharvey triaged T9956: KDE Promotional Stickers & More as Normal priority.
Oct 30 2018, 10:59 PM

Oct 13 2018

sharvey added a comment to D15011: [Kickoff] Make the search field always look like a search field.

Anyway, I am not yet a contributor so my words are weightless.

Oct 13 2018, 5:17 PM · Plasma
sharvey added a comment to D15011: [Kickoff] Make the search field always look like a search field.

</me looks up Activities since he doesn't use them>

Oct 13 2018, 4:52 PM · Plasma
sharvey added a comment to D15011: [Kickoff] Make the search field always look like a search field.

I can take a look at it. I didn't do anything regarding its visual appearance, just made it appear and disappear at will - by hiding or showing the row it was placed on.

Oct 13 2018, 3:37 PM · Plasma

Oct 1 2018

sharvey requested review of D15885: Clean UI file for `details` portion of UI.
Oct 1 2018, 4:40 PM · Plasma

Sep 30 2018

sharvey added a comment to T8623: sprint for onboarding goal.
In T8623#162141, @ervin wrote:

Do we have any news about that sprint and when/where it'll happen?

Sep 30 2018, 5:25 PM · Goal settings 2017

Sep 29 2018

sharvey added a comment to D12498: Fully remove `Application Name` from Details panel.

@ngraham : Now that I understand what went wrong here, I really do think this particular diff be abandoned. It mistakenly contains unrelated material from a different diff (D12311) - which we probably shouldn't re-submit. I will get a fresh master, which will have D12311 already incorporated and make @bruns 's small change. That should resolve the issue without any drama.

Sep 29 2018, 10:20 AM · Plasma

Sep 28 2018

sharvey added a comment to D12498: Fully remove `Application Name` from Details panel.

This was copied from D12311: Align lock icon with bold message text; reduce overall size of dialog, which languished unapproved and un-landed for a long time. Indeed, I should have made this a separate patch, but I'd only been a contributor for about 2-3 months at this time. It duplicates a lot of what's in D12311, which is now finally closed.

Sep 28 2018, 9:37 PM · Plasma
sharvey added a comment to D12498: Fully remove `Application Name` from Details panel.

I believe what you're perceiving in the XML file is in fact the result of a lot of changes made to the layout. Unneeded columns, rows, and spacers were deleted, causing "gaps" in the old XML file. In places, I added options like column spans and justifications. The XML file changed a lot.

Sep 28 2018, 9:06 PM · Plasma

Sep 27 2018

sharvey added inline comments to D12498: Fully remove `Application Name` from Details panel.
Sep 27 2018, 11:03 PM · Plasma

Sep 26 2018

sharvey updated the diff for D12498: Fully remove `Application Name` from Details panel.
  • Changed PolKit description to Description not provided

Was: "Missing"

Sep 26 2018, 3:22 PM · Plasma

Sep 25 2018

sharvey added a comment to T8569: Redesign Policy Kit Authorization dialog.

Anyone have any suggestions?

Sep 25 2018, 9:29 PM · Plasma

Sep 24 2018

sharvey added a comment to T9128: Ship some more of the best KDE apps with Cosmic.

Anything you can trim away? IIRC, Kubuntu ships with a full boat of System and Utility apps, which a lot of users might not need. I don't know how much space you can shave away with small apps like that - just thinking out loud.

Sep 24 2018, 2:46 PM · Kubuntu
sharvey added a comment to T9128: Ship some more of the best KDE apps with Cosmic.

I'd vote for Krita over all the others. It's a fantastic piece of software, on par with Photoshop and arguably outdoes GIMP.

Sep 24 2018, 9:44 AM · Kubuntu
sharvey added a comment to T9127: Ship some KDE games with Cosmic.

I vote for KPatience and KMahjong. They're two very good-looking games, proving that Linux games aren't pixellated messes from the 1980s. Plus, they're sort-of "classics", included in a lot of distros and even competing OSes like iOS and Windows. It would give Kubuntu a well-rounded feeling as a complete and user-friendly distro.

Sep 24 2018, 9:41 AM · Kubuntu

Sep 22 2018

sharvey updated the diff for D15699: Relabel "Mouse Click Emulation" to "Tap to Click".

Update "Mouse Click Emulation" to "Tap to Click"

Sep 22 2018, 10:17 PM · Plasma
sharvey updated the summary of D15699: Relabel "Mouse Click Emulation" to "Tap to Click".
Sep 22 2018, 9:36 PM · Plasma
sharvey added a reviewer for D15699: Relabel "Mouse Click Emulation" to "Tap to Click": Plasma.
Sep 22 2018, 9:34 PM · Plasma
sharvey added inline comments to D15699: Relabel "Mouse Click Emulation" to "Tap to Click".
Sep 22 2018, 9:33 PM · Plasma
sharvey requested review of D15699: Relabel "Mouse Click Emulation" to "Tap to Click".
Sep 22 2018, 9:31 PM · Plasma

Aug 29 2018

sharvey added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.

Thanks for the investigation. I've been hoping someone else would lend a pair of eyes to this problem for ages.

Aug 29 2018, 8:55 AM · Plasma

Aug 27 2018

sharvey accepted D15101: [Widget Explorer] always show the search field.
Aug 27 2018, 10:29 PM · Plasma
sharvey committed R119:08983522bfb4: Move Widget search field to its own row so it doesn't get compressed (authored by sharvey).
Move Widget search field to its own row so it doesn't get compressed
Aug 27 2018, 12:42 PM
sharvey closed D12855: Move Widget search field to its own row so it doesn't get compressed.
Aug 27 2018, 12:42 PM · Plasma
sharvey committed R121:d4ee26a76a21: Align lock icon with bold message text; reduce overall size of dialog (authored by sharvey).
Align lock icon with bold message text; reduce overall size of dialog
Aug 27 2018, 12:40 PM
sharvey closed D12311: Align lock icon with bold message text; reduce overall size of dialog.
Aug 27 2018, 12:40 PM · Plasma

Jul 31 2018

sharvey added a comment to D14520: Open `skipPager` functionality.

Hopefully .arclint is gone for good this time.

Jul 31 2018, 8:15 PM · Frameworks
sharvey updated the diff for D14520: Open `skipPager` functionality.
  • Whitespace fix & remove .arclint
Jul 31 2018, 8:13 PM · Frameworks
sharvey added a comment to D14520: Open `skipPager` functionality.

Okay, a clean copy. Apologies for the mess. I can do the coding, but the infrastructure is another story...

Jul 31 2018, 5:14 PM · Frameworks
sharvey updated the diff for D14520: Open `skipPager` functionality.
  • Remove wrongly committed files
Jul 31 2018, 5:13 PM · Frameworks
sharvey requested review of D14520: Open `skipPager` functionality.
Jul 31 2018, 5:09 PM · Frameworks
sharvey abandoned D14516: Open `skipPager` functionality.
Jul 31 2018, 4:42 PM · Frameworks
sharvey added a comment to D14516: Open `skipPager` functionality.

There's no functionality to remove files. I'll submit a new diff.

Jul 31 2018, 4:41 PM · Frameworks
sharvey updated the diff for D14516: Open `skipPager` functionality.

Remove untracked .arclint and CMakeLists.txt.user

Jul 31 2018, 4:39 PM · Frameworks
sharvey added a comment to D14516: Open `skipPager` functionality.

Changes to .arclint look unintended, and I'm not sure you meant to check in CMakeLists.txt.user.

Jul 31 2018, 4:31 PM · Frameworks
sharvey added a comment to D14516: Open `skipPager` functionality.

Plasma team: Please help me review and fix the failing autotests. I'm not familiar enough with the internals of KWayland - or autotests - to successfully debug what's happening. The patch builds and compiles without error.

Jul 31 2018, 4:27 PM · Frameworks
sharvey added a reviewer for D14516: Open `skipPager` functionality: Plasma on Wayland.
Jul 31 2018, 4:25 PM · Frameworks
sharvey requested review of D14516: Open `skipPager` functionality.
Jul 31 2018, 4:23 PM · Frameworks

Jul 25 2018

sharvey added a comment to T9271: Attracting and Onboarding contributors from downstream distributions.

I think this has to be considered an "advanced" topic. We've first got to get the new people submitting patches and having them accepted. I've been banging away at patches and bugfixes for the past 8 months and have never even investigated how to package something for distribution. I'm working on a personal project that I'll want to distribute, but I've got plenty of coding before I get there.

Jul 25 2018, 2:26 PM · Goal settings 2017
sharvey committed R166:9c07cae31955: Merge branch 'master' of git://anongit.kde.org/spectacle (authored by sharvey).
Merge branch 'master' of git://anongit.kde.org/spectacle
Jul 25 2018, 12:26 PM
sharvey committed R166:f96a1af43771: Merge remote-tracking branch 'origin/Applications/18.08' (authored by sharvey).
Merge remote-tracking branch 'origin/Applications/18.08'
Jul 25 2018, 12:26 PM
sharvey committed R166:f484ee979bed: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle (authored by sharvey).
Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle
Jul 25 2018, 12:18 PM
sharvey closed D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.
Jul 25 2018, 12:18 PM
sharvey added a comment to D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.

Thanks, can confirm that the issue with doubled resizing is fixed. Accepting for now, even though the code is not the most concise yet.

Please commit to the stable branch.

Jul 25 2018, 12:15 PM
sharvey added a comment to D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.

a more general tip, it should be easier to branch off of the stable branch (Applications/18.08) if you are submitting a bugfix, like so:

git checkout Applications/18.08
git pull
arc feature fix-stuck-edges

Currently your patch is branched from master, which makes landing to stable more difficult, as it requires extra steps for rebasing and specifying the target branch.

Jul 25 2018, 2:46 AM
sharvey added a comment to D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.

@rkflx - I fixed the double-size movement for Alt + (and Alt + + as well).

Jul 25 2018, 2:37 AM
sharvey updated the diff for D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.
  • Fix doubled movement for Alt-Up and Alt-Shift-Up
Jul 25 2018, 2:29 AM

Jul 24 2018

sharvey added inline comments to D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.
Jul 24 2018, 6:29 PM

Jul 23 2018

sharvey added a comment to D12498: Fully remove `Application Name` from Details panel.

As soon as D12311: Align lock icon with bold message text; reduce overall size of dialog is landed, I'll change this string.

Jul 23 2018, 10:48 PM · Plasma
sharvey added a comment to D12498: Fully remove `Application Name` from Details panel.

I'm still in favor of the brief but descriptive "Not Provided". This is an advanced developer field. I could add a tooltip with some additional information. My point is to convey the fact that "the vendor is supposed to provide this information, but did not."

Jul 23 2018, 3:37 PM · Plasma
sharvey added a comment to D12311: Align lock icon with bold message text; reduce overall size of dialog.

I believe it's done.

Jul 23 2018, 2:26 PM · Plasma

Jul 20 2018

sharvey added a comment to D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.

Here you go - a freshly rewritten arrow/rectangle handler. It's still got a fair bit of repetition, which I'd like to work on at some point. This version does not get "stuck" at the screen edges. It also stops resizing the rectangle to a minimum of 20x20px, the same as the initial mouse click to start the rectangle.

Jul 20 2018, 5:39 PM
sharvey added inline comments to D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.
Jul 20 2018, 5:34 PM
sharvey retitled D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle from Rework rectamgle/arrpw key handling to avoid "stuck edges" and 0x0px rectangle to Rework rectamgle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.
Jul 20 2018, 5:31 PM
sharvey added reviewers for D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle: rkflx, ngraham, Spectacle.
Jul 20 2018, 5:31 PM
sharvey requested review of D14252: Rework rectangle/arrow key handling to avoid "stuck edges" and 0x0px rectangle.
Jul 20 2018, 5:29 PM

Jul 19 2018

sharvey added a comment to T9243: Help the KDE PIM team with content for the new Kontact website.

First draft looks great! I like how bold the names of the apps appear on the slides. Really jumps out and looks like "confidence".

Jul 19 2018, 8:34 PM · KDE Promo
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

It seems you forgot to merge stable into master, which I now have done with

Jul 19 2018, 11:10 AM · Documentation
sharvey committed R166:48eacd1ba149: Add arrow keys to move and resize selection rectangle (authored by sharvey).
Add arrow keys to move and resize selection rectangle
Jul 19 2018, 10:38 AM
sharvey closed D13450: Add arrow keys to move and resize selection rectangle.
Jul 19 2018, 10:38 AM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Thanks, looking much better now.

Please make sure to commit to the stable branch, i.e. Applications/18.08 (let me know if you are unsure what that means).

Jul 19 2018, 10:36 AM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Minor whitespace cleanup
Jul 19 2018, 10:33 AM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Fix Alt + Down; Undo layout changes for help text; Reorder help text items
Jul 19 2018, 10:24 AM · Documentation

Jul 18 2018

sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Tagging is on Thursday at 23:59 UTC. I will accept the patch tomorrow so you can still land it in time (let me know if you are busy and I should commit on your behalf).

Jul 18 2018, 11:46 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Yeah, the magnifier shows up while dragging the selection rect (or not, depending on whether or not you've holding down ), but it currently doesn't show up when you're using Alt to resize the rect using the keyboard arrow keys.

IMHO, if you have the magnifier turned on in the settings, it should show up when you're in "fine tune" mode (holding down both and Alt and using the arrow keys to resize the rect by single pixels), because conceptually, if you're doing this, it's because you want a pixel-perfect rect.

Jul 18 2018, 3:12 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I still disagree regarding the default speed selection. We determined by looking at other apps that is the modifier to use, and I argued (in line with what I meant when triaging the bug) that for making the rectangle feature useful for keyboard users by default the movement should be fast. BTW, this is also what KWin is doing, and I see no reason at all why Spectacle should deviate from that standard. (See above for even more arguments.) I don't feel comfortable approving the current default, sorry.

Jul 18 2018, 2:21 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I'm noticing that the magnifier doesn't er show up while you're using the keyboard to resize the selection rect. Might wanna hook that up.

Jul 18 2018, 2:11 PM · Documentation
sharvey updated the test plan for D13450: Add arrow keys to move and resize selection rectangle.
Jul 18 2018, 2:01 PM · Documentation
sharvey added inline comments to D13450: Add arrow keys to move and resize selection rectangle.
Jul 18 2018, 1:59 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Change default adjustment to largeChange, uses smallChange for fine tuning
  • Numerous miscellaneous changes per reviewer comments, including:
    • Condensed adjustment calculations to use +=
    • Reverted help text box to match original layout
    • Revised docbook entry for clarity and consistency
Jul 18 2018, 1:56 PM · Documentation
sharvey added inline comments to D13450: Add arrow keys to move and resize selection rectangle.
Jul 18 2018, 12:57 PM · Documentation
sharvey added inline comments to D13450: Add arrow keys to move and resize selection rectangle.
Jul 18 2018, 12:33 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.
  • Selecting with the mouse sets a minimum size, however resizing with the arrow keys allows to resize to 0x0px.
Jul 18 2018, 12:40 AM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I will attempt to get these completed early tomorrow morning (my time). It's already the end of the day here and I know (from unfortunate experience) that I don't do my best work "after hours".

Jul 18 2018, 12:36 AM · Documentation

Jul 17 2018

sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Grammar consistency in docbook fixed
Jul 17 2018, 3:52 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

About the date: that's not the release date, but the date where the document was last updated.

Jul 17 2018, 3:47 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Correct revision date in docbook
Jul 17 2018, 3:46 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

There's only one remaining thing to do from my perspective: update the docbook to document this nice new feature! It would be great if you could do that in this patch. Keep in mind that 18.08 has already been branched and the freeze is in two days, so if you'd like to get this in for the next release, you'll have to work quickly. :)

Jul 17 2018, 3:41 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Edit docbook to include arrow key usage; update release number and date
Jul 17 2018, 3:34 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • String tweaks / Make smallChange and largeChange both "positive" for consistency
Jul 17 2018, 11:29 AM · Documentation

Jul 16 2018

sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I apologize for the delay in getting this finalized. It's been a tumultuous month in real life. Including emergency heart surgery for my father, a flare-up of my own illnesses (I'm on disability), and finally - a kernel upgrade that somehow failed, rendering my machine unbootable. Lots of reinstalling and reconfiguring.

Jul 16 2018, 8:02 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Change movement sizes to handle HiDPI screens
Jul 16 2018, 7:58 PM · Documentation

Jun 27 2018

sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Also, looks like the current policy for HiDPI is to "scale up" the moves, so if I set QT_SCALE_FACTOR=5, the smallest move is 5 real pixels. We probably want to change that, so that we move by factor / Screen.devicePixelRatio which would ensure we move by factor "real" pixels. Apart from that, 15px seems pretty good on my 2560x1440 monitor.

Jun 27 2018, 1:28 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Whitespace cleanup; remove unused variables
Jun 27 2018, 12:21 AM · Documentation

Jun 26 2018

sharvey added inline comments to D13450: Add arrow keys to move and resize selection rectangle.
Jun 26 2018, 9:37 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Why not make it a user configurable option?

Jun 26 2018, 9:05 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

I probably need to do a little whitespace & indenting cleanup. I'll hold off until everyone's satisfied with the behavior. Just want you to know I'm aware of it.

Jun 26 2018, 8:58 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Hm, my intention when I triaged the bug was indeed to make it possible to set the selection rectangle from the keyboard. When I mentioned the separate patch, this was only about how to start the actual selection process. I don't think it makes sense to change the speed later again, we should get it right here.

Jun 26 2018, 8:55 PM · Documentation
sharvey removed a watcher for Plasma: Mobile: sharvey.
Jun 26 2018, 8:41 PM
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

@abalaji: I have to respectfully disagree with the idea of multi-directional movement. My intent behind this patch remains geared toward incremental adjustments to the original mouse-drawn rectangle, not a full-blown replacement for drawing a rectangle entirely from the keyboard and having to make dramatic changes.

Jun 26 2018, 8:33 PM · Documentation
sharvey updated the summary of D13450: Add arrow keys to move and resize selection rectangle.
Jun 26 2018, 12:10 PM · Documentation
sharvey updated the test plan for D13450: Add arrow keys to move and resize selection rectangle.
Jun 26 2018, 12:08 PM · Documentation
sharvey updated the test plan for D13450: Add arrow keys to move and resize selection rectangle.
Jun 26 2018, 12:06 PM · Documentation
sharvey added a comment to D13450: Add arrow keys to move and resize selection rectangle.

Okay, I've finally gotten a working, reusable, reasonably sensible function for keeping the rectangle constrained inside the screen.

Jun 26 2018, 12:05 PM · Documentation
sharvey updated the diff for D13450: Add arrow keys to move and resize selection rectangle.
  • Revise modifier keys / Add boundary-checking function
Jun 26 2018, 12:04 PM · Documentation

Jun 25 2018

sharvey added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.
In D13415#282884, @hein wrote:

Can you have a look at the code in kdeclarative, specifically src/qmlcontrols/kcoreaddons/kuserproxy.cpp - that's where the KDirWatch monitoring the face.icon file is. I think you need to place some qDebug() there to see if the file change gets picked up on your system and the signal emitted. If this is working, then we know the problem has to be in the QML side.

Jun 25 2018, 7:45 PM · Plasma
sharvey added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.
In D13415#282860, @hein wrote:

Can you elaborate what you tried and what you wanted to happen and what didn't happen? I'm a bit confused now @ touch.

Jun 25 2018, 7:38 PM · Plasma
sharvey added a comment to D13415: Reshape Kickoff avatar to a circle with Opacity Mask.

Trying to use touch made no difference. I called it manually between changes, and actually added it (temporarily) to the actual Kickoff code, so it "touched" every time Kickoff was opened. No change.

Jun 25 2018, 6:56 PM · Plasma