graesslin (Martin Gräßlin)
KWin maintainer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 8:19 AM (105 w, 21 h)
Availability
Available

Recent Activity

Yesterday

graesslin committed R133:cc3265cf01cc: Fix removal of lock window on unmap (authored by graesslin).
Fix removal of lock window on unmap
Sat, Apr 22, 8:18 PM
graesslin committed R133:88b502d325d2: Terminate kscreenlocker_greet and don't kill it on unlockRequest (authored by graesslin).
Terminate kscreenlocker_greet and don't kill it on unlockRequest
Sat, Apr 22, 7:05 PM
graesslin committed R108:f3b20b482eb6: Use end() instead of constEnd() for where we compare to an iterator (authored by graesslin).
Use end() instead of constEnd() for where we compare to an iterator
Sat, Apr 22, 6:29 PM
graesslin moved T5197: Keyboard layout switching policies from Plasma 5.10 to Done on the Plasma on Wayland board.
Sat, Apr 22, 6:27 AM · KWin, Plasma on Wayland
graesslin moved T5197: Keyboard layout switching policies from Work In Progress to Done on the KWin board.
Sat, Apr 22, 6:26 AM · KWin, Plasma on Wayland
graesslin created D5540: Add a KSharedConfigPtr for kcminputrc to KWin::Application.
Sat, Apr 22, 6:26 AM · KWin
graesslin committed R108:ac08c5ac9d45: [plugins/qpa] Do not replace a valid FBO with an invalid one (authored by graesslin).
[plugins/qpa] Do not replace a valid FBO with an invalid one
Sat, Apr 22, 6:24 AM
graesslin committed R108:eec6afe6f5fe: Don't map screenedge approach window if edge is only used for touch (authored by graesslin).
Don't map screenedge approach window if edge is only used for touch
Sat, Apr 22, 6:24 AM
graesslin closed D5528: Don't map screenedge approach window if edge is only used for touch by committing R108:eec6afe6f5fe: Don't map screenedge approach window if edge is only used for touch.
Sat, Apr 22, 6:24 AM · KWin
graesslin committed R108:b132fe7c245c: Add support for keyboard layout switching policy "winclass" (authored by graesslin).
Add support for keyboard layout switching policy "winclass"
Sat, Apr 22, 6:24 AM
graesslin closed D5438: [plugins/qpa] Do not replace a valid FBO with an invalid one by committing R108:ac08c5ac9d45: [plugins/qpa] Do not replace a valid FBO with an invalid one.
Sat, Apr 22, 6:24 AM · KWin
graesslin committed R108:e9a44a275e74: Support blocking of screen edges on active fullscreen windows also for touch (authored by graesslin).
Support blocking of screen edges on active fullscreen windows also for touch
Sat, Apr 22, 6:24 AM
graesslin closed D5365: Add support for keyboard layout switching policy "winclass" by committing R108:b132fe7c245c: Add support for keyboard layout switching policy "winclass".
Sat, Apr 22, 6:24 AM · Plasma
graesslin closed D5403: Support blocking of screen edges on active fullscreen windows also for touch by committing R108:e9a44a275e74: Support blocking of screen edges on active fullscreen windows also for touch.
Sat, Apr 22, 6:24 AM · KWin
graesslin committed R108:c8274dbe5798: Add support for keyboard layout switching policy "window" (authored by graesslin).
Add support for keyboard layout switching policy "window"
Sat, Apr 22, 6:24 AM
graesslin closed D5315: Add support for keyboard layout switching policy "window" by committing R108:c8274dbe5798: Add support for keyboard layout switching policy "window".
Sat, Apr 22, 6:24 AM · Plasma
graesslin committed R108:bf99d9ffdd91: Introduce support for keyboard layout switching policies (authored by graesslin).
Introduce support for keyboard layout switching policies
Sat, Apr 22, 6:24 AM
graesslin closed D5301: Introduce support for keyboard layout switching policies by committing R108:bf99d9ffdd91: Introduce support for keyboard layout switching policies.
Sat, Apr 22, 6:24 AM · Plasma

Fri, Apr 21

graesslin added a comment to D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed.

The other dependencies: well KCoreAddons is needed for KCrash only IIRC. That is setting the KAboutData.

I've had a look... and the plugins are also handled by KPluginLoader, KPluginMetaData & co.

Fri, Apr 21, 2:15 PM · Frameworks
graesslin added a comment to T4448: [kwin] Support for startup notifications.

an idea how it could work technically: the startup notification id should still be passed to the application through env variable. We could - in the Qt case - use plasma-integration to pass the startup id to KWin, so that we have the link between window and startup id.

Fri, Apr 21, 1:59 PM · Plasma on Wayland
graesslin added a comment to D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed.

oh and yes for removing service dependency please open a separate review. The other dependencies: well KCoreAddons is needed for KCrash only IIRC. That is setting the KAboutData. So a possibility could be to move the binary out and replace it by a binary which does not use KCrash. And we could add the good old kglobalacceld5 with KCrash into Plasma. That could solve all the problems we have.

Fri, Apr 21, 1:11 PM · Frameworks
graesslin added a comment to D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed.
In D5521#103775, @cfeck wrote:

Btw, libKF5GlobalAccel is actually Tier1, so applications needing global shortcuts will not have any (additional) KF5 dependencies, only the runtime has.

But without the runtime the application using libKF5GlobalAccel will not get any shortcut signals delivered, not?

Fri, Apr 21, 1:07 PM · Frameworks
graesslin added a comment to D4893: Layout and animations on the on screen keyboard.
In D4893#103772, @mart wrote:

Just verified: reverting this change also fixes the issues mentioned for Wayland.

i think i found the problem, it was looking for VirtualKeyboard.qml in the wrong path, now it should work

Fri, Apr 21, 1:02 PM · Plasma
graesslin added a comment to D4893: Layout and animations on the on screen keyboard.

Just verified: reverting this change also fixes the issues mentioned for Wayland.

Fri, Apr 21, 5:09 AM · Plasma
graesslin added a comment to D4893: Layout and animations on the on screen keyboard.
In D4893#103687, @mart wrote:

I fear this change caused regressions. I now don't have the virtual keyboard button on the layout anymore (X11 and Wayland) and on Wayland it's impossible to unlock the screen.

I just reverted the change locally and that fixed the issue for me. So yes this change unfortunately broke the feature it was supposed to improve. As an idea: maybe it did not incorporate adjustements for 54479d32a96430dd093b4489c6f2a6fe449d2f80.

so is the virtual keyboard button itself that's invisible?

Fri, Apr 21, 4:51 AM · Plasma

Thu, Apr 20

graesslin committed R133:d3e3c2ebd432: [autotests] add missing add_test (authored by graesslin).
[autotests] add missing add_test
Thu, Apr 20, 6:58 PM
graesslin created D5528: Don't map screenedge approach window if edge is only used for touch.
Thu, Apr 20, 6:12 PM · KWin
graesslin added a comment to D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed.

Distributions will ship only one variant of kglobalaccel and that will most likely be the one which is wanted by KDE

Why is that? Why can't we have e.g. one foo-kde and other foo-lxqt package, both providing virtual foo (these will be in conflict as they will provide the same file(s)). Then KDE can depend strictly on foo-kde.

Thu, Apr 20, 5:36 PM · Frameworks
graesslin added a comment to D4893: Layout and animations on the on screen keyboard.

I fear this change caused regressions. I now don't have the virtual keyboard button on the layout anymore (X11 and Wayland) and on Wayland it's impossible to unlock the screen.

Thu, Apr 20, 3:10 PM · Plasma
graesslin committed R108:a5735e19b99d: [platforms/x11] Do not grab touch events (authored by graesslin).
[platforms/x11] Do not grab touch events
Thu, Apr 20, 3:04 PM
graesslin committed R108:919b497f9020: [effects/slideback] Consider windows which do have painting disabled as not… (authored by graesslin).
[effects/slideback] Consider windows which do have painting disabled as not…
Thu, Apr 20, 3:04 PM
graesslin closed D5520: [platforms/x11] Do not grab touch events by committing R108:a5735e19b99d: [platforms/x11] Do not grab touch events.
Thu, Apr 20, 3:04 PM · KWin
graesslin closed D5462: [effects/slideback] Consider windows which do have painting disabled as not usable by committing R108:919b497f9020: [effects/slideback] Consider windows which do have painting disabled as not….
Thu, Apr 20, 3:04 PM · KWin
graesslin committed R108:9a13743c4988: Don't update the focused pointer Surface if a button is pressed (authored by graesslin).
Don't update the focused pointer Surface if a button is pressed
Thu, Apr 20, 3:04 PM
graesslin closed D5461: Don't update the focused pointer Surface if a button is pressed by committing R108:9a13743c4988: Don't update the focused pointer Surface if a button is pressed.
Thu, Apr 20, 3:04 PM · Plasma
graesslin committed R108:c3ecf55bf8e0: Do not handle ScreenEdges::check for Edges which don't activate for Pointer (authored by graesslin).
Do not handle ScreenEdges::check for Edges which don't activate for Pointer
Thu, Apr 20, 3:04 PM
graesslin closed D5421: Do not handle ScreenEdges::check for Edges which don't activate for Pointer by committing R108:c3ecf55bf8e0: Do not handle ScreenEdges::check for Edges which don't activate for Pointer.
Thu, Apr 20, 3:04 PM · KWin
graesslin added a comment to D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed.

I don't really understand what this change is supposed to fix. Distributions will ship only one variant of kglobalaccel and that will most likely be the one which is wanted by KDE. If kglobalaccel is shipped without KCrash support I would consider this as a serious problem and report that to the distributions. Also given my experience about breakage in weird situations I'm against such build flexibility. KCrash is an important component for kglobalaccel and I'm not interested in having to spend time on bug reports because a distro mis-configured kglobalaccel.

Thu, Apr 20, 2:51 PM · Frameworks
graesslin created D5520: [platforms/x11] Do not grab touch events.
Thu, Apr 20, 5:13 AM · KWin
graesslin added a comment to D4893: Layout and animations on the on screen keyboard.

I fear this change caused regressions. I now don't have the virtual keyboard button on the layout anymore (X11 and Wayland) and on Wayland it's impossible to unlock the screen.

Thu, Apr 20, 5:08 AM · Plasma

Wed, Apr 19

graesslin committed R133:5e3c7b337c95: Use seccomp for implementing a sandbox for kscreenlocker_greet (authored by graesslin).
Use seccomp for implementing a sandbox for kscreenlocker_greet
Wed, Apr 19, 3:43 PM
graesslin closed D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet by committing R133:5e3c7b337c95: Use seccomp for implementing a sandbox for kscreenlocker_greet.
Wed, Apr 19, 3:43 PM · Plasma
graesslin committed R133:07d38ba65adc: Support for long running kcheckpass supporting multiple authentications (authored by graesslin).
Support for long running kcheckpass supporting multiple authentications
Wed, Apr 19, 3:43 PM
graesslin committed R133:d666fe879d46: [greeter] Send the auth result through the server instead return value (authored by graesslin).
[greeter] Send the auth result through the server instead return value
Wed, Apr 19, 3:43 PM
graesslin closed D4997: Support for long running kcheckpass supporting multiple authentications by committing R133:07d38ba65adc: Support for long running kcheckpass supporting multiple authentications.
Wed, Apr 19, 3:43 PM · Plasma
graesslin closed D4806: [greeter] Send the auth result through the server instead return value by committing R133:d666fe879d46: [greeter] Send the auth result through the server instead return value.
Wed, Apr 19, 3:43 PM · Plasma
graesslin added a comment to D5503: No "KDE Daemon" in password dialogs.

not that "KDE Daemon" is a good name, but what about i18n it?

Wed, Apr 19, 3:27 PM · Frameworks

Tue, Apr 18

graesslin accepted D5179: [DRM plugin] Reorganize DrmBuffer.
Tue, Apr 18, 6:55 PM · KWin
graesslin accepted D4026: [platforms/drm] Subclass DrmBuffer and fix cleanup after page flip.
Tue, Apr 18, 6:54 PM · KWin
graesslin created D5488: Improve the escape key handling for breaking constrained pointers.
Tue, Apr 18, 5:15 AM · KWin

Mon, Apr 17

graesslin closed D5164: fix occassional crash caused by needlessly delayed signals (bko#363224).
Mon, Apr 17, 7:33 AM · KWin

Sat, Apr 15

graesslin updated the diff for D5461: Don't update the focused pointer Surface if a button is pressed.

Use range-based for loop with qAsConst

Sat, Apr 15, 4:08 PM · Plasma
graesslin added a comment to D5464: Nextcloud Upload Purpose Plugin.

neat :-) Looking forward to use it

Sat, Apr 15, 3:42 PM · Plasma
graesslin updated subscribers of D5461: Don't update the focused pointer Surface if a button is pressed.
Sat, Apr 15, 3:23 PM · Plasma
graesslin created D5462: [effects/slideback] Consider windows which do have painting disabled as not usable.
Sat, Apr 15, 10:02 AM · KWin
graesslin created D5461: Don't update the focused pointer Surface if a button is pressed.
Sat, Apr 15, 9:42 AM · Plasma
graesslin committed R108:2132b1e0c829: [effects] Use arg="true" in the kcfg files (authored by graesslin).
[effects] Use arg="true" in the kcfg files
Sat, Apr 15, 8:08 AM
graesslin closed D3571: [effects] Use arg="true" in the kcfg files by committing R108:2132b1e0c829: [effects] Use arg="true" in the kcfg files.
Sat, Apr 15, 8:08 AM · KWin

Fri, Apr 14

graesslin created D5452: Handle modifier updates in the same sequence as Wayland does.
Fri, Apr 14, 7:08 PM · KWin

Thu, Apr 13

graesslin created D5438: [plugins/qpa] Do not replace a valid FBO with an invalid one.
Thu, Apr 13, 7:32 PM · KWin
graesslin updated the diff for D5421: Do not handle ScreenEdges::check for Edges which don't activate for Pointer.

Fixing arc mess

Thu, Apr 13, 7:30 PM · KWin
graesslin updated the diff for D5421: Do not handle ScreenEdges::check for Edges which don't activate for Pointer.
  • [plugins/qpa] Do not replace a valid FBO with an invalid one
Thu, Apr 13, 7:29 PM · KWin
graesslin added a comment to D5405: Create desktop file name based on organization domain unless set explicitely.

Ok, so let us not change kcoreaddons now although it's still something that could have better default behaviour in KF6.

Thu, Apr 13, 5:13 AM · Frameworks, Plasma on Wayland
graesslin created D5421: Do not handle ScreenEdges::check for Edges which don't activate for Pointer.
Thu, Apr 13, 5:10 AM · KWin

Wed, Apr 12

graesslin added a comment to D5405: Create desktop file name based on organization domain unless set explicitely.

The desktop file name should follow the way how the dbus name is created. If the applications are broken, then they are broken. Given that I mentioned this several times at KDE conferences, blogged about it, sent mails to KDE devel lists I assume the application maintainers don't care whether their applications work on Wayland. Which is totally fine. Then let them stay broken.

When you talk about "desktop file name", do you mean the method desktopFileName() in KAboutData, or the real file name of the desktop file?

Here I meant the method in Kaboutdata.

Also: I did not maintain an application back then and I missed those notifications. Could you please link at least one reference to the explanation (or which Akademy)? I will get the others from that.

https://blog.martin-graesslin.com/blog/2015/07/porting-qt-applications-to-wayland/

Thanks. I guess it's the section "Setting window icon", but:

  • there are no references to D-Bus, which you referred to in the previous comment (not also in the rest of the page in this context);
Wed, Apr 12, 7:53 PM · Frameworks, Plasma on Wayland
graesslin added a comment to D5405: Create desktop file name based on organization domain unless set explicitely.

The desktop file name should follow the way how the dbus name is created. If the applications are broken, then they are broken. Given that I mentioned this several times at KDE conferences, blogged about it, sent mails to KDE devel lists I assume the application maintainers don't care whether their applications work on Wayland. Which is totally fine. Then let them stay broken.

When you talk about "desktop file name", do you mean the method desktopFileName() in KAboutData, or the real file name of the desktop file?

Wed, Apr 12, 7:27 PM · Frameworks, Plasma on Wayland
graesslin committed R120:ea9489f32a6c: [lnf] Honor the new noModifierGrab in TabBox (authored by graesslin).
[lnf] Honor the new noModifierGrab in TabBox
Wed, Apr 12, 5:48 PM
graesslin closed D5415: [lnf] Honor the new noModifierGrab in TabBox by committing R120:ea9489f32a6c: [lnf] Honor the new noModifierGrab in TabBox.
Wed, Apr 12, 5:48 PM · Plasma
graesslin committed R108:259e373bfc93: [tabbox] Expose noModifierGrab to QtQuick (authored by graesslin).
[tabbox] Expose noModifierGrab to QtQuick
Wed, Apr 12, 5:47 PM
graesslin closed D5414: [tabbox] Expose noModifierGrab to QtQuick by committing R108:259e373bfc93: [tabbox] Expose noModifierGrab to QtQuick.
Wed, Apr 12, 5:47 PM · KWin
graesslin added a comment to D5405: Create desktop file name based on organization domain unless set explicitely.

The desktop file name should follow the way how the dbus name is created. If the applications are broken, then they are broken. Given that I mentioned this several times at KDE conferences, blogged about it, sent mails to KDE devel lists I assume the application maintainers don't care whether their applications work on Wayland. Which is totally fine. Then let them stay broken.

Wed, Apr 12, 5:44 PM · Frameworks, Plasma on Wayland
graesslin added a dependency for D5415: [lnf] Honor the new noModifierGrab in TabBox: D5414: [tabbox] Expose noModifierGrab to QtQuick.
Wed, Apr 12, 4:21 PM · Plasma
graesslin added a dependent revision for D5414: [tabbox] Expose noModifierGrab to QtQuick: D5415: [lnf] Honor the new noModifierGrab in TabBox.
Wed, Apr 12, 4:21 PM · KWin
graesslin created D5415: [lnf] Honor the new noModifierGrab in TabBox.
Wed, Apr 12, 4:21 PM · Plasma
graesslin created D5414: [tabbox] Expose noModifierGrab to QtQuick.
Wed, Apr 12, 4:18 PM · KWin
graesslin added inline comments to D5249: [RFC] New effect plugin - projector (keystone) correction.
Wed, Apr 12, 5:12 AM · Plasma

Tue, Apr 11

graesslin added a reviewer for D5403: Support blocking of screen edges on active fullscreen windows also for touch: leinir.
Tue, Apr 11, 7:01 PM · KWin
graesslin created D5403: Support blocking of screen edges on active fullscreen windows also for touch.
Tue, Apr 11, 7:01 PM · KWin
graesslin committed R108:3259d5e11326: Cancel popup if the user clicked window decoration of parent window (authored by graesslin).
Cancel popup if the user clicked window decoration of parent window
Tue, Apr 11, 6:22 PM
graesslin closed D5388: Cancel popup if the user clicked window decoration of parent window by committing R108:3259d5e11326: Cancel popup if the user clicked window decoration of parent window.
Tue, Apr 11, 6:22 PM · KWin
graesslin accepted D5401: Fix KWin decoration KCM showing correct index at startup.
Tue, Apr 11, 5:59 PM · KWin

Mon, Apr 10

graesslin committed R108:fea1986ed936: Merge branch 'Plasma/5.9' (authored by graesslin).
Merge branch 'Plasma/5.9'
Mon, Apr 10, 7:22 PM
graesslin committed R108:1d9e7c120fef: Merge branch 'Plasma/5.8' into Plasma/5.9 (authored by graesslin).
Merge branch 'Plasma/5.8' into Plasma/5.9
Mon, Apr 10, 7:21 PM
graesslin committed R108:c8cd474acd0c: [platforms/drm] Explicitly request event context version 2 (authored by graesslin).
[platforms/drm] Explicitly request event context version 2
Mon, Apr 10, 7:19 PM
graesslin closed T5839: libdrm 2.4.78 breaks KWin event handling as "Resolved" by committing R108:c8cd474acd0c: [platforms/drm] Explicitly request event context version 2.
Mon, Apr 10, 7:19 PM · KWin
graesslin closed D5380: [platforms/drm] Explicitly request event context version 2 by committing R108:c8cd474acd0c: [platforms/drm] Explicitly request event context version 2.
Mon, Apr 10, 7:19 PM · KWin
graesslin created D5388: Cancel popup if the user clicked window decoration of parent window.
Mon, Apr 10, 4:21 PM · KWin
graesslin created D5380: [platforms/drm] Explicitly request event context version 2.
Mon, Apr 10, 4:57 AM · KWin
graesslin added a revision to T5839: libdrm 2.4.78 breaks KWin event handling: D5380: [platforms/drm] Explicitly request event context version 2.
Mon, Apr 10, 4:57 AM · KWin
graesslin moved T5839: libdrm 2.4.78 breaks KWin event handling from Backlog to Under Review on the KWin board.
Mon, Apr 10, 4:57 AM · KWin

Sun, Apr 9

graesslin added a dependency for D5365: Add support for keyboard layout switching policy "winclass": D5315: Add support for keyboard layout switching policy "window".
Sun, Apr 9, 4:06 PM · Plasma
graesslin added a dependent revision for D5315: Add support for keyboard layout switching policy "window": D5365: Add support for keyboard layout switching policy "winclass".
Sun, Apr 9, 4:06 PM · Plasma
graesslin created D5365: Add support for keyboard layout switching policy "winclass".
Sun, Apr 9, 4:02 PM · Plasma
graesslin updated the diff for D5301: Introduce support for keyboard layout switching policies.

QMap -> QHash as ordering pointers doesn't make any sense

Sun, Apr 9, 9:09 AM · Plasma

Sat, Apr 8

graesslin committed R108:5ad6452ddd89: [kcmkwin] Fix saving of TouchScreen actions (authored by graesslin).
[kcmkwin] Fix saving of TouchScreen actions
Sat, Apr 8, 8:57 AM

Fri, Apr 7

graesslin moved T5223: Support for popup windows from Under Review to Done on the Plasma on Wayland board.
Fri, Apr 7, 2:26 PM · KWin, Plasma on Wayland
graesslin moved T5223: Support for popup windows from Under Review to Done on the KWin board.
Fri, Apr 7, 2:25 PM · KWin, Plasma on Wayland
graesslin moved T5756: New config module for touch screen actions from Under Review to Done on the KWin board.
Fri, Apr 7, 2:25 PM · KWin
graesslin moved T5755: Dedicated touch screen edge actions from Work In Progress to Done on the KWin board.
Fri, Apr 7, 2:25 PM · KWin
graesslin committed R108:1648844005d1: [kcmkwin] Add a new config module for touch screen gestures (authored by graesslin).
[kcmkwin] Add a new config module for touch screen gestures
Fri, Apr 7, 2:25 PM