graesslin (Martin Flöser)
KWin maintainer

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 8:19 AM (149 w, 3 h)
Availability
Available

Recent Activity

Yesterday

graesslin requested changes to D10762: Fix the build on armhf/aarch64.
Fri, Feb 23, 4:33 PM · KWin

Thu, Feb 22

Restricted Application edited projects for D10750: wayland: Add support for zwp_linux_dmabuf, added: KWin; removed Plasma.

Concerning the tests: the ones requiring OpenGL work best if module vgem is loaded. That normally makes them pass. The tests regarding keyboard layout need env variable XDG_DEFAULT_LAYOUT being unset or on us.

Thu, Feb 22, 6:58 PM · KWin
graesslin requested changes to D10731: Fix the quick tiling of maximized windows.

The quick tiling functionality is fully covered by unit tests. Please add a test case exposing the problem.

Thu, Feb 22, 5:51 AM · KWin

Wed, Feb 21

graesslin added a comment to D10081: Don't assert if used incorrectly from dbus.

ping

Wed, Feb 21, 5:11 PM · Frameworks
Restricted Application edited projects for D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed, added: Plasma; removed Plasma on Wayland.

ping

Wed, Feb 21, 5:11 PM · Plasma, Frameworks
Restricted Application edited projects for D10235: [server] Add support for the frame semantics of Pointer version 5, added: Plasma on Wayland; removed Plasma.

ping

Wed, Feb 21, 5:10 PM · Plasma on Wayland, Frameworks
Restricted Application edited projects for D10440: Support modifier mouse/scroll action on internal decorated windows, added: KWin; removed Plasma.

ping

Wed, Feb 21, 5:10 PM · KWin
Restricted Application edited projects for D10549: Don't crash if the cursor theme fails to create, added: KWin; removed Plasma.

ping

Wed, Feb 21, 5:10 PM · Plasma
Restricted Application edited projects for D10291: Add a recursion blocker in Pointer/TouchInputRedirection::update, added: KWin; removed Plasma.

ping

Wed, Feb 21, 5:09 PM · KWin
Restricted Application edited projects for D10294: Init the icon in ShellClient::init, added: KWin; removed Plasma.

ping

Wed, Feb 21, 5:09 PM · Plasma
Restricted Application edited projects for D10308: Send hoverLeave or hoverMotion after touch up on decoration, added: Plasma; removed KWin.

ping

Wed, Feb 21, 5:08 PM · Plasma
Restricted Application edited projects for D10490: Add a method to dbus interface to query information about a window, added: KWin; removed Plasma.

ping

Wed, Feb 21, 5:08 PM · Plasma
graesslin committed R108:a0c91c6e19fe: Merge branch 'Plasma/5.12' (authored by graesslin).
Merge branch 'Plasma/5.12'
Wed, Feb 21, 5:08 PM
graesslin committed R108:7bf4a94286a7: Disable window rule configuration for Wayland (authored by graesslin).
Disable window rule configuration for Wayland
Wed, Feb 21, 5:07 PM
graesslin committed R108:338c7362c9fb: Properly handle move during touch events (authored by graesslin).
Properly handle move during touch events
Wed, Feb 21, 5:07 PM
graesslin closed D10594: Disable window rule configuration for Wayland.
Wed, Feb 21, 5:07 PM · Plasma
graesslin closed D10431: Properly handle move during touch events.
Wed, Feb 21, 5:07 PM · Plasma

Tue, Feb 20

Restricted Application edited projects for D10594: Disable window rule configuration for Wayland, added: KWin; removed Plasma.
In D10594#209972, @mart wrote:

window rules is a feature which would "just" require the kcm reimplementation or as a principle is something which can't work on wayland?

Tue, Feb 20, 6:56 PM · Plasma
Restricted Application edited projects for D10490: Add a method to dbus interface to query information about a window, added: Plasma; removed KWin.
Tue, Feb 20, 6:56 PM · Plasma

Mon, Feb 19

graesslin committed R108:0886051622bc: [autotests] Add test case for decoration default mode (authored by graesslin).
[autotests] Add test case for decoration default mode
Mon, Feb 19, 9:11 PM
graesslin updated the diff for D10642: [kcmkwin/rules] Disable detect button on Wayland.

Hide buttons intead of disabling them

Mon, Feb 19, 4:47 PM · KWin
Restricted Application edited projects for D10642: [kcmkwin/rules] Disable detect button on Wayland, added: Plasma; removed KWin.

Tooltip is not possible, we are in string freeze. I can of course hide the button, but then users might be wondering where it has gone. Given that I doubt it makes much difference.

Mon, Feb 19, 5:29 AM · KWin

Sun, Feb 18

graesslin requested review of D10642: [kcmkwin/rules] Disable detect button on Wayland.
Sun, Feb 18, 5:06 PM · KWin

Fri, Feb 16

graesslin requested review of D10594: Disable window rule configuration for Wayland.
Fri, Feb 16, 7:59 PM · Plasma
Restricted Application edited projects for D10490: Add a method to dbus interface to query information about a window, added: KWin; removed Plasma.
Fri, Feb 16, 5:54 AM · Plasma
graesslin updated the diff for D10490: Add a method to dbus interface to query information about a window.

Remove unneeded comment

Fri, Feb 16, 5:53 AM · Plasma

Thu, Feb 15

graesslin requested review of D10549: Don't crash if the cursor theme fails to create.
Thu, Feb 15, 5:08 PM · Plasma
graesslin accepted D9638: [effects] replace old slide effect with a new one.
Thu, Feb 15, 4:50 PM · Plasma
graesslin accepted D10346: check for EGL_KHR_platform_gbm extension as well.
Thu, Feb 15, 4:48 PM · Plasma

Wed, Feb 14

graesslin added a comment to D3829: [touchpad] Use a separate X11 Display to monitor the XInput event..

@graesslin, does this still need changes to be merge-worthy?

Wed, Feb 14, 5:34 AM · Plasma
Restricted Application edited projects for D10490: Add a method to dbus interface to query information about a window, added: KWin; removed Plasma.
Wed, Feb 14, 5:30 AM · Plasma
graesslin added a comment to D10495: Workaround to restore KF5 programs from system tray.

This is more to start some discussion on system tray under Wayland. I'm not sure myself if this should be committed. I just use this workaround locally until winId() works on Wayland.

Wed, Feb 14, 5:26 AM · Frameworks, Plasma

Tue, Feb 13

graesslin requested review of D10490: Add a method to dbus interface to query information about a window.
Tue, Feb 13, 7:29 PM · Plasma

Sun, Feb 11

graesslin committed R108:a0aef86a7493: Add test case for force opacity rules on ShellClient (authored by graesslin).
Add test case for force opacity rules on ShellClient
Sun, Feb 11, 5:30 PM
graesslin requested review of D10440: Support modifier mouse/scroll action on internal decorated windows.
Sun, Feb 11, 9:51 AM · KWin
graesslin accepted D10425: Improve appearance of the logout dialog on wayland.
Sun, Feb 11, 7:49 AM · Plasma

Sat, Feb 10

graesslin requested review of D10431: Properly handle move during touch events.
Sat, Feb 10, 8:05 PM · Plasma
graesslin added a comment to D10425: Improve appearance of the logout dialog on wayland.

I'm against this change. The window is set to fullscreen, but that doesn't work due to a Qt bug.

Is the referenced patch enough to make it work? AFAICT it would also need a change in kwaylandintegration for the decoration.

Sat, Feb 10, 7:49 PM · Plasma
graesslin committed R108:137b954add81: Remove remaining HAVE_INPUT ifdef sections (authored by graesslin).
Remove remaining HAVE_INPUT ifdef sections
Sat, Feb 10, 7:37 PM
graesslin requested changes to D10425: Improve appearance of the logout dialog on wayland.

I'm against this change. The window is set to fullscreen, but that doesn't work due to a Qt bug. Let's not work around Qt bugs: https://bugreports.qt.io/browse/QTBUG-63748

Sat, Feb 10, 4:24 PM · Plasma

Fri, Feb 9

graesslin committed R108:6e5f5d92daab: Add KF5::WaylandServer to include the required directories (authored by bkchr).
Add KF5::WaylandServer to include the required directories
Fri, Feb 9, 8:04 PM
graesslin closed D10373: Add KF5::WaylandServer to include the required directories.
Fri, Feb 9, 8:04 PM · KWin

Thu, Feb 8

graesslin accepted D10393: Simplify compositing setup code.
Thu, Feb 8, 7:23 PM · KWin
graesslin committed R102:9482d45fedcb: Merge branch 'Plasma/5.12' (authored by graesslin).
Merge branch 'Plasma/5.12'
Thu, Feb 8, 6:18 PM
graesslin committed R102:a7e887975d01: Ensure Registry gets destroyed before the Wayland connection (authored by graesslin).
Ensure Registry gets destroyed before the Wayland connection
Thu, Feb 8, 6:18 PM
graesslin closed D10391: Ensure Registry gets destroyed before the Wayland connection.
Thu, Feb 8, 6:18 PM · Plasma
graesslin requested changes to D10346: check for EGL_KHR_platform_gbm extension as well.
Thu, Feb 8, 6:17 PM · Plasma
graesslin requested review of D10391: Ensure Registry gets destroyed before the Wayland connection.
Thu, Feb 8, 5:59 PM · Plasma
graesslin removed a reviewer for D10297: Add new "Tools" button above System Monitor's process list: floeser.
Thu, Feb 8, 4:32 PM · Plasma
graesslin accepted D10373: Add KF5::WaylandServer to include the required directories.
Thu, Feb 8, 4:01 PM · KWin

Wed, Feb 7

graesslin committed R108:7a3627fc2b7f: Merge branch 'Plasma/5.12' (authored by graesslin).
Merge branch 'Plasma/5.12'
Wed, Feb 7, 6:45 PM
graesslin committed R108:8245a74b31dc: Make it possible to compile 5.12 branch with a kdecoration from master (authored by graesslin).
Make it possible to compile 5.12 branch with a kdecoration from master
Wed, Feb 7, 6:44 PM
graesslin closed D10296: Make it possible to compile 5.12 branch with a kdecoration from master.
Wed, Feb 7, 6:44 PM · Plasma
Restricted Application edited projects for D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed, added: Plasma on Wayland; removed Plasma.

ping

Wed, Feb 7, 6:43 PM · Plasma, Frameworks
graesslin committed R127:d38825d934e4: [server] Don't crash when a subsurface gets commited whose parent surface got… (authored by graesslin).
[server] Don't crash when a subsurface gets commited whose parent surface got…
Wed, Feb 7, 6:42 PM
graesslin closed D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed.
Wed, Feb 7, 6:42 PM · Plasma, Frameworks
Restricted Application edited projects for D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed, added: Plasma on Wayland; removed Plasma.

Ping? Why this has not been committed even if in "accepted" state?

Wed, Feb 7, 4:26 PM · Plasma, Frameworks

Tue, Feb 6

graesslin added a comment to D10197: Fix krunner's alt+f2 on wayland.

To ensure we don't forget about it I created: https://bugs.kde.org/show_bug.cgi?id=389964

Tue, Feb 6, 6:11 PM · Plasma
graesslin added a comment to D10197: Fix krunner's alt+f2 on wayland.

As the commit went into the 5.12 branch we cannot build up on any functionality not yet available in Dialog.

Tue, Feb 6, 4:51 PM · Plasma
graesslin added a comment to D10197: Fix krunner's alt+f2 on wayland.

I really think this needs to be reverted. Krunner must be a dock, it must be set to windows go below and it must take focus. This is all functionality not provided by Plasma::Dialog. Just removing the code doesn't work unfortunately.

Tue, Feb 6, 4:29 PM · Plasma
graesslin added a comment to D10337: First approach to a plasmoid that can display the state of caps lock.
In D10337#202007, @apol wrote:

Please be aware that this will not work on Wayland. The modifier state is only available to the window which currently has keyboard focus. We either need a dedicated Wayland protocol to send all modifier changes to Plasma or some other way to have KWin feed in the state.

Anyway: I would recommend to make it only available for platform xcb right now.

Note this is using a Plasma Data Engine that is used by several plasmoids and components throughout plasma. In turn, we should make sure that if the data engine doesn't have any data, it doesn't work.
Or have the data engine work on Wayland.

Tue, Feb 6, 4:10 PM · Plasma
graesslin added a comment to D10334: RFC: Make KRunner a Dock window.
In D10334#201879, @apol wrote:

There is the panel behavior thing missing which used to be in the old code. A panel does not get keyboard focus. With the panel behavior that can be changed.

The old code was un-usably broken, please provide a patch yourself then.

Tue, Feb 6, 4:01 PM · Plasma
graesslin added a comment to D10337: First approach to a plasmoid that can display the state of caps lock.

Please be aware that this will not work on Wayland. The modifier state is only available to the window which currently has keyboard focus. We either need a dedicated Wayland protocol to send all modifier changes to Plasma or some other way to have KWin feed in the state.

Tue, Feb 6, 3:57 PM · Plasma
graesslin added a comment to D9207: Don't load KDE platform module in kglobalaccel5.
In D9207#201848, @hein wrote:

Well, the maintainer spoke out against it, so not much I can do.

Tue, Feb 6, 3:53 PM · Frameworks, Plasma
graesslin added a comment to D10334: RFC: Make KRunner a Dock window.

There is the panel behavior thing missing which used to be in the old code. A panel does not get keyboard focus. With the panel behavior that can be changed.

Tue, Feb 6, 5:27 AM · Plasma
graesslin added a comment to D10197: Fix krunner's alt+f2 on wayland.
In D10197#201733, @apol wrote:

I fear this broke some functionality of KRunner. It is important to be a dock window! Otherwise KRunner might not be able to go above fullscreen windows and won't be on all desktops. Also without being a PlasmaSurface the manual positioning cannot work. If it works for you, I fear it is pure chance.

Please read before freaking out. As David pointed out the surface code is already part of its parent class.

Tue, Feb 6, 5:25 AM · Plasma

Mon, Feb 5

graesslin committed R108:477d79b16aa6: Merge branch 'Plasma/5.12' (authored by graesslin).
Merge branch 'Plasma/5.12'
Mon, Feb 5, 8:22 PM
graesslin committed R108:ea5e70116456: [x11] Fix interactive point selection (authored by graesslin).
[x11] Fix interactive point selection
Mon, Feb 5, 8:22 PM
graesslin closed D10302: [x11] Fix interactive point selection.
Mon, Feb 5, 8:22 PM · Plasma
graesslin added a comment to D10314: Use F11 as the shortcut to toggle the aside preview.

Yeah, and Dolphin already overloads that by using F11 to show and hide the Information panel. I wouldn't object to using a different keyboard shortcut, but then we'd want to but we'd want to do it for all of for Dolphin's panels, and change the shortcuts here, too, which currently match Dolphin's.

Mon, Feb 5, 5:04 PM · Frameworks
graesslin added a comment to D10314: Use F11 as the shortcut to toggle the aside preview.

I'm a little bit late to the party, but F11is kind of the standard key for fullscreen.

Mon, Feb 5, 4:46 PM · Frameworks

Sun, Feb 4

graesslin added a reviewer for D10308: Send hoverLeave or hoverMotion after touch up on decoration: ngraham.
Sun, Feb 4, 8:27 PM · Plasma
Restricted Application edited projects for D10308: Send hoverLeave or hoverMotion after touch up on decoration, added: Plasma; removed KWin.
Sun, Feb 4, 8:24 PM · Plasma
Restricted Application edited projects for D10302: [x11] Fix interactive point selection, added: Plasma; removed KWin.
Sun, Feb 4, 5:05 PM · Plasma
Restricted Application edited projects for D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed, added: Plasma; removed Plasma on Wayland.
Sun, Feb 4, 4:00 PM · Plasma, Frameworks
Restricted Application edited projects for D10296: Make it possible to compile 5.12 branch with a kdecoration from master, added: Plasma; removed KWin.
Sun, Feb 4, 2:36 PM · Plasma
graesslin committed R108:bbf00fdd9808: Require libinput and udev (authored by graesslin).
Require libinput and udev
Sun, Feb 4, 2:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Sun, Feb 4, 2:07 PM · KWin
graesslin committed R108:45bdd8a3421a: Merge branch 'Plasma/5.12' (authored by graesslin).
Merge branch 'Plasma/5.12'
Sun, Feb 4, 2:07 PM
graesslin closed D10156: Block geometry updates on move resize finish and don't configure xdg shell surfaces while blocked.
Sun, Feb 4, 2:02 PM · KWin
graesslin committed R108:aefa11f11a25: Block geometry updates on move resize finish and don't configure xdg shell… (authored by graesslin).
Block geometry updates on move resize finish and don't configure xdg shell…
Sun, Feb 4, 2:02 PM
graesslin committed R108:e22d9d957b12: Enable blending if a subsurface has an alpha channel (authored by graesslin).
Enable blending if a subsurface has an alpha channel
Sun, Feb 4, 2:02 PM
graesslin closed D10060: Enable blending if a subsurface has an alpha channel.
Sun, Feb 4, 2:02 PM · Plasma
Restricted Application edited projects for D10294: Init the icon in ShellClient::init, added: Plasma; removed KWin.
Sun, Feb 4, 1:21 PM · Plasma
Restricted Application edited projects for D10291: Add a recursion blocker in Pointer/TouchInputRedirection::update, added: Plasma; removed KWin.
Sun, Feb 4, 12:39 PM · KWin
graesslin reopened D10197: Fix krunner's alt+f2 on wayland.

I just verified with KWin's debug console: KRunner window is now marked as NET::Normal and not as NET::Dock. This is a problem, KRunner needs to be a dock.

Sun, Feb 4, 9:04 AM · Plasma
graesslin added a comment to D10197: Fix krunner's alt+f2 on wayland.

I fear this broke some functionality of KRunner. It is important to be a dock window! Otherwise KRunner might not be able to go above fullscreen windows and won't be on all desktops. Also without being a PlasmaSurface the manual positioning cannot work. If it works for you, I fear it is pure chance.

Sun, Feb 4, 8:01 AM · Plasma

Sat, Feb 3

graesslin committed R108:dca80232070b: Merge branch 'Plasma/5.12' (authored by graesslin).
Merge branch 'Plasma/5.12'
Sat, Feb 3, 3:04 PM
graesslin committed R108:6c00cfb5c75d: [libinput] Ensure Event::device returns a proper Device (authored by graesslin).
[libinput] Ensure Event::device returns a proper Device
Sat, Feb 3, 3:03 PM
graesslin closed D10236: [libinput] Ensure Event::device returns a proper Device.
Sat, Feb 3, 3:03 PM · Plasma
Restricted Application edited projects for D10236: [libinput] Ensure Event::device returns a proper Device, added: KWin; removed Plasma.

I'm actually in favor of a tar respin for 5.12.0 in this case. What do you think?

Sat, Feb 3, 2:01 PM · Plasma
graesslin added inline comments to D5932: KCM for controlling Night Color.
Sat, Feb 3, 2:00 PM · Plasma

Fri, Feb 2

graesslin updated the diff for D10236: [libinput] Ensure Event::device returns a proper Device.

Make m_device mutable and always lazy load it.

Fri, Feb 2, 5:52 AM · Plasma

Thu, Feb 1

Restricted Application edited projects for D10236: [libinput] Ensure Event::device returns a proper Device, added: Plasma; removed KWin.

Now you can remove the initial setting of m_device as well.

Thu, Feb 1, 7:07 PM · Plasma
Restricted Application edited projects for D10057: Require libinput and udev, added: Plasma; removed KWin.

If nobody objects by Sunday I'm going to push this.

Thu, Feb 1, 5:18 PM · KWin
Restricted Application edited projects for D10234: LibInput: Queue native libinput events instead of LibInput::Event, added: KWin; removed Plasma.

alternative approach in D10236

Thu, Feb 1, 5:06 PM · KWin
Restricted Application edited projects for D10236: [libinput] Ensure Event::device returns a proper Device, added: Plasma; removed KWin.
Thu, Feb 1, 5:06 PM · Plasma
Restricted Application edited projects for D10235: [server] Add support for the frame semantics of Pointer version 5, added: Plasma; removed Plasma on Wayland.
Thu, Feb 1, 4:51 PM · Plasma on Wayland, Frameworks
Restricted Application edited projects for D10234: LibInput: Queue native libinput events instead of LibInput::Event, added: Plasma; removed KWin.

I had another idea: when the Event gets processed and the m_device is null, we just update it again from the event.

Something like

if (!event->device()) {
    event->updateDevice();
}

with

void Device::updateDevice()
{
    m_device = Device::getDevice(libinput_event_get_device(m_event);
}

I wouldn't do that manually, rather replace m_device references with a device() method and if m_device is nullptr, assign it lazily.

Thu, Feb 1, 4:39 PM · KWin
Restricted Application edited projects for D10234: LibInput: Queue native libinput events instead of LibInput::Event, added: Plasma; removed KWin.

I had another idea: when the Event gets processed and the m_device is null, we just update it again from the event.

Thu, Feb 1, 4:02 PM · KWin