graesslin (Martin Flöser)
KWin maintainer

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 8:19 AM (165 w, 3 d)
Availability
Available

Recent Activity

Mon, Jun 18

graesslin added a comment to D13481: Recommend window border size "None".

I realized that there's yet another problem with the approach: if two windows border and the window with pointer focus is lower in the stacking order this would create a dead zone in the window. With compositing disabled this would be worse as there's not even a visual hint.

Mon, Jun 18, 3:28 PM · Plasma

Sun, Jun 17

graesslin added a comment to D13567: Smaller steps for animation speed option.

We don't break users configuration. There is nothing which justifies that. For example: if the user configured a wallpaper the new wallpaper won't replace it. Only default values my be modified by updates. As soon as a user configured a setting it must not be changed. Users need to be able to trust their software.

Sun, Jun 17, 6:55 AM · KWin

Sat, Jun 16

graesslin added a comment to D13567: Smaller steps for animation speed option.

This would break configurations of users.

Also I don't think that such a change is needed as I already expressed in the bug report. It is possible to adjust the speed on a per effect level. I doubt that any user would benefit from a higher granularity.

If users' configuration is one of 0, 1, 2, 3, it won't change anything. If users' configuration is 4, 5 or 6. It only get slightly faster, nothing break.

Sat, Jun 16, 4:28 PM · KWin
graesslin added a comment to D13566: [effects/slide] Disable "Slide docks".

An advice: don't change the default based on the random feedback you get. If you change this I can promise you you will get the same amount of complaints after the next release.

Sat, Jun 16, 3:51 PM · KWin
graesslin requested changes to D13567: Smaller steps for animation speed option.

This would break configurations of users.

Sat, Jun 16, 3:44 PM · KWin
graesslin added a comment to D13530: Add XDG WmBase support.
In D13530#278467, @zzag wrote:

I disagree. comma at end is just bad style which is accepted by compilers.

by C++ standard. draft ;-)

Could you please explain why trailing commas are bad?

Sat, Jun 16, 5:51 AM · KWin

Thu, Jun 14

graesslin requested review of D13541: Port solid from Qt5::Widgets to Qt5::Gui.
Thu, Jun 14, 4:10 PM · Frameworks
graesslin added inline comments to D13530: Add XDG WmBase support.
Thu, Jun 14, 3:14 PM · KWin
graesslin added a comment to D13535: Do not cancel old clipboard selection if it is same as the new one..

I would appreciate a unit test for the issue.

Thu, Jun 14, 3:04 PM · Frameworks
graesslin added inline comments to D13492: Make keyboard focus a pointer constraints necessity.
Thu, Jun 14, 4:28 AM · KWin

Mon, Jun 11

graesslin added a comment to D13456: [wayland] Make it possible to reach screen edges.
In D13456#277137, @zzag wrote:

run "dbus-launch ./test-whatever"

I usually go to the build directory and run

bin/testWhateverIWantToTest
Mon, Jun 11, 7:30 PM · KWin
graesslin added a comment to D13456: [wayland] Make it possible to reach screen edges.

Great work. Could you please extend the unit test for this area. Did you run them? As this is a behavior change I could imagine that it breaks the existing tests.

Mon, Jun 11, 4:29 AM · KWin
graesslin added inline comments to D13466: Remove pointer constraint on resource unbind.
Mon, Jun 11, 4:25 AM · KWin

Sun, Jun 10

graesslin added a dependency for D13459: [RFC] Implement new window tab API in DecoratedClientImpl: D12997: Add new api to support window tabs.
Sun, Jun 10, 9:28 AM · KWin
graesslin added a dependent revision for D12997: Add new api to support window tabs: D13459: [RFC] Implement new window tab API in DecoratedClientImpl.
Sun, Jun 10, 9:28 AM · Plasma
graesslin requested review of D13459: [RFC] Implement new window tab API in DecoratedClientImpl.
Sun, Jun 10, 9:27 AM · KWin
graesslin committed R108:c86fdf4c5426: Merge branch 'Plasma/5.13' (authored by graesslin).
Merge branch 'Plasma/5.13'
Sun, Jun 10, 7:20 AM
graesslin committed R108:c44adda40f47: Hide decoration tooltip when the decoration gets destroyed (authored by graesslin).
Hide decoration tooltip when the decoration gets destroyed
Sun, Jun 10, 7:20 AM
graesslin closed D13299: Hide decoration tooltip when the decoration gets destroyed.
Sun, Jun 10, 7:20 AM · KWin

Thu, Jun 7

graesslin added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

Thanks David. I must be getting confused by the fact that right now, if a user switches to No Borders, there is indeed an extended resize area outside of the window's bounds (at least for me; do you not see this?). If this patch preserves it, than that's good.

Thu, Jun 7, 4:27 AM · KWin
graesslin accepted D13396: Set specific edge cursor shape when resizing.
Thu, Jun 7, 4:24 AM · KWin

Wed, Jun 6

graesslin added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

For breeze: yes, for Oxygen: no.

Wed, Jun 6, 4:48 PM · KWin
graesslin added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

That's a non-standard definition of the word accessibility.

Wed, Jun 6, 4:36 PM · KWin
graesslin added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

There's one more case where the no-border resize is problematic: when compositing is disabled. Then we don't have shadows so the resize handles would really indicate it's the other window.

Wed, Jun 6, 3:56 PM · KWin
graesslin added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

What I'm concerned about is accessibility. Accessibility in the case of users who learned that they need to hover over the border of a window. In case of an adjacent window they get the resize handle of the window, but it resizes the other window. This is totally unexpected and I wouldn't know how to explain this to my mother.

Wed, Jun 6, 4:33 AM · KWin

Tue, Jun 5

graesslin added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

Explaining why I prefer this approach over changing the default in KWin. It mostly comes from a rule for code changes: "it works together with all existing features" (see https://community.kde.org/KWin/Mission_Statement ). KWin ships one window decoration (Plastik as a QML Aurorae theme). As explained Aurorae does not support no (side) border as that doesn't match what Aurorae was designed for and is not possible to add without breaking the existing themes. Thus the change of the default conflicts with an existing feature in KWin and is thus not possible from the rules KWin has.

Tue, Jun 5, 7:02 PM · KWin
graesslin added a comment to D13353: [effects/minimizeanimation] Add more descriptive namespace comments.

Personal opinion: I think such comments like namespace or if after a closing braces don't add any useful information. If I need to know the scope the brace ends I use the editors functionality to highlight it.

Tue, Jun 5, 6:37 PM · KWin
graesslin accepted D13359: Remove Qt module declarations in includes.

Looks like there were quite a few surviving the script during qt5 porting.

Tue, Jun 5, 4:37 PM · KWin

Mon, Jun 4

graesslin added a comment to D13299: Hide decoration tooltip when the decoration gets destroyed.

Do you need the m_toolTipShowing variable at all? On destruct just always calling requestHideToolTip should be possible, not?

Mon, Jun 4, 3:04 PM · KWin

Sun, Jun 3

graesslin updated the diff for D13299: Hide decoration tooltip when the decoration gets destroyed.

Figured out why everything is crashing and could test now.

Sun, Jun 3, 5:28 PM · KWin
graesslin requested review of D13299: Hide decoration tooltip when the decoration gets destroyed.
Sun, Jun 3, 11:31 AM · KWin
graesslin added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

> To Martin, on the window rule: I know this is not the right place to discuss it, but still:

It would be really nice to have ! Right now both oxygen and breeze decorations implement "exceptions" which are essentially a crippled version of window rules. Moving the window border size out of this crippled version to the upstream and more feature complete version provided by window rules would be quite awesome.

Sun, Jun 3, 9:20 AM · KWin
graesslin added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

I like this approach. What I had as idea was to make border size a property of DecoratedClient and introduce a window specific rule. I haven't followed up on it as the vdg did not show any interest in me improving the code side of things.

Sun, Jun 3, 8:48 AM · KWin

Sat, Jun 2

graesslin requested changes to D13276: Display "No Borders" by default.

As indicated in the discussion on the task I'm against this change.

Sat, Jun 2, 6:08 AM · KWin

Fri, Jun 1

graesslin added a comment to T8707: Window borders.

Assuming we can live without rounded bottom corners, all we want to do here is change a user-facing default. That isn't a technical solution. It's a visual tweak that is absolutely under the purview of the VDG.

Fri, Jun 1, 7:42 PM · VDG
graesslin added a comment to D11781: Introduce generic Output class.

As you can see from the review comments I'm not too happy with the constant need of static_cast. To me that always looks wrong. If one needs to cast something is wrong in the design. I think this can be changed so that in the subclasses there is no need to static_cast or at least have the static_cast in a save way combined with static_asserts to make sure that it is save. The problem with static_cast is that further refactoring could break it really bad. It might still compile but fail at runtime. Just like a c-cast it kind of has a smell.

Fri, Jun 1, 7:15 PM · KWin
graesslin added a comment to T8707: Window borders.

We are not going to clip anything away from the windows. Sorry, but we cannot do that. It's in IMHO absolutely evil to clip away window content. If you want round borders follow the approach I outlined.

Fri, Jun 1, 3:42 PM · VDG

Thu, May 31

graesslin added a comment to D13155: [effects] Add Scale Out effect.

My comment was not a veto, it was meant as a different thought perspective.

Thu, May 31, 6:45 PM · KWin
graesslin requested review of D13235: [opengl] Drop functionality to start kcmshell compositing.
Thu, May 31, 12:05 PM · KWin
graesslin added a comment to D13155: [effects] Add Scale Out effect.

In general I'm against adding new effects to KWin and would rather prefer to remove effects such as scale in. I think everything which is not default should be on store.kde.org and not added to KWin directly.

Thu, May 31, 7:32 AM · KWin

Tue, May 29

graesslin accepted D13163: Honor BUILD_TESTING.
Tue, May 29, 4:50 PM · KWin

Sun, May 27

graesslin added a comment to D13153: WIP: [libkwineffects] Allow effects to grab windows.

What about moving this directly to Effect or AnimationEffect?

Sun, May 27, 4:42 PM · KWin

Thu, May 24

graesslin added a comment to D13084: Avoid invalid geometry of internal clients through plasma surface interface.

what does the test suite say about it? Are all tests still passing? Also do you think it's possible to create a test case for it? I think I tried in the past and didn't succeed.

Thu, May 24, 3:48 PM · KWin

Wed, May 23

graesslin accepted D13062: Don't manipulate foreign windows.

Please as bugfix to 5.12 branch.

Wed, May 23, 5:48 PM · Plasma
graesslin accepted D13071: [Klipper] Port away from KLineEdit.
Wed, May 23, 5:47 PM · Plasma
graesslin added a comment to T8707: Window borders.

OK, so if I understand you correctly, then if we move to client-side-decorated windows for 3rd party apps that currently do not implement their own titlebars and shadows, then they will have no titlebars and shadows. Correct?

Wed, May 23, 5:46 PM · VDG
graesslin added a comment to T8707: Window borders.

An example for how my proposal could look like:

Wed, May 23, 4:48 PM · VDG
graesslin added a comment to T8707: Window borders.

If we move 3rd-party apps to using CSDs per your proposal, Can the proposed window rules force a shadow and titlebars for them, in addition to forcing no borders?

If an application uses CSD, they don't get a decoration by KWin and thus also no title bar or shadow. That is the idea behind CSD.

So we can or cannot use KWin window rules to force CSD windows to have SSD shadows and titlebars?

Wed, May 23, 4:48 PM · VDG
graesslin added a comment to T8707: Window borders.

If we move 3rd-party apps to using CSDs per your proposal, Can the proposed window rules force a shadow and titlebars for them, in addition to forcing no borders?

Wed, May 23, 4:00 PM · VDG
graesslin added a comment to T8804: Add an On Screen Keyboard to Plasma (for X11).

Qt virtual keyboard is unfortunately unsuited on an X11 session.

Wed, May 23, 3:54 PM · Plasma Accessibility
graesslin accepted D13059: Only enable on XCB.
Wed, May 23, 3:49 PM · Plasma
graesslin added a comment to T8707: Window borders.

Sorry but I don't think you understood my proposal. My proposal requires changes in application - I mentioned kirigami as that is under our control. If we cannot change the code we need to look for a different solution. What I wrote is divide and conquer: find the correct solution for each class if application. The default for all applications would be no change. It's opt in. So no application would lose borders or shadows. As a fallback if applications cannot be patched, we can use window specific rules to enforce no side borders. This would work for everything except Elektron as Elektron is not icccm compliant.

Wed, May 23, 4:32 AM · VDG

Tue, May 22

graesslin added a comment to T8707: Window borders.

GTK apps that use CSDs don't have window shadows, and it looks bad. We get a neverending stream of complaints about this.

Tue, May 22, 8:01 PM · VDG
graesslin added a comment to D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced.

I wouldn't change plasmaquick based on KWin's behavior. KWin is weird after all. We should rather work around inside KWin.

Tue, May 22, 2:58 PM · Frameworks
graesslin accepted D11925: Add "SkipSwitcher" to API.

wonderful! Thanks to you two :-) And yes as soon as you push this change you can push the kwin change.

Tue, May 22, 2:56 PM · Frameworks
graesslin added a comment to T8707: Window borders.

Ok, great! Can you clarify whether or not your proposal:

  • Allows us to turn off KWin-drawn borders for all 3rd-party GTK/Electron/openGL/XUL/etc app windows?
Tue, May 22, 2:40 PM · VDG
graesslin added a comment to T8707: Window borders.

Does any part of your proposal add the risk that any windows which currently have nice shadows under Wayland or X11 would fail to request shadows and therefore get none?

Tue, May 22, 4:21 AM · VDG

Mon, May 21

graesslin added a comment to T8707: Window borders.

First on all about how to reach me: please don't expect me to hang around in telegram or irc to wait for anything design related touching my expertise. That's not possible, I just cannot monitor everything, my time is limited. Instead reach out to me or anybody else when you have something which requires my or anybody else feedback. Don't come up with technical solutions leave that to the technical experts, just like we technical experts should not come up with design solutions. I must say I found this process today frustrating and reading your answer I have a feeling that it was also very frustrating for you as well. I don't want to fight with you, we are in the same boat. But technical decisions should be done by those best understanding the technical area, for that you need to bring us into the boat quite early. I'm glad that I found this today by chance as if you would have opened a review for the change in KWin, I would have vetoed it.

Mon, May 21, 6:23 PM · VDG
graesslin added a comment to T8707: Window borders.

If I have not done that thoroughly enough, please feel free to refute my points and I'll respond accordingly.

Mon, May 21, 5:07 PM · VDG
graesslin added a comment to T8707: Window borders.

(Although it looks like Aurorae always renders at least 1 pixel for no border).

Mon, May 21, 4:49 PM · VDG
graesslin added a comment to T8707: Window borders.

I just looked through the list of aurorae themes I have installed and there are quite a few which visually break with no side borders. Please also think about the consequences for themes not being the default theme which you can influence. (Although it looks like Aurorae always renders at least 1 pixel for no border).

Mon, May 21, 4:45 PM · VDG
graesslin added a comment to T8707: Window borders.

I'll now provide some technical detail behind the dropdown and the options. This was never meant to be a designable option. If you compare kdecoration 1 and 2 you will notice that the decoration border size moved from being a per-deco to a global option. The main reason for this was that KWin considers the border size to be an accessibility feature which is so important that themes are not allowed to influence it. The decoration theme engine I wrote (Aurorae) provides a high level of customization to the theme designers, but borders sizes are not included. Exactly because it's an important accessibility feature.

Mon, May 21, 4:38 PM · VDG
graesslin committed R108:267b5a11222e: Disallow running KWin/Wayland as root (authored by graesslin).
Disallow running KWin/Wayland as root
Mon, May 21, 2:59 PM
graesslin closed D13008: Disallow running KWin/Wayland as root.
Mon, May 21, 2:59 PM · KWin
graesslin added a comment to T8707: Window borders.

As mentioned before, if we don't change this setting, then every Kirigami-based app we write looks ugly, as well as many 3rd-party apps, as pointed out above.

I outlined three possibilities to address this:

  • use the existing color scheme feature

Doesn't work when different elements on the page that want to touch the edge have different colors.

Mon, May 21, 2:42 PM · VDG
graesslin added a comment to T8707: Window borders.

The decoration border sizes are an accessibility feature. That's why they are designed as a KWin config property and not as a decoration/theme property. I know it, because I implemented it. Given that I disagree on that this is only a change affecting VDG, but a change which affects my technical expertise. I urge you to consider that I have experience of > 10 years on working with the decorations. Please don't just discard my feedback.

No one is belittling your experience. But your experience is not the law. I don't appreciate it when people work so hard on making a change that is widely supported, only to stumble on your experience to undo everything I am working on. I have more than 10 years of experience in visual design and I hope that you come to the side of evolution.

This idea of making borders an accessibility feature applies to people that need it. For them, we have the option to turn them on. However, you can't assume that 100% of people need this feature just because you have 10 years of experience. Allow this change.

Mon, May 21, 2:37 PM · VDG
graesslin added a comment to T8707: Window borders.

I propose that we move forward here:

  • Turn off side and bottom borders by default

I'm against such a radical change by default. This makes it impossible to resize the window.

I don't agree with this reasoning. The window is resized just fine with, or without borders.

That's what happens if you fast read. I read the comment that it would be impossible to resize.

But nevertheless I suggest to first experiment with some applications. The change is radical and users might have problems with the change. Not so experienced users might expect they need the borders to resize and taking them away by default could result in them not being able to resize the windows. Thus I suggest to first experiment with a few applications and wait for the feedback.

I hear a lot of "might" in the comments. I don't find this change "radical" at all. It is pretty much the norm across the industry.

Mon, May 21, 2:33 PM · VDG
graesslin added a comment to T8707: Window borders.

As mentioned before, if we don't change this setting, then every Kirigami-based app we write looks ugly, as well as many 3rd-party apps, as pointed out above.

Mon, May 21, 2:32 PM · VDG
graesslin added a comment to T8707: Window borders.

The decoration border sizes are an accessibility feature. That's why they are designed as a KWin config property and not as a decoration/theme property. I know it, because I implemented it. Given that I disagree on that this is only a change affecting VDG, but a change which affects my technical expertise. I urge you to consider that I have experience of > 10 years on working with the decorations. Please don't just discard my feedback.

Mon, May 21, 2:29 PM · VDG
graesslin added a comment to T8707: Window borders.

I propose that we move forward here:

  • Turn off side and bottom borders by default

I'm against such a radical change by default. This makes it impossible to resize the window.

I don't agree with this reasoning. The window is resized just fine with, or without borders.

Mon, May 21, 2:19 PM · VDG
graesslin added a comment to T8707: Window borders.

I propose that we move forward here:

  • Turn off side and bottom borders by default

I'm against such a radical change by default. This makes it impossible to resize the window.
Let's rather do this on an application case by case and experiment first with a few windows.

Mon, May 21, 1:57 PM · VDG
graesslin added a comment to T8707: Window borders.

Please note that every window can specify the color scheme for the decoration. I haven't seen this mentioned yet, but it might be an interesting aspect to consider.

Mon, May 21, 1:53 PM · VDG
graesslin added inline comments to D12820: Add KWayland virtual desktop protocol.
Mon, May 21, 1:47 PM · Frameworks
graesslin added a comment to D12795: Re-allow running Dolphin as the root user (but still not using sudo).

Actually I find it an interesting discussion going far further than Dolphin. If we can raise more awareness for security issues through such discussions, that's good. For example it just motivated D13008

In that patch, your reasoning for prohibiting running KWin as root is that "We cannot guarantee that running KWin as root is secure".

In the discussion here, you said of other software (including our own) that "new vulnerabilities are discovered each and every day". That means we can't guarantee security anywhere else either.

Ergo, by your reasoning, we should prohibit running all software because we can't guarantee that it's secure.

Mon, May 21, 8:37 AM · Dolphin
graesslin added a comment to D13008: Disallow running KWin/Wayland as root.

Why only main_wayland?

Mon, May 21, 8:20 AM · KWin

May 20 2018

graesslin added a comment to D12795: Re-allow running Dolphin as the root user (but still not using sudo).

The ideas of sandbox baloo_file_extractor are after all based on my sandboxing for kscreenlocker.

Then could you help review it, at least?

May 20 2018, 8:02 PM · Dolphin
graesslin requested review of D13008: Disallow running KWin/Wayland as root.
May 20 2018, 7:51 PM · KWin
graesslin added a comment to D12795: Re-allow running Dolphin as the root user (but still not using sudo).

You would also have to run a malicious application which is quite unlikely if you stick to vendor packages (but sure, there probably is a very small chance that a malicious package lands in the dist repository).

nope, sorry. The exploit I wrote would work through a drive-by download through an Internet browser. The world we live in sucks :-(

You've just completely ignored my valid use cases (which you asked for some comments earlier).

May 20 2018, 7:39 PM · Dolphin
graesslin added a comment to D12795: Re-allow running Dolphin as the root user (but still not using sudo).

Unfortunately drive-by downloads are a common thing for browsers. It does not have much to do with security fixes in browsers. It's more of a common thing.

On the contrary, drive-by-downloads are a major concern for browser vendors to fix. If someone reports one to them, they're //very motivated to fix it. Was the exploit that you used ever reported?

May 20 2018, 7:37 PM · Dolphin
graesslin added a comment to D12795: Re-allow running Dolphin as the root user (but still not using sudo).

For more information about Drive-by downloads see: https://en.wikipedia.org/wiki/Drive-by_download

May 20 2018, 7:19 PM · Dolphin
graesslin added a comment to D12795: Re-allow running Dolphin as the root user (but still not using sudo).

You would also have to run a malicious application which is quite unlikely if you stick to vendor packages (but sure, there probably is a very small chance that a malicious package lands in the dist repository).

nope, sorry. The exploit I wrote would work through a drive-by download through an Internet browser. The world we live in sucks :-(

Has the security hole in the web browser that allowed the exploit been fixed?

May 20 2018, 7:17 PM · Dolphin
graesslin added a comment to D12795: Re-allow running Dolphin as the root user (but still not using sudo).

You would also have to run a malicious application which is quite unlikely if you stick to vendor packages (but sure, there probably is a very small chance that a malicious package lands in the dist repository).

May 20 2018, 7:09 PM · Dolphin
graesslin added a comment to D12795: Re-allow running Dolphin as the root user (but still not using sudo).

I've deal with a lot of criticism in my time, Martin. But I have a thick enough skin to avoid taking it personally or letting it affect my judgment. If some jerks send hate mail, that is not a good reason to say "Now I really won't do it!" and punishing everyone else over it.

May 20 2018, 7:07 PM · Dolphin
graesslin added inline comments to D12795: Re-allow running Dolphin as the root user (but still not using sudo).
May 20 2018, 6:25 PM · Dolphin
graesslin committed R108:b19c3c1c8e52: Drop no longer needed cast to Client in TabGroup related code (authored by graesslin).
Drop no longer needed cast to Client in TabGroup related code
May 20 2018, 6:19 PM
graesslin committed R108:b6befb4ef88f: Use AbstractClient in UserActionsMenu for tab functionality (authored by graesslin).
Use AbstractClient in UserActionsMenu for tab functionality
May 20 2018, 6:19 PM
graesslin closed D12730: Port TabGroup from Client to AbstractClient.
May 20 2018, 6:19 PM · KWin
graesslin committed R108:46d8b87646cd: Move TabGroup functionality from Client to AbstractClient (authored by graesslin).
Move TabGroup functionality from Client to AbstractClient
May 20 2018, 6:19 PM
graesslin committed R108:7defd93047de: Port TabGroup from Client to AbstractClient (authored by graesslin).
Port TabGroup from Client to AbstractClient
May 20 2018, 6:19 PM
graesslin added a comment to D12795: Re-allow running Dolphin as the root user (but still not using sudo).
  • "You broke my workflow using sudo dolphin to edit root-owned files."
  • "You broke my use of a root GUI session in $DISTRO."
May 20 2018, 6:14 PM · Dolphin
graesslin added inline comments to D12795: Re-allow running Dolphin as the root user (but still not using sudo).
May 20 2018, 5:44 PM · Dolphin
graesslin accepted D9572: framebuffer: Attempt to set the framebuffer color layout on the framebuffer device.
May 20 2018, 5:28 PM · KWin
graesslin added a comment to D12732: Show a warning when running as the root user.

What you can do instead is starting a KMessageBox through an external process which drops back to the normal user. There inform the user about the risks, maybe with a link to a dedicated page on kde.org where we explain the attack on Dolphin through running as root. From within the message box one could provide a way to launch dolphin nevertheless as root (e.g. env variable I_KNOW_THAT_ROOT_CAN_BREAK_ME=1).

May 20 2018, 5:27 PM · Dolphin
graesslin added inline comments to D12795: Re-allow running Dolphin as the root user (but still not using sudo).
May 20 2018, 5:26 PM · Dolphin
graesslin added inline comments to D12795: Re-allow running Dolphin as the root user (but still not using sudo).
May 20 2018, 2:37 PM · Dolphin
graesslin committed R108:a02797ca0608: Use existing KSharedConfig in RuleBook::save (authored by graesslin).
Use existing KSharedConfig in RuleBook::save
May 20 2018, 2:08 PM
graesslin committed R108:32a715b0c94e: Merge branch 'Plasma/5.13' (authored by graesslin).
Merge branch 'Plasma/5.13'
May 20 2018, 2:08 PM
graesslin closed D12747: Use existing KSharedConfig in RuleBook::save.
May 20 2018, 2:08 PM · KWin
graesslin requested changes to D12732: Show a warning when running as the root user.

-2 from me. That is against our focus of providing secure software.

May 20 2018, 2:08 PM · Dolphin
graesslin added a comment to D11925: Add "SkipSwitcher" to API.

any update on this? It's just the version increase in registry.cpp which is missing...

May 20 2018, 1:58 PM · Frameworks