graesslin (Martin Flöser)
KWin maintainer

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 8:19 AM (127 w, 6 h)
Availability
Available

Recent Activity

Today

graesslin created T7054: Tests on FreeBSD fail due to ASAN, but debug symbols are missing.
Sat, Sep 23, 1:28 PM · FreeBSD, build.kde.org
graesslin committed R108:e74eacd27932: [autotests] Try making StartTest more robust on FreeBSD (authored by graesslin).
[autotests] Try making StartTest more robust on FreeBSD
Sat, Sep 23, 1:18 PM
graesslin committed R108:af20f1aa3572: Merge branch 'Plasma/5.11' (authored by graesslin).
Merge branch 'Plasma/5.11'
Sat, Sep 23, 9:52 AM
graesslin committed R108:537b36d1cb48: Only try creating X11 shadow if we have an X11 connection (authored by graesslin).
Only try creating X11 shadow if we have an X11 connection
Sat, Sep 23, 9:52 AM
graesslin closed D7894: Only try creating X11 shadow if we have an X11 connection.
Sat, Sep 23, 9:52 AM · KWin
graesslin committed R108:ab7b6757bf32: Properly update the visible (icon) name when the caption changes (authored by graesslin).
Properly update the visible (icon) name when the caption changes
Sat, Sep 23, 9:51 AM
graesslin closed D7871: Properly update the visible (icon) name when the caption changes.
Sat, Sep 23, 9:51 AM · KWin
graesslin updated the task description for T7050: Privacy Software.
Sat, Sep 23, 6:42 AM · Goal settings 2017

Yesterday

graesslin updated the test plan for D7843: Move XFixes cursor change tracking into the x11 standalone platform.
Fri, Sep 22, 6:40 PM · Plasma
graesslin added a dependency for D7942: Create a dedicated X11Filter for Client sync events and move it to X11 platform: D7843: Move XFixes cursor change tracking into the x11 standalone platform.
Fri, Sep 22, 6:39 PM · Plasma
graesslin added a dependent revision for D7843: Move XFixes cursor change tracking into the x11 standalone platform: D7942: Create a dedicated X11Filter for Client sync events and move it to X11 platform.
Fri, Sep 22, 6:39 PM · Plasma
graesslin created D7942: Create a dedicated X11Filter for Client sync events and move it to X11 platform.
Fri, Sep 22, 6:39 PM · Plasma
graesslin updated the diff for D7843: Move XFixes cursor change tracking into the x11 standalone platform.

Fix crash on startup - cursor is created before Workspace, so the filter creation needs to be delayed

Fri, Sep 22, 6:35 PM · Plasma
graesslin committed R108:8aa7bb28c876: Drop useless XCB_DESTROY_NOTIFY from big event switch statement (authored by graesslin).
Drop useless XCB_DESTROY_NOTIFY from big event switch statement
Fri, Sep 22, 4:51 PM
graesslin closed D7938: Drop useless XCB_DESTROY_NOTIFY from big event switch statement.
Fri, Sep 22, 4:51 PM · KWin
graesslin created D7938: Drop useless XCB_DESTROY_NOTIFY from big event switch statement.
Fri, Sep 22, 3:20 PM · KWin
graesslin accepted D7937: Don't reload background contrast effect on screen resize.
Fri, Sep 22, 2:55 PM · Plasma
graesslin added inline comments to D7937: Don't reload background contrast effect on screen resize.
Fri, Sep 22, 1:33 PM · Plasma
graesslin added a comment to D7934: Add KCM for adjusting QtQuick Rendering in Plasma.

Out from experience with the KWin Compositing kcm: hide it well, add more warnings and hide it even more. No matter how much you warn against the settings users will change them. Even if it tells them it's the wrong setting for their system and it's going to break there system: we got bug reports for that.

Fri, Sep 22, 1:30 PM · Plasma
graesslin committed R108:551a6246a897: Move XRenderUtils init/cleanup into X11 standalone platform (authored by graesslin).
Move XRenderUtils init/cleanup into X11 standalone platform
Fri, Sep 22, 1:23 PM
graesslin committed R108:27d06a1d4c1b: Fix position where removeEffectsOverrideCursor is called (authored by graesslin).
Fix position where removeEffectsOverrideCursor is called
Fri, Sep 22, 1:23 PM
graesslin closed D7845: Fix position where removeEffectsOverrideCursor is called.
Fri, Sep 22, 1:22 PM · KWin
graesslin closed D7760: Move XRenderUtils init/cleanup into X11 standalone platform.
Fri, Sep 22, 1:22 PM · KWin
grahamperrin awarded D7871: Properly update the visible (icon) name when the caption changes a Love token.
Fri, Sep 22, 2:58 AM · KWin

Thu, Sep 21

graesslin added dependencies for D7924: Support starting kwin_wayland without XWayland support: D7760: Move XRenderUtils init/cleanup into X11 standalone platform, D7894: Only try creating X11 shadow if we have an X11 connection, D7892: Only call xcb_flush in performCompositing if we have an X11 connection, D7856: Make xstacking order dirty handling work without X11, D7897: Move X11 specific Workspace initialization code into dedicated method.
Thu, Sep 21, 4:33 PM · KWin
graesslin created D7924: Support starting kwin_wayland without XWayland support.
Thu, Sep 21, 4:31 PM · KWin
graesslin committed R108:e8664f83b964: Only call xcb_flush in performCompositing if we have an X11 connection (authored by graesslin).
Only call xcb_flush in performCompositing if we have an X11 connection
Thu, Sep 21, 4:12 PM
graesslin closed D7892: Only call xcb_flush in performCompositing if we have an X11 connection.
Thu, Sep 21, 4:12 PM · KWin
graesslin added inline comments to D7897: Move X11 specific Workspace initialization code into dedicated method.
Thu, Sep 21, 3:42 PM · KWin

Wed, Sep 20

graesslin added a dependent revision for D7856: Make xstacking order dirty handling work without X11: D7897: Move X11 specific Workspace initialization code into dedicated method.
Wed, Sep 20, 7:54 PM · KWin
graesslin added a dependency for D7897: Move X11 specific Workspace initialization code into dedicated method: D7856: Make xstacking order dirty handling work without X11.
Wed, Sep 20, 7:54 PM · KWin
graesslin created D7897: Move X11 specific Workspace initialization code into dedicated method.
Wed, Sep 20, 7:53 PM · KWin
graesslin created D7894: Only try creating X11 shadow if we have an X11 connection.
Wed, Sep 20, 5:36 PM · KWin
graesslin created D7892: Only call xcb_flush in performCompositing if we have an X11 connection.
Wed, Sep 20, 5:34 PM · KWin
graesslin accepted D7888: Make sure OpenGL Context is valid before deleting shader.

Feel free to push either of the two revisions.

Wed, Sep 20, 4:43 PM · Plasma
graesslin added inline comments to D7888: Make sure OpenGL Context is valid before deleting shader.
Wed, Sep 20, 3:47 PM · Plasma
graesslin added a comment to D7882: on wayland startup create XDG_RUNTIME_DIR.
In D7882#147153, @sebas wrote:

That's happening when I start startplasmacompositor by hand, and it's annoying as fuck.

Wed, Sep 20, 3:26 PM · Plasma
graesslin requested changes to D7888: Make sure OpenGL Context is valid before deleting shader.
Wed, Sep 20, 3:23 PM · Plasma
graesslin accepted D7885: Don't crash if a client (legally) uses deleted global contrast manager.
Wed, Sep 20, 3:20 PM · Frameworks, Plasma on Wayland
graesslin added a comment to D7882: on wayland startup create XDG_RUNTIME_DIR.

-1 from my side. This is a clear bug in whatever is used in the login process. If XDG_RUNTIME_DIR is not created we might have a thousand more things which don't work as expected. I rather have KWin bail out early on that one than have to hunt down all the things which might not work because the system is weird.

Wed, Sep 20, 3:19 PM · Plasma

Tue, Sep 19

graesslin added a comment to D7757: Use real-time scheduling policy for kwin_wayland.

Looks good to me. Sorry for the timeout :)

Tue, Sep 19, 8:08 PM · Plasma
graesslin committed R108:a17c85a9eab5: Support mapping QKeyEvent to xkb_keysym_t (authored by graesslin).
Support mapping QKeyEvent to xkb_keysym_t
Tue, Sep 19, 5:12 PM
graesslin closed D7356: Support mapping QKeyEvent to xkb_keysym_t.
Tue, Sep 19, 5:12 PM · KWin
graesslin added a comment to D7757: Use real-time scheduling policy for kwin_wayland.

ping

Tue, Sep 19, 5:10 PM · Plasma
graesslin added a comment to D7740: Move SceneOpenGL into a dedicated plugin.

ping

Tue, Sep 19, 5:10 PM · KWin
graesslin accepted D7877: Don't recreate kwayland blurmanager on screen size changes.
Tue, Sep 19, 3:03 PM · KWin

Mon, Sep 18

graesslin accepted D7854: Fix TouchEvent::id() returning -1, fixes a crash.

Do you have commit rights or should one of us push for you?

Mon, Sep 18, 7:14 PM · KWin
graesslin added inline comments to D7870: Don't crash if a client (legally) uses a deleted global.
Mon, Sep 18, 7:13 PM · Plasma, Frameworks
graesslin committed R108:5256338772ae: [autotests] Force more tests to use evdev as XKB_DEFAULT_RULES (authored by graesslin).
[autotests] Force more tests to use evdev as XKB_DEFAULT_RULES
Mon, Sep 18, 7:06 PM
graesslin accepted D7870: Don't crash if a client (legally) uses a deleted global.

What surprises me is that BlurManager recreates for Output changes. That sounds like a bug in KWin (or an area which could be improved).

Mon, Sep 18, 6:45 PM · Plasma, Frameworks
graesslin created D7871: Properly update the visible (icon) name when the caption changes.
Mon, Sep 18, 4:40 PM · KWin
graesslin accepted D7868: Don't scale cursor hotspot differently to cursor.
Mon, Sep 18, 3:04 PM · KWin

Sun, Sep 17

graesslin added a comment to T6624: xkbcommon not functional in FreeBSD CI image.

Does this mean the tests need to be improved, or is something missing from the builders?

Looks mainly like a case of different keyboard layouts to me...

Sun, Sep 17, 7:29 PM · build.kde.org
graesslin committed R108:e55e437d861f: [autotests] Force XKB_DEFAULT_RULES to evdev in ModifierOnlyShortcutsTest (authored by graesslin).
[autotests] Force XKB_DEFAULT_RULES to evdev in ModifierOnlyShortcutsTest
Sun, Sep 17, 6:59 PM
graesslin added a comment to T6624: xkbcommon not functional in FreeBSD CI image.

Just had a look.

Sun, Sep 17, 6:47 PM · build.kde.org
graesslin added a comment to D7854: Fix TouchEvent::id() returning -1, fixes a crash.

If you want you could add another testcase in autotests/libinput/touch_event_test.cpp to cover the special condition.

Sun, Sep 17, 11:13 AM · KWin
graesslin created D7857: Change default argument of grabXKeyboard to XCB_WINDOW_NONE.
Sun, Sep 17, 7:44 AM · KWin
graesslin created D7856: Make xstacking order dirty handling work without X11.
Sun, Sep 17, 7:30 AM · KWin

Sat, Sep 16

graesslin created D7853: Add a dedicated X11EventFilter for forwarding property events to the effect system.
Sat, Sep 16, 5:29 PM · KWin
graesslin created D7846: [tabbox] Drop the passing to Effects in X11 Filter.
Sat, Sep 16, 9:34 AM · KWin
graesslin added a comment to D7760: Move XRenderUtils init/cleanup into X11 standalone platform.

ping

Sat, Sep 16, 9:05 AM · KWin
graesslin created D7845: Fix position where removeEffectsOverrideCursor is called.
Sat, Sep 16, 6:07 AM · KWin
graesslin committed R108:0c6fdeef2db4: Split out the X11 mouse event filtering for EffectsHandlerImpl (authored by graesslin).
Split out the X11 mouse event filtering for EffectsHandlerImpl
Sat, Sep 16, 6:04 AM
graesslin closed D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl.
Sat, Sep 16, 6:04 AM · KWin

Fri, Sep 15

graesslin added a comment to D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl.

ok.

Also note that I made a comment about the (untouched) wayland code.

Fri, Sep 15, 8:49 PM · KWin
graesslin created D7843: Move XFixes cursor change tracking into the x11 standalone platform.
Fri, Sep 15, 6:01 PM · Plasma
graesslin added a comment to D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl.

Code does what it says but one comment

  1. I would move the m_mouseInterceptionWindow code with it, that way we have RAII on that window, and less X specific things in the EffectsHandler. Logically it's grouped
Fri, Sep 15, 5:31 PM · KWin
graesslin created D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl.
Fri, Sep 15, 4:39 PM · KWin
graesslin requested changes to D7832: Color Vision Deficiency Simulation.

Honestly I'm not sure whether this makes sense to include into KWin directly. While it's a nice gimmick I don't think it's something we should ship with default offerings. Is that really something every user needs in a default setup? This might be handy for development setup, but not in general to ship.

Fri, Sep 15, 1:25 PM · KWin
graesslin accepted D7834: Sync XRDB DPI to the platform specific setting.
Fri, Sep 15, 1:19 PM · Plasma
graesslin added a comment to D6233: KKeyServer: fix handling of KeypadModifier..

Qt (at shortcut recording time) sees this as Meta+Shift+Print while KWindowSystem (xcbKeyPressEventToQt) sees it as Meta+Shift+SysReq.

Qt does xkb_state_key_get_one_sym( state=51 , code=6b ) = ff61 (XK_Print)
xcbKeyPressEventToQt does xcb_key_press_lookup_keysym e->state=51 keyModX= 41 keySym0= ff61 (XK_Print) keySym1= ff15 (XK_Sys_Req)
(all numbers are hex)
(51 or 41 is the same, that's just removing Numlock)

I'm at a loss at this point though. Should xcbKeyPressEventToQt rather use xkb_state_key_get_one_sym to be closer to the code in Qt? Or what am I missing?

Fri, Sep 15, 1:15 PM · Frameworks
graesslin added a comment to D7829: Fix kglobalaccel regression on Alt+Shift+arrowkey..

How do we know that this doesn't break other code? This code is for example used in KWin's Alt+Tab handling which is it's own fair beast. Any changes here might break the code as it might be bug-to-bug compatible.

Fri, Sep 15, 1:12 PM

Thu, Sep 14

graesslin added a comment to D7811: Put effectModelTest behind BUILD_TESTING conditional.

From a packager's POV, what I'd really like is some add_testdirectory macro where everyone would isolate their tests that would be auto-disabled by BUILD_TESTING=OFF...

Thu, Sep 14, 6:29 PM · KWin
graesslin requested changes to D7811: Put effectModelTest behind BUILD_TESTING conditional.

Why is this needed? Wasn't the idea behind ecm_mark_as_test that they are not built when BUILD_TESTING is off?

Thu, Sep 14, 4:49 PM · KWin

Wed, Sep 13

graesslin created D7808: Create a dedicated X11EventFilter for the events used by RootInfo.
Wed, Sep 13, 7:47 PM · KWin
graesslin accepted D7806: seccomp filter: Handle openat as well.
Wed, Sep 13, 6:19 PM · Plasma
graesslin added a comment to D6233: KKeyServer: fix handling of KeypadModifier..

This seems to be a big problem. Kglobalaccell got more new bugs reported this week, than normally in a year.

Wed, Sep 13, 4:17 AM · Frameworks

Tue, Sep 12

graesslin committed R108:a9270f4232b7: Try fixing build failure on CI (authored by graesslin).
Try fixing build failure on CI
Tue, Sep 12, 7:21 PM
graesslin accepted D7784: CMake 3.1 is the actually required version.

I had no idea that this requires a newer CMake. Thanks for fixing!

Tue, Sep 12, 5:00 PM · KWin
graesslin committed R108:90e77a939a4d: [effects] Support xcbConnectionChanged for support properties (authored by graesslin).
[effects] Support xcbConnectionChanged for support properties
Tue, Sep 12, 4:54 PM
graesslin closed D7761: [effects] Support xcbConnectionChanged for support properties by committing R108:90e77a939a4d: [effects] Support xcbConnectionChanged for support properties.
Tue, Sep 12, 4:54 PM · Plasma
graesslin committed R108:4fa41165d190: Move XRandR event filter into XRandRScreens (authored by graesslin).
Move XRandR event filter into XRandRScreens
Tue, Sep 12, 4:54 PM
graesslin closed D7654: Move XRandR event filter into XRandRScreens by committing R108:4fa41165d190: Move XRandR event filter into XRandRScreens.
Tue, Sep 12, 4:54 PM · KWin
graesslin committed R108:8015e4e84ece: Add virtual method to Scene to get the EGL/GLX extensions (authored by graesslin).
Add virtual method to Scene to get the EGL/GLX extensions
Tue, Sep 12, 3:37 PM
graesslin closed D7734: Add virtual method to Scene to get the EGL/GLX extensions by committing R108:8015e4e84ece: Add virtual method to Scene to get the EGL/GLX extensions.
Tue, Sep 12, 3:37 PM · KWin
graesslin requested changes to D6591: XdgV6 - Kwin side.

Now it looks good to me!

Tue, Sep 12, 3:17 PM · Plasma

Mon, Sep 11

graesslin added a comment to D7740: Move SceneOpenGL into a dedicated plugin.
In D7740#144854, @bshah wrote:

Tested this branch, and seems to build and work completely fine

Mon, Sep 11, 7:12 PM · KWin
graesslin committed R108:e0f7f58397a6: Move SceneOpenGL into a dedicated plugin (authored by graesslin).
Move SceneOpenGL into a dedicated plugin
Mon, Sep 11, 2:41 PM
graesslin committed R108:db2ddec23d51: Add virtual method to Scene to get the EGL/GLX extensions (authored by graesslin).
Add virtual method to Scene to get the EGL/GLX extensions
Mon, Sep 11, 2:41 PM
graesslin added a comment to D7740: Move SceneOpenGL into a dedicated plugin.
In D7740#144574, @bshah wrote:

@bshah could you please try this patch on hwcomposer platform? I tried to get all required changes into it, but I currently don't have a compiler to verify.

Can you commit them in one branch? makes easier for me to CI build this change, as patch is massive.

Mon, Sep 11, 2:40 PM · KWin

Sun, Sep 10

graesslin added inline comments to D7761: [effects] Support xcbConnectionChanged for support properties.
Sun, Sep 10, 8:04 PM · Plasma
graesslin updated the diff for D7761: [effects] Support xcbConnectionChanged for support properties.

Addressed David's comments

Sun, Sep 10, 7:52 PM · Plasma
graesslin committed R369:7534df21025b: Make Yakuake work on Wayland with Qt 5.9 (authored by graesslin).
Make Yakuake work on Wayland with Qt 5.9
Sun, Sep 10, 6:27 PM
graesslin closed D7709: Make Yakuake work on Wayland with Qt 5.9 by committing R369:7534df21025b: Make Yakuake work on Wayland with Qt 5.9.
Sun, Sep 10, 6:27 PM
graesslin updated the diff for D7757: Use real-time scheduling policy for kwin_wayland.

Check whether we have SCHED_RESET_ON_FORK and ifdef accordingly

Sun, Sep 10, 5:48 PM · Plasma
graesslin committed R108:8522ef17eea0: Do not hard runtime depend on X11 in RuleBook (authored by graesslin).
Do not hard runtime depend on X11 in RuleBook
Sun, Sep 10, 3:09 PM
graesslin closed D7653: Do not hard runtime depend on X11 in RuleBook by committing R108:8522ef17eea0: Do not hard runtime depend on X11 in RuleBook.
Sun, Sep 10, 3:09 PM · KWin
graesslin created D7761: [effects] Support xcbConnectionChanged for support properties.
Sun, Sep 10, 2:56 PM · Plasma
graesslin created D7760: Move XRenderUtils init/cleanup into X11 standalone platform.
Sun, Sep 10, 2:06 PM · KWin
graesslin added a comment to D7757: Use real-time scheduling policy for kwin_wayland.
                 ^
/home/Tobias/git/kwin/main_wayland.cpp:452:38: error: use of undeclared identifier 'SCHED_RESET_ON_FORK'
    sched_setscheduler(0, SCHED_RR | SCHED_RESET_ON_FORK, &sp);
                                     ^

Yes, SCHED_RESET_ON_FORK is linux only:
https://www.freebsd.org/cgi/man.cgi?query=sched_setscheduler

Sun, Sep 10, 1:47 PM · Plasma