graesslin (Martin Flöser)
KWin developer

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 8:19 AM (226 w, 5 d)
Availability
Available

Recent Activity

Mon, Aug 12

graesslin added a comment to D23069: Remove disabled TabGroup feature.

Just for the record: the patch to add window decoration back is in D13459 - I still have the code around and uncommitted changes on top. With the relatively small changes I had window tabs kind of working already. So if anyone wants to pick it up: we are almost there and I'm happy to share the code. Personally I doubt that I will find the time to finish it. I currently don't even find the time to push accepted changes. I'd love to do it, but I must be realistic.

Mon, Aug 12, 8:06 PM · KWin

Mon, Aug 5

graesslin committed R487:9721f3c58611: Merge branch 'Plasma/5.0' (authored by graesslin).
Merge branch 'Plasma/5.0'
Mon, Aug 5, 12:11 PM
graesslin committed R487:c208ce08b675: [kcms] I18n fixes (authored by graesslin).
[kcms] I18n fixes
Mon, Aug 5, 12:11 PM

Jul 20 2019

graesslin added a comment to D22571: Allow blacklisting some wayland interfaces.

And of course if this patch lands I have no objections any more to the fake key event injection in the fake input protocol which is required for kdeconnect and remote access.

Jul 20 2019, 2:50 PM · KWin
graesslin added a comment to D22418: WIP [wayland] make automatic backend selection truly automatic.

I'm not convinced that removing the ifdef is the solution to the problem. What you basically want is being able to do an out-of-tree build of a backend. Ideally you would want to install all the variants next to each other and be able to pick the correct one.

Jul 20 2019, 2:48 PM · KWin
graesslin added a comment to D22571: Allow blacklisting some wayland interfaces.

This is a wonderful patch - I love it!

Jul 20 2019, 2:39 PM · KWin
graesslin added a comment to T11067: Better tiling window manager.

Sure, but we here still don't know what those conflicts were, and given this task is about a tiling WM, it sounds possibly important information.

Jul 20 2019, 2:28 PM · Goal Setting 2019
graesslin added a comment to T10783: Right-click on touch.

Just something I want to add so that it is documented: In KWin we quite regularly get the request to emulate the right mouse click. This is not possible (and/or advisable). Obviously such a feature would belong into the display manager. Meaning on X11 it must be in the X server (no control from our side) and on Wayland it would be KWin. So let's explain why this wouldn't work on Wayland. On Wayland we have dedicated interfaces for touch and pointer (mouse, touchpad) interfaces. Touch does not influence pointer movement and does not emulate left clicks as it was the case on X11. In case an application would announce that it doesn't support touch, we could emulate mouse on touch events. But this is in practice not the case. We mostly interact with Qt, Gtk and XWayland which all announce touch support. For the compositor it is impossible to know whether the application truly supports touch or not. There is just no protocol to announce "hey I can do touch, or hey I cannot do touch". So KWin would need to handle all applications the same way and if KWin would start to emulate right click events it would break applications which already support touch. For example at $work we use KWin as the compositor for a gui application which was designed for touch screens. We don't have a context menu, but we handle the long press event. The moment KWin would start to emulate right click events our application would break. And this would not be the only one, every application starting to make proper use of touch would break. It is not a future proof approach to add such support to KWin.

Jul 20 2019, 9:13 AM · Plasma, VDG
graesslin added a comment to T11081: Wayland Migration.

Wayland by default would offer a better user experience. E.g. a tear free desktop, less power consumption, different refresh rates per screen, better possibilities to extend our desktop on mobile, better touch support and most important improved security. So yes, the goal as it is framed is focused on tech, but it can easily be reworded to focus on the advantages it gives us in comparison to X11.

Jul 20 2019, 8:58 AM · Goal Setting 2019
graesslin added a comment to T11067: Better tiling window manager.
Jul 20 2019, 8:55 AM · Goal Setting 2019
graesslin updated the diff for D22498: Introduce a simple frame rendered statistic.
  • numberFrames -> numberOfFrames
  • added missing copyright header
Jul 20 2019, 8:05 AM · KWin

Jul 16 2019

graesslin requested review of D22498: Introduce a simple frame rendered statistic.
Jul 16 2019, 7:42 PM · KWin

Jul 13 2019

graesslin added a comment to D22209: [effects/screenshot] Disable screenshot to file on Wayland.

@ngraham I do not understand why you request changes. This diff has no implications on spectacle or any other application. The api call is neither intended to be used by an X11 application nor by a Wayland application and predates the interaction with ksnapshot.

Jul 13 2019, 6:37 AM · KWin
graesslin added a comment to D22430: Load the keyboard on-demand.

The idea of loading on startup was to verify that the view works and only offer the sni and other interactions if the virtual keyboard is functional - see the early return in line 86. This is IMHO a must have feature as we cannot properly set a dependency on the virtual keyboard qml component. If we can check in another way, I'm all for this change.

Jul 13 2019, 6:33 AM · KWin
graesslin added a comment to D22418: WIP [wayland] make automatic backend selection truly automatic.

Is there a real world situation where KWin is getting compiled twice with different settings? When adding the ifdefs this was based on feedback from distributions

Jul 13 2019, 6:30 AM · KWin

Jul 2 2019

graesslin added a comment to T11067: Better tiling window manager.

@graesslin
Martin what is you opinion about integration of "smart tiling" (T11086 into KWin? Is it hard to do with current codebase?

Jul 2 2019, 9:53 AM · Goal Setting 2019
graesslin added a comment to D22209: [effects/screenshot] Disable screenshot to file on Wayland.

I accept your general criticism, but I disagree. When we started Wayland and added the interactive protocol flatpak did not exist (practically) and we still had to assume that everything runs trusted. Even right now it's still a nice theory only that all apps will be sandboxed (on my system they aren't yet). Given that we should also look at the now and present issues. Having these dbus call open was a mistake when adding the interactive mode. Given that I see it as a bug fix to that.

Jul 2 2019, 9:48 AM · KWin
graesslin requested review of D22209: [effects/screenshot] Disable screenshot to file on Wayland.
Jul 2 2019, 8:48 AM · KWin

Jul 1 2019

graesslin added a comment to T11067: Better tiling window manager.

Some more information about the removal of tiling support in: http://commits.kde.org/kde-workspace/34027455aaa2ee738c45987ca2d8cb7d65491bf0 - it has a few links explaining the problems.

Jul 1 2019, 7:10 PM · Goal Setting 2019
graesslin added a comment to D22033: Remove confirmation overlay from screenshotFullscreen.

But there are ways to circumvent this. For example if I were a malicious program I could just call the variant that doesn't take a file descriptor and saves to /tmp and then read the file from there.

Jul 1 2019, 10:31 AM · KWin
graesslin resigned from D22033: Remove confirmation overlay from screenshotFullscreen.

The interaction is a security feature. It makes it impossible to just screenshot and leak the information. Please keep this in place. Being able to screenshot was one of the big unfixable security issues on X11. Let's please not remove this. Also having a screenshot api which does not enforce user interaction provides a poor man screencast API. The explicit user interaction makes it impossible that someone tries to screencast through this way.

Jul 1 2019, 9:32 AM · KWin
graesslin added a comment to T11067: Better tiling window manager.

We had tiling support in KWin and it was a complete failure. The problems was that KWin is a stacking window manager and no matter how hard you hammer on it, it will be a stacking window manager. There are concepts which just don't fit - and that's fine. Maintenance was a hell, especially tiling broke stacking and stacking broke tiling. This is a problem which just cannot be solved.

Jul 1 2019, 9:17 AM · Goal Setting 2019

May 10 2019

graesslin added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.

Having some more time to write. I really do not want to see this option come back. It was the right decision to remove it, I stand to it. I had a shitload of of negative comments due to it and it would have been easy to just revert the change, but from a product development perspective it's wrong to do so. I really need to point out that this is a feature only required by a handful of very noisy and angry users. We don't have to cater to those who scream load but we need to develop a good working product with a streamlined UI and good interaction. While it's true that there are other applications implementing close on middle click, I think it's wrong to offer it on X11. Middle click has a very defined meaning as a fast way to paste. Users could expect that middle click performs a paste action and not close windows.

May 10 2019, 12:09 PM · KWin

May 8 2019

graesslin added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.

Please do not add this back. This is a very hot topic to many users, but let me explain. I was the one adding the feature in the first place and I removed it again. Personally I think adding the mouse actions functionality was a big mistake. I did this in 2008 when I joined KWin development. My work on Present Windows back then was a failure. I - and Lucas - added several features which turned the code base into an unmaintainable mess and significantly affected the stability of overall KWin. Several of the features added back then were reverted and replaced by better functionality. What I wanted to achieve back then was having the functionality of closing windows. My big mistake was to make this configurable. Instead of just adding this feature we made it completely configurable and turned it into a space ship control of window management. But nothing else in Present Windows is a window management feature. As the name says, it's intended to present all windows, not to manage them. Furthermore this introduced a big usability issue by reusing Present Windows in desktop grid to present the windows but not having the user interaction feature.

May 8 2019, 5:10 PM · KWin

Apr 5 2019

graesslin added a comment to D20066: Use Meta+D to Show Desktop by default.

You are aware that kglobalaccel doesn't support removing global shortcuts? If yes your reply doesn't make any sense, if no it means you need to consider now - a revert later on based on feedback is not an available option.

Apr 5 2019, 9:56 AM · KWin

Apr 2 2019

graesslin accepted D20153: Move keep-above clients to the Normal layer when showing desktop.
Apr 2 2019, 12:06 PM · KWin
graesslin added a comment to D20066: Use Meta+D to Show Desktop by default.

On the other hand you are stealing the shortcut even for users not using this feature at all. What about the following idea: if a user adds the show desktop widget the shortcut gets added?

Apr 2 2019, 12:06 PM · KWin
graesslin added a comment to D20192: Implement the keystate protocol.

Sorry, but I don't see the need for this protocol as that is already part of wl_keyboard.

Apr 2 2019, 12:00 PM · KWin

Apr 1 2019

graesslin added a comment to D20066: Use Meta+D to Show Desktop by default.

For what is worth to mention: we have for years refused to add further global shortcuts as they very easily conflict with application shortcuts. Yes, we were aware that people complained about the lack of default shortcuts. But on the other hand we get the bug reports about applications being broken. And I keep it with Linus: don't break user space. There's a reason why that shortcut didn't have a default and the windows shortcut existed back then.

Apr 1 2019, 8:00 PM · KWin
graesslin requested changes to D20154: Raise notifications with KeepAbove flag to OnScreenDisplay layer.

Please don't introduce such magic. If you need a special window type please add one or use osd directly. Please keep in mind that there's no way to set keep above for Wayland windows.

Apr 1 2019, 7:47 PM · KWin
graesslin added a comment to D20153: Move keep-above clients to the Normal layer when showing desktop.

When I read the bug report I was wondering whether that's actually intended? Does keep above implies it's kept above other windows in all cases?

Apr 1 2019, 7:45 PM · KWin

Mar 26 2019

graesslin accepted D20044: Expose AbstractClient::setMaximize to scripting.
Mar 26 2019, 7:22 AM · KWin

Mar 25 2019

graesslin added a comment to D19867: [X11] Force glXSwapBuffers to block with NVIDIA driver.

Thanks a lot! I suggest to backport it to all supported versions.

Mar 25 2019, 8:27 PM · KWin
graesslin requested changes to D20044: Expose AbstractClient::setMaximize to scripting.

Please don't randomly turn methods into slots. There's a fair chance of future breaking if somebody checks for the usage of the slot and notices it's unused.

Mar 25 2019, 4:18 PM · KWin

Mar 12 2019

graesslin added a comment to D19663: [platforms/fbdev] Use a better way to correct activating framebuffer devices.

I think there's no problem with anonymous contributions. We have no means to check anyway if the provided name is correct.

Mar 12 2019, 8:07 PM · KWin
graesslin added a comment to D19613: Support NET_WM_STATE_FOCUSED.

From my side a -1 as we are feature frozen. Gtk can easily check whether the window manager supports this property and if not do the same as this patch does. This is clearly a gtk bug and if gtk fixed it, it works for everyone and there is no need to incorrectly claim support for the property. Has this issue been reported to Gtk devs?

Mar 12 2019, 8:04 PM · KWin
graesslin accepted D19710: Rotate cursors also on portrait mode.
Mar 12 2019, 7:59 PM · KWin
graesslin added a comment to D19613: Support NET_WM_STATE_FOCUSED.

I still don't see a need for this property. All we do is something gtk can easily do itself. We are working around a gtk bug in all window managers. I think that's wrong.

Mar 12 2019, 5:32 AM · KWin

Feb 27 2019

graesslin added a comment to T10530: [BRAINSTORM] Redesign Scene.

The main problem with subsurface and WindowPixmap is that the subsurface a are evaluated too late in the rendering process which makes it impossible to have quads.

Feb 27 2019, 5:23 PM · KWin

Feb 25 2019

graesslin requested changes to D19296: Allow to set quarter tiling separately.
Feb 25 2019, 3:51 PM · KWin
graesslin added a comment to D19296: Allow to set quarter tiling separately.

I already expressed my concerns in the bug report: I consider this as featureitis and catering for a specific use case. I fear that the negative aspects of yet another checkbox (c.f. kde is too complicated). Also it creates yet another code path which nobody tests and those special use cases are the ones which tend to break.

Feb 25 2019, 3:49 PM · KWin

Feb 22 2019

graesslin committed R108:cbbe94d76920: Restrict available supported compositors based on first initialized one (authored by graesslin).
Restrict available supported compositors based on first initialized one
Feb 22 2019, 3:59 PM
graesslin closed D19084: Restrict available supported compositors based on first initialized one.
Feb 22 2019, 3:59 PM · KWin
graesslin committed R108:e48d9df14f30: [qpa] Drop PlatformContextWayland which uses wayland egl for OpenGL (authored by graesslin).
[qpa] Drop PlatformContextWayland which uses wayland egl for OpenGL
Feb 22 2019, 3:59 PM
graesslin closed D19012: [qpa] Drop PlatformContextWayland which uses wayland egl for OpenGL.
Feb 22 2019, 3:59 PM · KWin
graesslin added a comment to R108:e96da56f8ced: Fix tests.

Yes the code had a merge conflict. Sorry about that.

Feb 22 2019, 5:27 AM

Feb 21 2019

graesslin committed R108:9b922f88332f: Split out a dedicated InternalClient class (authored by graesslin).
Split out a dedicated InternalClient class
Feb 21 2019, 6:53 PM
graesslin closed D18569: Split out a dedicated InternalClient class.
Feb 21 2019, 6:53 PM · KWin

Feb 17 2019

graesslin committed R108:1d8d7bd9f7ad: [qpa] Set binary output path for QPA plugin (authored by graesslin).
[qpa] Set binary output path for QPA plugin
Feb 17 2019, 7:48 PM
graesslin closed D19010: [qpa] Set binary output path for QPA plugin.
Feb 17 2019, 7:48 PM · KWin

Feb 16 2019

graesslin added a comment to D19012: [qpa] Drop PlatformContextWayland which uses wayland egl for OpenGL.

See https://phabricator.kde.org/D19084

Feb 16 2019, 7:57 PM · KWin
graesslin requested review of D19084: Restrict available supported compositors based on first initialized one.
Feb 16 2019, 7:56 PM · KWin
graesslin added a comment to D19052: Fix captions with non-BMP characters.

I would need guidance to write such a test. If I understand it, I would need to create a dummy Client subclass, call setCaption() with different strings, and check what actually lands in the cap_normal variable.

The question is, how can I create a such a dummy Client when it actually requires a workspace? Any tests that do similar things with a different property?

Feb 16 2019, 6:15 PM · KWin
graesslin added inline comments to D18569: Split out a dedicated InternalClient class.
Feb 16 2019, 1:25 PM · KWin
graesslin added a comment to D19012: [qpa] Drop PlatformContextWayland which uses wayland egl for OpenGL.

or we have the QPainter compositor which also turns QtQuick to use software renderer.

Unfortunately that's not true if we still want to switch at runtime.
QQuickWindow::setSceneGraphBackend is only followed if set before the first QQuickWindow is created.

Feb 16 2019, 1:18 PM · KWin
graesslin added a comment to D19052: Fix captions with non-BMP characters.

I think we have a unit test for it which should now expect pass. If I'm wrong and we don't have a test case: could you please add one.

Feb 16 2019, 1:13 PM · KWin

Feb 14 2019

graesslin requested review of D19012: [qpa] Drop PlatformContextWayland which uses wayland egl for OpenGL.
Feb 14 2019, 4:48 PM · KWin
graesslin requested review of D19010: [qpa] Set binary output path for QPA plugin.
Feb 14 2019, 4:41 PM · KWin
graesslin added a comment to R108:01ee957c494a: Call setupCompositing on internal clients on startup of Compositor.

We cannot just call setupCompositing because there is a phase during startup where setupCompositing already passes but the Compositor is not yet fully initialized. Thus it could happen that it's called twice which makes the Scene assert.

When could this happen? Are there prominent functions or methods that one could look into in order to understand why setupCompositing is called twice?

Feb 14 2019, 3:14 PM

Feb 11 2019

graesslin added inline comments to D18914: Discard Deleted before Scene is destroyed.
Feb 11 2019, 4:13 PM · KWin
graesslin updated the diff for D18569: Split out a dedicated InternalClient class.

Remove rect.isValid check

Feb 11 2019, 4:10 PM · KWin
graesslin added inline comments to D18569: Split out a dedicated InternalClient class.
Feb 11 2019, 4:09 PM · KWin

Feb 10 2019

graesslin accepted D18863: [platforms/drm] Use more ScopedDrmPointer.
Feb 10 2019, 4:23 PM · KWin
graesslin added a comment to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.

Please don't take it negative that I once again request changes here. I once run into this issue myself when I added quick tiling - oh that was a mess, because I didn't track in Client the state changes. Back then Thomas fixed all of it :-) It's just a lesson learned and this geometry handling is really complex. It's too many states and we need to ensure here that we don't jump out of maximized or fullscreen due to keyboard open. Now to make it even more complex one could think about the display getting rotated which would again change the geometries and all the windows changes.

Feb 10 2019, 4:21 PM · KWin
graesslin requested changes to D18818: virtualkeyboard: resize the focused window to make room for the keyboard.

I'm not sure whether it's a good idea to resize windows for virtual keyboard. This can easily result in a feedback loop - the window resizes, the element with focus loses focus, keyboard closes, window resizes, element gets focus again and so on.

Feb 10 2019, 4:14 PM · KWin
graesslin accepted D18786: Copy layer repaints to Deleted.
Feb 10 2019, 4:07 PM · KWin
graesslin added a comment to D18795: Kill KillWindow.

One of the long time problem of KWin was that we had too many things in Workspace. Workspace just does too much - it's a god object.

Feb 10 2019, 4:04 PM · KWin
graesslin added a comment to D18569: Split out a dedicated InternalClient class.

I don't see how this patch could cause Plasma windows to have problems. All changed code is internal windows.

Feb 10 2019, 3:58 PM · KWin
graesslin accepted D18236: Use correct flag when checking whether a scene window is opaque.

go for it, we have now enough time to notice any regressions till the next release.

Feb 10 2019, 3:53 PM · KWin

Feb 8 2019

graesslin added a comment to R108:58fa92e40bd3: Pass EGL_PLATFORM=DRM to XWayland.

Setting the named symlink.

Feb 8 2019, 4:46 PM

Feb 6 2019

graesslin added a comment to R108:58fa92e40bd3: Pass EGL_PLATFORM=DRM to XWayland.

This commit breaks KWin on Plasma Mobile when HWComposer backend is used: https://invent.kde.org/snippets/5
I'm not sure what XWayland supports, but when I workaround this line by creating a link from /usr/lib/i386-linux-gnu/libhybris/eglplatform_DRM.so to /usr/lib/i386-linux-gnu/libhybris/eglplatform_wayland.so, XWayland applications start and work fine.

Feb 6 2019, 4:08 PM

Feb 5 2019

graesslin accepted D18657: Drop COPYING.DOC.
Feb 5 2019, 5:13 PM · KWin

Jan 29 2019

graesslin accepted D18594: [wayland] Drop Qt extended surface.

Ah I also had it on my to-do list as I noticed it in the internalclient branch.

Jan 29 2019, 4:00 PM · KWin

Jan 28 2019

graesslin added a comment to D18570: EGLStream DRM Backend Initial Implementation.

I really like that this is much more self contained than I expected. I haven't done an in depth review yet.

Jan 28 2019, 5:35 AM · KWin

Jan 27 2019

graesslin requested review of D18569: Split out a dedicated InternalClient class.
Jan 27 2019, 7:52 PM · KWin
graesslin committed R108:07e394fbb7e6: Fix unused param warning (authored by graesslin).
Fix unused param warning
Jan 27 2019, 1:04 PM
graesslin updated the diff for D17900: Introduce a dynamic enabled mode in virtual keyboard.

Now really update (git user error)

Jan 27 2019, 1:02 PM · KWin
graesslin updated the diff for D17900: Introduce a dynamic enabled mode in virtual keyboard.

Fix style - sorry that's $work coding style sneaking in

Jan 27 2019, 12:59 PM · KWin
graesslin added a comment to D17900: Introduce a dynamic enabled mode in virtual keyboard.

If there are no objections I'm going to push this

Jan 27 2019, 12:46 PM · KWin
graesslin added a comment to D18406: Silence warnings in TabBoxHandler.

gcc --version
gcc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Jan 27 2019, 12:34 PM · KWin
graesslin requested review of D18564: Remove support for KWin's QPA plugin for KWindowSystem.
Jan 27 2019, 12:30 PM · Plasma
graesslin committed R108:cfecb1e0770c: Fix reorder warning in AbstractScript (authored by graesslin).
Fix reorder warning in AbstractScript
Jan 27 2019, 12:26 PM
graesslin committed R108:2608026b8835: Silence warnings in TabBoxHandler (authored by graesslin).
Silence warnings in TabBoxHandler
Jan 27 2019, 12:26 PM
graesslin closed D18560: Fix reorder warning in AbstractScript.
Jan 27 2019, 12:26 PM · KWin
graesslin closed D18406: Silence warnings in TabBoxHandler.
Jan 27 2019, 12:26 PM · KWin
graesslin added a comment to D18406: Silence warnings in TabBoxHandler.
In D18406#400808, @zzag wrote:

Though I don't see -Wmaybe-uninitialized in my build logs.

Jan 27 2019, 11:37 AM · KWin
graesslin committed R108:932ccb2ac375: Switch ThumbnailItem to internal uuid instead of WId (authored by graesslin).
Switch ThumbnailItem to internal uuid instead of WId
Jan 27 2019, 9:06 AM
graesslin closed D18405: Switch ThumbnailItem to internal uuid instead of WId.
Jan 27 2019, 9:06 AM · KWin
graesslin committed R108:02a0561016c2: Add windowsystem plugin for KWin's qpa (authored by graesslin).
Add windowsystem plugin for KWin's qpa
Jan 27 2019, 9:06 AM
graesslin closed D18228: Add windowsystem plugin for KWin's qpa.
Jan 27 2019, 9:06 AM · KWin
graesslin requested review of D18560: Fix reorder warning in AbstractScript.
Jan 27 2019, 7:55 AM · KWin
graesslin added a comment to D18406: Silence warnings in TabBoxHandler.

Now I have the warnings again:

Jan 27 2019, 7:45 AM · KWin

Jan 26 2019

graesslin accepted D18495: Check rules in AbstractClient::setSkipTaskbar.
Jan 26 2019, 6:57 AM · KWin
graesslin added a comment to D18494: [wayland] Discard Force Temporarily rules for shell clients.

sure!

Jan 26 2019, 6:56 AM · KWin
graesslin accepted D18515: Bump to Qt5.12 - Drop kwin's custom ServerSideDecorationManager interface.
Jan 26 2019, 6:25 AM · Plasma

Jan 25 2019

graesslin added a comment to T9996: Improve Thumbnail Aside effect.

I fully agree with Vlad and David: this is not a feature belonging into the compositor and we should not drive by trying to copy features (badly). KWin's mission statement discourages to do so. We had huge problems in the past trying to please too many and failing.

Jan 25 2019, 5:30 AM · KDE Promo, VDG, KWin

Jan 24 2019

graesslin added a comment to D18494: [wayland] Discard Force Temporarily rules for shell clients.

Hmm... I would say we need to figure out the intention behind force temporarily and whether this concept can be mapped to Wayland.

Jan 24 2019, 5:33 PM · KWin
graesslin added inline comments to D18464: [autotests] Rewrite testShellClientRules.
Jan 24 2019, 2:17 PM · KWin
graesslin added a comment to D18496: [wayland] Make clients with forced minimize state unminimizeable.

Could you please add a test case

Jan 24 2019, 2:09 PM · KWin
graesslin added a comment to D18494: [wayland] Discard Force Temporarily rules for shell clients.

Could you please add this to the test case. IIRC we have already a few tests for force temporary.

Jan 24 2019, 2:08 PM · KWin