graesslin (Martin Flöser)
KWin developer

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 8:19 AM (191 w, 1 d)
Availability
Available

Recent Activity

Sat, Dec 15

graesslin requested review of D17601: Drop the COMPLIANCE file.
Sat, Dec 15, 12:28 PM · KWin
graesslin requested review of D17600: Introduce a new HACKING.md document to replace the previous HACKING.
Sat, Dec 15, 12:15 PM · KWin

Fri, Dec 14

graesslin added inline comments to D17544: virtualkeyboard: report the size of the inputwindow.
Fri, Dec 14, 4:26 PM · KWin
graesslin requested changes to D17577: Support for libinput Clickfinger and areas method.

Please also extend the unit test to verify the new functionality.

Fri, Dec 14, 4:22 PM · KWin
graesslin closed D17573: Fix the X11TimestampUpdateTest.
Fri, Dec 14, 4:12 PM · KWin
graesslin committed R108:c3e712e967bd: Fix the X11TimestampUpdateTest (authored by graesslin).
Fix the X11TimestampUpdateTest
Fri, Dec 14, 4:12 PM
graesslin requested review of D17573: Fix the X11TimestampUpdateTest.
Fri, Dec 14, 6:10 AM · KWin
graesslin accepted D17570: [wayland] Minimize transients together with parent.
Fri, Dec 14, 5:11 AM · KWin

Thu, Dec 13

graesslin committed R108:3e62f6aabeba: Remove no longer needed cast to Client in Workspace::sendClientToDesktop (authored by graesslin).
Remove no longer needed cast to Client in Workspace::sendClientToDesktop
Thu, Dec 13, 6:44 PM
graesslin committed R108:ba0cf19286bc: Fix dbus export of property Device::supportedButtons (authored by graesslin).
Fix dbus export of property Device::supportedButtons
Thu, Dec 13, 6:44 PM
graesslin closed D17546: Remove no longer needed cast to Client in Workspace::sendClientToDesktop.
Thu, Dec 13, 6:44 PM · KWin
graesslin committed R108:c8ede9a5ff97: Build platform plugins in correct sub directory of build dir (authored by graesslin).
Build platform plugins in correct sub directory of build dir
Thu, Dec 13, 6:44 PM
graesslin closed D17472: Fix dbus export of property Device::supportedButtons.
Thu, Dec 13, 6:44 PM · KWin
graesslin closed D17388: Build platform plugins in correct sub directory of build dir.
Thu, Dec 13, 6:44 PM · KWin
graesslin committed R108:a0b482cbabbc: Introduce a command line option to disable any kind of global shortcuts (authored by graesslin).
Introduce a command line option to disable any kind of global shortcuts
Thu, Dec 13, 6:44 PM
graesslin closed D17304: Introduce a command line option to disable any kind of global shortcuts.
Thu, Dec 13, 6:44 PM · KWin
graesslin committed R108:070b46f45566: Hide mouse cursor when interacting with touch screen (authored by graesslin).
Hide mouse cursor when interacting with touch screen
Thu, Dec 13, 6:44 PM
graesslin closed D17280: Hide mouse cursor when interacting with touch screen.
Thu, Dec 13, 6:44 PM · KWin
graesslin accepted D17565: [libkwineffects] Don't mark a painted window as transformed twice.
Thu, Dec 13, 4:37 PM · KWin
graesslin added inline comments to D17544: virtualkeyboard: report the size of the inputwindow.
Thu, Dec 13, 4:37 PM · KWin
graesslin requested changes to D17544: virtualkeyboard: report the size of the inputwindow.
Thu, Dec 13, 4:35 PM · KWin

Wed, Dec 12

graesslin added a comment to D17544: virtualkeyboard: report the size of the inputwindow.

course the scaling of the surface needs to be considered.

It doesn't, API states surface-local.

Wed, Dec 12, 6:13 PM · KWin
graesslin added inline comments to D17546: Remove no longer needed cast to Client in Workspace::sendClientToDesktop.
Wed, Dec 12, 5:53 PM · KWin
graesslin added a comment to D17544: virtualkeyboard: report the size of the inputwindow.

I also realized that I am passing this wrong information, I am passing it just keyboard position, which is not what client is interested in if I understand it correctly.

Wed, Dec 12, 5:50 PM · KWin
graesslin added a comment to D17537: Unset touch targets on no current touch points.

Thanks for looking into it.

Wed, Dec 12, 5:45 PM · KWin
graesslin accepted D17526: [autotests] Test window open/close animations.
Wed, Dec 12, 5:44 PM · KWin
graesslin requested review of D17546: Remove no longer needed cast to Client in Workspace::sendClientToDesktop.
Wed, Dec 12, 5:28 PM · KWin

Tue, Dec 11

graesslin added inline comments to D17388: Build platform plugins in correct sub directory of build dir.
Tue, Dec 11, 4:21 PM · KWin
graesslin added a comment to D17483: fix virtual keyboard on Plasma Mobile.

I think to say hide the button on mobile is the wrong conclusion. You need to hide it because it overlaps. So hide it based on size. That would also be useful on desktop and not only on mobile.

Tue, Dec 11, 5:15 AM · KWin
graesslin added a comment to D17483: fix virtual keyboard on Plasma Mobile.

This introduces a new dependency on KWin

It doesn't.
We already link Plasma in Core, that has already dependency on Kirigami.

Tue, Dec 11, 5:12 AM · KWin

Mon, Dec 10

graesslin requested changes to D17483: fix virtual keyboard on Plasma Mobile.
Mon, Dec 10, 4:50 PM · KWin
graesslin reopened D17483: fix virtual keyboard on Plasma Mobile.

Guys, code review doesn't make sense if one mobile dev opens a change for another mobile dev and the whole thing gets pushed in five minutes. This gives nobody else a chance to comment. If you want to operate like that you can just omit the review.

Mon, Dec 10, 4:50 PM · KWin
graesslin added a comment to D17472: Fix dbus export of property Device::supportedButtons.

It might be required to also adjust the KCM. I haven't tested yet against a running KWin. Also I think this is a candidate for backport to LTS release as we get complaints about non functional touchpad kcm.

Mon, Dec 10, 10:15 AM · KWin
graesslin requested review of D17472: Fix dbus export of property Device::supportedButtons.
Mon, Dec 10, 10:14 AM · KWin

Sat, Dec 8

graesslin requested review of D17433: Add a dbus method getWindowInfo returning same data as queryWindowInfo.
Sat, Dec 8, 4:11 PM · KWin
graesslin added a comment to D17426: [effects] Drop static_cast in getMainWindows.
In D17426#373168, @zzag wrote:

@graesslin Can I land this revision? Or I should wait until all tests pass again?

Sat, Dec 8, 12:59 PM · KWin
graesslin accepted D17426: [effects] Drop static_cast in getMainWindows.
Sat, Dec 8, 12:24 PM · KWin

Thu, Dec 6

graesslin requested review of D17388: Build platform plugins in correct sub directory of build dir.
Thu, Dec 6, 5:40 PM · KWin

Wed, Dec 5

graesslin updated the diff for D17369: Add touch support to x11 windowed platform.

Q_UNUSED

Wed, Dec 5, 8:35 PM · KWin
graesslin added inline comments to D17369: Add touch support to x11 windowed platform.
Wed, Dec 5, 8:07 PM · KWin
graesslin requested review of D17369: Add touch support to x11 windowed platform.
Wed, Dec 5, 6:13 PM · KWin

Tue, Dec 4

graesslin accepted D17353: Use appropriate sequence algorithms in IdleInhibition.
Tue, Dec 4, 6:36 PM · KWin
graesslin added inline comments to D17343: [wayland] Don't honor the idle inhibitor object if the surface is not visible.
Tue, Dec 4, 6:34 PM · KWin
graesslin added inline comments to D17343: [wayland] Don't honor the idle inhibitor object if the surface is not visible.
Tue, Dec 4, 5:09 PM · KWin

Mon, Dec 3

graesslin added a comment to D17304: Introduce a command line option to disable any kind of global shortcuts.

Well, I would certainly not want to expose a config option to disable VT switching. I think for e.g. a Plasma session that's a must have, for an embedded system it's a no-go.

Mon, Dec 3, 8:05 PM · KWin
graesslin added a comment to D17304: Introduce a command line option to disable any kind of global shortcuts.
In D17304#370672, @apol wrote:

Wouldn't this make more sense as a KConfig setting to override through kiosk?

Mon, Dec 3, 4:17 PM · KWin
graesslin accepted D17319: Update about data.
Mon, Dec 3, 5:16 AM · KWin

Sun, Dec 2

graesslin added inline comments to D17319: Update about data.
Sun, Dec 2, 7:04 PM · KWin
graesslin accepted D17311: Make sure that effect windows outlive effects.
Sun, Dec 2, 4:29 PM · KWin
graesslin accepted D17306: [scenes/opengl] Cleanup cached decoration shadow textures when suspending compositing.
Sun, Dec 2, 3:35 PM · KWin
graesslin added a comment to D17311: Make sure that effect windows outlive effects.

Are you sure that nothing in windowClosed and finishCompositing accesses EffectsHandler?

Sun, Dec 2, 3:34 PM · KWin
graesslin added a comment to T10069: KWin tests are flaky if CI system is under heavy load.

During last scripty run we had one random failure again: https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/221/

Sun, Dec 2, 3:28 PM · build.kde.org
graesslin updated the diff for D17280: Hide mouse cursor when interacting with touch screen.

Add missing copyright headers.

Sun, Dec 2, 3:24 PM · KWin
graesslin added a comment to D17304: Introduce a command line option to disable any kind of global shortcuts.

A more concrete example is the old idea of using KWin in sddm.

Sun, Dec 2, 2:45 PM · KWin
graesslin added a comment to D17280: Hide mouse cursor when interacting with touch screen.
In D17280#369946, @zzag wrote:

Wouldn't it be better to have TouchHideCursorSpy in input.cpp?

Sun, Dec 2, 2:34 PM · KWin
graesslin added a comment to D17304: Introduce a command line option to disable any kind of global shortcuts.

when KWin is just used as a compositor for one application

Do you have a specific use case in mind?

Sun, Dec 2, 2:31 PM · KWin
graesslin requested review of D17304: Introduce a command line option to disable any kind of global shortcuts.
Sun, Dec 2, 12:21 PM · KWin

Sat, Dec 1

graesslin added a comment to T10069: KWin tests are flaky if CI system is under heavy load.

Thanks a lot. This seems to be working - at least running the tests takes significantly more time and the last 4 build succeeded.

Sat, Dec 1, 6:23 PM · build.kde.org
graesslin committed R108:37060a6dd958: Add command line option no-lockscreen to disable lock screen integration (authored by graesslin).
Add command line option no-lockscreen to disable lock screen integration
Sat, Dec 1, 6:12 PM
graesslin closed D17279: Add command line option no-lockscreen to disable lock screen integration.
Sat, Dec 1, 6:12 PM · KWin
graesslin accepted D17283: [effects] Clean up effect_order in unloadAllEffects.
Sat, Dec 1, 5:05 PM · KWin
graesslin requested review of D17280: Hide mouse cursor when interacting with touch screen.
Sat, Dec 1, 1:54 PM · KWin
graesslin requested review of D17279: Add command line option no-lockscreen to disable lock screen integration.
Sat, Dec 1, 12:21 PM · KWin
graesslin committed R108:3ad9ac7229ff: Introduce the concept of an internal window system independent id (authored by graesslin).
Introduce the concept of an internal window system independent id
Sat, Dec 1, 11:20 AM
graesslin closed D16986: Introduce the concept of an internal window system independent id.
Sat, Dec 1, 11:20 AM · KWin
graesslin committed R108:f8459a71ccac: Switch lockscreen test to OpenGL (authored by graesslin).
Switch lockscreen test to OpenGL
Sat, Dec 1, 11:20 AM
graesslin closed D16940: Switch lockscreen test to OpenGL.
Sat, Dec 1, 11:20 AM · KWin
graesslin committed R108:98ddb93dfe83: Unset all env variables related to KDE session in integration tests (authored by graesslin).
Unset all env variables related to KDE session in integration tests
Sat, Dec 1, 11:20 AM
graesslin committed R108:260646ed6260: Delete kglobalshortcutsrc before executing a test (authored by graesslin).
Delete kglobalshortcutsrc before executing a test
Sat, Dec 1, 11:20 AM
graesslin closed D16939: Unset all env variables related to KDE session in integration tests.
Sat, Dec 1, 11:20 AM · KWin
graesslin committed R108:fa4f123fba2e: Add button to dynamically resize virtual keyboard (authored by graesslin).
Add button to dynamically resize virtual keyboard
Sat, Dec 1, 11:20 AM
graesslin closed D16932: Delete kglobalshortcutsrc before executing a test.
Sat, Dec 1, 11:20 AM · KWin
graesslin closed D16485: Add button to dynamically resize virtual keyboard.
Sat, Dec 1, 11:20 AM · KWin
graesslin committed R108:46eceef299b5: [opengl] Drop functionality to start kcmshell compositing (authored by graesslin).
[opengl] Drop functionality to start kcmshell compositing
Sat, Dec 1, 11:20 AM
graesslin closed D13235: [opengl] Drop functionality to start kcmshell compositing.
Sat, Dec 1, 11:20 AM · KWin
graesslin abandoned D16868: Fix VirtualDesktopTest after fixing semantics of AbstractClient::setDesktop.
Sat, Dec 1, 10:41 AM · KWin

Thu, Nov 29

graesslin accepted D17227: [wayland] Check presence of the inhibitor object when a client is registered in IdleInhibition.
Thu, Nov 29, 3:46 PM · KWin

Wed, Nov 28

graesslin added a comment to D17097: [scripting] Emit clientAdded for Wayland clients.
In D17097#366223, @zzag wrote:

The problem with the approach is that we cannot secure the kwinrc to which it is written. So the whole thing doesn't really work as long as all processes can write kwinrc. On the other hand it could protect properly sandboxed flatpacks.

Could we use kwallet for such a purpose? Also, do web browsers try to secure the list of enabled extensions?

Wed, Nov 28, 8:00 PM · KWin
graesslin added a comment to D17217: Implement free memory notifier.

I don't think that this is useful - sorry. I run out of memory about once every five years, so polling every five seconds is way too often and a waste of resources. On the other hand the time when it happens polling 5 sec is way too low as then we are already dead. This can only happen if an application eats memory and then it's going fast.

Wed, Nov 28, 5:44 PM · Plasma

Sat, Nov 24

graesslin added a comment to T10069: KWin tests are flaky if CI system is under heavy load.

As we want to be able to run ctest as developers I think it would be better if the CI would do the check.

Sat, Nov 24, 3:19 PM · build.kde.org
graesslin accepted D17069: [x11] Emit clientRemoved after client was removed.

Ok, just git blamed it. It was the scripting merge (previous version which has hardly anything to do with todays scripting) and that one had signals at a few stupid points. Also the signals were just added for scripting, so shouldn't be connected somewhere else.

Sat, Nov 24, 10:10 AM · KWin
graesslin added a comment to D17097: [scripting] Emit clientAdded for Wayland clients.
In D17097#364320, @zzag wrote:

(e.g. dedicated permissions for accessing dbus).

So, it would be something similar to what web browsers have when it comes to extensions(e.g. "Access your data for all websites", "Read and modify privacy settings", etc)?

Sat, Nov 24, 10:06 AM · KWin

Thu, Nov 22

graesslin added a comment to D17097: [scripting] Emit clientAdded for Wayland clients.

The main reason for not exposing Wayland clients to scripting was that this violates the Wayland security model. Through scripting api the complete windowing system is open again.

Thu, Nov 22, 5:17 PM · KWin
graesslin added a comment to T10069: KWin tests are flaky if CI system is under heavy load.

Sitting around and waiting sounds totally fine to me.

Thu, Nov 22, 5:12 PM · build.kde.org
graesslin added a comment to D17069: [x11] Emit clientRemoved after client was removed.

I'm wondering what the intention was to have it that early?

Thu, Nov 22, 5:29 AM · KWin
graesslin added a comment to D16710: [wayland] Fix window sizing when restoring a window that was initially fullscreen.

I would love to see a test case for it.

Thu, Nov 22, 5:27 AM · KWin
graesslin accepted D17087: Copy effective window type in Deleted.
Thu, Nov 22, 5:23 AM · KWin

Wed, Nov 21

graesslin added a comment to D16986: Introduce the concept of an internal window system independent id.
In D16986#363203, @zzag wrote:

Could you please also add qRegisterMetaType<KWn::Deleted *>() for both testX11Client and testShellClient?

Wed, Nov 21, 5:10 PM · KWin

Tue, Nov 20

graesslin updated the diff for D16986: Introduce the concept of an internal window system independent id.

Move the X11 test

Tue, Nov 20, 5:04 PM · KWin

Mon, Nov 19

graesslin added a comment to D16979: Add test case for apply initial size of X11 window.
In D16979#361761, @zzag wrote:

Shot in the dark: could it be that Kate configures the window size right after it was mapped?

Mon, Nov 19, 5:21 AM · KWin
graesslin added inline comments to D16986: Introduce the concept of an internal window system independent id.
Mon, Nov 19, 5:20 AM · KWin

Sun, Nov 18

graesslin updated the diff for D16945: Fix fallback to built-in ui.

Adjust in the way David suggested.

Sun, Nov 18, 7:22 PM · Plasma
graesslin requested review of D16986: Introduce the concept of an internal window system independent id.
Sun, Nov 18, 7:19 PM · KWin
graesslin requested review of D16979: Add test case for apply initial size of X11 window.
Sun, Nov 18, 2:43 PM · KWin

Sat, Nov 17

graesslin accepted D16955: [autotests] Hopefully stabilise TestShellClient.
xvfb-run ctest --output-on-failure --repeat-until-fail 10 -I 52,52 
Test project /home/martin/build/kde/workspace/kwin
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   29.80 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   29.90 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   30.02 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   29.96 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   30.00 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   30.00 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   30.01 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   29.99 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   29.99 sec
    Start 52: kwin-testShellClient
1/1 Test #52: kwin-testShellClient .............   Passed   30.02 sec
Sat, Nov 17, 12:49 PM · KWin
graesslin added a comment to D16955: [autotests] Hopefully stabilise TestShellClient.

I'll add the patch to my build and try to reproduce. I got the problem about every third run, so if it runs 10 times without failure I'll call it success

Sat, Nov 17, 12:36 PM · KWin
graesslin accepted D16448: [libkwineffects] Port AnimationEffect to TimeLine.
Sat, Nov 17, 11:41 AM · KWin
graesslin accepted D16447: [libkwineffects] Introduce timeline redirect modes.
Sat, Nov 17, 11:41 AM · KWin
graesslin created T10069: KWin tests are flaky if CI system is under heavy load.
Sat, Nov 17, 9:56 AM · build.kde.org
graesslin closed T6105: Use sensor to detect screen rotation as Resolved.

Implemented

Sat, Nov 17, 9:47 AM · KWin