graesslin (Martin Flöser)
KWin maintainer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 8:19 AM (118 w, 1 d)
Availability
Available

Recent Activity

Today

graesslin added inline comments to D6847: Hide the Linux specific parts behind a operating system check..
Sun, Jul 23, 3:52 PM · KWin
graesslin committed R108:7eb05552ca0d: Reset most_recently_raised when removing ShellClient (authored by graesslin).
Reset most_recently_raised when removing ShellClient
Sun, Jul 23, 3:31 PM
graesslin closed D6853: Reset most_recently_raised when removing ShellClient by committing R108:7eb05552ca0d: Reset most_recently_raised when removing ShellClient.
Sun, Jul 23, 3:31 PM · KWin
graesslin created D6853: Reset most_recently_raised when removing ShellClient.
Sun, Jul 23, 3:24 PM · KWin
graesslin requested changes to D6847: Hide the Linux specific parts behind a operating system check..
Sun, Jul 23, 3:20 PM · KWin
graesslin committed R108:bd158a632100: Reset last_active_client when a ShellClient is removed (authored by graesslin).
Reset last_active_client when a ShellClient is removed
Sun, Jul 23, 3:03 PM
graesslin closed D6852: Reset last_active_client when a ShellClient is removed by committing R108:bd158a632100: Reset last_active_client when a ShellClient is removed.
Sun, Jul 23, 3:03 PM · KWin
graesslin added a comment to D6852: Reset last_active_client when a ShellClient is removed.

there's 3 other differences between removeClient that I think should also be here:

yep I know, guess what I will work on next ;-)

Sun, Jul 23, 2:48 PM · KWin
graesslin created D6852: Reset last_active_client when a ShellClient is removed.
Sun, Jul 23, 2:21 PM · KWin
graesslin committed R108:dcbfa0869b36: [autotest] Add a test case for X11 fullscreen windows when an Wayland window is… (authored by graesslin).
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is…
Sun, Jul 23, 9:53 AM

Yesterday

graesslin created D6835: [effects] Exclude OSD windows from desktop grid.
Sat, Jul 22, 3:47 PM · KWin
graesslin added a comment to D6818: Implement support for window shortcuts for Wayland windows.

FYI: I figured out why the shortcut dialog does not work. It's an incorrect construction of the QKeyEvent which KWin uses internally and sends to QWindows and various other places. We convert the current key symbol to Qt:: Key and when a modifier key is released that doesn't change and that destroys the logic of the QKeySequenceEdit.

Sat, Jul 22, 10:57 AM · KWin
graesslin added a dependency for D6828: Send QKeyEvent with Qt::Key as expected by Qt to internal windows: D6818: Implement support for window shortcuts for Wayland windows.
Sat, Jul 22, 10:57 AM · Plasma
graesslin added a dependent revision for D6818: Implement support for window shortcuts for Wayland windows: D6828: Send QKeyEvent with Qt::Key as expected by Qt to internal windows.
Sat, Jul 22, 10:57 AM · KWin
graesslin created D6828: Send QKeyEvent with Qt::Key as expected by Qt to internal windows.
Sat, Jul 22, 10:56 AM · Plasma

Fri, Jul 21

graesslin added a comment to D6818: Implement support for window shortcuts for Wayland windows.

FYI: I figured out why the shortcut dialog does not work. It's an incorrect construction of the QKeyEvent which KWin uses internally and sends to QWindows and various other places. We convert the current key symbol to Qt:: Key and when a modifier key is released that doesn't change and that destroys the logic of the QKeySequenceEdit.

Fri, Jul 21, 7:29 PM · KWin
graesslin created D6818: Implement support for window shortcuts for Wayland windows.
Fri, Jul 21, 6:25 PM · KWin
graesslin added a dependency for D6811: Use std::bind expression for Workspace::slotWindowtoDesktop: D6783: Replace Workspace::slotWindowQuickTileFoo by a quickTileWindow with argument.
Fri, Jul 21, 2:12 PM · Plasma
graesslin added a dependent revision for D6783: Replace Workspace::slotWindowQuickTileFoo by a quickTileWindow with argument: D6811: Use std::bind expression for Workspace::slotWindowtoDesktop.
Fri, Jul 21, 2:12 PM · KWin
graesslin created D6811: Use std::bind expression for Workspace::slotWindowtoDesktop.
Fri, Jul 21, 2:11 PM · Plasma
graesslin closed D6569: [client] Track all created ConnectionThreads and add API to access them by committing R127:e4c90bf90717: [client] Track all created ConnectionThreads and add API to access them.
Fri, Jul 21, 5:15 AM · Plasma on Wayland, Frameworks
graesslin committed R127:706a4771803d: [server] Send text input leave if focused surface gets unbound (authored by graesslin).
[server] Send text input leave if focused surface gets unbound
Fri, Jul 21, 5:15 AM
graesslin committed R127:e4c90bf90717: [client] Track all created ConnectionThreads and add API to access them (authored by graesslin).
[client] Track all created ConnectionThreads and add API to access them
Fri, Jul 21, 5:15 AM
graesslin closed D6786: [server] Send text input leave if focused surface gets unbound by committing R127:706a4771803d: [server] Send text input leave if focused surface gets unbound.
Fri, Jul 21, 5:14 AM · Frameworks, Plasma on Wayland
graesslin committed R108:8cd95b56e3f3: [autotests] Add test case for sending window to desktop shortcuts (authored by graesslin).
[autotests] Add test case for sending window to desktop shortcuts
Fri, Jul 21, 5:13 AM
graesslin accepted D6798: [platforms/fbdev] Support for RGBA8888 color format.
Fri, Jul 21, 4:30 AM · KWin

Thu, Jul 20

graesslin committed R108:b1efdbaaf1bc: [autotest] Test opposite direction in switchWindow (authored by graesslin).
[autotest] Test opposite direction in switchWindow
Thu, Jul 20, 7:52 PM
graesslin committed R108:84b0578a7173: [autotests] Add test cases for switchWindow (authored by graesslin).
[autotests] Add test cases for switchWindow
Thu, Jul 20, 6:51 PM
graesslin added a comment to D6799: Apply maximize effect to full screen changes.

If we do this we need to rename the effect - it is no longer a maximize effect. Otherwise I'm surprised of how little impact it has on the code base.

Thu, Jul 20, 6:05 PM · KWin
graesslin created D6802: Call Platform::setupActionForGlobalAccel on the Client shortcut.
Thu, Jul 20, 5:15 PM · KWin
graesslin created D6801: Replace delegate slots for window shortcut by std::bind expressions.
Thu, Jul 20, 5:10 PM · KWin
graesslin committed R108:c9fa43e9db13: [autotests] Add test case for Client window shortcut (authored by graesslin).
[autotests] Add test case for Client window shortcut
Thu, Jul 20, 5:00 PM
graesslin abandoned D6654: [krunner] Perform Wayland integration in show not expose event.
Thu, Jul 20, 1:50 PM · Plasma
graesslin created D6791: Drop the Workspace::slotSwitchWindowFoo methods.
Thu, Jul 20, 5:13 AM · Plasma

Wed, Jul 19

graesslin committed R120:e967385b0a58: [krunner] First set panel behavior than as panel (authored by graesslin).
[krunner] First set panel behavior than as panel
Wed, Jul 19, 6:20 PM
graesslin closed D6657: [krunner] First set panel behavior than as panel by committing R120:e967385b0a58: [krunner] First set panel behavior than as panel.
Wed, Jul 19, 6:20 PM · Plasma
graesslin created D6786: [server] Send text input leave if focused surface gets unbound.
Wed, Jul 19, 6:17 PM · Frameworks, Plasma on Wayland
graesslin added a comment to D6657: [krunner] First set panel behavior than as panel.

Doesn't do any harm.

Was the original intention (before "the qt bug") to have shell surface set all it's states before the window gets mapped?

Wed, Jul 19, 6:11 PM · Plasma
graesslin added a dependency for D6785: Move bitCount from utils to GlxBackend: D6784: Move bitCount from utils to GlxBackend.
Wed, Jul 19, 5:55 PM · Plasma
graesslin added a dependent revision for D6784: Move bitCount from utils to GlxBackend: D6785: Move bitCount from utils to GlxBackend.
Wed, Jul 19, 5:55 PM · Plasma
graesslin created D6785: Move bitCount from utils to GlxBackend.
Wed, Jul 19, 5:55 PM · Plasma
graesslin updated the diff for D6784: Move bitCount from utils to GlxBackend.

Fix arc stupidity

Wed, Jul 19, 5:53 PM · Plasma
graesslin created D6784: Move bitCount from utils to GlxBackend.
Wed, Jul 19, 5:52 PM · Plasma
graesslin added a comment to D6657: [krunner] First set panel behavior than as panel.

ping! Anything speaking against this simple patch to make the situation better?

Wed, Jul 19, 5:52 PM · Plasma
graesslin created D6783: Replace Workspace::slotWindowQuickTileFoo by a quickTileWindow with argument.
Wed, Jul 19, 4:44 PM · KWin
graesslin committed R127:a00a5d5e1c97: [server] Send pointer leave if focused surface gets unbound (authored by graesslin).
[server] Send pointer leave if focused surface gets unbound
Wed, Jul 19, 5:13 AM
graesslin closed D6754: [server] Send pointer leave if focused surface gets unbound by committing R127:a00a5d5e1c97: [server] Send pointer leave if focused surface gets unbound.
Wed, Jul 19, 5:13 AM · Frameworks, Plasma on Wayland
graesslin added a comment to D6776: Don't perform wayland specific fixes when on X.

Your commit message has a typo where X is written but Wayland is meant.

Wed, Jul 19, 4:28 AM · Frameworks, Plasma

Tue, Jul 18

graesslin committed R108:81c59a86ddd8: [autotests] Try to make new QuickTilingTest addition more robust on CI (authored by graesslin).
[autotests] Try to make new QuickTilingTest addition more robust on CI
Tue, Jul 18, 7:31 PM
graesslin committed R108:bbbd2f6a24bb: [autotests/integration] Extend QuickTilingTest for keyboard shortcut and… (authored by graesslin).
[autotests/integration] Extend QuickTilingTest for keyboard shortcut and…
Tue, Jul 18, 7:11 PM

Mon, Jul 17

graesslin updated the diff for D6411: [platforms/x11] Use a GlxContextAttributeBuilder.

Rebased to master

Mon, Jul 17, 3:44 PM · KWin
graesslin committed R127:40c64757acd7: Drop unused variable (authored by graesslin).
Drop unused variable
Mon, Jul 17, 3:04 PM
graesslin created D6754: [server] Send pointer leave if focused surface gets unbound.
Mon, Jul 17, 3:01 PM · Frameworks, Plasma on Wayland
graesslin closed D6734: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context by committing R108:73fa7b21a187: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context.
Mon, Jul 17, 2:54 PM · KWin
graesslin committed R108:73fa7b21a187: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context (authored by graesslin).
[qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context
Mon, Jul 17, 2:54 PM
graesslin committed R108:ea5d611de1bc: Require C++14 (authored by graesslin).
Require C++14
Mon, Jul 17, 2:54 PM
graesslin closed D6634: Require C++14 by committing R108:ea5d611de1bc: Require C++14.
Mon, Jul 17, 2:54 PM · KWin
graesslin committed R108:8e2805ce9d4b: Merge branch 'Plasma/5.10' (authored by graesslin).
Merge branch 'Plasma/5.10'
Mon, Jul 17, 2:54 PM
graesslin committed R108:bf0e0f071ceb: [aurorae] Add support for shaded windows (authored by graesslin).
[aurorae] Add support for shaded windows
Mon, Jul 17, 2:52 PM
graesslin committed R108:139b4dc82a94: Properly swap the quick tile side when pressing the shortcut again (authored by graesslin).
Properly swap the quick tile side when pressing the shortcut again
Mon, Jul 17, 2:52 PM
graesslin closed D6708: Properly swap the quick tile side when pressing the shortcut again by committing R108:139b4dc82a94: Properly swap the quick tile side when pressing the shortcut again.
Mon, Jul 17, 2:52 PM · KWin
graesslin closed D6719: [aurorae] Add support for shaded windows by committing R108:bf0e0f071ceb: [aurorae] Add support for shaded windows.
Mon, Jul 17, 2:52 PM · Plasma
graesslin committed R108:5cb91762be43: [aurorae] Mark the render QQuickWindow as frameless (authored by graesslin).
[aurorae] Mark the render QQuickWindow as frameless
Mon, Jul 17, 2:52 PM
graesslin closed D6726: [aurorae] Mark the render QQuickWindow as frameless by committing R108:5cb91762be43: [aurorae] Mark the render QQuickWindow as frameless.
Mon, Jul 17, 2:52 PM · KWin
graesslin committed R108:06a558e3de65: [platforms/x11] Quit the OpenGL Freeze protection thread on shutdown (authored by graesslin).
[platforms/x11] Quit the OpenGL Freeze protection thread on shutdown
Mon, Jul 17, 2:52 PM
graesslin closed D6735: [platforms/x11] Quit the OpenGL Freeze protection thread on shutdown by committing R108:06a558e3de65: [platforms/x11] Quit the OpenGL Freeze protection thread on shutdown.
Mon, Jul 17, 2:52 PM · KWin
graesslin committed R127:bea87753629e: [client] Properly track enteredSurface in Keyboard (authored by graesslin).
[client] Properly track enteredSurface in Keyboard
Mon, Jul 17, 4:54 AM
graesslin closed D6741: [client] Properly track enteredSurface in Keyboard by committing R127:bea87753629e: [client] Properly track enteredSurface in Keyboard.
Mon, Jul 17, 4:54 AM · Frameworks, Plasma on Wayland
graesslin added inline comments to D6719: [aurorae] Add support for shaded windows.
Mon, Jul 17, 4:27 AM · Plasma

Sun, Jul 16

graesslin added a comment to D6734: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context.

Sort of offtopic: are you aware of the new(ish) QOpenGLContext::setNativeHandle() theoretically we can just wrap kwin's existing OpenGL context and not have to actually switch contexts.
(I tried for Aurorae on X, it didn't work out, but I can't remember why)

Sun, Jul 16, 7:26 PM · KWin
graesslin closed D6630: [kstyle] Do not delete the Surface for a QWindow.

https://commits.kde.org/breeze/e02fef0883af3d3b33ce8a9ea8677c82c1973975

Sun, Jul 16, 6:27 PM · Plasma
graesslin created D6741: [client] Properly track enteredSurface in Keyboard.
Sun, Jul 16, 6:25 PM · Frameworks, Plasma on Wayland
graesslin created D6735: [platforms/x11] Quit the OpenGL Freeze protection thread on shutdown.
Sun, Jul 16, 4:04 PM · KWin
graesslin created D6734: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context.
Sun, Jul 16, 3:33 PM · KWin
graesslin added a comment to D6727: Destroy all kwayland objects created by registry when it is destroyed.

We still need D6571, with my proposed change. That's a special case where we delete the connection before the QPA.

Sun, Jul 16, 2:29 PM · Frameworks, Plasma on Wayland
graesslin committed R127:98e5d269a110: [server] Send keyboard leave when client destroys the focused surface (authored by graesslin).
[server] Send keyboard leave when client destroys the focused surface
Sun, Jul 16, 2:26 PM
graesslin closed D6683: [server] Send keyboard leave when client destroys the focused surface by committing R127:98e5d269a110: [server] Send keyboard leave when client destroys the focused surface.
Sun, Jul 16, 2:25 PM · Plasma, Frameworks
graesslin updated the diff for D6719: [aurorae] Add support for shaded windows.

New approach to the problem

Sun, Jul 16, 2:01 PM · Plasma
graesslin added a comment to D6727: Destroy all kwayland objects created by registry when it is destroyed.

I like the idea! That would basically allow us to abandon D6571 and would also solve the issues we see with the kwayland-integration plugin which can crash applications on exit.

Sun, Jul 16, 1:31 PM · Frameworks, Plasma on Wayland

Sat, Jul 15

graesslin added inline comments to D6571: Delete all Wayland connections by plugins prior to own Wayland connection.
Sat, Jul 15, 7:56 PM · KWin
graesslin planned changes to D6719: [aurorae] Add support for shaded windows.

Unfortunately there are still themes which cause glitches.

Sat, Jul 15, 7:47 PM · Plasma
graesslin created D6726: [aurorae] Mark the render QQuickWindow as frameless.
Sat, Jul 15, 7:43 PM · KWin
graesslin updated the diff for D6683: [server] Send keyboard leave when client destroys the focused surface.

Add nullptr check to prevent crash

Sat, Jul 15, 7:03 PM · Plasma, Frameworks
graesslin planned changes to D6683: [server] Send keyboard leave when client destroys the focused surface.

Causes crash in KWayaland when closing a window.

Sat, Jul 15, 6:59 PM · Plasma, Frameworks
graesslin created D6719: [aurorae] Add support for shaded windows.
Sat, Jul 15, 5:03 PM · Plasma
graesslin added inline comments to D6659: [logind] Correct property name to fix logind session.
Sat, Jul 15, 9:01 AM · KWin
graesslin committed R108:58322c277892: Fix s_ck2ActiveProperty value (authored by graesslin).
Fix s_ck2ActiveProperty value
Sat, Jul 15, 9:01 AM
graesslin created D6708: Properly swap the quick tile side when pressing the shortcut again.
Sat, Jul 15, 7:00 AM · KWin

Thu, Jul 13

graesslin accepted D6660: [platforms/drm] Delete buffer on all errors in present.
Thu, Jul 13, 4:52 PM · KWin
graesslin added a comment to D6634: Require C++14.

openSUSE Leap 42.3 uses GCC 4.8 as default, although 5 and 6 are available as well.

Thu, Jul 13, 4:51 PM · KWin
graesslin accepted D6659: [logind] Correct property name to fix logind session.

That means my session worked again for at least a week! Wohoo the stability starts to reach the state of Pre-Qt 5.9

Thu, Jul 13, 4:50 PM · KWin
graesslin created D6683: [server] Send keyboard leave when client destroys the focused surface.
Thu, Jul 13, 3:49 PM · Plasma, Frameworks
graesslin updated the diff for D6569: [client] Track all created ConnectionThreads and add API to access them.

Make this compile. Looks like kdevelop fooled me and compiled KWin instead of KWayland (that happens all the time to me)

Thu, Jul 13, 3:38 PM · Plasma on Wayland, Frameworks
graesslin added a comment to D6657: [krunner] First set panel behavior than as panel.
In D6657#124801, @mart wrote:

does this overridex/fixes D6654?

Thu, Jul 13, 2:45 PM · Plasma
graesslin added a comment to D6657: [krunner] First set panel behavior than as panel.
In D6657#124685, @apol wrote:

Seems like this API is extremely brittle, would it be possible to make sure this is dealt with on the library side?

Thu, Jul 13, 4:18 AM · Plasma

Wed, Jul 12

graesslin created D6657: [krunner] First set panel behavior than as panel.
Wed, Jul 12, 7:08 PM · Plasma
graesslin planned changes to D6654: [krunner] Perform Wayland integration in show not expose event.

doesn't work

Wed, Jul 12, 6:51 PM · Plasma
graesslin created D6654: [krunner] Perform Wayland integration in show not expose event.
Wed, Jul 12, 4:42 PM · Plasma

Tue, Jul 11

graesslin added a reviewer for D6634: Require C++14: lbeltrame.
Tue, Jul 11, 6:31 PM · KWin
graesslin created D6634: Require C++14.
Tue, Jul 11, 6:31 PM · KWin