- User Since
- Apr 18 2015, 8:19 AM (157 w, 1 d)
There are users who only could get Egl to work. The setting was only removed as users "read on informed Internets" that it was better. For very few that's the case, for most it isn't. Nevertheless I don't think it would be good to break this for users who deliberately want to use it. From bug reports this is rather seldom a problem nowadays.
@bshah hwcomposer would also need adjustements, is that useful? Could we benefit from fractional scaling on hwcomposer?
Please note that the other animation time durations are also just random picked values. I doubt the random picked 250 is any better than the random picked 350.
The idea how the glide effect was implemented is to have this angle. The defaults have not been changed since the effect got introduced.
Sorry for the delay in review, I was on vacations.
Could you please document the new env variable in https://community.kde.org/KWin/Environment_Variables
Is it semantically correct to have this in KWin? Shouldn't that not be in the kded module so that it works in all variants of appmenu visualization?
Ah you are my hero! I was not understanding this bug and failed to reproduce it. Could you please add a small test case for it? should be relative straight forward and we have quite a few tests for global shortcuts already. And please mark bug 390110 as fixed, which also means I want this in 5.12 :-)
Sat, Apr 21
I'm pointing out that I'm in general against any risky changes on X11. If users want to use this features: Wayland is there. KWin is feature frozen on X11 and I highly suggest to the Plasma community to decide the same at the sprint. We will have less maintenance issues due to it.
I don't think that there's any reason to discard this. It's a start and improvement over the current situation and a fallback is needed anyway. So we start with the fallback instead of adding it later on.
Sorry, but I'm against this. The options keepass provides are just bullshit (sorry to be that direct). That cannot work and will not work. One cannot remove anything from the clipboard, trying to do so is insane. What would make most sense for things like clipboard is setting a mimetime like text/password. This could be used by Klipper to never add it to history. That would be a useful feature. But anything that just tries to support keepass's utterly broken workflow from an X11/Wayland and security point of view doesn't make any sense.
I also cannot imagine this to work due to the fact how X11 works. There is just no mapping from window to screen. No window can know on which screen it is. Not even KWin knows that as the window manager (screen is not a constant property, but evaluated every time it is accessed, it's based on the distance to closest screen). Especially for overlapping windows it's very difficult to try to get to which screen it belongs. It gets even more complicated when things like panning and overlapping screens get into it. So I wouldn't trust this thing in Qt to work due to the pain we have in KWin especially with these problems.
Mon, Apr 9
Sat, Apr 7
Btw could someone please push for me. I'm not around the next two weeks
Fri, Apr 6
Thu, Apr 5
I'm very much in favor of basing the complete KWin::Screens on top of this new class in the long run. Our current Screens class is a mess and with a dedicated Output we could even get to things like storing to which Output an AbstractClient belongs and keeping it there if screens change.
arc failed to apply this one. Could you please rebase again?
Could you please backport to Plasma/5.12 branch?
Wed, Apr 4
I'm not sure whether we can add elements to the states.
Fri, Mar 30
Thu, Mar 29
Wed, Mar 28
An env variable would not work for things like lock screen as the process starting the lock screen is started before Plasmashell.
Mon, Mar 26
I like this change
I'm against pushing to 5.8 - this is not a security issue.
Sun, Mar 25
Sat, Mar 24
Mar 23 2018
Mar 22 2018
In general I like the idea and that should be extended to Wayland as well, but private API is a no-no for breeze. That has huge runtime breakage potential.
Or just remove the assert.
Mar 21 2018
Mar 20 2018
Mar 19 2018
Mar 18 2018
As a note: there's currently work going on to change the theme config button: D11201
What's box header in your mockup?
Unfortunately the patch does not apply anymore to current KWin master :-(
For me it doesn't. It then tries to connect to github and asks for my github username and password. Which I don't have.