- User Since
- Apr 18 2015, 8:19 AM (149 w, 3 h)
Thu, Feb 22
Concerning the tests: the ones requiring OpenGL work best if module vgem is loaded. That normally makes them pass. The tests regarding keyboard layout need env variable XDG_DEFAULT_LAYOUT being unset or on us.
The quick tiling functionality is fully covered by unit tests. Please add a test case exposing the problem.
Wed, Feb 21
Tue, Feb 20
Mon, Feb 19
Hide buttons intead of disabling them
Tooltip is not possible, we are in string freeze. I can of course hide the button, but then users might be wondering where it has gone. Given that I doubt it makes much difference.
Sun, Feb 18
Fri, Feb 16
Remove unneeded comment
Thu, Feb 15
Wed, Feb 14
Tue, Feb 13
Sun, Feb 11
Sat, Feb 10
I'm against this change. The window is set to fullscreen, but that doesn't work due to a Qt bug. Let's not work around Qt bugs: https://bugreports.qt.io/browse/QTBUG-63748
Fri, Feb 9
Thu, Feb 8
Wed, Feb 7
Tue, Feb 6
To ensure we don't forget about it I created: https://bugs.kde.org/show_bug.cgi?id=389964
As the commit went into the 5.12 branch we cannot build up on any functionality not yet available in Dialog.
I really think this needs to be reverted. Krunner must be a dock, it must be set to windows go below and it must take focus. This is all functionality not provided by Plasma::Dialog. Just removing the code doesn't work unfortunately.
Please be aware that this will not work on Wayland. The modifier state is only available to the window which currently has keyboard focus. We either need a dedicated Wayland protocol to send all modifier changes to Plasma or some other way to have KWin feed in the state.
There is the panel behavior thing missing which used to be in the old code. A panel does not get keyboard focus. With the panel behavior that can be changed.
Mon, Feb 5
I'm a little bit late to the party, but F11is kind of the standard key for fullscreen.
Sun, Feb 4
I just verified with KWin's debug console: KRunner window is now marked as NET::Normal and not as NET::Dock. This is a problem, KRunner needs to be a dock.
I fear this broke some functionality of KRunner. It is important to be a dock window! Otherwise KRunner might not be able to go above fullscreen windows and won't be on all desktops. Also without being a PlasmaSurface the manual positioning cannot work. If it works for you, I fear it is pure chance.
Sat, Feb 3
Fri, Feb 2
Make m_device mutable and always lazy load it.
Thu, Feb 1
If nobody objects by Sunday I'm going to push this.
alternative approach in D10236
I had another idea: when the Event gets processed and the m_device is null, we just update it again from the event.