graesslin (Martin Flöser)
KWin maintainer

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 8:19 AM (135 w, 4 d)
Availability
Available

Recent Activity

Yesterday

graesslin added a comment to D8924: Move the KDE Polkit-Agent into ksmserver.
In D8924#170463, @apol wrote:

This creates a "slight" problem for Wayland as ksmserver is forced to XCB. What do you think about doing it like with kscreenlocker? On X11 ksmserver, on Wayland KWin? Otherwise +1000 to this suggestion.

Isn't the solution to stop forcing ksmserver to XCB?

Wed, Nov 22, 7:01 PM · Plasma
graesslin accepted D8938: Honor animationsSupported in minimize, slide and sliding popups effects.
Wed, Nov 22, 6:59 PM · KWin
graesslin added a comment to D8682: Improve some strings and UI elements in KWin KCM.

@graesslin, is this looking okay now?

Wed, Nov 22, 6:28 PM · KWin
graesslin created D8956: Implement geometry update blocking in ShellClient.
Wed, Nov 22, 6:25 PM · KWin

Tue, Nov 21

graesslin committed R108:1c61e61119f3: [autotests] Support new way to run the tests without need to install (authored by graesslin).
[autotests] Support new way to run the tests without need to install
Tue, Nov 21, 7:35 PM
graesslin closed D7543: [autotests] Support new way to run the tests without need to install.
Tue, Nov 21, 7:35 PM · Plasma
graesslin committed R108:f8be3f746ba9: [effects] Delay creation of EffectFrames in WindowGeometryEffect (authored by graesslin).
[effects] Delay creation of EffectFrames in WindowGeometryEffect
Tue, Nov 21, 6:28 PM
graesslin closed D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect.
Tue, Nov 21, 6:28 PM · KWin
graesslin committed R108:d4ba05a22f86: [autotests] Add tests for DRM platform plugin (authored by graesslin).
[autotests] Add tests for DRM platform plugin
Tue, Nov 21, 6:28 PM
graesslin closed D8776: [autotests] Add tests for DRM platform plugin.
Tue, Nov 21, 6:28 PM · Plasma
graesslin added a comment to D8924: Move the KDE Polkit-Agent into ksmserver.

This creates a "slight" problem for Wayland as ksmserver is forced to XCB. What do you think about doing it like with kscreenlocker? On X11 ksmserver, on Wayland KWin? Otherwise +1000 to this suggestion.

Tue, Nov 21, 5:01 PM · Plasma

Mon, Nov 20

graesslin added inline comments to D8919: Add explicit AppMenu protocol.
Mon, Nov 20, 9:01 PM · Frameworks, Plasma on Wayland
graesslin added a comment to D8919: Add explicit AppMenu protocol.

Looks good, just a few minor comments.

Mon, Nov 20, 8:02 PM · Frameworks, Plasma on Wayland
graesslin committed R108:45ac8eed34bc: Merge branch 'Plasma/5.11' (authored by graesslin).
Merge branch 'Plasma/5.11'
Mon, Nov 20, 5:13 PM
graesslin committed R108:9300aa82be77: Allow glXChooseFBConfig to return sRGB capable fbconfig (authored by Pierre Willenbrock <pierre@pirsoft.de>).
Allow glXChooseFBConfig to return sRGB capable fbconfig
Mon, Nov 20, 5:13 PM
graesslin accepted D8796: Support dynamic output enabling/disabling from KScreen.
Mon, Nov 20, 4:34 PM · KWin

Sun, Nov 19

graesslin accepted D8887: Fix leaking of FDs requested from logind.
Sun, Nov 19, 1:22 PM · Plasma
graesslin added a comment to D8888: Fix race condition with libinput events on startup.
In D8888#169518, @fvogt wrote:

Should this go into Plasma/5.11 as well?

Sun, Nov 19, 11:11 AM · KWin
graesslin added a comment to D8887: Fix leaking of FDs requested from logind.
In D8887#169520, @fvogt wrote:

Should this go into Plasma/5.11 (probably even 5.8) as well?

Sun, Nov 19, 11:10 AM · Plasma
graesslin accepted D8888: Fix race condition with libinput events on startup.
Sun, Nov 19, 8:10 AM · KWin
graesslin added inline comments to D8887: Fix leaking of FDs requested from logind.
Sun, Nov 19, 8:07 AM · Plasma

Fri, Nov 17

graesslin added inline comments to D8796: Support dynamic output enabling/disabling from KScreen.
Fri, Nov 17, 2:52 PM · KWin
graesslin requested changes to D8858: Fix testWaylandFullscreenShell..

Could you please add a message that it is missing?

Fri, Nov 17, 5:25 AM · Frameworks, Plasma on Wayland

Thu, Nov 16

graesslin created D8856: Add support for new IdleInhibition protocol.
Thu, Nov 16, 8:51 PM · KWin
graesslin committed R108:f0f4e494fe38: Merge branch 'Plasma/5.11' (authored by graesslin).
Merge branch 'Plasma/5.11'
Thu, Nov 16, 7:35 PM
graesslin committed R108:1ae7990a959c: Allow a cross-process check for same applications (authored by graesslin).
Allow a cross-process check for same applications
Thu, Nov 16, 7:34 PM
graesslin closed D8661: Allow a cross-process check for same applications.
Thu, Nov 16, 7:34 PM · KWin
graesslin committed R127:9520c2f292d0: Add support for zwp_idle_inhibit_manager_v1 (authored by graesslin).
Add support for zwp_idle_inhibit_manager_v1
Thu, Nov 16, 7:23 PM
graesslin closed D8396: Add support for zwp_idle_inhibit_manager_v1.
Thu, Nov 16, 7:23 PM · Frameworks, Plasma on Wayland
graesslin added a comment to D8845: Create tooltipManager on demand.

Look in the constructor, kept it consistent

Thu, Nov 16, 4:46 PM · Plasma
graesslin added inline comments to D8845: Create tooltipManager on demand.
Thu, Nov 16, 4:40 PM · Plasma

Wed, Nov 15

graesslin added a comment to D8396: Add support for zwp_idle_inhibit_manager_v1.

I think we need some big discussion about how powerdevil inhbitions, logind inhibitions and this are all going to fit together in a clear coherent way.

Wed, Nov 15, 8:25 PM · Frameworks, Plasma on Wayland
graesslin added inline comments to D8776: [autotests] Add tests for DRM platform plugin.
Wed, Nov 15, 8:19 PM · Plasma
graesslin accepted D8828: Honour the preferred mode flag in the kwayland backend.
Wed, Nov 15, 5:19 PM · Plasma
graesslin added a comment to D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect.

As I just made my kwin crash just to get the backtrace I'm adding nevertheless:

Wed, Nov 15, 4:55 PM · KWin
graesslin added a comment to D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect.

New test case added which crashes without this fix.

I wanted to see the backtrace of what we're working round, so applied just the test and not the changes to the effect.
It didn't crash. Any ideas?

Wed, Nov 15, 4:40 PM · KWin

Tue, Nov 14

graesslin created D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect.
Tue, Nov 14, 7:18 PM · KWin
graesslin committed R108:48f7331c4c1d: Merge branch 'Plasma/5.11' (authored by graesslin).
Merge branch 'Plasma/5.11'
Tue, Nov 14, 5:04 PM
graesslin committed R108:5313b8564680: Support modifier+mouse button on window decoration (authored by graesslin).
Support modifier+mouse button on window decoration
Tue, Nov 14, 5:04 PM
graesslin closed D8758: Support modifier+mouse button on window decoration.
Tue, Nov 14, 5:04 PM · KWin
graesslin committed R108:188491d39221: Support user fullscreen for XdgShellSurfaces (authored by graesslin).
Support user fullscreen for XdgShellSurfaces
Tue, Nov 14, 5:02 PM
graesslin committed R108:9a965405e3ea: Support updating deco for changes of borderless maximize windows config (authored by graesslin).
Support updating deco for changes of borderless maximize windows config
Tue, Nov 14, 5:02 PM
graesslin closed D8169: Support user fullscreen for XdgShellSurfaces.
Tue, Nov 14, 5:01 PM · KWin
graesslin closed D8095: Support updating deco for changes of borderless maximize windows config.
Tue, Nov 14, 5:01 PM · KWin
graesslin added a comment to D8661: Allow a cross-process check for same applications.

ping

Tue, Nov 14, 5:01 PM · KWin
graesslin committed R127:42b2daaec407: [server] Support inhibiting the IdleInterface (authored by graesslin).
[server] Support inhibiting the IdleInterface
Tue, Nov 14, 4:44 PM
graesslin closed D8383: [server] Support inhibiting the IdleInterface.
Tue, Nov 14, 4:44 PM · Frameworks, Plasma on Wayland
graesslin added a comment to D8396: Add support for zwp_idle_inhibit_manager_v1.

ping

Tue, Nov 14, 4:42 PM · Frameworks, Plasma on Wayland

Mon, Nov 13

graesslin accepted D8794: Split init'ing the wayland output from init.
Mon, Nov 13, 8:22 PM · KWin
graesslin committed R108:c601e875cfa7: [platforms/drm] At safety checks for the properties (authored by graesslin).
[platforms/drm] At safety checks for the properties
Mon, Nov 13, 8:20 PM
graesslin closed D8752: [platforms/drm] At safety checks for the properties.
Mon, Nov 13, 8:19 PM · Plasma
graesslin added a comment to D8796: Support dynamic output enabling/disabling from KScreen.

Does KScreen allow to disable all screens? And if yes: how does KWin behave in this case? I had been thinking about this for some time and are not sure how KWin should handle this situation. I can see reasons to say "user asked for it, so all screens should go off" and I can see reason to say "that's an invalid configuration request: ignore".

Mon, Nov 13, 8:18 PM · KWin
graesslin accepted D8779: Avoid hypothetical crash if output->init fails.

misclicked, wanted to accept it.

Mon, Nov 13, 4:35 PM · KWin
graesslin requested changes to D8779: Avoid hypothetical crash if output->init fails.
Mon, Nov 13, 4:17 PM · KWin
graesslin added inline comments to D8758: Support modifier+mouse button on window decoration.
Mon, Nov 13, 4:16 PM · KWin
graesslin added inline comments to D8748: [libinput] Find screen for touch screen devices and calibrate accordingly.
Mon, Nov 13, 5:30 AM · KWin
graesslin updated subscribers of D8752: [platforms/drm] At safety checks for the properties.
In D8752#166896, @fvogt wrote:

I don't remember seeing any of those issues before AMS got added.
Only issue 1 disappears with KWIN_DRM_NO_AMS=1.

Mon, Nov 13, 5:27 AM · Plasma

Sun, Nov 12

graesslin updated the diff for D8748: [libinput] Find screen for touch screen devices and calibrate accordingly.

Handle deviceAdded

Sun, Nov 12, 8:23 PM · KWin
graesslin added a dependency for D8776: [autotests] Add tests for DRM platform plugin: D8752: [platforms/drm] At safety checks for the properties.
Sun, Nov 12, 8:08 PM · Plasma
graesslin added a dependent revision for D8752: [platforms/drm] At safety checks for the properties: D8776: [autotests] Add tests for DRM platform plugin.
Sun, Nov 12, 8:08 PM · Plasma
graesslin created D8776: [autotests] Add tests for DRM platform plugin.
Sun, Nov 12, 8:07 PM · Plasma
graesslin updated the diff for D8752: [platforms/drm] At safety checks for the properties.

Update the eglsurface in AbstractEglBackend if it changed

Sun, Nov 12, 7:47 AM · Plasma
graesslin added a comment to D8752: [platforms/drm] At safety checks for the properties.

Ok, I figured out why the context is not current any more. We seem to get a mode change request from KScreen, which results in the DRMBackend updating a screen, the EGLBackend recreates the EGLSurface but didn't pass it to the parent class which tried to make a context current on the no longer existing surface. Thus making the context current failed. Uploading new patch.

Sun, Nov 12, 7:47 AM · Plasma
graesslin added a comment to D8752: [platforms/drm] At safety checks for the properties.

In combination that looks like kscreen sends a request to KWin which is stupid. Resulting in KWin losing the OpenGL context and then epoxy crashing. So we have two problems here: one being the incorrect request from KScreen, the other the fact that KWin ends up with no context. Anyway looks to me like I can push at least this patch as it improves the situation.

Sun, Nov 12, 7:32 AM · Plasma

Sat, Nov 11

graesslin updated the diff for D8752: [platforms/drm] At safety checks for the properties.

Fix stupid mistake, now starting should work again

Sat, Nov 11, 6:43 PM · Plasma
graesslin updated the diff for D8752: [platforms/drm] At safety checks for the properties.

Prevent the new reported crash

Sat, Nov 11, 12:15 PM · Plasma
graesslin created D8758: Support modifier+mouse button on window decoration.
Sat, Nov 11, 11:30 AM · KWin
graesslin accepted D8756: Forbid more syscalls which could modify the filesystem.
Sat, Nov 11, 7:38 AM · Plasma
graesslin updated the diff for D8748: [libinput] Find screen for touch screen devices and calibrate accordingly.

Use screens()->geometry() instead of size

Sat, Nov 11, 7:32 AM · KWin

Fri, Nov 10

graesslin added inline comments to D8748: [libinput] Find screen for touch screen devices and calibrate accordingly.
Fri, Nov 10, 9:54 PM · KWin
graesslin added inline comments to D8748: [libinput] Find screen for touch screen devices and calibrate accordingly.
Fri, Nov 10, 9:31 PM · KWin
graesslin created D8752: [platforms/drm] At safety checks for the properties.
Fri, Nov 10, 7:40 PM · Plasma
graesslin added a comment to D8731: [x11] Add support for automatic screen rotation through XRandR.

Yet we're putting this sensor stuff in kwin instead, then having to come up with extra interfaces to fix the problems we're creating.

Fri, Nov 10, 7:02 PM · KWin
graesslin updated the diff for D8731: [x11] Add support for automatic screen rotation through XRandR.

Fixup arc failure

Fri, Nov 10, 5:14 PM · KWin
graesslin created D8748: [libinput] Find screen for touch screen devices and calibrate accordingly.
Fri, Nov 10, 5:14 PM · KWin
graesslin updated the diff for D8731: [x11] Add support for automatic screen rotation through XRandR.
  • [libinput] Find screen for touch screen devices and calibrate accordingly
Fri, Nov 10, 5:12 PM · KWin

Thu, Nov 9

graesslin added inline comments to D8738: Add DBus interface to OrientationSensor and a persistent configuration.
Thu, Nov 9, 7:14 PM · KWin
graesslin added a comment to D8731: [x11] Add support for automatic screen rotation through XRandR.

Please see D8738 - I hope this addresses your concerns and can us allow to unblock this change.

Thu, Nov 9, 5:08 PM · KWin
graesslin created D8738: Add DBus interface to OrientationSensor and a persistent configuration.
Thu, Nov 9, 5:06 PM · KWin
graesslin added a comment to D8705: Remove Qt5::Widgets as a dependency.

I guess that the same argument could be made about Qt5::Widgets... if you're using a widget you're supposed to link to that, rather than indirectly via KWindowSystem...

This is making me change my mind. Maybe it's OK after all. It breaks SC in a case where "proper" application code shouldn't be affected.

Thu, Nov 9, 3:50 PM · Frameworks
graesslin added a comment to D8731: [x11] Add support for automatic screen rotation through XRandR.

I said on the previous patch that there's a *fundamental* design flaw in the previous patch, which will be even worse on X.
The last patch was pushed regardless..and now there's a patch on X without addressing the problems at all.

Thu, Nov 9, 5:22 AM · KWin

Wed, Nov 8

graesslin added inline comments to D8731: [x11] Add support for automatic screen rotation through XRandR.
Wed, Nov 8, 8:17 PM · KWin
graesslin created D8731: [x11] Add support for automatic screen rotation through XRandR.
Wed, Nov 8, 8:16 PM · KWin
graesslin committed R108:9df1744830a0: Support automatic screen rotation based on orientation sensor (authored by graesslin).
Support automatic screen rotation based on orientation sensor
Wed, Nov 8, 4:45 PM
graesslin closed D8699: Support automatic screen rotation based on orientation sensor.
Wed, Nov 8, 4:45 PM · Plasma
graesslin committed R108:99b6f6150d04: [platforms/drm] Determine the supported transformation on a plane (authored by graesslin).
[platforms/drm] Determine the supported transformation on a plane
Wed, Nov 8, 4:45 PM
graesslin closed D8645: [platforms/drm] Determine the supported transformation on a plane.
Wed, Nov 8, 4:45 PM · Plasma
graesslin committed R108:59f7ed9c780a: [platforms/drm] Forward the mode changes to the OutputInterface (authored by graesslin).
[platforms/drm] Forward the mode changes to the OutputInterface
Wed, Nov 8, 4:32 PM
graesslin closed D8578: [platforms/drm] Forward the mode changes to the OutputInterface.
Wed, Nov 8, 4:32 PM · Plasma
graesslin updated subscribers of D8705: Remove Qt5::Widgets as a dependency.

From my side a -1. This is not source compatible. Thus I think we need to wait for Frameworks 6 for it.

Wed, Nov 8, 4:12 PM · Frameworks
graesslin added a comment to D8699: Support automatic screen rotation based on orientation sensor.

if auto rotation is enabled you cannot manually rotate the screen and vice versa.

Yeah, that's great...but kscreen needs to have that information.

It's going to be especially difficult if you do want to support X.
kscreen there is following any external xrandr changes and we need to think about the whole set of potential races between kwin, X and kscreen.

Wed, Nov 8, 5:25 AM · Plasma
graesslin added a comment to D8706: Fix build with a KWindowSystem framework that doesn't pull QWidget.

5.11 yes, 5.8 no

Wed, Nov 8, 5:20 AM · KWin

Tue, Nov 7

graesslin added a comment to D8699: Support automatic screen rotation based on orientation sensor.

That reminds me: VDG how can I request two new status notifier icons? I need: "automatic-screen-rotation-enabled" and "automatic-screen-rotation-disabled"

Tue, Nov 7, 7:08 PM · Plasma
graesslin added a comment to D8699: Support automatic screen rotation based on orientation sensor.
In D8699#165399, @sebas wrote:

Ah, btw ... we have icons: They're in breeze-icons/applets/*/osd-rotate-{ccw,cw,flip,normal].svg

These should probably be used for the statusnotifier then.

Tue, Nov 7, 7:06 PM · Plasma
graesslin added a comment to D8699: Support automatic screen rotation based on orientation sensor.

I don't see how the interaction with KScreen is going to work; you rotate the screen in kscreen, kscreen will consider that a completely different config change and save it.

Tue, Nov 7, 7:05 PM · Plasma
graesslin added a comment to D8699: Support automatic screen rotation based on orientation sensor.
In D8699#165395, @sebas wrote:

Code-wise, looks good.

Have you thought about a way to switch it on and off? Perhaps a simple dbus interface that allows checking its state and turning it on and off is sufficient.

Tue, Nov 7, 7:03 PM · Plasma
graesslin accepted D8702: Debug output for platforms.
Tue, Nov 7, 7:01 PM · KWin
graesslin accepted D8703: Print screen scale in supportInformation.
Tue, Nov 7, 6:59 PM · KWin
graesslin added a comment to D8682: Improve some strings and UI elements in KWin KCM.

Gotcha, thanks for the background. I will adjust the string to note the distinction and address the other inline comments. FWIW I am a native English speaker, and "...unminimize all such way minimized windows" is simply gramatically wrong, and needs to be changed regardless. How about "Adds a shortcut to minimize and un-minimize all windows (only affects windows minimized by this script)"

Tue, Nov 7, 5:16 PM · KWin
graesslin requested changes to D8682: Improve some strings and UI elements in KWin KCM.

Please be aware that this will cause work for translators and they might be puzzled because their translated string will just be the same. If a native speaker thinks that the new texts are better than I'm fine with this. But if it is just a minor improvement or no real improvement at all I always decided against such changes to not cause unnecessary work for the translators.

Tue, Nov 7, 4:46 PM · KWin