graesslin (Martin Flöser)
KWin maintainer

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 8:19 AM (157 w, 1 d)
Availability
Available

Recent Activity

Yesterday

graesslin added a comment to D12066: [options] Disable prior selections of EGL on X backend.

There are users who only could get Egl to work. The setting was only removed as users "read on informed Internets" that it was better. For very few that's the case, for most it isn't. Nevertheless I don't think it would be good to break this for users who deliberately want to use it. From bug reports this is rather seldom a problem nowadays.

Sun, Apr 22, 7:30 PM · KWin
graesslin updated subscribers of D12243: Add XDG Output support.

@bshah hwcomposer would also need adjustements, is that useful? Could we benefit from fractional scaling on hwcomposer?

Sun, Apr 22, 7:26 PM · KWin
graesslin accepted D12404: Improve tooltips behavior.
Sun, Apr 22, 7:21 PM · KWin
graesslin added inline comments to D11926: Add "SkipSwitcher" to API.
Sun, Apr 22, 7:15 PM · KWin
graesslin added inline comments to D12447: Handle errors with drmModeSetCursor instead of silently failing.
Sun, Apr 22, 7:09 PM · KWin
graesslin accepted D12455: kcm_opengl: Fix EGL info retrieval..
Sun, Apr 22, 6:49 PM · Plasma
graesslin accepted D9574: fb_backend_qpainter_backend: Use logind to determine if the session is active..
Sun, Apr 22, 3:56 PM · KWin
graesslin committed R108:e737a6193c80: main_wayland: Don't hardcode /dev/fb0 anymore (authored by nerdopolist).
main_wayland: Don't hardcode /dev/fb0 anymore
Sun, Apr 22, 3:53 PM
graesslin closed D9557: main_wayland: Don't hardcode /dev/fb0 anymore.
Sun, Apr 22, 3:53 PM · KWin
graesslin accepted D9557: main_wayland: Don't hardcode /dev/fb0 anymore.
Sun, Apr 22, 3:53 PM · KWin
graesslin committed R108:8321453fdeee: fb_backend: use new udev function to detect framebuffer devices, if one is not… (authored by nerdopolist).
fb_backend: use new udev function to detect framebuffer devices, if one is not…
Sun, Apr 22, 3:52 PM
graesslin closed D9556: fb_backend: use new udev function to detect framebuffer devices, if one is not set.
Sun, Apr 22, 3:52 PM · KWin
graesslin committed R108:3c745bb5716c: fb_backend: fix warning (authored by nerdopolist).
fb_backend: fix warning
Sun, Apr 22, 3:50 PM
graesslin closed D9567: fb_backend: fix warning.
Sun, Apr 22, 3:50 PM · KWin
graesslin updated subscribers of D11977: Change the default animationTime of 350 to 250, like most other effects.

Please note that the other animation time durations are also just random picked values. I doubt the random picked 250 is any better than the random picked 350.

Sun, Apr 22, 3:43 PM · KWin
graesslin added a comment to D11976: Change/improve default settings of glide effect.

The idea how the glide effect was implemented is to have this angle. The defaults have not been changed since the effect got introduced.

Sun, Apr 22, 3:37 PM · KWin
graesslin requested changes to D11926: Add "SkipSwitcher" to API.

Sorry for the delay in review, I was on vacations.

Sun, Apr 22, 3:34 PM · KWin
graesslin committed R108:ddda524974d9: libinput/connection: Don't hardcode seat0 anymore (authored by nerdopolist).
libinput/connection: Don't hardcode seat0 anymore
Sun, Apr 22, 3:31 PM
graesslin closed D9552: libinput/connection: Don't hardcode seat0 anymore.
Sun, Apr 22, 3:30 PM · KWin
graesslin added a comment to D12322: Add environment variable to force sw cursor.

Could you please document the new env variable in https://community.kde.org/KWin/Environment_Variables

Sun, Apr 22, 3:24 PM · KWin
graesslin added a comment to D12445: Add shortcut for application menu.

Is it semantically correct to have this in KWin? Shouldn't that not be in the kded module so that it works in all variants of appmenu visualization?

Sun, Apr 22, 3:22 PM · KWin
graesslin added inline comments to D12447: Handle errors with drmModeSetCursor instead of silently failing.
Sun, Apr 22, 3:21 PM · KWin
graesslin requested changes to D12416: Don't try to filter null key combinations.

Ah you are my hero! I was not understanding this bug and failed to reproduce it. Could you please add a small test case for it? should be relative straight forward and we have quite a few tests for global shortcuts already. And please mark bug 390110 as fixed, which also means I want this in 5.12 :-)

Sun, Apr 22, 1:43 PM · KWin
graesslin accepted D12444: Don't try to open application menu when client doesn't have one.
Sun, Apr 22, 1:40 PM · KWin
graesslin requested changes to D12404: Improve tooltips behavior.
Sun, Apr 22, 1:40 PM · KWin

Sat, Apr 21

graesslin added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

I'm pointing out that I'm in general against any risky changes on X11. If users want to use this features: Wayland is there. KWin is feature frozen on X11 and I highly suggest to the Plasma community to decide the same at the sprint. We will have less maintenance issues due to it.

Sat, Apr 21, 7:52 PM · Plasma
graesslin added a comment to D12069: Implement a keyboard selector plasmoid.

I don't think that there's any reason to discard this. It's a start and improvement over the current situation and a fallback is needed anyway. So we start with the fallback instead of adding it later on.

Sat, Apr 21, 7:42 PM · Plasma
graesslin added a comment to D12373: Klipper: Remove first history item on clipboard clear.

Sorry, but I'm against this. The options keepass provides are just bullshit (sorry to be that direct). That cannot work and will not work. One cannot remove anything from the clipboard, trying to do so is insane. What would make most sense for things like clipboard is setting a mimetime like text/password. This could be used by Klipper to never add it to history. That would be a useful feature. But anything that just tries to support keepass's utterly broken workflow from an X11/Wayland and security point of view doesn't make any sense.

Sat, Apr 21, 7:21 PM · Plasma
graesslin added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

I also cannot imagine this to work due to the fact how X11 works. There is just no mapping from window to screen. No window can know on which screen it is. Not even KWin knows that as the window manager (screen is not a constant property, but evaluated every time it is accessed, it's based on the distance to closest screen). Especially for overlapping windows it's very difficult to try to get to which screen it belongs. It gets even more complicated when things like panning and overlapping screens get into it. So I wouldn't trust this thing in Qt to work due to the pain we have in KWin especially with these problems.

Sat, Apr 21, 7:01 PM · Plasma

Mon, Apr 9

graesslin added inline comments to D12069: Implement a keyboard selector plasmoid.
Mon, Apr 9, 5:31 PM · Plasma

Sat, Apr 7

graesslin added a comment to D11583: Add platform detection and adjustment to kded.

Btw could someone please push for me. I'm not around the next two weeks

Sat, Apr 7, 5:45 AM · Frameworks
graesslin added a comment to D11583: Add platform detection and adjustment to kded.
In D11583#241314, @apol wrote:

I wonder if all this code should be ifdef'd for Qt 5.10 though. The premise is that this won't be a problem with Qt 5.11, right?

Sat, Apr 7, 5:45 AM · Frameworks

Fri, Apr 6

graesslin added a comment to D11924: Add "SkipSwitcher" to API.

Martin, @sharvey does not yet have commit access. Would you like to land this patch for him, or should I?

Fri, Apr 6, 4:30 AM · Frameworks

Thu, Apr 5

graesslin accepted D11803: [colorcorrection] Set gamma through Output class.
Thu, Apr 5, 6:01 PM · KWin
graesslin accepted D11789: [platforms/virtual] Let VirtualOutput inherit Output.
Thu, Apr 5, 5:59 PM · KWin
graesslin added a comment to D11781: Introduce generic Output class.

I'm very much in favor of basing the complete KWin::Screens on top of this new class in the long run. Our current Screens class is a mess and with a dedicated Output we could even get to things like storing to which Output an AbstractClient belongs and keeping it there if screens change.

Thu, Apr 5, 5:58 PM · KWin
graesslin added a comment to D9552: libinput/connection: Don't hardcode seat0 anymore.

arc failed to apply this one. Could you please rebase again?

Thu, Apr 5, 5:50 PM · KWin
graesslin committed R108:99376d38f69f: udev: Only handle devices from the current seat (authored by nerdopolist).
udev: Only handle devices from the current seat
Thu, Apr 5, 5:48 PM
graesslin closed D9553: udev: Only handle devices from the current seat.
Thu, Apr 5, 5:48 PM · KWin
graesslin committed R108:7801afdd4c3d: udev: Add the ability to query the current framebuffer. (authored by nerdopolist).
udev: Add the ability to query the current framebuffer.
Thu, Apr 5, 5:46 PM
graesslin closed D9554: udev: Add the ability to query the current framebuffer..
Thu, Apr 5, 5:46 PM · KWin
graesslin added a comment to D11758: drm backend: choose correct EGL config with mesa-18.

Could you please backport to Plasma/5.12 branch?

Thu, Apr 5, 5:38 PM · Plasma on Wayland, KWin
graesslin accepted D11924: Add "SkipSwitcher" to API.
Thu, Apr 5, 4:25 AM · Frameworks

Wed, Apr 4

graesslin added a comment to D11924: Add "SkipSwitcher" to API.

I'm not sure whether we can add elements to the states.

Wed, Apr 4, 7:44 PM · Frameworks
graesslin requested changes to D11924: Add "SkipSwitcher" to API.

I'm not sure whether we can add elements to the states.

Wed, Apr 4, 7:42 PM · Frameworks
graesslin requested changes to D11925: Add "SkipSwitcher" to API.
Wed, Apr 4, 4:25 PM · Frameworks

Fri, Mar 30

graesslin requested review of D11806: Use XdgShell Unstable V6 in nested wayland platform.
Fri, Mar 30, 2:11 PM · KWin

Thu, Mar 29

graesslin committed R108:e54b0ef79a75: Merge branch 'Plasma/5.12' (authored by graesslin).
Merge branch 'Plasma/5.12'
Thu, Mar 29, 3:51 PM
graesslin committed R108:420549603372: Ensure _NET_CURRENT_DESKTOP is set on startup (authored by graesslin).
Ensure _NET_CURRENT_DESKTOP is set on startup
Thu, Mar 29, 3:51 PM
graesslin closed D10836: Ensure _NET_CURRENT_DESKTOP is set on startup.
Thu, Mar 29, 3:51 PM · KWin

Wed, Mar 28

graesslin accepted D11201: Make the Window Decoration themes' Configure buttons more obvious.
Wed, Mar 28, 5:21 PM · KWin
graesslin added a comment to D11722: If GL context creation fails fall back to the software renderer.

An env variable would not work for things like lock screen as the process starting the lock screen is started before Plasmashell.

Wed, Mar 28, 4:27 AM · Plasma

Mon, Mar 26

graesslin added a comment to D11722: If GL context creation fails fall back to the software renderer.

I like this change

Mon, Mar 26, 7:23 PM · Plasma
graesslin added a comment to D10465: Fix coverswitch broken reflection on multi-monitor setup.

I'm against pushing to 5.8 - this is not a security issue.

Mon, Mar 26, 4:30 AM · KWin

Sun, Mar 25

graesslin added a comment to D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM.

XDG_SESSION_TYPE is not set if you run startplasmacompositor from a tty - so should this also check for WAYLAND_DISPLAY or startplasmacompositor set XDG_SESSION_TYPE=wayland?

[...] from developers we can expect to set this variable.

Any reason not to set it in startplasmacompositor then?

Sun, Mar 25, 8:17 AM · Plasma

Sat, Mar 24

graesslin added a comment to D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM.

XDG_SESSION_TYPE is not set if you run startplasmacompositor from a tty - so should this also check for WAYLAND_DISPLAY or startplasmacompositor set XDG_SESSION_TYPE=wayland?

Sat, Mar 24, 6:49 PM · Plasma
graesslin committed R278:f04931eb5dd6: Fix narrowing conversion warning on gcc and error on clang/FreeBSD (authored by graesslin).
Fix narrowing conversion warning on gcc and error on clang/FreeBSD
Sat, Mar 24, 5:54 PM
graesslin added inline comments to D11414: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS.
Sat, Mar 24, 7:41 AM · Frameworks

Mar 23 2018

graesslin added inline comments to D11201: Make the Window Decoration themes' Configure buttons more obvious.
Mar 23 2018, 5:22 AM · KWin

Mar 22 2018

graesslin requested review of D11583: Add platform detection and adjustment to kded.
Mar 22 2018, 6:29 PM · Frameworks
graesslin added a comment to D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11.

In general I like the idea and that should be extended to Wayland as well, but private API is a no-no for breeze. That has huge runtime breakage potential.

Mar 22 2018, 6:07 PM · Plasma
graesslin accepted D11567: Fix use of assert/crash when removing global shortcut.

Or just remove the assert.

Mar 22 2018, 5:23 AM · Plasma

Mar 21 2018

graesslin committed R120:c4a0d6925ec6: No longer export QT_QPA_PLATFORM env variable to the session (authored by graesslin).
No longer export QT_QPA_PLATFORM env variable to the session
Mar 21 2018, 5:52 AM
graesslin closed D11447: No longer export QT_QPA_PLATFORM env variable to the session.
Mar 21 2018, 5:51 AM · Plasma
graesslin committed R122:8ba04f890e15: Use platform detection from KWorkspace in Powerdevil (authored by graesslin).
Use platform detection from KWorkspace in Powerdevil
Mar 21 2018, 5:51 AM
graesslin closed D11446: Use platform detection from KWorkspace in Powerdevil.
Mar 21 2018, 5:51 AM · Plasma
graesslin committed R124:2d8296904bb4: Use platform detection in SystemSettings (authored by graesslin).
Use platform detection in SystemSettings
Mar 21 2018, 5:50 AM
graesslin closed D11445: Use platform detection in SystemSettings.
Mar 21 2018, 5:50 AM · Plasma
graesslin committed R278:cc5d6fde1aba: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS (authored by graesslin).
[xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS
Mar 21 2018, 5:50 AM
graesslin closed D11414: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS.
Mar 21 2018, 5:50 AM · Frameworks

Mar 20 2018

graesslin accepted D11526: Remove "move zoomed area" shortcuts by default.
Mar 20 2018, 8:25 PM · KWin
graesslin added a comment to D11447: No longer export QT_QPA_PLATFORM env variable to the session.

There's another solution which might be cleaner and which KWin uses for that problem: modifying the process environment. I'll give a try whether this could work here.

Mar 20 2018, 4:44 PM · Plasma

Mar 19 2018

graesslin added a comment to D11447: No longer export QT_QPA_PLATFORM env variable to the session.

Could we use a wrapper for QApplication being called by

QApplication app = KWorkSpace::createPlattformAwareQApplication(argc, argv);

and that sets and unsets the env variable in the wrapper call? With above code there might be a copy involved though.

Mar 19 2018, 8:10 PM · Plasma
graesslin added a comment to D11447: No longer export QT_QPA_PLATFORM env variable to the session.

If KWorkSpace::detectPlatform(argc, argv); were changed to edit argc and argv to pass -platform foo instead of setting QT_QPA_PLATFORM, the qunsetenv calls would become unnecessary.

but that sounds rather dangerous. I don't want to mess with the command line arguments

Why is that more dangerous than environment variables?
If argc and argv are passed to QApplication, you already know how it'll be parsed.

Mar 19 2018, 4:54 PM · Plasma
graesslin accepted D11351: [platforms/virtual] Add virtual output class.
Mar 19 2018, 4:16 PM · KWin
graesslin added a comment to D11447: No longer export QT_QPA_PLATFORM env variable to the session.

If KWorkSpace::detectPlatform(argc, argv); were changed to edit argc and argv to pass -platform foo instead of setting QT_QPA_PLATFORM, the qunsetenv calls would become unnecessary.

Mar 19 2018, 4:15 PM · Plasma
graesslin added a comment to D11201: Make the Window Decoration themes' Configure buttons more obvious.

What's box header in your mockup?

Just the theme title. This is only the theme window. It is intended to represent the list of themes.

Mar 19 2018, 5:22 AM · KWin
graesslin accepted D11472: [libinput] Remove workaround for mouse configuration.
Mar 19 2018, 5:19 AM · KWin

Mar 18 2018

graesslin accepted D11453: Update kwindecoration docbook.

As a note: there's currently work going on to change the theme config button: D11201

Mar 18 2018, 7:54 PM · KWin
graesslin added a comment to D11201: Make the Window Decoration themes' Configure buttons more obvious.

What's box header in your mockup?

Mar 18 2018, 7:33 PM · KWin
graesslin added a comment to D9567: fb_backend: fix warning.
In D9567#228429, @rkflx wrote:
I wonder why you never ran into this with `arc patch` before, as this is not really specific to this patch, but any invocation of `arc patch` should trigger it.
Mar 18 2018, 10:49 AM · KWin
graesslin requested review of D11447: No longer export QT_QPA_PLATFORM env variable to the session.
Mar 18 2018, 10:11 AM · Plasma
graesslin requested review of D11446: Use platform detection from KWorkspace in Powerdevil.
Mar 18 2018, 8:56 AM · Plasma
graesslin requested review of D11445: Use platform detection in SystemSettings.
Mar 18 2018, 8:50 AM · Plasma
graesslin added a comment to D9553: udev: Only handle devices from the current seat.

Unfortunately the patch does not apply anymore to current KWin master :-(

Mar 18 2018, 8:39 AM · KWin
graesslin added a comment to D9553: udev: Only handle devices from the current seat.

Unfortunately the patch does not apply anymore to current KWin master :-(

Mar 18 2018, 8:31 AM · KWin
graesslin added a comment to D9567: fb_backend: fix warning.
In D9567#228374, @rkflx wrote:

Sorry for intruding here Martin, but smoothing this out and understanding where we still have problems is important for T7116: Streamlined onboarding of new contributors ;)

Mar 18 2018, 8:30 AM · KWin
graesslin committed R120:b5c326996309: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM (authored by graesslin).
Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM
Mar 18 2018, 8:19 AM
graesslin closed D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM.
Mar 18 2018, 8:18 AM · Plasma
graesslin committed R108:d3aa33b51bd6: Reevaluate window rules when the (xdg) shell surface's appId changes (authored by graesslin).
Reevaluate window rules when the (xdg) shell surface's appId changes
Mar 18 2018, 8:16 AM
graesslin committed R108:d61eaa2d66b0: Add a new desktopfile name rule (authored by graesslin).
Add a new desktopfile name rule
Mar 18 2018, 8:16 AM
graesslin closed D11268: Reevaluate window rules when the (xdg) shell surface's appId changes.
Mar 18 2018, 8:16 AM · KWin
graesslin closed D11266: Add a new desktopfile name rule.
Mar 18 2018, 8:16 AM · KWin
graesslin added a comment to D9567: fb_backend: fix warning.
In D9567#228364, @rkflx wrote:

I am able to download raw diff... ...did I upload something wrong?

arc patch works fine for me. "Base commit is not in local repository" is just informational BTW, you also get this if it will work.

For me it doesn't. It then tries to connect to github and asks for my github username and password. Which I don't have.

Mar 18 2018, 7:56 AM · KWin
graesslin added a comment to D11305: [effects/fade] Temporarily ignore shown/hidden signals.
In D11305#228208, @zzag wrote:

It's an idea I got from QAbstractItemModel - it emits signals like aboutToMoveRows. The problematic area is in Workspace where first all X11 Windows get hidden, then shown again. So basically what would be needed is emitting the signal at start and end of that method.

Only X11 Windows get their visibility updated in that method.

Yeah, seems Workspace::updateClientVisibilityOnDesktopChange updates visibility only for X11 clients. Why doesn't it update visibility of ShellClients too?

Mar 18 2018, 7:45 AM · KWin
graesslin added a comment to D9567: fb_backend: fix warning.

I am able to download raw diff... ...did I upload something wrong?

Mar 18 2018, 7:41 AM · KWin
graesslin added a comment to D11201: Make the Window Decoration themes' Configure buttons more obvious.

Perhaps an outside-the-preview button's text could say "Configure active theme"?

Mar 18 2018, 7:40 AM · KWin
graesslin added inline comments to D11377: Expose more default window management shortcuts.
Mar 18 2018, 7:36 AM · KWin
graesslin added a comment to D11377: Expose more default window management shortcuts.

It looks like the current quick tiling shortcuts (if any) are already tested in QuickTilingTest::testShortcut(), and the tests pass:

PASS   : KWin::QuickTilingTest::testShortcut(top)
PASS   : KWin::QuickTilingTest::testShortcut(left)
Mar 18 2018, 7:35 AM · KWin

Mar 17 2018

graesslin added a comment to D11305: [effects/fade] Temporarily ignore shown/hidden signals.
In D11305#227874, @zzag wrote:

I'm sorry but this breaks Wayland, auto-hiding panels and much more.

Sorry, I don't use Wayland because many features I use per day basis aren't working. Should have tested on Wayland too, sorry.

We need a different solution for the problem. E.g. a signal beginSwitchDesktop and endSwitchDesktop or a property isCurrentlySwitchingDesktops.

The property sounds like a hack. Could you please tell more about begin/endSwitchDesktop approach? E.g. when endSwitchDesktop will be emitted? what's the order of desktopChanged and windowShown/windowHidden signals, etc?

Mar 17 2018, 8:32 PM · KWin