graesslin (Martin Gräßlin)
KWin maintainer

Projects

User Details

User Since
Apr 18 2015, 8:19 AM (101 w, 5 h)

Recent Activity

Yesterday

graesslin added a comment to D4806: [greeter] Send the auth result through the server instead return value.

Since there seem to be not many others I'll try to give you reviews for this and your following patches, but first I've to understand this stuff.

Tell me if the following is right:

Until now the greeter waited for the exit code of the forked process with the pid m_pid.

Fri, Mar 24, 4:26 PM · Plasma
graesslin accepted D5164: fix occassional crash caused by needlessly delayed signals (bko#363224).

Given that it might introduce graphical issues (assuming that there was a good reason for the delaying) only in master please.

Fri, Mar 24, 4:17 PM · KWin
graesslin committed R108:89058173f7e2: Merge branch 'Plasma/5.9' (authored by graesslin).
Merge branch 'Plasma/5.9'
Fri, Mar 24, 4:08 PM
graesslin committed R108:3ab0de5e18aa: Merge branch 'Plasma/5.8' into Plasma/5.9 (authored by graesslin).
Merge branch 'Plasma/5.8' into Plasma/5.9
Fri, Mar 24, 4:06 PM
graesslin committed R108:c947e0a6012c: Fix crash on dragging titlebar buttons in System Settings (authored by vtronko).
Fix crash on dragging titlebar buttons in System Settings
Fri, Mar 24, 4:06 PM
graesslin closed D5117: Fix crash on dragging titlebar buttons in System Settings by committing R108:c947e0a6012c: Fix crash on dragging titlebar buttons in System Settings (authored by vtronko).
Fri, Mar 24, 4:06 PM · KWin
graesslin updated the diff for D5137: Add support for screenedge touchscreen events through XInput 2.2.

Next try

Fri, Mar 24, 2:57 PM · Plasma
graesslin added inline comments to D5137: Add support for screenedge touchscreen events through XInput 2.2.
Fri, Mar 24, 2:47 PM · Plasma
graesslin accepted D5156: Inject mouse clicks from SNI to xembedded icons with XTest.

meh

Fri, Mar 24, 6:14 AM · Plasma

Thu, Mar 23

graesslin created D5158: Support the emergency show property on ksld's lock screen window.
Thu, Mar 23, 8:42 PM · KWin
graesslin added a comment to D5157: Add support for emergency message show on Wayland.

emergency show on a nested Wayland compositor.

Thu, Mar 23, 8:40 PM · Plasma
graesslin created D5157: Add support for emergency message show on Wayland.
Thu, Mar 23, 8:39 PM · Plasma
graesslin updated the diff for D5137: Add support for screenedge touchscreen events through XInput 2.2.

Try two :-)

Thu, Mar 23, 7:51 PM · Plasma
graesslin updated the diff for D5137: Add support for screenedge touchscreen events through XInput 2.2.

Addressed David's comments

Thu, Mar 23, 5:54 AM · Plasma
graesslin added inline comments to D5137: Add support for screenedge touchscreen events through XInput 2.2.
Thu, Mar 23, 5:54 AM · Plasma

Wed, Mar 22

graesslin added dependencies for D5137: Add support for screenedge touchscreen events through XInput 2.2: D5106: Add support for activating screenedges through touch swipe gestures, D5097: Add support for global touchpad swipe gestures.
Wed, Mar 22, 8:06 PM · Plasma
graesslin added a dependent revision for D5106: Add support for activating screenedges through touch swipe gestures: D5137: Add support for screenedge touchscreen events through XInput 2.2.
Wed, Mar 22, 8:06 PM · Plasma on Wayland
graesslin added a dependent revision for D5097: Add support for global touchpad swipe gestures: D5137: Add support for screenedge touchscreen events through XInput 2.2.
Wed, Mar 22, 8:06 PM · Plasma on Wayland
graesslin created D5137: Add support for screenedge touchscreen events through XInput 2.2.
Wed, Mar 22, 8:05 PM · Plasma
graesslin requested changes to D5134: Don't exit if $DISPLAY is not set.

As I stumbled over that years ago: sorry I don't think that this is the proper solution. This is basically T4431 which is not yet implemented. What this change suggest is a rather hacky solution.

Wed, Mar 22, 7:15 PM · Frameworks
graesslin added a comment to D5061: [sddm-theme] Add virtual keyboard support.

It's worth testing natively as opposed to qmlscene because components loading can be a bit weird because of paths.

Wed, Mar 22, 3:48 PM · Plasma
graesslin accepted D5132: [Aurorae AppMenuButton] Show if client has app menu.
Wed, Mar 22, 3:46 PM · KWin
graesslin accepted D5131: [Plastik Decoration] Show application menu button if client has one.
Wed, Mar 22, 3:45 PM · KWin
graesslin accepted D5130: [Aurorae DecorationButton] Hook up app menu button.

5.9 branch

Wed, Mar 22, 3:45 PM · KWin

Tue, Mar 21

graesslin accepted D5116: [kcm_kwindecoration] Respect theme colors.
Tue, Mar 21, 3:53 PM · KWin
graesslin added a comment to D5116: [kcm_kwindecoration] Respect theme colors.

Does this also work when you change the theme?

Tue, Mar 21, 6:13 AM · KWin
graesslin accepted D5117: Fix crash on dragging titlebar buttons in System Settings.

do you have push rights?

Tue, Mar 21, 6:12 AM · KWin

Mon, Mar 20

graesslin updated the diff for D5106: Add support for activating screenedges through touch swipe gestures.

Change to doFoo pattern as noted by David

Mon, Mar 20, 4:45 PM · Plasma on Wayland
graesslin accepted D5114: support for high dpi in aurorae.
Mon, Mar 20, 3:57 PM · KWin
graesslin accepted D5115: [Logout Greeter] Properly fullscreen window and don't bypass WM.
Mon, Mar 20, 3:54 PM · Plasma

Sun, Mar 19

graesslin updated the diff for D5106: Add support for activating screenedges through touch swipe gestures.

Adressed David's comments

Sun, Mar 19, 5:48 PM · Plasma on Wayland
graesslin added inline comments to D5106: Add support for activating screenedges through touch swipe gestures.
Sun, Mar 19, 5:48 PM · Plasma on Wayland
graesslin added inline comments to D5106: Add support for activating screenedges through touch swipe gestures.
Sun, Mar 19, 5:41 PM · Plasma on Wayland
graesslin added a dependency for D5106: Add support for activating screenedges through touch swipe gestures: D5097: Add support for global touchpad swipe gestures.
Sun, Mar 19, 12:46 PM · Plasma on Wayland
graesslin added a dependent revision for D5097: Add support for global touchpad swipe gestures: D5106: Add support for activating screenedges through touch swipe gestures.
Sun, Mar 19, 12:46 PM · Plasma on Wayland
graesslin created D5106: Add support for activating screenedges through touch swipe gestures.
Sun, Mar 19, 12:46 PM · Plasma on Wayland

Sat, Mar 18

graesslin committed R108:fa4c60e33f1c: Add support for pointer gestures to nested Wayland platform (authored by graesslin).
Add support for pointer gestures to nested Wayland platform
Sat, Mar 18, 1:41 PM
graesslin closed D5059: Add support for pointer gestures to nested Wayland platform by committing R108:fa4c60e33f1c: Add support for pointer gestures to nested Wayland platform.
Sat, Mar 18, 1:41 PM · KWin
graesslin created D5097: Add support for global touchpad swipe gestures.
Sat, Mar 18, 1:40 PM · Plasma on Wayland
graesslin moved T5170: Global touch gestures from Plasma 5.10 to Work In Progress on the KWin board.
Sat, Mar 18, 1:25 PM · KWin, Plasma on Wayland
graesslin moved T5170: Global touch gestures from Plasma 5.10 to Work In Progress on the Plasma on Wayland board.
Sat, Mar 18, 1:24 PM · KWin, Plasma on Wayland

Fri, Mar 17

graesslin committed R133:6ef78dc09dad: Require PAM by default and provide an option to not require it (authored by graesslin).
Require PAM by default and provide an option to not require it
Fri, Mar 17, 4:53 PM
graesslin closed D4768: Require PAM by default and provide an option to not require it by committing R133:6ef78dc09dad: Require PAM by default and provide an option to not require it.
Fri, Mar 17, 4:53 PM · Plasma
graesslin accepted D5078: when the padding aroun the window changes, update.
Fri, Mar 17, 4:46 PM · KWin
graesslin accepted D5060: [DrmBackend] Straighten out EGL surface buffer release logic on page flip.
Fri, Mar 17, 4:45 PM · KWin
graesslin added a comment to D5078: when the padding aroun the window changes, update.
In D5078#95680, @mart wrote:

So if I understand correctly on the paddingChanged we do not need to repaint, you are only interested in the update of the m_visibleRectBeforeGeometryUpdate? In that case I suggest to update it whenever the shadow changes.

yes.
so just update that property in a lambda without the actual call to addRepaintDuringGeometryUpdates? (and addLayerRepaint)

Fri, Mar 17, 4:41 PM · KWin
graesslin added a comment to D5063: [sddm-theme] Improve positioning of Clock.
In D5063#95576, @mart wrote:

if you are ok, i would give its layouting the same treatment of D4893

Fri, Mar 17, 4:39 PM · Plasma
graesslin added a comment to D5078: when the padding aroun the window changes, update.

So if I understand correctly on the paddingChanged we do not need to repaint, you are only interested in the update of the m_visibleRectBeforeGeometryUpdate? In that case I suggest to update it whenever the shadow changes.

Fri, Mar 17, 4:35 PM · KWin
graesslin added inline comments to D5078: when the padding aroun the window changes, update.
Fri, Mar 17, 4:29 PM · KWin
graesslin added a comment to D5078: when the padding aroun the window changes, update.

I'm not sure whether this is the right solution. This yells side-effect and potential breakage in other areas to me.

Fri, Mar 17, 4:29 PM · KWin
graesslin added inline comments to D5078: when the padding aroun the window changes, update.
Fri, Mar 17, 4:24 PM · KWin

Thu, Mar 16

graesslin committed R133:06917c1253eb: [ksld] Don't unset greeter connection on destroy unconditionally (authored by graesslin).
[ksld] Don't unset greeter connection on destroy unconditionally
Thu, Mar 16, 6:36 PM
graesslin closed D5008: [ksld] Don't unset greeter connection on destroy unconditionally by committing R133:06917c1253eb: [ksld] Don't unset greeter connection on destroy unconditionally.
Thu, Mar 16, 6:36 PM · Plasma
graesslin committed R133:4cf34fea04dc: [kcheckpass] Drop all outdated/obsoleted checkpass variants (authored by graesslin).
[kcheckpass] Drop all outdated/obsoleted checkpass variants
Thu, Mar 16, 6:36 PM
graesslin closed D5005: [kcheckpass] Drop all outdated/obsoleted checkpass variants by committing R133:4cf34fea04dc: [kcheckpass] Drop all outdated/obsoleted checkpass variants.
Thu, Mar 16, 6:36 PM · Plasma
graesslin added inline comments to D5061: [sddm-theme] Add virtual keyboard support.
Thu, Mar 16, 5:44 PM · Plasma
graesslin added inline comments to D4893: Layout and animations on the on screen keyboard.
Thu, Mar 16, 5:40 PM · Plasma
graesslin added inline comments to D4893: Layout and animations on the on screen keyboard.
Thu, Mar 16, 4:38 PM · Plasma
graesslin added a comment to D4718: support for auto-hidden windows to resize.

remove the test, because the deletion of the edge pointer makes sense

Thu, Mar 16, 4:09 PM · KWin
graesslin added a comment to D4718: support for auto-hidden windows to resize.

remove the test, because the deletion of the edge pointer makes sense

Thu, Mar 16, 4:09 PM · KWin
graesslin added a comment to D4989: more aggressively repaint when the shadow changes.

This certainly has setting combinations which I consider as unsupported. To me any strong deviation is considered unsupported. We don't have the manpower to ensure that the weird combinations work. To me that is fine, most of these options are hidden in expert modes showing warnings. If users select them: they were warned. If distros do it, it becomes problematic.

Thu, Mar 16, 4:05 PM · Plasma
graesslin added a comment to D4989: more aggressively repaint when the shadow changes.

We now got a bug report for the issue: 377670

Thu, Mar 16, 6:15 AM · Plasma

Wed, Mar 15

graesslin added inline comments to D5061: [sddm-theme] Add virtual keyboard support.
Wed, Mar 15, 7:56 PM · Plasma
graesslin updated the diff for D5061: [sddm-theme] Add virtual keyboard support.

Addressed Kai-Uwe's suggestions

Wed, Mar 15, 7:54 PM · Plasma
graesslin committed R120:54479d32a964: [lnf] Only show virtual keyboard button if virtual keyboard is available (authored by graesslin).
[lnf] Only show virtual keyboard button if virtual keyboard is available
Wed, Mar 15, 7:51 PM
graesslin closed D5062: [lnf] Only show virtual keyboard button if virtual keyboard is available by committing R120:54479d32a964: [lnf] Only show virtual keyboard button if virtual keyboard is available.
Wed, Mar 15, 7:51 PM · Plasma
graesslin created D5063: [sddm-theme] Improve positioning of Clock.
Wed, Mar 15, 7:42 PM · Plasma
graesslin created D5062: [lnf] Only show virtual keyboard button if virtual keyboard is available.
Wed, Mar 15, 7:32 PM · Plasma
graesslin added a comment to D5061: [sddm-theme] Add virtual keyboard support.

- note the overlap with the clock will hardly be a problem in reality. It suffers from the same problem as the lockscreen, will upload a patch for it.

Wed, Mar 15, 7:30 PM · Plasma
graesslin created D5061: [sddm-theme] Add virtual keyboard support.
Wed, Mar 15, 7:28 PM · Plasma
graesslin added a comment to D4989: more aggressively repaint when the shadow changes.

In the video the shadow stays when moving the window. Given that and the knowledge of the distribution in question I doubt it's in any way related to the shadow at all but rather to the used effects. I assume that we have a repaint issue in a completely different area which just doesn't show with the default settings (please observe that translucency effect seems to be disabled). Given that what we need to know is which settings did the distribution change. Back in the days of Netrunner this used to be horrible by mostly delivering a broken (sic!) kwinrc. Netrunner used to ship a manually adjusted kwinrc with all auto detection mechanismns disabled by accident, thus a system could easily create rendering issues just by having the false settings.

Wed, Mar 15, 7:02 PM · Plasma
graesslin reopened D4718: support for auto-hidden windows to resize.

This broke a unit test: https://build.kde.org/user/graesslin/my-views/view/mgraesslin%20maintained/job/kwin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/554/testReport/junit/(root)/TestSuite/kwin_testScreenEdges/

Wed, Mar 15, 6:32 PM · KWin
graesslin requested changes to D4893: Layout and animations on the on screen keyboard.

Honestly I don't think it's a good idea to animate the y position of the main stack. I fear this can result in a completely unusable lock screen as the main elements might get outside the visible area. I had huge problems with the layout of the lockscreen and fiddled quite a bit till I had it working correctly. Compare the problems with the Clock and scaling. I went for overlapping with parts of the UI for a reason as I don't think we have enough screen estate to show both the full UI and the keyboard.

Wed, Mar 15, 6:28 PM · Plasma
graesslin created D5059: Add support for pointer gestures to nested Wayland platform.
Wed, Mar 15, 4:57 PM · KWin
graesslin accepted D5045: new logout effect.
Wed, Mar 15, 3:51 PM · Plasma
graesslin added a comment to D5045: new logout effect.
In D5045#95099, @mart wrote:

Please do not delete the shaders! They are still used by the blur effect for cheap fullscreen blur!

ouch, didn't knew, sorry :(perhaps would be better to move them in like a sharedshaders folder, so it's more self-evident it's not a leftover?

Wed, Mar 15, 3:50 PM · Plasma
graesslin requested changes to D5054: Make sure clock in lock screen is displayed within screen.

I recently fixed this in master.

Wed, Mar 15, 5:25 AM · Plasma

Tue, Mar 14

graesslin added a comment to D4806: [greeter] Send the auth result through the server instead return value.

ping! This is security relevant code. I don't want to push without anybody looking at it!

Tue, Mar 14, 5:33 PM · Plasma
graesslin accepted D4974: add packagestructure for KWin/Decoration.
Tue, Mar 14, 5:14 PM · Plasma
graesslin added inline comments to D4989: more aggressively repaint when the shadow changes.
Tue, Mar 14, 5:13 PM · Plasma
graesslin accepted D5048: store contrast matrix per-window.

Looks ok to me.

Tue, Mar 14, 5:04 PM · KWin
graesslin added a comment to D5045: new logout effect.

Please do not delete the shaders! They are still used by the blur effect for cheap fullscreen blur!

Tue, Mar 14, 5:02 PM · Plasma
graesslin requested changes to D5045: new logout effect.

When adding a new effect the auto tests for the effect loader need to be adjusted as otherwise it fails because it finds effects it doesn't know of.

Tue, Mar 14, 5:00 PM · Plasma

Mon, Mar 13

graesslin added inline comments to D5036: UI fixes for logout dialog.
Mon, Mar 13, 6:42 PM · Plasma

Sun, Mar 12

graesslin added inline comments to D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet.
Sun, Mar 12, 7:43 PM · Plasma
graesslin added inline comments to D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet.
Sun, Mar 12, 4:48 PM · Plasma
graesslin added dependencies for D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet: D4997: Support for long running kcheckpass supporting multiple authentications, D4806: [greeter] Send the auth result through the server instead return value.
Sun, Mar 12, 4:17 PM · Plasma
graesslin added a dependent revision for D4806: [greeter] Send the auth result through the server instead return value: D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet.
Sun, Mar 12, 4:17 PM · Plasma
graesslin added a dependent revision for D4997: Support for long running kcheckpass supporting multiple authentications: D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet.
Sun, Mar 12, 4:17 PM · Plasma
graesslin created D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet.
Sun, Mar 12, 4:17 PM · Plasma

Fri, Mar 10

graesslin created D5008: [ksld] Don't unset greeter connection on destroy unconditionally.
Fri, Mar 10, 6:03 PM · Plasma
graesslin added a comment to D5006: Set the correct desktop file name when in a KDE session..

Does it still work on Wayland?

Fri, Mar 10, 5:46 PM · Plasma
graesslin created D5005: [kcheckpass] Drop all outdated/obsoleted checkpass variants.
Fri, Mar 10, 3:18 PM · Plasma
graesslin added a comment to D4806: [greeter] Send the auth result through the server instead return value.

I plan to push this on Monday, so a review would be appreciated till then :-)

Fri, Mar 10, 3:11 PM · Plasma
graesslin accepted D4952: Restore the backend set viewport when popping the final render target.
Fri, Mar 10, 3:08 PM · KWin
graesslin accepted D4951: Take into account scaling in blitFromFrameBuffer.
Fri, Mar 10, 3:08 PM · KWin
graesslin accepted D4950: Scaling support in ColorPicker effect.
Fri, Mar 10, 3:07 PM · KWin
graesslin accepted D4948: Store GLRenderTarget::scale.
Fri, Mar 10, 3:07 PM · KWin
graesslin accepted D4990: Update Aurorae Shadow when we copy the buffer, not one frame after painting.

Hah, due to the render control the rendering became smarter than it used to be. Now after re-reading the existing code I see how your change helps. Looks like a good solution, thanks!

Fri, Mar 10, 2:57 PM · Plasma
graesslin added inline comments to D4989: more aggressively repaint when the shadow changes.
Fri, Mar 10, 6:16 AM · Plasma