shubham (Shubham )
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2018, 3:31 PM (46 w, 2 d)
Availability
Available

Recent Activity

Yesterday

shubham added inline comments to D20670: automatically hide undo notification 3 seconds after it has been shown.
Thu, Apr 25, 3:22 PM
shubham updated the test plan for D20735: [KPropertiesDialog] Add octal permissions.
Thu, Apr 25, 3:19 PM · Frameworks
shubham updated the diff for D20735: [KPropertiesDialog] Add octal permissions.
  1. Use mode_t to get the permissions
  2. Position the octal permissions inside "Advanced Permissions" tab
Thu, Apr 25, 3:18 PM · Frameworks
shubham added inline comments to D20670: automatically hide undo notification 3 seconds after it has been shown.
Thu, Apr 25, 2:21 PM
shubham added inline comments to D20804: RFC: Try getting the X keyboard grab multiple times.
Thu, Apr 25, 11:18 AM · Plasma

Wed, Apr 24

shubham added a comment to D20626: Refactor and cleanup.

@dfaure Ping?

Wed, Apr 24, 3:50 PM · Frameworks
shubham updated the summary of D20626: Refactor and cleanup.
Wed, Apr 24, 3:50 PM · Frameworks

Mon, Apr 22

shubham added a reviewer for D20745: Open new terminal in the same directory: hein.
Mon, Apr 22, 6:45 PM
shubham added a comment to D20735: [KPropertiesDialog] Add octal permissions.
In D20735#454263, @pino wrote:

Tried to print it as octal-based value?

No, now I get that those permissions were base 10.
How to print it as octal?

Mon, Apr 22, 4:21 PM · Frameworks
shubham added a comment to D20735: [KPropertiesDialog] Add octal permissions.

I had used permission() to get the mode_t variable, which I later type casted to qint64, still the permissions resulted were completed wrong.

Mon, Apr 22, 3:58 PM · Frameworks
shubham updated the summary of D20735: [KPropertiesDialog] Add octal permissions.
Mon, Apr 22, 2:16 PM · Frameworks
shubham updated the test plan for D20735: [KPropertiesDialog] Add octal permissions.
Mon, Apr 22, 12:03 PM · Frameworks
shubham requested review of D20735: [KPropertiesDialog] Add octal permissions.
Mon, Apr 22, 12:02 PM · Frameworks

Sat, Apr 20

shubham closed D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.
Sat, Apr 20, 2:22 PM · Frameworks
shubham committed R245:b63c2a236faf: Fix no member named 'setTime_t' in 'QDateTime' error while building (authored by shubham).
Fix no member named 'setTime_t' in 'QDateTime' error while building
Sat, Apr 20, 2:22 PM
shubham updated the diff for D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.

Fix unintentional mode change

Sat, Apr 20, 1:49 PM · Frameworks
shubham updated the summary of D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.
Sat, Apr 20, 6:40 AM · Frameworks
shubham requested review of D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.
Sat, Apr 20, 6:38 AM · Frameworks

Fri, Apr 19

shubham updated the test plan for D20626: Refactor and cleanup.
Fri, Apr 19, 8:25 AM · Frameworks
shubham updated the test plan for D20626: Refactor and cleanup.
Fri, Apr 19, 8:16 AM · Frameworks

Thu, Apr 18

shubham committed R241:8eddb63b0460: Merge branch 'master' of https://anongit.kde.org/kio (authored by shubham).
Merge branch 'master' of https://anongit.kde.org/kio
Thu, Apr 18, 8:09 AM
shubham committed R241:eb99a363724f: Remove TODO (authored by shubham).
Remove TODO
Thu, Apr 18, 8:09 AM
shubham abandoned D20639: Remove TODO.
Thu, Apr 18, 3:17 AM · Frameworks

Wed, Apr 17

shubham requested review of D20639: Remove TODO.
Wed, Apr 17, 5:27 PM · Frameworks
shubham added a comment to D20625: Truncate trailing forward slashes(/).

@dfaure Intention was just to fix the TODO

Wed, Apr 17, 4:35 PM · Frameworks
shubham committed R241:acc6b9b71b51: Truncate trailing forward slashes(/) (authored by shubham).
Truncate trailing forward slashes(/)
Wed, Apr 17, 4:34 PM
shubham closed D20625: Truncate trailing forward slashes(/).
Wed, Apr 17, 4:34 PM · Frameworks
shubham updated the test plan for D20625: Truncate trailing forward slashes(/).
Wed, Apr 17, 2:02 PM · Frameworks
shubham updated the diff for D20625: Truncate trailing forward slashes(/).

Correcty chop trailing slash

Wed, Apr 17, 2:01 PM · Frameworks
shubham requested review of D20626: Refactor and cleanup.
Wed, Apr 17, 8:20 AM · Frameworks
shubham added a reviewer for D20625: Truncate trailing forward slashes(/): dfaure.
Wed, Apr 17, 7:58 AM · Frameworks
shubham requested review of D20625: Truncate trailing forward slashes(/).
Wed, Apr 17, 7:56 AM · Frameworks

Tue, Apr 16

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

@ngraham @aacid Ping?

Tue, Apr 16, 6:39 AM · Documentation, Okular

Fri, Apr 12

shubham added a comment to D18384: Allow creating directory named '~' and throw a warning before creating it..

@ngraham Are you still working on this?

Fri, Apr 12, 6:12 AM · Frameworks
shubham added a comment to D18563: Don't create directory tree when a new folder has a '/' in the name.

@ngraham Are you working on it?

Fri, Apr 12, 6:11 AM · Frameworks

Mon, Apr 8

shubham updated the test plan for D18744: Add action in Edit menu to select the text on current page.
Mon, Apr 8, 4:10 PM · Documentation, Okular
shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.

Do not copy to clipboard

Mon, Apr 8, 4:09 PM · Documentation, Okular
shubham updated the test plan for D18744: Add action in Edit menu to select the text on current page.
Mon, Apr 8, 4:06 PM · Documentation, Okular

Sat, Apr 6

shubham added a comment to D20269: Fix typo and constantify arguments.

Looks alright, although I wouldn't call that thing a typo. Variable names in C++ doesn't have to match in function header and implementation, although, it's probably less confusing if they match. But sometimes one can simply omit names in header and just have types.

Sat, Apr 6, 4:20 AM · KDE Partition Manager

Fri, Apr 5

shubham added a project to D20269: Fix typo and constantify arguments: KDE Partition Manager.
Fri, Apr 5, 2:35 PM · KDE Partition Manager
shubham requested review of D20269: Fix typo and constantify arguments.
Fri, Apr 5, 2:34 PM · KDE Partition Manager

Sat, Mar 30

shubham abandoned D20109: Be consistent with rest of coding style.

Abandoned in favour of above comments

Sat, Mar 30, 3:41 PM · KDE Partition Manager
shubham added a comment to D20109: Be consistent with rest of coding style.

I don't think we should change other lines too here. We pass that percent to KJob, so keep the type the same as KJob expects.

Sat, Mar 30, 2:16 PM · KDE Partition Manager
shubham committed R563:10024cad2a37: Fix typo in comments (authored by shubham).
Fix typo in comments
Sat, Mar 30, 8:02 AM

Fri, Mar 29

shubham updated the diff for D20108: Constantify nonce and some cleanup.

Move QCA header outside Qt headers

Fri, Mar 29, 10:26 AM · KDE Partition Manager
shubham edited reviewers for D20108: Constantify nonce and some cleanup, added: cjlcarvalho; removed: caiovosilva.
Fri, Mar 29, 10:24 AM · KDE Partition Manager
shubham updated the diff for D20109: Be consistent with rest of coding style.

Do not change argument type for percent(KJob*, unsigned long) signal

Fri, Mar 29, 9:49 AM · KDE Partition Manager
shubham added a project to D20110: Fix typo: KDE Partition Manager.
Fri, Mar 29, 9:41 AM · KDE Partition Manager
shubham requested review of D20110: Fix typo.
Fri, Mar 29, 9:41 AM · KDE Partition Manager
shubham added a project to D20109: Be consistent with rest of coding style: KDE Partition Manager.
Fri, Mar 29, 8:51 AM · KDE Partition Manager
shubham requested review of D20109: Be consistent with rest of coding style.
Fri, Mar 29, 8:49 AM · KDE Partition Manager
shubham added a project to D20108: Constantify nonce and some cleanup: KDE Partition Manager.
Fri, Mar 29, 7:06 AM · KDE Partition Manager
shubham requested review of D20108: Constantify nonce and some cleanup.
Fri, Mar 29, 7:06 AM · KDE Partition Manager
shubham abandoned D20107: Simplify write condition.
Fri, Mar 29, 6:52 AM · KDE Partition Manager
shubham added a project to D20107: Simplify write condition: KDE Partition Manager.
Fri, Mar 29, 6:33 AM · KDE Partition Manager
shubham requested review of D20107: Simplify write condition.
Fri, Mar 29, 6:32 AM · KDE Partition Manager
shubham updated the summary of D20106: Constantify function parameters.
Fri, Mar 29, 5:56 AM · KDE Partition Manager
shubham added a project to D20106: Constantify function parameters: KDE Partition Manager.
Fri, Mar 29, 5:55 AM · KDE Partition Manager
shubham requested review of D20106: Constantify function parameters.
Fri, Mar 29, 5:54 AM · KDE Partition Manager

Wed, Mar 27

shubham added a comment to D20076: Do not use C data type.

I did not find any other occurrences of unsigned long long, so probably quint64 is the coding style

Wed, Mar 27, 1:48 PM · KDE Partition Manager
shubham added a project to D20076: Do not use C data type: KDE Partition Manager.
Wed, Mar 27, 11:10 AM · KDE Partition Manager
shubham requested review of D20076: Do not use C data type.
Wed, Mar 27, 11:09 AM · KDE Partition Manager

Mar 26 2019

shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.

Do not delete area

Mar 26 2019, 1:44 PM · Documentation, Okular

Mar 25 2019

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

@aacid area is a RegularAreaRect object which is a QRect bounding the selected text. "area" is to be deleted in all the cases except the case in which it is not possible to delete it since "area" will not contain any text in it and hence it will be nullptr. (case: if text is empty string) and hence return is called instead of deleting the "area".

Mar 25 2019, 2:50 PM · Documentation, Okular

Mar 24 2019

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

Try to fix the crash. I could not test it because for me I could not see the entry added to the menu.

You gotta fix that. :) Try deleting ~/.local/share/kxmlgui5/okular/partrc Does that help?

Mar 24 2019, 6:07 PM · Documentation, Okular
shubham added inline comments to D18744: Add action in Edit menu to select the text on current page.
Mar 24 2019, 6:06 PM · Documentation, Okular
shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.

Try to fix the crash. I could not test it because for me I could not see the entry added to the menu.

Mar 24 2019, 6:00 PM · Documentation, Okular

Mar 23 2019

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

@ngraham @aacid Ping?

Mar 23 2019, 6:41 AM · Documentation, Okular

Mar 21 2019

shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.

Remove useless return

Mar 21 2019, 4:21 PM · Documentation, Okular

Mar 14 2019

shubham added a comment to D19008: Add context menu entry to copy link text.

@drosca I had a look at those and found some python files doing something, still, I can't figure out what I have to do. Can you help a bit?

Mar 14 2019, 5:38 AM · Falkon

Mar 13 2019

shubham abandoned D18816: Accept and ignore event.
Mar 13 2019, 2:10 PM · Okular
shubham updated the test plan for D18744: Add action in Edit menu to select the text on current page.
Mar 13 2019, 2:09 PM · Documentation, Okular
shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.

Make requested changes by Albert and Nate

Mar 13 2019, 2:09 PM · Documentation, Okular
shubham committed R223:4610929e0c38: Use logically correct icon for direction arrows (authored by shubham).
Use logically correct icon for direction arrows
Mar 13 2019, 1:55 PM
shubham closed D19183: Use logically correct icon for direction arrows.
Mar 13 2019, 1:55 PM · Okular
shubham updated the diff for D19183: Use logically correct icon for direction arrows.

Rebase on master

Mar 13 2019, 1:54 PM · Okular

Mar 10 2019

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

Surely I can do that, but currently I am busy with my exams. Give me a week's time.

Mar 10 2019, 6:27 PM · Documentation, Okular

Mar 3 2019

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

@aacid Ping?

Mar 3 2019, 5:37 AM · Documentation, Okular
shubham added a comment to D19183: Use logically correct icon for direction arrows.

@aacid @ngraham Is this good to go now?

Mar 3 2019, 5:36 AM · Okular

Mar 1 2019

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

I will wait for @aacid's review before landing it.

Mar 1 2019, 2:10 AM · Documentation, Okular

Feb 28 2019

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

@aacid @ngraham Can you please confirm it now works to your expectations so that I can go ahead pushing this?

Feb 28 2019, 5:54 AM · Documentation, Okular

Feb 27 2019

shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.
Feb 27 2019, 2:48 PM · Documentation, Okular
shubham updated the diff for D19183: Use logically correct icon for direction arrows.

remove check for layout Direction

Feb 27 2019, 2:31 PM · Okular

Feb 26 2019

shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.
  1. Try to fix crash case
  2. Improve comment
Feb 26 2019, 4:49 AM · Documentation, Okular
shubham added a comment to D18816: Accept and ignore event.

The ping is on your side, you still haven't explained why this is needed and what it fixes

Feb 26 2019, 2:05 AM · Okular
shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

@yurchor what about the crash case, is it fixed now?

No. I think that the action should be created in part.cpp, setEnabled(false) by default, then setEnabled(true) in the Part::openFile to avoid the crash.

Regretfully, no function (like isOpened) for setEnabled to connect to.

Feb 26 2019, 2:03 AM · Documentation, Okular

Feb 25 2019

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

@yurchor what about the crash case, is it fixed now?

Feb 25 2019, 12:08 PM · Documentation, Okular
shubham added a comment to D19183: Use logically correct icon for direction arrows.

@aacid Do you have anything to say?

Feb 25 2019, 1:48 AM · Okular
shubham added a comment to D18563: Don't create directory tree when a new folder has a '/' in the name.

@ngraham Any updates?

Feb 25 2019, 1:47 AM · Frameworks
shubham added a comment to D18384: Allow creating directory named '~' and throw a warning before creating it..

@ngraham Any updates?

Feb 25 2019, 1:46 AM · Frameworks
shubham added a comment to D19008: Add context menu entry to copy link text.

@drosca I had a look at those and found some python files doing something, still, I can't figure out what I have to do. Can you help a bit?

Feb 25 2019, 1:45 AM · Falkon
shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

I can't test it since for me, somehow I don't see the action added to the menu.

Feb 25 2019, 1:41 AM · Documentation, Okular
shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.

Enable action for all the modes
Try to fix crash

Feb 25 2019, 1:40 AM · Documentation, Okular

Feb 23 2019

shubham added a comment to D18816: Accept and ignore event.

Ping?

Feb 23 2019, 10:07 AM · Okular
shubham updated the test plan for D18744: Add action in Edit menu to select the text on current page.
Feb 23 2019, 9:49 AM · Documentation, Okular

Feb 22 2019

shubham added a comment to D19183: Use logically correct icon for direction arrows.

What's the call?

Feb 22 2019, 2:11 PM · Okular

Feb 21 2019

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

@aacid ping?

Feb 21 2019, 6:15 PM · Documentation, Okular

Feb 20 2019

shubham updated the test plan for D19183: Use logically correct icon for direction arrows.
Feb 20 2019, 2:38 PM · Okular
shubham retitled D19183: Use logically correct icon for direction arrows from Use logically correct icon to Use logically correct icon for direction arrows.
Feb 20 2019, 2:36 PM · Okular
shubham added a reviewer for D19183: Use logically correct icon for direction arrows: VDG.
Feb 20 2019, 2:36 PM · Okular