shubham (Shubham )
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2018, 3:31 PM (63 w, 2 d)
Availability
Available

Recent Activity

Mon, Aug 19

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Try to start the helper(Atleast polkit-qt-1)

Mon, Aug 19, 6:13 AM · KDE Partition Manager
shubham updated the summary of D23255: Change warning dialog box to a question dialog box.
Mon, Aug 19, 6:08 AM · Dolphin
shubham added a reviewer for D23255: Change warning dialog box to a question dialog box: elvisangelaccio.
Mon, Aug 19, 6:07 AM · Dolphin
shubham requested review of D23255: Change warning dialog box to a question dialog box.
Mon, Aug 19, 6:06 AM · Dolphin

Sun, Aug 18

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove unnecessary linking

Sun, Aug 18, 10:44 AM · KDE Partition Manager

Fri, Aug 16

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
  1. Fix runtime warnings inside initPolkitAgent()
  2. Use "new" inside ctor to instantiate object
Fri, Aug 16, 5:59 PM · KDE Partition Manager

Thu, Aug 15

shubham added reviewers for D23193: Add support for Belarusian currency: Frameworks, ngraham.
Thu, Aug 15, 6:59 PM · Frameworks
shubham requested review of D23193: Add support for Belarusian currency.
Thu, Aug 15, 6:59 PM · Frameworks

Wed, Aug 14

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Move helperMain() outside Q_SLOTS

Wed, Aug 14, 6:19 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

some more changes

Wed, Aug 14, 5:32 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Try fixing the inline comments

Wed, Aug 14, 5:30 PM · KDE Partition Manager
shubham added inline comments to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Wed, Aug 14, 5:00 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Wed, Aug 14, 4:56 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Try to fix the broken things

Wed, Aug 14, 4:07 PM · KDE Partition Manager

Sat, Aug 10

shubham retitled D23077: Modify restoration icon to make it look like something is being restored from the trash from Change restoration icon to Modify restoration icon to make it look like something is being restored from the trash.
Sat, Aug 10, 8:15 PM · Frameworks
shubham updated the summary of D23077: Modify restoration icon to make it look like something is being restored from the trash.
Sat, Aug 10, 8:13 PM · Frameworks
shubham updated the test plan for D23077: Modify restoration icon to make it look like something is being restored from the trash.
Sat, Aug 10, 8:09 PM · Frameworks
shubham added a reviewer for D23077: Modify restoration icon to make it look like something is being restored from the trash: VDG.
Sat, Aug 10, 8:07 PM · Frameworks
shubham requested review of D23077: Modify restoration icon to make it look like something is being restored from the trash.
Sat, Aug 10, 8:07 PM · Frameworks
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

QDBus communication

Sat, Aug 10, 7:28 PM · KDE Partition Manager
shubham reopened D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Sat, Aug 10, 7:27 PM · KDE Partition Manager

Fri, Aug 9

shubham added a comment to D23044: [Notifications] Swing the bell when there is a new notification.

Personally I do not like info button to be swung like a bell, however VDG are the right people to decide this.

Fri, Aug 9, 1:44 PM · Plasma
shubham updated the diff for D22321: Add unit test for Polkit backend.

Update wrt parent

Fri, Aug 9, 1:40 PM · KDE Partition Manager
shubham reopened D22321: Add unit test for Polkit backend.
Fri, Aug 9, 1:40 PM · KDE Partition Manager

Wed, Aug 7

shubham committed R16:49a9f776cd50: Merge branch 'auth-polkit-backend' into unittest (authored by shubham).
Merge branch 'auth-polkit-backend' into unittest
Wed, Aug 7, 12:33 PM
shubham closed D22321: Add unit test for Polkit backend.
Wed, Aug 7, 12:33 PM · KDE Partition Manager
shubham committed R16:cd004570d6cd: Authorize using Polkit backend, compile Helper as standalone application and… (authored by shubham).
Authorize using Polkit backend, compile Helper as standalone application and…
Wed, Aug 7, 12:31 PM
shubham closed D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Wed, Aug 7, 12:31 PM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt parent

Wed, Aug 7, 12:30 PM · KDE Partition Manager
shubham reopened D22321: Add unit test for Polkit backend.
Wed, Aug 7, 12:22 PM · KDE Partition Manager
shubham updated the summary of D22321: Add unit test for Polkit backend.
Wed, Aug 7, 12:22 PM · KDE Partition Manager
shubham updated the summary of D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Wed, Aug 7, 12:16 PM · KDE Partition Manager

Tue, Aug 6

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove unwanted signals

Tue, Aug 6, 8:24 AM · KDE Partition Manager
shubham committed R16:f4402bc6fbc4: final (authored by shubham).
final
Tue, Aug 6, 8:21 AM

Mon, Aug 5

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Mon, Aug 5, 6:05 PM · KDE Partition Manager
shubham reopened D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Mon, Aug 5, 6:04 PM · KDE Partition Manager
shubham closed D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Mon, Aug 5, 5:56 PM · KDE Partition Manager
shubham committed R16:486a14f9d0f2: [WIP]: Send progress through QDBus from helper towards application (authored by shubham).
[WIP]: Send progress through QDBus from helper towards application
Mon, Aug 5, 5:56 PM
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Mon, Aug 5, 5:50 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Rename function

Mon, Aug 5, 5:17 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Refactor

Mon, Aug 5, 4:55 PM · KDE Partition Manager

Sun, Aug 4

shubham added a comment to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

@stikonas Yes, I am planning to re utilize the code, my first intention was just to make it compile.

Sun, Aug 4, 12:08 PM · KDE Partition Manager
shubham retitled D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application from [WIP]: Send progress through QDBus from helper towards application to [WIP]: Send progress via QDBus from helper towards application.
Sun, Aug 4, 6:44 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

connect to newData signal in the application

Sun, Aug 4, 6:42 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Fix errors, make it compile

Sun, Aug 4, 6:30 AM · KDE Partition Manager

Fri, Aug 2

shubham added a comment to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

@stikonas It says error: ‘org’ does not name a type

auto interface = new org::kde::kpmcore::externalcommand(QStringLiteral("org.kde.kpmcore.externalcommand"),

I think I need to add ExternalCommand as an interface.

Fri, Aug 2, 2:58 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Refactor

Fri, Aug 2, 2:46 PM · KDE Partition Manager
shubham added a project to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application: KDE Partition Manager.
Fri, Aug 2, 8:52 AM · KDE Partition Manager
shubham requested review of D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Fri, Aug 2, 8:51 AM · KDE Partition Manager

Mon, Jul 29

shubham committed R16:17d703182e28: Merge branch 'auth-polkit-backend' of https://anongit.kde.org/kpmcore into… (authored by shubham).
Merge branch 'auth-polkit-backend' of https://anongit.kde.org/kpmcore into…
Mon, Jul 29, 3:19 PM
shubham committed R16:bea38fabb049: Rebase wrt parent (authored by shubham).
Rebase wrt parent
Mon, Jul 29, 3:19 PM
shubham closed D22321: Add unit test for Polkit backend.
Mon, Jul 29, 3:19 PM · KDE Partition Manager
shubham committed R16:919af698c683: a (authored by shubham).
a
Mon, Jul 29, 3:01 PM
shubham updated the diff for D22321: Add unit test for Polkit backend.

Add test to revoke authorization

Mon, Jul 29, 2:33 PM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt parent

Mon, Jul 29, 2:25 PM · KDE Partition Manager
shubham committed R16:5d5aaa1a749c: Proper rebase (authored by shubham).
Proper rebase
Mon, Jul 29, 2:14 PM
shubham closed D22438: Authorize using Polkit backend and compile Helper as standalone application.
Mon, Jul 29, 2:14 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Remove extra line changes

Mon, Jul 29, 2:11 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Proper rebase

Mon, Jul 29, 2:08 PM · KDE Partition Manager

Sun, Jul 28

shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

.

Sun, Jul 28, 7:21 AM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Rebase

Sun, Jul 28, 7:18 AM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Rebase wrt master

Sun, Jul 28, 7:14 AM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt parent

Sun, Jul 28, 6:37 AM · KDE Partition Manager
shubham abandoned D22593: Compile helper into standalone application.

Merged this with the main patch ie. authorization backend

Sun, Jul 28, 6:24 AM · KDE Partition Manager
shubham retitled D22438: Authorize using Polkit backend and compile Helper as standalone application from Authorize using Polkit backend and implement QDBus communication between App and Helper to Authorize using Polkit backend and compile Helper as standalone application.
Sun, Jul 28, 6:23 AM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Compile helper as standalone

Sun, Jul 28, 6:22 AM · KDE Partition Manager
shubham reopened D22438: Authorize using Polkit backend and compile Helper as standalone application.
Sun, Jul 28, 6:22 AM · KDE Partition Manager
shubham committed R16:5f253ed78d03: a (authored by shubham).
a
Sun, Jul 28, 6:17 AM
shubham closed D22438: Authorize using Polkit backend and compile Helper as standalone application.
Sun, Jul 28, 6:17 AM · KDE Partition Manager
shubham committed R16:b5b46b468079: Authorize using Polkit backend and implement QDBus communication between App… (authored by shubham).
Authorize using Polkit backend and implement QDBus communication between App…
Sun, Jul 28, 6:17 AM
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Rebase on master

Sun, Jul 28, 5:58 AM · KDE Partition Manager

Sat, Jul 27

shubham added a reviewer for D22679: Remove code which resulted useless action: broulik.
Sat, Jul 27, 10:17 AM

Thu, Jul 25

shubham added a comment to D22444: Add Reset Zoom Level action inside View menu.

Oops, I had a perception that you have to press - twice to zoom out. Maybe it came to me from Windows.

Thu, Jul 25, 5:52 PM · Documentation, Dolphin
shubham added a comment to D22444: Add Reset Zoom Level action inside View menu.

If I am not blind, it shows ctrl+-. :)

Thu, Jul 25, 5:25 PM · Documentation, Dolphin
shubham added a comment to D22444: Add Reset Zoom Level action inside View menu.

Shouldn't the zoom out shortcut be ctrl-- or is it already occupied?

Thu, Jul 25, 5:22 PM · Documentation, Dolphin
shubham retitled D22438: Authorize using Polkit backend and compile Helper as standalone application from [WIP]: Authorize using Polkit backend and implement QDBus communication between App and Helper to Authorize using Polkit backend and implement QDBus communication between App and Helper.
Thu, Jul 25, 3:10 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.
Thu, Jul 25, 3:02 PM · KDE Partition Manager
shubham updated the diff for D22438: Authorize using Polkit backend and compile Helper as standalone application.

Final changes

Thu, Jul 25, 3:01 PM · KDE Partition Manager
shubham added a comment to D22479: Prompt user to save or discard changes.

The license in dolphin says "you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version".

Thu, Jul 25, 2:54 PM · Kate
shubham added a comment to D22479: Prompt user to save or discard changes.

So what to do?

Thu, Jul 25, 2:10 PM · Kate
shubham added a comment to D22444: Add Reset Zoom Level action inside View menu.

@shubham are you able to make those changes?

Thu, Jul 25, 2:35 AM · Documentation, Dolphin

Wed, Jul 24

shubham added a comment to D22479: Prompt user to save or discard changes.

It is exact copy of the dolphin code.

Wed, Jul 24, 3:27 PM · Kate
shubham updated subscribers of D22479: Prompt user to save or discard changes.
Wed, Jul 24, 8:07 AM · Kate
shubham added a comment to D22479: Prompt user to save or discard changes.

@cullmann what's you say?

Wed, Jul 24, 8:07 AM · Kate

Tue, Jul 23

shubham updated the diff for D22679: Remove code which resulted useless action.

Simplify much more

Tue, Jul 23, 8:09 PM
shubham added inline comments to D22679: Remove code which resulted useless action.
Tue, Jul 23, 8:07 PM
shubham updated the diff for D22679: Remove code which resulted useless action.

made some more changes

Tue, Jul 23, 8:05 PM
shubham updated the summary of D22679: Remove code which resulted useless action.
Tue, Jul 23, 7:40 PM
shubham updated the test plan for D22679: Remove code which resulted useless action.
Tue, Jul 23, 7:38 PM
shubham updated the diff for D22679: Remove code which resulted useless action.

Made requested changes

Tue, Jul 23, 7:37 PM

Jul 23 2019

shubham updated the summary of D22679: Remove code which resulted useless action.
Jul 23 2019, 3:20 PM
shubham added a reviewer for D22679: Remove code which resulted useless action: ngraham.
Jul 23 2019, 11:03 AM
shubham added reviewers for D22679: Remove code which resulted useless action: cfeck, teran.
Jul 23 2019, 10:59 AM
shubham requested review of D22679: Remove code which resulted useless action.
Jul 23 2019, 10:56 AM
shubham committed R16:7af8045f3263: Add unit test for Device (authored by shubham).
Add unit test for Device
Jul 23 2019, 6:30 AM
shubham closed D22629: Add unit test for Device.
Jul 23 2019, 6:30 AM

Jul 22 2019

shubham added a comment to D22629: Add unit test for Device.

@stikonas @cjlcarvalho ping?

Jul 22 2019, 8:14 PM
shubham updated the diff for D22629: Add unit test for Device.

Remove more useless includes

Jul 22 2019, 4:51 AM
shubham updated the diff for D22629: Add unit test for Device.

Remove useless includes

Jul 22 2019, 4:46 AM
shubham updated the diff for D22629: Add unit test for Device.

Check for all the available devices

Jul 22 2019, 4:44 AM