shubham (Shubham )
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2018, 3:31 PM (37 w, 2 d)
Availability
Available

Recent Activity

Yesterday

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

@aacid ping?

Thu, Feb 21, 6:15 PM · Documentation, Okular

Wed, Feb 20

shubham updated the test plan for D19183: Use logically correct icon for direction arrows.
Wed, Feb 20, 2:38 PM · Okular
shubham retitled D19183: Use logically correct icon for direction arrows from Use logically correct icon to Use logically correct icon for direction arrows.
Wed, Feb 20, 2:36 PM · Okular
shubham added a reviewer for D19183: Use logically correct icon for direction arrows: VDG.
Wed, Feb 20, 2:36 PM · Okular
shubham requested review of D19183: Use logically correct icon for direction arrows.
Wed, Feb 20, 2:34 PM · Okular
shubham added a comment to D15742: Add close tab and create new tab on middle click event.

Nice job, @shubham. Wanna do the same thing for Okular next? https://bugs.kde.org/show_bug.cgi?id=361756. Probably doesn't need an option there.

Wed, Feb 20, 3:17 AM · Konsole

Tue, Feb 19

shubham updated the diff for D15742: Add close tab and create new tab on middle click event.

Proper rebase on master

Tue, Feb 19, 3:23 PM · Konsole
shubham added a comment to D15742: Add close tab and create new tab on middle click event.

@emateli do you know how can I go to previous version I have uploaded?

Tue, Feb 19, 2:48 PM · Konsole
shubham added a comment to D15742: Add close tab and create new tab on middle click event.

Yes, noticed, going to fix in a moment

Tue, Feb 19, 2:46 PM · Konsole
shubham updated the diff for D15742: Add close tab and create new tab on middle click event.

Rebase on master

Tue, Feb 19, 2:37 PM · Konsole

Mon, Feb 18

shubham updated the diff for D15742: Add close tab and create new tab on middle click event.

Changes as requested by ngraham and kurt

Mon, Feb 18, 3:40 PM · Konsole

Sun, Feb 17

shubham added a comment to D18719: [WIP]Create context menu entry to rotate individual pages.

How do I resolve this?

Sun, Feb 17, 6:58 PM · Okular
shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.

Remove shortcut and it's documentation

Sun, Feb 17, 4:47 PM · Documentation, Okular
shubham abandoned D17599: Confirm closing muliple tabs..

I think this is going towards being abandoned.

Sun, Feb 17, 4:40 PM · Kate
shubham added a comment to D15742: Add close tab and create new tab on middle click event.

what should I now name the gui message? It will become quite big then.

Sun, Feb 17, 4:37 PM · Konsole
shubham updated the summary of D15742: Add close tab and create new tab on middle click event.
Sun, Feb 17, 4:36 PM · Konsole
shubham added a comment to D15742: Add close tab and create new tab on middle click event.

I can confirm that middle click on empty portion of the bar creates a new tab.

Sun, Feb 17, 4:35 PM · Konsole
shubham added a comment to D18744: Add action in Edit menu to select the text on current page.
  1. Quadruple-click to select whole page What do other folks think?

In my view quadruple click does not make sense because it is seldom the user can think it cam result in some kind of action or behaviour.
Secondly, this feature then would remain hidden or unknown about, even though I originally implemented this in double click. I would prefer double click over quadruple since for me double click is expected to do something, but surely quadruple not.(I don't know about others)
At the end you all are much more experienced amd understand UX way better than me, I will leave this to you.

Sun, Feb 17, 2:17 AM · Documentation, Okular

Sat, Feb 16

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

OK, works for me now. I'm not thrilled about the Alt-P shortcut since it's the only one in the menu that uses only the Alt modifier. But I won't block on that. I'll hand this back to the Okular folks now.

Sat, Feb 16, 3:58 PM · Documentation, Okular
shubham added a comment to D15742: Add close tab and create new tab on middle click event.

because that report also requests the feature of middle-clicking in empty areas of the tab bar to create new tabs.
...Unless you want to implement that, too. :)

I think it is not required, since we would be just duplicating the double click behaviour then. Currently double click does this.

Sat, Feb 16, 3:49 PM · Konsole
shubham updated the summary of D15742: Add close tab and create new tab on middle click event.
Sat, Feb 16, 3:41 PM · Konsole
shubham added a comment to D17599: Confirm closing muliple tabs..

@cullmann Don't you think this is some nice feature to have, having think of frustration one can have when they close kate thinking it will only close current tab, and unexpectedly all their tabs are closed.

Sat, Feb 16, 3:40 PM · Kate
shubham updated the test plan for D15742: Add close tab and create new tab on middle click event.
Sat, Feb 16, 3:16 PM · Konsole
shubham updated the diff for D15742: Add close tab and create new tab on middle click event.

Remove unnecessary change
Correct wordings

Sat, Feb 16, 3:14 PM · Konsole
shubham added a comment to D15742: Add close tab and create new tab on middle click event.

@hindenburg @ngraham Friendly Ping

Sat, Feb 16, 2:59 PM · Konsole
shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.

Correct shortcut in documentation
Fix coding style

Sat, Feb 16, 8:28 AM · Documentation, Okular
shubham retitled D15742: Add close tab and create new tab on middle click event from Handle middle click on tabs to Close tab on middle click event.
Sat, Feb 16, 7:57 AM · Konsole
shubham updated the summary of D15742: Add close tab and create new tab on middle click event.
Sat, Feb 16, 7:56 AM · Konsole
shubham updated the test plan for D15742: Add close tab and create new tab on middle click event.
Sat, Feb 16, 7:55 AM · Konsole
shubham updated the diff for D15742: Add close tab and create new tab on middle click event.

Add config option in TabBar settings

Sat, Feb 16, 7:53 AM · Konsole
shubham updated the summary of D15742: Add close tab and create new tab on middle click event.
Sat, Feb 16, 7:33 AM · Konsole
shubham updated the diff for D15742: Add close tab and create new tab on middle click event.

Do not use camel case in strings

Sat, Feb 16, 7:32 AM · Konsole
shubham updated the diff for D15742: Add close tab and create new tab on middle click event.

Make closing tabs on middle mouse button configurable

Sat, Feb 16, 7:28 AM · Konsole
shubham added a comment to D17599: Confirm closing muliple tabs..

How to take settings into account?

Sat, Feb 16, 3:04 AM · Kate

Fri, Feb 15

shubham added a comment to D19008: Add context menu entry to copy link text.

I meant that I don't want this feature. Context menu on page is already very long, and if it contained every action that someone requested on bugzilla, it would not even fit on screen.

So, as with other similar features, I always say that it should go into plugin. It is now also possible to create script plugins (instead of C++ libraries), which is preferred for adding functionality such as this patch.

Fri, Feb 15, 4:47 PM · Falkon
shubham added a comment to D19008: Add context menu entry to copy link text.

I did not get what you meant, can you please explain a bit?

Fri, Feb 15, 2:17 PM · Falkon
shubham added a reviewer for D19008: Add context menu entry to copy link text: ngraham.
Fri, Feb 15, 2:05 PM · Falkon
shubham retitled D18744: Add action in Edit menu to select the text on current page from Add action in Edit menu to select the current page to Add action in Edit menu to select the text on current page.
Fri, Feb 15, 2:55 AM · Documentation, Okular
shubham updated the test plan for D18744: Add action in Edit menu to select the text on current page.
Fri, Feb 15, 2:49 AM · Documentation, Okular
shubham updated the test plan for D18744: Add action in Edit menu to select the text on current page.
Fri, Feb 15, 1:24 AM · Documentation, Okular

Thu, Feb 14

shubham retitled D18744: Add action in Edit menu to select the text on current page from [RFC]Add action in Edit menu to select the current page to Add action in Edit menu to select the current page.
Thu, Feb 14, 4:43 PM · Documentation, Okular
shubham requested review of D19008: Add context menu entry to copy link text.
Thu, Feb 14, 4:37 PM · Falkon
shubham updated the test plan for D18744: Add action in Edit menu to select the text on current page.
Thu, Feb 14, 3:49 PM · Documentation, Okular
shubham commandeered D15742: Add close tab and create new tab on middle click event.
Thu, Feb 14, 2:50 PM · Konsole
shubham retitled D18744: Add action in Edit menu to select the text on current page from Add action in Edit menu to select the current page to [RFC]Add action in Edit menu to select the current page.
Thu, Feb 14, 2:48 PM · Documentation, Okular
shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.

Add action to part.rc
Bump version to 40

Thu, Feb 14, 2:47 PM · Documentation, Okular
shubham added inline comments to D18744: Add action in Edit menu to select the text on current page.
Thu, Feb 14, 3:13 AM · Documentation, Okular
shubham added inline comments to D18744: Add action in Edit menu to select the text on current page.
Thu, Feb 14, 2:59 AM · Documentation, Okular

Wed, Feb 13

shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

Please test your changes. The new menu is not actually added to the Edit menu and the shortcut you chose conflicts with the print shortcut.

Wed, Feb 13, 7:07 PM · Documentation, Okular
shubham updated the test plan for D18744: Add action in Edit menu to select the text on current page.
Wed, Feb 13, 5:24 PM · Documentation, Okular
shubham retitled D18744: Add action in Edit menu to select the text on current page from Add action in Edit menu to select the entire page to Add action in Edit menu to select the current page .
Wed, Feb 13, 5:12 PM · Documentation, Okular
shubham retitled D18744: Add action in Edit menu to select the text on current page from Select entire page on mouse double click event to Add action in Edit menu to select the entire page .
Wed, Feb 13, 5:11 PM · Documentation, Okular
shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.

Remove unneeded comment

Wed, Feb 13, 5:09 PM · Documentation, Okular
shubham updated the diff for D18744: Add action in Edit menu to select the text on current page.

Add action and shortcut to select the current page
Remove triggering on mouseDoubleClick event

Wed, Feb 13, 5:05 PM · Documentation, Okular
shubham updated the test plan for D17599: Confirm closing muliple tabs..
Wed, Feb 13, 2:47 PM · Kate
shubham updated the diff for D17599: Confirm closing muliple tabs..

Restore Cancel button

Wed, Feb 13, 2:46 PM · Kate
shubham added a comment to D17599: Confirm closing muliple tabs..

@ngraham What about the code? Is it okay if you had a look?

Wed, Feb 13, 2:37 PM · Kate
shubham added a comment to D15742: Add close tab and create new tab on middle click event.

@tcanabrava If you don't mind, can I commander this revision?

Wed, Feb 13, 7:48 AM · Konsole

Tue, Feb 12

shubham added a comment to D17599: Confirm closing muliple tabs..

Ping?

Tue, Feb 12, 4:48 PM · Kate
shubham abandoned D18606: [WIP]Close tab on middle mouse button event.
Tue, Feb 12, 4:47 PM · Konsole
shubham added a comment to D18606: [WIP]Close tab on middle mouse button event.

What should I do to this revision? continue or abandon in favor of the other?

Tue, Feb 12, 3:30 PM · Konsole
shubham updated the diff for D18719: [WIP]Create context menu entry to rotate individual pages.

use rotateAt()

Tue, Feb 12, 3:27 PM · Okular
shubham added a comment to D18719: [WIP]Create context menu entry to rotate individual pages.
Tue, Feb 12, 1:30 PM · Okular
shubham committed R134:c62901d8aed6: Don't show tooltip when search field has text and set a timeout period (authored by shubham).
Don't show tooltip when search field has text and set a timeout period
Tue, Feb 12, 12:53 PM
shubham closed D18766: Don't show tooltip when search field has text.
Tue, Feb 12, 12:53 PM · Plasma
shubham added a comment to D18816: Accept and ignore event.

Unless you have a bug that needs this fix, i really prefer if you don't touch event handling

Tue, Feb 12, 8:20 AM · Okular

Sun, Feb 10

shubham added a comment to D18766: Don't show tooltip when search field has text.

Yes, let's land it. Please land it on the 5.15 branch and then merge to master. If you don't know how to do that, I can help you.

Sun, Feb 10, 2:42 PM · Plasma
shubham added a comment to D18766: Don't show tooltip when search field has text.

@ngraham Is it now behaving as it should?

Sun, Feb 10, 2:39 PM · Plasma
shubham added a comment to D18816: Accept and ignore event.

Ping

Sun, Feb 10, 2:01 PM · Okular
shubham closed D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e).
Sun, Feb 10, 2:00 PM · Frameworks, Kate
shubham committed R39:b9a52834ec45: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e) (authored by shubham).
Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)
Sun, Feb 10, 2:00 PM
shubham retitled D18766: Don't show tooltip when search field has text from Don't show tooltip when search field has text and set a timeout period to Don't show tooltip when search field has text.
Sun, Feb 10, 3:28 AM · Plasma
shubham added a comment to D18766: Don't show tooltip when search field has text.

Works for me, no segfault. I don't see any reason why this change could cause that. @shubham, does the segfault stop happening when you build Discover from source without this change?

Sun, Feb 10, 3:26 AM · Plasma

Sat, Feb 9

shubham added a comment to D18766: Don't show tooltip when search field has text.

It compiles but I could not test this. When I run the plasma-discover segmentation fault prevails.

Sat, Feb 9, 4:48 PM · Plasma
shubham updated the diff for D18766: Don't show tooltip when search field has text.

Remove timeout period

Sat, Feb 9, 4:46 PM · Plasma
shubham added inline comments to D18719: [WIP]Create context menu entry to rotate individual pages.
Sat, Feb 9, 4:30 PM · Okular
shubham retitled D18719: [WIP]Create context menu entry to rotate individual pages from [RFC]Create context menu entry to rotate individual pages to [WIP]Create context menu entry to rotate individual pages.
Sat, Feb 9, 4:29 PM · Okular
shubham updated the diff for D18719: [WIP]Create context menu entry to rotate individual pages.

Remove unneeded include

Sat, Feb 9, 4:28 PM · Okular
shubham updated the diff for D18719: [WIP]Create context menu entry to rotate individual pages.

Rotate

Sat, Feb 9, 4:26 PM · Okular
shubham added a comment to D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable.

Can someone experienced review this?

Sat, Feb 9, 3:30 PM · Frameworks
shubham added a comment to D18719: [WIP]Create context menu entry to rotate individual pages.

@aacid stuck with what my inline message says.

Sat, Feb 9, 3:17 PM · Okular
shubham retitled D18606: [WIP]Close tab on middle mouse button event from [RFC]Close tab on middle mouse button event to [WIP]Close tab on middle mouse button event.
Sat, Feb 9, 3:11 PM · Konsole
shubham added a comment to D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e).

Is it okay now?

Sat, Feb 9, 2:16 PM · Frameworks, Kate
shubham added a comment to D18719: [WIP]Create context menu entry to rotate individual pages.

Any piece of help would be appreciated, I m stuck.

Sat, Feb 9, 2:25 AM · Okular

Fri, Feb 8

shubham added a comment to D18606: [WIP]Close tab on middle mouse button event.

I don't think we should present a dialog box because previously I have heard that dialog boxes are annoying to most users. @ngraham will know it.

Fri, Feb 8, 4:47 PM · Konsole
shubham added a reviewer for D18854: Allow changing the foreground/text color of buttons: cfeck.
Fri, Feb 8, 4:11 PM
shubham added a comment to D15742: Add close tab and create new tab on middle click event.

@tcanabrava Are you still working on this, because I did not knew about this revision and created a new revision for the same feature
Please see D18606

Fri, Feb 8, 7:57 AM · Konsole
shubham added a comment to D17599: Confirm closing muliple tabs..

Ping? Any comments, this patch is in review queue for almost 2 months now.

Fri, Feb 8, 7:52 AM · Kate
shubham added a comment to D17599: Confirm closing muliple tabs..

Um, why no Cancel button? As @emateli had shown this is usual. Is there a disadvantage to offer such button too?

Fri, Feb 8, 7:51 AM · Kate

Thu, Feb 7

shubham updated the summary of D18816: Accept and ignore event.
Thu, Feb 7, 4:16 PM · Okular
shubham updated the summary of D18816: Accept and ignore event.
Thu, Feb 7, 3:39 PM · Okular
shubham updated the summary of D18816: Accept and ignore event.
Thu, Feb 7, 3:38 PM · Okular
shubham requested review of D18816: Accept and ignore event.
Thu, Feb 7, 2:48 PM · Okular
shubham updated the diff for D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e).

Accept and ignore the event

Thu, Feb 7, 2:30 PM · Frameworks, Kate
shubham added inline comments to D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e).
Thu, Feb 7, 6:01 AM · Frameworks, Kate
shubham added a comment to D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e).

@dhaumann I don't think using switch when there is only a single case good thought

Thu, Feb 7, 3:01 AM · Frameworks, Kate

Wed, Feb 6

shubham updated the summary of D18744: Add action in Edit menu to select the text on current page.
Wed, Feb 6, 5:49 PM · Documentation, Okular
shubham updated the summary of D18744: Add action in Edit menu to select the text on current page.
Wed, Feb 6, 5:31 PM · Documentation, Okular
shubham added inline comments to R261:69363c800d5b: Use i18nc in case context is used.
Wed, Feb 6, 3:58 PM
shubham requested review of D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e).
Wed, Feb 6, 3:35 PM · Frameworks, Kate