shubham (Shubham )
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2018, 3:31 PM (79 w, 2 d)
Availability
Available

Recent Activity

Yesterday

shubham committed R7:c95244d25fe2: Rename action name to make it consistent with other applications (authored by shubham).
Rename action name to make it consistent with other applications
Thu, Dec 12, 2:09 PM
shubham added a comment to D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event.

@ngraham Ping?

Thu, Dec 12, 1:30 PM
shubham closed D23837: Rename action name to make it consistent with other applications.
Thu, Dec 12, 1:17 PM · Documentation

Tue, Nov 26

shubham added a comment to D23837: Rename action name to make it consistent with other applications.

@hein @ngraham Ping?

Tue, Nov 26, 1:55 PM · Documentation

Oct 27 2019

shubham added a comment to D24932: [WIP]: Add Button to open the folder in filelight for more details.

@ngraham How should I create a KService for runApplication?

Oct 27 2019, 1:24 PM · Frameworks

Oct 26 2019

shubham added inline comments to D24932: [WIP]: Add Button to open the folder in filelight for more details.
Oct 26 2019, 3:41 AM · Frameworks

Oct 25 2019

shubham updated the diff for D24932: [WIP]: Add Button to open the folder in filelight for more details.
Oct 25 2019, 4:12 PM · Frameworks

Oct 24 2019

shubham updated the summary of D24932: [WIP]: Add Button to open the folder in filelight for more details.
Oct 24 2019, 6:04 PM · Frameworks
shubham requested review of D24932: [WIP]: Add Button to open the folder in filelight for more details.
Oct 24 2019, 6:01 PM · Frameworks

Oct 19 2019

shubham committed R7:748c43324622: Remove period from the label (authored by shubham).
Remove period from the label
Oct 19 2019, 2:52 PM

Oct 8 2019

shubham committed R120:08823e7b08f5: Merge (authored by shubham).
Merge
Oct 8 2019, 6:29 PM
shubham committed R120:a719f0a7f4dc: Fix typo (authored by shubham).
Fix typo
Oct 8 2019, 6:29 PM
shubham added a comment to D24492: [FilteredDirIterator] Reduce stack pressure.

It is not a good practice to "goto" in C++

Oct 8 2019, 12:36 PM · Baloo, Frameworks

Oct 3 2019

shubham added a comment to D23837: Rename action name to make it consistent with other applications.

@hein Ping?

Oct 3 2019, 9:28 AM · Documentation

Sep 22 2019

shubham added a comment to D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event.

Ping?

Sep 22 2019, 1:09 PM
shubham removed a reviewer for D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event: broulik.
Sep 22 2019, 1:09 PM

Sep 16 2019

shubham committed R120:0de6c3066c15: Port to KRun::runApplication (authored by shubham).
Port to KRun::runApplication
Sep 16 2019, 12:17 PM

Sep 15 2019

shubham added inline comments to D23953: Warn before opening 5+ translation files.
Sep 15 2019, 9:31 AM · Localization
shubham added inline comments to D23953: Warn before opening 5+ translation files.
Sep 15 2019, 9:29 AM · Localization

Sep 11 2019

shubham reopened D23837: Rename action name to make it consistent with other applications.

Sorry for inconvenience caused, I thought blocking reviewer means that person can not review any longer. I have reverted this change. Here ba083b9983c19b13999a9733f7c1ec64c5347c8f

Sep 11 2019, 9:43 AM · Documentation
shubham committed R7:ba083b9983c1: Revert "Rename action name to make it consistent with other applications" (authored by shubham).
Revert "Rename action name to make it consistent with other applications"
Sep 11 2019, 9:42 AM
shubham added a reverting change for R7:695028fca543: Rename action name to make it consistent with other applications: R7:ba083b9983c1: Revert "Rename action name to make it consistent with other applications".
Sep 11 2019, 9:42 AM
shubham added a comment to D23837: Rename action name to make it consistent with other applications.

I saw green flag so went for it. You have any suggestions/queries?

Sep 11 2019, 9:24 AM · Documentation
shubham closed D23837: Rename action name to make it consistent with other applications.
Sep 11 2019, 9:13 AM · Documentation
shubham committed R7:695028fca543: Rename action name to make it consistent with other applications (authored by shubham).
Rename action name to make it consistent with other applications
Sep 11 2019, 9:13 AM

Sep 10 2019

shubham added reviewers for D23837: Rename action name to make it consistent with other applications: hein, ngraham.
Sep 10 2019, 2:30 PM · Documentation
shubham requested review of D23837: Rename action name to make it consistent with other applications.
Sep 10 2019, 2:29 PM · Documentation
shubham committed R7:7b251779bca2: Add .arcconfig file (authored by shubham).
Add .arcconfig file
Sep 10 2019, 2:28 PM

Sep 1 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Fix unrelated change

Sep 1 2019, 6:46 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Keep comment at the right place

Sep 1 2019, 6:32 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove unneeded change

Sep 1 2019, 6:16 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove trailing whitespaces

Sep 1 2019, 6:12 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Some cleanup and add unittest

Sep 1 2019, 5:44 PM · KDE Partition Manager
shubham committed R16:78f29ae8b532: Reduce temperature's precision from six decimal places to two (authored by shubham).
Reduce temperature's precision from six decimal places to two
Sep 1 2019, 5:42 PM
shubham closed D23572: Reduce temperature's precision from six decimal places to two.
Sep 1 2019, 5:42 PM · KDE Partition Manager

Aug 30 2019

shubham retitled D23572: Reduce temperature's precision from six decimal places to two from Reduce temperature's precision from six decimal places to one to Reduce temperature's precision from six decimal places to two.
Aug 30 2019, 2:17 AM · KDE Partition Manager

Aug 29 2019

shubham updated the test plan for D23572: Reduce temperature's precision from six decimal places to two.
Aug 29 2019, 7:17 PM · KDE Partition Manager
shubham added a project to D23572: Reduce temperature's precision from six decimal places to two: KDE Partition Manager.
Aug 29 2019, 7:16 PM · KDE Partition Manager
shubham requested review of D23572: Reduce temperature's precision from six decimal places to two.
Aug 29 2019, 7:16 PM · KDE Partition Manager

Aug 27 2019

shubham committed R16:745c96acb582: Fix unused parameters (authored by shubham).
Fix unused parameters
Aug 27 2019, 7:29 PM
shubham committed R16:4d6f592780aa: final fix (authored by shubham).
final fix
Aug 27 2019, 7:29 PM
shubham committed R16:ff97a2b13719: Remove kauth_install_helper_files macro and rather install the service files… (authored by shubham).
Remove kauth_install_helper_files macro and rather install the service files…
Aug 27 2019, 7:29 PM
shubham committed R16:8acbf1ccc490: Add unit test for Polkit backend (authored by shubham).
Add unit test for Polkit backend
Aug 27 2019, 7:29 PM
shubham committed R16:1ab31157da2c: Refactor connect inside startHelper() and fix infinite recursion (authored by shubham).
Refactor connect inside startHelper() and fix infinite recursion
Aug 27 2019, 7:29 PM
shubham committed R16:59911b231a3e: Remove code to init the helper, add code to kick start the helper (authored by shubham).
Remove code to init the helper, add code to kick start the helper
Aug 27 2019, 7:29 PM
shubham committed R16:3ad1c241bfd2: Change Polkit event loop a bit (authored by shubham).
Change Polkit event loop a bit
Aug 27 2019, 7:29 PM
shubham committed R16:1168b5f5a2d8: Authorize using Polkit backend (authored by shubham).
Authorize using Polkit backend
Aug 27 2019, 7:29 PM
shubham committed R16:ddb22107a74c: helper (authored by shubham).
helper
Aug 27 2019, 7:29 PM
shubham committed R16:223df31071f4: Add Polkit backend final (authored by shubham).
Add Polkit backend final
Aug 27 2019, 7:29 PM
shubham committed R16:584f37334bf9: Not working (authored by shubham).
Not working
Aug 27 2019, 7:29 PM
shubham committed R16:24338a0b853f: Add Polkit backend (authored by shubham).
Add Polkit backend
Aug 27 2019, 7:29 PM
shubham committed R16:b8bee3bcee54: QDBus communication (authored by shubham).
QDBus communication
Aug 27 2019, 7:29 PM
shubham committed R16:60d6b6dde86c: Helper as standalone application (authored by shubham).
Helper as standalone application
Aug 27 2019, 7:29 PM
shubham committed R16:1ee0aece09e8: Try to make helper into a standalone application (authored by shubham).
Try to make helper into a standalone application
Aug 27 2019, 7:29 PM

Aug 26 2019

shubham committed R16:15d5ea23fea9: final fix (authored by shubham).
final fix
Aug 26 2019, 8:11 AM
shubham committed R16:85752032abae: Fix unused parameters (authored by shubham).
Fix unused parameters
Aug 26 2019, 8:11 AM
shubham committed R16:eda83ae7b31f: Add unit test for Polkit backend (authored by shubham).
Add unit test for Polkit backend
Aug 26 2019, 8:11 AM
shubham closed D22321: Add unit test for Polkit backend.
Aug 26 2019, 8:11 AM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.
Aug 26 2019, 8:00 AM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase

Aug 26 2019, 7:56 AM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Rebase wrt parent

Aug 26 2019, 7:54 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

const at the end of startHelper() function

Aug 26 2019, 7:49 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Use sync version for checking authorization

Aug 26 2019, 7:36 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove left over commented code

Aug 26 2019, 7:28 AM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Fix documentation

Aug 26 2019, 7:26 AM · KDE Partition Manager
shubham reopened D22321: Add unit test for Polkit backend.
Aug 26 2019, 7:23 AM · KDE Partition Manager
shubham reopened D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 26 2019, 7:22 AM · KDE Partition Manager
shubham committed R16:689484f39060: Fix linker error (authored by shubham).
Fix linker error
Aug 26 2019, 7:11 AM
shubham closed D22321: Add unit test for Polkit backend.
Aug 26 2019, 7:11 AM · KDE Partition Manager
shubham committed R16:687beb197f9e: a (authored by shubham).
a
Aug 26 2019, 7:11 AM
shubham committed R16:ec39f508f6f9: a (authored by shubham).
a
Aug 26 2019, 7:11 AM
shubham committed R16:ecf9364a7851: a (authored by shubham).
a
Aug 26 2019, 7:11 AM
shubham committed R16:f2ad2cd0146e: helper (authored by shubham).
helper
Aug 26 2019, 7:11 AM
shubham committed R16:5e6b51b5403b: a (authored by shubham).
a
Aug 26 2019, 7:11 AM
shubham committed R16:3786d5827024: a (authored by shubham).
a
Aug 26 2019, 7:11 AM
shubham committed R16:7efa09411e18: Add Polkit backend final (authored by shubham).
Add Polkit backend final
Aug 26 2019, 7:11 AM
shubham committed R16:fe4936ea0a7e: Not working (authored by shubham).
Not working
Aug 26 2019, 7:11 AM
shubham committed R16:53b8706bc45b: Add Polkit backend (authored by shubham).
Add Polkit backend
Aug 26 2019, 7:11 AM
shubham committed R16:84ee9af2c752: QDBus communication (authored by shubham).
QDBus communication
Aug 26 2019, 7:11 AM
shubham committed R16:3ba15be4c356: Helper as standalone application (authored by shubham).
Helper as standalone application
Aug 26 2019, 7:11 AM
shubham committed R16:1ed945016178: a (authored by shubham).
a
Aug 26 2019, 7:11 AM
shubham closed D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 26 2019, 7:11 AM · KDE Partition Manager

Aug 25 2019

shubham updated the diff for D22321: Add unit test for Polkit backend.

More changes

Aug 25 2019, 8:07 AM · KDE Partition Manager
shubham updated the diff for D22321: Add unit test for Polkit backend.

Fix linker error

Aug 25 2019, 8:06 AM · KDE Partition Manager

Aug 24 2019

shubham added a reviewer for D23193: Add support for Belarusian currency: broulik.
Aug 24 2019, 6:32 PM · Frameworks
shubham updated the diff for D23405: Add properties action to trash in Places panel.

Fix more unrelated change

Aug 24 2019, 4:37 PM · Dolphin
shubham updated the diff for D23405: Add properties action to trash in Places panel.

Remove unrelated change

Aug 24 2019, 4:36 PM · Dolphin
shubham added reviewers for D23405: Add properties action to trash in Places panel: elvisangelaccio, ngraham.
Aug 24 2019, 4:31 PM · Dolphin
shubham requested review of D23405: Add properties action to trash in Places panel.
Aug 24 2019, 4:31 PM · Dolphin
shubham added a comment to D23193: Add support for Belarusian currency.

I can't get the new currency to actually show up in KRunner when I test the patch. Does it work for you?

Aug 24 2019, 3:36 PM · Frameworks
shubham updated the diff for D23193: Add support for Belarusian currency.

Move currency to its proper place alphabetically

Aug 24 2019, 3:34 PM · Frameworks
shubham abandoned D22481: Do not show play/pause button when no media is playing.
Aug 24 2019, 3:07 PM · Plasma
shubham updated the test plan for D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event.
Aug 24 2019, 3:05 PM
shubham abandoned D21617: Handle action authorization inside helper.
Aug 24 2019, 3:00 PM · KDE Partition Manager
shubham added a comment to D23255: Change warning dialog box to a question dialog box.

Shouldn't the message change then to be more informational?

Aug 24 2019, 2:58 PM · Dolphin
shubham added a comment to D23389: Use visible buttons to switch the default device.

+1
Personally I had faced this issue when I had bought a new monitor and tried to listen to music through its speakers. I couldn't figure out how to switch play back devices for couple of days or so.

Aug 24 2019, 3:33 AM · Plasma

Aug 23 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove unused parameters

Aug 23 2019, 6:03 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Success starting the kauth_externalcommand helper

Aug 23 2019, 2:13 PM · KDE Partition Manager

Aug 22 2019

shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Remove commented code

Aug 22 2019, 7:10 PM · KDE Partition Manager
shubham updated the diff for D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Refactor

Aug 22 2019, 7:01 PM · KDE Partition Manager