shubham (Shubham )
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2018, 3:31 PM (89 w, 1 d)
Availability
Available

Recent Activity

Sat, Feb 8

shubham added a comment to D21261: Prevent resizing read-only mounted file systems.

@stikonas I am a bit confused, can you please help a bit?

Sat, Feb 8, 5:32 PM · KDE Partition Manager
shubham added a comment to D26727: Fix font bug in ProgressBox.

@sandsmark Ping?

Sat, Feb 8, 5:31 PM
shubham added a comment to D26728: Add unittests.

@sandsmark Ping?

Sat, Feb 8, 5:30 PM

Sun, Jan 26

shubham added a comment to D26650: Use KService to look for Filelight.

@broulik @ngraham Any updates on this, how to proceed?

Sun, Jan 26, 6:54 AM · Frameworks

Sat, Jan 25

shubham updated the summary of D26917: Handle a crash in full screen requests when the window shows no host list .
Sat, Jan 25, 4:00 PM
shubham added a comment to D26293: Add CopyPaste unit test for spreadsheet.

@asemke I got a bit confuse, can you please assist a bit?

Sat, Jan 25, 1:10 PM · LabPlot, KDE Edu
shubham added a comment to D26728: Add unittests.

@sandsmark ping?

Sat, Jan 25, 8:51 AM

Jan 20 2020

shubham committed R37:ef0a00904393: Add icon to Close button of "About Krita" dialog box (authored by shubham).
Add icon to Close button of "About Krita" dialog box
Jan 20 2020, 4:26 PM
shubham closed D26724: Add icon to Close button of "About Krita" dialog box.
Jan 20 2020, 4:26 PM · Krita
shubham added a comment to D26727: Fix font bug in ProgressBox.

@sandsmark ping?

Jan 20 2020, 2:44 PM

Jan 19 2020

shubham committed R136:db9afa2dbe53: Name the items as per HIG (authored by shubham).
Name the items as per HIG
Jan 19 2020, 3:05 PM
shubham closed D26669: Name the items as per HIG.
Jan 19 2020, 3:05 PM
shubham added a comment to D26728: Add unittests.

lgtm

Jan 19 2020, 1:46 PM
shubham updated the diff for D26293: Add CopyPaste unit test for spreadsheet.

Few changes, test still fails. I tried debugging it and check the stack trace, it seems to end in pasteIntoSelection()

Jan 19 2020, 12:55 PM · LabPlot, KDE Edu
shubham added a comment to D26293: Add CopyPaste unit test for spreadsheet.

@asemke But the test still fails with:

Jan 19 2020, 7:44 AM · LabPlot, KDE Edu
shubham updated the diff for D26293: Add CopyPaste unit test for spreadsheet.

Add qRegisterMetaType() calls

Jan 19 2020, 7:43 AM · LabPlot, KDE Edu
shubham added a comment to D26651: Add unit test for spreadsheet's trivial features.

@asemke Ping?

Jan 19 2020, 7:39 AM · KDE Edu, LabPlot
shubham added a reviewer for D26724: Add icon to Close button of "About Krita" dialog box: ngraham.

@rempt Ping?

Jan 19 2020, 7:31 AM · Krita

Jan 17 2020

shubham added a comment to D26728: Add unittests.

@sandsmark I am getting linker error any help?

Jan 17 2020, 3:12 PM
shubham updated the diff for D26728: Add unittests.

Correct diff

Jan 17 2020, 3:11 PM
shubham requested review of D26728: Add unittests.
Jan 17 2020, 3:11 PM
shubham added a comment to D26727: Fix font bug in ProgressBox.

Please always add screenshots for patches that result in UI changes.

Jan 17 2020, 1:40 PM
shubham updated the test plan for D26727: Fix font bug in ProgressBox.
Jan 17 2020, 1:38 PM
shubham updated the diff for D26727: Fix font bug in ProgressBox.

Fix unrelated changes

Jan 17 2020, 1:38 PM
shubham updated the summary of D26727: Fix font bug in ProgressBox.
Jan 17 2020, 1:30 PM
shubham added reviewers for D26727: Fix font bug in ProgressBox: sandsmark, ngraham.
Jan 17 2020, 1:27 PM
shubham requested review of D26727: Fix font bug in ProgressBox.
Jan 17 2020, 1:26 PM
shubham added a comment to D26293: Add CopyPaste unit test for spreadsheet.

@asemke Actually, I waited for the test to finish and it failed with the following output.

Jan 17 2020, 12:09 PM · LabPlot, KDE Edu
shubham added a comment to D21261: Prevent resizing read-only mounted file systems.

@stikonas Ping?

Jan 17 2020, 10:54 AM · KDE Partition Manager
shubham requested review of D26724: Add icon to Close button of "About Krita" dialog box.
Jan 17 2020, 10:44 AM · Krita

Jan 15 2020

shubham updated the diff for D26650: Use KService to look for Filelight.

Make requested changes

Jan 15 2020, 7:56 AM · Frameworks

Jan 14 2020

shubham updated the diff for D26650: Use KService to look for Filelight.

Use desciptive variable name

Jan 14 2020, 6:51 PM · Frameworks
shubham added a comment to D26669: Name the items as per HIG.

Yup!

Jan 14 2020, 6:34 PM
shubham updated the test plan for D26669: Name the items as per HIG.
Jan 14 2020, 6:32 PM
shubham updated the summary of D26669: Name the items as per HIG.
Jan 14 2020, 5:59 PM
shubham requested review of D26669: Name the items as per HIG.
Jan 14 2020, 5:57 PM
shubham added a project to R304:36c798cd0bc8: Add ellipsis at the end, as per HIG: Frameworks.
Jan 14 2020, 5:30 PM · Frameworks
shubham committed R304:36c798cd0bc8: Add ellipsis at the end, as per HIG (authored by shubham).
Add ellipsis at the end, as per HIG
Jan 14 2020, 5:28 PM · Frameworks
shubham updated the diff for D26293: Add CopyPaste unit test for spreadsheet.

Bump copyright year

Jan 14 2020, 5:23 PM · LabPlot, KDE Edu
shubham updated the diff for D26293: Add CopyPaste unit test for spreadsheet.

Compiles, but make test hangs on testing CopyPasteTest

Jan 14 2020, 3:25 PM · LabPlot, KDE Edu
shubham updated the diff for D26650: Use KService to look for Filelight.

Use KService to get the application's icon

Jan 14 2020, 3:17 PM · Frameworks
shubham added inline comments to D26650: Use KService to look for Filelight.
Jan 14 2020, 9:26 AM · Frameworks
shubham requested review of D26651: Add unit test for spreadsheet's trivial features.
Jan 14 2020, 7:06 AM · KDE Edu, LabPlot
shubham added inline comments to D26293: Add CopyPaste unit test for spreadsheet.
Jan 14 2020, 6:48 AM · LabPlot, KDE Edu
shubham updated the diff for D26293: Add CopyPaste unit test for spreadsheet.
Jan 14 2020, 6:47 AM · LabPlot, KDE Edu
shubham closed D26341: Add arcconfig file.

Shipped here.
R262:47bbe5dafa74f360a59d4c168aceb4f2f8a0a9ea

Jan 14 2020, 6:31 AM · LabPlot, KDE Edu
shubham committed R262:47bbe5dafa74: Add .arcconfig file (authored by shubham).
Add .arcconfig file
Jan 14 2020, 6:28 AM
shubham abandoned D24932: Add button to open the folder in filelight to view more details.

Abandoned in favour of D26650

Jan 14 2020, 5:19 AM · Frameworks
shubham requested review of D26650: Use KService to look for Filelight.
Jan 14 2020, 5:19 AM · Frameworks

Jan 13 2020

shubham added a comment to D24932: Add button to open the folder in filelight to view more details.

@broulik I believe this is what you wanted?

Jan 13 2020, 8:54 AM · Frameworks
shubham updated the diff for D24932: Add button to open the folder in filelight to view more details.
Jan 13 2020, 8:53 AM · Frameworks

Jan 1 2020

shubham requested review of D26341: Add arcconfig file.
Jan 1 2020, 2:43 PM · LabPlot, KDE Edu
shubham updated the diff for D26293: Add CopyPaste unit test for spreadsheet.
Jan 1 2020, 2:36 PM · LabPlot, KDE Edu

Dec 30 2019

shubham added a comment to D26293: Add CopyPaste unit test for spreadsheet.

@asemke Any help why it is failing to compile? I have already added the directory to cmake.

Dec 30 2019, 4:14 PM · LabPlot, KDE Edu
shubham requested review of D26293: Add CopyPaste unit test for spreadsheet.
Dec 30 2019, 4:13 PM · LabPlot, KDE Edu
shubham committed R241:3377057dc1d8: Fix crash on non-unix based systems (authored by shubham).
Fix crash on non-unix based systems
Dec 30 2019, 3:06 PM
shubham closed D26265: Fix crash on non-unix based systems.
Dec 30 2019, 3:04 PM · Frameworks

Dec 29 2019

shubham added a comment to D24932: Add button to open the folder in filelight to view more details.

@pino @ngraham Fixed here https://phabricator.kde.org/D26265.

Dec 29 2019, 5:52 AM · Frameworks
shubham requested review of D26265: Fix crash on non-unix based systems.
Dec 29 2019, 5:50 AM · Frameworks

Dec 28 2019

shubham added a comment to D26250: Fix multiple warnings.

Congrats on the first PR!

Dec 28 2019, 2:30 PM · KDE Edu
shubham updated the diff for D26250: Fix multiple warnings.

Use #if #else

Dec 28 2019, 10:54 AM · KDE Edu
shubham updated the diff for D26250: Fix multiple warnings.

Do not depend upon relatively newer Qt functions

Dec 28 2019, 8:16 AM · KDE Edu
shubham added inline comments to D26250: Fix multiple warnings.
Dec 28 2019, 8:03 AM · KDE Edu
shubham added a comment to D26250: Fix multiple warnings.

Should I leave horizontalAdvance() and sizeInBytes() as it is?

Dec 28 2019, 8:01 AM · KDE Edu
shubham updated the diff for D26250: Fix multiple warnings.

Minor changes

Dec 28 2019, 7:32 AM · KDE Edu
shubham requested review of D26250: Fix multiple warnings.
Dec 28 2019, 7:29 AM · KDE Edu
shubham committed R241:e348cd80d35f: Add button to open the folder in filelight to view more details (authored by shubham).
Add button to open the folder in filelight to view more details
Dec 28 2019, 5:32 AM
shubham closed D24932: Add button to open the folder in filelight to view more details.
Dec 28 2019, 5:32 AM · Frameworks

Dec 27 2019

shubham updated the diff for D24932: Add button to open the folder in filelight to view more details.

Remove the use of variable

Dec 27 2019, 6:42 PM · Frameworks
shubham retitled D24932: Add button to open the folder in filelight to view more details from Add Button to open the folder in filelight to view more details to Add button to open the folder in filelight to view more details.
Dec 27 2019, 6:28 PM · Frameworks
shubham retitled D24932: Add button to open the folder in filelight to view more details from Add Button to open the folder in filelight for more details to Add Button to open the folder in filelight to view more details.
Dec 27 2019, 6:28 PM · Frameworks
shubham updated the diff for D24932: Add button to open the folder in filelight to view more details.

Fix whitespaces and crash condition

Dec 27 2019, 6:22 PM · Frameworks
shubham retitled D24932: Add button to open the folder in filelight to view more details from [WIP]: Add Button to open the folder in filelight for more details to Add Button to open the folder in filelight for more details.
Dec 27 2019, 4:09 PM · Frameworks
shubham updated the summary of D24932: Add button to open the folder in filelight to view more details.
Dec 27 2019, 4:07 PM · Frameworks
shubham updated the test plan for D24932: Add button to open the folder in filelight to view more details.
Dec 27 2019, 4:05 PM · Frameworks
shubham updated the diff for D24932: Add button to open the folder in filelight to view more details.

Fix above mentioned issues, now works perfectly fine
@ngraham Ping?

Dec 27 2019, 4:02 PM · Frameworks
shubham committed R241:bfa2496fb950: Fix deprecated function usage warnings (authored by shubham).
Fix deprecated function usage warnings
Dec 27 2019, 3:16 PM

Dec 24 2019

shubham added a comment to T12385: rename baby tangram to baby Puzzle.

I would like to take this. I did not get why it is not a tangram? What is it?

Dec 24 2019, 11:31 AM · GCompris: Improvements
shubham committed R138:34b263c4c1f2: Fix typo (authored by shubham).
Fix typo
Dec 24 2019, 10:20 AM
shubham committed R877:8f404cfb8133: Fix typo (authored by shubham).
Fix typo
Dec 24 2019, 9:58 AM
shubham closed D26206: Fix typo.
Dec 24 2019, 9:58 AM
shubham closed D26105: Fix typo.
Dec 24 2019, 9:56 AM · Craft
shubham requested review of D26206: Fix typo.
Dec 24 2019, 9:25 AM

Dec 19 2019

shubham added a project to D26105: Fix typo: Craft.
Dec 19 2019, 4:01 PM · Craft
shubham updated the summary of D26105: Fix typo.
Dec 19 2019, 4:01 PM · Craft
shubham requested review of D26105: Fix typo.
Dec 19 2019, 4:00 PM · Craft

Dec 12 2019

shubham committed R7:c95244d25fe2: Rename action name to make it consistent with other applications (authored by shubham).
Rename action name to make it consistent with other applications
Dec 12 2019, 2:09 PM
shubham added a comment to D22679: Change cursor shape to pointing hand during mouse hover event and copy contents of display to clipboard on mouse press event.

@ngraham Ping?

Dec 12 2019, 1:30 PM
shubham closed D23837: Rename action name to make it consistent with other applications.
Dec 12 2019, 1:17 PM · Documentation

Nov 26 2019

shubham added a comment to D23837: Rename action name to make it consistent with other applications.

@hein @ngraham Ping?

Nov 26 2019, 1:55 PM · Documentation

Oct 27 2019

shubham added a comment to D24932: Add button to open the folder in filelight to view more details.

@ngraham How should I create a KService for runApplication?

Oct 27 2019, 1:24 PM · Frameworks

Oct 26 2019

shubham added inline comments to D24932: Add button to open the folder in filelight to view more details.
Oct 26 2019, 3:41 AM · Frameworks

Oct 25 2019

shubham updated the diff for D24932: Add button to open the folder in filelight to view more details.
Oct 25 2019, 4:12 PM · Frameworks

Oct 24 2019

shubham updated the summary of D24932: Add button to open the folder in filelight to view more details.
Oct 24 2019, 6:04 PM · Frameworks
shubham requested review of D24932: Add button to open the folder in filelight to view more details.
Oct 24 2019, 6:01 PM · Frameworks

Oct 19 2019

shubham committed R7:748c43324622: Remove period from the label (authored by shubham).
Remove period from the label
Oct 19 2019, 2:52 PM

Oct 8 2019

shubham committed R120:08823e7b08f5: Merge (authored by shubham).
Merge
Oct 8 2019, 6:29 PM
shubham committed R120:a719f0a7f4dc: Fix typo (authored by shubham).
Fix typo
Oct 8 2019, 6:29 PM
shubham added a comment to D24492: [FilteredDirIterator] Reduce stack pressure.

It is not a good practice to "goto" in C++

Oct 8 2019, 12:36 PM · Baloo, Frameworks

Oct 3 2019

shubham added a comment to D23837: Rename action name to make it consistent with other applications.

@hein Ping?

Oct 3 2019, 9:28 AM · Documentation