shubham (Shubham )
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2018, 3:31 PM (27 w, 3 d)
Availability
Available

Recent Activity

Yesterday

shubham committed R120:743e5583ced0: Make Status and Notification popup consistent with others. (authored by shubham).
Make Status and Notification popup consistent with others.
Fri, Dec 14, 1:51 PM
shubham closed D17556: Make Status and Notification popup consistent with others..
Fri, Dec 14, 1:51 PM · Plasma
shubham committed R120:998d1a02c670: Remove period ( . ) character from the end (authored by shubham).
Remove period ( . ) character from the end
Fri, Dec 14, 1:49 PM
shubham closed D17574: Remove period ( . ) character from the end.
Fri, Dec 14, 1:49 PM · VDG, Plasma
shubham added a comment to D17556: Make Status and Notification popup consistent with others..

could I go ahead pushing it?

Fri, Dec 14, 1:46 PM · Plasma
shubham updated the diff for D17556: Make Status and Notification popup consistent with others..

Use units.smallSpacing

Fri, Dec 14, 1:41 PM · Plasma
shubham added a comment to D17574: Remove period ( . ) character from the end.
Fri, Dec 14, 9:39 AM · VDG, Plasma
shubham updated the summary of D17574: Remove period ( . ) character from the end.
Fri, Dec 14, 9:38 AM · VDG, Plasma
shubham updated the diff for D17556: Make Status and Notification popup consistent with others..

use 5px margin

Fri, Dec 14, 9:37 AM · Plasma
shubham added a reviewer for D17574: Remove period ( . ) character from the end: mart.
Fri, Dec 14, 9:32 AM · VDG, Plasma
shubham requested review of D17574: Remove period ( . ) character from the end.
Fri, Dec 14, 9:28 AM · VDG, Plasma
shubham updated the diff for D17545: Do not stat move/copy job if the destination file system does not support writing.

Unit test

Fri, Dec 14, 8:40 AM · Frameworks

Thu, Dec 13

shubham added a comment to D17545: Do not stat move/copy job if the destination file system does not support writing.

@dfaure I'm not so familiar writing unit tests. This is one I have made by doing some modifications. would you like to give me some help?

Thu, Dec 13, 2:52 PM · Frameworks
shubham added a comment to D17545: Do not stat move/copy job if the destination file system does not support writing.
Thu, Dec 13, 2:51 PM · Frameworks
shubham added a comment to D17545: Do not stat move/copy job if the destination file system does not support writing.

@dfaure do you need tests for all three modes ie. copy,move and link
And individually for files and folders

Thu, Dec 13, 1:35 PM · Frameworks
shubham added inline comments to D17545: Do not stat move/copy job if the destination file system does not support writing.
Thu, Dec 13, 10:50 AM · Frameworks
shubham committed R241:b1b46c4b0a35: Use <QTest> (authored by shubham).
Use <QTest>
Thu, Dec 13, 10:39 AM
shubham added reviewers for D17556: Make Status and Notification popup consistent with others.: mart, hein.
Thu, Dec 13, 10:27 AM · Plasma
shubham updated the diff for D17545: Do not stat move/copy job if the destination file system does not support writing.

Done above requested changes.

Thu, Dec 13, 10:24 AM · Frameworks
shubham added a comment to D17556: Make Status and Notification popup consistent with others..

@broulik In all others, if you notice it is 0

Thu, Dec 13, 9:15 AM · Plasma
shubham added a reviewer for D17556: Make Status and Notification popup consistent with others.: broulik.
Thu, Dec 13, 9:05 AM · Plasma
shubham requested review of D17556: Make Status and Notification popup consistent with others..
Thu, Dec 13, 9:03 AM · Plasma
shubham updated subscribers of D17545: Do not stat move/copy job if the destination file system does not support writing.
Thu, Dec 13, 4:51 AM · Frameworks

Wed, Dec 12

shubham added a reviewer for D17545: Do not stat move/copy job if the destination file system does not support writing: dfaure.
Wed, Dec 12, 4:41 PM · Frameworks
shubham committed R241:6c1e3c32a89b: Correct KF version (authored by shubham).
Correct KF version
Wed, Dec 12, 4:17 PM
shubham updated the diff for D17545: Do not stat move/copy job if the destination file system does not support writing.
Wed, Dec 12, 4:06 PM · Frameworks
shubham requested review of D17545: Do not stat move/copy job if the destination file system does not support writing.
Wed, Dec 12, 3:23 PM · Frameworks
shubham committed R120:977d2aadd522: Show tooltip for pinning system tray and calendar (authored by shubham).
Show tooltip for pinning system tray and calendar
Wed, Dec 12, 11:40 AM
shubham closed D17532: Show tooltip for pinning system tray and calendar.
Wed, Dec 12, 11:40 AM · Plasma
shubham updated the diff for D17532: Show tooltip for pinning system tray and calendar.

"Keep Open"

Wed, Dec 12, 11:22 AM · Plasma
shubham requested review of D17532: Show tooltip for pinning system tray and calendar.
Wed, Dec 12, 11:04 AM · Plasma

Tue, Dec 11

shubham committed R242:e3aa2cf8406e: Fix comparision between signed and unsigned integer warning (authored by shubham).
Fix comparision between signed and unsigned integer warning
Tue, Dec 11, 6:38 PM
shubham committed R242:c017d3a6934e: Merge branch 'master' of git://anongit.kde.org/plasma-framework (authored by shubham).
Merge branch 'master' of git://anongit.kde.org/plasma-framework
Tue, Dec 11, 6:24 PM
shubham committed R242:1bba82535c24: Fix unused parameter warning (authored by shubham).
Fix unused parameter warning
Tue, Dec 11, 6:24 PM
shubham committed R241:8bcc31d987f4: Fix unused parameter warning (authored by shubham).
Fix unused parameter warning
Tue, Dec 11, 5:47 PM
shubham added a comment to R867:13c808cd5250: Uste master branch.
Tue, Dec 11, 10:47 AM
shubham added a comment to R867:13c808cd5250: Uste master branch.

what is uste?

Tue, Dec 11, 10:46 AM
shubham accepted D17499: Correct spelling mistakes.
Tue, Dec 11, 9:48 AM · KDE PIM

Mon, Dec 10

shubham committed R318:ca25af6d38c8: Add an icon for "restore" action (authored by shubham).
Add an icon for "restore" action
Mon, Dec 10, 6:27 PM
shubham closed D17490: Add an icon for "restore" action.
Mon, Dec 10, 6:27 PM · Dolphin
shubham updated the diff for D17490: Add an icon for "restore" action.
Mon, Dec 10, 6:23 PM · Dolphin
shubham reopened D17490: Add an icon for "restore" action.
Mon, Dec 10, 6:13 PM · Dolphin
shubham committed R318:b3d054380c13: Revert back (authored by shubham).
Revert back
Mon, Dec 10, 6:12 PM
shubham committed R318:55db38d5ecc1: Add an icon for "restore" action (authored by shubham).
Add an icon for "restore" action
Mon, Dec 10, 5:59 PM
shubham closed D17490: Add an icon for "restore" action.
Mon, Dec 10, 5:59 PM · Dolphin
shubham updated the test plan for D17490: Add an icon for "restore" action.
Mon, Dec 10, 5:14 PM · Dolphin
shubham requested review of D17490: Add an icon for "restore" action.
Mon, Dec 10, 5:07 PM · Dolphin
shubham committed R241:ba5fd4060688: Merge branch 'master' of git://anongit.kde.org/kio (authored by shubham).
Merge branch 'master' of git://anongit.kde.org/kio
Mon, Dec 10, 7:08 AM
shubham committed R241:b7054c2f5fe3: Use the constructor for setting the text (authored by shubham).
Use the constructor for setting the text
Mon, Dec 10, 7:08 AM

Sun, Dec 9

shubham committed R108:16e904592ae4: Remove comparison between signed and unsigned integer expressions warning (authored by shubham).
Remove comparison between signed and unsigned integer expressions warning
Sun, Dec 9, 7:48 PM

Fri, Dec 7

shubham committed R241:00a539a80d21: Merge branch 'master' of git://anongit.kde.org/kio (authored by shubham).
Merge branch 'master' of git://anongit.kde.org/kio
Fri, Dec 7, 6:25 PM
shubham committed R241:c08ee4577168: Remove uninitialized parameter warning and use of a superfluous variable (authored by shubham).
Remove uninitialized parameter warning and use of a superfluous variable
Fri, Dec 7, 6:25 PM
shubham added a reviewer for D17406: add attributes `shared` and `__gshared`: cullmann.
Fri, Dec 7, 5:56 PM · Frameworks, Kate
shubham committed R318:48a4b7abea46: Remove unused parameter warning (authored by shubham).
Remove unused parameter warning
Fri, Dec 7, 4:59 PM
shubham removed a member for Dolphin: shubham.
Fri, Dec 7, 11:19 AM
shubham removed a watcher for Dolphin: shubham.
Fri, Dec 7, 11:19 AM
shubham committed R241:13092bd64615: Change title of the message box to something which conveys message (authored by shubham).
Change title of the message box to something which conveys message
Fri, Dec 7, 4:07 AM
shubham closed D17378: Change title of the message box to something which conveys message.
Fri, Dec 7, 4:07 AM · Frameworks

Thu, Dec 6

shubham added a watcher for Dolphin: shubham.
Thu, Dec 6, 8:57 AM
shubham added a member for Dolphin: shubham.
Thu, Dec 6, 8:57 AM
shubham requested review of D17378: Change title of the message box to something which conveys message.
Thu, Dec 6, 8:49 AM · Frameworks

Wed, Dec 5

shubham updated the summary of D17368: Fixed bug that crashed program when clicking Forecast->Chart.
Wed, Dec 5, 1:44 PM
shubham committed R241:f1f3bfbb2ebd: Remove QString() which is the default parameter (authored by shubham).
Remove QString() which is the default parameter
Wed, Dec 5, 1:00 PM
shubham added a comment to D17360: Added "Transparent with light text" theme for Desktop Notes.

Congrats on your first patch.

Wed, Dec 5, 10:15 AM · Plasma

Mon, Dec 3

shubham committed R108:2a1a0e42808a: Use override (authored by shubham).
Use override
Mon, Dec 3, 12:57 PM
shubham committed R133:4722a386ec27: Merge branch 'master' of git://anongit.kde.org/kscreenlocker (authored by shubham).
Merge branch 'master' of git://anongit.kde.org/kscreenlocker
Mon, Dec 3, 12:50 PM
shubham committed R133:7b2935f7ee51: Use override instead of Q_DECL_OVERRIDE (authored by shubham).
Use override instead of Q_DECL_OVERRIDE
Mon, Dec 3, 12:50 PM
shubham committed R241:518a7496c5c5: Warn user before copy/move job if the file size exceeds the maximum possible… (authored by shubham).
Warn user before copy/move job if the file size exceeds the maximum possible…
Mon, Dec 3, 12:03 PM
shubham closed D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).
Mon, Dec 3, 12:03 PM · Frameworks

Thu, Nov 29

shubham added reviewers for D17241: WIP:Disable highlighting for lines longer than 1024 characters.: cullmann, vkrause.
Thu, Nov 29, 7:57 PM · Frameworks, Kate
shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).

Change to KF 5.54
Will land it after saturday. This patch actually missed 2 tagging (5.52 and 5.53)

Thu, Nov 29, 4:46 PM · Frameworks

Wed, Nov 28

shubham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).

Waiting for green flags.

Wed, Nov 28, 10:55 AM · Frameworks

Mon, Nov 26

shubham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).

"transferred" done
request @ngraham @dfaure @bruns to give thumbs up again.

Mon, Nov 26, 5:45 AM · Frameworks
shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).
Mon, Nov 26, 5:44 AM · Frameworks

Sun, Nov 25

shubham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).

@bruns is it good to go?

Sun, Nov 25, 3:19 PM · Frameworks
shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).

@since 5.53

Sun, Nov 25, 6:09 AM · Frameworks

Sat, Nov 24

shubham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).

@ngraham @bruns do you have any objections?

Sat, Nov 24, 12:34 PM · Frameworks

Wed, Nov 21

shubham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).

@bruns @ngraham what's your view on this? Did you tested it out?

Wed, Nov 21, 5:08 PM · Frameworks
shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).
  • a
Wed, Nov 21, 1:48 PM · Frameworks

Nov 14 2018

shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).

Now patch applies cleanly

Nov 14 2018, 6:05 PM · Frameworks

Nov 8 2018

shubham removed a reviewer for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB): elvisangelaccio.
Nov 8 2018, 12:24 PM · Frameworks
shubham committed R318:b08cea86c972: Warn user before renaming the file/folder to start with a ' . ' (authored by shubham).
Warn user before renaming the file/folder to start with a ' . '
Nov 8 2018, 8:49 AM
shubham closed D15980: Warn user before renaming the file/folder to start with a ' . '.
Nov 8 2018, 8:49 AM · Dolphin
shubham reopened D15980: Warn user before renaming the file/folder to start with a ' . '.
Nov 8 2018, 8:45 AM · Dolphin

Nov 7 2018

shubham committed R318:eff5ae22578d: a (authored by shubham).
a
Nov 7 2018, 9:53 AM
shubham committed R318:e68f24637ca8: Warn user before renaming the file/folder to start with a ' . ' (authored by shubham).
Warn user before renaming the file/folder to start with a ' . '
Nov 7 2018, 9:53 AM
shubham closed D15980: Warn user before renaming the file/folder to start with a ' . '.
Nov 7 2018, 9:53 AM · Dolphin

Nov 2 2018

shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).
Nov 2 2018, 5:24 PM · Frameworks
shubham retitled D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB) from Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) to Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB) .
Nov 2 2018, 4:50 PM · Frameworks
shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).
Nov 2 2018, 4:50 PM · Frameworks
shubham added a comment to D15980: Warn user before renaming the file/folder to start with a ' . '.

@elvisangelaccio Yes, I have commit access, but what about @pino 's review?

Nov 2 2018, 1:01 PM · Dolphin
shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).
Nov 2 2018, 3:54 AM · Frameworks
shubham updated the diff for D15980: Warn user before renaming the file/folder to start with a ' . '.
Nov 2 2018, 3:49 AM · Dolphin

Nov 1 2018

shubham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).

Can I get a review?

Nov 1 2018, 5:37 AM · Frameworks

Oct 22 2018

shubham added a comment to D16364: Resolve symlinks before saving so we don't "break" them.

Please remove 'S' from BUGS in the summary.

Oct 22 2018, 10:29 AM · Okular

Oct 21 2018

shubham added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

Please add before and after screenshot.

Oct 21 2018, 2:59 PM · Dolphin
shubham added inline comments to D16119: Paste plain text as selected text style on SVG text tool.
Oct 21 2018, 1:47 PM · Krita
shubham added a comment to D16119: Paste plain text as selected text style on SVG text tool.

Reopen this one, copy the header from other file, change the name, email to yours and year to 2018

Oct 21 2018, 1:46 PM · Krita
shubham added a comment to D15732: Ignore default null eol in Session::sendTextToTerminal.

@hindenberg I think you forgot to credit Pavel

Oct 21 2018, 5:45 AM · Konsole

Oct 20 2018

shubham added inline comments to D16119: Paste plain text as selected text style on SVG text tool.
Oct 20 2018, 5:10 PM · Krita