Differential D13592

Fix bug where activating current view won't focus it
ClosedPublic
Actions

Authored by amhndu on Jun 18 2018, 5:22 PM.

Details

Reviewers
brauch
Group Reviewers
KDevelop
Commits
R32:207d850ed3b9: fix bug where activating current view won't focus it
Summary

When activateView is called with the currently active view,
it just returns early, ignoring the focus parameter whether or not
it has focus

BUG: 394105

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
amhndu created this revision.Jun 18 2018, 5:22 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJun 18 2018, 5:22 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
amhndu requested review of this revision.Jun 18 2018, 5:22 PM
brauch accepted this revision.Jun 18 2018, 5:50 PM
brauch added a subscriber: brauch.

Looks good to me, thanks! Can you submit it yourself?

This revision is now accepted and ready to land.Jun 18 2018, 5:50 PM
amhndu added a comment.Jun 19 2018, 3:24 AM

I don't think I can, this is my first patch.

brauch added a comment.Jun 19 2018, 6:34 AM

Ah, cool. In that case I would need your email address to set you as the author of the change.

amhndu added a comment.Jun 19 2018, 6:49 AM

Email: amhndu@gmail.com

Closed by commit R32:207d850ed3b9: fix bug where activating current view won't focus it (authored by amhndu, committed by brauch). · Explain WhyJun 20 2018, 6:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36398

View Options

kdevplatform/sublime/mainwindow.cpp

Loading...