amhndu (Amish Naidu)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 18 2018, 4:07 PM (25 w, 4 d)
Availability
Available

Recent Activity

Yesterday

amhndu committed R32:36ea7ca30c7c: Remove reliance on Qt 5.11+ QIODevice::NewOnly in the Scratchpad plugin (authored by amhndu).
Remove reliance on Qt 5.11+ QIODevice::NewOnly in the Scratchpad plugin
Fri, Dec 14, 10:35 AM
amhndu closed D17575: Remove reliance on Qt 5.11+ QIODevice::NewOnly in the Scratchpad plugin.
Fri, Dec 14, 10:35 AM · KDevelop
amhndu requested review of D17575: Remove reliance on Qt 5.11+ QIODevice::NewOnly in the Scratchpad plugin.
Fri, Dec 14, 10:25 AM · KDevelop

Thu, Dec 13

amhndu added a reviewer for D17569: Allow configuring shortcut for Run Scratch action and add to Run menu: kfunk.
Thu, Dec 13, 5:20 PM · KDevelop
amhndu requested review of D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.
Thu, Dec 13, 5:17 PM · KDevelop

Wed, Dec 12

amhndu requested review of D17525: Show "Move into Source" action in code menu.
Wed, Dec 12, 8:29 AM · KDevelop

Tue, Dec 11

amhndu committed R32:37f68b8d4299: Add scratchpad plugin (authored by amhndu).
Add scratchpad plugin
Tue, Dec 11, 3:06 PM
amhndu closed D16484: Add scratchpad plugin.
Tue, Dec 11, 3:06 PM · KDevelop

Mon, Dec 10

amhndu added inline comments to D16484: Add scratchpad plugin.
Mon, Dec 10, 9:27 AM · KDevelop

Fri, Dec 7

amhndu added inline comments to D16484: Add scratchpad plugin.
Fri, Dec 7, 6:22 AM · KDevelop

Thu, Dec 6

amhndu updated the test plan for D17370: Add assistant to generate header guards.
Thu, Dec 6, 6:25 PM · KDevelop
amhndu updated the diff for D17370: Add assistant to generate header guards.
  • Add tests for HeaderGuardAssistant
Thu, Dec 6, 6:24 PM · KDevelop
amhndu updated the diff for D17370: Add assistant to generate header guards.
  • QStringLiteral -> i18n
Thu, Dec 6, 11:17 AM · KDevelop

Wed, Dec 5

amhndu requested review of D17370: Add assistant to generate header guards.
Wed, Dec 5, 6:28 PM · KDevelop

Mon, Dec 3

amhndu added inline comments to D16484: Add scratchpad plugin.
Mon, Dec 3, 4:44 PM · KDevelop
amhndu updated the diff for D16484: Add scratchpad plugin.
  • Save scratch when run
  • Fix scratch removal bug
  • Invalidate actions when list is emptied
Mon, Dec 3, 4:44 PM · KDevelop
amhndu committed R32:0636cfdd8a93: Don't add 'override' specifier for non-modern project settings (authored by amhndu).
Don't add 'override' specifier for non-modern project settings
Mon, Dec 3, 10:51 AM
amhndu closed D16773: Don't add 'override' specifier for non-modern project settings.
Mon, Dec 3, 10:51 AM · KDevelop
amhndu added a comment to D16773: Don't add 'override' specifier for non-modern project settings.

Will push with your version, looks better.
Thanks for the review :)

Mon, Dec 3, 9:54 AM · KDevelop

Mon, Nov 26

amhndu added a comment to D16484: Add scratchpad plugin.

How should I proceed with this ?
As suggested on IRC, should I try to release it independently because of the size ?

Mon, Nov 26, 7:57 AM · KDevelop

Fri, Nov 23

amhndu added a comment to D16773: Don't add 'override' specifier for non-modern project settings.

ping ?

Fri, Nov 23, 4:59 AM · KDevelop

Nov 9 2018

amhndu added a reviewer for D16484: Add scratchpad plugin: KDevelop.
Nov 9 2018, 11:05 AM · KDevelop
amhndu updated the diff for D16773: Don't add 'override' specifier for non-modern project settings.
  • Change test case and convert octal literal to decimal
Nov 9 2018, 10:26 AM · KDevelop
amhndu requested review of D16773: Don't add 'override' specifier for non-modern project settings.
Nov 9 2018, 7:28 AM · KDevelop

Nov 3 2018

amhndu updated the diff for D16484: Add scratchpad plugin.
  • Add a message when the scratch list is empty
Nov 3 2018, 1:46 PM · KDevelop

Nov 1 2018

amhndu added a comment to D16484: Add scratchpad plugin.

Would something like this be worth adding ?

cpp
index 5c193432c9..1b5fb57352 100644
--- a/plugins/scratchpad/scratchpadview.cpp
+++ b/plugins/scratchpad/scratchpadview.cpp
@@ -37,6 +37,7 @@
 #include <QWidgetAction>
 #include <QLineEdit>
 #include <QInputDialog>
+#include <QPainter>
Nov 1 2018, 9:44 AM · KDevelop
amhndu added a comment to D16484: Add scratchpad plugin.

Marking inline comments done.

Nov 1 2018, 7:49 AM · KDevelop
amhndu updated the diff for D16484: Add scratchpad plugin.
  • Make commands per-config and new scratches use command set last for suffix. I could not use mime types, as I was having some problems with detecting them,
  • Removed dependency of a compiler
  • Some other minor improvements
Nov 1 2018, 7:48 AM · KDevelop

Oct 29 2018

amhndu updated the diff for D16484: Add scratchpad plugin.

Thanks for the feedback, I've updated with some of the requested changes.

Oct 29 2018, 4:49 PM · KDevelop
amhndu added a comment to D16484: Add scratchpad plugin.

One thing comes to mind: you kind of require that there is a compiler, while 3 of the 4 languages KDevelop officially supports (PHP, Python and JS) do not use one. I think it would be nice if this plugin would also easily work for e.g. Python snippets.

That's one of the problems I've had, the command box coupled with your suggestion to have per-scratch config could help somewhat. Is there some kdev interface that would help here or some other solution ?

Oct 29 2018, 4:14 PM · KDevelop
amhndu updated the diff for D16484: Add scratchpad plugin.

Some improvements

Oct 29 2018, 3:00 PM · KDevelop

Oct 28 2018

amhndu requested review of D16484: Add scratchpad plugin.
Oct 28 2018, 4:49 PM · KDevelop
amhndu updated the diff for D15645: Add scheme selection menu with a "System" entry..

kcolorschemedemo.cpp does not actually seem to build an executable.

Oct 28 2018, 9:41 AM · Frameworks

Oct 27 2018

amhndu updated the diff for D15645: Add scheme selection menu with a "System" entry..

Fixed error in colorschemedemo test.
Sorry about that, I must've forgotton to commit it.

Oct 27 2018, 5:49 AM · Frameworks

Oct 23 2018

amhndu committed R32:48e0f084ab74: Place cursor after opening brace for function implementation (authored by amhndu).
Place cursor after opening brace for function implementation
Oct 23 2018, 3:12 PM
amhndu closed D16386: Place cursor after opening brace for function implementation.
Oct 23 2018, 3:12 PM · KDevelop
amhndu added a comment to D16386: Place cursor after opening brace for function implementation.

Thanks!

Oct 23 2018, 3:00 PM · KDevelop
amhndu added a comment to D16386: Place cursor after opening brace for function implementation.

Yes, seems that way.
I also remember seeing that on bugzilla, but can't find now.

Oct 23 2018, 2:23 PM · KDevelop
amhndu requested review of D16386: Place cursor after opening brace for function implementation.
Oct 23 2018, 2:14 PM · KDevelop
amhndu committed R32:4e402f2e5726: Offer completion after user types the scope resolution operator. (authored by amhndu).
Offer completion after user types the scope resolution operator.
Oct 23 2018, 9:38 AM
amhndu closed D16315: Offer completion after user types the scope resolution operator..
Oct 23 2018, 9:38 AM · KDevelop
amhndu committed R32:4f2fc9e32452: Replace leading typed text when completing function implementation (authored by amhndu).
Replace leading typed text when completing function implementation
Oct 23 2018, 7:55 AM
amhndu closed D16326: Replace leading typed text when completing function implementation.
Oct 23 2018, 7:55 AM · KDevelop

Oct 22 2018

amhndu added a comment to D16326: Replace leading typed text when completing function implementation.

I do have push rights, I can land this tomorrow as I'll be travelling a bit today.
Which branch should this be landed against ?

Oct 22 2018, 10:46 AM · KDevelop
amhndu added a comment to D16315: Offer completion after user types the scope resolution operator..

Should I land this on master or 5.3 ?

Oct 22 2018, 3:49 AM · KDevelop
amhndu updated the diff for D16326: Replace leading typed text when completing function implementation.

Created new test case for whitespace mismatch.

Oct 22 2018, 3:41 AM · KDevelop

Oct 21 2018

amhndu updated the diff for D16326: Replace leading typed text when completing function implementation.

Updated to use QChar overload as suggested.

Oct 21 2018, 7:02 PM · KDevelop
amhndu added a comment to D16326: Replace leading typed text when completing function implementation.

I actually changed the last test to also test for this. Should I split it to a new one ?

Oct 21 2018, 6:42 PM · KDevelop
amhndu updated the diff for D16326: Replace leading typed text when completing function implementation.

I've changed the implementation to accomodate for whitespace, by comparing
a whitespace-stripped version of the signature and the leading text.

Oct 21 2018, 6:32 PM · KDevelop

Oct 20 2018

amhndu updated the diff for D16326: Replace leading typed text when completing function implementation.

Added tests in testCompleteFunction, which already has some implements-completion
tests. Should I move them to a different test, something like testImplementExecute
in a different patch or this one ?

Oct 20 2018, 8:42 AM · KDevelop

Oct 19 2018

amhndu added a reviewer for D16326: Replace leading typed text when completing function implementation: KDevelop.
Oct 19 2018, 6:36 PM · KDevelop
amhndu requested review of D16326: Replace leading typed text when completing function implementation.
Oct 19 2018, 6:33 PM · KDevelop
amhndu added a comment to D15645: Add scheme selection menu with a "System" entry..

Ping. Can someone please review ?

Oct 19 2018, 1:46 PM · Frameworks
amhndu added a reviewer for D16315: Offer completion after user types the scope resolution operator.: KDevelop.
Oct 19 2018, 12:11 PM · KDevelop
amhndu requested review of D16315: Offer completion after user types the scope resolution operator..
Oct 19 2018, 12:10 PM · KDevelop

Oct 12 2018

amhndu abandoned D15902: Consider using-directives with function implements code-completion.

The simple example

namespace A
{
    void foo();
}
Oct 12 2018, 1:56 PM · KDevelop

Oct 3 2018

amhndu updated the test plan for D15902: Consider using-directives with function implements code-completion.
Oct 3 2018, 4:13 AM · KDevelop
amhndu updated the diff for D15902: Consider using-directives with function implements code-completion.

Added a test.
But, as I've mentioned before, the tests for code completion crash,
So I haven't been able to run all tests, though you can run a single test case
before it crashes.

Oct 3 2018, 4:09 AM · KDevelop

Oct 2 2018

amhndu added a reviewer for D15902: Consider using-directives with function implements code-completion: KDevelop.
Oct 2 2018, 5:50 PM · KDevelop
amhndu requested review of D15902: Consider using-directives with function implements code-completion.
Oct 2 2018, 5:49 PM · KDevelop

Sep 28 2018

amhndu committed R32:c7922784ab63: Merge branch '5.3' (authored by amhndu).
Merge branch '5.3'
Sep 28 2018, 3:11 PM
amhndu committed R32:cef296113612: Fix removal of external scripts (authored by amhndu).
Fix removal of external scripts
Sep 28 2018, 2:59 PM
amhndu closed D15743: Fix removal of external scripts.
Sep 28 2018, 2:59 PM · KDevelop
amhndu added inline comments to D15743: Fix removal of external scripts.
Sep 28 2018, 2:04 PM · KDevelop
amhndu updated the diff for D15743: Fix removal of external scripts.

Updated with requested changes.

Sep 28 2018, 2:03 PM · KDevelop

Sep 27 2018

amhndu updated the summary of D15645: Add scheme selection menu with a "System" entry..
Sep 27 2018, 6:17 PM · Frameworks
amhndu committed R32:93c75eb21d3b: Merge branch '5.3' (authored by amhndu).
Merge branch '5.3'
Sep 27 2018, 6:08 PM
amhndu committed R32:030545919cde: Sublime: Rename private member of IdealButtonBarLayout for consistency (authored by amhndu).
Sublime: Rename private member of IdealButtonBarLayout for consistency
Sep 27 2018, 6:02 PM
amhndu committed R32:7169b3ac931c: Sublime: Fix crash when changing areas (authored by amhndu).
Sublime: Fix crash when changing areas
Sep 27 2018, 5:14 PM
amhndu closed D15625: Sublime: Fix crash when changing areas.
Sep 27 2018, 5:14 PM · KDevelop
amhndu updated the diff for D15625: Sublime: Fix crash when changing areas.

Final update with requested changes.

Sep 27 2018, 4:47 PM · KDevelop
amhndu updated the summary of D15625: Sublime: Fix crash when changing areas.
Sep 27 2018, 2:38 PM · KDevelop
amhndu updated the diff for D15625: Sublime: Fix crash when changing areas.

Pass style parent in the constructor for Ideal Layout, and install event filter
on it to monitor style changes and set spacing.

Sep 27 2018, 2:20 PM · KDevelop
amhndu added a comment to D15743: Fix removal of external scripts.

Patch to move the key set as a member:

diff --git a/plugins/externalscript/externalscriptplugin.cpp b/plugins/externalscript/externalscriptplugin.cpp
index e1009457c8..3f2bddeeff 100644
--- a/plugins/externalscript/externalscriptplugin.cpp
+++ b/plugins/externalscript/externalscriptplugin.cpp
@@ -120,6 +120,7 @@ ExternalScriptPlugin::ExternalScriptPlugin( QObject* parent, const QVariantList&
       item->action()->setShortcut( QKeySequence( script.readEntry( "shortcuts" ) ) );
       item->setShowOutput( script.readEntry( "showOutput", true ) );
       m_model->appendRow( item );
+      m_keySet.insert( script.name() );
     }
   }
   //END load config
@@ -350,6 +351,7 @@ void ExternalScriptPlugin::rowsAboutToBeRemoved( const QModelIndex& /*parent*/,
     const ExternalScriptItem* const item = static_cast<ExternalScriptItem*>( m_model->item( row ) );
     KConfigGroup child = config.group( item->key() );
     qCDebug(PLUGIN_EXTERNALSCRIPT) << "removing config group:" << child.name();
+    m_keySet.remove( item->key() );
     child.deleteGroup();
   }
   config.sync();
@@ -361,7 +363,10 @@ void ExternalScriptPlugin::updateItem( const ExternalScriptItem* item )
   Q_ASSERT( index.isValid() );
Sep 27 2018, 5:28 AM · KDevelop
amhndu updated the diff for D15625: Sublime: Fix crash when changing areas.

Updated with requested changes.

Sep 27 2018, 5:17 AM · KDevelop

Sep 26 2018

amhndu updated the diff for D15625: Sublime: Fix crash when changing areas.

IdealButtonBarLayout is now derived from QBoxLayout and delegates all operations to it.

Sep 26 2018, 4:37 PM · KDevelop
amhndu added inline comments to D15743: Fix removal of external scripts.
Sep 26 2018, 10:39 AM · KDevelop
amhndu added a comment to D15625: Sublime: Fix crash when changing areas.

Which could happen independently of us providing proper minimumSizeHints, by code that is broken or confused (think custom styles) or otherwise forced to go beyond our hints. The API dox of QLayoutItem::setGeometry(const QRect &r) does not forbid to set rects smaller than the minimumSizeHint() or even a 0 size rect.

Sep 26 2018, 7:56 AM · KDevelop
amhndu added a comment to D15625: Sublime: Fix crash when changing areas.

Still, the crash as I have understood is roots in IdealButtonBarLayout::setGeometry(QRect) being called with some zero rect.

Sep 26 2018, 7:03 AM · KDevelop

Sep 25 2018

amhndu updated the summary of D15743: Fix removal of external scripts.
Sep 25 2018, 7:18 PM · KDevelop
amhndu updated the diff for D15743: Fix removal of external scripts.

Refactored external script to store the config label inside the model
as discussed with @flherne on irc
Inserting/Deleting/Updating scripts now works as expected.

Sep 25 2018, 7:14 PM · KDevelop
amhndu retitled D15743: Fix removal of external scripts from Fix removal of external scripts to [WIP] Fix removal of external scripts.
Sep 25 2018, 1:46 PM · KDevelop
amhndu added a comment to D15743: Fix removal of external scripts.

I couldn't find anything to move a group or rename a group, so I'm copying and deleting.
Is there a better way ?

Sep 25 2018, 10:21 AM · KDevelop
amhndu added a reviewer for D15743: Fix removal of external scripts: KDevelop.
Sep 25 2018, 10:20 AM · KDevelop
amhndu requested review of D15743: Fix removal of external scripts.
Sep 25 2018, 10:20 AM · KDevelop
amhndu updated the summary of D15625: Sublime: Fix crash when changing areas.
Sep 25 2018, 7:13 AM · KDevelop
amhndu updated the summary of D15625: Sublime: Fix crash when changing areas.
Sep 25 2018, 7:09 AM · KDevelop
amhndu updated the diff for D15625: Sublime: Fix crash when changing areas.

Some styling fixes.

Sep 25 2018, 4:10 AM · KDevelop

Sep 24 2018

amhndu updated the diff for D15625: Sublime: Fix crash when changing areas.

Forgot to update one qCWarning into qCDebug.

Sep 24 2018, 7:04 PM · KDevelop
amhndu updated the diff for D15625: Sublime: Fix crash when changing areas.

Re-implemented Ideal Layout's minimumSize which accumulates the newly added
minimumSize in Ideal Button.
The previous buggy implementation of minimumSize in the Ideal Layout called the doVerticalLayout
with a zero rect, although the height is passed from a property, but it is never set to anything
non-zero, which is what caused problems with some QtCurve configs.

Sep 24 2018, 7:00 PM · KDevelop
amhndu added a comment to D15625: Sublime: Fix crash when changing areas.

It appears this bug is because minimumSize calls doVerticalLayout with a zero rect

Sep 24 2018, 5:24 PM · KDevelop
amhndu added a comment to D15625: Sublime: Fix crash when changing areas.

Then I don't understand the question.

Sep 24 2018, 5:12 PM · KDevelop
amhndu added a comment to D15625: Sublime: Fix crash when changing areas.

If I may: can someone please tell me why it should be impossible that only small items are found, IOW why there would also have to be something to shrink?

Ideally, Layout::sizeHint should tell us the total space the buttons would occupy (given that it sums up the button size hints), comparing that to the rect should make it make it possible to predict.
I've been assuming if the buttons were to all fit, rect.height() should be equal to sizeHint().height()

Sep 24 2018, 5:01 PM · KDevelop
amhndu added a comment to D15625: Sublime: Fix crash when changing areas.

are you sure the comparison should be itemWidth <= maximumWidth and not a simple < instead?

The reasoning was that Items that have maximumWidth size needn't be shrinked, as that's the maximum size that's allowable.

Sep 24 2018, 1:25 PM · KDevelop
amhndu added a comment to D15625: Sublime: Fix crash when changing areas.

if you want to bite in deeper I can share my settings

Sep 24 2018, 12:33 PM · KDevelop

Sep 23 2018

amhndu updated the diff for D15645: Add scheme selection menu with a "System" entry..

Updated with styling suggestions.

Sep 23 2018, 7:16 AM · Frameworks

Sep 21 2018

amhndu updated the diff for D15645: Add scheme selection menu with a "System" entry..

Move duplicate code from the two createSelectionMenu methods into one
generic createSelectionMenu in KColorSchemeMangerPrivate

Sep 21 2018, 7:34 PM · Frameworks
amhndu updated the diff for D15625: Sublime: Fix crash when changing areas.

Oh yes, sorry about that, they say misleading documentation is worse than no documentation :D

Sep 21 2018, 4:10 PM · KDevelop
amhndu updated the diff for D15625: Sublime: Fix crash when changing areas.

Add requested comments and warning

Sep 21 2018, 2:22 PM · KDevelop
amhndu added a comment to D15645: Add scheme selection menu with a "System" entry..

Should I also add the other overloads like createSchemeSelectionMenu does ?

Sep 21 2018, 1:29 PM · Frameworks