amhndu (Amish Naidu)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 18 2018, 4:07 PM (48 w, 1 d)
Availability
Available

Recent Activity

Apr 12 2019

amhndu abandoned D19883: Add unique-window mode which opens uris in a new tab instead of a window.

I understand

Apr 12 2019, 4:57 AM · Dolphin

Mar 26 2019

amhndu committed R318:017cd2322a0a: Prompt user to save/discard changes upon closing config dialog (authored by amhndu).
Prompt user to save/discard changes upon closing config dialog
Mar 26 2019, 8:54 AM
amhndu closed D19904: Prompt user to save/discard changes upon closing config dialog.
Mar 26 2019, 8:54 AM · Dolphin

Mar 25 2019

amhndu updated the diff for D19904: Prompt user to save/discard changes upon closing config dialog.
  • Update with requested changes
Mar 25 2019, 10:12 AM · Dolphin

Mar 21 2019

amhndu added a comment to D19904: Prompt user to save/discard changes upon closing config dialog.

Should that really prompt the user? I expect clicking Cancel to close the dialog

Mar 21 2019, 6:16 AM · Dolphin

Mar 20 2019

amhndu updated the summary of D19904: Prompt user to save/discard changes upon closing config dialog.
Mar 20 2019, 9:44 AM · Dolphin
amhndu added a reviewer for D19904: Prompt user to save/discard changes upon closing config dialog: Dolphin.
Mar 20 2019, 9:37 AM · Dolphin
amhndu requested review of D19904: Prompt user to save/discard changes upon closing config dialog.
Mar 20 2019, 9:35 AM · Dolphin

Mar 19 2019

amhndu added a comment to D19883: Add unique-window mode which opens uris in a new tab instead of a window.

I was not aware there were patches that already did this.
I only found https://git.reviewboard.kde.org/r/129043/ on the bug report which was abandoned, otherwise I would not have created another one!

Mar 19 2019, 3:59 PM · Dolphin
amhndu added a reviewer for D19883: Add unique-window mode which opens uris in a new tab instead of a window: Dolphin.
Mar 19 2019, 1:42 PM · Dolphin
amhndu requested review of D19883: Add unique-window mode which opens uris in a new tab instead of a window.
Mar 19 2019, 1:41 PM · Dolphin

Jan 14 2019

amhndu committed R32:519de0f126e8: Scratchpad: Validate actions when opening context menu (authored by amhndu).
Scratchpad: Validate actions when opening context menu
Jan 14 2019, 9:34 AM
amhndu closed D18216: Scratchpad: Validate actions when opening context menu.
Jan 14 2019, 9:34 AM · KDevelop

Jan 12 2019

amhndu added a reviewer for D18216: Scratchpad: Validate actions when opening context menu: arrowd.
Jan 12 2019, 8:15 PM · KDevelop
amhndu requested review of D18216: Scratchpad: Validate actions when opening context menu.
Jan 12 2019, 8:12 PM · KDevelop
amhndu committed R32:4c3856c029f6: Allow configuring shortcut for Run Scratch action and add to Run menu (authored by amhndu).
Allow configuring shortcut for Run Scratch action and add to Run menu
Jan 12 2019, 5:56 PM
amhndu closed D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.
Jan 12 2019, 5:56 PM · KDevelop
amhndu added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

But these actions are disabled until I open any scratch in the editor.

Jan 12 2019, 4:37 PM · KDevelop
amhndu added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

For example, I have 2 scratches: scr1.cpp and scr2.cpp. I left-click on first one and open it, then right-click on second one and select Run. The 2nd scratch gets executed.

Jan 12 2019, 4:36 PM · KDevelop
amhndu added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

I found the following minor issue:

When I just started KDevelop and open "Scratchpad" toolview, any action except "New Scratch" are greyed out. Even "Remove Scratch", as well as "Run Scratch". When I open any scratch, it turns back to normal, even if I again close all Sratchpad windows.

Jan 12 2019, 1:37 PM · KDevelop

Jan 8 2019

amhndu committed R32:a54c46524b8e: Add assistant to generate header guards (authored by amhndu).
Add assistant to generate header guards
Jan 8 2019, 12:30 PM
amhndu closed D17370: Add assistant to generate header guards.
Jan 8 2019, 12:30 PM · KDevelop

Jan 7 2019

amhndu added a comment to D17370: Add assistant to generate header guards.

Any objections for pushing this to 5.3 ?

Jan 7 2019, 5:47 AM · KDevelop

Jan 5 2019

amhndu committed R32:05efd841d4f5: Show "Move into Source" action in code menu (authored by amhndu).
Show "Move into Source" action in code menu
Jan 5 2019, 1:50 PM
amhndu closed D17525: Show "Move into Source" action in code menu.
Jan 5 2019, 1:50 PM · KDevelop

Jan 4 2019

amhndu updated the diff for D17370: Add assistant to generate header guards.
  • Fix some edge cases, cleanup and add more test cases
Jan 4 2019, 7:55 PM · KDevelop
amhndu added a comment to D17525: Show "Move into Source" action in code menu.

That is strange..
I bumped the version, so it should update it, I tried re-installing and it works for me.
Can you try deleting ~/.local/share/kxmlgui5/kdevclangsupport/kdevclangsupport.rc ?

Jan 4 2019, 4:56 AM · KDevelop

Jan 3 2019

amhndu added a comment to D17525: Show "Move into Source" action in code menu.

Before: https://i.imgur.com/GhGdOBV.png
After: https://i.imgur.com/ygDEnpw.png

Jan 3 2019, 7:33 PM · KDevelop
amhndu updated the diff for D17370: Add assistant to generate header guards.
  • Remove dependency on clang 7.0.0 functions
Jan 3 2019, 7:22 PM · KDevelop

Dec 14 2018

amhndu committed R32:36ea7ca30c7c: Remove reliance on Qt 5.11+ QIODevice::NewOnly in the Scratchpad plugin (authored by amhndu).
Remove reliance on Qt 5.11+ QIODevice::NewOnly in the Scratchpad plugin
Dec 14 2018, 10:35 AM
amhndu closed D17575: Remove reliance on Qt 5.11+ QIODevice::NewOnly in the Scratchpad plugin.
Dec 14 2018, 10:35 AM · KDevelop
amhndu requested review of D17575: Remove reliance on Qt 5.11+ QIODevice::NewOnly in the Scratchpad plugin.
Dec 14 2018, 10:25 AM · KDevelop

Dec 13 2018

amhndu added a reviewer for D17569: Allow configuring shortcut for Run Scratch action and add to Run menu: kfunk.
Dec 13 2018, 5:20 PM · KDevelop
amhndu requested review of D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.
Dec 13 2018, 5:17 PM · KDevelop

Dec 12 2018

amhndu requested review of D17525: Show "Move into Source" action in code menu.
Dec 12 2018, 8:29 AM · KDevelop

Dec 11 2018

amhndu committed R32:37f68b8d4299: Add scratchpad plugin (authored by amhndu).
Add scratchpad plugin
Dec 11 2018, 3:06 PM
amhndu closed D16484: Add scratchpad plugin.
Dec 11 2018, 3:06 PM · KDevelop

Dec 10 2018

amhndu added inline comments to D16484: Add scratchpad plugin.
Dec 10 2018, 9:27 AM · KDevelop

Dec 7 2018

amhndu added inline comments to D16484: Add scratchpad plugin.
Dec 7 2018, 6:22 AM · KDevelop

Dec 6 2018

amhndu updated the test plan for D17370: Add assistant to generate header guards.
Dec 6 2018, 6:25 PM · KDevelop
amhndu updated the diff for D17370: Add assistant to generate header guards.
  • Add tests for HeaderGuardAssistant
Dec 6 2018, 6:24 PM · KDevelop
amhndu updated the diff for D17370: Add assistant to generate header guards.
  • QStringLiteral -> i18n
Dec 6 2018, 11:17 AM · KDevelop

Dec 5 2018

amhndu requested review of D17370: Add assistant to generate header guards.
Dec 5 2018, 6:28 PM · KDevelop

Dec 3 2018

amhndu added inline comments to D16484: Add scratchpad plugin.
Dec 3 2018, 4:44 PM · KDevelop
amhndu updated the diff for D16484: Add scratchpad plugin.
  • Save scratch when run
  • Fix scratch removal bug
  • Invalidate actions when list is emptied
Dec 3 2018, 4:44 PM · KDevelop
amhndu committed R32:0636cfdd8a93: Don't add 'override' specifier for non-modern project settings (authored by amhndu).
Don't add 'override' specifier for non-modern project settings
Dec 3 2018, 10:51 AM
amhndu closed D16773: Don't add 'override' specifier for non-modern project settings.
Dec 3 2018, 10:51 AM · KDevelop
amhndu added a comment to D16773: Don't add 'override' specifier for non-modern project settings.

Will push with your version, looks better.
Thanks for the review :)

Dec 3 2018, 9:54 AM · KDevelop

Nov 26 2018

amhndu added a comment to D16484: Add scratchpad plugin.

How should I proceed with this ?
As suggested on IRC, should I try to release it independently because of the size ?

Nov 26 2018, 7:57 AM · KDevelop

Nov 23 2018

amhndu added a comment to D16773: Don't add 'override' specifier for non-modern project settings.

ping ?

Nov 23 2018, 4:59 AM · KDevelop

Nov 9 2018

amhndu added a reviewer for D16484: Add scratchpad plugin: KDevelop.
Nov 9 2018, 11:05 AM · KDevelop
amhndu updated the diff for D16773: Don't add 'override' specifier for non-modern project settings.
  • Change test case and convert octal literal to decimal
Nov 9 2018, 10:26 AM · KDevelop
amhndu requested review of D16773: Don't add 'override' specifier for non-modern project settings.
Nov 9 2018, 7:28 AM · KDevelop

Nov 3 2018

amhndu updated the diff for D16484: Add scratchpad plugin.
  • Add a message when the scratch list is empty
Nov 3 2018, 1:46 PM · KDevelop

Nov 1 2018

amhndu added a comment to D16484: Add scratchpad plugin.

Would something like this be worth adding ?

cpp
index 5c193432c9..1b5fb57352 100644
--- a/plugins/scratchpad/scratchpadview.cpp
+++ b/plugins/scratchpad/scratchpadview.cpp
@@ -37,6 +37,7 @@
 #include <QWidgetAction>
 #include <QLineEdit>
 #include <QInputDialog>
+#include <QPainter>
Nov 1 2018, 9:44 AM · KDevelop
amhndu added a comment to D16484: Add scratchpad plugin.

Marking inline comments done.

Nov 1 2018, 7:49 AM · KDevelop
amhndu updated the diff for D16484: Add scratchpad plugin.
  • Make commands per-config and new scratches use command set last for suffix. I could not use mime types, as I was having some problems with detecting them,
  • Removed dependency of a compiler
  • Some other minor improvements
Nov 1 2018, 7:48 AM · KDevelop

Oct 29 2018

amhndu updated the diff for D16484: Add scratchpad plugin.

Thanks for the feedback, I've updated with some of the requested changes.

Oct 29 2018, 4:49 PM · KDevelop
amhndu added a comment to D16484: Add scratchpad plugin.

One thing comes to mind: you kind of require that there is a compiler, while 3 of the 4 languages KDevelop officially supports (PHP, Python and JS) do not use one. I think it would be nice if this plugin would also easily work for e.g. Python snippets.

That's one of the problems I've had, the command box coupled with your suggestion to have per-scratch config could help somewhat. Is there some kdev interface that would help here or some other solution ?

Oct 29 2018, 4:14 PM · KDevelop
amhndu updated the diff for D16484: Add scratchpad plugin.

Some improvements

Oct 29 2018, 3:00 PM · KDevelop

Oct 28 2018

amhndu requested review of D16484: Add scratchpad plugin.
Oct 28 2018, 4:49 PM · KDevelop
amhndu updated the diff for D15645: Add scheme selection menu with a "System" entry..

kcolorschemedemo.cpp does not actually seem to build an executable.

Oct 28 2018, 9:41 AM · Frameworks

Oct 27 2018

amhndu updated the diff for D15645: Add scheme selection menu with a "System" entry..

Fixed error in colorschemedemo test.
Sorry about that, I must've forgotton to commit it.

Oct 27 2018, 5:49 AM · Frameworks

Oct 23 2018

amhndu committed R32:48e0f084ab74: Place cursor after opening brace for function implementation (authored by amhndu).
Place cursor after opening brace for function implementation
Oct 23 2018, 3:12 PM
amhndu closed D16386: Place cursor after opening brace for function implementation.
Oct 23 2018, 3:12 PM · KDevelop
amhndu added a comment to D16386: Place cursor after opening brace for function implementation.

Thanks!

Oct 23 2018, 3:00 PM · KDevelop
amhndu added a comment to D16386: Place cursor after opening brace for function implementation.

Yes, seems that way.
I also remember seeing that on bugzilla, but can't find now.

Oct 23 2018, 2:23 PM · KDevelop
amhndu requested review of D16386: Place cursor after opening brace for function implementation.
Oct 23 2018, 2:14 PM · KDevelop
amhndu committed R32:4e402f2e5726: Offer completion after user types the scope resolution operator. (authored by amhndu).
Offer completion after user types the scope resolution operator.
Oct 23 2018, 9:38 AM
amhndu closed D16315: Offer completion after user types the scope resolution operator..
Oct 23 2018, 9:38 AM · KDevelop
amhndu committed R32:4f2fc9e32452: Replace leading typed text when completing function implementation (authored by amhndu).
Replace leading typed text when completing function implementation
Oct 23 2018, 7:55 AM
amhndu closed D16326: Replace leading typed text when completing function implementation.
Oct 23 2018, 7:55 AM · KDevelop

Oct 22 2018

amhndu added a comment to D16326: Replace leading typed text when completing function implementation.

I do have push rights, I can land this tomorrow as I'll be travelling a bit today.
Which branch should this be landed against ?

Oct 22 2018, 10:46 AM · KDevelop
amhndu added a comment to D16315: Offer completion after user types the scope resolution operator..

Should I land this on master or 5.3 ?

Oct 22 2018, 3:49 AM · KDevelop
amhndu updated the diff for D16326: Replace leading typed text when completing function implementation.

Created new test case for whitespace mismatch.

Oct 22 2018, 3:41 AM · KDevelop

Oct 21 2018

amhndu updated the diff for D16326: Replace leading typed text when completing function implementation.

Updated to use QChar overload as suggested.

Oct 21 2018, 7:02 PM · KDevelop
amhndu added a comment to D16326: Replace leading typed text when completing function implementation.

I actually changed the last test to also test for this. Should I split it to a new one ?

Oct 21 2018, 6:42 PM · KDevelop
amhndu updated the diff for D16326: Replace leading typed text when completing function implementation.

I've changed the implementation to accomodate for whitespace, by comparing
a whitespace-stripped version of the signature and the leading text.

Oct 21 2018, 6:32 PM · KDevelop

Oct 20 2018

amhndu updated the diff for D16326: Replace leading typed text when completing function implementation.

Added tests in testCompleteFunction, which already has some implements-completion
tests. Should I move them to a different test, something like testImplementExecute
in a different patch or this one ?

Oct 20 2018, 8:42 AM · KDevelop

Oct 19 2018

amhndu added a reviewer for D16326: Replace leading typed text when completing function implementation: KDevelop.
Oct 19 2018, 6:36 PM · KDevelop
amhndu requested review of D16326: Replace leading typed text when completing function implementation.
Oct 19 2018, 6:33 PM · KDevelop
amhndu added a comment to D15645: Add scheme selection menu with a "System" entry..

Ping. Can someone please review ?

Oct 19 2018, 1:46 PM · Frameworks
amhndu added a reviewer for D16315: Offer completion after user types the scope resolution operator.: KDevelop.
Oct 19 2018, 12:11 PM · KDevelop
amhndu requested review of D16315: Offer completion after user types the scope resolution operator..
Oct 19 2018, 12:10 PM · KDevelop

Oct 12 2018

amhndu abandoned D15902: Consider using-directives with function implements code-completion.

The simple example

namespace A
{
    void foo();
}
Oct 12 2018, 1:56 PM · KDevelop

Oct 3 2018

amhndu updated the test plan for D15902: Consider using-directives with function implements code-completion.
Oct 3 2018, 4:13 AM · KDevelop
amhndu updated the diff for D15902: Consider using-directives with function implements code-completion.

Added a test.
But, as I've mentioned before, the tests for code completion crash,
So I haven't been able to run all tests, though you can run a single test case
before it crashes.

Oct 3 2018, 4:09 AM · KDevelop

Oct 2 2018

amhndu added a reviewer for D15902: Consider using-directives with function implements code-completion: KDevelop.
Oct 2 2018, 5:50 PM · KDevelop
amhndu requested review of D15902: Consider using-directives with function implements code-completion.
Oct 2 2018, 5:49 PM · KDevelop

Sep 28 2018

amhndu committed R32:c7922784ab63: Merge branch '5.3' (authored by amhndu).
Merge branch '5.3'
Sep 28 2018, 3:11 PM
amhndu committed R32:cef296113612: Fix removal of external scripts (authored by amhndu).
Fix removal of external scripts
Sep 28 2018, 2:59 PM
amhndu closed D15743: Fix removal of external scripts.
Sep 28 2018, 2:59 PM · KDevelop
amhndu added inline comments to D15743: Fix removal of external scripts.
Sep 28 2018, 2:04 PM · KDevelop
amhndu updated the diff for D15743: Fix removal of external scripts.

Updated with requested changes.

Sep 28 2018, 2:03 PM · KDevelop

Sep 27 2018

amhndu updated the summary of D15645: Add scheme selection menu with a "System" entry..
Sep 27 2018, 6:17 PM · Frameworks
amhndu committed R32:93c75eb21d3b: Merge branch '5.3' (authored by amhndu).
Merge branch '5.3'
Sep 27 2018, 6:08 PM
amhndu committed R32:030545919cde: Sublime: Rename private member of IdealButtonBarLayout for consistency (authored by amhndu).
Sublime: Rename private member of IdealButtonBarLayout for consistency
Sep 27 2018, 6:02 PM
amhndu committed R32:7169b3ac931c: Sublime: Fix crash when changing areas (authored by amhndu).
Sublime: Fix crash when changing areas
Sep 27 2018, 5:14 PM
amhndu closed D15625: Sublime: Fix crash when changing areas.
Sep 27 2018, 5:14 PM · KDevelop
amhndu updated the diff for D15625: Sublime: Fix crash when changing areas.

Final update with requested changes.

Sep 27 2018, 4:47 PM · KDevelop