+1, that's fine with me too.

I agree, I hate this kind of ambiguous language.

Relavant code is KFormat::formatRelativeDate

@dfaure Ping

Also revert 90beb4a5e37b887caad1e767046a42dad0af1ab3 which is no longer needed

various fixes suggested by dfaure

Yep, still looking for primarily design input.

• Fix indentation

Address comments

I dont think that's wise. It's an integral part of this change, since users have to know which settings are logically connected to this new mode and which ones are not.

Friendly ping

Please see 90beb4a5e37b887caad1e767046a42dad0af1ab3

Would you mind splitting the re-design of the Startup settings page to a different commit?

In T11663#213094, @manueljlin wrote:

"Keep a single URL Navigator in the toolbar, but change it dynamically to show the path for the active split view" is probably the best option

The issue with that approach is that you can never be 100% sure you're in the right directory on your inactive split view. A minor issue, yes, but an issue nonetheless.

Please push to release/19.12

+1 to tabs having a minimum width size
I kind of like that tab location but it probably shouldn't extend to the sidebar too.

With regards to the Docker/Gitlab CI part, please use the images under kdeorg/ on Dockerhub rather than personally maintained images as the wider community has no access to your namespace on Gitlab.com

I guess you were expecting a higher-level review, but I don't know anything about these protocols.

We decided not to do this. There are now quite a few items in here and it seems like they're fine there.

I just landed an old patch of mine that adds a dedicated "focus/de-focus terminal panel" action to Dolphin: D10959

Should be fully completed with D24247.

Yeah, let's keep this the way it is. I think it's plenty comprehensible, and we never managed to come up with a good place to move them anyway.

ReviewBoard has been closed down now.

This is currently in progress and I don't think we need this task open anymore. The patches are scattered across various bits of infrastructure so it won't be useful for linking them here.

In D25783#573233, @mlaurent wrote:

see https://bugs.kde.org/show_bug.cgi?id=414492 user already created patch.

see https://bugs.kde.org/show_bug.cgi?id=414492 user already created patch.

In D25732#573058, @dfaure wrote:

This should go into KDirWatch itself then, to avoid the risk of other callers falling into that trap.

In D25682#570849, @sitter wrote:

In D25682#570845, @davidedmundson wrote:

Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere?

Testing convenience until @caspermeijn makes a release mostly. The library was,or maybe even still is, in flux as API was being shuffled up to kdsoap.

See also commit 6be886bafae463ba in kcoreaddons (which was wrong, it would seem -- there are better ways to prevent infinite loops than to say "let's not follow symlinks at all").

This should go into KDirWatch itself then, to avoid the risk of other callers falling into that trap.

I think what was not working before was in fact a Konsole bug that has since been fixed in https://bugs.kde.org/show_bug.cgi?id=411181. Landing this now.

Rebase

Friendly ping!

Thanks, it no longer crashes now.

I agree that F4 should show and hide the Konsole panel in both apps. Then maybe we should assign a separate focus/defocus terminal panel shortcut, in both apps.

In T12318#212731, @sars wrote:

I was actually wondering why the F4 shortcut was put to Focus/Defocus Terminal and not to the "Show Terminal" action. The later action works the same as Dolphin (except that the focus to the terminal got broken at some point this fall or summer).

I would like F4 to be moved to "Show Terminal" (and fix the focus problem)

You can achieve Dolphin's behavior by reassigning the F4 shortcut to View > Tool Views > Show/Hide Konsole. That's what I do since > 10 years, and it works perfectly. Why is it not the default? Maybe because this action does not exist by default (i.e. when the Konsole plugin is not loaded). But the right fix is to reassign the F4 shortcut to this action.

I was actually wondering why the F4 shortcut was put to Focus/Defocus Terminal and not to the "Show Terminal" action. The later action works the same as Dolphin (except that the focus to the terminal got broken at some point this fall or summer).

In D25335#571651, @ngraham wrote:

In D25335#571437, @meven wrote:

Is your directory "/home/nate/Documents/Tabletop games/40K" owned by root or another user ?

No:

ls -la "/home/nate/Documents/Tabletop games/40K"
total 19404
drwxrwxr-x  5 nate users     4096 Nov 24 09:07  .

Use a QString as buffer for filenames

Picking up the discussions taken place on Reddit, on T12308 and on T11662, I'd like to show a revised mockup and would love some input on it:

Use QApplication::wheelScrollLines() instead of a magic number

Rebase

In D25335#571437, @meven wrote:

Is your directory "/home/nate/Documents/Tabletop games/40K" owned by root or another user ?

s/Deep/deep

In D25335#571311, @ngraham wrote:

I'm still not super thrilled by exposing something as nerdy as the maximum depth of calculation/recursion, but before we continue on the UI design discussion, Dolphin has started reproducibly crashing every time I enter Details view with the latest version of this patch. Here's the backtrace:

P498 cannot access memory

1	#0 __strlen_avx2 () at ../sysdeps/x86_64/multiarch/strlen-avx2.S:96
2	#1 0x00007ffff54d293e in __vfprintf_internal (s=s@entry=0x7fffe8e16f70,
3	format=format@entry=0x7ffff7eabefe "%s/%s", ap=ap@entry=0x7fffe8e170b0,
4	mode_flags=mode_flags@entry=0) at vfprintf-internal.c:1688
5	#2 0x00007ffff54ddf30 in __vsprintf_internal (
6	string=0x7fffe8e17240 "/home/nate/Documents/Tabletop games/40K/Inspiration",
7	maxlen=maxlen@entry=18446744073709551615,
8	format=format@entry=0x7ffff7eabefe "%s/%s", args=args@entry=0x7fffe8e170b0,
9	mode_flags=mode_flags@entry=0) at iovsprintf.c:96
10	#3 0x00007ffff54bd384 in __sprintf (
11	s=s@entry=0x7fffe8e17240 "/home/nate/Documents/Tabletop games/40K/Inspiration",
12	format=format@entry=0x7ffff7eabefe "%s/%s") at sprintf.c:30
13	#4 0x00007ffff7e5eab5 in walkDir (
14	dirPath=0x7fff0067706a <error: Cannot access memory at address 0x7fff0067706a>,
15	dirPath@entry=0x7fffe8e17430 "/home/nate/Documents/Tabletop games/40K",
16	countHiddenFiles=countHiddenFiles@entry=false, countDirectoriesOnly=97,
17	countDirectoriesOnly@entry=false, dirEntry=0x7fffe0014f88,
18	allowedRecursiveLevel=1818581280, allowedRecursiveLevel@entry=8)
19	at /home/nate/kde/src/dolphin/src/kitemviews/private/kdirectorycontentscounterworker.cpp:77
20	#5 0x00007ffff7e5eaf3 in walkDir (
21	dirPath=dirPath@entry=0x7fffe8e17620 "/home/nate/Documents/Tabletop games",
22	countHiddenFiles=countHiddenFiles@entry=false,
23	countDirectoriesOnly=countDirectoriesOnly@entry=false, dirEntry=0x7fffe000cd40,
24	allowedRecursiveLevel=allowedRecursiveLevel@entry=9)
25	at /home/nate/kde/src/dolphin/src/kitemviews/private/kdirectorycontentscounterworker.cpp:90
26	#6 0x00007ffff7e5eaf3 in walkDir (dirPath=0xcc50f8 "/home/nate/Documents",
27	countHiddenFiles=countHiddenFiles@entry=false,
28	countDirectoriesOnly=countDirectoriesOnly@entry=false, dirEntry=0x7fffe0004de0,
29	dirEntry@entry=0x0, allowedRecursiveLevel=allowedRecursiveLevel@entry=10)
30	at /home/nate/kde/src/dolphin/src/kitemviews/private/kdirectorycontentscounterworker.cpp:90
31	#7 0x00007ffff7e5ec0e in KDirectoryContentsCounterWorker::subItemsCount (path=...,
32	options=...) at /usr/include/qt5/QtCore/qarraydata.h:208
33	#8 0x00007ffff7e5ec77 in KDirectoryContentsCounterWorker::countDirectoryContents (
34	this=0x9ef7f0, path=..., options=...)
35	at /home/nate/kde/src/dolphin/src/kitemviews/private/kdirectorycontentscounterworker.cpp:131
36	#9 0x00007ffff5c30eea in QObject::event(QEvent*) () from /usr/lib64/libQt5Core.so.5
37	#10 0x00007ffff66dec62 in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
38	from /usr/lib64/libQt5Widgets.so.5
39	#11 0x00007ffff66e81e0 in QApplication::notify(QObject*, QEvent*) ()
40	from /usr/lib64/libQt5Widgets.so.5
41	#12 0x00007ffff5c05562 in QCoreApplication::notifyInternal2(QObject*, QEvent*) ()
42	from /usr/lib64/libQt5Core.so.5
43	#13 0x00007ffff5c081f8 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/lib64/libQt5Core.so.5
44	#14 0x00007ffff5c5c333 in ?? () from /usr/lib64/libQt5Core.so.5
45	#15 0x00007ffff4055f88 in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0
46	#16 0x00007ffff4056310 in ?? () from /usr/lib64/libglib-2.0.so.0
47	#17 0x00007ffff405639f in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0
48	#18 0x00007ffff5c5b971 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQt5Core.so.5
49	#19 0x00007ffff5c040cb in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) ()
50	from /usr/lib64/libQt5Core.so.5
51	#20 0x00007ffff5a3c021 in QThread::exec() () from /usr/lib64/libQt5Core.so.5
52	#21 0x00007ffff5a3d1a2 in ?? () from /usr/lib64/libQt5Core.so.5
53	#22 0x00007ffff50bdf2a in start_thread (arg=<optimized out>) at pthread_create.c:479
54	#23 0x00007ffff55654af in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

I'm still not super thrilled by exposing something as nerdy as the maximum depth of calculation/recursion, but before we continue on the UI design discussion, Dolphin has started reproducibly crashing every time I enter Details view with the latest version of this patch. Here's the backtrace:

In D25335#565799, @ngraham wrote:

I gave this a try today. The performance is quite good and the feature works great! It will be very nice to have, even without any caching (though that is probably necessary IMO to improve the display and performance and to minimize disk wear for SSDs in particular). I have a few concerns and suggestions for improvement:

1. The UI to turn this on is entirely too technical. It should be more like this:
   
   ` Folder size display: (o) Number of items ( ) Size of contents [4] Levels deep `

I mostly followed your nice suggestion.

Apply the setting in UI, better setting UI, remove nb of items when recurse count was selected, take into account folder size

This doesn't seem to work for me. When I click on the new menu item, the view refreshes but the item I told it to forget it still visible in the ioslave.

OMG it works!!! I can find my windows Samba share in Dolphin again!

@ahiemstra has graciously submitted a patch for KDirOperator: D25683

In D25682#570845, @davidedmundson wrote:

Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere?

Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere?

Rebase on master

UI looks good to me.

Disable selector when there are no tags

Rename addRecentlyUsedActions to addForgetRecentlyUsedAction

Split separately timelinecontext and searchcontext

In D25130#569590, @ngraham wrote:

Only one real suggestion: disable it when there are no tags. Otherwise clicking on it does nothing.

Nice idea! Baloo indexer is failing for me now due to some non-related assert error, so I cannot delete the tags to test it, but will try again.

• Use tag icon