anthonyfieroni (Anthony Fieroni)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2015, 10:58 AM (124 w, 3 d)
Availability
Available

Recent Activity

Thu, Jan 18

anthonyfieroni added a comment to D9731: Provide a dialog helper to handle properly its destruction.

The new class is quite simple, adding delete lead to manual add in more that one place at dialog use.

Thu, Jan 18, 3:09 PM

Wed, Jan 17

anthonyfieroni added a comment to D9731: Provide a dialog helper to handle properly its destruction.
In D9731#192122, @aacid wrote:

Why do you need a new template instead of using a QPointer as suggested in the blog?

Wed, Jan 17, 5:21 AM

Tue, Jan 16

anthonyfieroni added a reviewer for D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function): davidedmundson.
Tue, Jan 16, 5:56 PM · Frameworks

Mon, Jan 15

anthonyfieroni added reviewers for D9897: Small RTL fixes with the OverlayWidget: KDE PIM, mlaurent.
Mon, Jan 15, 7:12 PM · KDE PIM
anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

In Table -> Size -> Row Height... it has 'Fit to size' if it's checked you cannot cut text or make cell higher, but it's not you can make it whatever you want that cutting or exceeded lines.

Mon, Jan 15, 8:22 AM · Calligra: 3.0

Sun, Jan 14

anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

Bigger font will result with same *cutting* and this is only on PercentLineHeight.

Sun, Jan 14, 3:15 PM · Calligra: 3.0

Sat, Jan 13

Restricted Application edited projects for D9848: Updated the blur method to use the more efficient dual kawase blur algorithm., added: KWin; removed Plasma.
Sat, Jan 13, 9:36 AM · KWin

Fri, Jan 12

anthonyfieroni added a comment to D9829: Don't create 2 msgbox (one of them crashes) when can't change rights.

I'm still not sure that is correct fix. Can you investigate why second msgbox is shown? Maybe there is the problem.

Fri, Jan 12, 3:20 PM · Frameworks

Thu, Jan 11

anthonyfieroni added a comment to D9829: Don't create 2 msgbox (one of them crashes) when can't change rights.

What is job->error() ?

Thu, Jan 11, 6:47 PM · Frameworks
anthonyfieroni added a reviewer for D9826: [dolphin] Let users search everywhere: elvisangelaccio.

This is not good idea at all. In Linux we have many virtual FS that is not good to look in (or you can wait forever). Furthermore Dolphin does not search in hidden folders, so *everywhere* is quite relative.

Thu, Jan 11, 6:14 PM · KDE Applications, Dolphin
anthonyfieroni added reviewers for D9808: fix incorrect emission of signals by kLineEdit: dhaumann, cullmann.
Thu, Jan 11, 7:23 AM · Frameworks, KDevelop
anthonyfieroni added inline comments to D9808: fix incorrect emission of signals by kLineEdit.
Thu, Jan 11, 7:21 AM · Frameworks, KDevelop
anthonyfieroni added reviewers for D9809: work around bug in kLineEdit: KDevelop, apol.
Thu, Jan 11, 7:16 AM · KDevelop
anthonyfieroni added inline comments to D9809: work around bug in kLineEdit.
Thu, Jan 11, 7:16 AM · KDevelop

Wed, Jan 10

anthonyfieroni updated the test plan for D9731: Provide a dialog helper to handle properly its destruction.
Wed, Jan 10, 5:54 AM
anthonyfieroni updated the summary of D9731: Provide a dialog helper to handle properly its destruction.
Wed, Jan 10, 5:47 AM

Tue, Jan 9

anthonyfieroni added a comment to D9506: milti-screen sleep fix.

@McPain can you provide some debug info from qCDebug(KSCREEN_XRANDR), i don't have multi screen setup but we can make better fix.

Tue, Jan 9, 1:48 PM · Plasma
anthonyfieroni added a comment to D9731: Provide a dialog helper to handle properly its destruction.

I would move the file dialoghelper.h to one of the subdirectories, most likely /lib/?

Tue, Jan 9, 1:20 PM
anthonyfieroni updated the diff for D9731: Provide a dialog helper to handle properly its destruction.

Guard QPrintDialog too.

Tue, Jan 9, 1:06 PM
anthonyfieroni added a comment to D9731: Provide a dialog helper to handle properly its destruction.

So when you open foreground dialog you can click close button on background one, this will result in deletion of foreground and when exec() returns destructor will be called twice. This not always result in crash, depend on what is called in.

Tue, Jan 9, 12:52 PM

Mon, Jan 8

anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

In TEST PLAN has a screenshot 'before' you can see lower part of the text is cutoff.
https://phabricator.kde.org/file/data/dpjswbo33ottg5lrcpcf/PHID-FILE-lnwrz73xzlzj2ye3viou/Screenshot_20171228_211944.png

Mon, Jan 8, 8:57 PM · Calligra: 3.0
anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

Did you have a time to investigate? If you have suggest how to fix, i open document with Qt4 version it looks good.

Mon, Jan 8, 8:49 PM · Calligra: 3.0
anthonyfieroni added inline comments to D9738: Support font/ttf and font/otf mimetypes in kfontinst.
Mon, Jan 8, 6:20 PM · Plasma
anthonyfieroni added inline comments to D9632: Select only filename without extension in rename dialog box.
Mon, Jan 8, 12:13 PM

Sat, Jan 6

anthonyfieroni added inline comments to D9632: Select only filename without extension in rename dialog box.
Sat, Jan 6, 8:12 AM
anthonyfieroni added inline comments to D9632: Select only filename without extension in rename dialog box.
Sat, Jan 6, 7:58 AM

Thu, Jan 4

anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

Test document It's not present bug number.

Thu, Jan 4, 7:36 PM · Calligra: 3.0
anthonyfieroni added a comment to D9645: Bug fix 369542.

But KUrlRequester::setFilter expects KFilter syntax. So split it will end up with a QStringList { "Torrents (*.torrent);; (*)" } which is invalid for QFileDialog::setNameFilters

Thu, Jan 4, 1:25 PM · KDE Applications
anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

I investigate in drawing but i can't see how FormatRange is responsible for that. I think the problem is minimum height of the cell, if it changed in paintings it will allow to resize down, if we increase it, it will cannot.

Thu, Jan 4, 5:29 AM · Calligra: 3.0

Wed, Jan 3

anthonyfieroni added a comment to D9645: Bug fix 369542.

Function TorrentFileFilter is not working at all, so it's better to fix it.

Wed, Jan 3, 7:01 PM · KDE Applications
anthonyfieroni added a comment to D9610: Revive folderpanel when outside $HOME.

That's not exported, we cannot use it from Dolphin.

Yeah, i mean in same way.

Wed, Jan 3, 10:47 AM · Dolphin

Tue, Jan 2

anthonyfieroni updated subscribers of D9610: Revive folderpanel when outside $HOME.

@elvisangelaccio, the problem is file:/// + / + subdir result in invalid path. With @dfaure we make a path in KIO does we should do it here?

Tue, Jan 2, 8:41 PM · Dolphin
anthonyfieroni added inline comments to D9610: Revive folderpanel when outside $HOME.
Tue, Jan 2, 7:37 PM · Dolphin
anthonyfieroni added inline comments to D9610: Revive folderpanel when outside $HOME.
Tue, Jan 2, 6:49 PM · Dolphin
anthonyfieroni added inline comments to D9610: Revive folderpanel when outside $HOME.
Tue, Jan 2, 2:50 PM · Dolphin

Sun, Dec 31

anthonyfieroni removed a reviewer for D9347: Ignore baloo urls created from new KIO model: mlaurent.
Sun, Dec 31, 11:01 AM
anthonyfieroni added inline comments to D9416: Add support for OpenSSL 1.1.0.
Sun, Dec 31, 6:13 AM

Sat, Dec 30

anthonyfieroni added inline comments to D9556: fb_backend: use new udev function to detect framebuffer devices, if one is not set.
Sat, Dec 30, 8:59 PM · KWin
anthonyfieroni added a reviewer for D9070: KDE platform plugin: don't force default stylename on user-specified fonts: dfaure.

I'm not sure it's Qt bug, it change behavior and now it doing in *right* way. So i'm patch to be merged +1.

Sat, Dec 30, 4:31 PM · Plasma
anthonyfieroni committed R8:890b3198f4d1: [textlayout] Do not enter infinite loop when line rect is not valid (authored by anthonyfieroni).
[textlayout] Do not enter infinite loop when line rect is not valid
Sat, Dec 30, 6:32 AM
anthonyfieroni closed D9497: [textlayout] Do not enter infinite loop when line rect is not valid.
Sat, Dec 30, 6:32 AM · Calligra: 3.0

Fri, Dec 29

anthonyfieroni added inline comments to D9556: fb_backend: use new udev function to detect framebuffer devices, if one is not set.
Fri, Dec 29, 6:12 PM · KWin
anthonyfieroni added inline comments to D9551: logind: Add a function that detects the logind seat..
Fri, Dec 29, 6:04 PM · KWin
anthonyfieroni added inline comments to D9497: [textlayout] Do not enter infinite loop when line rect is not valid.
Fri, Dec 29, 6:46 AM · Calligra: 3.0
anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

The lines below will be drawn on top, and due to some other problem drawing lines will always clear the area first thus cutting away some of the text

Not sure if we can do anything about it

Fri, Dec 29, 6:27 AM · Calligra: 3.0
anthonyfieroni added inline comments to D698: Port from WebKit to WebEngine..
Fri, Dec 29, 6:13 AM · KDE Edu, Marble

Thu, Dec 28

anthonyfieroni added a reviewer for D9497: [textlayout] Do not enter infinite loop when line rect is not valid: Calligra: 3.0.
Thu, Dec 28, 7:17 PM · Calligra: 3.0
anthonyfieroni updated the diff for D9497: [textlayout] Do not enter infinite loop when line rect is not valid.

Revert qFuzzyIsNull, other part of project don't use it.

Thu, Dec 28, 7:16 PM · Calligra: 3.0

Wed, Dec 27

anthonyfieroni added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

I don't want to bother you but even last attempt can have race condition. If slotVerifyChecksums is called while future is not finished read/write cache can occur.
https://paste.kde.org/pdqu2bywp/sccbzb
I'm not using mutex at all. You can always use a signal/slot between threads, if receiver remains the same, cause slot will be called in its thread, synchronously.

Wed, Dec 27, 9:16 PM · Frameworks
anthonyfieroni added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

Even more future watcher will not needed anymore, if you use blocked mapper.

Wed, Dec 27, 6:40 PM · Frameworks
anthonyfieroni added inline comments to D8536: Add more hashing algorithms to KPropertiesDialog.
Wed, Dec 27, 6:39 PM · Frameworks
anthonyfieroni added inline comments to D8536: Add more hashing algorithms to KPropertiesDialog.
Wed, Dec 27, 6:30 PM · Frameworks
anthonyfieroni added inline comments to D8536: Add more hashing algorithms to KPropertiesDialog.
Wed, Dec 27, 4:58 PM · Frameworks
anthonyfieroni added inline comments to D8536: Add more hashing algorithms to KPropertiesDialog.
Wed, Dec 27, 9:26 AM · Frameworks

Tue, Dec 26

anthonyfieroni added reviewers for D9506: milti-screen sleep fix: sebas, drosca.
Tue, Dec 26, 6:32 PM · Plasma

Sun, Dec 24

anthonyfieroni created D9497: [textlayout] Do not enter infinite loop when line rect is not valid.
Sun, Dec 24, 8:41 AM · Calligra: 3.0

Fri, Dec 22

anthonyfieroni committed R114:095196ca6438: [comic] Fix update interval (authored by anthonyfieroni).
[comic] Fix update interval
Fri, Dec 22, 2:55 PM
anthonyfieroni closed D9338: [comic] Fix comic updater time interval.
Fri, Dec 22, 2:55 PM · Plasma
anthonyfieroni committed R120:acd7034952bc: [widgetexplorer] Fix trying to show deleted dialog (authored by anthonyfieroni).
[widgetexplorer] Fix trying to show deleted dialog
Fri, Dec 22, 2:37 PM
anthonyfieroni closed D9479: [widgetexplorer] Fix trying to show deleted dialog.
Fri, Dec 22, 2:37 PM · Plasma
anthonyfieroni added inline comments to D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed".
Fri, Dec 22, 2:21 PM · Plasma
anthonyfieroni added inline comments to D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed".
Fri, Dec 22, 2:19 PM · Plasma
anthonyfieroni updated the diff for D9479: [widgetexplorer] Fix trying to show deleted dialog.

Remove entire destructor.

Fri, Dec 22, 2:11 PM · Plasma
anthonyfieroni created D9479: [widgetexplorer] Fix trying to show deleted dialog.
Fri, Dec 22, 2:06 PM · Plasma
anthonyfieroni added a comment to D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed".
In D9473#182455, @fvogt wrote:

Yes it is. Reverting it you will not fix anything. Please explain step-by-step what not working.

"Download new widgets" -> Either plasmashell crashes instantly or the dialog does not show up and plasmashell crashes on the next click.

Fri, Dec 22, 1:39 PM · Plasma
anthonyfieroni added a comment to D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed".

Deletion is needed
https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$112
https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$50
https://phabricator.kde.org/source/knewstuff/browse/master/src/downloadwidget.cpp;6de0754aa9258558a7203afc366b49984f0192eb$69
https://phabricator.kde.org/source/knewstuff/browse/master/src/downloadwidget.cpp;6de0754aa9258558a7203afc366b49984f0192eb$121
https://phabricator.kde.org/source/knewstuff/browse/master/src/core/engine.cpp;6de0754aa9258558a7203afc366b49984f0192eb$107
Save this cache to disk, otherwise not saving anything since dialog just leak.

Fri, Dec 22, 1:36 PM · Plasma
anthonyfieroni added a comment to D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed".

Yes it is. Reverting it you will not fix anything. Please explain step-by-step what not working.

Fri, Dec 22, 1:31 PM · Plasma
anthonyfieroni added inline comments to D9338: [comic] Fix comic updater time interval.
Fri, Dec 22, 1:28 PM · Plasma
anthonyfieroni updated the diff for D9338: [comic] Fix comic updater time interval.
Fri, Dec 22, 1:28 PM · Plasma

Thu, Dec 21

anthonyfieroni committed R304:6de0754aa925: Limit request cache size (authored by anthonyfieroni).
Limit request cache size
Thu, Dec 21, 6:41 PM
anthonyfieroni closed D9318: [knewstuff] Limit request cache size.
Thu, Dec 21, 6:41 PM · Frameworks
anthonyfieroni committed R241:1b90a8c10547: [kcoredirlister] Fix sub path creation (authored by anthonyfieroni).
[kcoredirlister] Fix sub path creation
Thu, Dec 21, 6:37 PM
anthonyfieroni closed D9442: [kcoredirlister] FIx sub path creation.
Thu, Dec 21, 6:37 PM · Frameworks
anthonyfieroni added a reviewer for D9338: [comic] Fix comic updater time interval: mart.
Thu, Dec 21, 9:12 AM · Plasma

Dec 20 2017

anthonyfieroni created D9442: [kcoredirlister] FIx sub path creation.
Dec 20 2017, 7:21 PM · Frameworks
anthonyfieroni added a comment to D9318: [knewstuff] Limit request cache size.

Well, if this QSet can be huge, then these conversions from QList and to QList are going to take a lot of CPU.
Are you sure it wouldn't be much faster to do a linear search at append time, in exchange for saving all those temporary-containers conversions?

Dec 20 2017, 8:30 AM · Frameworks
anthonyfieroni updated the diff for D9318: [knewstuff] Limit request cache size.
Dec 20 2017, 8:28 AM · Frameworks

Dec 19 2017

anthonyfieroni added inline comments to D9399: Fix crash, presumably since Qt 5.10?.
Dec 19 2017, 5:52 AM · Frameworks

Dec 18 2017

anthonyfieroni added inline comments to D9399: Fix crash, presumably since Qt 5.10?.
Dec 18 2017, 6:56 PM · Frameworks
anthonyfieroni added inline comments to D9399: Fix crash, presumably since Qt 5.10?.
Dec 18 2017, 5:44 PM · Frameworks
anthonyfieroni added a comment to D9338: [comic] Fix comic updater time interval.

I plan to commit it this week, please review it, does something is not correct?

Dec 18 2017, 12:24 PM · Plasma
anthonyfieroni added a comment to D9318: [knewstuff] Limit request cache size.

Any objections?

Dec 18 2017, 12:22 PM · Frameworks
anthonyfieroni added a reviewer for D9388: Fix queued connection error: graesslin.

After this
Martin, is this correct?
It looks generic do it in applet.

Dec 18 2017, 6:17 AM · Plasma

Dec 17 2017

anthonyfieroni added a comment to D9338: [comic] Fix comic updater time interval.

Ping

Dec 17 2017, 3:45 AM · Plasma

Dec 16 2017

anthonyfieroni added a comment to D7528: Kontact: iconsidepane spacing between icons (for Qt5.9.1).


I don't get it. Are you using Wayland?

Dec 16 2017, 4:12 PM · KDE PIM

Dec 15 2017

anthonyfieroni added a comment to D9289: KCompletionBox: restore proper layering behaviour on Mac.
In D9289#179901, @rjvbb wrote:

Did you try either of your suggestions yourself? It'd be more efficient if you didn't ask me to try all kinds of alternatives that don't work on your end ;)

Dec 15 2017, 3:15 PM · Frameworks
anthonyfieroni added inline comments to D9289: KCompletionBox: restore proper layering behaviour on Mac.
Dec 15 2017, 1:26 PM · Frameworks
anthonyfieroni added a reviewer for D9341: Port kprinter4 to Qt 5/KDE 5: KDE Applications.
Dec 15 2017, 7:55 AM

Dec 14 2017

anthonyfieroni added a comment to D9318: [knewstuff] Limit request cache size.

Technically no, since it doesn't change the size of the class itself (and requestCache is private and isn't used in any inline method).

You are right, size will not change.

Dec 14 2017, 7:02 PM · Frameworks
anthonyfieroni created D9338: [comic] Fix comic updater time interval.
Dec 14 2017, 6:56 PM · Plasma
anthonyfieroni updated the diff for D9318: [knewstuff] Limit request cache size.

Use QSet instead of QList

Dec 14 2017, 6:31 PM · Frameworks
anthonyfieroni committed R241:c72f8e4b0ca0: Fix creation of paths (authored by anthonyfieroni).
Fix creation of paths
Dec 14 2017, 6:21 PM
anthonyfieroni closed D9290: [kio] Fix create path.
Dec 14 2017, 6:21 PM · Frameworks
anthonyfieroni added a comment to D9318: [knewstuff] Limit request cache size.

KNewStuff does not use d pointers so changing QHash<QString, EntryInternal::List> to QHash<QString, QSet<EntryInternal>> will result in binary incomparability, no?

Dec 14 2017, 9:46 AM · Frameworks

Dec 13 2017

anthonyfieroni created D9318: [knewstuff] Limit request cache size.
Dec 13 2017, 9:04 PM · Frameworks
anthonyfieroni updated the diff for D9290: [kio] Fix create path.
Dec 13 2017, 8:39 AM · Frameworks
anthonyfieroni added inline comments to D9290: [kio] Fix create path.
Dec 13 2017, 7:32 AM · Frameworks
anthonyfieroni updated the diff for D9290: [kio] Fix create path.

Rename function, remove variadic template, it still not needed

Dec 13 2017, 5:38 AM · Frameworks
anthonyfieroni added inline comments to D9271: Fixed memory leak in new_argv.
Dec 13 2017, 5:21 AM · Plasma

Dec 12 2017

anthonyfieroni updated the diff for D9290: [kio] Fix create path.

Helper function in all over places.

Dec 12 2017, 7:39 PM · Frameworks