anthonyfieroni (Anthony Fieroni)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2015, 10:58 AM (180 w, 3 d)
Availability
Available

Recent Activity

Tue, Feb 12

anthonyfieroni added a comment to D18963: Improve KoModeBox display in horizontal Mode.

It's good to +1

Tue, Feb 12, 3:56 PM · Calligra: 3.0
anthonyfieroni added a reviewer for D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*: kossebau.
Tue, Feb 12, 3:31 PM · Plasma

Thu, Feb 7

anthonyfieroni added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

Ok, so @trmdi you can apply exactly David suggest and discard D18804, i've test it and it works. Push it in 5.15 not 5.16 that's bug fix not feature. 5.12 can be also interested path as LTS version.

Thu, Feb 7, 4:15 PM · Plasma
anthonyfieroni added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

@davidedmundson it works. I really don't know that sharing model between contexts cause a such behavior. It's caused by some ref counting ? Did you know why, it's internal Qt issue that we can fix or it's expected ?

Thu, Feb 7, 12:24 PM · Plasma
anthonyfieroni added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in.

Thu, Feb 7, 9:25 AM · Plasma
anthonyfieroni added a comment to D18804: Workaround for the bug 393630 - Framework part.

Did you understand why it happen?

Thu, Feb 7, 8:06 AM · Frameworks
anthonyfieroni added a reviewer for D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency: davidedmundson.
Thu, Feb 7, 5:01 AM · Frameworks

Wed, Feb 6

anthonyfieroni added a reviewer for D18781: Fix SQLite backend foreign key PRAGMAs: dvratil.
Wed, Feb 6, 9:26 AM · KDE PIM
anthonyfieroni added a comment to D18781: Fix SQLite backend foreign key PRAGMAs.

I notice it, because i use SQLite backend, LGTM to me +1

Wed, Feb 6, 9:26 AM · KDE PIM

Sat, Feb 2

anthonyfieroni added inline comments to D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Sat, Feb 2, 6:06 PM · Build System, Frameworks
anthonyfieroni committed R318:83912a6de826: Fix member initialization (authored by anthonyfieroni).
Fix member initialization
Sat, Feb 2, 5:48 PM
anthonyfieroni committed R318:ec29cfff2017: [versioncontrolobserver] Update working directory on tab activation (authored by anthonyfieroni).
[versioncontrolobserver] Update working directory on tab activation
Sat, Feb 2, 5:38 PM
anthonyfieroni closed D18605: [versioncontrolobserver] Update working directory on tab activation.
Sat, Feb 2, 5:38 PM · Dolphin

Thu, Jan 31

anthonyfieroni updated the diff for D18605: [versioncontrolobserver] Update working directory on tab activation.
Thu, Jan 31, 5:18 AM · Dolphin

Wed, Jan 30

anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

This solution is Qt <5.12 friendly

Wed, Jan 30, 12:40 PM · Calligra: 3.0

Tue, Jan 29

anthonyfieroni updated the diff for D18605: [versioncontrolobserver] Update working directory on tab activation.

Let's make public slot approach.

Tue, Jan 29, 6:56 PM · Dolphin
anthonyfieroni added a comment to D18605: [versioncontrolobserver] Update working directory on tab activation.

VersionControlObserver is exported class changing its constructor type parameter can brake ABI, but does it user of ? In other hand addition of public slot is ABI comfortable, so another approach can be better solution.

Tue, Jan 29, 6:45 PM · Dolphin
anthonyfieroni requested review of D18605: [versioncontrolobserver] Update working directory on tab activation.
Tue, Jan 29, 6:41 PM · Dolphin
anthonyfieroni committed R318:9a9fbae98814: [versioncontrolobserver] Do not use static plugin objects (authored by anthonyfieroni).
[versioncontrolobserver] Do not use static plugin objects
Tue, Jan 29, 6:28 PM
anthonyfieroni closed D17640: [versioncontrolobserver] Do not use static plugin objects.
Tue, Jan 29, 6:28 PM · Dolphin
anthonyfieroni added a comment to D18089: KLauncher: handle processes exiting without error.

+1

Tue, Jan 29, 8:56 AM · Frameworks
anthonyfieroni added inline comments to D17640: [versioncontrolobserver] Do not use static plugin objects.
Tue, Jan 29, 6:35 AM · Dolphin

Sat, Jan 26

anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

So just don't call slotFilePrint connect loadCompleted to slotFilePrint. When openDocumentInternal downloads the document it fires signal of finish, just connect to slot of opened it.

Sat, Jan 26, 5:24 PM · Calligra: 3.0
anthonyfieroni added a comment to D18249: [datamodel] Rework items insert/remove.

I investigate on testing this patch, it does not fix systray issue, to discard it?

Sat, Jan 26, 8:30 AM · Frameworks

Fri, Jan 25

anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

Probably we need to start printing in a slot connected to KoMainWindow::loadCompleted() instead.
And to be safe, we also need to handle loadCanceled().

Fri, Jan 25, 9:04 AM · Calligra: 3.0

Mon, Jan 21

anthonyfieroni updated subscribers of D17640: [versioncontrolobserver] Do not use static plugin objects.

@alexeymin, can you try this patch as well, it's pretty annoying to have 5+ versioned tabs, error in one to be shown in others.

Mon, Jan 21, 7:26 PM · Dolphin
anthonyfieroni committed R449:9f8f6c152116: [gitpushdialog] Check GitWrapper::branches index validity (authored by anthonyfieroni).
[gitpushdialog] Check GitWrapper::branches index validity
Mon, Jan 21, 7:23 PM
anthonyfieroni closed D18289: [gitpushgialog] Check index validity.
Mon, Jan 21, 7:23 PM
anthonyfieroni added a comment to D18289: [gitpushgialog] Check index validity.

branches is a QStringList, so, we could also check that currentBranchIndex < branches.size() in condition, if it is all about bounds checking.

Mon, Jan 21, 7:18 PM
anthonyfieroni added a comment to D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action.

+1

Mon, Jan 21, 11:55 AM · Frameworks

Sun, Jan 20

anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

ping, issue is real and annoying.

Sun, Jan 20, 5:27 PM · Dolphin
anthonyfieroni added a comment to D18289: [gitpushgialog] Check index validity.

ping

Sun, Jan 20, 5:26 PM

Jan 16 2019

anthonyfieroni added a comment to D17882: Abort updateWindowTitle and activeViewChanged if not changed..

+1 it looks good to me.

Jan 16 2019, 2:22 PM · Dolphin
anthonyfieroni updated the diff for D18249: [datamodel] Rework items insert/remove.
Jan 16 2019, 1:02 PM · Frameworks
anthonyfieroni added inline comments to D18249: [datamodel] Rework items insert/remove.
Jan 16 2019, 12:57 PM · Frameworks
anthonyfieroni added inline comments to D18249: [datamodel] Rework items insert/remove.
Jan 16 2019, 9:34 AM · Frameworks
anthonyfieroni requested review of D18289: [gitpushgialog] Check index validity.
Jan 16 2019, 6:14 AM
anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

Sorry but I can't reproduce the bug you put in the commit message.

I tried to do a git checkout on a dirty repo, but the error message only shows up in the versioned tab (not in all tabs).

Jan 16 2019, 5:48 AM · Dolphin
anthonyfieroni updated the summary of D17640: [versioncontrolobserver] Do not use static plugin objects.
Jan 16 2019, 5:47 AM · Dolphin

Jan 15 2019

anthonyfieroni added a comment to D17882: Abort updateWindowTitle and activeViewChanged if not changed..

Searchbar propagates events even it's not visible, you can add check for visibility in focusin event.

Jan 15 2019, 4:03 PM · Dolphin

Jan 14 2019

anthonyfieroni requested review of D18249: [datamodel] Rework items insert/remove.
Jan 14 2019, 6:31 PM · Frameworks
anthonyfieroni added inline comments to D17640: [versioncontrolobserver] Do not use static plugin objects.
Jan 14 2019, 6:25 PM · Dolphin
anthonyfieroni committed R122:c40b8ba3b66d: [dimdisplay] Waits a bit display to wake-up (authored by anthonyfieroni).
[dimdisplay] Waits a bit display to wake-up
Jan 14 2019, 6:17 PM
anthonyfieroni closed D17874: [dimdisplay] Effectively waits display to wake-up.
Jan 14 2019, 6:17 PM · Plasma
anthonyfieroni committed R120:0885170daf56: [systemtray] Workaround component creation (authored by anthonyfieroni).
[systemtray] Workaround component creation
Jan 14 2019, 6:14 PM
anthonyfieroni closed D16890: [systemtray] Keep config entries after modifying.
Jan 14 2019, 6:14 PM · Plasma

Jan 12 2019

anthonyfieroni accepted D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui.
Jan 12 2019, 5:37 PM · Frameworks
anthonyfieroni added inline comments to D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui.
Jan 12 2019, 1:02 PM · Frameworks
anthonyfieroni added inline comments to D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui.
Jan 12 2019, 5:24 AM · Frameworks

Jan 11 2019

anthonyfieroni added inline comments to D18164: Review KateGotoBar.
Jan 11 2019, 6:49 AM · Frameworks, Kate

Jan 10 2019

anthonyfieroni added inline comments to D18164: Review KateGotoBar.
Jan 10 2019, 7:16 PM · Frameworks, Kate
anthonyfieroni added a comment to D18149: Share Plasma::Theme instances between multiple ColorScope.

Now in multi-thread environment will have problems especially on actualTheme(), no?

Jan 10 2019, 11:52 AM · Frameworks

Jan 9 2019

anthonyfieroni added a comment to D14241: [phonon-gstreamer] Do not trigger paused state on 0 percentage.

If you mean in 4.9 - no, i just not realize that.

Jan 9 2019, 12:37 PM

Jan 5 2019

anthonyfieroni updated the diff for D17640: [versioncontrolobserver] Do not use static plugin objects.

Apparently it has a problem, if 2 or more versioned tabs are open (in distinct git directories) switching between does not update status/actions. It looks like in dolphin-plugin is used static object as well. So after all we don't want error in one tab to be multiplied to all opened, i've seen it often, since i'm using plugin daily, so easy fix is to update directory on tab activated, since observer has only private slots i'm using old syntax did you have better idea?

Jan 5 2019, 10:59 PM · Dolphin

Jan 4 2019

anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

I want to have this in 18.12.1, i really not prefer to have custom changes against upstream.

Jan 4 2019, 9:29 AM · Dolphin

Jan 3 2019

anthonyfieroni added a comment to D17874: [dimdisplay] Effectively waits display to wake-up.

The problem is too specific, it happen when dpms is activated after dimm display is setted screen to 0, if dimm option is not checked it works correct to me.

Jan 3 2019, 4:38 PM · Plasma
anthonyfieroni added a comment to D17874: [dimdisplay] Effectively waits display to wake-up.

Video can't handle it. (i've think about screencast but can be recorded by a phone)

Jan 3 2019, 4:17 PM · Plasma

Jan 2 2019

anthonyfieroni added a comment to D17874: [dimdisplay] Effectively waits display to wake-up.

Does someone test it, @thsurrel ?

Jan 2 2019, 5:53 PM · Plasma
anthonyfieroni committed R40:806044f6a9d1: [projectplugin] Correct code index widget show (authored by anthonyfieroni).
[projectplugin] Correct code index widget show
Jan 2 2019, 4:21 PM
anthonyfieroni closed D17870: [projectplugin] Correct code index widget show.
Jan 2 2019, 4:21 PM · Kate
anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

Ping, we can remove parent but i don't see advantage of this.

Jan 2 2019, 4:11 PM · Dolphin
anthonyfieroni added a comment to D17870: [projectplugin] Correct code index widget show.

Ping, now on Alt+1 or right click ->project -> lookup does not show correct tab

Jan 2 2019, 11:32 AM · Kate

Dec 30 2018

anthonyfieroni added inline comments to D17640: [versioncontrolobserver] Do not use static plugin objects.
Dec 30 2018, 8:04 PM · Dolphin
anthonyfieroni requested review of D17874: [dimdisplay] Effectively waits display to wake-up.
Dec 30 2018, 4:40 PM · Plasma
anthonyfieroni requested review of D17870: [projectplugin] Correct code index widget show.
Dec 30 2018, 2:39 PM · Kate
anthonyfieroni closed D16918: [dimdisplay] Do not change screen brightness on invalid values.
Dec 30 2018, 8:48 AM · Plasma
anthonyfieroni committed R122:6f350690723a: [dimdisplay] Do not change screen brightness on invalid values (authored by anthonyfieroni).
[dimdisplay] Do not change screen brightness on invalid values
Dec 30 2018, 8:48 AM
anthonyfieroni committed R114:2ae3f4cfc7be: Merge branch 'Plasma/5.14' of git://anongit.kde.org/kdeplasma-addons into… (authored by anthonyfieroni).
Merge branch 'Plasma/5.14' of git://anongit.kde.org/kdeplasma-addons into…
Dec 30 2018, 7:54 AM
anthonyfieroni committed R114:37d5fc1933c7: [comic dataengine] Do not cache identifier only requests (authored by anthonyfieroni).
[comic dataengine] Do not cache identifier only requests
Dec 30 2018, 7:54 AM
anthonyfieroni committed R114:1e12a9df8a71: [comic] Update comic strip on current identifier only (authored by anthonyfieroni).
[comic] Update comic strip on current identifier only
Dec 30 2018, 7:54 AM
anthonyfieroni committed R114:e909e66b3008: [comic] Fix max cache limit (authored by anthonyfieroni).
[comic] Fix max cache limit
Dec 30 2018, 7:54 AM
anthonyfieroni committed R114:28493251921b: [comicupdater] Fix last day check (authored by anthonyfieroni).
[comicupdater] Fix last day check
Dec 30 2018, 7:54 AM
anthonyfieroni closed D16873: [comic] Request current identifier on date changed.
Dec 30 2018, 7:54 AM · Plasma
anthonyfieroni committed R114:fd19c36ec4e4: [comic] Request current identifier on data change (authored by anthonyfieroni).
[comic] Request current identifier on data change
Dec 30 2018, 7:54 AM
anthonyfieroni closed D16856: [comicupdater] Fix last day check.
Dec 30 2018, 7:54 AM · Plasma

Dec 29 2018

anthonyfieroni added inline comments to D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.
Dec 29 2018, 7:38 PM · Frameworks, Kate
anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

@elvisangelaccio i want to go ahead with this patch.

Dec 29 2018, 7:55 AM · Dolphin

Dec 27 2018

anthonyfieroni added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

If someone steal events it's not problem of the patch, similar patch as D15612 should be applied for that view.

Dec 27 2018, 9:30 PM · Gwenview
anthonyfieroni updated the diff for D17640: [versioncontrolobserver] Do not use static plugin objects.

Use parent in createInstance

Dec 27 2018, 12:45 PM · Dolphin
anthonyfieroni added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

As i mention before, that's not a patch issues.

Dec 27 2018, 12:43 PM · Gwenview
anthonyfieroni added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

@ngraham, you can test it.

Dec 27 2018, 6:17 AM · Gwenview

Dec 26 2018

anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

ping

Dec 26 2018, 1:54 PM · Dolphin

Dec 21 2018

anthonyfieroni added inline comments to D17459: SearchBar: Add Cancel button to stop long running tasks.
Dec 21 2018, 3:22 PM · Frameworks, Kate

Dec 20 2018

anthonyfieroni added inline comments to D17459: SearchBar: Add Cancel button to stop long running tasks.
Dec 20 2018, 7:54 PM · Frameworks, Kate
anthonyfieroni added inline comments to D17459: SearchBar: Add Cancel button to stop long running tasks.
Dec 20 2018, 3:19 PM · Frameworks, Kate
anthonyfieroni added inline comments to D17459: SearchBar: Add Cancel button to stop long running tasks.
Dec 20 2018, 6:50 AM · Frameworks, Kate

Dec 19 2018

anthonyfieroni added a comment to D17683: [kpmcore] S.M.A.R.T. attribute 178 is same as 179.

Can you push it, i've some problems - the change is small, thank you.

Dec 19 2018, 1:57 PM
anthonyfieroni requested review of D17683: [kpmcore] S.M.A.R.T. attribute 178 is same as 179.
Dec 19 2018, 12:06 PM
anthonyfieroni updated the diff for D17555: [phonon-gstreamer] Put resetting in false state on new Source.

Remove locking inside media object
Still has a deadlock inside gstreamer

Thread 1 "dragon" received signal SIGINT, Interrupt.
0x00007ffff11f541c in __lll_lock_wait () from /lib/libpthread.so.0
(gdb) bt
#0  0x00007ffff11f541c in __lll_lock_wait () at /lib/libpthread.so.0
#1  0x00007ffff11eeb96 in pthread_mutex_lock () at /lib/libpthread.so.0
#2  0x00007fffc88d8001 in  () at /usr/lib/gstreamer-1.0/libgstplayback.so
#3  0x00007fffdb6f2d07 in gst_element_query () at /usr/lib/libgstreamer-1.0.so.0
#4  0x00007fffdb74a6ea in gst_element_query_position () at /usr/lib/libgstreamer-1.0.so.0
#5  0x00007fffdba41034 in Phonon::Gstreamer::Pipeline::position() const () at /usr/lib/qt5/plugins/phonon4qt5_backend/phonon_gstreamer.so
#6  0x00007fffdba32b5e in Phonon::Gstreamer::MediaObject::emitTick() [clone .part.17] () at /usr/lib/qt5/plugins/phonon4qt5_backend/phonon_gstreamer.so
#7  0x00007fffdba35c4f in Phonon::Gstreamer::MediaObject::qt_static_metacall(QObject*, QMetaObject::C--Type <RET> for more, q to quit, c to continue with all, int, void**) () at /usr/lib/qt5/plugins/phonon4qt5_backend/phonon_gstreamer.so
#8  0x00007ffff3b37e22 in QObject::event(QEvent*) () at /usr/lib/libQt5Core.so.5
#9  0x00007ffff4589e3c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /usr/lib/libQt5Widgets.so.5
#10 0x00007ffff4590f5f in QApplication::notify(QObject*, QEvent*) () at /usr/lib/libQt5Widgets.so.5
#11 0x00007ffff3b098f8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /usr/lib/libQt5Core.so.5
#12 0x00007ffff3b0c295 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () at /usr/lib/libQt5Core.so.5
#13 0x00007ffff3b61313 in  () at /usr/lib/libQt5Core.so.5
#14 0x00007fffec5002f7 in g_main_context_dispatch () at /usr/lib/libglib-2.0.so.0
#15 0x00007fffec500508 in  () at /usr/lib/libglib-2.0.so.0
#16 0x00007fffec50058c in g_main_context_iteration () at /usr/lib/libglib-2.0.so.0
#17 0x00007ffff3b609af in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>)() at /usr/lib/libQt5Core.so.5
#18 0x00007fffe5f1c3b1 in  () at /usr/lib/qt5/plugins/platforms/../../../libQt5XcbQpa.so.5
#19 0x00007ffff3b081da in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/libQt5Core.so.5
#20 0x00007ffff3b10cd0 in QCoreApplication::exec() () at /usr/lib/libQt5Core.so.5
#21 0x0000000000438514 in main ()
Dec 19 2018, 8:14 AM

Dec 17 2018

anthonyfieroni added inline comments to D17617: Display error instead of silently failing when asked to create folder that already exists.
Dec 17 2018, 3:48 PM · Frameworks
anthonyfieroni requested review of D17640: [versioncontrolobserver] Do not use static plugin objects.
Dec 17 2018, 2:54 PM · Dolphin
anthonyfieroni added inline comments to D17617: Display error instead of silently failing when asked to create folder that already exists.
Dec 17 2018, 2:43 PM · Frameworks
anthonyfieroni added inline comments to D17617: Display error instead of silently failing when asked to create folder that already exists.
Dec 17 2018, 1:54 PM · Frameworks
anthonyfieroni added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

In facts that's 2 crashes, first one in ascent, second one misfit.

Dec 17 2018, 11:58 AM · Calligra: 3.0
anthonyfieroni added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

@danders you can commandeer this revision to update diff.

Dec 17 2018, 11:36 AM · Calligra: 3.0
anthonyfieroni added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Yep, it's look like same approach to mine, did you try mine or it's not correct in all cases?

Dec 17 2018, 10:58 AM · Calligra: 3.0
anthonyfieroni committed R260:9f9af42f4d70: [ThumbnailView] Fix mouse buttons handling (authored by anthonyfieroni).
[ThumbnailView] Fix mouse buttons handling
Dec 17 2018, 5:48 AM
anthonyfieroni closed D15612: [ThumbnailView] Fix mouse buttons handling.
Dec 17 2018, 5:48 AM · Gwenview

Dec 16 2018

anthonyfieroni added a comment to D16918: [dimdisplay] Do not change screen brightness on invalid values.

@broulik, @thsurrel any other ideas or to commit it?

Dec 16 2018, 9:04 AM · Plasma

Dec 14 2018

anthonyfieroni updated the diff for D17555: [phonon-gstreamer] Put resetting in false state on new Source.

Still has a problem, after aboutToFinish is emitted and queue is not empty, after setting new source paint of window freeze.

Dec 14 2018, 12:27 PM