- User Since
- Sep 1 2015, 10:58 AM (168 w, 12 h)
So i made simple script to test, it looks like the problem is that
xset dpms force off sleep 1 cat /sys/class/backlight/intel_backlight/max_brightness cat /sys/class/backlight/intel_backlight/brightness cat /sys/class/backlight/intel_backlight/actual_brightness
187 22 0
Sun, Nov 18
But for some reason, on second Entries show warnings says: cannot call createObject on null object. Looks like it is treated as local object or something.
Done. BTW I had tried to change the order of the menu entries, without success (?)
You should increase version to 84 https://phabricator.kde.org/source/kate/browse/master/kate/data/kateui.rc$3 Also you can generate diffs like git diff -U9999 > file for context to present.
Fri, Nov 16
Better not change data engine
Thu, Nov 15
Weird. If configuration window stays open, clicks in systray work correct, when it's dismissed clicks are incorrect.
Wed, Nov 14
Tue, Nov 13
Mon, Nov 12
Sat, Nov 10
But it's not only that https://phabricator.kde.org/R8:a7ee6f871af225fd5edc9458ee183604fabadc8a
Notice ~SectionLayout() and many others, you should use settings that trim whitespaces on file save. In Kate -> settings -> open/save -> Remove trailing spaces -> In entire document.
Fri, Nov 9
Please contact @bcooksley to remote all white space changes from you commit. Please be more precise when you commit, you introduce even more white spaces rather than to remove them.
Please, remove all white space changes before commit. It will be better if you test the patch some time without crash or other downsides. If you notice something wrong write here. If all is good you can commit in few days. Thank you for patch, other patches are welcome.
Can you add screenshots of horizontal and vertical version, add it to test, just to have how it looks. I see some gestures that i cannot test, did you can, touchscreen, tablet or something that this code works :)
Can you test my suggestions, it's looks good to me.
Thu, Nov 8
Config, if it's not set explicitly, <appname> + "rc" https://api.kde.org/frameworks/kconfig/html/kconfig_8cpp_source.html#l00607
Wed, Nov 7
Return QObjects, if you have problems copy linker output here.
I'm adding Krita as reviewer, because Karbon is unmaintained and I hope someone at Krita as some experience with the toolbox
Tue, Nov 6
Shift + Pg Up/Down works for me and why it will set up esc key?
Performing dynamic_cast without nullptr check is waste of time, use static_cast instead.
Sat, Nov 3
--new-window will be more readable, about me. Add braces on one line conditions, tryRise should be raise ('try' does not make sense).
Fri, Oct 26
Wed, Oct 24
@davidedmundson to commit or you have other objections?
Mon, Oct 22
When i investigate to find out why it's saved square not rectangle i suspect that code, but i'm still not absolutely sure that it's wrong. Maybe @boemann knows better. If so can we remove m_viewBound as well?
const QString fileName2 = path2.mid(path2.lastIndexOf(QLatin1Char('/')) + 1);
Oct 18 2018
Oct 16 2018
Looks good to me +1
Oct 15 2018
Oct 14 2018
KWin has itself this feature for all windows, i've use it, this can be helpful on split view, did you test it with KWin effect enabled to verify that it does not look strange/incorrect?
Oct 12 2018
Let's make some fix about that.
Oct 11 2018
Oct 9 2018
Oct 5 2018
Oct 4 2018
Also can you add parentheses over single line code and if you know better way to get impl() without duplicate calls will be great :)
Oct 2 2018
Revert unrelated changes
Mainly optimization + 1 change, maxTime is changed from 10 to 5 ms, effect looks more *smootly*, I hope someone of you to test it as well, I run it about a week on x11.
Oct 1 2018
1s file is a corner case as well as 0, cause you have always 2 positions - start and stop. In 0/1s these 2 steps just match, if you are right 0 isn't valid in 0s length file, does it?
+1 for the patch from me.
Sep 29 2018
Sep 28 2018
@tcanabrava can you add backtrace?
Small nip-tick, +1 for the patch.
Sep 27 2018
@zzag did you test it, especially on Wayland?
Sep 26 2018
Sep 25 2018
Looks good +1
Sep 24 2018
Ping, @davidedmundson let's make some change on this
Sep 23 2018
I run it with debug messages for a while, there is no leak in windows neither in stackingOrder. @zzag if you have suggest to watch some variable or container change? I can transform this review to some profiling changes, removing double lookups, const ref against copying of Pair and so on.
Sep 22 2018
Stop indicator in a minute, restart engine in 10 sec.
It looks can happen https://www.reddit.com/r/kde/comments/9hovrv/ive_been_having_this_randomly_icons_appears_to_be/
But i'm not sure that patch can handle it.
Sep 21 2018
KWin Support Information: The following information should be used when requesting support on e.g. http://forum.kde.org. It provides information about the currently running instance, which options are used, what OpenGL driver and which effects are running. Please post the information provided underneath this introductory text to a paste bin service like http://paste.kde.org instead of pasting into support threads.
Another approach: If timer expires in 2 min without result disconnect it from source and starts again for next 2 min, when it expires if try to update again by activate slotCurrentDay
Your are right, i don't have noticed it. So what i see when moving windows around (after several days usage) result in high cpu usage, looks like it preforms searching or other heavy operation.