- User Since
- Sep 1 2015, 10:58 AM (154 w, 1 d)
Tue, Aug 14
I'm aware of that it will fix the crash but functionally still will be missing, but i'll give a try.
About me when line(...) is accessed it should check for nullptr as well
It can be added an option in profile -> mouse but why someone to want disable it, he/she can predefine mouse buttons, or not use them at all, i don't know other option :)
Mon, Aug 13
Ok, +1 then.
Sun, Aug 12
Thu, Aug 9
It looks like in Browse view event is handled by pos and if mouse is over thumbnail it's selected otherwise selection is moved but unhighlighted
Wed, Aug 8
Mon, Aug 6
What fullscreen issue? Browse mode should written mouse event handling of thumbnalview that I don't want to bother.
Sun, Aug 5
About loop device it should present as well
Since you make question to new code I make for old one, did you why Device interfaces is ever used, it's look wrong and they should be empty, after all my tests, it's easy to see that they are never empty.
I'm using too.
Sat, Aug 4
It has a problems with mouse click inside ThumbnailView viewport, when forward/back works, left/right not and opposite.
Fri, Aug 3
It's not strange, if you click at main window it works, when you click in browse window it's not, that's normal.
Yeah, click in Browse window buttons are not handled, it's needed there ?
It works everywhere, i use such a mice for years (more than 5) you miss a lot :)
Update to show context
Rebase to master
Remove unrelated changes.
Thu, Aug 2
Yes, you should try it, the buttons are helpful and makes you lazy :)
Wed, Aug 1
It looks like - no
Tue, Jul 31
Fix copy-pasta bug
Mon, Jul 30
Values like 14.4, 28.8, 28.0-12.0, should be correct, how are they results?
It looks good +1
+1 from me.
Ping, anything unclear ?
Mon, Jul 23
Device(udi).interfaces() ("org.freedesktop.UDisks2.Loop", "org.freedesktop.UDisks2.Block")
Moundting by cdemu also works as expected, not without patch as is described in bug report.
Sun, Jul 22
Performing working tests
Sat, Jul 21
First tests looks good, i'll make more later
Ping, let put in this fix, what should be done?
Fri, Jul 20
Thu, Jul 19
Wed, Jul 18
It looks wrong on how it doing. When DrmOutput goes deleted m_fd is closed so fd in pageFlipHandler is invalid. Can we check /proc/<pid>/fd is valid or something ?
Jul 17 2018
Jul 15 2018
Jul 13 2018
Jul 12 2018
Jul 11 2018
Jul 9 2018
@mpyne , i'm unsure about file deletion and sync other than that it looks correct. Finding best lock algorithm can be *potential* problem, but surely it's not my best.
Jul 8 2018
Jul 7 2018
So the problem, probably, is there, i'll investigate, thanks.
Jul 6 2018
So the problem maybe not here as IconLoader loads icons but in icon writer
@davidedmundson , @dfaure who writes icon-cache.kcache in ~/.cache ?
Jul 4 2018
I'm aware that does not have an idea, what is the purpose of Predicate. What should i search in Solid::Predicate::matches?
It happen again, so it's not a threading issue
@hein when you hover grouped task in taskmanager click in thumbnail end up with broken icons, sometimes, kcache in ~/.cache is generated at same that icons are broken in plasmashell
So about docs when interface is added it will notify again for mounting, i think that's the idea behind interfaces.
So if KFilePlacesModel wants to hide, i don't see how this will break things, it only notify when udisk2 loose interface to mounted fs.
- Return early when path is empty
- Don't check for empty interfaces
Jul 3 2018
Add loop interface
Jul 1 2018
Also notice functions after https://phabricator.kde.org/source/kiconthemes/browse/master/src/kiconloader.cpp$1693 there is no guaranteed that they should be run in same thread. I manage to downgrade Qt 5.11 and upgrade again there is not broken icons after.
Furthermore if we manage to make new instance of iconloader every time it will significantly increase memory usage, it can be manage to create iconloader per thread i.e. global map that holds per thread iconloader instances, it will have downside of bigger memory usage and mutex lookup in the map.
Jun 27 2018
I have looking on https://bugs.kde.org/show_bug.cgi?id=394348 that's using same interface when ISO is umounting?
Fix icon loading issue (Dragonplayer related)
Jun 26 2018
You have done() why not use it, looks like running
- Use recursive mutex
- Unit test updated
Jun 22 2018
So, recursive mutex ?
tryLock(-1) to wait other thread to release
- Protect shared pointers as well
- DragonPlayer related icons still not shown
Fix deadlock, icon of DragonPlayer and its related is not showed, i have no idea why !?