anthonyfieroni (Anthony Fieroni)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2015, 10:58 AM (154 w, 1 d)
Availability
Available

Recent Activity

Tue, Aug 14

anthonyfieroni added a comment to D6473: Crash when replacing new lines with spaces.

I'm aware of that it will fix the crash but functionally still will be missing, but i'll give a try.

Tue, Aug 14, 2:55 PM · Kate, Frameworks
anthonyfieroni added a comment to D6473: Crash when replacing new lines with spaces.

About me when line(...) is accessed it should check for nullptr as well

Tue, Aug 14, 2:04 PM · Kate, Frameworks
anthonyfieroni added a comment to D14511: [TerminalDisplay] Handle forward/backward buttons to switch tabs.

It can be added an option in profile -> mouse but why someone to want disable it, he/she can predefine mouse buttons, or not use them at all, i don't know other option :)

Tue, Aug 14, 1:07 PM · Konsole
anthonyfieroni added inline comments to D14826: inline note interface wip #2.
Tue, Aug 14, 10:39 AM · Frameworks, Kate
anthonyfieroni added inline comments to D14822: Use QJSValue as method parameter type for the scripting interface.
Tue, Aug 14, 10:31 AM · Plasma
anthonyfieroni added a reviewer for D14661: Force reevaluation of Predicates if interfaces are removed: apol.

Since solid does not have a maintainer, you can wait for @apol or @broulik or ship it before 5.50 tagging.

Tue, Aug 14, 7:59 AM · Frameworks
anthonyfieroni added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

I found an old MS 5-button mouse at the office, so I can test with real hardware now. :)

There are two more problem I noticed, this time in View mode:

  • Repeatedly clicking fast on one of the forward or backward buttons will only change the image for every second click.

I don't think this is fixed. As far as I can see MainWindow::mouseDoubleClickEvent() is never called, only AbstractImageView::mouseDoubleClickEvent() is triggered.

Tue, Aug 14, 7:40 AM

Mon, Aug 13

anthonyfieroni abandoned D13869: [solid] Notify when interface to mounted fs is lost.

https://phabricator.kde.org/D14661

Mon, Aug 13, 4:39 AM · Frameworks
anthonyfieroni added a comment to D14661: Force reevaluation of Predicates if interfaces are removed.

Ok, +1 then.

Mon, Aug 13, 4:39 AM · Frameworks

Sun, Aug 12

anthonyfieroni added inline comments to D14661: Force reevaluation of Predicates if interfaces are removed.
Sun, Aug 12, 6:00 AM · Frameworks

Thu, Aug 9

anthonyfieroni updated the diff for D14583: [MainWindow] Navigate through mouse forward/back buttons.

It looks like in Browse view event is handled by pos and if mouse is over thumbnail it's selected otherwise selection is moved but unhighlighted

Thu, Aug 9, 6:36 PM
anthonyfieroni added inline comments to D14689: [KFileItem] Don't read directory comment on slow mounts.
Thu, Aug 9, 7:57 AM · Frameworks

Wed, Aug 8

anthonyfieroni added inline comments to D14685: [effects/sheet] Modernize code.
Wed, Aug 8, 12:13 PM · KWin

Mon, Aug 6

anthonyfieroni added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

What fullscreen issue? Browse mode should written mouse event handling of thumbnalview that I don't want to bother.

Mon, Aug 6, 8:01 PM
anthonyfieroni updated the diff for D14583: [MainWindow] Navigate through mouse forward/back buttons.
Mon, Aug 6, 6:19 PM

Sun, Aug 5

anthonyfieroni added a comment to D13869: [solid] Notify when interface to mounted fs is lost.

And thinking about it, this very likely makes your code wrong. Have you tried mounting a filesystem again after unmounting it, using via any mean implemented via solid? That is, "solid-hardware mount ...", the device notifier, ...

Sun, Aug 5, 6:54 PM · Frameworks
anthonyfieroni added a comment to D13869: [solid] Notify when interface to mounted fs is lost.

About loop device it should present as well
http://storaged.org/doc/udisks2-api/2.6.3/gdbus-org.freedesktop.UDisks2.Loop.html

Sun, Aug 5, 5:22 PM · Frameworks
anthonyfieroni added a comment to D13869: [solid] Notify when interface to mounted fs is lost.

Since you make question to new code I make for old one, did you why Device interfaces is ever used, it's look wrong and they should be empty, after all my tests, it's easy to see that they are never empty.

Sun, Aug 5, 5:11 PM · Frameworks
anthonyfieroni added a comment to D13869: [solid] Notify when interface to mounted fs is lost.

I'm using too.

Sun, Aug 5, 3:05 PM · Frameworks

Sat, Aug 4

anthonyfieroni added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

It has a problems with mouse click inside ThumbnailView viewport, when forward/back works, left/right not and opposite.

Sat, Aug 4, 8:21 AM

Fri, Aug 3

anthonyfieroni added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

It's not strange, if you click at main window it works, when you click in browse window it's not, that's normal.

Fri, Aug 3, 5:33 PM
anthonyfieroni added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

Yeah, click in Browse window buttons are not handled, it's needed there ?

Fri, Aug 3, 5:28 PM
anthonyfieroni added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

It works everywhere, i use such a mice for years (more than 5) you miss a lot :)

Fri, Aug 3, 5:11 PM
anthonyfieroni updated the diff for D14583: [MainWindow] Navigate through mouse forward/back buttons.

Update to show context

Fri, Aug 3, 4:41 PM
anthonyfieroni updated the diff for D14583: [MainWindow] Navigate through mouse forward/back buttons.

Rebase to master

Fri, Aug 3, 4:36 PM
anthonyfieroni added inline comments to D14583: [MainWindow] Navigate through mouse forward/back buttons.
Fri, Aug 3, 4:35 PM
anthonyfieroni updated the diff for D14583: [MainWindow] Navigate through mouse forward/back buttons.

Remove unrelated changes.

Fri, Aug 3, 4:30 PM
anthonyfieroni added inline comments to D14583: [MainWindow] Navigate through mouse forward/back buttons.
Fri, Aug 3, 4:28 PM
anthonyfieroni updated the test plan for D14583: [MainWindow] Navigate through mouse forward/back buttons.
Fri, Aug 3, 4:10 PM
anthonyfieroni requested review of D14583: [MainWindow] Navigate through mouse forward/back buttons.
Fri, Aug 3, 4:04 PM
anthonyfieroni added a comment to D14511: [TerminalDisplay] Handle forward/backward buttons to switch tabs.

Any chance you'd be willing to submit a similar patch to Gwenview so that you can use the mouse's back and forward buttons to navigate between images while in View mode?

Fri, Aug 3, 3:08 PM · Konsole
anthonyfieroni added inline comments to D14576: [Desktop Scripting ConfigGroup] Add more nullptr checks.
Fri, Aug 3, 10:06 AM · Plasma

Thu, Aug 2

anthonyfieroni added inline comments to D14546: [Service Runner] Look up relative entryPaths.
Thu, Aug 2, 8:55 PM · Plasma
anthonyfieroni added a comment to D13869: [solid] Notify when interface to mounted fs is lost.

For 5.49?

Thu, Aug 2, 11:59 AM · Frameworks
anthonyfieroni added a comment to D14511: [TerminalDisplay] Handle forward/backward buttons to switch tabs.

Just to clarify, this is for a mouse which have extra button on side correct?

Yes, you should try it, the buttons are helpful and makes you lazy :)

Thu, Aug 2, 4:04 AM · Konsole

Wed, Aug 1

anthonyfieroni added inline comments to D14360: Remove custom icon selection for trash.
Wed, Aug 1, 6:19 PM · Frameworks
anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

given that we no multiply with1.16 the values should be: 12*1.16, 24*1.16, no

It looks like - no

Wed, Aug 1, 11:18 AM · Calligra: 3.0

Tue, Jul 31

anthonyfieroni updated the diff for D14511: [TerminalDisplay] Handle forward/backward buttons to switch tabs.

Fix copy-pasta bug

Tue, Jul 31, 3:11 PM · Konsole
anthonyfieroni requested review of D14511: [TerminalDisplay] Handle forward/backward buttons to switch tabs.
Tue, Jul 31, 2:30 PM · Konsole
anthonyfieroni added inline comments to D14486: Update to current mdbtools.
Tue, Jul 31, 11:51 AM · KEXI
anthonyfieroni added inline comments to D14162: Figure out the escaped path list on kconfig.
Tue, Jul 31, 10:47 AM · Frameworks

Mon, Jul 30

anthonyfieroni added inline comments to D14308: [Exe Thumbnailer] Improve icon selection algorithm.
Mon, Jul 30, 4:18 PM
anthonyfieroni added inline comments to D14308: [Exe Thumbnailer] Improve icon selection algorithm.
Mon, Jul 30, 4:03 PM
anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

Values like 14.4, 28.8, 28.0-12.0, should be correct, how are they results?

Mon, Jul 30, 5:19 AM · Calligra: 3.0
anthonyfieroni added a comment to D14241: [phonon-gstreamer] Try to sync calls to gst_element_set_state.

@sitter happens every time on http://79.120.77.11:9091

Mon, Jul 30, 5:02 AM
anthonyfieroni updated the diff for D14241: [phonon-gstreamer] Try to sync calls to gst_element_set_state.
Mon, Jul 30, 5:02 AM
anthonyfieroni added a comment to D11971: Use same keyword separator for read and write.

It looks good +1

Mon, Jul 30, 4:47 AM · Calligra: 3.0
anthonyfieroni resigned from D12692: Add back magnifier to QPainter port of rectangle selection.
Mon, Jul 30, 4:46 AM · Spectacle
anthonyfieroni added inline comments to D14437: Fix QFileDialog not remembering the last visited directory..
Mon, Jul 30, 4:45 AM · Plasma
anthonyfieroni added a comment to D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too.

+1 from me.

Mon, Jul 30, 4:44 AM
anthonyfieroni added a comment to D13869: [solid] Notify when interface to mounted fs is lost.

Ping, anything unclear ?

Mon, Jul 30, 4:44 AM · Frameworks

Mon, Jul 23

anthonyfieroni added a comment to D13869: [solid] Notify when interface to mounted fs is lost.

Device(udi).interfaces() ("org.freedesktop.UDisks2.Loop", "org.freedesktop.UDisks2.Block")
interfaces ("org.freedesktop.UDisks2.Filesystem")

Mon, Jul 23, 11:57 AM · Frameworks
anthonyfieroni added inline comments to D13869: [solid] Notify when interface to mounted fs is lost.
Mon, Jul 23, 11:49 AM · Frameworks
anthonyfieroni added inline comments to D13869: [solid] Notify when interface to mounted fs is lost.
Mon, Jul 23, 11:48 AM · Frameworks
anthonyfieroni added a comment to D13869: [solid] Notify when interface to mounted fs is lost.

Moundting by cdemu also works as expected, not without patch as is described in bug report.

Mon, Jul 23, 4:42 AM · Frameworks

Sun, Jul 22

anthonyfieroni added a comment to D14241: [phonon-gstreamer] Try to sync calls to gst_element_set_state.

Any suggestions?

Sun, Jul 22, 4:44 PM
anthonyfieroni committed R8:805df2276602: Fix line percentage height (authored by anthonyfieroni).
Fix line percentage height
Sun, Jul 22, 4:41 PM
anthonyfieroni closed D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

https://cgit.kde.org/calligra.git/commit/?id=805df22766026fac22154ae89b64dad532a6cbb4

Sun, Jul 22, 4:13 PM · Calligra: 3.0
anthonyfieroni added a comment to D13869: [solid] Notify when interface to mounted fs is lost.
Performing working tests
Sun, Jul 22, 4:02 PM · Frameworks
anthonyfieroni updated the diff for D9537: [kotextlayoutarea] Make percentage line height relative to the default height.
Sun, Jul 22, 3:44 PM · Calligra: 3.0
anthonyfieroni updated the diff for D9537: [kotextlayoutarea] Make percentage line height relative to the default height.
Sun, Jul 22, 2:48 PM · Calligra: 3.0
anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

This -> https://phabricator.kde.org/source/calligra/browse/master/plugins/textshape/dialogs/ParagraphIndentSpacing.cpp$124-132 ?

Sun, Jul 22, 5:07 AM · Calligra: 3.0

Sat, Jul 21

anthonyfieroni updated the diff for D13869: [solid] Notify when interface to mounted fs is lost.

First tests looks good, i'll make more later

Sat, Jul 21, 5:52 AM · Frameworks
anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

Ping, let put in this fix, what should be done?

Sat, Jul 21, 5:50 AM · Calligra: 3.0
anthonyfieroni added a comment to D14253: avoid memory leak in slave jobs.

It's deleted in https://phabricator.kde.org/source/kio/browse/master/src/core/slaveinterface_p.h$47

Sat, Jul 21, 5:30 AM · Frameworks

Fri, Jul 20

anthonyfieroni updated the summary of D14241: [phonon-gstreamer] Try to sync calls to gst_element_set_state.
Fri, Jul 20, 7:53 AM
anthonyfieroni requested review of D14241: [phonon-gstreamer] Try to sync calls to gst_element_set_state.
Fri, Jul 20, 7:52 AM

Thu, Jul 19

anthonyfieroni added a comment to D14210: Don't remove outputs during page flip.

There's one FD for all outputs. The issue is if you remove one output.

Thu, Jul 19, 5:26 AM · KWin

Wed, Jul 18

anthonyfieroni added a comment to D14210: Don't remove outputs during page flip.

It looks wrong on how it doing. When DrmOutput goes deleted m_fd is closed so fd in pageFlipHandler is invalid. Can we check /proc/<pid>/fd is valid or something ?

Wed, Jul 18, 6:22 PM · KWin

Jul 17 2018

anthonyfieroni added inline comments to D13808: Fix KMainWindow saving incorrect widget settings.
Jul 17 2018, 6:13 AM · Frameworks

Jul 15 2018

anthonyfieroni added a reviewer for D14090: [libbreezecommon] Fix build when qreal is float: hpereiradacosta.
Jul 15 2018, 9:49 PM · Plasma

Jul 13 2018

anthonyfieroni added inline comments to D13570: Add workaround for labels with word-wrapping.
Jul 13 2018, 7:36 PM · Frameworks

Jul 12 2018

anthonyfieroni added inline comments to D14060: Clean up string casts.
Jul 12 2018, 6:52 AM · Plasma

Jul 11 2018

anthonyfieroni added inline comments to D14050: Fwupd-Backend Integration.
Jul 11 2018, 7:03 PM · Discover Software Store, Plasma

Jul 9 2018

anthonyfieroni added a comment to D13627: [KSharedDataCache] Assume lock before flush changes.

@mpyne , i'm unsure about file deletion and sync other than that it looks correct. Finding best lock algorithm can be *potential* problem, but surely it's not my best.

Jul 9 2018, 7:58 AM · Frameworks

Jul 8 2018

anthonyfieroni updated the diff for D13627: [KSharedDataCache] Assume lock before flush changes.
Jul 8 2018, 4:17 PM · Frameworks
anthonyfieroni changed the repository for D13627: [KSharedDataCache] Assume lock before flush changes from R302 KIconThemes to R244 KCoreAddons.
Jul 8 2018, 4:15 PM · Frameworks

Jul 7 2018

anthonyfieroni added a comment to D13627: [KSharedDataCache] Assume lock before flush changes.

So the problem, probably, is there, i'll investigate, thanks.

Jul 7 2018, 5:29 PM · Frameworks

Jul 6 2018

anthonyfieroni added a comment to D13627: [KSharedDataCache] Assume lock before flush changes.

https://phabricator.kde.org/source/kiconthemes/browse/master/src/kiconloader.cpp$603
So the problem maybe not here as IconLoader loads icons but in icon writer
@davidedmundson , @dfaure who writes icon-cache.kcache in ~/.cache ?

Jul 6 2018, 1:05 PM · Frameworks

Jul 4 2018

anthonyfieroni added a comment to D13869: [solid] Notify when interface to mounted fs is lost.

I'm aware that does not have an idea, what is the purpose of Predicate. What should i search in Solid::Predicate::matches?

Jul 4 2018, 3:55 PM · Frameworks
anthonyfieroni added a reviewer for D13627: [KSharedDataCache] Assume lock before flush changes: hein.

It happen again, so it's not a threading issue
@hein when you hover grouped task in taskmanager click in thumbnail end up with broken icons, sometimes, kcache in ~/.cache is generated at same that icons are broken in plasmashell

Jul 4 2018, 9:57 AM · Frameworks
anthonyfieroni added a comment to D13869: [solid] Notify when interface to mounted fs is lost.

So about docs when interface is added it will notify again for mounting, i think that's the idea behind interfaces.

Jul 4 2018, 7:31 AM · Frameworks
anthonyfieroni added a comment to D13869: [solid] Notify when interface to mounted fs is lost.

So if KFilePlacesModel wants to hide, i don't see how this will break things, it only notify when udisk2 loose interface to mounted fs.

Jul 4 2018, 7:27 AM · Frameworks
anthonyfieroni added inline comments to D13869: [solid] Notify when interface to mounted fs is lost.
Jul 4 2018, 4:15 AM · Frameworks
anthonyfieroni updated the diff for D13869: [solid] Notify when interface to mounted fs is lost.
  1. Return early when path is empty
  2. Don't check for empty interfaces
Jul 4 2018, 4:15 AM · Frameworks

Jul 3 2018

anthonyfieroni updated the diff for D13869: [solid] Notify when interface to mounted fs is lost.

Add loop interface

Jul 3 2018, 2:42 PM · Frameworks
anthonyfieroni updated the summary of D13869: [solid] Notify when interface to mounted fs is lost.
Jul 3 2018, 2:39 PM · Frameworks
anthonyfieroni requested review of D13869: [solid] Notify when interface to mounted fs is lost.
Jul 3 2018, 2:39 PM · Frameworks
anthonyfieroni added a reviewer for D13866: Fix ResultModel item moving: ivan.
Jul 3 2018, 11:37 AM · Frameworks
anthonyfieroni added a comment to D10342: From 100% plasma cpu usage to normal when using vivaldi.

Or perhaps is it better to try to create that cache in KServiceTypeTrader?

Jul 3 2018, 7:33 AM · Plasma

Jul 1 2018

anthonyfieroni added a comment to D13627: [KSharedDataCache] Assume lock before flush changes.

Also notice functions after https://phabricator.kde.org/source/kiconthemes/browse/master/src/kiconloader.cpp$1693 there is no guaranteed that they should be run in same thread. I manage to downgrade Qt 5.11 and upgrade again there is not broken icons after.
Furthermore if we manage to make new instance of iconloader every time it will significantly increase memory usage, it can be manage to create iconloader per thread i.e. global map that holds per thread iconloader instances, it will have downside of bigger memory usage and mutex lookup in the map.

Jul 1 2018, 11:58 AM · Frameworks

Jun 27 2018

anthonyfieroni added a comment to D13752: Build solidautoeject only on FreeBSD.

I have looking on https://bugs.kde.org/show_bug.cgi?id=394348 that's using same interface when ISO is umounting?

Jun 27 2018, 2:39 PM · Plasma
anthonyfieroni added inline comments to D13627: [KSharedDataCache] Assume lock before flush changes.
Jun 27 2018, 10:51 AM · Frameworks
anthonyfieroni updated the diff for D13627: [KSharedDataCache] Assume lock before flush changes.

Fix icon loading issue (Dragonplayer related)

Jun 27 2018, 7:56 AM · Frameworks

Jun 26 2018

anthonyfieroni added a comment to D13740: [libkwineffects] Add TimeLine helper.

You have done() why not use it, looks like running

Jun 26 2018, 4:45 PM · KWin
anthonyfieroni updated the diff for D13627: [KSharedDataCache] Assume lock before flush changes.
  • Use recursive mutex
  • Unit test updated
Jun 26 2018, 12:14 PM · Frameworks

Jun 22 2018

anthonyfieroni added a comment to D13627: [KSharedDataCache] Assume lock before flush changes.

So, recursive mutex ?

Jun 22 2018, 5:26 PM · Frameworks
anthonyfieroni updated the diff for D13627: [KSharedDataCache] Assume lock before flush changes.

tryLock(-1) to wait other thread to release

Jun 22 2018, 2:57 PM · Frameworks
anthonyfieroni updated the diff for D13627: [KSharedDataCache] Assume lock before flush changes.
  • Protect shared pointers as well
  • DragonPlayer related icons still not shown
Jun 22 2018, 10:22 AM · Frameworks
anthonyfieroni updated the diff for D13627: [KSharedDataCache] Assume lock before flush changes.

Fix deadlock, icon of DragonPlayer and its related is not showed, i have no idea why !?

Jun 22 2018, 4:46 AM · Frameworks