- User Since
- Sep 1 2015, 10:58 AM (180 w, 3 d)
Tue, Feb 12
It's good to +1
Thu, Feb 7
@davidedmundson it works. I really don't know that sharing model between contexts cause a such behavior. It's caused by some ref counting ? Did you know why, it's internal Qt issue that we can fix or it's expected ?
I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in.
Did you understand why it happen?
Wed, Feb 6
I notice it, because i use SQLite backend, LGTM to me +1
Sat, Feb 2
Thu, Jan 31
Wed, Jan 30
Tue, Jan 29
Let's make public slot approach.
VersionControlObserver is exported class changing its constructor type parameter can brake ABI, but does it user of ? In other hand addition of public slot is ABI comfortable, so another approach can be better solution.
Sat, Jan 26
So just don't call slotFilePrint connect loadCompleted to slotFilePrint. When openDocumentInternal downloads the document it fires signal of finish, just connect to slot of opened it.
I investigate on testing this patch, it does not fix systray issue, to discard it?
Fri, Jan 25
Mon, Jan 21
@alexeymin, can you try this patch as well, it's pretty annoying to have 5+ versioned tabs, error in one to be shown in others.
Sun, Jan 20
ping, issue is real and annoying.
Jan 16 2019
+1 it looks good to me.
Jan 15 2019
Searchbar propagates events even it's not visible, you can add check for visibility in focusin event.
Jan 14 2019
Jan 12 2019
Jan 11 2019
Jan 10 2019
Now in multi-thread environment will have problems especially on actualTheme(), no?
Jan 9 2019
If you mean in 4.9 - no, i just not realize that.
Jan 5 2019
Apparently it has a problem, if 2 or more versioned tabs are open (in distinct git directories) switching between does not update status/actions. It looks like in dolphin-plugin is used static object as well. So after all we don't want error in one tab to be multiplied to all opened, i've seen it often, since i'm using plugin daily, so easy fix is to update directory on tab activated, since observer has only private slots i'm using old syntax did you have better idea?
Jan 4 2019
I want to have this in 18.12.1, i really not prefer to have custom changes against upstream.
Jan 3 2019
The problem is too specific, it happen when dpms is activated after dimm display is setted screen to 0, if dimm option is not checked it works correct to me.
Video can't handle it. (i've think about screencast but can be recorded by a phone)
Jan 2 2019
Does someone test it, @thsurrel ?
Ping, we can remove parent but i don't see advantage of this.
Ping, now on Alt+1 or right click ->project -> lookup does not show correct tab
Dec 30 2018
Dec 29 2018
@elvisangelaccio i want to go ahead with this patch.
Dec 27 2018
If someone steal events it's not problem of the patch, similar patch as D15612 should be applied for that view.
Use parent in createInstance
As i mention before, that's not a patch issues.
@ngraham, you can test it.
Dec 26 2018
Dec 21 2018
Dec 20 2018
Dec 19 2018
Can you push it, i've some problems - the change is small, thank you.
Remove locking inside media object
Still has a deadlock inside gstreamer
Thread 1 "dragon" received signal SIGINT, Interrupt. 0x00007ffff11f541c in __lll_lock_wait () from /lib/libpthread.so.0 (gdb) bt #0 0x00007ffff11f541c in __lll_lock_wait () at /lib/libpthread.so.0 #1 0x00007ffff11eeb96 in pthread_mutex_lock () at /lib/libpthread.so.0 #2 0x00007fffc88d8001 in () at /usr/lib/gstreamer-1.0/libgstplayback.so #3 0x00007fffdb6f2d07 in gst_element_query () at /usr/lib/libgstreamer-1.0.so.0 #4 0x00007fffdb74a6ea in gst_element_query_position () at /usr/lib/libgstreamer-1.0.so.0 #5 0x00007fffdba41034 in Phonon::Gstreamer::Pipeline::position() const () at /usr/lib/qt5/plugins/phonon4qt5_backend/phonon_gstreamer.so #6 0x00007fffdba32b5e in Phonon::Gstreamer::MediaObject::emitTick() [clone .part.17] () at /usr/lib/qt5/plugins/phonon4qt5_backend/phonon_gstreamer.so #7 0x00007fffdba35c4f in Phonon::Gstreamer::MediaObject::qt_static_metacall(QObject*, QMetaObject::C--Type <RET> for more, q to quit, c to continue with all, int, void**) () at /usr/lib/qt5/plugins/phonon4qt5_backend/phonon_gstreamer.so #8 0x00007ffff3b37e22 in QObject::event(QEvent*) () at /usr/lib/libQt5Core.so.5 #9 0x00007ffff4589e3c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /usr/lib/libQt5Widgets.so.5 #10 0x00007ffff4590f5f in QApplication::notify(QObject*, QEvent*) () at /usr/lib/libQt5Widgets.so.5 #11 0x00007ffff3b098f8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /usr/lib/libQt5Core.so.5 #12 0x00007ffff3b0c295 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () at /usr/lib/libQt5Core.so.5 #13 0x00007ffff3b61313 in () at /usr/lib/libQt5Core.so.5 #14 0x00007fffec5002f7 in g_main_context_dispatch () at /usr/lib/libglib-2.0.so.0 #15 0x00007fffec500508 in () at /usr/lib/libglib-2.0.so.0 #16 0x00007fffec50058c in g_main_context_iteration () at /usr/lib/libglib-2.0.so.0 #17 0x00007ffff3b609af in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>)() at /usr/lib/libQt5Core.so.5 #18 0x00007fffe5f1c3b1 in () at /usr/lib/qt5/plugins/platforms/../../../libQt5XcbQpa.so.5 #19 0x00007ffff3b081da in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/libQt5Core.so.5 #20 0x00007ffff3b10cd0 in QCoreApplication::exec() () at /usr/lib/libQt5Core.so.5 #21 0x0000000000438514 in main ()
Dec 17 2018
In facts that's 2 crashes, first one in ascent, second one misfit.
@danders you can commandeer this revision to update diff.
Yep, it's look like same approach to mine, did you try mine or it's not correct in all cases?
Dec 16 2018
Dec 14 2018
Still has a problem, after aboutToFinish is emitted and queue is not empty, after setting new source paint of window freeze.