anthonyfieroni (Anthony Fieroni)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2015, 10:58 AM (115 w, 3 d)
Availability
Available

Recent Activity

Today

anthonyfieroni added a reviewer for D7335: [libraw] Increase minimal version of libraw and enable some extensions: aacid.
Fri, Nov 17, 6:03 AM
anthonyfieroni added a comment to D7335: [libraw] Increase minimal version of libraw and enable some extensions.

Anyone ?

Fri, Nov 17, 6:02 AM
anthonyfieroni committed R304:ab6a48778bbe: [knewstuff] Do not leak ImageLoader on error (authored by anthonyfieroni).
[knewstuff] Do not leak ImageLoader on error
Fri, Nov 17, 5:53 AM
anthonyfieroni closed D8811: [knewstuff] Do not leak ImageLoader on error.
Fri, Nov 17, 5:53 AM · KNewStuff, Frameworks
anthonyfieroni updated the diff for D8741: [kget] Fix a crash when opening the transfer history dialog.
Fri, Nov 17, 5:49 AM
anthonyfieroni added a comment to D7569: [kmcomposerwin] Save configuration on composer window close.

https://phabricator.kde.org/R206:c9c677e7bc06995667b4ea8f0839d178a94b1c75

Fri, Nov 17, 5:36 AM · KDE PIM: KMail, KDE PIM
anthonyfieroni committed R206:c9c677e7bc06: [komposerwin] Save configuration on window close (authored by anthonyfieroni).
[komposerwin] Save configuration on window close
Fri, Nov 17, 5:34 AM

Yesterday

anthonyfieroni added a comment to D8741: [kget] Fix a crash when opening the transfer history dialog.

Maybe sizeHint is for that but it's not a big dial, no? You can always resize at your need.

Thu, Nov 16, 11:46 AM

Wed, Nov 15

anthonyfieroni updated the diff for D8741: [kget] Fix a crash when opening the transfer history dialog.

Remove unused sizeHint.
Make resize in ShowEvent or we should have a temporary widget in TransferHistory, because resize is in base constructor before setupUi call.

Wed, Nov 15, 9:27 PM
anthonyfieroni added a comment to D8730: Fix a crash when opening the transfer history dialog.

I understand it goes to smaller :) Ok i'll make it to store geometry in rc file.

Wed, Nov 15, 7:08 PM
anthonyfieroni updated the diff for D8811: [knewstuff] Do not leak ImageLoader on error.
Wed, Nov 15, 6:40 PM · KNewStuff, Frameworks
anthonyfieroni added a comment to D8730: Fix a crash when opening the transfer history dialog.

Can you provide steps for reproduce?

Wed, Nov 15, 6:28 PM
anthonyfieroni added inline comments to D8811: [knewstuff] Do not leak ImageLoader on error.
Wed, Nov 15, 12:52 PM · KNewStuff, Frameworks
anthonyfieroni updated the diff for D8811: [knewstuff] Do not leak ImageLoader on error.
Wed, Nov 15, 12:37 PM · KNewStuff, Frameworks
anthonyfieroni added inline comments to D8623: Use QtConcurrent for populating mime type list.
Wed, Nov 15, 5:56 AM

Tue, Nov 14

anthonyfieroni updated the diff for D8811: [knewstuff] Do not leak ImageLoader on error.
Tue, Nov 14, 8:29 PM · KNewStuff, Frameworks
anthonyfieroni added inline comments to D8811: [knewstuff] Do not leak ImageLoader on error.
Tue, Nov 14, 12:25 PM · KNewStuff, Frameworks
anthonyfieroni created D8811: [knewstuff] Do not leak ImageLoader on error.
Tue, Nov 14, 5:47 AM · KNewStuff, Frameworks

Mon, Nov 13

anthonyfieroni added a comment to D7569: [kmcomposerwin] Save configuration on composer window close.

Ping

Mon, Nov 13, 4:40 AM · KDE PIM: KMail, KDE PIM

Sun, Nov 12

anthonyfieroni added a comment to D8273: Change window title when searching.

It looks good to me +1

Sun, Nov 12, 5:21 PM · Dolphin
anthonyfieroni added inline comments to D8335: flake8 as an additional code analysis tool for the Kate Editor Project addon.
Sun, Nov 12, 3:30 PM · Kate
anthonyfieroni added a comment to D8273: Change window title when searching.

Function should looks like:

void DolphinMainWindow::setUrlAsCaption(const QUrl& url)
{
    static KFilePlacesModel s_placesModel;
Sun, Nov 12, 3:02 PM · Dolphin

Sat, Nov 11

anthonyfieroni updated the diff for D8741: [kget] Fix a crash when opening the transfer history dialog.
Sat, Nov 11, 4:30 PM

Fri, Nov 10

anthonyfieroni updated the summary of D8741: [kget] Fix a crash when opening the transfer history dialog.
Fri, Nov 10, 4:43 AM
anthonyfieroni updated the summary of D8741: [kget] Fix a crash when opening the transfer history dialog.
Fri, Nov 10, 4:39 AM
anthonyfieroni removed a dependent revision for D5111: Provide demo/preview for checkable menu items: D8741: [kget] Fix a crash when opening the transfer history dialog.
Fri, Nov 10, 4:34 AM
anthonyfieroni removed a dependency for D8741: [kget] Fix a crash when opening the transfer history dialog: D5111: Provide demo/preview for checkable menu items.
Fri, Nov 10, 4:34 AM
anthonyfieroni added a dependent revision for D5111: Provide demo/preview for checkable menu items: D8741: [kget] Fix a crash when opening the transfer history dialog.
Fri, Nov 10, 4:34 AM
anthonyfieroni added dependencies for D8741: [kget] Fix a crash when opening the transfer history dialog: D5111: Provide demo/preview for checkable menu items, D8730: Fix a crash when opening the transfer history dialog.
Fri, Nov 10, 4:34 AM
anthonyfieroni added a dependent revision for D8730: Fix a crash when opening the transfer history dialog: D8741: [kget] Fix a crash when opening the transfer history dialog.
Fri, Nov 10, 4:34 AM
anthonyfieroni created D8741: [kget] Fix a crash when opening the transfer history dialog.
Fri, Nov 10, 4:32 AM

Thu, Nov 9

anthonyfieroni added inline comments to D8738: Add DBus interface to OrientationSensor and a persistent configuration.
Thu, Nov 9, 6:36 PM · KWin
anthonyfieroni added inline comments to D8730: Fix a crash when opening the transfer history dialog.
Thu, Nov 9, 2:08 PM
anthonyfieroni added inline comments to D8730: Fix a crash when opening the transfer history dialog.
Thu, Nov 9, 5:07 AM

Wed, Nov 8

anthonyfieroni added inline comments to D8730: Fix a crash when opening the transfer history dialog.
Wed, Nov 8, 7:25 PM
anthonyfieroni added a comment to D8536: Add more hashing algorithms to KPropertiesDialog.

As I mentioned, using only a combobox doesn't work, because the main functionality (= check integrity of downloaded files) is now harder to use.

In other hand moslty user check one of following algorithms i.e. when i check a downloaded file i validate sha256, so i selected it in combobox (if needed) then paste expected. In most of time *one* prefered algorithm is used.

Wed, Nov 8, 6:58 PM · Frameworks
anthonyfieroni added inline comments to D8536: Add more hashing algorithms to KPropertiesDialog.
Wed, Nov 8, 6:46 PM · Frameworks
anthonyfieroni added inline comments to D8524: Add a signal notifying a change in the names of running activities..
Wed, Nov 8, 2:34 PM · Plasma
anthonyfieroni added a comment to D8705: Remove Qt5::Widgets as a dependency.

One more place -> kselectionowner.cpp:37
Dropping can't be done before KF6 :)

Wed, Nov 8, 5:37 AM · Frameworks

Mon, Nov 6

anthonyfieroni updated the diff for D7569: [kmcomposerwin] Save configuration on composer window close.

Rebase to master

Mon, Nov 6, 9:13 AM · KDE PIM: KMail, KDE PIM
anthonyfieroni moved T6827: goal template (feel free to copy this when creating new ones) from ready for discussion to Backlog on the Goal settings 2017 board.
Mon, Nov 6, 8:31 AM · Goal settings 2017
anthonyfieroni moved T6827: goal template (feel free to copy this when creating new ones) from Backlog to ready for discussion on the Goal settings 2017 board.
Mon, Nov 6, 8:31 AM · Goal settings 2017
anthonyfieroni added inline comments to D7569: [kmcomposerwin] Save configuration on composer window close.
Mon, Nov 6, 8:11 AM · KDE PIM: KMail, KDE PIM
anthonyfieroni added a reviewer for D7569: [kmcomposerwin] Save configuration on composer window close: dfaure.
Mon, Nov 6, 8:10 AM · KDE PIM: KMail, KDE PIM

Sun, Nov 5

anthonyfieroni added a comment to D7569: [kmcomposerwin] Save configuration on composer window close.

All parts of this patch are needed. AttachmentView has parent ComposerWin who dies after kernel so it cannot use it in AttachmentView destructor. I don't see any reason to decline this patch even current implementation crashing every time at logout with corudumps log.

Sun, Nov 5, 8:05 AM · KDE PIM: KMail, KDE PIM
anthonyfieroni added a comment to D7569: [kmcomposerwin] Save configuration on composer window close.

Let's push it to master if someone has a problem with it?

Sun, Nov 5, 5:23 AM · KDE PIM: KMail, KDE PIM

Fri, Nov 3

anthonyfieroni committed R161:27c0245b1715: [resources] Nicely quit threads (authored by anthonyfieroni).
[resources] Nicely quit threads
Fri, Nov 3, 9:34 PM
anthonyfieroni closed D8561: [d_ptr] Do not harsh destroy QThread .
Fri, Nov 3, 9:33 PM · Plasma
anthonyfieroni added inline comments to D8493: Make Folder View screen aware.
Fri, Nov 3, 9:00 PM · Plasma
anthonyfieroni updated the diff for D8561: [d_ptr] Do not harsh destroy QThread .
Fri, Nov 3, 10:45 AM · Plasma

Thu, Nov 2

anthonyfieroni added inline comments to D8608: Fix crash in KAStatsFavouritesModel.
Thu, Nov 2, 4:56 AM · Plasma

Wed, Nov 1

anthonyfieroni added a comment to D8596: Fix memory leak in FolderModel::drop.

Are sure about that? Every connection is destroyed when sender or receiver dies i.e. when dropjob dies connection also, no?

Wed, Nov 1, 5:10 PM · Plasma
anthonyfieroni added a reviewer for D8596: Fix memory leak in FolderModel::drop: Plasma.
Wed, Nov 1, 5:01 PM · Plasma

Tue, Oct 31

anthonyfieroni added a comment to D8561: [d_ptr] Do not harsh destroy QThread .

With metaprogramming approach.

Tue, Oct 31, 2:02 PM · Plasma
anthonyfieroni added a comment to D8561: [d_ptr] Do not harsh destroy QThread .

Wouldn't it be cleaner to put the quit in:

Resources::Private::~Private
and/or ResourceScoreMaintainer::Private::~Private

(also I have no idea what the Resource thread is for, literally the only thing it does actually in the thread is sleep)

Tue, Oct 31, 8:35 AM · Plasma
anthonyfieroni updated the diff for D8561: [d_ptr] Do not harsh destroy QThread .

Correct patch version.

Tue, Oct 31, 8:34 AM · Plasma

Mon, Oct 30

anthonyfieroni created D8561: [d_ptr] Do not harsh destroy QThread .
Mon, Oct 30, 9:07 PM · Plasma
anthonyfieroni added a comment to D7569: [kmcomposerwin] Save configuration on composer window close.

ping? Without patch systemd still generate coredump file in /var/lib/systemd/coredumps

Mon, Oct 30, 8:10 PM · KDE PIM: KMail, KDE PIM

Sun, Oct 29

anthonyfieroni added a reviewer for D8362: Added setting to toggle drawing of title bar separator: hpereiradacosta.
Sun, Oct 29, 6:48 AM · Plasma
anthonyfieroni added a reviewer for D8541: Don't require tasks to begin with an executable file: cfeck.
Sun, Oct 29, 6:45 AM
anthonyfieroni added inline comments to D8454: Make Saved Search feature discoverable.
Sun, Oct 29, 6:20 AM · Dolphin

Sun, Oct 22

anthonyfieroni added inline comments to D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP).
Sun, Oct 22, 10:32 AM · Frameworks

Sat, Oct 21

anthonyfieroni added a comment to D7440: Turn on Dolphin icon previews by default.
In D7440#157913, @markg wrote:

I have my doubts for this one. The same block of code is now duplicated 4 times.. 3x in Dolphin, 1x in KIO.

Sat, Oct 21, 6:23 PM · Dolphin

Oct 18 2017

anthonyfieroni added inline comments to D8348: Add a section for removable devices.
Oct 18 2017, 5:02 PM · Frameworks
anthonyfieroni added inline comments to D8356: Don't use the global KConfig object on the OpenGL freeze detection thread.
Oct 18 2017, 1:27 PM · KWin
anthonyfieroni added a comment to D8227: Show total space in status bar's Free Space widget.
%1%% free
Oct 18 2017, 11:22 AM · Dolphin
anthonyfieroni added inline comments to D8347: KIO::PreviewJob::defaultPlugins() function.
Oct 18 2017, 4:38 AM · Frameworks

Oct 17 2017

anthonyfieroni added inline comments to D8065: Ensure libinput connection thread uses real time scheduling.
Oct 17 2017, 4:32 AM · Plasma
anthonyfieroni accepted D8339: Drop pre Qt5.9 changes.
Oct 17 2017, 3:29 AM · Plasma
anthonyfieroni added inline comments to D4484: external viewer support (based on Qt Assistant) in the QtHelp plugin (optional) (WIP).
Oct 17 2017, 3:16 AM · KDevelop

Oct 16 2017

anthonyfieroni added inline comments to D8333: fix some indenters from randomly invoking indent.
Oct 16 2017, 6:04 PM · Frameworks, Kate
anthonyfieroni added inline comments to D8065: Ensure libinput connection thread uses real time scheduling.
Oct 16 2017, 5:56 PM · Plasma
anthonyfieroni added inline comments to D8327: [Task Manager] Understand applications: URLs in Unity launchers.
Oct 16 2017, 10:01 AM · Plasma

Oct 15 2017

anthonyfieroni added a comment to D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips.

Baloo doesn't have active developers so you can add Aacid to accept it.

Oct 15 2017, 4:55 AM · Dolphin

Oct 14 2017

anthonyfieroni added inline comments to D8300: Added the "save selection/cut selection to file" to Edit menu.
Oct 14 2017, 7:51 PM · Kate
anthonyfieroni added inline comments to D8285: Unload poller's connection thread earlier in teardown.
Oct 14 2017, 5:57 AM · Plasma

Oct 13 2017

anthonyfieroni added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

In D7446#154790, @ngraham wrote:
I'm not sure exactly what this is referring to. Can you clarify?

Oct 13 2017, 7:58 AM · Frameworks, Dolphin
anthonyfieroni added a comment to D7569: [kmcomposerwin] Save configuration on composer window close.

Ping?

Oct 13 2017, 7:55 AM · KDE PIM: KMail, KDE PIM
anthonyfieroni added inline comments to D8243: Implement support for categories on KfilesPlacesView.
Oct 13 2017, 7:52 AM · Frameworks

Oct 12 2017

anthonyfieroni added inline comments to D8243: Implement support for categories on KfilesPlacesView.
Oct 12 2017, 7:46 PM · Frameworks
anthonyfieroni added inline comments to D8243: Implement support for categories on KfilesPlacesView.
Oct 12 2017, 7:19 PM · Frameworks
anthonyfieroni added inline comments to D8243: Implement support for categories on KfilesPlacesView.
Oct 12 2017, 7:17 PM · Frameworks
anthonyfieroni added inline comments to D8243: Implement support for categories on KfilesPlacesView.
Oct 12 2017, 6:16 PM · Frameworks
anthonyfieroni added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

You can add recent documents as an action like in Kate. Places model looks in not correct destination.

Oct 12 2017, 6:05 PM · Frameworks, Dolphin
anthonyfieroni added inline comments to D8243: Implement support for categories on KfilesPlacesView.
Oct 12 2017, 6:42 AM · Frameworks

Oct 11 2017

anthonyfieroni added a reviewer for D8243: Implement support for categories on KfilesPlacesView: dfaure.
Oct 11 2017, 1:52 PM · Frameworks
anthonyfieroni added inline comments to D7660: Fix a regression caused by changing backspace key behavior.
Oct 11 2017, 12:00 PM · Frameworks

Oct 10 2017

anthonyfieroni added inline comments to D8233: Port finite() -> std::isfinite().
Oct 10 2017, 10:59 AM · KDE Edu

Oct 9 2017

anthonyfieroni added a comment to D8213: some crash and hang fixes.

Last time i saw this code QThreadStorage allocates MySQL connection by thread but it's not destroy them thus ~ThreadInitializer() was never called.

Oct 9 2017, 6:14 PM

Oct 8 2017

anthonyfieroni added a comment to D7972: Scroll wheel and touchpad zoom in smaller increments.

I have one more suggest, sqrt is a function which will be called in every iteration so just precalculate steps

const auto minStep = sqrt(0.5);
const auto maxStep = sqrt(2.0);
Oct 8 2017, 6:14 AM

Oct 7 2017

anthonyfieroni updated the diff for D7569: [kmcomposerwin] Save configuration on composer window close.
Oct 7 2017, 4:44 AM · KDE PIM: KMail, KDE PIM

Oct 6 2017

anthonyfieroni updated the diff for D7569: [kmcomposerwin] Save configuration on composer window close.

Tested from Kontact:

  1. Close compose window - works
  2. Close Kontact with open compose window - works
  3. Do not access kernel in AttachmentView' destructor
Oct 6 2017, 7:19 PM · KDE PIM: KMail, KDE PIM

Oct 2 2017

anthonyfieroni updated the diff for D7569: [kmcomposerwin] Save configuration on composer window close.
Oct 2 2017, 8:43 PM · KDE PIM: KMail, KDE PIM
anthonyfieroni retitled D7569: [kmcomposerwin] Save configuration on composer window close from [kmkernel] Save configuration on composer window close to [kmcomposerwin] Save configuration on composer window close.
Oct 2 2017, 8:02 PM · KDE PIM: KMail, KDE PIM
anthonyfieroni added inline comments to D7569: [kmcomposerwin] Save configuration on composer window close.
Oct 2 2017, 8:01 PM · KDE PIM: KMail, KDE PIM
anthonyfieroni retitled D7569: [kmcomposerwin] Save configuration on composer window close from [kmkernel] Make world to know that kernel is about to shutting down to [kmkernel] Save configuration on composer window close.
Oct 2 2017, 8:00 PM · KDE PIM: KMail, KDE PIM
anthonyfieroni updated the diff for D7569: [kmcomposerwin] Save configuration on composer window close.
Oct 2 2017, 7:59 PM · KDE PIM: KMail, KDE PIM

Sep 28 2017

anthonyfieroni added a comment to D7928: Do not mark messages as unread immediately, makes unread/new filter unusable.

Is there a call with oldStatus -1 and did you know if oldStatus is -1 and status() returns != Read articlesModified call is correct, e.g. should it be

if (oldStatus != -1 && newStatus != Read) {
    articlesModified();
}
Sep 28 2017, 2:13 PM · KDE PIM
anthonyfieroni added a comment to D7569: [kmcomposerwin] Save configuration on composer window close.

What is not clear now?

Sep 28 2017, 7:51 AM · KDE PIM: KMail, KDE PIM
anthonyfieroni added inline comments to D7928: Do not mark messages as unread immediately, makes unread/new filter unusable.
Sep 28 2017, 7:50 AM · KDE PIM