anthonyfieroni (Anthony Fieroni)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2015, 10:58 AM (190 w, 2 d)
Availability
Available

Recent Activity

Today

anthonyfieroni added a comment to D20693: Remove pixelated border.

Will be good see how it looks in dark theme, especially dark pictures.

Thu, Apr 25, 5:49 AM · Frameworks, KNewStuff

Yesterday

anthonyfieroni added a comment to D20776: Only show tags action when baloo is enabled.

That's for right click action menu, i notice that after upgrading to 19.04, since i'm not using Baloo tags action does nothing, patch looks good it should work.

Wed, Apr 24, 2:04 PM · Baloo

Tue, Apr 9

anthonyfieroni added inline comments to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.
Tue, Apr 9, 5:12 PM · Frameworks
anthonyfieroni added inline comments to D19262: Delayed focus updates for Toplevels without surface.
Tue, Apr 9, 11:56 AM · KWin

Mar 25 2019

anthonyfieroni added a comment to D19947: systray: show a small animation on the icons when activated.
In D19947#438052, @apol wrote:

It's subtle but I quite like it.

\o/

It feels a bit inconsistent given it affects plasmoids on keyshortcut, but not on click.

Agreed, but here the bug is that on click it doesn't happen I'd say, and we'll have to go over all plasmoids I'm afraid, because they all implement a MouseArea to deal with triggering.
I was looking into introducing context menu on pressAndHold and there's a similar problem.

Mar 25 2019, 4:07 PM · Plasma

Mar 22 2019

Restricted Application added a project to D5111: Provide demo/preview for checkable menu items: Plasma.
Mar 22 2019, 1:23 PM · Plasma
anthonyfieroni added a comment to D11971: Use same keyword separator for read and write.

Ping this looks sane, anyone ?

Mar 22 2019, 1:22 PM · Calligra: 3.0
anthonyfieroni added a comment to D15763: Set correct image attributes on directory thumbnail.

What happen to this? Put it to 19.04 for testing.

Mar 22 2019, 1:21 PM · Frameworks, Dolphin

Mar 15 2019

anthonyfieroni added inline comments to D19780: Fix a todo in Information Panel, fixing two bugs.
Mar 15 2019, 1:56 PM · Dolphin

Mar 14 2019

anthonyfieroni added a reviewer for D19767: Fix malloc/delete mismatch: dfaure.
Mar 14 2019, 7:21 PM · Frameworks, Dolphin
anthonyfieroni added inline comments to D17643: Multiple Splits per Tab.
Mar 14 2019, 10:34 AM · Konsole
anthonyfieroni added reviewers for D19745: Fix system tray UI/UX & refactor: VDG, Plasma, broulik.

Video or screenshot will be helpful.

Mar 14 2019, 4:56 AM · Plasma

Mar 7 2019

anthonyfieroni added inline comments to D19327: Karbon: Enable multi page capability.
Mar 7 2019, 6:33 PM · Calligra: 3.0
anthonyfieroni added inline comments to D19588: [Notifications] Improve finished notification.
Mar 7 2019, 12:12 PM · Plasma
anthonyfieroni added inline comments to D19559: Move management of QWebEngineProfile to WebEnginePage, to avoid crash on KMail exit or viewer window close.
Mar 7 2019, 11:55 AM · KDE PIM

Mar 6 2019

anthonyfieroni added inline comments to D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption.
Mar 6 2019, 5:41 PM · Plasma

Feb 26 2019

anthonyfieroni added inline comments to D17643: Multiple Splits per Tab.
Feb 26 2019, 6:15 AM · Konsole
anthonyfieroni added reviewers for D19323: fix crash when mapping unified mailboxes to collections: dvratil, mlaurent.
Feb 26 2019, 6:05 AM · KDE PIM

Feb 22 2019

anthonyfieroni added inline comments to D19216: Karbon: Enable multi page capability.
Feb 22 2019, 2:53 PM · Calligra: 3.0
anthonyfieroni added inline comments to D19216: Karbon: Enable multi page capability.
Feb 22 2019, 1:46 PM · Calligra: 3.0
anthonyfieroni updated the diff for D14583: [MainWindow] Navigate through mouse forward/back buttons.

Test now, i can't reproduce behavior mentioned above.

Feb 22 2019, 5:55 AM · Gwenview
anthonyfieroni abandoned D18249: [datamodel] Rework items insert/remove.
Feb 22 2019, 5:30 AM · Frameworks

Feb 21 2019

anthonyfieroni added inline comments to D19194: Adjust date string height to match time string with vertical panel.
Feb 21 2019, 8:22 AM · Plasma

Feb 20 2019

anthonyfieroni added inline comments to D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Feb 20 2019, 5:35 PM · Dolphin

Feb 16 2019

anthonyfieroni added inline comments to D19036: [notifications] Lift up notification content if one line of body text droops.
Feb 16 2019, 6:29 AM · Plasma

Feb 12 2019

anthonyfieroni added a comment to D18963: Improve KoModeBox display in horizontal Mode.

It's good to +1

Feb 12 2019, 3:56 PM · Calligra: 3.0
anthonyfieroni added a reviewer for D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*: kossebau.
Feb 12 2019, 3:31 PM · Plasma

Feb 7 2019

anthonyfieroni added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

Ok, so @trmdi you can apply exactly David suggest and discard D18804, i've test it and it works. Push it in 5.15 not 5.16 that's bug fix not feature. 5.12 can be also interested path as LTS version.

Feb 7 2019, 4:15 PM · Plasma
anthonyfieroni added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

@davidedmundson it works. I really don't know that sharing model between contexts cause a such behavior. It's caused by some ref counting ? Did you know why, it's internal Qt issue that we can fix or it's expected ?

Feb 7 2019, 12:24 PM · Plasma
anthonyfieroni added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in.

Feb 7 2019, 9:25 AM · Plasma
anthonyfieroni added a comment to D18804: Workaround for the bug 393630 - Framework part.

Did you understand why it happen?

Feb 7 2019, 8:06 AM · Frameworks
anthonyfieroni added a reviewer for D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency: davidedmundson.
Feb 7 2019, 5:01 AM · Frameworks

Feb 6 2019

anthonyfieroni added a reviewer for D18781: Fix SQLite backend foreign key PRAGMAs: dvratil.
Feb 6 2019, 9:26 AM · KDE PIM
anthonyfieroni added a comment to D18781: Fix SQLite backend foreign key PRAGMAs.

I notice it, because i use SQLite backend, LGTM to me +1

Feb 6 2019, 9:26 AM · KDE PIM

Feb 2 2019

anthonyfieroni added inline comments to D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Feb 2 2019, 6:06 PM · Build System, Frameworks
anthonyfieroni committed R318:83912a6de826: Fix member initialization (authored by anthonyfieroni).
Fix member initialization
Feb 2 2019, 5:48 PM
anthonyfieroni committed R318:ec29cfff2017: [versioncontrolobserver] Update working directory on tab activation (authored by anthonyfieroni).
[versioncontrolobserver] Update working directory on tab activation
Feb 2 2019, 5:38 PM
anthonyfieroni closed D18605: [versioncontrolobserver] Update working directory on tab activation.
Feb 2 2019, 5:38 PM · Dolphin

Jan 31 2019

anthonyfieroni updated the diff for D18605: [versioncontrolobserver] Update working directory on tab activation.
Jan 31 2019, 5:18 AM · Dolphin

Jan 30 2019

anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

This solution is Qt <5.12 friendly

Jan 30 2019, 12:40 PM · Calligra: 3.0

Jan 29 2019

anthonyfieroni updated the diff for D18605: [versioncontrolobserver] Update working directory on tab activation.

Let's make public slot approach.

Jan 29 2019, 6:56 PM · Dolphin
anthonyfieroni added a comment to D18605: [versioncontrolobserver] Update working directory on tab activation.

VersionControlObserver is exported class changing its constructor type parameter can brake ABI, but does it user of ? In other hand addition of public slot is ABI comfortable, so another approach can be better solution.

Jan 29 2019, 6:45 PM · Dolphin
anthonyfieroni requested review of D18605: [versioncontrolobserver] Update working directory on tab activation.
Jan 29 2019, 6:41 PM · Dolphin
anthonyfieroni committed R318:9a9fbae98814: [versioncontrolobserver] Do not use static plugin objects (authored by anthonyfieroni).
[versioncontrolobserver] Do not use static plugin objects
Jan 29 2019, 6:28 PM
anthonyfieroni closed D17640: [versioncontrolobserver] Do not use static plugin objects.
Jan 29 2019, 6:28 PM · Dolphin
anthonyfieroni added a comment to D18089: KLauncher: handle processes exiting without error.

+1

Jan 29 2019, 8:56 AM · Frameworks
anthonyfieroni added inline comments to D17640: [versioncontrolobserver] Do not use static plugin objects.
Jan 29 2019, 6:35 AM · Dolphin

Jan 26 2019

anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

So just don't call slotFilePrint connect loadCompleted to slotFilePrint. When openDocumentInternal downloads the document it fires signal of finish, just connect to slot of opened it.

Jan 26 2019, 5:24 PM · Calligra: 3.0
anthonyfieroni added a comment to D18249: [datamodel] Rework items insert/remove.

I investigate on testing this patch, it does not fix systray issue, to discard it?

Jan 26 2019, 8:30 AM · Frameworks

Jan 25 2019

anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

Probably we need to start printing in a slot connected to KoMainWindow::loadCompleted() instead.
And to be safe, we also need to handle loadCanceled().

Jan 25 2019, 9:04 AM · Calligra: 3.0

Jan 21 2019

anthonyfieroni updated subscribers of D17640: [versioncontrolobserver] Do not use static plugin objects.

@alexeymin, can you try this patch as well, it's pretty annoying to have 5+ versioned tabs, error in one to be shown in others.

Jan 21 2019, 7:26 PM · Dolphin
anthonyfieroni committed R449:9f8f6c152116: [gitpushdialog] Check GitWrapper::branches index validity (authored by anthonyfieroni).
[gitpushdialog] Check GitWrapper::branches index validity
Jan 21 2019, 7:23 PM
anthonyfieroni closed D18289: [gitpushgialog] Check index validity.
Jan 21 2019, 7:23 PM
anthonyfieroni added a comment to D18289: [gitpushgialog] Check index validity.

branches is a QStringList, so, we could also check that currentBranchIndex < branches.size() in condition, if it is all about bounds checking.

Jan 21 2019, 7:18 PM
anthonyfieroni added a comment to D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action.

+1

Jan 21 2019, 11:55 AM · Frameworks

Jan 20 2019

anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

ping, issue is real and annoying.

Jan 20 2019, 5:27 PM · Dolphin
anthonyfieroni added a comment to D18289: [gitpushgialog] Check index validity.

ping

Jan 20 2019, 5:26 PM

Jan 16 2019

anthonyfieroni added a comment to D17882: Abort updateWindowTitle and activeViewChanged if not changed..

+1 it looks good to me.

Jan 16 2019, 2:22 PM · Dolphin
anthonyfieroni updated the diff for D18249: [datamodel] Rework items insert/remove.
Jan 16 2019, 1:02 PM · Frameworks
anthonyfieroni added inline comments to D18249: [datamodel] Rework items insert/remove.
Jan 16 2019, 12:57 PM · Frameworks
anthonyfieroni added inline comments to D18249: [datamodel] Rework items insert/remove.
Jan 16 2019, 9:34 AM · Frameworks
anthonyfieroni requested review of D18289: [gitpushgialog] Check index validity.
Jan 16 2019, 6:14 AM
anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

Sorry but I can't reproduce the bug you put in the commit message.

I tried to do a git checkout on a dirty repo, but the error message only shows up in the versioned tab (not in all tabs).

Jan 16 2019, 5:48 AM · Dolphin
anthonyfieroni updated the summary of D17640: [versioncontrolobserver] Do not use static plugin objects.
Jan 16 2019, 5:47 AM · Dolphin

Jan 15 2019

anthonyfieroni added a comment to D17882: Abort updateWindowTitle and activeViewChanged if not changed..

Searchbar propagates events even it's not visible, you can add check for visibility in focusin event.

Jan 15 2019, 4:03 PM · Dolphin

Jan 14 2019

anthonyfieroni requested review of D18249: [datamodel] Rework items insert/remove.
Jan 14 2019, 6:31 PM · Frameworks
anthonyfieroni added inline comments to D17640: [versioncontrolobserver] Do not use static plugin objects.
Jan 14 2019, 6:25 PM · Dolphin
anthonyfieroni committed R122:c40b8ba3b66d: [dimdisplay] Waits a bit display to wake-up (authored by anthonyfieroni).
[dimdisplay] Waits a bit display to wake-up
Jan 14 2019, 6:17 PM
anthonyfieroni closed D17874: [dimdisplay] Effectively waits display to wake-up.
Jan 14 2019, 6:17 PM · Plasma
anthonyfieroni committed R120:0885170daf56: [systemtray] Workaround component creation (authored by anthonyfieroni).
[systemtray] Workaround component creation
Jan 14 2019, 6:14 PM
anthonyfieroni closed D16890: [systemtray] Keep config entries after modifying.
Jan 14 2019, 6:14 PM · Plasma

Jan 12 2019

anthonyfieroni accepted D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui.
Jan 12 2019, 5:37 PM · Frameworks
anthonyfieroni added inline comments to D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui.
Jan 12 2019, 1:02 PM · Frameworks
anthonyfieroni added inline comments to D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui.
Jan 12 2019, 5:24 AM · Frameworks

Jan 11 2019

anthonyfieroni added inline comments to D18164: Review KateGotoBar.
Jan 11 2019, 6:49 AM · Frameworks, Kate

Jan 10 2019

anthonyfieroni added inline comments to D18164: Review KateGotoBar.
Jan 10 2019, 7:16 PM · Frameworks, Kate
anthonyfieroni added a comment to D18149: Share Plasma::Theme instances between multiple ColorScope.

Now in multi-thread environment will have problems especially on actualTheme(), no?

Jan 10 2019, 11:52 AM · Frameworks

Jan 9 2019

anthonyfieroni added a comment to D14241: [phonon-gstreamer] Do not trigger paused state on 0 percentage.

If you mean in 4.9 - no, i just not realize that.

Jan 9 2019, 12:37 PM

Jan 5 2019

anthonyfieroni updated the diff for D17640: [versioncontrolobserver] Do not use static plugin objects.

Apparently it has a problem, if 2 or more versioned tabs are open (in distinct git directories) switching between does not update status/actions. It looks like in dolphin-plugin is used static object as well. So after all we don't want error in one tab to be multiplied to all opened, i've seen it often, since i'm using plugin daily, so easy fix is to update directory on tab activated, since observer has only private slots i'm using old syntax did you have better idea?

Jan 5 2019, 10:59 PM · Dolphin

Jan 4 2019

anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

I want to have this in 18.12.1, i really not prefer to have custom changes against upstream.

Jan 4 2019, 9:29 AM · Dolphin

Jan 3 2019

anthonyfieroni added a comment to D17874: [dimdisplay] Effectively waits display to wake-up.

The problem is too specific, it happen when dpms is activated after dimm display is setted screen to 0, if dimm option is not checked it works correct to me.

Jan 3 2019, 4:38 PM · Plasma
anthonyfieroni added a comment to D17874: [dimdisplay] Effectively waits display to wake-up.

Video can't handle it. (i've think about screencast but can be recorded by a phone)

Jan 3 2019, 4:17 PM · Plasma

Jan 2 2019

anthonyfieroni added a comment to D17874: [dimdisplay] Effectively waits display to wake-up.

Does someone test it, @thsurrel ?

Jan 2 2019, 5:53 PM · Plasma
anthonyfieroni committed R40:806044f6a9d1: [projectplugin] Correct code index widget show (authored by anthonyfieroni).
[projectplugin] Correct code index widget show
Jan 2 2019, 4:21 PM
anthonyfieroni closed D17870: [projectplugin] Correct code index widget show.
Jan 2 2019, 4:21 PM · Kate
anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

Ping, we can remove parent but i don't see advantage of this.

Jan 2 2019, 4:11 PM · Dolphin
anthonyfieroni added a comment to D17870: [projectplugin] Correct code index widget show.

Ping, now on Alt+1 or right click ->project -> lookup does not show correct tab

Jan 2 2019, 11:32 AM · Kate

Dec 30 2018

anthonyfieroni added inline comments to D17640: [versioncontrolobserver] Do not use static plugin objects.
Dec 30 2018, 8:04 PM · Dolphin
anthonyfieroni requested review of D17874: [dimdisplay] Effectively waits display to wake-up.
Dec 30 2018, 4:40 PM · Plasma
anthonyfieroni requested review of D17870: [projectplugin] Correct code index widget show.
Dec 30 2018, 2:39 PM · Kate
anthonyfieroni closed D16918: [dimdisplay] Do not change screen brightness on invalid values.
Dec 30 2018, 8:48 AM · Plasma
anthonyfieroni committed R122:6f350690723a: [dimdisplay] Do not change screen brightness on invalid values (authored by anthonyfieroni).
[dimdisplay] Do not change screen brightness on invalid values
Dec 30 2018, 8:48 AM
anthonyfieroni committed R114:2ae3f4cfc7be: Merge branch 'Plasma/5.14' of git://anongit.kde.org/kdeplasma-addons into… (authored by anthonyfieroni).
Merge branch 'Plasma/5.14' of git://anongit.kde.org/kdeplasma-addons into…
Dec 30 2018, 7:54 AM
anthonyfieroni committed R114:37d5fc1933c7: [comic dataengine] Do not cache identifier only requests (authored by anthonyfieroni).
[comic dataengine] Do not cache identifier only requests
Dec 30 2018, 7:54 AM
anthonyfieroni committed R114:1e12a9df8a71: [comic] Update comic strip on current identifier only (authored by anthonyfieroni).
[comic] Update comic strip on current identifier only
Dec 30 2018, 7:54 AM
anthonyfieroni committed R114:e909e66b3008: [comic] Fix max cache limit (authored by anthonyfieroni).
[comic] Fix max cache limit
Dec 30 2018, 7:54 AM
anthonyfieroni committed R114:28493251921b: [comicupdater] Fix last day check (authored by anthonyfieroni).
[comicupdater] Fix last day check
Dec 30 2018, 7:54 AM
anthonyfieroni closed D16873: [comic] Request current identifier on date changed.
Dec 30 2018, 7:54 AM · Plasma
anthonyfieroni committed R114:fd19c36ec4e4: [comic] Request current identifier on data change (authored by anthonyfieroni).
[comic] Request current identifier on data change
Dec 30 2018, 7:54 AM
anthonyfieroni closed D16856: [comicupdater] Fix last day check.
Dec 30 2018, 7:54 AM · Plasma