anthonyfieroni (Anthony Fieroni)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2015, 10:58 AM (247 w, 5 d)
Availability
Available

Recent Activity

Tue, May 26

anthonyfieroni added a reviewer for D29833: Akonadi searches for file mysql-global.conf at wrong path: mlaurent.

Another approach is to remove prefix akonadi/ from all calls to the StandardDirs::locateResourceFile (second parameter):

Tue, May 26, 10:53 AM · KDE PIM

Mon, May 25

anthonyfieroni added a comment to D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag.

Wait @davidedmundson to accept it.

Mon, May 25, 2:35 PM · Frameworks

Wed, May 20

anthonyfieroni added a reviewer for D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag: davidedmundson.

So change should be fine, (https://phabricator.kde.org/source/plasma-workspace/browse/master/appmenu) since KDED loads only modules they don't know where and when qApp is instantiated.

Wed, May 20, 2:49 PM · Frameworks

Tue, May 19

anthonyfieroni added inline comments to D29391: Introduce setWindow and CloseWhenWindowActivated.
Tue, May 19, 4:41 AM · Frameworks

Mon, May 18

anthonyfieroni added a reviewer for D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag: zzag.

Is that KWin that set titlebar menus?

Mon, May 18, 3:00 PM · Frameworks
anthonyfieroni added inline comments to D29791: [kcm/kwinrules] Detect also window complete class.
Mon, May 18, 9:00 AM · KWin

Sun, May 17

anthonyfieroni added a comment to D29811: t/simplify-sending-data-through-socket.

But I'm not quite ready for 5.70 yet, that would probably mean recompiling most of KDE

Sun, May 17, 7:54 PM · Frameworks
anthonyfieroni added inline comments to D29810: Don't use the setenv function after fork.
Sun, May 17, 7:46 PM · Frameworks
anthonyfieroni added reviewers for D29807: Change Chrome API design: broulik, Plasma.

Commented code should be removed.

Sun, May 17, 5:07 PM · Plasma

Sat, May 16

anthonyfieroni added a comment to D15111: [KoUnit] Let's show pixel units.

Even for line thickness it doesn't make sense to enable it in general. the image will change if you zoom in and out.

Sat, May 16, 1:55 PM · Calligra: 3.0
anthonyfieroni added a comment to D15111: [KoUnit] Let's show pixel units.

I miss something here, the idea behind the patch is to have pixel metrics in thickness, geometry etc. @boemann i got your opinion as to have configurable pixel units, is that right?

Sat, May 16, 8:37 AM · Calligra: 3.0

Fri, May 15

anthonyfieroni added inline comments to D15111: [KoUnit] Let's show pixel units.
Fri, May 15, 8:38 AM · Calligra: 3.0
anthonyfieroni added inline comments to D15111: [KoUnit] Let's show pixel units.
Fri, May 15, 4:25 AM · Calligra: 3.0

Thu, May 14

anthonyfieroni updated the diff for D15111: [KoUnit] Let's show pixel units.

Rebase on master

Thu, May 14, 6:36 AM · Calligra: 3.0

Wed, May 13

anthonyfieroni added a comment to D29542: Refactor canvas event handling.

Thank you, i should wait ship it, but just got Dag comment as it is.

Wed, May 13, 9:53 AM · Calligra: 3.0
anthonyfieroni added a comment to D29688: Exclude all loop devices from partition and disk sensors.

Should it /var/lib/flatpak (or just /flatpak/) be included as well?

Wed, May 13, 9:52 AM · Plasma
anthonyfieroni committed R8:0126ae02e3aa: Refactor main window views (authored by anthonyfieroni).
Refactor main window views
Wed, May 13, 9:00 AM
anthonyfieroni committed R8:07e44bfb50d5: Fix canvas event handling (authored by anthonyfieroni).
Fix canvas event handling
Wed, May 13, 8:54 AM
anthonyfieroni committed R8:2258d76ae064: Fix canvas event handling (authored by anthonyfieroni).
Fix canvas event handling
Wed, May 13, 8:51 AM
anthonyfieroni closed D29542: Refactor canvas event handling.
Wed, May 13, 8:51 AM · Calligra: 3.0
anthonyfieroni added a comment to D29542: Refactor canvas event handling.

Seems fine, i'll push pageapp/flake changes as part of this review in 3.2 branch and master, refactoring main window in separate commit master only.

Wed, May 13, 7:45 AM · Calligra: 3.0

Tue, May 12

anthonyfieroni updated the diff for D29542: Refactor canvas event handling.

@danders i saw you patch on my email. d->viewportWidget->canvas()->removeEventFilter(this); fixes the issue but i still prefer all of refactoring code. Please test on all components does not have regressions.

Tue, May 12, 10:29 AM · Calligra: 3.0
anthonyfieroni retitled D29542: Refactor canvas event handling from Refactor MainWindow view to Refactor canvas event handling.
Tue, May 12, 10:26 AM · Calligra: 3.0

Mon, May 11

anthonyfieroni added a comment to D29542: Refactor canvas event handling.

We should call removeEventFilter or found exactly why signal is emitted in destructor.

Mon, May 11, 2:49 PM · Calligra: 3.0
anthonyfieroni added a comment to D29542: Refactor canvas event handling.

d->rootPart->createView(doc, this); Creates the view which parent is main window.

Mon, May 11, 9:50 AM · Calligra: 3.0
anthonyfieroni added inline comments to D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent.
Mon, May 11, 5:22 AM · Plasma

Sat, May 9

anthonyfieroni added a reviewer for D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11: zzag.
Sat, May 9, 4:56 PM · Frameworks
anthonyfieroni added inline comments to D29568: use KSycoca for updating OpenPreferredSearchTool action.
Sat, May 9, 3:48 PM · Dolphin
anthonyfieroni added inline comments to D29559: Remove obsolte and broken importer.
Sat, May 9, 12:20 PM
anthonyfieroni updated the diff for D29542: Refactor canvas event handling.

Add more context

Sat, May 9, 8:54 AM · Calligra: 3.0

Fri, May 8

anthonyfieroni requested review of D29542: Refactor canvas event handling.
Fri, May 8, 5:35 PM · Calligra: 3.0

Thu, May 7

anthonyfieroni added inline comments to D29506: rejigger lookup of services by exec.
Thu, May 7, 12:45 PM · Plasma
anthonyfieroni added inline comments to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
Thu, May 7, 10:46 AM · Spectacle
anthonyfieroni added inline comments to D29486: xdgshellclient: Allow menus from panels to take focus.
Thu, May 7, 9:19 AM · KWin
anthonyfieroni added inline comments to D25339: update lineHeight if boundingRect indicates a larger value..
Thu, May 7, 5:58 AM · Frameworks, Kate

Wed, May 6

anthonyfieroni added inline comments to D29489: [svn] Added SVN Checkout dialog..
Wed, May 6, 6:02 PM
anthonyfieroni added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

I don't see why qApp is not deleted here
https://api.kde.org/frameworks-api/frameworks-apidocs/frameworks/kdbusaddons/html/kdbusservice_8cpp_source.html#l00099

Wed, May 6, 5:37 PM · Spectacle
anthonyfieroni added inline comments to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
Wed, May 6, 5:33 PM · Spectacle

Sat, May 2

anthonyfieroni accepted D29101: KNewStuff: Fix file path and process call.

KNewstuff is framework, it has only master.

Sat, May 2, 7:01 PM · Frameworks

Apr 29 2020

anthonyfieroni added inline comments to D29242: WIP: redesign sidebar.
Apr 29 2020, 10:16 AM · Calligra: 3.0
anthonyfieroni added a comment to D29266: Windows: Handle QLocalSocket behavior gracefully.

QSignalBlocker ?

Apr 29 2020, 10:11 AM · KDE PIM
anthonyfieroni added a comment to D25714: [WIP]: Port away from deprecated KHtml.
Apr 29 2020, 6:16 AM · Calligra: 3.0
anthonyfieroni added a comment to D25714: [WIP]: Port away from deprecated KHtml.

Is this still WIP, it looks good, can we proceed?

Apr 29 2020, 6:15 AM · Calligra: 3.0
anthonyfieroni accepted D29025: Remove unneeded pixmap usage.
Apr 29 2020, 6:14 AM

Apr 28 2020

anthonyfieroni added inline comments to D29101: KNewStuff: Fix file path and process call.
Apr 28 2020, 1:49 PM · Frameworks
anthonyfieroni added a comment to D29242: WIP: redesign sidebar.

The idea is to remove some of the configuration possibility: for example only allowing the KoModeBoxDocker to be a left or right sidebar. (putting at the top and bottom was completely broken anyway so I don't think many people did it).

Apr 28 2020, 11:36 AM · Calligra: 3.0
anthonyfieroni added a comment to D29242: WIP: redesign sidebar.

I don't know why everyone wants tools to be above edit window. That's pretty old style when resolution ratio was 4:3 that's why they was arranged one above another. But i agree that it should be flexible to be horizontal or vertical as needed.

Apr 28 2020, 11:20 AM · Calligra: 3.0

Apr 27 2020

anthonyfieroni added a comment to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.

What kind of GHNS dialog you spot about? It's a service menu, right click on supported file format (deb, rpm, zst)

Apr 27 2020, 4:56 PM · Dolphin
anthonyfieroni added inline comments to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
Apr 27 2020, 3:07 PM · Dolphin
anthonyfieroni accepted D29224: [Task Manager] Avoid crash with QStringBuilder.
Apr 27 2020, 11:27 AM · Plasma
anthonyfieroni added a comment to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.

+1, well done. Wait ship it from maintainer.

Apr 27 2020, 10:51 AM · Dolphin
anthonyfieroni added a comment to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.

You can rename summary to inform that Debian, RPM and Pacman packages are supported.

Apr 27 2020, 10:18 AM · Dolphin
anthonyfieroni added inline comments to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
Apr 27 2020, 10:15 AM · Dolphin
anthonyfieroni added inline comments to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
Apr 27 2020, 7:25 AM · Dolphin
anthonyfieroni added inline comments to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
Apr 27 2020, 6:28 AM · Dolphin
anthonyfieroni added inline comments to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
Apr 27 2020, 6:08 AM · Dolphin

Apr 22 2020

anthonyfieroni added a comment to D29028: feat(wayland): add Wrapland plugin.
In D29028#653192, @apol wrote:

I don't really see why we'd want to support something that is not offering ABI stability and doesn't push Plasma in any direction.

It is offering in the same way ABI stability as most other components of Plasma, i.e. until a new minor Plasma release.

Apr 22 2020, 10:26 AM · Plasma

Apr 20 2020

anthonyfieroni added inline comments to D28785: Don't request blur when panel is opaque.
Apr 20 2020, 2:38 PM · Plasma
anthonyfieroni added inline comments to D26350: Don't create pixmaps for loglevel icons.
Apr 20 2020, 11:38 AM

Apr 18 2020

anthonyfieroni added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

+1, looks great.

Apr 18 2020, 9:49 AM · Frameworks, Kate

Apr 17 2020

anthonyfieroni added inline comments to D28904: Cleanup dependencies.
Apr 17 2020, 8:52 AM · Plasma
anthonyfieroni added inline comments to D28885: Avoid deleting BlurInterface global.
Apr 17 2020, 7:43 AM · KWin
anthonyfieroni added inline comments to D28885: Avoid deleting BlurInterface global.
Apr 17 2020, 7:42 AM · KWin

Apr 14 2020

anthonyfieroni added a comment to D28817: fix (kcm): correct output identifier position on wayland.

I don't think we have a leak, on destructor we delete all view
qDeleteAll(m_views);

Apr 14 2020, 11:53 AM · Plasma
anthonyfieroni added inline comments to D28817: fix (kcm): correct output identifier position on wayland.
Apr 14 2020, 11:22 AM · Plasma
anthonyfieroni added a reviewer for D28812: Avoid fullRepaint loop penalty in paintSimpleScreen: zzag.

Create patch like this git diff -U999 > 1.patch it will add more context to be shown to reviewers.

Apr 14 2020, 6:17 AM · KWin

Apr 9 2020

anthonyfieroni added inline comments to D28669: make CopyJob non-recursive.
Apr 9 2020, 11:02 AM · Frameworks
anthonyfieroni added inline comments to D28669: make CopyJob non-recursive.
Apr 9 2020, 10:11 AM · Frameworks
anthonyfieroni added inline comments to D28692: Don't leak DrKonqi dialog / fix crash on wayland.
Apr 9 2020, 3:58 AM · Plasma

Apr 8 2020

anthonyfieroni added inline comments to D28127: Add some new battery sensors : energy_now, energy_full and power_now..
Apr 8 2020, 10:58 AM · Plasma
anthonyfieroni added inline comments to D28669: make CopyJob non-recursive.
Apr 8 2020, 9:44 AM · Frameworks
anthonyfieroni added a comment to D28669: make CopyJob non-recursive.

If you want to kill the job how this loop will be break?

Apr 8 2020, 6:07 AM · Frameworks

Apr 5 2020

anthonyfieroni added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

@elvisangelaccio this peace of code is purely wrong at least m_storages is not updated to new device and not only. This code should never exists or try to hide some other bug.

Apr 5 2020, 4:40 PM · Frameworks, Dolphin

Apr 4 2020

anthonyfieroni added a comment to D28286: [Task Manager] Port backend to ApplicationLauncherJob.

That wouldn't work either, you need to be able to choose between a Notification delegate, a Dialog delegate (which lives in a different library due to the QtWidgets dependency), and some more.

Apr 4 2020, 12:46 PM · Plasma
anthonyfieroni added a comment to D28286: [Task Manager] Port backend to ApplicationLauncherJob.

OK, let's keep things as they are. Because the best i can make without dedicated function is new KIO::ApplicationLauncherJob(service, KIO::ApplicationLauncher::WITH_AUTO_ERROR_HANDLED_DELEGATE)

Apr 4 2020, 10:17 AM · Plasma
anthonyfieroni added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

Ok that's look good to me. We can move that code in constructor just before loop for storages, then use m_mtpdevice instead of raw device, but it looks like removed code is just a noise and it shouldn't present at all.

Apr 4 2020, 6:03 AM · Frameworks, Dolphin
anthonyfieroni added a comment to D28286: [Task Manager] Port backend to ApplicationLauncherJob.

And what about the idea to pass delegate to job constructor? At least it's better than current one. I'm pretty pedantic about duplicate code in plus it makes porting harder.

Apr 4 2020, 5:54 AM · Plasma

Apr 3 2020

anthonyfieroni added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

So to be succinct, the only correct fix here is to change getDevice() to return m_mtpdevice?

Apr 3 2020, 1:20 PM · Frameworks, Dolphin
anthonyfieroni added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

@feverfew are you gonna try what i'm writing about or i should do it? Just use cached device, do not reopen since it'll return nullptr.

Apr 3 2020, 12:49 PM · Frameworks, Dolphin
anthonyfieroni added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

I see we don't speak in same language :)
LIBMTP_Open_Raw_Device_Uncached(&m_rawdevice);
returns nullptr that's normal since device is inaccessible, i mean it does not need to call LIBMTP_Release_Device using m_mtpdevice is safe it's not nullptr, it's just a disconnected device and libmtp knows that.

Apr 3 2020, 12:25 PM · Frameworks, Dolphin
anthonyfieroni added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

If getDevice() returns nullptr, this means that MTPDevice::getDevice() returns nullptr. This can only happen if m_mtpdevice is nullptr, which will crash in MTPDevice::~MTPDevice sooner or later anyway.

Apr 3 2020, 11:47 AM · Frameworks, Dolphin
anthonyfieroni added inline comments to D28215: [RFC]: WIP: Make mobile broadband actually functional.
Apr 3 2020, 11:39 AM · Plasma
anthonyfieroni added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

You're right about bug report, but it can fail in any other place, just in particular version it happen in updateStorageInfo Can we cache getDevice in m_device (in constructor) then use it everywhere. I think libmtp has guard against disconnected device and will not crash.

Apr 3 2020, 11:28 AM · Frameworks, Dolphin

Apr 2 2020

anthonyfieroni added inline comments to D28498: [xdgoutput] Explicitly set version of server interface.
Apr 2 2020, 10:08 AM · Frameworks

Apr 1 2020

anthonyfieroni committed R449:609887228ab1: [git] Set combo box to current branch in pull dialog (authored by anthonyfieroni).
[git] Set combo box to current branch in pull dialog
Apr 1 2020, 9:09 AM
anthonyfieroni closed D28459: [git] Set combo box to current branch in pull dialog.
Apr 1 2020, 9:09 AM
anthonyfieroni added inline comments to D28476: Samba: Ensure to differenciate mounts sharing the same source.
Apr 1 2020, 9:07 AM · Frameworks

Mar 31 2020

anthonyfieroni added inline comments to D28445: Reduce the amount of objects that are compiled several times.
Mar 31 2020, 9:38 AM · KWin
anthonyfieroni requested review of D28459: [git] Set combo box to current branch in pull dialog.
Mar 31 2020, 9:10 AM
anthonyfieroni added inline comments to D27988: KCM/Compositing: Use KConfig XT in UI.
Mar 31 2020, 7:47 AM · KWin

Mar 29 2020

anthonyfieroni added a comment to D28286: [Task Manager] Port backend to ApplicationLauncherJob.

Why not -> because it just doesn't scale. 30 jobs * 4 delegates = 120 wrapper methods...

Mar 29 2020, 1:44 PM · Plasma

Mar 28 2020

anthonyfieroni added a comment to D28286: [Task Manager] Port backend to ApplicationLauncherJob.

Why not? Furthermore they can be easy fixable.

Mar 28 2020, 2:19 PM · Plasma
anthonyfieroni added a comment to D28286: [Task Manager] Port backend to ApplicationLauncherJob.

Benefit: available everywhere, unlike a local wrapper function.

Mar 28 2020, 11:28 AM · Plasma
anthonyfieroni added inline comments to D28286: [Task Manager] Port backend to ApplicationLauncherJob.
Mar 28 2020, 10:14 AM · Plasma

Mar 26 2020

anthonyfieroni added inline comments to D28289: Refactor of OverlaySheet.
Mar 26 2020, 11:49 AM · Kirigami

Mar 19 2020

anthonyfieroni added inline comments to D28135: Port away from deprecated QSet/QList methods in some places.
Mar 19 2020, 11:32 AM · Plasma
anthonyfieroni added inline comments to D28135: Port away from deprecated QSet/QList methods in some places.
Mar 19 2020, 11:06 AM · Plasma
anthonyfieroni added a comment to D27861: [wayland] Rework xdg-shell implementation.

Because KWayland is a KF library,
we are not able to change existing API in ways that may break API or
ABI compatibility. So, if some particular wrapper has been implemented
incorrectly, we can't do that much about it except maybe leaving
comments that look like "// TODO KF6".

Mar 19 2020, 8:07 AM · KWin

Mar 17 2020

anthonyfieroni added a comment to D28107: Fix overlayIcon sometimes not visible.

Can we just set/clear OverlayIconName depends of icon presence then overlays: model.OverlayIconName ?

Mar 17 2020, 6:53 PM · Plasma
anthonyfieroni added a comment to D28102: SVN: added SVN Log dialog.

Dialog looks and behaves similar to a TortoiseSVN one.

Mar 17 2020, 6:39 PM