anthonyfieroni (Anthony Fieroni)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2015, 10:58 AM (216 w, 2 h)
Availability
Available

Recent Activity

Yesterday

anthonyfieroni added a comment to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.

That should be fine, in QPA we have a tray icon per sni, update menu should be on same object which will not be a problem, check it.

There are two objects in QPA that live independently:

  • KDEPlatformSystemTrayIcon (QPlatformSystemTrayIcon), with KSNI instance, KSNI and KDEPlatformSystemTrayIcon are destroyed on QSystemTrayIcon->hide() and new instance (with new KSNI) is created on QSystemTrayIcon->show()
  • SystemTrayMenu (QPlatformMenu) is not destroyed on QSystemTrayIcon->hide() and will be reused later on QSystemTrayIcon->show()

    kdeplatformsystemtrayicon.cpp#L339

    ` void KDEPlatformSystemTrayIcon::updateMenu(QPlatformMenu *menu) { //... if (SystemTrayMenu *ourMenu = qobject_cast<SystemTrayMenu*>(menu)) { m_sni->setContextMenu(ourMenu->menu()); } } `

    About you patch: I understand your idea, but it changes API contract and is not backward-compatible. Current documentation says:

The KStatusNotifierItem instance takes ownership of the menu, and will delete it upon its destruction.

This is quite clear, I want to be really careful here - I don't want to be blamed for memory leaks :) I think that we need to keep:

Mon, Oct 21, 2:05 PM · Frameworks

Sun, Oct 20

anthonyfieroni added a comment to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.


That should be fine, in QPA we have a tray icon per sni, update menu should be on same object which will not be a problem, check it.

Sun, Oct 20, 5:56 AM · Frameworks

Sat, Oct 19

anthonyfieroni added inline comments to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.
Sat, Oct 19, 6:39 PM · Frameworks
anthonyfieroni added inline comments to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.
Sat, Oct 19, 3:37 PM · Frameworks
anthonyfieroni added inline comments to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.
Sat, Oct 19, 2:30 PM · Frameworks
anthonyfieroni added inline comments to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.
Sat, Oct 19, 6:31 AM · Frameworks

Fri, Oct 18

anthonyfieroni added inline comments to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.
Fri, Oct 18, 1:11 PM · Frameworks

Thu, Oct 17

anthonyfieroni added inline comments to D24683: [KWindowSystem] in icon() return realistic icon size.
Thu, Oct 17, 12:34 PM · Plasma
anthonyfieroni added a comment to D24711: [Mouse KCM] Fix acceleration profile on X11.

https://phabricator.kde.org/source/plasma-desktop/browse/master/kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp$126
It should be changed also, right?
When you create a diff add a more context to it, like git diff -U100 > patch

Thu, Oct 17, 5:59 AM · Plasma

Sun, Sep 29

anthonyfieroni added inline comments to D24290: Remove extra pixel when cropping with an aspect ratio.
Sun, Sep 29, 6:40 AM · Gwenview
anthonyfieroni added inline comments to D24290: Remove extra pixel when cropping with an aspect ratio.
Sun, Sep 29, 5:07 AM · Gwenview

Tue, Sep 24

anthonyfieroni added reviewers for D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).: mart, Plasma.

Kirigami itself depends on 5.11 https://phabricator.kde.org/source/kirigami/browse/master/CMakeLists.txt$8 so update version to that one https://doc.qt.io/qt-5/qtquickcontrols-index.html

Tue, Sep 24, 2:34 PM · Kirigami

Sep 21 2019

anthonyfieroni added a comment to D23866: Port from KHTML to QtWebEngine.

I have played a bit around with QTextBrowser, but couldn't get a working result yet.

Sep 21 2019, 7:06 PM · Documentation
anthonyfieroni added inline comments to D23579: port ftp slave to new error reporting system.
Sep 21 2019, 5:42 AM · Frameworks

Sep 17 2019

anthonyfieroni added inline comments to D24012: Supress mouse events in KCMs causing window moves.
Sep 17 2019, 6:24 AM · Frameworks
anthonyfieroni added a comment to D24009: RFC: Make Breeze Dark darker.

I'm using it from 5.1 and it's great because it's not so dark, -1 from me.

Sep 17 2019, 6:18 AM · Plasma

Sep 16 2019

anthonyfieroni added inline comments to D23984: Redesign intro page.
Sep 16 2019, 10:56 AM · VDG, Plasma

Sep 14 2019

anthonyfieroni added a comment to D23918: RFC: Drop Outputs class.
In D23918#530952, @zzag wrote:

Um, I would say that's really bad code unless you use private inheritance.

Sep 14 2019, 1:43 PM · KWin
anthonyfieroni added a comment to D23918: RFC: Drop Outputs class.

You don't need virtual destructor when you don't have at least one virtual method, since you don't have at least one that method you don't want to delete object by its pointer to base. You use it to extend its functionality since that you declare objects by derived type, also you can add virtual destructor to derived class then extend with virtual methods and keep pointer to middle one. There is nothing wrong with stl containers or any other class without virtual destructor without at a virtual method.
https://onlinegdb.com/Bk9IKrc8S

Sep 14 2019, 11:06 AM · KWin
anthonyfieroni added a comment to D23918: RFC: Drop Outputs class.
In D23918#530932, @zzag wrote:

Sorry to disappoint you but that's an unwritten rule in C++ community. The main reason why one should avoid inheriting qvector or std::vector has something to do with destructors. More specifically, neither one of those container types has virtual destructor. However, you could fix that with private inheritance, which will look very ugly!

Sep 14 2019, 10:46 AM · KWin

Sep 11 2019

anthonyfieroni added a comment to D23866: Port from KHTML to QtWebEngine.

I think QTextBrowser fits better than WebEngine.

Sep 11 2019, 11:33 AM · Documentation

Sep 8 2019

anthonyfieroni added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Let's commit this, it's fair small patch but it covers some unwanted crashes.

Sep 8 2019, 6:46 AM · Calligra: 3.0

Sep 7 2019

anthonyfieroni committed R8:7743486fd5b6: [gemini] Clarify touch <-> desktop view switch (authored by anthonyfieroni).
[gemini] Clarify touch <-> desktop view switch
Sep 7 2019, 10:18 AM
anthonyfieroni committed R8:f8717365d240: [gemini] Fix loading of templates and files creation (authored by anthonyfieroni).
[gemini] Fix loading of templates and files creation
Sep 7 2019, 10:18 AM
anthonyfieroni closed D23327: [Gemini] Clarify deletion of document.
Sep 7 2019, 10:18 AM · Calligra: 3.0
anthonyfieroni closed D23617: [gemini] Remove "template://" scheme from file name.
Sep 7 2019, 10:18 AM · Calligra: 3.0

Sep 3 2019

anthonyfieroni updated the diff for D23617: [gemini] Remove "template://" scheme from file name.

I can't test, but it should be fine.

Sep 3 2019, 6:13 PM · Calligra: 3.0

Sep 2 2019

anthonyfieroni updated the diff for D23617: [gemini] Remove "template://" scheme from file name.

Test plan:

Sep 2 2019, 3:49 PM · Calligra: 3.0

Sep 1 2019

anthonyfieroni added a comment to D23617: [gemini] Remove "template://" scheme from file name.

That makes sense but none handle that schemes or should be responsible for that?

Sep 1 2019, 11:19 AM · Calligra: 3.0

Aug 31 2019

anthonyfieroni requested review of D23617: [gemini] Remove "template://" scheme from file name.
Aug 31 2019, 8:14 PM · Calligra: 3.0
anthonyfieroni updated the diff for D23327: [Gemini] Clarify deletion of document.

Fix a bunch of crashes :)

Aug 31 2019, 7:32 PM · Calligra: 3.0
anthonyfieroni accepted D23610: Fix orientation sensor DBus.
Aug 31 2019, 6:13 PM · KWin
anthonyfieroni added a comment to D23591: [platforms/drm] Disable orientation sensor for now.

-1 to disable something without knowing the reason to not work.

Aug 31 2019, 10:47 AM · KWin
anthonyfieroni added a comment to D23591: [platforms/drm] Disable orientation sensor for now.

It's added in D8738. Looks like a use after free issue https://phabricator.kde.org/source/kwin/browse/master/orientation_sensor.cpp$140 can be deleteLater, i think. Also DBus adaptors shouldn't be deleted, they should persist in app lifetime.

Aug 31 2019, 9:09 AM · KWin

Aug 30 2019

anthonyfieroni added inline comments to D23098: [x11] Fix crash during tear down.
Aug 30 2019, 7:39 PM · KWin
anthonyfieroni added inline comments to D23098: [x11] Fix crash during tear down.
Aug 30 2019, 6:05 PM · KWin

Aug 27 2019

anthonyfieroni added inline comments to D23420: Use solid to check if a KFileItem is located on a network mount.
Aug 27 2019, 7:19 AM · Frameworks

Aug 26 2019

anthonyfieroni added inline comments to D23420: Use solid to check if a KFileItem is located on a network mount.
Aug 26 2019, 6:47 AM · Frameworks

Aug 25 2019

anthonyfieroni added inline comments to D23420: Use solid to check if a KFileItem is located on a network mount.
Aug 25 2019, 8:46 AM · Frameworks

Aug 24 2019

anthonyfieroni added a comment to D23389: Use visible buttons to switch the default device.

I can add a note for translators that this string should be kept as short as possible.

Aug 24 2019, 6:03 PM · Plasma
anthonyfieroni added a comment to D23389: Use visible buttons to switch the default device.

My big concern is that translated text is mainly not too big in English but in other lang. Even we change it to "Default Out" (since it has a label "Outputs").

Aug 24 2019, 4:46 PM · Plasma
anthonyfieroni added a comment to D23389: Use visible buttons to switch the default device.

But in settings is radio button

Aug 24 2019, 3:57 PM · Plasma
anthonyfieroni added a comment to D23389: Use visible buttons to switch the default device.

Why not it's a checkbox ? Make default looks big.

Aug 24 2019, 6:04 AM · Plasma

Aug 22 2019

anthonyfieroni added a comment to D23350: Chaning default iconSize in systemtray.

So this is a complaint that comes up a lot. I do see what you mean, and in my opinion, what we need is a dual-mode size control UI that lets you switch between "scale icons to fit in panel", "static icon size", and "n columns".

Aug 22 2019, 4:30 PM · Plasma

Aug 21 2019

anthonyfieroni requested review of D23327: [Gemini] Clarify deletion of document.
Aug 21 2019, 6:41 PM · Calligra: 3.0

Aug 8 2019

anthonyfieroni added inline comments to D22973: docs: introduce commit message guideline.
Aug 8 2019, 11:53 AM · KWin
anthonyfieroni added inline comments to D20532: Proof of Concept: Add double click actions to empty space in the folder view.
Aug 8 2019, 5:56 AM · Dolphin
anthonyfieroni added inline comments to D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events.
Aug 8 2019, 5:31 AM · Baloo, Frameworks
anthonyfieroni added inline comments to D20532: Proof of Concept: Add double click actions to empty space in the folder view.
Aug 8 2019, 5:15 AM · Dolphin

Aug 2 2019

anthonyfieroni added inline comments to D22887: Load animation speed from new global animation speed controller.
Aug 2 2019, 6:42 AM · KWin
anthonyfieroni added a comment to D22316: Avoid garbling the sound if the volume slider is moved fast.

updateTimer uses slider value and it takes 200 ms to react, so you can sync the timer with keyboard one by increase the interval https://phabricator.kde.org/source/plasma-pa/browse/master/applet/contents/ui/ListItemBase.qml$198

Aug 2 2019, 6:40 AM · Plasma
anthonyfieroni added a comment to D22885: Add global animation speed slider to workspace options KCM.

Since we have 4 values on right / left, 0 should be the default one, no?

Aug 2 2019, 6:35 AM · Plasma

Jul 20 2019

anthonyfieroni added a comment to D19559: Move management of QWebEngineProfile to WebEnginePage, to avoid crash on KMail exit or viewer window close.

Did you commit in 19.04 branch, i still get hangs in KMail on logout in QtWebEngineCore::ProfileAdapter::~ProfileAdapter then in QtWebEngineCore::WebContentsAdapter::~WebContentsAdapter.

Jul 20 2019, 11:52 AM · KDE PIM

Jul 19 2019

anthonyfieroni added a comment to D21667: Optionally display threads as if they were processes.

Use spaces instead of tabs.

Jul 19 2019, 6:07 PM · Plasma

Jul 15 2019

anthonyfieroni added a comment to D22386: Fix an issue with a new tab focus.

It does not look correct either, the problem is that the focus on location bar is delayed and setActive(false) isn't applied, this is workaround. But we have problems on that before, exactly that part with focusIn on location bar. You should correct there but it can break something other.

Jul 15 2019, 4:16 PM · Dolphin

Jul 13 2019

anthonyfieroni added inline comments to D22424: TextDocument: remove actions from contextmenu on hide already.
Jul 13 2019, 10:59 AM · KDevelop
anthonyfieroni added a comment to D22333: Move Solid::Device::listFromQuery calls to a separate thread.

https://phabricator.kde.org/source/solid/browse/master/src/solid/devices/frontend/devicemanager.cpp$301
@bruns, It's backend per thread

Jul 13 2019, 9:10 AM · Plasma

Jul 12 2019

anthonyfieroni added inline comments to D22422: Fix dir change when show hidden terminal panel with running program in it.
Jul 12 2019, 2:40 PM · Dolphin

Jul 10 2019

anthonyfieroni added inline comments to D22378: don't use nullptr to stay compatible with !c++11 & qt4.
Jul 10 2019, 3:59 PM
anthonyfieroni added inline comments to D22195: Split Compositor class in Wayland and X11 child classes.
Jul 10 2019, 10:33 AM · KWin

Jul 9 2019

anthonyfieroni added inline comments to D22183: Add click to play/pause feature on previews for audio/video.
Jul 9 2019, 3:11 PM · Dolphin

Jul 8 2019

anthonyfieroni added inline comments to D22296: [ksmserver] Remove obsolete KDELibs4Support dependency.
Jul 8 2019, 5:14 PM · Plasma
anthonyfieroni added inline comments to D22160: Document tree view close on middle button.
Jul 8 2019, 5:07 PM · KDevelop

Jul 2 2019

anthonyfieroni added inline comments to D22195: Split Compositor class in Wayland and X11 child classes.
Jul 2 2019, 5:25 AM · KWin

Jul 1 2019

anthonyfieroni added a comment to D22155: Add new activities and virtual desktops icons.

Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new features + bugs fix and Plasma offers LTS.

Do you have any examples of distros that do this? To my knowledge, all "LTS" style distros freeze all versions of KDE software, not just Plasma and apps.

Jul 1 2019, 1:50 PM · Frameworks

Jun 30 2019

anthonyfieroni added a comment to D22155: Add new activities and virtual desktops icons.
In D22155#488497, @GB_2 wrote:

We can backport the changes in Plasma to the LTS branch though.

Jun 30 2019, 4:42 PM · Frameworks
anthonyfieroni added a comment to D22155: Add new activities and virtual desktops icons.

Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new features + bugs fix and Plasma offers LTS.

Jun 30 2019, 3:53 PM · Frameworks
anthonyfieroni added a comment to D22102: Implement apply-on-double-click for all grid view KCM delegates.

Alternatively you can add message widget that explore double click functionality, when double click is applied it can change its message that save is applied. But rater OK/Apply became a bit pointless.

Jun 30 2019, 3:41 PM · Frameworks

Jun 29 2019

anthonyfieroni added inline comments to D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.
Jun 29 2019, 11:35 AM · Frameworks
anthonyfieroni added inline comments to D22148: Fix on click not working.
Jun 29 2019, 8:01 AM · Spectacle
anthonyfieroni added inline comments to D22148: Fix on click not working.
Jun 29 2019, 5:14 AM · Spectacle

Jun 27 2019

anthonyfieroni added inline comments to D22122: use pwquality_strerror to get error strings.
Jun 27 2019, 2:52 PM · Plasma

Jun 26 2019

anthonyfieroni added inline comments to D22053: [libtaskmanager] Track stacking order and window activation (on X11).
Jun 26 2019, 6:12 PM · Plasma

Jun 24 2019

anthonyfieroni added inline comments to D22084: Span wayland objects to lifespan of the QApplication.
Jun 24 2019, 5:11 PM · Plasma
anthonyfieroni added inline comments to D22084: Span wayland objects to lifespan of the QApplication.
Jun 24 2019, 5:09 PM · Plasma

Jun 21 2019

anthonyfieroni added a comment to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

QList<KNSCore::Comment*> should be QList<shared_ptr<KNSCore::Comment>>, don't leave ownership to consumers.

Jun 21 2019, 10:23 AM · Frameworks

Jun 20 2019

anthonyfieroni committed R122:d7298f157fec: Merge branch 'Plasma/5.16' of git://anongit.kde.org/powerdevil into Plasma/5.16 (authored by anthonyfieroni).
Merge branch 'Plasma/5.16' of git://anongit.kde.org/powerdevil into Plasma/5.16
Jun 20 2019, 2:11 PM
anthonyfieroni closed D21918: [powerdevil] Connect to battery source events.
Jun 20 2019, 2:11 PM · Plasma
anthonyfieroni committed R122:a1f9e365a5b4: [powerdevil] Return battery source monitoring (authored by anthonyfieroni).
[powerdevil] Return battery source monitoring
Jun 20 2019, 2:11 PM
anthonyfieroni added a reviewer for D21918: [powerdevil] Connect to battery source events: davidedmundson.

it's removed in D20157

Jun 20 2019, 10:37 AM · Plasma
anthonyfieroni requested review of D21918: [powerdevil] Connect to battery source events.
Jun 20 2019, 7:56 AM · Plasma
anthonyfieroni accepted D20400: Karbon: Enable multi page capability.

I saw filters does not compile when it compiles Karbon only, i should correct that, but i have much time now.
Edit: I investigate and it works correctly, i mislead APP_KARBON and KARBON.

Jun 20 2019, 7:52 AM · Calligra: 3.0

Jun 15 2019

anthonyfieroni added inline comments to D21638: Display delay in the taskmanager.
Jun 15 2019, 1:11 PM · Spectacle

Jun 10 2019

anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

If you mean export to svg here, afaics there are no page element in svg. Have I missed it?

Jun 10 2019, 12:39 PM · Calligra: 3.0

Jun 6 2019

anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

Jun 6 2019, 7:58 PM · Calligra: 3.0

Jun 5 2019

anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Apparently it has a problem, when we compile only Karbon, as i done now, KoPAView is in pageapp, which is not compile-able in Karbon, right?
Full cmake command

cmake .. -DCMAKE_INSTALL_PREFIX=/usr  -DCMAKE_INSTALL_LIBDIR=lib -DKDE_INSTALL_PLUGINDIR=/usr/lib/qt5/plugins -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DBUILD_TESTING=FALSE -DPACKAGERS_BUILD=true -DBUILD_UNMAINTAINED=TRUE -DPRODUCTSET=APP_KARBON
Jun 5 2019, 6:30 AM · Calligra: 3.0

Jun 4 2019

anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Someone test it, code wise looks good, i plan to test it soon.

Jun 4 2019, 8:36 PM · Calligra: 3.0
anthonyfieroni abandoned D19327: Karbon: Enable multi page capability.

In flavor of D20400

Jun 4 2019, 8:35 PM · Calligra: 3.0
anthonyfieroni commandeered D19327: Karbon: Enable multi page capability.
Jun 4 2019, 8:35 PM · Calligra: 3.0
anthonyfieroni abandoned D19216: Karbon: Enable multi page capability.

In flavor of D20400

Jun 4 2019, 8:35 PM · Calligra: 3.0
anthonyfieroni commandeered D19216: Karbon: Enable multi page capability.
Jun 4 2019, 8:34 PM · Calligra: 3.0

Jun 3 2019

anthonyfieroni added inline comments to D15580: [WIP] New annotation toolbar.
Jun 3 2019, 6:34 PM · Okular
anthonyfieroni added a comment to D21562: fix crash in webenginepart on konqueror shutdown.

The change is correct to me.

Jun 3 2019, 6:31 PM

Jun 2 2019

anthonyfieroni added a comment to D16648: Open externally called files/directories in new tabs.

I failed to request changes for D16648#inline-121014.
This is bound to randomly exhibit strange behaviour.

Jun 2 2019, 6:18 PM · Dolphin
anthonyfieroni added a comment to D16648: Open externally called files/directories in new tabs.

Activity id can be appended to dbus name, so it will be trivial to check.

Jun 2 2019, 6:12 PM · Dolphin

May 28 2019

anthonyfieroni added inline comments to D21315: Dolphin-style view modes in the file dialog.
May 28 2019, 10:36 AM · Frameworks
anthonyfieroni added inline comments to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.
May 28 2019, 10:31 AM · Frameworks

May 27 2019

anthonyfieroni added inline comments to D21409: KWrite: Implement skeleton KTextEditor::Application.
May 27 2019, 5:03 AM · Kate

May 19 2019

anthonyfieroni added inline comments to D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux.
May 19 2019, 4:57 AM · Frameworks

May 16 2019

anthonyfieroni added inline comments to D21202: [WIP] Support animated PDF.
May 16 2019, 11:45 AM · Okular