- User Since
- Sep 1 2015, 10:58 AM (216 w, 2 h)
Sun, Oct 20
That should be fine, in QPA we have a tray icon per sni, update menu should be on same object which will not be a problem, check it.
Sat, Oct 19
Fri, Oct 18
Thu, Oct 17
It should be changed also, right?
When you create a diff add a more context to it, like git diff -U100 > patch
Sun, Sep 29
Tue, Sep 24
Kirigami itself depends on 5.11 https://phabricator.kde.org/source/kirigami/browse/master/CMakeLists.txt$8 so update version to that one https://doc.qt.io/qt-5/qtquickcontrols-index.html
Sep 21 2019
Sep 17 2019
I'm using it from 5.1 and it's great because it's not so dark, -1 from me.
Sep 16 2019
Sep 14 2019
You don't need virtual destructor when you don't have at least one virtual method, since you don't have at least one that method you don't want to delete object by its pointer to base. You use it to extend its functionality since that you declare objects by derived type, also you can add virtual destructor to derived class then extend with virtual methods and keep pointer to middle one. There is nothing wrong with stl containers or any other class without virtual destructor without at a virtual method.
Sep 11 2019
I think QTextBrowser fits better than WebEngine.
Sep 8 2019
Let's commit this, it's fair small patch but it covers some unwanted crashes.
Sep 7 2019
Sep 3 2019
I can't test, but it should be fine.
Sep 2 2019
Sep 1 2019
That makes sense but none handle that schemes or should be responsible for that?
Aug 31 2019
Fix a bunch of crashes :)
-1 to disable something without knowing the reason to not work.
It's added in D8738. Looks like a use after free issue https://phabricator.kde.org/source/kwin/browse/master/orientation_sensor.cpp$140 can be deleteLater, i think. Also DBus adaptors shouldn't be deleted, they should persist in app lifetime.
Aug 30 2019
Aug 27 2019
Aug 26 2019
Aug 25 2019
Aug 24 2019
My big concern is that translated text is mainly not too big in English but in other lang. Even we change it to "Default Out" (since it has a label "Outputs").
But in settings is radio button
Why not it's a checkbox ? Make default looks big.
Aug 22 2019
Aug 21 2019
Aug 8 2019
Aug 2 2019
updateTimer uses slider value and it takes 200 ms to react, so you can sync the timer with keyboard one by increase the interval https://phabricator.kde.org/source/plasma-pa/browse/master/applet/contents/ui/ListItemBase.qml$198
Since we have 4 values on right / left, 0 should be the default one, no?
Jul 20 2019
Did you commit in 19.04 branch, i still get hangs in KMail on logout in QtWebEngineCore::ProfileAdapter::~ProfileAdapter then in QtWebEngineCore::WebContentsAdapter::~WebContentsAdapter.
Jul 19 2019
Use spaces instead of tabs.
Jul 15 2019
It does not look correct either, the problem is that the focus on location bar is delayed and setActive(false) isn't applied, this is workaround. But we have problems on that before, exactly that part with focusIn on location bar. You should correct there but it can break something other.
Jul 13 2019
Jul 12 2019
Jul 10 2019
Jul 9 2019
Jul 8 2019
Jul 2 2019
Jul 1 2019
Jun 30 2019
Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new features + bugs fix and Plasma offers LTS.
Alternatively you can add message widget that explore double click functionality, when double click is applied it can change its message that save is applied. But rater OK/Apply became a bit pointless.
Jun 29 2019
Jun 27 2019
Jun 26 2019
Jun 24 2019
Jun 21 2019
QList<KNSCore::Comment*> should be QList<shared_ptr<KNSCore::Comment>>, don't leave ownership to consumers.
Jun 20 2019
it's removed in D20157
I saw filters does not compile when it compiles Karbon only, i should correct that, but i have much time now.
Edit: I investigate and it works correctly, i mislead APP_KARBON and KARBON.
Jun 15 2019
Jun 10 2019
Jun 6 2019
Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.
Jun 5 2019
Apparently it has a problem, when we compile only Karbon, as i done now, KoPAView is in pageapp, which is not compile-able in Karbon, right?
Full cmake command
cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBDIR=lib -DKDE_INSTALL_PLUGINDIR=/usr/lib/qt5/plugins -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DBUILD_TESTING=FALSE -DPACKAGERS_BUILD=true -DBUILD_UNMAINTAINED=TRUE -DPRODUCTSET=APP_KARBON
Jun 4 2019
Someone test it, code wise looks good, i plan to test it soon.
In flavor of D20400
In flavor of D20400
Jun 3 2019
The change is correct to me.
Jun 2 2019
Activity id can be appended to dbus name, so it will be trivial to check.