anthonyfieroni (Anthony Fieroni)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2015, 10:58 AM (229 w, 5 d)
Availability
Available

Recent Activity

Yesterday

anthonyfieroni added a comment to D26764: Another revert to unbreak crash fix.

Actually remove all atexit usage, it does not needed at all
https://en.cppreference.com/w/cpp/utility/program/exit

The destructors of objects with thread local storage duration that are associated with the current thread, the destructors of objects with static storage duration, and the functions registered with std::atexit are executed concurrently, while maintaining the following guarantees:
Sat, Jan 25, 7:41 AM · Konsole

Fri, Jan 24

anthonyfieroni added a comment to D26764: Another revert to unbreak crash fix.
atexit([app]() {
    app.reset();
});

Could be better approach.

Fri, Jan 24, 4:15 PM · Konsole
anthonyfieroni added a comment to D26764: Another revert to unbreak crash fix.

Hi! Sorry, could you please elaborate why does it break the logic? Behavior of the code before and after the change should be the same because unique_ptr calls delete app upon going out of scope.

Fri, Jan 24, 4:12 PM · Konsole
anthonyfieroni added a comment to D26881: [Applets/Folder View] Allow using a folder that ends with a space.

If url ends with more than one space?

Fri, Jan 24, 4:05 PM · Plasma

Thu, Jan 23

anthonyfieroni added inline comments to D26848: Don't assume the manager and menu have the same lifetime.
Thu, Jan 23, 12:30 PM · Frameworks

Tue, Jan 21

anthonyfieroni added inline comments to D26801: Really fix the Windows backend for KNotifications.
Tue, Jan 21, 6:32 AM · Frameworks, KDE Connect

Mon, Jan 20

anthonyfieroni added a comment to D26259: Fixes svn plugin issuing "mkfifo" on Windows..

Use startDetached instead.

Mon, Jan 20, 7:02 AM

Sun, Jan 19

anthonyfieroni added a comment to D26773: Added option to blur background on active window.

That's look interesting but indeed it should be a KWin feature, say it has effect dim inactive this should be blur inactive then wallpaper and any other inactive window will be blurred.

Sun, Jan 19, 7:26 PM · Plasma
anthonyfieroni added a comment to D26764: Another revert to unbreak crash fix.

Make app unique_ptr global then in deleteQApplication use app.reset().

Sun, Jan 19, 4:21 PM · Konsole
anthonyfieroni added a comment to D26755: [WIP] KMessageWidget: Set widget height on resize event.

That's same issue when file is open then externally modified then updated by kmessagewidget button cause a frame to not resize correct?

Sun, Jan 19, 12:09 PM · Frameworks

Thu, Jan 16

anthonyfieroni added inline comments to D26691: Optimize code when dropping files into the desktop.
Thu, Jan 16, 8:31 AM · Frameworks
anthonyfieroni added inline comments to D26688: WIP: [Night Color] Display time when the next transition will start.
Thu, Jan 16, 8:25 AM · Plasma

Wed, Jan 15

anthonyfieroni added inline comments to D26688: WIP: [Night Color] Display time when the next transition will start.
Wed, Jan 15, 4:07 PM · Plasma
anthonyfieroni added inline comments to D26650: Use KService to look for Filelight.
Wed, Jan 15, 9:35 AM · Frameworks

Tue, Jan 14

anthonyfieroni added inline comments to D26650: Use KService to look for Filelight.
Tue, Jan 14, 7:22 PM · Frameworks
anthonyfieroni added inline comments to D26650: Use KService to look for Filelight.
Tue, Jan 14, 7:21 PM · Frameworks
anthonyfieroni added inline comments to D26650: Use KService to look for Filelight.
Tue, Jan 14, 8:34 AM · Frameworks

Sat, Jan 11

anthonyfieroni abandoned D26117: [solid] Clarify referencing of DeviceInterface.

https://phabricator.kde.org/R245:3ff3aaa6640c0fb14bba5430110b20237105c203

Sat, Jan 11, 7:22 AM · Frameworks
anthonyfieroni added inline comments to D25449: Start of the new Formats KCM.
Sat, Jan 11, 7:11 AM · Plasma

Fri, Jan 10

anthonyfieroni committed R245:3ff3aaa6640c: Clarify referencing of DeviceInterface (authored by anthonyfieroni).
Clarify referencing of DeviceInterface
Fri, Jan 10, 8:34 AM

Wed, Jan 8

anthonyfieroni added inline comments to D26484: Add KIO::DropJobFlag to allow manually showing the menu.
Wed, Jan 8, 6:40 AM · Frameworks

Sun, Jan 5

anthonyfieroni added inline comments to D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced..
Sun, Jan 5, 3:27 PM · Frameworks
anthonyfieroni accepted D26434: [Battery Monitor] Don't blink when battery is critical.

Given battery critical notification is persistent and always on top of everything these days, you can't really miss the fact that you're almost ouf of power.

I investigate on it, but if you watch full screen video (Falkon) it does not appear on top, for some reason.

Sun, Jan 5, 1:22 PM · Plasma

Sat, Jan 4

anthonyfieroni added inline comments to D10883: Ability to view git diff (with difftool) for selected file.
Sat, Jan 4, 2:44 PM
anthonyfieroni added a comment to D26393: Expand dynamic cast hierarchy..

That's bug in Clang, dynamic_cast does not do anything to depth and it should not depend of that.

Sat, Jan 4, 12:21 PM · KDE PIM
anthonyfieroni added inline comments to D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs.
Sat, Jan 4, 11:03 AM · Frameworks
anthonyfieroni added a comment to D26117: [solid] Clarify referencing of DeviceInterface.

Ping what else to do? If no objectives i'll push it for next framework release.

Sat, Jan 4, 9:01 AM · Frameworks
anthonyfieroni added inline comments to D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs.
Sat, Jan 4, 6:50 AM · Frameworks

Tue, Dec 31

anthonyfieroni added a comment to D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data.

Isn't it better to just use Qt::endl ?

Tue, Dec 31, 11:38 AM · Documentation, Frameworks
anthonyfieroni added a comment to D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data.

Will be better if you use QLatin1Char('\n'), "\n" will call strlen on which is unneeded. Also QStringLiteral is missing on some strings.

Tue, Dec 31, 7:21 AM · Documentation, Frameworks

Mon, Dec 30

anthonyfieroni added a comment to D26117: [solid] Clarify referencing of DeviceInterface.

I've using the patch till now with no issues.

Mon, Dec 30, 8:35 AM · Frameworks

Sun, Dec 29

anthonyfieroni added a comment to D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data().

auto c = client().toStrongRef().data();
This is completely wrong, the idea behind shared / weak pointer is ability to know when non-owning resource goes out of scope. by calling toStrongRef you extend its lifetime if and only if it exists at time of call then holding this ref you ensure that resource will not be destroyed meanwhile. By holding data() it does nothing to extend resource lifetime but getting a pointer to well-known dying object. It should be
auto c = m_decoration.data()->client().toStrongRef();
Last but not least, c can be nullptr check against null should be performed as well. Exp

xcb_window_t windowId;
auto c = m_decoration.data()->client().toStrongRef();
if (c && (windowId = c->windowId())) {
} else {
    hide();
}

It should be added checks in all use places.

Sun, Dec 29, 8:24 AM · Plasma

Sat, Dec 28

anthonyfieroni added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

Can forcing bigger font DPI make things better?

Sat, Dec 28, 6:04 PM · Plasma

Dec 27 2019

anthonyfieroni added inline comments to D10883: Ability to view git diff (with difftool) for selected file.
Dec 27 2019, 2:18 PM
anthonyfieroni added inline comments to D10883: Ability to view git diff (with difftool) for selected file.
Dec 27 2019, 2:14 PM
anthonyfieroni added inline comments to D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'.
Dec 27 2019, 1:18 PM · Plasma
anthonyfieroni added inline comments to D10883: Ability to view git diff (with difftool) for selected file.
Dec 27 2019, 1:14 PM

Dec 26 2019

anthonyfieroni added a comment to D26050: Fix build with poppler 82.

I'm pretty sure Krita devs think about when they split application out of Calligra repo and make its own copy of libs, flakes, etc. So beneficial of splitting libs in their own release plan will be for all applications. That will a huge work pretty underrated by all users.

Dec 26 2019, 3:38 PM · Calligra: 3.0

Dec 25 2019

anthonyfieroni accepted D26219: Check DPMS extension being present.
Dec 25 2019, 2:12 PM · Plasma
anthonyfieroni added inline comments to D17816: Support for xattrs on kio copy/move.
Dec 25 2019, 6:44 AM · Frameworks
anthonyfieroni added inline comments to D26213: Exclude daemonized processes from Dolphin::attachToExistingInstance().
Dec 25 2019, 6:10 AM · Dolphin

Dec 23 2019

anthonyfieroni added a comment to D26117: [solid] Clarify referencing of DeviceInterface.

Ok, is it clear now?

Dec 23 2019, 3:25 PM · Frameworks
anthonyfieroni added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

Test with qputenv(QT_ENABLE_HIGHDPI_SCALING, "1") it's especially for 5.14+

Dec 23 2019, 12:55 PM · Plasma

Dec 22 2019

anthonyfieroni added a comment to D26117: [solid] Clarify referencing of DeviceInterface.

You can't run kinfocenter or what?

Application: Info Center (kinfocenter), signal: Segmentation fault
Using host libthread_db library "/lib/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f4c245a2840 (LWP 318849))]
Dec 22 2019, 5:13 PM · Frameworks

Dec 20 2019

anthonyfieroni updated the test plan for D26117: [solid] Clarify referencing of DeviceInterface.
Dec 20 2019, 8:44 AM · Frameworks
anthonyfieroni requested review of D26117: [solid] Clarify referencing of DeviceInterface.
Dec 20 2019, 8:42 AM · Frameworks

Dec 16 2019

anthonyfieroni added a comment to D26050: Fix build with poppler 82.

Maybe we can drop 62, but not 72.

Dec 16 2019, 4:19 PM · Calligra: 3.0

Dec 12 2019

anthonyfieroni abandoned D25934: [xattr] Fix passing negative size to QByteArray.
Dec 12 2019, 8:29 PM · Baloo, Frameworks
anthonyfieroni requested review of D25934: [xattr] Fix passing negative size to QByteArray.
Dec 12 2019, 8:04 PM · Baloo, Frameworks
anthonyfieroni accepted D25902: Fix decrement index and not iterator as discussed with David.
Dec 12 2019, 6:55 PM · Frameworks, Dolphin

Dec 11 2019

anthonyfieroni added inline comments to D25902: Fix decrement index and not iterator as discussed with David.
Dec 11 2019, 8:11 PM · Frameworks, Dolphin
anthonyfieroni accepted D25891: fix preview of plain text files when using dark theme.
Dec 11 2019, 8:06 PM · Frameworks, Dolphin

Dec 4 2019

anthonyfieroni added a comment to D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.

+1

Dec 4 2019, 1:33 PM · Plasma
anthonyfieroni added a comment to D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.

So with the patch is it drawn when it is ticked in window decoration?

Dec 4 2019, 1:28 PM · Plasma
anthonyfieroni added a reviewer for D25732: Add only canonical paths to dirWatcher: dfaure.
Dec 4 2019, 1:26 PM · Dolphin
anthonyfieroni added a comment to D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.

Is that configurable (Window decorations -> ^ Draw separator between titlebar and a window ?

Dec 4 2019, 1:25 PM · Plasma

Dec 3 2019

anthonyfieroni added inline comments to D25335: [Details mode] Allow to fill the column size of directories with actual size.
Dec 3 2019, 7:18 AM · Dolphin

Nov 25 2019

anthonyfieroni added a comment to D25510: Force dbus introspection on the Dolphin_1 object.

It looks like a hack knowing Qt algorithm, can we append the pid in the name? It looks like same, but if we have more than one instances?

Nov 25 2019, 6:21 AM · Dolphin

Nov 19 2019

anthonyfieroni added inline comments to D25219: Only create a session config when actually restoring a session.
Nov 19 2019, 7:31 PM · Frameworks

Nov 18 2019

anthonyfieroni added a comment to D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight..

Having different font height for every line?

Nov 18 2019, 6:52 AM · Frameworks, Kate

Nov 17 2019

anthonyfieroni added inline comments to D21235: Add handling of fuseiso filesystem type.
Nov 17 2019, 10:27 AM · Frameworks

Nov 16 2019

anthonyfieroni added inline comments to D22418: WIP [wayland] make automatic backend selection truly automatic.
Nov 16 2019, 1:35 PM · KWin
anthonyfieroni added inline comments to D23413: [System Tray] Unified data model for System Tray items.
Nov 16 2019, 6:30 AM · Plasma

Nov 15 2019

anthonyfieroni added inline comments to D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH.
Nov 15 2019, 4:35 PM · Frameworks

Nov 14 2019

anthonyfieroni added a comment to D25254: Remove flow, not needed since karbon can do it all.

I'm fine with your decision, just i don't want to be the only person accepted such a change.

Nov 14 2019, 10:46 AM · Calligra: 3.0

Nov 11 2019

anthonyfieroni added a reviewer for D25254: Remove flow, not needed since karbon can do it all: Calligra: 3.0.

Let's other members leave their opinion as well. I don't want to have surprised people by removing Flow.

Nov 11 2019, 1:30 PM · Calligra: 3.0
anthonyfieroni added a comment to D25254: Remove flow, not needed since karbon can do it all.

I'm unsure about that, if some people still prefer using Flow will make this change superfluous. I can't make decision about this changes, if you think it should be done - i'm fine.

Nov 11 2019, 12:53 PM · Calligra: 3.0
anthonyfieroni added a comment to D24852: Remove list style from headings.

+1, i'm ok with that.

Nov 11 2019, 11:33 AM · Calligra: 3.0

Nov 10 2019

anthonyfieroni accepted D25214: Karbon image filter: Add multipage support.
Nov 10 2019, 12:01 PM · Calligra: 3.0

Nov 8 2019

anthonyfieroni accepted D25171: PDF Import: Add multipage support.
Nov 8 2019, 6:38 AM · Calligra: 3.0

Nov 7 2019

anthonyfieroni added a comment to D25185: Icon: solve threading issue on when the source is http.

Can we just use queued connection, it'll avoid mutex weirdness.

Nov 7 2019, 9:13 AM · Kirigami
anthonyfieroni added a comment to D25151: Fix tabs not indicating activity.

I see it in line above, but using qobject_cast and not checking for nullptr is waste of time, say if you're sure in type use static_cast, if not check result of qobject_cast against nullptr.

Nov 7 2019, 8:47 AM · Konsole

Nov 3 2019

anthonyfieroni added a comment to D25125: Use KListOpenFilesJob for retrieving apps blocking unmount.

Set QT_PLUGIN_PATH to you local path with plugin after that set the system path for others
QT_PLUGIN_PATH=/local/path:/system/path executable

Nov 3 2019, 9:30 AM · Plasma

Oct 31 2019

anthonyfieroni added a comment to D25039: Fix Clazy performance issues, const &.

Not using references is not a big problem with QString nor QUrl since they are reference counting objects, say if you don't change their content they are immutable, so

const QString s = other; // it's fine
void func(QString s)
{
     const QString o = s; // use o instead of s is also fine, using plain s is fine too, if you don't touch mutability 
     ...
}
Oct 31 2019, 6:54 AM · Frameworks

Oct 30 2019

anthonyfieroni added a comment to D24852: Remove list style from headings.

I think add should be conditional.

Oct 30 2019, 8:36 AM · Calligra: 3.0
anthonyfieroni added inline comments to D25008: Add XLSX spreadsheets import optimisations for small/readonly devices.
Oct 30 2019, 8:35 AM · Calligra: 3.0
anthonyfieroni added inline comments to D25059: KPluginSelector: use new KAboutPluginDialog.
Oct 30 2019, 5:37 AM · Frameworks

Oct 28 2019

anthonyfieroni added a reviewer for D24995: Fix terminal not always gaining focus when shown: tcanabrava.

@tcanabrava https://phabricator.kde.org/R319:6e8153a78e3c63e514a6ecb62f6c9b4b504e7eb7 _viewSplitter->setFocusProxy(controller->view()) is missing so that's the problem to me, not related to Dolphin code.

Oct 28 2019, 7:41 AM · Dolphin

Oct 27 2019

anthonyfieroni added inline comments to D24985: [wallpapers/image] Seed random number generator.
Oct 27 2019, 4:19 PM · Plasma

Oct 22 2019

anthonyfieroni added a comment to D24748: [containmentlayoutmanager] Don't accept button events that only start timers.

You can try it like that:

if (!m_editMode) {
    event->setAccepted(false);
}

or

event->setAccepted(m_editMode);
Oct 22 2019, 4:48 PM · Plasma

Oct 21 2019

anthonyfieroni added a comment to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.

That should be fine, in QPA we have a tray icon per sni, update menu should be on same object which will not be a problem, check it.

There are two objects in QPA that live independently:

  • KDEPlatformSystemTrayIcon (QPlatformSystemTrayIcon), with KSNI instance, KSNI and KDEPlatformSystemTrayIcon are destroyed on QSystemTrayIcon->hide() and new instance (with new KSNI) is created on QSystemTrayIcon->show()
  • SystemTrayMenu (QPlatformMenu) is not destroyed on QSystemTrayIcon->hide() and will be reused later on QSystemTrayIcon->show()

    kdeplatformsystemtrayicon.cpp#L339

    ` void KDEPlatformSystemTrayIcon::updateMenu(QPlatformMenu *menu) { //... if (SystemTrayMenu *ourMenu = qobject_cast<SystemTrayMenu*>(menu)) { m_sni->setContextMenu(ourMenu->menu()); } } `

    About you patch: I understand your idea, but it changes API contract and is not backward-compatible. Current documentation says:

The KStatusNotifierItem instance takes ownership of the menu, and will delete it upon its destruction.

This is quite clear, I want to be really careful here - I don't want to be blamed for memory leaks :) I think that we need to keep:

Oct 21 2019, 2:05 PM · Frameworks

Oct 20 2019

anthonyfieroni added a comment to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.


That should be fine, in QPA we have a tray icon per sni, update menu should be on same object which will not be a problem, check it.

Oct 20 2019, 5:56 AM · Frameworks

Oct 19 2019

anthonyfieroni added inline comments to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.
Oct 19 2019, 6:39 PM · Frameworks
anthonyfieroni added inline comments to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.
Oct 19 2019, 3:37 PM · Frameworks
anthonyfieroni added inline comments to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.
Oct 19 2019, 2:30 PM · Frameworks
anthonyfieroni added inline comments to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.
Oct 19 2019, 6:31 AM · Frameworks

Oct 18 2019

anthonyfieroni added inline comments to D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.
Oct 18 2019, 1:11 PM · Frameworks

Oct 17 2019

anthonyfieroni added inline comments to D24683: [KWindowSystem] in icon() return realistic icon size.
Oct 17 2019, 12:34 PM · Plasma
anthonyfieroni added a comment to D24711: [Mouse KCM] Fix acceleration profile on X11.

https://phabricator.kde.org/source/plasma-desktop/browse/master/kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp$126
It should be changed also, right?
When you create a diff add a more context to it, like git diff -U100 > patch

Oct 17 2019, 5:59 AM · Plasma

Sep 29 2019

anthonyfieroni added inline comments to D24290: Remove extra pixel when cropping with an aspect ratio.
Sep 29 2019, 6:40 AM · Gwenview
anthonyfieroni added inline comments to D24290: Remove extra pixel when cropping with an aspect ratio.
Sep 29 2019, 5:07 AM · Gwenview

Sep 24 2019

anthonyfieroni added reviewers for D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).: mart, Plasma.

Kirigami itself depends on 5.11 https://phabricator.kde.org/source/kirigami/browse/master/CMakeLists.txt$8 so update version to that one https://doc.qt.io/qt-5/qtquickcontrols-index.html

Sep 24 2019, 2:34 PM · Kirigami

Sep 21 2019

anthonyfieroni added a comment to D23866: Port from KHTML to QtWebEngine.

I have played a bit around with QTextBrowser, but couldn't get a working result yet.

Sep 21 2019, 7:06 PM · Documentation
anthonyfieroni added inline comments to D23579: port ftp slave to new error reporting system.
Sep 21 2019, 5:42 AM · Frameworks

Sep 17 2019

anthonyfieroni added inline comments to D24012: Supress mouse events in KCMs causing window moves.
Sep 17 2019, 6:24 AM · Frameworks
anthonyfieroni added a comment to D24009: RFC: Make Breeze Dark darker.

I'm using it from 5.1 and it's great because it's not so dark, -1 from me.

Sep 17 2019, 6:18 AM · Plasma

Sep 16 2019

anthonyfieroni added inline comments to D23984: Redesign intro page.
Sep 16 2019, 10:56 AM · VDG, Plasma

Sep 14 2019

anthonyfieroni added a comment to D23918: RFC: Drop Outputs class.
In D23918#530952, @zzag wrote:

Um, I would say that's really bad code unless you use private inheritance.

Sep 14 2019, 1:43 PM · KWin
anthonyfieroni added a comment to D23918: RFC: Drop Outputs class.

You don't need virtual destructor when you don't have at least one virtual method, since you don't have at least one that method you don't want to delete object by its pointer to base. You use it to extend its functionality since that you declare objects by derived type, also you can add virtual destructor to derived class then extend with virtual methods and keep pointer to middle one. There is nothing wrong with stl containers or any other class without virtual destructor without at a virtual method.
https://onlinegdb.com/Bk9IKrc8S

Sep 14 2019, 11:06 AM · KWin
anthonyfieroni added a comment to D23918: RFC: Drop Outputs class.
In D23918#530932, @zzag wrote:

Sorry to disappoint you but that's an unwritten rule in C++ community. The main reason why one should avoid inheriting qvector or std::vector has something to do with destructors. More specifically, neither one of those container types has virtual destructor. However, you could fix that with private inheritance, which will look very ugly!

Sep 14 2019, 10:46 AM · KWin