- User Since
- Sep 1 2015, 10:58 AM (190 w, 2 d)
Will be good see how it looks in dark theme, especially dark pictures.
That's for right click action menu, i notice that after upgrading to 19.04, since i'm not using Baloo tags action does nothing, patch looks good it should work.
Tue, Apr 9
Mar 25 2019
Mar 22 2019
Ping this looks sane, anyone ?
What happen to this? Put it to 19.04 for testing.
Mar 15 2019
Mar 14 2019
Video or screenshot will be helpful.
Mar 7 2019
Mar 6 2019
Feb 26 2019
Feb 22 2019
Test now, i can't reproduce behavior mentioned above.
Feb 21 2019
Feb 20 2019
Feb 16 2019
Feb 12 2019
It's good to +1
Feb 7 2019
@davidedmundson it works. I really don't know that sharing model between contexts cause a such behavior. It's caused by some ref counting ? Did you know why, it's internal Qt issue that we can fix or it's expected ?
I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in.
Did you understand why it happen?
Feb 6 2019
I notice it, because i use SQLite backend, LGTM to me +1
Feb 2 2019
Jan 31 2019
Jan 30 2019
Jan 29 2019
Let's make public slot approach.
VersionControlObserver is exported class changing its constructor type parameter can brake ABI, but does it user of ? In other hand addition of public slot is ABI comfortable, so another approach can be better solution.
Jan 26 2019
So just don't call slotFilePrint connect loadCompleted to slotFilePrint. When openDocumentInternal downloads the document it fires signal of finish, just connect to slot of opened it.
I investigate on testing this patch, it does not fix systray issue, to discard it?
Jan 25 2019
Jan 21 2019
@alexeymin, can you try this patch as well, it's pretty annoying to have 5+ versioned tabs, error in one to be shown in others.
Jan 20 2019
ping, issue is real and annoying.
Jan 16 2019
+1 it looks good to me.
Jan 15 2019
Searchbar propagates events even it's not visible, you can add check for visibility in focusin event.
Jan 14 2019
Jan 12 2019
Jan 11 2019
Jan 10 2019
Now in multi-thread environment will have problems especially on actualTheme(), no?
Jan 9 2019
If you mean in 4.9 - no, i just not realize that.
Jan 5 2019
Apparently it has a problem, if 2 or more versioned tabs are open (in distinct git directories) switching between does not update status/actions. It looks like in dolphin-plugin is used static object as well. So after all we don't want error in one tab to be multiplied to all opened, i've seen it often, since i'm using plugin daily, so easy fix is to update directory on tab activated, since observer has only private slots i'm using old syntax did you have better idea?
Jan 4 2019
I want to have this in 18.12.1, i really not prefer to have custom changes against upstream.
Jan 3 2019
The problem is too specific, it happen when dpms is activated after dimm display is setted screen to 0, if dimm option is not checked it works correct to me.
Video can't handle it. (i've think about screencast but can be recorded by a phone)
Jan 2 2019
Does someone test it, @thsurrel ?
Ping, we can remove parent but i don't see advantage of this.
Ping, now on Alt+1 or right click ->project -> lookup does not show correct tab