anthonyfieroni (Anthony Fieroni)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2015, 10:58 AM (199 w, 2 h)
Availability
Available

Recent Activity

Yesterday

anthonyfieroni added inline comments to D22084: Span wayland objects to lifespan of the QApplication.
Mon, Jun 24, 5:11 PM · Plasma
anthonyfieroni added inline comments to D22084: Span wayland objects to lifespan of the QApplication.
Mon, Jun 24, 5:09 PM · Plasma

Fri, Jun 21

anthonyfieroni added a comment to D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

QList<KNSCore::Comment*> should be QList<shared_ptr<KNSCore::Comment>>, don't leave ownership to consumers.

Fri, Jun 21, 10:23 AM · Frameworks

Thu, Jun 20

anthonyfieroni committed R122:d7298f157fec: Merge branch 'Plasma/5.16' of git://anongit.kde.org/powerdevil into Plasma/5.16 (authored by anthonyfieroni).
Merge branch 'Plasma/5.16' of git://anongit.kde.org/powerdevil into Plasma/5.16
Thu, Jun 20, 2:11 PM
anthonyfieroni closed D21918: [powerdevil] Connect to battery source events.
Thu, Jun 20, 2:11 PM · Plasma
anthonyfieroni committed R122:a1f9e365a5b4: [powerdevil] Return battery source monitoring (authored by anthonyfieroni).
[powerdevil] Return battery source monitoring
Thu, Jun 20, 2:11 PM
anthonyfieroni added a reviewer for D21918: [powerdevil] Connect to battery source events: davidedmundson.

it's removed in D20157

Thu, Jun 20, 10:37 AM · Plasma
anthonyfieroni requested review of D21918: [powerdevil] Connect to battery source events.
Thu, Jun 20, 7:56 AM · Plasma
anthonyfieroni accepted D20400: Karbon: Enable multi page capability.

I saw filters does not compile when it compile only Karbon, i should correct that, but i have much time now.

Thu, Jun 20, 7:52 AM · Calligra: 3.0

Sat, Jun 15

anthonyfieroni added inline comments to D21638: Display delay in the taskmanager.
Sat, Jun 15, 1:11 PM · Spectacle

Mon, Jun 10

anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

If you mean export to svg here, afaics there are no page element in svg. Have I missed it?

Mon, Jun 10, 12:39 PM · Calligra: 3.0

Thu, Jun 6

anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

Thu, Jun 6, 7:58 PM · Calligra: 3.0

Wed, Jun 5

anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Apparently it has a problem, when we compile only Karbon, as i done now, KoPAView is in pageapp, which is not compile-able in Karbon, right?
Full cmake command

cmake .. -DCMAKE_INSTALL_PREFIX=/usr  -DCMAKE_INSTALL_LIBDIR=lib -DKDE_INSTALL_PLUGINDIR=/usr/lib/qt5/plugins -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DBUILD_TESTING=FALSE -DPACKAGERS_BUILD=true -DBUILD_UNMAINTAINED=TRUE -DPRODUCTSET=APP_KARBON
Wed, Jun 5, 6:30 AM · Calligra: 3.0

Tue, Jun 4

anthonyfieroni added a comment to D20400: Karbon: Enable multi page capability.

Someone test it, code wise looks good, i plan to test it soon.

Tue, Jun 4, 8:36 PM · Calligra: 3.0
anthonyfieroni abandoned D19327: Karbon: Enable multi page capability.

In flavor of D20400

Tue, Jun 4, 8:35 PM · Calligra: 3.0
anthonyfieroni commandeered D19327: Karbon: Enable multi page capability.
Tue, Jun 4, 8:35 PM · Calligra: 3.0
anthonyfieroni abandoned D19216: Karbon: Enable multi page capability.

In flavor of D20400

Tue, Jun 4, 8:35 PM · Calligra: 3.0
anthonyfieroni commandeered D19216: Karbon: Enable multi page capability.
Tue, Jun 4, 8:34 PM · Calligra: 3.0

Mon, Jun 3

anthonyfieroni added inline comments to D15580: New annotation toolbar.
Mon, Jun 3, 6:34 PM · Okular
anthonyfieroni added a comment to D21562: fix crash in webenginepart on konqueror shutdown.

The change is correct to me.

Mon, Jun 3, 6:31 PM

Sun, Jun 2

anthonyfieroni added a comment to D16648: Open externally called files/directories in new tabs.

I failed to request changes for D16648#inline-121014.
This is bound to randomly exhibit strange behaviour.

Sun, Jun 2, 6:18 PM · Dolphin
anthonyfieroni added a comment to D16648: Open externally called files/directories in new tabs.

Activity id can be appended to dbus name, so it will be trivial to check.

Sun, Jun 2, 6:12 PM · Dolphin

Tue, May 28

anthonyfieroni added inline comments to D21315: Dolphin-style view modes in the file dialog.
Tue, May 28, 10:36 AM · Frameworks
anthonyfieroni added inline comments to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.
Tue, May 28, 10:31 AM · Frameworks

Mon, May 27

anthonyfieroni added inline comments to D21409: KWrite: Implement skeleton KTextEditor::Application.
Mon, May 27, 5:03 AM · Kate

May 19 2019

anthonyfieroni added inline comments to D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux.
May 19 2019, 4:57 AM · Frameworks

May 16 2019

anthonyfieroni added inline comments to D21202: [WIP] Support animated PDF.
May 16 2019, 11:45 AM · Okular
anthonyfieroni added inline comments to D21202: [WIP] Support animated PDF.
May 16 2019, 5:54 AM · Okular

May 15 2019

anthonyfieroni added inline comments to D19745: Fix system tray UI/UX & refactor.
May 15 2019, 11:17 AM · Plasma

May 13 2019

anthonyfieroni added inline comments to D21076: ICC Color Correction Effect.
May 13 2019, 11:38 AM · KWin

May 11 2019

anthonyfieroni added inline comments to D21121: Fix leaking of requests in ItemRetriever::exec().
May 11 2019, 5:09 PM · KDE PIM
anthonyfieroni added inline comments to D21121: Fix leaking of requests in ItemRetriever::exec().
May 11 2019, 12:36 PM · KDE PIM

May 10 2019

anthonyfieroni added a comment to D21121: Fix leaking of requests in ItemRetriever::exec().

Can we make readyItems unique_ptr?

May 10 2019, 3:44 PM · KDE PIM
anthonyfieroni added a comment to D21121: Fix leaking of requests in ItemRetriever::exec().

That's not the right place do it, it should be done in ItemRetrievalManager.

May 10 2019, 12:25 PM · KDE PIM

May 7 2019

anthonyfieroni added inline comments to D19796: [Device Notifier] Restore Solid notification messages.
May 7 2019, 4:54 PM · Plasma

May 3 2019

anthonyfieroni added a comment to D20958: New menu of syntax highlighting in the status bar.

dymanic_cast is expensive, prefer qobject_cast if you want to check result against nullptr, if you don't want - static_cast.

May 3 2019, 2:15 PM · Frameworks, Kate
anthonyfieroni added inline comments to D20958: New menu of syntax highlighting in the status bar.
May 3 2019, 2:11 PM · Frameworks, Kate

Apr 27 2019

anthonyfieroni added inline comments to D20786: ProcessList: add support for cgroups.
Apr 27 2019, 9:51 AM · Plasma
anthonyfieroni added a comment to D20859: Crash in sddmthemeinstaller invalid use of errorString.

That's maybe KAuth bug or KCoreAddons one, when job fails it should have errorString. Also check jobs does not delete itself.

Apr 27 2019, 5:33 AM · Plasma
anthonyfieroni added inline comments to D20748: Fix wrong "Unable to find service type" warnings.
Apr 27 2019, 5:25 AM · Frameworks
anthonyfieroni added inline comments to D20786: ProcessList: add support for cgroups.
Apr 27 2019, 5:15 AM · Plasma

Apr 25 2019

anthonyfieroni added a comment to D20693: Remove pixelated border.

Will be good see how it looks in dark theme, especially dark pictures.

Apr 25 2019, 5:49 AM · Frameworks, KNewStuff

Apr 24 2019

anthonyfieroni added a comment to D20776: Only show tags action when baloo is enabled.

That's for right click action menu, i notice that after upgrading to 19.04, since i'm not using Baloo tags action does nothing, patch looks good it should work.

Apr 24 2019, 2:04 PM · Baloo

Apr 9 2019

anthonyfieroni added inline comments to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.
Apr 9 2019, 5:12 PM · Frameworks
anthonyfieroni added inline comments to D19262: Delayed focus updates for Toplevels without surface.
Apr 9 2019, 11:56 AM · KWin

Mar 25 2019

anthonyfieroni added a comment to D19947: systray: show a small animation on the icons when activated.
In D19947#438052, @apol wrote:

It's subtle but I quite like it.

\o/

It feels a bit inconsistent given it affects plasmoids on keyshortcut, but not on click.

Agreed, but here the bug is that on click it doesn't happen I'd say, and we'll have to go over all plasmoids I'm afraid, because they all implement a MouseArea to deal with triggering.
I was looking into introducing context menu on pressAndHold and there's a similar problem.

Mar 25 2019, 4:07 PM · Plasma

Mar 22 2019

Restricted Application added a project to D5111: Provide demo/preview for checkable menu items: Plasma.
Mar 22 2019, 1:23 PM · Plasma
anthonyfieroni added a comment to D11971: Use same keyword separator for read and write.

Ping this looks sane, anyone ?

Mar 22 2019, 1:22 PM · Calligra: 3.0
anthonyfieroni added a comment to D15763: Set correct image attributes on directory thumbnail.

What happen to this? Put it to 19.04 for testing.

Mar 22 2019, 1:21 PM · Frameworks, Dolphin

Mar 15 2019

anthonyfieroni added inline comments to D19780: Fix a todo in Information Panel, fixing two bugs.
Mar 15 2019, 1:56 PM · Dolphin

Mar 14 2019

anthonyfieroni added a reviewer for D19767: Fix malloc/delete mismatch: dfaure.
Mar 14 2019, 7:21 PM · Frameworks, Dolphin
anthonyfieroni added inline comments to D17643: Multiple Splits per Tab.
Mar 14 2019, 10:34 AM · Konsole
anthonyfieroni added reviewers for D19745: Fix system tray UI/UX & refactor: VDG, Plasma, broulik.

Video or screenshot will be helpful.

Mar 14 2019, 4:56 AM · Plasma

Mar 7 2019

anthonyfieroni added inline comments to D19327: Karbon: Enable multi page capability.
Mar 7 2019, 6:33 PM · Calligra: 3.0
anthonyfieroni added inline comments to D19588: [Notifications] Improve finished notification.
Mar 7 2019, 12:12 PM · Plasma
anthonyfieroni added inline comments to D19559: Move management of QWebEngineProfile to WebEnginePage, to avoid crash on KMail exit or viewer window close.
Mar 7 2019, 11:55 AM · KDE PIM

Mar 6 2019

anthonyfieroni added inline comments to D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption.
Mar 6 2019, 5:41 PM · Plasma

Feb 26 2019

anthonyfieroni added inline comments to D17643: Multiple Splits per Tab.
Feb 26 2019, 6:15 AM · Konsole
anthonyfieroni added reviewers for D19323: fix crash when mapping unified mailboxes to collections: dvratil, mlaurent.
Feb 26 2019, 6:05 AM · KDE PIM

Feb 22 2019

anthonyfieroni added inline comments to D19216: Karbon: Enable multi page capability.
Feb 22 2019, 2:53 PM · Calligra: 3.0
anthonyfieroni added inline comments to D19216: Karbon: Enable multi page capability.
Feb 22 2019, 1:46 PM · Calligra: 3.0
anthonyfieroni updated the diff for D14583: [MainWindow] Navigate through mouse forward/back buttons.

Test now, i can't reproduce behavior mentioned above.

Feb 22 2019, 5:55 AM · Gwenview
anthonyfieroni abandoned D18249: [datamodel] Rework items insert/remove.
Feb 22 2019, 5:30 AM · Frameworks

Feb 21 2019

anthonyfieroni added inline comments to D19194: Adjust date string height to match time string with vertical panel.
Feb 21 2019, 8:22 AM · Plasma

Feb 20 2019

anthonyfieroni added inline comments to D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Feb 20 2019, 5:35 PM · Dolphin

Feb 16 2019

anthonyfieroni added inline comments to D19036: [notifications] Lift up notification content if one line of body text droops.
Feb 16 2019, 6:29 AM · Plasma

Feb 12 2019

anthonyfieroni added a comment to D18963: Improve KoModeBox display in horizontal Mode.

It's good to +1

Feb 12 2019, 3:56 PM · Calligra: 3.0
anthonyfieroni added a reviewer for D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*: kossebau.
Feb 12 2019, 3:31 PM · Plasma

Feb 7 2019

anthonyfieroni added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

Ok, so @trmdi you can apply exactly David suggest and discard D18804, i've test it and it works. Push it in 5.15 not 5.16 that's bug fix not feature. 5.12 can be also interested path as LTS version.

Feb 7 2019, 4:15 PM · Plasma
anthonyfieroni added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

@davidedmundson it works. I really don't know that sharing model between contexts cause a such behavior. It's caused by some ref counting ? Did you know why, it's internal Qt issue that we can fix or it's expected ?

Feb 7 2019, 12:24 PM · Plasma
anthonyfieroni added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in.

Feb 7 2019, 9:25 AM · Plasma
anthonyfieroni added a comment to D18804: Workaround for the bug 393630 - Framework part.

Did you understand why it happen?

Feb 7 2019, 8:06 AM · Frameworks
anthonyfieroni added a reviewer for D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency: davidedmundson.
Feb 7 2019, 5:01 AM · Frameworks

Feb 6 2019

anthonyfieroni added a reviewer for D18781: Fix SQLite backend foreign key PRAGMAs: dvratil.
Feb 6 2019, 9:26 AM · KDE PIM
anthonyfieroni added a comment to D18781: Fix SQLite backend foreign key PRAGMAs.

I notice it, because i use SQLite backend, LGTM to me +1

Feb 6 2019, 9:26 AM · KDE PIM

Feb 2 2019

anthonyfieroni added inline comments to D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.
Feb 2 2019, 6:06 PM · Build System, Frameworks
anthonyfieroni committed R318:83912a6de826: Fix member initialization (authored by anthonyfieroni).
Fix member initialization
Feb 2 2019, 5:48 PM
anthonyfieroni committed R318:ec29cfff2017: [versioncontrolobserver] Update working directory on tab activation (authored by anthonyfieroni).
[versioncontrolobserver] Update working directory on tab activation
Feb 2 2019, 5:38 PM
anthonyfieroni closed D18605: [versioncontrolobserver] Update working directory on tab activation.
Feb 2 2019, 5:38 PM · Dolphin

Jan 31 2019

anthonyfieroni updated the diff for D18605: [versioncontrolobserver] Update working directory on tab activation.
Jan 31 2019, 5:18 AM · Dolphin

Jan 30 2019

anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

This solution is Qt <5.12 friendly

Jan 30 2019, 12:40 PM · Calligra: 3.0

Jan 29 2019

anthonyfieroni updated the diff for D18605: [versioncontrolobserver] Update working directory on tab activation.

Let's make public slot approach.

Jan 29 2019, 6:56 PM · Dolphin
anthonyfieroni added a comment to D18605: [versioncontrolobserver] Update working directory on tab activation.

VersionControlObserver is exported class changing its constructor type parameter can brake ABI, but does it user of ? In other hand addition of public slot is ABI comfortable, so another approach can be better solution.

Jan 29 2019, 6:45 PM · Dolphin
anthonyfieroni requested review of D18605: [versioncontrolobserver] Update working directory on tab activation.
Jan 29 2019, 6:41 PM · Dolphin
anthonyfieroni committed R318:9a9fbae98814: [versioncontrolobserver] Do not use static plugin objects (authored by anthonyfieroni).
[versioncontrolobserver] Do not use static plugin objects
Jan 29 2019, 6:28 PM
anthonyfieroni closed D17640: [versioncontrolobserver] Do not use static plugin objects.
Jan 29 2019, 6:28 PM · Dolphin
anthonyfieroni added a comment to D18089: KLauncher: handle processes exiting without error.

+1

Jan 29 2019, 8:56 AM · Frameworks
anthonyfieroni added inline comments to D17640: [versioncontrolobserver] Do not use static plugin objects.
Jan 29 2019, 6:35 AM · Dolphin

Jan 26 2019

anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

So just don't call slotFilePrint connect loadCompleted to slotFilePrint. When openDocumentInternal downloads the document it fires signal of finish, just connect to slot of opened it.

Jan 26 2019, 5:24 PM · Calligra: 3.0
anthonyfieroni added a comment to D18249: [datamodel] Rework items insert/remove.

I investigate on testing this patch, it does not fix systray issue, to discard it?

Jan 26 2019, 8:30 AM · Frameworks

Jan 25 2019

anthonyfieroni added a comment to D18466: Fixed calligra crashing when opening remote document.

Probably we need to start printing in a slot connected to KoMainWindow::loadCompleted() instead.
And to be safe, we also need to handle loadCanceled().

Jan 25 2019, 9:04 AM · Calligra: 3.0

Jan 21 2019

anthonyfieroni updated subscribers of D17640: [versioncontrolobserver] Do not use static plugin objects.

@alexeymin, can you try this patch as well, it's pretty annoying to have 5+ versioned tabs, error in one to be shown in others.

Jan 21 2019, 7:26 PM · Dolphin
anthonyfieroni committed R449:9f8f6c152116: [gitpushdialog] Check GitWrapper::branches index validity (authored by anthonyfieroni).
[gitpushdialog] Check GitWrapper::branches index validity
Jan 21 2019, 7:23 PM
anthonyfieroni closed D18289: [gitpushgialog] Check index validity.
Jan 21 2019, 7:23 PM
anthonyfieroni added a comment to D18289: [gitpushgialog] Check index validity.

branches is a QStringList, so, we could also check that currentBranchIndex < branches.size() in condition, if it is all about bounds checking.

Jan 21 2019, 7:18 PM
anthonyfieroni added a comment to D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action.

+1

Jan 21 2019, 11:55 AM · Frameworks

Jan 20 2019

anthonyfieroni added a comment to D17640: [versioncontrolobserver] Do not use static plugin objects.

ping, issue is real and annoying.

Jan 20 2019, 5:27 PM · Dolphin
anthonyfieroni added a comment to D18289: [gitpushgialog] Check index validity.

ping

Jan 20 2019, 5:26 PM

Jan 16 2019

anthonyfieroni added a comment to D17882: Abort updateWindowTitle and activeViewChanged if not changed..

+1 it looks good to me.

Jan 16 2019, 2:22 PM · Dolphin
anthonyfieroni updated the diff for D18249: [datamodel] Rework items insert/remove.
Jan 16 2019, 1:02 PM · Frameworks