anthonyfieroni (Anthony Fieroni)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2015, 10:58 AM (138 w, 1 d)
Availability
Available

Recent Activity

Yesterday

anthonyfieroni added a comment to D12371: fix always reproducible crash.

Can you verify who calls lister with file:///kk -> this is not correct it should be file://kk (2 slashes) then Cache will start to work again.

Wed, Apr 25, 8:52 AM · Frameworks

Tue, Apr 24

anthonyfieroni added a comment to D12490: concatPaths: process empty path1 correctly.

Q_ASSERT(!path2.startsWith(QLatin1Char('/')));

If path1 is empty path2 will point to full path not absolute e.g. /something it should be ./something.

Tue, Apr 24, 1:28 PM · Frameworks
anthonyfieroni added a comment to D12490: concatPaths: process empty path1 correctly.

path1 *should* never be empty

Tue, Apr 24, 12:00 PM · Frameworks

Sun, Apr 22

anthonyfieroni added a comment to D12448: Fix KCompletionBox on wayland.

Why not

static const auto flags = qGuiApp->platformName() == QLatin1String("wayland") ? Qt::WindowFlags(Qt::ToolTip | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint) :
                                                                                Qt::WindowFlags(Qt::Window | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint);
q->setWindowFlags(flags);

It's not need to check in every completion construction.

Sun, Apr 22, 5:27 PM · Frameworks

Wed, Apr 18

anthonyfieroni added inline comments to D12315: Fixed crash at shutdown.
Wed, Apr 18, 6:38 PM · Amarok

Tue, Apr 17

anthonyfieroni added a comment to D12271: Don't remove trailing whitespace from cursor line.

But if you do this

do_work(); |

will not remove trailling space after ';' before corsor. You should explicit chaeck that you have only whitespace on the line.

Tue, Apr 17, 8:48 AM · Frameworks, Kate, KTextEditor
anthonyfieroni added inline comments to D12240: Save the dialog view settings when closing the dialog without hitting the cancel button.
Tue, Apr 17, 3:58 AM · Plasma
anthonyfieroni added inline comments to D12240: Save the dialog view settings when closing the dialog without hitting the cancel button.
Tue, Apr 17, 3:45 AM · Plasma

Sun, Apr 15

anthonyfieroni added inline comments to D12231: Reduce the number of zombies to a minimum.
Sun, Apr 15, 7:44 PM · Frameworks

Sat, Apr 14

anthonyfieroni added inline comments to D12162: Support for touch scrolling in Dolphin.
Sat, Apr 14, 5:58 AM · Dolphin

Wed, Apr 11

anthonyfieroni added inline comments to D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views.
Wed, Apr 11, 4:46 AM

Mon, Apr 9

anthonyfieroni added a comment to D11871: [DolphinTabWidget] Rewrite tab widget close.

Make sure focus is in search box when you click on add tab.

Mon, Apr 9, 6:17 PM
anthonyfieroni added inline comments to D12068: Add Screenshot portal.
Mon, Apr 9, 4:01 PM

Sat, Apr 7

anthonyfieroni added a comment to D11871: [DolphinTabWidget] Rewrite tab widget close.

Perform search then click Add new tab, I'm on Qt 10.1

Sat, Apr 7, 2:43 PM
anthonyfieroni added a comment to D11979: Automatically show and hide selection markers based on single click/double click setting.

You can prevent markers to be paint when ctrl is hold.

Sat, Apr 7, 5:12 AM

Fri, Apr 6

anthonyfieroni added a comment to D11979: Automatically show and hide selection markers based on single click/double click setting.

Why? I'm using double click and markers since 2009.

Fri, Apr 6, 5:10 AM

Wed, Apr 4

anthonyfieroni added a comment to D11871: [DolphinTabWidget] Rewrite tab widget close.

@elvisangelaccio, did you have any objections?

Wed, Apr 4, 11:49 AM

Tue, Apr 3

anthonyfieroni added a comment to D11897: Expose group information to Dolphin's Information panel, tooltips, etc.

Patch does not contains strings why it's targeted for 18.08?

Tue, Apr 3, 9:24 PM · Baloo

Sun, Apr 1

anthonyfieroni requested review of D11871: [DolphinTabWidget] Rewrite tab widget close.
Sun, Apr 1, 7:19 PM

Mar 25 2018

anthonyfieroni added a reviewer for D11669: Fix pixmap scaling on HiDPI screens: lesliezhai.
Mar 25 2018, 4:56 AM

Mar 23 2018

anthonyfieroni added inline comments to D11590: Add mutex round static member used in a thread.
Mar 23 2018, 5:15 AM · Plasma

Mar 22 2018

anthonyfieroni added a comment to D10014: PictureShape: fix CropWidget rendering.

@pettke can you commit it?

Mar 22 2018, 7:30 PM · Calligra: 3.0
anthonyfieroni added reviewers for D11569: Improve consistency of "Open With" UI by always showing top app inline: dfaure, elvisangelaccio.

+1
@dfaure and @elvisangelaccio can have other objections.

Mar 22 2018, 2:32 PM · Frameworks
anthonyfieroni added inline comments to D11569: Improve consistency of "Open With" UI by always showing top app inline.
Mar 22 2018, 2:25 PM · Frameworks
anthonyfieroni added a comment to D7946: CSV characters should not be translated.

What is state of this review @mecir ?

Mar 22 2018, 8:30 AM · Calligra: 3.0
anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

I try what you want (screenshot)
https://phabricator.kde.org/file/data/lpjuzqc2vi4a74potaml/PHID-FILE-53wfjewtgqjv4wm7tvgq/Screenshot_20180115_102720.png
As you can see if fit to size isn't checked text is *cutted* (selected one) but you can see it does not have percentage but cm.

Mar 22 2018, 8:28 AM · Calligra: 3.0
anthonyfieroni accepted D11454: Fix build with Qt 5.11 (missing headers).

You can commit it if @danders does not have any objections, but it look resonable to me.

Mar 22 2018, 8:25 AM · Calligra: 3.0
anthonyfieroni added a comment to D11571: [Battery Monitor] Support "Gaming Input Battery type".

@broulik, does it makes sens, when batteries isn't available (as your screenshot) to be shown, the icon and its percentage of next device in the list, in systray ?

Mar 22 2018, 8:23 AM · Plasma
anthonyfieroni added inline comments to D11487: optimization of TextLineData::attribute.
Mar 22 2018, 5:48 AM · Frameworks, Kate
anthonyfieroni added inline comments to D11569: Improve consistency of "Open With" UI by always showing top app inline.
Mar 22 2018, 5:02 AM · Frameworks

Mar 17 2018

anthonyfieroni added inline comments to D10883: Ability to view git diff (with difftool) for selected file.
Mar 17 2018, 6:35 PM

Mar 15 2018

anthonyfieroni added inline comments to D11322: Add Qt5KeyChain support to store the password.
Mar 15 2018, 1:06 PM

Mar 13 2018

anthonyfieroni added reviewers for D11292: [RFC] Ordered system tray v2: Plasma, VDG.
Mar 13 2018, 8:03 PM · Plasma
anthonyfieroni added inline comments to D11292: [RFC] Ordered system tray v2.
Mar 13 2018, 8:03 PM · Plasma

Mar 11 2018

anthonyfieroni added inline comments to D11232: Make qstring_t and qbytearray_t into POD types.
Mar 11 2018, 7:38 PM
anthonyfieroni added inline comments to D11233: Ordered system tray.
Mar 11 2018, 4:37 PM · Plasma
anthonyfieroni added inline comments to D11232: Make qstring_t and qbytearray_t into POD types.
Mar 11 2018, 3:08 PM
anthonyfieroni added reviewers for D11233: Ordered system tray: Plasma, VDG.
Mar 11 2018, 3:01 PM · Plasma
anthonyfieroni added inline comments to D11232: Make qstring_t and qbytearray_t into POD types.
Mar 11 2018, 2:51 PM
anthonyfieroni added a comment to D11078: Fix crash stemming from mismatch of the C++ and Rust interfaces bug #389419.

Most of Qt classes are same size as void* to keep ABI compatibility so you can try:

typedef void (*qstring_set)(QString*, void*);
void set_qstring(QString* v, void* val) {
    static_assert(sizeof(void*) >= sizeof(QString), "QString has a bigger size than void*, code below will crash");
    *v = *(QString*)&val;
}
Mar 11 2018, 6:23 AM

Mar 10 2018

anthonyfieroni added inline comments to D11048: Convert hard coded shortcuts to standard keys.
Mar 10 2018, 8:35 PM
anthonyfieroni added inline comments to D11204: Support NTFS hidden files.
Mar 10 2018, 9:45 AM · Frameworks

Mar 9 2018

anthonyfieroni added inline comments to D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming.
Mar 9 2018, 12:53 PM · Dolphin

Mar 7 2018

anthonyfieroni added inline comments to D11132: Avoid an asan runtime error.
Mar 7 2018, 3:41 PM · Frameworks

Mar 5 2018

anthonyfieroni committed R259:acf0665257e9: Hide thumbnail widget after video ends (authored by anthonyfieroni).
Hide thumbnail widget after video ends
Mar 5 2018, 8:14 PM
anthonyfieroni closed D11060: Hide thumbnail view after video stops.
Mar 5 2018, 8:14 PM
anthonyfieroni added a comment to T8149: Rewritten Dragon player UI in Kirigami (QML).

But Qt itself uses GStreamer and it has QtMultimedia, it can be used without external depends, right? This is "native" decision about me.

Mar 5 2018, 4:33 PM
anthonyfieroni triaged T8149: Rewritten Dragon player UI in Kirigami (QML) as Wishlist priority.
Mar 5 2018, 2:43 PM
anthonyfieroni requested review of D11060: Hide thumbnail view after video stops.
Mar 5 2018, 2:31 PM
anthonyfieroni committed R259:c0d82f24729d: Show inhibition text (authored by anthonyfieroni).
Show inhibition text
Mar 5 2018, 2:17 PM
anthonyfieroni closed D11042: [dragon] Show notification restriction text.
Mar 5 2018, 2:17 PM
anthonyfieroni updated the diff for D11042: [dragon] Show notification restriction text.
Mar 5 2018, 7:39 AM
anthonyfieroni requested review of D11042: [dragon] Show notification restriction text.
Mar 5 2018, 6:59 AM

Mar 4 2018

anthonyfieroni added a comment to D10890: Don't skip certain recent documents in kicker and taskmanager.

It looks good to me

Mar 4 2018, 8:07 PM · Plasma
anthonyfieroni added inline comments to D10820: Send slave's polkit authorization status to the host.
Mar 4 2018, 6:57 AM · Frameworks

Mar 1 2018

anthonyfieroni added a reviewer for D10835: [kicker] Never execute recent documents: hein.
Mar 1 2018, 3:36 PM · Plasma

Feb 28 2018

anthonyfieroni added a comment to D10890: Don't skip certain recent documents in kicker and taskmanager.

So why you called hack, why no just add conditional compilation against 5.44

Feb 28 2018, 7:37 AM · Plasma

Feb 26 2018

anthonyfieroni added inline comments to D10826: [WIP] Introduce DocumentId class.
Feb 26 2018, 8:20 AM · Frameworks, Baloo
anthonyfieroni added inline comments to D10835: [kicker] Never execute recent documents.
Feb 26 2018, 8:07 AM · Plasma

Feb 25 2018

anthonyfieroni added inline comments to D10466: Prevent Akregator from overwriting feeds.opml with an emtpy feed list.
Feb 25 2018, 7:51 PM · KDE PIM
anthonyfieroni added a comment to D10466: Prevent Akregator from overwriting feeds.opml with an emtpy feed list.

You can commit it on its behalf :)

Feb 25 2018, 4:54 PM · KDE PIM

Feb 23 2018

Restricted Application edited projects for D10750: wayland: Add support for zwp_linux_dmabuf, added: Plasma; removed KWin.
Feb 23 2018, 6:11 PM · KWin

Feb 21 2018

anthonyfieroni added inline comments to D10512: try to preload certain applets in a smart way.
Feb 21 2018, 7:29 AM · Frameworks, Plasma

Feb 20 2018

anthonyfieroni added a reviewer for D10683: Fix compilation on Qt 5.6: rkflx.
Feb 20 2018, 3:19 PM · Spectacle

Feb 19 2018

anthonyfieroni added inline comments to D10512: try to preload certain applets in a smart way.
Feb 19 2018, 6:15 PM · Frameworks, Plasma
anthonyfieroni edited reviewers for D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying, added: dfaure; removed: Dolphin.

It looks D10635 is duplicate.

Feb 19 2018, 5:54 PM · Frameworks

Feb 17 2018

anthonyfieroni added a comment to D9829: Don't create 2 msgbox (one of them crashes) when can't change rights.

What is state of this?

Feb 17 2018, 7:54 PM · Frameworks
anthonyfieroni added reviewers for D10610: Fix favicons in firefox bookmarks runner: Plasma, broulik.
Feb 17 2018, 6:49 PM · Plasma

Feb 16 2018

anthonyfieroni added a comment to D10587: Restore KTextEditor Document Dbus bindings.

I don't think I would know how to make these changes. I was only able to get this to work because it was mostly a simple revert.

Feb 16 2018, 10:37 PM · Frameworks, Kate, KTextEditor
anthonyfieroni accepted D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager.

It looks good to me.

Feb 16 2018, 5:31 PM · Plasma
anthonyfieroni added a comment to D10587: Restore KTextEditor Document Dbus bindings.

It will not break compatibility or you should supposed how? Kate and KWrite present in same repo, so the code can be shared, but yes it will not have this feature in other apps that uses KTextEditor. But you can read @cullmann wrote in bug report that it doesn't want KTextEditor to depend on QDBus.

Feb 16 2018, 5:26 PM · Frameworks, Kate, KTextEditor
anthonyfieroni added a comment to D10587: Restore KTextEditor Document Dbus bindings.

You can try to add DBus in Kate (application) rather than KTextEditor (framework).

Feb 16 2018, 5:09 PM · Frameworks, Kate, KTextEditor

Feb 14 2018

anthonyfieroni added inline comments to D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333).
Feb 14 2018, 6:00 PM · Plasma

Feb 12 2018

anthonyfieroni added a reviewer for D10466: Prevent Akregator from overwriting feeds.opml with an emtpy feed list: mlaurent.

https://phabricator.kde.org/source/akregator/browse/master/src/akregator_part.cpp;fab007f05d5e09d3ce5755cd3ea40a32392b48d5$531
You can make instead

if (xml.isEmpty()) {
    return;
}
Feb 12 2018, 6:05 PM · KDE PIM

Feb 11 2018

anthonyfieroni added a reviewer for D8267: Correcting symlinks between col- and row-resize and split_v and _h Bug 384864: apol.
Feb 11 2018, 12:40 PM · Plasma
anthonyfieroni added inline comments to D10437: Update file ioslave's temporary authorization list.
Feb 11 2018, 12:26 PM · Frameworks

Feb 10 2018

anthonyfieroni added a comment to D10429: Disable the title bar separator by default.

-1

Feb 10 2018, 10:45 PM · Plasma
anthonyfieroni added inline comments to D10424: Always exit after notification is closed.
Feb 10 2018, 5:44 PM
anthonyfieroni added a reviewer for D10421: Add options to disable some/all buttons when hovering over thumbnails: rkflx.
Feb 10 2018, 7:59 AM

Feb 9 2018

anthonyfieroni added a comment to D9537: [kotextlayoutarea] Make percentage line height relative to the default height.

Ping

Feb 9 2018, 9:02 PM · Calligra: 3.0
anthonyfieroni committed R449:0767eb45c569: [git plugin] Add merge action (authored by anthonyfieroni).
[git plugin] Add merge action
Feb 9 2018, 8:57 PM
anthonyfieroni closed D10213: [fileviewgitplugin] Add merge option.
Feb 9 2018, 8:57 PM
anthonyfieroni committed R449:92ea669a154b: [git plugin] Add log action (authored by anthonyfieroni).
[git plugin] Add log action
Feb 9 2018, 8:57 PM
anthonyfieroni closed D10267: [fileviewgitplugin] Add log action.
Feb 9 2018, 8:57 PM
anthonyfieroni updated the diff for D10267: [fileviewgitplugin] Add log action.
Feb 9 2018, 8:24 AM

Feb 8 2018

anthonyfieroni added a comment to D10267: [fileviewgitplugin] Add log action.

Is it normal that the dolphin process does not quit if I close the dolphin window but not the Git Log window?

Feb 8 2018, 9:03 PM
anthonyfieroni added inline comments to D10297: Add new "Tools" button above System Monitor's process list.
Feb 8 2018, 6:52 PM · Plasma
anthonyfieroni added a comment to D10267: [fileviewgitplugin] Add log action.

Ping, is it good to go in?

Feb 8 2018, 11:11 AM

Feb 4 2018

anthonyfieroni added a comment to D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list.

You should increase minimal required plasma-framework version to 5.44 but when you do this the patch goes to master i.e. 5.13.

Feb 4 2018, 7:54 PM · Plasma

Feb 3 2018

anthonyfieroni updated the diff for D10267: [fileviewgitplugin] Add log action.

Use QTextBrowser instead of QWebEngine

Feb 3 2018, 7:03 PM
anthonyfieroni added a comment to D10267: [fileviewgitplugin] Add log action.

I can give try to QTextBrowser?

Feb 3 2018, 4:23 PM
anthonyfieroni updated the diff for D10213: [fileviewgitplugin] Add merge option.
Feb 3 2018, 3:58 PM
anthonyfieroni updated the diff for D10267: [fileviewgitplugin] Add log action.

Small css fixes.

Feb 3 2018, 3:52 PM
anthonyfieroni added a comment to D10267: [fileviewgitplugin] Add log action.

I have also idea to draw graph at left side but i don't find any "easy way" to do it :D

Feb 3 2018, 1:43 PM
anthonyfieroni added a comment to D10267: [fileviewgitplugin] Add log action.

The main idea behind WebEngineView is that git to generate content, sticky header and only bottom border. Furthermore the code still looks simple as is.

Feb 3 2018, 1:25 PM

Feb 1 2018

anthonyfieroni added inline comments to D10085: Faster drag&drop in directories with thousands of files.
Feb 1 2018, 5:31 PM

Jan 30 2018

anthonyfieroni committed R260:7769905d5469: Provide a dialog helper to handle its destruction (authored by anthonyfieroni).
Provide a dialog helper to handle its destruction
Jan 30 2018, 8:20 PM
anthonyfieroni closed D9731: Provide a dialog helper to handle properly its destruction.
Jan 30 2018, 8:20 PM
anthonyfieroni added inline comments to D10189: Let the terminal panel dock to any part of the window.
Jan 30 2018, 4:14 AM

Jan 29 2018

anthonyfieroni added a comment to D9731: Provide a dialog helper to handle properly its destruction.

17.12 or master ? I have some troubles with newer ram stick, i'll commit it soon i can.

Jan 29 2018, 6:10 AM