anthonyfieroni (Anthony Fieroni)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2015, 10:58 AM (168 w, 12 h)
Availability
Available

Recent Activity

Today

anthonyfieroni added inline comments to D16971: Depend on KDE Frameworks 5.41.
Tue, Nov 20, 6:29 PM

Yesterday

anthonyfieroni added a comment to D16918: [brightnesscontrol] Do not change screen brightness on invalid values.

So i made simple script to test, it looks like the problem is that

xset dpms force off
sleep 1
cat /sys/class/backlight/intel_backlight/max_brightness
cat /sys/class/backlight/intel_backlight/brightness
cat /sys/class/backlight/intel_backlight/actual_brightness

Results:

187
22
0
Mon, Nov 19, 6:30 PM · Plasma

Sun, Nov 18

anthonyfieroni added a comment to D16890: [systemtray] Keep config entries after modifying.

But for some reason, on second Entries show warnings says: cannot call createObject on null object. Looks like it is treated as local object or something.

Sun, Nov 18, 6:56 PM · Plasma
anthonyfieroni added a comment to D16926: Review user interaction in session management.

Done. BTW I had tried to change the order of the menu entries, without success (?)

Sun, Nov 18, 9:54 AM · Kate
anthonyfieroni added a comment to D16926: Review user interaction in session management.

You should increase version to 84 https://phabricator.kde.org/source/kate/browse/master/kate/data/kateui.rc$3 Also you can generate diffs like git diff -U9999 > file for context to present.

Sun, Nov 18, 7:49 AM · Kate

Fri, Nov 16

anthonyfieroni requested review of D16918: [brightnesscontrol] Do not change screen brightness on invalid values.
Fri, Nov 16, 8:42 AM · Plasma
anthonyfieroni updated the diff for D16856: [comic] Sync configuration on write.

Better not change data engine

Fri, Nov 16, 6:53 AM · Plasma
anthonyfieroni updated the summary of D16856: [comic] Sync configuration on write.
Fri, Nov 16, 6:52 AM · Plasma

Thu, Nov 15

anthonyfieroni added a comment to D16890: [systemtray] Keep config entries after modifying.

Weird. If configuration window stays open, clicks in systray work correct, when it's dismissed clicks are incorrect.

Thu, Nov 15, 1:26 PM · Plasma
anthonyfieroni updated the diff for D16890: [systemtray] Keep config entries after modifying.
Thu, Nov 15, 8:30 AM · Plasma
anthonyfieroni requested review of D16890: [systemtray] Keep config entries after modifying.
Thu, Nov 15, 8:00 AM · Plasma

Wed, Nov 14

anthonyfieroni requested review of D16873: [comic] Request current identifier on date changed.
Wed, Nov 14, 6:51 AM · Plasma

Tue, Nov 13

anthonyfieroni requested review of D16856: [comic] Sync configuration on write.
Tue, Nov 13, 6:57 AM · Plasma
anthonyfieroni committed R120:d53622d7d9e0: [clipboard] Limit length of clipboard text item visualisation (authored by anthonyfieroni).
[clipboard] Limit length of clipboard text item visualisation
Tue, Nov 13, 6:45 AM
anthonyfieroni closed D16842: [clipboard] Limit length of clipboard text item visualisation.
Tue, Nov 13, 6:45 AM · Plasma

Mon, Nov 12

anthonyfieroni updated the diff for D16844: [comic] Correct usage of DataEngineConsumer.

Fix diff

Mon, Nov 12, 5:48 PM · Plasma
anthonyfieroni requested review of D16844: [comic] Correct usage of DataEngineConsumer.
Mon, Nov 12, 5:46 PM · Plasma
anthonyfieroni requested review of D16842: [clipboard] Limit length of clipboard text item visualisation.
Mon, Nov 12, 5:39 PM · Plasma

Sat, Nov 10

anthonyfieroni added a comment to D16721: Use Krita toolbar in Karbon.

Force pushes are generally reserved for pretty serious issues, couldn't the whitespace be corrected with a follow up commit to remove it?

Sat, Nov 10, 9:03 AM · Calligra: 3.0
anthonyfieroni added a comment to D16784: Remove whitespace created by D16721.

But it's not only that https://phabricator.kde.org/R8:a7ee6f871af225fd5edc9458ee183604fabadc8a
Notice ~SectionLayout() and many others, you should use settings that trim whitespaces on file save. In Kate -> settings -> open/save -> Remove trailing spaces -> In entire document.

Sat, Nov 10, 9:01 AM · Calligra: 3.0

Fri, Nov 9

anthonyfieroni updated subscribers of D16721: Use Krita toolbar in Karbon.

Please contact @bcooksley to remote all white space changes from you commit. Please be more precise when you commit, you introduce even more white spaces rather than to remove them.

Fri, Nov 9, 5:51 PM · Calligra: 3.0
anthonyfieroni accepted D16721: Use Krita toolbar in Karbon.

Please, remove all white space changes before commit. It will be better if you test the patch some time without crash or other downsides. If you notice something wrong write here. If all is good you can commit in few days. Thank you for patch, other patches are welcome.

Fri, Nov 9, 4:33 PM · Calligra: 3.0
anthonyfieroni added a comment to D16721: Use Krita toolbar in Karbon.

Can you add screenshots of horizontal and vertical version, add it to test, just to have how it looks. I see some gestures that i cannot test, did you can, touchscreen, tablet or something that this code works :)

Fri, Nov 9, 1:17 PM · Calligra: 3.0
anthonyfieroni added inline comments to D16721: Use Krita toolbar in Karbon.
Fri, Nov 9, 7:09 AM · Calligra: 3.0
anthonyfieroni added a comment to D16721: Use Krita toolbar in Karbon.

Can you test my suggestions, it's looks good to me.

Fri, Nov 9, 7:08 AM · Calligra: 3.0

Thu, Nov 8

anthonyfieroni added a comment to D16721: Use Krita toolbar in Karbon.

Config, if it's not set explicitly, <appname> + "rc" https://api.kde.org/frameworks/kconfig/html/kconfig_8cpp_source.html#l00607

Thu, Nov 8, 11:29 AM · Calligra: 3.0
anthonyfieroni added inline comments to D16721: Use Krita toolbar in Karbon.
Thu, Nov 8, 8:55 AM · Calligra: 3.0

Wed, Nov 7

anthonyfieroni added a comment to D16721: Use Krita toolbar in Karbon.

Return QObjects, if you have problems copy linker output here.

Wed, Nov 7, 2:35 PM · Calligra: 3.0
anthonyfieroni added inline comments to D16643: Correct the accept flag of the event object on DragMove .
Wed, Nov 7, 6:54 AM · Frameworks
anthonyfieroni added a comment to D16721: Use Krita toolbar in Karbon.

I'm adding Krita as reviewer, because Karbon is unmaintained and I hope someone at Krita as some experience with the toolbox

Wed, Nov 7, 6:49 AM · Calligra: 3.0
anthonyfieroni accepted D16714: [Terminal Display] Don't hide the search box when scrolling with the keyboard.
Wed, Nov 7, 6:23 AM · Konsole

Tue, Nov 6

anthonyfieroni added inline comments to D16715: make global menu minimize state aware.
Tue, Nov 6, 6:36 PM · Plasma
anthonyfieroni added a comment to D16714: [Terminal Display] Don't hide the search box when scrolling with the keyboard.

Shift + Pg Up/Down works for me and why it will set up esc key?

Tue, Nov 6, 6:18 PM · Konsole
anthonyfieroni added a comment to D16704: [wayland] add enter/leave virtual desktop API.

Performing dynamic_cast without nullptr check is waste of time, use static_cast instead.

Tue, Nov 6, 12:30 PM · KWin

Sat, Nov 3

anthonyfieroni added a comment to D16648: Open externally called files/directories in new tabs.

--new-window will be more readable, about me. Add braces on one line conditions, tryRise should be raise ('try' does not make sense).

Sat, Nov 3, 6:53 PM · Dolphin

Fri, Oct 26

anthonyfieroni added inline comments to D16434: Fix keyboard layout change notifications.
Fri, Oct 26, 11:00 AM · Frameworks

Wed, Oct 24

anthonyfieroni closed D15616: [Comic] Handle error state correctly.
Wed, Oct 24, 3:33 PM · Plasma
anthonyfieroni committed R114:7c7c00798048: [comicprovider] Restart timer on redirect request (authored by anthonyfieroni).
[comicprovider] Restart timer on redirect request
Wed, Oct 24, 3:33 PM
anthonyfieroni added inline comments to D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob.
Wed, Oct 24, 8:11 AM · Frameworks
anthonyfieroni added inline comments to D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob.
Wed, Oct 24, 8:07 AM · Frameworks
anthonyfieroni added a comment to D15616: [Comic] Handle error state correctly.

@davidedmundson to commit or you have other objections?

Wed, Oct 24, 6:23 AM · Plasma

Mon, Oct 22

anthonyfieroni added a comment to D16367: EnhancedPathShape: Shape is moved/resized on save/load.

When i investigate to find out why it's saved square not rectangle i suspect that code, but i'm still not absolutely sure that it's wrong. Maybe @boemann knows better. If so can we remove m_viewBound as well?

Mon, Oct 22, 10:23 AM · Calligra: 3.0
anthonyfieroni added a comment to D16366: Fix crash with icon dialog.

https://phabricator.kde.org/source/kiconthemes/browse/master/src/kicondialog.cpp;fea52a4f204fd44d9a45e78a663964c326687e33$419
It should be

const QString fileName2 = path2.mid(path2.lastIndexOf(QLatin1Char('/')) + 1);

no?

Mon, Oct 22, 4:22 AM · Frameworks

Oct 18 2018

anthonyfieroni accepted D16289: Karbon: Add Anthony as maintainer and remove unmaintained.
Oct 18 2018, 7:23 AM · Calligra: 3.0

Oct 16 2018

anthonyfieroni added a comment to D16127: Annotation: Block adding comment to an annotation shape.

Looks good to me +1

Oct 16 2018, 11:40 AM · Calligra: 3.0
anthonyfieroni added a comment to D15763: Set correct image attributes on directory thumbnail.

+1

Oct 16 2018, 11:38 AM · Frameworks, Dolphin

Oct 15 2018

anthonyfieroni added inline comments to D16231: [ksmserver] Rewrite Startup.
Oct 15 2018, 8:33 PM · Plasma

Oct 14 2018

anthonyfieroni added a comment to D16198: Add support for dimming the colors when losing focus.

KWin has itself this feature for all windows, i've use it, this can be helpful on split view, did you test it with KWin effect enabled to verify that it does not look strange/incorrect?

Oct 14 2018, 4:22 PM · Konsole

Oct 12 2018

anthonyfieroni updated the diff for D15616: [Comic] Handle error state correctly.
Oct 12 2018, 1:26 PM · Plasma
anthonyfieroni added a comment to D15616: [Comic] Handle error state correctly.

The DataEngine also has a timer for timeouts, so we now have two timeout timers.
Having two timeout timers doesn't seem right.

Oct 12 2018, 12:46 PM · Plasma
anthonyfieroni added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Let's make some fix about that.

Oct 12 2018, 7:36 AM · Calligra: 3.0
anthonyfieroni added a comment to D15616: [Comic] Handle error state correctly.

Someone?

Oct 12 2018, 7:35 AM · Plasma
anthonyfieroni abandoned D15634: [WobblyWindows] Prevent hash table to grow significantly.
Oct 12 2018, 7:35 AM · KWin

Oct 11 2018

anthonyfieroni added inline comments to D16127: Annotation: Block adding comment to an annotation shape.
Oct 11 2018, 12:19 PM · Calligra: 3.0

Oct 9 2018

anthonyfieroni updated subscribers of D15053: Consistently use qreal in libs/pigment.

I'm OK with it +1, @danders or @boemann should accept it.

Oct 9 2018, 10:29 AM · Calligra: 3.0

Oct 5 2018

anthonyfieroni added inline comments to D15609: Add "Create New" menu to "Control" button.
Oct 5 2018, 7:42 AM · Dolphin
anthonyfieroni added inline comments to D15929: Add a 'Properties' entry in the Places panel context menu.
Oct 5 2018, 7:38 AM · Dolphin

Oct 4 2018

anthonyfieroni added a comment to D15775: Make the item background color and page cache properties available from View component.

Also can you add parentheses over single line code and if you know better way to get impl() without duplicate calls will be great :)

Oct 4 2018, 11:38 AM · Calligra: 3.0
anthonyfieroni added a comment to D15735: [effects/wobblywindows] Optimize wobbly windows effect.
In D15735#336368, @zzag wrote:

The Maximize effect causes that, not scene repaints. Please add the repaints back until we find proper solution.

Oct 4 2018, 10:32 AM · KWin
anthonyfieroni abandoned D15735: [effects/wobblywindows] Optimize wobbly windows effect.
In D15735#336368, @zzag wrote:

This patch has unrelated changes and you're objecting to remove them. Instead of focusing on one particular change, it shuffles code around, it alters behavior(e.g. removal of repaints), and it does code cleanup.

Oct 4 2018, 8:52 AM · KWin
anthonyfieroni added inline comments to D15735: [effects/wobblywindows] Optimize wobbly windows effect.
Oct 4 2018, 7:38 AM · KWin
anthonyfieroni added a comment to D15616: [Comic] Handle error state correctly.

Ping

Oct 4 2018, 5:54 AM · Plasma
anthonyfieroni updated the diff for D15735: [effects/wobblywindows] Optimize wobbly windows effect.
Oct 4 2018, 5:51 AM · KWin

Oct 2 2018

anthonyfieroni added inline comments to D15735: [effects/wobblywindows] Optimize wobbly windows effect.
Oct 2 2018, 1:36 PM · KWin
anthonyfieroni added inline comments to D15735: [effects/wobblywindows] Optimize wobbly windows effect.
Oct 2 2018, 11:29 AM · KWin
anthonyfieroni updated the diff for D15735: [effects/wobblywindows] Optimize wobbly windows effect.
Oct 2 2018, 11:12 AM · KWin
anthonyfieroni updated the diff for D15735: [effects/wobblywindows] Optimize wobbly windows effect.

Revert unrelated changes

Oct 2 2018, 10:55 AM · KWin
anthonyfieroni added a comment to D15735: [effects/wobblywindows] Optimize wobbly windows effect.

Mainly optimization + 1 change, maxTime is changed from 10 to 5 ms, effect looks more *smootly*, I hope someone of you to test it as well, I run it about a week on x11.

Oct 2 2018, 9:29 AM · KWin
anthonyfieroni added a comment to D15735: [effects/wobblywindows] Optimize wobbly windows effect.

Ping

Oct 2 2018, 7:27 AM · KWin
anthonyfieroni added a comment to D15616: [Comic] Handle error state correctly.

Ping

Oct 2 2018, 7:26 AM · Plasma

Oct 1 2018

anthonyfieroni added reviewers for D15887: Fix Klipper popup opening on default screen instead of at cursor position: Plasma, davidedmundson.
Oct 1 2018, 7:52 PM · Plasma
anthonyfieroni added inline comments to D15840: [Folder View] Remember selected item when navigating in subfolders.
Oct 1 2018, 1:19 PM · Plasma
anthonyfieroni added inline comments to D15840: [Folder View] Remember selected item when navigating in subfolders.
Oct 1 2018, 12:14 PM · Plasma
anthonyfieroni added a comment to D15875: [Media Controller] Disallow seeking beyond end of track.

1s file is a corner case as well as 0, cause you have always 2 positions - start and stop. In 0/1s these 2 steps just match, if you are right 0 isn't valid in 0s length file, does it?
+1 for the patch from me.

Oct 1 2018, 12:10 PM · Plasma

Sep 29 2018

anthonyfieroni added inline comments to D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data.
Sep 29 2018, 9:13 AM · Baloo, Frameworks

Sep 28 2018

anthonyfieroni accepted D15818: [Exe Thumbnailer] Ignore depth > 32.
Sep 28 2018, 4:59 PM · Frameworks, Dolphin
anthonyfieroni added a comment to D13854: Refactor Profile and ColorScheme.

@tcanabrava can you add backtrace?

Sep 28 2018, 4:56 PM · Konsole
anthonyfieroni added a comment to D15794: Check clipboard->mimeData() is valid.

Small nip-tick, +1 for the patch.

Sep 28 2018, 4:49 PM · Konsole
anthonyfieroni added inline comments to D15804: Fix Duplicates on Quick Open File.
Sep 28 2018, 7:50 AM · Kate

Sep 27 2018

anthonyfieroni added inline comments to D15735: [effects/wobblywindows] Optimize wobbly windows effect.
Sep 27 2018, 4:55 PM · KWin
anthonyfieroni added a comment to D15735: [effects/wobblywindows] Optimize wobbly windows effect.

@zzag did you test it, especially on Wayland?

Sep 27 2018, 6:32 AM · KWin

Sep 26 2018

anthonyfieroni added a comment to D15742: Handle middle click on tabs.

An "undo close tab" feature would be a really fantastic addition though.

Sep 26 2018, 1:04 PM · Konsole

Sep 25 2018

anthonyfieroni added a reviewer for D15616: [Comic] Handle error state correctly: broulik.
Sep 25 2018, 12:51 PM · Plasma
anthonyfieroni added inline comments to D15742: Handle middle click on tabs.
Sep 25 2018, 11:36 AM · Konsole
anthonyfieroni added a comment to D15402: [Thumbnails] Paint larger "one thumbnail" tile only when needed.

Looks good +1

Sep 25 2018, 8:44 AM · Frameworks, Dolphin
anthonyfieroni updated the diff for D15616: [Comic] Handle error state correctly.
Sep 25 2018, 8:24 AM · Plasma
anthonyfieroni updated the diff for D15735: [effects/wobblywindows] Optimize wobbly windows effect.
Sep 25 2018, 8:13 AM · KWin

Sep 24 2018

anthonyfieroni requested review of D15735: [effects/wobblywindows] Optimize wobbly windows effect.
Sep 24 2018, 6:48 PM · KWin
anthonyfieroni added a comment to D15616: [Comic] Handle error state correctly.

Ping, @davidedmundson let's make some change on this

Sep 24 2018, 6:14 AM · Plasma

Sep 23 2018

anthonyfieroni added a comment to D15634: [WobblyWindows] Prevent hash table to grow significantly.

I run it with debug messages for a while, there is no leak in windows neither in stackingOrder. @zzag if you have suggest to watch some variable or container change? I can transform this review to some profiling changes, removing double lookups, const ref against copying of Pair and so on.

Sep 23 2018, 6:31 PM · KWin

Sep 22 2018

anthonyfieroni updated the diff for D15616: [Comic] Handle error state correctly.

Stop indicator in a minute, restart engine in 10 sec.

Sep 22 2018, 6:43 PM · Plasma
anthonyfieroni added a comment to D15634: [WobblyWindows] Prevent hash table to grow significantly.
In D15634#330047, @zzag wrote:

Well, for the beginning, CPU profiling, I guess.

Sep 22 2018, 5:14 PM · KWin
anthonyfieroni added a comment to D13627: [KSharedDataCache] Assume lock before flush changes.

It looks can happen https://www.reddit.com/r/kde/comments/9hovrv/ive_been_having_this_randomly_icons_appears_to_be/
But i'm not sure that patch can handle it.

Sep 22 2018, 4:16 AM · Frameworks

Sep 21 2018

anthonyfieroni added a comment to D15634: [WobblyWindows] Prevent hash table to grow significantly.
In D15634#329858, @zzag wrote:

As I said earlier, please do proper analysis.

Sep 21 2018, 4:37 PM · KWin
anthonyfieroni added a comment to D15634: [WobblyWindows] Prevent hash table to grow significantly.
KWin Support Information:
The following information should be used when requesting support on e.g. http://forum.kde.org.
It provides information about the currently running instance, which options are used,
what OpenGL driver and which effects are running.
Please post the information provided underneath this introductory text to a paste bin service
like http://paste.kde.org instead of pasting into support threads.
Sep 21 2018, 1:05 PM · KWin
anthonyfieroni added a comment to D15634: [WobblyWindows] Prevent hash table to grow significantly.
In D15634#329417, @zzag wrote:

When you start to experience lags in the Wobbly Windows effects, can you please run

qdbus org.kde.KWin /KWin supportInformation
Sep 21 2018, 1:01 PM · KWin
anthonyfieroni added a comment to D15634: [WobblyWindows] Prevent hash table to grow significantly.

@broulik , @zzag did you have some ideas?

Sep 21 2018, 8:39 AM · KWin
anthonyfieroni updated the diff for D15616: [Comic] Handle error state correctly.

Another approach: If timer expires in 2 min without result disconnect it from source and starts again for next 2 min, when it expires if try to update again by activate slotCurrentDay

Sep 21 2018, 8:37 AM · Plasma
anthonyfieroni added a comment to D15634: [WobblyWindows] Prevent hash table to grow significantly.

Your are right, i don't have noticed it. So what i see when moving windows around (after several days usage) result in high cpu usage, looks like it preforms searching or other heavy operation.

Sep 21 2018, 7:54 AM · KWin
anthonyfieroni requested review of D15634: [WobblyWindows] Prevent hash table to grow significantly.
Sep 21 2018, 7:41 AM · KWin