iasensio (Ismael Asensio)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 7 2019, 10:42 PM (24 w, 3 d)
Availability
Available

Recent Activity

Tue, Jan 21

iasensio added a comment to D26659: [KCoreDirLister] Port QRegExp to QRegularExpression.

Hi! This change fails to build for me, and also in CI (https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/409/console)

Tue, Jan 21, 10:09 PM · Frameworks
iasensio added a comment to D26369: (search) Fix searching tags with spaces.

Seems like a candidate for the 19.12 branch, no?

Tue, Jan 21, 12:37 AM · Dolphin

Sun, Jan 19

iasensio committed R318:5778099ece7a: (search) Fix searching tags with spaces (authored by iasensio).
(search) Fix searching tags with spaces
Sun, Jan 19, 10:17 PM
iasensio closed D26369: (search) Fix searching tags with spaces.
Sun, Jan 19, 10:17 PM · Dolphin

Tue, Jan 14

iasensio removed a watcher for KWin: iasensio.
Tue, Jan 14, 12:10 AM

Sun, Jan 12

iasensio committed R318:a8dd6998407c: Get rid of -Wdeprecated-copy warning (authored by iasensio).
Get rid of -Wdeprecated-copy warning
Sun, Jan 12, 6:00 PM
iasensio closed D26585: Get rid of -Wdeprecated-copy warning.
Sun, Jan 12, 6:00 PM · Dolphin

Sat, Jan 11

iasensio added a watcher for KWin: iasensio.
Sat, Jan 11, 8:04 PM
iasensio requested review of D26585: Get rid of -Wdeprecated-copy warning.
Sat, Jan 11, 4:47 PM · Dolphin
This is a test notification, sent at Sat, Jan 11, 01:15.
Sat, Jan 11, 12:15 AM
This is a test notification, sent at Sat, Jan 11, 01:15.
Sat, Jan 11, 12:15 AM

Thu, Jan 9

iasensio updated the diff for D26369: (search) Fix searching tags with spaces.

Remove unnecessary variable

Thu, Jan 9, 12:55 AM · Dolphin
iasensio added a reviewer for D26369: (search) Fix searching tags with spaces: meven.
Thu, Jan 9, 12:11 AM · Dolphin
iasensio updated the diff for D26369: (search) Fix searching tags with spaces.

Better approach, by stripping out DolphinQuery

Thu, Jan 9, 12:06 AM · Dolphin

Wed, Jan 8

iasensio planned changes to D26369: (search) Fix searching tags with spaces.

Is it possible to add a test case in dolphinquerytest.cpp?

Wed, Jan 8, 2:45 PM · Dolphin

Mon, Jan 6

iasensio added inline comments to D26369: (search) Fix searching tags with spaces.
Mon, Jan 6, 7:17 PM · Dolphin
iasensio committed R318:296082b2b929: (search) Keep menu open when selecting tags (authored by iasensio).
(search) Keep menu open when selecting tags
Mon, Jan 6, 3:04 PM
iasensio closed D26343: (search) Keep menu open when selecting tags.
Mon, Jan 6, 3:04 PM · Dolphin
iasensio updated the diff for D26369: (search) Fix searching tags with spaces.

Only strip quotes and keep QString::mid() for clarity

Mon, Jan 6, 2:10 PM · Dolphin

Thu, Jan 2

iasensio added a reviewer for D26343: (search) Keep menu open when selecting tags: VDG.
Thu, Jan 2, 4:50 PM · Dolphin
iasensio added a comment to D26362: [Tentative] Move from the searchbox to the results.

As far as I can tell, currently the focus will change from the searchbar to the view when you press <Enter>.
Would that be an acceptable workflow?

Thu, Jan 2, 4:25 PM · Dolphin
iasensio added a comment to D26343: (search) Keep menu open when selecting tags.

The flickering in the current state is kind of unavoidable.
Every time a tag is clicked and a new search is made, the whole search url is reparsed and the menu gets repainted several times.
It seems to me that it is less annoying when the repainting is done "in the dark" and then show the menu again, that when it's keep visible the whole time.
Due to the way that tags are retrieved (using a KDirLister, as in the context menu) I cannot think of a better while simple way to do it without a major refactor and lots of extra code.

Thu, Jan 2, 4:21 PM · Dolphin
iasensio updated the diff for D26369: (search) Fix searching tags with spaces.

Sorry, I messed up with the diffs. Back to normal

Thu, Jan 2, 3:44 PM · Dolphin
iasensio updated the diff for D26343: (search) Keep menu open when selecting tags.

Going back to the simpler option.
This should have less flickering

Thu, Jan 2, 3:43 PM · Dolphin
iasensio updated the diff for D26369: (search) Fix searching tags with spaces.
Thu, Jan 2, 3:42 PM · Dolphin
iasensio added a comment to D26343: (search) Keep menu open when selecting tags.

Ehhhh, I find the flicker pretty annoying. :/

I think I'll re-upload the first revision so you can try it too, and decide on that.

Thu, Jan 2, 3:27 PM · Dolphin
iasensio requested review of D26369: (search) Fix searching tags with spaces.
Thu, Jan 2, 3:20 PM · Dolphin

Wed, Jan 1

iasensio added a comment to D26343: (search) Keep menu open when selecting tags.

I have uploaded the version with eventFilter so you may try if the flicker is too much to be annoying or it is just me.
I'd still prefer the simplest/maybe hackiest oneliner to just re-show the menu:

Wed, Jan 1, 5:28 PM · Dolphin
iasensio updated the diff for D26343: (search) Keep menu open when selecting tags.
  • Use eventFilter
Wed, Jan 1, 5:25 PM · Dolphin
iasensio added a comment to D26343: (search) Keep menu open when selecting tags.

I think you probably want to use an event filter instead to keep the menu from closing in the first place?

I'm not so sure I want to enter there 😃

Wed, Jan 1, 5:18 PM · Dolphin
iasensio updated the test plan for D26343: (search) Keep menu open when selecting tags.
Wed, Jan 1, 3:14 PM · Dolphin
iasensio updated the test plan for D26343: (search) Keep menu open when selecting tags.
Wed, Jan 1, 3:08 PM · Dolphin
iasensio requested review of D26343: (search) Keep menu open when selecting tags.
Wed, Jan 1, 3:06 PM · Dolphin
iasensio committed R178:2908bb8f09b8: [kldap] Fix compilation without LDAP (authored by iasensio).
[kldap] Fix compilation without LDAP
Wed, Jan 1, 1:58 PM
iasensio closed D26337: [kldap] Fix compilation without LDAP.
Wed, Jan 1, 1:58 PM · KDE PIM

Tue, Dec 31

iasensio requested review of D26337: [kldap] Fix compilation without LDAP.
Tue, Dec 31, 8:42 PM · KDE PIM

Sun, Dec 29

iasensio committed R318:c331d7068574: Clean-up DolphinFacetsWidget (authored by iasensio).
Clean-up DolphinFacetsWidget
Sun, Dec 29, 8:05 PM
iasensio closed D26150: Clean-up DolphinFacetsWidget.
Sun, Dec 29, 8:05 PM · Dolphin

Dec 26 2019

iasensio committed R318:732697d0d6fc: Rename methods on DolphinFacetsWidget (authored by iasensio).
Rename methods on DolphinFacetsWidget
Dec 26 2019, 6:30 PM
iasensio closed D26029: Rename methods on DolphinFacetsWidget.
Dec 26 2019, 6:30 PM · Dolphin
iasensio committed R318:4dc362db1ec5: Port from deprecated KIconLoader::IconSize() (authored by iasensio).
Port from deprecated KIconLoader::IconSize()
Dec 26 2019, 6:26 PM
iasensio closed D26237: Port from deprecated KIconLoader::IconSize().
Dec 26 2019, 6:26 PM · Dolphin
iasensio added a revision to T11637: Investigate if KIconThemes is needed as a framework: D26237: Port from deprecated KIconLoader::IconSize().
Dec 26 2019, 4:35 PM · KF6
iasensio added a task to D26237: Port from deprecated KIconLoader::IconSize(): T11637: Investigate if KIconThemes is needed as a framework.
Dec 26 2019, 4:35 PM · Dolphin
iasensio requested review of D26237: Port from deprecated KIconLoader::IconSize().
Dec 26 2019, 4:32 PM · Dolphin

Dec 21 2019

iasensio added a dependency for D26150: Clean-up DolphinFacetsWidget: D26029: Rename methods on DolphinFacetsWidget.
Dec 21 2019, 7:04 PM · Dolphin
iasensio added a dependent revision for D26029: Rename methods on DolphinFacetsWidget: D26150: Clean-up DolphinFacetsWidget.
Dec 21 2019, 7:04 PM · Dolphin
iasensio requested review of D26150: Clean-up DolphinFacetsWidget.
Dec 21 2019, 7:01 PM · Dolphin
iasensio updated the summary of D26029: Rename methods on DolphinFacetsWidget.
Dec 21 2019, 6:52 PM · Dolphin
iasensio updated the diff for D26029: Rename methods on DolphinFacetsWidget.
  • Only rename methods
Dec 21 2019, 6:50 PM · Dolphin
iasensio committed R318:616d4e6bdd70: fix(search): Correctly parse filename and/or content search (authored by iasensio).
fix(search): Correctly parse filename and/or content search
Dec 21 2019, 6:17 PM
iasensio closed D25416: fix(search): Correctly parse filename and/or content search.
Dec 21 2019, 6:17 PM · Dolphin

Dec 16 2019

iasensio added a comment to D25416: fix(search): Correctly parse filename and/or content search.

LGTM otherwise.

Dec 16 2019, 9:41 PM · Dolphin

Dec 15 2019

iasensio requested review of D26029: Rename methods on DolphinFacetsWidget.
Dec 15 2019, 10:33 PM · Dolphin
iasensio added inline comments to D25130: [dolphin/search] Search by (multiple) tags.
Dec 15 2019, 4:53 PM · Dolphin
iasensio updated the diff for D25416: fix(search): Correctly parse filename and/or content search.
  • Rebase and adapt tests
Dec 15 2019, 4:46 PM · Dolphin
iasensio committed R318:8e80c1d6dc1e: [dolphin/search] Search by (multiple) tags (authored by iasensio).
[dolphin/search] Search by (multiple) tags
Dec 15 2019, 4:28 PM
iasensio closed D25130: [dolphin/search] Search by (multiple) tags.
Dec 15 2019, 4:28 PM · Dolphin
iasensio updated the diff for D25416: fix(search): Correctly parse filename and/or content search.
  • Use QStringLiteral
Dec 15 2019, 3:27 PM · Dolphin

Dec 14 2019

iasensio committed R119:275195373cf1: [KCMs/Night Color] Fix 1-digit minutes representation (authored by iasensio).
[KCMs/Night Color] Fix 1-digit minutes representation
Dec 14 2019, 8:41 PM
iasensio closed D26002: [KCMs/Night Color] Fix 1-digit minutes representation.
Dec 14 2019, 8:41 PM · Plasma
iasensio retitled D26002: [KCMs/Night Color] Fix 1-digit minutes representation from [nightcolor] Fix 1-digit minutes representation to [KCMs/Night Color] Fix 1-digit minutes representation.
Dec 14 2019, 8:06 PM · Plasma
iasensio updated the summary of D26002: [KCMs/Night Color] Fix 1-digit minutes representation.
Dec 14 2019, 8:04 PM · Plasma
iasensio requested review of D26002: [KCMs/Night Color] Fix 1-digit minutes representation.
Dec 14 2019, 8:03 PM · Plasma
iasensio committed R293:34e682a1c0ed: Move URL parsing methods from kioslave to query object (authored by iasensio).
Move URL parsing methods from kioslave to query object
Dec 14 2019, 4:44 PM
iasensio closed D24433: Move URL parsing methods from kioslave to query object.
Dec 14 2019, 4:44 PM · Baloo, Frameworks
iasensio updated the diff for D24433: Move URL parsing methods from kioslave to query object.
  • Use return statements
Dec 14 2019, 3:15 PM · Baloo, Frameworks

Dec 12 2019

iasensio updated the diff for D25130: [dolphin/search] Search by (multiple) tags.

Clarify updateTagSelector logic

Dec 12 2019, 11:10 PM · Dolphin
l10n daemon script <scripty@kde.org> committed R286:dea539c7ed34: xattr: fix crash on dangling symlinks (authored by iasensio).
xattr: fix crash on dangling symlinks
Dec 12 2019, 10:37 PM
iasensio committed R286:4bb4195a6fc6: xattr: fix crash on dangling symlinks (authored by iasensio).
xattr: fix crash on dangling symlinks
Dec 12 2019, 8:50 PM
iasensio closed D25414: xattr: fix crash on dangling symlinks.
Dec 12 2019, 8:50 PM · Baloo, Frameworks

Dec 9 2019

iasensio updated the diff for D25130: [dolphin/search] Search by (multiple) tags.
  • Fix indentation
Dec 9 2019, 5:52 AM · Dolphin
iasensio updated the diff for D25130: [dolphin/search] Search by (multiple) tags.

Address comments

Dec 9 2019, 5:49 AM · Dolphin

Dec 8 2019

iasensio added a comment to D25416: fix(search): Correctly parse filename and/or content search.

Friendly ping

Dec 8 2019, 10:36 PM · Dolphin
iasensio added a comment to D25414: xattr: fix crash on dangling symlinks.

Ping?

Dec 8 2019, 10:33 PM · Baloo, Frameworks

Dec 1 2019

iasensio updated the diff for D25130: [dolphin/search] Search by (multiple) tags.

Disable selector when there are no tags

Dec 1 2019, 9:36 PM · Dolphin

Nov 30 2019

iasensio added a comment to D25130: [dolphin/search] Search by (multiple) tags.

Only one real suggestion: disable it when there are no tags. Otherwise clicking on it does nothing.

Nice idea! Baloo indexer is failing for me now due to some non-related assert error, so I cannot delete the tags to test it, but will try again.

Nov 30 2019, 12:25 AM · Dolphin
iasensio updated the diff for D25130: [dolphin/search] Search by (multiple) tags.
  • Use tag icon
Nov 30 2019, 12:21 AM · Dolphin

Nov 29 2019

iasensio updated the summary of D25130: [dolphin/search] Search by (multiple) tags.
Nov 29 2019, 7:48 PM · Dolphin
iasensio updated the diff for D25130: [dolphin/search] Search by (multiple) tags.
  • Rebase
  • Add test case for tags
Nov 29 2019, 7:47 PM · Dolphin

Nov 28 2019

iasensio committed R318:6776fbc94760: fix(search): Fix baloo searchString parsing (authored by iasensio).
fix(search): Fix baloo searchString parsing
Nov 28 2019, 9:11 PM
iasensio closed D25260: fix(search): Fix baloo searchString parsing.
Nov 28 2019, 9:11 PM · Dolphin
iasensio updated the summary of D25260: fix(search): Fix baloo searchString parsing.
Nov 28 2019, 8:58 PM · Dolphin
iasensio added a comment to D25260: fix(search): Fix baloo searchString parsing.

@elvisangelaccio, @bruns, if there is no strong objections, I would like to push this fix to release/19.12 today, before the RC tagging

Nov 28 2019, 8:35 PM · Dolphin

Nov 23 2019

iasensio updated the diff for D25416: fix(search): Correctly parse filename and/or content search.

Fix coding style

Nov 23 2019, 12:45 PM · Dolphin

Nov 22 2019

iasensio updated the diff for D25416: fix(search): Correctly parse filename and/or content search.

Respect quotes when splitting terms

Nov 22 2019, 10:18 PM · Dolphin

Nov 19 2019

iasensio added inline comments to D25414: xattr: fix crash on dangling symlinks.
Nov 19 2019, 11:18 PM · Baloo, Frameworks
iasensio updated the diff for D25414: xattr: fix crash on dangling symlinks.
  • Simplify symlink creation
Nov 19 2019, 11:18 PM · Baloo, Frameworks
iasensio added a comment to D25260: fix(search): Fix baloo searchString parsing.

Any more thoughts on this? I wouldn't like to miss this fix for release/19.12 😃

Nov 19 2019, 10:25 PM · Dolphin
iasensio updated the test plan for D25414: xattr: fix crash on dangling symlinks.
Nov 19 2019, 10:19 PM · Baloo, Frameworks
iasensio updated the diff for D25414: xattr: fix crash on dangling symlinks.
  • Use temporal symlink
Nov 19 2019, 10:17 PM · Baloo, Frameworks
iasensio updated the diff for D25414: xattr: fix crash on dangling symlinks.
  • Protect from size < 0
  • Add test case for dangling symlink
Nov 19 2019, 10:02 PM · Baloo, Frameworks
iasensio updated the summary of D25414: xattr: fix crash on dangling symlinks.
Nov 19 2019, 9:21 PM · Baloo, Frameworks
iasensio added a dependency for D25416: fix(search): Correctly parse filename and/or content search: D25260: fix(search): Fix baloo searchString parsing.
Nov 19 2019, 9:16 PM · Dolphin
iasensio added a dependent revision for D25260: fix(search): Fix baloo searchString parsing: D25416: fix(search): Correctly parse filename and/or content search.
Nov 19 2019, 9:16 PM · Dolphin
iasensio requested review of D25416: fix(search): Correctly parse filename and/or content search.
Nov 19 2019, 9:16 PM · Dolphin
iasensio updated the summary of D25414: xattr: fix crash on dangling symlinks.
Nov 19 2019, 8:44 PM · Baloo, Frameworks
iasensio requested review of D25414: xattr: fix crash on dangling symlinks.
Nov 19 2019, 8:41 PM · Baloo, Frameworks

Nov 17 2019

iasensio added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

Also I am wondering about surfacing to users that the dir size computation is non complete.

Nov 17 2019, 12:03 PM · Dolphin

Nov 16 2019

iasensio added inline comments to D24433: Move URL parsing methods from kioslave to query object.
Nov 16 2019, 12:26 PM · Baloo, Frameworks