iasensio (Ismael Asensio)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 7 2019, 10:42 PM (10 w, 6 d)
Availability
Available

Recent Activity

Yesterday

iasensio added a comment to D24422: [dolphin] Improve parsing of Baloo query searchString.

Also, an automatic test case would be helpful, might be necessary to splict the function into a parsing function and integration into dolphin.

Tue, Oct 22, 8:24 PM · Dolphin
iasensio updated the diff for D24422: [dolphin] Improve parsing of Baloo query searchString.
  • Use QLatin1 methods
Tue, Oct 22, 8:02 PM · Dolphin
iasensio added inline comments to D24422: [dolphin] Improve parsing of Baloo query searchString.
Tue, Oct 22, 12:11 PM · Dolphin

Sun, Oct 20

iasensio updated the test plan for D24422: [dolphin] Improve parsing of Baloo query searchString.
Sun, Oct 20, 7:24 PM · Dolphin
iasensio updated the diff for D24422: [dolphin] Improve parsing of Baloo query searchString.
  • Check for empty filename
Sun, Oct 20, 7:16 PM · Dolphin
iasensio updated the test plan for D24422: [dolphin] Improve parsing of Baloo query searchString.
Sun, Oct 20, 7:14 PM · Dolphin
iasensio updated the diff for D24422: [dolphin] Improve parsing of Baloo query searchString.
  • Split off foreach change
Sun, Oct 20, 1:27 PM · Dolphin
iasensio updated the diff for D24602: New design for extended search options.
  • Remove unrelated changes
  • Coding style
Sun, Oct 20, 12:01 PM · Dolphin
iasensio added a comment to D24602: New design for extended search options.

Fails to compile for me, btw:

./src/search/dolphinfacetswidget.cpp:86:5: error: use of undeclared identifier 'm_anyType'
    m_anyType->setChecked(true);
    ^
../src/search/dolphinfacetswidget.cpp:87:5: error: use of undeclared identifier 'm_anytime'
    m_anytime->setChecked(true);
    ^
../src/search/dolphinfacetswidget.cpp:88:5: error: use of undeclared identifier 'm_anyRating'
    m_anyRating->setChecked(true);
    ^
3 errors generated.
Sun, Oct 20, 11:47 AM · Dolphin
iasensio updated the diff for D24602: New design for extended search options.
  • Fix rebasing
Sun, Oct 20, 11:44 AM · Dolphin
iasensio added a comment to D24422: [dolphin] Improve parsing of Baloo query searchString.

Are https://bugs.kde.org/show_bug.cgi?id=412980 and https://bugs.kde.org/show_bug.cgi?id=413184 also related?

Sun, Oct 20, 11:37 AM · Dolphin
iasensio updated the diff for D24602: New design for extended search options.
  • Rebase to master
Sun, Oct 20, 10:40 AM · Dolphin
iasensio updated the diff for D24422: [dolphin] Improve parsing of Baloo query searchString.
  • Rebase to master
Sun, Oct 20, 10:24 AM · Dolphin

Thu, Oct 17

iasensio added a comment to D24422: [dolphin] Improve parsing of Baloo query searchString.

I just saw a new bug reporting on something this should fix, namely the double quotes around the search terms (https://bugs.kde.org/show_bug.cgi?id=412952), so updating the summary.
Since now the search box reloads its contents on URL changes, this kind of bugs are more exposed to the users.

Thu, Oct 17, 10:39 AM · Dolphin
iasensio updated the summary of D24422: [dolphin] Improve parsing of Baloo query searchString.
Thu, Oct 17, 10:35 AM · Dolphin

Sun, Oct 13

iasensio updated the diff for D24450: [dolphin/search] Reset search options when needed.
  • Use changedEvent() instead of overriding
Sun, Oct 13, 6:26 PM · Dolphin
iasensio abandoned D24619: [dolphin/search] Reset search options when needed.

Bad arcanist foo, sorry

Sun, Oct 13, 6:21 PM · Dolphin
iasensio requested review of D24619: [dolphin/search] Reset search options when needed.
Sun, Oct 13, 6:19 PM · Dolphin
iasensio added a comment to D24577: [dolphin/search] Fix search behavior when selecting "Your Files".

@elvisangelaccio, about your question, reviewing the code, there are four places (apart from setter and getter) where m_searchPath is used:

  1. For baloo search (l.502), it is only used if m_everywhere is not checked, so it would cancel the condition in the getter, returning m_searchPath anyway
  2. For regular search (l.135), there is a similar condition as in searchPath().
  3. Menu action to call an external tool (KFind) (l.423)
  4. In the entry point fromUrlSearch(), introduced in this patch to reset it on certain paths
Sun, Oct 13, 5:57 PM · Dolphin
iasensio updated the diff for D24577: [dolphin/search] Fix search behavior when selecting "Your Files".
  • Rebase to master
  • Fix non-indexed corner case
  • Make use of searchPath()
Sun, Oct 13, 5:57 PM · Dolphin
iasensio added a comment to D24602: New design for extended search options.

Why do the comboboxes look so thin in the video?

Sun, Oct 13, 12:34 PM · Dolphin
iasensio updated the diff for D24602: New design for extended search options.
  • Fix combos' height
Sun, Oct 13, 12:28 PM · Dolphin
iasensio added a comment to D24602: New design for extended search options.

I think we could even get rid of the More Options/Fewer Options toggle button and just always show the search options now that they don't take up much space.

Sun, Oct 13, 11:54 AM · Dolphin
iasensio updated the diff for D24602: New design for extended search options.
  • Validate terms before applying
Sun, Oct 13, 12:29 AM · Dolphin

Sat, Oct 12

iasensio requested review of D24602: New design for extended search options.
Sat, Oct 12, 11:13 PM · Dolphin
iasensio updated the summary of D24422: [dolphin] Improve parsing of Baloo query searchString.
Sat, Oct 12, 12:38 AM · Dolphin

Fri, Oct 11

iasensio requested review of D24577: [dolphin/search] Fix search behavior when selecting "Your Files".
Fri, Oct 11, 11:50 PM · Dolphin

Thu, Oct 10

iasensio updated the diff for D24446: Hide search extra options when not available.
  • Fix typo and correct i18n markers
Thu, Oct 10, 9:12 PM · Dolphin

Wed, Oct 9

iasensio updated the diff for D24446: Hide search extra options when not available.
  • Add setFacetsVisible() method
  • Update toggle button on showEvent
Wed, Oct 9, 11:31 PM · Dolphin
iasensio updated the diff for D24446: Hide search extra options when not available.
Wed, Oct 9, 9:20 PM · Dolphin
iasensio added inline comments to D24446: Hide search extra options when not available.
Wed, Oct 9, 7:33 PM · Dolphin

Tue, Oct 8

iasensio added inline comments to D24450: [dolphin/search] Reset search options when needed.
Tue, Oct 8, 2:07 PM · Dolphin

Mon, Oct 7

iasensio added a dependency for D24446: Hide search extra options when not available: D24478: [dolphin/search] Add method isIndexEnabled().
Mon, Oct 7, 9:44 PM · Dolphin
iasensio added a dependent revision for D24478: [dolphin/search] Add method isIndexEnabled(): D24446: Hide search extra options when not available.
Mon, Oct 7, 9:44 PM · Dolphin
iasensio updated the diff for D24446: Hide search extra options when not available.

Split out refactor of isIndexingEnabled and depend on D24478

Mon, Oct 7, 9:37 PM · Dolphin
iasensio updated the diff for D24446: Hide search extra options when not available.
Mon, Oct 7, 9:00 PM · Dolphin
iasensio requested review of D24478: [dolphin/search] Add method isIndexEnabled().
Mon, Oct 7, 8:31 PM · Dolphin
iasensio added a comment to D24446: Hide search extra options when not available.

Would you mind to move the isIndexingEnabled() refactoring to another commit?

Mon, Oct 7, 8:11 PM · Dolphin
iasensio updated the diff for D24446: Hide search extra options when not available.
  • Name change
Mon, Oct 7, 7:40 PM · Dolphin

Sun, Oct 6

iasensio updated the test plan for D24422: [dolphin] Improve parsing of Baloo query searchString.
Sun, Oct 6, 10:52 PM · Dolphin
iasensio requested review of D24450: [dolphin/search] Reset search options when needed.
Sun, Oct 6, 10:40 PM · Dolphin
iasensio updated the diff for D24422: [dolphin] Improve parsing of Baloo query searchString.
  • Clean patch into several revisions
Sun, Oct 6, 10:24 PM · Dolphin
iasensio requested review of D24449: [dolphin/search] Avoid unnecesary reloads on setSearchPath.
Sun, Oct 6, 10:06 PM · Dolphin
iasensio requested review of D24448: [dolphin/search] Add missing parsing for type 'Folder'.
Sun, Oct 6, 9:52 PM · Dolphin
iasensio added a comment to D24422: [dolphin] Improve parsing of Baloo query searchString.

Please do one change at a time.

Sun, Oct 6, 7:20 PM · Dolphin
iasensio updated the summary of D24446: Hide search extra options when not available.
Sun, Oct 6, 6:47 PM · Dolphin
iasensio requested review of D24446: Hide search extra options when not available.
Sun, Oct 6, 6:45 PM · Dolphin
iasensio updated the diff for D24422: [dolphin] Improve parsing of Baloo query searchString.
  • Add parsing for filename/content
Sun, Oct 6, 5:20 PM · Dolphin
iasensio updated the summary of D24433: Move URL parsing methods from kioslave to query object.
Sun, Oct 6, 8:41 AM · Baloo, Frameworks

Sat, Oct 5

iasensio updated the summary of D24422: [dolphin] Improve parsing of Baloo query searchString.
Sat, Oct 5, 11:28 PM · Dolphin
iasensio requested review of D24433: Move URL parsing methods from kioslave to query object.
Sat, Oct 5, 11:26 PM · Baloo, Frameworks
iasensio requested review of D24432: Fix crash when lauching dolphin with a search scheme.
Sat, Oct 5, 11:13 PM · Dolphin
iasensio requested review of D24422: [dolphin] Improve parsing of Baloo query searchString.
Sat, Oct 5, 1:21 PM · Dolphin

Wed, Oct 2

iasensio added a comment to D24369: [dolphin] Update searchbar parameters on URL change.

I've found a bug I introduced within this patch. The fix is in D24376.
I'm really sorry for not having tested it more thoroughly.

Wed, Oct 2, 11:39 PM · Dolphin
iasensio requested review of D24376: Update searchbox on URL changes (Fix D24369).
Wed, Oct 2, 11:34 PM · Dolphin
iasensio added inline comments to D24369: [dolphin] Update searchbar parameters on URL change.
Wed, Oct 2, 8:51 PM · Dolphin
iasensio updated the diff for D24369: [dolphin] Update searchbar parameters on URL change.
  • Improve coding style
Wed, Oct 2, 8:51 PM · Dolphin
iasensio updated the test plan for D24369: [dolphin] Update searchbar parameters on URL change.
Wed, Oct 2, 7:46 PM · Dolphin
iasensio requested review of D24369: [dolphin] Update searchbar parameters on URL change.
Wed, Oct 2, 7:44 PM · Dolphin

Wed, Sep 25

iasensio added a comment to D23475: [baloo-widgets] Apply condensed date to file metadata properties.

Small ping on this small diff 😃

Wed, Sep 25, 6:31 PM · Dolphin, Baloo

Sep 15 2019

iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

Thanks for the review and the hints @elvisangelaccio.
Those were some issues I tried to explore when starting the patch but didn't get to work, so I went the hardcoded way.
I hope it is in a better shape now.

Sep 15 2019, 3:17 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Remove unrelated changes
  • Reuse QMovie instance
  • Check supported formats instead of hardcoded mimetypes
Sep 15 2019, 3:07 PM · Dolphin

Sep 13 2019

iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

Ugh, those kinds of if/else blocks are always confusing. I would (in another patch) re-arrange it so everything currently in the else block comes first (if (!usePhonon) { blabla) to get that small bit out of the way first so the more complex logic can come next without an else block after it.

Sep 13 2019, 5:08 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Move isAnimatedImage block for clarity
Sep 13 2019, 4:40 PM · Dolphin

Sep 11 2019

iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

I think we are having a misunderstanding, maybe due to the unlucky coincidence of line 278 having a different else on different branches 😃

Sep 11 2019, 3:32 PM · Dolphin

Sep 4 2019

iasensio added a watcher for Dolphin: iasensio.
Sep 4 2019, 9:20 PM

Sep 1 2019

iasensio added inline comments to D23538: [dolphin] Animate gifs on preview.
Sep 1 2019, 7:33 PM · Dolphin
iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • reorder disconnect
Sep 1 2019, 7:10 PM · Dolphin
iasensio added inline comments to D23538: [dolphin] Animate gifs on preview.
Sep 1 2019, 4:58 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Small optimization
Sep 1 2019, 4:58 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Correct indentation
Sep 1 2019, 4:19 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Rebased to master after D22183
Sep 1 2019, 4:00 PM · Dolphin

Aug 31 2019

iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

Yeah, I see now that you're right.

This looks great to me now. @elvisangelaccio?

Aug 31 2019, 12:49 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Fix refresh on resizing event
Aug 31 2019, 12:30 PM · Dolphin

Aug 30 2019

iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

Yes, I was reluctant to move this line inside the condition, but it will actually refresh the preview less, that is, no refreshing when the item to be shown is the same as the current one. In fact, this change is not needed to avoid the animation restarting, but to avoid the following flickering:

.

Aug 30 2019, 6:25 PM · Dolphin

Aug 29 2019

iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

I've finally moved it to a separate function, and directly harcoded the mimetypes, as it seems cleaner.
I've not been able to test if the preview of mngfiles actually animates or not, but the mimetype check is now correct.

Aug 29 2019, 10:36 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Fix animated mimetypes (harcoded)
Aug 29 2019, 10:18 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Avoid restarting animation on hover+select
Aug 29 2019, 8:57 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Check if same file or already running
Aug 29 2019, 8:07 PM · Dolphin
iasensio updated the diff for D23475: [baloo-widgets] Apply condensed date to file metadata properties.
  • Add also QVariant::Date
Aug 29 2019, 7:11 PM · Dolphin, Baloo
iasensio added a comment to D23475: [baloo-widgets] Apply condensed date to file metadata properties.

I agree with you both, but I found some problems on that path.

Aug 29 2019, 6:58 PM · Dolphin, Baloo
iasensio updated the diff for D23475: [baloo-widgets] Apply condensed date to file metadata properties.
  • Making formatDateTime a non-member function
  • Simplify
Aug 29 2019, 6:39 PM · Dolphin, Baloo
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Fix bugs when hovering and selecting
Aug 29 2019, 5:50 PM · Dolphin
iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

I've reviewed your test cases and now all of them are (hopefully) gone. Also another one when selecting multiple files.
Finally I had to go deleting the QMovieobject, because it doesn't provide a way to deactivate it, other than setting an empty FileName (which shows a log error message).

Aug 29 2019, 5:49 PM · Dolphin
iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

About checking for m_animatedImage

Aug 29 2019, 4:29 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Return QSring() instead of QString::null
Aug 29 2019, 4:29 PM · Dolphin
iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

I also added stopAnimatedImage() because stopping it by passing an empty filename was kind of hacky

Aug 29 2019, 2:58 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Change name to animatedImage
  • Create QMovie object only on first use
Aug 29 2019, 2:56 PM · Dolphin

Aug 28 2019

iasensio added inline comments to D23538: [dolphin] Animate gifs on preview.
Aug 28 2019, 7:21 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Remove extra line
Aug 28 2019, 7:20 PM · Dolphin
iasensio added a comment to D23538: [dolphin] Animate gifs on preview.

Inline comment about supported formats

Aug 28 2019, 5:29 PM · Dolphin
iasensio updated the diff for D23538: [dolphin] Animate gifs on preview.
  • Clean includes and delete
Aug 28 2019, 5:16 PM · Dolphin
iasensio updated the summary of D23538: [dolphin] Animate gifs on preview.
Aug 28 2019, 4:00 PM · Dolphin
iasensio requested review of D23538: [dolphin] Animate gifs on preview.
Aug 28 2019, 3:58 PM · Dolphin

Aug 27 2019

iasensio added a comment to D23103: Add decibel power units (dBW and multiples).

Friendly ping

Aug 27 2019, 1:51 PM · Frameworks

Aug 26 2019

iasensio added a project to D23475: [baloo-widgets] Apply condensed date to file metadata properties: Dolphin.
Aug 26 2019, 8:41 PM · Dolphin, Baloo
iasensio requested review of D23475: [baloo-widgets] Apply condensed date to file metadata properties.
Aug 26 2019, 8:39 PM · Dolphin, Baloo

Aug 25 2019

iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Address inline comments
  • Use setSearchModeEnabled as a public slot
  • Capitalize action text
Aug 25 2019, 11:04 PM · Dolphin

Aug 19 2019

iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Set toggle_search as default toolbar action
Aug 19 2019, 11:34 AM · Dolphin
iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Set toggle_search as default toolbar action (on top of D23075)
Aug 19 2019, 11:15 AM · Dolphin