- User Since
- Aug 7 2019, 10:42 PM (24 w, 3 d)
Tue, Jan 21
Hi! This change fails to build for me, and also in CI (https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/409/console)
Sun, Jan 19
Tue, Jan 14
Sun, Jan 12
Sat, Jan 11
Thu, Jan 9
Remove unnecessary variable
Better approach, by stripping out DolphinQuery
Wed, Jan 8
Mon, Jan 6
Only strip quotes and keep QString::mid() for clarity
Thu, Jan 2
As far as I can tell, currently the focus will change from the searchbar to the view when you press <Enter>.
Would that be an acceptable workflow?
The flickering in the current state is kind of unavoidable.
Every time a tag is clicked and a new search is made, the whole search url is reparsed and the menu gets repainted several times.
It seems to me that it is less annoying when the repainting is done "in the dark" and then show the menu again, that when it's keep visible the whole time.
Due to the way that tags are retrieved (using a KDirLister, as in the context menu) I cannot think of a better while simple way to do it without a major refactor and lots of extra code.
Sorry, I messed up with the diffs. Back to normal
Going back to the simpler option.
This should have less flickering
I think I'll re-upload the first revision so you can try it too, and decide on that.
Wed, Jan 1
I have uploaded the version with eventFilter so you may try if the flicker is too much to be annoying or it is just me.
I'd still prefer the simplest/maybe hackiest oneliner to just re-show the menu:
- Use eventFilter
I'm not so sure I want to enter there 😃
Tue, Dec 31
Sun, Dec 29
Dec 26 2019
Dec 21 2019
- Only rename methods
Dec 16 2019
Dec 15 2019
- Rebase and adapt tests
- Use QStringLiteral
Dec 14 2019
- Use return statements
Dec 12 2019
Clarify updateTagSelector logic
Dec 9 2019
- Fix indentation
Dec 8 2019
Dec 1 2019
Disable selector when there are no tags
Nov 30 2019
Nice idea! Baloo indexer is failing for me now due to some non-related assert error, so I cannot delete the tags to test it, but will try again.
- Use tag icon
Nov 29 2019
- Add test case for tags
Nov 28 2019
Nov 23 2019
Fix coding style
Nov 22 2019
Respect quotes when splitting terms
Nov 19 2019
- Simplify symlink creation
Any more thoughts on this? I wouldn't like to miss this fix for release/19.12 😃
- Use temporal symlink
- Protect from size < 0
- Add test case for dangling symlink
Nov 17 2019
Also I am wondering about surfacing to users that the dir size computation is non complete.