Feed Advanced Search

Yesterday

ngraham added a comment to T12349: "Last <day>" in condensed dates is unclear in English.

+1, that's fine with me too.

Tue, Dec 10, 8:30 PM · VDG, Dolphin, Localization
ndavis added a comment to T12349: "Last <day>" in condensed dates is unclear in English.

I agree, I hate this kind of ambiguous language.

Tue, Dec 10, 6:03 PM · VDG, Dolphin, Localization
davidedmundson added a comment to T12349: "Last <day>" in condensed dates is unclear in English.

Relavant code is KFormat::formatRelativeDate

Tue, Dec 10, 5:53 PM · VDG, Dolphin, Localization
chehrlic added inline comments to D7700: Show list of tags in PlacesView.
Tue, Dec 10, 5:48 PM · Frameworks, Dolphin
ngraham created T12349: "Last <day>" in condensed dates is unclear in English.
Tue, Dec 10, 5:17 PM · VDG, Dolphin, Localization

Mon, Dec 9

arojas closed D25783: Fix build with Qt 5.14 RC.
Mon, Dec 9, 10:23 PM · Dolphin
broulik added a comment to D15763: Set correct image attributes on directory thumbnail.

@dfaure Ping

Mon, Dec 9, 5:31 PM · Frameworks, Dolphin
ngraham updated the summary of D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Mon, Dec 9, 4:34 PM · Dolphin
ngraham added a reverted change for D19190: Improve scroll wheel speed by basing it on label height, not icon height: R318:90beb4a5e37b: Fix slow scrolling in dock panels.
Mon, Dec 9, 4:33 PM · Dolphin
ngraham updated the diff for D19190: Improve scroll wheel speed by basing it on label height, not icon height.

Also revert 90beb4a5e37b887caad1e767046a42dad0af1ab3 which is no longer needed

Mon, Dec 9, 4:32 PM · Dolphin
sitter updated the diff for D25682: [WIP] add initial wsdiscovery support.

various fixes suggested by dfaure

Mon, Dec 9, 3:35 PM · Frameworks, Dolphin
sitter added a comment to D25682: [WIP] add initial wsdiscovery support.

Yep, still looking for primarily design input.

Mon, Dec 9, 3:34 PM · Frameworks, Dolphin
iasensio updated the diff for D25130: [dolphin/search] Search by (multiple) tags.
  • Fix indentation
Mon, Dec 9, 5:52 AM · Dolphin
iasensio updated the diff for D25130: [dolphin/search] Search by (multiple) tags.

Address comments

Mon, Dec 9, 5:49 AM · Dolphin

Sun, Dec 8

ngraham added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

I dont think that's wise. It's an integral part of this change, since users have to know which settings are logically connected to this new mode and which ones are not.

Sun, Dec 8, 10:58 PM · Dolphin
iasensio added a comment to D25416: fix(search): Correctly parse filename and/or content search.

Friendly ping

Sun, Dec 8, 10:36 PM · Dolphin
elvisangelaccio requested changes to D19190: Improve scroll wheel speed by basing it on label height, not icon height.

Please see 90beb4a5e37b887caad1e767046a42dad0af1ab3

Sun, Dec 8, 8:45 PM · Dolphin
elvisangelaccio added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

Would you mind splitting the re-design of the Startup settings page to a different commit?

Sun, Dec 8, 8:21 PM · Dolphin
elvisangelaccio requested changes to D25130: [dolphin/search] Search by (multiple) tags.
Sun, Dec 8, 6:14 PM · Dolphin
joricke added a comment to T11663: Move URL Navigator into toolbar.

"Keep a single URL Navigator in the toolbar, but change it dynamically to show the path for the active split view" is probably the best option

The issue with that approach is that you can never be 100% sure you're in the right directory on your inactive split view. A minor issue, yes, but an issue nonetheless.

Sun, Dec 8, 5:50 PM · VDG, Dolphin
ngraham closed T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent as Resolved by committing R40:4fec9bf8a828: Open/close and focus/defocus terminal using the same shortcuts as Dolphin.
Sun, Dec 8, 4:50 PM · Goal: Consistency, Dolphin, Kate
elvisangelaccio accepted D25783: Fix build with Qt 5.14 RC.

Please push to release/19.12

Sun, Dec 8, 1:01 PM · Dolphin
elvisangelaccio accepted D25665: Port away from deprecated KBookmarksmenu API.
Sun, Dec 8, 12:53 PM · Dolphin
manueljlin added a comment to T11663: Move URL Navigator into toolbar.

+1 to tabs having a minimum width size
I kind of like that tab location but it probably shouldn't extend to the sidebar too.

Sun, Dec 8, 10:47 AM · VDG, Dolphin

Sat, Dec 7

ngraham moved T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent from Reported to Apps Implementation on the Goal: Consistency board.
Sat, Dec 7, 10:40 PM · Goal: Consistency, Dolphin, Kate
ngraham claimed T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.
Sat, Dec 7, 10:39 PM · Goal: Consistency, Dolphin, Kate
ngraham added a revision to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent: D25805: Open/close and focus/defocus terminal using the same shortcuts as Dolphin.
Sat, Dec 7, 10:38 PM · Goal: Consistency, Dolphin, Kate
bcooksley added a comment to D25682: [WIP] add initial wsdiscovery support.

With regards to the Docker/Gitlab CI part, please use the images under kdeorg/ on Dockerhub rather than personally maintained images as the wider community has no access to your namespace on Gitlab.com

Sat, Dec 7, 12:39 AM · Frameworks, Dolphin
dfaure requested changes to D25682: [WIP] add initial wsdiscovery support.

I guess you were expecting a higher-level review, but I don't know anything about these protocols.

Sat, Dec 7, 12:27 AM · Frameworks, Dolphin

Fri, Dec 6

dfaure accepted D25783: Fix build with Qt 5.14 RC.
Fri, Dec 6, 9:22 PM · Dolphin
ngraham changed the status of T5970: NaturalSorting option needs a place in system settings from Resolved to Wontfix.
Fri, Dec 6, 5:04 PM · Dolphin, Frameworks
ngraham closed T8136: Investigate relocating content in General > Confirmations tab as Wontfix.

We decided not to do this. There are now quite a few items in here and it seems like they're fine there.

Fri, Dec 6, 5:04 PM · Dolphin
ngraham added a project to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent: Goal: Consistency.

I just landed an old patch of mine that adds a dedicated "focus/de-focus terminal panel" action to Dolphin: D10959

Fri, Dec 6, 5:03 PM · Goal: Consistency, Dolphin, Kate
ngraham added a task to D10959: Add action for focusing Terminal Panel: T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.
Fri, Dec 6, 5:00 PM · Dolphin
ngraham added a revision to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent: D10959: Add action for focusing Terminal Panel.
Fri, Dec 6, 5:00 PM · Goal: Consistency, Dolphin, Kate
ngraham closed T9932: [ConfirmationsSettingsPage] behaviourOnLaunch setting needs a tri-state as Resolved.

Should be fully completed with D24247.

Fri, Dec 6, 5:00 PM · Dolphin
ngraham closed T5970: NaturalSorting option needs a place in system settings as Resolved.

Yeah, let's keep this the way it is. I think it's plenty comprehensible, and we never managed to come up with a good place to move them anyway.

Fri, Dec 6, 4:59 PM · Dolphin, Frameworks
ngraham closed T11600: Cleanup ReviewBoard as Resolved.

ReviewBoard has been closed down now.

Fri, Dec 6, 4:58 PM · Dolphin
ngraham closed T10262: Integrate KIO Slaves into file system using FUSE gateway as Resolved.

This is currently in progress and I don't think we need this task open anymore. The patches are scattered across various bits of infrastructure so it won't be useful for linking them here.

Fri, Dec 6, 4:55 PM · Dolphin
arojas added a comment to D25783: Fix build with Qt 5.14 RC.

see https://bugs.kde.org/show_bug.cgi?id=414492 user already created patch.

Fri, Dec 6, 2:28 PM · Dolphin
mlaurent added a comment to D25783: Fix build with Qt 5.14 RC.

see https://bugs.kde.org/show_bug.cgi?id=414492 user already created patch.

Fri, Dec 6, 2:16 PM · Dolphin
arojas requested review of D25783: Fix build with Qt 5.14 RC.
Fri, Dec 6, 2:04 PM · Dolphin
ngraham added reviewers for D25682: [WIP] add initial wsdiscovery support: dfaure, Frameworks, Dolphin.
Fri, Dec 6, 2:00 PM · Frameworks, Dolphin
hoffmannrobert added a comment to D25732: Add only canonical paths to dirWatcher.

This should go into KDirWatch itself then, to avoid the risk of other callers falling into that trap.

Fri, Dec 6, 11:01 AM · Dolphin
caspermeijn added a comment to D25682: [WIP] add initial wsdiscovery support.

Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere?

Testing convenience until @caspermeijn makes a release mostly. The library was,or maybe even still is, in flux as API was being shuffled up to kdsoap.

Fri, Dec 6, 10:01 AM · Frameworks, Dolphin
dfaure requested changes to D25732: Add only canonical paths to dirWatcher.

See also commit 6be886bafae463ba in kcoreaddons (which was wrong, it would seem -- there are better ways to prevent infinite loops than to say "let's not follow symlinks at all").

Fri, Dec 6, 8:11 AM · Dolphin
dfaure added a comment to D25732: Add only canonical paths to dirWatcher.

This should go into KDirWatch itself then, to avoid the risk of other callers falling into that trap.

Fri, Dec 6, 8:06 AM · Dolphin

Thu, Dec 5

ngraham closed D10959: Add action for focusing Terminal Panel.
Thu, Dec 5, 10:53 PM · Dolphin
ngraham updated the summary of D10959: Add action for focusing Terminal Panel.
Thu, Dec 5, 10:50 PM · Dolphin
ngraham added a comment to D10959: Add action for focusing Terminal Panel.

I think what was not working before was in fact a Konsole bug that has since been fixed in https://bugs.kde.org/show_bug.cgi?id=411181. Landing this now.

Thu, Dec 5, 10:49 PM · Dolphin
ngraham updated the diff for D10959: Add action for focusing Terminal Panel.

Rebase

Thu, Dec 5, 10:48 PM · Dolphin
ngraham added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

Friendly ping!

Thu, Dec 5, 9:04 PM · Dolphin
ngraham closed D23730: Add new protocol for 7z archives.
Thu, Dec 5, 8:37 PM · Frameworks, Dolphin

Wed, Dec 4

ngraham added a reviewer for D25732: Add only canonical paths to dirWatcher: Dolphin.
Wed, Dec 4, 5:17 PM · Dolphin
ngraham added reviewers for D25741: Add case-insensitive sorting for all role-types: Dolphin, nicolasfella.
Wed, Dec 4, 5:13 PM · Dolphin
ngraham added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

Thanks, it no longer crashes now.

Wed, Dec 4, 5:03 PM · Dolphin
ngraham added a comment to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.

I agree that F4 should show and hide the Konsole panel in both apps. Then maybe we should assign a separate focus/defocus terminal panel shortcut, in both apps.

Wed, Dec 4, 4:41 PM · Goal: Consistency, Dolphin, Kate
ngraham added a comment to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.
In T12318#212731, @sars wrote:

I was actually wondering why the F4 shortcut was put to Focus/Defocus Terminal and not to the "Show Terminal" action. The later action works the same as Dolphin (except that the focus to the terminal got broken at some point this fall or summer).

I would like F4 to be moved to "Show Terminal" (and fix the focus problem)

Wed, Dec 4, 4:40 PM · Goal: Consistency, Dolphin, Kate
dhaumann added a comment to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.

You can achieve Dolphin's behavior by reassigning the F4 shortcut to View > Tool Views > Show/Hide Konsole. That's what I do since > 10 years, and it works perfectly. Why is it not the default? Maybe because this action does not exist by default (i.e. when the Konsole plugin is not loaded). But the right fix is to reassign the F4 shortcut to this action.

Wed, Dec 4, 3:50 PM · Goal: Consistency, Dolphin, Kate
gvgeo requested review of D25741: Add case-insensitive sorting for all role-types.
Wed, Dec 4, 1:54 PM · Dolphin
anthonyfieroni added a reviewer for D25732: Add only canonical paths to dirWatcher: dfaure.
Wed, Dec 4, 1:26 PM · Dolphin
sars added a comment to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.

I was actually wondering why the F4 shortcut was put to Focus/Defocus Terminal and not to the "Show Terminal" action. The later action works the same as Dolphin (except that the focus to the terminal got broken at some point this fall or summer).

Wed, Dec 4, 12:26 PM · Goal: Consistency, Dolphin, Kate
hoffmannrobert requested review of D25732: Add only canonical paths to dirWatcher.
Wed, Dec 4, 10:33 AM · Dolphin
alexde created T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.
Wed, Dec 4, 10:29 AM · Goal: Consistency, Dolphin, Kate
meven added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

Is your directory "/home/nate/Documents/Tabletop games/40K" owned by root or another user ?

No:

ls -la "/home/nate/Documents/Tabletop games/40K"
total 19404
drwxrwxr-x  5 nate users     4096 Nov 24 09:07  .
Wed, Dec 4, 8:30 AM · Dolphin
meven updated the diff for D25335: [Details mode] Allow to fill the column size of directories with actual size.

Use a QString as buffer for filenames

Wed, Dec 4, 8:28 AM · Dolphin

Tue, Dec 3

joricke added a comment to T11663: Move URL Navigator into toolbar.

Picking up the discussions taken place on Reddit, on T12308 and on T11662, I'd like to show a revised mockup and would love some input on it:


I was also toying with the idea of having the tabs use a minimum width to increase their overall wideness and to prevent really small tabs when users are in directories such as /usr, maybe even auto fill the width available to use the space completely.
This mockup is not using any new QStyles, so it may look different on a proper redesign, but it takes into account a lot of information gathered from the talks as such:

Tue, Dec 3, 11:27 PM · VDG, Dolphin
ngraham updated the summary of D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Tue, Dec 3, 8:48 PM · Dolphin
ngraham updated the diff for D19190: Improve scroll wheel speed by basing it on label height, not icon height.

Use QApplication::wheelScrollLines() instead of a magic number

Tue, Dec 3, 8:47 PM · Dolphin
ngraham updated the diff for D19190: Improve scroll wheel speed by basing it on label height, not icon height.

Rebase

Tue, Dec 3, 8:35 PM · Dolphin
ngraham added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

Is your directory "/home/nate/Documents/Tabletop games/40K" owned by root or another user ?

Tue, Dec 3, 7:09 PM · Dolphin
meven updated the diff for D25335: [Details mode] Allow to fill the column size of directories with actual size.

s/Deep/deep

Tue, Dec 3, 11:03 AM · Dolphin
meven added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

I'm still not super thrilled by exposing something as nerdy as the maximum depth of calculation/recursion, but before we continue on the UI design discussion, Dolphin has started reproducibly crashing every time I enter Details view with the latest version of this patch. Here's the backtrace:

1#0 __strlen_avx2 () at ../sysdeps/x86_64/multiarch/strlen-avx2.S:96
2#1 0x00007ffff54d293e in __vfprintf_internal (s=s@entry=0x7fffe8e16f70,
3 format=format@entry=0x7ffff7eabefe "%s/%s", ap=ap@entry=0x7fffe8e170b0,
4 mode_flags=mode_flags@entry=0) at vfprintf-internal.c:1688
5#2 0x00007ffff54ddf30 in __vsprintf_internal (
6 string=0x7fffe8e17240 "/home/nate/Documents/Tabletop games/40K/Inspiration",
7 maxlen=maxlen@entry=18446744073709551615,
8 format=format@entry=0x7ffff7eabefe "%s/%s", args=args@entry=0x7fffe8e170b0,
9 mode_flags=mode_flags@entry=0) at iovsprintf.c:96
10#3 0x00007ffff54bd384 in __sprintf (
11 s=s@entry=0x7fffe8e17240 "/home/nate/Documents/Tabletop games/40K/Inspiration",
12 format=format@entry=0x7ffff7eabefe "%s/%s") at sprintf.c:30
13#4 0x00007ffff7e5eab5 in walkDir (
14 dirPath=0x7fff0067706a <error: Cannot access memory at address 0x7fff0067706a>,
15 dirPath@entry=0x7fffe8e17430 "/home/nate/Documents/Tabletop games/40K",
16 countHiddenFiles=countHiddenFiles@entry=false, countDirectoriesOnly=97,
17 countDirectoriesOnly@entry=false, dirEntry=0x7fffe0014f88,
18 allowedRecursiveLevel=1818581280, allowedRecursiveLevel@entry=8)
19 at /home/nate/kde/src/dolphin/src/kitemviews/private/kdirectorycontentscounterworker.cpp:77
20#5 0x00007ffff7e5eaf3 in walkDir (
21 dirPath=dirPath@entry=0x7fffe8e17620 "/home/nate/Documents/Tabletop games",
22 countHiddenFiles=countHiddenFiles@entry=false,
23 countDirectoriesOnly=countDirectoriesOnly@entry=false, dirEntry=0x7fffe000cd40,
24 allowedRecursiveLevel=allowedRecursiveLevel@entry=9)
25 at /home/nate/kde/src/dolphin/src/kitemviews/private/kdirectorycontentscounterworker.cpp:90
26#6 0x00007ffff7e5eaf3 in walkDir (dirPath=0xcc50f8 "/home/nate/Documents",
27 countHiddenFiles=countHiddenFiles@entry=false,
28 countDirectoriesOnly=countDirectoriesOnly@entry=false, dirEntry=0x7fffe0004de0,
29 dirEntry@entry=0x0, allowedRecursiveLevel=allowedRecursiveLevel@entry=10)
30 at /home/nate/kde/src/dolphin/src/kitemviews/private/kdirectorycontentscounterworker.cpp:90
31#7 0x00007ffff7e5ec0e in KDirectoryContentsCounterWorker::subItemsCount (path=...,
32 options=...) at /usr/include/qt5/QtCore/qarraydata.h:208
33#8 0x00007ffff7e5ec77 in KDirectoryContentsCounterWorker::countDirectoryContents (
34 this=0x9ef7f0, path=..., options=...)
35 at /home/nate/kde/src/dolphin/src/kitemviews/private/kdirectorycontentscounterworker.cpp:131
36#9 0x00007ffff5c30eea in QObject::event(QEvent*) () from /usr/lib64/libQt5Core.so.5
37#10 0x00007ffff66dec62 in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
38 from /usr/lib64/libQt5Widgets.so.5
39#11 0x00007ffff66e81e0 in QApplication::notify(QObject*, QEvent*) ()
40 from /usr/lib64/libQt5Widgets.so.5
41#12 0x00007ffff5c05562 in QCoreApplication::notifyInternal2(QObject*, QEvent*) ()
42 from /usr/lib64/libQt5Core.so.5
43#13 0x00007ffff5c081f8 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/lib64/libQt5Core.so.5
44#14 0x00007ffff5c5c333 in ?? () from /usr/lib64/libQt5Core.so.5
45#15 0x00007ffff4055f88 in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0
46#16 0x00007ffff4056310 in ?? () from /usr/lib64/libglib-2.0.so.0
47#17 0x00007ffff405639f in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0
48#18 0x00007ffff5c5b971 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQt5Core.so.5
49#19 0x00007ffff5c040cb in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) ()
50 from /usr/lib64/libQt5Core.so.5
51#20 0x00007ffff5a3c021 in QThread::exec() () from /usr/lib64/libQt5Core.so.5
52#21 0x00007ffff5a3d1a2 in ?? () from /usr/lib64/libQt5Core.so.5
53#22 0x00007ffff50bdf2a in start_thread (arg=<optimized out>) at pthread_create.c:479
54#23 0x00007ffff55654af in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Tue, Dec 3, 11:01 AM · Dolphin
ahiemstra added inline comments to D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Tue, Dec 3, 10:29 AM · Dolphin
anthonyfieroni added inline comments to D25335: [Details mode] Allow to fill the column size of directories with actual size.
Tue, Dec 3, 7:18 AM · Dolphin
ngraham added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

I'm still not super thrilled by exposing something as nerdy as the maximum depth of calculation/recursion, but before we continue on the UI design discussion, Dolphin has started reproducibly crashing every time I enter Details view with the latest version of this patch. Here's the backtrace:

Tue, Dec 3, 3:03 AM · Dolphin

Mon, Dec 2

meven added a comment to D25335: [Details mode] Allow to fill the column size of directories with actual size.

I gave this a try today. The performance is quite good and the feature works great! It will be very nice to have, even without any caching (though that is probably necessary IMO to improve the display and performance and to minimize disk wear for SSDs in particular). I have a few concerns and suggestions for improvement:

  1. The UI to turn this on is entirely too technical. It should be more like this:

    ` Folder size display: (o) Number of items ( ) Size of contents [4] Levels deep `

I mostly followed your nice suggestion.

Mon, Dec 2, 6:06 PM · Dolphin
meven updated the diff for D25335: [Details mode] Allow to fill the column size of directories with actual size.

Apply the setting in UI, better setting UI, remove nb of items when recurse count was selected, take into account folder size

Mon, Dec 2, 5:56 PM · Dolphin
ngraham added a comment to D25651: Allow to forget recentlyused resources.

This doesn't seem to work for me. When I click on the new menu item, the view refreshes but the item I told it to forget it still visible in the ioslave.

Mon, Dec 2, 3:51 PM · Dolphin
ngraham added a comment to D25682: [WIP] add initial wsdiscovery support.

OMG it works!!! I can find my windows Samba share in Dolphin again!

Mon, Dec 2, 3:22 PM · Frameworks, Dolphin
ngraham updated subscribers of D19190: Improve scroll wheel speed by basing it on label height, not icon height.

@ahiemstra has graciously submitted a patch for KDirOperator: D25683

Mon, Dec 2, 3:03 PM · Dolphin
sitter updated subscribers of D25682: [WIP] add initial wsdiscovery support.

Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere?

Mon, Dec 2, 2:42 PM · Frameworks, Dolphin
davidedmundson added a comment to D25682: [WIP] add initial wsdiscovery support.

Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere?

Mon, Dec 2, 2:38 PM · Frameworks, Dolphin
ngraham updated the summary of D25682: [WIP] add initial wsdiscovery support.
Mon, Dec 2, 2:27 PM · Frameworks, Dolphin
meven updated the diff for D25651: Allow to forget recentlyused resources.

Rebase on master

Mon, Dec 2, 1:56 PM · Dolphin
sitter requested review of D25682: [WIP] add initial wsdiscovery support.
Mon, Dec 2, 1:50 PM · Frameworks, Dolphin
meven closed D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.
Mon, Dec 2, 12:25 PM · Dolphin
ngraham accepted D25130: [dolphin/search] Search by (multiple) tags.

UI looks good to me.

Mon, Dec 2, 2:54 AM · Dolphin

Sun, Dec 1

elvisangelaccio accepted D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.
Sun, Dec 1, 10:17 PM · Dolphin
nicolasfella requested review of D25665: Port away from deprecated KBookmarksmenu API.
Sun, Dec 1, 9:40 PM · Dolphin
iasensio updated the diff for D25130: [dolphin/search] Search by (multiple) tags.

Disable selector when there are no tags

Sun, Dec 1, 9:36 PM · Dolphin
meven updated the diff for D25651: Allow to forget recentlyused resources.

Rename addRecentlyUsedActions to addForgetRecentlyUsedAction

Sun, Dec 1, 1:28 PM · Dolphin
meven added a dependent revision for D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext: D25651: Allow to forget recentlyused resources.
Sun, Dec 1, 1:25 PM · Dolphin
meven added a dependency for D25651: Allow to forget recentlyused resources: D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.
Sun, Dec 1, 1:25 PM · Dolphin
meven requested review of D25651: Allow to forget recentlyused resources.
Sun, Dec 1, 1:22 PM · Dolphin
meven added inline comments to D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.
Sun, Dec 1, 1:09 PM · Dolphin
meven updated the diff for D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.

Split separately timelinecontext and searchcontext

Sun, Dec 1, 1:08 PM · Dolphin
elvisangelaccio added inline comments to D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext.
Sun, Dec 1, 11:16 AM · Dolphin

Sat, Nov 30

iasensio added a comment to D25130: [dolphin/search] Search by (multiple) tags.

Only one real suggestion: disable it when there are no tags. Otherwise clicking on it does nothing.

Nice idea! Baloo indexer is failing for me now due to some non-related assert error, so I cannot delete the tags to test it, but will try again.

Sat, Nov 30, 12:25 AM · Dolphin
iasensio updated the diff for D25130: [dolphin/search] Search by (multiple) tags.
  • Use tag icon
Sat, Nov 30, 12:21 AM · Dolphin