Feed Advanced Search

Today

meven requested review of D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue.
Wed, Oct 16, 7:48 AM · Frameworks, Dolphin

Yesterday

ngraham added a comment to D24602: New design for extended search options.

This is so nice!

Tue, Oct 15, 10:30 PM · Dolphin
broulik planned changes to D24431: Restore cursor thumbnailer.
Tue, Oct 15, 1:44 PM · Frameworks, Dolphin

Mon, Oct 14

meven added inline comments to D24505: Avoid emitting twice twice selectionChanged when keyboard changes the selection.
Mon, Oct 14, 6:25 AM · Dolphin
meven updated the diff for D24505: Avoid emitting twice twice selectionChanged when keyboard changes the selection.

Move comment to header

Mon, Oct 14, 6:25 AM · Dolphin

Sun, Oct 13

iasensio updated the diff for D24450: [dolphin/search] Reset search options when needed.
  • Use changedEvent() instead of overriding
Sun, Oct 13, 6:26 PM · Dolphin
iasensio abandoned D24619: [dolphin/search] Reset search options when needed.

Bad arcanist foo, sorry

Sun, Oct 13, 6:21 PM · Dolphin
iasensio requested review of D24619: [dolphin/search] Reset search options when needed.
Sun, Oct 13, 6:19 PM · Dolphin
iasensio added a comment to D24577: [dolphin/search] Fix search behavior when selecting "Your Files".

@elvisangelaccio, about your question, reviewing the code, there are four places (apart from setter and getter) where m_searchPath is used:

  1. For baloo search (l.502), it is only used if m_everywhere is not checked, so it would cancel the condition in the getter, returning m_searchPath anyway
  2. For regular search (l.135), there is a similar condition as in searchPath().
  3. Menu action to call an external tool (KFind) (l.423)
  4. In the entry point fromUrlSearch(), introduced in this patch to reset it on certain paths
Sun, Oct 13, 5:57 PM · Dolphin
iasensio updated the diff for D24577: [dolphin/search] Fix search behavior when selecting "Your Files".
  • Rebase to master
  • Fix non-indexed corner case
  • Make use of searchPath()
Sun, Oct 13, 5:57 PM · Dolphin
elvisangelaccio added inline comments to D24577: [dolphin/search] Fix search behavior when selecting "Your Files".
Sun, Oct 13, 3:51 PM · Dolphin
elvisangelaccio requested changes to D24450: [dolphin/search] Reset search options when needed.
Sun, Oct 13, 3:42 PM · Dolphin
elvisangelaccio closed D24446: Hide search extra options when not available.
Sun, Oct 13, 3:25 PM · Dolphin
elvisangelaccio accepted D24446: Hide search extra options when not available.
Sun, Oct 13, 3:25 PM · Dolphin
elvisangelaccio requested changes to D22594: [Dolphin] Open Preferred Search Tool action.

Almost there!

Sun, Oct 13, 3:19 PM · Documentation, Dolphin
elvisangelaccio closed D24353: Add actions for switching to a specific tab.
Sun, Oct 13, 3:03 PM · Dolphin
elvisangelaccio accepted D24353: Add actions for switching to a specific tab.
Sun, Oct 13, 2:43 PM · Dolphin
elvisangelaccio requested changes to D24505: Avoid emitting twice twice selectionChanged when keyboard changes the selection.

I still don't understand if we are fixing an issue or if this is just a removal of a redundant signal. AFAICS we are only removing a selectionChanged() instance called by clearSelection() in "search mode", but this signal is also emitted in many other places (e.g. is emitted 3 times if I change selection with the mouse).

Sun, Oct 13, 2:08 PM · Dolphin
iasensio added a comment to D24602: New design for extended search options.

Why do the comboboxes look so thin in the video?

Sun, Oct 13, 12:34 PM · Dolphin
iasensio updated the diff for D24602: New design for extended search options.
  • Fix combos' height
Sun, Oct 13, 12:28 PM · Dolphin
iasensio added a comment to D24602: New design for extended search options.

I think we could even get rid of the More Options/Fewer Options toggle button and just always show the search options now that they don't take up much space.

Sun, Oct 13, 11:54 AM · Dolphin
astippich closed T8196: KFileMetadata: String lists. How do clients cope? as Resolved.

Baloo now only outputs multiple entries in the property map instead of stringlist as of D19088 and clients all handle this since Applications 19.08

Sun, Oct 13, 11:41 AM · Dolphin, Elisa, Frameworks, Baloo
ndavis added a comment to D24602: New design for extended search options.

Why do the comboboxes look so thin in the video?

Sun, Oct 13, 6:13 AM · Dolphin
ngraham added a comment to D24602: New design for extended search options.

This is a lot nicer. I think we could even get rid of the More Options/Fewer Options toggle button and just always show the search options now that they don't take up much space.

Sun, Oct 13, 2:39 AM · Dolphin
iasensio updated the diff for D24602: New design for extended search options.
  • Validate terms before applying
Sun, Oct 13, 12:29 AM · Dolphin

Sat, Oct 12

iasensio requested review of D24602: New design for extended search options.
Sat, Oct 12, 11:13 PM · Dolphin
dfaure accepted D24487: fix password error condition handling of smb mount.
Sat, Oct 12, 6:01 PM · Frameworks, Dolphin
iasensio updated the summary of D24422: [dolphin] Improve parsing of Baloo query searchString.
Sat, Oct 12, 12:38 AM · Dolphin

Fri, Oct 11

iasensio requested review of D24577: [dolphin/search] Fix search behavior when selecting "Your Files".
Fri, Oct 11, 11:50 PM · Dolphin
adridg added inline comments to D24431: Restore cursor thumbnailer.
Fri, Oct 11, 12:32 PM · Frameworks, Dolphin
mthw added a comment to D23926: Move "Details" tab to second place in Properties dialog.

Any progress on this?

Fri, Oct 11, 8:55 AM · VDG, Dolphin, Frameworks

Thu, Oct 10

iasensio updated the diff for D24446: Hide search extra options when not available.
  • Fix typo and correct i18n markers
Thu, Oct 10, 9:12 PM · Dolphin
elvisangelaccio requested changes to D24446: Hide search extra options when not available.

More info on the i18n markers here: https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_ctxt

Thu, Oct 10, 7:57 PM · Dolphin
meven added inline comments to D23716: When the selection is deselected, restart the keyboard search from the beginning.
Thu, Oct 10, 7:30 AM · Dolphin
meven updated the diff for D23716: When the selection is deselected, restart the keyboard search from the beginning.

Rebasing

Thu, Oct 10, 7:28 AM · Dolphin

Wed, Oct 9

iasensio updated the diff for D24446: Hide search extra options when not available.
  • Add setFacetsVisible() method
  • Update toggle button on showEvent
Wed, Oct 9, 11:31 PM · Dolphin
iasensio updated the diff for D24446: Hide search extra options when not available.
Wed, Oct 9, 9:20 PM · Dolphin
elvisangelaccio added a comment to D23557: Update dolphin tests following place changes D7446.

It seems to me the test fails because is uses an older kio version than 5.63 with D7446 applied creating "Recently Saved" group instead of group "Recent".

FAIL! : PlacesItemModelTest::testGroups() Compared values are not the same

Actual   (groups.at(2).second.toString()): "Recently Saved"
Expected (QStringLiteral("Recent"))      : "Recent"

The actual shows that the old "Recently Saved" group was created when it should not have been.

I don't know how this jenkins job works, but I would recommend cleaning the cached artifact KIO 5.63.0 for dolphin somehow.
We can alternatively limit this test run only on KF5 >= 5.64

Wed, Oct 9, 8:17 PM · Dolphin
iasensio added inline comments to D24446: Hide search extra options when not available.
Wed, Oct 9, 7:33 PM · Dolphin
ngraham added a comment to D23475: [baloo-widgets] Apply condensed date to file metadata properties.

@bruns are you good with this now?

Wed, Oct 9, 5:12 PM · Dolphin, Baloo
meven accepted D24446: Hide search extra options when not available.
Wed, Oct 9, 11:40 AM · Dolphin
meven added a reviewer for D24505: Avoid emitting twice twice selectionChanged when keyboard changes the selection: Dolphin.
Wed, Oct 9, 11:19 AM · Dolphin
meven added a dependency for D23716: When the selection is deselected, restart the keyboard search from the beginning: D24505: Avoid emitting twice twice selectionChanged when keyboard changes the selection.
Wed, Oct 9, 8:16 AM · Dolphin
meven added a dependent revision for D24505: Avoid emitting twice twice selectionChanged when keyboard changes the selection: D23716: When the selection is deselected, restart the keyboard search from the beginning.
Wed, Oct 9, 8:16 AM · Dolphin
meven requested review of D24505: Avoid emitting twice twice selectionChanged when keyboard changes the selection.
Wed, Oct 9, 8:16 AM · Dolphin
meven added a comment to D23557: Update dolphin tests following place changes D7446.
Wed, Oct 9, 8:00 AM · Dolphin

Tue, Oct 8

elvisangelaccio added a comment to D23557: Update dolphin tests following place changes D7446.

@meven Looks like this patch is not enough: https://build.kde.org/job/Applications/job/dolphin/job/kf5-qt5%20SUSEQt5.12/78/testReport/projectroot.src/tests/placesitemmodeltest/

Tue, Oct 8, 8:33 PM · Dolphin
elvisangelaccio added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

Adding a new setting makes the code and the UI more complex and harder to maintain in the long term. We should add new settings only when there is no other way (this usually happens if a new feature makes sense only for a subset of users).

But even if we go with just the "Go up" action, I think there should be an option to turn it off.
I often miss the file or folder when double clicking and going up would be annoying.

Tue, Oct 8, 8:03 PM · Dolphin
elvisangelaccio closed D24478: [dolphin/search] Add method isIndexEnabled().
Tue, Oct 8, 7:45 PM · Dolphin
elvisangelaccio accepted D24478: [dolphin/search] Add method isIndexEnabled().

Thanks

Tue, Oct 8, 7:42 PM · Dolphin
iasensio added inline comments to D24450: [dolphin/search] Reset search options when needed.
Tue, Oct 8, 2:07 PM · Dolphin
pdabrowski added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
Tue, Oct 8, 1:32 PM · Documentation, Dolphin
pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.
Tue, Oct 8, 1:30 PM · Documentation, Dolphin
sitter requested review of D24487: fix password error condition handling of smb mount.
Tue, Oct 8, 10:03 AM · Frameworks, Dolphin
sitter closed D24387: improve error reporting for when kpasswdserver is unreachable.
Tue, Oct 8, 9:36 AM · Frameworks, Dolphin
sitter added inline comments to D24387: improve error reporting for when kpasswdserver is unreachable.
Tue, Oct 8, 9:27 AM · Frameworks, Dolphin
meven added inline comments to D24450: [dolphin/search] Reset search options when needed.
Tue, Oct 8, 7:40 AM · Dolphin
meven accepted D24478: [dolphin/search] Add method isIndexEnabled().

Nice code improvement

Tue, Oct 8, 7:31 AM · Dolphin
dhaumann added inline comments to D20532: Proof of Concept: Add double click actions to empty space in the folder view.
Tue, Oct 8, 6:10 AM · Dolphin

Mon, Oct 7

iasensio added a dependency for D24446: Hide search extra options when not available: D24478: [dolphin/search] Add method isIndexEnabled().
Mon, Oct 7, 9:44 PM · Dolphin
iasensio added a dependent revision for D24478: [dolphin/search] Add method isIndexEnabled(): D24446: Hide search extra options when not available.
Mon, Oct 7, 9:44 PM · Dolphin
iasensio updated the diff for D24446: Hide search extra options when not available.

Split out refactor of isIndexingEnabled and depend on D24478

Mon, Oct 7, 9:37 PM · Dolphin
iasensio updated the diff for D24446: Hide search extra options when not available.
Mon, Oct 7, 9:00 PM · Dolphin
ngraham accepted D24478: [dolphin/search] Add method isIndexEnabled().
Mon, Oct 7, 8:36 PM · Dolphin
iasensio requested review of D24478: [dolphin/search] Add method isIndexEnabled().
Mon, Oct 7, 8:31 PM · Dolphin
iasensio added a comment to D24446: Hide search extra options when not available.

Would you mind to move the isIndexingEnabled() refactoring to another commit?

Mon, Oct 7, 8:11 PM · Dolphin
elvisangelaccio added a comment to D24446: Hide search extra options when not available.

Would you mind to move the isIndexingEnabled() refactoring to another commit?

Mon, Oct 7, 7:58 PM · Dolphin
elvisangelaccio closed D24449: [dolphin/search] Avoid unnecesary reloads on setSearchPath.
Mon, Oct 7, 7:51 PM · Dolphin
elvisangelaccio accepted D24449: [dolphin/search] Avoid unnecesary reloads on setSearchPath.
Mon, Oct 7, 7:51 PM · Dolphin
elvisangelaccio closed D24448: [dolphin/search] Add missing parsing for type 'Folder'.
Mon, Oct 7, 7:50 PM · Dolphin
elvisangelaccio accepted D24448: [dolphin/search] Add missing parsing for type 'Folder'.
Mon, Oct 7, 7:46 PM · Dolphin
iasensio updated the diff for D24446: Hide search extra options when not available.
  • Name change
Mon, Oct 7, 7:40 PM · Dolphin
ngraham added a comment to D24446: Hide search extra options when not available.

useBalooSearch() is not accurate; it's phrased as a command, not a question. I'd recommend changing it to usesBalooSearch or indexingEnabled or balooIndexingEnabled or something like that.

Mon, Oct 7, 4:59 PM · Dolphin
ngraham accepted D24450: [dolphin/search] Reset search options when needed.
Mon, Oct 7, 3:43 PM · Dolphin
ngraham accepted D24431: Restore cursor thumbnailer.

Nice.

Mon, Oct 7, 3:39 PM · Frameworks, Dolphin

Sun, Oct 6

ngraham accepted D24449: [dolphin/search] Avoid unnecesary reloads on setSearchPath.
Sun, Oct 6, 11:55 PM · Dolphin
ngraham accepted D24353: Add actions for switching to a specific tab.
Sun, Oct 6, 11:37 PM · Dolphin
iasensio updated the test plan for D24422: [dolphin] Improve parsing of Baloo query searchString.
Sun, Oct 6, 10:52 PM · Dolphin
alexmi updated the diff for D24353: Add actions for switching to a specific tab.
  • Add action to switch to the last tab
Sun, Oct 6, 10:48 PM · Dolphin
iasensio requested review of D24450: [dolphin/search] Reset search options when needed.
Sun, Oct 6, 10:40 PM · Dolphin
iasensio updated the diff for D24422: [dolphin] Improve parsing of Baloo query searchString.
  • Clean patch into several revisions
Sun, Oct 6, 10:24 PM · Dolphin
iasensio requested review of D24449: [dolphin/search] Avoid unnecesary reloads on setSearchPath.
Sun, Oct 6, 10:06 PM · Dolphin
ngraham accepted D24448: [dolphin/search] Add missing parsing for type 'Folder'.
Sun, Oct 6, 9:55 PM · Dolphin
iasensio requested review of D24448: [dolphin/search] Add missing parsing for type 'Folder'.
Sun, Oct 6, 9:52 PM · Dolphin
fbg13 added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

Adding a new setting makes the code and the UI more complex and harder to maintain in the long term. We should add new settings only when there is no other way (this usually happens if a new feature makes sense only for a subset of users).

But even if we go with just the "Go up" action, I think there should be an option to turn it off.
I often miss the file or folder when double clicking and going up would be annoying.

Sun, Oct 6, 7:45 PM · Dolphin
ngraham added a comment to D24353: Add actions for switching to a specific tab.

I think Alt+0 for the tenth tab is fine, but maybe we should have it switch to the last tab instead. I doubt it's that common for people to have ten tabs open in Dolphin!

Sun, Oct 6, 7:25 PM · Dolphin
alexmi added a comment to D24353: Add actions for switching to a specific tab.

As far as I know "Switch to tab n" shortcuts are not identical between applications and vary quite a bit. Some applications use 0-9, some use 1-9. Some have a "Switch to last tab" shortcut assigned to 0 or 9. Some use Ctrl, some use Alt instead or even both.
In the case of web browsers I would assume they don't use 0 because Ctrl + 0 resets the zoom level, and Firefox on Windows uses Ctrl instead of Alt, Chrome uses both Ctrl and Alt I think but I don't use Chrome.

Sun, Oct 6, 7:21 PM · Dolphin
iasensio added a comment to D24422: [dolphin] Improve parsing of Baloo query searchString.

Please do one change at a time.

Sun, Oct 6, 7:20 PM · Dolphin
bruns requested changes to D24422: [dolphin] Improve parsing of Baloo query searchString.

Please do one change at a time.

Sun, Oct 6, 6:48 PM · Dolphin
iasensio updated the summary of D24446: Hide search extra options when not available.
Sun, Oct 6, 6:47 PM · Dolphin
iasensio requested review of D24446: Hide search extra options when not available.
Sun, Oct 6, 6:45 PM · Dolphin
iasensio updated the diff for D24422: [dolphin] Improve parsing of Baloo query searchString.
  • Add parsing for filename/content
Sun, Oct 6, 5:20 PM · Dolphin
ngraham added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

I don't see a compelling reason why this feature shouldn't work when you're using the systemwide double-click mode. I use that mode and this feature works perfectly fine with it.

Sun, Oct 6, 2:18 PM · Dolphin
elvisangelaccio added a comment to D20532: Proof of Concept: Add double click actions to empty space in the folder view.

Another thing that I forgot: the double click trigger should only be enabled in single-click mode, probably.

Sun, Oct 6, 12:43 PM · Dolphin
elvisangelaccio added a comment to D24353: Add actions for switching to a specific tab.

Yep, the i18n issue if fixed now.

Sun, Oct 6, 11:43 AM · Dolphin
meven added a comment to D7446: [Places panel] Revamp the Recently Saved section.
Sun, Oct 6, 11:25 AM · Frameworks, Dolphin
elvisangelaccio requested changes to D23716: When the selection is deselected, restart the keyboard search from the beginning.

Patch seems to work fine, but the lack of commit message makes it hard to understand where the actual bugfix is. Please simplify the patch as mentioned inline.

Sun, Oct 6, 11:24 AM · Dolphin
elvisangelaccio closed D24432: Fix crash when lauching dolphin with a search scheme.
Sun, Oct 6, 9:40 AM · Dolphin
elvisangelaccio accepted D24432: Fix crash when lauching dolphin with a search scheme.
Sun, Oct 6, 9:39 AM · Dolphin
dfaure added a comment to D7446: [Places panel] Revamp the Recently Saved section.

This commit breaks kfileplacesmodeltest, please take a look.

Sun, Oct 6, 9:00 AM · Frameworks, Dolphin