[dolphin/search] Search by (multiple) tags
Changes PlannedPublic

Authored by iasensio on Sun, Nov 3, 5:11 PM.

Details

Summary

Adds a tag selector in the extended filters of the search box. Selected tag or tags are added to the search query along with the other filters (type, date, rating).

It depends on D24422 because otherwise the tag tokens will populate the user search text, making it unusable in practice.

DEPENDS-ON: D24422
FEATURE: 412564
CCBUG: 356062

Test Plan
  • Menu shows the user tags
  • Picking any tag/s filters the search to that specific tag/s

Diff Detail

Repository
R318 Dolphin
Branch
search_tags
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18582
Build 18600: arc lint + arc unit
iasensio created this revision.Sun, Nov 3, 5:11 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptSun, Nov 3, 5:11 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
iasensio requested review of this revision.Sun, Nov 3, 5:11 PM

This looks fantastic!

iasensio updated this revision to Diff 69418.Fri, Nov 8, 1:11 AM
  • Use tag:<tag> token
  • Fix style
iasensio planned changes to this revision.Wed, Nov 13, 12:04 AM

Will have to be rebased after D25260