ahiemstra (Arjen Hiemstra)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 11:12 PM (231 w, 2 d)
Availability
Available

Recent Activity

Fri, Sep 20

ahiemstra added inline comments to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Fri, Sep 20, 10:35 AM · Frameworks

Thu, Sep 19

ahiemstra committed R106:ec2532c5f2df: Set default visibility for per-process network sensors to true (authored by ahiemstra).
Set default visibility for per-process network sensors to true
Thu, Sep 19, 10:08 AM
ahiemstra closed D24054: Set default visibility for per-process network sensors to true.
Thu, Sep 19, 10:08 AM · Plasma
ahiemstra committed R111:e04aa1b7eebb: Properly handle ProcessAttribute enabled and default visibility (authored by ahiemstra).
Properly handle ProcessAttribute enabled and default visibility
Thu, Sep 19, 10:08 AM
ahiemstra closed D24053: Properly handle ProcessAttribute enabled and default visibility.
Thu, Sep 19, 10:08 AM · Plasma
ahiemstra committed R106:4fb371b16a72: Replace s6_addr32 with s6_addr in the network plugin helper (authored by ahiemstra).
Replace s6_addr32 with s6_addr in the network plugin helper
Thu, Sep 19, 9:10 AM
ahiemstra committed R106:297a6b51e244: Yet another BSD compile fix (authored by ahiemstra).
Yet another BSD compile fix
Thu, Sep 19, 8:49 AM
ahiemstra committed R106:471ba264dba5: Another FreeBSD compile fix (authored by ahiemstra).
Another FreeBSD compile fix
Thu, Sep 19, 8:26 AM

Wed, Sep 18

ahiemstra committed R106:8aec34039d71: Try to fix building the network plugin on FreeBSD (authored by ahiemstra).
Try to fix building the network plugin on FreeBSD
Wed, Sep 18, 8:53 PM
ahiemstra added a reviewer for D24054: Set default visibility for per-process network sensors to true: Plasma.
Wed, Sep 18, 2:19 PM · Plasma
ahiemstra requested review of D24054: Set default visibility for per-process network sensors to true.
Wed, Sep 18, 2:16 PM · Plasma
ahiemstra requested review of D24053: Properly handle ProcessAttribute enabled and default visibility.
Wed, Sep 18, 2:08 PM · Plasma
ahiemstra accepted D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

I went over it again and found a few more small things and also added some suggestions. Feel free to apply or ignore the suggestions. Once the other items have been taken care of, I think this is good to go.

Wed, Sep 18, 9:27 AM · Frameworks

Mon, Sep 16

ahiemstra committed R106:842d64591d84: Add a per-process network information plugin (authored by ahiemstra).
Add a per-process network information plugin
Mon, Sep 16, 9:25 AM
ahiemstra closed D23342: Add a per-process network information plugin.
Mon, Sep 16, 9:25 AM · Plasma

Tue, Sep 10

ahiemstra added a comment to T11547: Remove unneeded QWidget dependencies to set parent windows or display errors.

KAuth has a parentWidget property for actions (https://api.kde.org/frameworks/kauth/html/classKAuth_1_1Action.html#af91c15e1de114497e20e5c391f2afc3e) that is used to set window modality, it can probably do with just a QWindow.

Tue, Sep 10, 9:46 PM · Frameworks, KF6

Sun, Sep 8

ahiemstra committed R169:01fe807d9950: Remove custom content item from ActionMenu separator (authored by ahiemstra).
Remove custom content item from ActionMenu separator
Sun, Sep 8, 2:25 PM
ahiemstra closed D23784: Remove custom content item from ActionMenu separator.
Sun, Sep 8, 2:25 PM · Kirigami
ahiemstra added inline comments to D23784: Remove custom content item from ActionMenu separator.
Sun, Sep 8, 12:20 PM · Kirigami
ahiemstra updated the diff for D23784: Remove custom content item from ActionMenu separator.
  • Remove Component {} wrapping for Component properties
Sun, Sep 8, 12:18 PM · Kirigami
ahiemstra updated the summary of D23784: Remove custom content item from ActionMenu separator.
Sun, Sep 8, 8:48 AM · Kirigami
ahiemstra requested review of D23784: Remove custom content item from ActionMenu separator.
Sun, Sep 8, 8:45 AM · Kirigami

Sat, Sep 7

ahiemstra committed R169:57266693f2fc: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar (authored by ahiemstra).
Replace the custom overflow button with PrivateActionToolButton in ActionToolBar
Sat, Sep 7, 1:09 PM
ahiemstra closed D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar.
Sat, Sep 7, 1:09 PM · Kirigami
ahiemstra committed R169:b5d86e2fc7e7: If a submenu action has an icon set, make sure to also display it (authored by ahiemstra).
If a submenu action has an icon set, make sure to also display it
Sat, Sep 7, 1:07 PM
ahiemstra closed D23501: If a submenu action has an icon set, make sure to also display it.
Sat, Sep 7, 1:07 PM · Kirigami

Fri, Sep 6

ahiemstra added a comment to D23342: Add a per-process network information plugin.

That's correct. The reason for that is that a non-root process is not allowed to read which inodes root process has open, thus there is no way for the helper to map from incoming port to process ID. The only way I know of solving that is by having the helper run as root, which I would prefer to avoid.

Fri, Sep 6, 7:52 PM · Plasma

Mon, Sep 2

ahiemstra committed R111:cb3ccfc6b3db: Move code to send signals and set priority of processes to a dedicated object (authored by ahiemstra).
Move code to send signals and set priority of processes to a dedicated object
Mon, Sep 2, 9:51 AM
ahiemstra closed D23566: Move code to send signals and set priority of processes to a dedicated object.
Mon, Sep 2, 9:51 AM · Plasma
ahiemstra added a comment to D23342: Add a per-process network information plugin.

The readme already mentions it needs cap_net_raw. But I've now added a line on how to ensure that it has that.

Mon, Sep 2, 9:50 AM · Plasma
ahiemstra updated the diff for D23342: Add a per-process network information plugin.
  • Add a line that explains using setcap for cap_net_raw
Mon, Sep 2, 9:49 AM · Plasma

Thu, Aug 29

ahiemstra added inline comments to D23566: Move code to send signals and set priority of processes to a dedicated object.
Thu, Aug 29, 5:11 PM · Plasma
ahiemstra added inline comments to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Thu, Aug 29, 1:47 PM · Frameworks
ahiemstra requested review of D23566: Move code to send signals and set priority of processes to a dedicated object.
Thu, Aug 29, 1:27 PM · Plasma

Wed, Aug 28

ahiemstra added inline comments to D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar.
Wed, Aug 28, 10:02 AM · Kirigami
ahiemstra updated the diff for D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar.
  • Address review comments
Wed, Aug 28, 10:01 AM · Kirigami
ahiemstra added inline comments to D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar.
Wed, Aug 28, 9:28 AM · Kirigami
ahiemstra requested changes to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

I have probably missed stuff, but here are my initial comments.

Wed, Aug 28, 9:18 AM · Frameworks

Tue, Aug 27

ahiemstra committed R169:75652ff0f9af: Fix context menu button for pages not showing up (authored by ahiemstra).
Fix context menu button for pages not showing up
Tue, Aug 27, 7:23 PM
ahiemstra closed D23499: Fix context menu button for pages not showing up.
Tue, Aug 27, 7:23 PM · Kirigami
ahiemstra requested review of D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar.
Tue, Aug 27, 5:07 PM · Kirigami
ahiemstra requested review of D23501: If a submenu action has an icon set, make sure to also display it.
Tue, Aug 27, 4:49 PM · Kirigami
ahiemstra requested review of D23499: Fix context menu button for pages not showing up.
Tue, Aug 27, 4:25 PM · Kirigami
ahiemstra committed R169:7fe5a47ec705: Fix PrivateActionToolButton with menu not clearing checked state properly (authored by ahiemstra).
Fix PrivateActionToolButton with menu not clearing checked state properly
Tue, Aug 27, 3:29 PM
ahiemstra closed D23463: Fix PrivateActionToolButton with menu not clearing checked state properly.
Tue, Aug 27, 3:29 PM · Kirigami
ahiemstra committed R111:3a28505384fb: Add vmPSS to Process and display it as "total memory" column (authored by ahiemstra).
Add vmPSS to Process and display it as "total memory" column
Tue, Aug 27, 3:29 PM
ahiemstra closed D23382: Add vmPSS to Process and display it as "total memory" column.
Tue, Aug 27, 3:29 PM · Plasma

Mon, Aug 26

ahiemstra added a reviewer for D23463: Fix PrivateActionToolButton with menu not clearing checked state properly: mart.
Mon, Aug 26, 1:58 PM · Kirigami
ahiemstra updated the diff for D23463: Fix PrivateActionToolButton with menu not clearing checked state properly.
  • Remove usage of no longer existing property
Mon, Aug 26, 1:56 PM · Kirigami
ahiemstra updated the diff for D23463: Fix PrivateActionToolButton with menu not clearing checked state properly.
  • Fix null object error
Mon, Aug 26, 1:53 PM · Kirigami
ahiemstra added a reviewer for D23463: Fix PrivateActionToolButton with menu not clearing checked state properly: Kirigami.
Mon, Aug 26, 1:52 PM · Kirigami
ahiemstra requested review of D23463: Fix PrivateActionToolButton with menu not clearing checked state properly.
Mon, Aug 26, 1:51 PM · Kirigami

Aug 23 2019

ahiemstra requested review of D23382: Add vmPSS to Process and display it as "total memory" column.
Aug 23 2019, 5:56 PM · Plasma
ahiemstra accepted D23287: Create a plugin framework for processes.
Aug 23 2019, 8:57 AM · Plasma

Aug 22 2019

ahiemstra updated the diff for D23342: Add a per-process network information plugin.
  • Use libexec dir for the helper install location
  • Don't use nonexistant variables
Aug 22 2019, 2:30 PM · Plasma
ahiemstra added inline comments to D23342: Add a per-process network information plugin.
Aug 22 2019, 2:09 PM · Plasma
ahiemstra added inline comments to D23342: Add a per-process network information plugin.
Aug 22 2019, 1:49 PM · Plasma
ahiemstra added inline comments to D23342: Add a per-process network information plugin.
Aug 22 2019, 11:21 AM · Plasma
ahiemstra updated the diff for D23342: Add a per-process network information plugin.
  • Reject lines <7 elements instead of <2
Aug 22 2019, 11:20 AM · Plasma
ahiemstra updated the diff for D23342: Add a per-process network information plugin.
  • Add missing header and remove unneeded forward declares
  • Code style fixes
Aug 22 2019, 11:15 AM · Plasma
ahiemstra added a reviewer for D23342: Add a per-process network information plugin: Plasma.
Aug 22 2019, 11:01 AM · Plasma
ahiemstra added a dependent revision for D23287: Create a plugin framework for processes: D23342: Add a per-process network information plugin.
Aug 22 2019, 10:59 AM · Plasma
ahiemstra requested review of D23342: Add a per-process network information plugin.
Aug 22 2019, 10:59 AM · Plasma

Aug 21 2019

ahiemstra requested changes to D23287: Create a plugin framework for processes.

Just a few small things I came across when working on the network plugin.

Aug 21 2019, 10:05 AM · Plasma

Aug 6 2019

ahiemstra added a comment to D22844: [kcm-colors] Export colorscheme to GTK color definitions.

Just a small thing I noticed when scrolling through the patch.

Aug 6 2019, 1:48 PM · Plasma

Jul 28 2018

ahiemstra accepted D6513: Add support for Attica tags support.
Jul 28 2018, 10:05 AM · Frameworks, KNewStuff

Jul 24 2018

ahiemstra requested changes to D6513: Add support for Attica tags support.
Jul 24 2018, 10:08 AM · Frameworks, KNewStuff
ahiemstra accepted D6512: Add support for proposed tags addition in OCS 1.7.
Jul 24 2018, 8:38 AM · KDE Store, Frameworks
ahiemstra added a comment to D6512: Add support for proposed tags addition in OCS 1.7.

Right, so leave it to application users how to deal with that, maybe later on add some convenience functions. Sounds sensible. :)

Jul 24 2018, 8:37 AM · KDE Store, Frameworks

Jul 23 2018

ahiemstra added a comment to D6512: Add support for proposed tags addition in OCS 1.7.

T6133 suggests that tags are formatted as "group##key=value" or something similar. Wouldn't it make sense to handle parsing that format here as well? Or are tags more intended as exact matches?

Jul 23 2018, 2:24 PM · KDE Store, Frameworks

Jan 21 2018

ahiemstra committed R157:a4134cce1e36: Ensure the database path exists before trying to create a file there (authored by ahiemstra).
Ensure the database path exists before trying to create a file there
Jan 21 2018, 7:31 PM
ahiemstra closed D9954: Ensure the database path exists before trying to create a file there.
Jan 21 2018, 7:31 PM
ahiemstra committed R157:96204f2d0d4c: Update the ContentList QML plugin to make it more general (authored by ahiemstra).
Update the ContentList QML plugin to make it more general
Jan 21 2018, 7:30 PM
ahiemstra closed D9907: Update the ContentList QML plugin to make it more general.
Jan 21 2018, 7:30 PM

Jan 17 2018

ahiemstra added inline comments to D9907: Update the ContentList QML plugin to make it more general.
Jan 17 2018, 7:22 PM
ahiemstra updated the diff for D9907: Update the ContentList QML plugin to make it more general.
  • Change ContentList::data back to single return point
  • Fix FileSystem searcher when locations is not set
  • Properly perform mime-type filtering in Baloo searcher
  • Use the right role from ContentList for retrieving the file path
  • Simplify if statement in ContentList::componentComplete
Jan 17 2018, 7:20 PM

Jan 15 2018

ahiemstra committed R157:4f1cc148bfff: Keep a set of known files so we can filter out known files (authored by ahiemstra).
Keep a set of known files so we can filter out known files
Jan 15 2018, 9:40 PM
ahiemstra committed R157:af45700b0cee: Properly call setKnownFiles from PeruseMain (authored by ahiemstra).
Properly call setKnownFiles from PeruseMain
Jan 15 2018, 9:40 PM
ahiemstra committed R157:738e8f648abd: Implement caching of results (authored by ahiemstra).
Implement caching of results
Jan 15 2018, 9:40 PM
ahiemstra committed R157:1751e24a4e72: Add setKnownFiles to ContentList (authored by ahiemstra).
Add setKnownFiles to ContentList
Jan 15 2018, 9:40 PM
ahiemstra committed R157:5d4441ab01cb: Reduce debug output (authored by ahiemstra).
Reduce debug output
Jan 15 2018, 9:40 PM
ahiemstra committed R157:69c4dbc2fb18: Link ContentList QML plugin to Qt5::Gui (authored by ahiemstra).
Link ContentList QML plugin to Qt5::Gui
Jan 15 2018, 9:40 PM
ahiemstra committed R157:6b5bd9c0555d: Update Main QML with the changed API of ContentList (authored by ahiemstra).
Update Main QML with the changed API of ContentList
Jan 15 2018, 9:40 PM
ahiemstra committed R157:ef26d749a0b2: Remove unnecessary code (authored by ahiemstra).
Remove unnecessary code
Jan 15 2018, 9:40 PM
ahiemstra committed R157:3460a0ca8a79: Add file path as a role to ContentList (authored by ahiemstra).
Add file path as a role to ContentList
Jan 15 2018, 9:40 PM
ahiemstra committed R157:96b57fcfa0fb: Add an autoSearch property to ContentList (authored by ahiemstra).
Add an autoSearch property to ContentList
Jan 15 2018, 9:40 PM
ahiemstra committed R157:4eddb3ef5f15: Add a list of ContentQuery objects as property to ContentList (authored by ahiemstra).
Add a list of ContentQuery objects as property to ContentList
Jan 15 2018, 9:40 PM
ahiemstra committed R157:037570343df4: Properly wait for BalooContentLister to be done before destoying it (authored by ahiemstra).
Properly wait for BalooContentLister to be done before destoying it
Jan 15 2018, 9:40 PM
ahiemstra committed R157:592a7aec7696: Make BalooContentLister use ContentQuery (authored by ahiemstra).
Make BalooContentLister use ContentQuery
Jan 15 2018, 9:40 PM
ahiemstra committed R157:6fac660ccc81: Convert FileSystemContentLister to use ContentQuery and threaded searching (authored by ahiemstra).
Convert FileSystemContentLister to use ContentQuery and threaded searching
Jan 15 2018, 9:40 PM
ahiemstra committed R157:4a09b8cdb1b9: Move default metadata handling to ContentListerBase (authored by ahiemstra).
Move default metadata handling to ContentListerBase
Jan 15 2018, 9:40 PM
ahiemstra committed R157:d54cd18f01a7: Convert metadata to use QVariantMap (authored by ahiemstra).
Convert metadata to use QVariantMap
Jan 15 2018, 9:40 PM
ahiemstra committed R157:afa2a4b75060: Add locations and mimeTypes properties to ContentQuery (authored by ahiemstra).
Add locations and mimeTypes properties to ContentQuery
Jan 15 2018, 9:40 PM
ahiemstra committed R157:c9cd21339456: Convert ContentListerBase to use ContentQuery (authored by ahiemstra).
Convert ContentListerBase to use ContentQuery
Jan 15 2018, 9:40 PM
ahiemstra committed R157:f71258d48ee6: Introduce a ContentQuery class to encapsulate content query details (authored by ahiemstra).
Introduce a ContentQuery class to encapsulate content query details
Jan 15 2018, 9:40 PM
ahiemstra committed R157:651827891d29: Do not assume peruse attributes exist on a file (authored by ahiemstra).
Do not assume peruse attributes exist on a file
Jan 15 2018, 9:40 PM

Sep 10 2016

ahiemstra committed R8:017c97244490: Add the intial workings of an OpenGL2 based canvas. (authored by ahiemstra).
Add the intial workings of an OpenGL2 based canvas.
Sep 10 2016, 4:20 AM
ahiemstra committed R8:96c57f352031: Temporarily use the new OpenGL2 canvas instead of the GL1 canvas. (authored by ahiemstra).
Temporarily use the new OpenGL2 canvas instead of the GL1 canvas.
Sep 10 2016, 4:20 AM
ahiemstra committed R8:5b9746a82588: Add missing ) (authored by ahiemstra).
Add missing )
Sep 10 2016, 4:14 AM
ahiemstra committed R8:5a039c2e69ea: gemini: Enable save incremental after saving a new file. (authored by ahiemstra).
gemini: Enable save incremental after saving a new file.
Sep 10 2016, 4:14 AM