ahiemstra (Arjen Hiemstra)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 11:12 PM (248 w, 2 d)
Availability
Available

Recent Activity

Yesterday

ahiemstra added a comment to D24706: [RFC] Change button style.

Or is QML's rotation property not the right property to use?

Sun, Jan 19, 6:00 PM · Breeze, VDG, Plasma

Sat, Jan 18

ahiemstra added a comment to D24706: [RFC] Change button style.

KScreen uses QML, so it may well be that the buttons were rotated using QML's rotation property, which does rotate the frame, since that's rendered by qqc2-desktop-style's StyleItem as a sub-part of the button.

Sat, Jan 18, 4:54 PM · Breeze, VDG, Plasma

Thu, Jan 16

ahiemstra added a comment to D26686: Remove scrollbar related workarounds from list delegates.

That logic is in ScrollView already. Since the delegate no longer needs special padding, this changes the padding to the same value for left or right. We could change the padding depending on where the scrollbar is, but I don't think that would be an improvement.

Thu, Jan 16, 10:57 AM · Plasma

Wed, Jan 15

ahiemstra updated the test plan for D26686: Remove scrollbar related workarounds from list delegates.
Wed, Jan 15, 9:48 AM · Plasma
ahiemstra requested review of D26686: Remove scrollbar related workarounds from list delegates.
Wed, Jan 15, 9:46 AM · Plasma

Tue, Jan 14

ahiemstra added a comment to D26655: show a thin separator between view and scrollbar.

In QQC there is an issue of overlap between item selection (and header titles) and scrollbar. Isn't that made even worth with the addition of the thin separator ?

Tue, Jan 14, 3:15 PM · Plasma
ahiemstra committed R169:d4bf3ed38a9f: Expose ActionToolBar's overflow button icon name (authored by ahiemstra).
Expose ActionToolBar's overflow button icon name
Tue, Jan 14, 11:58 AM
ahiemstra closed D25943: Expose ActionToolBar's overflow button icon name.
Tue, Jan 14, 11:58 AM · Kirigami
ahiemstra committed R169:2829d2be5584: Use QQC2 Page as base for Kirigami Page (authored by ahiemstra).
Use QQC2 Page as base for Kirigami Page
Tue, Jan 14, 11:57 AM
ahiemstra closed D26656: Use QQC2 Page as base for Kirigami Page.
Tue, Jan 14, 11:57 AM · Kirigami
ahiemstra added a comment to D26586: [SystemTray] Rework system tray settings.

There should be no need to explicitly specify paddings now that D26530 has landed. But there's a bunch of workarounds that we still need to remove, so you may have some intermittent weird results.

Tue, Jan 14, 11:41 AM · Plasma
ahiemstra requested review of D26656: Use QQC2 Page as base for Kirigami Page.
Tue, Jan 14, 11:03 AM · Kirigami
ahiemstra committed R858:06d4bb0e6b86: ScrollView: Do not overlay scrollbars over contents (authored by ahiemstra).
ScrollView: Do not overlay scrollbars over contents
Tue, Jan 14, 9:59 AM
ahiemstra closed D26530: ScrollView: Do not overlay scrollbars over contents.
Tue, Jan 14, 9:58 AM · Plasma
ahiemstra updated the diff for D26530: ScrollView: Do not overlay scrollbars over contents.
  • Review comments
Tue, Jan 14, 9:56 AM · Plasma

Mon, Jan 13

ahiemstra added a comment to D26530: ScrollView: Do not overlay scrollbars over contents.

Also, just want to reiterate that I actually don't really care about how things look, what I care about is the amount of workarounds that are introduced by the scrollbar behaviour as it is. One current example is D26586 but I have ran into this myself when doing application development, as well as seen other people run into it. The workarounds introduced easily break, either with a different QtQuick Controls style or even with just a different widget style (Take a look at the System Settings sidebar with Oxygen for example).

Mon, Jan 13, 3:36 PM · Plasma
ahiemstra added a comment to D26530: ScrollView: Do not overlay scrollbars over contents.

yes, i'm saying that the patch besides putting the separation in the frame, it also reintroduces the frame by default, which is unrelated (and i think it should be avoided)

Mon, Jan 13, 3:22 PM · Plasma
awilcox awarded D26530: ScrollView: Do not overlay scrollbars over contents a Love token.
Mon, Jan 13, 11:39 AM · Plasma
ahiemstra updated the test plan for D26530: ScrollView: Do not overlay scrollbars over contents.
Mon, Jan 13, 11:31 AM · Plasma

Sat, Jan 11

ahiemstra added a comment to D25449: Start of the new Formats KCM.

Note that the interaction model is that way because that's how the system locale works. The KCM sets a bunch of environment variables (LC_ALL and related) which Qt then uses to determine what format to use. These generally correspond to certain country formats. While in theory it might be possible to create custom locales, I have no idea how hard that is to do.

Sat, Jan 11, 6:06 PM · Plasma

Fri, Jan 10

ahiemstra added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

Getting back to the topic of naming: I just did a real quick search for "zephyr" or "zephyr style" and could not really find anything obviously style related. Therefore I would suggest to use Zephyr as the new style name.

Fri, Jan 10, 2:49 PM · VDG, Plasma, Breeze
ahiemstra added a comment to D26530: ScrollView: Do not overlay scrollbars over contents.

Also note that the intention is to have the scrollbar background match the view background. In the example case I didn't bother with any view specific styling, so it looks a little more ugly than necessary. This is what it would look like with fixed background styling:

Fri, Jan 10, 2:30 PM · Plasma

Wed, Jan 8

ngraham awarded D26530: ScrollView: Do not overlay scrollbars over contents a Love token.
Wed, Jan 8, 11:27 PM · Plasma
ahiemstra added a comment to D26530: ScrollView: Do not overlay scrollbars over contents.

I think overlay scrollbars just cause more problems than they solve. Basically every application developer needs to account for the scrollbars, rather than just using ScrollView without bothering about it. Additionally, as mentioned, it is inconsistent with all the other views we use.

Wed, Jan 8, 9:34 PM · Plasma
cfeck awarded D26530: ScrollView: Do not overlay scrollbars over contents a Love token.
Wed, Jan 8, 8:11 PM · Plasma
ahiemstra added a task to D26530: ScrollView: Do not overlay scrollbars over contents: T9126: Breeze scrollbar look-and-feel unification.
Wed, Jan 8, 8:10 PM · Plasma
ahiemstra added a revision to T9126: Breeze scrollbar look-and-feel unification: D26530: ScrollView: Do not overlay scrollbars over contents.
Wed, Jan 8, 8:10 PM · KDE Applications, Plasma, Breeze, Kirigami, Goal: Consistency, VDG
ahiemstra updated the test plan for D26530: ScrollView: Do not overlay scrollbars over contents.
Wed, Jan 8, 8:09 PM · Plasma
ahiemstra requested review of D26530: ScrollView: Do not overlay scrollbars over contents.
Wed, Jan 8, 8:08 PM · Plasma
ahiemstra committed R1014:9f3a617da366: Add a page to display ActionToolBar and some of its features (authored by ahiemstra).
Add a page to display ActionToolBar and some of its features
Wed, Jan 8, 7:25 PM
ahiemstra closed D25941: Add a page to display ActionToolBar and some of its features.
Wed, Jan 8, 7:25 PM · Kirigami, Plasma

Tue, Jan 7

ahiemstra added a comment to T7622: Support Latte Dock layout in Look N' Feel packages.

@mvourlakos Is there currently a D-Bus method for starting Latte that can be used? Asking to save myself looking around for it when I work on the Global Theme KCM Code once more.

Tue, Jan 7, 10:12 AM · Plasma

Sun, Jan 5

ahiemstra abandoned D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property.

The bug mentioned got fixed by this (old Qt doesn't iterate over QList).

I don't see how this would make it look any different. The kirigami visible patch is indeed necessary but for an entirely different reason.

Sun, Jan 5, 1:13 PM · Plasma
ahiemstra accepted D26431: Fix build of python bindings for kcolumnheadersmodel.

Silly sip :/

Sun, Jan 5, 12:30 PM · Frameworks

Fri, Jan 3

ahiemstra added a comment to T7622: Support Latte Dock layout in Look N' Feel packages.

Already I can see one hurdle: Non-running Latte Dock. How would we go about doing the import command best: Would we go about running latte-dock's command through the C++ system thing (usually regarded as being insecure) so it works if Latte Dock isn't running? Is there another, more secure, C++ equivalent to its "system" code to launch Latte Dock?

Fri, Jan 3, 2:21 PM · Plasma
ahiemstra committed R169:8c09cfd92dbf: ActionToolBar: Only show the overflow button if there are visible items in the… (authored by ahiemstra).
ActionToolBar: Only show the overflow button if there are visible items in the…
Fri, Jan 3, 10:43 AM
ahiemstra closed D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu.
Fri, Jan 3, 10:43 AM · Kirigami

Sun, Dec 29

ahiemstra added a comment to D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property.

I've created https://phabricator.kde.org/D26279 for the overflow menu.

Sun, Dec 29, 7:30 PM · Plasma
ahiemstra updated the diff for D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu.
  • Remove unrelated flat change
Sun, Dec 29, 7:27 PM · Kirigami
ahiemstra requested review of D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu.
Sun, Dec 29, 7:26 PM · Kirigami
ahiemstra updated the test plan for D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property.
Sun, Dec 29, 4:57 PM · Plasma
ahiemstra requested review of D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property.
Sun, Dec 29, 4:55 PM · Plasma

Dec 19 2019

ahiemstra committed R120:66aaaf72a4df: Use a fixed icon size for the notification popup close button (authored by ahiemstra).
Use a fixed icon size for the notification popup close button
Dec 19 2019, 6:19 PM
ahiemstra closed D26093: Use a fixed icon size for the notification popup close button.
Dec 19 2019, 6:19 PM · Plasma

Dec 18 2019

ahiemstra requested review of D26093: Use a fixed icon size for the notification popup close button.
Dec 18 2019, 11:10 PM · Plasma

Dec 15 2019

ahiemstra committed R120:e7af306adcc6: Use KQuickCharts to render notification timeout as a circular progress bar (authored by ahiemstra).
Use KQuickCharts to render notification timeout as a circular progress bar
Dec 15 2019, 11:47 AM
ahiemstra closed D25993: Use KQuickCharts to render notification timeout as a circular progress bar.
Dec 15 2019, 11:47 AM · Plasma
ahiemstra committed R120:da86d1e40a1d: Restore circular progress bar in compact notification applet (authored by ahiemstra).
Restore circular progress bar in compact notification applet
Dec 15 2019, 11:46 AM
ahiemstra closed D26012: Restore circular progress bar in compact notification applet.
Dec 15 2019, 11:46 AM · Plasma
ahiemstra updated the diff for D26012: Restore circular progress bar in compact notification applet.
  • Don't show busyindicator when there are no jobs
Dec 15 2019, 11:14 AM · Plasma
ahiemstra updated the diff for D26012: Restore circular progress bar in compact notification applet.
  • Use visible to hide the busyindicator when progress > 0
Dec 15 2019, 10:46 AM · Plasma
ahiemstra updated the summary of D26012: Restore circular progress bar in compact notification applet.
Dec 15 2019, 10:31 AM · Plasma
ahiemstra requested review of D26012: Restore circular progress bar in compact notification applet.
Dec 15 2019, 10:29 AM · Plasma

Dec 14 2019

ahiemstra updated the diff for D25993: Use KQuickCharts to render notification timeout as a circular progress bar.
  • Explicitly set opacity
Dec 14 2019, 5:45 PM · Plasma
ahiemstra updated the diff for D25993: Use KQuickCharts to render notification timeout as a circular progress bar.
  • Re-add hiding behaviour on mouse over
Dec 14 2019, 5:10 PM · Plasma
ahiemstra updated the diff for D25993: Use KQuickCharts to render notification timeout as a circular progress bar.
  • Remove limiting to just showing the last 10 seconds
  • Replace ToolButton IconItem with custom to fix alignment
Dec 14 2019, 4:53 PM · Plasma
ahiemstra updated the summary of D25993: Use KQuickCharts to render notification timeout as a circular progress bar.
Dec 14 2019, 3:54 PM · Plasma
ahiemstra requested review of D25993: Use KQuickCharts to render notification timeout as a circular progress bar.
Dec 14 2019, 3:53 PM · Plasma

Dec 13 2019

ahiemstra committed R169:22d31898ae0b: Add support for custom display components to Action (authored by ahiemstra).
Add support for custom display components to Action
Dec 13 2019, 4:38 PM
ahiemstra closed D25940: Add support for custom display components to Action.
Dec 13 2019, 4:38 PM · Kirigami
ahiemstra requested review of D25943: Expose ActionToolBar's overflow button icon name.
Dec 13 2019, 10:21 AM · Kirigami
ahiemstra updated the summary of D25941: Add a page to display ActionToolBar and some of its features.
Dec 13 2019, 10:15 AM · Kirigami, Plasma
ahiemstra updated the diff for D25940: Add support for custom display components to Action.
  • Add missing @since
Dec 13 2019, 10:13 AM · Kirigami
ahiemstra updated the summary of D25940: Add support for custom display components to Action.
Dec 13 2019, 9:57 AM · Kirigami
ahiemstra updated the test plan for D25940: Add support for custom display components to Action.
Dec 13 2019, 9:54 AM · Kirigami
ahiemstra requested review of D25941: Add a page to display ActionToolBar and some of its features.
Dec 13 2019, 9:53 AM · Kirigami, Plasma
ahiemstra requested review of D25940: Add support for custom display components to Action.
Dec 13 2019, 9:47 AM · Kirigami

Dec 12 2019

ahiemstra committed R169:48177613f2ca: Remove dynamic item creation in DefaultListItemBackground (authored by ahiemstra).
Remove dynamic item creation in DefaultListItemBackground
Dec 12 2019, 4:53 PM
ahiemstra closed D25882: Remove dynamic item creation in DefaultListItemBackground.
Dec 12 2019, 4:53 PM · Kirigami

Dec 11 2019

ahiemstra requested review of D25882: Remove dynamic item creation in DefaultListItemBackground.
Dec 11 2019, 12:53 PM · Kirigami
ahiemstra closed D25879: Add an option to enable QML profiling.
Dec 11 2019, 12:46 PM · Kirigami, Plasma
ahiemstra committed R1014:693c491bc577: Add an option to enable QML profiling (authored by ahiemstra).
Add an option to enable QML profiling
Dec 11 2019, 12:46 PM
ahiemstra added inline comments to D25879: Add an option to enable QML profiling.
Dec 11 2019, 11:50 AM · Kirigami, Plasma
ahiemstra updated the diff for D25879: Add an option to enable QML profiling.
  • Actually set qml profiling to ON by default
Dec 11 2019, 11:49 AM · Kirigami, Plasma
ahiemstra requested review of D25879: Add an option to enable QML profiling.
Dec 11 2019, 11:40 AM · Kirigami, Plasma

Dec 10 2019

ahiemstra committed R275:241e9dec6896: Add KColumnHeadersProxyModel (authored by ahiemstra).
Add KColumnHeadersProxyModel
Dec 10 2019, 3:13 PM
ahiemstra closed D25311: Add KColumnHeadersProxyModel.
Dec 10 2019, 3:13 PM · Frameworks

Dec 6 2019

ahiemstra closed D25568: Fix errors in Legend size calculation.

This revision was merged ( https://commits.kde.org/kquickcharts/76cc27403514954fcd58c5a4c08c1dde0c6c4ccd ) but apparently phab didn't pick it up, so I'm closing this manually.

Dec 6 2019, 3:01 PM

Dec 5 2019

ahiemstra committed R169:277fc7222021: Fix margins of ToolBarHeader (authored by ahiemstra).
Fix margins of ToolBarHeader
Dec 5 2019, 8:31 PM
ahiemstra closed D25761: Fix margins of ToolBarHeader.
Dec 5 2019, 8:31 PM · Kirigami
ahiemstra committed R169:a85e5f354c9c: Do not crash when icon's source is empty (authored by ahiemstra).
Do not crash when icon's source is empty
Dec 5 2019, 1:25 PM
ahiemstra closed D25759: Do not crash when icon's source is empty.
Dec 5 2019, 1:25 PM · Kirigami
ahiemstra requested review of D25761: Fix margins of ToolBarHeader.
Dec 5 2019, 12:24 PM · Kirigami
ahiemstra added a comment to D25311: Add KColumnHeadersProxyModel.

Sure, I can land it after saturday.

Dec 5 2019, 11:53 AM · Frameworks
ahiemstra updated the diff for D25311: Add KColumnHeadersProxyModel.
  • Add missing layoutChanged/reset signals
Dec 5 2019, 11:21 AM · Frameworks
ahiemstra requested review of D25759: Do not crash when icon's source is empty.
Dec 5 2019, 11:19 AM · Kirigami

Dec 3 2019

ahiemstra added inline comments to D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Dec 3 2019, 10:29 AM · Dolphin

Dec 2 2019

ahiemstra updated the summary of D25683: KDirOperator: Use a fixed line height for scroll speed.
Dec 2 2019, 2:08 PM · Frameworks
ahiemstra requested review of D25683: KDirOperator: Use a fixed line height for scroll speed.
Dec 2 2019, 2:07 PM · Frameworks
ahiemstra added a comment to D25311: Add KColumnHeadersProxyModel.

@vkrause Is the updated version more what you expected?

Dec 2 2019, 11:07 AM · Frameworks

Nov 29 2019

ahiemstra added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

@jjorge: I had to manually edit your author information into the commit, since that got lost somewhere along the way and replaced with our localization script info. I think it is OK now, but please check https://commits.kde.org/ksysguard/94f9bbc246743f5eed7eac0fc9be791f43ba5052

Nov 29 2019, 2:09 PM · Plasma
ahiemstra added a reverting change for R106:9022a93738df: Move ACPI battery information from /proc/acpi to /sys: R106:87ee05ed1624: Revert "Move ACPI battery information from /proc/acpi to /sys".
Nov 29 2019, 2:07 PM
ahiemstra committed R106:87ee05ed1624: Revert "Move ACPI battery information from /proc/acpi to /sys" (authored by ahiemstra).
Revert "Move ACPI battery information from /proc/acpi to /sys"
Nov 29 2019, 2:07 PM
ahiemstra committed R106:94f9bbc24674: Move ACPI battery information from /proc/acpi to /sys (authored by jjorge).
Move ACPI battery information from /proc/acpi to /sys
Nov 29 2019, 2:07 PM
ahiemstra committed R106:9022a93738df: Move ACPI battery information from /proc/acpi to /sys (authored by l10n daemon script <scripty@kde.org>).
Move ACPI battery information from /proc/acpi to /sys
Nov 29 2019, 1:55 PM
ahiemstra closed D25018: Move ACPI battery information from /proc/acpi to /sys.
Nov 29 2019, 1:55 PM · Plasma

Nov 28 2019

ahiemstra added a comment to D25584: [TabBar] Remove frame.

Kai means a different QQC2 style. Which is indeed a problem with this approach, if you switch to say Material style with QT_QUICK_CONTROLS_STYLE=material the KCM will not load.

Nov 28 2019, 10:58 AM · Plasma

Nov 27 2019

ahiemstra committed R111:eedf1ca73d1b: Add translations for new memory sensors (authored by ahiemstra).
Add translations for new memory sensors
Nov 27 2019, 5:57 PM
ahiemstra closed D25306: Add translations for new memory sensors.
Nov 27 2019, 5:57 PM · Plasma
ahiemstra closed D25305: Add Total/Available/Allocated memory sensors.
Nov 27 2019, 5:56 PM · Plasma