- User Since
- Apr 17 2015, 11:12 PM (248 w, 2 d)
Or is QML's rotation property not the right property to use?
Sat, Jan 18
KScreen uses QML, so it may well be that the buttons were rotated using QML's rotation property, which does rotate the frame, since that's rendered by qqc2-desktop-style's StyleItem as a sub-part of the button.
Thu, Jan 16
That logic is in ScrollView already. Since the delegate no longer needs special padding, this changes the padding to the same value for left or right. We could change the padding depending on where the scrollbar is, but I don't think that would be an improvement.
Wed, Jan 15
Tue, Jan 14
In QQC there is an issue of overlap between item selection (and header titles) and scrollbar. Isn't that made even worth with the addition of the thin separator ?
There should be no need to explicitly specify paddings now that D26530 has landed. But there's a bunch of workarounds that we still need to remove, so you may have some intermittent weird results.
- Review comments
Mon, Jan 13
Also, just want to reiterate that I actually don't really care about how things look, what I care about is the amount of workarounds that are introduced by the scrollbar behaviour as it is. One current example is D26586 but I have ran into this myself when doing application development, as well as seen other people run into it. The workarounds introduced easily break, either with a different QtQuick Controls style or even with just a different widget style (Take a look at the System Settings sidebar with Oxygen for example).
yes, i'm saying that the patch besides putting the separation in the frame, it also reintroduces the frame by default, which is unrelated (and i think it should be avoided)
Sat, Jan 11
Note that the interaction model is that way because that's how the system locale works. The KCM sets a bunch of environment variables (LC_ALL and related) which Qt then uses to determine what format to use. These generally correspond to certain country formats. While in theory it might be possible to create custom locales, I have no idea how hard that is to do.
Fri, Jan 10
Getting back to the topic of naming: I just did a real quick search for "zephyr" or "zephyr style" and could not really find anything obviously style related. Therefore I would suggest to use Zephyr as the new style name.
Also note that the intention is to have the scrollbar background match the view background. In the example case I didn't bother with any view specific styling, so it looks a little more ugly than necessary. This is what it would look like with fixed background styling:
Wed, Jan 8
I think overlay scrollbars just cause more problems than they solve. Basically every application developer needs to account for the scrollbars, rather than just using ScrollView without bothering about it. Additionally, as mentioned, it is inconsistent with all the other views we use.
Tue, Jan 7
@mvourlakos Is there currently a D-Bus method for starting Latte that can be used? Asking to save myself looking around for it when I work on the Global Theme KCM Code once more.
Sun, Jan 5
The bug mentioned got fixed by this (old Qt doesn't iterate over QList).
I don't see how this would make it look any different. The kirigami visible patch is indeed necessary but for an entirely different reason.
Silly sip :/
Fri, Jan 3
Already I can see one hurdle: Non-running Latte Dock. How would we go about doing the import command best: Would we go about running latte-dock's command through the C++ system thing (usually regarded as being insecure) so it works if Latte Dock isn't running? Is there another, more secure, C++ equivalent to its "system" code to launch Latte Dock?
Sun, Dec 29
I've created https://phabricator.kde.org/D26279 for the overflow menu.
- Remove unrelated flat change
Dec 19 2019
Dec 18 2019
Dec 15 2019
- Don't show busyindicator when there are no jobs
- Use visible to hide the busyindicator when progress > 0
Dec 14 2019
- Explicitly set opacity
- Re-add hiding behaviour on mouse over
- Remove limiting to just showing the last 10 seconds
- Replace ToolButton IconItem with custom to fix alignment
Dec 13 2019
- Add missing @since
Dec 12 2019
Dec 11 2019
- Actually set qml profiling to ON by default
Dec 10 2019
Dec 6 2019
This revision was merged ( https://commits.kde.org/kquickcharts/76cc27403514954fcd58c5a4c08c1dde0c6c4ccd ) but apparently phab didn't pick it up, so I'm closing this manually.
Dec 5 2019
Sure, I can land it after saturday.
- Add missing layoutChanged/reset signals
Dec 3 2019
Dec 2 2019
@vkrause Is the updated version more what you expected?
Nov 29 2019
@jjorge: I had to manually edit your author information into the commit, since that got lost somewhere along the way and replaced with our localization script info. I think it is OK now, but please check https://commits.kde.org/ksysguard/94f9bbc246743f5eed7eac0fc9be791f43ba5052
Nov 28 2019
Kai means a different QQC2 style. Which is indeed a problem with this approach, if you switch to say Material style with QT_QUICK_CONTROLS_STYLE=material the KCM will not load.