ahiemstra (Arjen Hiemstra)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 17 2015, 11:12 PM (238 w, 5 d)
Availability
Available

Recent Activity

Mon, Nov 11

ahiemstra committed R169:9098606194e1: Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar (authored by ahiemstra).
Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar
Mon, Nov 11, 4:04 PM
ahiemstra closed D25178: Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar.
Mon, Nov 11, 4:04 PM · Kirigami
ahiemstra committed R169:b60dd839ee0b: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible (authored by ahiemstra).
ActionToolBar: Automatically change to icon-only for actions marked KeepVisible
Mon, Nov 11, 4:02 PM
ahiemstra closed D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
Mon, Nov 11, 4:02 PM · Kirigami
ahiemstra committed R169:2fe7e4598871: Add a displayHint property to Action (authored by ahiemstra).
Add a displayHint property to Action
Mon, Nov 11, 3:52 PM
ahiemstra closed D25176: Add a displayHint property to Action.
Mon, Nov 11, 3:52 PM · Kirigami
ahiemstra updated the diff for D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
  • Also add to kirigami.qrc.in
Mon, Nov 11, 3:50 PM · Kirigami
ahiemstra updated the diff for D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
  • Add ActionToolBarLayoutDetails.qml to qrc file
Mon, Nov 11, 12:17 PM · Kirigami
ahiemstra accepted D25018: Move ACPI battery information from /proc/acpi to /sys.

So, with this my system lists battery in ksysguard again, which is really nice. I do wonder about the usefulness of the "DesignCharge" sensor and would maybe like to see some additional sensors, but those can be discussed in a follow up.

Mon, Nov 11, 11:11 AM · Plasma

Fri, Nov 8

ahiemstra added inline comments to D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
Fri, Nov 8, 4:21 PM · Kirigami
ahiemstra updated the diff for D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
  • Fix showing actions with visible property undefined
Fri, Nov 8, 4:21 PM · Kirigami
ahiemstra added inline comments to D25176: Add a displayHint property to Action.
Fri, Nov 8, 4:04 PM · Kirigami
ahiemstra updated the diff for D25176: Add a displayHint property to Action.
  • Add and use DisplayHint.NoPreference value for displayHint default
Fri, Nov 8, 4:02 PM · Kirigami

Wed, Nov 6

ahiemstra added a dependent revision for D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible: D25178: Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar.
Wed, Nov 6, 6:48 PM · Kirigami
ahiemstra requested review of D25178: Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar.
Wed, Nov 6, 6:48 PM · Kirigami
ahiemstra requested review of D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
Wed, Nov 6, 6:41 PM · Kirigami
ahiemstra added a dependent revision for D25176: Add a displayHint property to Action: D25177: ActionToolBar: Automatically change to icon-only for actions marked KeepVisible.
Wed, Nov 6, 6:41 PM · Kirigami
ahiemstra requested review of D25176: Add a displayHint property to Action.
Wed, Nov 6, 6:40 PM · Kirigami
ahiemstra added a comment to D25018: Move ACPI battery information from /proc/acpi to /sys.

You are right, sorry. I was confusing /sys with /proc, which does have a lot of "put all of this information in a single file" stuff going on. It would still be nice if there was a better way of getting this information, but that is not related to this change. So then I mostly have style nitpicks as comment.

Wed, Nov 6, 11:09 AM · Plasma

Tue, Nov 5

ahiemstra added inline comments to D25067: Fix the header layouts for EntryDetails and Page components.
Tue, Nov 5, 11:18 AM · Frameworks
ahiemstra committed R169:ecaebbaea1f4: Use a RowLayout for laying out ToolBarPageHeader (authored by ahiemstra).
Use a RowLayout for laying out ToolBarPageHeader
Tue, Nov 5, 9:06 AM
ahiemstra closed D25141: Use a RowLayout for laying out ToolBarPageHeader.
Tue, Nov 5, 9:06 AM · Kirigami

Mon, Nov 4

ahiemstra updated the diff for D25141: Use a RowLayout for laying out ToolBarPageHeader.
  • Correctly hide everything if no page actions are set
Mon, Nov 4, 4:25 PM · Kirigami
ahiemstra requested review of D25141: Use a RowLayout for laying out ToolBarPageHeader.
Mon, Nov 4, 3:19 PM · Kirigami
ahiemstra requested changes to D25018: Move ACPI battery information from /proc/acpi to /sys.

Hmm, I would like to see some smarter sys file handling for this. Right now, multiple calls to getSysFileValue result in the same file being read from disk over and over. While the original implementation may not have been ideal either, the update function at least made sure the ACPI stuff got only read once per update. If you need some inspiration, Memory.c has a fairly decent implementation.

Mon, Nov 4, 2:10 PM · Plasma
ahiemstra added a comment to T9041: New "Home" tab for Kickoff.

I agree that it seems like that would just lead to accidental clicks on shutdown. I quite liked the version with the shutdown options on the right side, maybe make a version that simply always shows that sidebar?

Mon, Nov 4, 9:34 AM · Plasma, VDG

Sat, Nov 2

ahiemstra accepted D25104: Fix PageRow globalToolBar documentation.

Great, thank you!

Sat, Nov 2, 3:13 PM · Kirigami

Fri, Nov 1

ahiemstra added a comment to D25104: Fix PageRow globalToolBar documentation.

Can you also have a look at the height and reservedSpace properties below it? Those have similar issues.

Fri, Nov 1, 7:24 PM · Kirigami

Thu, Oct 31

ahiemstra accepted D25019: Ensure that GlobalDrawer topContent always stays on top.
Thu, Oct 31, 3:58 PM · Kirigami
ahiemstra added inline comments to D25019: Ensure that GlobalDrawer topContent always stays on top.
Thu, Oct 31, 1:16 PM · Kirigami

Wed, Oct 30

ahiemstra added inline comments to D25067: Fix the header layouts for EntryDetails and Page components.
Wed, Oct 30, 3:58 PM · Frameworks

Thu, Oct 24

ahiemstra added a comment to D24906: [KCMs/Night Color] Explain Night Color feature inline.

Hmm, I feel the text here is a bit vague... "can make" should probably be "makes". Also, do people understand what "making colours warmer" means?

Thu, Oct 24, 10:32 AM · Plasma

Mon, Oct 21

ahiemstra committed R169:d09b13861254: Allow contextualActions to flow into the header toolbar (authored by ahiemstra).
Allow contextualActions to flow into the header toolbar
Mon, Oct 21, 1:38 PM
ahiemstra closed D24634: Allow contextualActions to flow into the header toolbar.
Mon, Oct 21, 1:38 PM · Kirigami
ahiemstra retitled D24634: Allow contextualActions to flow into the header toolbar from [WIP] Allow contextualActions to flow into the header toolbar to Allow contextualActions to flow into the header toolbar.
Mon, Oct 21, 1:22 PM · Kirigami

Wed, Oct 16

ahiemstra added a comment to D24634: Allow contextualActions to flow into the header toolbar.

now has the order main action, left, right. before was left, main right.
it does change a bit the behavior, tough i see the point of making sure that the main action is always the last being hidden (i wonder how it would be making it hide last even if not the last)

Wed, Oct 16, 10:07 PM · Kirigami

Tue, Oct 15

ahiemstra committed R249:b45c3cea521e: Replace all qWarning and related calls with categorised logging (authored by ahiemstra).
Replace all qWarning and related calls with categorised logging
Tue, Oct 15, 11:28 AM
ahiemstra closed D24630: Replace all qWarning and related calls with categorised logging.
Tue, Oct 15, 11:28 AM · Frameworks

Oct 14 2019

ahiemstra updated the test plan for D24634: Allow contextualActions to flow into the header toolbar.
Oct 14 2019, 3:14 PM · Kirigami
ahiemstra updated the diff for D24634: Allow contextualActions to flow into the header toolbar.
  • Use the right width for showing the more button when all actions are visible
Oct 14 2019, 3:11 PM · Kirigami
ahiemstra requested review of D24634: Allow contextualActions to flow into the header toolbar.
Oct 14 2019, 3:08 PM · Kirigami
ahiemstra requested review of D24630: Replace all qWarning and related calls with categorised logging.
Oct 14 2019, 11:12 AM · Frameworks

Oct 11 2019

ahiemstra committed R106:13d1b8c0562d: Merge branch 'Plasma/5.17' (authored by ahiemstra).
Merge branch 'Plasma/5.17'
Oct 11 2019, 1:37 PM
ahiemstra committed R106:ad65ea5b6864: Fix a number of issues found by the OpenSuse security team in networkhelper (authored by ahiemstra).
Fix a number of issues found by the OpenSuse security team in networkhelper
Oct 11 2019, 1:34 PM

Oct 9 2019

ahiemstra committed R106:e358aa840a34: Fix a number of issues found by the OpenSuse security team in networkhelper (authored by ahiemstra).
Fix a number of issues found by the OpenSuse security team in networkhelper
Oct 9 2019, 5:11 PM
ahiemstra closed D24359: Fix a number of issues found by the OpenSuse security team in networkhelper.
Oct 9 2019, 5:11 PM · Plasma
ahiemstra added a watcher for Plasma: ahiemstra.
Oct 9 2019, 1:58 PM
ahiemstra added a watcher for Kirigami: ahiemstra.
Oct 9 2019, 1:56 PM
ahiemstra closed D24499: Do not warn about LayoutDirection in SearchField.
Oct 9 2019, 1:42 PM · Kirigami
ahiemstra committed R169:0115ad12b25a: Do not warn about LayoutDirection in SearchField (authored by ahiemstra).
Do not warn about LayoutDirection in SearchField
Oct 9 2019, 1:42 PM
ahiemstra committed R169:4479e865be45: Properly check enabled state of Action for ActionToolBar buttons (authored by ahiemstra).
Properly check enabled state of Action for ActionToolBar buttons
Oct 9 2019, 1:41 PM
ahiemstra closed D24498: Properly check enabled state of Action for ActionToolBar buttons.
Oct 9 2019, 1:41 PM · Kirigami
ahiemstra committed R169:a1773a7d42c7: Use MenuItem's action property directly in ActionMenuItem (authored by ahiemstra).
Use MenuItem's action property directly in ActionMenuItem
Oct 9 2019, 1:41 PM
ahiemstra closed D24501: Use MenuItem's action property directly in ActionMenuItem.
Oct 9 2019, 1:41 PM · Kirigami
ahiemstra updated the diff for D24501: Use MenuItem's action property directly in ActionMenuItem.
  • Simplify visible binding
Oct 9 2019, 11:42 AM · Kirigami
ahiemstra added inline comments to D24498: Properly check enabled state of Action for ActionToolBar buttons.
Oct 9 2019, 11:40 AM · Kirigami
ahiemstra updated the diff for D24498: Properly check enabled state of Action for ActionToolBar buttons.
  • Do not implicitly convert float to bool
Oct 9 2019, 11:39 AM · Kirigami
ahiemstra committed R169:2b7683fe9db9: Be more explicit about action property types (authored by ahiemstra).
Be more explicit about action property types
Oct 9 2019, 11:36 AM
ahiemstra closed D24500: Be more explicit about action property types.
Oct 9 2019, 11:36 AM · Kirigami
ahiemstra updated the diff for D24499: Do not warn about LayoutDirection in SearchField.
  • Use "edit-clear-locationbar-{rtl,ltr}" as icon to match widgets style
Oct 9 2019, 11:35 AM · Kirigami

Oct 8 2019

ahiemstra requested review of D24501: Use MenuItem's action property directly in ActionMenuItem.
Oct 8 2019, 2:02 PM · Kirigami
ahiemstra requested review of D24500: Be more explicit about action property types.
Oct 8 2019, 1:56 PM · Kirigami
ahiemstra requested review of D24499: Do not warn about LayoutDirection in SearchField.
Oct 8 2019, 1:51 PM · Kirigami
ahiemstra requested review of D24498: Properly check enabled state of Action for ActionToolBar buttons.
Oct 8 2019, 1:46 PM · Kirigami

Oct 7 2019

ahiemstra committed R169:7a3b56c4fc24: Replace all tabs with spaces (authored by ahiemstra).
Replace all tabs with spaces
Oct 7 2019, 10:28 AM

Oct 2 2019

ahiemstra added a comment to D24359: Fix a number of issues found by the OpenSuse security team in networkhelper.

Note that https://bugzilla.opensuse.org/show_bug.cgi?id=1152638 says pcap_breakloop() is unsupported when called from multiple threads. However, the actual libpcap documentation states:

Oct 2 2019, 10:38 AM · Plasma
ahiemstra requested review of D24359: Fix a number of issues found by the OpenSuse security team in networkhelper.
Oct 2 2019, 10:00 AM · Plasma
ahiemstra abandoned D24358: SVN_SILENT made messages (.desktop file) - always resolve ours.
Oct 2 2019, 9:52 AM · Plasma
ahiemstra requested review of D24358: SVN_SILENT made messages (.desktop file) - always resolve ours.
Oct 2 2019, 9:51 AM · Plasma

Sep 20 2019

ahiemstra added inline comments to D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
Sep 20 2019, 10:35 AM · Frameworks

Sep 19 2019

ahiemstra committed R106:ec2532c5f2df: Set default visibility for per-process network sensors to true (authored by ahiemstra).
Set default visibility for per-process network sensors to true
Sep 19 2019, 10:08 AM
ahiemstra closed D24054: Set default visibility for per-process network sensors to true.
Sep 19 2019, 10:08 AM · Plasma
ahiemstra committed R111:e04aa1b7eebb: Properly handle ProcessAttribute enabled and default visibility (authored by ahiemstra).
Properly handle ProcessAttribute enabled and default visibility
Sep 19 2019, 10:08 AM
ahiemstra closed D24053: Properly handle ProcessAttribute enabled and default visibility.
Sep 19 2019, 10:08 AM · Plasma
ahiemstra committed R106:4fb371b16a72: Replace s6_addr32 with s6_addr in the network plugin helper (authored by ahiemstra).
Replace s6_addr32 with s6_addr in the network plugin helper
Sep 19 2019, 9:10 AM
ahiemstra committed R106:297a6b51e244: Yet another BSD compile fix (authored by ahiemstra).
Yet another BSD compile fix
Sep 19 2019, 8:49 AM
ahiemstra committed R106:471ba264dba5: Another FreeBSD compile fix (authored by ahiemstra).
Another FreeBSD compile fix
Sep 19 2019, 8:26 AM

Sep 18 2019

ahiemstra committed R106:8aec34039d71: Try to fix building the network plugin on FreeBSD (authored by ahiemstra).
Try to fix building the network plugin on FreeBSD
Sep 18 2019, 8:53 PM
ahiemstra added a reviewer for D24054: Set default visibility for per-process network sensors to true: Plasma.
Sep 18 2019, 2:19 PM · Plasma
ahiemstra requested review of D24054: Set default visibility for per-process network sensors to true.
Sep 18 2019, 2:16 PM · Plasma
ahiemstra requested review of D24053: Properly handle ProcessAttribute enabled and default visibility.
Sep 18 2019, 2:08 PM · Plasma
ahiemstra accepted D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).

I went over it again and found a few more small things and also added some suggestions. Feel free to apply or ignore the suggestions. Once the other items have been taken care of, I think this is good to go.

Sep 18 2019, 9:27 AM · Frameworks

Sep 16 2019

ahiemstra committed R106:842d64591d84: Add a per-process network information plugin (authored by ahiemstra).
Add a per-process network information plugin
Sep 16 2019, 9:25 AM
ahiemstra closed D23342: Add a per-process network information plugin.
Sep 16 2019, 9:25 AM · Plasma

Sep 10 2019

ahiemstra added a comment to T11547: Remove unneeded QWidget dependencies to set parent windows or display errors.

KAuth has a parentWidget property for actions (https://api.kde.org/frameworks/kauth/html/classKAuth_1_1Action.html#af91c15e1de114497e20e5c391f2afc3e) that is used to set window modality, it can probably do with just a QWindow.

Sep 10 2019, 9:46 PM · Frameworks, KF6

Sep 8 2019

ahiemstra committed R169:01fe807d9950: Remove custom content item from ActionMenu separator (authored by ahiemstra).
Remove custom content item from ActionMenu separator
Sep 8 2019, 2:25 PM
ahiemstra closed D23784: Remove custom content item from ActionMenu separator.
Sep 8 2019, 2:25 PM · Kirigami
ahiemstra added inline comments to D23784: Remove custom content item from ActionMenu separator.
Sep 8 2019, 12:20 PM · Kirigami
ahiemstra updated the diff for D23784: Remove custom content item from ActionMenu separator.
  • Remove Component {} wrapping for Component properties
Sep 8 2019, 12:18 PM · Kirigami
ahiemstra updated the summary of D23784: Remove custom content item from ActionMenu separator.
Sep 8 2019, 8:48 AM · Kirigami
ahiemstra requested review of D23784: Remove custom content item from ActionMenu separator.
Sep 8 2019, 8:45 AM · Kirigami

Sep 7 2019

ahiemstra committed R169:57266693f2fc: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar (authored by ahiemstra).
Replace the custom overflow button with PrivateActionToolButton in ActionToolBar
Sep 7 2019, 1:09 PM
ahiemstra closed D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar.
Sep 7 2019, 1:09 PM · Kirigami
ahiemstra committed R169:b5d86e2fc7e7: If a submenu action has an icon set, make sure to also display it (authored by ahiemstra).
If a submenu action has an icon set, make sure to also display it
Sep 7 2019, 1:07 PM
ahiemstra closed D23501: If a submenu action has an icon set, make sure to also display it.
Sep 7 2019, 1:07 PM · Kirigami

Sep 6 2019

ahiemstra added a comment to D23342: Add a per-process network information plugin.

That's correct. The reason for that is that a non-root process is not allowed to read which inodes root process has open, thus there is no way for the helper to map from incoming port to process ID. The only way I know of solving that is by having the helper run as root, which I would prefer to avoid.

Sep 6 2019, 7:52 PM · Plasma

Sep 2 2019

ahiemstra committed R111:cb3ccfc6b3db: Move code to send signals and set priority of processes to a dedicated object (authored by ahiemstra).
Move code to send signals and set priority of processes to a dedicated object
Sep 2 2019, 9:51 AM
ahiemstra closed D23566: Move code to send signals and set priority of processes to a dedicated object.
Sep 2 2019, 9:51 AM · Plasma
ahiemstra added a comment to D23342: Add a per-process network information plugin.

The readme already mentions it needs cap_net_raw. But I've now added a line on how to ensure that it has that.

Sep 2 2019, 9:50 AM · Plasma
ahiemstra updated the diff for D23342: Add a per-process network information plugin.
  • Add a line that explains using setcap for cap_net_raw
Sep 2 2019, 9:49 AM · Plasma