Many web browsers (Firefox for example) offer a function to show tabs from last time when a browser starts. This patch implements this functionality as an option.
How does that behave when I start Dolphin a second time? I'm a person that usually has 5 Dolphin windows open with tons of tabs inside of them.
Instead of hardcoding those settings everywhere, please use KConfigXt (the kcfg files you can see for other places in Dolphin), like GeneralSettings
This wording could be improved (can't think of one right now)
It opens a new instance of Dolphin identical to the previous one... I guess that's a wrong behavior. Should the new instance be fresh if there are other Dolphins running? If so, how to check this? DBus?
It opens a new instance of Dolphin identical to the previous one... I guess that's a wrong behavior. Should the new instance be fresh if there are other Dolphins running?
I don't know. Perhaps restore the set only once? (This would make for an awesome crash recovery feature btw) Best add VDG team as reviewers so they can chime in
Hi everyone. I worked on KDE because I was severely ill and couldn't work at a normal job and I wanted to do something valuable. Now I'm healthy and have a full-time job and also a business, so I don't have time for contributing to Free Software. So for now, I'm not planning to contribute to KDE in the nearest future.
Yep, hope to be getting the patch merged soon. To note that D16648 is not implementing a strict "single window mode". As in whilst all external calls are opened in an existing window (if it exists), one can still have multiple windows, similar to how most browser's open externally called URIs. I suggest the way this feature should be implemented is that the last dolphin instance closed will have its tabs re-opened. It's the simplest one to code up and makes sense to the user. However, users may find it annoying if they have many tabs sprawled over many windows and want to save them all; users can't drag tabs to other windows.
Amazing :) great work and nice feature, tested this under v17.12.3 along with https://phabricator.kde.org/D19150... it works but
- Enabling the feature on the settings make the other startup settings grayed/disabled, this should not happen... may be because i am using v17, i will have a deeper look later on ;)
- Also this disable the warning about closing window containing multiple tab, it should not disable that warning even it tabs are saved.
- Restored window suffer from having right click disabled (can not right click on files)