Expose full set of script execution options in settings window

Authored by ngraham on Sep 26 2019, 6:34 PM.



Right now the script execution setting is a checkbox, capable only of handling boolean
input. This is not appropriate because there are actually three options available.

Accordingly, this patch replaces the checkbox with a combobox (to save space compared
to radio buttons) that clearly exposes all three options.

BUG: 371837
FIXED-IN: 19.12.0

Test Plan

  • All three options do what they say they'll do
  • All options get saved properly
  • The combobox displays the correct option when the window is loaded
  • The Defaults button resets it to "always ask" as expected

Diff Detail

R318 Dolphin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Sep 26 2019, 6:34 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptSep 26 2019, 6:34 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
ngraham requested review of this revision.Sep 26 2019, 6:34 PM

Alternatively, we could put this on the Behavior tab, or even the Navigation page.

elvisangelaccio accepted this revision.Sep 29 2019, 3:51 PM

While the Confirmation tab is not perfect, I don't think that moving this setting to the Behavior or Navigation tabs would be much better.



This revision is now accepted and ready to land.Sep 29 2019, 3:51 PM

Oh, and there is a missing BUG: 371837 in the commit message ;)

ngraham edited the summary of this revision. (Show Details)Sep 29 2019, 4:25 PM
ngraham updated this revision to Diff 67034.Sep 29 2019, 4:27 PM
ngraham marked an inline comment as done.

More const

This revision was automatically updated to reflect the committed changes.