dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (223 w, 3 d)
Availability
Available

Recent Activity

Thu, Jun 13

dfaure added a comment to D21517: Fix "Type error" when creating a TextField with focus: true.

Maybe someone should test this on mobile to make sure the testcase doesn't lead to the "Mobile Text Actions Toolbar" being broken?

Thu, Jun 13, 7:52 PM
dfaure committed R865:9f89c03b1f25: Preserve "at Y end" when the typing notification pops up (authored by dfaure).
Preserve "at Y end" when the typing notification pops up
Thu, Jun 13, 1:25 PM
dfaure committed R865:c74016263301: make timestamp vertically-centered (authored by dfaure).
make timestamp vertically-centered
Thu, Jun 13, 12:37 PM
dfaure committed R865:6e90dcce7116: Remove date on the right, as discussed today (authored by dfaure).
Remove date on the right, as discussed today
Thu, Jun 13, 12:34 PM
dfaure committed R865:3c7643706401: Add date header at the very top (authored by dfaure).
Add date header at the very top
Thu, Jun 13, 12:32 PM
dfaure committed R865:4814bde6e0ae: Position view at end when switching rooms (authored by dfaure).
Position view at end when switching rooms
Thu, Jun 13, 8:01 AM

Tue, Jun 11

dfaure accepted D21650: Shorten sockets file path.

Looks good to me, wait for Dan's approval too.

Tue, Jun 11, 10:57 AM · KDE PIM
dfaure committed R865:86f1d499ae6a: Improve auto-at-end when changing rooms. Works better but not perfect. (authored by dfaure).
Improve auto-at-end when changing rooms. Works better but not perfect.
Tue, Jun 11, 8:58 AM
dfaure requested changes to D21650: Shorten sockets file path.
Tue, Jun 11, 8:40 AM · KDE PIM
dfaure committed R241:565c22615ae4: Add KProtocolInfo::defaultMimetype (authored by dfaure).
Add KProtocolInfo::defaultMimetype
Tue, Jun 11, 8:37 AM
dfaure closed D21742: Add KProtocolInfo::defaultMimetype.
Tue, Jun 11, 8:37 AM · Frameworks
dfaure committed R865:5d8a0996efd6: Scroll to bottom when changing rooms (authored by dfaure).
Scroll to bottom when changing rooms
Tue, Jun 11, 7:55 AM
dfaure requested review of D21742: Add KProtocolInfo::defaultMimetype.
Tue, Jun 11, 7:32 AM · Frameworks

Mon, Jun 10

dfaure abandoned D21598: s/Data/Settings/ in the menu items..
Mon, Jun 10, 9:10 PM · KDE PIM
dfaure committed R865:fbaa6f649fe5: Stay at bottom when we're at bottom and new messages arrive. (authored by dfaure).
Stay at bottom when we're at bottom and new messages arrive.
Mon, Jun 10, 4:34 PM
dfaure closed D21726: Stay at bottom when we're at bottom and new messages arrive..
Mon, Jun 10, 4:34 PM
dfaure requested review of D21726: Stay at bottom when we're at bottom and new messages arrive..
Mon, Jun 10, 4:04 PM
dfaure committed R865:1fed70872202: Show quoted message when a message is a reply to another one (authored by dfaure).
Show quoted message when a message is a reply to another one
Mon, Jun 10, 2:25 PM
dfaure closed D21719: Show quoted message when a message is a reply to another one.
Mon, Jun 10, 2:25 PM
dfaure requested changes to D21695: Add FindTaglib.cmake.

Certainly a good idea to have this in ECM, so that this mess can be sorted out once and for all...

Mon, Jun 10, 11:04 AM · Build System, Frameworks
dfaure requested review of D21719: Show quoted message when a message is a reply to another one.
Mon, Jun 10, 10:53 AM

Sun, Jun 9

dfaure committed R865:b8b42281b186: GIT_SILENT clean up includes (authored by dfaure).
GIT_SILENT clean up includes
Sun, Jun 9, 8:11 PM
dfaure committed R865:49af12574e16: MessageModel: use find_if instead of manual for loop. (authored by dfaure).
MessageModel: use find_if instead of manual for loop.
Sun, Jun 9, 8:07 PM
dfaure committed R865:6ba143a10b2b: Simplify messagemodel code by using a local variable (authored by dfaure).
Simplify messagemodel code by using a local variable
Sun, Jun 9, 8:03 PM
dfaure committed R865:9df59d5607d2: Fix grammar: CanEditing -> CanEdit (authored by dfaure).
Fix grammar: CanEditing -> CanEdit
Sun, Jun 9, 7:57 PM

Sat, Jun 8

dfaure committed R145:5bfe8a7e5b5b: Add missing override keywords. (authored by dfaure).
Add missing override keywords.
Sat, Jun 8, 11:20 AM
dfaure committed R145:7511b95aad8a: Remove extra KPeople/ prefix in include, it's incorrect to use the framework… (authored by dfaure).
Remove extra KPeople/ prefix in include, it's incorrect to use the framework…
Sat, Jun 8, 11:13 AM
dfaure committed R739:23e4b0e6912f: Fix compilation with Qt 5.13 (authored by dfaure).
Fix compilation with Qt 5.13
Sat, Jun 8, 11:03 AM
dfaure committed R738:f4708d17983c: Add missing override macros, to fix -Wsuggest-override warnings. (authored by dfaure).
Add missing override macros, to fix -Wsuggest-override warnings.
Sat, Jun 8, 11:01 AM
dfaure committed R738:b39ea8bf12d4: Fix compilation with boost enabled. (authored by dfaure).
Fix compilation with boost enabled.
Sat, Jun 8, 10:58 AM
dfaure committed R6:f9e215b5eba6: GIT_SILENT Fix comment in fatal error, this isn't plasma (authored by dfaure).
GIT_SILENT Fix comment in fatal error, this isn't plasma
Sat, Jun 8, 9:34 AM
dfaure committed R883:1543681: KF 5.59.
KF 5.59
Sat, Jun 8, 9:01 AM
dfaure committed R883:1543680: add frameworks-5.59.0 to generate_release_data.py.
add frameworks-5.59.0 to generate_release_data.py
Sat, Jun 8, 8:55 AM
dfaure requested changes to D21650: Shorten sockets file path.

Thanks!

Sat, Jun 8, 8:46 AM · KDE PIM

Fri, Jun 7

dfaure abandoned D21597: Change title of action to launch PIM Settings Exporter.

OK, I can't think of a better solution than "Data" everywhere.

Fri, Jun 7, 6:50 AM · KDE PIM

Thu, Jun 6

dfaure committed R206:31d23ed870c9: Merge branch 'Applications/19.04' (authored by dfaure).
Merge branch 'Applications/19.04'
Thu, Jun 6, 5:52 PM
dfaure committed R206:97e165dcf5a8: Fix kontact crash on logout. (authored by dfaure).
Fix kontact crash on logout.
Thu, Jun 6, 5:51 PM
dfaure closed D21626: Fix kontact crash on logout..
Thu, Jun 6, 5:51 PM · KDE PIM
dfaure committed R209:13f0f7730cec: Allow parts (like kmail) to set a custom caption in guiActivateEvent (authored by dfaure).
Allow parts (like kmail) to set a custom caption in guiActivateEvent
Thu, Jun 6, 5:50 PM
dfaure closed D21625: Allow parts (like kmail) to set a custom caption in guiActivateEvent.
Thu, Jun 6, 5:50 PM · KDE PIM
dfaure requested review of D21626: Fix kontact crash on logout..
Thu, Jun 6, 4:13 PM · KDE PIM
dfaure requested review of D21625: Allow parts (like kmail) to set a custom caption in guiActivateEvent.
Thu, Jun 6, 4:10 PM · KDE PIM
dfaure committed R165:d4b36909bf19: Merge branch 'Applications/19.04' (authored by dfaure).
Merge branch 'Applications/19.04'
Thu, Jun 6, 2:30 PM
dfaure committed R165:0b9e5c6cc9eb: Show error string from QLocalServer on failure (authored by dfaure).
Show error string from QLocalServer on failure
Thu, Jun 6, 2:29 PM

Wed, Jun 5

dfaure added a comment to D21597: Change title of action to launch PIM Settings Exporter.

Yeah, well, right now it's a big mess, with 90% of the GUI talking about settings, and 10% talking about data.

Wed, Jun 5, 10:19 AM · KDE PIM
dfaure requested review of D21598: s/Data/Settings/ in the menu items..
Wed, Jun 5, 9:31 AM · KDE PIM
dfaure requested review of D21597: Change title of action to launch PIM Settings Exporter.
Wed, Jun 5, 9:28 AM · KDE PIM

Tue, Jun 4

dfaure committed R865:1c7e4d0450ec: Implement "Unread on Top" in rooms list, with a toggle action. (authored by dfaure).
Implement "Unread on Top" in rooms list, with a toggle action.
Tue, Jun 4, 10:57 AM
dfaure closed D21570: Implement "Unread on Top" in rooms list, with a toggle action..
Tue, Jun 4, 10:57 AM
dfaure requested review of D21570: Implement "Unread on Top" in rooms list, with a toggle action..
Tue, Jun 4, 7:55 AM

Mon, Jun 3

dfaure requested changes to D21562: fix crash in webenginepart on konqueror shutdown.
Mon, Jun 3, 3:53 PM

Sun, Jun 2

dfaure added a comment to D21517: Fix "Type error" when creating a TextField with focus: true.

So isn't there a risk that controlRoot is never set because contentItem is set too late?

Sun, Jun 2, 10:33 PM
dfaure committed R241:2e37ace712ae: kio_ftp: improve error handling when copying to FTP fails (authored by dfaure).
kio_ftp: improve error handling when copying to FTP fails
Sun, Jun 2, 7:27 PM
dfaure closed D21290: kio_ftp: improve error handling when copying to FTP fails.
Sun, Jun 2, 7:27 PM · Frameworks
dfaure accepted D21527: Fix the 'Report bug' button being always disabled.
Sun, Jun 2, 6:51 AM · Plasma

Fri, May 31

dfaure committed R497:83b9c4d443d4: Set all vars first, for easier copy/pasting (authored by dfaure).
Set all vars first, for easier copy/pasting
Fri, May 31, 8:26 PM
dfaure committed R497:e09b5a08aefb: Version update for 5.59 (authored by dfaure).
Version update for 5.59
Fri, May 31, 8:26 PM
dfaure updated the test plan for D21517: Fix "Type error" when creating a TextField with focus: true.
Fri, May 31, 8:14 PM
dfaure requested review of D21517: Fix "Type error" when creating a TextField with focus: true.
Fri, May 31, 8:13 PM
dfaure added a comment to D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI.

Writing into the user's home dir is a "hack".

Fri, May 31, 6:56 PM · Plasma
dfaure requested changes to D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI.

I agree that we shouldn't remove the underlying feature, in fact it's still used on other protocols than http.

Fri, May 31, 5:49 PM · Plasma
dfaure requested review of D21514: MobileTextActionsToolBar: fix runtime warnings when controlRoot isn't set yet.
Fri, May 31, 5:28 PM · Plasma
dfaure committed R865:145ea512148a: Remove warning which isn't a warning. (authored by dfaure).
Remove warning which isn't a warning.
Fri, May 31, 9:49 AM
dfaure committed R858:24936c8a2b7c: GIT_SILENT remove unused include, no QTimer here (authored by dfaure).
GIT_SILENT remove unused include, no QTimer here
Fri, May 31, 9:45 AM
dfaure accepted D21455: Automatic recovery from Multiple Merge Candidates error.

Just one typo, looks good otherwise.

Fri, May 31, 8:58 AM · KDE PIM
dfaure committed R865:f39e2c61a374: Room list: use gray text color for rooms with no unread messages (authored by dfaure).
Room list: use gray text color for rooms with no unread messages
Fri, May 31, 8:39 AM
dfaure closed D21487: Room list: use gray text color for rooms with no unread messages.
Fri, May 31, 8:39 AM

Wed, May 29

dfaure requested review of D21487: Room list: use gray text color for rooms with no unread messages.
Wed, May 29, 9:09 PM
dfaure committed R172:dfc7f6b50e38: Merge branch 'Applications/19.04' (authored by dfaure).
Merge branch 'Applications/19.04'
Wed, May 29, 4:02 PM
dfaure committed R172:964ec882c3be: Remove bogus TODO, this is a private header already so it's fine (authored by dfaure).
Remove bogus TODO, this is a private header already so it's fine
Wed, May 29, 4:02 PM
dfaure accepted D21367: kioexec: change the scary debug messages for delayed deletion.
Wed, May 29, 7:29 AM · Frameworks

Mon, May 27

dfaure added a comment to D21313: Create specific directory for Qt logging categories file.

My suggestion is to call this qlogging-categories5.

Mon, May 27, 8:48 PM · Build System, Frameworks
dfaure committed R865:53cf039662cf: Log all DDP messages sent and received in RUQOLA_LOGFILE, if set. (authored by dfaure).
Log all DDP messages sent and received in RUQOLA_LOGFILE, if set.
Mon, May 27, 8:43 PM
dfaure closed D21424: Log all DDP messages sent and received in RUQOLA_LOGFILE, if set..
Mon, May 27, 8:43 PM
dfaure updated the diff for D21424: Log all DDP messages sent and received in RUQOLA_LOGFILE, if set..

initialize to nullptr in the header

Mon, May 27, 7:26 PM
dfaure added inline comments to D21424: Log all DDP messages sent and received in RUQOLA_LOGFILE, if set..
Mon, May 27, 11:43 AM
dfaure updated the diff for D21424: Log all DDP messages sent and received in RUQOLA_LOGFILE, if set..

Fix crash when RUQOLA_LOGFILE isn't set

Mon, May 27, 8:54 AM
dfaure requested review of D21424: Log all DDP messages sent and received in RUQOLA_LOGFILE, if set..
Mon, May 27, 8:12 AM

Sun, May 26

dfaure updated the diff for D21290: kio_ftp: improve error handling when copying to FTP fails.

Don't leak the file descriptor on error. Thanks for catching!

Sun, May 26, 8:36 PM · Frameworks
dfaure updated the diff for D21290: kio_ftp: improve error handling when copying to FTP fails.

keep error code; mention pure-ftpd in the commit log

Sun, May 26, 3:46 PM · Frameworks
dfaure added inline comments to D21290: kio_ftp: improve error handling when copying to FTP fails.
Sun, May 26, 3:45 PM · Frameworks

Fri, May 24

dfaure committed R241:4dcd8217a924: Fix kioslave executables never exiting, when setting KDE_FORK_SLAVES. (authored by dfaure).
Fix kioslave executables never exiting, when setting KDE_FORK_SLAVES.
Fri, May 24, 11:30 AM
dfaure added a comment to D21317: Manipulate bytes instead of characters.

+1 from me, but if Thiago can take a look (about the issue of truncating in the middle of a multi-bytes utf8 characters) that'd be even better.

Fri, May 24, 9:40 AM · Frameworks

Thu, May 23

dfaure accepted D21367: kioexec: change the scary debug messages for delayed deletion.
Thu, May 23, 4:22 PM · Frameworks
dfaure committed R865:72b2acdd330f: Fix channelgetallusermentionsjobtest by comparing strings rather than URLs (authored by dfaure).
Fix channelgetallusermentionsjobtest by comparing strings rather than URLs
Thu, May 23, 10:46 AM
dfaure closed D21359: Fix channelgetallusermentionsjobtest by comparing strings rather than URLs.
Thu, May 23, 10:46 AM
dfaure requested review of D21359: Fix channelgetallusermentionsjobtest by comparing strings rather than URLs.
Thu, May 23, 7:42 AM
dfaure committed R241:bc548acd7913: kioslave: replace exit() with return as suggested by Christoph Cullmann (authored by dfaure).
kioslave: replace exit() with return as suggested by Christoph Cullmann
Thu, May 23, 7:11 AM

Wed, May 22

dfaure committed R865:c1971a3781ce: Improve typing notification for the case of multiple users (authored by dfaure).
Improve typing notification for the case of multiple users
Wed, May 22, 12:44 PM
dfaure closed D21338: Improve typing notification for the case of multiple users.
Wed, May 22, 12:44 PM
dfaure requested review of D21338: Improve typing notification for the case of multiple users.
Wed, May 22, 12:32 PM
dfaure committed R865:2b36f9d713be: Reduce icon sizes in messages, a little bit. It was really huge. (authored by dfaure).
Reduce icon sizes in messages, a little bit. It was really huge.
Wed, May 22, 12:13 PM
dfaure committed R309:70bca6c70683: Fix another assert when the file disappears under us: ASSERT: "ctime != 0" (authored by dfaure).
Fix another assert when the file disappears under us: ASSERT: "ctime != 0"
Wed, May 22, 8:27 AM
dfaure committed R309:5137a5550a5c: Fix assert (hash != 0) sometimes when a file is deleted by another process (authored by dfaure).
Fix assert (hash != 0) sometimes when a file is deleted by another process
Wed, May 22, 8:27 AM
dfaure added a reviewer for D21317: Manipulate bytes instead of characters: thiago.
Wed, May 22, 7:50 AM · Frameworks
dfaure committed R240:79665b067c9d: Don't enable QT_STRICT_ITERATORS on Windows. (authored by dfaure).
Don't enable QT_STRICT_ITERATORS on Windows.
Wed, May 22, 7:49 AM
dfaure closed D21314: Don't enable QT_STRICT_ITERATORS on Windows..
Wed, May 22, 7:49 AM · Build System, Frameworks

Tue, May 21

dfaure accepted D21249: Test current filter before setting a new one .

Thanks!

Tue, May 21, 3:38 PM · Frameworks
dfaure updated the diff for D21314: Don't enable QT_STRICT_ITERATORS on Windows..

Remove unrelated change

Tue, May 21, 7:32 AM · Build System, Frameworks
dfaure requested review of D21314: Don't enable QT_STRICT_ITERATORS on Windows..
Tue, May 21, 7:32 AM · Build System, Frameworks