User Details
User Details
- User Since
- Mar 5 2015, 12:44 PM (273 w, 3 d)
- Availability
- Available
Today
Today
dfaure committed R241:6936c76fffa6: Use ++ operator to advance QHash::const_iterator (authored by ahmadsamir).
Use ++ operator to advance QHash::const_iterator
dfaure committed R241:f9d683c4abdb: autotests: fix kdirmodeltest by restoring the dirlister mode (authored by dfaure).
autotests: fix kdirmodeltest by restoring the dirlister mode
Sat, May 30
Sat, May 30
dfaure committed R241:fce5800150e7: RenameDialog: Warn when file sizes are not the same (authored by meven).
RenameDialog: Warn when file sizes are not the same
dfaure committed R241:b633cf2e0ecb: GIT_SILENT ++KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT ++KF_DISABLE_DEPRECATED_BEFORE_AND_AT
dfaure committed R241:c494d1b60862: [KSambaShare] Check that both smbd and testparm are available (authored by ahmadsamir).
[KSambaShare] Check that both smbd and testparm are available
dfaure committed R241:395854b0a1c6: Fix test KFilePlacesModelTest::testEnableBaloo (authored by meven).
Fix test KFilePlacesModelTest::testEnableBaloo
dfaure committed R241:f08ceea98ed9: RenameDialog: Warn when file sizes are not the same (authored by meven).
RenameDialog: Warn when file sizes are not the same
Thanks!
dfaure committed R241:fe87d93250d2: KDirModel: fix hasChildren() regression for trees with files shown (authored by dfaure).
KDirModel: fix hasChildren() regression for trees with files shown
Fri, May 29
Fri, May 29
dfaure committed R295:52b1b8b27237: Add X-KDE-KCM-Args as property, read property in module loader (authored by alex).
Add X-KDE-KCM-Args as property, read property in module loader
dfaure committed R241:b719f5758f65: file_unix.cpp: when ::rename is used as condition compare its return to -1 (authored by ahmadsamir).
file_unix.cpp: when ::rename is used as condition compare its return to -1
dfaure requested changes to D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error.
I have modified DesktopExecParser in kio commit d1e9325fba37eddb9cb44173edfc1fee122a0c57 to return an error string so that its users don't need to do the work again of figuring out what went wrong (see DesktopExecParser::errorMessage()).
I just realized that this would be very useful here as well. AFAICS the current patch only works if the user types a full path, not with a relative path.
dfaure added a comment to D26113: Places: Use Solid::Device::DisplayName for DisplayRole.
Please check that kfileplacesmodeltest and kfileplacesviewtest still pass.
dfaure added a comment to D29814: Fix segfault on no restart args.
Can you explain how to trigger this crash in the first place? Which application triggers it?
Wed, May 27
Wed, May 27
dfaure requested changes to D29814: Fix segfault on no restart args.
I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled??
dfaure added a comment to D29809: Don't invoke qstring localized stuff in critical section.
Makes sense; just two minor things.
Port away from deprecated QLinkedList
Coding style; one more const
Remove redundant #include
Port away from deprecated QLinkedList
Tue, May 26
Tue, May 26
dfaure requested changes to D29668: Do not reject icon theme dir with invalid context/type..
Mon, May 25
Mon, May 25
KFileItem: localize timeString
Sat, May 23
Sat, May 23
GIT_SILENT remove some traces of KRun
dfaure committed R226:b5982a4246f5: Port from KRun::displayOpenWithDialog to OpenUrlJob (authored by dfaure).
Port from KRun::displayOpenWithDialog to OpenUrlJob
Port away from Qt::escape
dfaure committed R226:6d7d4284dedb: Port konq_popupmenu from KRun to OpenUrlJob (authored by dfaure).
Port konq_popupmenu from KRun to OpenUrlJob
Port kfmclient from KRun to OpenUrlJob.
Port to KIOGuiPrivate::checkStartupNotify
dfaure committed R497:9401ee159c40: Feat: Port framework release script to kde.org in git (authored by ognarb).
Feat: Port framework release script to kde.org in git
Fri, May 22
Fri, May 22
Port plasma-framework away from KRun
Port plasma-framework away from KRun
Add porting docu for KRun constructor.
GIT_SILENT add explanation
dfaure committed R241:60475571926d: KUrlNavigatorPlacesSelector: only update once the menu on changes (authored by meven).
KUrlNavigatorPlacesSelector: only update once the menu on changes
dfaure committed R295:e290e9e666fc: Port these two to KCModuleInfo::property() as well, seems to fix Configure… (authored by dfaure).
Port these two to KCModuleInfo::property() as well, seems to fix Configure…
dfaure committed R295:c2db5f797fd3: Repair kcmshell5 after previous commits, now with unittest (authored by dfaure).
Repair kcmshell5 after previous commits, now with unittest
dfaure committed R295:b1f56973ea19: Add test for a "normal" KCM with desktop file (authored by dfaure).
Add test for a "normal" KCM with desktop file
dfaure committed R295:a65c6819464b: Rename KCModuleInfo unittest and extend it with the "fake KCM" testcase (authored by dfaure).
Rename KCModuleInfo unittest and extend it with the "fake KCM" testcase
Thu, May 21
Thu, May 21
GIT_SILENT remove last traces of KRun
Support multiple entries in XDG_DATA_DIRS
dfaure updated the diff for D29613: Support multiple entries in XDG_DATA_DIRS.
add missing braces
dfaure added a comment to D29613: Support multiple entries in XDG_DATA_DIRS.
They are used. But indeed I don't actually need that to fix my use case. I thought proper cascading was better than just fixing my use case?
dfaure committed R295:53b41bc90b35: Fix crash when loading an external app KCM like yast (authored by dfaure).
Fix crash when loading an external app KCM like yast
Wed, May 20
Wed, May 20
Address review comments
dfaure added a comment to D28765: KSettings::Dialog: add support for KPluginInfos without a KService.
dfaure committed R295:0f442313d335: Fix crash when loading an external app KCM like yast (authored by dfaure).
Fix crash when loading an external app KCM like yast
Fix another crash due to a null cursor.
Tue, May 19
Tue, May 19
Port KRun::runUrl to KIO::OpenUrlJob
dfaure updated the diff for D29598: Port KRun::runUrl to KIO::OpenUrlJob.
adjust commit log
Improve error message when saving
dfaure added a comment to D29613: Support multiple entries in XDG_DATA_DIRS.
ping?
dfaure committed R241:347b48f7ef82: autotests: allow xterm to be in /usr/local/bin (FreeBSD) (authored by dfaure).
autotests: allow xterm to be in /usr/local/bin (FreeBSD)
Mon, May 18
Mon, May 18
Update KF6 TODO -- GIT_SILENT
dfaure committed R241:fe059af66760: Fix compilation with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT (authored by dfaure).
Fix compilation with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT
dfaure committed R241:4e782be573fb: GIT_SILENT autotests: one last quote to fix CI (authored by dfaure).
GIT_SILENT autotests: one last quote to fix CI
dfaure committed R241:cf728b92aae3: ApplicationLauncherJob: show the Open With dialog if no service was passed (authored by dfaure).
ApplicationLauncherJob: show the Open With dialog if no service was passed
dfaure committed R241:6de2688ebd30: ApplicationLauncherJob: show the Open With dialog if no service was passed (authored by dfaure).
ApplicationLauncherJob: show the Open With dialog if no service was passed
dfaure committed R241:fe26267f9941: GIT_SILENT quote expected value, to fix CI (authored by dfaure).
GIT_SILENT quote expected value, to fix CI
dfaure committed R241:6adaa3a2f797: autotests: fix krununittest for CI; remove qDebug (authored by dfaure).
autotests: fix krununittest for CI; remove qDebug
dfaure committed R241:718659841aab: autotests: use ktrash5 instead of kdeinit5, to pick something installed by KIO (authored by dfaure).
autotests: use ktrash5 instead of kdeinit5, to pick something installed by KIO
Port from KRun::runUrl to OpenUrlJob
Port from runUrl to OpenUrlJob
dfaure committed R241:423c48f2a51a: ApplicationLauncherJob: show the Open With dialog if no service was passed (authored by dfaure).
ApplicationLauncherJob: show the Open With dialog if no service was passed
Sun, May 17
Sun, May 17
dfaure committed R241:f6849fde97f7: Port runapplication to ApplicationLauncherJob (authored by dfaure).
Port runapplication to ApplicationLauncherJob
Port kruntest to OpenUrlJob
dfaure committed R241:aad751d4643e: OpenUrlJob: document the use of KIO::JobUiDelegate (authored by dfaure).
OpenUrlJob: document the use of KIO::JobUiDelegate
dfaure committed R241:486d9aabeef3: Port OpenFileManagerWindowJob to KIO::OpenUrlJob (authored by dfaure).
Port OpenFileManagerWindowJob to KIO::OpenUrlJob
dfaure committed R241:ca3f3556175e: Port OpenFileManagerWindowJob to KIO::OpenUrlJob (authored by dfaure).
Port OpenFileManagerWindowJob to KIO::OpenUrlJob
Port KAutoMount to OpenUrlJob.
dfaure committed R241:1c7acb567fda: Port OpenFileManagerWindowJob to KIO::OpenUrlJob (authored by dfaure).
Port OpenFileManagerWindowJob to KIO::OpenUrlJob
dfaure committed R241:5d4af5197d2f: GIT_SILENT add missing macro around runLink too (authored by dfaure).
GIT_SILENT add missing macro around runLink too
dfaure committed R241:5c684e8726ce: Make sure the program exists and is executable before we inject… (authored by dfaure).
Make sure the program exists and is executable before we inject…
dfaure committed R241:ad0e97b1994d: Add missing deprecation macro, the only caller has the same (authored by dfaure).
Add missing deprecation macro, the only caller has the same
dfaure committed R241:cc211959ef51: Port OpenFileManagerWindowJob to KIO::OpenUrlJob (authored by dfaure).
Port OpenFileManagerWindowJob to KIO::OpenUrlJob
dfaure committed R241:2e25bdca620d: ApplicationLauncherJob: show the Open With dialog if no service was passed (authored by dfaure).
ApplicationLauncherJob: show the Open With dialog if no service was passed
dfaure committed R241:947f9ef281b6: ApplicationLauncherJob: show the Open With dialog if no service was passed (authored by dfaure).
ApplicationLauncherJob: show the Open With dialog if no service was passed
dfaure committed R241:18d1bad232e3: Make sure the program exists and is executable before we inject… (authored by dfaure).
Make sure the program exists and is executable before we inject…
dfaure committed R241:fbf3a76e23cf: Make sure the program exists and is executable before we inject… (authored by dfaure).
Make sure the program exists and is executable before we inject…
dfaure committed R241:38acf99b1fc1: ApplicationLauncherJob: show the Open With dialog if no service was passed (authored by dfaure).
ApplicationLauncherJob: show the Open With dialog if no service was passed
dfaure added a comment to D29738: Fix service file specifying 'Run in terminal' giving an error code 100.
(Intrusive) fix is up at https://invent.kde.org/frameworks/kio/-/merge_requests/3
dfaure committed R241:24020c55a9b2: Make sure the program exists and is executable before we inject… (authored by dfaure).
Make sure the program exists and is executable before we inject…
dfaure added inline comments to D29687: [IconApplet] Port KRun to ApplicationLauncherJob.
KServiceFactory::findServiceByStorageId falls back to "new KService" if it can't find the storageId in ksycoca. So yes it worked, but it's kind of pointless (and confusing) to call it just to go to the new KService fallback, better do that directly.
dfaure added a comment to D29738: Fix service file specifying 'Run in terminal' giving an error code 100.
Well spotted. Indeed, when using kioexec (because of the DeleteTemporaryFiles option) we no longer detect non-existing executables. I'll look into fixing this.
dfaure committed R241:94598635adcc: autotests: repair clipboardupdatertest after port to KIO::paste (authored by dfaure).
autotests: repair clipboardupdatertest after port to KIO::paste
dfaure added a comment to D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog.
Yeah, the full story is that I pushed to git.kde.org, reverted because I changed my mind, then the sysadmins told me I wasn't supposed to push to git.kde.org at all (it was blocked for everyone, but I have sysadmin privileges for historical and bus-factor reasons). We realized there was nothing to sync to gitlab anyway, since I had simply done push+push+revert+revert.
dfaure committed R241:69c949da193a: Rename KIO::OpenUrlJobHandlerInterface to KIO::OpenWithHandlerInterface (authored by dfaure).
Rename KIO::OpenUrlJobHandlerInterface to KIO::OpenWithHandlerInterface
dfaure reopened D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog.
Not committed after all.
dfaure committed R241:18cd92e4811e: Fix new test method in jobtest to clean up after itself (authored by dfaure).
Fix new test method in jobtest to clean up after itself
dfaure committed R241:8faf9776c5d6: Support multiple URLs in promptUserForApplication() (authored by dfaure).
Support multiple URLs in promptUserForApplication()
Sat, May 16
Sat, May 16
Thanks for the unittest and fix!
dfaure added a comment to D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs.
OK, I picked testtrash because kio_trash *is* a :local protocol. If it doesn't use UDS_LOCAL_PATH, at least it means the job will actually go through (no early filtering out). That's at least interesting to test too.
dfaure committed R241:56d42d93e333: Revert "Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun… (authored by dfaure).
Revert "Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun…