dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (233 w, 3 h)
Availability
Available

Recent Activity

Today

dfaure committed R311:10c60ecd5513: Port to non-deprecated KWindowSystem::setMainWindow overload (authored by dfaure).
Port to non-deprecated KWindowSystem::setMainWindow overload
Thu, Aug 22, 12:46 PM
dfaure committed R241:268121bbeb88: KIO: port to non-deprecated KWindowSystem::setMainWindow (authored by dfaure).
KIO: port to non-deprecated KWindowSystem::setMainWindow
Thu, Aug 22, 12:38 PM
dfaure requested review of D23347: kdelibs4support: port away from deprecated KWindowSystem API.
Thu, Aug 22, 12:21 PM · Frameworks
dfaure added a comment to D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan.

Probably still valid, yes. Needs investigation, and a unittest....

Thu, Aug 22, 12:18 PM · Frameworks
dfaure abandoned D18536: Another attempt at fixing arc diff not setting the repository.

Not really an issue anymore, https://phabricator.kde.org/D22578 had the right repository somehow.

Thu, Aug 22, 12:16 PM
dfaure closed D23215: Port to non-deprecated KWindowSystem::setMainWindow overload.
Thu, Aug 22, 12:13 PM · Frameworks
dfaure closed D23217: KIO: port to non-deprecated KWindowSystem::setMainWindow.
Thu, Aug 22, 12:12 PM · Frameworks
dfaure committed R108:36ee6729034d: Merge remote-tracking branch 'origin/Plasma/5.16' (authored by dfaure).
Merge remote-tracking branch 'origin/Plasma/5.16'
Thu, Aug 22, 12:10 PM
dfaure committed R108:ba5432fd52ef: Remove slideWindow(QWidget*) overload with recent KWindowSystem (authored by dfaure).
Remove slideWindow(QWidget*) overload with recent KWindowSystem
Thu, Aug 22, 12:10 PM
dfaure closed D23227: Remove slideWindow(QWidget*) overload with recent KWindowSystem.
Thu, Aug 22, 12:09 PM · KWin
dfaure committed R130:e99558e33987: Merge remote-tracking branch 'origin/Plasma/5.16' (authored by dfaure).
Merge remote-tracking branch 'origin/Plasma/5.16'
Thu, Aug 22, 12:08 PM
dfaure committed R130:143a325ad1f4: Remove slideWindow(QWidget*) overload with recent KWindowSystem (authored by dfaure).
Remove slideWindow(QWidget*) overload with recent KWindowSystem
Thu, Aug 22, 12:07 PM
dfaure closed D23334: Remove slideWindow(QWidget*) overload with recent KWindowSystem.
Thu, Aug 22, 12:07 PM · Plasma
dfaure added a comment to D23216: KWindowSystem: add cmake option KWINDOWSYSTEM_NO_WIDGETS.

This one still needs a review.

Thu, Aug 22, 12:04 PM
dfaure committed R278:ef202bd54db0: Deprecate slideWindow(QWidget *widget) (authored by dfaure).
Deprecate slideWindow(QWidget *widget)
Thu, Aug 22, 12:03 PM
dfaure closed D23213: Deprecate slideWindow(QWidget *widget).
Thu, Aug 22, 12:03 PM · Frameworks
dfaure closed D23211: KWindowSystem: fix compilation with KWINDOWSYSTEM_NO_DEPRECATED.
Thu, Aug 22, 12:03 PM · Frameworks
dfaure committed R278:d458a2295360: KWindowSystem: fix compilation with KWINDOWSYSTEM_NO_DEPRECATED (authored by dfaure).
KWindowSystem: fix compilation with KWINDOWSYSTEM_NO_DEPRECATED
Thu, Aug 22, 12:03 PM
dfaure committed R278:7a913367487d: Add KWindowSystem::setMainWindow(QWindow *) overload (authored by dfaure).
Add KWindowSystem::setMainWindow(QWindow *) overload
Thu, Aug 22, 12:03 PM
dfaure closed D23108: Add KWindowSystem::setMainWindow(QWindow *) overload.
Thu, Aug 22, 12:01 PM · Frameworks
dfaure added a comment to D23227: Remove slideWindow(QWidget*) overload with recent KWindowSystem.

Yep, I had that locally, here it is https://phabricator.kde.org/D23334

Thu, Aug 22, 8:42 AM · KWin
dfaure requested review of D23334: Remove slideWindow(QWidget*) overload with recent KWindowSystem.
Thu, Aug 22, 8:42 AM · Plasma
dfaure updated the diff for D23108: Add KWindowSystem::setMainWindow(QWindow *) overload.

Fix memory leak in new overload

Thu, Aug 22, 8:40 AM · Frameworks
dfaure added inline comments to D23108: Add KWindowSystem::setMainWindow(QWindow *) overload.
Thu, Aug 22, 8:40 AM · Frameworks

Sun, Aug 18

dfaure committed R120:4f39afc056c8: Merge remote-tracking branch 'origin/Plasma/5.16' (authored by dfaure).
Merge remote-tracking branch 'origin/Plasma/5.16'
Sun, Aug 18, 8:24 AM
dfaure committed R120:eaa5e74c04c5: Add missing include (QJsonArray) to fix compilation with Qt 5.13 (authored by dfaure).
Add missing include (QJsonArray) to fix compilation with Qt 5.13
Sun, Aug 18, 8:24 AM
dfaure added inline comments to D23211: KWindowSystem: fix compilation with KWINDOWSYSTEM_NO_DEPRECATED.
Sun, Aug 18, 7:40 AM · Frameworks
dfaure added a comment to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

The truth is stronger than "I would not recommend".
put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.

Sun, Aug 18, 7:08 AM · Frameworks, Dolphin

Sat, Aug 17

dfaure added inline comments to D23211: KWindowSystem: fix compilation with KWINDOWSYSTEM_NO_DEPRECATED.
Sat, Aug 17, 9:08 PM · Frameworks
dfaure requested review of D23228: Port away from deprecated KWindowSystem API.
Sat, Aug 17, 8:53 PM · Plasma
dfaure requested review of D23227: Remove slideWindow(QWidget*) overload with recent KWindowSystem.
Sat, Aug 17, 8:43 PM · KWin
dfaure added a comment to D23225: Allow 0 in line ranges in vim mode..

The unittest doesn't seem to pass on CI:
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/149/testReport/junit/projectroot.autotests.src/vimode/vimode_emulatedcommandbar/

FAIL!  :   EmulatedCommandBarTest::EmulatedCommandBarTests() Compared values are not the same
Actual   (kate_document->text()): "bar\nbar\nbar"
Expected (expected_text)        : "foo\nfoo\nbar"
Loc: [/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 SUSEQt5.12/autotests/src/vimode/emulatedcommandbar.cpp(1950)]
Sat, Aug 17, 8:14 PM · Frameworks, Kate
dfaure committed R342:6dc435ae6e87: Merge branch 'Applications/19.08' (authored by dfaure).
Merge branch 'Applications/19.08'
Sat, Aug 17, 12:47 PM
dfaure committed R342:1169ad1fa6bf: Add missing ShowPreviews key to audiocd.json (authored by dfaure).
Add missing ShowPreviews key to audiocd.json
Sat, Aug 17, 12:47 PM
dfaure requested review of D23217: KIO: port to non-deprecated KWindowSystem::setMainWindow.
Sat, Aug 17, 12:15 PM · Frameworks
dfaure requested review of D23216: KWindowSystem: add cmake option KWINDOWSYSTEM_NO_WIDGETS.
Sat, Aug 17, 12:11 PM
dfaure requested review of D23215: Port to non-deprecated KWindowSystem::setMainWindow overload.
Sat, Aug 17, 11:17 AM · Frameworks
dfaure requested review of D23213: Deprecate slideWindow(QWidget *widget).
Sat, Aug 17, 10:56 AM · Frameworks
dfaure updated the diff for D23211: KWindowSystem: fix compilation with KWINDOWSYSTEM_NO_DEPRECATED.

fix description

Sat, Aug 17, 10:11 AM · Frameworks
dfaure requested review of D23211: KWindowSystem: fix compilation with KWINDOWSYSTEM_NO_DEPRECATED.
Sat, Aug 17, 10:11 AM · Frameworks
dfaure updated the diff for D23108: Add KWindowSystem::setMainWindow(QWindow *) overload.

Adjust documentation

Sat, Aug 17, 8:36 AM · Frameworks

Fri, Aug 16

dfaure accepted D23204: Restore backward compatibility for the version header.
Fri, Aug 16, 5:49 PM · KDE PIM
dfaure requested changes to D23202: Fix headers for >=KCalCore-5.12.0.
Fri, Aug 16, 3:47 PM · Calligra: 3.0
dfaure added a reviewer for D23202: Fix headers for >=KCalCore-5.12.0: vkrause.
Fri, Aug 16, 3:46 PM · Calligra: 3.0
dfaure accepted D23199: Rename childTask to isChildTask in TaskExtraData.

What a good idea :-)

Fri, Aug 16, 1:58 PM
dfaure requested changes to D17595: Upstream Dolphin's file rename dialog.
Fri, Aug 16, 11:13 AM · Frameworks
dfaure committed R165:4fb179ce46ad: ItemSync: skip handling remote items if local changes failed (authored by dfaure).
ItemSync: skip handling remote items if local changes failed
Fri, Aug 16, 11:04 AM
dfaure committed R165:15c91a0ac930: Akonadi: fix dangling transaction after itemsync failure (authored by dfaure).
Akonadi: fix dangling transaction after itemsync failure
Fri, Aug 16, 11:04 AM
dfaure accepted D23182: Switch ItemDelegate to the finer grained additional info roles.

Yeah, clearly unfinished, but this shows how we'll access the information.

Fri, Aug 16, 7:39 AM
dfaure accepted D23181: Add finer grained roles for the additional info.
Fri, Aug 16, 7:13 AM
dfaure accepted D23180: Have all the relevant PageModel use defaultTaskData.

Nice de-duplication.

Fri, Aug 16, 7:11 AM
dfaure accepted D23179: Rename dataForTaskWithProject to defaultTaskData.
Fri, Aug 16, 7:09 AM
dfaure accepted D23178: Extend TaskExtraData to support data source and contexts.
Fri, Aug 16, 7:08 AM
dfaure accepted D23177: Remove useless include.
Fri, Aug 16, 7:04 AM
dfaure requested changes to D17595: Upstream Dolphin's file rename dialog.
Fri, Aug 16, 7:04 AM · Frameworks

Wed, Aug 14

dfaure committed R241:7d888cb31db6: KRun: fix runtime warning when widget is null (authored by dfaure).
KRun: fix runtime warning when widget is null
Wed, Aug 14, 10:03 AM
dfaure closed D23147: KRun: fix runtime warning when widget is null.
Wed, Aug 14, 10:03 AM · Frameworks
dfaure requested review of D23147: KRun: fix runtime warning when widget is null.
Wed, Aug 14, 9:10 AM · Frameworks

Mon, Aug 12

dfaure committed R758:a38e1b6456cb: Merge branch '5.0' (authored by dfaure).
Merge branch '5.0'
Mon, Aug 12, 11:54 AM
dfaure committed R758:a6f0549c9401: Fix taglib includes to match the way taglib was meant to be used: #include <tag. (authored by dfaure).
Fix taglib includes to match the way taglib was meant to be used: #include <tag.
Mon, Aug 12, 11:53 AM
dfaure requested review of D23108: Add KWindowSystem::setMainWindow(QWindow *) overload.
Mon, Aug 12, 9:47 AM · Frameworks

Sun, Aug 11

dfaure committed R278:288b78d7d11a: KWindowSystem: add setNewStartupId(QWindow *...) overload (authored by dfaure).
KWindowSystem: add setNewStartupId(QWindow *...) overload
Sun, Aug 11, 2:04 PM
dfaure closed D23088: KWindowSystem: add setNewStartupId(QWindow *...) overload.
Sun, Aug 11, 2:04 PM · Frameworks
dfaure committed R278:09228717fb36: KWindowSystem: remove unused QWidget includes (authored by dfaure).
KWindowSystem: remove unused QWidget includes
Sun, Aug 11, 2:03 PM
dfaure closed D23089: KWindowSystem: remove unused QWidget includes.
Sun, Aug 11, 2:02 PM · Frameworks
dfaure added a comment to D23089: KWindowSystem: remove unused QWidget includes.
In D23089#510276, @zzag wrote:

"KWindowSystem:" can be omitted in the subject line.

Sun, Aug 11, 2:02 PM · Frameworks
dfaure committed R241:55f45250c937: KRun: remove KProcessRunner dependency on QtWidgets (authored by dfaure).
KRun: remove KProcessRunner dependency on QtWidgets
Sun, Aug 11, 1:14 PM
dfaure closed D23092: KRun: remove KProcessRunner dependency on QtWidgets.
Sun, Aug 11, 1:13 PM · Frameworks
dfaure requested review of D23092: KRun: remove KProcessRunner dependency on QtWidgets.
Sun, Aug 11, 12:58 PM · Frameworks
dfaure requested review of D23089: KWindowSystem: remove unused QWidget includes.
Sun, Aug 11, 12:28 PM · Frameworks
dfaure committed R278:73b9ed7dc4b7: KWindowSystem: port from QApplication to QCoreApplication (authored by dfaure).
KWindowSystem: port from QApplication to QCoreApplication
Sun, Aug 11, 12:25 PM
dfaure updated the diff for D23088: KWindowSystem: add setNewStartupId(QWindow *...) overload.

Add test for QWidget overload and fix crash

Sun, Aug 11, 12:22 PM · Frameworks
dfaure added a comment to D23088: KWindowSystem: add setNewStartupId(QWindow *...) overload.

vladz has no phab account?

Sun, Aug 11, 11:18 AM · Frameworks
dfaure requested review of D23088: KWindowSystem: add setNewStartupId(QWindow *...) overload.
Sun, Aug 11, 11:18 AM · Frameworks
dfaure committed R241:c75b5ff61041: GIT_SILENT fix compiler warning (authored by dfaure).
GIT_SILENT fix compiler warning
Sun, Aug 11, 10:45 AM
dfaure committed R275:072dc8f0f715: Port away from deprecated methods in Qt (authored by dfaure).
Port away from deprecated methods in Qt
Sun, Aug 11, 9:03 AM
dfaure committed R275:81529406d824: Port away from deprecated method QModelIndex::child() (authored by dfaure).
Port away from deprecated method QModelIndex::child()
Sun, Aug 11, 8:52 AM
dfaure committed R241:b2ce4388004c: Port KIO::Job documentation to Qt5-style connect syntax (authored by dfaure).
Port KIO::Job documentation to Qt5-style connect syntax
Sun, Aug 11, 8:36 AM
dfaure committed R226:7145003deec2: Fix konqueror exiting immediately when using --open-session (authored by dfaure).
Fix konqueror exiting immediately when using --open-session
Sun, Aug 11, 7:58 AM
dfaure committed R226:473555629acf: Port to QTRY_COMPARE (authored by dfaure).
Port to QTRY_COMPARE
Sun, Aug 11, 7:22 AM
dfaure committed R883:1549305: Add missing KConfig security fix to the changelog.
Add missing KConfig security fix to the changelog
Sun, Aug 11, 7:08 AM
dfaure committed R497:835fd1da445f: improve email; increase version (authored by dfaure).
improve email; increase version
Sun, Aug 11, 7:06 AM
dfaure committed R497:58b58f1e7b8f: Fix the "5.52" bug for good (authored by dfaure).
Fix the "5.52" bug for good
Sun, Aug 11, 7:05 AM
dfaure committed R883:1549304: KF 5.61.
KF 5.61
Sun, Aug 11, 7:01 AM

Sat, Aug 10

dfaure committed R883:1549278: add frameworks-5.61.0 to generate_release_data.py.
add frameworks-5.61.0 to generate_release_data.py
Sat, Aug 10, 8:01 PM

Fri, Aug 9

dfaure committed R205:7ad2bfc3f3d0: Merge branch 'Applications/19.08' (authored by dfaure).
Merge branch 'Applications/19.08'
Fri, Aug 9, 8:28 AM
dfaure committed R205:285946e2a895: KAlarm: simplify the starting of KOrganizer to use DBus activation (authored by dfaure).
KAlarm: simplify the starting of KOrganizer to use DBus activation
Fri, Aug 9, 8:28 AM
dfaure closed D22626: KAlarm: simplify the starting of KOrganizer to use DBus activation.
Fri, Aug 9, 8:27 AM · KDE PIM
dfaure added a comment to D22626: KAlarm: simplify the starting of KOrganizer to use DBus activation.

This is no bug. isValid() doesn't make a remote procedure call to check if the remote object still exists.

Fri, Aug 9, 8:27 AM · KDE PIM

Wed, Aug 7

dfaure committed R883:1549091: kconfig: malicious .desktop files (and others) would execute code.
kconfig: malicious .desktop files (and others) would execute code
Wed, Aug 7, 9:13 PM
l10n daemon script <scripty@kde.org> committed R237:01674d7d5b1d: Security: remove support for $(...) in config keys with [$e] marker. (authored by dfaure).
Security: remove support for $(...) in config keys with [$e] marker.
Wed, Aug 7, 8:04 PM
dfaure added a comment to D22979: Security: remove support for $(...) in config keys with [$e] marker..

Yes.

Wed, Aug 7, 7:56 PM · Frameworks
dfaure committed R237:5d3e71b1d2ec: Security: remove support for $(...) in config keys with [$e] marker. (authored by dfaure).
Security: remove support for $(...) in config keys with [$e] marker.
Wed, Aug 7, 2:04 PM
dfaure closed D22979: Security: remove support for $(...) in config keys with [$e] marker..
Wed, Aug 7, 2:04 PM · Frameworks
dfaure accepted D22989: Security: remove support for $(...) in config keys with [$e] marker..
Wed, Aug 7, 2:04 PM
dfaure committed R883:1549022: Use 5.xx here too for consistency.
Use 5.xx here too for consistency
Wed, Aug 7, 7:57 AM
dfaure committed R883:1549021: Fix wrong version numbers.
Fix wrong version numbers
Wed, Aug 7, 7:57 AM
dfaure committed R883:1549019: Fix broken link, thanks to Friedrich for noticing.
Fix broken link, thanks to Friedrich for noticing
Wed, Aug 7, 7:45 AM
dfaure committed R355:2f9e8ffe4bfb: kdebugsettings: add option --test-mode to configure output from unittests (authored by dfaure).
kdebugsettings: add option --test-mode to configure output from unittests
Wed, Aug 7, 7:41 AM
dfaure closed D22913: kdebugsettings: add option --test-mode to configure output from unittests.
Wed, Aug 7, 7:41 AM