dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (163 w, 5 d)
Availability
Available

Recent Activity

Sun, Apr 22

dfaure requested review of D12461: Akonadiconsole: support incidences serialized in the binary format.
Sun, Apr 22, 10:10 PM · KDE PIM
dfaure committed R170:4d298c77ca1f: Merge remote-tracking branch 'origin/Applications/18.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/18.04'
Sun, Apr 22, 1:46 PM
dfaure committed R170:262aaf3e0308: Binary serializer code now supports FreeBusy too, so we can remove "default"… (authored by dfaure).
Binary serializer code now supports FreeBusy too, so we can remove "default"…
Sun, Apr 22, 1:45 PM
dfaure committed R165:ba3420a81f31: Merge remote-tracking branch 'origin/Applications/18.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/18.04'
Sun, Apr 22, 1:42 PM
dfaure committed R165:f14a6e997629: TransactionSequence: fix rollback not finishing properly. (authored by dfaure).
TransactionSequence: fix rollback not finishing properly.
Sun, Apr 22, 1:42 PM
dfaure closed D12426: TransactionSequence: fix rollback not finishing properly..
Sun, Apr 22, 1:42 PM · KDE PIM
dfaure committed R81:6284d7759904: Merge branch 'Applications/18.04' (authored by dfaure).
Merge branch 'Applications/18.04'
Sun, Apr 22, 11:42 AM
dfaure committed R733:33a2156fef6f: Merge branch 'Applications/18.04' (authored by dfaure).
Merge branch 'Applications/18.04'
Sun, Apr 22, 10:15 AM
dfaure committed R733:c1b826b79783: Remove dependency on KMime, in master branch. (authored by dfaure).
Remove dependency on KMime, in master branch.
Sun, Apr 22, 10:15 AM
dfaure committed R733:98956d3bcd49: Partial revert, restore API in the stable branch. (authored by dfaure).
Partial revert, restore API in the stable branch.
Sun, Apr 22, 10:14 AM
dfaure added a reverting change for R733:93a7777ae7dc: KSMTP: remove dependency on KMime, by removing setMessage().: R733:98956d3bcd49: Partial revert, restore API in the stable branch..
Sun, Apr 22, 10:14 AM
dfaure committed R733:988e06498609: KSMTP: Fix sending emails where a line starts with a dot (authored by dfaure).
KSMTP: Fix sending emails where a line starts with a dot
Sun, Apr 22, 10:08 AM
dfaure closed D12434: KSMTP: Fix sending emails where a line starts with a dot.
Sun, Apr 22, 10:08 AM · KDE PIM
dfaure committed R733:93a7777ae7dc: KSMTP: remove dependency on KMime, by removing setMessage(). (authored by dfaure).
KSMTP: remove dependency on KMime, by removing setMessage().
Sun, Apr 22, 10:08 AM
dfaure closed D12432: KSMTP: remove dependency on KMime, by removing setMessage()..
Sun, Apr 22, 10:08 AM · KDE PIM
dfaure committed R44:76e1cca20a8c: Merge remote-tracking branch 'origin/Applications/18.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/18.04'
Sun, Apr 22, 10:06 AM
dfaure committed R44:743e0cb230d6: IMAP resource: fix data loss on connection lost, depending on the current task (authored by dfaure).
IMAP resource: fix data loss on connection lost, depending on the current task
Sun, Apr 22, 10:06 AM
dfaure committed R44:60dbde3cd4e5: IMAP resource: fix data loss on connection lost, depending on the current task (authored by dfaure).
IMAP resource: fix data loss on connection lost, depending on the current task
Sun, Apr 22, 10:06 AM
dfaure closed D12427: IMAP resource: fix data loss on connection lost, depending on the current task.
Sun, Apr 22, 10:06 AM · KDE PIM
dfaure added inline comments to D12434: KSMTP: Fix sending emails where a line starts with a dot.
Sun, Apr 22, 10:02 AM · KDE PIM
dfaure updated the diff for D12434: KSMTP: Fix sending emails where a line starts with a dot.

Add bug number

Sun, Apr 22, 9:57 AM · KDE PIM
dfaure requested review of D12434: KSMTP: Fix sending emails where a line starts with a dot.
Sun, Apr 22, 9:56 AM · KDE PIM
dfaure updated the diff for D12432: KSMTP: remove dependency on KMime, by removing setMessage()..

Improve unittest by actually testing the body too.

Sun, Apr 22, 9:34 AM · KDE PIM
dfaure requested review of D12432: KSMTP: remove dependency on KMime, by removing setMessage()..
Sun, Apr 22, 9:18 AM · KDE PIM
dfaure committed R81:f3da346dcecd: Fix GrantleeTheme::ThemeManager being leaked. (authored by dfaure).
Fix GrantleeTheme::ThemeManager being leaked.
Sun, Apr 22, 8:58 AM
dfaure closed D12431: Fix GrantleeTheme::ThemeManager being leaked..
Sun, Apr 22, 8:58 AM · KDE PIM
dfaure requested review of D12431: Fix GrantleeTheme::ThemeManager being leaked..
Sun, Apr 22, 8:55 AM · KDE PIM
dfaure added a comment to D12371: fix always reproducible crash.

It looks like the issue is that forgetDirs() doesn't find smb:// on the line of code that says DirectoryDataHash::iterator dit = directoryData.find(urlStr);.
So it goes into early return and doesn't do dirData.listersCurrentlyHolding.removeAll(lister);
which later leads to using a deleted lister that is still in listersCurrentlyHolding (for a slightly different URL).

Sun, Apr 22, 7:31 AM · Frameworks

Sat, Apr 21

dfaure requested review of D12427: IMAP resource: fix data loss on connection lost, depending on the current task.
Sat, Apr 21, 10:44 PM · KDE PIM
dfaure requested review of D12426: TransactionSequence: fix rollback not finishing properly..
Sat, Apr 21, 10:24 PM · KDE PIM
dfaure committed R44:990052941b36: IMAP: Collection removal should be replayed on error. (authored by dfaure).
IMAP: Collection removal should be replayed on error.
Sat, Apr 21, 8:39 PM
dfaure committed R44:a15be637c051: IMAP: Collection removal should be replayed on error. (authored by dfaure).
IMAP: Collection removal should be replayed on error.
Sat, Apr 21, 8:39 PM
dfaure closed D12421: IMAP: Collection removal should be replayed on error..
Sat, Apr 21, 8:39 PM · KDE PIM
dfaure requested review of D12421: IMAP: Collection removal should be replayed on error..
Sat, Apr 21, 8:36 PM · KDE PIM
dfaure committed R44:625fb4bc60f5: GIT_SILENT remove conflict markers (authored by dfaure).
GIT_SILENT remove conflict markers
Sat, Apr 21, 8:09 PM
dfaure committed R44:f21fa67b09a7: Merge remote-tracking branch 'origin/Applications/18.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/18.04'
Sat, Apr 21, 7:59 PM
dfaure committed R44:e1ed624d87d1: IMAP Resource: handle disconnection before initial "OK" from server (authored by dfaure).
IMAP Resource: handle disconnection before initial "OK" from server
Sat, Apr 21, 7:59 PM
dfaure committed R44:5f3cf19f8755: IMAP Resource: handle disconnection before initial "OK" from server (authored by dfaure).
IMAP Resource: handle disconnection before initial "OK" from server
Sat, Apr 21, 7:59 PM
dfaure closed D12418: IMAP Resource: handle disconnection before initial "OK" from server.
Sat, Apr 21, 7:58 PM · KDE PIM
dfaure committed R165:b07c028b33ae: Akonadi: fix documentation of ResourceBase::deferTask() (authored by dfaure).
Akonadi: fix documentation of ResourceBase::deferTask()
Sat, Apr 21, 7:45 PM
dfaure closed D12419: Akonadi: fix documentation of ResourceBase::deferTask().
Sat, Apr 21, 7:45 PM · KDE PIM
dfaure requested review of D12419: Akonadi: fix documentation of ResourceBase::deferTask().
Sat, Apr 21, 7:36 PM · KDE PIM
dfaure requested review of D12418: IMAP Resource: handle disconnection before initial "OK" from server.
Sat, Apr 21, 5:49 PM · KDE PIM
dfaure committed R177:274b4d5b9b7e: Merge branch 'Applications/18.04' (authored by dfaure).
Merge branch 'Applications/18.04'
Sat, Apr 21, 5:43 PM
dfaure committed R177:1b79b4be0758: Session: emit connectionLost when getting disconnected before the initial OK (authored by dfaure).
Session: emit connectionLost when getting disconnected before the initial OK
Sat, Apr 21, 5:42 PM
dfaure closed D12417: Session: emit connectionLost when getting disconnected before the initial OK.
Sat, Apr 21, 5:42 PM
dfaure committed R177:b185289830fd: IMAP fake server: provide more output in case the scenario is incomplete. (authored by dfaure).
IMAP fake server: provide more output in case the scenario is incomplete.
Sat, Apr 21, 5:33 PM
dfaure closed D12402: IMAP fake server: provide more output in case the scenario is incomplete..
Sat, Apr 21, 5:33 PM · KDE PIM
dfaure committed R177:c5424b187c4a: KIMAP fake server: add support for disconnect before response (authored by dfaure).
KIMAP fake server: add support for disconnect before response
Sat, Apr 21, 5:29 PM
dfaure closed D12400: KIMAP fake server: add support for disconnect before response.
Sat, Apr 21, 5:29 PM · KDE PIM
dfaure requested review of D12417: Session: emit connectionLost when getting disconnected before the initial OK.
Sat, Apr 21, 5:25 PM
dfaure committed R44:a0a2f6a824cf: Fix IMAP resource stuck if connection lost during Login. (authored by dfaure).
Fix IMAP resource stuck if connection lost during Login.
Sat, Apr 21, 3:41 PM
dfaure committed R44:4db8fc736da4: Fix IMAP resource stuck if connection lost during Login. (authored by dfaure).
Fix IMAP resource stuck if connection lost during Login.
Sat, Apr 21, 3:41 PM
dfaure closed D12403: Fix IMAP resource stuck if connection lost during Login..
Sat, Apr 21, 3:41 PM · KDE PIM
dfaure committed R178:7255db099d52: Merge branch 'Applications/18.04' (authored by dfaure).
Merge branch 'Applications/18.04'
Sat, Apr 21, 1:59 PM
dfaure committed R178:76f496735b20: LdapUrl: remove ctor code which made the QUrl invalid. (authored by dfaure).
LdapUrl: remove ctor code which made the QUrl invalid.
Sat, Apr 21, 1:57 PM
dfaure closed D12386: LdapUrl: remove ctor code which made the QUrl invalid..
Sat, Apr 21, 1:57 PM · KDE PIM
dfaure requested review of D12403: Fix IMAP resource stuck if connection lost during Login..
Sat, Apr 21, 1:37 PM · KDE PIM
dfaure updated the diff for D12402: IMAP fake server: provide more output in case the scenario is incomplete..

use QVERIFY instead of Q_ASSERT, as it was before

Sat, Apr 21, 1:36 PM · KDE PIM
dfaure requested review of D12402: IMAP fake server: provide more output in case the scenario is incomplete..
Sat, Apr 21, 1:35 PM · KDE PIM
dfaure committed R177:f5456fad70ed: Fix ctest with CTEST_PARALLEL_LEVEL being set. (authored by dfaure).
Fix ctest with CTEST_PARALLEL_LEVEL being set.
Sat, Apr 21, 1:10 PM
dfaure committed R44:64240a38af55: Fix a bunch of typos in comments (authored by dfaure).
Fix a bunch of typos in comments
Sat, Apr 21, 1:10 PM
dfaure requested review of D12400: KIMAP fake server: add support for disconnect before response.
Sat, Apr 21, 1:05 PM · KDE PIM

Fri, Apr 20

dfaure accepted D12228: kdirlister new connect syntax.
Fri, Apr 20, 8:40 PM · Frameworks
dfaure committed R178:aef21d5c5f91: LdapUrl: fix LDAP queries broken with non-ascii search strings. (authored by dfaure).
LdapUrl: fix LDAP queries broken with non-ascii search strings.
Fri, Apr 20, 5:59 PM
dfaure closed D12387: LdapUrl: fix LDAP queries broken with non-ascii search strings..
Fri, Apr 20, 5:58 PM · KDE PIM
dfaure added inline comments to D12228: kdirlister new connect syntax.
Fri, Apr 20, 5:55 PM · Frameworks
dfaure added a comment to D11155: handle zip files embedded within zip files.

ping?

Fri, Apr 20, 5:35 PM · Frameworks
dfaure requested review of D12387: LdapUrl: fix LDAP queries broken with non-ascii search strings..
Fri, Apr 20, 5:32 PM · KDE PIM
dfaure requested review of D12386: LdapUrl: remove ctor code which made the QUrl invalid..
Fri, Apr 20, 5:31 PM · KDE PIM
dfaure added a comment to D12228: kdirlister new connect syntax.

I meant this stuff:

Fri, Apr 20, 5:23 PM · Frameworks
dfaure requested changes to D12371: fix always reproducible crash.

I find this solution horrible. QPointers screams "we designed this wrongly, the ownership rules are unclear, stuff gets deleted randomly, we have to guard against it".

Fri, Apr 20, 5:21 PM · Frameworks
dfaure requested changes to D12228: kdirlister new connect syntax.

Looks good, but shouldn't you remove the Q_PRIVATE_SLOT declarations too? They aren't used anymore, AFAICS.

Fri, Apr 20, 5:14 PM · Frameworks
dfaure committed R165:e7c2ae559abc: Merge remote-tracking branch 'origin/Applications/18.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/18.04'
Fri, Apr 20, 4:08 PM
dfaure committed R165:f7104b0ccb1c: Akonadi tests: make checkTestIsIsolated work in release mode too (authored by dfaure).
Akonadi tests: make checkTestIsIsolated work in release mode too
Fri, Apr 20, 4:07 PM
dfaure closed D12383: Akonadi tests: make checkTestIsIsolated work in release mode too.
Fri, Apr 20, 4:07 PM · KDE PIM
dfaure requested review of D12383: Akonadi tests: make checkTestIsIsolated work in release mode too.
Fri, Apr 20, 2:54 PM · KDE PIM
dfaure committed R355:85a9fb9058b5: Add category name as tooltip. (authored by dfaure).
Add category name as tooltip.
Fri, Apr 20, 1:50 PM
dfaure closed D12377: Add category name as tooltip..
Fri, Apr 20, 1:37 PM
dfaure requested review of D12377: Add category name as tooltip..
Fri, Apr 20, 11:37 AM
dfaure committed R165:adfec26f5e26: Merge remote-tracking branch 'origin/Applications/18.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/18.04'
Fri, Apr 20, 7:53 AM
dfaure committed R165:c10f8522c935: Fix handling of cut collections. (authored by dfaure).
Fix handling of cut collections.
Fri, Apr 20, 7:53 AM
dfaure closed D12303: Fix handling of cut collections..
Fri, Apr 20, 7:52 AM · KDE PIM

Wed, Apr 18

dfaure added a comment to D12303: Fix handling of cut collections..

kaddressbook does support cutting entities, that's in fact exactly what the initial bug report is about (which led to this code).

Wed, Apr 18, 8:02 AM · KDE PIM
dfaure requested review of D12303: Fix handling of cut collections..
Wed, Apr 18, 7:47 AM · KDE PIM

Tue, Apr 17

dfaure committed R119:e465ebf58544: Merge branch 'Plasma/5.12' (authored by dfaure).
Merge branch 'Plasma/5.12'
Tue, Apr 17, 11:31 AM
dfaure committed R119:38403268aad3: FunnelModel: fix invalid model API usage. (authored by dfaure).
FunnelModel: fix invalid model API usage.
Tue, Apr 17, 11:31 AM
dfaure closed D12275: FunnelModel: fix invalid model API usage..
Tue, Apr 17, 11:31 AM · Plasma
dfaure requested review of D12275: FunnelModel: fix invalid model API usage..
Tue, Apr 17, 10:39 AM · Plasma

Mon, Apr 16

dfaure committed R845:d961ed68537c: Merge branch 'Plasma/5.12' (authored by dfaure).
Merge branch 'Plasma/5.12'
Mon, Apr 16, 6:13 PM
dfaure committed R845:4ace32df8345: Add missing includes to fix compilation with Qt 5.11 (authored by dfaure).
Add missing includes to fix compilation with Qt 5.11
Mon, Apr 16, 6:12 PM
dfaure accepted D12242: KJob public signals.
Mon, Apr 16, 10:00 AM · Frameworks
dfaure requested changes to D12242: KJob public signals.
Mon, Apr 16, 9:37 AM · Frameworks
dfaure added a comment to D12228: kdirlister new connect syntax.

Signals having changed from protected to public in Qt5, the whole idea of preventing others to emit signals went down the drain anyway. Extending that to KJob we could make the signals non-private there, with strong documentation "don't emit this yourself".

Mon, Apr 16, 7:37 AM · Frameworks

Sat, Apr 14

dfaure added a comment to T8425: Simplify announcement submission.

Wordpress *and* ruby, way out of my comfort zone.
Can someone look into porting the current script?
git clone git@git.kde.org:sysadmin/release-tools -b frameworks/5.0
then read create_sources_inc and look for svn

Sat, Apr 14, 10:03 AM · Websites: WKO Migration
dfaure committed R883:1513939: KF 5.45.
KF 5.45
Sat, Apr 14, 9:52 AM
dfaure accepted D9070: KDE platform plugin: don't force default stylename on user-specified fonts.

I think this patch makes sense, even though I'm sad that it doesn't actually fix the bug I was seeing (you call it broken config file, in that case that would mean that the code writing out that config file is -- or was -- broken, if it shouldn't write out ",Regular").

Sat, Apr 14, 9:46 AM · Plasma
dfaure committed R883:1513938: add frameworks-5.45.0 to generate_release_data.py.
add frameworks-5.45.0 to generate_release_data.py
Sat, Apr 14, 9:39 AM

Wed, Apr 11

dfaure added a comment to D10803: handle more tags in taglibextractor.

No. As soon as the RC1 tags are there, the message freeze is lifted.

Wed, Apr 11, 8:25 PM · Baloo, Frameworks

Mon, Apr 9

dfaure accepted D12053: Increase SMTP session timeout to 1 minute.

Very cool, this might be the issue I've been seeing recently too.

Mon, Apr 9, 8:05 AM · KDE PIM