User Details
User Details
- User Since
- Mar 5 2015, 12:44 PM (223 w, 3 d)
- Availability
- Available
Thu, Jun 13
Thu, Jun 13
dfaure added a comment to D21517: Fix "Type error" when creating a TextField with focus: true.
Maybe someone should test this on mobile to make sure the testcase doesn't lead to the "Mobile Text Actions Toolbar" being broken?
dfaure committed R865:9f89c03b1f25: Preserve "at Y end" when the typing notification pops up (authored by dfaure).
Preserve "at Y end" when the typing notification pops up
make timestamp vertically-centered
dfaure committed R865:6e90dcce7116: Remove date on the right, as discussed today (authored by dfaure).
Remove date on the right, as discussed today
Add date header at the very top
Position view at end when switching rooms
Tue, Jun 11
Tue, Jun 11
dfaure accepted D21650: Shorten sockets file path.
Looks good to me, wait for Dan's approval too.
dfaure committed R865:86f1d499ae6a: Improve auto-at-end when changing rooms. Works better but not perfect. (authored by dfaure).
Improve auto-at-end when changing rooms. Works better but not perfect.
dfaure requested changes to D21650: Shorten sockets file path.
Add KProtocolInfo::defaultMimetype
Scroll to bottom when changing rooms
dfaure requested review of D21742: Add KProtocolInfo::defaultMimetype.
Mon, Jun 10
Mon, Jun 10
dfaure committed R865:fbaa6f649fe5: Stay at bottom when we're at bottom and new messages arrive. (authored by dfaure).
Stay at bottom when we're at bottom and new messages arrive.
dfaure requested review of D21726: Stay at bottom when we're at bottom and new messages arrive..
dfaure committed R865:1fed70872202: Show quoted message when a message is a reply to another one (authored by dfaure).
Show quoted message when a message is a reply to another one
dfaure requested changes to D21695: Add FindTaglib.cmake.
Certainly a good idea to have this in ECM, so that this mess can be sorted out once and for all...
dfaure requested review of D21719: Show quoted message when a message is a reply to another one.
Sun, Jun 9
Sun, Jun 9
GIT_SILENT clean up includes
dfaure committed R865:49af12574e16: MessageModel: use find_if instead of manual for loop. (authored by dfaure).
MessageModel: use find_if instead of manual for loop.
dfaure committed R865:6ba143a10b2b: Simplify messagemodel code by using a local variable (authored by dfaure).
Simplify messagemodel code by using a local variable
Fix grammar: CanEditing -> CanEdit
Sat, Jun 8
Sat, Jun 8
Add missing override keywords.
dfaure committed R145:7511b95aad8a: Remove extra KPeople/ prefix in include, it's incorrect to use the framework… (authored by dfaure).
Remove extra KPeople/ prefix in include, it's incorrect to use the framework…
Fix compilation with Qt 5.13
dfaure committed R738:f4708d17983c: Add missing override macros, to fix -Wsuggest-override warnings. (authored by dfaure).
Add missing override macros, to fix -Wsuggest-override warnings.
Fix compilation with boost enabled.
dfaure committed R6:f9e215b5eba6: GIT_SILENT Fix comment in fatal error, this isn't plasma (authored by dfaure).
GIT_SILENT Fix comment in fatal error, this isn't plasma
add frameworks-5.59.0 to generate_release_data.py
Fri, Jun 7
Fri, Jun 7
OK, I can't think of a better solution than "Data" everywhere.
Thu, Jun 6
Thu, Jun 6
Merge branch 'Applications/19.04'
Fix kontact crash on logout.
dfaure committed R209:13f0f7730cec: Allow parts (like kmail) to set a custom caption in guiActivateEvent (authored by dfaure).
Allow parts (like kmail) to set a custom caption in guiActivateEvent
dfaure requested review of D21626: Fix kontact crash on logout..
dfaure requested review of D21625: Allow parts (like kmail) to set a custom caption in guiActivateEvent.
Merge branch 'Applications/19.04'
dfaure committed R165:0b9e5c6cc9eb: Show error string from QLocalServer on failure (authored by dfaure).
Show error string from QLocalServer on failure
Wed, Jun 5
Wed, Jun 5
dfaure added a comment to D21597: Change title of action to launch PIM Settings Exporter.
Yeah, well, right now it's a big mess, with 90% of the GUI talking about settings, and 10% talking about data.
dfaure requested review of D21598: s/Data/Settings/ in the menu items..
dfaure requested review of D21597: Change title of action to launch PIM Settings Exporter.
Tue, Jun 4
Tue, Jun 4
dfaure committed R865:1c7e4d0450ec: Implement "Unread on Top" in rooms list, with a toggle action. (authored by dfaure).
Implement "Unread on Top" in rooms list, with a toggle action.
dfaure requested review of D21570: Implement "Unread on Top" in rooms list, with a toggle action..
Mon, Jun 3
Mon, Jun 3
dfaure requested changes to D21562: fix crash in webenginepart on konqueror shutdown.
Sun, Jun 2
Sun, Jun 2
dfaure added a comment to D21517: Fix "Type error" when creating a TextField with focus: true.
So isn't there a risk that controlRoot is never set because contentItem is set too late?
dfaure committed R241:2e37ace712ae: kio_ftp: improve error handling when copying to FTP fails (authored by dfaure).
kio_ftp: improve error handling when copying to FTP fails
Fri, May 31
Fri, May 31
dfaure committed R497:83b9c4d443d4: Set all vars first, for easier copy/pasting (authored by dfaure).
Set all vars first, for easier copy/pasting
Version update for 5.59
dfaure updated the test plan for D21517: Fix "Type error" when creating a TextField with focus: true.
dfaure requested review of D21517: Fix "Type error" when creating a TextField with focus: true.
dfaure added a comment to D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI.
Writing into the user's home dir is a "hack".
dfaure requested changes to D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI.
I agree that we shouldn't remove the underlying feature, in fact it's still used on other protocols than http.
Remove warning which isn't a warning.
dfaure committed R858:24936c8a2b7c: GIT_SILENT remove unused include, no QTimer here (authored by dfaure).
GIT_SILENT remove unused include, no QTimer here
Just one typo, looks good otherwise.
dfaure committed R865:f39e2c61a374: Room list: use gray text color for rooms with no unread messages (authored by dfaure).
Room list: use gray text color for rooms with no unread messages
Wed, May 29
Wed, May 29
dfaure requested review of D21487: Room list: use gray text color for rooms with no unread messages.
Merge branch 'Applications/19.04'
dfaure committed R172:964ec882c3be: Remove bogus TODO, this is a private header already so it's fine (authored by dfaure).
Remove bogus TODO, this is a private header already so it's fine
Mon, May 27
Mon, May 27
dfaure added a comment to D21313: Create specific directory for Qt logging categories file.
My suggestion is to call this qlogging-categories5.
dfaure committed R865:53cf039662cf: Log all DDP messages sent and received in RUQOLA_LOGFILE, if set. (authored by dfaure).
Log all DDP messages sent and received in RUQOLA_LOGFILE, if set.
dfaure updated the diff for D21424: Log all DDP messages sent and received in RUQOLA_LOGFILE, if set..
initialize to nullptr in the header
dfaure added inline comments to D21424: Log all DDP messages sent and received in RUQOLA_LOGFILE, if set..
dfaure updated the diff for D21424: Log all DDP messages sent and received in RUQOLA_LOGFILE, if set..
Fix crash when RUQOLA_LOGFILE isn't set
dfaure requested review of D21424: Log all DDP messages sent and received in RUQOLA_LOGFILE, if set..
Sun, May 26
Sun, May 26
dfaure updated the diff for D21290: kio_ftp: improve error handling when copying to FTP fails.
Don't leak the file descriptor on error. Thanks for catching!
dfaure updated the diff for D21290: kio_ftp: improve error handling when copying to FTP fails.
keep error code; mention pure-ftpd in the commit log
dfaure added inline comments to D21290: kio_ftp: improve error handling when copying to FTP fails.
Fri, May 24
Fri, May 24
dfaure committed R241:4dcd8217a924: Fix kioslave executables never exiting, when setting KDE_FORK_SLAVES. (authored by dfaure).
Fix kioslave executables never exiting, when setting KDE_FORK_SLAVES.
dfaure added a comment to D21317: Manipulate bytes instead of characters.
+1 from me, but if Thiago can take a look (about the issue of truncating in the middle of a multi-bytes utf8 characters) that'd be even better.
Thu, May 23
Thu, May 23
dfaure committed R865:72b2acdd330f: Fix channelgetallusermentionsjobtest by comparing strings rather than URLs (authored by dfaure).
Fix channelgetallusermentionsjobtest by comparing strings rather than URLs
dfaure requested review of D21359: Fix channelgetallusermentionsjobtest by comparing strings rather than URLs.
dfaure committed R241:bc548acd7913: kioslave: replace exit() with return as suggested by Christoph Cullmann (authored by dfaure).
kioslave: replace exit() with return as suggested by Christoph Cullmann
Wed, May 22
Wed, May 22
dfaure committed R865:c1971a3781ce: Improve typing notification for the case of multiple users (authored by dfaure).
Improve typing notification for the case of multiple users
dfaure requested review of D21338: Improve typing notification for the case of multiple users.
dfaure committed R865:2b36f9d713be: Reduce icon sizes in messages, a little bit. It was really huge. (authored by dfaure).
Reduce icon sizes in messages, a little bit. It was really huge.
dfaure committed R309:70bca6c70683: Fix another assert when the file disappears under us: ASSERT: "ctime != 0" (authored by dfaure).
Fix another assert when the file disappears under us: ASSERT: "ctime != 0"
dfaure committed R309:5137a5550a5c: Fix assert (hash != 0) sometimes when a file is deleted by another process (authored by dfaure).
Fix assert (hash != 0) sometimes when a file is deleted by another process
dfaure committed R240:79665b067c9d: Don't enable QT_STRICT_ITERATORS on Windows. (authored by dfaure).
Don't enable QT_STRICT_ITERATORS on Windows.
Tue, May 21
Tue, May 21
Thanks!
dfaure updated the diff for D21314: Don't enable QT_STRICT_ITERATORS on Windows..
Remove unrelated change
dfaure requested review of D21314: Don't enable QT_STRICT_ITERATORS on Windows..