dfaure (David Faure)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (240 w, 3 d)
Availability
Available

Recent Activity

Today

dfaure accepted D24560: remove legacy space handling code.

If you say so :-)

Mon, Oct 14, 7:47 AM · Frameworks
dfaure accepted D24588: [SslUi] Add api docs for askIgnoreSslErrors().
Mon, Oct 14, 7:31 AM · Frameworks

Sat, Oct 12

dfaure added a comment to D24588: [SslUi] Add api docs for askIgnoreSslErrors().

Hmm, why not just do KSslErrorUiData uiData(socket); in the caller, or even just askIgnoreSslErrors(KSslErrorUiData(socket), storedRules).
Don't know, just wondering (not objecting). @vkrause, any opinion?

Sat, Oct 12, 9:56 PM · Frameworks
dfaure accepted D24558: fix proxy setting loading.

Err, yeah, the call to setPort(-1) serves no purpose at all otherwise...

Sat, Oct 12, 9:40 PM · Frameworks
dfaure accepted D23579: port ftp slave to new error reporting system.

Excellent work!

Sat, Oct 12, 9:39 PM · Frameworks
dfaure added inline comments to D24466: Use ECMGenerateExportHeader to manage deprecated API better.
Sat, Oct 12, 9:30 PM · Frameworks
dfaure committed R497:5b1188065617: KF 5.63 changes (authored by dfaure).
KF 5.63 changes
Sat, Oct 12, 9:28 PM
dfaure committed R497:183b86bf3269: New modules in KF 5.63 (authored by dfaure).
New modules in KF 5.63
Sat, Oct 12, 9:28 PM
dfaure accepted D23802: Use ECMGenerateExportHeader to manage deprecated API better.
Sat, Oct 12, 9:11 PM · Frameworks
dfaure accepted D24372: Compile without deprecated foreach.
Sat, Oct 12, 9:09 PM · Frameworks
dfaure committed R883:1553695: KF 5.63.
KF 5.63
Sat, Oct 12, 9:04 PM
dfaure added inline comments to D23802: Use ECMGenerateExportHeader to manage deprecated API better.
Sat, Oct 12, 8:26 PM · Frameworks
dfaure added inline comments to D24466: Use ECMGenerateExportHeader to manage deprecated API better.
Sat, Oct 12, 7:44 PM · Frameworks
dfaure committed R883:1553691: add frameworks-5.63.0 to generate_release_data.py.
add frameworks-5.63.0 to generate_release_data.py
Sat, Oct 12, 7:42 PM
dfaure accepted D24467: Use ECMGenerateExportHeader to manage deprecated API better.
Sat, Oct 12, 7:41 PM · Frameworks
dfaure accepted D24372: Compile without deprecated foreach.
Sat, Oct 12, 7:35 PM · Frameworks
dfaure accepted D24487: fix password error condition handling of smb mount.
Sat, Oct 12, 6:01 PM · Frameworks, Dolphin

Fri, Oct 11

dfaure requested changes to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Fri, Oct 11, 11:02 PM · Frameworks
dfaure added a comment to D24465: Use ECMGenerateExportHeader to manage deprecated API better.

+1 from me

Fri, Oct 11, 10:55 PM · Frameworks

Wed, Oct 9

dfaure requested changes to D23579: port ftp slave to new error reporting system.
Wed, Oct 9, 5:41 AM · Frameworks
dfaure added inline comments to D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API.
Wed, Oct 9, 5:29 AM · Build System, Frameworks

Tue, Oct 8

dfaure added a comment to D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API.

I found confirmation in cmake's Tests/RunCMake/GenerateExportHeader/reference/

Not sure what you exactly mean, can you please specify confirmation for what? And what this recommends us to do? :)

Tue, Oct 8, 5:19 AM · Build System, Frameworks
dfaure requested changes to D24372: Compile without deprecated foreach.
Tue, Oct 8, 5:17 AM · Frameworks

Mon, Oct 7

dfaure added a comment to D24442: ensure winId() not called on non-native widgets.

Done, this is in the v5.63.0-rc3 tag now.

Mon, Oct 7, 8:44 PM · Frameworks
l10n daemon script <scripty@kde.org> committed R174:2c5d544833e4: Install translations (authored by dfaure).
Install translations
Mon, Oct 7, 8:35 PM
dfaure committed R174:bc9044fb4573: Install translations (authored by dfaure).
Install translations
Mon, Oct 7, 8:35 PM
dfaure accepted D24442: ensure winId() not called on non-native widgets.

Looks good, quite similar to https://phabricator.kde.org/D23808

Mon, Oct 7, 3:57 PM · Frameworks

Sun, Oct 6

dfaure committed R244:64223e381701: Fix include path to kjob.h (authored by hallas).
Fix include path to kjob.h
Sun, Oct 6, 9:44 AM
dfaure closed D24434: Fix include path to kjob.h.
Sun, Oct 6, 9:43 AM · Frameworks
dfaure added a comment to D24434: Fix include path to kjob.h.

Argh, I retagged, but this wasn't pushed yet.
Landing and retagging again...

Sun, Oct 6, 9:42 AM · Frameworks
dfaure added a comment to D7446: [Places panel] Revamp the Recently Saved section.

This commit breaks kfileplacesmodeltest, please take a look.

Sun, Oct 6, 9:00 AM · Frameworks, Dolphin

Fri, Oct 4

dfaure added a comment to D23902: [KCoreDirLister] replace deprecated foreach with range-for.

For the record, JFBastien was actually wrong. Calling .begin() on a const return value does call the const overload. Testcase http://www.davidfaure.fr/kde/const_retval.cpp

That looks like a failure in communication, either one of you _assumed_ something but didn't tell the other. :D

Fri, Oct 4, 3:53 PM · Frameworks
dfaure added a comment to T11821: Move KDirModel to KioCore.

Do you mean QtGui? We need icons...

Fri, Oct 4, 2:33 PM · KF6
dfaure added a comment to D23902: [KCoreDirLister] replace deprecated foreach with range-for.

For the record, JFBastien was actually wrong. Calling .begin() on a const return value does call the const overload. Testcase http://www.davidfaure.fr/kde/const_retval.cpp

Fri, Oct 4, 2:23 PM · Frameworks
dfaure accepted D24387: improve error reporting for when kpasswdserver is unreachable.
Fri, Oct 4, 1:00 PM · Frameworks, Dolphin

Thu, Oct 3

dfaure committed R45:8df827a28181: Add more tests for Parser: bottom-up and top-down data (authored by dfaure).
Add more tests for Parser: bottom-up and top-down data
Thu, Oct 3, 9:08 PM
dfaure closed D24396: Add more tests for Parser: bottom-up and top-down data.
Thu, Oct 3, 9:07 PM
dfaure added a comment to D24389: Fix klistopenfilesjob header file not being installed.

git tag doesn't show any 5.63.0-rc* tag yet, so it hasn't been tagged, so this commit will be included.

Thu, Oct 3, 6:29 PM · Frameworks
dfaure requested review of D24396: Add more tests for Parser: bottom-up and top-down data.
Thu, Oct 3, 5:37 PM
dfaure committed R45:84bb2cde32d6: Fix previous commit to actually use an unordered map (authored by dfaure).
Fix previous commit to actually use an unordered map
Thu, Oct 3, 4:10 PM
dfaure committed R45:39da3a97e402: Add an ID to Symbol in order to make hashing faster (authored by dfaure).
Add an ID to Symbol in order to make hashing faster
Thu, Oct 3, 9:12 AM
dfaure added a comment to D24282: Port all of inboxpagemodeltest away from mocks.

It doesn't look like there is a null pointer we can check.

Thu, Oct 3, 8:30 AM
dfaure committed R241:55cb24916ada: [KIO] Modernize the code to use range-for in more places (authored by dfaure).
[KIO] Modernize the code to use range-for in more places
Thu, Oct 3, 8:20 AM
dfaure closed D24160: [KIO] Modernize the code to use range-for in more places.
Thu, Oct 3, 8:20 AM · Frameworks
dfaure closed D24099: Add an ID to Symbol in order to make hashing faster.
Thu, Oct 3, 8:19 AM

Wed, Oct 2

dfaure committed R226:dbd0780af943: Fix compilation with Qt 5.9 for Raphael Rosch (authored by dfaure).
Fix compilation with Qt 5.9 for Raphael Rosch
Wed, Oct 2, 8:27 AM
dfaure accepted D24308: [DataProtocol] compile without implicit coversion from ascii.
Wed, Oct 2, 8:20 AM · Frameworks
dfaure committed R236:e6438e379961: Make OK button configurable in KMessageBox::sorry/detailedSorry (authored by dfaure).
Make OK button configurable in KMessageBox::sorry/detailedSorry
Wed, Oct 2, 8:20 AM
dfaure closed D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry.
Wed, Oct 2, 8:19 AM · Frameworks
dfaure added a comment to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

I suggest do look at kio_file (kio/src/ioslaves/file), the above code was inspired by kio_file, and then ported differently to Windows.

Wed, Oct 2, 8:19 AM · Frameworks, Dolphin

Tue, Oct 1

dfaure requested changes to D24308: [DataProtocol] compile without implicit coversion from ascii.
Tue, Oct 1, 9:50 AM · Frameworks
dfaure added a comment to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

I'm not sure what the QFileDevice enum gives us compared to the octal permissions as int? Is this just because it looks nicer, to save a conversion, or because you actually need the differenciation between ReadUser and ReadOwner, on Windows?

Tue, Oct 1, 8:07 AM · Frameworks, Dolphin
dfaure accepted D24323: Reorder a bit the top of the CMakeLists.txt to be more similar to other frameworks.
Tue, Oct 1, 8:03 AM

Mon, Sep 30

dfaure added a comment to D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API.

I found confirmation in cmake's Tests/RunCMake/GenerateExportHeader/reference/

Mon, Sep 30, 8:37 PM · Build System, Frameworks
dfaure accepted D24315: REPORT also supports the Depth header.

This is exactly why we release KF5 every month these days, so people fix issues here instead of working around them in app code like in 2010 :-)

Mon, Sep 30, 6:31 PM · Frameworks
dfaure accepted D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV.

Ah I see, the hacks in KDAV::DavManager is the context :)

Mon, Sep 30, 6:30 PM · Frameworks
dfaure added a comment to D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV.

Test Plan: ?

Mon, Sep 30, 6:30 PM · Frameworks
dfaure added a comment to D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API.

Which might be an issue for people who would like to use different compiler on the same system, both building against the same generated export header file.

Mon, Sep 30, 6:27 PM · Build System, Frameworks
dfaure accepted D24262: Modernize code: use range-based loops & algorithms in more places.
Mon, Sep 30, 7:58 AM · Frameworks

Sun, Sep 29

dfaure added inline comments to D24262: Modernize code: use range-based loops & algorithms in more places.
Sun, Sep 29, 10:14 PM · Frameworks
dfaure requested changes to D24262: Modernize code: use range-based loops & algorithms in more places.

Please make the loop variable const-ref whenever possible.

Sun, Sep 29, 9:44 PM · Frameworks
dfaure committed R241:ffb666d46a4a: [src/ioslaves/*] replace deprecated foreach with range for (authored by ahmadsamir).
[src/ioslaves/*] replace deprecated foreach with range for
Sun, Sep 29, 9:04 PM
dfaure closed D24220: [src/ioslaves/*] replace deprecated foreach with range for.
Sun, Sep 29, 9:04 PM · Frameworks
dfaure committed R241:68b7a22f9e0e: [src/filewidgets/*] replace deprecated foreach with range for (authored by ahmadsamir).
[src/filewidgets/*] replace deprecated foreach with range for
Sun, Sep 29, 8:36 PM
dfaure closed D24171: [src/filewidgets/*] replace deprecated foreach with range for.
Sun, Sep 29, 8:33 PM · Frameworks
dfaure added a comment to D24171: [src/filewidgets/*] replace deprecated foreach with range for.

(Reminder: I don't have a dev account so you'll have to commit the patches :)).

Sun, Sep 29, 8:30 PM · Frameworks
dfaure accepted D24171: [src/filewidgets/*] replace deprecated foreach with range for.

Thanks!

Sun, Sep 29, 8:17 PM · Frameworks
dfaure accepted D23920: Deprecate the KSslError::Error ctor of KSslError.
Sun, Sep 29, 8:13 PM · Frameworks

Sat, Sep 28

dfaure added inline comments to D24171: [src/filewidgets/*] replace deprecated foreach with range for.
Sat, Sep 28, 8:08 PM · Frameworks
dfaure added a comment to D24262: Modernize code: use range-based loops & algorithms in more places.

It's actually quite clear in my head, because I imagine the generated class. A captured variable in a lambda becomes a member variable. If it's a capture by value (which is what happens with [library]), it's a "plain value" member.
So:

Sat, Sep 28, 7:55 PM · Frameworks
dfaure added a comment to D24282: Port all of inboxpagemodeltest away from mocks.

Any input on the (implicit) questions in the commit log? ;-)

Sat, Sep 28, 7:39 PM
dfaure accepted D24287: cleanup dbus related objects early enough to avoid hang on program exit.
Sat, Sep 28, 6:59 PM · Frameworks
dfaure added inline comments to D24171: [src/filewidgets/*] replace deprecated foreach with range for.
Sat, Sep 28, 6:58 PM · Frameworks
dfaure committed R241:ca501f5deaa2: [Windows] fix listing the parent dir of C:\foo, that's C:\ and not C: (authored by dfaure).
[Windows] fix listing the parent dir of C:\foo, that's C:\ and not C:
Sat, Sep 28, 3:32 PM
dfaure added inline comments to D24261: Modernize code: use range-based for loop in more places.
Sat, Sep 28, 1:30 PM · Frameworks
dfaure added inline comments to D24262: Modernize code: use range-based loops & algorithms in more places.
Sat, Sep 28, 1:20 PM · Frameworks
dfaure updated the diff for D24160: [KIO] Modernize the code to use range-for in more places.

Make changes suggested by Friedrich's code review (thanks!)

Sat, Sep 28, 1:06 PM · Frameworks
dfaure added inline comments to D24160: [KIO] Modernize the code to use range-for in more places.
Sat, Sep 28, 1:03 PM · Frameworks
dfaure committed R241:ea035cd204de: GIT_SILENT use QString::clear() instead of = QLatin1String("") (authored by dfaure).
GIT_SILENT use QString::clear() instead of = QLatin1String("")
Sat, Sep 28, 12:57 PM
dfaure committed R236:1b081c8f02d8: [KCollapsibleGroupBox] Fix QTimeLine::start warning at runtime (authored by dfaure).
[KCollapsibleGroupBox] Fix QTimeLine::start warning at runtime
Sat, Sep 28, 12:26 PM
dfaure committed R241:4127bf6b9901: GIT_SILENT improve other existing range-for loops (authored by dfaure).
GIT_SILENT improve other existing range-for loops
Sat, Sep 28, 12:21 PM
dfaure committed R241:1660e30f3821: GIT_SILENT Fix existing range for loops (const ref, qAsConst) (authored by dfaure).
GIT_SILENT Fix existing range for loops (const ref, qAsConst)
Sat, Sep 28, 12:12 PM
dfaure committed R241:54429f8a36aa: GIT_SILENT add override to virtual dtors (authored by dfaure).
GIT_SILENT add override to virtual dtors
Sat, Sep 28, 12:05 PM
dfaure committed R230:7db3c74d0335: Merge remote-tracking branch 'origin/Applications/19.08' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/19.08'
Sat, Sep 28, 11:56 AM
dfaure committed R230:0048b754fe44: Fix unwanted removal of /* before emacs mode line, which broke compilation (authored by dfaure).
Fix unwanted removal of /* before emacs mode line, which broke compilation
Sat, Sep 28, 11:56 AM
dfaure committed R241:c8c2eff2a236: GIT_SILENT Reformat code using uncrustify-kf5 (authored by dfaure).
GIT_SILENT Reformat code using uncrustify-kf5
Sat, Sep 28, 11:55 AM
dfaure requested review of D24282: Port all of inboxpagemodeltest away from mocks.
Sat, Sep 28, 11:18 AM
dfaure requested changes to D24171: [src/filewidgets/*] replace deprecated foreach with range for.
Sat, Sep 28, 11:18 AM · Frameworks
dfaure closed D24254: [KCollapsibleGroupBox] Fix QTimeLine::start warning at runtime.
Sat, Sep 28, 11:12 AM · Frameworks

Fri, Sep 27

dfaure updated the diff for D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry.

perl -pi -e 's/buttonOK/buttonOk/g' kmessagebox.*

Fri, Sep 27, 9:33 PM · Frameworks
dfaure committed R120:e508e5e35a58: Merge remote-tracking branch 'origin/Plasma/5.17' (authored by dfaure).
Merge remote-tracking branch 'origin/Plasma/5.17'
Fri, Sep 27, 5:44 PM
dfaure committed R120:a0a80c67f91c: [startplasma] don't set QT_AUTO_SCREEN_SCALE_FACTOR with Qt >= 5.14 (authored by dfaure).
[startplasma] don't set QT_AUTO_SCREEN_SCALE_FACTOR with Qt >= 5.14
Fri, Sep 27, 5:29 PM
dfaure closed D24255: [startplasma] don't set QT_AUTO_SCREEN_SCALE_FACTOR with Qt >= 5.14.
Fri, Sep 27, 5:28 PM · Plasma
dfaure added a comment to D24237: Fix compilation with Qt 5.14.

For the record, the upstream fix proposal is https://codereview.qt-project.org/c/qt/qtbase/+/275380 (Qt is actually a better place than cmake for this)

Fri, Sep 27, 1:26 AM · KDE PIM
dfaure committed R241:2c379fecccbf: Fix crash on exit in kio_file (authored by dfaure).
Fix crash on exit in kio_file
Fri, Sep 27, 12:57 AM
dfaure closed D24150: Fix crash on exit in kio_file.
Fri, Sep 27, 12:56 AM · Frameworks
dfaure accepted D24150: Fix crash on exit in kio_file.

Ah, I see, OK.

Fri, Sep 27, 12:54 AM · Frameworks
dfaure requested review of D24255: [startplasma] don't set QT_AUTO_SCREEN_SCALE_FACTOR with Qt >= 5.14.
Fri, Sep 27, 12:52 AM · Plasma
dfaure requested review of D24254: [KCollapsibleGroupBox] Fix QTimeLine::start warning at runtime.
Fri, Sep 27, 12:31 AM · Frameworks
dfaure updated the diff for D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry.

also add this to sorry(); fix inconsistency with Options arg, that one can still have a default value

Fri, Sep 27, 12:27 AM · Frameworks