dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (188 w, 5 d)
Availability
Available

Recent Activity

Today

dfaure added inline comments to D16248: Fix build with botan < 2 and openssl < 1.1.
Wed, Oct 17, 7:10 AM

Mon, Oct 15

dfaure committed R883:1526620: KF 5.51.
KF 5.51
Mon, Oct 15, 8:18 AM
dfaure committed R883:1526617: add frameworks-5.51.0 to generate_release_data.py.
add frameworks-5.51.0 to generate_release_data.py
Mon, Oct 15, 8:02 AM

Sun, Oct 14

dfaure requested review of D16210: Zanshin: show datasource in inbox page model..
Sun, Oct 14, 7:33 PM
l10n daemon script <scripty@kde.org> committed R285:064f7642adc8: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication (authored by dfaure).
KCrash: fix crash (ironic heh) when used in an app without QCoreApplication
Sun, Oct 14, 9:34 AM
dfaure added a comment to D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication.

You're right. Fixed, thanks.

Sun, Oct 14, 9:33 AM · Frameworks
dfaure committed R285:ec8ae99f21a0: GIT_SILENT add missing braces (authored by dfaure).
GIT_SILENT add missing braces
Sun, Oct 14, 9:33 AM
dfaure closed D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication.
Sun, Oct 14, 9:27 AM · Frameworks
dfaure committed R285:6dbd0edec10f: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication (authored by dfaure).
KCrash: fix crash (ironic heh) when used in an app without QCoreApplication
Sun, Oct 14, 9:27 AM
dfaure accepted D16189: kio_help: Fix crash in QCoreApplication when accessing help://.

See also https://phabricator.kde.org/D16183

Sun, Oct 14, 9:27 AM · Frameworks
dfaure accepted D15510: Introduce HKDF.

I would certainly like a style reformat, but I'm not sure who is the current/active maintainer for this code.

Sun, Oct 14, 9:25 AM
dfaure accepted D16072: Avoid waiting for user actions when kwin Focus stealing prevention is high or extreme.

Looks good, but this might be worth fixing in QTest::qWaitForWindowActive itself, for all other unittests using that (including Qt's own).

Sun, Oct 14, 9:22 AM · Frameworks

Sat, Oct 13

dfaure committed R497:09730a02fe32: Fixes for KF 5.51 (authored by dfaure).
Fixes for KF 5.51
Sat, Oct 13, 7:46 PM
dfaure added inline comments to D15972: Port KFind away from KMimeType.
Sat, Oct 13, 7:36 PM
dfaure updated the diff for D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication.

add bug number

Sat, Oct 13, 7:34 PM · Frameworks
dfaure requested review of D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication.
Sat, Oct 13, 7:33 PM · Frameworks
dfaure committed R96:301b57a84c9c: Add missing README.md file (needed by various scripts) (authored by dfaure).
Add missing README.md file (needed by various scripts)
Sat, Oct 13, 7:16 PM

Fri, Oct 12

dfaure requested changes to D16139: Fix handling of cookies without a domain.
Fri, Oct 12, 8:06 AM
dfaure added a comment to D16141: Disable unmount option for / or /home.

This whole method could put placesModel->url(index) into a local variable to avoid calling it so many times, though.

Fri, Oct 12, 7:56 AM · Frameworks

Thu, Oct 11

dfaure accepted D16125: Add QCoreApplication.
Thu, Oct 11, 12:48 PM

Mon, Oct 8

dfaure committed R36:d903ff3b7af1: Merge branch 'Applications/18.08' (authored by dfaure).
Merge branch 'Applications/18.08'
Mon, Oct 8, 8:43 PM
dfaure committed R36:27d71389921f: Downgrade warning to debug. (authored by dfaure).
Downgrade warning to debug.
Mon, Oct 8, 8:43 PM
dfaure requested review of D16036: Workday: display project name under the task title.
Mon, Oct 8, 7:52 AM
dfaure committed R241:45fb19db41ff: KFilePlacesModel: fix previous commit to avoid duplicating devices (authored by dfaure).
KFilePlacesModel: fix previous commit to avoid duplicating devices
Mon, Oct 8, 7:43 AM
dfaure closed D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices.
Mon, Oct 8, 7:43 AM · Frameworks

Sun, Oct 7

dfaure accepted D15973: Add a 'Properties' entry in the places panel context menu.
Sun, Oct 7, 8:56 PM · Frameworks
dfaure committed R4:ef00727eba66: Minor: remove unused lambda captures (authored by dfaure).
Minor: remove unused lambda captures
Sun, Oct 7, 8:35 PM
dfaure requested review of D16029: Use QueryTreeModelBase to access the roles..
Sun, Oct 7, 8:32 PM
dfaure committed R365:0fe9920893a9: Enable plasma-mycroft and massif-visualizer (authored by dfaure).
Enable plasma-mycroft and massif-visualizer
Sun, Oct 7, 6:57 PM
dfaure requested changes to D15510: Introduce HKDF.
Sun, Oct 7, 6:29 PM
dfaure requested changes to D15973: Add a 'Properties' entry in the places panel context menu.
Sun, Oct 7, 6:24 PM · Frameworks
dfaure committed R94:9b6dff36eaa9: Merge branch 'Applications/18.08' (authored by dfaure).
Merge branch 'Applications/18.08'
Sun, Oct 7, 6:22 PM
dfaure committed R94:4c360329969b: Relicense my code from GPLv2 to GPLv2+ (authored by dfaure).
Relicense my code from GPLv2 to GPLv2+
Sun, Oct 7, 6:21 PM
dfaure accepted D15859: allow non-local file:// redirect to a M$-WebDav URL.

+2, assuming the commit log doesn't have M$ anymore (the phab review does, but you don't use arc apparently so I guess the two things are unrelated)

Sun, Oct 7, 4:37 PM · Frameworks
dfaure added a reviewer for D11236: [KCrash] Establish socket to allow change of ptrace scope: ossi.
Sun, Oct 7, 4:35 PM · Frameworks
dfaure added a comment to D11236: [KCrash] Establish socket to allow change of ptrace scope.

This looks like the kind of commit where a review by Oswald Buddenhagen <ossi@kde.org> would be useful.

Sun, Oct 7, 4:34 PM · Frameworks
dfaure accepted D16007: [KNewFileMenu] Don't open an empty QFile.
Sun, Oct 7, 4:33 PM · Frameworks
dfaure added a comment to D11880: Add firewall-config and firewall-applet icons.

I don't really know, but see https://phabricator.kde.org/D4254 for the full reasoning of the unittest.

Sun, Oct 7, 4:33 PM · Frameworks
dfaure added a comment to D14072: Don't try to restore invalid user places.

Possible fix in https://phabricator.kde.org/D16020

Sun, Oct 7, 4:31 PM · Frameworks
dfaure requested review of D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices.
Sun, Oct 7, 4:31 PM · Frameworks
dfaure added a comment to D14072: Don't try to restore invalid user places.

More generally, please please run the unittests after changing a class. I hate that I currently am the one doing this, on the day of the release, which forces me to bugfix such things, or delay the release.

Sun, Oct 7, 4:28 PM · Frameworks
dfaure added a comment to D14072: Don't try to restore invalid user places.

This commit breaks kfileplacesmodeltest.

Sun, Oct 7, 4:27 PM · Frameworks
dfaure added a comment to D15968: kreadconfig: make the tool slightly more useful.

Will you port the kreadconfig usage in startkde to add --ignore-globals --ignore-cascading in order to preserve performance?

Sun, Oct 7, 12:47 PM · Frameworks
dfaure accepted D15947: Start drawing emblems in the bottom-right corner.
Sun, Oct 7, 12:43 PM · Frameworks

Sat, Oct 6

dfaure added a comment to D11880: Add firewall-config and firewall-applet icons.

This commit breaks the unittest "scalabletest" :

Sat, Oct 6, 8:48 AM · Frameworks
dfaure committed R266:930e8bf20360: Fix "stack-use-after-scope" detected by ASAN in CI (authored by dfaure).
Fix "stack-use-after-scope" detected by ASAN in CI
Sat, Oct 6, 8:48 AM

Thu, Oct 4

dfaure accepted D15277: [mtp] Move MTP device handling from kioslave to kiod-module.

Great stuff. Only found some typos and very minor things, feel free to fix and push.

Thu, Oct 4, 11:45 AM · Frameworks, Dolphin
dfaure added a comment to D7446: [Places panel] Add a Recently Used item by default.

I guess the implicit part of the question is "what if kio-extras isn't installed ?".
I assume it will lead to a broken item.

Thu, Oct 4, 2:19 AM · Frameworks, Dolphin
dfaure requested changes to D15727: Prepare environment to be able to test grantleeheaderstyle..

No ECM foo for local copying, so this CMakeLists.txt looks fine to me.

Thu, Oct 4, 2:15 AM · KDE PIM
dfaure accepted D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.

I think I'm fine with it now, but please wait until next Monday (Oct 8) before pushing, so it doesn't break the upcoming KF5 release. I'm not 100% confident.... (given that earlier versions of the patch had obvious bugs that were not detected by the unittests).

Thu, Oct 4, 2:10 AM · Frameworks
dfaure accepted D15753: Fix removing cookies from KCookieServer.
Thu, Oct 4, 2:01 AM

Wed, Oct 3

dfaure accepted D15871: Add a specific error string for ENOTEMPTY return code in SMB slave..
Wed, Oct 3, 10:18 PM · Frameworks, Dolphin
dfaure added a comment to D15871: Add a specific error string for ENOTEMPTY return code in SMB slave..

kio_file returns KIO::ERR_CANNOT_RMDIR when trying to delete a non-empty directory, maybe kio_smb could do the same? Although I see that the above isn't dependent on the command being executed.... But well, is there any other operation that would return ENOTEMPTY? If not, then ERR_CANNOT_RMDIR would be better IMHO (so KIO code or app code can check for it, if needed).

Wed, Oct 3, 12:21 PM · Frameworks, Dolphin

Tue, Oct 2

dfaure committed R287:f48571901228: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit. (authored by dfaure).
kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit.
Tue, Oct 2, 10:51 PM
dfaure closed D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit..
Tue, Oct 2, 10:51 PM · Frameworks
dfaure added inline comments to D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit..
Tue, Oct 2, 3:26 AM · Frameworks
dfaure requested review of D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit..
Tue, Oct 2, 12:53 AM · Frameworks

Fri, Sep 28

dfaure accepted D14162: Fix issue when reading path lists.
Fri, Sep 28, 4:57 PM · Frameworks
dfaure committed R135:2465b43f8971: Merge branch 'Plasma/5.14' (authored by dfaure).
Merge branch 'Plasma/5.14'
Fri, Sep 28, 4:31 PM
dfaure committed R135:db3a865c8cbf: Simplify cmake code: link to Qt5::GuiPrivate. (authored by dfaure).
Simplify cmake code: link to Qt5::GuiPrivate.
Fri, Sep 28, 4:29 PM
dfaure closed D15429: Simplify cmake code: link to Qt5::GuiPrivate..
Fri, Sep 28, 4:29 PM · Plasma
dfaure added a comment to D15429: Simplify cmake code: link to Qt5::GuiPrivate..

I completely forgot about pushing it, thanks for the reminder and for the target branch information.

Fri, Sep 28, 4:29 PM · Plasma

Tue, Sep 25

dfaure accepted D15635: Use String to store UDS_USER and UDS_GROUP of String type..
Tue, Sep 25, 6:49 AM · Baloo, Frameworks

Sun, Sep 23

dfaure accepted D15697: Fix deletion of files from DAV.
Sun, Sep 23, 10:28 AM · Frameworks
dfaure added a comment to D15697: Fix deletion of files from DAV.

Patch looks ok but I'm surprised by the commit log. Doesn't this method also work for directories, even after the patch?

Sun, Sep 23, 10:09 AM · Frameworks

Sat, Sep 22

dfaure added inline comments to D15277: [mtp] Move MTP device handling from kioslave to kiod-module.
Sat, Sep 22, 3:45 PM · Frameworks, Dolphin
dfaure requested changes to D15277: [mtp] Move MTP device handling from kioslave to kiod-module.

This is excellent work, thanks a lot for doing this. I just have "a few" minor comments... ;)

Sat, Sep 22, 3:42 PM · Frameworks, Dolphin
dfaure accepted D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags.
Sat, Sep 22, 1:52 PM · Build System, Frameworks
dfaure committed R4:ff8a82fbaa72: Fix two "TODO Qt5" comments (authored by dfaure).
Fix two "TODO Qt5" comments
Sat, Sep 22, 10:42 AM
dfaure committed R45:f752536fd565: fix syntax error when boost filesystem is not found (authored by dfaure).
fix syntax error when boost filesystem is not found
Sat, Sep 22, 10:18 AM
dfaure accepted D15686: Prevent highlighter from erasing selected text.
Sat, Sep 22, 8:35 AM · Frameworks
dfaure added a comment to D15686: Prevent highlighter from erasing selected text.

Makes sense.

Sat, Sep 22, 8:32 AM · Frameworks

Fri, Sep 21

dfaure added a comment to D15635: Use String to store UDS_USER and UDS_GROUP of String type..

The question of the caching of the KUser usage remains, though.

Fri, Sep 21, 8:50 AM · Baloo, Frameworks

Thu, Sep 20

dfaure committed R165:c6c316f2b37b: Merge branch 'Applications/18.08' (authored by dfaure).
Merge branch 'Applications/18.08'
Thu, Sep 20, 8:16 AM
dfaure committed R165:5ada337059fa: Job tracker: fix expected reply signature, improve error handling (authored by dfaure).
Job tracker: fix expected reply signature, improve error handling
Thu, Sep 20, 8:16 AM
dfaure accepted D15559: Python bindings: use cmake_parse_arguments, fix documentation.

This is technically not 100% source compatible, but since the callers were already passing "TARGET" (and others) as documented, I guess it's fine.

Thu, Sep 20, 7:29 AM · Build System, Frameworks

Wed, Sep 19

dfaure committed R241:6c02509a9fbf: GIT_SILENT s/KDE/KIO/ in a comment (authored by dfaure).
GIT_SILENT s/KDE/KIO/ in a comment
Wed, Sep 19, 8:31 PM
dfaure added a comment to D13315: Detect mime type of local files based on their contents.

I agree, extensions are not reliable over HTTP, which is why mimeTypeForUrl doesn't use them for HTTP urls.
But here we're in KFileItem, so much more likely talking about local files or FTP/SFTP/FISH/SMB/etc. where the *.php issue doesn't happen.

Wed, Sep 19, 7:20 AM · Frameworks

Tue, Sep 18

dfaure accepted D14072: Don't try to restore invalid user places.
Tue, Sep 18, 7:23 AM · Frameworks
dfaure requested changes to D15451: Let KUrlCombo operate on QIcon instead of QPixmap.

loadMimeTypeIcon also has the fallback to application-octet-stream if the mimetype icon isn't found, you could pass that as 2nd argument to fromTheme().

Tue, Sep 18, 7:14 AM · Frameworks
dfaure accepted D13416: image thumbnailer: instruct Qt to look at the file contents when detecting its format.

In code that is specific to images, I have no problem with determination from content.

Tue, Sep 18, 7:07 AM
dfaure added a comment to D13315: Detect mime type of local files based on their contents.

(BTW thanks for what you said about FUSE, I agree 100% and it makes me glad to see some people from the opposite camp, when so many people are trying to convince me that network mounts via FUSE is the solution to all problems on earth, see bug 75324)

Tue, Sep 18, 7:06 AM · Frameworks
dfaure requested changes to D13315: Detect mime type of local files based on their contents.

No, no. Too unreliable and against the MIME spec.

Tue, Sep 18, 7:03 AM · Frameworks

Mon, Sep 17

dfaure requested changes to D14072: Don't try to restore invalid user places.

Shouldn't this skip the invalid bookmark rather than abort completely ?

Mon, Sep 17, 5:30 PM · Frameworks
dfaure accepted D13316: manually set format in jpeg thumbnail creator.
Mon, Sep 17, 5:26 PM
dfaure accepted D13676: Make it possible to change directory up even with trailing slashes in the url .
Mon, Sep 17, 5:22 PM · Frameworks
dfaure accepted D15097: [Thumbnailer] Use enabled plugins passed in as metadata.
Mon, Sep 17, 5:16 PM
dfaure accepted D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave.
Mon, Sep 17, 5:15 PM · Frameworks
dfaure accepted D14006: Fix WebDAV destination header on COPY and MOVE operations.

FullyEncoded makes perfect sense for sending in a protocol implementation.

Mon, Sep 17, 5:11 PM · Frameworks
dfaure accepted D15573: replace custom backtracing in SlaveBase with KCrash.
Mon, Sep 17, 5:07 PM · Frameworks

Sep 17 2018

dfaure accepted D15405: [EPS] Fix crash at app shutdown (being tried to persist clipboard image).
Sep 17 2018, 7:32 AM · Frameworks
dfaure added a comment to D14757: Warn user before copy/move operation if available space is not enough.

Looks OK now.

Sep 17 2018, 7:30 AM · Frameworks
dfaure added a comment to D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags.

Do all frameworks build with this change?

Sep 17 2018, 7:28 AM · Build System, Frameworks
dfaure added inline comments to D15381: Add basic tests for WebEnginePartCookieJar.
Sep 17 2018, 7:00 AM

Sep 16 2018

dfaure accepted D15381: Add basic tests for WebEnginePartCookieJar.

I would sprinkle some const on local variables, but looks good otherwise.

Sep 16 2018, 9:19 AM
dfaure accepted D12520: [PasteJob] Emit KDirNotify on paste.

"perhaps fix storedPut to do that?" --> I'm not in favour. Generally speaking, we want to do this at the highest level possible, so that batching N jobs doesn't trigger N notifications.

Sep 16 2018, 9:09 AM · Frameworks

Sep 15 2018

dfaure added a comment to D15448: Send file contents in chunks.

Yes to chunking.

Sep 15 2018, 6:39 PM
dfaure added a comment to D15528: KSMTP: improve error handling..

Thanks, pushed to master.

Sep 15 2018, 6:33 PM · KDE PIM
dfaure committed R44:5d09572b4458: Merge branch 'Applications/18.08' (authored by dfaure).
Merge branch 'Applications/18.08'
Sep 15 2018, 6:33 PM
dfaure committed R733:80831750cefc: KSMTP: improve error handling. (authored by dfaure).
KSMTP: improve error handling.
Sep 15 2018, 6:33 PM