dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (133 w, 2 d)
Availability
Available

Recent Activity

Today

dfaure accepted D7948: Only match real MIME types, not e.g. "raw CD image".

Yes (although I would then swap document to be after text/, to have all the "groups" together, and then the "substring searches").
In any case feel free to push.

Sat, Sep 23, 1:55 PM · Frameworks
dfaure added a comment to D7948: Only match real MIME types, not e.g. "raw CD image".

Yes, but then startsWith() would be even more correct (and slightly faster) than contains().

Sat, Sep 23, 7:18 AM · Frameworks

Yesterday

dfaure accepted D7580: Support loading by stream and restoring state on reload.
Fri, Sep 22, 7:50 PM

Mon, Sep 18

dfaure added a comment to D7497: Fix Ctrl PageUp/PageDown shortcut conflict due to KF 5.37..

I agree, this should go in.

Mon, Sep 18, 8:35 AM

Fri, Sep 15

dfaure accepted D7837: Show kioslave names in the debug output.

One can also put %{appname} in his $QT_MESSAGE_PATTERN for this :-)

Fri, Sep 15, 12:53 PM · Frameworks
dfaure added a comment to D6233: KKeyServer: fix handling of KeypadModifier..

Qt (at shortcut recording time) sees this as Meta+Shift+Print while KWindowSystem (xcbKeyPressEventToQt) sees it as Meta+Shift+SysReq.

Fri, Sep 15, 6:55 AM · Frameworks
dfaure committed R355:2610eda65363: add missing category (authored by dfaure).
add missing category
Fri, Sep 15, 6:49 AM

Thu, Sep 14

dfaure added a comment to D6233: KKeyServer: fix handling of KeypadModifier..

Alt+Shift+right bug fixed in https://phabricator.kde.org/D7829

Thu, Sep 14, 9:44 PM · Frameworks
dfaure committed R278:af6d5ab12b2d: autotest: test the shortcuts broken by last month's changes. (authored by dfaure).
autotest: test the shortcuts broken by last month's changes.
Thu, Sep 14, 9:24 PM
dfaure created D7829: Fix kglobalaccel regression on Alt+Shift+arrowkey..
Thu, Sep 14, 9:14 PM
dfaure added a comment to D6233: KKeyServer: fix handling of KeypadModifier..

Thanks for the reports. These shortcuts get converted correctly (https://commits.kde.org/kwindowsystem/af6d5ab12b2d99b39a73ed8df903368470ded55b), so the problem must be in the shift handling in xcbKeyPressEventToQt().

Thu, Sep 14, 8:54 PM · Frameworks

Mon, Sep 11

dfaure committed R875:eecaf2e9d6b5: Fix compilation with -DQT_NO_CAST_TO_ASCII (authored by dfaure).
Fix compilation with -DQT_NO_CAST_TO_ASCII
Mon, Sep 11, 8:06 AM
dfaure added a comment to D7571: Enable modifying root-owned files in Dolphin.

Add both flag values, so that the current patches still work and don't need to be changed again if we toggle the default.

Mon, Sep 11, 7:43 AM

Sun, Sep 10

dfaure added a comment to D7706: Use runtime install prefix instead of compile time install prefix..

If all you need is <APPDIR>, you can use QCoreApplication::applicationDirPath().

Sun, Sep 10, 3:39 PM · Frameworks
dfaure added a comment to D7580: Support loading by stream and restoring state on reload.

When I read this initially, I guessed this method is just about the view state. But is also bound to data-pulling by the kpart, given that the default implementation explicitely calls openUrl() with the url stored in the datastream. Which might make sense for simple-to-use API with the non-stream use cases. But leaves out the stream-based data-pushing usage.

Sun, Sep 10, 3:37 PM
dfaure committed R290:9990eb0518e5: kpackage: bundle a copy of servicetypes/kpackage-generic.desktop (authored by dfaure).
kpackage: bundle a copy of servicetypes/kpackage-generic.desktop
Sun, Sep 10, 2:24 PM
dfaure closed D7243: kpackage: bundle a copy of servicetypes/kpackage-generic.desktop by committing R290:9990eb0518e5: kpackage: bundle a copy of servicetypes/kpackage-generic.desktop.
Sun, Sep 10, 2:24 PM
dfaure committed R290:a34d2dcd87e7: kpackagetool: bundle a copy of servicetypes/kpackage-generic.desktop (authored by dfaure).
kpackagetool: bundle a copy of servicetypes/kpackage-generic.desktop
Sun, Sep 10, 2:23 PM
dfaure closed D7242: kpackagetool: bundle a copy of servicetypes/kpackage-generic.desktop by committing R290:a34d2dcd87e7: kpackagetool: bundle a copy of servicetypes/kpackage-generic.desktop.
Sun, Sep 10, 2:23 PM
dfaure committed R290:4babd39d622c: autotest: adapt for ECM 5.38 setting CMAKE_RUNTIME_OUTPUT_DIRECTORY to bin (authored by dfaure).
autotest: adapt for ECM 5.38 setting CMAKE_RUNTIME_OUTPUT_DIRECTORY to bin
Sun, Sep 10, 2:23 PM
dfaure added a comment to D7243: kpackage: bundle a copy of servicetypes/kpackage-generic.desktop.

I'll take silence as approval, this should be non-controversial...

Sun, Sep 10, 2:23 PM
dfaure accepted D7294: Deprecate KStandardAction::PasteText and KPasteTextAction.
Sun, Sep 10, 2:21 PM · Frameworks
dfaure accepted D7758: Deprecate KStandardShortcut::SaveOptions.
Sun, Sep 10, 2:15 PM · Frameworks
dfaure added a comment to T6858: Falkon Translations.

The CMake buildsystem is done.

Sun, Sep 10, 2:14 PM · Falkon
dfaure committed R858:dbebe062c5c2: remove dep version, this is a tier1 (no deps) (authored by dfaure).
remove dep version, this is a tier1 (no deps)
Sun, Sep 10, 1:56 PM
dfaure added inline comments to D7706: Use runtime install prefix instead of compile time install prefix..
Sun, Sep 10, 1:30 PM · Frameworks
dfaure accepted D7707: Fix 'klauncher uses absolute compile time install path for finding kioslave.exe'.
Sun, Sep 10, 1:23 PM · Frameworks
dfaure committed R875:76457af13038: CMake buildsystem for the autotest (authored by dfaure).
CMake buildsystem for the autotest
Sun, Sep 10, 1:17 PM
dfaure committed R875:6e7a14a9c2b3: CMake buildsystem for plugins (authored by dfaure).
CMake buildsystem for plugins
Sun, Sep 10, 1:04 PM
dfaure committed R875:31d0e1f6b348: CMake buildsystem for src/main as well. (authored by dfaure).
CMake buildsystem for src/main as well.
Sun, Sep 10, 11:37 AM
dfaure added a comment to D7580: Support loading by stream and restoring state on reload.

"how would zoom and other custom state properties be save and retrieved again" -> using BrowserExtension's saveState/restoreState as usual, no? I'm not 100% sure about the interaction with streaming, but normally that happens after opening the url anyway, so it should be unrelated.

Oh, somehow missed those methods. Possibly was blinded by KParts::OpenUrlArguments::xOffset()/yOffset() and since then assumed that state restoring was supposed to be done only via those arguments.

Sun, Sep 10, 10:30 AM

Sat, Sep 9

dfaure committed R875:d69e5458f996: First steps towards a cmake buildsystem, currently only builds src/lib. (authored by dfaure).
First steps towards a cmake buildsystem, currently only builds src/lib.
Sat, Sep 9, 6:49 PM
dfaure added a comment to D7571: Enable modifying root-owned files in Dolphin.

Hmm. Emmanuel might have a point.
Looking at KIO jobs usage, I see a lot that are user-triggered and would benefit from privilege-execution support.
All of KIO's filewidgets library (filedialog etc.) obviously qualifies. KTextEditor for editing root-owned files, KParts for vieweing them, and then the same in most apps that use KIO to open and/or save files.

Sat, Sep 9, 6:15 PM
dfaure accepted D7270: [FileUndoManager] Enable undoing changes in read-only folders.
Sat, Sep 9, 1:28 PM
dfaure accepted D6833: Add support for PrivilegeExecution in KIO jobs.
Sat, Sep 9, 1:20 PM · Frameworks
dfaure added a comment to D6831: Make use of kauth helper in methods of file ioslave.

separate commits are easier to review, so that's fine

Sat, Sep 9, 1:19 PM · Frameworks
dfaure accepted D6830: Make use of kauth helper in copy method of file ioslave.
Sat, Sep 9, 1:10 PM · Frameworks
dfaure accepted D6739: [akregator part] Make sure part is created before restore window.
Sat, Sep 9, 12:55 PM · KDE PIM, KDE Applications
dfaure accepted D7738: Coding style and readability.
Sat, Sep 9, 12:32 PM · Frameworks
dfaure committed R497:a641b8ca3329: KF 5.38 (authored by dfaure).
KF 5.38
Sat, Sep 9, 11:39 AM
dfaure committed R459:f661eeefdd44: Merge branch 'Applications/17.08' (authored by dfaure).
Merge branch 'Applications/17.08'
Sat, Sep 9, 10:28 AM
dfaure committed R459:bf7800974ed4: EmailAddressSelectionWidget: use ETM signal to expand, rather than 1s timer. (authored by dfaure).
EmailAddressSelectionWidget: use ETM signal to expand, rather than 1s timer.
Sat, Sep 9, 10:28 AM
dfaure closed D7613: EmailAddressSelectionWidget: use ETM signal to expand, rather than 1s timer..
Sat, Sep 9, 10:26 AM · KDE PIM

Mon, Sep 4

dfaure accepted D7675: doc: validation not available in QInputDialog::getText.
Mon, Sep 4, 6:52 AM · Frameworks
dfaure accepted D7448: generate and use a local cdda_interface headerfile copy.

Has this been reported upstream, so the cdda people can fix it properly?

Mon, Sep 4, 6:50 AM
dfaure added a comment to D7580: Support loading by stream and restoring state on reload.

Oops, yes, you're completely right. I got distracted by the word close, but it's a different meaning in closeStream and closeUrl. Apologies for the confusion.

Mon, Sep 4, 6:31 AM

Sun, Sep 3

dfaure committed R226:b8fc67c65cc4: New maintainer for Konqueror: Stefano Crocco (authored by dfaure).
New maintainer for Konqueror: Stefano Crocco
Sun, Sep 3, 8:48 PM
dfaure accepted D7681: Update human-readable tier designation in API dox.
Sun, Sep 3, 6:36 PM · Kirigami
dfaure accepted D7677: Fix python bindings compilation after 7af93dd23873d0b9cdbac192949e7e5114940aa6.

Thanks for the fix!

Sun, Sep 3, 5:13 PM · Build System, Frameworks
dfaure committed R169:9a98a6b95b6d: If plasma isn't available, KF5Plasma isn't either. Should fix the CI error. (authored by dfaure).
If plasma isn't available, KF5Plasma isn't either. Should fix the CI error.
Sun, Sep 3, 12:27 PM
dfaure added a comment to D7571: Enable modifying root-owned files in Dolphin.

It's opt-in because it should only happen for user-triggered operations.
An application copying some config file in the background (or any other internal file operation) shouldn't bother the user with prompts.

Sun, Sep 3, 10:04 AM
dfaure committed R499:1f379165e457: make it possible to build heaptrack in stable-kf5-qt5 branch too (authored by dfaure).
make it possible to build heaptrack in stable-kf5-qt5 branch too
Sun, Sep 3, 9:31 AM
dfaure committed R499:c32b44820c6d: add missing dependency (authored by dfaure).
add missing dependency
Sun, Sep 3, 9:31 AM
dfaure requested changes to D7534: [KUrlNavigator] Emit tabRequested when path in path selector menu is middle-clicked.
Sun, Sep 3, 9:06 AM · Frameworks
dfaure added a comment to D7534: [KUrlNavigator] Emit tabRequested when path in path selector menu is middle-clicked.

Maybe it would be safer/simpler to use a different QObject for watching the menus.

Sun, Sep 3, 9:06 AM · Frameworks
dfaure accepted D7609: make Targets::fromUrlList() return an url instead a path if requested.
Sun, Sep 3, 8:52 AM
dfaure added inline comments to D7580: Support loading by stream and restoring state on reload.
Sun, Sep 3, 8:45 AM
dfaure added a comment to D6197: Add kauth helper to file ioslave.

(strange that Phabricator still says "Needs Review" when this has two approvals)

Sun, Sep 3, 8:35 AM · Frameworks
dfaure requested changes to D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper.
Sun, Sep 3, 8:32 AM · Frameworks
dfaure added a comment to D7430: Add unit test.

Also please improve the commit log to be more self contained (unit tests for what? And "T6561" will mean nothing to someone doing git log).

Sun, Sep 3, 8:14 AM
dfaure added a task to D7430: Add unit test: T6561: Polkit support in KIO.
Sun, Sep 3, 8:14 AM
dfaure added a revision to T6561: Polkit support in KIO: D7430: Add unit test.
Sun, Sep 3, 8:14 AM · Frameworks
dfaure added inline comments to D7571: Enable modifying root-owned files in Dolphin.
Sun, Sep 3, 8:12 AM
dfaure accepted D7563: Add privilegeExecution field to file protocol description.
Sun, Sep 3, 8:09 AM
dfaure accepted D7605: Add apidox to KStandardShorcut::StandardShortcut.
Sun, Sep 3, 8:08 AM · Frameworks
dfaure requested changes to D7430: Add unit test.

Looks good, just some minor things.

Sun, Sep 3, 8:06 AM
dfaure requested changes to D7642: [ksycoca] Use QDateTime::currentDateTimeUtc.

Please use arc diff to upload patches so that context is available.

Sun, Sep 3, 8:00 AM · Frameworks
dfaure added inline comments to D7389: Install browser .desktop file with name used by appstream.
Sun, Sep 3, 7:48 AM

Sat, Sep 2

dfaure committed R497:e767f0f65dd4: remove 20s sleep, hopefully not needed anymore (authored by dfaure).
remove 20s sleep, hopefully not needed anymore
Sat, Sep 2, 9:34 PM
dfaure committed R241:5ea4db3a5d1f: Port the webshortcuts KCM from KServiceTypeTrader to KPluginLoader::findPlugins (authored by dfaure).
Port the webshortcuts KCM from KServiceTypeTrader to KPluginLoader::findPlugins
Sat, Sep 2, 9:08 AM

Wed, Aug 30

dfaure updated the test plan for D7613: EmailAddressSelectionWidget: use ETM signal to expand, rather than 1s timer..
Wed, Aug 30, 9:42 AM · KDE PIM
dfaure created D7613: EmailAddressSelectionWidget: use ETM signal to expand, rather than 1s timer..
Wed, Aug 30, 9:40 AM · KDE PIM
dfaure added a comment to D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing..

Patch for more docu: https://phabricator.kde.org/D7612

Wed, Aug 30, 7:36 AM · Build System, Frameworks
dfaure created D7612: KDECMakeSettings: more docu about the layout of the build dir.
Wed, Aug 30, 7:35 AM · Build System, Frameworks

Tue, Aug 29

dfaure added a comment to D7497: Fix Ctrl PageUp/PageDown shortcut conflict due to KF 5.37..

Well, *if*. Let's first find out if this is the case. I'm sort for time right now, feel free to investigate if you have time.

Tue, Aug 29, 11:19 AM
dfaure committed R459:4a38a47fdb81: Add test program for EmailAddressSelectionModel (authored by dfaure).
Add test program for EmailAddressSelectionModel
Tue, Aug 29, 7:51 AM

Mon, Aug 28

dfaure committed R241:589c21a9fb7d: autotest: make a dir sticky rather than a file, should be better supported on… (authored by dfaure).
autotest: make a dir sticky rather than a file, should be better supported on…
Mon, Aug 28, 8:24 PM
dfaure accepted D7503: [KFilePropsPlugin] Locale-format totalSize during calculation.
Mon, Aug 28, 7:16 AM · Frameworks
dfaure committed R241:04147e26fa2c: KIO: fix long-standing memory leak on exit. (authored by dfaure).
KIO: fix long-standing memory leak on exit.
Mon, Aug 28, 7:14 AM
dfaure closed D7529: KIO: fix long-standing memory leak on exit..
Mon, Aug 28, 7:14 AM · Frameworks
dfaure committed R241:ca288d53e517: KIO: Task should be used in QVector, not QList. (authored by dfaure).
KIO: Task should be used in QVector, not QList.
Mon, Aug 28, 7:12 AM
dfaure closed D7530: KIO: Task should be used in QVector, not QList..
Mon, Aug 28, 7:11 AM
dfaure accepted D6831: Make use of kauth helper in methods of file ioslave.

Ah! I know how to improve the readability of (auto ret = execWithElevatedPrivilege)... please rename all "ret" variables to "err" (short for error, which is already taken), or if you prefer something longer, maybe execError ? eWEPError ?

Mon, Aug 28, 7:02 AM · Frameworks

Sun, Aug 27

dfaure committed R220:fc8f707b6f65: Fix compilation of tests (authored by dfaure).
Fix compilation of tests
Sun, Aug 27, 7:43 PM
dfaure accepted D7517: Remove defective svn::Path(QUrl) ctor.

RemoveAutority contains RemoveUserInfo | RemovePort, so you probably don't want that either.

Sun, Aug 27, 7:17 PM
dfaure added a comment to D4826: Prefer place name over actual name in title bar.

Is there a reason why Konqueror is added in CC of all dolphin merge requests? Is that done manually or automatically? I don't see the relevance for konqueror, especially for a patch for DolphinMainWindow (no effect on dolphinpart).

Sun, Aug 27, 7:15 PM
dfaure committed R241:b7947bf71d8b: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData (authored by dfaure).
KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
Sun, Aug 27, 7:05 PM
dfaure accepted D7354: Add new standard KDE tab switching shortcuts (ctrl+pgup/pgdn).
Sun, Aug 27, 7:01 PM · Konsole
dfaure closed D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData.
Sun, Aug 27, 6:59 PM
dfaure added a comment to D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData.

Ah, phabricator is strange, I have indeed modified the commit log before doing arc diff but it didn't update it here.

Sun, Aug 27, 6:58 PM

Sat, Aug 26

dfaure updated the diff for D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData.

Provide servicetype file to the cmake macro so that the priority is stored as an int.

Sat, Aug 26, 9:30 PM
dfaure added a comment to D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData.
In D7533#139802, @bshah wrote:

One thing I don't understand is the need for toString().toInt(),
or in other words, why my json file with a numeric value gets turned
into a string value when using qtplugininfo to inspect the plugin:

Maybe you need to add following in the src/widgets/kurifilterplugin.desktop

[PropertyDef::X-KDE-InitialPreference]
Type=int
Sat, Aug 26, 3:11 PM

Fri, Aug 25

dfaure committed R244:2e5312416080: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*" (authored by dfaure).
DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"
Fri, Aug 25, 8:28 PM
dfaure closed D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*".
Fri, Aug 25, 7:33 PM · Frameworks
dfaure added a comment to D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*".

It will be tested at every "make test" in kio and kpackage ;-)

Fri, Aug 25, 7:32 PM · Frameworks
dfaure added a comment to D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*".

ping?

Fri, Aug 25, 5:39 PM · Frameworks
dfaure added reviewers for D7236: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*": arichardson, davidedmundson.
Fri, Aug 25, 5:38 PM · Frameworks
dfaure accepted D7479: klauncher: fix appId matching for flatpak apps.
Fri, Aug 25, 4:04 PM · Frameworks
dfaure created D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData.
Fri, Aug 25, 9:09 AM

Thu, Aug 24

dfaure updated the diff for D7529: KIO: fix long-standing memory leak on exit..
  • Fix leak introduced by first version of the commit, we need to make a copy of the idle list before clearing it.
Thu, Aug 24, 11:03 PM · Frameworks