dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (215 w, 2 d)
Availability
Available

Recent Activity

Today

dfaure committed R241:3759bcd73ef5: autotests: adapt to QUrl behaviour change in Qt 5.12.1 (authored by dfaure).
autotests: adapt to QUrl behaviour change in Qt 5.12.1
Sat, Apr 20, 11:15 AM
dfaure added a comment to D20694: Use regular stat when resolving a symlink.

I fixed them ;-)

Sat, Apr 20, 10:49 AM · Frameworks
dfaure committed R241:4d99515206c1: autotests: adapt to shared-mime-info change (authored by dfaure).
autotests: adapt to shared-mime-info change
Sat, Apr 20, 10:32 AM
dfaure accepted D20694: Use regular stat when resolving a symlink.

Glad that the unittest caught an actual bug for once :-)

Sat, Apr 20, 10:07 AM · Frameworks
dfaure committed R241:e091dd683c89: autotests: kfileitemtest: close file before inspecting it (authored by dfaure).
autotests: kfileitemtest: close file before inspecting it
Sat, Apr 20, 8:37 AM
dfaure added a comment to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.

I'm talking about jobtest and kdirmodeltest regressing exactly in build 87, which is where this commit landed.
If you click on history for a given test you can see that those aren't sporadic failures: https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiowidgets_kdirmodeltest/history/
and
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiocore_jobtest/history/

Sat, Apr 20, 8:28 AM · Frameworks
dfaure requested changes to D20692: Fix test KDirListerTest::testRenameItem.
Sat, Apr 20, 8:25 AM · Frameworks

Thu, Apr 18

dfaure added a comment to D20656: Plotter: Scope GL Program to lifespan of scenegraph node.

No, it's pretty much the same. The garbage looks a bit different, but switching to another email and back fixes it, so no big deal. I thought this was what this whole effort was about, though :-)

Thu, Apr 18, 4:25 PM · Frameworks
dfaure added a comment to D20656: Plotter: Scope GL Program to lifespan of scenegraph node.

Thanks, this fixes the plasma crash on resume.

Thu, Apr 18, 4:10 PM · Frameworks
dfaure accepted D20647: [Purpose] Make it compile without foreach.
Thu, Apr 18, 11:48 AM · Frameworks
dfaure added a comment to D20648: [KNotification] Add HighUrgency.

Ah, great, thanks.

Thu, Apr 18, 8:39 AM · Frameworks
dfaure added inline comments to D20648: [KNotification] Add HighUrgency.
Thu, Apr 18, 8:37 AM · Frameworks
dfaure requested changes to D20647: [Purpose] Make it compile without foreach.
Thu, Apr 18, 7:25 AM · Frameworks

Wed, Apr 17

dfaure accepted D20625: Truncate trailing forward slashes(/).

Patch looks good now ;-)

Wed, Apr 17, 4:06 PM · Frameworks
dfaure added a comment to D20626: Refactor and cleanup.

I like the idea.

Wed, Apr 17, 12:32 PM · Frameworks
dfaure requested changes to D20625: Truncate trailing forward slashes(/).
Wed, Apr 17, 12:30 PM · Frameworks

Tue, Apr 16

dfaure added a comment to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.

This change also introduced regressions in two unittests: jobtest and kdirmodeltest. I'll let you look into those :-)

Tue, Apr 16, 11:12 AM · Frameworks
dfaure added a comment to D20599: Fix compilation error on window.

Sorry, I was faster.... :/

Tue, Apr 16, 10:45 AM · Frameworks
dfaure committed R241:8f9f0f8db248: Compilation fix: don't try using uid_t and gid_t on Windows. (authored by dfaure).
Compilation fix: don't try using uid_t and gid_t on Windows.
Tue, Apr 16, 10:38 AM
dfaure added a comment to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.

Nah, no C++17 here, the compiler is just confused because it doesn't know the types uid_t and gid_t.

Tue, Apr 16, 10:38 AM · Frameworks

Mon, Apr 15

dfaure committed R165:08438b04e96f: FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it (authored by dfaure).
FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it
Mon, Apr 15, 9:55 PM
dfaure closed D20512: FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it.
Mon, Apr 15, 9:55 PM · KDE PIM
dfaure updated the diff for D20512: FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it.

Call IntervalCheck::init()

Mon, Apr 15, 8:47 PM · KDE PIM
dfaure added inline comments to D20512: FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it.
Mon, Apr 15, 8:46 PM · KDE PIM
dfaure committed R165:85d98e4e9250: CollectionScheduler: list all collections initially, not just those with… (authored by dfaure).
CollectionScheduler: list all collections initially, not just those with…
Mon, Apr 15, 8:41 PM
dfaure closed D20505: CollectionScheduler: list all collections initially, not just those with syncPref set..
Mon, Apr 15, 8:41 PM · KDE PIM
dfaure committed R165:047961b1f970: CollectionScheduler: add tests for the actual QTimer interval (authored by dfaure).
CollectionScheduler: add tests for the actual QTimer interval
Mon, Apr 15, 8:40 PM
dfaure closed D20483: CollectionScheduler: add tests for the actual QTimer interval.
Mon, Apr 15, 8:40 PM · KDE PIM
dfaure committed R165:f50f23be96d9: Comment out the flaky part of ItemsyncTest… (authored by dfaure).
Comment out the flaky part of ItemsyncTest…
Mon, Apr 15, 6:37 PM
dfaure closed D20363: CollectionScheduler: port to std::chrono to avoid the year-2038 bug.
Mon, Apr 15, 6:19 PM · KDE PIM
dfaure committed R165:ce317f7e5f4e: CollectionScheduler: port to std::chrono to avoid the year-2038 bug (authored by dfaure).
CollectionScheduler: port to std::chrono to avoid the year-2038 bug
Mon, Apr 15, 6:19 PM
dfaure committed R199:2f0f78c9d86e: Merge branch 'Applications/19.04' (authored by dfaure).
Merge branch 'Applications/19.04'
Mon, Apr 15, 4:55 PM
dfaure committed R226:211d5e1f7958: Fix compilation with Qt 5.13 (QByteArray/QString confusions) (authored by dfaure).
Fix compilation with Qt 5.13 (QByteArray/QString confusions)
Mon, Apr 15, 4:35 PM
dfaure committed R199:51c31b72918c: Browser tab: fix sorting by task summary (authored by dfaure).
Browser tab: fix sorting by task summary
Mon, Apr 15, 4:07 PM
dfaure committed R199:0e3640a61c2f: Browser tab: update item details whenever current item changes in the list (authored by dfaure).
Browser tab: update item details whenever current item changes in the list
Mon, Apr 15, 4:05 PM
dfaure accepted D20346: Remove Collection references from Akonadi.

Nice pun :-)

Mon, Apr 15, 8:03 AM · KDE PIM
dfaure committed R78:fbf246d76af4: Merge remote-tracking branch 'origin/Applications/19.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/19.04'
Mon, Apr 15, 6:57 AM
dfaure committed R78:33068cbce44e: Re-enable moving events between collections in korganizer (authored by dfaure).
Re-enable moving events between collections in korganizer
Mon, Apr 15, 6:56 AM
dfaure closed D20340: Re-enable moving events between collections in korganizer.
Mon, Apr 15, 6:56 AM · KDE PIM
dfaure committed R78:e8bb93c71700: Incidence Dialog: don't show an empty message widget initially. (authored by dfaure).
Incidence Dialog: don't show an empty message widget initially.
Mon, Apr 15, 6:55 AM
dfaure closed D20560: Incidence Dialog: don't show an empty message widget initially..
Mon, Apr 15, 6:55 AM · KDE PIM

Sun, Apr 14

dfaure requested review of D20560: Incidence Dialog: don't show an empty message widget initially..
Sun, Apr 14, 9:57 PM · KDE PIM
dfaure updated the diff for D20363: CollectionScheduler: port to std::chrono to avoid the year-2038 bug.

fix commit log

Sun, Apr 14, 9:27 PM · KDE PIM
dfaure committed R165:40a122a2962e: GIT_SILENT fix typo in comment (authored by dfaure).
GIT_SILENT fix typo in comment
Sun, Apr 14, 9:27 PM
dfaure accepted D20557: Install krcc.h header.

Can't remember what use case I had in mind back then... Probably someone asked me to implement this....

Sun, Apr 14, 9:14 PM · Frameworks
dfaure committed R294:746ecc8db9a0: Add KF6 TODO (authored by dfaure).
Add KF6 TODO
Sun, Apr 14, 6:54 PM
dfaure added a comment to D20209: Add support for KBookmarkOwner to communicate if it has tabs open.

Urgh. Indeed. And looking around I find many inline virtuals in apparently public headers... http://www.davidfaure.fr/2019/inline_virtual_dtors.diff (though maybe some of these don't have d pointers at all...)

Sun, Apr 14, 6:52 PM · Frameworks
dfaure accepted D20555: Don't use qAsConst over a temporary variable.
Sun, Apr 14, 6:18 PM · Frameworks
dfaure committed R290:c3e896e02f9a: Don't use qAsConst over a temporary variable (authored by dfaure).
Don't use qAsConst over a temporary variable
Sun, Apr 14, 6:15 PM
dfaure closed D20552: Don't use qAsConst over a temporary variable.
Sun, Apr 14, 6:15 PM · Frameworks
dfaure accepted D20519: Fix double delete on broken files.

The double star looks very C-ish to me, but OK, I just realized that the recursive call itself would probably look more cumbersome, so I won't insist.

Sun, Apr 14, 6:05 PM · Frameworks
dfaure added a comment to D20519: Fix double delete on broken files.

Oops indeed, I stopped working on the unittest when I managed to make it reproduce the crash. Thanks for integrating it and fixing it.

Sun, Apr 14, 5:57 PM · Frameworks
dfaure added a comment to D20489: [KIO] Make it compile without foreach (Step 1).

Yes, the pitfalls are well known.

  1. don't modify the container being iterated upon (from inside the loop)
  2. don't use qAsConst on temporaries
Sun, Apr 14, 5:56 PM · Frameworks
dfaure updated the diff for D20552: Don't use qAsConst over a temporary variable.

Improve regexp to avoid catching kbuildsycoca.cpp

Sun, Apr 14, 5:49 PM · Frameworks
dfaure requested review of D20552: Don't use qAsConst over a temporary variable.
Sun, Apr 14, 5:47 PM · Frameworks
dfaure committed R172:179dafa44a11: GIT_SILENT remove _P in ifndef/define macro, for public headers (authored by dfaure).
GIT_SILENT remove _P in ifndef/define macro, for public headers
Sun, Apr 14, 11:47 AM
dfaure committed R241:414c3a9c8a46: Fix signed/unsigned warning after statx change (authored by dfaure).
Fix signed/unsigned warning after statx change
Sun, Apr 14, 10:48 AM
dfaure closed D20530: Fix signed/unsigned warning after statx change.
Sun, Apr 14, 10:48 AM · Frameworks
dfaure requested review of D20530: Fix signed/unsigned warning after statx change.
Sun, Apr 14, 10:00 AM · Frameworks
dfaure added inline comments to D20209: Add support for KBookmarkOwner to communicate if it has tabs open.
Sun, Apr 14, 9:55 AM · Frameworks
dfaure requested changes to D20519: Fix double delete on broken files.

Good catch.
I'd still prefer if such changes would come with a unittest, because it will be hard otherwise to immediately detect (while developing) that changes don't introduce any regressions.
I managed to write a unittest for this one, please integrate it into your commit:

Sun, Apr 14, 9:48 AM · Frameworks

Sat, Apr 13

dfaure added a comment to D20489: [KIO] Make it compile without foreach (Step 1).

I view the KF5 changelog as the list of things that can be useful to the users of the frameworks (i.e. application developers).
When we add API, fix a bug, or change dependencies, that's useful for them to know.
When we repair a unittest, fix typos in comments, port away from deprecated methods and so on, I don't see how that is useful for the application developers to know. To me it would just be noise in the changelog, it doesn't affect them.
Sure, in the long run it means we're maintaining the stuff and making sure it will still work with future versions of Qt, but they'll get notified of that when the time comes anyway.

Sat, Apr 13, 10:21 PM · Frameworks
dfaure abandoned D7497: Fix Ctrl PageUp/PageDown shortcut conflict due to KF 5.37..
Sat, Apr 13, 9:46 PM · Kate
dfaure added a comment to D20489: [KIO] Make it compile without foreach (Step 1).

GIT_SILENT is "trivial, don't look at the commit" -- at least it used to be. Not really applicable to commits such as this one....

Sat, Apr 13, 9:44 PM · Frameworks
dfaure added a comment to D7497: Fix Ctrl PageUp/PageDown shortcut conflict due to KF 5.37..

I actually meant Alt+Home/End, because I thought this was "go to beginning/end of view" (itempotent, if you do it twice, the second time it does nothing).

Sat, Apr 13, 9:05 PM · Kate
dfaure added a comment to D7497: Fix Ctrl PageUp/PageDown shortcut conflict due to KF 5.37..

Alt+Home, Alt+End ?

Sat, Apr 13, 8:34 PM · Kate
dfaure added a comment to D20512: FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it.

BTW I didn't go for "making intervalChecker() return a base class pointer" because of the code that says AkonadiServer::instance()->intervalChecker()->requestCollectionSync(collection);

Sat, Apr 13, 8:20 PM · KDE PIM
dfaure requested review of D20516: KCharSelect: remove unnecessary call.
Sat, Apr 13, 7:23 PM
dfaure requested review of D20515: KCharSelect: add unittest. Hits the assert in QHeaderView..
Sat, Apr 13, 7:15 PM · Frameworks
dfaure added a comment to D7497: Fix Ctrl PageUp/PageDown shortcut conflict due to KF 5.37..

I agree.

Sat, Apr 13, 7:04 PM · Kate
dfaure requested review of D20512: FakeCollectionScheduler => FakeIntervalCheck, so FakeAkonadiServer can return it.
Sat, Apr 13, 4:26 PM · KDE PIM
dfaure added a comment to D20346: Remove Collection references from Akonadi.

Hi Dan, can you push this ASAP? My own work keeps touching lines that have referenced() in them, a good recipe for merge conflicts for either of us at some point.

Sat, Apr 13, 4:20 PM · KDE PIM
dfaure added a comment to D20506: KCharSelect's internal model: ensure rowCount() is 0 for valid indexes.

It's common to say "I have 3 columns everywhere", that's what tree models look like.
And if you have zero rows somewhere, it doesn't matter how many columns you have, that's still "nothing".

Sat, Apr 13, 3:25 PM · Frameworks
dfaure committed R236:794d10a834a7: KCharSelect's internal model: ensure rowCount() is 0 for valid indexes (authored by dfaure).
KCharSelect's internal model: ensure rowCount() is 0 for valid indexes
Sat, Apr 13, 2:08 PM
dfaure closed D20506: KCharSelect's internal model: ensure rowCount() is 0 for valid indexes.
Sat, Apr 13, 2:08 PM · Frameworks
dfaure accepted D20489: [KIO] Make it compile without foreach (Step 1).

FYI NO_CHANGELOG doesn't have to be in the first line (which would make noise in phab review titles for new requests, etc). It can be a line of its own, for example towards the end of the commit log.

Sat, Apr 13, 1:47 PM · Frameworks
dfaure requested review of D20506: KCharSelect's internal model: ensure rowCount() is 0 for valid indexes.
Sat, Apr 13, 1:42 PM · Frameworks
dfaure committed R236:7b253e4c219a: KAcceleratorManager: initialize member variable to fix compiler warning (authored by dfaure).
KAcceleratorManager: initialize member variable to fix compiler warning
Sat, Apr 13, 1:13 PM
dfaure requested review of D20505: CollectionScheduler: list all collections initially, not just those with syncPref set..
Sat, Apr 13, 12:38 PM · KDE PIM
dfaure added a comment to D20489: [KIO] Make it compile without foreach (Step 1).

Yep, but extracting changelogs from commit logs can be mostly automated, including filtering out many commits with the same first line.
It's what I do in git@git.kde.org:sysadmin/release-tools branch frameworks/5.0 file parse_changelogs.pl.

Sat, Apr 13, 12:09 PM · Frameworks
dfaure requested changes to D20489: [KIO] Make it compile without foreach (Step 1).

cgiboudeaux: the Qt documentation says that foreach is deprecated, what do you suggest Laurent should add to the commit log? Just "it's deprecated", a copy/paste of the Qt docu, or https://www.kdab.com/goodbye-q_foreach/ ?

Sat, Apr 13, 10:50 AM · Frameworks
dfaure requested changes to D20209: Add support for KBookmarkOwner to communicate if it has tabs open.

Thanks for this contribution.

Sat, Apr 13, 10:27 AM · Frameworks
dfaure committed R497:9f6b6f086681: up version numbers (authored by dfaure).
up version numbers
Sat, Apr 13, 10:26 AM
dfaure committed R497:91b2cfa3b3f6: improve changelog filtering (authored by dfaure).
improve changelog filtering
Sat, Apr 13, 10:26 AM
dfaure committed R497:4b06f6b58f0f: Update CI URL (authored by dfaure).
Update CI URL
Sat, Apr 13, 10:26 AM
dfaure accepted D20503: "Fix" KArchive::findOrCreate running out of stack on VERY LONG paths.

Thanks!

Sat, Apr 13, 10:19 AM · Frameworks
dfaure committed R883:1539746: KF 5.57.
KF 5.57
Sat, Apr 13, 9:51 AM
dfaure updated the diff for D20483: CollectionScheduler: add tests for the actual QTimer interval.

port interval method to std::chrono

Sat, Apr 13, 9:21 AM · KDE PIM
dfaure committed R883:1539738: add frameworks-5.57.0 to generate_release_data.py.
add frameworks-5.57.0 to generate_release_data.py
Sat, Apr 13, 8:47 AM
dfaure updated the diff for D20363: CollectionScheduler: port to std::chrono to avoid the year-2038 bug.

Port to chrono_literals, even if it makes QtCreator 4.8 barf on the syntax ;)

Sat, Apr 13, 8:46 AM · KDE PIM
dfaure committed R165:074b2c7a6a5d: Add test for CollectionScheduler, code cleanups, bugfixes. (authored by dfaure).
Add test for CollectionScheduler, code cleanups, bugfixes.
Sat, Apr 13, 8:39 AM
dfaure closed D20362: Add test for CollectionScheduler, code cleanups, bugfixes..
Sat, Apr 13, 8:39 AM · KDE PIM

Fri, Apr 12

dfaure requested review of D20483: CollectionScheduler: add tests for the actual QTimer interval.
Fri, Apr 12, 7:58 AM · KDE PIM
dfaure committed R165:f2e8d84f89f4: Improve error message "multiple merge candidates" to indicate the collection… (authored by dfaure).
Improve error message "multiple merge candidates" to indicate the collection…
Fri, Apr 12, 7:49 AM
dfaure accepted D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog.
Fri, Apr 12, 7:13 AM · Frameworks
dfaure accepted D20462: [KUiServerJobTracker] Track kuiserver service life time and re-register jobs if needed.
Fri, Apr 12, 7:12 AM · Frameworks

Thu, Apr 11

dfaure updated the diff for D20363: CollectionScheduler: port to std::chrono to avoid the year-2038 bug.

update comment

Thu, Apr 11, 6:50 AM · KDE PIM
dfaure updated the diff for D20363: CollectionScheduler: port to std::chrono to avoid the year-2038 bug.

Port to std::chrono.

Thu, Apr 11, 6:48 AM · KDE PIM
dfaure updated the diff for D20362: Add test for CollectionScheduler, code cleanups, bugfixes..

use mutexlocker

Thu, Apr 11, 6:47 AM · KDE PIM
dfaure added inline comments to D20362: Add test for CollectionScheduler, code cleanups, bugfixes..
Thu, Apr 11, 6:45 AM · KDE PIM