- User Since
- Mar 5 2015, 12:44 PM (141 w, 3 d)
Sat, Nov 18
Fri, Nov 17
Thu, Nov 16
Can you push this to Applications/17.12? Laurent is on vacations, and I'd like to have the fix in that release, with time to test it before the actual release.
Weird, I wonder what's the relation with FreeBSD :) Compiler, I guess...
More seriously, this could be a reason for adding QUrl::addPath(), like we had in KUrl.
Maybe we need a KUrl class :-)
Urgh. That QUrl change doesn't make things easy for this type of code indeed.
Wed, Nov 15
isNull() does quite some filesystem lookup at least, yes.
I just found it's a combo, so actually only one item is visible, which makes it even more weird that it would need to do much with the other icons upfront.
I thought QIcon::fromTheme itself did nothing and the lookup was done on demand. But maybe addItem does trigger this indeed, which makes sense for visible items at least... setUniformHeights or something might help so it doesn't query each icon for size?
You should prefer mimetype filters, so that more extensions and magic-mimetype-determination works.
text/html and text/plain should do the job just fine, no?
Tue, Nov 14
This commit is full of race conditions. Writing to a memory location from a thread and reading from that memory location from another thread, with no synchronization mechanism, is a data race, which is undefined behavior.
Leave qt4 untouched.
Mon, Nov 13
Sun, Nov 12
I like the idea.
Sat, Nov 11
Personally, I don't find a check in QFile/QFileInfo "much cleaner". It's an invalid call, arguably. So checking here makes sense.
Thu, Nov 9
Qt doesn't have files like KF5WindowSystemConfig.cmake.in :)
That is indeed source incompatible (apart from the change to the _p.h headers). You can either just add a "TODO KF6" comment, or provide a cmake option for linking to QtWidgets, but it needs to be on by default to keep source compat.
Wed, Nov 8
Yes, feel free to kill the hidden setting for completion, especially if the default value isn't the one that gives the best user experience.
Tue, Nov 7
Mon, Nov 6
The KCM uses KServiceTypeTrader so we still need the desktop files.
Sun, Nov 5
The answer to "I'm not sure why" is easy: git log -S MALLOC shows exactly two commits, the one that introduced the usage of this stuff, and the one that removed it again. Ain't git great?