dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (171 w, 6 d)
Availability
Available

Recent Activity

Today

dfaure accepted D13630: automatic tests: do not embed EmbeddedImageData already in the library.
Wed, Jun 20, 2:33 PM · Baloo, Frameworks

Yesterday

dfaure accepted D13623: [kded kcm] Fix estimating dbusModuleName of kded plugins.
Tue, Jun 19, 9:45 PM · Plasma
dfaure accepted D13622: Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata.

Note: kcoreaddons, baloo, kservice/autotests, and kdelibs4support mention this key too, you can clean it all up ;)

Tue, Jun 19, 9:19 PM · Frameworks
dfaure accepted D13621: KDEDModule servicetype definition: remove unused key X-KDE-DBus-ModuleName.

Indeed, not used, and not useful.

Tue, Jun 19, 9:17 PM · Frameworks
dfaure added a comment to D13043: Properly sanitize input.

BTW, the commit message refers to ModelTest, but that's the old modeltest.cpp, not the new QAbstractItemModelTester, right?

Tue, Jun 19, 1:12 PM · Frameworks

Mon, Jun 18

dfaure accepted D13590: Use QUrl < instead of QString.compare.
Mon, Jun 18, 6:49 PM · Frameworks
dfaure requested changes to D13590: Use QUrl < instead of QString.compare.

Well then you can just remove lessThan altogether, and call std::sort with only 2 arguments instead of 3 ;)

Mon, Jun 18, 4:14 PM · Frameworks

Fri, Jun 15

dfaure committed R78:1edaab04a4fb: Implement TODO: show error message on invalid date/time (authored by dfaure).
Implement TODO: show error message on invalid date/time
Fri, Jun 15, 9:23 AM

Wed, Jun 13

dfaure committed R85:926f4d843afc: PimUniqueApplication: make newInstance virtual. (authored by dfaure).
PimUniqueApplication: make newInstance virtual.
Wed, Jun 13, 8:58 AM
dfaure closed D13300: PimUniqueApplication: make newInstance virtual..
Wed, Jun 13, 8:58 AM · KDE PIM
dfaure committed R206:7b5d2c0fc097: KMail: don't move the mainwindow to the current desktop when invoking a composer (authored by dfaure).
KMail: don't move the mainwindow to the current desktop when invoking a composer
Wed, Jun 13, 8:57 AM
dfaure closed D13301: KMail: don't move the mainwindow to the current desktop when invoking a composer.
Wed, Jun 13, 8:57 AM · KDE PIM
dfaure committed R206:db6f5fba5243: Fix typo in argument name (authored by dfaure).
Fix typo in argument name
Wed, Jun 13, 8:57 AM
dfaure accepted D13397: Support desktop:/ protocol.
Wed, Jun 13, 7:56 AM
dfaure accepted D13211: Enable comparing KFileItems by url.
Wed, Jun 13, 7:54 AM · Frameworks

Tue, Jun 12

dfaure accepted D13475: fix sftp links with new uds implementation.
Tue, Jun 12, 7:24 AM

Sat, Jun 9

dfaure committed R497:87e0c4fa3d4a: kf 5.47 fixes (authored by dfaure).
kf 5.47 fixes
Sat, Jun 9, 3:44 PM
dfaure committed R883:1517622: KF 5.47.
KF 5.47
Sat, Jun 9, 3:27 PM
dfaure committed R883:1517621: add frameworks-5.47.0 to generate_release_data.py.
add frameworks-5.47.0 to generate_release_data.py
Sat, Jun 9, 3:25 PM

Thu, Jun 7

dfaure accepted D13398: [KFileItem] Check most local URL for whether it's shared.
Thu, Jun 7, 6:55 AM · Frameworks

Tue, Jun 5

dfaure added a comment to D13342: Fix regression when pasting binary data from clipboard.

Done.

Tue, Jun 5, 10:11 PM · Frameworks
dfaure accepted D13332: Don't generate thumbnail for desktop files with custom icon.
Tue, Jun 5, 5:40 PM
dfaure accepted D13342: Fix regression when pasting binary data from clipboard.

Heh, indeed.

Tue, Jun 5, 8:52 AM · Frameworks

Sun, Jun 3

dfaure requested review of D13301: KMail: don't move the mainwindow to the current desktop when invoking a composer.
Sun, Jun 3, 12:13 PM · KDE PIM
dfaure requested review of D13300: PimUniqueApplication: make newInstance virtual..
Sun, Jun 3, 11:45 AM · KDE PIM

Sat, Jun 2

dfaure committed R241:ac6cf0b2494d: autotests: fix ktcpsockettest after server change. (authored by dfaure).
autotests: fix ktcpsockettest after server change.
Sat, Jun 2, 4:21 PM
dfaure committed R241:6a69c992235f: Fix compilation with gcc 5.3.1, offsetof comes from stddef.h (authored by dfaure).
Fix compilation with gcc 5.3.1, offsetof comes from stddef.h
Sat, Jun 2, 4:11 PM
dfaure accepted D12599: KFileOperator: fix apidox of fileHighlighted().
Sat, Jun 2, 4:07 PM · Frameworks

Wed, May 30

dfaure accepted D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu.
Wed, May 30, 8:55 PM · Frameworks
dfaure added a comment to D7451: Dragging tabs in konsole lags.

I've noticed that since this commit, I often accidentally drag-n-drop a tab outside the window such that it creates a new window.

Wed, May 30, 3:59 PM · Konsole
dfaure requested changes to D13211: Enable comparing KFileItems by url.

A good example of how a unittest helps catching a bug :-)
(and a good example of how code that I suggest isn't necessarily bugfree, haha)

Wed, May 30, 2:12 PM · Frameworks
dfaure committed R723:a791e380fa55: Enable -DQT_NO_URL_CAST_FROM_STRING and fix compilation (authored by dfaure).
Enable -DQT_NO_URL_CAST_FROM_STRING and fix compilation
Wed, May 30, 12:47 PM
dfaure requested changes to D13211: Enable comparing KFileItems by url.
Wed, May 30, 11:59 AM · Frameworks
dfaure accepted D13189: [kcoredirlister] Remove as many url.toString() as possible.

Yep, this makes sense these days (back when this was written, QUrl had no hashing function, and my first attempt at writing one was to call qHash(url.toString()) -- how horribly slow!!)

Wed, May 30, 8:41 AM · Frameworks

Tue, May 29

dfaure added a comment to D13083: Respect custom directory icons in iconNameForURL().

Unlike KFileItem, this function does no caching. I hope you do caching at the layer above then...

Tue, May 29, 7:42 AM · Frameworks
dfaure accepted D13145: Check if destination exists also when pasting binary data.
Tue, May 29, 7:29 AM · Frameworks

Mon, May 28

dfaure added a comment to D12636: Fix lack of confirmation when deleting an item with hidden children..

ping?

Mon, May 28, 5:19 PM
dfaure requested changes to D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.
Mon, May 28, 8:01 AM · Frameworks
dfaure accepted D12745: Unify API for file descriptor sharing.
Mon, May 28, 7:49 AM · Frameworks

Fri, May 25

dfaure accepted D10410: Move task of cleaning up socket file to FdReceiver.
Fri, May 25, 11:08 PM · Frameworks
dfaure requested changes to D12945: kcoredirlister lstItems benchmark.
Fri, May 25, 11:06 PM · Frameworks
dfaure accepted D12728: KFileItemActions: fallback to default mimetype when selecting only files.

It should be easy to use lxr to see which KDE applications uses KFileItemListProperties::mimeType(), but OK, your solution is safer in case of third-party applications.

Fri, May 25, 10:54 PM · Frameworks

Thu, May 24

dfaure added inline comments to D12994: Provide access to actions in part.
Thu, May 24, 7:12 AM

May 17 2018

dfaure committed R497:1bc8a915dc35: Move log files to subdir (authored by dfaure).
Move log files to subdir
May 17 2018, 8:14 AM
dfaure committed R497:a9e3c4b4c42c: Always create a local_release branch, for possible cherry-picking later (authored by dfaure).
Always create a local_release branch, for possible cherry-picking later
May 17 2018, 8:13 AM

May 15 2018

dfaure accepted D12886: check that ffmpeg is at least version 3.1 that introduce the API we require.

Even old OpenSuSE Leap 42.3 has ffmpeg 3.3.4, so this seems fine ;-)

May 15 2018, 7:59 AM · Baloo, Frameworks

May 14 2018

dfaure requested review of D12864: Upgrade to ubuntu bionic and Qt 5.8.
May 14 2018, 7:13 AM

May 12 2018

dfaure committed R883:1515518: fix typo.
fix typo
May 12 2018, 7:52 PM
dfaure committed R883:1515517: KF 5.46.0.
KF 5.46.0
May 12 2018, 7:50 PM
dfaure committed R883:1515516: add frameworks-5.46.0 to generate_release_data.py.
add frameworks-5.46.0 to generate_release_data.py
May 12 2018, 6:24 PM

May 11 2018

dfaure added a comment to D12774: Fix submenus not updating when switching between categories of the same size.

Oops, thanks for the fix.

May 11 2018, 7:12 PM · Plasma
dfaure accepted D12807: Akregator feed detector plugin: Port the context menu plugin.

Still strange that "rss" or "rdf" anywhere in the path is enough, but I'm no rss expert... Looks good overall.

May 11 2018, 6:36 PM
dfaure accepted D12616: Akregator feed detector plugin: Port away from KDELibs4Support.

Found stuff on the way, but the commit itself is fine.

May 11 2018, 6:32 PM

May 10 2018

dfaure requested changes to D12807: Akregator feed detector plugin: Port the context menu plugin.

Nice

May 10 2018, 8:19 PM
dfaure accepted D12696: Use the new uds implementation.
May 10 2018, 11:10 AM · Frameworks

May 9 2018

dfaure accepted D11155: handle zip files embedded within zip files.
May 9 2018, 9:42 PM · Frameworks
dfaure added a comment to D12696: Use the new uds implementation.

Starting to look good ;-)

May 9 2018, 7:30 PM · Frameworks
dfaure accepted D12371: Don't redirect smb:/ to smb:// and then to smb:///.

Patch looks good, but please update the first line of the commit message so that it gives more context (think about the changelog, where the rest of the description won't be visible...)

May 9 2018, 9:57 AM · Frameworks
dfaure accepted D12744: Add null pointer check when creating SocketAddress.
May 9 2018, 7:38 AM · Frameworks

May 8 2018

dfaure added inline comments to D12744: Add null pointer check when creating SocketAddress.
May 8 2018, 1:52 PM · Frameworks
dfaure added inline comments to D12744: Add null pointer check when creating SocketAddress.
May 8 2018, 12:06 PM · Frameworks
dfaure added inline comments to D12696: Use the new uds implementation.
May 8 2018, 12:03 PM · Frameworks

May 7 2018

dfaure added a comment to D12696: Use the new uds implementation.

Oh OK I had misunderstood your comment.

May 7 2018, 8:21 PM · Frameworks
dfaure added a comment to D12696: Use the new uds implementation.

I requested it, for proper encapsulation

May 7 2018, 6:57 PM · Frameworks
dfaure requested changes to D12696: Use the new uds implementation.
May 7 2018, 3:31 PM · Frameworks

May 6 2018

dfaure added a comment to D12696: Use the new uds implementation.

First line of commit log should have changelog in mind, so more context needed. Maybe rather something like "KIO::UDSEntry: switch to a single std::vector for more performance".

May 6 2018, 10:34 PM · Frameworks
dfaure requested changes to D12696: Use the new uds implementation.

Looks good.

May 6 2018, 10:31 PM · Frameworks
dfaure accepted D7415: kconfig: kcfg.xsd do not require a kcfgfile.

It helps if you actually add reviewers...

May 6 2018, 10:03 PM · Frameworks
dfaure committed R497:e9de3deae5c0: swap things around to send changelog upfront (authored by dfaure).
swap things around to send changelog upfront
May 6 2018, 9:19 PM
dfaure committed R499:9401e334f2db: Remove kexi-extras from kde4's kdesrc-build task list (authored by dfaure).
Remove kexi-extras from kde4's kdesrc-build task list
May 6 2018, 9:17 PM
dfaure added a comment to D12728: KFileItemActions: fallback to default mimetype when selecting only files.

Makes sense, but why not do this in KFileItemListProperties::mimeType()?

May 6 2018, 9:03 PM · Frameworks
dfaure accepted D12727: Introduce KFileItemListProperties::isFile().
May 6 2018, 9:01 PM · Frameworks

May 5 2018

dfaure requested changes to D11604: kdirlistertest doesn't fail at random.

Please add QStandardPaths::setTestModeEnabled(true) in initTestCase() so that your (broken, thank you WinE) locally defined mimetypes don't interfer with the test. Then "hardcoding" text/html will be fine again.

May 5 2018, 1:57 PM · Frameworks
dfaure committed R497:3e74c303c0c5: preparations for 5.46 (authored by dfaure).
preparations for 5.46
May 5 2018, 1:06 PM

May 4 2018

dfaure accepted D12697: Add missing actions from the Kontact part.
May 4 2018, 5:33 PM
dfaure accepted D12659: two new UDS structures.

Thanks

May 4 2018, 8:33 AM · Frameworks

May 3 2018

dfaure added a comment to D12637: Display an error page for error URLs in WebEnginePart.

I don't understand the "except" in your reply.

May 3 2018, 8:36 AM
dfaure added a comment to D12659: two new UDS structures.

I like the replaceOrInsert idea, and the assert in insert... we might have to fix some kioslaves, but in general they have no good reason to insert twice for the same key.

May 3 2018, 8:06 AM · Frameworks
dfaure added inline comments to D12637: Display an error page for error URLs in WebEnginePart.
May 3 2018, 7:58 AM
dfaure added a comment to D12637: Display an error page for error URLs in WebEnginePart.

In both cases the same fragility exists, in case one of the replacement strings contains one of the placeholders --- unless you use multi-arg, i.e. myString.arg(title, direction, m_warningIconData, ...)

May 3 2018, 7:56 AM

May 2 2018

dfaure added a comment to D12659: two new UDS structures.

Thanks for that investigation. Interesting that linear search is faster than binary search in the same data structure... maybe the compiler optimizes it better? Did you profile V2 to find out where the time is spent, or do you have a better explanation?

Binary search has a (small) overhead, you can hardly beat linear search when the number of entries is small. When you use binary search, you pay when inserting - find the right position, probably move other items. When you do inserts one item a time, you have O(n^2) behavior.

May 2 2018, 4:04 PM · Frameworks
dfaure added a comment to D12659: two new UDS structures.

Thanks for that investigation. Interesting that linear search is faster than binary search in the same data structure... maybe the compiler optimizes it better? Did you profile V2 to find out where the time is spent, or do you have a better explanation?
But even if both were equal performance-wise I'd favor linear search because sorted insertion is easy to get wrong - as this patch shows ;)

May 2 2018, 11:58 AM · Frameworks

May 1 2018

dfaure requested changes to D12637: Display an error page for error URLs in WebEnginePart.

Thanks for the fixes, here are a few more nitpicks ;)

May 1 2018, 8:45 PM
dfaure requested changes to D12637: Display an error page for error URLs in WebEnginePart.

Nice! I remember that this was sorely missing when I was using that part :-)

May 1 2018, 5:09 PM
dfaure requested review of D12636: Fix lack of confirmation when deleting an item with hidden children..
May 1 2018, 3:03 PM
dfaure committed R4:8beb006cb309: Fix typo in test name (authored by dfaure).
Fix typo in test name
May 1 2018, 2:41 PM
dfaure requested review of D12635: Tests: remove unnecessary QDate => QDateTime => QDate conversions.
May 1 2018, 2:32 PM
dfaure committed R4:e12ffdbdb91f: Also port EditorView to QDate only (authored by ervin).
Also port EditorView to QDate only
May 1 2018, 2:27 PM
dfaure closed D12615: Also port EditorView to QDate only.
May 1 2018, 2:27 PM
dfaure requested review of D12634: RunningTaskModel: update shown title when renaming the currently running task.
May 1 2018, 2:24 PM
dfaure requested review of D12632: RunningTaskWidget: test the shown text in the unittest.
May 1 2018, 2:19 PM

Apr 30 2018

dfaure accepted D12615: Also port EditorView to QDate only.

Clearly we should port to the qt5 connect syntax...

Apr 30 2018, 7:04 PM
dfaure committed R4:f1cb4ad6b020: Finish removing the compat code for old kcalcore versions. (authored by dfaure).
Finish removing the compat code for old kcalcore versions.
Apr 30 2018, 10:37 AM
dfaure closed D12607: Finish removing the compat code for old kcalcore versions..
Apr 30 2018, 10:37 AM
dfaure committed R4:c7db6d661cb6: Remove now unused DateTime::currentDateTime() (authored by dfaure).
Remove now unused DateTime::currentDateTime()
Apr 30 2018, 10:37 AM
dfaure closed D12597: Remove now unused DateTime::currentDateTime().
Apr 30 2018, 10:37 AM
dfaure committed R4:82d97f65f4f5: Fix regression where today's tasks don't appear between 00:00 and 01:00. (authored by dfaure).
Fix regression where today's tasks don't appear between 00:00 and 01:00.
Apr 30 2018, 10:37 AM
dfaure closed D9095: Fix regression where today's tasks don't appear between 00:00 and 01:00..
Apr 30 2018, 10:36 AM
dfaure committed R4:885c7b0f655b: Add Utils::DateTime::currentDate() (authored by dfaure).
Add Utils::DateTime::currentDate()
Apr 30 2018, 10:36 AM
dfaure closed D12581: Add Utils::DateTime::currentDate().
Apr 30 2018, 10:36 AM