dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (206 w, 6 d)
Availability
Available

Recent Activity

Tue, Feb 19

dfaure requested changes to D19168: Fix crash in Dolphin when dropping trashed file in trash.

Looks good, just some minor improvement suggestions for the unittest.

Tue, Feb 19, 10:59 PM · Frameworks
dfaure accepted D19172: Fix building with akonadi search support.

Oops... thanks.

Tue, Feb 19, 10:56 PM · KDE PIM
dfaure requested changes to D19170: Fix crash while moving files.

If some code is deleting this job from a slot connected to it, that code needs to be fixed. This hack isn't a fix, it will only create more problems..

Tue, Feb 19, 10:55 PM · Frameworks
dfaure requested review of D19147: Fix context not disappearing from the treeview upon removal..
Tue, Feb 19, 12:04 AM
dfaure requested review of D19146: Store contexts as todos, not tags, step 7: fixing feature tests.
Tue, Feb 19, 12:04 AM
dfaure set the repository for D19139: Store contexts as todos, not tags, step 3: add GenTodo().asContext() to R4 Zanshin.
Tue, Feb 19, 12:04 AM
dfaure requested review of D19145: Remove all remaining traces of Akonadi::Tag.
Tue, Feb 19, 12:04 AM
dfaure requested review of D19144: Remove AkonadiCache's handling of tags, not needed anymore.
Tue, Feb 19, 12:04 AM
dfaure requested review of D19143: Remove fetchTags() and fetchTagItems() from the storage implementations.
Tue, Feb 19, 12:03 AM
dfaure requested review of D19142: Store contexts as todos, not tags, step 6: AkonadiFakeData.
Tue, Feb 19, 12:03 AM
dfaure requested review of D19141: Store contexts as todos, not tags, step 5: much porting.
Tue, Feb 19, 12:03 AM
dfaure requested review of D19140: Store contexts as todos, not tags, step 4: more Serializer methods.
Tue, Feb 19, 12:02 AM
dfaure requested review of D19139: Store contexts as todos, not tags, step 3: add GenTodo().asContext().
Tue, Feb 19, 12:02 AM
dfaure requested review of D19138: Store contexts as todos, not tags, step 2: port ContextRepository.
Tue, Feb 19, 12:02 AM

Mon, Feb 18

dfaure requested review of D19137: Store contexts as todos, not tags, step 1: extend AkonadiSerializer.
Mon, Feb 18, 11:59 PM
dfaure abandoned D19136: Store contexts as todos, not tags..

Bleh, phabricator sucks. It does show a list of commits, but no way to view (and review) each commit's diff separately?

Mon, Feb 18, 11:52 PM
dfaure requested review of D19136: Store contexts as todos, not tags..
Mon, Feb 18, 11:50 PM
dfaure committed R4:91740e7f21e3: Fix connect warning on quit. (authored by dfaure).
Fix connect warning on quit.
Mon, Feb 18, 11:03 PM
dfaure added a comment to D19107: Write valid UTF8 characters without escaping..

No objection from me, but I'm no utf-8 expert.

Mon, Feb 18, 9:41 PM · Frameworks
dfaure committed R4:0c2abd6983fe: Remove leftover _data method, unused. (authored by dfaure).
Remove leftover _data method, unused.
Mon, Feb 18, 8:54 AM

Sun, Feb 17

dfaure added a comment to D19080: [WIP] Make file overwrite a bit safer.

Ah I see, we copy to .part only when the destination actually exists. I had missed that in my earlier comment. Makes sense, actually.

Sun, Feb 17, 3:45 PM · Frameworks
dfaure added a comment to D18883: Add PDF thumbnailer.

kio_thumbnail is a separate process (like all kioslaves) so a crash doesn't bring down the user-visible application.

Sun, Feb 17, 3:32 PM · Frameworks, Dolphin

Sat, Feb 16

dfaure requested changes to D19080: [WIP] Make file overwrite a bit safer.

Thanks for working on this, here's my review.

Sat, Feb 16, 1:51 PM · Frameworks
dfaure committed R4:da68e1e1b6ad: Remove unused method AkonadiSerializer::hasContextTags() (authored by dfaure).
Remove unused method AkonadiSerializer::hasContextTags()
Sat, Feb 16, 12:42 PM

Fri, Feb 15

dfaure committed R220:14c1fe3a3a4a: Merge branch '2.0' (authored by dfaure).
Merge branch '2.0'
Fri, Feb 15, 3:28 PM
dfaure committed R220:f81a246839b4: Fix copy/paste typo on variable name (authored by dfaure).
Fix copy/paste typo on variable name
Fri, Feb 15, 3:25 PM
dfaure committed R220:f87f3c9cfc59: Fix ASSERTs when calling beginRemoveRows with out of bounds parameters. (authored by dfaure).
Fix ASSERTs when calling beginRemoveRows with out of bounds parameters.
Fri, Feb 15, 3:25 PM

Tue, Feb 12

dfaure committed R108:1b316b6b69c5: Merge branch 'Plasma/5.15' (authored by dfaure).
Merge branch 'Plasma/5.15'
Tue, Feb 12, 7:56 AM
dfaure committed R108:48971e084853: Enable -DQT_NO_URL_CAST_FROM_STRING and fix compilation (authored by dfaure).
Enable -DQT_NO_URL_CAST_FROM_STRING and fix compilation
Tue, Feb 12, 7:55 AM

Mon, Feb 11

dfaure added a comment to D18904: [FileCopyJob] Clean up after file copy operation is cancelled.

Your reasoning seems to forget that there is a first confirmation, in case of overwriting, in the form of the "Overwrite/Skip/Cancel" dialog?

Mon, Feb 11, 3:43 PM · Frameworks
dfaure committed R165:6692cb577e4c: Akonadi: fix racy code in (MimeType|Resource)::retrieveByNameOrCreate (authored by dfaure).
Akonadi: fix racy code in (MimeType|Resource)::retrieveByNameOrCreate
Mon, Feb 11, 8:00 AM
dfaure closed D18888: Akonadi: fix racy code in (MimeType|Resource)::retrieveByNameOrCreate.
Mon, Feb 11, 8:00 AM · KDE PIM

Sun, Feb 10

dfaure added inline comments to D18904: [FileCopyJob] Clean up after file copy operation is cancelled.
Sun, Feb 10, 7:42 PM · Frameworks
dfaure committed R101:e27f6c30e9a9: Merge branch 'Plasma/5.15' (authored by dfaure).
Merge branch 'Plasma/5.15'
Sun, Feb 10, 7:27 PM
dfaure committed R101:ae5743738245: Harmonize usage of HAVE_X11, using #if and #cmakedefine01. (authored by dfaure).
Harmonize usage of HAVE_X11, using #if and #cmakedefine01.
Sun, Feb 10, 7:27 PM
dfaure committed R120:52fbaf72ab9e: Merge branch 'Plasma/5.15' (authored by dfaure).
Merge branch 'Plasma/5.15'
Sun, Feb 10, 7:23 PM
dfaure committed R120:c534fdf1ba34: Harmonize usage of HAVE_X11, using #if and #cmakedefine01 everywhere (authored by dfaure).
Harmonize usage of HAVE_X11, using #if and #cmakedefine01 everywhere
Sun, Feb 10, 7:23 PM
dfaure closed D18889: Akonadi: fix timing-dependent failure of partstreamertest.
Sun, Feb 10, 9:34 AM
dfaure committed R165:ff5c5c79a01d: Akonadi: fix timing-dependent failure of partstreamertest (authored by dfaure).
Akonadi: fix timing-dependent failure of partstreamertest
Sun, Feb 10, 9:34 AM
dfaure committed R165:a9511393016e: Akonadi: add missing dependencies on included XSL files (authored by dfaure).
Akonadi: add missing dependencies on included XSL files
Sun, Feb 10, 9:34 AM
dfaure closed D18887: Akonadi: add missing dependencies on included XSL files.
Sun, Feb 10, 9:34 AM · KDE PIM
Restricted Application added a project to D18888: Akonadi: fix racy code in (MimeType|Resource)::retrieveByNameOrCreate: KDE PIM.
Sun, Feb 10, 9:28 AM · KDE PIM

Sat, Feb 9

dfaure requested review of D18889: Akonadi: fix timing-dependent failure of partstreamertest.
Sat, Feb 9, 11:23 PM
dfaure requested review of D18888: Akonadi: fix racy code in (MimeType|Resource)::retrieveByNameOrCreate.
Sat, Feb 9, 9:58 PM · KDE PIM
dfaure requested review of D18887: Akonadi: add missing dependencies on included XSL files.
Sat, Feb 9, 9:28 PM · KDE PIM
dfaure committed R135:112e21bd45da: autotests: remove KDE_FORK_SLAVES, to see if CI works better. (authored by dfaure).
autotests: remove KDE_FORK_SLAVES, to see if CI works better.
Sat, Feb 9, 7:35 PM
dfaure committed R240:6bbb7b0a8746: Fix destroying QThread while still running -> warning -> crash (authored by dfaure).
Fix destroying QThread while still running -> warning -> crash
Sat, Feb 9, 3:28 PM
dfaure committed R883:1535005: KF 5.55.
KF 5.55
Sat, Feb 9, 1:03 PM
dfaure committed R883:1535004: add frameworks-5.55.0 to generate_release_data.py.
add frameworks-5.55.0 to generate_release_data.py
Sat, Feb 9, 12:59 PM

Wed, Feb 6

dfaure added a comment to D18762: Add support for portals in KRun.

This should only be done if KRun::setEnableExternalBrowser(false) wasn't called, otherwise it will break KParts' BrowserRun subclass and Konqueror's KonqRun (who use KRun to actually find out the mimetype of the file, not to launch another browser).
T
his means adding a bool d->m_externalBrowserEnabled in KRun, since right now we can't know that it was called if the settings don't actually define an external browser.

Wed, Feb 6, 8:06 AM · Frameworks
dfaure requested changes to D18778: [KRun] Fall back to reading text/html in mimeapps.list if others aren't there.

This makes no sense to me. The whole point of " based on the contents of the URL " is to open images in an image viewer, PDFs in a PDF viewer, etc.
So hardcoding text/html breaks this and opens everything in a webbrowser -- if that's what you want, set a browser app, not "based on the contents of the URL".

Wed, Feb 6, 7:59 AM · Frameworks

Tue, Feb 5

dfaure committed R165:42b83846f525: Merge branch 'Applications/18.12' (authored by dfaure).
Merge branch 'Applications/18.12'
Tue, Feb 5, 8:27 PM
dfaure committed R165:5099b3cfda53: Simplify AggregatedFetchScope code, removing all setters. (authored by dfaure).
Simplify AggregatedFetchScope code, removing all setters.
Tue, Feb 5, 8:26 PM
dfaure committed R165:861a6e8800cc: Fix tag change notification shipping a bogus name. (authored by dfaure).
Fix tag change notification shipping a bogus name.
Tue, Feb 5, 8:26 PM
dfaure closed D18711: Simplify AggregatedFetchScope code, removing all setters..
Tue, Feb 5, 8:26 PM · KDE PIM
dfaure closed D18709: Fix tag change notification shipping a bogus name..
Tue, Feb 5, 8:26 PM · KDE PIM
dfaure committed R165:ccea01c5cd15: AggregatedFetchScope: fix fetchAllAttributes for tags. (authored by dfaure).
AggregatedFetchScope: fix fetchAllAttributes for tags.
Tue, Feb 5, 8:26 PM
dfaure closed D18695: AggregatedFetchScope: fix fetchAllAttributes for tags..
Tue, Feb 5, 8:26 PM · KDE PIM
dfaure committed R165:a4ff4ce80087: Properly clean up scopes when deregistering a subscriber. (authored by dfaure).
Properly clean up scopes when deregistering a subscriber.
Tue, Feb 5, 8:24 PM
dfaure closed D18672: Properly clean up scopes when deregistering a subscriber..
Tue, Feb 5, 8:24 PM · KDE PIM
dfaure committed R165:87a155b85080: Fix "QIODevice::read" warnings. (authored by dfaure).
Fix "QIODevice::read" warnings.
Tue, Feb 5, 8:19 PM
dfaure closed D18558: Fix "QIODevice::read" warnings..
Tue, Feb 5, 8:19 PM · KDE PIM
dfaure committed R165:4208803dd65e: autotests: partstreamertest: show more info on failure (authored by dfaure).
autotests: partstreamertest: show more info on failure
Tue, Feb 5, 8:17 PM

Mon, Feb 4

dfaure added a comment to D14927: KConfig: handle directory symlinks correctly..

https://build.kde.org/job/Frameworks/view/Everything/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/ green !!! :-)
Well, blue, because blue is the new green (!?).

Mon, Feb 4, 6:17 PM · Frameworks
dfaure committed R237:c6bb7aea2132: KConfig: handle directory symlinks correctly. (authored by dfaure).
KConfig: handle directory symlinks correctly.
Mon, Feb 4, 12:42 PM
dfaure closed D14927: KConfig: handle directory symlinks correctly..
Mon, Feb 4, 12:42 PM · Frameworks

Sun, Feb 3

dfaure added a comment to D17816: Support for xattrs on kio copy/move.

Using exec() from a job implementation is a big no no, it creates an unexpected re-entrancy, source of all sorts of problems. This cannot be shipped as is.

Sun, Feb 3, 10:20 PM · Frameworks
dfaure updated the diff for D18558: Fix "QIODevice::read" warnings..

Recreate socket as suggested

Sun, Feb 3, 10:02 PM · KDE PIM
dfaure updated the diff for D18711: Simplify AggregatedFetchScope code, removing all setters..

remove another pair of add/remove methods

Sun, Feb 3, 7:47 PM · KDE PIM
dfaure requested review of D18711: Simplify AggregatedFetchScope code, removing all setters..
Sun, Feb 3, 7:45 PM · KDE PIM
dfaure requested review of D18709: Fix tag change notification shipping a bogus name..
Sun, Feb 3, 7:09 PM · KDE PIM
dfaure updated subscribers of D18695: AggregatedFetchScope: fix fetchAllAttributes for tags..
Sun, Feb 3, 6:56 PM · KDE PIM
dfaure updated the diff for D18695: AggregatedFetchScope: fix fetchAllAttributes for tags..

also add lower-level unittest

Sun, Feb 3, 5:43 PM · KDE PIM
dfaure committed R135:43d2be9b1352: Merge branch 'Plasma/5.14' (authored by dfaure).
Merge branch 'Plasma/5.14'
Sun, Feb 3, 5:35 PM
dfaure committed R135:a94bbdaadff2: autotests: remove KDE_FORK_SLAVES, to see if CI works better. (authored by dfaure).
autotests: remove KDE_FORK_SLAVES, to see if CI works better.
Sun, Feb 3, 5:34 PM
dfaure requested review of D18695: AggregatedFetchScope: fix fetchAllAttributes for tags..
Sun, Feb 3, 2:22 PM · KDE PIM
dfaure accepted D15727: Prepare environment to be able to test grantleeheaderstyle..
Sun, Feb 3, 12:45 PM · KDE PIM
dfaure accepted D16407: Add test to check that cookies are imported from KCookieServer at creation.
Sun, Feb 3, 12:41 PM
dfaure committed R4:e072a69888ed: Fix AkonadiStorageTestBase::shouldNotifyItemTagRemoved (authored by dfaure).
Fix AkonadiStorageTestBase::shouldNotifyItemTagRemoved
Sun, Feb 3, 11:49 AM
dfaure closed D18691: Fix AkonadiStorageTestBase::shouldNotifyItemTagRemoved.
Sun, Feb 3, 11:49 AM
dfaure requested review of D18691: Fix AkonadiStorageTestBase::shouldNotifyItemTagRemoved.
Sun, Feb 3, 12:11 AM

Sat, Feb 2

dfaure committed R239:c551f97f047f: autotests: disable failing KTabWidget test, not worth debugging (authored by dfaure).
autotests: disable failing KTabWidget test, not worth debugging
Sat, Feb 2, 11:19 PM
dfaure updated the diff for D18672: Properly clean up scopes when deregistering a subscriber..

Add m_startMode to AkThread to make quitThread() a no-op if NoThread.

Sat, Feb 2, 5:22 PM · KDE PIM
dfaure added inline comments to D18672: Properly clean up scopes when deregistering a subscriber..
Sat, Feb 2, 5:12 PM · KDE PIM
dfaure committed R165:a646904587fc: Fix aggregation logic for cacheOnly and ignoreErrors. (authored by dfaure).
Fix aggregation logic for cacheOnly and ignoreErrors.
Sat, Feb 2, 5:10 PM
dfaure closed D18670: Fix aggregation logic for cacheOnly and ignoreErrors..
Sat, Feb 2, 5:10 PM · KDE PIM
dfaure requested review of D18672: Properly clean up scopes when deregistering a subscriber..
Sat, Feb 2, 3:18 PM · KDE PIM
dfaure requested review of D18670: Fix aggregation logic for cacheOnly and ignoreErrors..
Sat, Feb 2, 3:14 PM · KDE PIM
dfaure added a comment to D12477: Add unit test to see that :/ files can work.

Right, this would fail if the part was not using QFile, indeed. Still, at the level of the KParts frameworks itself it's all fine ;)

Sat, Feb 2, 11:02 AM · Frameworks
dfaure accepted D12477: Add unit test to see that :/ files can work.
Sat, Feb 2, 11:00 AM · Frameworks
dfaure accepted D18638: Avoid using trimmed method.

A better name would be "hasOnlySpaces" (with the opposite return value), but OK.

Sat, Feb 2, 10:57 AM · Frameworks
dfaure committed R4:bbc3ec44fed5: Fix AkonadiStorageTest::shouldNotifyTagAdded() flakiness. (authored by dfaure).
Fix AkonadiStorageTest::shouldNotifyTagAdded() flakiness.
Sat, Feb 2, 10:55 AM
dfaure closed D18634: Fix AkonadiStorageTest::shouldNotifyTagAdded() flakiness..
Sat, Feb 2, 10:55 AM
dfaure closed D18089: KLauncher: handle processes exiting without error.

Pushed as https://commits.kde.org/kinit/c29988a97b3ae7abc0d196a1166eb16ee6c3fa95

Sat, Feb 2, 10:54 AM · Frameworks
dfaure accepted D18089: KLauncher: handle processes exiting without error.

Sorry for the delay

Sat, Feb 2, 10:54 AM · Frameworks
dfaure committed R303:c29988a97b3a: KLauncher: handle processes exiting without error (authored by ahmadsamir).
KLauncher: handle processes exiting without error
Sat, Feb 2, 10:54 AM
dfaure committed R239:264d63175f58: autotests: tab reordering is done with LMB these days, not MMB (authored by dfaure).
autotests: tab reordering is done with LMB these days, not MMB
Sat, Feb 2, 10:38 AM
dfaure committed R278:452f625ac317: autotests: fix it, since nobody else did, grmbl (authored by dfaure).
autotests: fix it, since nobody else did, grmbl
Sat, Feb 2, 10:38 AM
dfaure added a comment to D14927: KConfig: handle directory symlinks correctly..

ping?

Sat, Feb 2, 10:22 AM · Frameworks
dfaure added a comment to D9822: Add benchmarks for KDirWatch.

Hi Milian,

Sat, Feb 2, 10:19 AM · Frameworks