dfaure (David Faure)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (248 w, 12 h)
Availability
Available

Recent Activity

Yesterday

dfaure added a comment to D8773: Improve discoverability of drag-and-drop of toolbar actions.

That is excellent! But in the implementation, mind the "multiple kxmlgui-clients" use case, like konqueror or kdevelop (or kate I guess). It can make things tricky...
(you drop between two clients, how do you know which one should memorize the action into its kxmlgui file?)

Thu, Dec 5, 11:01 PM · Frameworks
dfaure accepted D25767: KAutoSaveFile: add a unit test to check max. filename length.
Thu, Dec 5, 10:50 PM · Frameworks
dfaure requested changes to D24489: KAutosaveFile not respecting maximum filename length.

Why is this not in the same commit as the related unittest, as is common practice?

Thu, Dec 5, 10:45 PM · Frameworks
dfaure added a comment to D8774: Show Configure Toolbars dialog as modal.

The description says this depends on D8773 which isn't approved.

Thu, Dec 5, 10:34 PM · Frameworks

Wed, Dec 4

dfaure added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Why does KRun duplicate all of the (new) code from DesktopExecParser, when DesktopExecParser is actually a helper class for KRun?
I would expect it to have solved all this already, unless I'm missing something about the various code paths.
The code you changed in krun.cpp was supposed to simply resolve desktop:/foo to file:///bleh but everything else about %u/%f is done by DesktopExecParser.

Wed, Dec 4, 11:14 PM · Frameworks
dfaure requested changes to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

OK, please give me a day or two to review this, it shouldn't go in before Saturday anyway so we have one month of testing in git before release

Wed, Dec 4, 11:45 AM · Frameworks
dfaure added a comment to T12256: Phase out KonqPopupMenu/Plugin service type.

Right, we are going too far. What we want to deprecate is desktop files pointing to c++ plugins.
And therefore the class that loads such plugins.

Wed, Dec 4, 7:59 AM · KF6
dfaure accepted D25420: [KFileWidget] Avoid calling slotOk right after the url changed.

No reconstructing-call-history-via-a-boolean-member, I like this! :-)

Wed, Dec 4, 12:06 AM · Frameworks
dfaure committed R230:2837e620c36c: Merge remote-tracking branch 'origin/release/19.12' (authored by dfaure).
Merge remote-tracking branch 'origin/release/19.12'
Wed, Dec 4, 12:03 AM
dfaure committed R230:8f2f329d8b24: Tobias Anton replied yes/yes/yes/yes/no, record that in the script. (authored by dfaure).
Tobias Anton replied yes/yes/yes/yes/no, record that in the script.
Wed, Dec 4, 12:00 AM

Tue, Dec 3

dfaure committed R230:d3f98c07dc24: Eike Hein said yes to all 5 questions, thanks! (authored by dfaure).
Eike Hein said yes to all 5 questions, thanks!
Tue, Dec 3, 11:54 PM
dfaure added a comment to D25420: [KFileWidget] Avoid calling slotOk right after the url changed.

So after a double-click, activated() is emitted, the boolean is set, and much later some Key_Enter event that should have been emitted, gets eaten?

Tue, Dec 3, 1:52 PM · Frameworks
dfaure accepted D25678: Document Notifiers setting.
Tue, Dec 3, 9:23 AM · Frameworks
dfaure requested changes to D25420: [KFileWidget] Avoid calling slotOk right after the url changed.
Tue, Dec 3, 8:42 AM · Frameworks
dfaure added a comment to D25420: [KFileWidget] Avoid calling slotOk right after the url changed.

I'm not smarter than you, but I consider this code hacky :-)

Tue, Dec 3, 8:42 AM · Frameworks
dfaure added a comment to T12004: Replacement of API Documentation System.

About your very first point: for information, lxr.kde.org also relies on kdesrc-build to check out all the relevant sources. This has been working rather well for many years, I don't see that as "unwanted coupling of tools".
But OK, the rest of your email makes that point moot anyway :-)

Tue, Dec 3, 8:39 AM · KF6, Sysadmin
dfaure accepted D25664: [WIP]: Port away from deprecated QSignalMapper.
Tue, Dec 3, 8:36 AM · Calligra: 3.0
dfaure accepted D25664: [WIP]: Port away from deprecated QSignalMapper.
Tue, Dec 3, 8:36 AM · Calligra: 3.0
dfaure accepted D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items.
Tue, Dec 3, 8:29 AM · Frameworks

Mon, Dec 2

dfaure accepted D25533: Deprecate KFileWidget::toolBar.

This patch itself is still correct though, of course.

Mon, Dec 2, 10:22 PM · Frameworks
dfaure added a comment to D25420: [KFileWidget] Avoid calling slotOk right after the url changed.

Urgh. bool members as used here to share state between methods, with the assumption that they're always called together and in a certain order, are very brittle.

Mon, Dec 2, 10:19 PM · Frameworks
dfaure added a comment to T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.

Wow I had never seen KIconUtils. This is very nice stuff (because very independent from anything else).

Mon, Dec 2, 10:11 PM · KF6
dfaure accepted D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items.
Mon, Dec 2, 10:09 PM · Frameworks
dfaure requested changes to D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items.

So many hardcoded numbers! Much better indeed.

Mon, Dec 2, 10:07 PM · Frameworks
dfaure committed R230:73c25112f7d2: Got 5 yes from Lukas Tinkl, thanks! (authored by dfaure).
Got 5 yes from Lukas Tinkl, thanks!
Mon, Dec 2, 10:01 PM
dfaure committed R230:1a4bd5778681: Got 5 "yes" from yurchor, thanks! (authored by dfaure).
Got 5 "yes" from yurchor, thanks!
Mon, Dec 2, 10:00 PM
dfaure updated the diff for D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader.

add missing "get" (this bug was in kmimetypetrader.h already, blatant proof of copy/pasting... ;-) )

Mon, Dec 2, 9:58 PM · Frameworks
dfaure requested review of D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader.
Mon, Dec 2, 9:37 PM · Frameworks
dfaure added a revision to T12175: KService: write ApplicationTrader: D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader.
Mon, Dec 2, 9:37 PM · KF6
dfaure added a comment to T12182: KService: deprecate KServiceTypeProfile.

https://lxr.kde.org/ident?_i=writeServiceTypeProfile&_remember=1 -> completely unused

Mon, Dec 2, 9:29 PM · KF6
dfaure created T12309: KService: deprecate/remove allowAsDefault.
Mon, Dec 2, 9:14 PM · KF6
dfaure accepted D24828: KRun: don't override user preferred app when opening local *.*html and co. files.

This makes perfect sense to me, thanks for the detailed analysis and the fix.

Mon, Dec 2, 9:01 PM · Frameworks
dfaure added a comment to D25664: [WIP]: Port away from deprecated QSignalMapper.

Then write your own, it's easy:

Mon, Dec 2, 3:19 PM · Calligra: 3.0
dfaure added reviewers for D25433: KActionCollection: provide a changed() signal as a replacement for removed(): vkrause, nicolasfella.
Mon, Dec 2, 12:23 PM · Frameworks
dfaure committed R230:1799e3bed5e3: Add more email aliases (authored by dfaure).
Add more email aliases
Mon, Dec 2, 12:06 AM

Sun, Dec 1

dfaure committed R230:adb52d563a69: Merge remote-tracking branch 'origin/release/19.12' (authored by dfaure).
Merge remote-tracking branch 'origin/release/19.12'
Sun, Dec 1, 11:56 PM
dfaure added a comment to T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.

OK then we could deprecate KDE::icon(1 arg), and keep KDE::icon(2 args)

Sun, Dec 1, 11:55 PM · KF6
dfaure committed R230:b71abe38f14c: Add alternate email address for schwarzer, needed for kplugininfo.h (authored by dfaure).
Add alternate email address for schwarzer, needed for kplugininfo.h
Sun, Dec 1, 11:53 PM
dfaure committed R230:cf92606928bb: Add alternate email address for arichardson, needed for kmimetypefactory_p.h (authored by dfaure).
Add alternate email address for arichardson, needed for kmimetypefactory_p.h
Sun, Dec 1, 11:46 PM
dfaure committed R318:89d53b98c735: GIT_SILENT remove unused include (authored by dfaure).
GIT_SILENT remove unused include
Sun, Dec 1, 11:44 PM
dfaure requested changes to D25664: [WIP]: Port away from deprecated QSignalMapper.
Sun, Dec 1, 10:55 PM · Calligra: 3.0
dfaure added a comment to T12285: KTextWidgets usage in KIO.

In my opinion it could be done, yes. The common plasma use case (linux distro desktop) installs everything and the specialized setups probably don't need the KCM, or can install it. On the other hand there's a ton of stuff we can do before branching for KF6, so we could also wait until after the branching for the move. We can't really change KIO's dependencies before that anyway.

Sun, Dec 1, 9:45 PM · KF6
dfaure added a comment to T12285: KTextWidgets usage in KIO.

I like the idea of moving the KCMs to kio-extras. They are indeed extra functionality.

Sun, Dec 1, 9:26 PM · KF6
dfaure added a comment to D24489: KAutosaveFile not respecting maximum filename length.

A unittest would be very welcome.

Sun, Dec 1, 7:32 PM · Frameworks
dfaure accepted D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag.

My head hurts a bit but I think I understand this now ;)

Sun, Dec 1, 7:27 PM · Build System, Frameworks
dfaure accepted D25662: Restore ability to close tab by clicking on close button.

Thanks for the fix, sorry for not noticing.

Sun, Dec 1, 5:59 PM
dfaure requested changes to D25572: [KFileWidget] Allow double quotes in filenames.

I think this needs more work, we lost some tolerance here, AFAICS.

Sun, Dec 1, 5:59 PM · Frameworks
dfaure committed R365:586c59aaa9df: libaccounts-glib switched to meson, remove old configure flag (authored by dfaure).
libaccounts-glib switched to meson, remove old configure flag
Sun, Dec 1, 5:22 PM
dfaure committed R1003:c5485c4f0d82: Merge remote-tracking branch 'origin/release/19.12' (authored by dfaure).
Merge remote-tracking branch 'origin/release/19.12'
Sun, Dec 1, 2:48 PM
dfaure added a comment to D25644: kitinerary: fix compilation with poppler >= 0.83.

It would help if I wasn't a complete idiot :)

Sun, Dec 1, 2:47 PM · KDE PIM
dfaure committed R1003:6256dde4aa53: Fix compilation with older poppler (authored by dfaure).
Fix compilation with older poppler
Sun, Dec 1, 2:42 PM
dfaure accepted D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.
Sun, Dec 1, 2:30 PM · Frameworks
dfaure requested changes to D25010: [StatJob] Use A QFlag to specify the details returned by StatJob.
Sun, Dec 1, 1:20 PM · Frameworks
dfaure added a comment to D25572: [KFileWidget] Allow double quotes in filenames.

Restarting kdeinit is only needed when making changes that affect kioslaves.
Here it's just about a widget, all you need is to start the application from a terminal.

Sun, Dec 1, 1:16 PM · Frameworks
dfaure abandoned D25643: Use PERL_EXECUTABLE on all platforms.
Sun, Dec 1, 1:04 PM · KDE PIM
dfaure added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

@ngraham AFAIK gnome has a trick where a fuse mount is created, its path is passed to the application being started, and the application, if it supports gvfs, re-translates that into a URL and uses that instead if it makes more sense. This way "dumb" apps get a local file (with all the limitations of doing synchronous I/O over the network) and network-transparent applications use URLs.
On the other hand, the KDE logic is "if the app takes %f and not %u in the Exec line, it doesn't support remote URLs, so we need to download the file first" (that's done by kioexec). If you see a "download first" check if kioexec is running. But if it's the app doing it, then I have no idea.

Sun, Dec 1, 12:45 PM · Frameworks
dfaure committed R230:e9ba3e47a188: Merge remote-tracking branch 'origin/release/19.12' (authored by dfaure).
Merge remote-tracking branch 'origin/release/19.12'
Sun, Dec 1, 12:28 PM
dfaure committed R230:4ec552f44f56: Add andreyc to relicensecheck.pl (authored by dfaure).
Add andreyc to relicensecheck.pl
Sun, Dec 1, 12:24 PM
dfaure committed R1003:880f1f806c94: Merge remote-tracking branch 'origin/release/19.12' (authored by dfaure).
Merge remote-tracking branch 'origin/release/19.12'
Sun, Dec 1, 12:16 PM
dfaure committed R1003:dfa6ca840994: kitinerary: fix compilation with poppler >= 0.83 (authored by dfaure).
kitinerary: fix compilation with poppler >= 0.83
Sun, Dec 1, 12:16 PM
dfaure closed D25644: kitinerary: fix compilation with poppler >= 0.83.
Sun, Dec 1, 12:15 PM · KDE PIM
dfaure accepted D25638: autotests: Find perl executable on all platforms.

I approve, given that I wrote the same in D25643 :-)

Sun, Dec 1, 12:14 PM · Frameworks, KDE PIM
dfaure committed R473:51fb0f61e988: Port away from deprecated KStartupInfo::setNewStartupId overload (authored by dfaure).
Port away from deprecated KStartupInfo::setNewStartupId overload
Sun, Dec 1, 2:55 AM
dfaure committed R32:d563e5caaeb3: Merge remote-tracking branch 'origin/5.4' (authored by dfaure).
Merge remote-tracking branch 'origin/5.4'
Sun, Dec 1, 2:54 AM
dfaure committed R32:2c3626955cd4: Fix compilation error with gcc 7.4.1, ambiguous overload (authored by dfaure).
Fix compilation error with gcc 7.4.1, ambiguous overload
Sun, Dec 1, 2:54 AM
dfaure closed D25639: Fix compilation error with gcc 7.4.1, ambiguous overload.
Sun, Dec 1, 2:54 AM · KDevelop
dfaure committed R121:c56dbfc84ab6: Port away from deprecated API in KWindowSystem (authored by dfaure).
Port away from deprecated API in KWindowSystem
Sun, Dec 1, 2:49 AM
dfaure committed R258:849ac4d0d716: Fix compilation with Qt 5.14, because of qmlRegisterType being deprecated (authored by dfaure).
Fix compilation with Qt 5.14, because of qmlRegisterType being deprecated
Sun, Dec 1, 2:46 AM
dfaure committed R424:f22eb4c7ca55: Merge remote-tracking branch 'origin/release/19.12' (authored by dfaure).
Merge remote-tracking branch 'origin/release/19.12'
Sun, Dec 1, 2:34 AM
dfaure committed R424:a8b7eecc7cee: Link with Qt5::Xml explicitly, so we don't rely on KConfigGui bringing it (authored by dfaure).
Link with Qt5::Xml explicitly, so we don't rely on KConfigGui bringing it
Sun, Dec 1, 2:32 AM
dfaure committed R365:2ae88f7b82cb: krita requires quazip, which uses Qt (authored by dfaure).
krita requires quazip, which uses Qt
Sun, Dec 1, 2:30 AM
dfaure added a comment to D25533: Deprecate KFileWidget::toolBar.

I started a kdesrc-build with the method removed, and found that KFileDialog::toolBar (in kdelibs4support) uses it, so it needs a matching #if in case EXCLUDE_DEPRECATED_BEFORE_AND_AT.

Sun, Dec 1, 2:13 AM · Frameworks
dfaure added a comment to D25644: kitinerary: fix compilation with poppler >= 0.83.

Note that calligra/filters/karbon/pdf/PdfImport.cpp is broken by this as well.

Sun, Dec 1, 1:56 AM · KDE PIM
dfaure requested review of D25644: kitinerary: fix compilation with poppler >= 0.83.
Sun, Dec 1, 1:54 AM · KDE PIM
dfaure requested review of D25643: Use PERL_EXECUTABLE on all platforms.
Sun, Dec 1, 1:29 AM · KDE PIM
dfaure committed R385:c526f949cf72: Move xmlgui file to a qrc resource, to simplify deployment (authored by dfaure).
Move xmlgui file to a qrc resource, to simplify deployment
Sun, Dec 1, 1:27 AM
dfaure committed R155:2910794a6855: Improve error handling in KAccountsMacros (authored by dfaure).
Improve error handling in KAccountsMacros
Sun, Dec 1, 1:24 AM
dfaure committed R7:0efede7857a8: Port to QElapsedTimer; remove unused default constructor (authored by dfaure).
Port to QElapsedTimer; remove unused default constructor
Sun, Dec 1, 1:11 AM

Sat, Nov 30

dfaure committed R494:14008a2040b0: Link to Qt5::Xml explicitly, one day this won't come via KConfigGui anymore (authored by dfaure).
Link to Qt5::Xml explicitly, one day this won't come via KConfigGui anymore
Sat, Nov 30, 11:03 PM
dfaure committed R331:f62549bdada2: Merge remote-tracking branch 'origin/release/19.12' (authored by dfaure).
Merge remote-tracking branch 'origin/release/19.12'
Sat, Nov 30, 10:36 PM
dfaure committed R331:27309d41b50f: Port away from deprecated QWheelEvent API. (authored by dfaure).
Port away from deprecated QWheelEvent API.
Sat, Nov 30, 10:36 PM
dfaure committed R228:d4a61d3777d4: Merge remote-tracking branch 'origin/release/19.12' (authored by dfaure).
Merge remote-tracking branch 'origin/release/19.12'
Sat, Nov 30, 10:30 PM
dfaure committed R228:587a1f1cdddf: Lower deprecation numbers to unbreak compilation with current KF5 (authored by dfaure).
Lower deprecation numbers to unbreak compilation with current KF5
Sat, Nov 30, 10:30 PM
dfaure requested review of D25639: Fix compilation error with gcc 7.4.1, ambiguous overload.
Sat, Nov 30, 9:42 PM · KDevelop
dfaure added a comment to T12240: Prefer QLineEdit/QComboBox over KLineEdit/KComboBox where KCompletion features are not needed.

Now that I see "The signals will still be emitted of course" I'm no longer sure.
Trapping sounds like the event is completely eaten and the signal isn't emitted.

Sat, Nov 30, 9:35 PM · KF6
dfaure added a comment to T12189: KDED: remove KService dependency.

We must keep compatibility, yes. That's the promise of KDE Frameworks. There *is* more KF5-based code outside lxr.kde.org.

Sat, Nov 30, 9:28 PM · KF6
dfaure added a comment to T12240: Prefer QLineEdit/QComboBox over KLineEdit/KComboBox where KCompletion features are not needed.

This is also a good candidate for upstreaming the feature into Qt... as QLineEdit::setTrapReturnKey for instance. Maybe we should try that first...

Sat, Nov 30, 4:46 PM · KF6
dfaure committed R325:c95e36f27248: Fix compilation with Qt 5.14 (authored by dfaure).
Fix compilation with Qt 5.14
Sat, Nov 30, 2:00 PM
dfaure added a comment to T12240: Prefer QLineEdit/QComboBox over KLineEdit/KComboBox where KCompletion features are not needed.

This could be done externally by an event filter.

Sat, Nov 30, 1:29 PM · KF6
dfaure committed R230:51030187d711: Merge remote-tracking branch 'origin/release/19.12' (authored by dfaure).
Merge remote-tracking branch 'origin/release/19.12'
Sat, Nov 30, 12:39 PM
dfaure committed R230:d533cee75055: Add michaeleden to relicensecheck.pl (authored by dfaure).
Add michaeleden to relicensecheck.pl
Sat, Nov 30, 12:38 PM
dfaure committed R230:a5579fb45888: Add myself (arichardson) to relicensecheck.pl (authored by arichardson).
Add myself (arichardson) to relicensecheck.pl
Sat, Nov 30, 12:35 PM
dfaure committed R230:582dd8f9916c: Add vladz to relicensecheck.pl (authored by zzag).
Add vladz to relicensecheck.pl
Sat, Nov 30, 12:35 PM
dfaure added a comment to D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path.

Hmmpf, indeed. I forgot about the objection I had here :)

Sat, Nov 30, 12:32 PM · Frameworks
dfaure committed R124:517463b55adb: Merge remote-tracking branch 'origin/Plasma/5.17' (authored by dfaure).
Merge remote-tracking branch 'origin/Plasma/5.17'
Sat, Nov 30, 12:10 PM
dfaure committed R124:32567d4f61b4: Unbreak build with Qt 5.14 (authored by dfaure).
Unbreak build with Qt 5.14
Sat, Nov 30, 12:10 PM
dfaure accepted D25561: Remove unused signal we can use directly "signal(const QUrl&).
Sat, Nov 30, 11:51 AM · Frameworks
dfaure committed R369:7768a7cdb9b1: Merge remote-tracking branch 'origin/release/19.12' (authored by dfaure).
Merge remote-tracking branch 'origin/release/19.12'
Sat, Nov 30, 10:43 AM
dfaure committed R369:54518b0bca8a: Port away from deprecated overload of slideWindow (authored by dfaure).
Port away from deprecated overload of slideWindow
Sat, Nov 30, 10:43 AM
dfaure committed R365:0f3cd33e4866: Remove simon, it was marked unmaintained (authored by dfaure).
Remove simon, it was marked unmaintained
Sat, Nov 30, 12:18 AM