dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (179 w, 6 d)
Availability
Available

Recent Activity

Today

dfaure committed R199:55bc370ff679: Merge branch 'Applications/18.08' (authored by dfaure).
Merge branch 'Applications/18.08'
Wed, Aug 15, 1:42 PM
dfaure committed R199:2793d34f8393: Implement filtering of notification types using KCheckComboBox. (authored by dfaure).
Implement filtering of notification types using KCheckComboBox.
Wed, Aug 15, 1:42 PM
dfaure requested review of D14861: KCheckComboBox: prefer a width that allows to read the complete lineedit text.
Wed, Aug 15, 1:42 PM · KDE PIM
dfaure added a comment to T9390: Next Gen MTP.

Here are the notes from the design discussion we had today about how to fix "two kioslaves accessing the same MTP device at the same time cannot work":

Wed, Aug 15, 8:54 AM · Frameworks

Yesterday

dfaure requested review of D14853: Don't fetch missing parts from the resource..
Tue, Aug 14, 11:00 PM · KDE PIM
dfaure committed R849:382cd5e0f91a: CMakeLists: use existing install path variable; honour BUILD_TESTING (authored by dfaure).
CMakeLists: use existing install path variable; honour BUILD_TESTING
Tue, Aug 14, 10:27 PM
dfaure closed D14833: CMakeLists: use existing install path variable; honour BUILD_TESTING.
Tue, Aug 14, 10:27 PM
dfaure committed R44:43a3b7a3f75e: Merge branch 'Applications/18.08' (authored by dfaure).
Merge branch 'Applications/18.08'
Tue, Aug 14, 10:26 PM
dfaure committed R44:6752a1697099: Fix gmail auth dialog popping up over and over again. (authored by dfaure).
Fix gmail auth dialog popping up over and over again.
Tue, Aug 14, 10:26 PM
dfaure committed R44:8e7dfb8696c8: Fix gmail auth dialog popping up over and over again. (authored by dfaure).
Fix gmail auth dialog popping up over and over again.
Tue, Aug 14, 10:26 PM
dfaure closed D14852: Fix gmail auth dialog popping up over and over again..
Tue, Aug 14, 10:26 PM · KDE PIM
dfaure committed R477:b0cb1d6fad12: Merge branch 'Applications/18.08' (authored by dfaure).
Merge branch 'Applications/18.08'
Tue, Aug 14, 10:12 PM
dfaure committed R477:2b138b37971c: gmail auth: return proper HTTP response to avoid qwebengine error (authored by dfaure).
gmail auth: return proper HTTP response to avoid qwebengine error
Tue, Aug 14, 10:12 PM
dfaure closed D14845: gmail auth: return proper HTTP response to avoid qwebengine error.
Tue, Aug 14, 10:11 PM · KDE PIM
dfaure committed R199:d9ad06b91549: Merge branch 'Applications/18.08' (authored by dfaure).
Merge branch 'Applications/18.08'
Tue, Aug 14, 9:30 PM
dfaure committed R199:f50d85eb5bb1: Add milliseconds to timestamps (authored by dfaure).
Add milliseconds to timestamps
Tue, Aug 14, 9:29 PM
dfaure requested review of D14852: Fix gmail auth dialog popping up over and over again..
Tue, Aug 14, 8:05 PM · KDE PIM
dfaure committed R477:12d61077135f: Fix typos (authored by dfaure).
Fix typos
Tue, Aug 14, 4:40 PM
dfaure requested review of D14845: gmail auth: return proper HTTP response to avoid qwebengine error.
Tue, Aug 14, 3:58 PM · KDE PIM
dfaure committed R165:a67a78b25e67: Merge branch 'Applications/18.08' (authored by dfaure).
Merge branch 'Applications/18.08'
Tue, Aug 14, 2:42 PM
dfaure committed R165:25709af97626: Fix warning due to deleteLater on null object (authored by dfaure).
Fix warning due to deleteLater on null object
Tue, Aug 14, 2:40 PM
dfaure committed R499:6d5d1ce55c2a: Remove kdepim-runtime dependency for messagelib, the serializers moved meanwhile (authored by dfaure).
Remove kdepim-runtime dependency for messagelib, the serializers moved meanwhile
Tue, Aug 14, 1:49 PM
dfaure requested review of D14833: CMakeLists: use existing install path variable; honour BUILD_TESTING.
Tue, Aug 14, 1:38 PM
dfaure committed R237:1bf473224a0b: Remove warning about old kiosk feature that no longer applies. (authored by dfaure).
Remove warning about old kiosk feature that no longer applies.
Tue, Aug 14, 12:54 PM
dfaure closed D14829: Remove warning about old kiosk feature that no longer applies..
Tue, Aug 14, 12:54 PM · Frameworks
dfaure requested review of D14829: Remove warning about old kiosk feature that no longer applies..
Tue, Aug 14, 12:34 PM · Frameworks
dfaure accepted D14798: Scope the glib hack to older Qt versions.

(I'd normally add spaces after commas in QT_VERSION_CHECK)

Tue, Aug 14, 9:07 AM · Konsole

Mon, Aug 13

dfaure accepted D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation..
Mon, Aug 13, 8:40 PM · Frameworks
dfaure added a comment to D7033: Port ki18n from QtScript to QtQml.

+1, looks good to me (but I'm no QJSEngine expert)

Mon, Aug 13, 1:13 PM · Frameworks
dfaure accepted D14674: handle non-ASCII encodings of file names in tar archives.

Excellent, thanks for the contribution.

Mon, Aug 13, 1:06 PM · Frameworks
dfaure requested changes to D14757: Warn user before copy operation if available space is not enough.
Mon, Aug 13, 1:03 PM · Frameworks
dfaure accepted D14772: Deprecate KFilterProxySearchLine.
Mon, Aug 13, 11:17 AM · Frameworks
dfaure accepted D14772: Deprecate KFilterProxySearchLine.

This class was doing it with a timer, I wonder if that should be part of the recommendation ("use QLineEdit with a timer"), or if we don't recommend delaying the searching as a general solution.
(e.g. another typical fix for the "I type one letter and the result is huge" issue is to require 3 letters).

Mon, Aug 13, 11:04 AM · Frameworks
dfaure committed R1007:a1363fb2f63e: Sort the list of countries in the combobox. (authored by dfaure).
Sort the list of countries in the combobox.
Mon, Aug 13, 10:55 AM
dfaure closed D14771: Sort the list of countries in the combobox..
Mon, Aug 13, 10:55 AM · KDE PIM

Sun, Aug 12

dfaure accepted D14754: KHolidays: Install headers according to the frameworks way.

Much better, thanks ;)

Sun, Aug 12, 3:13 PM · KDE PIM
dfaure requested review of D14771: Sort the list of countries in the combobox..
Sun, Aug 12, 2:53 PM · KDE PIM
dfaure committed R1007:c47772e49de6: KPimItinerary 5.9.40 is required for the Event header. (authored by dfaure).
KPimItinerary 5.9.40 is required for the Event header.
Sun, Aug 12, 1:57 PM
dfaure added a comment to D14754: KHolidays: Install headers according to the frameworks way.

Depends whether you want people to #include <Zodiac> (and zodiac.h) (the KArchive solution) or to #include <KHolidays/Zodiac> (and kholidays/zodiac.h) (the KParts solution, i.e. with namespace)

Sun, Aug 12, 1:35 PM · KDE PIM
dfaure committed R241:d766661faba3: Port KPATH_SEPARATOR "hack" to QDir::listSeparator, added in Qt 5.6 (authored by dfaure).
Port KPATH_SEPARATOR "hack" to QDir::listSeparator, added in Qt 5.6
Sun, Aug 12, 1:11 PM
dfaure committed R244:0c7bd81751ff: KPluginLoader: use '/' even on Windows, libraryPaths() returns paths with '/' (authored by dfaure).
KPluginLoader: use '/' even on Windows, libraryPaths() returns paths with '/'
Sun, Aug 12, 11:28 AM
dfaure added a comment to D14757: Warn user before copy operation if available space is not enough.

Yes, Pino is right. Trust Pino ;)

Sun, Aug 12, 11:23 AM · Frameworks
dfaure added a comment to D14707: autotests: skip '/' fstab check with zfs.

The check is trying to verify that possibleMountPoints() works, by picking a mount point that we know has to exist, the root mount point. Anything else is hard to rely on, in a unittest ;)
At least that was the logic in the old days, before all this magic that circumvents having entries in fstab...

Sun, Aug 12, 11:12 AM · Frameworks
dfaure added a comment to D14757: Warn user before copy operation if available space is not enough.

Ah, hmm, my suggestion would allow to display a warning messagebox, but not to offer "continue/cancel" type of interaction.

Sun, Aug 12, 11:03 AM · Frameworks
dfaure committed R495:b33583e7ea55: autotests: use QTemporaryDir instead of a hardcoded filename (authored by dfaure).
autotests: use QTemporaryDir instead of a hardcoded filename
Sun, Aug 12, 10:57 AM
dfaure added a comment to D14757: Warn user before copy operation if available space is not enough.

You can just emit the warning signal, from the job.

Sun, Aug 12, 10:07 AM · Frameworks
dfaure committed R241:896548793b8c: autotests: add debug output for kioslave lookup to debug CI failure (authored by dfaure).
autotests: add debug output for kioslave lookup to debug CI failure
Sun, Aug 12, 9:46 AM
dfaure requested changes to D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation..
Sun, Aug 12, 9:45 AM · Frameworks
dfaure committed R244:13834d9788c2: autotests: add debug output for plugin dirs, to investigate Purpose CI on… (authored by dfaure).
autotests: add debug output for plugin dirs, to investigate Purpose CI on…
Sun, Aug 12, 9:27 AM
dfaure requested changes to D14674: handle non-ASCII encodings of file names in tar archives.

Great job, thanks for the unittest.

Sun, Aug 12, 9:13 AM · Frameworks
dfaure added a comment to D14754: KHolidays: Install headers according to the frameworks way.

I'm confused by the removal of PREFIX.

Sun, Aug 12, 9:03 AM · KDE PIM

Sat, Aug 11

dfaure committed R497:f5e766582ece: ++ version number (authored by dfaure).
++ version number
Sat, Aug 11, 2:06 PM
dfaure committed R497:47f245f7bd96: exclude one more type of commit (authored by dfaure).
exclude one more type of commit
Sat, Aug 11, 2:06 PM
dfaure requested changes to D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation..
Sat, Aug 11, 1:12 PM · Frameworks
dfaure committed R883:1522362: KF 5.49.
KF 5.49
Sat, Aug 11, 10:15 AM
dfaure committed R883:1522361: add frameworks-5.49.0 to generate_release_data.py.
add frameworks-5.49.0 to generate_release_data.py
Sat, Aug 11, 10:10 AM
dfaure committed R309:32fdecea9cc4: autotests: debug output for CI failure, or for general debugging (authored by dfaure).
autotests: debug output for CI failure, or for general debugging
Sat, Aug 11, 10:01 AM
dfaure committed R309:5444c53db205: autotests: rename header and function to match new purpose (authored by dfaure).
autotests: rename header and function to match new purpose
Sat, Aug 11, 9:40 AM
dfaure committed R309:95d8a5382580: autotests: also copy applications.menu and set XDG_CONFIG_DIRS so it's found (authored by dfaure).
autotests: also copy applications.menu and set XDG_CONFIG_DIRS so it's found
Sat, Aug 11, 9:40 AM

Fri, Aug 10

dfaure committed R309:42fd88fbc5f1: KBuildSycoca: always process application desktop files. (authored by dfaure).
KBuildSycoca: always process application desktop files.
Fri, Aug 10, 8:11 PM
dfaure committed R309:9db7c4e2008f: autotests: factorize XDG_DATA_DIRS setup in new header, use from 3rd test (authored by dfaure).
autotests: factorize XDG_DATA_DIRS setup in new header, use from 3rd test
Fri, Aug 10, 8:10 PM
dfaure added a comment to R241:02087a39d95a: autotests: fix compilation.
Fri, Aug 10, 8:09 PM
dfaure committed R309:a18ea0d20bd4: autotests: don't wait for signal if we already received it (e.g. Windows CI) (authored by dfaure).
autotests: don't wait for signal if we already received it (e.g. Windows CI)
Fri, Aug 10, 2:48 PM
dfaure committed R308:b88b1332200b: autotests: ensure Plasma/Runner servicetype is found in CI (authored by dfaure).
autotests: ensure Plasma/Runner servicetype is found in CI
Fri, Aug 10, 2:43 PM
dfaure committed R309:f726f9d190da: autotests: fix failure on Windows, QStringLiteral isn't fromUtf8 there... (authored by dfaure).
autotests: fix failure on Windows, QStringLiteral isn't fromUtf8 there...
Fri, Aug 10, 2:23 PM
dfaure committed R309:8381ebe09f30: autotests: use data/kservicetypes5 instead of share, so it works on Windows too (authored by dfaure).
autotests: use data/kservicetypes5 instead of share, so it works on Windows too
Fri, Aug 10, 2:14 PM
dfaure committed R309:34cec8ac870f: autotests: use local servicetype desktop files in kservicetest as well (authored by dfaure).
autotests: use local servicetype desktop files in kservicetest as well
Fri, Aug 10, 11:30 AM
dfaure committed R309:77e62f074df5: autotests: use local copies of kplugininfo.desktop and application.desktop (authored by dfaure).
autotests: use local copies of kplugininfo.desktop and application.desktop
Fri, Aug 10, 11:23 AM
dfaure committed R241:02087a39d95a: autotests: fix compilation (authored by dfaure).
autotests: fix compilation
Fri, Aug 10, 10:42 AM
dfaure added a comment to D14723: Add option to disable KWallet entirely in the new wallet dialog.

+1, looks good to me (I just wonder how well KDE applications actually behave with KWallet disabled...)

Fri, Aug 10, 10:34 AM · Frameworks
dfaure committed R244:6be0ee1d0e6e: KPluginMetaData: convert empty string to empty stringlist. (authored by dfaure).
KPluginMetaData: convert empty string to empty stringlist.
Fri, Aug 10, 10:13 AM
dfaure closed D14722: KPluginMetaData: convert empty string to empty stringlist..
Fri, Aug 10, 10:13 AM · Frameworks
dfaure requested review of D14724: autotests: don't fail if an unrelated window shows up..
Fri, Aug 10, 10:09 AM · Frameworks
dfaure committed R290:906bf2db4173: autotests: plasmoidpackagetest fails when run in parallel to others (authored by dfaure).
autotests: plasmoidpackagetest fails when run in parallel to others
Fri, Aug 10, 9:56 AM
dfaure requested review of D14722: KPluginMetaData: convert empty string to empty stringlist..
Fri, Aug 10, 9:55 AM · Frameworks

Thu, Aug 9

dfaure committed R495:9755f5e9f574: autotests: remove dependency on klauncher, in the hope to fix Windows CI (authored by dfaure).
autotests: remove dependency on klauncher, in the hope to fix Windows CI
Thu, Aug 9, 7:20 PM
dfaure committed R355:c7009c8c1a11: Merge branch 'Applications/18.08' (authored by dfaure).
Merge branch 'Applications/18.08'
Thu, Aug 9, 5:13 PM
dfaure committed R355:c41cba9e8091: the default setting for kf5.kcoreaddons.desktopparser is actually Warning (authored by dfaure).
the default setting for kf5.kcoreaddons.desktopparser is actually Warning
Thu, Aug 9, 5:11 PM
dfaure committed R239:c3fe9344a8e7: Fix compilation without openssl headers (authored by dfaure).
Fix compilation without openssl headers
Thu, Aug 9, 2:45 PM
dfaure closed D14457: Forward-declare X509 structure.

Fix pushed as https://commits.kde.org/kdelibs4support/c3fe9344a8e7be1347e97523da19b5395ce9b3db

Thu, Aug 9, 2:24 PM · Frameworks
dfaure added a comment to D14707: autotests: skip '/' fstab check with zfs.

OK maybe I misunderstood the comment "Welcome to the wondeful world of / on zfs with boot-environments :)."

Thu, Aug 9, 1:18 PM · Frameworks
dfaure committed R290:e34246957ae0: GIT_SILENT fix compilation on CI (authored by dfaure).
GIT_SILENT fix compilation on CI
Thu, Aug 9, 1:06 PM
dfaure committed R309:b968a70454a6: GIT_SILENT add qDebug for CI failure (authored by dfaure).
GIT_SILENT add qDebug for CI failure
Thu, Aug 9, 12:24 PM
dfaure accepted D14457: Forward-declare X509 structure.

OK, now we're getting somewhere.
If ssl-dev isn't installed, this code is compiled without SSL support, and fails

Thu, Aug 9, 12:20 PM · Frameworks
dfaure added a comment to D14707: autotests: skip '/' fstab check with zfs.

Yes it does, and that's where I get the "zfs" information from.

Thu, Aug 9, 12:14 PM · Frameworks
dfaure accepted D14689: [KFileItem] Don't read directory comment on slow mounts.

Yep, exactly.

Thu, Aug 9, 12:12 PM · Frameworks
dfaure committed R290:27cb9c83c16e: autotests: handle /home being a symlink on the FreeBSD CI (authored by dfaure).
autotests: handle /home being a symlink on the FreeBSD CI
Thu, Aug 9, 11:38 AM
dfaure requested review of D14707: autotests: skip '/' fstab check with zfs.
Thu, Aug 9, 11:13 AM · Frameworks
dfaure added a comment to D9387: Add cross compile support for kconfig_compiler and kconf_update..

That doesn't mean it's the right solution :-)

Thu, Aug 9, 10:58 AM · Frameworks
dfaure added a comment to D14457: Forward-declare X509 structure.

The reason I don't like it, is that X509 isn't a class ;-)

Thu, Aug 9, 10:33 AM · Frameworks
dfaure accepted D14704: Don't define WebEnginePartCookieJar::filterCookie for old versions of Qt.
Thu, Aug 9, 10:05 AM
dfaure accepted D13743: Migrate build system to use find_package in autotests/ki18n_install.

Ah, I see. This fails indeed:

CMake Error at CMakeLists.txt:4 (include):
  include could not find load file:
Thu, Aug 9, 9:52 AM · Frameworks
dfaure committed R241:5406689d7d03: autotests: FreeBSD really makes tiny directories (authored by dfaure).
autotests: FreeBSD really makes tiny directories
Thu, Aug 9, 9:46 AM
dfaure committed R241:0e1dbd1f14f5: autotests: follow symlink if /home is one, might help on FreeBSD (authored by dfaure).
autotests: follow symlink if /home is one, might help on FreeBSD
Thu, Aug 9, 9:46 AM
dfaure committed R495:dc515b52f6fc: Use a temp dir so that an existing /tmp/purposetest file doesn't break the test. (authored by dfaure).
Use a temp dir so that an existing /tmp/purposetest file doesn't break the test.
Thu, Aug 9, 9:34 AM
dfaure committed R495:c480fa214b50: autotests: actually disable copyjob debug output in CI (authored by dfaure).
autotests: actually disable copyjob debug output in CI
Thu, Aug 9, 9:34 AM
dfaure added a comment to D14591: Implement a basic way to see the project for a task in the workday.

Depends on the query part. It doesn't have to list the whole collection, it could just fetch the single item + ancestors and then return a list containing just the top most ancestor. Your predicate could then just return true if said parent was indeed a project. That fetch should not be expensive since in the current design it'll go through the cache anyway.

Thu, Aug 9, 9:28 AM
dfaure added a comment to D14379: Synchronize cookies between QWebEngine and KCookieServer.

This commit seems to break CI with Qt 5.9, please check

Thu, Aug 9, 9:18 AM
dfaure committed R241:a307ab856858: autotests: fix random failure of lastModified check in kfileitemtest (authored by dfaure).
autotests: fix random failure of lastModified check in kfileitemtest
Thu, Aug 9, 9:01 AM
dfaure added inline comments to D14689: [KFileItem] Don't read directory comment on slow mounts.
Thu, Aug 9, 7:51 AM · Frameworks