dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (141 w, 3 d)
Availability
Available

Recent Activity

Yesterday

dfaure created D8908: KDateComboBox: fix dateChanged() not emitted after typing a date.
Sun, Nov 19, 11:45 PM · Frameworks
dfaure committed R236:6211436a7c58: KDateComboBox: port to Qt5 connect syntax, remove Q_PRIVATE_SLOTs. (authored by dfaure).
KDateComboBox: port to Qt5 connect syntax, remove Q_PRIVATE_SLOTs.
Sun, Nov 19, 11:38 PM
dfaure committed R236:efa35f021100: autotests: replace member with local scoped pointer (authored by dfaure).
autotests: replace member with local scoped pointer
Sun, Nov 19, 5:09 PM
dfaure committed R355:deb8f2c6b8f8: Merge branch 'Applications/17.12' (authored by dfaure).
Merge branch 'Applications/17.12'
Sun, Nov 19, 4:45 PM
dfaure committed R355:9ff8b0388148: Debug goes above Info. (authored by dfaure).
Debug goes above Info.
Sun, Nov 19, 4:45 PM

Sat, Nov 18

dfaure added dependencies for D8885: KMail: enable reordering of favorites: D8884: Implement reordering of favorite folders using DnD, D8883: EntityOrderProxyModel: adapt base class for reordering favorites.
Sat, Nov 18, 12:49 PM · KDE PIM
dfaure added a dependent revision for D8883: EntityOrderProxyModel: adapt base class for reordering favorites: D8885: KMail: enable reordering of favorites.
Sat, Nov 18, 12:49 PM · KDE PIM
dfaure added a dependent revision for D8884: Implement reordering of favorite folders using DnD: D8885: KMail: enable reordering of favorites.
Sat, Nov 18, 12:49 PM · KDE PIM
dfaure created D8885: KMail: enable reordering of favorites.
Sat, Nov 18, 12:49 PM · KDE PIM
dfaure created D8884: Implement reordering of favorite folders using DnD.
Sat, Nov 18, 12:47 PM · KDE PIM
dfaure created D8883: EntityOrderProxyModel: adapt base class for reordering favorites.
Sat, Nov 18, 12:40 PM · KDE PIM

Fri, Nov 17

dfaure committed R165:812cb3516f87: Remove unused testdata file, testdata-res*.xml is used instead. (authored by dfaure).
Remove unused testdata file, testdata-res*.xml is used instead.
Fri, Nov 17, 11:45 PM
dfaure committed R206:6bfc311c7b01: Fix compilation (authored by dfaure).
Fix compilation
Fri, Nov 17, 8:28 AM

Thu, Nov 16

dfaure added a comment to D7569: [kmcomposerwin] Save configuration on composer window close.

Can you push this to Applications/17.12? Laurent is on vacations, and I'd like to have the fix in that release, with time to test it before the actual release.

Thu, Nov 16, 10:13 PM · KDE PIM, KDE PIM: KMail
dfaure accepted D8841: Fix build on FreeBSD.

Weird, I wonder what's the relation with FreeBSD :) Compiler, I guess...

Thu, Nov 16, 11:50 AM · Frameworks
dfaure accepted D8836: Fix KIO::mkpath with qtbase 5.10 beta 4.
Thu, Nov 16, 10:54 AM · Frameworks
dfaure added inline comments to D8836: Fix KIO::mkpath with qtbase 5.10 beta 4.
Thu, Nov 16, 10:28 AM · Frameworks
dfaure added a comment to D8837: Fix testtrash with qtbase 5.10 beta 4.

More seriously, this could be a reason for adding QUrl::addPath(), like we had in KUrl.

Thu, Nov 16, 10:01 AM · Frameworks
dfaure added a comment to D8837: Fix testtrash with qtbase 5.10 beta 4.

Maybe we need a KUrl class :-)
Just kidding.

Thu, Nov 16, 10:01 AM · Frameworks
dfaure accepted D8837: Fix testtrash with qtbase 5.10 beta 4.
Thu, Nov 16, 10:01 AM · Frameworks
dfaure accepted D8836: Fix KIO::mkpath with qtbase 5.10 beta 4.

Urgh. That QUrl change doesn't make things easy for this type of code indeed.

Thu, Nov 16, 9:48 AM · Frameworks
dfaure added a reviewer for D8836: Fix KIO::mkpath with qtbase 5.10 beta 4: thiago.
Thu, Nov 16, 9:47 AM · Frameworks

Wed, Nov 15

dfaure added a comment to D8623: Use QtConcurrent for populating mime type list.

isNull() does quite some filesystem lookup at least, yes.

Wed, Nov 15, 11:48 AM
dfaure added a comment to D8623: Use QtConcurrent for populating mime type list.

I just found it's a combo, so actually only one item is visible, which makes it even more weird that it would need to do much with the other icons upfront.

Wed, Nov 15, 11:36 AM
dfaure added a comment to D8623: Use QtConcurrent for populating mime type list.

I thought QIcon::fromTheme itself did nothing and the lookup was done on demand. But maybe addItem does trigger this indeed, which makes sense for visible items at least... setUniformHeights or something might help so it doesn't query each icon for size?

Wed, Nov 15, 11:35 AM
dfaure accepted D8625: Fix Save As feature.
Wed, Nov 15, 11:12 AM
dfaure added inline comments to D8625: Fix Save As feature.
Wed, Nov 15, 11:00 AM
dfaure accepted D7440: Turn on Dolphin icon previews by default.
Wed, Nov 15, 8:34 AM · Dolphin
dfaure added a comment to D8625: Fix Save As feature.

You should prefer mimetype filters, so that more extensions and magic-mimetype-determination works.
text/html and text/plain should do the job just fine, no?

Wed, Nov 15, 8:02 AM
dfaure accepted D8624: Add separator between special mime types and mime type list.
Wed, Nov 15, 8:01 AM
dfaure added a comment to D8421: Port the dict applet to KF5 and QtQuick 2.

Have you added it to the panel?

Wed, Nov 15, 8:00 AM · Plasma
dfaure committed R499:1fafa0e575f4: blogilo is now unmaintained (authored by dfaure).
blogilo is now unmaintained
Wed, Nov 15, 7:59 AM
dfaure accepted D8434: Created 'remote' section.
Wed, Nov 15, 7:57 AM · Frameworks
dfaure added inline comments to D8623: Use QtConcurrent for populating mime type list.
Wed, Nov 15, 7:56 AM

Tue, Nov 14

dfaure requested changes to D8623: Use QtConcurrent for populating mime type list.

This commit is full of race conditions. Writing to a memory location from a thread and reading from that memory location from another thread, with no synchronization mechanism, is a data race, which is undefined behavior.

Tue, Nov 14, 10:45 PM
dfaure created D8818: Use EntityCollectionOrderProxyModel for filtering folders..
Tue, Nov 14, 1:44 PM · KDE PIM
dfaure created D8817: Port zanshin to QDateTime, as used by the Applications/17.12 kcalcore API..
Tue, Nov 14, 1:08 PM
dfaure committed R165:a2787d076ffb: Merge branch 'Applications/17.12' (authored by dfaure).
Merge branch 'Applications/17.12'
Tue, Nov 14, 10:41 AM
dfaure committed R499:a80a1aedaaa9: Switch stable to Applications/17.12, sync deps with dependency-data-kf5-qt5 (authored by dfaure).
Switch stable to Applications/17.12, sync deps with dependency-data-kf5-qt5
Tue, Nov 14, 10:40 AM
dfaure closed D8812: Switch stable to Applications/17.12, sync deps with dependency-data-kf5-qt5.
Tue, Nov 14, 10:40 AM
dfaure committed R165:40252aae3c79: Simplify FavoriteCollectionsModel: inherit KSelectionProxyModel (authored by dfaure).
Simplify FavoriteCollectionsModel: inherit KSelectionProxyModel
Tue, Nov 14, 10:37 AM
dfaure closed D8802: Simplify FavoriteCollectionsModel: inherit KSelectionProxyModel.
Tue, Nov 14, 10:37 AM · KDE PIM
dfaure committed R165:c5a31c8d3257: Enable recursive filtering in EntityOrderProxyModel (authored by dfaure).
Enable recursive filtering in EntityOrderProxyModel
Tue, Nov 14, 10:36 AM
dfaure closed D8799: Enable recursive filtering in EntityOrderProxyModel.
Tue, Nov 14, 10:36 AM · KDE PIM
dfaure committed R165:8bffff2813a6: StandardActionManager: allow using a proxy on top of FavoriteCollectionsModel (authored by dfaure).
StandardActionManager: allow using a proxy on top of FavoriteCollectionsModel
Tue, Nov 14, 10:33 AM
dfaure closed D8803: StandardActionManager: allow using a proxy on top of FavoriteCollectionsModel.
Tue, Nov 14, 10:32 AM · KDE PIM
dfaure updated the diff for D8812: Switch stable to Applications/17.12, sync deps with dependency-data-kf5-qt5.

Leave qt4 untouched.

Tue, Nov 14, 8:34 AM
dfaure created D8812: Switch stable to Applications/17.12, sync deps with dependency-data-kf5-qt5.
Tue, Nov 14, 8:24 AM
dfaure committed R845:7e214a05acce: Merge branch 'Plasma/5.11' (authored by dfaure).
Merge branch 'Plasma/5.11'
Tue, Nov 14, 8:19 AM
dfaure committed R845:df32c16850e6: Enable -DQT_NO_URL_CAST_FROM_STRING and fix compilation. (authored by dfaure).
Enable -DQT_NO_URL_CAST_FROM_STRING and fix compilation.
Tue, Nov 14, 8:18 AM
dfaure accepted D8640: [KDirModel] Emit change for HasJobRole when jobs change.
Tue, Nov 14, 8:11 AM · Frameworks
dfaure committed R325:2ef40170e59e: Enable -DQT_NO_CAST_TO_ASCII and fix compilation with it (authored by dfaure).
Enable -DQT_NO_CAST_TO_ASCII and fix compilation with it
Tue, Nov 14, 8:09 AM

Mon, Nov 13

dfaure committed R165:edfca539a91c: Rename debug category for consistency, and add it to categories file. (authored by dfaure).
Rename debug category for consistency, and add it to categories file.
Mon, Nov 13, 9:31 PM
dfaure committed R165:b663c2f91d52: Fix EntityOrderProxyModel::setOrderConfig signature (authored by dfaure).
Fix EntityOrderProxyModel::setOrderConfig signature
Mon, Nov 13, 9:31 PM
dfaure created D8803: StandardActionManager: allow using a proxy on top of FavoriteCollectionsModel.
Mon, Nov 13, 9:20 PM · KDE PIM
dfaure created D8802: Simplify FavoriteCollectionsModel: inherit KSelectionProxyModel.
Mon, Nov 13, 9:18 PM · KDE PIM
dfaure created D8799: Enable recursive filtering in EntityOrderProxyModel.
Mon, Nov 13, 7:05 PM · KDE PIM
dfaure committed R165:f9887d2f24f0: Fix EntityOrderProxyModel::setOrderConfig signature (authored by dfaure).
Fix EntityOrderProxyModel::setOrderConfig signature
Mon, Nov 13, 7:02 PM
dfaure closed D8783: Fix EntityOrderProxyModel::setOrderConfig signature.
Mon, Nov 13, 7:02 PM · KDE PIM
dfaure accepted D7569: [kmcomposerwin] Save configuration on composer window close.
Mon, Nov 13, 9:05 AM · KDE PIM, KDE PIM: KMail
dfaure created D8783: Fix EntityOrderProxyModel::setOrderConfig signature.
Mon, Nov 13, 8:13 AM · KDE PIM
dfaure committed R165:8c51fbac4b79: Rename debug category for consistency, and add it to categories file. (authored by dfaure).
Rename debug category for consistency, and add it to categories file.
Mon, Nov 13, 8:11 AM
dfaure closed D8778: Rename debug category for consistency, and add it to categories file..
Mon, Nov 13, 8:11 AM · KDE PIM

Sun, Nov 12

dfaure created D8778: Rename debug category for consistency, and add it to categories file..
Sun, Nov 12, 9:44 PM · KDE PIM
dfaure committed R497:70b1bc2aab38: up version (authored by dfaure).
up version
Sun, Nov 12, 8:03 PM
dfaure accepted D8767: Fix translation of toolbar name when it has i18n context.
Sun, Nov 12, 6:39 PM · Frameworks
dfaure committed R497:8b0a0a14319b: Fix "- " in changelog entry (authored by dfaure).
Fix "- " in changelog entry
Sun, Nov 12, 6:30 PM
dfaure accepted D8774: Show Configure Toolbars dialog as modal.
Sun, Nov 12, 6:20 PM · Frameworks
dfaure added a comment to D8773: Improve discoverability of drag-and-drop of toolbar actions.

I like the idea.

Sun, Nov 12, 6:18 PM · Frameworks

Sat, Nov 11

dfaure committed R883:1503982: KF 5.40.
KF 5.40
Sat, Nov 11, 9:54 AM
dfaure committed R883:1503981: add frameworks-5.40.0 to generate_release_data.py.
add frameworks-5.40.0 to generate_release_data.py
Sat, Nov 11, 9:53 AM
dfaure added a comment to D8697: Don't check whether an empty filename exists.

Personally, I don't find a check in QFile/QFileInfo "much cleaner". It's an invalid call, arguably. So checking here makes sense.

Sat, Nov 11, 9:29 AM · Frameworks
dfaure committed R773:027792744ea0: Fix loading of tips (authored by dfaure).
Fix loading of tips
Sat, Nov 11, 9:27 AM
dfaure committed R773:afa73e432b5e: Fix porting of findAllResources() (authored by dfaure).
Fix porting of findAllResources()
Sat, Nov 11, 9:13 AM
dfaure committed R773:4788dc491618: Fix crash when reply is nullptr (authored by dfaure).
Fix crash when reply is nullptr
Sat, Nov 11, 9:03 AM
dfaure accepted D6281: Prevent folders from drag and dropping onto themselves in dolphin main view.
Sat, Nov 11, 8:27 AM · Dolphin
dfaure added inline comments to D8332: Added baloo urls into places model.
Sat, Nov 11, 8:20 AM · Frameworks

Thu, Nov 9

dfaure added a comment to D8705: Remove Qt5::Widgets as a dependency.

Qt doesn't have files like KF5WindowSystemConfig.cmake.in :)

Thu, Nov 9, 1:15 PM · Frameworks
dfaure committed R165:8dd8613455c2: FavoriteCollectionsModel: don't use parent().child(). (authored by dfaure).
FavoriteCollectionsModel: don't use parent().child().
Thu, Nov 9, 6:42 AM
dfaure closed D8693: FavoriteCollectionsModel: don't use parent().child()..
Thu, Nov 9, 6:41 AM · KDE PIM
dfaure requested changes to D8705: Remove Qt5::Widgets as a dependency.

That is indeed source incompatible (apart from the change to the _p.h headers). You can either just add a "TODO KF6" comment, or provide a cmake option for linking to QtWidgets, but it needs to be on by default to keep source compat.

Thu, Nov 9, 6:37 AM · Frameworks
dfaure committed R773:2329b7e2f2b4: include KDECMakeSettings so that the RPATH is set (authored by dfaure).
include KDECMakeSettings so that the RPATH is set
Thu, Nov 9, 6:31 AM
dfaure committed R773:343c59be0966: Fix cmake warning about icon file names (authored by dfaure).
Fix cmake warning about icon file names
Thu, Nov 9, 6:27 AM

Wed, Nov 8

dfaure committed R241:c3ec3e9609f0: Oops, didn't intend to commit this (authored by dfaure).
Oops, didn't intend to commit this
Wed, Nov 8, 1:55 PM
dfaure added inline comments to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
Wed, Nov 8, 12:41 PM · Frameworks
dfaure accepted D8683: Only prevent the name to update if it's empty.
Wed, Nov 8, 7:01 AM · Frameworks
dfaure requested changes to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.
Wed, Nov 8, 6:36 AM · Frameworks
dfaure added a comment to D8056: Improve usability of "Open With" dialog by adding option to filter the application tree.

Yes, feel free to kill the hidden setting for completion, especially if the default value isn't the one that gives the best user experience.

Wed, Nov 8, 6:30 AM · Frameworks
dfaure accepted D8696: Don't autoremove empty temp file.
Wed, Nov 8, 6:26 AM · Frameworks
dfaure accepted D8697: Don't check whether an empty filename exists.
Wed, Nov 8, 6:21 AM · Frameworks

Tue, Nov 7

dfaure created D8693: FavoriteCollectionsModel: don't use parent().child()..
Tue, Nov 7, 1:18 PM · KDE PIM
dfaure committed R165:f8ab56df5270: FavoriteCollectionsModel: fix handling of dataChanged and rowsInserted (authored by dfaure).
FavoriteCollectionsModel: fix handling of dataChanged and rowsInserted
Tue, Nov 7, 1:16 PM

Mon, Nov 6

dfaure requested changes to D8546: Add Aztec code generator.
Mon, Nov 6, 4:42 PM · Frameworks
dfaure added a comment to D8671: KEmoticons: port plugins to JSON and add support for loading with KPluginMetaData.

The KCM uses KServiceTypeTrader so we still need the desktop files.

Mon, Nov 6, 6:04 AM · Frameworks

Sun, Nov 5

dfaure created D8671: KEmoticons: port plugins to JSON and add support for loading with KPluginMetaData.
Sun, Nov 5, 9:55 PM · Frameworks
dfaure requested changes to D6281: Prevent folders from drag and dropping onto themselves in dolphin main view.
Sun, Nov 5, 9:47 PM · Dolphin
dfaure added inline comments to D8332: Added baloo urls into places model.
Sun, Nov 5, 9:28 PM · Frameworks
dfaure requested changes to D8434: Created 'remote' section.
Sun, Nov 5, 9:19 PM · Frameworks
dfaure accepted D8461: Remove unused config.h.cmake entries.

The answer to "I'm not sure why" is easy: git log -S MALLOC shows exactly two commits, the one that introduced the usage of this stuff, and the one that removed it again. Ain't git great?

Sun, Nov 5, 9:11 PM · Frameworks
dfaure committed R39:d6fc0b782046: Fix: Missing dependencies for ktexeditor autotests (authored by hgoebel).
Fix: Missing dependencies for ktexeditor autotests
Sun, Nov 5, 9:01 PM