dfaure (David Faure)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (289 w, 3 d)
Availability
Available

Recent Activity

Sun, Sep 13

dfaure added a comment to T12286: Move things needed to provide FileItemActionPlugins into a low tier.

We need to decide on what KIO is.
Some people think "if I don't need kioslaves, I shouldn't have to use KIO".
But another line of reasoning is "if you want to do any sort of file-management stuff with URLs, files, dirs, mimetypes, then KIO[Core] is what you want". KFileItem, KFileItemListPropreties, KFileItemActionPlugins... this all fits into this definition.
Where else would one put KFileItem and KFileItemListProperties?

Sun, Sep 13, 11:42 AM · KF6
dfaure moved T12364: Cleanup random hexadecimal roles from Backlog to Done on the KF6 board.
Sun, Sep 13, 11:38 AM · KF6
dfaure added a comment to T12364: Cleanup random hexadecimal roles.

Merged. Please reopen this (or just paste the comment) if you find more.

Sun, Sep 13, 11:38 AM · KF6
dfaure added a comment to T12664: KIO: Move out models from kiofilewidgets that don't require QWidgets.

See T11821 for the similar task for KDirModel.

Sun, Sep 13, 8:42 AM · KF6
dfaure renamed T13612: KRunner: Improve handling of actions from Improve handling of actions to KRunner: Improve handling of actions.
Sun, Sep 13, 8:41 AM · KF6
dfaure added a comment to T12364: Cleanup random hexadecimal roles.

This is already there in kdirmodel.h
Here's a MR for doing the same in kfileplacesmodel.h: https://invent.kde.org/frameworks/kio/-/merge_requests/130
Any other model that needs this?

Sun, Sep 13, 8:39 AM · KF6

Sat, Sep 12

dfaure added a comment to T12104: Port syndication away from QXmlInputSource API.

--> https://invent.kde.org/frameworks/syndication/-/merge_requests/5

Sat, Sep 12, 7:01 PM · KF6
dfaure added a comment to T12031: Clean up KRunner.

The second architecture seems better/simpler.

Sat, Sep 12, 7:00 PM · KF6
dfaure added a comment to D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR.
In D29299#676447, @pino wrote:
In D29299#676445, @pino wrote:

One of the primary goals of KF5 is to be useable by other applications not written by the KDE community (I actually know quite a few).
As such, it's not hard to imagine a cmake-based application that uses Qt and GNUInstallDirs [with qmake going away this will happen more and more], and one day it wants to use one of the frameworks. At that point, it shouldn't be forced to switch to ECMInstallDirs. Therefore I definitely see value in keeping the two things separate, as long as we keep making things easy for what is the most common case for us: using both.

Sigh. I know this, I never, ever, ever, and let me say it again, never, forgot about this.

Sat, Sep 12, 2:25 PM · Frameworks
dfaure added a comment to D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR.
In D29299#676445, @pino wrote:

I asked for actual valid use cases when using the new variables first would break, and I still got none. There is a limit to how much you can keep broken code working... assuming such broken code exists. I don't think there is any of this such situation, as ki18n_install() is basically used by KF sources that use ECM already, with marble being the only exception (and even that, marble won't break).

Sat, Sep 12, 1:07 PM · Frameworks
dfaure added a comment to D29136: Use non-deprecated KDEInstallDir.

(to remove some confusion: the previous comment had the wrong link and should have said "Abandoned in favour of https://phabricator.kde.org/D29299" -- but now it's reopened anyway, as an alternative to D29299)

Sat, Sep 12, 12:45 PM · Frameworks
dfaure added a comment to D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR.

@pino Other than the fact that you think D29136 is "good enough", do you have any concrete objection to this version?

Sat, Sep 12, 12:44 PM · Frameworks

Fri, Sep 11

dfaure closed D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

https://invent.kde.org/network/konqueror/commit/cd6364a2c8a5362c49145204de4eebeff1e4185c

Fri, Sep 11, 12:13 PM · Documentation
dfaure added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

Ah, I forgot I had to land your patches manually.
I'll do it now (already resolving a few conflicts...)

Fri, Sep 11, 12:06 PM · Documentation
dfaure added a comment to T12364: Cleanup random hexadecimal roles.

@broulik can we remove this task from the dashboard?

Fri, Sep 11, 7:34 AM · KF6

Thu, Sep 10

dfaure added a comment to T12722: Drop KDBusConnectionPool.

https://lxr.kde.org/ident?_i=KDBusConnectionPool&_remember=1 says everything was ported away from KDBusConnectionPool, good job :-)

Thu, Sep 10, 9:47 AM · KF6

Wed, Sep 9

dfaure added a comment to T13565: Nextcloud is not a suitable etherpad replacement for shared documents.

Were you using the Markdown/text editor or the full blown office one?

Wed, Sep 9, 3:55 PM · KDE Promo, Sysadmin
dfaure added a comment to T13565: Nextcloud is not a suitable etherpad replacement for shared documents.

My experience with editing files on share.kde.org yesterday: constant conflicts, can't rename the file, *lost my changes*, can't give out a link to the file (it lists the directory), can't copy/paste the filename at the top when opening the file. Next time I'm using the wiki.

Wed, Sep 9, 1:00 PM · KDE Promo, Sysadmin
dfaure added a comment to T12104: Port syndication away from QXmlInputSource API.

So, to be sure, I continue with this patch, adjusting the unittest to the new hash -- and no change required in akregrator?

Wed, Sep 9, 12:30 PM · KF6
dfaure added a comment to T12210: Port KIO DavJob away from QDomDocument in the public API.

OK, fair point, putting the task back onto the board ;)

Wed, Sep 9, 12:27 PM · KF6
dfaure added a project to T12210: Port KIO DavJob away from QDomDocument in the public API: KF6.
Wed, Sep 9, 12:27 PM · KF6

Tue, Sep 8

dfaure renamed T12193: Refactor JobUiDelegateExtension to be async from Refactor JobUiDelegateExtension to be 4 jobs to Refactor JobUiDelegateExtension to be async.
Tue, Sep 8, 6:25 PM · KF6
dfaure added a comment to T12193: Refactor JobUiDelegateExtension to be async.

More details:

Tue, Sep 8, 6:25 PM · KF6
dfaure added a comment to T12104: Port syndication away from QXmlInputSource API.

This is not as easy as I thought it would be. When used without QXmlInputSource, QDomDocument simplifies whitespace-only CDATA sections.
This patch: http://www.davidfaure.fr/2020/port_syndication_away_from_qxmlinputsource.diff
leads to a failure in autotests/atom/atom10_entry_content.xml which can be narrowed to
-id: #hash:aff2c4358030579d2c3dcea6e92b40fe#
+id: #hash:a359558b397d24593c3b55afb85d173a#

Tue, Sep 8, 6:21 PM · KF6
dfaure updated subscribers of T12104: Port syndication away from QXmlInputSource API.
Tue, Sep 8, 6:18 PM · KF6
dfaure claimed T12104: Port syndication away from QXmlInputSource API.
Tue, Sep 8, 5:28 PM · KF6
dfaure renamed T12104: Port syndication away from QXmlInputSource API from Port away from QDom API to Port syndication away from QXmlInputSource API.
Tue, Sep 8, 4:52 PM · KF6
dfaure added a comment to T12104: Port syndication away from QXmlInputSource API.

What's deprecated is only QXmlInputSource, QXmlReader/QXmlSimpleReader and associated classes (QXmlEntityResolver, QXmlAttributes...).

Tue, Sep 8, 4:52 PM · KF6
dfaure added a comment to T12106: Port KNewStuff away from QDom API.

Removed from the KF6 board (I can't find how to fully delete a task)

Tue, Sep 8, 4:51 PM
dfaure removed a project from T12106: Port KNewStuff away from QDom API: KF6.
Tue, Sep 8, 4:51 PM
dfaure removed a project from T12145: Port kbookmarks away from QDom API: KF6.
Tue, Sep 8, 4:50 PM
dfaure added a comment to T12145: Port kbookmarks away from QDom API.

Right, there is no task here anymore.

Tue, Sep 8, 4:50 PM
dfaure added a comment to T13590: Move ApplicationLauncherJob/CommandLauncherJob/KProcessRunner to KService?.

The main problem I see is the KRecentDocuments integration.

Tue, Sep 8, 4:44 PM · KF6
dfaure created T13590: Move ApplicationLauncherJob/CommandLauncherJob/KProcessRunner to KService?.
Tue, Sep 8, 4:43 PM · KF6
dfaure removed a project from T12210: Port KIO DavJob away from QDomDocument in the public API: KF6.
Tue, Sep 8, 4:34 PM · KF6
dfaure removed a subtask for T12104: Port syndication away from QXmlInputSource API: T12210: Port KIO DavJob away from QDomDocument in the public API.
Tue, Sep 8, 4:31 PM · KF6
dfaure removed a subtask for T12089: KIO for KF6: T12210: Port KIO DavJob away from QDomDocument in the public API.
Tue, Sep 8, 4:31 PM · KF6
dfaure removed parent tasks for T12210: Port KIO DavJob away from QDomDocument in the public API: T12089: KIO for KF6, T12104: Port syndication away from QXmlInputSource API.
Tue, Sep 8, 4:31 PM · KF6
dfaure added a comment to T11557: Change policies/design guidelines.

I agree, this is too vague, and therefore not actionable. @knauss do you want to make the task more targeted, or should I (somehow) delete it?

Tue, Sep 8, 4:24 PM · KF6
dfaure added a comment to T12210: Port KIO DavJob away from QDomDocument in the public API.

QDomDocument won't be deprecated after all, so we can forget this IMHO.

Tue, Sep 8, 4:22 PM · KF6
dfaure updated subscribers of T12212: Move KIO::SearchProvider to runners.

Right, @stefanocrocco maintains the WebEnginePart for konqueror, @rrosch worked on the sidebar, other people ported it away from deprecated API, and I review contributions.
So konqueror is still around.

Tue, Sep 8, 4:14 PM · KF6
dfaure added a comment to T12106: Port KNewStuff away from QDom API.

Turns out QDom isn't deprecated after all, so maybe this task isn't applicable anymore.

Tue, Sep 8, 12:53 PM

Sat, Aug 29

dfaure accepted D28745: Skip caching thumbnails on encrypted filesystems.
Sat, Aug 29, 9:28 AM · Frameworks, Dolphin

Thu, Aug 27

dfaure added inline comments to D28745: Skip caching thumbnails on encrypted filesystems.
Thu, Aug 27, 12:18 PM · Frameworks, Dolphin

Sat, Aug 22

dfaure added inline comments to D28745: Skip caching thumbnails on encrypted filesystems.
Sat, Aug 22, 8:57 PM · Frameworks, Dolphin

Aug 21 2020

dfaure added inline comments to D28745: Skip caching thumbnails on encrypted filesystems.
Aug 21 2020, 8:51 PM · Frameworks, Dolphin

Aug 19 2020

dfaure requested changes to D28745: Skip caching thumbnails on encrypted filesystems.
Aug 19 2020, 10:31 PM · Frameworks, Dolphin

Aug 16 2020

dfaure added a comment to T12176: KService: deprecate KAutostart.

It's more than "a handful" though.
I repaired lxr after noticing many desktop files were not being indexed, and it shows that this is used by:
kup, calindac, baloo_file, konqy_preload, kmix, rsibreak, klipper, kalarm, korgac, and kgpg
That's a large number of apps to adapt to toggling the Hidden key at runtime, no?

Aug 16 2020, 10:50 PM · KF6

Aug 13 2020

dfaure accepted D26448: Add KRecentFilesMenu to replace KRecentFileAction.

Thanks :-)

Aug 13 2020, 9:17 PM · Frameworks
dfaure added a comment to T12177: KService: deprecate KMimeTypeTrader.

No, we determined that the trader language wasn't the best way to write C++ code.
ktraderclient was mostly written as a debugging helper. I suggest to strip out the constraint functionality from ktraderclient.

Aug 13 2020, 10:00 AM · KF6
dfaure added inline comments to D26448: Add KRecentFilesMenu to replace KRecentFileAction.
Aug 13 2020, 9:58 AM · Frameworks

Aug 11 2020

dfaure accepted D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Aug 11 2020, 8:33 AM · Documentation

Aug 8 2020

dfaure accepted D26448: Add KRecentFilesMenu to replace KRecentFileAction.

A unittest would be useful too, especially if we then refactor the loading to use KIO jobs.

Aug 8 2020, 8:59 AM · Frameworks

Aug 6 2020

dfaure added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

I didn't have an assert before though, should I replace the if statement with a Q_ASSERT then?

Aug 6 2020, 8:31 AM · Documentation

Aug 5 2020

dfaure added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

A bunch of fixes got reverted. The dead code is back. The assert is gone. The docu improvement is gone....

Aug 5 2020, 8:18 PM · Documentation
dfaure added inline comments to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Aug 5 2020, 3:50 PM · Documentation
dfaure added inline comments to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Aug 5 2020, 3:47 PM · Documentation

Aug 2 2020

dfaure added inline comments to D26448: Add KRecentFilesMenu to replace KRecentFileAction.
Aug 2 2020, 10:20 AM · Frameworks

Aug 1 2020

dfaure added inline comments to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Aug 1 2020, 8:26 PM · Documentation

Jul 25 2020

dfaure added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

I can't really approve a half finished feature that is undiscoverable.

Jul 25 2020, 3:47 PM · Documentation

Jul 18 2020

dfaure added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

Well, if you insist, but this is how cruft just adds up. Will you -- or someone else -- remember to actually remove this weird entry from desktop files when implementing something better?
I just don't see how it belongs there. To make this actually available to users, you'd have to ship two desktop files "Home" and "Home with hidden directories shown"? Urgh.

Jul 18 2020, 9:11 PM · Documentation
dfaure added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

BTW we have moved to gitlab for merge requests :-)

Argh. So how do I do it now?

Jul 18 2020, 8:02 PM · Documentation
dfaure requested changes to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

Users don't create or edit desktop files ;)

Jul 18 2020, 7:47 PM · Documentation

Jul 14 2020

dfaure added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

The commit log explains the what but not the why. Can you give more details about the use case for this? At first sight it smells like overconfigurability (given that the user can already request that hidden files are shown, more globally).

Jul 14 2020, 9:42 AM · Documentation

Jul 6 2020

dfaure added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

Only if you can find a way to change BatchRenameJob in a binary and behaviour compatible way. And then it will be a dual-headed thing with two modes of operations, awful. All this sounds to me like much more trouble than writing a different job.

Jul 6 2020, 9:02 AM · Frameworks

Jul 5 2020

dfaure added a comment to T13364: lxr.kde.org seems to have incomplete index for General Search.

Done.

Jul 5 2020, 9:36 AM · Sysadmin

Jul 4 2020

dfaure added a comment to T13364: lxr.kde.org seems to have incomplete index for General Search.

Not fully sure. I thought it was corruption of the glimpse databases, but every tuesday they get deleted and recreated, AFAICS.

Jul 4 2020, 9:59 PM · Sysadmin
dfaure added a comment to T13364: lxr.kde.org seems to have incomplete index for General Search.

https://lxr.kde.org/search?_filestring=&_string=KAboutData looks much better now.

Jul 4 2020, 5:50 PM · Sysadmin
dfaure added a comment to T13364: lxr.kde.org seems to have incomplete index for General Search.

Here are my findings.

Jul 4 2020, 10:39 AM · Sysadmin
dfaure added a comment to T13364: lxr.kde.org seems to have incomplete index for General Search.

One thing that used to work better, was that I was able to get email when the cron job fails.
But now it says
"
A message that you sent could not be delivered to one or more of its
recipients. This is a permanent error. The following address(es) failed:

Jul 4 2020, 9:42 AM · Sysadmin

Jun 14 2020

dfaure added a comment to D29066: Ensure that WebEnginePart uses proxy settings from KCM.

In the repo where your git push fails, what does git remote -v say?

Jun 14 2020, 9:41 AM

Jun 13 2020

dfaure added a comment to D26253: Port the About page to QtWebEngine.

OK, Qt min version increased: https://invent.kde.org/network/konqueror/commit/a6def18fba4958e0c5a105fd0d8507baeca78d92

Jun 13 2020, 8:38 PM
dfaure accepted D29066: Ensure that WebEnginePart uses proxy settings from KCM.

Good idea to check the default webengine. Just in case :)

Jun 13 2020, 6:01 PM
dfaure added a comment to D26342: Allow overriding to disable auto language detection.

I don't think that's a regression, in the previous behavior you could try to set any language to proofread, it would always auto-detect "Bonjour" as French, thus the "Tools / Spelling / change language" had not effect if autodetect was enabled at system level (while autodetection should be an application or even case by case decision).

Jun 13 2020, 5:58 PM · Frameworks
dfaure added a comment to D26253: Port the About page to QtWebEngine.

@stefanocrocco if it makes your life easier I'm fine with konqueror requiring Qt >= 5.12 (currently the CMakeLists.txt says 5.9, but KF5 requires 5.12)

Jun 13 2020, 12:55 PM
dfaure added a comment to D26342: Allow overriding to disable auto language detection.

This actually breaks language auto-detection for me in the KMail composer.

Jun 13 2020, 12:51 PM · Frameworks
dfaure accepted D29066: Ensure that WebEnginePart uses proxy settings from KCM.

Sorry, slipped my mind.

Jun 13 2020, 11:52 AM

Jun 11 2020

dfaure added a comment to D26253: Port the About page to QtWebEngine.

Implementing something Konqueror-specific in kwebkitpart doesn't really feel right though. I suppose that the konq: URLs are implemented by generating HTML code which is then sent to the engine; is there a reason why this would have to be done in the web kpart? That would also solve the problem for the other view modes (my build still shows KHTML, but also a fancy term for "kate" and okular).

Jun 11 2020, 7:02 PM
dfaure committed R178:2277b0fffb08: Make KDocTools optional (like in e.g. KIO) (authored by dfaure).
Make KDocTools optional (like in e.g. KIO)
Jun 11 2020, 6:46 PM
dfaure added a comment to D26253: Port the About page to QtWebEngine.

The fix is to implement similar support for the about page (with konq: URLs) in kwebkitpart. Since you're the only person interested in kwebkitpart these days (AFAIK), feel free to go ahead and do that.

Jun 11 2020, 6:16 PM

Jun 8 2020

dfaure moved T12226: Port akregator away from BrowserRun::saveUrl from Backlog to Done on the KF6 board.

Done in https://invent.kde.org/pim/akregator/-/merge_requests/1

Jun 8 2020, 3:16 PM · KF6
dfaure committed R249:58febc1b34ae: autotests: repair after recent commit introducing single quotes around filenames (authored by dfaure).
autotests: repair after recent commit introducing single quotes around filenames
Jun 8 2020, 8:30 AM

Jun 7 2020

dfaure committed R241:b5e3f560825c: Deprecate totalFiles and totalDirs signals, not emitted (authored by dfaure).
Deprecate totalFiles and totalDirs signals, not emitted
Jun 7 2020, 7:32 PM
dfaure committed R497:b88212a3d1b0: Add support for "force" to make_rc_tag.sh (authored by dfaure).
Add support for "force" to make_rc_tag.sh
Jun 7 2020, 7:22 PM
dfaure committed R201:770108e781c4: Port away from KParts::BrowserRun (authored by dfaure).
Port away from KParts::BrowserRun
Jun 7 2020, 11:54 AM
dfaure added a comment to D29810: Don't use the setenv function after fork.

This breaks FreeBSD compilation. Please check: https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/17/

Jun 7 2020, 10:36 AM · Frameworks
dfaure committed R236:226987c89e94: KDatePicker: Fix parsing date from line edit on Enter press (authored by volkov).
KDatePicker: Fix parsing date from line edit on Enter press
Jun 7 2020, 10:34 AM
dfaure committed R201:8889379f282f: Port akregator away from KParts::BrowserRun (authored by dfaure).
Port akregator away from KParts::BrowserRun
Jun 7 2020, 10:32 AM
dfaure committed R241:e8b3e5fe64e7: Port from KRandom::random to QRandomGenerator (authored by aacid).
Port from KRandom::random to QRandomGenerator
Jun 7 2020, 10:20 AM
dfaure committed R285:bb7c80717a60: Don't use the setenv function after fork (authored by jpalecek).
Don't use the setenv function after fork
Jun 7 2020, 9:24 AM
dfaure closed D29810: Don't use the setenv function after fork.
Jun 7 2020, 9:24 AM · Frameworks
dfaure committed R285:dfae07a8ed40: Fix segfault on no restart args (authored by jpalecek).
Fix segfault on no restart args
Jun 7 2020, 9:22 AM
dfaure closed D29814: Fix segfault on no restart args.
Jun 7 2020, 9:22 AM · Frameworks
dfaure accepted D29814: Fix segfault on no restart args.
Jun 7 2020, 9:17 AM · Frameworks

Jun 6 2020

dfaure committed R497:6c019d4c8d8d: Minor fixes (authored by dfaure).
Minor fixes
Jun 6 2020, 11:19 PM
dfaure committed R883:1570733: add frameworks-5.71.0 to generate_release_data.py.
add frameworks-5.71.0 to generate_release_data.py
Jun 6 2020, 11:15 PM
dfaure committed R497:f4c8e51e6486: Fixes (authored by dfaure).
Fixes
Jun 6 2020, 8:02 PM
dfaure committed R201:70c1d3683a65: Remove unused includes (authored by dfaure).
Remove unused includes
Jun 6 2020, 7:52 PM
dfaure committed R286:698fe94d39b2: Adapt kfilemetadata to "audio/x-speex+ogg" as recently changed in shared-mime… (authored by dfaure).
Adapt kfilemetadata to "audio/x-speex+ogg" as recently changed in shared-mime…
Jun 6 2020, 3:48 PM
dfaure committed R244:ee056eec85fb: autotests: make kdirwatch_stat_unittest more robust. (authored by dfaure).
autotests: make kdirwatch_stat_unittest more robust.
Jun 6 2020, 3:33 PM