- User Since
- Mar 5 2015, 12:44 PM (171 w, 6 d)
Note: kcoreaddons, baloo, kservice/autotests, and kdelibs4support mention this key too, you can clean it all up ;)
Indeed, not used, and not useful.
BTW, the commit message refers to ModelTest, but that's the old modeltest.cpp, not the new QAbstractItemModelTester, right?
Mon, Jun 18
Well then you can just remove lessThan altogether, and call std::sort with only 2 arguments instead of 3 ;)
Fri, Jun 15
Wed, Jun 13
Tue, Jun 12
Sat, Jun 9
Thu, Jun 7
Tue, Jun 5
Sun, Jun 3
Sat, Jun 2
Wed, May 30
A good example of how a unittest helps catching a bug :-)
(and a good example of how code that I suggest isn't necessarily bugfree, haha)
Yep, this makes sense these days (back when this was written, QUrl had no hashing function, and my first attempt at writing one was to call qHash(url.toString()) -- how horribly slow!!)
Tue, May 29
Unlike KFileItem, this function does no caching. I hope you do caching at the layer above then...
Mon, May 28
Fri, May 25
It should be easy to use lxr to see which KDE applications uses KFileItemListProperties::mimeType(), but OK, your solution is safer in case of third-party applications.
Thu, May 24
May 17 2018
May 15 2018
Even old OpenSuSE Leap 42.3 has ffmpeg 3.3.4, so this seems fine ;-)
May 14 2018
May 12 2018
May 11 2018
Oops, thanks for the fix.
Still strange that "rss" or "rdf" anywhere in the path is enough, but I'm no rss expert... Looks good overall.
Found stuff on the way, but the commit itself is fine.
May 10 2018
May 9 2018
Starting to look good ;-)
Patch looks good, but please update the first line of the commit message so that it gives more context (think about the changelog, where the rest of the description won't be visible...)
May 8 2018
May 7 2018
Oh OK I had misunderstood your comment.
I requested it, for proper encapsulation
May 6 2018
First line of commit log should have changelog in mind, so more context needed. Maybe rather something like "KIO::UDSEntry: switch to a single std::vector for more performance".
It helps if you actually add reviewers...
Makes sense, but why not do this in KFileItemListProperties::mimeType()?
May 5 2018
Please add QStandardPaths::setTestModeEnabled(true) in initTestCase() so that your (broken, thank you WinE) locally defined mimetypes don't interfer with the test. Then "hardcoding" text/html will be fine again.
May 4 2018
May 3 2018
I don't understand the "except" in your reply.
I like the replaceOrInsert idea, and the assert in insert... we might have to fix some kioslaves, but in general they have no good reason to insert twice for the same key.
In both cases the same fragility exists, in case one of the replacement strings contains one of the placeholders --- unless you use multi-arg, i.e. myString.arg(title, direction, m_warningIconData, ...)
May 2 2018
Thanks for that investigation. Interesting that linear search is faster than binary search in the same data structure... maybe the compiler optimizes it better? Did you profile V2 to find out where the time is spent, or do you have a better explanation?
But even if both were equal performance-wise I'd favor linear search because sorted insertion is easy to get wrong - as this patch shows ;)
May 1 2018
Thanks for the fixes, here are a few more nitpicks ;)
Nice! I remember that this was sorely missing when I was using that part :-)
Apr 30 2018
Clearly we should port to the qt5 connect syntax...