- User Since
- Mar 5 2015, 12:44 PM (116 w, 2 d)
Thu, May 25
Tue, May 23
Mon, May 22
Sun, May 21
Looks good otherwise.
Yes. KDirWatch doesn't support watching such paths.
Mon, May 15
avoid doing removeDir twice
In fact, CopyJob has no way to know whether a view somewhere is watching that directory. When an app other than Dolphin uses CopyJob, there isn't going to be any watching, possibly.
So I think we need to remove the qDebug in KDirWatch so that removeDir is silent if the dir wasn't watched [this is faster than checking before removing, from the outside].
Sun, May 14
Random thought: a ProxyStorage base class for CachingStorage could generalize this implementation, just in case there's more need for "reimplement all methods by forwarding to another storage, except for one method".
Fixed unwanted scrollbar when squeezing (missing use of "double"). Now it works for me.
Yes, if this is confirmed to work we can deprecate stopDirScan/restartDirScan.
In that case you might want to look at the fixes I just committed for https://bugs.kde.org/show_bug.cgi?id=208625
Sat, May 13
Ouch, sorry about your toe ! :(
... and this is how one ends up spending his saturday clicking on web pages ;)
zat iss mouch bitter indid.
not really worth review :)
Talk about spring cleaning ;)
d_ed: I use the DBus name in multi mode to talk to running processes ;-)
(for introspection, debugging, automation, etc.)
I don't really know this code, but I definitely welcome such very needed speed improvements.
Fri, May 12
I didn't actually test this with multiple screens.
Tue, May 9
Mon, May 8
Sun, May 7
50000 is 50kB.
You wrote 50 megs which would be 50000000 or 50*1024*1024.
Looks simpler indeed.
Sat, May 6
Fri, May 5
Sun, Apr 30
Easy one ;-)
Could this be made more lightweight by adding a precise subscription method rather than signal broadcasts?
Apr 18 2017
Apr 17 2017
Apr 16 2017
Would it help if QSaveFile had an API to set more restrictive permissions on the temp file?
Apr 15 2017
OK then ;)
Isn't this missing a "set_package_properties .. TYPE OPTIONAL" so that the user is told about the optional deps they're missing?
Not sure if that works for KF5 components.
Seems consistent with the code further down, but I'm really puzzled because this code was the same in kdelibs4... Anyone with konqueror4 to test this? Otherwise I can do that in the office, 10 days from now.
Feel free to push after that last fix.