Probably still valid, yes. Needs investigation, and a unittest....

Not really an issue anymore, https://phabricator.kde.org/D22578 had the right repository somehow.

This one still needs a review.

Yep, I had that locally, here it is https://phabricator.kde.org/D23334

Fix memory leak in new overload

The truth is stronger than "I would not recommend".
put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.

The unittest doesn't seem to pass on CI:
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/149/testReport/junit/projectroot.autotests.src/vimode/vimode_emulatedcommandbar/

FAIL!  :   EmulatedCommandBarTest::EmulatedCommandBarTests() Compared values are not the same
Actual   (kate_document->text()): "bar\nbar\nbar"
Expected (expected_text)        : "foo\nfoo\nbar"
Loc: [/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 SUSEQt5.12/autotests/src/vimode/emulatedcommandbar.cpp(1950)]

fix description

Adjust documentation

What a good idea :-)

Yeah, clearly unfinished, but this shows how we'll access the information.

Nice de-duplication.

In D23089#510276, @zzag wrote:

"KWindowSystem:" can be omitted in the subject line.

Add test for QWidget overload and fix crash

vladz has no phab account?

This is no bug. isValid() doesn't make a remote procedure call to check if the remote object still exists.

Yes.