- User Since
- Mar 5 2015, 12:44 PM (233 w, 3 h)
Probably still valid, yes. Needs investigation, and a unittest....
Not really an issue anymore, https://phabricator.kde.org/D22578 had the right repository somehow.
This one still needs a review.
Yep, I had that locally, here it is https://phabricator.kde.org/D23334
Fix memory leak in new overload
Sun, Aug 18
The truth is stronger than "I would not recommend".
put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.
Sat, Aug 17
The unittest doesn't seem to pass on CI:
FAIL! : EmulatedCommandBarTest::EmulatedCommandBarTests() Compared values are not the same Actual (kate_document->text()): "bar\nbar\nbar" Expected (expected_text) : "foo\nfoo\nbar" Loc: [/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 SUSEQt5.12/autotests/src/vimode/emulatedcommandbar.cpp(1950)]
Fri, Aug 16
What a good idea :-)
Yeah, clearly unfinished, but this shows how we'll access the information.
Wed, Aug 14
Mon, Aug 12
Sun, Aug 11
Add test for QWidget overload and fix crash
vladz has no phab account?
Sat, Aug 10
Fri, Aug 9
This is no bug. isValid() doesn't make a remote procedure call to check if the remote object still exists.
Wed, Aug 7