dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (124 w, 3 d)
Availability
Available

Recent Activity

Today

dfaure committed R865:5fdbbe704339: kirigami2 is the one you want (authored by dfaure).
kirigami2 is the one you want
Sun, Jul 23, 12:42 PM
dfaure committed R247:de79021ed3fa: Update Ruqola description (authored by dfaure).
Update Ruqola description
Sun, Jul 23, 10:30 AM
dfaure committed R226:737525dbb240: Bundle the ui.rc file into a qrc resource. (authored by dfaure).
Bundle the ui.rc file into a qrc resource.
Sun, Jul 23, 8:56 AM
dfaure committed R226:888fc319bd31: GIT_SILENT coding style fixes for previous commit (authored by dfaure).
GIT_SILENT coding style fixes for previous commit
Sun, Jul 23, 8:27 AM
dfaure committed R241:e4099f6084b0: GIT_SILENT port to qCDebug (mostly to trigger CI again) (authored by dfaure).
GIT_SILENT port to qCDebug (mostly to trigger CI again)
Sun, Jul 23, 7:26 AM

Yesterday

dfaure committed R865:b2503f10afa6: Fix cancelling the image dialog, add missing tr() calls (authored by dfaure).
Fix cancelling the image dialog, add missing tr() calls
Sat, Jul 22, 9:43 PM
dfaure committed R865:9e32d3502cd8: Added code conditionals for systemTray (authored by vasudhamathur).
Added code conditionals for systemTray
Sat, Jul 22, 9:43 PM
dfaure committed R865:b8456aebcde6: Testing Ruqola on Android, without conditionals (authored by vasudhamathur).
Testing Ruqola on Android, without conditionals
Sat, Jul 22, 9:43 PM
dfaure committed R241:7afee3f17674: Stash without asking the user with a Copy/Cancel popup. (authored by dfaure).
Stash without asking the user with a Copy/Cancel popup.
Sat, Jul 22, 5:20 PM
dfaure closed D6836: Stash without asking the user with a Copy/Cancel popup. by committing R241:7afee3f17674: Stash without asking the user with a Copy/Cancel popup..
Sat, Jul 22, 5:20 PM · Frameworks
dfaure created D6836: Stash without asking the user with a Copy/Cancel popup..
Sat, Jul 22, 4:40 PM · Frameworks
dfaure committed R226:43ebc7d8e8a7: add logging category org.kde.konqueror (authored by dfaure).
add logging category org.kde.konqueror
Sat, Jul 22, 4:08 PM
dfaure committed R865:d51a843626b1: Fix cancelling the image dialog, add missing tr() calls (authored by dfaure).
Fix cancelling the image dialog, add missing tr() calls
Sat, Jul 22, 2:17 PM
dfaure committed R226:26e7cc9727df: Port Konqueror to qCDebug. (authored by dfaure).
Port Konqueror to qCDebug.
Sat, Jul 22, 2:09 PM
dfaure committed R226:e610205ad05b: Fix compilation warnings (authored by dfaure).
Fix compilation warnings
Sat, Jul 22, 2:09 PM
dfaure accepted D6781: Allow konqueror to embed / open in a new window downloaded files using webengine part.

Please push, then I'll port all of webenginepart to qCDebug in a separate commit.

Sat, Jul 22, 1:44 PM
dfaure accepted D6781: Allow konqueror to embed / open in a new window downloaded files using webengine part.

Let's get this in even if there are a few issues left, it's certainly much better than the current behaviour ;)

Sat, Jul 22, 10:45 AM
dfaure committed R226:e28d2074f8e6: Fix handling of mailto links (authored by dfaure).
Fix handling of mailto links
Sat, Jul 22, 9:36 AM
dfaure committed R241:1449ecf136b5: Ensure KDirLister updates items whose target URL has changed. (authored by dfaure).
Ensure KDirLister updates items whose target URL has changed.
Sat, Jul 22, 6:52 AM

Fri, Jul 21

dfaure accepted D6815: kcmtrash: fix i18n warning.

Indeed, forget what I said, it's perfectly valid XML.

Fri, Jul 21, 5:48 PM · Frameworks
dfaure accepted D6816: Fix kdirwatch warning.
Fri, Jul 21, 5:15 PM · Frameworks
dfaure added a comment to D6815: kcmtrash: fix i18n warning.

Isn't the use of single quotes for XML attribute values a little bit ... unorthodox?

Fri, Jul 21, 5:13 PM · Frameworks
dfaure accepted D6777: Port to KStandardAction::RenameFile.
Fri, Jul 21, 3:50 PM
dfaure accepted D6779: Drop duplicate i18n strings.
Fri, Jul 21, 3:47 PM
dfaure requested changes to D6781: Allow konqueror to embed / open in a new window downloaded files using webengine part.
Fri, Jul 21, 3:21 PM
dfaure added inline comments to D6781: Allow konqueror to embed / open in a new window downloaded files using webengine part.
Fri, Jul 21, 3:20 PM

Wed, Jul 19

dfaure committed R365:8b2a0696e4ea: Add zanshin (authored by dfaure).
Add zanshin
Wed, Jul 19, 4:09 PM
dfaure committed R44:4ed67e11d262: Fix crash when clicking on "try again". (authored by dfaure).
Fix crash when clicking on "try again".
Wed, Jul 19, 8:14 AM

Mon, Jul 17

dfaure committed R94:4300cfbfcdfb: Fix the previous fix: skip algo if the guessed index was out of bounds. (authored by dfaure).
Fix the previous fix: skip algo if the guessed index was out of bounds.
Mon, Jul 17, 1:55 PM
dfaure committed R499:94dc0a6a2013: Fix path to kdepim-runtime (authored by dfaure).
Fix path to kdepim-runtime
Mon, Jul 17, 1:35 PM
dfaure committed R94:6948f86e8e1a: Fix another crash in this code, where fwdIt would keep going, past the end (authored by dfaure).
Fix another crash in this code, where fwdIt would keep going, past the end
Mon, Jul 17, 12:47 PM
dfaure committed R94:f8188f1f8625: Fix crash when deleting multiple emails, due to begin+idx being out of bounds. (authored by dfaure).
Fix crash when deleting multiple emails, due to begin+idx being out of bounds.
Mon, Jul 17, 12:34 PM
dfaure committed R739:7966d72d8823: Update modeltest.cpp from qtbase to fix link error (authored by dfaure).
Update modeltest.cpp from qtbase to fix link error
Mon, Jul 17, 10:55 AM

Sun, Jul 16

dfaure committed R120:052ab380b6cb: Fix compilation with current cmake (git branch release). (authored by dfaure).
Fix compilation with current cmake (git branch release).
Sun, Jul 16, 10:08 PM

Sat, Jul 15

dfaure committed R241:0296b89714ce: Make advanced options of "open with" dialog collabsible and hidden by default (authored by simgunz).
Make advanced options of "open with" dialog collabsible and hidden by default
Sat, Jul 15, 12:53 PM

Fri, Jul 14

dfaure committed R226:86ed60240e9e: Implement a file dialog for downloads (authored by dfaure).
Implement a file dialog for downloads
Fri, Jul 14, 8:13 PM
dfaure committed R226:9beb9525f759: Code cleanups (authored by dfaure).
Code cleanups
Fri, Jul 14, 8:13 PM
dfaure accepted D6684: Fix drop menu position with urlnavigator drops.

Looks much better to me.

Fri, Jul 14, 7:21 PM
dfaure committed R226:e6788a0ca623: Implement TODO: get rid of this duplicated code, and just reimplement… (authored by dfaure).
Implement TODO: get rid of this duplicated code, and just reimplement…
Fri, Jul 14, 3:33 PM
dfaure committed R226:f31e41d8dbe3: Avoid emitting changed() if the icon is the same as the one we knew already. (authored by dfaure).
Avoid emitting changed() if the icon is the same as the one we knew already.
Fri, Jul 14, 3:22 PM
dfaure committed R226:b9b446043322: Simplify code by using method added in KF 5.20 (authored by dfaure).
Simplify code by using method added in KF 5.20
Fri, Jul 14, 3:22 PM
dfaure committed R226:59cd3d500877: GIT_SILENT Remove dead code (authored by dfaure).
GIT_SILENT Remove dead code
Fri, Jul 14, 3:22 PM
dfaure committed R226:8a5ef4d042f4: Add support again for man:, info: and other slaves which output HTML. (authored by dfaure).
Add support again for man:, info: and other slaves which output HTML.
Fri, Jul 14, 2:48 PM
dfaure committed R226:a1691b2f334a: Make the "about" protocol configurable to attempt working around QtWebEngine… (authored by dfaure).
Make the "about" protocol configurable to attempt working around QtWebEngine…
Fri, Jul 14, 2:48 PM
dfaure committed R226:e1f9ebc309b8: Redesign the implementation of the about page. (authored by dfaure).
Redesign the implementation of the about page.
Fri, Jul 14, 2:48 PM
dfaure committed R226:5af022a8107d: Restore support for launching executables from the about page (authored by dfaure).
Restore support for launching executables from the about page
Fri, Jul 14, 2:48 PM
dfaure added inline comments to D6684: Fix drop menu position with urlnavigator drops.
Fri, Jul 14, 11:13 AM
dfaure accepted D6686: Drop usage of KDE_DEFAULT_WINDOWFLAGS.
Fri, Jul 14, 10:52 AM · Frameworks

Thu, Jul 13

dfaure added a comment to D6665: Make kssl compile against OpenSSL 1.1.0.

Thanks for this work, but I can't review it, I don't know anything about openssl APIs or this code.

Thu, Jul 13, 11:04 AM · Frameworks
dfaure accepted D6604: add a metainfo.yaml to make ECM a proper framework.
Thu, Jul 13, 11:01 AM · Build System, Frameworks

Wed, Jul 12

dfaure committed R226:64e7096f7466: WebEngine: port from execJScript to runJavaScript+lambda. Not tested. (authored by dfaure).
WebEngine: port from execJScript to runJavaScript+lambda. Not tested.
Wed, Jul 12, 9:32 AM
dfaure committed R226:94f7685b84d1: GIT_SILENT rename a variable (authored by dfaure).
GIT_SILENT rename a variable
Wed, Jul 12, 8:29 AM
dfaure committed R226:6e635df98530: Add convenience DBus method `qdbus org.kde.konqueror /KonqMain urls` (authored by dfaure).
Add convenience DBus method `qdbus org.kde.konqueror /KonqMain urls`
Wed, Jul 12, 8:29 AM

Tue, Jul 11

dfaure added a comment to D6604: add a metainfo.yaml to make ECM a proper framework.

Please add a README.md too, with the same syntax as in the other frameworks.

Tue, Jul 11, 3:23 PM · Build System, Frameworks
dfaure added a comment to D6603: move ECM from kdesupport to frameworks.

Yes, I already said +1 in this review request ;-)

Tue, Jul 11, 3:21 PM
dfaure committed R226:295ebd8c1200: Remove another unused PNG (since 2007), fix CMakeLists.txt (authored by dfaure).
Remove another unused PNG (since 2007), fix CMakeLists.txt
Tue, Jul 11, 10:11 AM
dfaure committed R226:a16cdb8c4523: Remove image that has been unused for a long time (authored by dfaure).
Remove image that has been unused for a long time
Tue, Jul 11, 10:08 AM

Mon, Jul 10

dfaure committed R226:1d35838cc4d6: Don't offer to restore an empty list of windows (authored by dfaure).
Don't offer to restore an empty list of windows
Mon, Jul 10, 8:54 PM
dfaure committed R226:e025cb34d3f2: Don't autosave preloaded windows (authored by dfaure).
Don't autosave preloaded windows
Mon, Jul 10, 3:23 PM
dfaure committed R226:fdd6cb31185d: Rename file for consistency (authored by dfaure).
Rename file for consistency
Mon, Jul 10, 2:48 PM
dfaure added a reviewer for D6603: move ECM from kdesupport to frameworks: bcooksley.

+1 from me.

Mon, Jul 10, 2:38 PM
dfaure committed R226:1201a6ef497c: Fix HTML to work in firefox/chromium as well. (authored by dfaure).
Fix HTML to work in firefox/chromium as well.
Mon, Jul 10, 2:33 PM
dfaure committed R226:0fc7ecaed79c: Remove TODO, the TODO is actually much bigger now (porting away from KTabWidget) (authored by dfaure).
Remove TODO, the TODO is actually much bigger now (porting away from KTabWidget)
Mon, Jul 10, 2:33 PM
dfaure committed R226:f9b7b235bc53: Fix deprecation warnings (authored by dfaure).
Fix deprecation warnings
Mon, Jul 10, 2:33 PM
dfaure committed R226:4a256e9bc770: Fix deprecation warnings, and a TODO now that we're not using a protected… (authored by dfaure).
Fix deprecation warnings, and a TODO now that we're not using a protected…
Mon, Jul 10, 2:33 PM
dfaure accepted D6606: Support SVG too.
Mon, Jul 10, 2:10 PM · Frameworks
dfaure committed R293:73965ae8336a: Fix compilation with cmake current git and cmake >= 3.10 (authored by dfaure).
Fix compilation with cmake current git and cmake >= 3.10
Mon, Jul 10, 9:34 AM

Sun, Jul 9

dfaure committed R239:32988dd7e6e9: Mark constructors as deprecated too. (authored by dfaure).
Mark constructors as deprecated too.
Sun, Jul 9, 12:31 PM
dfaure committed R226:b961789fcaa4: add missing license (authored by dfaure).
add missing license
Sun, Jul 9, 10:40 AM
dfaure committed R226:3c58b0b0452a: Make preloading do something again, even in a single-process situation. (authored by dfaure).
Make preloading do something again, even in a single-process situation.
Sun, Jul 9, 10:38 AM
dfaure committed R226:736b74509189: Make Konqueror a KUniqueApplication, as QtWebEngine expects. (authored by dfaure).
Make Konqueror a KUniqueApplication, as QtWebEngine expects.
Sun, Jul 9, 10:38 AM
dfaure committed R226:997541a6a64b: Move code that talks to a running konq (or starts one) into a separate class. (authored by dfaure).
Move code that talks to a running konq (or starts one) into a separate class.
Sun, Jul 9, 10:38 AM
dfaure committed R125:8a7a80b72fc3: Call QCLP::parse rather than process in the slot connected to activateRequested (authored by dfaure).
Call QCLP::parse rather than process in the slot connected to activateRequested
Sun, Jul 9, 10:20 AM
dfaure committed R363:142107890509: Fix handling of activateRequested, the first arg is the exe name, strip it off. (authored by dfaure).
Fix handling of activateRequested, the first arg is the exe name, strip it off.
Sun, Jul 9, 9:25 AM
dfaure abandoned D6579: KDBusService: pass executable name to QStringList arguments in the activateRequested signal.

It was already documented that the arg list could be empty when called directly via DBus, so this fix is wrong. Apps have to handle empty args list correctly.

Sun, Jul 9, 9:21 AM · Frameworks
dfaure committed R271:856ddb707268: KDBusService: improve documentation to handle empty argument list correctly. (authored by dfaure).
KDBusService: improve documentation to handle empty argument list correctly.
Sun, Jul 9, 9:20 AM
dfaure updated the diff for D6579: KDBusService: pass executable name to QStringList arguments in the activateRequested signal.

Make the behaviour explicit in the documentation.

Sun, Jul 9, 8:52 AM · Frameworks
dfaure created D6579: KDBusService: pass executable name to QStringList arguments in the activateRequested signal.
Sun, Jul 9, 8:51 AM · Frameworks
dfaure committed R134:3114021e572e: Call QCLP parse rather than process, as documented in KDBusService. (authored by dfaure).
Call QCLP parse rather than process, as documented in KDBusService.
Sun, Jul 9, 8:37 AM
dfaure committed R271:9d35b0ca4442: Revert "API docs: prepend executable name, since QCommandLineParser needs it." (authored by dfaure).
Revert "API docs: prepend executable name, since QCommandLineParser needs it."
Sun, Jul 9, 7:31 AM
dfaure added a reverting commit for R271:cc386062687f: API docs: prepend executable name, since QCommandLineParser needs it.: R271:9d35b0ca4442: Revert "API docs: prepend executable name, since QCommandLineParser needs it.".
Sun, Jul 9, 7:31 AM

Sat, Jul 8

dfaure committed R271:cc386062687f: API docs: prepend executable name, since QCommandLineParser needs it. (authored by dfaure).
API docs: prepend executable name, since QCommandLineParser needs it.
Sat, Jul 8, 9:45 PM
dfaure accepted D6573: Babelfish plugin: Allow secure URLs to be translated.
Sat, Jul 8, 8:32 PM · Plasma
dfaure added a comment to D6573: Babelfish plugin: Allow secure URLs to be translated.

Looks good, just some details.

Sat, Jul 8, 1:38 PM · Plasma
dfaure added a comment to D6569: [client] Track all created ConnectionThreads and add API to access them.

Isn't a mutex needed to protect this data structure that is apparently modified by different threads?

Sat, Jul 8, 1:29 PM · Plasma on Wayland, Frameworks
dfaure added a comment to D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab..

Damn, you're right, the third alternate isn't editable.

Sat, Jul 8, 12:03 PM · Frameworks
dfaure committed R497:f4bfce548990: small fixes (authored by dfaure).
small fixes
Sat, Jul 8, 11:43 AM
dfaure updated the diff for D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab..

Preserve existing shortcuts

Sat, Jul 8, 11:29 AM · Frameworks
dfaure accepted D6558: do not stderr that NoDisplay is set.
Sat, Jul 8, 11:19 AM · Frameworks
dfaure added a comment to D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab..

QKeySequence supports more, just not this data table.

Sat, Jul 8, 11:15 AM · Frameworks
dfaure committed R240:bcf2bcf39b44: Android: scan for qml files in the source dir, not in the install dir. (authored by dfaure).
Android: scan for qml files in the source dir, not in the install dir.
Sat, Jul 8, 10:52 AM
dfaure closed D6466: Android: scan for qml files in the source dir, not in the install dir. by committing R240:bcf2bcf39b44: Android: scan for qml files in the source dir, not in the install dir..
Sat, Jul 8, 10:52 AM · Build System, Frameworks

Fri, Jul 7

dfaure created D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab..
Fri, Jul 7, 1:48 PM · Frameworks
dfaure accepted D6537: Fix display of formatDuration with rounding..
Fri, Jul 7, 11:45 AM · Frameworks

Thu, Jul 6

dfaure committed R497:9df12d01605e: Improvements for 5.36 (authored by dfaure).
Improvements for 5.36
Thu, Jul 6, 10:01 PM
dfaure added a comment to D6233: KKeyServer: fix handling of KeypadModifier..

What if you write me down as maintainer of this code, can this then go in?

Thu, Jul 6, 7:59 PM · Frameworks
dfaure added a comment to D6466: Android: scan for qml files in the source dir, not in the install dir..
In D6466#121152, @apol wrote:

This will be problematic as soon as your application depends on any libraries.

Thu, Jul 6, 7:57 PM · Build System, Frameworks

Sun, Jul 2

dfaure created D6466: Android: scan for qml files in the source dir, not in the install dir..
Sun, Jul 2, 8:29 AM · Build System, Frameworks
dfaure committed R169:1b7134d9c846: Not ready for release yet: translations, CI, tarball naming... (authored by dfaure).
Not ready for release yet: translations, CI, tarball naming...
Sun, Jul 2, 7:40 AM

Sat, Jul 1

dfaure accepted D6008: Give a parent to KMoreToolsMenuFactory menus.
Sat, Jul 1, 6:38 PM · Frameworks