dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (116 w, 2 d)
Availability
Available

Recent Activity

Yesterday

dfaure accepted D5935: Move non-exported code to a static library.
Fri, May 26, 9:31 PM

Thu, May 25

dfaure accepted D5956: Make sure we always set a default mime filter in save mode.
Thu, May 25, 5:45 PM · Plasma
dfaure committed R230:77e13b76ff51: Fix regex in convert-kurl.pl (authored by rthomas).
Fix regex in convert-kurl.pl
Thu, May 25, 5:42 PM
dfaure closed D5963: Fix regex in convert-kurl.pl by committing R230:77e13b76ff51: Fix regex in convert-kurl.pl (authored by rthomas).
Thu, May 25, 5:42 PM
dfaure accepted D5963: Fix regex in convert-kurl.pl.
Thu, May 25, 5:38 PM

Tue, May 23

dfaure committed R94:579a09e1bba7: Workaround assert in QtWebEngine 5.9 (ASSERT: "m_updateHttpCache") (authored by dfaure).
Workaround assert in QtWebEngine 5.9 (ASSERT: "m_updateHttpCache")
Tue, May 23, 9:38 AM
dfaure accepted D5936: Introduce DolphinMainWindowTest.
Tue, May 23, 7:12 AM

Mon, May 22

dfaure committed R244:c3dc4effa60b: Remove qDebug from removeDir/removeFile as discussed in https://phabricator.kde. (authored by dfaure).
Remove qDebug from removeDir/removeFile as discussed in https://phabricator.kde.
Mon, May 22, 7:22 AM

Sun, May 21

dfaure accepted D5877: Do not watch QRC's paths.
Sun, May 21, 6:39 PM · Frameworks
dfaure added a comment to D5877: Do not watch QRC's paths.

Looks good otherwise.

Sun, May 21, 5:17 PM · Frameworks
dfaure requested changes to D5873: Add missing job start calls in the fake storage.
Sun, May 21, 3:06 PM
dfaure added a comment to D5877: Do not watch QRC's paths.

Yes. KDirWatch doesn't support watching such paths.

Sun, May 21, 3:03 PM · Frameworks
dfaure requested changes to D5832: Implement caching for the collection fetches.
Sun, May 21, 12:24 PM
dfaure added inline comments to D5357: Introduce a Cache class.
Sun, May 21, 12:20 PM
dfaure committed R94:23d0007f6781: Fix runtime warning about application/x-pkcs7-signature. (authored by dfaure).
Fix runtime warning about application/x-pkcs7-signature.
Sun, May 21, 11:55 AM
dfaure closed D5859: Fix runtime warning about application/x-pkcs7-signature. by committing R94:23d0007f6781: Fix runtime warning about application/x-pkcs7-signature..
Sun, May 21, 11:55 AM · KDE PIM
dfaure requested changes to D5877: Do not watch QRC's paths.
Sun, May 21, 11:44 AM · Frameworks

Mon, May 15

dfaure accepted D5843: Do not use QtModule/QtClass includes.
Mon, May 15, 4:50 PM
dfaure updated the diff for D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan.

avoid doing removeDir twice

Mon, May 15, 12:53 PM · Frameworks
dfaure added a comment to D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan.

In fact, CopyJob has no way to know whether a view somewhere is watching that directory. When an app other than Dolphin uses CopyJob, there isn't going to be any watching, possibly.
So I think we need to remove the qDebug in KDirWatch so that removeDir is silent if the dir wasn't watched [this is faster than checking before removing, from the outside].

Mon, May 15, 12:52 PM · Frameworks

Sun, May 14

dfaure created D5859: Fix runtime warning about application/x-pkcs7-signature..
Sun, May 14, 10:27 PM · KDE PIM
dfaure added inline comments to D5832: Implement caching for the collection fetches.
Sun, May 14, 10:14 PM
dfaure added a comment to D5831: Add a CachingStorage.

Random thought: a ProxyStorage base class for CachingStorage could generalize this implementation, just in case there's more need for "reimplement all methods by forwarding to another storage, except for one method".

Sun, May 14, 10:13 PM
dfaure accepted D5831: Add a CachingStorage.
Sun, May 14, 10:05 PM
dfaure requested changes to D5357: Introduce a Cache class.
Sun, May 14, 10:03 PM
dfaure updated the diff for D5763: Use floating point calculations for column sizes to avoid accumulating rounding errors.

Fixed unwanted scrollbar when squeezing (missing use of "double"). Now it works for me.

Sun, May 14, 9:40 PM
dfaure added a comment to D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan.

Yes, if this is confirmed to work we can deprecate stopDirScan/restartDirScan.

Sun, May 14, 9:21 PM · Frameworks
dfaure created D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan.
Sun, May 14, 6:42 PM · Frameworks
dfaure added a comment to D4552: [PreviewJob] Remove maximum size for local files by default.

In that case you might want to look at the fixes I just committed for https://bugs.kde.org/show_bug.cgi?id=208625

Sun, May 14, 3:04 PM · Frameworks
dfaure committed R241:162003277246: PreviewJob: skip remote directories. Too expensive to preview. (authored by dfaure).
PreviewJob: skip remote directories. Too expensive to preview.
Sun, May 14, 1:49 PM
dfaure committed R241:78c45a1ea0e2: PreviewJob: clean up empty temp file when get() fails. (authored by dfaure).
PreviewJob: clean up empty temp file when get() fails.
Sun, May 14, 1:41 PM

Sat, May 13

dfaure added inline comments to D5843: Do not use QtModule/QtClass includes.
Sat, May 13, 5:56 PM
dfaure added a comment to D5841: Don't include the same file twice.

Ouch, sorry about your toe ! :(

Sat, May 13, 5:55 PM
dfaure accepted D5843: Do not use QtModule/QtClass includes.
Sat, May 13, 5:01 PM
dfaure accepted D5842: Add missing include guards.
Sat, May 13, 5:00 PM
dfaure accepted D5841: Don't include the same file twice.
Sat, May 13, 5:00 PM
dfaure added a comment to D5841: Don't include the same file twice.

... and this is how one ends up spending his saturday clicking on web pages ;)

Sat, May 13, 5:00 PM
dfaure accepted D5840: Include own include first.
Sat, May 13, 5:00 PM
dfaure accepted D5839: Add missing license header.

oops.

Sat, May 13, 4:59 PM
dfaure accepted D5838: Use prefix increment.
Sat, May 13, 4:59 PM
dfaure accepted D5837: Fix spelling errors found by Krazy.

zat iss mouch bitter indid.

Sat, May 13, 4:53 PM
dfaure accepted D5836: Use a for loop instead of foreach.
Sat, May 13, 4:52 PM
dfaure accepted D5835: End the file with a newline character.

not really worth review :)

Sat, May 13, 4:51 PM
dfaure accepted D5834: Use single chars operation when possible.
Sat, May 13, 4:51 PM
dfaure accepted D5833: Use QPointer for modal dialogs.
Sat, May 13, 4:51 PM
dfaure accepted D5830: Remove the unused list/unlist/bookmark collection feature.

Talk about spring cleaning ;)

Sat, May 13, 4:49 PM
dfaure accepted D5829: Get EBN to ignore the 3rdparty subdir and qclasses.
Sat, May 13, 4:47 PM
dfaure added a comment to D5775: Don't include the pid in the dbus path when on flatpak.

d_ed: I use the DBus name in multi mode to talk to running processes ;-)

(for introspection, debugging, automation, etc.)
Sat, May 13, 12:22 PM · Frameworks
dfaure accepted D5774: speed up detail treeview display by avoiding too many column resizes.

I don't really know this code, but I definitely welcome such very needed speed improvements.

Sat, May 13, 12:19 PM · Frameworks
dfaure committed R108:baf114491574: Merge branch 'Plasma/5.10' (authored by dfaure).
Merge branch 'Plasma/5.10'
Sat, May 13, 10:08 AM
dfaure committed R497:218d71373fc9: New server for packaging (authored by dfaure).
New server for packaging
Sat, May 13, 10:06 AM
dfaure committed R108:bddde8d78e9a: Fix compilation without libinput. #if is used everywhere else, #ifdef is wrong. (authored by dfaure).
Fix compilation without libinput. #if is used everywhere else, #ifdef is wrong.
Sat, May 13, 10:05 AM

Fri, May 12

dfaure added a comment to R428:e410d659592c: Fix runtime warning about using QPixmap::grabWindow. Not perfect, but not worse..

I didn't actually test this with multiple screens.

Fri, May 12, 9:03 PM

Tue, May 9

dfaure added inline comments to D5564: Man ioslave: Port away from KDELibs4Support.
Tue, May 9, 11:02 AM · Plasma

Mon, May 8

dfaure created D5763: Use floating point calculations for column sizes to avoid accumulating rounding errors.
Mon, May 8, 11:28 AM

Sun, May 7

dfaure accepted D5638: Use a single QNAM (and a disk cache) for HTTP jobs.
Sun, May 7, 8:36 PM · Frameworks
dfaure accepted D5639: Internal cache for provider data on initialisation.
Sun, May 7, 5:27 PM · Frameworks
dfaure added a comment to D5638: Use a single QNAM (and a disk cache) for HTTP jobs.

50000 is 50kB.
You wrote 50 megs which would be 50000000 or 50*1024*1024.

Sun, May 7, 5:26 PM · Frameworks
dfaure added a comment to D5639: Internal cache for provider data on initialisation.

Looks simpler indeed.

Sun, May 7, 5:09 PM · Frameworks
dfaure requested changes to D5638: Use a single QNAM (and a disk cache) for HTTP jobs.
Sun, May 7, 5:05 PM · Frameworks

Sat, May 6

dfaure committed R497:031258351526: KF 5.34; implement resuming due to my flaky wifi connection (authored by dfaure).
KF 5.34; implement resuming due to my flaky wifi connection
Sat, May 6, 6:53 PM
dfaure added inline comments to D5639: Internal cache for provider data on initialisation.
Sat, May 6, 9:31 AM · Frameworks
dfaure requested changes to D5638: Use a single QNAM (and a disk cache) for HTTP jobs.
Sat, May 6, 9:17 AM · Frameworks

Fri, May 5

dfaure committed R499:10370fc430d4: plasma-framework appears to depend on kwayland (authored by dfaure).
plasma-framework appears to depend on kwayland
Fri, May 5, 10:57 PM
dfaure accepted D5658: Don't ignore tag clicks in the tooltips.
Fri, May 5, 10:42 PM
dfaure created D5724: messagelist: fix horizontal scrollbar when applying column sizes.
Fri, May 5, 10:39 PM · KDE PIM
dfaure committed R94:f049e42e151e: crypto unittests can't be run in parallel since they start/stop gpg-agent (authored by dfaure).
crypto unittests can't be run in parallel since they start/stop gpg-agent
Fri, May 5, 6:40 PM
dfaure committed R44:dc031319f50b: Fix build with CMake 3.8. (authored by cgiboudeaux).
Fix build with CMake 3.8.
Fri, May 5, 3:12 PM

Sun, Apr 30

dfaure accepted D5568: SFTP ioslave: Port away from KDELibs4Support.
Sun, Apr 30, 6:07 PM · Plasma
dfaure accepted D5569: thumbnail ioslave: Port away from KDELibs4Support.

Easy one ;-)

Sun, Apr 30, 5:54 PM · Plasma
dfaure requested changes to D5568: SFTP ioslave: Port away from KDELibs4Support.
Sun, Apr 30, 2:46 PM · Plasma
dfaure accepted D5567: Settings ioslave: Port away from KDELibs4Support.
Sun, Apr 30, 2:23 PM · Plasma
dfaure accepted D5566: recentdocuments ioslave: Port away from KDELibs4Support.
Sun, Apr 30, 1:26 PM · Plasma
dfaure accepted D5562: Fish ioslave: Port away from KDELibs4Support.

Nice work.

Sun, Apr 30, 10:11 AM · Plasma
dfaure accepted D5561: Filter ioslave: Port away from KDELibs4Support.

Thanks!

Sun, Apr 30, 10:09 AM · Plasma
dfaure accepted D5560: Archive ioslave: Port away from KDELibs4Support.
Sun, Apr 30, 10:08 AM · Plasma
dfaure added a comment to D4911: add Baloo DBus signals for moved or removed files.

Could this be made more lightweight by adding a precise subscription method rather than signal broadcasts?

Sun, Apr 30, 10:05 AM · Frameworks
dfaure accepted D5446: Implement support for selected mime type filters.
Sun, Apr 30, 9:57 AM · Plasma

Apr 18 2017

dfaure committed R174:5de361ff80ce: VCardParser: gain 1% of performance by using indexOf+mid instead of split('\n') (authored by dfaure).
VCardParser: gain 1% of performance by using indexOf+mid instead of split('\n')
Apr 18 2017, 9:35 AM

Apr 17 2017

dfaure committed R174:24a0f2129594: VCardParser: extract class for parsing the current line (authored by dfaure).
VCardParser: extract class for parsing the current line
Apr 17 2017, 11:32 PM
dfaure committed R174:93f6aaf44613: VCardParser: rewrite parser to use a state machine instead of split() (authored by dfaure).
VCardParser: rewrite parser to use a state machine instead of split()
Apr 17 2017, 11:32 PM
dfaure committed R174:629d3e73c73e: Revert 1760aca (which commented out some unittests...). (authored by dfaure).
Revert 1760aca (which commented out some unittests...).
Apr 17 2017, 11:32 PM
dfaure added a reverting commit for R174:1760aca6e92a: Reimplement parsing: R174:629d3e73c73e: Revert 1760aca (which commented out some unittests...)..
Apr 17 2017, 11:32 PM
dfaure committed R94:20cfe6716810: Merge remote-tracking branch 'origin/Applications/17.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/17.04'
Apr 17 2017, 11:28 AM
dfaure committed R94:2aecb813b87d: [autotests] repair mailwebenginescripttest after my changes in 37b99257 (authored by dfaure).
[autotests] repair mailwebenginescripttest after my changes in 37b99257
Apr 17 2017, 11:25 AM

Apr 16 2017

dfaure added a comment to D5394: KAuth integration in document saving - vol. 2.

Would it help if QSaveFile had an API to set more restrictive permissions on the temp file?

Apr 16 2017, 8:18 AM · Frameworks, KTextEditor
dfaure accepted D5413: makes KArchive be optional and do not build extractors needing it.
Apr 16 2017, 7:47 AM · Frameworks

Apr 15 2017

dfaure accepted D5368: http slave: send error page after authorization failure.

OK then ;)

Apr 15 2017, 6:10 PM · Frameworks
dfaure added inline comments to D5446: Implement support for selected mime type filters.
Apr 15 2017, 9:07 AM · Plasma
dfaure added a comment to D5413: makes KArchive be optional and do not build extractors needing it.

Isn't this missing a "set_package_properties .. TYPE OPTIONAL" so that the user is told about the optional deps they're missing?
Not sure if that works for KF5 components.

Apr 15 2017, 8:31 AM · Frameworks
dfaure added a comment to D5368: http slave: send error page after authorization failure.

Seems consistent with the code further down, but I'm really puzzled because this code was the same in kdelibs4... Anyone with konqueror4 to test this? Otherwise I can do that in the office, 10 days from now.

Apr 15 2017, 8:24 AM · Frameworks
dfaure accepted D5030: kioexec: delegate upload to a kded module.

Feel free to push after that last fix.

Apr 15 2017, 8:14 AM · Frameworks
dfaure added inline comments to D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties.
Apr 15 2017, 8:04 AM · Frameworks
dfaure requested changes to D5446: Implement support for selected mime type filters.
Apr 15 2017, 8:00 AM · Plasma

Apr 14 2017

dfaure committed R230:1bd03e8e6bb0: Merge remote-tracking branch 'origin/Applications/17.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/17.04'
Apr 14 2017, 11:43 AM
dfaure committed R230:7bf556985cd3: Fix infinite recursion in cxxmetric when having a dir with spaces. (authored by dfaure).
Fix infinite recursion in cxxmetric when having a dir with spaces.
Apr 14 2017, 11:42 AM

Apr 10 2017

dfaure committed R94:9ddb27721056: Port isScrolledToBottom from jQuery to standard DOM, so it works even when… (authored by dfaure).
Port isScrolledToBottom from jQuery to standard DOM, so it works even when…
Apr 10 2017, 8:15 AM

Apr 9 2017

dfaure committed R94:37b992574c9c: Rework timing of script injection for showing attachments in message viewer. (authored by dfaure).
Rework timing of script injection for showing attachments in message viewer.
Apr 9 2017, 5:48 PM
dfaure committed R206:ec5c3703fcaf: SearchDialog: improve performance by caching collection full paths. (authored by dfaure).
SearchDialog: improve performance by caching collection full paths.
Apr 9 2017, 3:29 PM
dfaure committed R44:57206b8243a6: Add remote ID information to "Corrupt Event", to make debugging possible. (authored by dfaure).
Add remote ID information to "Corrupt Event", to make debugging possible.
Apr 9 2017, 2:44 PM