dfaure (David Faure)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (259 w, 2 d)
Availability
Available

Recent Activity

Today

dfaure committed R865:d3737478acd6: Implement completion for emojis (authored by dfaure).
Implement completion for emojis
Sat, Feb 22, 11:34 AM
dfaure committed R865:05f4e9e16508: Skip "modifier" category (authored by dfaure).
Skip "modifier" category
Sat, Feb 22, 11:34 AM
dfaure committed R865:cb4534e68aef: Finish removing EmojiManager::unicodeEmojiMap() (authored by dfaure).
Finish removing EmojiManager::unicodeEmojiMap()
Sat, Feb 22, 11:34 AM
dfaure committed R865:fef3b398a259: Add EmojiManager::categories, use that for the categories model (authored by dfaure).
Add EmojiManager::categories, use that for the categories model
Sat, Feb 22, 11:34 AM
dfaure accepted D27539: KIO::iconNameForUrl: fix searching for kde protocol icons.
Sat, Feb 22, 10:48 AM · Frameworks
dfaure requested changes to D27539: KIO::iconNameForUrl: fix searching for kde protocol icons.
Sat, Feb 22, 10:38 AM · Frameworks
dfaure added a comment to D27539: KIO::iconNameForUrl: fix searching for kde protocol icons.

This is about an icon name. Apps don't (shouldn't) "check the value".

Sat, Feb 22, 9:14 AM · Frameworks
dfaure requested changes to D27097: Port from QRegExp to QRegularExpression.

OK for deprecating Incremental. A full revert (at KF6 time) of commit 9ac82e27ad0322e444c16 looks tricky though :-)
I searched the git history, and I can't see where we ever used FindIncremental... [I searched kdelibs, since I'm pretty sure this was added for KHTML]

Sat, Feb 22, 9:11 AM · Frameworks
dfaure requested changes to D27153: port sftp to Result system to force serialization of error/finish condition.

Nice work! Found 2 bugs though.

Sat, Feb 22, 8:52 AM · Frameworks, Dolphin
dfaure accepted D27451: Drop KToolInvocation support from KRun::runService.

This makes runService and runApplication almost the same, right?

Sat, Feb 22, 8:34 AM · Frameworks
dfaure committed R865:ae5b5432d0bb: Rebaes EmojiFilterModel on top of EmojiModel, as a QSortFilterProxyModel (authored by dfaure).
Rebaes EmojiFilterModel on top of EmojiModel, as a QSortFilterProxyModel
Sat, Feb 22, 12:06 AM
dfaure committed R865:057e2b9e5c14: New class EmoticonModel, to list all emoticons (authored by dfaure).
New class EmoticonModel, to list all emoticons
Sat, Feb 22, 12:06 AM

Yesterday

dfaure added a comment to D27539: KIO::iconNameForUrl: fix searching for kde protocol icons.

kfileitemtest still passes?

Fri, Feb 21, 5:22 PM · Frameworks
dfaure added a comment to D27230: Move accounts overview to the LHS.

How about we do this more like in KMail ?

Fri, Feb 21, 4:12 PM
dfaure committed R865:f87428538c85: Rename EmoticonModel to EmoticonFilterModel, since it filters on one category (authored by dfaure).
Rename EmoticonModel to EmoticonFilterModel, since it filters on one category
Fri, Feb 21, 9:16 AM
dfaure committed R865:bb86af6f5475: Rename to unicodeEmojiMap, get it directly from the emojimanager (authored by dfaure).
Rename to unicodeEmojiMap, get it directly from the emojimanager
Fri, Feb 21, 9:16 AM
dfaure committed R865:2efed740b10d: Add some documentation on the emoji completion code (authored by dfaure).
Add some documentation on the emoji completion code
Fri, Feb 21, 8:16 AM

Thu, Feb 20

dfaure committed R865:f43a10655598: Remove duplicated code (authored by dfaure).
Remove duplicated code
Thu, Feb 20, 9:34 PM
dfaure committed R865:7aae241d3266: Reverse if() condition to simplify loop bodies (no need for "continue") (authored by dfaure).
Reverse if() condition to simplify loop bodies (no need for "continue")
Thu, Feb 20, 9:29 PM
dfaure committed R865:26fb49c996e2: Use KCategorizedView for the emoticon menu widget (authored by dfaure).
Use KCategorizedView for the emoticon menu widget
Thu, Feb 20, 9:02 PM
dfaure added a comment to D27230: Move accounts overview to the LHS.

Yes, I like it too.

Thu, Feb 20, 6:17 PM
dfaure committed R865:d49852accb88: Sort emoticons by the order specified in the json file (authored by dfaure).
Sort emoticons by the order specified in the json file
Thu, Feb 20, 8:41 AM

Wed, Feb 19

dfaure committed R865:da4049b0766f: Fix range-for usage to avoid a detach (authored by dfaure).
Fix range-for usage to avoid a detach
Wed, Feb 19, 8:38 PM
dfaure committed R865:21c084f0cbe3: Simplify code (no need to take + reinsert, [] is much simpler) (authored by dfaure).
Simplify code (no need to take + reinsert, [] is much simpler)
Wed, Feb 19, 8:35 PM
dfaure committed R865:d8969f167a89: Fix bug in my refactoring of UnicodeEmoticon::escapeUnicodeEmoji (authored by dfaure).
Fix bug in my refactoring of UnicodeEmoticon::escapeUnicodeEmoji
Wed, Feb 19, 8:28 PM
dfaure committed R385:680bf57438aa: Fix compilation with Qt 5.15 (authored by dfaure).
Fix compilation with Qt 5.15
Wed, Feb 19, 3:37 PM
dfaure committed R342:6835890ac2f8: Fix compilation with Qt 5.15 (authored by dfaure).
Fix compilation with Qt 5.15
Wed, Feb 19, 3:36 PM
dfaure committed R382:4377fa6648b6: Fix compilation with Qt 5.15 (authored by dfaure).
Fix compilation with Qt 5.15
Wed, Feb 19, 3:14 PM
dfaure committed R122:0fa63b8685f8: Fix compilation with Qt 5.15, this hit the time bomb too (authored by dfaure).
Fix compilation with Qt 5.15, this hit the time bomb too
Wed, Feb 19, 2:58 PM
dfaure committed R348:ffe81b780fdd: Fix compilation with Qt 5.15 (authored by dfaure).
Fix compilation with Qt 5.15
Wed, Feb 19, 2:56 PM
dfaure committed R420:9ac419d13ad7: Fix compilation with Qt 5.15 (authored by dfaure).
Fix compilation with Qt 5.15
Wed, Feb 19, 2:03 PM
dfaure committed R420:6bb919618c96: Fix using 0 for a flags (authored by mlaurent).
Fix using 0 for a flags
Wed, Feb 19, 2:00 PM

Tue, Feb 18

dfaure added a comment to D27459: Port QLinkedList which is deprecated in qt5.15.

This code only seems to do append() and contains(), a QVector (contiguous area of memory) is better than a std::list (individual nodes spread all over the memory, more cache lines to load)

Tue, Feb 18, 1:04 PM · Frameworks

Mon, Feb 17

dfaure accepted D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups.
Mon, Feb 17, 9:33 PM · Frameworks
dfaure committed R374:bb58f9f10b6d: Port to KFileCustomDialog (authored by dfaure).
Port to KFileCustomDialog
Mon, Feb 17, 7:25 PM
dfaure closed D26645: Port to KFileCustomDialog.
Mon, Feb 17, 6:02 PM
dfaure committed R865:c4ca333c6c52: Simplify UnicodeEmoticon::escapeUnicodeEmoji (authored by dfaure).
Simplify UnicodeEmoticon::escapeUnicodeEmoji
Mon, Feb 17, 10:18 AM

Sun, Feb 16

dfaure committed R865:aaca47d27cb3: Use more complete emoji.json from https://github.com/joypixels/emoji-toolkit (authored by dfaure).
Use more complete emoji.json from https://github.com/joypixels/emoji-toolkit
Sun, Feb 16, 10:09 PM
dfaure added a comment to T12708: Drop units singleton being exported from the Kirigami desktop theme plugin.

I'm confused. The units singleton shouldn't be exported but Kirigami.Units is fine? What's the difference?

Sun, Feb 16, 9:25 PM · KF6
dfaure requested changes to D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups.

Well, I'm not the KConfig maintainer, mdawson is :-)

Sun, Feb 16, 9:53 AM · Frameworks

Sat, Feb 15

dfaure committed R865:b5582f82661c: Support custom emojis as reactions (authored by dfaure).
Support custom emojis as reactions
Sat, Feb 15, 10:35 PM
dfaure committed R865:4b9a1fdc1308: Extract class PixmapCache from MessageDelegateHelperImage. (authored by dfaure).
Extract class PixmapCache from MessageDelegateHelperImage.
Sat, Feb 15, 7:11 PM
dfaure added a comment to T12641: Refactor KFileProtocol::copy.

I don't really understand the relation to ksmserver, surely kioslaves are not part of session management.

Sat, Feb 15, 6:55 PM · Dolphin, Frameworks
dfaure committed R865:a9b228e7fd93: Fix unittest regression introduced by my logout fix (authored by dfaure).
Fix unittest regression introduced by my logout fix
Sat, Feb 15, 11:16 AM
dfaure committed R865:b7dc58bd01e5: Don't create directories in ManagerDataPaths (authored by dfaure).
Don't create directories in ManagerDataPaths
Sat, Feb 15, 10:36 AM
dfaure committed R865:f4439f58e2e4: Add method EmojiManager::customEmojiFileName and unittest it (authored by dfaure).
Add method EmojiManager::customEmojiFileName and unittest it
Sat, Feb 15, 9:11 AM
dfaure committed R865:37b6fe36543d: Extract methods Emoji::emojiUrl()/emojiFileName() and unittest them (authored by dfaure).
Extract methods Emoji::emojiUrl()/emojiFileName() and unittest them
Sat, Feb 15, 9:11 AM

Fri, Feb 14

dfaure closed D27387: Re-enable auto-reconnect, after fixing logout..
Fri, Feb 14, 8:20 PM
dfaure committed R865:157baeae33a8: Re-enable auto-reconnect, after fixing logout. (authored by dfaure).
Re-enable auto-reconnect, after fixing logout.
Fri, Feb 14, 8:20 PM

Thu, Feb 13

dfaure requested review of D27387: Re-enable auto-reconnect, after fixing logout..
Thu, Feb 13, 11:00 PM
dfaure committed R865:2d84bad703da: Fix minimumSizeHint of MessageTextEdit (authored by dfaure).
Fix minimumSizeHint of MessageTextEdit
Thu, Feb 13, 1:43 PM
dfaure committed R865:79b666b5999f: Widgets: move cursor to end when editing (authored by dfaure).
Widgets: move cursor to end when editing
Thu, Feb 13, 1:43 PM

Wed, Feb 12

dfaure committed R865:e75b00d34b80: Handle HTTP errors in RestApiAbstractJob::emitFailedMessage. (authored by dfaure).
Handle HTTP errors in RestApiAbstractJob::emitFailedMessage.
Wed, Feb 12, 8:52 AM

Tue, Feb 11

dfaure accepted D27317: RocketChatAccount: Try to reduce delegating funcs.
Tue, Feb 11, 10:22 PM
dfaure committed R865:d01fff23e778: Repair autocompletion for QML, improve API for Widgets (authored by dfaure).
Repair autocompletion for QML, improve API for Widgets
Tue, Feb 11, 9:27 AM
dfaure committed R865:57a0e6c806b7: Fix cursor position after autocompletion. (authored by dfaure).
Fix cursor position after autocompletion.
Tue, Feb 11, 7:48 AM
dfaure committed R865:e3a2348fb571: Reduce noise (authored by dfaure).
Reduce noise
Tue, Feb 11, 7:48 AM

Mon, Feb 10

dfaure added a comment to D27291: install smb as both smb:// and cifs://.

feverfew: you're probably looking at master while this is a patch for the 19.12 branch.
See https://phabricator.kde.org/D26358 which happened in master.

Mon, Feb 10, 10:26 PM · Frameworks, Dolphin
dfaure added a comment to D27291: install smb as both smb:// and cifs://.

Both are supported, but indeed json is preferred over installed .protocol files.

Mon, Feb 10, 10:24 PM · Frameworks, Dolphin
dfaure committed R883:1562067: 5.67.1.
5.67.1
Mon, Feb 10, 10:17 PM
dfaure committed R865:5a9cccbcba93: MessageTextEdit: allow Up/Down also when a single paragraph wraps (authored by dfaure).
MessageTextEdit: allow Up/Down also when a single paragraph wraps
Mon, Feb 10, 9:40 AM
dfaure committed R865:9b8eb2fe7706: Widgets: grow the input textedit with the number of lines in the message (authored by dfaure).
Widgets: grow the input textedit with the number of lines in the message
Mon, Feb 10, 9:03 AM

Sun, Feb 9

dfaure committed R865:896e8ce30a84: Rename MessageLineEdit to MessageTextEdit (authored by dfaure).
Rename MessageLineEdit to MessageTextEdit
Sun, Feb 9, 11:06 PM
dfaure committed R865:509a7c42c48a: Port MessageLineEdit to CompletionTextEdit. (authored by dfaure).
Port MessageLineEdit to CompletionTextEdit.
Sun, Feb 9, 10:59 PM
dfaure committed R865:bcb07ab5c2de: Add CompletionTextEdit, based on CompletionLineEdit. Unused yet. (authored by dfaure).
Add CompletionTextEdit, based on CompletionLineEdit. Unused yet.
Sun, Feb 9, 10:13 PM
dfaure committed R242:8e786761fef3: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:29 PM
dfaure committed R312:6ad8ef811557: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:29 PM
dfaure committed R96:21cc6ff731f9: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:28 PM
dfaure committed R39:0ace8fac4270: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:28 PM
dfaure committed R309:7a25c6f03d3c: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:28 PM
dfaure committed R858:d70a3b524948: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:28 PM
dfaure committed R308:fe38be3efce9: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:28 PM
dfaure committed R495:495adab36d8c: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:28 PM
dfaure committed R307:e9b1d3afa57d: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:28 PM
dfaure committed R263:ae9fbd9ed01a: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:28 PM
dfaure committed R289:fd0bcf411b9b: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:28 PM
dfaure committed R311:dbc8db9eda1c: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:28 PM
dfaure committed R304:68a26ad03f5f: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:28 PM
dfaure committed R292:73ac2675497c: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:28 PM
dfaure committed R310:c410c5ee8ff4: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:27 PM
dfaure committed R241:b7028dbc9167: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:27 PM
dfaure committed R291:502254acde84: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:27 PM
dfaure committed R306:41e5bb10fd3e: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:27 PM
dfaure committed R302:617d782620e6: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:27 PM
dfaure committed R290:2616443aed6f: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:27 PM
dfaure committed R305:0c40b2b59127: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:27 PM
dfaure committed R268:834a63a5fd24: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:27 PM
dfaure committed R301:e38b47538406: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:27 PM
dfaure committed R316:4a5fb71c8063: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:27 PM
dfaure committed R315:9be4d202a07d: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:27 PM
dfaure committed R288:1b9e00460388: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:26 PM
dfaure committed R296:9127da0c12e0: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:26 PM
dfaure committed R303:b824f0f6789f: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:26 PM
dfaure committed R287:5c66570b9e64: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:26 PM
dfaure committed R265:13e31825f4bb: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:26 PM
dfaure committed R286:c2be9629c653: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:26 PM
dfaure committed R295:11f1b40cf5d9: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:26 PM
dfaure committed R238:b05f529f65db: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:26 PM
dfaure committed R283:b9d53fee20c6: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:26 PM
dfaure committed R299:0739d302aeaa: GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sun, Feb 9, 7:26 PM