dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (111 w, 2 d)
Availability
Available

Recent Activity

Tue, Apr 18

dfaure committed R174:5de361ff80ce: VCardParser: gain 1% of performance by using indexOf+mid instead of split('\n') (authored by dfaure).
VCardParser: gain 1% of performance by using indexOf+mid instead of split('\n')
Tue, Apr 18, 9:35 AM

Mon, Apr 17

dfaure committed R174:24a0f2129594: VCardParser: extract class for parsing the current line (authored by dfaure).
VCardParser: extract class for parsing the current line
Mon, Apr 17, 11:32 PM
dfaure committed R174:93f6aaf44613: VCardParser: rewrite parser to use a state machine instead of split() (authored by dfaure).
VCardParser: rewrite parser to use a state machine instead of split()
Mon, Apr 17, 11:32 PM
dfaure committed R174:629d3e73c73e: Revert 1760aca (which commented out some unittests...). (authored by dfaure).
Revert 1760aca (which commented out some unittests...).
Mon, Apr 17, 11:32 PM
dfaure added a reverting commit for R174:1760aca6e92a: Reimplement parsing: R174:629d3e73c73e: Revert 1760aca (which commented out some unittests...)..
Mon, Apr 17, 11:32 PM
dfaure committed R94:20cfe6716810: Merge remote-tracking branch 'origin/Applications/17.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/17.04'
Mon, Apr 17, 11:28 AM
dfaure committed R94:2aecb813b87d: [autotests] repair mailwebenginescripttest after my changes in 37b99257 (authored by dfaure).
[autotests] repair mailwebenginescripttest after my changes in 37b99257
Mon, Apr 17, 11:25 AM

Sun, Apr 16

dfaure added a comment to D5394: KAuth integration in document saving - vol. 2.

Would it help if QSaveFile had an API to set more restrictive permissions on the temp file?

Sun, Apr 16, 8:18 AM · Frameworks, KTextEditor
dfaure accepted D5413: makes KArchive be optional and do not build extractors needing it.
Sun, Apr 16, 7:47 AM · Frameworks

Sat, Apr 15

dfaure accepted D5368: http slave: send error page after authorization failure.

OK then ;)

Sat, Apr 15, 6:10 PM · Frameworks
dfaure added inline comments to D5446: Implement support for selected mime type filters.
Sat, Apr 15, 9:07 AM · Plasma
dfaure added a comment to D5413: makes KArchive be optional and do not build extractors needing it.

Isn't this missing a "set_package_properties .. TYPE OPTIONAL" so that the user is told about the optional deps they're missing?
Not sure if that works for KF5 components.

Sat, Apr 15, 8:31 AM · Frameworks
dfaure added a comment to D5368: http slave: send error page after authorization failure.

Seems consistent with the code further down, but I'm really puzzled because this code was the same in kdelibs4... Anyone with konqueror4 to test this? Otherwise I can do that in the office, 10 days from now.

Sat, Apr 15, 8:24 AM · Frameworks
dfaure accepted D5030: kioexec: delegate upload to a kded module.

Feel free to push after that last fix.

Sat, Apr 15, 8:14 AM · Frameworks
dfaure added inline comments to D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties.
Sat, Apr 15, 8:04 AM · Frameworks
dfaure requested changes to D5446: Implement support for selected mime type filters.
Sat, Apr 15, 8:00 AM · Plasma

Fri, Apr 14

dfaure committed R230:1bd03e8e6bb0: Merge remote-tracking branch 'origin/Applications/17.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/17.04'
Fri, Apr 14, 11:43 AM
dfaure committed R230:7bf556985cd3: Fix infinite recursion in cxxmetric when having a dir with spaces. (authored by dfaure).
Fix infinite recursion in cxxmetric when having a dir with spaces.
Fri, Apr 14, 11:42 AM

Mon, Apr 10

dfaure committed R94:9ddb27721056: Port isScrolledToBottom from jQuery to standard DOM, so it works even when… (authored by dfaure).
Port isScrolledToBottom from jQuery to standard DOM, so it works even when…
Mon, Apr 10, 8:15 AM

Sun, Apr 9

dfaure committed R94:37b992574c9c: Rework timing of script injection for showing attachments in message viewer. (authored by dfaure).
Rework timing of script injection for showing attachments in message viewer.
Sun, Apr 9, 5:48 PM
dfaure committed R206:ec5c3703fcaf: SearchDialog: improve performance by caching collection full paths. (authored by dfaure).
SearchDialog: improve performance by caching collection full paths.
Sun, Apr 9, 3:29 PM
dfaure committed R44:57206b8243a6: Add remote ID information to "Corrupt Event", to make debugging possible. (authored by dfaure).
Add remote ID information to "Corrupt Event", to make debugging possible.
Sun, Apr 9, 2:44 PM
dfaure committed R94:7d2ad8ca0024: [autotests] more work towards stable autotests (authored by dfaure).
[autotests] more work towards stable autotests
Sun, Apr 9, 1:20 PM
dfaure committed R94:66262c2a6ba1: [autotests] Let's see if this fixes the flakiness of the test (authored by dfaure).
[autotests] Let's see if this fixes the flakiness of the test
Sun, Apr 9, 12:56 PM
dfaure committed R94:3383346119f8: [autotests] Enable test mode in QStandardPaths to avoid interference from user… (authored by dfaure).
[autotests] Enable test mode in QStandardPaths to avoid interference from user…
Sun, Apr 9, 11:59 AM
dfaure committed R94:ea995fa89819: GIT_SILENT oops revert unwanted changes (authored by dfaure).
GIT_SILENT oops revert unwanted changes
Sun, Apr 9, 9:18 AM
dfaure committed R94:e6899bbabd49: [autotest] avoid timeout due to waiting for klauncher to exit (authored by dfaure).
[autotest] avoid timeout due to waiting for klauncher to exit
Sun, Apr 9, 9:15 AM
dfaure abandoned D5358: KMime: reduce memory allocations by using QLatin1String for appending to QString.

heaptrack shows that this actually makes things worse (same number of allocations, but on top of that it leads to more pre-allocated data in QString (note that the destination is empty, at least in parseAtom/parseToken - I just changed to '=' instead of "+=" to make that clearer).

Sun, Apr 9, 9:07 AM · KDE PIM
dfaure committed R180:ac3e6a7d6700: Minor optimization, the destination is always empty anyway. (authored by dfaure).
Minor optimization, the destination is always empty anyway.
Sun, Apr 9, 9:05 AM
dfaure created D5358: KMime: reduce memory allocations by using QLatin1String for appending to QString.
Sun, Apr 9, 8:33 AM · KDE PIM

Sat, Apr 8

dfaure committed R180:22d2b360ab95: autotest: give the data rows different names, otherwise debugging gets really… (authored by dfaure).
autotest: give the data rows different names, otherwise debugging gets really…
Sat, Apr 8, 5:07 PM
dfaure committed R42:a9395be18bc8: Merge remote-tracking branch 'origin/Applications/17.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/17.04'
Sat, Apr 8, 12:39 PM
dfaure committed R42:7be68f22ac3b: Don't get hit forever by an old setting from baloorc when hand-editing the… (authored by dfaure).
Don't get hit forever by an old setting from baloorc when hand-editing the…
Sat, Apr 8, 12:38 PM
dfaure closed D5349: Don't get hit forever by an old setting from baloorc when hand-editing the agent rc file. by committing R42:7be68f22ac3b: Don't get hit forever by an old setting from baloorc when hand-editing the….
Sat, Apr 8, 12:38 PM · KDE PIM
dfaure committed R44:662b8677ce17: Improve debug output for the MyRights noise (which shouldn't happen anymore ;) (authored by dfaure).
Improve debug output for the MyRights noise (which shouldn't happen anymore ;)
Sat, Apr 8, 12:20 PM
dfaure created D5349: Don't get hit forever by an old setting from baloorc when hand-editing the agent rc file..
Sat, Apr 8, 10:52 AM · KDE PIM
dfaure committed R44:563dc3e3f6fa: Merge remote-tracking branch 'origin/Applications/17.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/17.04'
Sat, Apr 8, 10:39 AM
dfaure committed R44:50e13e4ad975: SessionPool: set the namespaces variables from the namespace job. (authored by dfaure).
SessionPool: set the namespaces variables from the namespace job.
Sat, Apr 8, 10:38 AM
dfaure committed R44:8ac1c8fef041: SessionPool: set the namespaces variables from the namespace job. (authored by dfaure).
SessionPool: set the namespaces variables from the namespace job.
Sat, Apr 8, 10:38 AM
dfaure closed D5347: SessionPool: set the namespaces variables from the namespace job. by committing R44:8ac1c8fef041: SessionPool: set the namespaces variables from the namespace job..
Sat, Apr 8, 10:37 AM · KDE PIM
dfaure accepted D5348: Remove dead code in Akonadi::StorageSettings.

If it's dead, it's dead.

Sat, Apr 8, 9:34 AM
dfaure created D5347: SessionPool: set the namespaces variables from the namespace job..
Sat, Apr 8, 9:29 AM · KDE PIM

Fri, Apr 7

dfaure added a comment to D5030: kioexec: delegate upload to a kded module.

Good point, I added a destructor to KIOD now, please try again ;)

Fri, Apr 7, 6:44 AM · Frameworks
dfaure committed R241:6fb63b15f9ce: Delete kiod modules on exit (authored by dfaure).
Delete kiod modules on exit
Fri, Apr 7, 6:38 AM

Thu, Apr 6

dfaure accepted D5319: Generate a moc_predefs.h file for KIOCore.

Thanks. I don't agree that it was a small optimization, because regenerating a header file means recompiling all the files that include it, every single time. It's the job of a build system to make sure this doesn't happen, to save developer time ;)

Thu, Apr 6, 5:21 PM · Frameworks
dfaure added a comment to D5030: kioexec: delegate upload to a kded module.

Yes, that should be it. And for good practice, rather than hardcoding kded5 or kiod5 in the calling code, create a dbus .service file to autostart it (two purposes: making it independent from whoever is hosting the service, and starting kiod if it's not already running). See kio/src/kpasswdserver for an example.

Thu, Apr 6, 4:45 PM · Frameworks
dfaure added inline comments to D5319: Generate a moc_predefs.h file for KIOCore.
Thu, Apr 6, 3:43 PM · Frameworks

Wed, Apr 5

dfaure added a comment to D5302: Use -Wno-gnu-zero-variadic-macro-arguments more.

5.33 is tagged since last saturday, you can push without waiting. It's always summer in master, for KF5.

Wed, Apr 5, 11:57 AM · Build System, Frameworks

Mon, Apr 3

dfaure committed R241:fff13bf08667: kioexec: fix support for --suggestedfilename (authored by dfaure).
kioexec: fix support for --suggestedfilename
Mon, Apr 3, 1:41 PM
dfaure committed R94:9e5557d8bdc8: Merge remote-tracking branch 'origin/Applications/17.04' (authored by dfaure).
Merge remote-tracking branch 'origin/Applications/17.04'
Mon, Apr 3, 7:02 AM
dfaure committed R94:14728b61a24f: Fix gpgsm processes being leaked due to QGpgME::KeyListJob not being deleted (authored by dfaure).
Fix gpgsm processes being leaked due to QGpgME::KeyListJob not being deleted
Mon, Apr 3, 7:01 AM

Sun, Apr 2

dfaure committed R81:ff2cc0a28cb0: Pass calendar from memento to itiphandler to avoid loading it all over again. (authored by dfaure).
Pass calendar from memento to itiphandler to avoid loading it all over again.
Sun, Apr 2, 6:41 PM
dfaure closed D5280: Pass calendar from memento to itiphandler to avoid loading it all over again. by committing R81:ff2cc0a28cb0: Pass calendar from memento to itiphandler to avoid loading it all over again..
Sun, Apr 2, 6:40 PM · KDE PIM
dfaure created D5280: Pass calendar from memento to itiphandler to avoid loading it all over again..
Sun, Apr 2, 4:06 PM · KDE PIM
dfaure committed R81:4222ba75a3f8: Make "todo akonadi port" message more precise (authored by dfaure).
Make "todo akonadi port" message more precise
Sun, Apr 2, 4:05 PM

Sat, Apr 1

dfaure committed R174:9bb2ecda19b4: More work on VCardParser performance (authored by dfaure).
More work on VCardParser performance
Sat, Apr 1, 8:57 PM

Fri, Mar 31

dfaure accepted D5221: [desktop:/ KIO] Add descriptive name for root item.
Fri, Mar 31, 8:58 PM · Plasma

Thu, Mar 30

dfaure committed R230:fbc3409a2520: Merge branch 'Applications/17.04' (authored by dfaure).
Merge branch 'Applications/17.04'
Thu, Mar 30, 4:43 PM
dfaure committed R230:742db5352476: add support for svn, and for falling back to "mv" when the file isn't added to… (authored by dfaure).
add support for svn, and for falling back to "mv" when the file isn't added to…
Thu, Mar 30, 4:42 PM

Wed, Mar 29

dfaure requested changes to D5221: [desktop:/ KIO] Add descriptive name for root item.
Wed, Mar 29, 7:11 AM · Plasma
dfaure accepted D4847: KAuth integration in document saving.
Wed, Mar 29, 7:05 AM · KTextEditor, Frameworks
dfaure accepted D5112: Make archiver ioslave extensible.

Looks OK. It would be good to port this away from kdelibs4support though, to avoid propagating that dependency on users of the lib -- making it impossible to remove later.
At least it should be removed as a public dependency (in the target_link_libraries line and from KioArchiveConfig.cmake.in).

Wed, Mar 29, 6:56 AM · Plasma
dfaure accepted D5056: [KCModuleProxy] Remove dead code.

I don't know anything about this code, but if it's dead, it's dead.

Wed, Mar 29, 6:45 AM · Frameworks

Tue, Mar 28

dfaure requested changes to D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata.
Tue, Mar 28, 6:37 AM · Plasma
dfaure accepted D5206: Save/restore window size.

Heh, of course. Simple fix ;) Thanks !

Tue, Mar 28, 6:26 AM
dfaure added a comment to D5112: Make archiver ioslave extensible.

Yeah KF5Konq is a bug, it shouldn't be named that way.

Tue, Mar 28, 6:26 AM · Plasma

Mon, Mar 27

dfaure requested changes to D5030: kioexec: delegate upload to a kded module.
Mon, Mar 27, 8:02 PM · Frameworks
dfaure added a comment to D5030: kioexec: delegate upload to a kded module.

Nice idea.

Mon, Mar 27, 7:54 PM · Frameworks
dfaure added a comment to D5112: Make archiver ioslave extensible.

The idea sounds OK to me.

Mon, Mar 27, 7:40 PM · Plasma
dfaure added a comment to D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'..

So bin isn't in %PATH%, but found relatively to the app being run?

Mon, Mar 27, 7:37 PM · Frameworks
dfaure accepted D5199: Reflect trash state in iconNameForUrl.

Yep it means parsing a file, but that file is exactly 2 lines long and this is only done when asking about trash:/ so I think it's fine.

Mon, Mar 27, 5:10 PM · Frameworks
dfaure added inline comments to D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'..
Mon, Mar 27, 6:50 AM · Frameworks
dfaure added a comment to D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'..

Well I would accept a compromise, where dbus-started services get installed in bin on Unix as well.
Which means still only two install vars and dirs: bin and libexec. With consistency between Unix and Windows about whether a given executable gets installed into bin or libexec.

Mon, Mar 27, 6:46 AM · Frameworks

Sun, Mar 26

dfaure accepted D5185: prevent signals in glib2 be defined by QT.

Ah, networkmanager-qt itself uses KDEFrameworkCompilerSettings so it gets -DQT_NO_SIGNALS_SLOTS_KEYWORDS, i.e. signals isn't defined.
But indeed this is an installed public header, so the fix is necessary for apps that don't use these settings.

Sun, Mar 26, 4:58 PM · Frameworks
dfaure accepted D5181: API dox: fix missing note to call setXMLFile with KParts::MainWindow.

I agree.
The person who wrote this API doc was aiming for something slightly simpler (one less method to call), but my original design was for everyone to call setXMLFile, and it would make things a bit weird at the kxmlguiwindow level.

Sun, Mar 26, 4:56 PM · Frameworks
dfaure accepted D5184: Accept single line command options like we used to do.

I'd rather we fix kfmclient.cpp to add the missing dash, but OK, if we care for command-line compatibility with KDE4 era then we should use ParseAsLongOptions.... everywhere...

Sun, Mar 26, 4:49 PM
dfaure added a comment to D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'..

If "findable by dbus services" is the only argument for polluting bin with libexec binaries on Windows, then it doesn't apply to *everything* in libexec, only to a handful of executables.

Sun, Mar 26, 3:02 PM · Frameworks
dfaure added a comment to D5181: API dox: fix missing note to call setXMLFile with KParts::MainWindow.

Seems right. The alternative is to make it work.
Not sure which solution is better.

Sun, Mar 26, 2:53 PM · Frameworks

Sat, Mar 25

dfaure committed R229:d72ab46df887: Fix kdialog --progress, thanks to Thiago. (authored by dfaure).
Fix kdialog --progress, thanks to Thiago.
Sat, Mar 25, 9:56 PM
dfaure committed R229:da7c7c8218fc: KDialog: use separate process to handle the progress dialog case. (authored by dfaure).
KDialog: use separate process to handle the progress dialog case.
Sat, Mar 25, 2:57 PM
dfaure added a comment to D4847: KAuth integration in document saving.

Looks good to me. Just some minor things I noticed.

Sat, Mar 25, 10:50 AM · KTextEditor, Frameworks

Fri, Mar 24

dfaure committed R199:41cf344072b2: Fix "DB Console" tab being empty with no way to create a tab. (authored by dfaure).
Fix "DB Console" tab being empty with no way to create a tab.
Fri, Mar 24, 11:08 PM
dfaure committed R170:1f8691556b82: Simplify unittest using QSignalSpy::wait() (authored by dfaure).
Simplify unittest using QSignalSpy::wait()
Fri, Mar 24, 11:03 PM
dfaure committed R170:f306a68a244e: Remove unused file (authored by dfaure).
Remove unused file
Fri, Mar 24, 11:03 PM
dfaure committed R275:11b36d24ac85: Mention the new QSFPM::setRecursiveFiltering(true) which makes… (authored by dfaure).
Mention the new QSFPM::setRecursiveFiltering(true) which makes…
Fri, Mar 24, 2:35 PM

Mar 23 2017

dfaure added a comment to D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD.

Ah yes OK, the extraction on Linux is indeed not done in those Qt patches either. Nevermind ;)

Mar 23 2017, 11:53 AM · Frameworks
dfaure added a comment to D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD.

The comment about ctime is still true ;-)

Mar 23 2017, 10:39 AM · Frameworks
dfaure committed R271:0d819bc3eecc: KDBusService: Add accessor for the dbus service name we registered. (authored by dfaure).
KDBusService: Add accessor for the dbus service name we registered.
Mar 23 2017, 7:51 AM
dfaure accepted D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD.

Feel like implementing it for Linux, too? ;-)

Mar 23 2017, 7:42 AM · Frameworks

Mar 22 2017

dfaure added a comment to D5044: Move "Analyze" menu items into "Code" menu.

Not right now, see kxmlgui/src/kshortcutseditoritem.cpp:54

m_actionNameInTable = i18nc([...] KLocalizedString::removeAcceleratorMarker(m_action->text()));

which is returned further down as DisplayRole for the Name column.
But you could easily add support for a custom property here ("descriptiveText") and document that, it would certainly be useful for all those actions whose text only makes sense in the context of the submenu they're in.

Mar 22 2017, 8:49 AM
dfaure added a comment to D5123: Try to fix call to KXMLGuiWindow::setupGUI.

Oh, yeah, that sounds backwards.

Mar 22 2017, 8:28 AM
dfaure added a comment to D5123: Try to fix call to KXMLGuiWindow::setupGUI.

createGUI(part) takes care of loading ui_standards.rc, see the bit of code I pointed to in my last comment.

Mar 22 2017, 8:20 AM
dfaure added a comment to D5123: Try to fix call to KXMLGuiWindow::setupGUI.

This looks like ui_standards.rc isn't loaded.
Does this code call createGUI(part) anywhere? Do you get into KParts::MainWindow::createShellGUI(), and does it end up calling setXMLFile(KXMLGUIClient::standardsXmlFileLocation()); in kparts/src/mainwindow.cpp:168 ?

Mar 22 2017, 7:54 AM

Mar 21 2017

dfaure committed R170:a82860b8b87c: Merge branch 'Applications/16.12' into Applications/17.04 (authored by dfaure).
Merge branch 'Applications/16.12' into Applications/17.04
Mar 21 2017, 7:30 AM
dfaure committed R170:12711617070b: ITIPHandler: emit correct signal in case of an error loading the calendar. (authored by dfaure).
ITIPHandler: emit correct signal in case of an error loading the calendar.
Mar 21 2017, 7:28 AM
dfaure closed D5107: ITIPHandler: emit correct signal in case of an error loading the calendar. by committing R170:12711617070b: ITIPHandler: emit correct signal in case of an error loading the calendar..
Mar 21 2017, 7:28 AM · KDE PIM
dfaure committed R226:fc683223ad74: Merge branch 'Applications/16.12' into Applications/17.04 (authored by dfaure).
Merge branch 'Applications/16.12' into Applications/17.04
Mar 21 2017, 7:25 AM

Mar 19 2017

dfaure committed R94:18c8cdcaf81b: List deps more explicitly. A lot of them are brought in via CalendarCore using… (authored by dfaure).
List deps more explicitly. A lot of them are brought in via CalendarCore using…
Mar 19 2017, 9:28 PM
dfaure created D5107: ITIPHandler: emit correct signal in case of an error loading the calendar..
Mar 19 2017, 6:13 PM · KDE PIM
dfaure accepted D5090: User messages cleanup (and de-emphasize Konqueror).
Mar 19 2017, 5:22 PM · Frameworks