- User Since
- Mar 5 2015, 12:44 PM (240 w, 3 d)
If you say so :-)
Sat, Oct 12
Hmm, why not just do KSslErrorUiData uiData(socket); in the caller, or even just askIgnoreSslErrors(KSslErrorUiData(socket), storedRules).
Don't know, just wondering (not objecting). @vkrause, any opinion?
Err, yeah, the call to setPort(-1) serves no purpose at all otherwise...
Fri, Oct 11
+1 from me
Wed, Oct 9
Tue, Oct 8
Mon, Oct 7
Done, this is in the v5.63.0-rc3 tag now.
Looks good, quite similar to https://phabricator.kde.org/D23808
Sun, Oct 6
Argh, I retagged, but this wasn't pushed yet.
Landing and retagging again...
This commit breaks kfileplacesmodeltest, please take a look.
Fri, Oct 4
Do you mean QtGui? We need icons...
For the record, JFBastien was actually wrong. Calling .begin() on a const return value does call the const overload. Testcase http://www.davidfaure.fr/kde/const_retval.cpp
Thu, Oct 3
git tag doesn't show any 5.63.0-rc* tag yet, so it hasn't been tagged, so this commit will be included.
It doesn't look like there is a null pointer we can check.
Wed, Oct 2
I suggest do look at kio_file (kio/src/ioslaves/file), the above code was inspired by kio_file, and then ported differently to Windows.
Tue, Oct 1
I'm not sure what the QFileDevice enum gives us compared to the octal permissions as int? Is this just because it looks nicer, to save a conversion, or because you actually need the differenciation between ReadUser and ReadOwner, on Windows?
Mon, Sep 30
I found confirmation in cmake's Tests/RunCMake/GenerateExportHeader/reference/
This is exactly why we release KF5 every month these days, so people fix issues here instead of working around them in app code like in 2010 :-)
Ah I see, the hacks in KDAV::DavManager is the context :)
Test Plan: ?
Which might be an issue for people who would like to use different compiler on the same system, both building against the same generated export header file.
Sun, Sep 29
Please make the loop variable const-ref whenever possible.
Sat, Sep 28
It's actually quite clear in my head, because I imagine the generated class. A captured variable in a lambda becomes a member variable. If it's a capture by value (which is what happens with [library]), it's a "plain value" member.
Any input on the (implicit) questions in the commit log? ;-)
Make changes suggested by Friedrich's code review (thanks!)
Fri, Sep 27
perl -pi -e 's/buttonOK/buttonOk/g' kmessagebox.*
For the record, the upstream fix proposal is https://codereview.qt-project.org/c/qt/qtbase/+/275380 (Qt is actually a better place than cmake for this)
Ah, I see, OK.
also add this to sorry(); fix inconsistency with Options arg, that one can still have a default value