dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (150 w, 3 d)
Availability
Available

Recent Activity

Yesterday

dfaure added a comment to D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).

"autotests" and unittests are the same thing. The files are in the right place.

Sat, Jan 20, 7:06 PM · Frameworks

Fri, Jan 19

dfaure committed R172:152aedab0cc3: Merge branch 'Applications/17.12' (authored by dfaure).
Merge branch 'Applications/17.12'
Fri, Jan 19, 1:06 PM
dfaure committed R172:72909253ae44: icalformat: remove QByteArray->QString->QByteArray roundtrip. (authored by dfaure).
icalformat: remove QByteArray->QString->QByteArray roundtrip.
Fri, Jan 19, 1:06 PM
dfaure closed D3203: icalformat: remove QByteArray->QString->QByteArray roundtrip..
Fri, Jan 19, 1:06 PM · KDE PIM
dfaure updated the diff for D3203: icalformat: remove QByteArray->QString->QByteArray roundtrip..

and now it compiles

Fri, Jan 19, 12:58 PM · KDE PIM
dfaure updated the diff for D3203: icalformat: remove QByteArray->QString->QByteArray roundtrip..

re-add trimmed()

Fri, Jan 19, 12:53 PM · KDE PIM
dfaure added a comment to D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry.

What is slow in my experience is feeding a KDW instance.

Fri, Jan 19, 12:49 PM · Frameworks
dfaure closed D9808: fix incorrect emission of signals by kLineEdit.

Pushed in https://commits.kde.org/kcompletion/31f226116f99bcf40ddc67fe6328594d5fb46222, thanks for the contribution! Keep 'em coming ;-)

Fri, Jan 19, 8:50 AM · Frameworks, KDevelop
dfaure committed R284:31f226116f99: Fix incorrect emission of textEdited() by KLineEdit (authored by dweatherill).
Fix incorrect emission of textEdited() by KLineEdit
Fri, Jan 19, 8:48 AM
dfaure added a comment to D9966: [KIO] Fix issues with sharing of file descriptor.

Note: if someone wants to use XDG_RUNTIME_DIR with Qt, use QStandardPaths::RuntimeLocation (which includes the proper security checks for that directory, and fallbacks).

Fri, Jan 19, 8:35 AM · Frameworks
dfaure added a comment to D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry.
In D9824#193179, @rjvbb wrote:

That's not applicable.

Did you read my actual, original request? If so you'd have seen that it's satisfied by this answer.

Fri, Jan 19, 8:33 AM · Frameworks

Thu, Jan 18

dfaure accepted D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry.

This patch fixes a O(n) performance issue in the inotify backend using a cache, which makes KDirWatch *better* suited for applications that use KDirWatch heavily. Clearly a step in the right direction. Yes a cache needs memory, like all caches, how else is one going to optimize linear searches [in unsorted data]...

Thu, Jan 18, 11:06 PM · Frameworks
dfaure added a comment to D9095: Fix regression where today's tasks don't appear between 00:00 and 01:00..

The more I dig into this, the more I think all of my previous commits on the topic of timezones might be wrong.
This whole idea of using UTC everywhere comes from 9e65b991 / https://phabricator.kde.org/D876 which doesn't really tell me much about the reasoning.

Thu, Jan 18, 10:51 PM
dfaure committed R4:34ddf2dd4895: Add feature tests for dnd within the workday. (authored by dfaure).
Add feature tests for dnd within the workday.
Thu, Jan 18, 10:02 PM
dfaure closed D9322: Add feature tests for dnd within the workday..
Thu, Jan 18, 10:02 PM
dfaure committed R4:8a79cac872a5: Update README with instructions for running feature tests (authored by dfaure).
Update README with instructions for running feature tests
Thu, Jan 18, 10:02 PM
dfaure committed R4:c97a99bfac77: Workday: fix LLCONFLICT when deparenting a task. (authored by dfaure).
Workday: fix LLCONFLICT when deparenting a task.
Thu, Jan 18, 10:02 PM
dfaure closed D9343: Update README with instructions for running feature tests.
Thu, Jan 18, 10:01 PM
dfaure closed D9355: Workday: fix LLCONFLICT when deparenting a task..
Thu, Jan 18, 10:01 PM

Wed, Jan 17

dfaure accepted D9822: Add benchmarks for KDirWatch.
Wed, Jan 17, 2:49 PM · Frameworks
dfaure accepted D9938: [Uri Filter Search Provider] Avoid double delete.

Oops.

Wed, Jan 17, 8:51 AM · Frameworks

Tue, Jan 16

dfaure updated the diff for D9913: Give reasoning behind qproperty-without-notify.

mention Gammaray too

Tue, Jan 16, 11:05 AM
dfaure updated the diff for D8908: KDateComboBox: fix dateChanged() not emitted after typing a date.

add QVERIFY

Tue, Jan 16, 8:56 AM · Frameworks

Mon, Jan 15

dfaure committed R497:fa11375ca55d: update version number (authored by dfaure).
update version number
Mon, Jan 15, 3:14 PM
dfaure committed R497:0bd7f80f04cc: Commit fixes made during 5.42 release (authored by dfaure).
Commit fixes made during 5.42 release
Mon, Jan 15, 3:14 PM
dfaure added a comment to D9884: KMultiTabBar: Fix regression in conversion to new style connect() .

Done, kwidgetaddons-5.42.1 is out: https://download.kde.org/stable/frameworks/5.42/

Mon, Jan 15, 2:53 PM · Frameworks
dfaure added a comment to D8908: KDateComboBox: fix dateChanged() not emitted after typing a date.

ping?

Mon, Jan 15, 2:43 PM · Frameworks
dfaure added a comment to D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry.

I'm 100% sure the same rules applies, because the "limitations" of operator[] come from C++ and therefore apply to all associative containers.

Mon, Jan 15, 11:08 AM · Frameworks
dfaure accepted D9821: Use QSignalSpy::wait instead of QTest::wait where possible.

Oh, right. I see. Still very strange that QTRY_COMPARE_WITH_TIMEOUT behaves differently (if more signals are coming in than expected, the current (old) code could have caught them too, during the 50ms. Actually that might explain some of the flakiness I sometimes saw....

Mon, Jan 15, 10:00 AM · Frameworks
dfaure added a comment to D9822: Add benchmarks for KDirWatch.

"The third one touches all files in the tree and measure how long it
takes until all dirty signals arrive. If you subtract that measurement
from the third benchmark"

Mon, Jan 15, 8:50 AM · Frameworks
dfaure added inline comments to D9821: Use QSignalSpy::wait instead of QTest::wait where possible.
Mon, Jan 15, 8:45 AM · Frameworks
dfaure accepted D9820: Verify that the file was opened.
Mon, Jan 15, 8:44 AM · Frameworks
dfaure accepted D9823: Optimize: use QMetaObject::invokeMethod with functor.
Mon, Jan 15, 8:43 AM · Frameworks

Sun, Jan 14

dfaure accepted D9844: Don't stat(/etc/localtime) between read() and write() copying files.

Well spotted!

Sun, Jan 14, 12:19 PM · Frameworks
dfaure requested changes to D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files.

This goes against the whole redesign of ksycoca that I did some time ago. It's supposed to check timestamps on dirs, to rebuild the cache on demand, much like many other caches out there. Did you run the unittests in kservice after this change? I strongly doubt they pass.

Sun, Jan 14, 12:00 PM · Frameworks

Sat, Jan 13

dfaure committed R883:1508570: KF 5.42.
KF 5.42
Sat, Jan 13, 8:47 PM
dfaure accepted D9867: Fix compile fail on macOS.
Sat, Jan 13, 8:43 PM · Frameworks
dfaure committed R883:1508555: add frameworks-5.42.0 to generate_release_data.py.
add frameworks-5.42.0 to generate_release_data.py
Sat, Jan 13, 1:40 PM

Fri, Jan 12

dfaure committed R241:b25194b04b98: Add missing override keyword (authored by dfaure).
Add missing override keyword
Fri, Jan 12, 12:42 PM
dfaure requested changes to D9823: Optimize: use QMetaObject::invokeMethod with functor.
Fri, Jan 12, 9:12 AM · Frameworks
dfaure accepted D9808: fix incorrect emission of signals by kLineEdit.

Thanks for the fix. Looking at the reasoning in 737a983feb the added emit is definitely wrong, as the unittest proves. Please push.

Fri, Jan 12, 9:09 AM · Frameworks, KDevelop
dfaure added a comment to D9830: Fix KFilePreviewGenerator::LayoutBlocker.

I certainly hope QListView doesn't trigger a nested event loop, that would be horribly nasty and the cause for a million more problems.... (up to and including crashes when closing the view/window while this is happening). But I'm assuming this is just a supposition, and I'm strongly hoping it's unfounded ;-)

Fri, Jan 12, 8:50 AM · Frameworks
dfaure added inline comments to D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry.
Fri, Jan 12, 8:48 AM · Frameworks
dfaure accepted D9424: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file.
Fri, Jan 12, 8:41 AM · Frameworks
dfaure accepted D9830: Fix KFilePreviewGenerator::LayoutBlocker.

Nice investigation and fix! Do you happen to know the actual change in Qt which broke this? Wondering if it should 1) be mentioned in the commit log, 2) lead to an #if QT_VERSION.
But if it's just a supposition, then that's fine, don't spend a week tracking down the change in Qt :-)

Fri, Jan 12, 8:39 AM · Frameworks

Thu, Jan 11

dfaure added a comment to D9808: fix incorrect emission of signals by kLineEdit.

Sorry to be a pain, but can you also update the description, which still talks about textEmitted()?

Thu, Jan 11, 3:14 PM · Frameworks, KDevelop
dfaure added inline comments to D9808: fix incorrect emission of signals by kLineEdit.
Thu, Jan 11, 1:37 PM · Frameworks, KDevelop
dfaure added inline comments to D9808: fix incorrect emission of signals by kLineEdit.
Thu, Jan 11, 8:44 AM · Frameworks, KDevelop

Wed, Jan 10

dfaure committed R266:47a9c6589f14: Fix broken index.theme files, "Context=Status" was missing in status/64 (authored by dfaure).
Fix broken index.theme files, "Context=Status" was missing in status/64
Wed, Jan 10, 11:58 PM
dfaure committed R266:a1b0e5155b69: autotests: better error message when the Context key is missing (authored by dfaure).
autotests: better error message when the Context key is missing
Wed, Jan 10, 11:56 PM
dfaure committed R266:464bd1a2e3a5: autotests: do not incorrectly split spaces in paths of duplicate results (authored by dfaure).
autotests: do not incorrectly split spaces in paths of duplicate results
Wed, Jan 10, 11:39 PM
dfaure committed R266:f9887012838b: Revert "do not incorrectly split spaces in paths of duplicate results" (authored by dfaure).
Revert "do not incorrectly split spaces in paths of duplicate results"
Wed, Jan 10, 11:39 PM
dfaure added a reverting commit for R266:08ddec40bf89: do not incorrectly split spaces in paths of duplicate results: R266:f9887012838b: Revert "do not incorrectly split spaces in paths of duplicate results".
Wed, Jan 10, 11:39 PM
dfaure closed D9807: autotests: do not incorrectly split spaces in paths of duplicate results.
Wed, Jan 10, 11:39 PM
dfaure accepted D6833: Add support for privilege execution in KIO jobs.
Wed, Jan 10, 11:37 PM · Frameworks
dfaure accepted D7270: [FileUndoManager] Enable undoing changes in read-only folders.
Wed, Jan 10, 11:35 PM · Frameworks
dfaure added a comment to D6830: Make use of kauth helper in copy method of file ioslave.

Doesn't execWithElevatedPrivilege call ERR_USER_CANCELED on cancel?
That was the idea, at least.

Wed, Jan 10, 11:34 PM · Frameworks
dfaure accepted D6832: Integrate new file ioslave in KIO job.

Please keep in mind that we should remove one of the two flags before the end of the month, after people tested this as much as possible ;)

Wed, Jan 10, 11:30 PM · Frameworks
dfaure accepted D7272: [DropJob] Enable drag and drop in a read-only folder.
Wed, Jan 10, 11:24 PM · Frameworks
dfaure added a comment to T7711: Phabricator does not update commit messages in patch updated with arcanist.

The proper way to push the fix is arc land...

Wed, Jan 10, 11:23 PM · Phabricator
dfaure accepted D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata.
Wed, Jan 10, 10:27 PM · Plasma
dfaure added a comment to D9807: autotests: do not incorrectly split spaces in paths of duplicate results.

Sample output:

Wed, Jan 10, 10:07 PM
dfaure added a comment to D9781: do not incorrectly split spaces in paths of duplicate results.

https://phabricator.kde.org/D9807 (to be applied after reverting this commit)

Wed, Jan 10, 10:07 PM · Frameworks
dfaure committed R230:2c7a43b4f862: Merge branch 'Applications/17.12' (authored by dfaure).
Merge branch 'Applications/17.12'
Wed, Jan 10, 10:05 PM
dfaure committed R230:fddee611f987: makeobj: fix syntax error when pwd contains a space (authored by dfaure).
makeobj: fix syntax error when pwd contains a space
Wed, Jan 10, 10:05 PM
dfaure added a comment to D9781: do not incorrectly split spaces in paths of duplicate results.

I don't either ;)

Wed, Jan 10, 9:43 PM · Frameworks
dfaure committed R275:9145c173d29c: KRearrangeColumnsProxyModel: fix crash when there's no source model (authored by dfaure).
KRearrangeColumnsProxyModel: fix crash when there's no source model
Wed, Jan 10, 5:09 PM
dfaure committed R275:26699d4d0402: GIT_SILENT fix coding style (authored by dfaure).
GIT_SILENT fix coding style
Wed, Jan 10, 5:09 PM
dfaure committed R275:18ab467c1126: KRearrangeColumnsProxyModel: reimplement sibling() so it works as expected (authored by dfaure).
KRearrangeColumnsProxyModel: reimplement sibling() so it works as expected
Wed, Jan 10, 4:44 PM
dfaure committed R170:e183447891a2: Merge branch 'Applications/17.12' (authored by dfaure).
Merge branch 'Applications/17.12'
Wed, Jan 10, 12:51 PM
dfaure committed R170:4172a6ed0553: Use the chosen organizer identity when emailing attendees (authored by dfaure).
Use the chosen organizer identity when emailing attendees
Wed, Jan 10, 12:31 PM
dfaure closed D9789: Use the chosen organizer identity when emailing attendees.
Wed, Jan 10, 12:31 PM · KDE PIM
dfaure accepted D9734: [KFileItemActions] Allow specifying the number of selected files required for an action.
Wed, Jan 10, 8:03 AM · Frameworks

Tue, Jan 9

dfaure abandoned D9758: Gammaray: use GNUInstallDirs so that LIB_SUFFIX is no longer needed..

Wrong tooling :-)

Tue, Jan 9, 12:09 PM
dfaure committed R94:155647759daf: Repair Page Down with Qt 5.9, there documentElement.scrollTop doesn't work. (authored by dfaure).
Repair Page Down with Qt 5.9, there documentElement.scrollTop doesn't work.
Tue, Jan 9, 10:24 AM

Mon, Jan 8

dfaure added a comment to D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file.

thanks for this pointer, see T7711

Mon, Jan 8, 12:24 PM · Frameworks
dfaure added a comment to D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file.

As a KDE sysadmin ticket; the sysadmins want to centralize KDE's issues with Phabricator before reporting them upstream (to present a unified front and avoid duplicates).

Mon, Jan 8, 10:16 AM · Frameworks
dfaure committed R278:984e118ff3d2: autotests: set LIBRARY_OUTPUT_DIRECTORY so platform plugins are found… (authored by dfaure).
autotests: set LIBRARY_OUTPUT_DIRECTORY so platform plugins are found…
Mon, Jan 8, 8:07 AM

Sun, Jan 7

dfaure added a comment to D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII ).

The rest looks good.

Sun, Jan 7, 10:48 PM · Frameworks
dfaure accepted D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file.
Sun, Jan 7, 6:07 PM · Frameworks
dfaure committed R44:93cbd75a6df4: Merge branch 'Applications/17.12' (authored by dfaure).
Merge branch 'Applications/17.12'
Sun, Jan 7, 5:12 PM
dfaure committed R44:57b24f6a033b: DAV: fix Next button not enabled when typing password. (authored by dfaure).
DAV: fix Next button not enabled when typing password.
Sun, Jan 7, 5:12 PM
dfaure committed R246:b7e6da6ce9f9: autotests: replace duplication with for loop (authored by dfaure).
autotests: replace duplication with for loop
Sun, Jan 7, 4:16 PM
dfaure committed R246:8efe29c7417d: GIT_SILENT reformat code with uncrustify (authored by dfaure).
GIT_SILENT reformat code with uncrustify
Sun, Jan 7, 4:16 PM
dfaure accepted D9666: balooctl status: process all arguments.
Sun, Jan 7, 3:06 PM · Frameworks

Fri, Jan 5

dfaure committed R287:04e2ee01cb10: Set LIBRARY_OUTPUT_DIRECTORY so the autotests can run without the plugins… (authored by dfaure).
Set LIBRARY_OUTPUT_DIRECTORY so the autotests can run without the plugins…
Fri, Jan 5, 10:20 AM
dfaure committed R241:0a6ab3c54619: autotests: fix icon check when trash is empty (as on CI) (authored by dfaure).
autotests: fix icon check when trash is empty (as on CI)
Fri, Jan 5, 9:27 AM
dfaure accepted D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file.
Fri, Jan 5, 8:36 AM · Frameworks

Thu, Jan 4

dfaure committed R275:b4457200af28: test program: fix QLayout warning (authored by dfaure).
test program: fix QLayout warning
Thu, Jan 4, 12:33 PM
dfaure accepted D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'.
Thu, Jan 4, 12:26 PM · Frameworks
dfaure committed R436:ecea7149d423: Don't use qCritical for debug output, that's what qCDebug is for. (authored by dfaure).
Don't use qCritical for debug output, that's what qCDebug is for.
Thu, Jan 4, 9:49 AM
dfaure committed R365:37091c7de1b8: Add krdc and kdesvn (authored by dfaure).
Add krdc and kdesvn
Thu, Jan 4, 9:46 AM
dfaure accepted D7430: Add unit tests for privilege excution in KIO.

Just missing a 'e' in "execution" in the commit log ;)

Thu, Jan 4, 8:54 AM · Frameworks
dfaure accepted D6831: Make use of kauth helper in methods of file ioslave.
Thu, Jan 4, 8:46 AM · Frameworks
dfaure accepted D9593: Fix crash in setMainWindow on wayland.
Thu, Jan 4, 8:29 AM · Frameworks

Tue, Jan 2

dfaure committed R241:de5cc8b6bb4c: autotest: use QTEST_GUILESS_MAIN (authored by dfaure).
autotest: use QTEST_GUILESS_MAIN
Tue, Jan 2, 1:12 PM
dfaure requested changes to D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file.
Tue, Jan 2, 8:32 AM · Frameworks
dfaure added a comment to D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'.

Let's discard this one and proceed with https://phabricator.kde.org/D9480 instead.

Tue, Jan 2, 8:31 AM · Frameworks
dfaure requested changes to D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'.
Tue, Jan 2, 8:31 AM · Frameworks

Fri, Dec 29

dfaure added a comment to D9550: Don't set the LD_LIBRARY_PATH in prefix.sh.

Why leave it here, commented out, without explanations?
I'd either remove it completely, or explain the '#' ...

Fri, Dec 29, 7:49 PM · Build System, Frameworks