dfaure (David Faure)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (273 w, 3 d)
Availability
Available

Recent Activity

Today

dfaure committed R241:6936c76fffa6: Use ++ operator to advance QHash::const_iterator (authored by ahmadsamir).
Use ++ operator to advance QHash::const_iterator
Mon, Jun 1, 9:36 AM
dfaure committed R241:f9d683c4abdb: autotests: fix kdirmodeltest by restoring the dirlister mode (authored by dfaure).
autotests: fix kdirmodeltest by restoring the dirlister mode
Mon, Jun 1, 9:11 AM

Sat, May 30

dfaure committed R241:fce5800150e7: RenameDialog: Warn when file sizes are not the same (authored by meven).
RenameDialog: Warn when file sizes are not the same
Sat, May 30, 4:26 PM
dfaure committed R241:b633cf2e0ecb: GIT_SILENT ++KF_DISABLE_DEPRECATED_BEFORE_AND_AT (authored by dfaure).
GIT_SILENT ++KF_DISABLE_DEPRECATED_BEFORE_AND_AT
Sat, May 30, 2:04 PM
dfaure committed R241:c494d1b60862: [KSambaShare] Check that both smbd and testparm are available (authored by ahmadsamir).
[KSambaShare] Check that both smbd and testparm are available
Sat, May 30, 2:04 PM
dfaure committed R241:395854b0a1c6: Fix test KFilePlacesModelTest::testEnableBaloo (authored by meven).
Fix test KFilePlacesModelTest::testEnableBaloo
Sat, May 30, 11:21 AM
dfaure committed R241:f08ceea98ed9: RenameDialog: Warn when file sizes are not the same (authored by meven).
RenameDialog: Warn when file sizes are not the same
Sat, May 30, 10:54 AM
dfaure accepted D26113: Places: Use Solid::Device::DisplayName for DisplayRole.

Thanks!

Sat, May 30, 9:56 AM · Frameworks
dfaure committed R241:fe87d93250d2: KDirModel: fix hasChildren() regression for trees with files shown (authored by dfaure).
KDirModel: fix hasChildren() regression for trees with files shown
Sat, May 30, 12:57 AM

Fri, May 29

dfaure committed R295:52b1b8b27237: Add X-KDE-KCM-Args as property, read property in module loader (authored by alex).
Add X-KDE-KCM-Args as property, read property in module loader
Fri, May 29, 11:22 PM
dfaure committed R241:b719f5758f65: file_unix.cpp: when ::rename is used as condition compare its return to -1 (authored by ahmadsamir).
file_unix.cpp: when ::rename is used as condition compare its return to -1
Fri, May 29, 10:34 PM
dfaure requested changes to D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error.

I have modified DesktopExecParser in kio commit d1e9325fba37eddb9cb44173edfc1fee122a0c57 to return an error string so that its users don't need to do the work again of figuring out what went wrong (see DesktopExecParser::errorMessage()).
I just realized that this would be very useful here as well. AFAICS the current patch only works if the user types a full path, not with a relative path.

Fri, May 29, 10:27 PM · Frameworks
dfaure added a comment to D26113: Places: Use Solid::Device::DisplayName for DisplayRole.

Please check that kfileplacesmodeltest and kfileplacesviewtest still pass.

Fri, May 29, 5:07 PM · Frameworks
dfaure added a comment to D29814: Fix segfault on no restart args.

Can you explain how to trigger this crash in the first place? Which application triggers it?

Fri, May 29, 4:50 PM · Frameworks

Wed, May 27

dfaure requested changes to D29814: Fix segfault on no restart args.

I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled??

Wed, May 27, 9:40 PM · Frameworks
dfaure accepted D29810: Don't use the setenv function after fork.
Wed, May 27, 9:21 PM · Frameworks
dfaure added a comment to D29809: Don't invoke qstring localized stuff in critical section.

Makes sense; just two minor things.

Wed, May 27, 9:12 PM · Frameworks
dfaure committed R241:01c79ffff1e2: Port away from deprecated QLinkedList (authored by ahmadsamir).
Port away from deprecated QLinkedList
Wed, May 27, 9:07 PM
dfaure committed R241:bfcc0c028449: Coding style; one more const (authored by ahmadsamir).
Coding style; one more const
Wed, May 27, 9:07 PM
dfaure committed R241:fa1c28890e11: Remove redundant #include (authored by ahmadsamir).
Remove redundant #include
Wed, May 27, 9:07 PM
dfaure committed R241:2df0dcc5a70c: Port away from deprecated QLinkedList (authored by ahmadsamir).
Port away from deprecated QLinkedList
Wed, May 27, 9:07 PM

Tue, May 26

dfaure requested changes to D29668: Do not reject icon theme dir with invalid context/type..
Tue, May 26, 11:02 PM · Frameworks

Mon, May 25

dfaure committed R241:9d68a216a6d8: KFileItem: localize timeString (authored by meven).
KFileItem: localize timeString
Mon, May 25, 7:40 AM

Sat, May 23

dfaure committed R226:12e1226e7e1e: GIT_SILENT remove some traces of KRun (authored by dfaure).
GIT_SILENT remove some traces of KRun
Sat, May 23, 2:32 PM
dfaure committed R226:b5982a4246f5: Port from KRun::displayOpenWithDialog to OpenUrlJob (authored by dfaure).
Port from KRun::displayOpenWithDialog to OpenUrlJob
Sat, May 23, 2:30 PM
dfaure committed R226:ec60852483fd: Port away from Qt::escape (authored by dfaure).
Port away from Qt::escape
Sat, May 23, 2:16 PM
dfaure committed R226:6d7d4284dedb: Port konq_popupmenu from KRun to OpenUrlJob (authored by dfaure).
Port konq_popupmenu from KRun to OpenUrlJob
Sat, May 23, 1:27 PM
dfaure committed R226:96cb6e6b8cd2: Port kfmclient from KRun to OpenUrlJob. (authored by dfaure).
Port kfmclient from KRun to OpenUrlJob.
Sat, May 23, 1:22 PM
dfaure added a comment to D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts.

@meven you're confusing me with my clone @ervin.

Sat, May 23, 11:14 AM · Frameworks
dfaure requested changes to D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts.
Sat, May 23, 10:43 AM · Frameworks
dfaure committed R303:76b220cb67df: Port to KIOGuiPrivate::checkStartupNotify (authored by dfaure).
Port to KIOGuiPrivate::checkStartupNotify
Sat, May 23, 8:57 AM
dfaure committed R497:9401ee159c40: Feat: Port framework release script to kde.org in git (authored by ognarb).
Feat: Port framework release script to kde.org in git
Sat, May 23, 8:15 AM

Fri, May 22

dfaure committed R242:50530a7739e0: Port plasma-framework away from KRun (authored by dfaure).
Port plasma-framework away from KRun
Fri, May 22, 8:36 PM
dfaure committed R242:dc9ecf159026: Port plasma-framework away from KRun (authored by dfaure).
Port plasma-framework away from KRun
Fri, May 22, 8:26 PM
dfaure committed R241:1cca05e96d73: Add porting docu for KRun constructor. (authored by dfaure).
Add porting docu for KRun constructor.
Fri, May 22, 8:03 PM
dfaure committed R295:7413185fbf18: GIT_SILENT add explanation (authored by dfaure).
GIT_SILENT add explanation
Fri, May 22, 6:00 PM
dfaure committed R241:60475571926d: KUrlNavigatorPlacesSelector: only update once the menu on changes (authored by meven).
KUrlNavigatorPlacesSelector: only update once the menu on changes
Fri, May 22, 5:53 PM
dfaure committed R295:e290e9e666fc: Port these two to KCModuleInfo::property() as well, seems to fix Configure… (authored by dfaure).
Port these two to KCModuleInfo::property() as well, seems to fix Configure…
Fri, May 22, 12:19 PM
dfaure committed R295:c2db5f797fd3: Repair kcmshell5 after previous commits, now with unittest (authored by dfaure).
Repair kcmshell5 after previous commits, now with unittest
Fri, May 22, 11:23 AM
dfaure committed R295:b1f56973ea19: Add test for a "normal" KCM with desktop file (authored by dfaure).
Add test for a "normal" KCM with desktop file
Fri, May 22, 10:47 AM
dfaure committed R295:a65c6819464b: Rename KCModuleInfo unittest and extend it with the "fake KCM" testcase (authored by dfaure).
Rename KCModuleInfo unittest and extend it with the "fake KCM" testcase
Fri, May 22, 10:30 AM

Thu, May 21

dfaure committed R39:65cd3a54da98: GIT_SILENT remove last traces of KRun (authored by dfaure).
GIT_SILENT remove last traces of KRun
Thu, May 21, 10:51 AM
dfaure committed R77:f070ce97df71: Support multiple entries in XDG_DATA_DIRS (authored by dfaure).
Support multiple entries in XDG_DATA_DIRS
Thu, May 21, 10:41 AM
dfaure closed D29613: Support multiple entries in XDG_DATA_DIRS.
Thu, May 21, 10:41 AM · KDE PIM
dfaure updated the diff for D29613: Support multiple entries in XDG_DATA_DIRS.

add missing braces

Thu, May 21, 8:55 AM · KDE PIM
dfaure added a comment to D29613: Support multiple entries in XDG_DATA_DIRS.

They are used. But indeed I don't actually need that to fix my use case. I thought proper cascading was better than just fixing my use case?

Thu, May 21, 8:53 AM · KDE PIM
dfaure committed R295:53b41bc90b35: Fix crash when loading an external app KCM like yast (authored by dfaure).
Fix crash when loading an external app KCM like yast
Thu, May 21, 8:24 AM

Wed, May 20

dfaure committed R295:9d7cc7d80d1b: Address review comments (authored by dfaure).
Address review comments
Wed, May 20, 9:51 PM
dfaure added a comment to D28765: KSettings::Dialog: add support for KPluginInfos without a KService.

https://invent.kde.org/frameworks/kcmutils/-/merge_requests/2

Wed, May 20, 9:09 PM · Frameworks
dfaure committed R295:0f442313d335: Fix crash when loading an external app KCM like yast (authored by dfaure).
Fix crash when loading an external app KCM like yast
Wed, May 20, 8:53 PM
dfaure committed R865:f2a4bc480ba5: Fix another crash due to a null cursor. (authored by dfaure).
Fix another crash due to a null cursor.
Wed, May 20, 10:19 AM

Tue, May 19

dfaure committed R226:7e61ba621ab4: Port KRun::runUrl to KIO::OpenUrlJob (authored by dfaure).
Port KRun::runUrl to KIO::OpenUrlJob
Tue, May 19, 10:56 PM
dfaure closed D29598: Port KRun::runUrl to KIO::OpenUrlJob.
Tue, May 19, 10:56 PM
dfaure updated the diff for D29598: Port KRun::runUrl to KIO::OpenUrlJob.

adjust commit log

Tue, May 19, 10:55 PM
dfaure committed R374:2befe0e23cfe: Improve error message when saving (authored by dfaure).
Improve error message when saving
Tue, May 19, 10:53 PM
dfaure added a comment to D29613: Support multiple entries in XDG_DATA_DIRS.

ping?

Tue, May 19, 10:50 PM · KDE PIM
dfaure committed R241:347b48f7ef82: autotests: allow xterm to be in /usr/local/bin (FreeBSD) (authored by dfaure).
autotests: allow xterm to be in /usr/local/bin (FreeBSD)
Tue, May 19, 11:21 AM

Mon, May 18

dfaure committed R241:2dfe6ec1e059: Update KF6 TODO -- GIT_SILENT (authored by dfaure).
Update KF6 TODO -- GIT_SILENT
Mon, May 18, 7:43 PM
dfaure committed R241:fe059af66760: Fix compilation with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT (authored by dfaure).
Fix compilation with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT
Mon, May 18, 12:16 PM
dfaure committed R241:4e782be573fb: GIT_SILENT autotests: one last quote to fix CI (authored by dfaure).
GIT_SILENT autotests: one last quote to fix CI
Mon, May 18, 12:11 PM
dfaure committed R241:cf728b92aae3: ApplicationLauncherJob: show the Open With dialog if no service was passed (authored by dfaure).
ApplicationLauncherJob: show the Open With dialog if no service was passed
Mon, May 18, 12:05 PM
dfaure committed R241:6de2688ebd30: ApplicationLauncherJob: show the Open With dialog if no service was passed (authored by dfaure).
ApplicationLauncherJob: show the Open With dialog if no service was passed
Mon, May 18, 12:04 PM
dfaure committed R241:fe26267f9941: GIT_SILENT quote expected value, to fix CI (authored by dfaure).
GIT_SILENT quote expected value, to fix CI
Mon, May 18, 11:28 AM
dfaure committed R241:6adaa3a2f797: autotests: fix krununittest for CI; remove qDebug (authored by dfaure).
autotests: fix krununittest for CI; remove qDebug
Mon, May 18, 9:53 AM
dfaure committed R241:718659841aab: autotests: use ktrash5 instead of kdeinit5, to pick something installed by KIO (authored by dfaure).
autotests: use ktrash5 instead of kdeinit5, to pick something installed by KIO
Mon, May 18, 9:07 AM
dfaure committed R39:f551b4c701d3: Port from KRun::runUrl to OpenUrlJob (authored by dfaure).
Port from KRun::runUrl to OpenUrlJob
Mon, May 18, 8:01 AM
dfaure committed R304:a71c3fec7d35: Port from runUrl to OpenUrlJob (authored by dfaure).
Port from runUrl to OpenUrlJob
Mon, May 18, 7:42 AM
dfaure committed R241:423c48f2a51a: ApplicationLauncherJob: show the Open With dialog if no service was passed (authored by dfaure).
ApplicationLauncherJob: show the Open With dialog if no service was passed
Mon, May 18, 7:30 AM

Sun, May 17

dfaure committed R241:f6849fde97f7: Port runapplication to ApplicationLauncherJob (authored by dfaure).
Port runapplication to ApplicationLauncherJob
Sun, May 17, 10:36 PM
dfaure committed R241:e714bf3ba510: Port kruntest to OpenUrlJob (authored by dfaure).
Port kruntest to OpenUrlJob
Sun, May 17, 10:24 PM
dfaure committed R241:aad751d4643e: OpenUrlJob: document the use of KIO::JobUiDelegate (authored by dfaure).
OpenUrlJob: document the use of KIO::JobUiDelegate
Sun, May 17, 10:23 PM
dfaure committed R241:486d9aabeef3: Port OpenFileManagerWindowJob to KIO::OpenUrlJob (authored by dfaure).
Port OpenFileManagerWindowJob to KIO::OpenUrlJob
Sun, May 17, 10:08 PM
dfaure committed R241:ca3f3556175e: Port OpenFileManagerWindowJob to KIO::OpenUrlJob (authored by dfaure).
Port OpenFileManagerWindowJob to KIO::OpenUrlJob
Sun, May 17, 10:03 PM
dfaure committed R241:0a477ebd8a17: Port KAutoMount to OpenUrlJob. (authored by dfaure).
Port KAutoMount to OpenUrlJob.
Sun, May 17, 9:25 PM
dfaure committed R241:1c7acb567fda: Port OpenFileManagerWindowJob to KIO::OpenUrlJob (authored by dfaure).
Port OpenFileManagerWindowJob to KIO::OpenUrlJob
Sun, May 17, 8:41 PM
dfaure committed R241:5d4af5197d2f: GIT_SILENT add missing macro around runLink too (authored by dfaure).
GIT_SILENT add missing macro around runLink too
Sun, May 17, 8:19 PM
dfaure committed R241:5c684e8726ce: Make sure the program exists and is executable before we inject… (authored by dfaure).
Make sure the program exists and is executable before we inject…
Sun, May 17, 6:32 PM
dfaure committed R241:ad0e97b1994d: Add missing deprecation macro, the only caller has the same (authored by dfaure).
Add missing deprecation macro, the only caller has the same
Sun, May 17, 6:26 PM
dfaure committed R241:cc211959ef51: Port OpenFileManagerWindowJob to KIO::OpenUrlJob (authored by dfaure).
Port OpenFileManagerWindowJob to KIO::OpenUrlJob
Sun, May 17, 6:16 PM
dfaure committed R241:2e25bdca620d: ApplicationLauncherJob: show the Open With dialog if no service was passed (authored by dfaure).
ApplicationLauncherJob: show the Open With dialog if no service was passed
Sun, May 17, 5:50 PM
dfaure committed R241:947f9ef281b6: ApplicationLauncherJob: show the Open With dialog if no service was passed (authored by dfaure).
ApplicationLauncherJob: show the Open With dialog if no service was passed
Sun, May 17, 4:28 PM
dfaure committed R241:18d1bad232e3: Make sure the program exists and is executable before we inject… (authored by dfaure).
Make sure the program exists and is executable before we inject…
Sun, May 17, 4:28 PM
dfaure committed R241:fbf3a76e23cf: Make sure the program exists and is executable before we inject… (authored by dfaure).
Make sure the program exists and is executable before we inject…
Sun, May 17, 3:57 PM
dfaure committed R241:38acf99b1fc1: ApplicationLauncherJob: show the Open With dialog if no service was passed (authored by dfaure).
ApplicationLauncherJob: show the Open With dialog if no service was passed
Sun, May 17, 3:25 PM
dfaure added a comment to D29738: Fix service file specifying 'Run in terminal' giving an error code 100.

(Intrusive) fix is up at https://invent.kde.org/frameworks/kio/-/merge_requests/3

Sun, May 17, 2:26 PM · Frameworks
dfaure committed R241:24020c55a9b2: Make sure the program exists and is executable before we inject… (authored by dfaure).
Make sure the program exists and is executable before we inject…
Sun, May 17, 2:25 PM
dfaure accepted D29687: [IconApplet] Port KRun to ApplicationLauncherJob.
Sun, May 17, 2:21 PM · Plasma
dfaure added inline comments to D29687: [IconApplet] Port KRun to ApplicationLauncherJob.
Sun, May 17, 1:45 PM · Plasma
dfaure accepted D29687: [IconApplet] Port KRun to ApplicationLauncherJob.

KServiceFactory::findServiceByStorageId falls back to "new KService" if it can't find the storageId in ksycoca. So yes it worked, but it's kind of pointless (and confusing) to call it just to go to the new KService fallback, better do that directly.

Sun, May 17, 1:43 PM · Plasma
dfaure added a comment to D29738: Fix service file specifying 'Run in terminal' giving an error code 100.

Well spotted. Indeed, when using kioexec (because of the DeleteTemporaryFiles option) we no longer detect non-existing executables. I'll look into fixing this.

Sun, May 17, 1:09 PM · Frameworks
dfaure committed R241:94598635adcc: autotests: repair clipboardupdatertest after port to KIO::paste (authored by dfaure).
autotests: repair clipboardupdatertest after port to KIO::paste
Sun, May 17, 10:35 AM
dfaure added a comment to D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog.

Yeah, the full story is that I pushed to git.kde.org, reverted because I changed my mind, then the sysadmins told me I wasn't supposed to push to git.kde.org at all (it was blocked for everyone, but I have sysadmin privileges for historical and bus-factor reasons). We realized there was nothing to sync to gitlab anyway, since I had simply done push+push+revert+revert.

Sun, May 17, 9:52 AM · Frameworks
dfaure committed R241:69c949da193a: Rename KIO::OpenUrlJobHandlerInterface to KIO::OpenWithHandlerInterface (authored by dfaure).
Rename KIO::OpenUrlJobHandlerInterface to KIO::OpenWithHandlerInterface
Sun, May 17, 9:51 AM
dfaure reopened D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog.

Not committed after all.

Sun, May 17, 9:41 AM · Frameworks
dfaure committed R241:18cd92e4811e: Fix new test method in jobtest to clean up after itself (authored by dfaure).
Fix new test method in jobtest to clean up after itself
Sun, May 17, 9:38 AM
dfaure committed R241:8faf9776c5d6: Support multiple URLs in promptUserForApplication() (authored by dfaure).
Support multiple URLs in promptUserForApplication()
Sun, May 17, 9:38 AM

Sat, May 16

dfaure accepted D29800: Fix URL being passed as argument when launching a .desktop file.

Thanks for the unittest and fix!

Sat, May 16, 9:06 PM · Frameworks
dfaure added a comment to D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs.

OK, I picked testtrash because kio_trash *is* a :local protocol. If it doesn't use UDS_LOCAL_PATH, at least it means the job will actually go through (no early filtering out). That's at least interesting to test too.

Sat, May 16, 9:03 PM · Frameworks
dfaure committed R241:56d42d93e333: Revert "Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun… (authored by dfaure).
Revert "Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun…
Sat, May 16, 9:55 AM
dfaure added a reverting change for R241:7bdefdfdb0ee: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun…: R241:56d42d93e333: Revert "Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun….
Sat, May 16, 9:55 AM