- User Since
- Mar 5 2015, 12:44 PM (124 w, 3 d)
Please push, then I'll port all of webenginepart to qCDebug in a separate commit.
Let's get this in even if there are a few issues left, it's certainly much better than the current behaviour ;)
Fri, Jul 21
Indeed, forget what I said, it's perfectly valid XML.
Isn't the use of single quotes for XML attribute values a little bit ... unorthodox?
Wed, Jul 19
Mon, Jul 17
Sun, Jul 16
Sat, Jul 15
Fri, Jul 14
Looks much better to me.
Thu, Jul 13
Thanks for this work, but I can't review it, I don't know anything about openssl APIs or this code.
Wed, Jul 12
Tue, Jul 11
Please add a README.md too, with the same syntax as in the other frameworks.
Yes, I already said +1 in this review request ;-)
Mon, Jul 10
+1 from me.
Sun, Jul 9
It was already documented that the arg list could be empty when called directly via DBus, so this fix is wrong. Apps have to handle empty args list correctly.
Make the behaviour explicit in the documentation.
Sat, Jul 8
Looks good, just some details.
Isn't a mutex needed to protect this data structure that is apparently modified by different threads?
Damn, you're right, the third alternate isn't editable.
Preserve existing shortcuts
QKeySequence supports more, just not this data table.
Fri, Jul 7
Thu, Jul 6
What if you write me down as maintainer of this code, can this then go in?