If you say so :-)

Hmm, why not just do KSslErrorUiData uiData(socket); in the caller, or even just askIgnoreSslErrors(KSslErrorUiData(socket), storedRules).
Don't know, just wondering (not objecting). @vkrause, any opinion?

Err, yeah, the call to setPort(-1) serves no purpose at all otherwise...

Excellent work!

+1 from me

In D23789#541134, @kossebau wrote:

In D23789#540033, @dfaure wrote:

I found confirmation in cmake's Tests/RunCMake/GenerateExportHeader/reference/

Not sure what you exactly mean, can you please specify confirmation for what? And what this recommends us to do? :)

Done, this is in the v5.63.0-rc3 tag now.

Looks good, quite similar to https://phabricator.kde.org/D23808

Argh, I retagged, but this wasn't pushed yet.
Landing and retagging again...

This commit breaks kfileplacesmodeltest, please take a look.

In D23902#542037, @ahmadsamir wrote:

In D23902#542026, @dfaure wrote:

For the record, JFBastien was actually wrong. Calling .begin() on a const return value does call the const overload. Testcase http://www.davidfaure.fr/kde/const_retval.cpp

That looks like a failure in communication, either one of you _assumed_ something but didn't tell the other. :D

Do you mean QtGui? We need icons...

For the record, JFBastien was actually wrong. Calling .begin() on a const return value does call the const overload. Testcase http://www.davidfaure.fr/kde/const_retval.cpp

git tag doesn't show any 5.63.0-rc* tag yet, so it hasn't been tagged, so this commit will be included.

It doesn't look like there is a null pointer we can check.

I suggest do look at kio_file (kio/src/ioslaves/file), the above code was inspired by kio_file, and then ported differently to Windows.

I'm not sure what the QFileDevice enum gives us compared to the octal permissions as int? Is this just because it looks nicer, to save a conversion, or because you actually need the differenciation between ReadUser and ReadOwner, on Windows?

I found confirmation in cmake's Tests/RunCMake/GenerateExportHeader/reference/

This is exactly why we release KF5 every month these days, so people fix issues here instead of working around them in app code like in 2010 :-)

Ah I see, the hacks in KDAV::DavManager is the context :)

Test Plan: ?

Which might be an issue for people who would like to use different compiler on the same system, both building against the same generated export header file.

Please make the loop variable const-ref whenever possible.

In D24171#539612, @ahmadsamir wrote:

(Reminder: I don't have a dev account so you'll have to commit the patches :)).

Thanks!

It's actually quite clear in my head, because I imagine the generated class. A captured variable in a lambda becomes a member variable. If it's a capture by value (which is what happens with [library]), it's a "plain value" member.
So:

Any input on the (implicit) questions in the commit log? ;-)

Make changes suggested by Friedrich's code review (thanks!)

perl -pi -e 's/buttonOK/buttonOk/g' kmessagebox.*

For the record, the upstream fix proposal is https://codereview.qt-project.org/c/qt/qtbase/+/275380 (Qt is actually a better place than cmake for this)

Ah, I see, OK.

also add this to sorry(); fix inconsistency with Options arg, that one can still have a default value