dfaure (David Faure)
User

Projects

User Details

User Since
Mar 5 2015, 12:44 PM (107 w, 2 d)

Recent Activity

Today

dfaure added a comment to D4847: KAuth integration in document saving.

Looks good to me. Just some minor things I noticed.

Sat, Mar 25, 10:50 AM · KTextEditor, Frameworks

Yesterday

dfaure committed R199:41cf344072b2: Fix "DB Console" tab being empty with no way to create a tab. (authored by dfaure).
Fix "DB Console" tab being empty with no way to create a tab.
Fri, Mar 24, 11:08 PM
dfaure committed R170:1f8691556b82: Simplify unittest using QSignalSpy::wait() (authored by dfaure).
Simplify unittest using QSignalSpy::wait()
Fri, Mar 24, 11:03 PM
dfaure committed R170:f306a68a244e: Remove unused file (authored by dfaure).
Remove unused file
Fri, Mar 24, 11:03 PM
dfaure committed R275:11b36d24ac85: Mention the new QSFPM::setRecursiveFiltering(true) which makes… (authored by dfaure).
Mention the new QSFPM::setRecursiveFiltering(true) which makes…
Fri, Mar 24, 2:35 PM

Thu, Mar 23

dfaure added a comment to D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD.

Ah yes OK, the extraction on Linux is indeed not done in those Qt patches either. Nevermind ;)

Thu, Mar 23, 11:53 AM · Frameworks
dfaure added a comment to D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD.

The comment about ctime is still true ;-)

Thu, Mar 23, 10:39 AM · Frameworks
dfaure committed R271:0d819bc3eecc: KDBusService: Add accessor for the dbus service name we registered. (authored by dfaure).
KDBusService: Add accessor for the dbus service name we registered.
Thu, Mar 23, 7:51 AM
dfaure accepted D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD.

Feel like implementing it for Linux, too? ;-)

Thu, Mar 23, 7:42 AM · Frameworks

Wed, Mar 22

dfaure added a comment to D5044: Move "Analyze" menu items into "Code" menu.

Not right now, see kxmlgui/src/kshortcutseditoritem.cpp:54

m_actionNameInTable = i18nc([...] KLocalizedString::removeAcceleratorMarker(m_action->text()));

which is returned further down as DisplayRole for the Name column.
But you could easily add support for a custom property here ("descriptiveText") and document that, it would certainly be useful for all those actions whose text only makes sense in the context of the submenu they're in.

Wed, Mar 22, 8:49 AM
dfaure added a comment to D5123: Try to fix call to KXMLGuiWindow::setupGUI.

Oh, yeah, that sounds backwards.

Wed, Mar 22, 8:28 AM
dfaure added a comment to D5123: Try to fix call to KXMLGuiWindow::setupGUI.

createGUI(part) takes care of loading ui_standards.rc, see the bit of code I pointed to in my last comment.

Wed, Mar 22, 8:20 AM
dfaure added a comment to D5123: Try to fix call to KXMLGuiWindow::setupGUI.

This looks like ui_standards.rc isn't loaded.
Does this code call createGUI(part) anywhere? Do you get into KParts::MainWindow::createShellGUI(), and does it end up calling setXMLFile(KXMLGUIClient::standardsXmlFileLocation()); in kparts/src/mainwindow.cpp:168 ?

Wed, Mar 22, 7:54 AM

Tue, Mar 21

dfaure committed R170:a82860b8b87c: Merge branch 'Applications/16.12' into Applications/17.04 (authored by dfaure).
Merge branch 'Applications/16.12' into Applications/17.04
Tue, Mar 21, 7:30 AM
dfaure committed R170:12711617070b: ITIPHandler: emit correct signal in case of an error loading the calendar. (authored by dfaure).
ITIPHandler: emit correct signal in case of an error loading the calendar.
Tue, Mar 21, 7:28 AM
dfaure closed D5107: ITIPHandler: emit correct signal in case of an error loading the calendar. by committing R170:12711617070b: ITIPHandler: emit correct signal in case of an error loading the calendar..
Tue, Mar 21, 7:28 AM · KDE PIM
dfaure committed R226:fc683223ad74: Merge branch 'Applications/16.12' into Applications/17.04 (authored by dfaure).
Merge branch 'Applications/16.12' into Applications/17.04
Tue, Mar 21, 7:25 AM

Sun, Mar 19

dfaure committed R94:18c8cdcaf81b: List deps more explicitly. A lot of them are brought in via CalendarCore using… (authored by dfaure).
List deps more explicitly. A lot of them are brought in via CalendarCore using…
Sun, Mar 19, 9:28 PM
dfaure created D5107: ITIPHandler: emit correct signal in case of an error loading the calendar..
Sun, Mar 19, 6:13 PM · KDE PIM
dfaure accepted D5090: User messages cleanup (and de-emphasize Konqueror).
Sun, Mar 19, 5:22 PM · Frameworks
dfaure committed R497:04b82b5e4e4d: one more GIT_SILENT (authored by dfaure).
one more GIT_SILENT
Sun, Mar 19, 12:37 PM
dfaure committed R497:e156b4f8e3a0: add GIT_SILENT (authored by dfaure).
add GIT_SILENT
Sun, Mar 19, 12:37 PM
dfaure committed R170:4a0c8a105f9a: More work on itiphandlertest: (authored by dfaure).
More work on itiphandlertest:
Sun, Mar 19, 11:12 AM
dfaure added inline comments to D5090: User messages cleanup (and de-emphasize Konqueror).
Sun, Mar 19, 10:52 AM · Frameworks
dfaure accepted D5091: Updated user agents (Firefox 52 ESR, Chromium 57).

Bug in the commit log, Chrome 57, not Chromium 52 ;)

Sun, Mar 19, 9:49 AM · Frameworks

Sat, Mar 18

dfaure committed R170:da7daa17e41a: Repair compilation of the invitation autotests. They are broken, but at least… (authored by dfaure).
Repair compilation of the invitation autotests. They are broken, but at least…
Sat, Mar 18, 4:52 PM

Wed, Mar 15

dfaure accepted D5040: [KDialog] Fix --attach argument by watching for QDialog.

I should have said this earlier, but qobject_cast<QDialog *>(o) would even be better than inherits, and the isWidgetType() check is unnecessary anyway (a dialog is a widget, yes). Oh well ;) Either way, ship it.

Wed, Mar 15, 9:05 PM
dfaure committed R237:e1fd748982dc: Remove unused QDateTime in KConfigBackend. (authored by dfaure).
Remove unused QDateTime in KConfigBackend.
Wed, Mar 15, 12:27 PM
dfaure committed R237:c5be11a78983: Now that kconfigbackend.h isn't installed anymore, rename it to _p.h for… (authored by dfaure).
Now that kconfigbackend.h isn't installed anymore, rename it to _p.h for…
Wed, Mar 15, 12:27 PM
dfaure committed R4:77ad64872f69: Port away from qt_qhash_seed which is going away in Qt 5.9 (authored by dfaure).
Port away from qt_qhash_seed which is going away in Qt 5.9
Wed, Mar 15, 9:20 AM
dfaure added a comment to D5040: [KDialog] Fix --attach argument by watching for QDialog.

Well, KDialog inherits from QDialog, so your new check covers both.

Wed, Mar 15, 8:03 AM
dfaure committed R158:ab8c2381ae1e: Port away from qt_qhash_seed which is going away in Qt 5.9 (authored by dfaure).
Port away from qt_qhash_seed which is going away in Qt 5.9
Wed, Mar 15, 7:53 AM
dfaure committed R158:52cb4d3a7dc7: Port away from qt_qhash_seed which is going away in Qt 5.9 (authored by dfaure).
Port away from qt_qhash_seed which is going away in Qt 5.9
Wed, Mar 15, 7:52 AM
dfaure committed R172:0fa4d280dbbe: Merge branch 'Applications/16.12' (authored by dfaure).
Merge branch 'Applications/16.12'
Wed, Mar 15, 7:49 AM
dfaure committed R172:93b2da839a29: Port away from qt_qhash_seed which is going away in Qt 5.9 (authored by dfaure).
Port away from qt_qhash_seed which is going away in Qt 5.9
Wed, Mar 15, 7:49 AM
dfaure accepted D5049: [PlacesItemModel] Use QDir::homePath() instead of KUser().homeDir().

Would be worth doing a search for all uses of KUser::homeDir() then -- and possibly deprecated it, except if it makes sense for e.g. a user-management KCM?

Wed, Mar 15, 7:37 AM

Mon, Mar 13

dfaure committed R241:d804fb5ef43e: autotest: comment why the SSE-disabling thing doesn't work (QTBUG-47566) (authored by dfaure).
autotest: comment why the SSE-disabling thing doesn't work (QTBUG-47566)
Mon, Mar 13, 7:55 PM

Sun, Mar 12

dfaure added a comment to D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification.

Ship it ;)

Sun, Mar 12, 2:32 PM · Frameworks, Plasma
dfaure added a comment to D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification.

Yes; looks much nicer, doesn't it?

Sun, Mar 12, 2:23 PM · Frameworks, Plasma

Sat, Mar 11

dfaure accepted D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification.

Extra credit for factorizing this into a file-static function and handling data: URLs separately (no point in seeing 100 chars of data crap, we could do data:[...] or something like that).

Sat, Mar 11, 7:09 PM · Frameworks, Plasma
dfaure accepted D5017: Fix ecm_generate_pkgconfig_file compatibility with new cmake.
Sat, Mar 11, 7:06 PM · Build System, Frameworks
dfaure added a comment to D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification.

Can you use KStringHandler::csqueeze ? This way filenames are still visible.

Sat, Mar 11, 1:07 PM · Frameworks, Plasma

Fri, Mar 10

dfaure committed R94:ab111e47e20e: Fix expected value in messagefactorytest. (authored by dfaure).
Fix expected value in messagefactorytest.
Fri, Mar 10, 7:06 AM
dfaure closed D4811: Fix expected value in messagefactorytest. by committing R94:ab111e47e20e: Fix expected value in messagefactorytest..
Fri, Mar 10, 7:06 AM · KDE PIM

Thu, Mar 9

dfaure committed R94:3048a9657de0: autotests: workaround ctest not exiting when klauncher was started by the test (authored by dfaure).
autotests: workaround ctest not exiting when klauncher was started by the test
Thu, Mar 9, 8:53 AM

Wed, Mar 8

dfaure added a comment to D4979: Add places:/ KIO slave.

"I didn't find signals to notify changes" --> you mean how to tell apps that something changed in a given protocol? That's what KDirNotify is for, but you can't do the monitoring from a short-lived slave, you need something that stays alive for the whole session, and that's what a kded module can be used for.

Wed, Mar 8, 8:59 PM · Plasma
dfaure added inline comments to D4823: Pass application name and icon to KRun.
Wed, Mar 8, 1:39 PM
dfaure added a comment to D4937: Add KFileWidget::setSelectedUrl().

BTW don't port the callers to this new method yet, we'll have to wait until the KF5 minimum requirement is raised in kdialog and plasma-integration. I made a TODO for June ;)

Wed, Mar 8, 1:01 PM · Frameworks
dfaure committed R241:f49f34727ee6: Add KFileWidget::setSelectedUrl() (authored by dfaure).
Add KFileWidget::setSelectedUrl()
Wed, Mar 8, 12:13 PM
dfaure closed D4937: Add KFileWidget::setSelectedUrl().
Wed, Mar 8, 12:11 PM · Frameworks
dfaure updated the diff for D4937: Add KFileWidget::setSelectedUrl().

Add test for relative URL and document the proper way to do it

Wed, Mar 8, 8:24 AM · Frameworks
dfaure accepted D4968: Mac OS (X) has a POSIX-compliant /bin/sh too.

Can you use arc diff to upload changes? Then context would be available in the diffs (I think).

Wed, Mar 8, 8:13 AM · Frameworks
dfaure added a comment to D4847: KAuth integration in document saving.

I don't know the full architecture of this kauth stuff, but isn't it possible to save to <destinationfile>.tmp rather than /tmp, ~/.cache or anywhere else? Then instead of "more likely" we are *sure* it's on the same device as the destination.

Wed, Mar 8, 8:03 AM · KTextEditor, Frameworks

Tue, Mar 7

dfaure added a comment to D4937: Add KFileWidget::setSelectedUrl().

I thought about it, but the call sites I found didn't actually need that. So unless you know of one, I changed my mind to "let's wait for someone to request it". Although I guess it won't happen because people will just pass a QUrl instead ;-)

Tue, Mar 7, 11:47 AM · Frameworks
dfaure updated the diff for D4937: Add KFileWidget::setSelectedUrl().

deprecate setSelection

Tue, Mar 7, 9:38 AM · Frameworks
dfaure added a comment to D4937: Add KFileWidget::setSelectedUrl().

I just found that this bug was very likely introduced by the fix for https://bugs.kde.org/show_bug.cgi?id=369216, proving that a method that takes a badly defined QString leads to some code (kdialog) calling it with a path and other code (filedialog integration plugin) calling it with URLs, which only leads to ping-pong fixes ;)

Tue, Mar 7, 9:09 AM · Frameworks
dfaure added a comment to D4923: [desktop:/ KIO] Strip superfluous slashes and fixup local root url.

KFileItem::localPath() should not ever ever be a URL like desktop:/. That would be very wrong.
It just returns what you set in UDS_LOCAL_PATH, so it's kio_desktop you should debug, not kio ;)
Well except for KIO::ForwardingSlaveBase, called by kio_desktop -- note that ForwardingSlaveBase::prepareUDSEntry already sets UDS_LOCAL_PATH, but ok you call insert again which replaces that value.

Tue, Mar 7, 8:50 AM · Plasma
dfaure added a comment to D4847: KAuth integration in document saving.

Right the only way to get atomic renaming is to write the tempfile next to its final destination, NOT in /tmp.
(just like QSaveFile does ;)

Tue, Mar 7, 8:15 AM · KTextEditor, Frameworks

Mon, Mar 6

dfaure committed R320:c57b3d4921fc: Merge branch 'Applications/16.12' (authored by dfaure).
Merge branch 'Applications/16.12'
Mon, Mar 6, 8:45 AM
dfaure committed R320:7386dfcf96a5: Fix kio_sftp hanging when server doesn't support statvfs (authored by dfaure).
Fix kio_sftp hanging when server doesn't support statvfs
Mon, Mar 6, 8:37 AM

Sun, Mar 5

dfaure accepted D4839: kio_mtp: add write permissions to root storage folder.

If you say it works... ;)

Sun, Mar 5, 7:16 PM · Plasma
dfaure committed R309:814295b61b7f: [autotest] Fix the workaround for inotify-on-overlay-fs so it actually works (authored by dfaure).
[autotest] Fix the workaround for inotify-on-overlay-fs so it actually works
Sun, Mar 5, 7:09 PM
dfaure accepted D4941: Avoid a lot allocations in KConfig.
Sun, Mar 5, 6:56 PM · Frameworks
dfaure added inline comments to D4847: KAuth integration in document saving.
Sun, Mar 5, 6:55 PM · KTextEditor, Frameworks
dfaure committed R309:a0c8cf9d43fb: [autotest] test s-m-i requirement (authored by dfaure).
[autotest] test s-m-i requirement
Sun, Mar 5, 6:30 PM
dfaure committed R309:854f6d3cd0e6: [autotests] add tests for the KService constructors (authored by dfaure).
[autotests] add tests for the KService constructors
Sun, Mar 5, 6:08 PM
dfaure added inline comments to D4937: Add KFileWidget::setSelectedUrl().
Sun, Mar 5, 1:50 PM · Frameworks
dfaure added inline comments to D4937: Add KFileWidget::setSelectedUrl().
Sun, Mar 5, 1:43 PM · Frameworks
dfaure added inline comments to D4937: Add KFileWidget::setSelectedUrl().
Sun, Mar 5, 1:29 PM · Frameworks

Sat, Mar 4

dfaure created D4937: Add KFileWidget::setSelectedUrl().
Sat, Mar 4, 7:54 PM · Frameworks
dfaure committed R497:95c98f740ca0: KF 5.32 fixes (authored by dfaure).
KF 5.32 fixes
Sat, Mar 4, 7:20 PM
dfaure committed R241:fb4ad46b0dba: With this change it is now possible to list multiple paths as defined via the… (authored by mwolff).
With this change it is now possible to list multiple paths as defined via the…
Sat, Mar 4, 7:05 PM
dfaure committed R39:ad04b82318fa: Fix compilation with Qt 5.6 (authored by dfaure).
Fix compilation with Qt 5.6
Sat, Mar 4, 6:29 PM
dfaure committed R304:ca7fb5c6a680: Fix compilation with Qt 5.6 (authored by dfaure).
Fix compilation with Qt 5.6
Sat, Mar 4, 6:26 PM
dfaure committed R244:9d31febf74e3: Fix compilation with Qt 5.6. (authored by dfaure).
Fix compilation with Qt 5.6.
Sat, Mar 4, 6:01 PM
dfaure committed R165:f42e54c0c390: Fix ServerManager going into Broken state when called before going to the event… (authored by dfaure).
Fix ServerManager going into Broken state when called before going to the event…
Sat, Mar 4, 2:28 PM
dfaure committed R241:e4ea31a53969: Cookies KCM: disable "delete" button when there is no current item (authored by dfaure).
Cookies KCM: disable "delete" button when there is no current item
Sat, Mar 4, 1:54 PM
dfaure closed D4932: Cookies KCM: disable "delete" button when there is no current item.
Sat, Mar 4, 1:52 PM · Frameworks
dfaure added a comment to D4932: Cookies KCM: disable "delete" button when there is no current item.

I'm curious to find out whether the clang static analyzer still complains or realizes this is fine now :)

Sat, Mar 4, 1:51 PM · Frameworks
dfaure accepted D4630: Only register APPLE_* options if(APPLE).
Sat, Mar 4, 9:53 AM · Build System, Frameworks
dfaure added a comment to D4823: Pass application name and icon to KRun.

Seems like a valid fix.

Sat, Mar 4, 9:17 AM
dfaure created D4932: Cookies KCM: disable "delete" button when there is no current item.
Sat, Mar 4, 9:11 AM · Frameworks

Fri, Mar 3

dfaure added a comment to D4923: [desktop:/ KIO] Strip superfluous slashes and fixup local root url.

QDir::cleanPath or QUrl::NormalizePathSegments can help making this fix more generic.

Fri, Mar 3, 3:30 PM · Plasma
dfaure committed R497:11337541f8aa: more error checking (authored by dfaure).
more error checking
Fri, Mar 3, 12:46 PM
dfaure added a comment to D4849: Export a proper shared library for KDocTools.

I think you can remove the static lib, yes. It didn't "look" like a proper KF5 lib, being the only static one, and the functions being undocumented, etc.

Fri, Mar 3, 11:58 AM · Documentation, Frameworks
dfaure accepted D4849: Export a proper shared library for KDocTools.
Fri, Mar 3, 11:57 AM · Documentation, Frameworks
dfaure accepted D4769: Try to get the real port instead of always use DEFAULT_SFTP_PORT.

Looks good - just a minor nitpick on coding style / readability, feel free to push (either way, actually).

Fri, Mar 3, 11:56 AM

Thu, Mar 2

dfaure added inline comments to D4849: Export a proper shared library for KDocTools.
Thu, Mar 2, 10:15 AM · Documentation, Frameworks
dfaure added inline comments to D4849: Export a proper shared library for KDocTools.
Thu, Mar 2, 9:24 AM · Documentation, Frameworks
dfaure committed R94:1f4f40492226: Finish removing the user agent from sent emails. (authored by dfaure).
Finish removing the user agent from sent emails.
Thu, Mar 2, 8:53 AM
dfaure accepted D4850: Use the new shared library exported by KDocTools.
Thu, Mar 2, 8:06 AM · Frameworks
dfaure closed D4809: Finish removing the user agent from sent emails..
Thu, Mar 2, 8:01 AM · KDE PIM

Tue, Feb 28

dfaure added a comment to D4799: Delay notifications until desktop session has loaded.

Yes interface->isServiceRegistered(dbusServiceName) is technically blocking, but it can't block for a long time, since it's only talking to the dbus daemon. The reply comes in rather quickly, unlike a blocking call to another KDE process which could be busy or where the call itself could take a long time to be processed.
In summary, I don't think an existing call to isServiceRegistered can be used as an argument for making (potentially much much longer) blocking calls.

Tue, Feb 28, 9:46 PM · Plasma, Frameworks
dfaure accepted D4739: make sure the cancel action is last.
Tue, Feb 28, 12:02 PM · Frameworks, Plasma
dfaure added inline comments to D4739: make sure the cancel action is last.
Tue, Feb 28, 11:56 AM · Frameworks, Plasma

Mon, Feb 27

dfaure committed R4:81370ce00868: Fix compilation with Qt < 5.8, missing QSharedPointer(nullptr_t) support. (authored by dfaure).
Fix compilation with Qt < 5.8, missing QSharedPointer(nullptr_t) support.
Mon, Feb 27, 4:37 PM
dfaure closed D4825: Fix compilation with Qt < 5.8, missing QSharedPointer(nullptr_t) support..
Mon, Feb 27, 4:37 PM
dfaure created D4825: Fix compilation with Qt < 5.8, missing QSharedPointer(nullptr_t) support..
Mon, Feb 27, 4:28 PM
dfaure committed R4:7ec90d075379: New feature: running task widget (authored by dfaure).
New feature: running task widget
Mon, Feb 27, 10:48 AM
dfaure committed R499:36441b69ad14: messagelib: attachmentvcardfromaddressbookjobtest needs… (authored by dfaure).
messagelib: attachmentvcardfromaddressbookjobtest needs…
Mon, Feb 27, 8:37 AM