dfaure (David Faure)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2015, 12:44 PM (196 w, 5 d)
Availability
Available

Recent Activity

Yesterday

dfaure accepted D17502: Store timestamp as UTC.
Tue, Dec 11, 12:46 PM · Frameworks

Sun, Dec 9

dfaure committed R883:1530414: update qt-kde image from Björn Feber.
update qt-kde image from Björn Feber
Sun, Dec 9, 8:38 PM
dfaure committed R474:1a0eca5bd4f9: Merge branch 'Applications/18.12' (authored by dfaure).
Merge branch 'Applications/18.12'
Sun, Dec 9, 5:53 PM
dfaure committed R474:22105f451647: Fix compilation with -DQT_NO_URL_CAST_FROM_STRING and enable it. (authored by dfaure).
Fix compilation with -DQT_NO_URL_CAST_FROM_STRING and enable it.
Sun, Dec 9, 5:53 PM
dfaure committed R146:a59d709e21a0: Fix compilation with -DQT_NO_URL_CAST_FROM_STRING and enabled it (authored by dfaure).
Fix compilation with -DQT_NO_URL_CAST_FROM_STRING and enabled it
Sun, Dec 9, 5:49 PM
dfaure committed R456:957e7892748e: Merge branch 'Applications/18.12' (authored by dfaure).
Merge branch 'Applications/18.12'
Sun, Dec 9, 5:41 PM
dfaure committed R456:9e2e6f01afbe: Fix compilation with -DQT_NO_CAST_TO_ASCII and enable it. (authored by dfaure).
Fix compilation with -DQT_NO_CAST_TO_ASCII and enable it.
Sun, Dec 9, 5:38 PM
dfaure committed R497:30752a1d9c18: Remove weird trailing spaces which messed up the email (authored by dfaure).
Remove weird trailing spaces which messed up the email
Sun, Dec 9, 10:57 AM
dfaure committed R883:1530391: KF 5.53.
KF 5.53
Sun, Dec 9, 10:55 AM
dfaure committed R497:5350d6b61ada: Update checkout name (authored by dfaure).
Update checkout name
Sun, Dec 9, 10:55 AM
dfaure committed R883:1530390: add frameworks-5.53.0 to generate_release_data.py.
add frameworks-5.53.0 to generate_release_data.py
Sun, Dec 9, 10:54 AM
dfaure accepted D17446: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin.
Sun, Dec 9, 10:34 AM · Frameworks

Sun, Dec 2

dfaure accepted D17290: Don't set DCMAKE_BUILD_TYPE in kf5-frameworks-build-include.

Fair point, one can set this in kdesrc-buildrc anyway.

Sun, Dec 2, 2:43 PM

Fri, Nov 30

dfaure requested changes to D17167: Provide a method of assigning custom default icons for non-XDG dirs.

This feels *very* special cased. Where does this automagic ends? Any why only in $HOME? We'll keep adding entries here forever... Why don't people use a .directory file for this?
If ~/Games is a de-facto standard, whoever creates it could add a .directory in there. If it's not, then that makes my point.

Fri, Nov 30, 12:37 PM · Frameworks
dfaure accepted D17208: Set window icon with --icon argument.
Fri, Nov 30, 12:27 PM
dfaure accepted D17195: Avoid constantly increasing Qt event queue in KIO slaves.

Very nice catch.

Fri, Nov 30, 12:20 PM · Frameworks
dfaure committed R278:42c6c1ec13a0: autotests: cast to int so that the values appear. (authored by dfaure).
autotests: cast to int so that the values appear.
Fri, Nov 30, 11:01 AM
dfaure committed R275:93157cd3d25a: autotests: remove testmodelqueuedconnections.cpp which asserts in Qt 5.11 (authored by dfaure).
autotests: remove testmodelqueuedconnections.cpp which asserts in Qt 5.11
Fri, Nov 30, 10:59 AM
dfaure added a comment to D16867: Don't generate appstream data for files that lack a description.

More casualties: the kpackage unittests...

Fri, Nov 30, 10:48 AM · Frameworks
dfaure added a comment to D17204: BrightScript: Allow sub to be unnamed.

It seems this commit is the reason for the unittest failure below?

Fri, Nov 30, 10:46 AM · Frameworks, Kate

Thu, Nov 29

dfaure accepted D17238: Explicitly create QDateTime with UTC time.

Yep, tzset is really slow. I suppose there are other similar lines of code in KIO that would benefit from the same fix? KFileItem for example?

Thu, Nov 29, 4:37 PM · Frameworks

Mon, Nov 26

dfaure accepted D17017: Fix assert when cleaning up symlinks in PreviewJob.
Mon, Nov 26, 8:08 AM · Frameworks

Sun, Nov 25

dfaure accepted D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).
Sun, Nov 25, 8:04 AM · Frameworks
dfaure committed R497:e3d5e87551c9: Update CI URLs (authored by dfaure).
Update CI URLs
Sun, Nov 25, 12:39 AM

Sat, Nov 24

dfaure committed R499:39159dc30e51: kdeconnect is missing a stable-branch entry here. (authored by dfaure).
kdeconnect is missing a stable-branch entry here.
Sat, Nov 24, 11:38 PM
dfaure closed D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`.

https://commits.kde.org/frameworkintegration/4cc12a5ad1fa92f8b934f02ff2e401539ec9b9f7

Sat, Nov 24, 11:03 AM · Frameworks
dfaure committed R252:4cc12a5ad1fa: Add option BUILD_KPACKAGE_INSTALL_HANDLERS to skip building install handlers (authored by ntninja).
Add option BUILD_KPACKAGE_INSTALL_HANDLERS to skip building install handlers
Sat, Nov 24, 11:03 AM
dfaure added a comment to D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`.

Ah, you need to specify that you don't have a developer account, otherwise the assumption is simply that you'll push the patch once approved.

Sat, Nov 24, 10:59 AM · Frameworks

Thu, Nov 22

dfaure added a comment to D17071: Don't include any directory sizes in DirectorySizeJob.

(sure it's convenient for the unittest, but less meaningful for the users....)

Thu, Nov 22, 8:49 AM · Frameworks
dfaure added a comment to D17071: Don't include any directory sizes in DirectorySizeJob.

Hmm hmm. The goal of this was to behave like "du" as much as possible. As you say, the real bug isn't that we count directories, but that we count files "as is" instead of blocks. But I'm not sure how easily we could get block information from here.

Thu, Nov 22, 8:46 AM · Frameworks

Wed, Nov 21

dfaure accepted D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).
Wed, Nov 21, 3:45 PM · Frameworks
dfaure accepted D17065: Fix mem leak found with asan.

Cool, that debugging and profiling training I gave you last week is already paying off :-)

Wed, Nov 21, 9:33 AM · Frameworks
dfaure requested changes to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB).
Wed, Nov 21, 12:04 AM · Frameworks

Tue, Nov 20

dfaure accepted D17048: Restore sendfile support.

Nice catch.

Tue, Nov 20, 10:04 PM · Frameworks

Mon, Nov 19

dfaure committed R165:b39e2a01d84b: Merge branch 'Applications/18.12' (authored by dfaure).
Merge branch 'Applications/18.12'
Mon, Nov 19, 10:36 PM
dfaure committed R165:fbcd065c0dbb: Akonadi: ignore remote ID if it's empty (authored by dfaure).
Akonadi: ignore remote ID if it's empty
Mon, Nov 19, 10:36 PM
dfaure closed D16917: Akonadi: ignore remote ID if it's empty.
Mon, Nov 19, 10:35 PM · KDE PIM
dfaure accepted D17018: actually initialize kcrash properly.
Mon, Nov 19, 9:30 PM
dfaure accepted D17021: [ioslaves/trash] Handle broken symlinks in deleted subdirectories.
Mon, Nov 19, 9:27 PM · Frameworks
dfaure accepted D17010: Make sure the unified mailbox dialog is only really shown once.
Mon, Nov 19, 12:04 PM · KDE PIM
dfaure accepted D16985: Fix apidox of RenameDialog_Option.
Mon, Nov 19, 8:51 AM · Frameworks

Sun, Nov 18

dfaure committed R86:116e2ad3105c: Fix wrong commit that left an old call to rehighlight() (authored by dfaure).
Fix wrong commit that left an old call to rehighlight()
Sun, Nov 18, 6:27 PM

Sat, Nov 17

dfaure committed R499:f6b192465e56: Make it possible to compile plasma-mycroft on top of stable-kf5-qt5 too (authored by dfaure).
Make it possible to compile plasma-mycroft on top of stable-kf5-qt5 too
Sat, Nov 17, 5:45 PM

Fri, Nov 16

dfaure added a comment to D8843: Use URLs in multiget requests as returned by the Server.

Here's some debug output to understand what's going on:

Fri, Nov 16, 10:56 PM · KDE PIM
dfaure requested review of D16917: Akonadi: ignore remote ID if it's empty.
Fri, Nov 16, 7:50 AM · KDE PIM

Nov 10 2018

dfaure added a comment to D16407: Add test to check that cookies are imported from KCookieServer at creation.

I don't like magic based on process name. Just call a setter from the tests that sets a bool to enable the logging into m_testCookies? Inside the ifdef if you want, although the performance impact (of checking a bool) is negligible, so actually I'd remove the define/ifdef... (but I'm also OK with it if you want to keep it).

Nov 10 2018, 10:28 PM
dfaure committed R320:349c958e78a7: MTP: fix runtime warning when showing a warning to the user. (authored by dfaure).
MTP: fix runtime warning when showing a warning to the user.
Nov 10 2018, 10:20 PM
dfaure closed D16674: MTP: fix runtime warning when showing a warning to the user..
Nov 10 2018, 10:19 PM · Frameworks, Dolphin
dfaure requested changes to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.
Nov 10 2018, 10:16 PM · Frameworks
dfaure requested changes to D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path.
Nov 10 2018, 9:44 PM · Frameworks
dfaure added inline comments to D7380: KCD: use modern logging classes throughout.
Nov 10 2018, 9:39 PM
dfaure accepted D16798: KPluginFactory: fix create() apidox.
Nov 10 2018, 9:33 PM · Frameworks
dfaure requested changes to D16798: KPluginFactory: fix create() apidox.
Nov 10 2018, 11:56 AM · Frameworks
dfaure committed R883:1528157: KF 5.52.
KF 5.52
Nov 10 2018, 8:52 AM
dfaure committed R883:1528156: add frameworks-5.52.0 to generate_release_data.py.
add frameworks-5.52.0 to generate_release_data.py
Nov 10 2018, 8:46 AM

Nov 7 2018

dfaure accepted D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space.

switch would require ugly fall-through, I prefer this code.

Nov 7 2018, 10:13 PM · Frameworks

Nov 4 2018

dfaure requested review of D16674: MTP: fix runtime warning when showing a warning to the user..
Nov 4 2018, 10:33 PM · Frameworks, Dolphin
dfaure requested changes to D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob.

This map will keep growing and growing...

Nov 4 2018, 10:14 AM · Frameworks
dfaure accepted D16355: Ask the user what to do in case of a SSL certificate error.
Nov 4 2018, 9:50 AM
dfaure requested changes to D16407: Add test to check that cookies are imported from KCookieServer at creation.
Nov 4 2018, 9:42 AM

Nov 3 2018

dfaure committed R497:109bd392741d: Fixes for KF 5.52 (authored by dfaure).
Fixes for KF 5.52
Nov 3 2018, 7:59 PM
dfaure committed R298:ecb5803e64de: Fix compile time warnings about nullptr (authored by dfaure).
Fix compile time warnings about nullptr
Nov 3 2018, 6:40 PM
dfaure committed R244:ee424e9b6236: autotests: repair "detecting hardlink change" with stat/qfswatch (authored by dfaure).
autotests: repair "detecting hardlink change" with stat/qfswatch
Nov 3 2018, 2:00 PM
dfaure committed R243:32374fd82e21: autotests: force use of utf8 for filename encodings (authored by dfaure).
autotests: force use of utf8 for filename encodings
Nov 3 2018, 1:26 PM

Nov 2 2018

dfaure added a comment to D16509: Eventviews: associate calendar color to remoteID rather than ID..

assuming DAV actually supports that.

It doesn't: https://stackoverflow.com/a/30871369.
I didn't find "color" nor "colour" in any CalDAV/WebDAV/iCal RFC either, except for one unrelated match in https://tools.ietf.org/html/rfc4791.

Nov 2 2018, 4:02 PM

Nov 1 2018

dfaure added a comment to D16509: Eventviews: associate calendar color to remoteID rather than ID..

I'm having second thoughts about this one.

Nov 1 2018, 11:12 PM
dfaure committed R76:4dab2d3b545b: Eventviews: properly fall back to color-generator if ColorAttribute is absent (authored by dfaure).
Eventviews: properly fall back to color-generator if ColorAttribute is absent
Nov 1 2018, 11:07 PM
dfaure closed D16508: Eventviews: properly fall back to color-generator if ColorAttribute is absent.
Nov 1 2018, 11:07 PM
dfaure added inline comments to D16508: Eventviews: properly fall back to color-generator if ColorAttribute is absent.
Nov 1 2018, 11:01 PM

Oct 31 2018

dfaure committed R76:46344f242854: Eventviews: simplify/modernize resource color code (authored by dfaure).
Eventviews: simplify/modernize resource color code
Oct 31 2018, 3:50 PM
dfaure added inline comments to D16507: Eventviews: simplify/modernize resource color code.
Oct 31 2018, 3:47 PM · KDE PIM
dfaure closed D16507: Eventviews: simplify/modernize resource color code.
Oct 31 2018, 3:44 PM · KDE PIM

Oct 30 2018

dfaure committed R210:4679c1d8da2e: Merge branch 'Applications/18.08' (authored by dfaure).
Merge branch 'Applications/18.08'
Oct 30 2018, 10:26 AM
dfaure committed R210:7d2d99a18cdf: korgac: repair the dumpAlarms() DBus method (authored by dfaure).
korgac: repair the dumpAlarms() DBus method
Oct 30 2018, 10:26 AM

Oct 29 2018

dfaure committed R210:77fb04fb4310: korgac: hide "Dismiss all" button if there's only one reminder. (authored by dfaure).
korgac: hide "Dismiss all" button if there's only one reminder.
Oct 29 2018, 10:45 AM
dfaure added a comment to D16506: korgac: hide "Dismiss all" button if there's only one reminder..

Laurent: can you do the merge to master? There's a whole lot of version numbers conflicts which I don't have time to sort out right now ;)

Oct 29 2018, 10:45 AM · KDE PIM
dfaure closed D16506: korgac: hide "Dismiss all" button if there's only one reminder..
Oct 29 2018, 10:43 AM · KDE PIM
dfaure requested review of D16510: Context pages: show project name as additional information..
Oct 29 2018, 10:26 AM
dfaure updated the diff for D16210: Zanshin: show datasource in inbox page model..

Don't show data source for child tasks, it's redundant.

Oct 29 2018, 10:25 AM
dfaure updated the diff for D16036: Workday: display project name under the task title.

Don't show project name for subtasks. Makes the view smaller indeed.

Oct 29 2018, 10:23 AM
dfaure requested review of D16509: Eventviews: associate calendar color to remoteID rather than ID..
Oct 29 2018, 10:21 AM
dfaure requested review of D16508: Eventviews: properly fall back to color-generator if ColorAttribute is absent.
Oct 29 2018, 10:14 AM
dfaure requested review of D16507: Eventviews: simplify/modernize resource color code.
Oct 29 2018, 10:11 AM · KDE PIM
dfaure requested review of D16506: korgac: hide "Dismiss all" button if there's only one reminder..
Oct 29 2018, 10:01 AM · KDE PIM

Oct 28 2018

dfaure committed R4:30ed18347d2a: Better fix for the compilation problem with older Qt versions. (authored by dfaure).
Better fix for the compilation problem with older Qt versions.
Oct 28 2018, 12:55 PM

Oct 22 2018

dfaure added a comment to D16348: Properly look for the libphonenumber dependency.

This seems copy/pasted from most of the attic cmake modules in ECM, which also say "the BSD license", with a reference to ECM's COPYING-CMAKE-SCRIPTS. Good enough?

Oct 22 2018, 8:13 AM
dfaure accepted D16349: [kdirlistertest] Wait a little longer for the lister to finish.

Thanks!!

Oct 22 2018, 8:11 AM · Frameworks
dfaure accepted D16139: Fix handling of cookies without a domain.
Oct 22 2018, 7:47 AM

Oct 19 2018

dfaure updated the diff for D16036: Workday: display project name under the task title.

Use default-template-type trick, but it makes the additional "int" argument for the data() methods a bit weird (hidden magic)

Oct 19 2018, 9:14 AM
dfaure committed R4:62db4b506aba: Use QueryTreeModelBase to access the roles. (authored by dfaure).
Use QueryTreeModelBase to access the roles.
Oct 19 2018, 7:36 AM
dfaure committed R4:834756778ba9: Implement a basic way to see the project for a task in the workday (authored by dfaure).
Implement a basic way to see the project for a task in the workday
Oct 19 2018, 7:31 AM
dfaure closed D14591: Implement a basic way to see the project for a task in the workday.
Oct 19 2018, 7:31 AM
dfaure accepted D16306: [Codecs] Remove unneeded const_cast.
Oct 19 2018, 7:25 AM · Baloo, Frameworks

Oct 17 2018

dfaure accepted D16248: Fix build with botan < 2 and openssl < 1.1.

Ah sorry I read too fast and I confused HKDFContext et BotanHKDFContext.

Oct 17 2018, 11:51 AM
dfaure added inline comments to D16248: Fix build with botan < 2 and openssl < 1.1.
Oct 17 2018, 7:10 AM

Oct 15 2018

dfaure committed R883:1526620: KF 5.51.
KF 5.51
Oct 15 2018, 8:18 AM
dfaure committed R883:1526617: add frameworks-5.51.0 to generate_release_data.py.
add frameworks-5.51.0 to generate_release_data.py
Oct 15 2018, 8:02 AM

Oct 14 2018

dfaure requested review of D16210: Zanshin: show datasource in inbox page model..
Oct 14 2018, 7:33 PM
l10n daemon script <scripty@kde.org> committed R285:064f7642adc8: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication (authored by dfaure).
KCrash: fix crash (ironic heh) when used in an app without QCoreApplication
Oct 14 2018, 9:34 AM
dfaure added a comment to D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication.

You're right. Fixed, thanks.

Oct 14 2018, 9:33 AM · Frameworks