Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext
ClosedPublic

Authored by meven on Fri, Nov 29, 5:00 PM.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Fri, Nov 29, 5:00 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptFri, Nov 29, 5:00 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.Fri, Nov 29, 5:00 PM
src/dolphincontextmenu.cpp
208

Why this change?

src/dolphincontextmenu.h
150

I'd prefer to add separate TimelineContext and SearchContext values. It would be more future-proof.

meven updated this revision to Diff 70665.Sun, Dec 1, 1:08 PM

Split separately timelinecontext and searchcontext

meven marked 2 inline comments as done.Sun, Dec 1, 1:09 PM
meven added inline comments.
src/dolphincontextmenu.cpp
208

The other function is deprecated since KF 5.0

elvisangelaccio accepted this revision.Sun, Dec 1, 10:17 PM
This revision is now accepted and ready to land.Sun, Dec 1, 10:17 PM
This revision was automatically updated to reflect the committed changes.
meven marked an inline comment as done.