chehrlic (Christian Ehrlicher)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 29 2016, 6:00 AM (194 w, 3 d)
Availability
Available

Recent Activity

Thu, Nov 7

chehrlic added inline comments to D25199: Fix some compiler warnings.
Thu, Nov 7, 7:54 PM

Oct 21 2019

chehrlic added inline comments to D24422: [dolphin] Improve parsing of Baloo query searchString.
Oct 21 2019, 8:18 PM · Dolphin
chehrlic added a comment to D24841: Use modern way to set the C/CXX standard.

I would also use CMAKE_CXX_STANDARD_REQUIRED to make sure the compiler actually *can* c++11, otherwise the flag is only added when the compiler supports it. Should not make much difference nowadays but since it's in ECM...

Oct 21 2019, 7:05 PM · Build System, Frameworks

Sep 28 2019

chehrlic added a comment to D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API.
  • why has all Qt code not yet been adapted to QT_DEPRECATED_VERSION/QT_DEPRECATED_VERSION_X, are there places where those macros should not be used, but the version-less ones?

Because noone wanted to do the work and it was added late in the Qt5 lifetime -> A lot of stuff was deprecated for a long time already (in Qt4 times) and there is was a replacement since Qt5.0.0 so the macro was not needed (even though a lot of people got very angry about it). I added it for some new signals which created a lot of discussion since the old ones are widely used.

Can you point to those discussions? Would be curious to learn what people's thought are.

https://lists.qt-project.org/pipermail/development/2019-March/035343.html

Sep 28 2019, 5:11 PM · Build System, Frameworks

Sep 27 2019

chehrlic added a comment to D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API.

Actual questions I have:

  • why is QT_DEPRECATED_WARNINGS_SINCE not officially documented? like, any plans to change that macro to something else?

Just forgot it (and also the reviewers) I would guess. There is no plan to change it, at least none I'm aware of. I'm looking for an automatic generation of this macro. Since Qt6 switches to CMake I can maybe borrow some stuff from you ;)

Sep 27 2019, 7:09 PM · Build System, Frameworks

Sep 23 2019

chehrlic committed R220:6230f6bd7483: CacheEntry: don't work on danlging reference (authored by chehrlic).
CacheEntry: don't work on danlging reference
Sep 23 2019, 8:09 AM

Aug 9 2019

chehrlic committed R220:30830d51ca01: Fix opening 'Open with' dialog in context menu (authored by chehrlic).
Fix opening 'Open with' dialog in context menu
Aug 9 2019, 8:06 PM
chehrlic committed R220:90436ec1642a: Remove Help button to not confuse the user - it's without functionality and… (authored by chehrlic).
Remove Help button to not confuse the user - it's without functionality and…
Aug 9 2019, 7:47 PM

Aug 1 2019

chehrlic closed D22849: kdesvn: cleanup/c++11'ify.

uploaded without arcanist to have 11 separate commits

Aug 1 2019, 9:39 AM
chehrlic committed R220:ad2ef6dd1302: svnfrontend/svnactions: use range-based for loops (authored by chehrlic).
svnfrontend/svnactions: use range-based for loops
Aug 1 2019, 9:37 AM
chehrlic committed R220:c80b5b4d9599: svnfrontend/models: use range-based for loops (authored by chehrlic).
svnfrontend/models: use range-based for loops
Aug 1 2019, 9:37 AM
chehrlic committed R220:16d79c974f66: svnfrontend: use range-based for loops, use member-initialization instead… (authored by chehrlic).
svnfrontend: use range-based for loops, use member-initialization instead…
Aug 1 2019, 9:37 AM
chehrlic committed R220:4db93e13d4bb: svnfrontend: use range-based for loops (authored by chehrlic).
svnfrontend: use range-based for loops
Aug 1 2019, 9:37 AM
chehrlic committed R220:6cba8a75fb16: svnqt: use range-based for loops (authored by chehrlic).
svnqt: use range-based for loops
Aug 1 2019, 9:37 AM
chehrlic committed R220:95c78951e2dd: svnqt/cache: use range-based for loops (authored by chehrlic).
svnqt/cache: use range-based for loops
Aug 1 2019, 9:37 AM
chehrlic committed R220:9f9b893ae8a6: SvnTreeView: remove useless ctor, SvnLogModel: add override (authored by chehrlic).
SvnTreeView: remove useless ctor, SvnLogModel: add override
Aug 1 2019, 9:37 AM
chehrlic committed R220:e1674383fdf7: kiosvn/ksvnwidgets: use range-based for loops, dont' emit dataChanged() twice… (authored by chehrlic).
kiosvn/ksvnwidgets: use range-based for loops, dont' emit dataChanged() twice…
Aug 1 2019, 9:37 AM
chehrlic committed R220:001079f2f60a: StringArray: remove unused functions StringArray::operator[], use range-based… (authored by chehrlic).
StringArray: remove unused functions StringArray::operator[], use range-based…
Aug 1 2019, 9:37 AM
chehrlic committed R220:f7e391e49ce9: Rearrage members for some classes to adjust paddings (authored by chehrlic).
Rearrage members for some classes to adjust paddings
Aug 1 2019, 9:36 AM
chehrlic committed R220:7804d95f6c57: Remove useless svn::Path copy operator - the compiler can create a valid one by… (authored by chehrlic).
Remove useless svn::Path copy operator - the compiler can create a valid one by…
Aug 1 2019, 9:36 AM

Jul 31 2019

chehrlic updated the diff for D22849: kdesvn: cleanup/c++11'ify.
  • svnqt/cache: use range-based for loops
  • svnfrontend: use range-based for loops
  • svnfrontend/models: use range-based for loops
  • svnfrontend: use range-based for loops, use member-initialization instead custom ctors, use auto instead foo<bar>::iterator
  • svnfrontend/svnactions: use range-based for loops
Jul 31 2019, 10:00 AM
chehrlic requested review of D22849: kdesvn: cleanup/c++11'ify.
Jul 31 2019, 10:00 AM

Jul 12 2019

chehrlic accepted D22415: Actually set minimum Qt version.

Thx, this was an oversight from Qt4 porting.

Jul 12 2019, 1:47 PM
chehrlic accepted D22412: Fix build with Qt 5.9.

Thx.

Jul 12 2019, 1:47 PM

Jul 10 2019

chehrlic committed R220:a5657ecba9fd: Update appdata.xml (authored by chehrlic).
Update appdata.xml
Jul 10 2019, 7:22 PM

Jul 3 2019

chehrlic committed R220:2028bc2f3621: Update for 2.1 (authored by chehrlic).
Update for 2.1
Jul 3 2019, 6:57 PM
chehrlic committed R220:d3af6b1358ce: Use range-based for loop (authored by chehrlic).
Use range-based for loop
Jul 3 2019, 6:03 PM
chehrlic committed R220:6030567c1940: Compile with Qt5.13 - add missing include for QList (authored by chehrlic).
Compile with Qt5.13 - add missing include for QList
Jul 3 2019, 6:03 PM
chehrlic committed R220:f3289d180089: Replace some long deprecated Qt functions with their successors (authored by chehrlic).
Replace some long deprecated Qt functions with their successors
Jul 3 2019, 6:03 PM

Jun 1 2019

chehrlic committed R220:1e831035188e: RangeInput: add ability to specifiy revision to display, cleanup ui (authored by chehrlic).
RangeInput: add ability to specifiy revision to display, cleanup ui
Jun 1 2019, 4:15 PM
chehrlic committed R220:3c0f8e35db33: Fix some cppcheck / clang warnings: avoid old-style casts, avoid implicit… (authored by chehrlic).
Fix some cppcheck / clang warnings: avoid old-style casts, avoid implicit…
Jun 1 2019, 3:52 PM
chehrlic committed R220:78c3e54e06e3: Cleanup Commitmsg_impl (authored by chehrlic).
Cleanup Commitmsg_impl
Jun 1 2019, 3:52 PM
chehrlic committed R220:4cfa214d408b: Don't crash on exit when log fill thread is still running (authored by chehrlic).
Don't crash on exit when log fill thread is still running
Jun 1 2019, 3:52 PM
chehrlic committed R220:eddc2e8aa1a1: svn::targets: use int/Paths::size_type instead size_t for the index access (authored by chehrlic).
svn::targets: use int/Paths::size_type instead size_t for the index access
Jun 1 2019, 3:52 PM
chehrlic committed R220:f45f7e426ec4: Use range-based for loop instead iterators/plain for loop (authored by chehrlic).
Use range-based for loop instead iterators/plain for loop
Jun 1 2019, 3:52 PM
chehrlic committed R220:7ab88e623a8b: MainTreeWidget, SvnActions: don't detach in range-based for loops, use emit… (authored by chehrlic).
MainTreeWidget, SvnActions: don't detach in range-based for loops, use emit…
Jun 1 2019, 3:52 PM
chehrlic committed R220:837bb1edbd6d: Enable 'Revert' action when a single directory with modified items is selected (authored by chehrlic).
Enable 'Revert' action when a single directory with modified items is selected
Jun 1 2019, 3:52 PM
chehrlic committed R220:6f15fb1356eb: Models: cleanup includes, add 'emit' keyword where needed, properly emit… (authored by chehrlic).
Models: cleanup includes, add 'emit' keyword where needed, properly emit…
Jun 1 2019, 3:52 PM
chehrlic committed R220:c5a2c178e312: DiffSyntax: port to QRegularExpression (authored by chehrlic).
DiffSyntax: port to QRegularExpression
Jun 1 2019, 3:52 PM

May 28 2019

chehrlic committed R220:022377acfcee: run-clang-tidy: modernize-loop-convert (authored by chehrlic).
run-clang-tidy: modernize-loop-convert
May 28 2019, 7:33 PM
chehrlic committed R220:d95fadbb28a1: Don't accept richtext in commit message dialog (authored by chehrlic).
Don't accept richtext in commit message dialog
May 28 2019, 7:33 PM
chehrlic committed R220:55a03029c727: run-clang-tidy: modernize-use-nullptr, remove some unused includes (authored by chehrlic).
run-clang-tidy: modernize-use-nullptr, remove some unused includes
May 28 2019, 7:33 PM
chehrlic committed R220:8c8697d06a5e: Cleanup QSortFilterProxyModel usages (authored by chehrlic).
Cleanup QSortFilterProxyModel usages
May 28 2019, 7:33 PM
chehrlic committed R220:1708afad4797: Misc: add missing space, add override keyword (authored by chehrlic).
Misc: add missing space, add override keyword
May 28 2019, 7:33 PM

May 3 2019

chehrlic added a comment to D21003: Convert from virtual+Q_DECL_OVERRIDE to override..

The you can also update your minimum Qt version to 5.9 - currently you've 5.7 which still supports gcc 4.6 which does not support 'override' so this requirement is no longer needed and can go away :)

May 3 2019, 7:04 PM

Nov 26 2018

chehrlic committed R220:e3e9de9c5463: Port to new signal/slot syntax (with the help of QOverload::of) (authored by chehrlic).
Port to new signal/slot syntax (with the help of QOverload::of)
Nov 26 2018, 10:15 PM
chehrlic committed R220:b42c702ba527: Propertylist: remove addCallback, use direct signal/slot connection (authored by chehrlic).
Propertylist: remove addCallback, use direct signal/slot connection
Nov 26 2018, 10:15 PM
chehrlic committed R220:d25254d7de30: kio_svnProtocol: return KIO::UDSEntry directly instead through arg reference (authored by chehrlic).
kio_svnProtocol: return KIO::UDSEntry directly instead through arg reference
Nov 26 2018, 10:15 PM

Oct 31 2018

chehrlic committed R220:5dbc14090bce: Remove usage of foreach (authored by chehrlic).
Remove usage of foreach
Oct 31 2018, 3:34 PM
chehrlic committed R220:604bc864a649: Make buttons in sslprompt actually work, use correct cursor when showing this… (authored by chehrlic).
Make buttons in sslprompt actually work, use correct cursor when showing this…
Oct 31 2018, 3:33 PM

Sep 22 2018

chehrlic committed R220:63a79b6e6f59: Update to 2.0.95 in preparation for 2.1 release (authored by chehrlic).
Update to 2.0.95 in preparation for 2.1 release
Sep 22 2018, 7:24 PM
chehrlic committed R220:4958e457fc87: Fix typo (sigUrlOpend -> sigUrlOpened) (authored by chehrlic).
Fix typo (sigUrlOpend -> sigUrlOpened)
Sep 22 2018, 7:24 PM
chehrlic committed R220:d1b60d1551a4: kdesvnd: don't mark non-slots as slots, add const where possible (authored by chehrlic).
kdesvnd: don't mark non-slots as slots, add const where possible
Sep 22 2018, 7:10 PM
chehrlic committed R220:6b286dc8fd15: Set Qt5.9 as minimum required version (authored by chehrlic).
Set Qt5.9 as minimum required version
Sep 22 2018, 7:10 PM
chehrlic committed R220:27b1c2005a16: Create signal slotUrlOpened in kdesvnView and connect it in kdesvn instead… (authored by chehrlic).
Create signal slotUrlOpened in kdesvnView and connect it in kdesvn instead…
Sep 22 2018, 7:10 PM
chehrlic committed R220:7993ac87cafc: Remove wrong connect - no slotHelp in AuthDialogImpl (authored by chehrlic).
Remove wrong connect - no slotHelp in AuthDialogImpl
Sep 22 2018, 7:10 PM
chehrlic committed R220:b02a966f53ba: Use new Signal/Slot syntax with the help of clazy (export CLAZY_FIXIT=fix-old… (authored by chehrlic).
Use new Signal/Slot syntax with the help of clazy (export CLAZY_FIXIT=fix-old…
Sep 22 2018, 7:10 PM
chehrlic committed R220:4693e8cc3ad4: Adjust strings for better translation (authored by chehrlic).
Adjust strings for better translation
Sep 22 2018, 7:10 PM
chehrlic committed R220:26db1d0ce3de: Use 4-arg connect (clazy warning) (authored by chehrlic).
Use 4-arg connect (clazy warning)
Sep 22 2018, 7:10 PM
chehrlic committed R220:4f729b5351d2: Pass CContextListener* instead plain QObject* to StopDlg (authored by chehrlic).
Pass CContextListener* instead plain QObject* to StopDlg
Sep 22 2018, 7:10 PM
chehrlic committed R220:788f40263b29: RevisionTree: directly pass CContextListener* instead QObject*, return… (authored by chehrlic).
RevisionTree: directly pass CContextListener* instead QObject*, return…
Sep 22 2018, 7:10 PM

Aug 12 2018

chehrlic committed R220:ec95b7c728d5: Merge branch '2.0' (authored by chehrlic).
Merge branch '2.0'
Aug 12 2018, 7:41 PM

May 16 2018

chehrlic committed R74:b96538d803c1: CLazy: fix run_tests.py to work with Qt >= 5.10 (authored by chehrlic).
CLazy: fix run_tests.py to work with Qt >= 5.10
May 16 2018, 4:31 AM
chehrlic closed D12763: CLazy: fix run_tests.py to work with Qt >= 5.10.
May 16 2018, 4:30 AM

May 8 2018

chehrlic requested review of D12763: CLazy: fix run_tests.py to work with Qt >= 5.10.
May 8 2018, 6:39 PM

Apr 4 2018

chehrlic added a comment to D11931: [kiriki] avoid memory leak.

And why is m_scores not an object? No need for a pointer here I guess

Apr 4 2018, 7:44 PM

Mar 30 2018

chehrlic committed R220:7d1a5218b535: Summary: Properly emit dataChanged signals when a file changes. dataChanged()… (authored by chehrlic).
Summary: Properly emit dataChanged signals when a file changes. dataChanged()…
Mar 30 2018, 7:13 PM
chehrlic closed D11337: Summary: Properly emit dataChanged signals when a file changes. dataChanged() was only emitted sometimes and then only for column 0..
Mar 30 2018, 7:13 PM

Mar 20 2018

chehrlic committed R220:59c1b2cb840e: Cleanup PropertyListViewItem, fix adding a new property to a svn entry. Thx to… (authored by chehrlic).
Cleanup PropertyListViewItem, fix adding a new property to a svn entry. Thx to…
Mar 20 2018, 7:24 PM

Mar 15 2018

chehrlic committed R220:86c57ff79ef7: clang-tidy - modernize-use-bool-literals (authored by chehrlic).
clang-tidy - modernize-use-bool-literals
Mar 15 2018, 7:52 PM
chehrlic committed R220:e2f7c613c750: clang-tidy - virtual -> override (authored by chehrlic).
clang-tidy - virtual -> override
Mar 15 2018, 7:52 PM
chehrlic committed R220:58918f5750fa: clang-tidy - virtual -> override (authored by chehrlic).
clang-tidy - virtual -> override
Mar 15 2018, 7:52 PM
chehrlic committed R220:2bfdea54b655: clang-tidy - virtual -> override (authored by chehrlic).
clang-tidy - virtual -> override
Mar 15 2018, 7:52 PM
chehrlic committed R220:1426a0312ff4: clang-tidy - modernize-use-nullptr (authored by chehrlic).
clang-tidy - modernize-use-nullptr
Mar 15 2018, 6:53 PM
chehrlic committed R220:0bca87796da3: clang-tidy - modernize-use-nullptr (authored by chehrlic).
clang-tidy - modernize-use-nullptr
Mar 15 2018, 6:53 PM
chehrlic committed R220:41196714afc4: clang-tidy - modernize-use-nullptr (authored by chehrlic).
clang-tidy - modernize-use-nullptr
Mar 15 2018, 6:53 PM
chehrlic committed R220:55670fee6228: Avoid some possible nullptr dereferences (authored by chehrlic).
Avoid some possible nullptr dereferences
Mar 15 2018, 5:13 PM
chehrlic accepted D11355: Display relative path (including name of the checkout) in the titlebar.
Mar 15 2018, 4:42 PM
chehrlic accepted D11346: Only set iconText() if actually changed.

This should at least fix the most cases as described in the bug report :)

Mar 15 2018, 6:02 AM · Frameworks

Mar 14 2018

chehrlic added reviewers for D11337: Summary: Properly emit dataChanged signals when a file changes. dataChanged() was only emitted sometimes and then only for column 0.: dfaure, aspotashev, broulik.
Mar 14 2018, 7:33 PM
chehrlic requested review of D11337: Summary: Properly emit dataChanged signals when a file changes. dataChanged() was only emitted sometimes and then only for column 0..
Mar 14 2018, 7:31 PM
chehrlic committed R220:fc3208214869: SvnSortFilterProxy: cleanup (authored by chehrlic).
SvnSortFilterProxy: cleanup
Mar 14 2018, 7:28 PM
chehrlic committed R220:ec1d3afa107f: SvnActions::createUpdateThread: connect m_UThread instead m_FCThread, convert… (authored by chehrlic).
SvnActions::createUpdateThread: connect m_UThread instead m_FCThread, convert…
Mar 14 2018, 7:28 PM
chehrlic committed R220:9480f5eceff4: SvnActions: make some functions const (authored by chehrlic).
SvnActions: make some functions const
Mar 14 2018, 7:28 PM

Mar 8 2018

chehrlic added inline comments to D10995: Fix some compile warnings.
Mar 8 2018, 4:24 PM

Dec 7 2017

chehrlic created T7552: [clazy] Wrong range-loop warning.
Dec 7 2017, 7:30 PM

Nov 27 2017

chehrlic accepted D8967: Remove configure*.sh.
Nov 27 2017, 4:59 PM
chehrlic accepted D8972: Apply title capitalization to window titles.

Thx, somehow forgot about this review

Nov 27 2017, 4:59 PM
chehrlic accepted D9011: Add ellipsis to button that opens a dialog.
Nov 27 2017, 5:52 AM
chehrlic accepted D9010: Fix typo.
Nov 27 2017, 5:52 AM
chehrlic accepted D9009: Apply title capitalization to dialog title.
Nov 27 2017, 5:51 AM

Nov 23 2017

chehrlic accepted D8975: Add i18n contexts to StopDlg titles.
Nov 23 2017, 6:48 PM

Oct 8 2017

chehrlic committed R183:6bc76bafaa37: Fix title for kirigami by hand for now - this time with the correct display… (authored by chehrlic).
Fix title for kirigami by hand for now - this time with the correct display…
Oct 8 2017, 5:02 PM
chehrlic committed R183:e60954d6f76b: Fix title for kirigami by hand for now (authored by chehrlic).
Fix title for kirigami by hand for now
Oct 8 2017, 5:02 PM
chehrlic committed R183:285568ff17b8: Add description for kirigami by hand for now (authored by chehrlic).
Add description for kirigami by hand for now
Oct 8 2017, 5:02 PM
chehrlic committed R169:75dbb4498ab4: Add 'Introduction' section to README.md - this is needed for inqlude script to… (authored by chehrlic).
Add 'Introduction' section to README.md - this is needed for inqlude script to…
Oct 8 2017, 4:04 PM

Sep 28 2017

chehrlic committed R74:fa75c97e6f9b: Fix false warning in qhash-namespace check for enum (classes) (authored by chehrlic).
Fix false warning in qhash-namespace check for enum (classes)
Sep 28 2017, 5:10 PM
chehrlic closed D8010: Fix false warning in qhash-namespace check for enum (classes).
Sep 28 2017, 5:09 PM

Sep 27 2017

chehrlic added a reviewer for D8010: Fix false warning in qhash-namespace check for enum (classes): smartins.
Sep 27 2017, 2:12 PM
chehrlic created D8010: Fix false warning in qhash-namespace check for enum (classes).
Sep 27 2017, 2:08 PM