nicolasfella (Nicolas Fella)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 13 2017, 8:21 AM (49 w, 5 d)
Availability
Available

Recent Activity

Yesterday

nicolasfella updated the diff for D12559: [WIP] Add MprisReceiverPlugin (Android).
  • Add license header
Thu, Apr 26, 11:20 PM · KDE Connect
nicolasfella requested review of D12559: [WIP] Add MprisReceiverPlugin (Android).
Thu, Apr 26, 11:17 PM · KDE Connect
nicolasfella requested review of D12552: Use title, album and artist in UI.
Thu, Apr 26, 9:54 PM · KDE Connect
nicolasfella added a dependent revision for D12546: Support multiple players in MprisRemote: D12552: Use title, album and artist in UI.
Thu, Apr 26, 9:54 PM · KDE Connect
nicolasfella added a dependency for D12550: Request status when connecting: D12546: Support multiple players in MprisRemote.
Thu, Apr 26, 9:51 PM · KDE Connect
nicolasfella added a dependent revision for D12546: Support multiple players in MprisRemote: D12550: Request status when connecting.
Thu, Apr 26, 9:51 PM · KDE Connect
nicolasfella requested review of D12550: Request status when connecting.
Thu, Apr 26, 9:51 PM · KDE Connect
nicolasfella updated the diff for D12546: Support multiple players in MprisRemote.
  • Add new properties to interfaces
Thu, Apr 26, 9:42 PM · KDE Connect
nicolasfella updated the diff for D12546: Support multiple players in MprisRemote.
  • Fix build
  • fix UI not updating
Thu, Apr 26, 8:41 PM · KDE Connect
nicolasfella abandoned D12543: Support title, artist and album in MprisRemote.

Superseeded by D12546

Thu, Apr 26, 8:12 PM · KDE Connect
nicolasfella requested review of D12546: Support multiple players in MprisRemote.
Thu, Apr 26, 8:11 PM · KDE Connect
nicolasfella updated the diff for D12543: Support title, artist and album in MprisRemote.
  • Unrelated change
Thu, Apr 26, 3:44 PM · KDE Connect
nicolasfella requested review of D12543: Support title, artist and album in MprisRemote.
Thu, Apr 26, 3:40 PM · KDE Connect
nicolasfella added a comment to D12501: Bump gradle version.

I wonder; if we're updating the gradle plugin version, shouldn't we go to the latest stable version 3.1.2?

Thu, Apr 26, 12:54 AM · KDE Connect
nicolasfella requested review of D12528: Fix DBus signals in Mprisremote.
Thu, Apr 26, 12:51 AM · KDE Connect

Wed, Apr 25

nicolasfella committed R224:25cbf66e585a: Fix DBus connection in Kirigami app (authored by nicolasfella).
Fix DBus connection in Kirigami app
Wed, Apr 25, 12:48 PM
nicolasfella closed D12505: Fix DBus connection in Kirigami app.
Wed, Apr 25, 12:48 PM · KDE Connect
nicolasfella added a comment to D12506: Fix another DBus connection in Kirigami app.

What does not make sense? That it doesn't work, the fix or that it still does not work?

Wed, Apr 25, 11:14 AM · KDE Connect

Tue, Apr 24

nicolasfella requested review of D12506: Fix another DBus connection in Kirigami app.
Tue, Apr 24, 11:26 PM · KDE Connect
nicolasfella requested review of D12505: Fix DBus connection in Kirigami app.
Tue, Apr 24, 10:32 PM · KDE Connect
nicolasfella requested review of D12501: Bump gradle version.
Tue, Apr 24, 6:56 PM · KDE Connect
nicolasfella committed R225:8a2ea77030ba: Add marginEnd for RTL layouts (authored by nicolasfella).
Add marginEnd for RTL layouts
Tue, Apr 24, 5:59 PM
nicolasfella closed D12345: Add marginEnd for RTL layouts.
Tue, Apr 24, 5:59 PM · KDE Connect

Mon, Apr 23

nicolasfella added a comment to T8281: Make runcommand great again.
In T8281#139368, @apol wrote:
  • Sliders and stuff

Seems out of scope for this plugin to me

Mon, Apr 23, 10:46 PM · KDE Connect
nicolasfella added a comment to T8281: Make runcommand great again.
In T8281#139370, @apol wrote:

What do you think about introducing hooks that commands could be connected to? E.g. run foo on device connected/disconnected. Or connect commands to DBus signals.

I'd say we can have such separate plugin, along the line of the un/lock screen. It's not something that requires interaction with other devices anyway, right?

Mon, Apr 23, 10:43 PM · KDE Connect
nicolasfella updated the diff for D7993: System volume plugin Android.
  • Merge branch 'master' into arcpatch-D7993
  • Tweak mpris layout
Mon, Apr 23, 10:37 PM · KDE Connect
nicolasfella claimed T7994: Extract Qt Pulseaudio bindings into a Framework.
Mon, Apr 23, 10:09 PM · Plasma, KDE Connect, Frameworks
nicolasfella added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

Anything else that should be done before we can release?

Mon, Apr 23, 10:09 PM · Plasma, KDE Connect, Frameworks
nicolasfella updated the diff for D12481: Add dptr to models.
  • Remove unneeded modifier
Mon, Apr 23, 10:01 PM · Plasma
nicolasfella added inline comments to D12481: Add dptr to models.
Mon, Apr 23, 10:00 PM · Plasma
nicolasfella updated the diff for D12481: Add dptr to models.
  • Add license header
Mon, Apr 23, 9:45 PM · Plasma
nicolasfella updated the diff for D12481: Add dptr to models.
  • Coding style
Mon, Apr 23, 9:44 PM · Plasma
nicolasfella requested review of D12481: Add dptr to models.
Mon, Apr 23, 9:41 PM · Plasma
nicolasfella added inline comments to D9690: Add contacts-reading plugin (Android side).
Mon, Apr 23, 8:35 PM · KDE Connect
nicolasfella committed R224:755091b44763: Assign notification area category (authored by wsdfhjxc).
Assign notification area category
Mon, Apr 23, 8:33 PM
nicolasfella closed D11751: Assign notification area category.
Mon, Apr 23, 8:33 PM · KDE Connect
nicolasfella committed R224:9c1d6e43ad99: Add contacts-reading plugin (KDE side) (authored by sredman).
Add contacts-reading plugin (KDE side)
Mon, Apr 23, 8:31 PM
nicolasfella closed D9691: Add contacts-reading plugin (KDE side).
Mon, Apr 23, 8:30 PM · KDE Connect
nicolasfella closed T7044: Dark Mode & Settings as Resolved.
Mon, Apr 23, 7:55 PM · KDE Connect
nicolasfella updated the diff for D7993: System volume plugin Android.

Hide Fragment in Landscape mode
There is not enough vertical space for it

Mon, Apr 23, 7:47 PM · KDE Connect
nicolasfella committed R225:a1f1693d0bf0: Add a dark theme (authored by philipc).
Add a dark theme
Mon, Apr 23, 4:36 PM
nicolasfella closed D11694: Add a dark theme.
Mon, Apr 23, 4:36 PM · KDE Connect
nicolasfella updated the diff for D12232: Simplify failed plugin list creation.

Right diff

Mon, Apr 23, 11:42 AM · KDE Connect
nicolasfella updated the diff for D12232: Simplify failed plugin list creation.
  • Rename
Mon, Apr 23, 11:39 AM · KDE Connect
nicolasfella updated the diff for D12281: Enable (de)selecting all apps in notification filter.
  • Merge branch 'master' into selectall
  • Use raw SQL
Mon, Apr 23, 11:34 AM · KDE Connect
nicolasfella added a comment to D12345: Add marginEnd for RTL layouts.

Shouldn't this replace the layout_marginRight? Now we get margins on both sides?

Mon, Apr 23, 11:00 AM · KDE Connect
nicolasfella added a comment to T8281: Make runcommand great again.

What do you think about introducing hooks that commands could be connected to? E.g. run foo on device connected/disconnected. Or connect commands to DBus signals.

Mon, Apr 23, 10:56 AM · KDE Connect
nicolasfella accepted D11694: Add a dark theme.

Looks pretty good!

Mon, Apr 23, 10:52 AM · KDE Connect

Thu, Apr 19

nicolasfella added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.
  • Profile doesn't derive from PulseObject
  • casting d-ptr is weird obj->Stream::d->update() - but this is only in .cpp so I guess it's fine for now
  • move update() function to Private class everywhere
  • remove all libpulse includes in public headers
  • some classes still don't have d-ptr
  • rename pulseaudio.h include (probably to models.h)
  • constants from Context (Normal|Minimal|Maximal Volume) should probably go just into PulseAudioQt namespace
Thu, Apr 19, 5:50 PM · Plasma, KDE Connect, Frameworks
nicolasfella committed R994:c102a76c9538: Move volume constants into functions (authored by nicolasfella).
Move volume constants into functions
Thu, Apr 19, 5:35 PM
nicolasfella closed D12356: Move volume constants into functions.
Thu, Apr 19, 5:35 PM · Plasma
nicolasfella added a comment to D12356: Move volume constants into functions.

Weird, it did build for me so I didn't notice, sorry

Thu, Apr 19, 5:29 PM · Plasma
nicolasfella updated the diff for D12356: Move volume constants into functions.
  • Fix names
Thu, Apr 19, 5:28 PM · Plasma
nicolasfella updated the diff for D7992: Add systemvolume plugin.
  • Adapt to proposed changes in pulseaudio-qt
Thu, Apr 19, 3:23 PM · KDE Connect
nicolasfella requested review of D12356: Move volume constants into functions.
Thu, Apr 19, 3:21 PM · Plasma
nicolasfella added a comment to D11694: Add a dark theme.

@philipc Mind if I take over this revision and incorporate my changes?

Thu, Apr 19, 2:44 PM · KDE Connect
nicolasfella created T8555: [RFC] Import contacts from KDE Connect.
Thu, Apr 19, 12:04 PM · KDE Connect, Sink
nicolasfella requested review of D12345: Add marginEnd for RTL layouts.
Thu, Apr 19, 11:47 AM · KDE Connect
nicolasfella updated the diff for D12344: Add find remote device plugin.
  • Optimize imports
Thu, Apr 19, 11:41 AM · KDE Connect
nicolasfella requested review of D12344: Add find remote device plugin.
Thu, Apr 19, 11:40 AM · KDE Connect
nicolasfella requested review of D12334: Fix SharePlugin devices list.
Thu, Apr 19, 12:47 AM · KDE Connect
nicolasfella accepted D11684: Show the KCM with the run commands open when a setup packet is received.

I thought about ifdef'ing too, but by the time the next update will hit distros Frameworks 5.45 will be available too. The only reason would be for self-building people on distros that won't ship 5.45 soon

Thu, Apr 19, 12:40 AM · KDE Connect
nicolasfella updated the diff for D12281: Enable (de)selecting all apps in notification filter.
  • Code format
Thu, Apr 19, 12:15 AM · KDE Connect
nicolasfella added a comment to D12281: Enable (de)selecting all apps in notification filter.

Thu, Apr 19, 12:13 AM · KDE Connect
nicolasfella updated the diff for D12281: Enable (de)selecting all apps in notification filter.
  • Use header checkbox
Thu, Apr 19, 12:12 AM · KDE Connect

Wed, Apr 18

nicolasfella added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

Yes, it's used to initialize

static const qint64 NormalVolume = PA_VOLUME_NORM;
static const qint64 MinimalVolume = 0;
static const qint64 MaximalVolume = (PA_VOLUME_NORM / 100.0) * 150;

But I don't quite get what you mean though

Wed, Apr 18, 10:23 PM · Plasma, KDE Connect, Frameworks
nicolasfella updated the diff for D12332: Send Runcommand setup package from phone.
  • Add explanation dialog
Wed, Apr 18, 9:59 PM · KDE Connect
nicolasfella updated the diff for D12332: Send Runcommand setup package from phone.
  • Remove import
Wed, Apr 18, 9:50 PM · KDE Connect
nicolasfella requested review of D12332: Send Runcommand setup package from phone.
Wed, Apr 18, 9:49 PM · KDE Connect
nicolasfella requested changes to D11684: Show the KCM with the run commands open when a setup packet is received.

Please apply

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4d5d0229..6ad7b225 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -8,7 +8,7 @@ set(KDECONNECT_VERSION_PATCH 1)
 set(KDECONNECT_VERSION "${KDECONNECT_VERSION_MAJOR}.${KDECONNECT_VERSION_MINOR}.${KDECONNECT_VERSION_PATCH}")
Wed, Apr 18, 9:41 PM · KDE Connect
nicolasfella abandoned D7960: Add commands to RunCommandPlugin - Desktop part.
Wed, Apr 18, 9:18 PM · KDE Connect
nicolasfella added a comment to D11854: (WIP) Upgrade Telephony plugin to read SMS history (KDE side).

Test plan should include some steps to reproduce the desired behavior and see what is already implemented and what not

Wed, Apr 18, 7:39 PM · KDE Connect

Tue, Apr 17

nicolasfella committed R994:8f0dcaeb55db: Rename pulseaudio.h -> models.h (authored by nicolasfella).
Rename pulseaudio.h -> models.h
Tue, Apr 17, 10:11 PM
nicolasfella added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

The only libpulse include in public headers left is #include "pulse/volume.h" in context.h which is used to define Context (Normal|Minimal|Maximal Volume). How should we deal with those?

Tue, Apr 17, 10:05 PM · Plasma, KDE Connect, Frameworks
nicolasfella committed R994:7e32309ca93d: Fix build (authored by nicolasfella).
Fix build
Tue, Apr 17, 10:02 PM
nicolasfella committed R994:40b49747f086: Move update to ServerPrivate (authored by nicolasfella).
Move update to ServerPrivate
Tue, Apr 17, 10:02 PM
nicolasfella committed R994:cba9ae226b6f: Make Profile extend PulseObject (authored by nicolasfella).
Make Profile extend PulseObject
Tue, Apr 17, 10:02 PM
nicolasfella added a comment to D11854: (WIP) Upgrade Telephony plugin to read SMS history (KDE side).

Not sure if I'm overly nitpicky here 😆

Tue, Apr 17, 8:03 PM · KDE Connect
nicolasfella added a comment to D11854: (WIP) Upgrade Telephony plugin to read SMS history (KDE side).

Looks like your diff got lost

Tue, Apr 17, 7:53 PM · KDE Connect
nicolasfella reopened D11854: (WIP) Upgrade Telephony plugin to read SMS history (KDE side).
Tue, Apr 17, 7:52 PM · KDE Connect
nicolasfella added a comment to D12294: Send notification actions.

I think we should also send the action icon. That might be hard at the moment though, because we can only send one payload.

For what would you use it?

Tue, Apr 17, 7:07 PM · KDE Connect
nicolasfella committed R225:bc330018e14e: Rename list layout (authored by nicolasfella).
Rename list layout
Tue, Apr 17, 6:50 PM
nicolasfella closed D12289: Rename list layout.
Tue, Apr 17, 6:50 PM · KDE Connect
nicolasfella committed R225:9837c89f350e: Hide Available devices section if no devices are available (authored by nicolasfella).
Hide Available devices section if no devices are available
Tue, Apr 17, 6:48 PM
nicolasfella closed D12212: Hide Available devices section if no devices are available.
Tue, Apr 17, 6:48 PM · KDE Connect
nicolasfella requested review of D12294: Send notification actions.
Tue, Apr 17, 6:47 PM · KDE Connect
nicolasfella requested review of D12293: Add actions to notifications.
Tue, Apr 17, 6:36 PM · KDE Connect
nicolasfella updated the diff for D12212: Hide Available devices section if no devices are available.
  • Only hide section when there is at least one device connected
Tue, Apr 17, 5:23 PM · KDE Connect
nicolasfella committed R225:4d2357f016cd: Allow JSONObject in a NetworkPacket (authored by sredman).
Allow JSONObject in a NetworkPacket
Tue, Apr 17, 5:04 PM
nicolasfella closed D11870: Allow JSONObject in a NetworkPacket.
Tue, Apr 17, 5:04 PM · KDE Connect
nicolasfella updated the test plan for D12290: Don't draw list dividers.
Tue, Apr 17, 5:02 PM · KDE Connect
nicolasfella requested review of D12290: Don't draw list dividers.
Tue, Apr 17, 5:01 PM · KDE Connect
nicolasfella requested review of D12289: Rename list layout.
Tue, Apr 17, 4:56 PM · KDE Connect
nicolasfella added inline comments to D12281: Enable (de)selecting all apps in notification filter.
Tue, Apr 17, 4:49 PM · KDE Connect
nicolasfella updated the summary of D12285: [RFC] Change drawer header image.
Tue, Apr 17, 4:34 PM · KDE Connect
nicolasfella updated the test plan for D12285: [RFC] Change drawer header image.
Tue, Apr 17, 4:33 PM · KDE Connect
nicolasfella requested review of D12285: [RFC] Change drawer header image.
Tue, Apr 17, 4:30 PM · KDE Connect
nicolasfella added inline comments to D12232: Simplify failed plugin list creation.
Tue, Apr 17, 4:11 PM · KDE Connect
nicolasfella updated the diff for D12232: Simplify failed plugin list creation.
  • Revert lambda, nename PluginSmallEntryItem
Tue, Apr 17, 4:09 PM · KDE Connect
nicolasfella updated the summary of D12281: Enable (de)selecting all apps in notification filter.
Tue, Apr 17, 1:23 PM · KDE Connect