nicolasfella (Nicolas Fella)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 13 2017, 8:21 AM (101 w, 5 d)
Availability
Available

Recent Activity

Tue, Apr 23

nicolasfella updated the test plan for D20776: Only show tags action when baloo is enabled.
Tue, Apr 23, 9:51 PM · Baloo
nicolasfella requested review of D20776: Only show tags action when baloo is enabled.
Tue, Apr 23, 9:50 PM · Baloo

Mon, Apr 22

nicolasfella committed R224:8fd954b6d8a0: Use initializer for QJsonObject (authored by nicolasfella).
Use initializer for QJsonObject
Mon, Apr 22, 6:04 PM

Sat, Apr 20

nicolasfella committed R225:e882bebe4e58: Simplify switch (authored by nicolasfella).
Simplify switch
Sat, Apr 20, 8:38 PM
nicolasfella committed R225:d1565702cc3c: Simplify switch (authored by nicolasfella).
Simplify switch
Sat, Apr 20, 8:37 PM
nicolasfella committed R225:1b8763db6140: Format (authored by nicolasfella).
Format
Sat, Apr 20, 8:33 PM
nicolasfella committed R225:f4a4046b3b2e: Rename updateComputerList -> updateDeviceList (authored by nicolasfella).
Rename updateComputerList -> updateDeviceList
Sat, Apr 20, 1:03 AM

Fri, Apr 19

nicolasfella committed R225:882afbbc43a9: Make ListAdapter.Item.inflateView nonNull (authored by nicolasfella).
Make ListAdapter.Item.inflateView nonNull
Fri, Apr 19, 10:11 PM
nicolasfella committed R225:ba5a92507523: Require KitKat for SMS plugin (authored by nicolasfella).
Require KitKat for SMS plugin
Fri, Apr 19, 10:01 PM
nicolasfella committed R225:8e6035949695: Fix warning when overriding methods with nonnull annotations (authored by nicolasfella).
Fix warning when overriding methods with nonnull annotations
Fri, Apr 19, 10:01 PM
nicolasfella committed R225:d7c8f61c8035: Unify coding style (authored by nicolasfella).
Unify coding style
Fri, Apr 19, 9:47 PM
nicolasfella committed R225:7da6310926a4: Add nonnull annotation (authored by nicolasfella).
Add nonnull annotation
Fri, Apr 19, 9:47 PM
nicolasfella committed R225:ccd92aca031f: Remove redundant assignment (authored by nicolasfella).
Remove redundant assignment
Fri, Apr 19, 9:37 PM
nicolasfella committed R225:c5a84069283b: Organize imports (authored by nicolasfella).
Organize imports
Fri, Apr 19, 9:37 PM
nicolasfella committed R225:a4afc849116d: Use non-deprecated onAttach override (authored by nicolasfella).
Use non-deprecated onAttach override
Fri, Apr 19, 9:37 PM
nicolasfella committed R225:6d70d0dc507b: Remove unneeded drawable (authored by nicolasfella).
Remove unneeded drawable
Fri, Apr 19, 7:41 PM
nicolasfella committed R225:edc04f41a646: Remove unneeded file (authored by nicolasfella).
Remove unneeded file
Fri, Apr 19, 7:37 PM
nicolasfella committed R225:2a361942730b: Add tools:keep to plugin prefs to avoid false-positive lint (authored by nicolasfella).
Add tools:keep to plugin prefs to avoid false-positive lint
Fri, Apr 19, 7:37 PM
nicolasfella committed R225:cf526953f3fa: Remove unnecessary supression (authored by nicolasfella).
Remove unnecessary supression
Fri, Apr 19, 7:37 PM
nicolasfella committed R225:7f215b8cd528: Remove redundant namespace (authored by nicolasfella).
Remove redundant namespace
Fri, Apr 19, 7:37 PM

Thu, Apr 18

nicolasfella committed R225:21b97d335c9a: Add NonNull annotations (authored by nicolasfella).
Add NonNull annotations
Thu, Apr 18, 11:57 PM
nicolasfella committed R225:f735520aba71: Organize imports (authored by nicolasfella).
Organize imports
Thu, Apr 18, 11:13 PM
nicolasfella committed R225:0072911c5b6d: Use java style instead of C style for arrays (authored by nicolasfella).
Use java style instead of C style for arrays
Thu, Apr 18, 11:12 PM
nicolasfella committed R225:96a83ddcd35a: Inline fields (authored by nicolasfella).
Inline fields
Thu, Apr 18, 11:12 PM
nicolasfella committed R225:794f1d470683: Remove unneeded file (authored by nicolasfella).
Remove unneeded file
Thu, Apr 18, 11:12 PM
nicolasfella committed R225:e5c8160ee2b5: Revert "Bump gradle plugin version" (authored by nicolasfella).
Revert "Bump gradle plugin version"
Thu, Apr 18, 10:53 PM
nicolasfella added a reverting change for R225:6bcb77f65f49: Bump gradle plugin version: R225:e5c8160ee2b5: Revert "Bump gradle plugin version".
Thu, Apr 18, 10:53 PM
nicolasfella committed R225:25a09726063c: Fix javadoc regression (authored by nicolasfella).
Fix javadoc regression
Thu, Apr 18, 10:34 PM
nicolasfella committed R225:6bcb77f65f49: Bump gradle plugin version (authored by nicolasfella).
Bump gradle plugin version
Thu, Apr 18, 10:20 PM
nicolasfella committed R225:e8e01c9a5119: Remove redundant padding declaration (authored by nicolasfella).
Remove redundant padding declaration
Thu, Apr 18, 5:58 PM
nicolasfella committed R225:9a8ae36ef673: remove obsolete layout params (authored by nicolasfella).
remove obsolete layout params
Thu, Apr 18, 3:24 PM
nicolasfella committed R225:b1e8a66a8cc1: Remove unused file (authored by nicolasfella).
Remove unused file
Thu, Apr 18, 12:51 AM

Wed, Apr 17

nicolasfella committed R225:b375d796530c: Add version check (authored by nicolasfella).
Add version check
Wed, Apr 17, 11:43 PM

Mon, Apr 15

nicolasfella requested review of D20589: Add QML to source code types.
Mon, Apr 15, 10:44 PM · Baloo, Frameworks

Sun, Apr 14

nicolasfella committed R225:2ab76c6e9012: Deduplicate code for listeners in MprisActivity (authored by nicolasfella).
Deduplicate code for listeners in MprisActivity
Sun, Apr 14, 5:48 PM
nicolasfella committed R225:728bfeefea88: Rename (authored by nicolasfella).
Rename
Sun, Apr 14, 5:48 PM
nicolasfella committed R224:b50b79425023: Fix crash in daemon (authored by nicolasfella).
Fix crash in daemon
Sun, Apr 14, 5:25 PM
nicolasfella committed R224:d6de041324b7: Coding style (authored by nicolasfella).
Coding style
Sun, Apr 14, 5:23 PM
nicolasfella committed R224:331cedfa2f5c: Don't connect to action invoked signals multiple times (authored by nicolasfella).
Don't connect to action invoked signals multiple times
Sun, Apr 14, 5:20 PM
nicolasfella committed R224:08fd50931bdd: Don't show multiple windows when replying to a notification (authored by nicolasfella).
Don't show multiple windows when replying to a notification
Sun, Apr 14, 5:09 PM
nicolasfella committed R224:54df89809e7e: Don't show multiple windows when replying to a notification (authored by nicolasfella).
Don't show multiple windows when replying to a notification
Sun, Apr 14, 5:06 PM

Fri, Apr 12

nicolasfella abandoned D15930: Add more icons to actions.
Fri, Apr 12, 8:11 PM · Falkon

Thu, Apr 11

nicolasfella added a comment to D20433: Use mount point returned from DBus instead of using property value.

This approach is completely wrong.

The right approach is to wait for the information in a PropertiesChanged signal, and only when the mountpoint has been set in the property propage the signal.

This whole "our information is inconsistent, lets query for it explicitly" dance is a mess.

Thu, Apr 11, 9:36 AM · Frameworks

Wed, Apr 10

nicolasfella committed R245:27ef15fb1624: Use mount point returned from DBus instead of using property value (authored by nicolasfella).
Use mount point returned from DBus instead of using property value
Wed, Apr 10, 2:10 PM
nicolasfella reopened D20433: Use mount point returned from DBus instead of using property value.
Wed, Apr 10, 2:07 PM · Frameworks
nicolasfella committed R245:3ed42e887066: Use mount point returned from DBus instead of using property value (authored by nicolasfella).
Use mount point returned from DBus instead of using property value
Wed, Apr 10, 2:07 PM
nicolasfella closed D20433: Use mount point returned from DBus instead of using property value.
Wed, Apr 10, 2:07 PM · Frameworks
nicolasfella requested review of D20433: Use mount point returned from DBus instead of using property value.
Wed, Apr 10, 2:02 PM · Frameworks

Tue, Apr 9

nicolasfella added inline comments to D20265: Introduce libnotificationmanager.
Tue, Apr 9, 11:14 PM · Plasma

Sun, Apr 7

nicolasfella committed R225:3c97e1c067bd: Catch Exception when releasing storage URIs (authored by nicolasfella).
Catch Exception when releasing storage URIs
Sun, Apr 7, 5:34 PM
nicolasfella committed R824:0f6a158a5e92: Merge branch 'Applications/19.04' (authored by nicolasfella).
Merge branch 'Applications/19.04'
Sun, Apr 7, 5:16 PM
nicolasfella committed R824:96505aed6d59: [tagsaction] Don't crash on multiple files (authored by nicolasfella).
[tagsaction] Don't crash on multiple files
Sun, Apr 7, 5:13 PM
nicolasfella closed D20361: [tagsaction] Don't crash on multiple files.
Sun, Apr 7, 5:13 PM · Baloo
nicolasfella committed R225:50dc239d6431: fix telephony explanation (authored by brute4s99).
fix telephony explanation
Sun, Apr 7, 4:45 PM
nicolasfella added a reviewer for D20361: [tagsaction] Don't crash on multiple files: elvisangelaccio.
Sun, Apr 7, 4:33 PM · Baloo
nicolasfella requested review of D20361: [tagsaction] Don't crash on multiple files.
Sun, Apr 7, 4:32 PM · Baloo

Sat, Apr 6

nicolasfella committed R286:50d14ea058b5: Fix build with exiv2 0.28 (authored by nicolasfella).
Fix build with exiv2 0.28
Sat, Apr 6, 10:25 PM
nicolasfella closed D20324: Fix build with exiv2 0.28.
Sat, Apr 6, 10:25 PM · Baloo, Frameworks
nicolasfella added inline comments to D20324: Fix build with exiv2 0.28.
Sat, Apr 6, 10:22 PM · Baloo, Frameworks
nicolasfella updated the diff for D20324: Fix build with exiv2 0.28.
  • Use EXIV_TEST_VERSION
Sat, Apr 6, 10:21 PM · Baloo, Frameworks
nicolasfella updated the summary of D20324: Fix build with exiv2 0.28.
Sat, Apr 6, 9:43 PM · Baloo, Frameworks
nicolasfella committed R286:1de8b370725b: Use nullptr instead of NULL (authored by nicolasfella).
Use nullptr instead of NULL
Sat, Apr 6, 9:34 PM
nicolasfella closed D20310: Use nullptr instead of NULL.
Sat, Apr 6, 9:34 PM · Baloo, Frameworks
nicolasfella added reviewers for D20324: Fix build with exiv2 0.28: mgallien, astippich, bruns.
Sat, Apr 6, 9:28 PM · Baloo, Frameworks
nicolasfella requested review of D20324: Fix build with exiv2 0.28.
Sat, Apr 6, 9:26 PM · Baloo, Frameworks
nicolasfella added reviewers for D20310: Use nullptr instead of NULL: Frameworks, bruns, mgallien, astippich.
Sat, Apr 6, 4:34 PM · Baloo, Frameworks
nicolasfella requested review of D20310: Use nullptr instead of NULL.
Sat, Apr 6, 4:33 PM · Baloo, Frameworks
nicolasfella added a comment to T10766: KDE Connect Plugin Security.

The current behaviour is anything but a "major security flaw". I consider a security issue 'major' when it allows remote code execution without needing other security issues.

Sat, Apr 6, 1:08 PM · KDE Connect
nicolasfella added a reviewer for D20301: Ensure to add a trailing / at the end of fstab mounted devices.: broulik.
Sat, Apr 6, 12:34 PM · Frameworks

Fri, Apr 5

nicolasfella committed R115:277fddaf0c3a: Fixup cmake (authored by nicolasfella).
Fixup cmake
Fri, Apr 5, 2:21 PM
nicolasfella committed R115:b08c91b78570: rebase (authored by nicolasfella).
rebase
Fri, Apr 5, 2:17 PM
nicolasfella committed R115:de2effc2875c: Make use of PulseAudioQt (authored by nicolasfella).
Make use of PulseAudioQt
Fri, Apr 5, 2:17 PM
nicolasfella committed R115:f878cc7b0aab: Fix namespace, add files that were removed from PulseAudioQt (authored by nicolasfella).
Fix namespace, add files that were removed from PulseAudioQt
Fri, Apr 5, 2:17 PM
nicolasfella committed R115:5deecf60b1ac: Use the PulseAudioQt5 framework (authored by apol).
Use the PulseAudioQt5 framework
Fri, Apr 5, 2:17 PM

Thu, Apr 4

nicolasfella added a comment to D20253: [Context] Update StreamRestore before inserting it.

If obj already exists this would result in having it in m_streamRestores twice, wouldn't it?

Thu, Apr 4, 4:58 PM · Plasma
nicolasfella committed R994:6e2e40d28b6a: Export StreamRestore (authored by nicolasfella).
Export StreamRestore
Thu, Apr 4, 4:29 PM
nicolasfella committed R994:520c3881bd18: Export stream and sinkinput (authored by nicolasfella).
Export stream and sinkinput
Thu, Apr 4, 4:26 PM

Sun, Mar 31

nicolasfella committed R224:147fb6f35f96: Tweak Upload job finished notification (authored by nicolasfella).
Tweak Upload job finished notification
Sun, Mar 31, 7:20 PM
nicolasfella committed R225:5063f3d0f426: Use fancier lambda (authored by nicolasfella).
Use fancier lambda
Sun, Mar 31, 6:16 PM
nicolasfella committed R225:f1194e88c294: Use Log.e instead of printStackTrace (authored by nicolasfella).
Use Log.e instead of printStackTrace
Sun, Mar 31, 6:12 PM
nicolasfella committed R225:386a9f3f4099: remove unneeded throws (authored by nicolasfella).
remove unneeded throws
Sun, Mar 31, 6:12 PM
nicolasfella committed R115:e04e034c24b8: Port from GConf to GSettings (authored by nicolasfella).
Port from GConf to GSettings
Sun, Mar 31, 3:11 PM
nicolasfella closed D14147: Port from GConf to GSettings.
Sun, Mar 31, 3:11 PM · Plasma
nicolasfella updated the diff for D14147: Port from GConf to GSettings.
  • address comments
Sun, Mar 31, 2:20 PM · Plasma
nicolasfella committed R225:1867150ebbfc: Replace layout size values (authored by nicolasfella).
Replace layout size values
Sun, Mar 31, 12:08 AM

Sat, Mar 30

nicolasfella updated the diff for D14147: Port from GConf to GSettings.
  • Use and reqire GSettings by default and add CMake option to use GConf
  • Coding style
Sat, Mar 30, 10:24 PM · Plasma
nicolasfella committed R225:3022e3d83549: Mark ignored Exceptions as such (authored by nicolasfella).
Mark ignored Exceptions as such
Sat, Mar 30, 4:43 PM
nicolasfella committed R225:71609f144d9b: Use fancier lambdas (authored by nicolasfella).
Use fancier lambdas
Sat, Mar 30, 4:43 PM
nicolasfella committed R225:6e1fe3edbd78: Pass exception to log (authored by nicolasfella).
Pass exception to log
Sat, Mar 30, 4:43 PM
nicolasfella committed R225:102ce97a199f: Organize imports (authored by nicolasfella).
Organize imports
Sat, Mar 30, 4:43 PM
nicolasfella committed R225:3a36a4a675aa: Use ButterKnife in MprisActivity (authored by nicolasfella).
Use ButterKnife in MprisActivity
Sat, Mar 30, 4:42 PM
nicolasfella committed R225:655a9805e433: Fix logic in volumechange (authored by nicolasfella).
Fix logic in volumechange
Sat, Mar 30, 4:41 PM

Fri, Mar 29

nicolasfella committed R224:362b0ba2e260: Move ConversationsDbusInterface pointer handling to ConversationsDbusInterface (authored by sredman).
Move ConversationsDbusInterface pointer handling to ConversationsDbusInterface
Fri, Mar 29, 11:00 PM
nicolasfella committed R225:b46321395446: rebase and fix build (authored by nicolasfella).
rebase and fix build
Fri, Mar 29, 9:18 PM
nicolasfella committed R225:333606c824c6: Upload files using a CompositeUploadFileJob making the upload cancelable (authored by eduisters).
Upload files using a CompositeUploadFileJob making the upload cancelable
Fri, Mar 29, 9:18 PM

Tue, Mar 26

nicolasfella committed R225:2a61f431d6a3: Use more runwithplugin (authored by nicolasfella).
Use more runwithplugin
Tue, Mar 26, 11:23 PM
nicolasfella committed R225:8b5734db43a7: Use runwithplugin (authored by nicolasfella).
Use runwithplugin
Tue, Mar 26, 11:11 PM

Mar 26 2019

nicolasfella committed R224:d0cb028a8410: add icons for pair, accept, reject (authored by rpatwal).
add icons for pair, accept, reject
Mar 26 2019, 12:33 PM
nicolasfella closed T10729: Crash in lock inhibitor on Android as Resolved.
Mar 26 2019, 11:57 AM · KDE Itinerary

Mar 25 2019

nicolasfella claimed T10729: Crash in lock inhibitor on Android.

https://invent.kde.org/kde/itinerary/merge_requests/6/diffs

Mar 25 2019, 11:06 PM · KDE Itinerary