- User Since
- May 13 2017, 8:21 AM (30 w, 3 d)
Could you supply some more information so I can look into it?
Works well so far :) Some small things I noticed: Toggling the option doesn't activate/deactivate the notification immediately. When my laptop screen turns off plasma pauses the media player, but the notification is still in play mode. Both are not critical, but a fix would be nice if it's not too complex.
Sun, Dec 10
Thanks for working on this! I would like to have an option to disable the notification in the plugin settings because I can imagine some people may not like to have a persistent notification.
Tue, Dec 5
Yes it does. You don't know it but
m_reply = Daemon::instance()->networkAccessManager()->put(req, m_origin.data());
in filetransferjob.cpp is using kio.
I really didn't know that
I'm sorry, but this does not resolve https://bugs.kde.org/show_bug.cgi?id=386246 for me. KDE Connect's FileTransferJob does not even use KIO's TransferJob. It just extends KJob, so it could be a (similar) bug there.
Sun, Dec 3
Thu, Nov 23
The only commit I see that is not in the master is the one with the Appcompatactivity. Since it does not affect your patch there is no rebasing necessary. I don't know why it's not merged, I would guess Albert has no Oreo phone to test it.
FYI there is already some similar work here: https://cgit.kde.org/kdeconnect-android.git/log/?h=update/android-o
Sat, Nov 18
I would like to propose another approach. Like discussed in D7700 D8243 and D7446 I would vote for splitting the functionality of the placespanel into smaller panels (~one for each group in the current places panel). By default this could look like the status quo, but the user would be able to reorder them in her gusto. For example, hve the "normal" places entries on the left and the baloo stuff or a tags panel on the right. These panels would inherit from a common abstract panel class but each would have its own model which would be much more maintainable (current PlacesItemModel.cpp has ~1200 LOC). The small panels would also not need group support (the panel IS the group) so the code would be less complex as well
What's the status of this?
Nov 6 2017
Guess this can be closed?
implement suggestion from @thomasp
Nov 5 2017
Oct 31 2017
emit dataChanged instead of readding the notification.
Oct 25 2017
Oct 23 2017
IMHO we can merge it for now (maybe I will have to rebase) I like the idea of separate panels and I'm working on something similar. I try to extract generic pieces from the PlacesPanel to an abstract ListPanel that can be extended to create all kinds of panels we want. I'm not done yet but I hope I can show you something soon
Oct 17 2017
Oct 15 2017
Don't crash when the icon cannot be transferred.
Ooops, wrong diff
Adapt to change in desktop part. Also show the plugin even if the commandlist is empty to make users aware that this functionality exists.
Ask user for confirmation. Updated android part as well
Oct 13 2017
This change was overridden by D7312. I discovered that when observing a bug I fixed months ago :D
Oct 9 2017
Since it's only an optional Permission IMHO it would be okay to ask for it and provide an explanation. The user can still decline it if unwanted.
Oct 5 2017
Oct 4 2017
Sep 27 2017
I see your point. Right now, the UI to add a command is quite hidden. Most users probably don't even know that there is the Commands Plugin, and without adding commands its pretty useless. Maybe we could ask for the user to confirm the sent command in the desktop. What do you think about this?
Sep 26 2017
Sep 24 2017
Icons are from https://material.io/icons/
Only show add option if adding is supported
Let the other device know that it can add commands. Prevents newer Android Clients to show functionality that is not yet there on the desktop
Sep 23 2017
The diff contains some files that shouldn't be there, just ignore them
I would be fine with moving it to a separate panel. If we do that, the PlacesPanel, the TagsPanel and a (hypothetical, but I saw people voting for it) BookmarksPanel would share a lot of code. Basically it would be the same View and Controller with different Models. I would suggest to get rid of that redundancy by sharing the View and Controller.
Sep 22 2017
pactl only has a subset of the functionality of pacmd. pacmd also has an interactive cli, but we don't need that and pactl has all the features we need for both this and for setting the system volume. On my Arch/Manjaro system both do the job, but since pacmd fails on your machine we should go with pactl.
Sep 21 2017
@albertvaka Which system are you running on?
This is a workaround for issues which will be more visible when https://phabricator.kde.org/D7700 gets merged
Sep 17 2017
Any further objections/issues/comments?
Sep 16 2017
Sep 13 2017
Use url() instead of urlbase+name
Sep 12 2017
Use KCoreDirLister (thanks @emmanuelp). It simplified the whole patch and fixed a problem with newly appearing bookmarks (e.g. when plugging in a USB-Stick). Right now the first 8 Tags are shown, but showing the most (recent) used would sure be better. Any ideas on how to implement this?
Sep 11 2017
Only show "All tags" if there are any tags
Isn't there a way to transfer his copyright to KDE e.V.?
As I understand he wants to contribute without showing his full name. Is there a way to do so? Maybe somebody else can commit it under his/her name?
Show max 8 (because we're better than macOS ;) ) Tags
I was thinking about colored tags as well. Users can already change the icons of the tags in the sidebar. Maybe we could provide some "colored tag" icons. Making the tagged files colored would be worth trying, but is out of scope for this patch
Fixed indentation and warnings
Sep 10 2017
Not sure about Dolphin in general, but the Places Panel definitely takes longer to load
Sep 8 2017
Sep 7 2017
Sep 5 2017
Sep 1 2017
Aug 31 2017
Aug 22 2017
Aug 21 2017
Aug 19 2017
I don't know much about telepathy. Can we figure out whether it is used at runtime and what should we do different if it is used?