nicolasfella (Nicolas Fella)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 13 2017, 8:21 AM (133 w, 5 d)
Availability
Available

Recent Activity

Yesterday

nicolasfella requested review of D25756: Port from QStringList::ConstIterator to range-based for.
Thu, Dec 5, 12:10 AM · Frameworks

Wed, Dec 4

nicolasfella requested review of D25755: Replace iterators with range-based for.
Wed, Dec 4, 11:34 PM · Frameworks
nicolasfella requested review of D25754: Refactor KHistoryComboBox::insertItems.
Wed, Dec 4, 11:21 PM · Frameworks
nicolasfella updated the diff for D25722: Replace upload service with purpose plugin.
  • Make Purpose optional
Wed, Dec 4, 3:48 PM
nicolasfella committed R150:423c75cc12c3: Port to json metadata (authored by nicolasfella).
Port to json metadata
Wed, Dec 4, 12:11 AM
nicolasfella closed D25630: Port to json metadata.
Wed, Dec 4, 12:11 AM

Tue, Dec 3

nicolasfella committed R152:f25a4e3e989a: Replace KIconloader with QIcon::fromTheme (authored by nicolasfella).
Replace KIconloader with QIcon::fromTheme
Tue, Dec 3, 11:45 PM
nicolasfella closed D25723: Replace KIconloader with QIcon::fromTheme.
Tue, Dec 3, 11:45 PM
nicolasfella committed R152:5b5945d61850: Remove old-style service menu (authored by nicolasfella).
Remove old-style service menu
Tue, Dec 3, 11:45 PM
nicolasfella closed D25724: Remove old-style service menu.
Tue, Dec 3, 11:45 PM
nicolasfella requested review of D25725: Get icon size from QStyle.
Tue, Dec 3, 10:26 PM · Plasma
nicolasfella added a reviewer for D25724: Remove old-style service menu: KDE Telepathy.
Tue, Dec 3, 10:07 PM
nicolasfella requested review of D25724: Remove old-style service menu.
Tue, Dec 3, 10:07 PM
nicolasfella added reviewers for D25723: Replace KIconloader with QIcon::fromTheme: Frameworks, KDE Telepathy.
Tue, Dec 3, 10:01 PM
nicolasfella requested review of D25723: Replace KIconloader with QIcon::fromTheme.
Tue, Dec 3, 10:01 PM
nicolasfella added a comment to T12256: Phase out KonqPopupMenu/Plugin service type.

That would mean that desktopfile-only services like in https://cgit.kde.org/plasma-desktop.git/tree/kcms/kfontinst/apps/installfont.desktop would no longer be possible, right? One would need to write a C++ plugin.
That would be at least a bit sad

Tue, Dec 3, 9:40 PM · KF6
nicolasfella added reviewers for D25722: Replace upload service with purpose plugin: volt4ire, scarpino.
Tue, Dec 3, 9:28 PM
nicolasfella added a task to D25722: Replace upload service with purpose plugin: T12256: Phase out KonqPopupMenu/Plugin service type.
Tue, Dec 3, 9:26 PM
nicolasfella added a revision to T12256: Phase out KonqPopupMenu/Plugin service type: D25722: Replace upload service with purpose plugin.
Tue, Dec 3, 9:26 PM · KF6
nicolasfella updated the summary of D25722: Replace upload service with purpose plugin.
Tue, Dec 3, 9:25 PM
nicolasfella added a reviewer for D25722: Replace upload service with purpose plugin: Choqok.
Tue, Dec 3, 9:24 PM
nicolasfella requested review of D25722: Replace upload service with purpose plugin.
Tue, Dec 3, 9:23 PM
nicolasfella added a comment to D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader.

Works fine for my rather simple KDE Connect use case

Tue, Dec 3, 8:36 PM · Frameworks
nicolasfella moved T12310: Kill KUrlPixmapProvider from Backlog to In Progress on the KF6 board.
Tue, Dec 3, 8:24 PM · KF6
nicolasfella added a comment to D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme.

Well, there are certainly more ugly things out there :)

Tue, Dec 3, 8:22 PM · Frameworks
nicolasfella added a comment to T12285: KTextWidgets usage in KIO.

This would allow us to get rid of the KTextWidgets dependency immediately, so there would be a gain in doing it now

Tue, Dec 3, 8:20 PM · KF6
nicolasfella added a comment to D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme.

It's a bit ugly that fallback is a QIcon, not a QString :/
I will send a patch to Qt

Tue, Dec 3, 7:56 PM · Frameworks
nicolasfella updated the diff for D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme.
  • Fall back to application-octet-stream
Tue, Dec 3, 7:54 PM · Frameworks
nicolasfella committed R260:a6538c45ba7f: Port away from deprecated DesktopIcon (authored by nicolasfella).
Port away from deprecated DesktopIcon
Tue, Dec 3, 7:24 PM
nicolasfella closed D25693: Port away from deprecated DesktopIcon.
Tue, Dec 3, 7:24 PM · Gwenview
nicolasfella updated the diff for D25693: Port away from deprecated DesktopIcon.
  • Use single arg fucntion
Tue, Dec 3, 7:24 PM · Gwenview
nicolasfella committed R307:1e339edef781: Allow triggering sort from QML (authored by nicolasfella).
Allow triggering sort from QML
Tue, Dec 3, 6:20 PM
nicolasfella closed D24046: Allow triggering sort from QML.
Tue, Dec 3, 6:20 PM · Frameworks
nicolasfella added a comment to D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them.

Unrelated to the issue: For GLIB2 we have a ECM find module that makes things a bit nicer. See https://invent.kde.org/snippets/601
For GOBJECT we don't have one, but since we afaik use it on at least one other place it might be worth making one

Tue, Dec 3, 5:47 PM · Plasma
nicolasfella updated the diff for D24046: Allow triggering sort from QML.

Override and forward

Tue, Dec 3, 4:16 PM · Frameworks
nicolasfella requested review of D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme.
Tue, Dec 3, 12:45 AM · Frameworks
nicolasfella requested review of D25706: Port away from deprecated KIO::suggestName.
Tue, Dec 3, 12:27 AM · Ark
nicolasfella requested review of D25705: Deprecate KIO::pixmapForUrl.
Tue, Dec 3, 12:09 AM · Frameworks

Mon, Dec 2

nicolasfella closed D25704: [kfilewidget] Load icons by name.
Mon, Dec 2, 11:56 PM · Frameworks
nicolasfella committed R241:b21a6c1a5b93: [kfilewidget] Load icons by name (authored by nicolasfella).
[kfilewidget] Load icons by name
Mon, Dec 2, 11:56 PM
nicolasfella updated the diff for D25704: [kfilewidget] Load icons by name.
  • [kfilewidget] Load icons by name
  • Remove include
Mon, Dec 2, 11:48 PM · Frameworks
nicolasfella requested review of D25704: [kfilewidget] Load icons by name.
Mon, Dec 2, 11:43 PM · Frameworks
nicolasfella requested review of D25702: Deprecate KUrlPixmapProvider.
Mon, Dec 2, 11:23 PM · Frameworks
nicolasfella updated the summary of D25700: [KHistoryComboBox] Add method to set an icon provider.
Mon, Dec 2, 11:12 PM · Frameworks
nicolasfella updated the diff for D25700: [KHistoryComboBox] Add method to set an icon provider.
  • Deprecation, fix, and docs
Mon, Dec 2, 11:12 PM · Frameworks
nicolasfella added a revision to T12310: Kill KUrlPixmapProvider: D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox.
Mon, Dec 2, 11:01 PM · KF6
nicolasfella added a task to D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox: T12310: Kill KUrlPixmapProvider.
Mon, Dec 2, 11:01 PM · Plasma
nicolasfella requested review of D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox.
Mon, Dec 2, 11:00 PM · Plasma
nicolasfella added a task to D25700: [KHistoryComboBox] Add method to set an icon provider: T12310: Kill KUrlPixmapProvider.
Mon, Dec 2, 10:52 PM · Frameworks
nicolasfella added a revision to T12310: Kill KUrlPixmapProvider: D25700: [KHistoryComboBox] Add method to set an icon provider.
Mon, Dec 2, 10:52 PM · KF6
nicolasfella requested review of D25700: [KHistoryComboBox] Add method to set an icon provider.
Mon, Dec 2, 10:52 PM · Frameworks
nicolasfella added a comment to T12310: Kill KUrlPixmapProvider.

For the KHistoryComboBox case I can imagine to replace the setPixmapProvider with a method that taked a function/lambda that takes a QString and returns a QIcon. No need to define a class for that.

Mon, Dec 2, 10:09 PM · KF6
nicolasfella added a comment to T12310: Kill KUrlPixmapProvider.

Besides that KPixmapProvider is used only in konqueror for KonqPixmapProvider, so it might be worth looking into killing that as well

Mon, Dec 2, 10:06 PM · KF6
nicolasfella renamed T12310: Kill KUrlPixmapProvider from Kill-ish KUrlPixmapProvider to Kill KUrlPixmapProvider.
Mon, Dec 2, 10:02 PM · KF6
nicolasfella created T12310: Kill KUrlPixmapProvider.
Mon, Dec 2, 10:00 PM · KF6
nicolasfella added a revision to T11637: Investigate if KIconThemes is needed as a framework: D25697: Port away from KIconLoader::SizeSmallMedium.
Mon, Dec 2, 9:32 PM · KF6
nicolasfella added a task to D25697: Port away from KIconLoader::SizeSmallMedium: T11637: Investigate if KIconThemes is needed as a framework.
Mon, Dec 2, 9:32 PM · Frameworks
nicolasfella requested review of D25697: Port away from KIconLoader::SizeSmallMedium.
Mon, Dec 2, 9:31 PM · Frameworks
nicolasfella requested review of D25696: Remove dead code.
Mon, Dec 2, 9:18 PM · Frameworks
nicolasfella added a comment to T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.

DesktopIcon is now only used in kexi

Mon, Dec 2, 9:08 PM · KF6
nicolasfella added a task to D25694: Port away from DesktopIcon: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.
Mon, Dec 2, 9:04 PM · Plasma
nicolasfella added a revision to T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API: D25694: Port away from DesktopIcon.
Mon, Dec 2, 9:04 PM · KF6
nicolasfella added a reviewer for D25694: Port away from DesktopIcon: Plasma.
Mon, Dec 2, 9:04 PM · Plasma
nicolasfella requested review of D25694: Port away from DesktopIcon.
Mon, Dec 2, 9:03 PM · Plasma
nicolasfella added a task to D25693: Port away from deprecated DesktopIcon: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.
Mon, Dec 2, 8:33 PM · Gwenview
nicolasfella added a revision to T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API: D25693: Port away from deprecated DesktopIcon.
Mon, Dec 2, 8:33 PM · KF6
nicolasfella requested review of D25693: Port away from deprecated DesktopIcon.
Mon, Dec 2, 8:32 PM · Gwenview
nicolasfella committed R994:f9511e23cfaf: clang-format all the things (authored by nicolasfella).
clang-format all the things
Mon, Dec 2, 2:17 PM
nicolasfella committed R994:1840ebb6b109: Fix build (authored by nicolasfella).
Fix build
Mon, Dec 2, 2:17 PM
nicolasfella added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

10 days have passed. What's the status of this?

Mon, Dec 2, 1:59 PM
nicolasfella committed R499:a189260b10ad: Remove KTextWidgets dependency from KXMLGui (authored by nicolasfella).
Remove KTextWidgets dependency from KXMLGui
Mon, Dec 2, 12:21 PM
nicolasfella added a comment to T12195: Remove KTextWidgets dependency from KXMLGui.

Done

Mon, Dec 2, 12:17 PM · KF6
nicolasfella committed R167:f60ab0c3a38d: Replace Q_DECL_OVERRIDE with override (authored by nicolasfella).
Replace Q_DECL_OVERRIDE with override
Mon, Dec 2, 11:42 AM
nicolasfella closed D25669: Replace Q_DECL_OVERRIDE with override.
Mon, Dec 2, 11:42 AM · Krusader
nicolasfella closed D25675: Remove ContextBarButton.
Mon, Dec 2, 11:41 AM · Gwenview
nicolasfella committed R260:fc95bb5be82d: Remove ContextBarButton (authored by nicolasfella).
Remove ContextBarButton
Mon, Dec 2, 11:41 AM
nicolasfella added a parent task for T12306: Port ksystemlog away from deprecated KIconLoader API: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.
Mon, Dec 2, 1:22 AM · KF6
nicolasfella added a subtask for T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API: T12306: Port ksystemlog away from deprecated KIconLoader API.
Mon, Dec 2, 1:22 AM · KF6
nicolasfella created T12306: Port ksystemlog away from deprecated KIconLoader API.
Mon, Dec 2, 1:21 AM · KF6
nicolasfella accepted D25668: Port away from deprecated KIconLoader::SmallIcon.
Mon, Dec 2, 12:57 AM · Plasma
nicolasfella requested review of D25675: Remove ContextBarButton.
Mon, Dec 2, 12:54 AM · Gwenview
nicolasfella committed R473:89c3e453cab1: Port away from KIconLoader's SmallIcon (authored by nicolasfella).
Port away from KIconLoader's SmallIcon
Mon, Dec 2, 12:43 AM
nicolasfella closed D25674: Port away from KIconLoader's SmallIcon.
Mon, Dec 2, 12:43 AM
nicolasfella added reviewers for D25674: Port away from KIconLoader's SmallIcon: trufanov, stikonas, valeriymalov.
Mon, Dec 2, 12:42 AM
nicolasfella requested review of D25674: Port away from KIconLoader's SmallIcon.
Mon, Dec 2, 12:41 AM
nicolasfella added a comment to T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.

Another usage of KDE::icon that is not trivially replacable by QIcon::fromTheme:
https://cgit.kde.org/systemsettings.git/tree/sidebar/ToolTips/tooltipmanager.cpp#n224

Mon, Dec 2, 12:13 AM · KF6
nicolasfella moved T12287: KService: deprecate KServiceTypeProfile, unused from Backlog to In Progress on the KF6 board.
Mon, Dec 2, 12:01 AM · KF6

Sun, Dec 1

nicolasfella requested review of D25673: Deprecate KServiceTypeProfile.
Sun, Dec 1, 11:56 PM · Frameworks
nicolasfella requested review of D25672: Port to std::sort.
Sun, Dec 1, 11:40 PM · Plasma
nicolasfella accepted D24744: Remove unneeded options in GTK KCM.
Sun, Dec 1, 11:24 PM · VDG, Plasma
nicolasfella added a reviewer for D25669: Replace Q_DECL_OVERRIDE with override: Krusader.
Sun, Dec 1, 10:22 PM · Krusader
nicolasfella requested review of D25669: Replace Q_DECL_OVERRIDE with override.
Sun, Dec 1, 10:22 PM · Krusader
nicolasfella updated the diff for D25630: Port to json metadata.
  • Use kcoreaddons_desktop_to_json
Sun, Dec 1, 10:07 PM
nicolasfella requested review of D25665: Port away from deprecated KBookmarksmenu API.
Sun, Dec 1, 9:40 PM · Dolphin
nicolasfella added a comment to T12285: KTextWidgets usage in KIO.

Would such a move be possible in KF5? Technically it wouldn't be an API break, but it would break something for people that don't have kio-extras installed

Sun, Dec 1, 9:33 PM · KF6
nicolasfella added a comment to T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.

As part of this task, KDE::icon should actually be deprecated in favor of QIcon::fromTheme(). Seems it's not yet deprecated.

Sun, Dec 1, 9:06 PM · KF6
nicolasfella moved T12056: KBookmarks from Backlog to In Progress on the KF6 board.
Sun, Dec 1, 8:59 PM · KF6
nicolasfella moved T12219: Try to get QKeyChain as a framework from Backlog to In Progress on the KF6 board.
Sun, Dec 1, 8:59 PM · KF6
nicolasfella updated the diff for D25660: Decouple KBookmarksMenu from KActionCollection.
Rebase
Sun, Dec 1, 8:57 PM · Frameworks
nicolasfella updated the test plan for D25660: Decouple KBookmarksMenu from KActionCollection.
Sun, Dec 1, 8:48 PM · Frameworks