nicolasfella (Nicolas Fella)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
May 13 2017, 8:21 AM (41 w, 13 h)
Availability
Available

Recent Activity

Today

nicolasfella updated subscribers of D10703: Build kdeconnect on sailfish and port some simple plugins.

Biggest issue seems to be the notifications. It would be great to have a unified approach for that.

Sat, Feb 24, 9:06 PM · KDE Connect
nicolasfella added inline comments to D10703: Build kdeconnect on sailfish and port some simple plugins.
Sat, Feb 24, 8:57 PM · KDE Connect
nicolasfella updated subscribers of D10807: fileindexerconfig: Exclude Vaults by default.

I honestly don't know.

Sat, Feb 24, 8:36 PM · Plasma, Frameworks, Baloo
nicolasfella added a comment to D10807: fileindexerconfig: Exclude Vaults by default.

You have to hit next a couple of times

Sat, Feb 24, 8:31 PM · Plasma, Frameworks, Baloo
nicolasfella added a comment to D10807: fileindexerconfig: Exclude Vaults by default.

Sat, Feb 24, 8:29 PM · Plasma, Frameworks, Baloo
nicolasfella added a comment to D10807: fileindexerconfig: Exclude Vaults by default.

When creating a Vault you can choose any location for it. ~/Vaults is just the default

Sat, Feb 24, 8:29 PM · Plasma, Frameworks, Baloo
nicolasfella added a comment to D10807: fileindexerconfig: Exclude Vaults by default.

Vault can also be mounted in other directories than ~/Vaults

Sat, Feb 24, 8:24 PM · Plasma, Frameworks, Baloo
nicolasfella added a comment to D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status.

I can confirm that this fixes the glitch

Sat, Feb 24, 5:50 PM · Plasma
nicolasfella added a comment to D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status.

The glitch:

Sat, Feb 24, 5:40 PM · Plasma
nicolasfella added a comment to D10796: Change mpris play/pause button color instead of removing it.

Here's how it would look in all-orange

Sat, Feb 24, 5:30 PM
nicolasfella added a comment to D10796: Change mpris play/pause button color instead of removing it.

Awesome!

Sat, Feb 24, 5:17 PM
nicolasfella added a comment to D10796: Change mpris play/pause button color instead of removing it.

There is still a glitch. Did you test with Plasma Browser Integration? If that's the only player where it occurs it would make more sense to patch it there

Sat, Feb 24, 4:55 PM
nicolasfella requested changes to D10798: Add album art to media notification and lock screen.

Crashes on my Oreo phone as soon as it tries to display the notification

Sat, Feb 24, 4:33 PM
nicolasfella added a comment to D10796: Change mpris play/pause button color instead of removing it.

Wouldn't this lead to another visual glitch like D9564?

Sat, Feb 24, 4:24 PM
nicolasfella added a comment to D10796: Change mpris play/pause button color instead of removing it.

Haha, funny, I was thinking about coloring the buttons right now, too. But I was thinking about orange instead of blue

Sat, Feb 24, 4:17 PM
nicolasfella accepted D9266: Add MPRIS media control notification.

I can't reproduce it either right now. Let's merge it for now and see if we can reproduce it in daily usage

Sat, Feb 24, 3:39 PM · KDE Connect
nicolasfella added a comment to D9564: Add album cover art support..

That sounds reasonable

Sat, Feb 24, 3:09 PM
nicolasfella committed R225:e9a35d3bb2fd: Allow to blacklist numbers in the telephony plugin (authored by nicolasfella).
Allow to blacklist numbers in the telephony plugin
Sat, Feb 24, 2:54 PM
nicolasfella closed D10520: Allow to blacklist numbers in the telephony plugin.
Sat, Feb 24, 2:54 PM · KDE Connect

Yesterday

nicolasfella requested review of D10779: Split MousepadPlugin into X11 and Wayland plugin.
Fri, Feb 23, 7:47 PM · KDE Connect

Thu, Feb 22

nicolasfella added a comment to T7994: Extract Qt Pulseaudio bindings into a Framework.

I've forked plasma-pa into https://cgit.kde.org/scratch/nicolasfella/pulseaudio-qt.git/

Thu, Feb 22, 3:50 PM · Plasma, KDE Connect, Frameworks
nicolasfella added a project to D9266: Add MPRIS media control notification: KDE Connect.
Thu, Feb 22, 1:32 PM · KDE Connect
nicolasfella added a comment to D9266: Add MPRIS media control notification.

Another issue:

Thu, Feb 22, 1:31 PM · KDE Connect
nicolasfella requested changes to D9266: Add MPRIS media control notification.

Works pretty good, but I found one issue. To reproduce:

Thu, Feb 22, 12:44 PM · KDE Connect
nicolasfella added a comment to D9564: Add album cover art support..

It also occurs when the player is played/paused directly

Thu, Feb 22, 12:11 PM
nicolasfella added a comment to D9564: Add album cover art support..

When using a player that doesn't provide artwork (I tested it with plasma browser integration) the UI glitches when hitting the play/pause button.

Thu, Feb 22, 11:25 AM
nicolasfella requested review of D10737: Remove dead code in the ReceiveNotificationsPlugin.
Thu, Feb 22, 10:54 AM · KDE Connect
nicolasfella updated the diff for D7959: Make it possible to add commands for the RunCommandsPlugin from Android.
  • Fix regression
Thu, Feb 22, 12:54 AM · KDE Connect
nicolasfella updated the diff for D7959: Make it possible to add commands for the RunCommandsPlugin from Android.

Add explanation text

Thu, Feb 22, 12:49 AM · KDE Connect
nicolasfella requested review of D7960: Add commands to RunCommandPlugin - Desktop part.

Issue seems to have gone

Thu, Feb 22, 12:17 AM · KDE Connect
nicolasfella updated the diff for D10520: Allow to blacklist numbers in the telephony plugin.

Use PhoneNumberUtils.compare.
Untested because I can't send SMS atm.

Thu, Feb 22, 12:03 AM · KDE Connect

Wed, Feb 21

nicolasfella committed R225:4d5d7449200a: Allow choosing a ringtone for FindMyPhone (authored by nicolasfella).
Allow choosing a ringtone for FindMyPhone
Wed, Feb 21, 11:50 PM
nicolasfella closed D10332: Allow choosing a ringtone for FindMyPhone.
Wed, Feb 21, 11:50 PM · KDE Connect
nicolasfella committed R225:82db080a5145: Apply some coding style to TelephonyPlugin (authored by nicolasfella).
Apply some coding style to TelephonyPlugin
Wed, Feb 21, 11:49 PM
nicolasfella closed D10519: Apply some coding style to TelephonyPlugin.
Wed, Feb 21, 11:49 PM · KDE Connect
nicolasfella added a project to D10703: Build kdeconnect on sailfish and port some simple plugins: KDE Connect.
Wed, Feb 21, 12:22 AM · KDE Connect
nicolasfella added a comment to D10703: Build kdeconnect on sailfish and port some simple plugins.

Thanks for working on this!

Wed, Feb 21, 12:22 AM · KDE Connect

Tue, Feb 20

nicolasfella added a comment to D10698: Adds a new RenameDialog to Dolphin with more options for batch renaming.

Remember that it should work with all languages, so stuff like #now or #today either need to be translated or get a description that will be translated

Tue, Feb 20, 9:14 PM
nicolasfella added inline comments to D9559: Remove unused code in NotificationDbusInterface.
Tue, Feb 20, 7:55 PM
nicolasfella added a comment to D10520: Allow to blacklist numbers in the telephony plugin.

Only works when specifying an international number, not a national number.

Maybe use something like this: https://developer.android.com/reference/android/telephony/PhoneNumberUtils.html#compare(java.lang.String,%20java.lang.String)?

Tue, Feb 20, 6:22 PM · KDE Connect
nicolasfella added a comment to D10688: Show high-resolution and vector logos properly in HighDPI mode.

I don't know the before state, but just by looking at the screenshots from my phone I like the first and the third better

First and third are clearly more pixelated.

Tue, Feb 20, 5:48 PM
nicolasfella added a comment to D10688: Show high-resolution and vector logos properly in HighDPI mode.

I don't know the before state, but just by looking at the screenshots from my phone I like the first and the third better

Tue, Feb 20, 5:45 PM
nicolasfella added a comment to D10688: Show high-resolution and vector logos properly in HighDPI mode.

Are you saying those icons should be that small?

Tue, Feb 20, 5:42 PM
nicolasfella added a comment to D10688: Show high-resolution and vector logos properly in HighDPI mode.

I think you labeled the images the wrong way

Tue, Feb 20, 5:37 PM

Sat, Feb 17

nicolasfella triaged T7994: Extract Qt Pulseaudio bindings into a Framework as Normal priority.
Sat, Feb 17, 12:42 PM · Plasma, KDE Connect, Frameworks
nicolasfella added a comment to D9564: Add album cover art support..

I've tested it quite some time. Works really well, but I noticed some visual glitches. I will give details in a couple of days.

Sat, Feb 17, 12:34 PM
nicolasfella added a comment to D10332: Allow choosing a ringtone for FindMyPhone.

Shipping our own ringtone AND having the setting seems an overkill to me. Since we got an awesome ringtone picker "for free" the complexity seems bearable to me. The actual Activity isn't much bigger in the end

Sat, Feb 17, 12:27 PM · KDE Connect
nicolasfella added a comment to D10332: Allow choosing a ringtone for FindMyPhone.

A use case is described in the Bug report

Sat, Feb 17, 10:51 AM · KDE Connect
nicolasfella added a comment to D10165: Use small notification icons when available.

No general objection from my side, the only concern I have is that the small icon might be very low-res and look uglish when scaled. But this is just gut-feeling. Have you tested on real examples?

Sat, Feb 17, 10:18 AM

Wed, Feb 14

nicolasfella committed R224:34a431a00fe7: Fix build (authored by nicolasfella).
Fix build
Wed, Feb 14, 11:01 PM
nicolasfella requested review of D10520: Allow to blacklist numbers in the telephony plugin.
Wed, Feb 14, 9:30 PM · KDE Connect
nicolasfella added a dependent revision for D10519: Apply some coding style to TelephonyPlugin: D10520: Allow to blacklist numbers in the telephony plugin.
Wed, Feb 14, 9:30 PM · KDE Connect
nicolasfella requested review of D10519: Apply some coding style to TelephonyPlugin.
Wed, Feb 14, 9:00 PM · KDE Connect
nicolasfella added a comment to D9266: Add MPRIS media control notification.

Works well so far :) Some small things I noticed: Toggling the option doesn't activate/deactivate the notification immediately.

I know (should have mentioned that, though). It's because the plugin doesn't reload and doesn't get notified in any way of the preference change. I figured that this is the simplest solution, as the notification appears/disappears on the next track/device/player list changes. In general, I think it's good if the plugin can be notified of such changes, or automatically reloads, but I think that's out of scope for this diff.

Maybe https://developer.android.com/guide/topics/ui/settings.html#ReadingPrefs can help :)

Wed, Feb 14, 8:27 PM · KDE Connect

Thu, Feb 8

nicolasfella committed R224:cdb5e488ba74: Merge branch 'master' into filesync (authored by nicolasfella).
Merge branch 'master' into filesync
Thu, Feb 8, 7:12 PM
nicolasfella updated the summary of D10165: Use small notification icons when available.
Thu, Feb 8, 2:18 PM

Wed, Feb 7

nicolasfella added a watcher for Baloo: nicolasfella.
Wed, Feb 7, 6:47 PM

Tue, Feb 6

nicolasfella added inline comments to D10332: Allow choosing a ringtone for FindMyPhone.
Tue, Feb 6, 1:21 AM · KDE Connect

Mon, Feb 5

nicolasfella updated the summary of D7993: System volume plugin Android.
Mon, Feb 5, 6:45 PM · KDE Connect
nicolasfella updated the summary of D7992: Add systemvolume plugin.
Mon, Feb 5, 6:42 PM · KDE Connect
nicolasfella retitled D7993: System volume plugin Android from WIP: System volume plugin Android to System volume plugin Android.
Mon, Feb 5, 6:41 PM · KDE Connect
nicolasfella updated the diff for D7993: System volume plugin Android.

Adapt to desktop

Mon, Feb 5, 6:39 PM · KDE Connect
nicolasfella retitled D7992: Add systemvolume plugin from WIP: Add systemvolume plugin to Add systemvolume plugin.
Mon, Feb 5, 6:34 PM · KDE Connect
nicolasfella updated the diff for D7992: Add systemvolume plugin.

Use libpulse. I copied the code from plasma-pa without modifying it. Most of it is unused, but *could* be
useful someday for more advanced features (e.g. switching profiles). I'm not sure how to deal with that. We
could strip down to the needed code, but then we could not apply improvements from plasma-pa easily.

Mon, Feb 5, 6:33 PM · KDE Connect

Sun, Feb 4

nicolasfella accepted D10148: KCM: Show only available device profiles.

Looks good to me

Sun, Feb 4, 1:01 PM · Plasma
nicolasfella updated the diff for D7993: System volume plugin Android.

Extract control slider into a fragment.
Preparation, but still no support for multiple sinks.

Sun, Feb 4, 12:48 PM · KDE Connect
nicolasfella committed R224:aeb4eeff735e: Tweak KCM (authored by nicolasfella).
Tweak KCM
Sun, Feb 4, 12:10 PM
nicolasfella closed D10287: Tweak KCM.
Sun, Feb 4, 12:08 PM · KDE Connect
nicolasfella committed R115:f5c2a04e8d87: Fix output device context menu (authored by nicolasfella).
Fix output device context menu
Sun, Feb 4, 12:06 PM
nicolasfella closed D10280: Fix output device context menu.
Sun, Feb 4, 12:06 PM · Plasma
nicolasfella updated the test plan for D10287: Tweak KCM.
Sun, Feb 4, 1:57 AM · KDE Connect

Sat, Feb 3

nicolasfella added a comment to D9671: Show only available profiles in Pulseaudio KCM.

This breaks the context menu of output devices:

org.kde.plasma.volume/contents/ui/ListItemBase.qml:315: ReferenceError: Port is not defined
Sat, Feb 3, 9:19 PM · Plasma
nicolasfella abandoned D10224: Give a default player name.

Turns out i wasn't running the latest extension. Works fine now.

Sat, Feb 3, 5:49 PM · Plasma

Fri, Feb 2

nicolasfella requested changes to D10148: KCM: Show only available device profiles.

This leads to the wrong profile being selected. Because some profiles are excluded from the model the indices don't match anymore.

Fri, Feb 2, 9:58 PM · Plasma
nicolasfella added a comment to D10224: Give a default player name.

Well, I am trying to fix PBI. The problem is that my Firefox (58.0.1) does not get recognized as such. Chrome works fine. I will try to dig into the underlying issue.

Fri, Feb 2, 12:27 AM · Plasma
nicolasfella requested changes to D10089: Fix crash in NotificationsPlugin.
Fri, Feb 2, 12:06 AM · KDE Connect
nicolasfella added inline comments to D7959: Make it possible to add commands for the RunCommandsPlugin from Android.
Fri, Feb 2, 12:04 AM · KDE Connect
nicolasfella updated the diff for D7959: Make it possible to add commands for the RunCommandsPlugin from Android.

Replace Material with Appcompat style

Fri, Feb 2, 12:04 AM · KDE Connect
nicolasfella added a comment to D7960: Add commands to RunCommandPlugin - Desktop part.

@apol @albertvaka @mtijink can somebody please test if this works? It doesn't work for me out of nowhere. Looks like the slot in line 128 is never called.

Fri, Feb 2, 12:00 AM · KDE Connect

Thu, Feb 1

nicolasfella committed R116:e1673f18e942: Adjust spacing between text and plotter line in Speed tab of nm applet (authored by kamathraghavendra).
Adjust spacing between text and plotter line in Speed tab of nm applet
Thu, Feb 1, 4:17 PM
nicolasfella closed D10183: Adjust spacing between text and plotter line in Speed tab of nm applet.
Thu, Feb 1, 4:17 PM · Plasma
nicolasfella committed R225:c05f13afac3e: Loop ringtone in FindMyPhonePlugin (authored by nicolasfella).
Loop ringtone in FindMyPhonePlugin
Thu, Feb 1, 10:47 AM
nicolasfella closed D9947: Loop ringtone in FindMyPhonePlugin.
Thu, Feb 1, 10:47 AM · KDE Connect
nicolasfella committed R225:de7d9442300f: Get rid of MaxWidthImageButton (authored by nicolasfella).
Get rid of MaxWidthImageButton
Thu, Feb 1, 10:45 AM
nicolasfella closed D9520: Get rid of MaxWidthImageButton.
Thu, Feb 1, 10:45 AM · KDE Connect

Tue, Jan 30

nicolasfella added a comment to D7700: Show list of tags in PlacesView.

The patch can't stay as-is, because the model was replaced by the one from KIO. We could either include this patch into KIO (which would raise concerns about having too much stuff there) or make it a separate panel. I once planned to extract common stuff from places panel and tags panel to a common ancestor, but that's quite some work. I'll try to put together a standalone Tags Panel soon

Tue, Jan 30, 7:44 PM · Dolphin

Mon, Jan 29

nicolasfella added a reviewer for D10165: Use small notification icons when available: VDG.

I'm not entirely against the idea, but without the icon the desktop notification looks more like the "original" notification. That's why I implemented it the current way.

Mon, Jan 29, 10:47 PM

Jan 24 2018

nicolasfella awarded D10089: Fix crash in NotificationsPlugin a Like token.
Jan 24 2018, 10:10 PM · KDE Connect
nicolasfella added a comment to D9671: Show only available profiles in Pulseaudio KCM.

Feel free to take over, I can't promise to finish it anytime soon

Jan 24 2018, 4:36 PM · Plasma

Jan 23 2018

nicolasfella added a comment to D10032: Swap play/pause icons in mediacontroller plasmoid.

Before

Jan 23 2018, 7:53 PM · Plasma

Jan 20 2018

nicolasfella added inline comments to D7959: Make it possible to add commands for the RunCommandsPlugin from Android.
Jan 20 2018, 1:46 AM · KDE Connect
nicolasfella updated the diff for D7959: Make it possible to add commands for the RunCommandsPlugin from Android.

Add some padding to the dialog

Jan 20 2018, 1:45 AM · KDE Connect
nicolasfella updated the diff for D7959: Make it possible to add commands for the RunCommandsPlugin from Android.

Change android: to app: to avoid crash

Jan 20 2018, 1:39 AM · KDE Connect
nicolasfella planned changes to D7960: Add commands to RunCommandPlugin - Desktop part.

Something broke, have to figure out what.

Jan 20 2018, 1:35 AM · KDE Connect

Jan 19 2018

nicolasfella accepted D9977: Mention 2 fingers to scroll in mousepad_info.
Jan 19 2018, 4:47 AM

Jan 17 2018

nicolasfella added a comment to D9564: Add album cover art support..

Can you confirm that something like https://bugs.kde.org/show_bug.cgi?id=370890 won't happen?

Jan 17 2018, 6:45 PM
nicolasfella updated the summary of D9266: Add MPRIS media control notification.
Jan 17 2018, 12:27 AM · KDE Connect
nicolasfella added a comment to T7629: Clean up bugtracker.

You can do that too,

Jan 17 2018, 12:23 AM · KDE Connect
nicolasfella added a comment to T7629: Clean up bugtracker.

Looks good, now we can focus on the real bugs.

Jan 17 2018, 12:16 AM · KDE Connect

Jan 14 2018

nicolasfella updated the diff for D7959: Make it possible to add commands for the RunCommandsPlugin from Android.

Remove invalidateoptionsmenu

Jan 14 2018, 6:58 PM · KDE Connect