nicolasfella (Nicolas Fella)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 13 2017, 8:21 AM (82 w, 3 d)
Availability
Available

Recent Activity

Today

nicolasfella accepted D17516: [Desktop] Change ThreadID to long.

Didn't test, but looks sane

Wed, Dec 12, 1:01 AM · KDE Connect
nicolasfella accepted D17517: [Android] Change ThreadID to long.

Didn't test but looks sane

Wed, Dec 12, 1:00 AM · KDE Connect

Yesterday

nicolasfella committed R1007:0ae92686285b: Don't show empty entries in FlightPage (authored by nicolasfella).
Don't show empty entries in FlightPage
Tue, Dec 11, 6:14 PM
nicolasfella closed D17509: Don't show empty entries in FlightPage.
Tue, Dec 11, 6:14 PM · KDE PIM
nicolasfella requested review of D17509: Don't show empty entries in FlightPage.
Tue, Dec 11, 4:47 PM · KDE PIM

Mon, Dec 10

nicolasfella added a comment to D17250: Fixed Header in 3 plugin pages: Run Command, Multimedia control, Remote input.

Updated the diff to reflect just the relevant changes for this commit.

Looks good from this point of view. Thanks!

@nicolasfella, do you know whether changing the names of the strings in strings.xml will mess up the translators? If so, we should probably not touch those. It will make our code a little strange but it would save a lot of hassle on their end.

Mon, Dec 10, 7:01 PM · KDE Connect
nicolasfella added a comment to D17287: Enable sharing URLs via email.
In D17287#370993, @apol wrote:

I'm not sure it makes a lot of sense to have the application include the title, isn't it better that the user writes it down on a config page or just the e-mail client?

Mon, Dec 10, 12:27 AM · Frameworks
nicolasfella updated the diff for D17305: Add KDE Connect SMS plugin.
  • i18n
Mon, Dec 10, 12:26 AM · Frameworks

Sun, Dec 9

nicolasfella added reviewers for D17464: [Timer applet] Minor fixes for the applet: muhlenpfordt, mmazur, friedreich, Plasma.
Sun, Dec 9, 9:54 PM · Plasma
nicolasfella accepted D17456: Make DeviceFragments listview use full screen width so the over scroll indicator looks better.

Cool!

Sun, Dec 9, 5:40 PM · KDE Connect
nicolasfella accepted D17451: Incorporate more Material Design components.
Sun, Dec 9, 1:51 PM · KDE Connect
nicolasfella accepted D17417: Add a progress slider to mpris remote in app.

LGTM

Sun, Dec 9, 1:13 PM · KDE Connect
nicolasfella accepted D17434: Use android:theme instead of app:theme because it is deprecated.
Sun, Dec 9, 12:57 PM · KDE Connect
nicolasfella accepted D17452: Fix some lint warnings.
Sun, Dec 9, 12:54 PM · KDE Connect
nicolasfella committed R225:4f54d55cc520: Use one port more (authored by nicolasfella).
Use one port more
Sun, Dec 9, 12:48 PM
nicolasfella closed D17271: Use one port more.
Sun, Dec 9, 12:48 PM · KDE Connect

Sat, Dec 8

nicolasfella requested changes to D17417: Add a progress slider to mpris remote in app.

On Android the position indicator is below the other control (but above the volume control). I would prefer to do the same here.

Sat, Dec 8, 1:16 AM · KDE Connect

Fri, Dec 7

nicolasfella accepted D17409: Do not create a new content fragment on orientation change.
Fri, Dec 7, 7:37 PM · KDE Connect
nicolasfella accepted D17411: Use butterknife for view binding.

Looks fine to me. I can't say much to Butterknife, but it seems to work fine

Fri, Dec 7, 7:32 PM · KDE Connect
nicolasfella accepted D17320: Closing a SSLSockets input or output stream does not close the socket (https://issuetracker.google.com/issues/37018094).

Looks good from looking at it, didn't try it out.

Fri, Dec 7, 6:28 PM · KDE Connect
nicolasfella committed R224:63a353550c93: Add icons to indicator (authored by nicolasfella).
Add icons to indicator
Fri, Dec 7, 4:32 PM
nicolasfella closed D17407: Add icons to indicator.
Fri, Dec 7, 4:32 PM · KDE Connect
nicolasfella requested review of D17407: Add icons to indicator.
Fri, Dec 7, 2:53 PM · KDE Connect
nicolasfella added a parent task for T10162: Make indicator autostart on Windows: T9997: KDE Connect on Windows.
Fri, Dec 7, 12:01 AM · Windows, KDE Connect
nicolasfella added a subtask for T9997: KDE Connect on Windows: T10162: Make indicator autostart on Windows.
Fri, Dec 7, 12:01 AM · Windows, KDE Connect
nicolasfella created T10162: Make indicator autostart on Windows.
Fri, Dec 7, 12:00 AM · Windows, KDE Connect

Thu, Dec 6

nicolasfella committed R224:d26d2ada78bd: Don't use kcmshell5 for opening the KCM (authored by nicolasfella).
Don't use kcmshell5 for opening the KCM
Thu, Dec 6, 10:10 PM
nicolasfella closed D17383: Don't use kcmshell5 for opening the KCM.
Thu, Dec 6, 10:10 PM · KDE Connect
nicolasfella updated the task description for T8992: Improve Media Player in app.
Thu, Dec 6, 7:43 PM · KDE Connect
nicolasfella updated the task description for T8992: Improve Media Player in app.
Thu, Dec 6, 7:43 PM · KDE Connect
nicolasfella accepted D17390: Fix lint warning: Avoid non-default constructors in fragments.
Thu, Dec 6, 6:43 PM · KDE Connect
nicolasfella accepted D17389: Remove not used constructor.
Thu, Dec 6, 6:07 PM · KDE Connect
nicolasfella accepted D17384: Do not send null NetworkPackets.
Thu, Dec 6, 6:07 PM · KDE Connect
nicolasfella added inline comments to D17384: Do not send null NetworkPackets.
Thu, Dec 6, 3:52 PM · KDE Connect
nicolasfella updated the diff for D17383: Don't use kcmshell5 for opening the KCM.
  • Correct license header
Thu, Dec 6, 3:06 PM · KDE Connect
nicolasfella updated the diff for D17383: Don't use kcmshell5 for opening the KCM.
  • Add missing file
Thu, Dec 6, 3:05 PM · KDE Connect
nicolasfella requested review of D17383: Don't use kcmshell5 for opening the KCM.
Thu, Dec 6, 3:04 PM · KDE Connect

Tue, Dec 4

nicolasfella committed R875:7bca744cabb2: Enable page sharing (authored by nicolasfella).
Enable page sharing
Tue, Dec 4, 3:00 AM
nicolasfella closed D17286: Enable page sharing.
Tue, Dec 4, 3:00 AM · Falkon
nicolasfella committed R495:74e0e9852637: Add plugin type for sharing URLs (authored by nicolasfella).
Add plugin type for sharing URLs
Tue, Dec 4, 2:59 AM
nicolasfella closed D17285: Add plugin type for sharing URLs.
Tue, Dec 4, 2:59 AM · Frameworks

Sun, Dec 2

nicolasfella added a comment to D17320: Closing a SSLSockets input or output stream does not close the socket (https://issuetracker.google.com/issues/37018094).

Thanks for looking into this!

Sun, Dec 2, 10:15 PM · KDE Connect
nicolasfella added a dependency for D17305: Add KDE Connect SMS plugin: D17285: Add plugin type for sharing URLs.
Sun, Dec 2, 12:48 PM · Frameworks
nicolasfella added a dependent revision for D17285: Add plugin type for sharing URLs: D17305: Add KDE Connect SMS plugin.
Sun, Dec 2, 12:48 PM · Frameworks
nicolasfella added a dependency for D17305: Add KDE Connect SMS plugin: D17292: [SMS App] Allow passing a message via args.
Sun, Dec 2, 12:47 PM · Frameworks
nicolasfella added a dependent revision for D17292: [SMS App] Allow passing a message via args: D17305: Add KDE Connect SMS plugin.
Sun, Dec 2, 12:47 PM · KDE Connect
nicolasfella requested review of D17305: Add KDE Connect SMS plugin.
Sun, Dec 2, 12:47 PM · Frameworks
nicolasfella updated the diff for D17286: Enable page sharing.
  • Typo--
Sun, Dec 2, 12:38 PM · Falkon
nicolasfella updated the diff for D17286: Enable page sharing.
  • Address comments
Sun, Dec 2, 12:22 PM · Falkon
nicolasfella requested review of D17292: [SMS App] Allow passing a message via args.
Sun, Dec 2, 1:02 AM · KDE Connect

Sat, Dec 1

nicolasfella updated the diff for D17286: Enable page sharing.
  • Remove unneeded include
Sat, Dec 1, 7:38 PM · Falkon
nicolasfella updated the diff for D17286: Enable page sharing.
  • Simplify
Sat, Dec 1, 7:37 PM · Falkon
nicolasfella updated the diff for D17286: Enable page sharing.
  • Set correct min KF5
Sat, Dec 1, 7:33 PM · Falkon
nicolasfella updated the summary of D17286: Enable page sharing.
Sat, Dec 1, 7:33 PM · Falkon
nicolasfella updated the diff for D17286: Enable page sharing.
  • Include page title
Sat, Dec 1, 7:32 PM · Falkon
nicolasfella added a dependency for D17287: Enable sharing URLs via email: D17285: Add plugin type for sharing URLs.
Sat, Dec 1, 7:32 PM · Frameworks
nicolasfella added a dependent revision for D17285: Add plugin type for sharing URLs: D17287: Enable sharing URLs via email.
Sat, Dec 1, 7:32 PM · Frameworks
nicolasfella requested review of D17287: Enable sharing URLs via email.
Sat, Dec 1, 7:31 PM · Frameworks
nicolasfella updated the summary of D17286: Enable page sharing.
Sat, Dec 1, 6:29 PM · Falkon
nicolasfella updated the summary of D17286: Enable page sharing.
Sat, Dec 1, 6:27 PM · Falkon
nicolasfella added a dependency for D17286: Enable page sharing: D17285: Add plugin type for sharing URLs.
Sat, Dec 1, 6:26 PM · Falkon
nicolasfella added a dependent revision for D17285: Add plugin type for sharing URLs: D17286: Enable page sharing.
Sat, Dec 1, 6:26 PM · Frameworks
nicolasfella updated the test plan for D17285: Add plugin type for sharing URLs.
Sat, Dec 1, 6:26 PM · Frameworks
nicolasfella requested review of D17286: Enable page sharing.
Sat, Dec 1, 6:25 PM · Falkon
nicolasfella requested review of D17285: Add plugin type for sharing URLs.
Sat, Dec 1, 6:22 PM · Frameworks
nicolasfella created T10142: Gmail extraction plugin.
Sat, Dec 1, 4:06 PM · KDE Itinerary

Fri, Nov 30

nicolasfella requested review of D17271: Use one port more.
Fri, Nov 30, 10:39 PM · KDE Connect
nicolasfella added a comment to D17250: Fixed Header in 3 plugin pages: Run Command, Multimedia control, Remote input.

Please change the strings only in the res/values/strings.xml. The translations are handled automatically

Fri, Nov 30, 4:57 PM · KDE Connect
nicolasfella abandoned D17125: Title (/Header) in Run Command, Remote Input and Multimedia control was "Remote control". This patch fixes the said Title (/Header) to their respective plugin titles..
Fri, Nov 30, 4:55 PM · KDE Connect
nicolasfella commandeered D17125: Title (/Header) in Run Command, Remote Input and Multimedia control was "Remote control". This patch fixes the said Title (/Header) to their respective plugin titles..
Fri, Nov 30, 4:55 PM · KDE Connect
nicolasfella requested changes to D16491: Allow shares to be canceled.

Needs rebasing, but seems to work fine otherwise.

Fri, Nov 30, 12:22 AM · KDE Connect

Thu, Nov 29

nicolasfella resigned from D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.
Thu, Nov 29, 8:36 PM · KDE Connect
nicolasfella added a comment to T8906: QR code scanner.

An idea that came around was to add barcode scanning to Purpose so that applications that use barcode scanning don't need to implement it themselves. This way one could have multiple "sources" of barcodes such as the local camera or the camera of a device connected via KDE Connect.

Thu, Nov 29, 2:05 PM · Plasma: Mobile (PM 1.0)
nicolasfella added inline comments to D17235: Handle receiving an empty file.
Thu, Nov 29, 1:46 PM · KDE Connect

Wed, Nov 28

nicolasfella requested changes to D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching.

I get some compile errors, apparently you need to explicitly covert int to QString

Wed, Nov 28, 10:19 PM · KDE Connect
nicolasfella added inline comments to D17214: GCI [KDE Connect] Start New Conversation in Messaging App.
Wed, Nov 28, 9:40 PM · KDE Connect
nicolasfella added a comment to T8289: Share whole folder.

Since I wrote the original task description a few things changed. The file sharing in Dolphin is now handled via Purpose. ATM the Share menu isn't shown for folders. Adding that is trivial, but special care is needed that the other share options in Purpose handle sharing a folder gracefully.

Wed, Nov 28, 7:07 PM · Junior Jobs, KDE Connect
nicolasfella moved T5191: KDE Connect should warn user if it can't open needed ports from Fixes to Ideas on the KDE Connect board.
Wed, Nov 28, 6:30 PM · KDE Connect
nicolasfella added a comment to T8647: Application Toolbars App.

This is difficult to implement. AFAIK you can either tell an application to export its menu (make it available to the global menu widget or KDE Connect) or display it in the app itself. Both simultaneously is not possible. So this could only work in combination with some form of global menu.

Wed, Nov 28, 6:25 PM · KDE Connect
nicolasfella moved T9850: Privacy Options for Notifications Forwarded to Desktop from GSoC & GCi to In progress on the KDE Connect board.
Wed, Nov 28, 6:21 PM · Junior Jobs, KDE Connect
nicolasfella closed T4659: Add general system volume control to MPRIS controls using pulseaudio as Resolved.
Wed, Nov 28, 6:21 PM · KDE Connect
nicolasfella moved T9277: Relay Job tracker progress to other device from Ideas to In progress on the KDE Connect board.
Wed, Nov 28, 6:19 PM · KDE Connect
nicolasfella moved T8373: [Junior Job] Use composite job for multiple file transfers from Junior Jobs to In progress on the KDE Connect board.
Wed, Nov 28, 6:18 PM · Junior Jobs, KDE Connect
nicolasfella placed T8289: Share whole folder up for grabs.
Wed, Nov 28, 6:18 PM · Junior Jobs, KDE Connect
nicolasfella closed T6702: Sending a file should have a progress indicator like receiving a file as Resolved.
Wed, Nov 28, 6:18 PM · Junior Jobs, KDE Connect
nicolasfella moved T6702: Sending a file should have a progress indicator like receiving a file from Junior Jobs to In progress on the KDE Connect board.
Wed, Nov 28, 6:17 PM · Junior Jobs, KDE Connect
nicolasfella moved T8637: [Junior Job] Open on remote device from Junior Jobs to In progress on the KDE Connect board.
Wed, Nov 28, 6:17 PM · Junior Jobs, KDE Connect
nicolasfella moved T8539: [Junior Job] Limit KDE Connect to certain (wifi) networks from Junior Jobs to In progress on the KDE Connect board.
Wed, Nov 28, 6:17 PM · Junior Jobs, KDE Connect
nicolasfella moved T9848: Start new conversation in messaging app from Junior Jobs to In progress on the KDE Connect board.
Wed, Nov 28, 6:17 PM · Junior Jobs, KDE Connect
nicolasfella requested changes to D17214: GCI [KDE Connect] Start New Conversation in Messaging App.

There are some changes in this patch that don't belong here. You probably need to do git rebase master to fix it

Wed, Nov 28, 1:47 PM · KDE Connect
nicolasfella edited reviewers for D17214: GCI [KDE Connect] Start New Conversation in Messaging App, added: sredman; removed: Simon.
Wed, Nov 28, 1:44 PM · KDE Connect

Tue, Nov 27

nicolasfella accepted D16962: Add mute button with dynamic icon to MPRIS volume control.

Cool. Thanks for the work!

Tue, Nov 27, 8:41 PM · KDE Connect
nicolasfella added inline comments to D16962: Add mute button with dynamic icon to MPRIS volume control.
Tue, Nov 27, 8:12 PM · KDE Connect

Mon, Nov 26

nicolasfella requested changes to D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.

This needs rebasing to master

Mon, Nov 26, 10:38 PM · KDE Connect
nicolasfella committed R224:793c74e89e06: Show text when device is not reachable (authored by nicolasfella).
Show text when device is not reachable
Mon, Nov 26, 9:56 PM
nicolasfella committed R224:1cee137dcbb9: Align behaviour of the desktop app with the Android app (authored by alexkovrigin).
Align behaviour of the desktop app with the Android app
Mon, Nov 26, 9:15 PM
nicolasfella closed D16935: Align behaviour of the desktop app with the Android app.
Mon, Nov 26, 9:15 PM · KDE Connect
nicolasfella accepted D16935: Align behaviour of the desktop app with the Android app.

Thanks!

Mon, Nov 26, 9:14 PM · KDE Connect
nicolasfella updated the summary of D17178: Don't ask for confimation when reloading.
Mon, Nov 26, 6:32 PM · Frameworks, Kate
nicolasfella requested review of D17178: Don't ask for confimation when reloading.
Mon, Nov 26, 6:31 PM · Frameworks, Kate