nicolasfella (Nicolas Fella)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 13 2017, 8:21 AM (65 w, 4 d)
Availability
Available

Recent Activity

Today

nicolasfella committed R224:1d1fdf8ef5c2: [WIP] Get rid of DownloadJob (authored by nicolasfella).
[WIP] Get rid of DownloadJob
Wed, Aug 15, 3:18 PM
nicolasfella closed D14597: [WIP] Get rid of DownloadJob.
Wed, Aug 15, 3:18 PM · KDE Connect
nicolasfella committed R225:665354c5d598: Split Telephony and SMS plugin on Android (authored by nicolasfella).
Split Telephony and SMS plugin on Android
Wed, Aug 15, 3:12 PM
nicolasfella closed D14612: Split Telephony and SMS plugin on Android.
Wed, Aug 15, 3:12 PM · KDE Connect
nicolasfella added a comment to D14612: Split Telephony and SMS plugin on Android.

It's a bit weird that blocked numbers are now configured from one plugin but affect to both. Are we going to leave it like this?

Wed, Aug 15, 3:11 PM · KDE Connect
nicolasfella committed R206:bae4ef916c87: Remove attachmentservicemenu in favor of Purpose plugin (authored by nicolasfella).
Remove attachmentservicemenu in favor of Purpose plugin
Wed, Aug 15, 3:07 PM
nicolasfella closed D14811: Remove attachmentservicemenu in favor of Purpose plugin.
Wed, Aug 15, 3:07 PM · KDE PIM

Mon, Aug 13

nicolasfella retitled D13594: Split SMS and Telephony plugin on desktop from [WIP] Split SMS and Telephony plugin on desktop to Split SMS and Telephony plugin on desktop.
Mon, Aug 13, 10:01 PM · KDE Connect
nicolasfella added a comment to D13594: Split SMS and Telephony plugin on desktop.

Is this still WIP?

Mon, Aug 13, 10:01 PM · KDE Connect
nicolasfella added a project to D14812: Move 'copy file location after saving' to Save Options page: Spectacle.
Mon, Aug 13, 9:50 PM · Spectacle
nicolasfella requested review of D14811: Remove attachmentservicemenu in favor of Purpose plugin.
Mon, Aug 13, 9:41 PM · KDE PIM
nicolasfella added a comment to D13880: [KMoreTools] Reduce menu hierarchy.

What is the current state of this?
The new private functions should move to the pimpl class behind the d-pointer.

In general: Looking at the public classes, /all/ the private functions should have been hidden behind the pimpl class...

Mon, Aug 13, 11:04 AM · Frameworks

Mon, Aug 6

nicolasfella committed R224:372f23b103e1: [SMS app] Mask regex special characters in search box (authored by nicolasfella).
[SMS app] Mask regex special characters in search box
Mon, Aug 6, 11:07 AM
nicolasfella closed D14642: [SMS app] Mask regex special characters in search box.
Mon, Aug 6, 11:07 AM · KDE Connect
nicolasfella updated the diff for D14597: [WIP] Get rid of DownloadJob.
  • Hack test to pass
  • Remove unneeded lines
  • Split line for readability
Mon, Aug 6, 10:59 AM · KDE Connect
nicolasfella updated the diff for D14642: [SMS app] Mask regex special characters in search box.
  • Use Kai's suggestion
Mon, Aug 6, 10:44 AM · KDE Connect

Sun, Aug 5

nicolasfella updated the diff for D14642: [SMS app] Mask regex special characters in search box.
  • Add a comment
Sun, Aug 5, 10:50 PM · KDE Connect
nicolasfella requested review of D14642: [SMS app] Mask regex special characters in search box.
Sun, Aug 5, 10:48 PM · KDE Connect
nicolasfella committed R224:3437fa5a3968: [SMS app] Search case insensitive (authored by nicolasfella).
[SMS app] Search case insensitive
Sun, Aug 5, 10:32 PM
nicolasfella committed R224:5f63f78f77c2: Show new messages on the bottom (authored by nicolasfella).
Show new messages on the bottom
Sun, Aug 5, 10:22 PM
nicolasfella closed D14638: Show new messages on the bottom.
Sun, Aug 5, 10:22 PM · KDE Connect
nicolasfella updated the diff for D14638: Show new messages on the bottom.
  • Fix send
Sun, Aug 5, 10:19 PM · KDE Connect
nicolasfella committed R224:21b52d7dcfbb: Refine SMS conversation view (authored by nicolasfella).
Refine SMS conversation view
Sun, Aug 5, 10:10 PM
nicolasfella closed D14635: Refine SMS conversation view.
Sun, Aug 5, 10:09 PM · KDE Connect
nicolasfella committed R224:a1b5c4e2d9ac: Display Name and message in separate line (authored by nicolasfella).
Display Name and message in separate line
Sun, Aug 5, 10:05 PM
nicolasfella closed D14636: Display Name and message in separate line.
Sun, Aug 5, 10:05 PM · KDE Connect
nicolasfella requested review of D14638: Show new messages on the bottom.
Sun, Aug 5, 8:50 PM · KDE Connect
nicolasfella updated the summary of D14636: Display Name and message in separate line.
Sun, Aug 5, 7:58 PM · KDE Connect
nicolasfella requested review of D14636: Display Name and message in separate line.
Sun, Aug 5, 7:56 PM · KDE Connect
nicolasfella updated the diff for D14635: Refine SMS conversation view.

fix diff

Sun, Aug 5, 7:51 PM · KDE Connect
nicolasfella requested review of D14635: Refine SMS conversation view.
Sun, Aug 5, 7:50 PM · KDE Connect
nicolasfella committed R224:3bd534449aaa: Port messages to cards (authored by nicolasfella).
Port messages to cards
Sun, Aug 5, 3:14 PM

Sat, Aug 4

nicolasfella added a comment to D14612: Split Telephony and SMS plugin on Android.

Okay arc/git, I give up. SMSPlugin is actually renamed from Telepathyplugin, so the diff is kinda confusing

Sat, Aug 4, 8:45 PM · KDE Connect
nicolasfella updated the diff for D14612: Split Telephony and SMS plugin on Android.

Fix for real

Sat, Aug 4, 8:43 PM · KDE Connect
nicolasfella updated the diff for D14612: Split Telephony and SMS plugin on Android.

fix diff

Sat, Aug 4, 8:38 PM · KDE Connect
nicolasfella requested review of D14612: Split Telephony and SMS plugin on Android.
Sat, Aug 4, 8:31 PM · KDE Connect
nicolasfella updated the diff for D13594: Split SMS and Telephony plugin on desktop.
  • Remove leftover comment
  • Rename variable
Sat, Aug 4, 7:46 PM · KDE Connect
nicolasfella committed R224:367f2e08a950: Clear SMS input field on send (authored by nicolasfella).
Clear SMS input field on send
Sat, Aug 4, 7:20 PM
nicolasfella requested review of D14607: Find my phone runner.
Sat, Aug 4, 4:36 PM · KDE Connect
nicolasfella requested review of D14604: Runner for executing commands on remote device.
Sat, Aug 4, 2:46 PM · KDE Connect
nicolasfella requested review of D14597: [WIP] Get rid of DownloadJob.
Sat, Aug 4, 12:18 PM · KDE Connect

Fri, Aug 3

nicolasfella committed R224:aaa95cf6db0e: Revert accidental change (authored by nicolasfella).
Revert accidental change
Fri, Aug 3, 12:42 AM
nicolasfella committed R224:81cc275f5bf1: Fix NotificationListener Test (authored by nicolasfella).
Fix NotificationListener Test
Fri, Aug 3, 12:40 AM
nicolasfella committed R224:e4385042ebe6: Show icons in plugin list (authored by nicolasfella).
Show icons in plugin list
Fri, Aug 3, 12:26 AM
nicolasfella closed D14571: Show icons in plugin list.
Fri, Aug 3, 12:26 AM · KDE Connect
nicolasfella committed R224:d9f427aaeb64: Move declarativeplugin to top-level dir (authored by nicolasfella).
Move declarativeplugin to top-level dir
Fri, Aug 3, 12:25 AM
nicolasfella closed D14567: Move declarativeplugin to top-level dir.
Fri, Aug 3, 12:25 AM · KDE Connect

Thu, Aug 2

nicolasfella added a dependency for D14571: Show icons in plugin list: D14567: Move declarativeplugin to top-level dir.
Thu, Aug 2, 11:55 PM · KDE Connect
nicolasfella added a dependent revision for D14567: Move declarativeplugin to top-level dir: D14571: Show icons in plugin list.
Thu, Aug 2, 11:55 PM · KDE Connect
nicolasfella requested review of D14571: Show icons in plugin list.
Thu, Aug 2, 11:54 PM · KDE Connect
nicolasfella requested review of D14567: Move declarativeplugin to top-level dir.
Thu, Aug 2, 9:15 PM · KDE Connect

Wed, Aug 1

nicolasfella committed R225:d720684af605: Fix layoout file formatting (authored by nicolasfella).
Fix layoout file formatting
Wed, Aug 1, 9:45 PM
nicolasfella committed R225:877cf6734766: Fix volume icon on dark theme (authored by nicolasfella).
Fix volume icon on dark theme
Wed, Aug 1, 9:45 PM
nicolasfella accepted D10703: Build kdeconnect on sailfish and port some simple plugins.

Looks good to me

Wed, Aug 1, 9:28 PM · KDE Connect

Tue, Jul 31

nicolasfella added a comment to D14397: Support libcanberra for audio notification.

+1 for Canberra

Tue, Jul 31, 12:16 PM · Frameworks
nicolasfella accepted D14430: Added a plugin to present slideshows.

Lovely!

Tue, Jul 31, 10:23 AM · KDE Connect

Mon, Jul 30

nicolasfella added a comment to D12507: Added runcommandplugin widget.

arc land adds the commit message automatically ;)

Mon, Jul 30, 4:16 PM · KDE Connect
nicolasfella committed R225:e0fde1652522: Added runcommandplugin widget (authored by nicolasfella).
Added runcommandplugin widget
Mon, Jul 30, 4:15 PM
nicolasfella closed D12507: Added runcommandplugin widget.
Mon, Jul 30, 4:15 PM · KDE Connect
nicolasfella added a comment to D12507: Added runcommandplugin widget.

I still can't apply the patch using arc, I have to download and apply the diff. When I do so the commit message with the description is lost, so I can't merge this. Can you @nicolasfella push it if arc works for you?

Mon, Jul 30, 4:13 PM · KDE Connect
nicolasfella added a reviewer for D12507: Added runcommandplugin widget: KDE Connect.
Mon, Jul 30, 10:38 AM · KDE Connect
D12507: Added runcommandplugin widget is now accepted and ready to land.
Mon, Jul 30, 10:38 AM · KDE Connect
nicolasfella resigned from D12507: Added runcommandplugin widget.

Thanks, I was able to apply the patch

Mon, Jul 30, 10:37 AM · KDE Connect

Sun, Jul 29

nicolasfella added a comment to D12507: Added runcommandplugin widget.

I get

error: patch failed: AndroidManifest.xml:30
error: AndroidManifest.xml: patch does not apply
Sun, Jul 29, 10:42 PM · KDE Connect
nicolasfella committed R225:5c4c402f2319: Lessen indent before "Send files" in main activity (authored by lennarts).
Lessen indent before "Send files" in main activity
Sun, Jul 29, 10:34 PM
nicolasfella closed D14344: Lessen indent before "Send files" in main activity.
Sun, Jul 29, 10:34 PM · KDE Connect
nicolasfella accepted D14344: Lessen indent before "Send files" in main activity.

If you are looking for something to do next: The icon appears to be a bit darker than the rest, they should have the same color.

Sun, Jul 29, 10:33 PM · KDE Connect
nicolasfella updated the test plan for D14472: Set Dialog flag for JobDialog.
Sun, Jul 29, 9:13 PM · Frameworks
nicolasfella requested review of D14472: Set Dialog flag for JobDialog.
Sun, Jul 29, 9:10 PM · Frameworks

Sat, Jul 28

nicolasfella added reviewers for D14442: Unify window and tab title: Dolphin, ngraham, elvisangelaccio.
Sat, Jul 28, 4:10 PM · Dolphin

Fri, Jul 27

nicolasfella added a comment to D14430: Added a plugin to present slideshows.

Nice work! Some suggestions:

Fri, Jul 27, 10:05 PM · KDE Connect
nicolasfella committed R225:f81cf3bf363c: Don't draw list dividers (authored by nicolasfella).
Don't draw list dividers
Fri, Jul 27, 9:41 PM
nicolasfella closed D12290: Don't draw list dividers.
Fri, Jul 27, 9:41 PM · KDE Connect
nicolasfella accepted D10703: Build kdeconnect on sailfish and port some simple plugins.
Fri, Jul 27, 9:37 PM · KDE Connect
nicolasfella committed R224:69698f340766: Fix typos (authored by nicolasfella).
Fix typos
Fri, Jul 27, 1:01 PM
nicolasfella committed R224:fedea3a9d220: Add .arclint (authored by nicolasfella).
Add .arclint
Fri, Jul 27, 11:32 AM
nicolasfella created T9277: Relay Job tracker progress to other device.
Fri, Jul 27, 10:43 AM · KDE Connect
nicolasfella added a comment to D14397: Support libcanberra for audio notification.

Not using something because it's from a "rival GUI" is not a valid argument. FWIW plasma-pa already uses Glib and Canberra. QtMultimedia uses GStreamer as backend on Unix, so it pulls in glib anyway. The only advantage, if any, of using QtMultimedia is that it uses native APIs on Mac/Windows, but Canberra over GStreamer works there as well.

Fri, Jul 27, 10:39 AM · Frameworks
nicolasfella created T9276: Notify connected devices when about to suspend.
Fri, Jul 27, 10:27 AM · KDE Connect
nicolasfella added a comment to D14421: Build all of KDE Connect in CI.

Those guard experimental code that is not ready for public yet

Fri, Jul 27, 9:12 AM
nicolasfella committed R994:090059ea90de: Fix port availability (authored by nicolasfella).
Fix port availability
Fri, Jul 27, 8:36 AM
nicolasfella added a comment to T9250: Revive bug triaging days.

I'm interested :)

Fri, Jul 27, 7:54 AM
nicolasfella requested review of D14421: Build all of KDE Connect in CI.
Fri, Jul 27, 7:37 AM
nicolasfella committed R224:02e52b787b8a: Add systemvolume plugin (authored by nicolasfella).
Add systemvolume plugin
Fri, Jul 27, 7:22 AM
nicolasfella closed D7992: Add systemvolume plugin.
Fri, Jul 27, 7:22 AM · KDE Connect
nicolasfella committed R225:f9c30148b7ab: System volume plugin Android (authored by nicolasfella).
System volume plugin Android
Fri, Jul 27, 7:20 AM
nicolasfella closed D7993: System volume plugin Android.
Fri, Jul 27, 7:20 AM · KDE Connect
nicolasfella requested changes to D12507: Added runcommandplugin widget.

I'm having trouble applying your patch. Can you please upload it again using arc? It makes our and your life easier. See https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches for instructions

Fri, Jul 27, 6:31 AM · KDE Connect
nicolasfella committed R224:fc4d4e7685d9: Enable running commands from the plasmoid (authored by nicolasfella).
Enable running commands from the plasmoid
Fri, Jul 27, 6:11 AM
nicolasfella closed D13660: Enable running commands from the plasmoid.
Fri, Jul 27, 6:11 AM · KDE Connect
nicolasfella committed R225:2a7535053a71: Add find remote device plugin (authored by nicolasfella).
Add find remote device plugin
Fri, Jul 27, 6:02 AM
nicolasfella closed D12344: Add find remote device plugin.
Fri, Jul 27, 6:02 AM · KDE Connect
nicolasfella committed R225:57fc625af957: Use kdeconnect:// url to trigger commands (authored by nicolasfella).
Use kdeconnect:// url to trigger commands
Fri, Jul 27, 5:57 AM
nicolasfella closed D13447: Use kdeconnect:// url to trigger commands.
Fri, Jul 27, 5:57 AM · KDE Connect
nicolasfella committed R225:7ab7222f7fe5: Fix missing string (authored by nicolasfella).
Fix missing string
Fri, Jul 27, 5:53 AM
nicolasfella committed R225:3e05b7080397: Support MPRIS stop (authored by nicolasfella).
Support MPRIS stop
Fri, Jul 27, 5:48 AM
nicolasfella closed T9070: Implement Stop in MPRIS plugin as Resolved by committing R225:3e05b7080397: Support MPRIS stop.
Fri, Jul 27, 5:47 AM · KDE Connect
nicolasfella closed D13709: Support MPRIS stop.
Fri, Jul 27, 5:47 AM · KDE Connect
nicolasfella committed R225:d83091faf887: Give clearer names (authored by nicolasfella).
Give clearer names
Fri, Jul 27, 5:46 AM
nicolasfella closed D12217: Give clearer names.
Fri, Jul 27, 5:46 AM · KDE Connect