nicolasfella (Nicolas Fella)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 13 2017, 8:21 AM (74 w, 3 d)
Availability
Available

Recent Activity

Yesterday

nicolasfella added a comment to T6702: Sending a file should have a progress indicator like receiving a file.

I'm going to look into this one.

That's great to hear!

I'm completely new to KDE/QT development so bear with me please

We will. Feel free to ask any questions.

Tue, Oct 16, 2:05 PM · Junior Jobs, KDE Connect

Mon, Oct 15

nicolasfella added a project to T9356: AppImage Awarness in plasma Desktop: Baloo.
Mon, Oct 15, 12:28 PM · Baloo, VDG, Plasma, Dolphin
nicolasfella added a comment to T9356: AppImage Awarness in plasma Desktop.

Some thoughts on implementation:

Dolphin file icons.

The thumbnailer should be moved to a KDE repo. Either a new appimageIntegration repo or kio-extras

Mon, Oct 15, 12:27 PM · Baloo, VDG, Plasma, Dolphin
nicolasfella added a project to T8288: Drag n Drop Filetransfer on the plasmoid: Junior Jobs.
Mon, Oct 15, 11:02 AM · Junior Jobs, KDE Connect
nicolasfella added a project to T6702: Sending a file should have a progress indicator like receiving a file: Junior Jobs.
Mon, Oct 15, 11:02 AM · Junior Jobs, KDE Connect
nicolasfella added a project to T8289: Share whole folder: Junior Jobs.
Mon, Oct 15, 11:02 AM · Junior Jobs, KDE Connect
nicolasfella added a project to T8373: [Junior Job] Use composite job for multiple file transfers: Junior Jobs.
Mon, Oct 15, 11:01 AM · Junior Jobs, KDE Connect
nicolasfella added a project to T8637: [Junior Job] Open on remote device: Junior Jobs.
Mon, Oct 15, 11:01 AM · Junior Jobs, KDE Connect
nicolasfella added a project to T8539: [Junior Job] Limit KDE Connect to certain (wifi) networks: Junior Jobs.
Mon, Oct 15, 11:01 AM · Junior Jobs, KDE Connect
nicolasfella added a project to T8611: Support dbus-broker: Junior Jobs.
Mon, Oct 15, 11:01 AM · Junior Jobs, KDE Connect
nicolasfella added a project to T8293: Improve file sharing: Junior Jobs.
Mon, Oct 15, 11:01 AM · Junior Jobs, KDE Connect
nicolasfella added a project to T9676: [Junior Job] Synchonize clipboard on device connection: Junior Jobs.
Mon, Oct 15, 11:00 AM · Junior Jobs, KDE Connect
nicolasfella added a project to T9848: Start new conversation in messaging app: Junior Jobs.
Mon, Oct 15, 11:00 AM · Junior Jobs, KDE Connect
nicolasfella added a project to T9850: Privacy Options for Notifications Forwarded to Desktop: Junior Jobs.
Mon, Oct 15, 11:00 AM · Junior Jobs, KDE Connect

Sat, Oct 13

nicolasfella closed D16145: Adapt autotest to new menu structure.
Sat, Oct 13, 3:32 PM · Frameworks
nicolasfella committed R304:34e50636dd7b: Adapt autotest to new menu structure (authored by nicolasfella).
Adapt autotest to new menu structure
Sat, Oct 13, 3:32 PM

Thu, Oct 11

nicolasfella requested review of D16145: Adapt autotest to new menu structure.
Thu, Oct 11, 10:57 PM · Frameworks
nicolasfella committed R224:7307cd2709a6: [App] Always show drawer on Desktop (authored by nicolasfella).
[App] Always show drawer on Desktop
Thu, Oct 11, 2:30 PM
nicolasfella closed D16122: [App] Always show drawer on Desktop.
Thu, Oct 11, 2:30 PM · KDE Connect

Wed, Oct 10

nicolasfella updated the test plan for D16122: [App] Always show drawer on Desktop.
Wed, Oct 10, 10:38 PM · KDE Connect
nicolasfella updated the test plan for D16122: [App] Always show drawer on Desktop.
Wed, Oct 10, 10:36 PM · KDE Connect
nicolasfella requested review of D16122: [App] Always show drawer on Desktop.
Wed, Oct 10, 10:35 PM · KDE Connect

Tue, Oct 9

nicolasfella added a comment to D15979: [SMS App] Allow scrolling up to load and display older messages.

Yes. The issue is the backend only has one message loaded from the phone. When the view first loads it requests the first 10 which causes the backend to request from the phone. Once they're in cache this isn't a problem (try opening the same conversation twice after a slight delay)
I agree this is kind of ugly but I don't know an easy way to fix it. One thought is to make ConversationsDbusInterface::requestConversation synchronous and block until it is able to serve the request. This would be good for several reasons... For one thing, it would enable having multiple conversation views open at the same time!

Making it blocking sound like it could cause issues when a device is not reachable. Have you actually tested this?
When opening the conversation a bunch (10) messages are requested. The problem is that once they arrive the view isn't updated, isn't it?

Tue, Oct 9, 3:32 PM · KDE Connect
nicolasfella updated the test plan for D16071: Use input field from Kaidan.
Tue, Oct 9, 12:40 PM · KDE Connect
nicolasfella requested review of D16071: Use input field from Kaidan.
Tue, Oct 9, 12:38 PM · KDE Connect

Mon, Oct 8

nicolasfella committed R224:8bfe093939a2: Don't show phonenumber if name is available (authored by nicolasfella).
Don't show phonenumber if name is available
Mon, Oct 8, 6:38 PM
nicolasfella closed D16017: Don't show phonenumber if name is available.
Mon, Oct 8, 6:38 PM · KDE Connect
nicolasfella committed R224:45e966c290d6: Fix person name displaying in ConversationDisplay (authored by nicolasfella).
Fix person name displaying in ConversationDisplay
Mon, Oct 8, 6:37 PM
nicolasfella closed D16015: Fix person name displaying in ConversationDisplay.
Mon, Oct 8, 6:36 PM · KDE Connect
nicolasfella added a reviewer for D16048: Resize the preferences dialogue to avoid horizontal scrolling: aacid.
Mon, Oct 8, 4:25 PM · Okular

Sun, Oct 7

nicolasfella accepted D15608: [Desktop] Update conversation list when a new message arrives.
Sun, Oct 7, 6:55 PM · KDE Connect
nicolasfella added a dependency for D16017: Don't show phonenumber if name is available: D16015: Fix person name displaying in ConversationDisplay.
Sun, Oct 7, 3:10 PM · KDE Connect
nicolasfella added a dependent revision for D16015: Fix person name displaying in ConversationDisplay: D16017: Don't show phonenumber if name is available.
Sun, Oct 7, 3:10 PM · KDE Connect
nicolasfella added a reviewer for D16017: Don't show phonenumber if name is available: KDE Connect.
Sun, Oct 7, 2:59 PM · KDE Connect
nicolasfella requested review of D16017: Don't show phonenumber if name is available.
Sun, Oct 7, 2:57 PM · KDE Connect
nicolasfella requested review of D16015: Fix person name displaying in ConversationDisplay.
Sun, Oct 7, 2:47 PM · KDE Connect
nicolasfella accepted D15992: [SMS App] Improve contact matching.
Sun, Oct 7, 2:31 PM · KDE Connect

Sat, Oct 6

nicolasfella requested changes to D15992: [SMS App] Improve contact matching.

Works pretty good, but to make it work perfectly for me a minor change is needed. Please make canonicalizePhonenumber strip leading zeroes, else +49123456 and 0123456 wouldn't match

Sat, Oct 6, 11:25 PM · KDE Connect
nicolasfella added a comment to T9806: Standardize on a single file/folder/icon view engine that can be re-used across all KDE software.

What's the difference to T9226?

Sat, Oct 6, 10:51 PM · Plasma, Frameworks, Gwenview, Dolphin, KDE Applications
nicolasfella added a comment to D15979: [SMS App] Allow scrolling up to load and display older messages.

Do you mean with the mouse wheel, or with a touchpad? It works with a mouse wheel (and with dragging), but I only just tested a touchpad and that doesn't seem to work. It works after there is more than one message showing. Maybe the solution is to fix the only-one-message problem.

Neither mouse nor touchpad work for me

Sat, Oct 6, 10:34 PM · KDE Connect
nicolasfella added a comment to D15979: [SMS App] Allow scrolling up to load and display older messages.

When I open a long conversation I initially see one message. Scrolling has no effect at all. When dragging I see a couple of messages appearing and immediately disappearing. Still only one message stays. Scrolling still has no effect. I can show new messages by dragging the single message. If I show about half of the new messages scrolling still has no effect. When I drag long enough to trigger the second reload scrolling works as I would expect it.

Sat, Oct 6, 3:24 PM · KDE Connect
nicolasfella accepted D15978: Correct braces and add contributors.
Sat, Oct 6, 2:21 PM · KDE Connect

Fri, Oct 5

nicolasfella committed R1007:9a0f65edb3d5: Add JSON-LD mimetype to desktop file (authored by nicolasfella).
Add JSON-LD mimetype to desktop file
Fri, Oct 5, 2:58 PM
nicolasfella closed D15954: Add JSON-LD mimetype to desktop file.
Fri, Oct 5, 2:58 PM · KDE Itinerary, KDE PIM

Thu, Oct 4

nicolasfella added a project to D15954: Add JSON-LD mimetype to desktop file: KDE Itinerary.
Thu, Oct 4, 9:33 PM · KDE Itinerary, KDE PIM
nicolasfella requested review of D15954: Add JSON-LD mimetype to desktop file.
Thu, Oct 4, 9:31 PM · KDE Itinerary, KDE PIM
nicolasfella accepted D15931: [Places panel] use more appropriate network icon.
Thu, Oct 4, 7:16 PM · Frameworks
nicolasfella added a comment to D15827: [applet] Avoid showing a generic audio-card icon.

I think showing a generic speaker or microphone icon is a huge visual improvement over a sound card, but I agree with @drosca that it's odd to duplicate them.

Here's an idea: It's completely obvious what the sliders are for, so just get rid of the little ones:

Thu, Oct 4, 7:05 PM · Plasma
nicolasfella committed R31:63207819b89f: Link *-resize to the right icons (authored by nicolasfella).
Link *-resize to the right icons
Thu, Oct 4, 6:51 PM
nicolasfella closed D15950: Link *-resize to the right icons.
Thu, Oct 4, 6:50 PM · Plasma
nicolasfella closed D15889: [Cursors] link *-resize to *_corner cursor.

Fixed in D15950

Thu, Oct 4, 6:34 PM · Plasma
nicolasfella requested review of D15950: Link *-resize to the right icons.
Thu, Oct 4, 6:33 PM · Plasma
nicolasfella committed R224:d7d2917e00f9: Use new icon for clearing notifications (authored by nicolasfella).
Use new icon for clearing notifications
Thu, Oct 4, 5:26 PM
nicolasfella closed D15948: Use new icon for clearing notifications.
Thu, Oct 4, 5:26 PM · KDE Connect
nicolasfella updated the summary of D15948: Use new icon for clearing notifications.
Thu, Oct 4, 5:23 PM · KDE Connect
nicolasfella requested review of D15948: Use new icon for clearing notifications.
Thu, Oct 4, 5:22 PM · KDE Connect
nicolasfella committed R224:7cab490cc541: Fix receiving payloads using a bluetooth connection (authored by mtijink).
Fix receiving payloads using a bluetooth connection
Thu, Oct 4, 5:06 PM
nicolasfella closed D12153: Fix receiving payloads using a bluetooth connection.
Thu, Oct 4, 5:05 PM · KDE Connect
nicolasfella committed R225:a4e2af2c51a6: Simplify failed plugin list creation (authored by nicolasfella).
Simplify failed plugin list creation
Thu, Oct 4, 5:03 PM
nicolasfella closed D12232: Simplify failed plugin list creation.
Thu, Oct 4, 5:03 PM · KDE Connect
nicolasfella updated the diff for D15930: Add more icons to actions.

QSL

Thu, Oct 4, 4:56 PM · Falkon
nicolasfella committed R875:3365b52d1c9a: Add icon to Fullscreen action (authored by nicolasfella).
Add icon to Fullscreen action
Thu, Oct 4, 4:53 PM
nicolasfella closed D15925: Add icon to Fullscreen action.
Thu, Oct 4, 4:52 PM · Falkon
nicolasfella committed R875:1f2b2bf819aa: Add icon to Web Search action (authored by nicolasfella).
Add icon to Web Search action
Thu, Oct 4, 4:51 PM
nicolasfella closed D15926: Add icon to Web Search action.
Thu, Oct 4, 4:51 PM · Falkon
nicolasfella added a comment to T8839: Find a better alternative for the QML FileDialog with the Plasma team.

videoPlayer has a quite decent QML file picker
https://github.com/llelectronics/videoPlayer/tree/master/qml/pages/fileman

Thu, Oct 4, 11:46 AM · KDE Itinerary

Wed, Oct 3

nicolasfella updated subscribers of T9795: Use Places Panel code from KIO instead of private implementation.

One thing that strikes me is that a lot of the PlacesItemModel code is just proxying KFilePlacesModel. Another large part of the code seems entirely duplicated. It would make sense to check if we can just use KFilePlacesModel directly in the Places Panel. @renatoo did a larger refactoring of this (D8855), maybe he can offer some insights on this.

Wed, Oct 3, 11:21 PM · Frameworks, Dolphin
nicolasfella requested review of D15930: Add more icons to actions.
Wed, Oct 3, 10:07 PM · Falkon
nicolasfella updated the summary of D15926: Add icon to Web Search action.
Wed, Oct 3, 5:09 PM · Falkon
nicolasfella requested review of D15926: Add icon to Web Search action.
Wed, Oct 3, 5:06 PM · Falkon
nicolasfella updated the summary of D15925: Add icon to Fullscreen action.
Wed, Oct 3, 5:02 PM · Falkon
nicolasfella requested review of D15925: Add icon to Fullscreen action.
Wed, Oct 3, 5:00 PM · Falkon
nicolasfella committed R875:75f3d587185a: Add icon to DownloadManager action (authored by nicolasfella).
Add icon to DownloadManager action
Wed, Oct 3, 2:34 PM
nicolasfella closed D15921: Add icon to DownloadManager action.
Wed, Oct 3, 2:33 PM · Falkon
nicolasfella updated the summary of D15921: Add icon to DownloadManager action.
Wed, Oct 3, 2:32 PM · Falkon
nicolasfella requested review of D15921: Add icon to DownloadManager action.
Wed, Oct 3, 2:29 PM · Falkon
nicolasfella closed T8681: Enable accepting pairing in app, a subtask of T8968: KDE Connect on Plasma Mobile, as Resolved.
Wed, Oct 3, 2:07 PM · Plasma: Mobile (PM 1.0), KDE Connect
nicolasfella closed T8681: Enable accepting pairing in app as Resolved.
Wed, Oct 3, 2:07 PM · KDE Connect
nicolasfella closed T8683: Add runcommand UI to app as Resolved.
Wed, Oct 3, 2:07 PM · KDE Connect
nicolasfella closed T8683: Add runcommand UI to app, a subtask of T8968: KDE Connect on Plasma Mobile, as Resolved.
Wed, Oct 3, 2:07 PM · Plasma: Mobile (PM 1.0), KDE Connect
nicolasfella planned changes to D15883: [Android] Support args for running commands.
Wed, Oct 3, 1:19 PM · KDE Connect
nicolasfella planned changes to D15884: [Desktop] Support args for running commands.
Wed, Oct 3, 1:19 PM · KDE Connect
nicolasfella committed R31:54c6c189f9ba: [cursors] Also link for Breeze Snow (authored by nicolasfella).
[cursors] Also link for Breeze Snow
Wed, Oct 3, 12:31 PM
nicolasfella closed D15920: [cursors] Also link for Breeze Snow.
Wed, Oct 3, 12:30 PM · Plasma
nicolasfella requested review of D15920: [cursors] Also link for Breeze Snow.
Wed, Oct 3, 12:21 PM · Plasma
nicolasfella committed R31:baab8494bbe9: [Cursors] link *-resize to *_corner cursor (authored by nicolasfella).
[Cursors] link *-resize to *_corner cursor
Wed, Oct 3, 12:15 PM
nicolasfella closed D15889: [Cursors] link *-resize to *_corner cursor.
Wed, Oct 3, 12:15 PM · Plasma

Tue, Oct 2

nicolasfella retitled D15899: Fix segfault on project reload with cmake from Fiix segfalut on project reload with cmake to Fix segfault on project reload with cmake.
Tue, Oct 2, 4:01 PM · KDevelop
nicolasfella added a comment to D15883: [Android] Support args for running commands.
In D15883#334966, @apol wrote:

What's the use-case?

Tue, Oct 2, 3:39 PM · KDE Connect

Mon, Oct 1

nicolasfella updated the test plan for D15889: [Cursors] link *-resize to *_corner cursor.
Mon, Oct 1, 10:43 PM · Plasma
nicolasfella added reviewers for D15889: [Cursors] link *-resize to *_corner cursor: Breeze, hpereiradacosta, ngraham, andreask.
Mon, Oct 1, 10:36 PM · Plasma
nicolasfella requested review of D15889: [Cursors] link *-resize to *_corner cursor.
Mon, Oct 1, 10:33 PM · Plasma
nicolasfella retitled D15883: [Android] Support args for running commands from {Android} Support args for running commands to [Android] Support args for running commands.
Mon, Oct 1, 3:38 PM · KDE Connect
nicolasfella retitled D15883: [Android] Support args for running commands from Support args for running commands to {Android} Support args for running commands.
Mon, Oct 1, 3:38 PM · KDE Connect
nicolasfella requested review of D15884: [Desktop] Support args for running commands.
Mon, Oct 1, 3:38 PM · KDE Connect
nicolasfella requested review of D15883: [Android] Support args for running commands.
Mon, Oct 1, 3:35 PM · KDE Connect

Sun, Sep 30

nicolasfella added a comment to D15801: Add icon to compress/extract actions.

I agree that a monochrome icon is better.
archive-extract could use some redesign indeed. I don't see any monochrome compress icon at all.

Sun, Sep 30, 6:09 PM · Ark
nicolasfella committed R225:e4ffd3d3cf02: Enable (de)selecting all apps in notification filter (authored by nicolasfella).
Enable (de)selecting all apps in notification filter
Sun, Sep 30, 5:34 PM
nicolasfella closed D12281: Enable (de)selecting all apps in notification filter.
Sun, Sep 30, 5:34 PM · KDE Connect
nicolasfella committed R225:297f0f66f596: [Telephony] Check last state before handling broadcast (authored by nicolasfella).
[Telephony] Check last state before handling broadcast
Sun, Sep 30, 5:24 PM