nicolasfella (Nicolas Fella)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 13 2017, 8:21 AM (30 w, 3 d)
Availability
Available

Recent Activity

Today

nicolasfella added a comment to D9266: Add MPRIS media control notification.

Could you supply some more information so I can look into it?

Tue, Dec 12, 7:00 PM
nicolasfella added inline comments to D9266: Add MPRIS media control notification.
Tue, Dec 12, 2:50 PM
nicolasfella added a comment to D9266: Add MPRIS media control notification.

Works well so far :) Some small things I noticed: Toggling the option doesn't activate/deactivate the notification immediately. When my laptop screen turns off plasma pauses the media player, but the notification is still in play mode. Both are not critical, but a fix would be nice if it's not too complex.

Tue, Dec 12, 2:21 PM

Yesterday

nicolasfella added a comment to D8966: Add a foreground notification to the background service.
In D8966#178278, @apol wrote:

I've been running the version you gave me that keeps the notification on all the time. I see 2 problems:

  • The notification is annoying. It's more Android saying KDE Connect is doing dark stuff than KDE Connect stating it's alive.
  • I'm pretty sure the phone doesn't do power management properly when it's on (I can't confirm because I had FireChat installed and it's craziness)

    Or did I misunderstand this patch altogether?
Mon, Dec 11, 12:37 AM

Sun, Dec 10

nicolasfella added a task to D9266: Add MPRIS media control notification: T6512: Add Media Player Controls.
Sun, Dec 10, 7:02 PM
nicolasfella added a revision to T6512: Add Media Player Controls: D9266: Add MPRIS media control notification.
Sun, Dec 10, 7:02 PM · KDE Connect
nicolasfella added a comment to D9266: Add MPRIS media control notification.

Thanks for working on this! I would like to have an option to disable the notification in the plugin settings because I can imagine some people may not like to have a persistent notification.

Sun, Dec 10, 6:40 PM

Tue, Dec 5

nicolasfella added a comment to D9190: TransferJob: workaround for when the readChannelFinished has already been emitted.

Yes it does. You don't know it but
m_reply = Daemon::instance()->networkAccessManager()->put(req, m_origin.data());
in filetransferjob.cpp is using kio.

I really didn't know that

Tue, Dec 5, 4:12 PM · Frameworks
nicolasfella added a comment to D9190: TransferJob: workaround for when the readChannelFinished has already been emitted.

I'm sorry, but this does not resolve https://bugs.kde.org/show_bug.cgi?id=386246 for me. KDE Connect's FileTransferJob does not even use KIO's TransferJob. It just extends KJob, so it could be a (similar) bug there.

Tue, Dec 5, 1:20 PM · Frameworks

Sun, Dec 3

nicolasfella committed R224:6a6b97e7c9e5: Fix kdeconnect-cli device list (authored by mtijink).
Fix kdeconnect-cli device list
Sun, Dec 3, 6:29 PM
nicolasfella closed D9060: Fix kdeconnect-cli device list.
Sun, Dec 3, 6:29 PM
nicolasfella committed R224:227e264042f9: Fix "error activiting kdeconnectd" for kdeconnect-cli (authored by mtijink).
Fix "error activiting kdeconnectd" for kdeconnect-cli
Sun, Dec 3, 6:22 PM
nicolasfella closed D9058: Fix "error activiting kdeconnectd" for kdeconnect-cli.
Sun, Dec 3, 6:22 PM

Thu, Nov 23

nicolasfella added inline comments to D8966: Add a foreground notification to the background service.
Thu, Nov 23, 7:36 PM
nicolasfella added a comment to D8966: Add a foreground notification to the background service.

The only commit I see that is not in the master is the one with the Appcompatactivity. Since it does not affect your patch there is no rebasing necessary. I don't know why it's not merged, I would guess Albert has no Oreo phone to test it.

Thu, Nov 23, 3:39 PM
nicolasfella added a comment to D8966: Add a foreground notification to the background service.

FYI there is already some similar work here: https://cgit.kde.org/kdeconnect-android.git/log/?h=update/android-o

Thu, Nov 23, 3:04 PM

Sat, Nov 18

nicolasfella added a comment to D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

I would like to propose another approach. Like discussed in D7700 D8243 and D7446 I would vote for splitting the functionality of the placespanel into smaller panels (~one for each group in the current places panel). By default this could look like the status quo, but the user would be able to reorder them in her gusto. For example, hve the "normal" places entries on the left and the baloo stuff or a tags panel on the right. These panels would inherit from a common abstract panel class but each would have its own model which would be much more maintainable (current PlacesItemModel.cpp has ~1200 LOC). The small panels would also not need group support (the panel IS the group) so the code would be less complex as well

Sat, Nov 18, 2:49 PM
nicolasfella added a comment to T6913: Specific Broadcast Packets.

What's the status of this?

Sat, Nov 18, 10:47 AM · KDE Connect

Nov 6 2017

nicolasfella added a comment to D8157: Fixed typo in German translation of 'category_not_paired_devices'.

Guess this can be closed?

Nov 6 2017, 2:43 PM
nicolasfella abandoned D8157: Fixed typo in German translation of 'category_not_paired_devices'.
Nov 6 2017, 2:42 PM
nicolasfella commandeered D8157: Fixed typo in German translation of 'category_not_paired_devices'.
Nov 6 2017, 2:42 PM
nicolasfella updated the summary of D7960: Add commands to RunCommandPlugin - Desktop part.
Nov 6 2017, 3:27 AM · KDE Connect
nicolasfella added a dependent revision for D7959: Make it possible to add commands for the RunCommandsPlugin from Android: D7960: Add commands to RunCommandPlugin - Desktop part.
Nov 6 2017, 3:27 AM · KDE Connect
nicolasfella updated the diff for D7960: Add commands to RunCommandPlugin - Desktop part.

implement suggestion from @thomasp

Nov 6 2017, 3:25 AM · KDE Connect
nicolasfella committed R224:fbf8852d6fd4: Fix Notifications in Plasmoid (authored by nicolasfella).
Fix Notifications in Plasmoid
Nov 6 2017, 3:16 AM
nicolasfella closed D7209: Fix Notifications in Plasmoid.
Nov 6 2017, 3:16 AM · KDE Connect

Nov 5 2017

nicolasfella updated subscribers of T7257: KDE Connect.
Nov 5 2017, 5:23 PM · Plasma: KCM Redesign

Oct 31 2017

nicolasfella updated the diff for D7209: Fix Notifications in Plasmoid.

emit dataChanged instead of readding the notification.

Oct 31 2017, 11:30 PM · KDE Connect

Oct 25 2017

nicolasfella added a comment to D8449: Have a default backend (if one available).

https://community.kde.org/Infrastructure/Get_a_Developer_Account

Oct 25 2017, 7:54 PM · Plasma

Oct 23 2017

nicolasfella added a comment to D7700: Show list of tags in PlacesView.

IMHO we can merge it for now (maybe I will have to rebase) I like the idea of separate panels and I'm working on something similar. I try to extract generic pieces from the PlacesPanel to an abstract ListPanel that can be extended to create all kinds of panels we want. I'm not done yet but I hope I can show you something soon

Oct 23 2017, 4:38 PM · Dolphin

Oct 17 2017

nicolasfella removed a member for Dolphin: nicolasfella.
Oct 17 2017, 11:00 PM

Oct 15 2017

nicolasfella updated the diff for D7209: Fix Notifications in Plasmoid.

Don't crash when the icon cannot be transferred.

Oct 15 2017, 11:11 PM · KDE Connect
nicolasfella updated the diff for D7959: Make it possible to add commands for the RunCommandsPlugin from Android.

Ooops, wrong diff

Oct 15 2017, 9:20 PM · KDE Connect
nicolasfella updated the diff for D7959: Make it possible to add commands for the RunCommandsPlugin from Android.

Adapt to change in desktop part. Also show the plugin even if the commandlist is empty to make users aware that this functionality exists.

Oct 15 2017, 9:17 PM · KDE Connect
nicolasfella updated the diff for D7960: Add commands to RunCommandPlugin - Desktop part.

Ask user for confirmation. Updated android part as well

Oct 15 2017, 9:04 PM · KDE Connect

Oct 13 2017

nicolasfella added a comment to D7209: Fix Notifications in Plasmoid.

Why is it needed to remove and re-add the notification instead of just calling update?

Oct 13 2017, 9:43 PM · KDE Connect
nicolasfella updated the diff for D7209: Fix Notifications in Plasmoid.

Rebasing

Oct 13 2017, 7:37 PM · KDE Connect
nicolasfella reopened D7209: Fix Notifications in Plasmoid.

This change was overridden by D7312. I discovered that when observing a bug I fixed months ago :D

Oct 13 2017, 7:36 PM · KDE Connect

Oct 9 2017

nicolasfella added inline comments to D8161: findmyphone: Turn on camera flash as well.
Oct 9 2017, 7:50 PM
nicolasfella added a comment to D8161: findmyphone: Turn on camera flash as well.

Since it's only an optional Permission IMHO it would be okay to ask for it and provide an explanation. The user can still decline it if unwanted.

Oct 9 2017, 7:49 PM

Oct 5 2017

nicolasfella abandoned D8146: Don't try to override label heights - PlasmaComponents.
Oct 5 2017, 12:22 PM · Frameworks, Plasma

Oct 4 2017

nicolasfella created D8146: Don't try to override label heights - PlasmaComponents.
Oct 4 2017, 11:15 PM · Frameworks, Plasma

Sep 27 2017

nicolasfella added a comment to D7960: Add commands to RunCommandPlugin - Desktop part.

I see your point. Right now, the UI to add a command is quite hidden. Most users probably don't even know that there is the Commands Plugin, and without adding commands its pretty useless. Maybe we could ask for the user to confirm the sent command in the desktop. What do you think about this?

Sep 27 2017, 1:50 PM · KDE Connect

Sep 26 2017

nicolasfella created D7993: WIP: System volume plugin Android.
Sep 26 2017, 11:05 AM · KDE Connect
nicolasfella created D7992: WIP: Add systemvolume plugin.
Sep 26 2017, 10:59 AM · KDE Connect

Sep 24 2017

nicolasfella closed T4676: Migrate from kmix to pulseaudio as Resolved.
Sep 24 2017, 11:03 AM · KDE Connect
nicolasfella added a comment to D7959: Make it possible to add commands for the RunCommandsPlugin from Android.

Icons are from https://material.io/icons/

Sep 24 2017, 10:28 AM · KDE Connect
nicolasfella updated the diff for D7959: Make it possible to add commands for the RunCommandsPlugin from Android.

Only show add option if adding is supported

Sep 24 2017, 10:25 AM · KDE Connect
nicolasfella updated the diff for D7960: Add commands to RunCommandPlugin - Desktop part.

Let the other device know that it can add commands. Prevents newer Android Clients to show functionality that is not yet there on the desktop

Sep 24 2017, 10:09 AM · KDE Connect
nicolasfella planned changes to D7146: Fix information leak via /tmp.
Sep 24 2017, 10:06 AM · KDE Connect
nicolasfella planned changes to D7700: Show list of tags in PlacesView.
Sep 24 2017, 10:05 AM · Dolphin

Sep 23 2017

nicolasfella created D7960: Add commands to RunCommandPlugin - Desktop part.
Sep 23 2017, 10:10 PM · KDE Connect
nicolasfella added a comment to D7959: Make it possible to add commands for the RunCommandsPlugin from Android.

The diff contains some files that shouldn't be there, just ignore them

Sep 23 2017, 10:06 PM · KDE Connect
nicolasfella updated the summary of D7959: Make it possible to add commands for the RunCommandsPlugin from Android.
Sep 23 2017, 10:00 PM · KDE Connect
nicolasfella created D7959: Make it possible to add commands for the RunCommandsPlugin from Android.
Sep 23 2017, 9:59 PM · KDE Connect
nicolasfella added a comment to D7700: Show list of tags in PlacesView.

I would be fine with moving it to a separate panel. If we do that, the PlacesPanel, the TagsPanel and a (hypothetical, but I saw people voting for it) BookmarksPanel would share a lot of code. Basically it would be the same View and Controller with different Models. I would suggest to get rid of that redundancy by sharing the View and Controller.

Sep 23 2017, 3:22 PM · Dolphin
nicolasfella committed R224:9639d5cd0332: Use pactl instead of KMix in PauseMusic Plugin (authored by nicolasfella).
Use pactl instead of KMix in PauseMusic Plugin
Sep 23 2017, 8:42 AM
nicolasfella closed D7922: Use pactl instead of KMix in PauseMusic Plugin.
Sep 23 2017, 8:42 AM · KDE Connect

Sep 22 2017

nicolasfella retitled D7922: Use pactl instead of KMix in PauseMusic Plugin from Use pacmd instead of KMix in PauseMusic Plugin to Use pactl instead of KMix in PauseMusic Plugin.
Sep 22 2017, 12:43 PM · KDE Connect
nicolasfella updated the diff for D7922: Use pactl instead of KMix in PauseMusic Plugin.

pactl only has a subset of the functionality of pacmd. pacmd also has an interactive cli, but we don't need that and pactl has all the features we need for both this and for setting the system volume. On my Arch/Manjaro system both do the job, but since pacmd fails on your machine we should go with pactl.

Sep 22 2017, 12:41 PM · KDE Connect
nicolasfella committed R293:8d7db8710ed6: Fix tags KIO-slave protocol description (authored by nicolasfella).
Fix tags KIO-slave protocol description
Sep 22 2017, 10:13 AM
nicolasfella closed D7855: Fix tags KIO-slave protocol description.
Sep 22 2017, 10:13 AM · Frameworks

Sep 21 2017

nicolasfella added a comment to D7922: Use pactl instead of KMix in PauseMusic Plugin.

@albertvaka Which system are you running on?

Sep 21 2017, 9:26 PM · KDE Connect
nicolasfella added a comment to D7855: Fix tags KIO-slave protocol description.

This is a workaround for issues which will be more visible when https://phabricator.kde.org/D7700 gets merged

Sep 21 2017, 4:57 PM · Frameworks
nicolasfella created D7922: Use pactl instead of KMix in PauseMusic Plugin.
Sep 21 2017, 4:16 PM · KDE Connect

Sep 17 2017

nicolasfella added a comment to D7700: Show list of tags in PlacesView.

Any further objections/issues/comments?

Sep 17 2017, 7:52 PM · Dolphin

Sep 16 2017

nicolasfella created D7855: Fix tags KIO-slave protocol description.
Sep 16 2017, 8:37 PM · Frameworks
nicolasfella committed R224:9336c0536016: Fix build with Bluetooth enabled (authored by nicolasfella).
Fix build with Bluetooth enabled
Sep 16 2017, 12:04 PM
nicolasfella closed D7777: Fix build with Bluetooth enabled.
Sep 16 2017, 12:04 PM · KDE Connect

Sep 13 2017

nicolasfella updated the diff for D7700: Show list of tags in PlacesView.

Addressed comments

Sep 13 2017, 7:55 PM · Dolphin
nicolasfella added inline comments to D7700: Show list of tags in PlacesView.
Sep 13 2017, 7:52 PM · Dolphin
nicolasfella updated the diff for D7700: Show list of tags in PlacesView.

Use url() instead of urlbase+name

Sep 13 2017, 5:05 PM · Dolphin

Sep 12 2017

nicolasfella updated the diff for D7700: Show list of tags in PlacesView.

Use KCoreDirLister (thanks @emmanuelp). It simplified the whole patch and fixed a problem with newly appearing bookmarks (e.g. when plugging in a USB-Stick). Right now the first 8 Tags are shown, but showing the most (recent) used would sure be better. Any ideas on how to implement this?

Sep 12 2017, 10:35 PM · Dolphin

Sep 11 2017

nicolasfella created D7777: Fix build with Bluetooth enabled.
Sep 11 2017, 10:42 PM · KDE Connect
nicolasfella updated the diff for D7700: Show list of tags in PlacesView.

Only show "All tags" if there are any tags

Sep 11 2017, 8:31 PM · Dolphin
nicolasfella added a comment to D7755: Add "Release Year" to Dolphin information sidebar.

Isn't there a way to transfer his copyright to KDE e.V.?

Sep 11 2017, 8:18 PM · Dolphin
nicolasfella added a comment to D7755: Add "Release Year" to Dolphin information sidebar.

As I understand he wants to contribute without showing his full name. Is there a way to do so? Maybe somebody else can commit it under his/her name?

Sep 11 2017, 8:16 PM · Dolphin
nicolasfella added a comment to D7700: Show list of tags in PlacesView.

What happens if I don't have any tag? Will it show "All tags" without anything below?

Sep 11 2017, 8:13 PM · Dolphin
nicolasfella updated the diff for D7700: Show list of tags in PlacesView.

Show max 8 (because we're better than macOS ;) ) Tags

Sep 11 2017, 6:22 PM · Dolphin
nicolasfella added inline comments to D7700: Show list of tags in PlacesView.
Sep 11 2017, 4:50 PM · Dolphin
nicolasfella added a comment to D7700: Show list of tags in PlacesView.

I was thinking about colored tags as well. Users can already change the icons of the tags in the sidebar. Maybe we could provide some "colored tag" icons. Making the tagged files colored would be worth trying, but is out of scope for this patch

Sep 11 2017, 4:00 PM · Dolphin
nicolasfella added a comment to D7700: Show list of tags in PlacesView.

Thanks for the patch!

I think that we should show only a limited number of tags with an additional Show All (or something like that) which opens tags://.

Sep 11 2017, 2:54 PM · Dolphin
nicolasfella added inline comments to D7700: Show list of tags in PlacesView.
Sep 11 2017, 2:43 PM · Dolphin
nicolasfella updated the summary of D7700: Show list of tags in PlacesView.
Sep 11 2017, 2:20 PM · Dolphin
nicolasfella updated the diff for D7700: Show list of tags in PlacesView.

Fixed indentation and warnings

Sep 11 2017, 12:26 PM · Dolphin

Sep 10 2017

nicolasfella added a comment to D7700: Show list of tags in PlacesView.

Not sure about Dolphin in general, but the Places Panel definitely takes longer to load

Sep 10 2017, 9:25 PM · Dolphin

Sep 8 2017

nicolasfella added a comment to D7700: Show list of tags in PlacesView.

Compiles OK and shows All tags item, but with no children, how do I force a reindex?

Sep 8 2017, 3:51 PM · Dolphin

Sep 7 2017

nicolasfella added a reviewer for D7700: Show list of tags in PlacesView: KDE Applications.
Sep 7 2017, 3:22 PM · Dolphin

Sep 5 2017

nicolasfella created D7700: Show list of tags in PlacesView.
Sep 5 2017, 8:08 PM · Dolphin
nicolasfella added a member for Dolphin: nicolasfella.
Sep 5 2017, 8:01 PM
nicolasfella removed a watcher for Dolphin: nicolasfella.
Sep 5 2017, 8:01 PM

Sep 1 2017

nicolasfella added a reviewer for D6945: Add support for the normal 'umount' porgram.: KDE Connect.
Sep 1 2017, 12:42 PM

Aug 31 2017

nicolasfella added a watcher for Dolphin: nicolasfella.
Aug 31 2017, 11:57 AM

Aug 22 2017

nicolasfella committed R224:5d4821fb9cf6: Only show notification title in plasmoid if different to app name (authored by nicolasfella).
Only show notification title in plasmoid if different to app name
Aug 22 2017, 4:18 PM
nicolasfella closed D7457: Only show notification title in plasmoid if different to app name by committing R224:5d4821fb9cf6: Only show notification title in plasmoid if different to app name.
Aug 22 2017, 4:18 PM · KDE Connect

Aug 21 2017

nicolasfella created D7457: Only show notification title in plasmoid if different to app name .
Aug 21 2017, 9:46 PM · KDE Connect

Aug 19 2017

nicolasfella added a comment to T6651: Redundant SMS Notifications.

Like this:

Aug 19 2017, 3:22 PM · KDE Connect
nicolasfella added a comment to T6651: Redundant SMS Notifications.

I don't know much about telepathy. Can we figure out whether it is used at runtime and what should we do different if it is used?

Aug 19 2017, 11:40 AM · KDE Connect
nicolasfella closed T6583: Android: Clicking a device after a pull-to-refresh breaks the UI as Resolved.
Aug 19 2017, 11:28 AM · KDE Connect
nicolasfella committed R225:9338641a789c: Fix bug while refreshing (authored by nicolasfella).
Fix bug while refreshing
Aug 19 2017, 11:27 AM