hoffmannrobert (Robert Hoffmann)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 23 2017, 8:28 AM (119 w, 1 d)
Availability
Available

Recent Activity

Wed, Dec 4

hoffmannrobert requested review of D25732: Add only canonical paths to dirWatcher.
Wed, Dec 4, 10:33 AM · Dolphin

Fri, Nov 8

hoffmannrobert added inline comments to D25005: Fix image loading performance.
Fri, Nov 8, 2:14 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Move connect to constructor
Fri, Nov 8, 2:11 PM · Gwenview

Nov 5 2019

hoffmannrobert updated the summary of D25005: Fix image loading performance.
Nov 5 2019, 8:57 AM · Gwenview

Nov 4 2019

hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Remove unnecessary include
Nov 4 2019, 2:52 PM · Gwenview
hoffmannrobert added a comment to D25005: Fix image loading performance.

Thanks, I moved the reload() and added a signal readyForDirListerStart() to DocumentFactory, which is emitted when the document is loaded or failed. In ContextManager::setUrlToSelect() this signal is connected to the dirlister start.

Nov 4 2019, 2:35 PM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Move reload(), add DocumentFactory::readyForDirListerStart()
Nov 4 2019, 2:31 PM · Gwenview

Oct 30 2019

hoffmannrobert added a comment to D25005: Fix image loading performance.

The connects at ContextManager::setUrlToSelect() only work with the if (UrlUtils::urlIsFastLocalFile()) determination.

Oct 30 2019, 11:52 AM · Gwenview

Oct 29 2019

hoffmannrobert added a comment to D25005: Fix image loading performance.

You are right, I changed it to use the signals from the document loaded (or not).

Oct 29 2019, 11:54 AM · Gwenview
hoffmannrobert updated the diff for D25005: Fix image loading performance.
  • Start dirlister on document signals
Oct 29 2019, 11:51 AM · Gwenview

Oct 28 2019

hoffmannrobert requested review of D25005: Fix image loading performance.
Oct 28 2019, 1:44 PM · Gwenview

Jul 24 2019

hoffmannrobert updated the diff for D22715: Save and load page margins.
  • Use KTextEditor::EditorPrivate::config()
Jul 24 2019, 2:51 PM · Frameworks, Kate
hoffmannrobert requested review of D22715: Save and load page margins.
Jul 24 2019, 1:31 PM · Frameworks, Kate

Jun 29 2019

hoffmannrobert added a comment to D21563: Fix empty pages in print preview and lines printed twice.

I tried to reproduce the issue with and without this fix but I somehow fail.
Has somebody else more luck?

Jun 29 2019, 5:49 AM · Frameworks, Kate

Jun 25 2019

hoffmannrobert added a comment to D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.

I tested the new code:
Tests 1-5 of the test plan behave like previously "without patch", in tests 6 and 7 the integrated laptop screen isn't reacitivated after opening.

Jun 25 2019, 10:44 AM · Plasma
hoffmannrobert updated the diff for D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.

Rebase and adapt to new upstream code

Jun 25 2019, 10:37 AM · Plasma

Jun 24 2019

hoffmannrobert added a comment to D21959: Fix selectedNameFilter() multiple matches.

Can you please push it for me, I don't have commit access. Thanks.

Jun 24 2019, 9:47 AM · Plasma

Jun 23 2019

hoffmannrobert added a comment to D21563: Fix empty pages in print preview and lines printed twice.

It fixes this bug: https://bugs.kde.org/show_bug.cgi?id=348598

Jun 23 2019, 8:08 PM · Frameworks, Kate
hoffmannrobert added a comment to D21563: Fix empty pages in print preview and lines printed twice.
Jun 23 2019, 8:04 PM · Frameworks, Kate

Jun 22 2019

hoffmannrobert updated the diff for D21959: Fix selectedNameFilter() multiple matches.
  • Remove redundant condition
Jun 22 2019, 8:47 AM · Plasma

Jun 21 2019

hoffmannrobert requested review of D21959: Fix selectedNameFilter() multiple matches.
Jun 21 2019, 11:37 AM · Plasma

Jun 3 2019

hoffmannrobert requested review of D21563: Fix empty pages in print preview and lines printed twice.
Jun 3 2019, 3:07 PM · Frameworks, Kate

May 22 2019

hoffmannrobert updated the summary of D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.
May 22 2019, 2:40 PM · Plasma
hoffmannrobert added a comment to D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.

I added some more fixes:

  • The OSD was displayed even on a closed laptop panel.
  • With more than two screens, using the OSD always generated an "extend to right" configuration, even if "extend to left", "clone", or "disable external/internal" was selected. Now these options do what they say with more than two screens, too.
May 22 2019, 2:36 PM · Plasma
hoffmannrobert added a comment to D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.

This is the real issue. Why are the screen positions scrambled around although there should be a config from before shutdown/suspend (not the lidOpened one), that has the current positions stored. Apparently this one has the wrong positions saved as well. You could check this in your config files.

May 22 2019, 2:35 PM · Plasma
hoffmannrobert updated the test plan for D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.
May 22 2019, 2:29 PM · Plasma
hoffmannrobert updated the test plan for D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.
May 22 2019, 2:03 PM · Plasma
hoffmannrobert updated the test plan for D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.
May 22 2019, 2:02 PM · Plasma
hoffmannrobert updated the test plan for D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.
May 22 2019, 2:02 PM · Plasma
hoffmannrobert updated the diff for D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.
  • Fix OSD displayed on closed laptop panel.
  • Fix generated configurations if there are more than two screens.
May 22 2019, 2:00 PM · Plasma

May 11 2019

hoffmannrobert added a comment to D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.

My goal is to make the screen configurations work reliably with notebooks, not to support a new use case. The use case is: work with a notebook docked and undocked, with and without external screen(s), lid open or closed.

May 11 2019, 8:52 AM · Plasma

May 8 2019

hoffmannrobert requested review of D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens.
May 8 2019, 2:32 PM · Plasma

Apr 7 2019

hoffmannrobert added a comment to D20197: Fix desktop link to file or directory.

Ah! So "DirOrFile" means the user can see and choose both directories and files? Maybe call this ModeWasDirAndFile. I kept reading this was "mode was dirs or mode was files" (which made me say "what else is there?"), while now I think I understand it means "mode was (both dir+files)", right?

Apr 7 2019, 9:52 AM · Frameworks
hoffmannrobert updated the diff for D20197: Fix desktop link to file or directory.
  • Renames
Apr 7 2019, 9:37 AM · Frameworks
hoffmannrobert added inline comments to D20197: Fix desktop link to file or directory.
Apr 7 2019, 8:05 AM · Frameworks
hoffmannrobert updated the diff for D20197: Fix desktop link to file or directory.
  • Use lambdas and helper
Apr 7 2019, 7:54 AM · Frameworks

Apr 5 2019

hoffmannrobert added a comment to D20197: Fix desktop link to file or directory.

Thanks, I've learned that QFileDialog only creates a well behaving directory chooser, if the QFileDialog::ShowDirsOnly option is set to true _after_ having set the fileMode to QFileDialog::Directory. If you do it the other way around, it doesn't add directories to the selection.

Apr 5 2019, 9:07 AM · Frameworks
hoffmannrobert updated the diff for D20197: Fix desktop link to file or directory.
  • Set option QFileDialog::ShowDirsOnly after setting file mode
Apr 5 2019, 8:56 AM · Frameworks

Apr 4 2019

hoffmannrobert added a comment to D20197: Fix desktop link to file or directory.

Is there a different decided directory chooser than QFileDialog?

Apr 4 2019, 4:36 PM · Frameworks
hoffmannrobert added a comment to D20197: Fix desktop link to file or directory.

You need to double click the directory, so you enter the directory, then click Open.

Apr 4 2019, 2:17 PM · Frameworks
hoffmannrobert added a comment to D20197: Fix desktop link to file or directory.

This doesn't work. Try creating a symlink to a directory. In the file picker dialog, the Open button doesn't work.

See https://bugs.kde.org/show_bug.cgi?id=357171 for more context.

Apr 4 2019, 10:34 AM · Frameworks
hoffmannrobert updated the test plan for D20197: Fix desktop link to file or directory.
Apr 4 2019, 10:32 AM · Frameworks
hoffmannrobert updated the diff for D20197: Fix desktop link to file or directory.
  • Add file/directory selection
Apr 4 2019, 10:22 AM · Frameworks

Apr 2 2019

hoffmannrobert requested review of D20197: Fix desktop link to file or directory.
Apr 2 2019, 9:43 AM · Frameworks

Mar 31 2019

hoffmannrobert updated the diff for D19784: Avoid calling QT_LSTAT and accessing recent documents.
  • Add KIO_VERSION check, use SkipMimeTypeFromContent
Mar 31 2019, 9:07 AM · Plasma

Mar 29 2019

hoffmannrobert added a comment to D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option.

Yes, please, and https://phabricator.kde.org/D19784 too.

Mar 29 2019, 2:57 PM · Frameworks
hoffmannrobert added inline comments to D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option.
Mar 29 2019, 2:33 PM · Frameworks
hoffmannrobert updated the diff for D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option.
  • Add ensureInitialized(), entry() changes
Mar 29 2019, 2:24 PM · Frameworks
hoffmannrobert added inline comments to D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option.
Mar 29 2019, 11:40 AM · Frameworks
hoffmannrobert updated the summary of D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option.
Mar 29 2019, 11:38 AM · Frameworks
hoffmannrobert updated the diff for D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option.
  • Fix cmp() #3, add test for cmp()/init(), simplifications
Mar 29 2019, 11:22 AM · Frameworks

Mar 27 2019

hoffmannrobert added a comment to D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option.

JobTest also fails, but this fails in master, too. Something with FileCopyJob.

Mar 27 2019, 1:47 PM · Frameworks
hoffmannrobert updated the diff for D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option.
  • Fix cmp() #2
Mar 27 2019, 1:47 PM · Frameworks
hoffmannrobert updated the diff for D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option.
  • Fix cmp(), SkipMimeTypeFromContent rename, change isDir()
Mar 27 2019, 1:16 PM · Frameworks

Mar 26 2019

hoffmannrobert updated the summary of D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option.
Mar 26 2019, 4:27 PM · Frameworks
hoffmannrobert updated the diff for D19784: Avoid calling QT_LSTAT and accessing recent documents.
  • Use new KFileItem::SkipMimeTypeDetermination parameter
Mar 26 2019, 4:12 PM · Plasma
hoffmannrobert updated the diff for D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option.
  • On-demand stat(), helper function, SkipMimeTypeDetermination
Mar 26 2019, 4:12 PM · Frameworks

Mar 25 2019

hoffmannrobert added a comment to D19784: Avoid calling QT_LSTAT and accessing recent documents.

...

Indeed this doesn't need the stat() done by KFileItem's init(). This means the right solution is indeed for KFileItem to do that stat() on demand, and this code doesn't need any changes.

Mar 25 2019, 6:53 AM · Plasma

Mar 22 2019

hoffmannrobert added a comment to D19784: Avoid calling QT_LSTAT and accessing recent documents.

Nice, kinda sounds like this fixes https://bugs.kde.org/show_bug.cgi?id=373352. Can you confirm?

No, unfortunately it doesn't fix this. If the network isn't available, the file dialog waits for KCoreDirLister ("Iterating over dirs").

Mar 22 2019, 12:51 PM · Plasma
hoffmannrobert added a comment to D19786: Fix WebDAV directory renaming if KeepAlive is off.

No, thanks, I have a sponsor, but I don't have commit access. Please push it for me.

Mar 22 2019, 9:53 AM · Frameworks

Mar 21 2019

hoffmannrobert added a comment to D19786: Fix WebDAV directory renaming if KeepAlive is off.

setting server to keepalive=false? what is this? the 90's? :O

Mar 21 2019, 4:54 PM · Frameworks
hoffmannrobert updated the diff for D19786: Fix WebDAV directory renaming if KeepAlive is off.
  • Call resetSessionSettings()
Mar 21 2019, 4:44 PM · Frameworks

Mar 19 2019

hoffmannrobert added a comment to D19784: Avoid calling QT_LSTAT and accessing recent documents.

Nice, kinda sounds like this fixes https://bugs.kde.org/show_bug.cgi?id=373352. Can you confirm?

Mar 19 2019, 5:00 PM · Plasma
hoffmannrobert added a comment to D19784: Avoid calling QT_LSTAT and accessing recent documents.

See https://phabricator.kde.org/D19887

Mar 19 2019, 4:45 PM · Plasma
hoffmannrobert updated the diff for D19784: Avoid calling QT_LSTAT and accessing recent documents.
  • Use new KFileItem constructor with skipStat set to true
Mar 19 2019, 4:39 PM · Plasma
hoffmannrobert requested review of D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option.
Mar 19 2019, 4:38 PM · Frameworks

Mar 15 2019

hoffmannrobert requested review of D19786: Fix WebDAV directory renaming if KeepAlive is off.
Mar 15 2019, 2:06 PM · Frameworks
hoffmannrobert requested review of D19784: Avoid calling QT_LSTAT and accessing recent documents.
Mar 15 2019, 1:01 PM · Plasma

Mar 11 2019

hoffmannrobert added a comment to D19443: Fix automatic bullets.

No, I don't have commit access. Please push it for me, thanks.

Mar 11 2019, 7:49 PM · KDE PIM

Mar 6 2019

hoffmannrobert added a comment to D19422: Fix upper/lower case rename on case insensitive fs.

Could you please land it for me, I don't have commit access. Thanks.

Mar 6 2019, 4:10 PM · Frameworks

Mar 3 2019

hoffmannrobert updated the diff for D19422: Fix upper/lower case rename on case insensitive fs.

QDir not required, just add '/'

Mar 3 2019, 10:02 AM · Frameworks

Mar 1 2019

hoffmannrobert requested review of D19443: Fix automatic bullets.
Mar 1 2019, 1:58 PM · KDE PIM

Feb 28 2019

hoffmannrobert requested review of D19422: Fix upper/lower case rename on case insensitive fs.
Feb 28 2019, 4:02 PM · Frameworks

Aug 29 2018

hoffmannrobert added a comment to D13853: Fix setting primary connector if primary output changed.

Thanks for reviewing. Can you please land it for me, I don't have commit access.

Aug 29 2018, 7:15 AM · Plasma

Jul 27 2018

hoffmannrobert updated the diff for D10344: Create panel on current screen.

Fix crash if screen numbers are not consecutive.
Add ShellCorona::screenForId(int screenNum) for easy access to a panel's QScreen replacing wrong access via QGuiApplication::screens().at(screenNum).

Jul 27 2018, 3:39 PM · Plasma
hoffmannrobert added a comment to D10344: Create panel on current screen.

Thank you. If these non-consecutive screen numbers are legitimate, then getting the QScreen via QGuiApplication::screens().at(screenNum) is wrong. I found a solution using ShellCorona::m_desktopViewforId.

Jul 27 2018, 2:24 PM · Plasma
hoffmannrobert added a comment to D10344: Create panel on current screen.

In Wayland there seems to be a problem with QScreen: creating a panel on the second screen crashes plasmashell in QScreen::size(), called by PanelView::panelConfig() (shell/panelview.cpp:130).

Jul 27 2018, 9:48 AM · Plasma

Jul 25 2018

hoffmannrobert added a comment to D10344: Create panel on current screen.

Sorry for the delay.

Jul 25 2018, 11:59 AM · Plasma
hoffmannrobert updated the diff for D10344: Create panel on current screen.

Regard focus window position only if manually creating panels.

Jul 25 2018, 11:52 AM · Plasma
hoffmannrobert updated the diff for D10343: Create containment on specified screen.
  • Remove unnecessary Containment::setLastScreen()
Jul 25 2018, 11:40 AM · Frameworks

Jul 18 2018

hoffmannrobert added a comment to D13612: Fix drop between shared views.

Can somebody please land this patch for me? Thanks.

Jul 18 2018, 2:30 PM · Plasma

Jul 5 2018

hoffmannrobert updated the diff for D13853: Fix setting primary connector if primary output changed.
  • Remove wrong Q_ASSERT
Jul 5 2018, 8:31 AM · Plasma

Jul 4 2018

hoffmannrobert added a comment to D13853: Fix setting primary connector if primary output changed.

Addition to last comment: In the other case, booting with HDMI-2 and hotplugging HDMI-3 the problem with primary switching doesn't exist.

Jul 4 2018, 2:23 PM · Plasma
hoffmannrobert added inline comments to D13853: Fix setting primary connector if primary output changed.
Jul 4 2018, 2:15 PM · Plasma

Jul 2 2018

hoffmannrobert updated the test plan for D13853: Fix setting primary connector if primary output changed.
Jul 2 2018, 3:42 PM · Plasma
hoffmannrobert requested review of D13853: Fix setting primary connector if primary output changed.
Jul 2 2018, 3:40 PM · Plasma

Jun 20 2018

hoffmannrobert added a comment to D13612: Fix drop between shared views.

I don't have commit access, can you please land it for me? Thanks.

Jun 20 2018, 8:43 AM · Plasma
hoffmannrobert updated subscribers of D13612: Fix drop between shared views.
Jun 20 2018, 8:15 AM · Plasma

Jun 19 2018

hoffmannrobert requested review of D13612: Fix drop between shared views.
Jun 19 2018, 3:10 PM · Plasma

Jun 12 2018

hoffmannrobert added a comment to D13401: Improve dragging notes.

This is a follow-up to https://phabricator.kde.org/D13379

Jun 12 2018, 8:21 AM · KDE PIM

Jun 7 2018

hoffmannrobert updated the diff for D13401: Improve dragging notes.

Use member variable

Jun 7 2018, 3:20 PM · KDE PIM
hoffmannrobert requested review of D13401: Improve dragging notes.
Jun 7 2018, 11:41 AM · KDE PIM

Jun 6 2018

hoffmannrobert added a comment to D13379: Fix dragging notes.

Works fine
Thanks.

Do you have commit access or do you want that I commit it ?

Jun 6 2018, 11:44 AM · KDE PIM
hoffmannrobert requested review of D13379: Fix dragging notes.
Jun 6 2018, 10:34 AM · KDE PIM

Apr 26 2018

hoffmannrobert added a comment to D12539: Klipper: Do not insert secret data into history.

The keepassx pull request:

Apr 26 2018, 4:16 PM · Plasma
hoffmannrobert added a comment to D12539: Klipper: Do not insert secret data into history.

No, I haven't.

Apr 26 2018, 10:49 AM · Plasma
hoffmannrobert updated the summary of D12539: Klipper: Do not insert secret data into history.
Apr 26 2018, 10:48 AM · Plasma
hoffmannrobert added a comment to D12373: Klipper: Remove first history item on clipboard clear.

Thank you, that caused the issue.

Apr 26 2018, 10:46 AM · Plasma
hoffmannrobert updated the summary of D12539: Klipper: Do not insert secret data into history.
Apr 26 2018, 10:42 AM · Plasma
hoffmannrobert requested review of D12539: Klipper: Do not insert secret data into history.
Apr 26 2018, 10:41 AM · Plasma