dhaumann (Dominik Haumann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 20 2015, 7:20 AM (165 w, 5 d)
Availability
Available

Recent Activity

Thu, Jun 21

dhaumann committed R216:37b803155261: CoffeeScript: add extension .cson (authored by nibags).
CoffeeScript: add extension .cson
Thu, Jun 21, 8:35 PM
dhaumann closed D13565: CoffeeScript: add extension .cson.

Committed, see https://commits.kde.org/syntax-highlighting/37b803155261e97939021cd00cdfcf25fdba65b4

Thu, Jun 21, 7:54 PM · Framework: Syntax Highlighting, Frameworks
dhaumann added a comment to D13394: C++: update for c++20 and fix some syntax errors.

@jpoelen Can you push yourself, or do you still not have a KDE contributor account?

Thu, Jun 21, 7:47 PM · Frameworks
dhaumann accepted D13565: CoffeeScript: add extension .cson.

Looks good.

Thu, Jun 21, 7:40 PM · Framework: Syntax Highlighting, Frameworks
dhaumann accepted D13657: Highlight Gradle files with Groovy syntax too.

Looks good.

Thu, Jun 21, 7:39 PM · Frameworks

Fri, Jun 15

dhaumann accepted D13026: Make menu-bearing toolbar buttons show their menus with normal click rather than click-and-hold.

Lgtm - thanks! Please only in master (as this review request shows).

Fri, Jun 15, 2:52 PM · Frameworks, Kate

Thu, Jun 14

dhaumann accepted D13541: Port solid from Qt5::Widgets to Qt5::Gui.

const auto would be even nicer, if possible. Besides that, lgtm.

Thu, Jun 14, 7:14 PM · Frameworks

Tue, Jun 12

dhaumann updated subscribers of D13394: C++: update for c++20 and fix some syntax errors.

To be honest, I cannot claim I can follow all changes, since this is a big update. But in general the usage of the rules look good.

Tue, Jun 12, 8:07 PM · Frameworks
dhaumann committed R216:601f93780573: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes (authored by nibags).
Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes
Tue, Jun 12, 7:54 PM
dhaumann closed D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes.
Tue, Jun 12, 7:54 PM · Framework: Syntax Highlighting, Frameworks
dhaumann accepted D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes.

Nice update, will integrate. And thanks for the unit test!

Tue, Jun 12, 7:49 PM · Framework: Syntax Highlighting, Frameworks

Sat, Jun 9

dhaumann added a comment to D12768: Allow wrapping selection off top/bottom of autocomplete results.

Indeed, question is if wrapping helps: If you see 5 entries, and you see the last one is correct, then moving up would be ok.
But if the completion contains >> 10 entries, this will not work. And then, there is still the "End" key on the keyboard as dedicated action.

Sat, Jun 9, 9:56 AM · KTextEditor, Frameworks, Kate
dhaumann requested changes to D12271: Don't remove trailing whitespace from cursor line.

See arguments above: If we change it, another one will come over time and submit yet another patch to revert again, and again. This patch cannot go in as is.

Sat, Jun 9, 9:55 AM · Frameworks, KTextEditor, Kate
dhaumann updated subscribers of D12768: Allow wrapping selection off top/bottom of autocomplete results.

I remember that @cullmann intentionally implemented it this way: Going upwards will hide the completion list and not wrap around.

Sat, Jun 9, 9:53 AM · KTextEditor, Frameworks, Kate
dhaumann committed R216:d5c5f4d3c85a: Awk: fix regex in a function and update syntax for gawk (authored by dhaumann).
Awk: fix regex in a function and update syntax for gawk
Sat, Jun 9, 9:51 AM
dhaumann closed D12854: Awk: fix regex in a function and update syntax for gawk.
Sat, Jun 9, 9:51 AM · Framework: Syntax Highlighting, Frameworks
dhaumann accepted D12854: Awk: fix regex in a function and update syntax for gawk.

Looks good to me, will integrate.

Sat, Jun 9, 9:50 AM · Framework: Syntax Highlighting, Frameworks
dhaumann updated subscribers of D12897: Reserve space for the cachedLineForRanges Qhash (optimization).

@mwolff To me this looks ok - do you see an issue with this? E.g. that KTextEditor will require much more memory for almost no gain?

Sat, Jun 9, 9:47 AM · Frameworks, Kate
dhaumann added a comment to D13026: Make menu-bearing toolbar buttons show their menus with normal click rather than click-and-hold.

The same holds true for other actions such as: Tools > Highlighting, Mode, Indentation, Script.

Sat, Jun 9, 9:43 AM · Frameworks, Kate
dhaumann committed R216:0ec0100e5948: Pony: fix single quote escape and a possible infinite loop with # (authored by dhaumann).
Pony: fix single quote escape and a possible infinite loop with #
Sat, Jun 9, 9:37 AM
dhaumann closed D13395: Pony: fix single quote escape and a possible infinite loop with #.
Sat, Jun 9, 9:37 AM · Frameworks
dhaumann accepted D13395: Pony: fix single quote escape and a possible infinite loop with #.

Works - will integrate. Thanks!

Sat, Jun 9, 9:35 AM · Frameworks

Thu, May 31

dhaumann accepted D13138: Re-allow running Kate and KWrite as the actual root user (but still not using sudo).

If it also was decided for Dolphin that this is wanted, I am fine with it.

Thu, May 31, 9:51 AM · Kate

Wed, May 30

dhaumann added a comment to D12233: Avoid manipulation of lists with quadratic complexity.

I would give a ship-it - but maybe another review would be good? @ngraham maybe?

Wed, May 30, 8:21 AM · Baloo, Frameworks

Tue, May 29

dhaumann committed R216:cd9068f802bc: Perl6: Add support for extensions .pl6, .p6, or .pm6 (authored by dhaumann).
Perl6: Add support for extensions .pl6, .p6, or .pm6
Tue, May 29, 9:00 PM
dhaumann committed R216:2dc190ec81d2: GIT_SILENT: Forgot these unit test files (authored by dhaumann).
GIT_SILENT: Forgot these unit test files
Tue, May 29, 9:00 PM
dhaumann committed R216:db2cbfd50c22: Add unit test for C++ Octal number misdetection (authored by dhaumann).
Add unit test for C++ Octal number misdetection
Tue, May 29, 8:56 PM
dhaumann committed R216:b136c9fd1c49: DoxygenLua: fix closing comment blocks (authored by dhaumann).
DoxygenLua: fix closing comment blocks
Tue, May 29, 8:38 PM
dhaumann closed D12860: DoxygenLua: fix closing comment blocks.
Tue, May 29, 8:38 PM · Frameworks
dhaumann accepted D12860: DoxygenLua: fix closing comment blocks.

Will integrate, thanks.

Tue, May 29, 8:35 PM · Frameworks
dhaumann updated subscribers of D12689: Lua: updated for Lua5.3.

@vkrause @cullmann Could you please comment on the above? Should we change KTextEditor such that dynamic is automatically derived based on whether there is a dynamic rule? Indeed, I agree with @jpoelen that this is redundant.

Tue, May 29, 8:34 PM · Frameworks, Framework: Syntax Highlighting
dhaumann added a comment to D13067: add pgf to the latex-ish file formats (same format as tikz).

@jan.hajer Thanks for the patch, updates like this are very much appreciated, so please keep it coming :-) The change will be in KDE Frameworks 5.47, released early in June.

Tue, May 29, 8:27 PM · Framework: Syntax Highlighting, Frameworks
dhaumann committed R216:770d1515db89: add pgf to the latex-ish file formats (same format as tikz) (authored by dhaumann).
add pgf to the latex-ish file formats (same format as tikz)
Tue, May 29, 8:26 PM
dhaumann closed D13067: add pgf to the latex-ish file formats (same format as tikz).
Tue, May 29, 8:26 PM · Framework: Syntax Highlighting, Frameworks
dhaumann added inline comments to D12047: Avoid crash when reading corrupt data from document terms db.
Tue, May 29, 12:46 PM · Baloo, Frameworks
dhaumann added a comment to D12047: Avoid crash when reading corrupt data from document terms db.

Ok, then please commit.

Tue, May 29, 12:45 PM · Baloo, Frameworks
dhaumann added a comment to D11785: Add kcolorschemechooser support and related setting menu entry.

@rempt Is Digikams code the same as this?

Tue, May 29, 11:30 AM · Kate
dhaumann accepted D12025: Terminate query execution early if subterm returns empty result set.
Tue, May 29, 2:53 AM · Baloo, Frameworks
dhaumann accepted D13067: add pgf to the latex-ish file formats (same format as tikz).

This patch is correct, except that the version needs to be increased. Will integrate later.

Tue, May 29, 2:45 AM · Framework: Syntax Highlighting, Frameworks
dhaumann added a project to D13067: add pgf to the latex-ish file formats (same format as tikz): Framework: Syntax Highlighting.
Tue, May 29, 2:44 AM · Framework: Syntax Highlighting, Frameworks
dhaumann added a comment to D12233: Avoid manipulation of lists with quadratic complexity.

Looks good to me.

Tue, May 29, 2:41 AM · Baloo, Frameworks
dhaumann accepted D12047: Avoid crash when reading corrupt data from document terms db.

If the format is really such that a term must appear before any Suffix, then this patch is already better that before.

Tue, May 29, 2:28 AM · Baloo, Frameworks
dhaumann updated subscribers of D11785: Add kcolorschemechooser support and related setting menu entry.

@rempt Does Krita also allow changing the application color scheme? Would something like this be useful?

Tue, May 29, 2:05 AM · Kate

Mon, May 28

dhaumann added a comment to D11685: Implement single click on line number to select line of text.

Ok, thanks!

Mon, May 28, 5:05 AM · Frameworks, Kate
dhaumann added a comment to D11785: Add kcolorschemechooser support and related setting menu entry.

@tfjellstrom Would you give this a try?

Mon, May 28, 5:05 AM · Kate

Sun, May 27

dhaumann added a comment to D11785: Add kcolorschemechooser support and related setting menu entry.

Ping. Any updates on this matter?

Sun, May 27, 8:53 PM · Kate
dhaumann added a comment to D11685: Implement single click on line number to select line of text.

Btw, did anyone test with dynamic word wrap enabled? Does it still work, when a line spans multiple view lines?

Sun, May 27, 8:49 PM · Frameworks, Kate
dhaumann accepted D13094: Avoid short pages in kate configuring docbook.
Sun, May 27, 8:36 PM · Documentation, Kate
dhaumann added a comment to D12629: kateproject: add submodule listing support for git projects.
  1. make a branch: git checkout -b MyNiceFix origin/master
  2. commit in this branch
  3. arc diff # now you have a phabricator review D12345
  4. reviewers review
  5. you change your branch, and again: arc diff, to update the online review
  6. you get your OK: arc land
Sun, May 27, 8:26 PM · Kate
dhaumann committed R216:495600abc98f: Add postgresql keywords (authored by dhaumann).
Add postgresql keywords
Sun, May 27, 8:12 PM
dhaumann added a comment to D7245: Improve reStructuredText highlighting.

@turbov ping again :-) After adding the reference file in autotest/input, run make test, and then call ./autotests/update-reference-data.sh in your build folder. Then git status will tell you which files are new and need to be added updated.

Sun, May 27, 5:12 PM · Frameworks
dhaumann committed R216:849aea294446: Highlighting for OpenSCAD (authored by dhaumann).
Highlighting for OpenSCAD
Sun, May 27, 5:07 PM
dhaumann closed D10719: Highlighting for OpenSCAD.
Sun, May 27, 5:07 PM · Frameworks
dhaumann accepted D10719: Highlighting for OpenSCAD.

Looks good, will integrate!

Sun, May 27, 5:05 PM · Frameworks
dhaumann added a comment to D7087: Add "Copy Info" button to the About System KCM.

Looks pretty good to me already. Is there anything that needs to be addressed? What do you think about i18nc?

Sun, May 27, 4:55 PM · Plasma
dhaumann closed D12629: kateproject: add submodule listing support for git projects.

@michalhumpula This was committed already with 0a96383144e11a6608cbee6a233ffafc4007704d right? I close this revision, probably the commit hooks did not work as expected or so.

Sun, May 27, 10:34 AM · Kate

May 21 2018

dhaumann accepted D12963: Move KWrite command line options from katepart to kwrite docbook.

Oh, I messed up the direction. Makes sense!

May 21 2018, 7:39 PM · Documentation, Kate

May 20 2018

dhaumann accepted D12985: Update+fix katepart menu docbook.

Thanks!

May 20 2018, 5:22 PM · Documentation, Kate
dhaumann added a comment to D12963: Move KWrite command line options from katepart to kwrite docbook.

What is the reason for this move? I am asking since I thought KWrite, Kate, and all the other applications using KTextEditor all implement command line parsing on their own. And Kate for instance has different options such as sessions that KWrite does not have.

May 20 2018, 5:20 PM · Documentation, Kate

May 14 2018

dhaumann updated subscribers of D12689: Lua: updated for Lua5.3.

@jpoelen And why is it a problem with Kate? This means the C++ implementation of the highlighting rules is different in KSyntaxHighlighting and KTextEditor? If so, this would be an important catch. Can you elaborate why this is going wrong?

May 14 2018, 7:55 AM · Frameworks, Framework: Syntax Highlighting

May 13 2018

dhaumann added a comment to D12835: Draw borders around side panels by default.

I as someone being around for 15 years now also immediately thought "huh? Why this forth and back and forth..."?

May 13 2018, 10:18 AM · Plasma
dhaumann added a comment to D12689: Lua: updated for Lua5.3.

@jpoelen Could you have a look at https://bugs.kde.org/show_bug.cgi?id=394184 ? It seems we have a regression?

May 13 2018, 3:06 AM · Frameworks, Framework: Syntax Highlighting

May 12 2018

dhaumann added a comment to T7116: Streamlined onboarding of new contributors.

BTW, Akademy is nearing, registration is open. Could we send a mail to all (!) contributors who have a KDE commit account? I think this does make a lot of sense to trigger everyone (especially new contributors) to come to this event.

May 12 2018, 8:14 PM · Goal settings 2017
dhaumann added a comment to D12831: Don't automatically set the default icons for each style.

Thanks!

May 12 2018, 8:45 AM · Frameworks

May 10 2018

dhaumann added a comment to D9219: WIP: Extend Scripting API.

@cullmann ping? :-)

May 10 2018, 7:17 PM · Frameworks, Kate
dhaumann added a comment to R236:00bce130d35e: Make KMessageWidget match Kirigami inlineMessage's style.

Ah, found my comments in a different browser tab :-P

May 10 2018, 7:15 PM
dhaumann added a comment to D12508: Make KMessageWidget match Kirigami inlineMessage's style.

I think the setIcon() is also buggy, since if you call setIcon() and then setMessageType(), the icon is lost. So yes, I would be in favor of a better solution.

May 10 2018, 7:07 PM · Frameworks
dhaumann added a comment to D12508: Make KMessageWidget match Kirigami inlineMessage's style.

Somehow my other comments were lost, here we go:

  • could you also update the screenshot in the doxygen documentation?
  • setIcon() is behavior incompatible, and in fact, the referenced bugs did not complain about icons. So why the change? In my opinion this is not good enough in case of Kate/KWrite.
  • setIcon(): Now the API documentation in the header file is wrong, since it says by default no icon is set.
May 10 2018, 7:03 PM · Frameworks
dhaumann added a comment to D12508: Make KMessageWidget match Kirigami inlineMessage's style.

Can we revert the setIcon() part? It changes application behavior, an in the case of Kate/KWrite, this is note wanted, see my comments.

May 10 2018, 6:59 PM · Frameworks

May 6 2018

dhaumann committed R216:b7265a714729: cmake: Fix DetectChar warning about escaped backslash (authored by dhaumann).
cmake: Fix DetectChar warning about escaped backslash
May 6 2018, 7:13 PM
dhaumann committed R216:ec6486460a6a: Pony: fix identifier and keyword (authored by jpoelen2).
Pony: fix identifier and keyword
May 6 2018, 7:09 PM
dhaumann closed D12569: Pony: fix identifier and keyword.
May 6 2018, 7:09 PM · Frameworks, Framework: Syntax Highlighting
dhaumann committed R216:9f11b4fa2604: Lua: updated for Lua5.3 (authored by jpoelen).
Lua: updated for Lua5.3
May 6 2018, 7:08 PM
dhaumann accepted D12569: Pony: fix identifier and keyword.

Looks good, will integrate.

May 6 2018, 7:07 PM · Frameworks, Framework: Syntax Highlighting
dhaumann closed D12689: Lua: updated for Lua5.3.

Committed, see https://commits.kde.org/syntax-highlighting/9f11b4fa2604c02e9a15f1949a8455283e9c0d62

May 6 2018, 7:06 PM · Frameworks, Framework: Syntax Highlighting
dhaumann accepted D12689: Lua: updated for Lua5.3.

Looks good to me. Please push.

May 6 2018, 6:58 PM · Frameworks, Framework: Syntax Highlighting
dhaumann added inline comments to D12662: Add InlineNoteInterface.
May 6 2018, 6:53 PM · Frameworks, Kate
dhaumann added a comment to D12662: Add InlineNoteInterface.

This is already an excellent patch. The API documentation is already really nice.

May 6 2018, 6:52 PM · Frameworks, Kate

Apr 29 2018

dhaumann added a comment to D12587: Indentation script for R.

@devillemereuil If I remember correctly, you do not have to run all tests. It is enough to start the indenter test (look into the bin folder) and add as parameter you indent test folder (relative, e.g. cstyle). And, what Thomas says is correct. Typically a test case only contains very few lines to test a specific case. I think once you get the first one running, it will be easy for you to add more.

Apr 29 2018, 9:04 PM · Frameworks, Kate
dhaumann added a comment to D12587: Indentation script for R.

I think this is very cool. But there is one thing we require for new indenters: unit tests.

Apr 29 2018, 7:53 AM · Frameworks, Kate

Apr 17 2018

dhaumann added a comment to D12271: Don't remove trailing whitespace from cursor line.

@sraizada I am just seeing that this is your first KDE patch, nice! I hope that you do not get discouraged by my comments, I am just trying to find good solutions that work for everyone, and in this case, the solution this patch proposed did not work out in the past...

Apr 17 2018, 9:46 AM · Frameworks, KTextEditor, Kate
dhaumann added a comment to D12271: Don't remove trailing whitespace from cursor line.

The behavior that is proposed here was like Kate behaved before, and as result we got bug reports that not all trailing spaces were removed. So we removed this.

Apr 17 2018, 9:44 AM · Frameworks, KTextEditor, Kate

Apr 16 2018

dhaumann added a comment to D11945: Optimize AppArmor & SELinux highlighting and improve regex.

Out of curiosity: why are you putting multiple items in the same line on the keyword lists? This bloats up the diff and makes a real review so much harder... :/

Apr 16 2018, 8:31 AM · Framework: Syntax Highlighting, Frameworks

Apr 15 2018

dhaumann accepted D12224: Use Tree View as the default view mode in the Filesystem Browser plugin.

Ok, then thanks & please go ahead in master branch.

Apr 15 2018, 4:26 PM · Kate
dhaumann added a comment to D12224: Use Tree View as the default view mode in the Filesystem Browser plugin.

I think this is nice, but is this patch a problem if you have new Kate with KTextEditor < 5.46?

Apr 15 2018, 4:14 PM · Kate
dhaumann added a comment to D7175: Redesign CMake syntax.

Sure? It was reverted a month ago once. Was it applied again?

Apr 15 2018, 4:07 PM · Frameworks
dhaumann added a comment to D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9.

@ngraham So what is the current state of a proper fix in KFontRequester?

Apr 15 2018, 4:05 PM · Frameworks, Kate
dhaumann added a comment to D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9.

They all are closed as a general KFontChooser issue. Maybe we should even blog about this :p

Apr 15 2018, 11:48 AM · Frameworks, Kate
dhaumann added a comment to D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9.

Btw there are bug reports for this. Could you link the Kate related ones, if existing?

Apr 15 2018, 11:37 AM · Frameworks, Kate
dhaumann accepted D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9.

A simple fix for a severe issue - please commit!

Apr 15 2018, 11:35 AM · Frameworks, Kate
dhaumann added a comment to D12215: Add a "Reload" menu item to KDirOperator's context menu.

I am ok with this: +1

Apr 15 2018, 7:57 AM · Frameworks

Apr 14 2018

dhaumann updated subscribers of D11785: Add kcolorschemechooser support and related setting menu entry.

Indeed, maybe this class should be part of the KConfigWidgets framework? See https://api.kde.org/frameworks/kconfigwidgets/html/annotated.html for current list of classes - it already contains the color scheme stuff and is a tier3 framework (so many dependencies allowed).

Apr 14 2018, 12:57 AM · Kate
dhaumann added a comment to D11785: Add kcolorschemechooser support and related setting menu entry.

@cullmann This patch is unrelated to KTextEditor settings itself. It only adds an action that allows to change the KDE color scheme per application. The name "KateColorScheme..." is misleading here, since it has nothing to do with Kate color schemes...

Apr 14 2018, 12:49 AM · Kate
dhaumann requested changes to D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).

Looks mostly good, but there are some minor issues we first need to address:

  • dsControlFlow and similar default styles were added with KDE Frameworks 5, so kateversion="5.0" is required in the header
  • WordDetect for things like "end if" is not sensitive to multiple spaces anymore. Are you sure this is correct? If not, please keep RegExpr.
Apr 14 2018, 12:46 AM · Frameworks

Apr 2 2018

dhaumann added a comment to D11818: Don't restart the blocking process on session restore.

Just as more background: no, you are definitely not expected to push to the branch. You only should push to the branch if the bug justifies a mostly untested patch (untested in the sense of that it's probably only you who did proper testing). That said, it usually is up to you to decide. Personally, I believe crashes and severe bug fixes should be backported, but given the risk of introducing regressions in stable versions, commits to the stable branch are often not necessary. It all boils down to risk, and the fact that you take responsibility for what you do :-)

Apr 2 2018, 8:25 PM · Kate
dhaumann added a comment to D11838: Turn on line numbers by default.

As background: in KF5 world, the KTextEditor settings are shared among applications: enabling line numbers in Kate will enable line numbers in KDevelop, Kile, KWrite, ...

Apr 2 2018, 8:19 PM · Frameworks, Kate

Apr 1 2018

dhaumann updated subscribers of D11838: Turn on line numbers by default.

This looks good from my side.

Apr 1 2018, 6:22 AM · Frameworks, Kate

Mar 31 2018

dhaumann requested changes to D11838: Turn on line numbers by default.

Not yet good enough, let's have another revision.

Mar 31 2018, 8:00 PM · Frameworks, Kate
dhaumann accepted D11818: Don't restart the blocking process on session restore.

Thanks for the additional info. Please add this comment to the commit log when you push, so that we have it in the history. Thanks!

Mar 31 2018, 7:49 PM · Kate
dhaumann added a comment to D11818: Don't restart the blocking process on session restore.

Would it also be possible to call setRestartHint() directly, or why is the connect required?

Mar 31 2018, 7:13 AM · Kate