dhaumann (Dominik Haumann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 20 2015, 7:20 AM (276 w, 5 d)
Availability
Available

Recent Activity

May 16 2020

dhaumann added a comment to D29789: Make text always align with font base line.

I like this patch. In fact, I observed over the past years again and again that sometimes, especially if chinese or similar letters are included, the baseline is wrong in Kate, leading to much more overpainting that needed.
If this patch fixes this, then I'm all for it. Or let's put it like this: The current implementation is wrong, this patch looks less wrong than the current state :-)

May 16 2020, 9:16 PM · Frameworks, Kate

May 15 2020

dhaumann added a comment to D27844: Store and fetch complete view config in and from session config.

I suggest to revert, and send a notification with the change to kde-distro-packager@kde.org to avoid that many users break their configuration.

May 15 2020, 5:23 AM · Frameworks, Kate

May 14 2020

dhaumann updated subscribers of D29735: Assign "Identifier" attribute to opening double quote instead of "Comment".

@cullmann could you integrate this?

May 14 2020, 6:33 AM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann accepted D29735: Assign "Identifier" attribute to opening double quote instead of "Comment".

Good catch :) please commit

May 14 2020, 6:31 AM · Frameworks, Framework: Syntax Highlighting, Kate

May 9 2020

dhaumann added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Looking at the code, might it make more sense to just move away from the fixed height we have?

May 9 2020, 3:48 PM · Frameworks, Kate

Mar 25 2020

dhaumann added a comment to D28287: Undo cursor move.

I am currently not convinced for several reasons:

  1. There is already a way to do this on KTextEditor level, see: https://github.com/KDE/ktexteditor/blob/master/src/document/katedocument.h#L406
  2. I believe this should be a plugin, since the current implementation makes the current code more complex, and it's a feature we have not needed for > 15 years.
Mar 25 2020, 10:25 PM · Kate

Mar 14 2020

dhaumann added a comment to D28039: optimize dynamic regex matching.

Thanks yes, maybe you can add a comment to the skipOffset, Christoph :)

Mar 14 2020, 9:38 AM · Frameworks, Kate

Mar 13 2020

dhaumann accepted D28039: optimize dynamic regex matching.

I guess this is OK, but the concept of a "skip offset" is a bit fuzzy to me.

Mar 13 2020, 9:48 PM · Frameworks, Kate
dhaumann accepted D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt.

I guess in a followup commit the reported issues will be fixed? :-)

Mar 13 2020, 4:46 PM · Frameworks, Kate

Mar 10 2020

dhaumann added a comment to D27928: [VIM Mode] Add g<up> g<down> commands.

The intimidating one :)

Mar 10 2020, 12:45 PM · Frameworks, Kate

Mar 9 2020

dhaumann accepted D27929: CMake syntax fixes.

Thanks!

Mar 9 2020, 8:14 PM · Frameworks, Kate
dhaumann accepted D27916: Add Overpass QL highlighting.

Almost good, please fix + ship.

Mar 9 2020, 8:13 PM · Frameworks, Kate
dhaumann added a comment to D27928: [VIM Mode] Add g<up> g<down> commands.

I like the patch, but please add a unit test before we commit this. See https://github.com/KDE/ktexteditor/tree/master/autotests/src/vimode
Could you add one? :)

Mar 9 2020, 8:11 PM · Frameworks, Kate
dhaumann added a comment to D27844: Store and fetch complete view config in and from session config.

I guess we can give this a try. As I understand, though, with this patch you will never be able to use e.g. a global zoom once you change the zoom of a view. This was different before this patch.

Mar 9 2020, 8:08 PM · Frameworks, Kate

Feb 26 2020

dhaumann added a comment to T12744: Consider increasing the default fixed width font size by 1 (9 -> 10).

I'd be ok with this for Kate.

Feb 26 2020, 10:09 PM · Konsole, Kate, VDG

Feb 23 2020

dhaumann added inline comments to D27533: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks.
Feb 23 2020, 12:36 PM · Frameworks, Kate

Feb 22 2020

dhaumann accepted D27533: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks.
Feb 22 2020, 10:41 AM · Frameworks, Kate
dhaumann added a comment to D27533: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks.

Ok, then I am fine with this. Maybe add a KF6 task to the KF6 board?

Feb 22 2020, 10:41 AM · Frameworks, Kate

Feb 21 2020

dhaumann added a comment to D27533: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks.

Definitely a +1 for using a QIcon here.

Feb 21 2020, 11:00 PM · Frameworks, Kate

Feb 13 2020

dhaumann updated subscribers of D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines.

Ok, I now fully got this, thanks for the explanation. And indeed without any left fill visual feedback is missing.

Feb 13 2020, 10:21 PM · Frameworks, Kate

Feb 12 2020

dhaumann added a comment to D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines.

No offense meant, but even with the screenshots I still have no idea what this is about :)

Feb 12 2020, 11:04 PM · Frameworks, Kate

Feb 9 2020

dhaumann updated subscribers of D27238: Add an option to dynamic-break inside words.

I think this patch looks good.

Feb 9 2020, 9:43 PM · Frameworks, Kate, KTextEditor

Feb 6 2020

dhaumann added a comment to D27180: Add sortable columns to session manager dialog, and remove previous sorting code.

I'd be fine with committing this. Still, there very clearly is large room to improve this further.

Feb 6 2020, 11:01 PM · Kate
dhaumann added a comment to D27180: Add sortable columns to session manager dialog, and remove previous sorting code.

I like the idea of the patch, could you add a screenshot?

Feb 6 2020, 9:31 PM · Kate

Jan 30 2020

dhaumann added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Better :) with corners I mean the 1-3 pixels left due to the rounding corners. These pixels were once also drawn as background although they are outside of the frame. It may be a minor detail, but imho such details are important. But indeed, the screenshots look good.

Jan 30 2020, 9:19 PM · Frameworks
dhaumann added a comment to D26697: Message-related methods: Use more member-function-pointer-based connect.

In two days we have the next KDE Frameworks tag. I'd have preferred a commit on Sunday ;)

Jan 30 2020, 9:05 PM · Frameworks, Kate
dhaumann added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Can you provide screenshots of more styles? :-)

Jan 30 2020, 4:30 PM · Frameworks
dhaumann added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Does that also work in Kate for floating messages like when the search wraps? What I want to know is whether the corners behind the green frame are transparent in this case, or whether the corners are painted solid. If I remember correctly, these kind of bugs were the reason to use Qt StyleSheets. And it must work with all styles.

Jan 30 2020, 4:19 PM · Frameworks

Jan 24 2020

dhaumann added a comment to D26903: allow programLogo property to be a QIcon, too.

Looks good to me, and very much in line with the other canConvert statements before.

Jan 24 2020, 8:43 PM · Frameworks

Jan 21 2020

dhaumann committed R40:d198c37cdb36: Fix External Tool "Google Selected Text" (authored by dhaumann).
Fix External Tool "Google Selected Text"
Jan 21 2020, 6:07 PM
dhaumann committed R40:a07dceabbb02: Fix External Tool "Google Selected Text" (authored by dhaumann).
Fix External Tool "Google Selected Text"
Jan 21 2020, 6:02 PM
dhaumann closed D26812: Variable expansion: Add variable PercentEncoded.
Jan 21 2020, 5:33 PM · Frameworks, Kate
dhaumann committed R39:b0055e8476bb: Variable expansion: Add variable PercentEncoded (authored by dhaumann).
Variable expansion: Add variable PercentEncoded
Jan 21 2020, 5:33 PM
dhaumann committed R39:22fa707eb7e2: Fix crash in variable expansion (used by external tools) (authored by dhaumann).
Fix crash in variable expansion (used by external tools)
Jan 21 2020, 5:33 PM
dhaumann closed D26811: Fix crash in variable expansion (used by external tools).
Jan 21 2020, 5:33 PM · Frameworks, Kate
dhaumann requested review of D26812: Variable expansion: Add variable PercentEncoded.
Jan 21 2020, 5:31 PM · Frameworks, Kate
dhaumann requested review of D26811: Fix crash in variable expansion (used by external tools).
Jan 21 2020, 5:13 PM · Frameworks, Kate
dhaumann committed R216:e8e098bd9f28: Perl: Add 'say' to keyword list (authored by dhaumann).
Perl: Add 'say' to keyword list
Jan 21 2020, 11:20 AM
dhaumann added inline comments to D25698: New query mechanism for applications: KApplicationTrader.
Jan 21 2020, 7:37 AM · Frameworks

Jan 20 2020

dhaumann accepted D26779: Updates nasm.xml with the latest instructions.

Looks good to me. Can you commit or shall we push this for you?

Jan 20 2020, 2:01 PM · Frameworks, Kate

Jan 19 2020

dhaumann added a comment to D26755: [WIP] KMessageWidget: Set widget height on resize event.

Well, it definitely would be very nice if you find a patch that fixes this.

Jan 19 2020, 2:53 PM · Frameworks
dhaumann resigned from D26755: [WIP] KMessageWidget: Set widget height on resize event.

In that case I withdraw my review for now. I can only speak for Kate that I could not find a regression with my tests. But if you find other regressions, then this is likely not correct.

Jan 19 2020, 12:28 PM · Frameworks
dhaumann committed R39:d47bf03792fc: GIT_SILENT: Adapt timings of message test (authored by dhaumann).
GIT_SILENT: Adapt timings of message test
Jan 19 2020, 11:41 AM
dhaumann accepted D26755: [WIP] KMessageWidget: Set widget height on resize event.

I just tested with KTextEditor's messagetest and KTextEditor's usage of KMessageWidget in the top and bottom bar, and all this looks still good.

Jan 19 2020, 11:34 AM · Frameworks
dhaumann committed R40:631f6a3e4e7f: QUrl: Use isLocalFile() to test for valid local file (authored by dhaumann).
QUrl: Use isLocalFile() to test for valid local file
Jan 19 2020, 11:06 AM
dhaumann committed R40:df2b580f1d6f: External tools: Correctly set the working directory (authored by dhaumann).
External tools: Correctly set the working directory
Jan 19 2020, 11:00 AM
dhaumann added a comment to D26755: [WIP] KMessageWidget: Set widget height on resize event.

Since KTextEditor uses KMessageWidget extensively we have to make sure the unit test messagetest still passes with this change.

Jan 19 2020, 8:46 AM · Frameworks

Jan 16 2020

dhaumann accepted D26704: KateMessageWidget: remove unused event filter installation.

I guess this change is correct :-)

Jan 16 2020, 3:48 PM · Frameworks, Kate

Jan 13 2020

dhaumann added a comment to D26560: Fix selection printing.

That looks already better: If a line is wrapped and on the same page, then only the selected text is printed. It seems there are still corner cases.

  1. Create a document with just one long line that wraps over two printed pages. I this case, I am not able to print only the selected text properly.
  2. Say you have a line that wraps over e.g. 5 visual lines. And you just want to print the visually wrapped line 4 and 5. Right now, the visual lines 1-3 are just empty, but still take place. Maybe it makes sense to omit fully empty lines completely?
Jan 13 2020, 7:51 PM · Frameworks, Kate

Jan 10 2020

dhaumann committed R40:007a7aef9999: Highlight documentation: add equivalence in regex for number rules and add… (authored by nibags).
Highlight documentation: add equivalence in regex for number rules and add…
Jan 10 2020, 8:09 PM

Jan 6 2020

dhaumann accepted D26463: Port endl as \n or std::cout ... std::endl when we wrote directly on console or flush QTextStream when it's a qstring.
Jan 6 2020, 8:19 PM · Frameworks, Kate

Jan 5 2020

dhaumann added inline comments to D26424: [kdiroperator] Add method for accessing actions without KActionCollection.
Jan 5 2020, 9:45 AM · Frameworks

Jan 3 2020

dhaumann committed R40:adb1a3564abb: Remove Qt 5.7 version check, since Kate depends on Qt 5.10 (authored by dhaumann).
Remove Qt 5.7 version check, since Kate depends on Qt 5.10
Jan 3 2020, 2:28 PM
dhaumann committed R40:b451a73f6055: Remove QT_VERSION_CHECK for Qt >= 5.7, since Kate depends on Qt 5.10 (authored by dhaumann).
Remove QT_VERSION_CHECK for Qt >= 5.7, since Kate depends on Qt 5.10
Jan 3 2020, 2:14 PM
dhaumann committed R39:6609e4f9235d: Fix warning about unused variable and minor optimization (authored by dhaumann).
Fix warning about unused variable and minor optimization
Jan 3 2020, 2:13 PM
dhaumann committed R39:1520fced9ccf: GIT_SILENT: Adapt qDebug() output to proper spaces and quotes (authored by dhaumann).
GIT_SILENT: Adapt qDebug() output to proper spaces and quotes
Jan 3 2020, 2:13 PM
dhaumann committed R40:6b5f1ee7a3e2: Merge branch 'release/19.12' (authored by dhaumann).
Merge branch 'release/19.12'
Jan 3 2020, 1:47 PM
dhaumann committed R40:5aa3b009cf53: Fix crash when pressing ESC after external tools plugin was un/reloaded (authored by dhaumann).
Fix crash when pressing ESC after external tools plugin was un/reloaded
Jan 3 2020, 1:46 PM

Jan 1 2020

dhaumann accepted D26321: Expose show-line-count in the ConfigInterface.

Ok with this... Thanks. A note " Since 5.6x would be nice".

Jan 1 2020, 12:38 AM · Frameworks, KTextEditor, Kate

Dec 30 2019

dhaumann committed R39:46ff95a99746: Branch for KSyntaxHighlighting::Theme integration (authored by dhaumann).
Branch for KSyntaxHighlighting::Theme integration
Dec 30 2019, 10:03 AM
dhaumann committed R40:5203a17cc497: Merge branch 'release/19.12' (authored by dhaumann).
Merge branch 'release/19.12'
Dec 30 2019, 9:54 AM

Dec 29 2019

dhaumann added a comment to D21563: Fix empty pages in print preview and lines printed twice.

@hoffmannrobert: by the way, looking at your phabricator activity, you should get a KDE contributor account, if you don't have one already.

Dec 29 2019, 11:06 AM · Frameworks, Kate
dhaumann added a comment to D21563: Fix empty pages in print preview and lines printed twice.

@hoffmannrobert: Are you maybe also interested in looking into https://bugs.kde.org/show_bug.cgi?id=415570 ? It's again about printing, this time about the very last line that seems to be wrong...

Dec 29 2019, 11:03 AM · Frameworks, Kate

Dec 22 2019

dhaumann added a comment to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.

@Gregor: That the terminal does not get focus on show was a regression in konsole part and should be fixed. I don't think there is any action item left for now.

Dec 22 2019, 10:16 PM · Goal: Consistency, Dolphin, Kate

Dec 15 2019

dhaumann committed R40:5d486c09a859: doc: extend lspclient documentation (authored by mnauwelaerts).
doc: extend lspclient documentation
Dec 15 2019, 10:59 PM

Dec 11 2019

dhaumann accepted D25870: SELinux: add "glblub" keyword and update permissions list.
Dec 11 2019, 2:07 PM · Frameworks, Kate
dhaumann accepted D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword.
Dec 11 2019, 2:06 PM · Frameworks, Kate

Dec 10 2019

dhaumann added a comment to D23457: Port the search interface from QRegExp to QRegularExpression.

Personally, I am not convinced replacing \s with [ \t], and deviating from PCRE default behaviour is a good idea in this case.

Dec 10 2019, 9:11 PM · Frameworks, Kate
dhaumann added a comment to D23457: Port the search interface from QRegExp to QRegularExpression.

Was anything of the previously commented issues addressed?

Dec 10 2019, 1:43 PM · Frameworks, Kate

Dec 8 2019

dhaumann added a comment to D25805: Open/close and focus/defocus terminal using the same shortcuts as Dolphin.

Doesn't this patch imply we have the same action twice now? Once provided by Konsole, and once by katemdi via View > Tool Views > Show Terminal?

Dec 8 2019, 10:56 PM · Kate

Dec 6 2019

dhaumann added inline comments to D25767: KAutoSaveFile: add a unit test to check max. filename length.
Dec 6 2019, 8:13 AM · Frameworks

Dec 5 2019

dhaumann added a comment to D25755: Replace iterators with range-based for.

Do we dislike iterators now?

We don't, and they still make sense for when you need the key, but range for is just much nier to look at :)

I'm fine with that statement. But are we going to be reviewing changing all the KDE code from iterators to range for? Feels like an overkill to me.

Dec 5 2019, 8:18 PM · Frameworks
dhaumann accepted D25770: Several enhancements to gitolite syntax definition..

Looks good. But does the highlighting work for RW+CD? I am wondering whether + needs to be added to the weakDeliminator list?

Dec 5 2019, 8:06 PM · Frameworks, Kate

Dec 4 2019

dhaumann added a comment to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.

You can achieve Dolphin's behavior by reassigning the F4 shortcut to View > Tool Views > Show/Hide Konsole. That's what I do since > 10 years, and it works perfectly. Why is it not the default? Maybe because this action does not exist by default (i.e. when the Konsole plugin is not loaded). But the right fix is to reassign the F4 shortcut to this action.

Dec 4 2019, 3:50 PM · Goal: Consistency, Dolphin, Kate

Dec 3 2019

dhaumann accepted D25276: reStructuredText: Fix inline literals highlighting preceding characters.

Ok

Dec 3 2019, 6:59 AM · Frameworks, Kate

Dec 2 2019

dhaumann added inline comments to D25698: New query mechanism for applications: KApplicationTrader.
Dec 2 2019, 9:55 PM · Frameworks
dhaumann committed R40:4003304a4d13: Merge branch 'fix-translation' into release/19.12 (authored by dhaumann).
Merge branch 'fix-translation' into release/19.12
Dec 2 2019, 9:15 PM
dhaumann committed R40:f65192bbe6a6: Fix translation of external tools (authored by dhaumann).
Fix translation of external tools
Dec 2 2019, 8:46 PM
dhaumann committed R40:df460443bf6e: Fix: Do not translate KActionCollection identifier (authored by dhaumann).
Fix: Do not translate KActionCollection identifier
Dec 2 2019, 8:35 PM

Nov 26 2019

dhaumann added a comment to D25493: EBN kmoretools cleanup transport protocol.

@jhayes Do you have commit access, or shall I commit this for you?

Nov 26 2019, 10:47 PM · Frameworks
dhaumann added a comment to D23457: Port the search interface from QRegExp to QRegularExpression.

Any news here?

Nov 26 2019, 10:45 PM · Frameworks, Kate
dhaumann added a comment to D24982: Small improvements in some XML files.

I think we should decide what to do with this patch, as over time it will get merge conflicts.

Nov 26 2019, 10:42 PM · Frameworks, Kate

Nov 24 2019

dhaumann committed R304:c8fa3ab044cb: Make KF6 cleanup work visible (authored by dhaumann).
Make KF6 cleanup work visible
Nov 24 2019, 6:03 PM
dhaumann closed D25508: Make KF6 cleanup work visible.
Nov 24 2019, 6:03 PM · Frameworks
dhaumann renamed T12244: Move enum KSyntaxHighlighting::TextStyles from KSyntaxHighlighting Text Styles to Move enum KSyntaxHighlighting::TextStyles.
Nov 24 2019, 5:57 PM · KF6
dhaumann created T12244: Move enum KSyntaxHighlighting::TextStyles.
Nov 24 2019, 5:56 PM · KF6
dhaumann created T12243: KSyntaxHighlighting: Expose context in highlighting functions.
Nov 24 2019, 5:41 PM · KF6
dhaumann requested review of D25508: Make KF6 cleanup work visible.
Nov 24 2019, 5:12 PM · Frameworks
dhaumann added a comment to D25503: JavaScript: move keywords from TypeScript and other improvements.

I think this is ok.

Nov 24 2019, 2:37 PM · Frameworks, Kate
dhaumann accepted D25493: EBN kmoretools cleanup transport protocol.
Nov 24 2019, 7:03 AM · Frameworks
dhaumann added a comment to D17595: Upstream Dolphin's file rename dialog.

I received the agreements of all contributors including the original code author, to relicense this code and hence upstream it.

Nov 24 2019, 7:01 AM · Frameworks

Nov 23 2019

dhaumann added a comment to D25485: Remove KIconThemes use.

Makes sense, thanks.

Nov 23 2019, 9:51 AM · Kate, Frameworks

Nov 22 2019

dhaumann accepted D25465: [DropJob] Minor grammar fix in API docs.

Lgtm.

Nov 22 2019, 4:48 PM · Frameworks

Nov 19 2019

dhaumann added inline comments to D25276: reStructuredText: Fix inline literals highlighting preceding characters.
Nov 19 2019, 8:44 PM · Frameworks, Kate

Nov 16 2019

dhaumann added a comment to D25328: Always rehiglhight() after definition was changed.

Can't you call rehighlight() yourself after calling setDefinition()?

Nov 16 2019, 6:09 PM · Frameworks, Kate
dhaumann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

You can force the current clang format to keep the multi-line if as follows:

Nov 16 2019, 8:03 AM · Build System, Frameworks

Nov 11 2019

dhaumann committed R40:b99cceb1f7f4: Merge branch 'add-json-xml-formatters' into 'master' (authored by dhaumann).
Merge branch 'add-json-xml-formatters' into 'master'
Nov 11 2019, 8:56 PM

Nov 10 2019

dhaumann updated subscribers of T11864: Integrate KQuickSyntaxHighlighter into KSyntaxHighlighting.

@hein: Could you add a commit that relicenses all code to MIT? We switched to MIT for entire KSyntaxHighlighting. This will ease integration later.

Nov 10 2019, 9:10 PM · KF6
dhaumann accepted D25232: kate: port away from deprecated methods in KWindowSystem >= 5.62.

Thanks, please commit! PS: Kate is also on gitlab: When pushing your branch to KDE's kate.git, the git push output will tell you how to create the merge request. But you can push directly as well, if you want.

Nov 10 2019, 2:18 PM · Kate

Oct 31 2019

dhaumann added a comment to T11535: Organize 2019 KF6 sprint.

Also can't make it.

Oct 31 2019, 6:59 PM · KF6