- User Since
- Apr 20 2015, 7:20 AM (144 w, 6 h)
@davidedmundson If the associated bug is fixed, it should be closed.
Sat, Jan 20
+1, but someone else must approve.
Tue, Jan 16
I would prefer if you commit this soon, since then we still have 3 weeks for testing.
To me this look ok, but I cannot say whether there are side-effects or not.
Mon, Jan 15
@dfaure Can we provide an update to KWidgetAddons? Is this feasible? If not, we should at least announce this bug on email@example.com, since this breaks Kate.
Sun, Jan 14
I have the same issue. I saw things like this before, not sure whether Kate really picks up the correct plugins. Maybe it's messed up with the plugins from the stable system.
Sat, Jan 13
I would like to add another todo item to the list: All new contributors (e.g. the ones who committed a patch for the first time within the last year) should get a personal email, asking them to please attend the KDE conference. I think Akademy is an integral part of holding people together. As such, we need to push those a bit who are unsure (I was in this situation myself in 2004).
Thu, Jan 11
It's the same for me - I'll revert for now, since this seems to entirely break Kate's terminal toolview.
Wed, Jan 3
Ok, good :)
Tue, Jan 2
Hi all, I regularly stumble over this issue again and again. In fact, I would like to give especially first-time contributors the correct authorship (git commit --author="..."). But I cannot, since the email address is hidden. This is *really* cumbersome, and in fact kind of breaks my workflow. In the end, I mostly claim the work by others for myself, just to get work done. This is not how it should be ideally :-)
Btw, I just posed on kde-core-devel to find out how to get email addressed on phabricator: https://marc.info/?l=kde-core-devel&m=151492773414285&w=2
What I now did is:
- copy the link behind "Download Raw Diff" in the top right
- in the terminal, I cd'ed into kate.git, and typed: wget https://phabricator.kde.org/file/data/dvyfeaphmpg6urfgoip2/PHID-FILE-zw34xdqxdltejw3t56wf/D9590.diff
- I applied the patch, typing:
The search depth option was removed. Kate will simply ALWAYS search, no way afaik to turn it off anymore. Noone complained so far, afaik.
I'll give some hints of what I did:
- you gave me the hint to src/kde/applications/dolphin/src/panels/terminal/terminalpanel.cpp@167
- I checked out the dolphin git repo
- went to the terminal folder, and typed: git annotate terminalplane.cpp <enter>, and went to line 167
- This tells me Peter Penz, but it's not yet sure he was really the initial author.
- then I entered: git log -S "kill(processId, SIGINT);"
- essentially, this command shows me ALL commits with changed lines that contain the string "kill(processId, SIGINT);"
- It shows 2 commits, both from Peter Penz.
- I copied the sha 14d5a32475ef646e51f6750a80f216020b648039 and entered in the github search, which gives 3 code matches.
Looks good, I just suggest two minor changes, see below. Thanks for the additions!
Without looking too much into details of the patch: what happens, if you are already root? Does that work as expected?
Mon, Jan 1
First, thanks for this patch - it makes a lot of sense. And congratulations you worked through most of the KDE infrastructure (accounts, phabricator, arc, git, ...).
Sun, Dec 31
Sat, Dec 30
Sun, Dec 24
Good enough :)
Sat, Dec 23
What happens, if you edit several remove documents and switch a lot.
Will this "spam" the current view with the info message again and again?
Dec 21 2017
@neundorf Did you try the patch? Or anyone else? I would like to get this right instead of having yet another solution that is not good enough.
Dec 18 2017
That could very well be the case. Another possibility would be to simply show an icon, like Qt Creator does it.
- Avoid queuing messages if F3 is continuously pressed
Example for a wrapping search at bottom, continuing at top:
- Add @since 5.42
@cullmann This patch now only adds the CenterInView, nothing else (i.e. no changes in search code). Now good to go?
Abandoned in favor of followup request: https://phabricator.kde.org/D9393
@dfaure Better push today than one day before release. ;)
Dec 17 2017
- ContextChecker::check(): use 'success' bool correctly (was unused before)
- remove m_ for member variables in the Language helper class
- turn firstContext into a bool and immediately add the first context to the usedContextList
Dec 16 2017
Dec 14 2017
From my side this looks good. A second OK is always better, but I'd be OK if you go ahead. Thanks for the ping!
Dec 11 2017
Looks good to me. I don't think a backport is really necessary, or?
- Honor spacing for message widgets
- Remove unneeded include
- Simplify MessageWidget member variable handling
@cullmann Did you intentionally request changes or was that by accident and you meant Accept?
@mwolff I still would like to know from you whether you think this patch makes thinks better: I need additional helper functions etc. just to use the STL to avoid these allocs. Additional helper functions are added complexity, since it's not standard Qt stuff that everyone typically knows out of the box. That's why I am asking :-) So I for one see benefits and drawbacks ;)
Dec 10 2017
Btw: To update the reference, you can simply execute
Dec 8 2017
Well, the scripting commands are also available on the command line as commands, aren't they? So you could essentially call yourself.