dhaumann (Dominik Haumann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 20 2015, 7:20 AM (144 w, 6 h)
Availability
Available

Recent Activity

Yesterday

dhaumann added a comment to D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function).

@davidedmundson If the associated bug is fixed, it should be closed.

Sun, Jan 21, 7:36 AM · Frameworks

Sat, Jan 20

dhaumann added a reviewer for D9997: [Build Addon] Use system’s fixed font for output page: sars.
Sat, Jan 20, 8:27 PM · Kate
dhaumann added a comment to D9987: Lessen log spam by not checking for existence of file with empty name.

+1, but someone else must approve.

Sat, Jan 20, 8:07 AM · Frameworks

Tue, Jan 16

dhaumann added a comment to D9766: Use at least the requested width for the argument hint tree.

I would prefer if you commit this soon, since then we still have 3 weeks for testing.
To me this look ok, but I cannot say whether there are side-effects or not.

Tue, Jan 16, 12:21 PM · Frameworks, Kate

Mon, Jan 15

dhaumann added a comment to D9590: Clear konsole command-line before directory change.

@michaelh The button issue was introduced in KWidgetAddons and is meanwhile fixed: https://phabricator.kde.org/D9884

Mon, Jan 15, 2:20 PM · Kate
dhaumann updated subscribers of D9884: KMultiTabBar: Fix regression in conversion to new style connect() .

@dfaure Can we provide an update to KWidgetAddons? Is this feasible? If not, we should at least announce this bug on kde-distro-packagers@kde.org, since this breaks Kate.

Mon, Jan 15, 2:14 PM · Frameworks

Sun, Jan 14

dhaumann added a comment to D9590: Clear konsole command-line before directory change.

I have the same issue. I saw things like this before, not sure whether Kate really picks up the correct plugins. Maybe it's messed up with the plugins from the stable system.

Sun, Jan 14, 1:32 PM · Kate

Sat, Jan 13

dhaumann added a comment to T7116: Streamlined onboarding of new contributors.

I would like to add another todo item to the list: All new contributors (e.g. the ones who committed a patch for the first time within the last year) should get a personal email, asking them to please attend the KDE conference. I think Akademy is an integral part of holding people together. As such, we need to push those a bit who are unsure (I was in this situation myself in 2004).

Sat, Jan 13, 2:45 PM · Goal settings 2017

Thu, Jan 11

dhaumann added 1 commit(s) for D9590: Clear konsole command-line before directory change: R40:6303cc4a0788: Revert "Clear konsole command-line before directory change".
Thu, Jan 11, 6:56 PM · Kate
dhaumann added an edge to R40:6303cc4a0788: Revert "Clear konsole command-line before directory change": D9590: Clear konsole command-line before directory change.
Thu, Jan 11, 6:56 PM
dhaumann added a comment to D9590: Clear konsole command-line before directory change.

Reverted, see https://commits.kde.org/kate/6303cc4a0788d84190db74951fc2db639456a8bc

Thu, Jan 11, 6:54 PM · Kate
dhaumann committed R40:6303cc4a0788: Revert "Clear konsole command-line before directory change" (authored by dhaumann).
Revert "Clear konsole command-line before directory change"
Thu, Jan 11, 6:54 PM
dhaumann added a reverting commit for R40:732f690534d8: Clear konsole command-line before directory change: R40:6303cc4a0788: Revert "Clear konsole command-line before directory change".
Thu, Jan 11, 6:54 PM
dhaumann added a comment to D9590: Clear konsole command-line before directory change.

It's the same for me - I'll revert for now, since this seems to entirely break Kate's terminal toolview.

Thu, Jan 11, 6:50 PM · Kate

Wed, Jan 3

dhaumann added a comment to D6831: Make use of kauth helper in methods of file ioslave.

Ok, good :)

Wed, Jan 3, 6:20 PM · Frameworks

Tue, Jan 2

dhaumann added a comment to T5242: Display user information so that others can land/amend a patch.

Hi all, I regularly stumble over this issue again and again. In fact, I would like to give especially first-time contributors the correct authorship (git commit --author="..."). But I cannot, since the email address is hidden. This is *really* cumbersome, and in fact kind of breaks my workflow. In the end, I mostly claim the work by others for myself, just to get work done. This is not how it should be ideally :-)

Tue, Jan 2, 9:23 PM · Phabricator
dhaumann added a comment to D9590: Clear konsole command-line before directory change.

Btw, I just posed on kde-core-devel to find out how to get email addressed on phabricator: https://marc.info/?l=kde-core-devel&m=151492773414285&w=2

Tue, Jan 2, 9:17 PM · Kate
dhaumann added a comment to D9590: Clear konsole command-line before directory change.

What I now did is:

  • copy the link behind "Download Raw Diff" in the top right
  • in the terminal, I cd'ed into kate.git, and typed: wget https://phabricator.kde.org/file/data/dvyfeaphmpg6urfgoip2/PHID-FILE-zw34xdqxdltejw3t56wf/D9590.diff
  • I applied the patch, typing:
Tue, Jan 2, 9:10 PM · Kate
dhaumann added a comment to D9616: update info about kateconfig file and extended options.

The search depth option was removed. Kate will simply ALWAYS search, no way afaik to turn it off anymore. Noone complained so far, afaik.

Tue, Jan 2, 9:01 PM · Kate
dhaumann added a comment to D9590: Clear konsole command-line before directory change.

I'll give some hints of what I did:

  • you gave me the hint to src/kde/applications/dolphin/src/panels/terminal/terminalpanel.cpp@167
  • I checked out the dolphin git repo
  • went to the terminal folder, and typed: git annotate terminalplane.cpp <enter>, and went to line 167
  • This tells me Peter Penz, but it's not yet sure he was really the initial author.
  • then I entered: git log -S "kill(processId, SIGINT);"
  • essentially, this command shows me ALL commits with changed lines that contain the string "kill(processId, SIGINT);"
  • It shows 2 commits, both from Peter Penz.
  • I copied the sha 14d5a32475ef646e51f6750a80f216020b648039 and entered in the github search, which gives 3 code matches.
Tue, Jan 2, 8:57 PM · Kate
dhaumann accepted D9616: update info about kateconfig file and extended options.

Looks good, I just suggest two minor changes, see below. Thanks for the additions!

Tue, Jan 2, 8:45 PM · Kate
dhaumann added a comment to D6831: Make use of kauth helper in methods of file ioslave.

Without looking too much into details of the patch: what happens, if you are already root? Does that work as expected?

Tue, Jan 2, 6:03 PM · Frameworks

Mon, Jan 1

dhaumann accepted D9590: Clear konsole command-line before directory change.

First, thanks for this patch - it makes a lot of sense. And congratulations you worked through most of the KDE infrastructure (accounts, phabricator, arc, git, ...).

Mon, Jan 1, 7:17 PM · Kate

Sun, Dec 31

dhaumann committed R39:225d774b5219: clang-tidy modernize-use-override (authored by dhaumann).
clang-tidy modernize-use-override
Sun, Dec 31, 5:19 PM
dhaumann closed D9571: clang-tidy modernize-use-override.
Sun, Dec 31, 5:18 PM · Frameworks, Kate

Sat, Dec 30

dhaumann committed R475:7a51f57c42c4: Apply clang-tidy readability-redundant-member-init (authored by dhaumann).
Apply clang-tidy readability-redundant-member-init
Sat, Dec 30, 10:27 PM
dhaumann committed R475:7749fd48554e: Apply clang-tidy modernize-use-override (authored by dhaumann).
Apply clang-tidy modernize-use-override
Sat, Dec 30, 10:27 PM
dhaumann committed R475:c279d9bb9bb8: Apply clang-tidy modernize-use-nullptr (authored by dhaumann).
Apply clang-tidy modernize-use-nullptr
Sat, Dec 30, 10:27 PM
dhaumann committed R39:eff6bd61e2d7: Fix wildcard matching for modelines (authored by dhaumann).
Fix wildcard matching for modelines
Sat, Dec 30, 8:32 PM
dhaumann closed D9569: Fix wildcard matching for modelines.
Sat, Dec 30, 8:32 PM · Frameworks, Kate
dhaumann added a reviewer for D9569: Fix wildcard matching for modelines: nalvarez.
Sat, Dec 30, 8:26 PM · Frameworks, Kate

Sun, Dec 24

dhaumann added inline comments to D9491: Sonnet: fix wrong language for suggestions in mixed-language texts.
Sun, Dec 24, 7:23 PM · Frameworks
dhaumann committed R216:79ca6ce4ec6a: Highlighting indexer: Warn about context switch fallthroughContext="#stay" (authored by dhaumann).
Highlighting indexer: Warn about context switch fallthroughContext="#stay"
Sun, Dec 24, 7:17 PM
dhaumann closed D9493: Highlighting indexer: Warn about context switch fallthroughContext="#stay".
Sun, Dec 24, 7:17 PM · Frameworks
dhaumann committed R216:d84035c61eac: Highlighting indexer: Warn about empty attributes (authored by dhaumann).
Highlighting indexer: Warn about empty attributes
Sun, Dec 24, 7:17 PM
dhaumann closed D9494: Highlighting indexer: Warn about empty attributes.
Sun, Dec 24, 7:17 PM · Frameworks
dhaumann accepted D9491: Sonnet: fix wrong language for suggestions in mixed-language texts.

Good enough :)

Sun, Dec 24, 11:59 AM · Frameworks

Sat, Dec 23

dhaumann added a comment to D9484: Use KTextEditor::Message in KateConsole::slotSync.

What happens, if you edit several remove documents and switch a lot.
Will this "spam" the current view with the info message again and again?

Sat, Dec 23, 10:00 PM · Kate
dhaumann created D9494: Highlighting indexer: Warn about empty attributes.
Sat, Dec 23, 9:20 PM · Frameworks
dhaumann created D9493: Highlighting indexer: Warn about context switch fallthroughContext="#stay".
Sat, Dec 23, 9:06 PM · Frameworks

Dec 21 2017

dhaumann added a comment to D9394: Show "Search wrapped" message in center of view for better visibility.

@neundorf Did you try the patch? Or anyone else? I would like to get this right instead of having yet another solution that is not good enough.

Dec 21 2017, 7:42 PM · Frameworks, Kate

Dec 18 2017

dhaumann added a comment to D9394: Show "Search wrapped" message in center of view for better visibility.

That could very well be the case. Another possibility would be to simply show an icon, like Qt Creator does it.

Dec 18 2017, 12:19 PM · Frameworks, Kate
dhaumann added reviewers for D9394: Show "Search wrapped" message in center of view for better visibility: kfunk, mwolff.
Dec 18 2017, 11:37 AM · Frameworks, Kate
dhaumann updated the diff for D9394: Show "Search wrapped" message in center of view for better visibility.
  • Avoid queuing messages if F3 is continuously pressed
Dec 18 2017, 11:34 AM · Frameworks, Kate
dhaumann added a comment to D9394: Show "Search wrapped" message in center of view for better visibility.

Example for a wrapping search at bottom, continuing at top:

Dec 18 2017, 11:23 AM · Frameworks, Kate
dhaumann created D9394: Show "Search wrapped" message in center of view for better visibility.
Dec 18 2017, 11:20 AM · Frameworks, Kate
dhaumann committed R39:fc7433321d36: MessageInterface: Add CenterInView as additional position (authored by dhaumann).
MessageInterface: Add CenterInView as additional position
Dec 18 2017, 11:04 AM
dhaumann closed D9393: MessageInterface: Add CenterInView as additional position.
Dec 18 2017, 11:04 AM · Frameworks, Kate
dhaumann updated the diff for D9393: MessageInterface: Add CenterInView as additional position.
  • Add @since 5.42
Dec 18 2017, 11:01 AM · Frameworks, Kate
dhaumann added a comment to D9393: MessageInterface: Add CenterInView as additional position.

@cullmann This patch now only adds the CenterInView, nothing else (i.e. no changes in search code). Now good to go?

Dec 18 2017, 10:52 AM · Frameworks, Kate
dhaumann abandoned D9257: MessageInterface: Add CenterInView as additional position.

Abandoned in favor of followup request: https://phabricator.kde.org/D9393

Dec 18 2017, 10:51 AM · Frameworks, Kate
dhaumann created D9393: MessageInterface: Add CenterInView as additional position.
Dec 18 2017, 10:50 AM · Frameworks, Kate
dhaumann added a comment to D9257: MessageInterface: Add CenterInView as additional position.

ping?

Dec 18 2017, 8:51 AM · Frameworks, Kate
dhaumann added a comment to D9217: KUriFilter: don't return an error on non-existing files..

@dfaure Better push today than one day before release. ;)

Dec 18 2017, 8:47 AM · Frameworks

Dec 17 2017

dhaumann committed R216:f521183c4cc2: Highlighting indexer: Enable errors (authored by dhaumann).
Highlighting indexer: Enable errors
Dec 17 2017, 2:42 PM
dhaumann closed D9377: Highlighting indexer: Enable errors.
Dec 17 2017, 2:42 PM · Frameworks
dhaumann created D9377: Highlighting indexer: Enable errors.
Dec 17 2017, 2:40 PM · Frameworks
dhaumann committed R216:6b9c12981391: Lilypond, MetaFont, RHTML: Fix missing/unused itemDatas (authored by dhaumann).
Lilypond, MetaFont, RHTML: Fix missing/unused itemDatas
Dec 17 2017, 2:33 PM
dhaumann closed D9375: Lilypond, MetaFont, RHTML: Fix missing/unused itemDatas.
Dec 17 2017, 2:33 PM · Frameworks
dhaumann committed R216:412f5a7e705c: Highlighting indexer: report unused itemDatas and missing itemDatas (authored by dhaumann).
Highlighting indexer: report unused itemDatas and missing itemDatas
Dec 17 2017, 2:33 PM
dhaumann closed D9374: Highlighting indexer: report unused itemDatas and missing itemDatas.
Dec 17 2017, 2:33 PM · Frameworks
dhaumann committed R216:9cdf1bee0dd3: Prolog, RelaxNG, RMarkDown: Fix highlighting issues (authored by dhaumann).
Prolog, RelaxNG, RMarkDown: Fix highlighting issues
Dec 17 2017, 2:33 PM
dhaumann closed D9376: Prolog, RelaxNG, RMarkDown: Fix highlighting issues.
Dec 17 2017, 2:33 PM · Frameworks
dhaumann created D9376: Prolog, RelaxNG, RMarkDown: Fix highlighting issues.
Dec 17 2017, 2:24 PM · Frameworks
dhaumann created D9375: Lilypond, MetaFont, RHTML: Fix missing/unused itemDatas.
Dec 17 2017, 2:03 PM · Frameworks
dhaumann created D9374: Highlighting indexer: report unused itemDatas and missing itemDatas.
Dec 17 2017, 2:02 PM · Frameworks
dhaumann committed R216:91ca8ca39f66: Haml: Fix invalid and unused itemDatas (authored by dhaumann).
Haml: Fix invalid and unused itemDatas
Dec 17 2017, 1:47 PM
dhaumann closed D9373: Haml: Fix invalid and unused itemDatas.
Dec 17 2017, 1:47 PM · Frameworks
dhaumann created D9373: Haml: Fix invalid and unused itemDatas.
Dec 17 2017, 1:44 PM · Frameworks
dhaumann committed R216:b80748a58293: ObjectiveC++: Remove duplicate comment contexts (authored by dhaumann).
ObjectiveC++: Remove duplicate comment contexts
Dec 17 2017, 1:36 PM
dhaumann closed D9372: ObjectiveC++: Remove duplicate comment contexts.
Dec 17 2017, 1:36 PM · Frameworks
dhaumann created D9372: ObjectiveC++: Remove duplicate comment contexts.
Dec 17 2017, 1:35 PM · Frameworks
dhaumann committed R216:da6d5a7cc33a: Diff, ObjectiveC++: Cleanups and fix highlighting files (authored by dhaumann).
Diff, ObjectiveC++: Cleanups and fix highlighting files
Dec 17 2017, 1:31 PM
dhaumann closed D9371: Diff, ObjectiveC++: Cleanups and fix highlighting files.
Dec 17 2017, 1:30 PM · Frameworks
dhaumann created D9371: Diff, ObjectiveC++: Cleanups and fix highlighting files.
Dec 17 2017, 1:27 PM · Frameworks
dhaumann committed R216:00cbdc0fdc7d: Stata highlighting: Remove unused itemData and fix non-existing attribute (authored by dhaumann).
Stata highlighting: Remove unused itemData and fix non-existing attribute
Dec 17 2017, 12:00 PM
dhaumann closed D9370: Stata highlighting: Remove unused itemData and fix non-existing attribute.
Dec 17 2017, 12:00 PM · Frameworks
dhaumann created D9370: Stata highlighting: Remove unused itemData and fix non-existing attribute.
Dec 17 2017, 11:58 AM · Frameworks
dhaumann committed R216:b58763275dfd: XML (Debug): Fix incorrect DetectChar rule (authored by dhaumann).
XML (Debug): Fix incorrect DetectChar rule
Dec 17 2017, 11:54 AM
dhaumann closed D9369: XML (Debug): Fix incorrect DetectChar rule.
Dec 17 2017, 11:54 AM · Frameworks
dhaumann created D9369: XML (Debug): Fix incorrect DetectChar rule.
Dec 17 2017, 11:52 AM · Frameworks
dhaumann committed R216:ec49a95d0959: Highlighting Indexer: Support cross-hl context checking (authored by dhaumann).
Highlighting Indexer: Support cross-hl context checking
Dec 17 2017, 11:43 AM
dhaumann closed D9361: Highlighting Indexer: Support cross-hl context checking.
Dec 17 2017, 11:43 AM · Frameworks
dhaumann updated the diff for D9361: Highlighting Indexer: Support cross-hl context checking.
  • ContextChecker::check(): use 'success' bool correctly (was unused before)
    • remove m_ for member variables in the Language helper class
    • turn firstContext into a bool and immediately add the first context to the usedContextList
Dec 17 2017, 11:40 AM · Frameworks

Dec 16 2017

dhaumann added a reviewer for D9361: Highlighting Indexer: Support cross-hl context checking: cullmann.
Dec 16 2017, 6:33 PM · Frameworks
dhaumann created D9361: Highlighting Indexer: Support cross-hl context checking.
Dec 16 2017, 6:32 PM · Frameworks

Dec 14 2017

dhaumann accepted D9217: KUriFilter: don't return an error on non-existing files..

From my side this looks good. A second OK is always better, but I'd be OK if you go ahead. Thanks for the ping!

Dec 14 2017, 11:01 AM · Frameworks

Dec 11 2017

dhaumann accepted D9291: Remove obsolete QScript includes from CMake files.

Looks good to me. I don't think a backport is really necessary, or?

Dec 11 2017, 10:41 PM · Kate
dhaumann committed R216:306959eb50b4: isocpp.xml: Extend unit test to check for GNU Macros (authored by dhaumann).
isocpp.xml: Extend unit test to check for GNU Macros
Dec 11 2017, 10:39 PM
dhaumann committed R216:5465008d5c6e: Revert: Add GNUMacros to gcc.xml again, used by isocpp.xml (authored by dhaumann).
Revert: Add GNUMacros to gcc.xml again, used by isocpp.xml
Dec 11 2017, 10:34 PM
dhaumann updated the diff for D9257: MessageInterface: Add CenterInView as additional position.
  • Honor spacing for message widgets
Dec 11 2017, 10:23 PM · Frameworks, Kate
dhaumann updated the diff for D9257: MessageInterface: Add CenterInView as additional position.
  • Remove unneeded include
Dec 11 2017, 10:18 PM · Frameworks, Kate
dhaumann updated the diff for D9257: MessageInterface: Add CenterInView as additional position.
  • Simplify MessageWidget member variable handling
Dec 11 2017, 10:16 PM · Frameworks, Kate
dhaumann added a comment to D9219: WIP: Extend Scripting API.

@cullmann Did you intentionally request changes or was that by accident and you meant Accept?

Dec 11 2017, 9:38 PM · Frameworks, Kate
dhaumann added a comment to D9211: Iterate over initializer_lists to avoid mem allocs.

@mwolff I still would like to know from you whether you think this patch makes thinks better: I need additional helper functions etc. just to use the STL to avoid these allocs. Additional helper functions are added complexity, since it's not standard Qt stuff that everyone typically knows out of the box. That's why I am asking :-) So I for one see benefits and drawbacks ;)

Dec 11 2017, 9:35 PM · Frameworks, Kate
dhaumann accepted D9283: Fix build with Qt < 5.7.
Dec 11 2017, 6:53 AM · Kate

Dec 10 2017

dhaumann added a comment to D8371: Support for underscores in numeric literals (Python 3.6).

Btw: To update the reference, you can simply execute

Dec 10 2017, 11:43 AM · Frameworks, Framework: Syntax Highlighting

Dec 8 2017

dhaumann created D9257: MessageInterface: Add CenterInView as additional position.
Dec 8 2017, 3:29 PM · Frameworks, Kate
dhaumann added a comment to D9247: Extend Scripting API to allow executing commands.

Well, the scripting commands are also available on the command line as commands, aren't they? So you could essentially call yourself.

Dec 8 2017, 11:31 AM · Frameworks, Kate
dhaumann updated the summary of D9247: Extend Scripting API to allow executing commands.
Dec 8 2017, 10:50 AM · Frameworks, Kate