dhaumann (Dominik Haumann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 20 2015, 7:20 AM (242 w, 4 d)
Availability
Available

Recent Activity

Wed, Dec 11

dhaumann accepted D25870: SELinux: add "glblub" keyword and update permissions list.
Wed, Dec 11, 2:07 PM · Frameworks, Kate
dhaumann accepted D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword.
Wed, Dec 11, 2:06 PM · Frameworks, Kate

Tue, Dec 10

dhaumann added a comment to D23457: Port regex search to QRegularExpression.

Personally, I am not convinced replacing \s with [ \t], and deviating from PCRE default behaviour is a good idea in this case.

Tue, Dec 10, 9:11 PM · Frameworks, Kate
dhaumann added a comment to D23457: Port regex search to QRegularExpression.

Was anything of the previously commented issues addressed?

Tue, Dec 10, 1:43 PM · Frameworks, Kate

Sun, Dec 8

dhaumann added a comment to D25805: Open/close and focus/defocus terminal using the same shortcuts as Dolphin.

Doesn't this patch imply we have the same action twice now? Once provided by Konsole, and once by katemdi via View > Tool Views > Show Terminal?

Sun, Dec 8, 10:56 PM · Kate

Fri, Dec 6

dhaumann added inline comments to D25767: KAutoSaveFile: add a unit test to check max. filename length.
Fri, Dec 6, 8:13 AM · Frameworks

Thu, Dec 5

dhaumann added a comment to D25755: Replace iterators with range-based for.

Do we dislike iterators now?

We don't, and they still make sense for when you need the key, but range for is just much nier to look at :)

I'm fine with that statement. But are we going to be reviewing changing all the KDE code from iterators to range for? Feels like an overkill to me.

Thu, Dec 5, 8:18 PM · Frameworks
dhaumann accepted D25770: Several enhancements to gitolite syntax definition..

Looks good. But does the highlighting work for RW+CD? I am wondering whether + needs to be added to the weakDeliminator list?

Thu, Dec 5, 8:06 PM · Frameworks, Kate

Wed, Dec 4

dhaumann added a comment to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.

You can achieve Dolphin's behavior by reassigning the F4 shortcut to View > Tool Views > Show/Hide Konsole. That's what I do since > 10 years, and it works perfectly. Why is it not the default? Maybe because this action does not exist by default (i.e. when the Konsole plugin is not loaded). But the right fix is to reassign the F4 shortcut to this action.

Wed, Dec 4, 3:50 PM · Goal: Consistency, Dolphin, Kate

Tue, Dec 3

dhaumann accepted D25276: reStructuredText: Fix inline literals highlighting preceding characters.

Ok

Tue, Dec 3, 6:59 AM · Frameworks, Kate

Mon, Dec 2

dhaumann added inline comments to D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader.
Mon, Dec 2, 9:55 PM · Frameworks
dhaumann committed R40:4003304a4d13: Merge branch 'fix-translation' into release/19.12 (authored by dhaumann).
Merge branch 'fix-translation' into release/19.12
Mon, Dec 2, 9:15 PM
dhaumann committed R40:f65192bbe6a6: Fix translation of external tools (authored by dhaumann).
Fix translation of external tools
Mon, Dec 2, 8:46 PM
dhaumann committed R40:df460443bf6e: Fix: Do not translate KActionCollection identifier (authored by dhaumann).
Fix: Do not translate KActionCollection identifier
Mon, Dec 2, 8:35 PM

Tue, Nov 26

dhaumann added a comment to D25493: EBN kmoretools cleanup transport protocol.

@jhayes Do you have commit access, or shall I commit this for you?

Tue, Nov 26, 10:47 PM · Frameworks
dhaumann added a comment to D23457: Port regex search to QRegularExpression.

Any news here?

Tue, Nov 26, 10:45 PM · Frameworks, Kate
dhaumann added a comment to D24982: Small improvements in some XML files.

I think we should decide what to do with this patch, as over time it will get merge conflicts.

Tue, Nov 26, 10:42 PM · Frameworks, Kate

Sun, Nov 24

dhaumann committed R304:c8fa3ab044cb: Make KF6 cleanup work visible (authored by dhaumann).
Make KF6 cleanup work visible
Sun, Nov 24, 6:03 PM
dhaumann closed D25508: Make KF6 cleanup work visible.
Sun, Nov 24, 6:03 PM · Frameworks
dhaumann renamed T12244: Move enum KSyntaxHighlighting::TextStyles from KSyntaxHighlighting Text Styles to Move enum KSyntaxHighlighting::TextStyles.
Sun, Nov 24, 5:57 PM · KF6
dhaumann created T12244: Move enum KSyntaxHighlighting::TextStyles.
Sun, Nov 24, 5:56 PM · KF6
dhaumann created T12243: KSyntaxHighlighting: Expose context in highlighting functions.
Sun, Nov 24, 5:41 PM · KF6
dhaumann requested review of D25508: Make KF6 cleanup work visible.
Sun, Nov 24, 5:12 PM · Frameworks
dhaumann added a comment to D25503: JavaScript: move keywords from TypeScript and other improvements.

I think this is ok.

Sun, Nov 24, 2:37 PM · Frameworks, Kate
dhaumann accepted D25493: EBN kmoretools cleanup transport protocol.
Sun, Nov 24, 7:03 AM · Frameworks
dhaumann added a comment to D17595: Upstream Dolphin's file rename dialog.

I received the agreements of all contributors including the original code author, to relicense this code and hence upstream it.

Sun, Nov 24, 7:01 AM · Frameworks

Sat, Nov 23

dhaumann added a comment to D25485: Remove KIconThemes use.

Makes sense, thanks.

Sat, Nov 23, 9:51 AM · Kate, Frameworks

Fri, Nov 22

dhaumann accepted D25465: [DropJob] Minor grammar fix in API docs.

Lgtm.

Fri, Nov 22, 4:48 PM · Frameworks

Tue, Nov 19

dhaumann added inline comments to D25276: reStructuredText: Fix inline literals highlighting preceding characters.
Tue, Nov 19, 8:44 PM · Frameworks, Kate

Sat, Nov 16

dhaumann added a comment to D25328: Always rehiglhight() after definition was changed.

Can't you call rehighlight() yourself after calling setDefinition()?

Sat, Nov 16, 6:09 PM · Frameworks, Kate
dhaumann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

You can force the current clang format to keep the multi-line if as follows:

Sat, Nov 16, 8:03 AM · Build System, Frameworks

Nov 11 2019

dhaumann committed R40:b99cceb1f7f4: Merge branch 'add-json-xml-formatters' into 'master' (authored by dhaumann).
Merge branch 'add-json-xml-formatters' into 'master'
Nov 11 2019, 8:56 PM

Nov 10 2019

dhaumann updated subscribers of T11864: Integrate KQuickSyntaxHighlighter into KSyntaxHighlighting.

@hein: Could you add a commit that relicenses all code to MIT? We switched to MIT for entire KSyntaxHighlighting. This will ease integration later.

Nov 10 2019, 9:10 PM · KF6
dhaumann accepted D25232: kate: port away from deprecated methods in KWindowSystem >= 5.62.

Thanks, please commit! PS: Kate is also on gitlab: When pushing your branch to KDE's kate.git, the git push output will tell you how to create the merge request. But you can push directly as well, if you want.

Nov 10 2019, 2:18 PM · Kate

Oct 31 2019

dhaumann added a comment to T11535: Organize 2019 KF6 sprint.

Also can't make it.

Oct 31 2019, 6:59 PM · KF6

Oct 29 2019

dhaumann added a comment to D25054: Add string escape characters to PowerShell syntax..

Looks good to me.

Oct 29 2019, 9:34 PM · Frameworks, Kate
dhaumann accepted D25054: Add string escape characters to PowerShell syntax..

Please commit.

Oct 29 2019, 6:54 PM · Frameworks, Kate

Oct 28 2019

dhaumann added a comment to D24982: Small improvements in some XML files.

Hm right... too bad. I was hoping to find an automated way to detect this. Since relying on the user to optimize the RegExps will always be suboptimal. @cullmann Do you have any ideas?

Oct 28 2019, 9:31 PM · Frameworks, Kate
dhaumann added a comment to D24983: KateModeMenuList: improve word wrap.

Good, fine with me.

Oct 28 2019, 3:38 PM · Frameworks, Kate
dhaumann added a comment to D24982: Small improvements in some XML files.

[...]
One option would be to add a capture or dontCapture attribute to enable or disable captures for RegExpr rules. Also, captures could be enabled or disabled in all RegExpr rules using the <general> group, adding an element for that.

Oct 28 2019, 3:34 PM · Frameworks, Kate

Oct 27 2019

dhaumann accepted D24983: KateModeMenuList: improve word wrap.

It's hard to review all the pixel changes with no screenshots. It's even unclear to me what problem exactly is fixed at hand. Given it's all your code, I trust you know what you are doing...

Oct 27 2019, 4:45 PM · Frameworks, Kate
dhaumann added a comment to D24982: Small improvements in some XML files.

I wonder if the ?: optimizations make sense. QRegularExpression has the option QRegularExpression::DontCaptureOption to not capture anything. Looking into our code we have:

Oct 27 2019, 4:32 PM · Frameworks, Kate
dhaumann accepted D24981: Modelines: fix end of comment.
Oct 27 2019, 1:26 PM · Frameworks, Kate

Oct 25 2019

dhaumann accepted D24939: Meson: more built-in functions and add built-in member functions.

Looks good to me, thanks!

Oct 25 2019, 5:43 AM · Frameworks, Kate

Oct 20 2019

dhaumann accepted D24620: Windows MSVC compile fix.

Imo we should simply try: We have another two weeks for testing.

Oct 20 2019, 7:32 PM · Frameworks

Oct 19 2019

dhaumann committed R40:1fbfc2a37879: Merge branch 'update-docs' into 'master' (authored by dhaumann).
Merge branch 'update-docs' into 'master'
Oct 19 2019, 8:20 PM
dhaumann committed R40:b520021b1771: Update documentation of highlight & RegExp (authored by nibags).
Update documentation of highlight & RegExp
Oct 19 2019, 8:19 PM

Oct 12 2019

dhaumann added a comment to T9585: Publish Okteta in the Microsoft Store.

@kossebau Just tried Okteta on Windows that is available on https://binary-factory.kde.org/job/Okteta_Nightly_win64/ and it works really well, out of the box. I believe it really has a lot of value making Okteta more visible, especially since users on Windows would also use it on Linux.

Oct 12 2019, 7:23 PM · Windows
dhaumann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

I'm all for it. This would unify how we can reformat any KDE module, which is very much desirable.

Oct 12 2019, 7:30 AM · Build System, Frameworks
dhaumann accepted D24578: Meson: Add a comment section for comment/uncomment with Kate.

Please increase the version number and commit.

Oct 12 2019, 7:12 AM · Frameworks, Kate
dhaumann accepted D24575: Updates from CMake 3.16.

Thanks for the quick update.

Oct 12 2019, 7:10 AM · Frameworks, Kate

Oct 10 2019

dhaumann moved T10319: Ideas for External Tools from Backlog to Done on the Kate board.

The External Tools plugin is done for now. I would like to wait a bit to get feedback, and over time we can certainly add more default tools, or even extend the plugin with additional functionality.

Oct 10 2019, 8:38 AM · Kate
dhaumann moved T10281: Create an "Outline View" from Backlog to Done on the Kate board.

I believe work should be invested into the LSP client, since it provides an outline as well. Over time, the language servers will get better and better, so you'll get all this for free.

Oct 10 2019, 8:37 AM · Kate
dhaumann moved T10249: Revive External Tools Plugin from In Progress to Done on the Kate board.
Oct 10 2019, 8:34 AM · Kate

Oct 8 2019

dhaumann added inline comments to D20532: Proof of Concept: Add double click actions to empty space in the folder view.
Oct 8 2019, 6:10 AM · Dolphin

Oct 7 2019

dhaumann committed R40:1e3ed83667b3: External Tools: Fix accelerators and label buddys (authored by dhaumann).
External Tools: Fix accelerators and label buddys
Oct 7 2019, 8:59 PM
dhaumann committed R40:d10af90957bf: External Tools: Fix translation of empty name/category (authored by dhaumann).
External Tools: Fix translation of empty name/category
Oct 7 2019, 8:59 PM
dhaumann added a comment to D24443: Add a plugin system.

I'd go for a QVector for now. Arguing with Qt6 doesn't sound convincing to me, since Qt6 will take another>=1 year(s). So why try this experiment in public API now? :)

Oct 7 2019, 6:45 AM · KDE PIM

Oct 6 2019

dhaumann added a comment to T9584: Publish Kile in the Microsoft Store.

I've checked to today and it seems that a few small regressions have appeared over the last months in Kile for Windows - I will need to iron them out first over the next weeks.

Oct 6 2019, 7:52 PM · Kile, Windows

Oct 4 2019

dhaumann added inline comments to D24415: Add standard icons to support to all entries in QDialogButtonBox.
Oct 4 2019, 9:49 PM · Frameworks
dhaumann accepted D24403: Small performance improvements suggested by clang-tidy.

I also think it's fine. A next patch could convert the QRegExp to a QRegularExpression.

Oct 4 2019, 9:31 PM · Frameworks, Kate
dhaumann committed R40:6d62b347a284: External Tool Dialog: Forgot to also reset Name and Icon (authored by dhaumann).
External Tool Dialog: Forgot to also reset Name and Icon
Oct 4 2019, 6:08 PM
dhaumann committed R40:9b151a96fb28: External Tools: Add "Defaults" button to tool dialog for factory tools (authored by dhaumann).
External Tools: Add "Defaults" button to tool dialog for factory tools
Oct 4 2019, 5:53 PM
dhaumann committed R40:54e70216cfca: External Tools: User KUrlRequester instead of LineEdit + Button (authored by dhaumann).
External Tools: User KUrlRequester instead of LineEdit + Button
Oct 4 2019, 5:16 PM
dhaumann accepted D24404: Small performance improvements suggested by clang-tidy.
Oct 4 2019, 4:08 PM · Frameworks, Kate
dhaumann committed R40:53a8f89bfd66: External Tools: Translate name and category (authored by dhaumann).
External Tools: Translate name and category
Oct 4 2019, 1:50 PM
dhaumann accepted D24354: Mustache/Handlebars: minor fixes.
Oct 4 2019, 6:35 AM · Frameworks, Kate

Oct 3 2019

dhaumann accepted D24399: Pass QDir by const & instead of copy.
Oct 3 2019, 8:46 PM · Frameworks
dhaumann added a comment to D13541: Port solid from Qt5::Widgets to Qt5::Gui.

@graesslin pong? One year passed.

Oct 3 2019, 7:28 PM · Frameworks
dhaumann added a comment to D24378: WordDetect rule: detect delimiters at the inner edge of the string.

I think it's fine as is. The docbook says:

Oct 3 2019, 7:26 PM · Frameworks, Kate
dhaumann committed R39:eb4113d70e20: Variable expansion: Use std::function internally (authored by dhaumann).
Variable expansion: Use std::function internally
Oct 3 2019, 5:28 PM
dhaumann committed R40:e6ce67e02d96: Projects Plugin: Support variables %{Project:Path} and %{Project:NativePath} (authored by dhaumann).
Projects Plugin: Support variables %{Project:Path} and %{Project:NativePath}
Oct 3 2019, 4:52 PM
dhaumann added a comment to D24378: WordDetect rule: detect delimiters at the inner edge of the string.

This looks good to me and as mentioned in D24354 WordDetect is better than RegExpr.

Oct 3 2019, 11:23 AM · Frameworks, Kate
dhaumann accepted D24326: Add syntax highlighting for RenPy (.rpy).
Oct 3 2019, 6:07 AM · Frameworks, Kate
dhaumann added a comment to D24354: Mustache/Handlebars: minor fixes.

Thanks a lot!

Oct 3 2019, 6:01 AM · Frameworks, Kate
dhaumann accepted D24371: [KCM] Make the warning message wider.

Makes a lot of sense and looks visually good in the screenshot. I'm taking the liberty to give a +2.

Oct 3 2019, 5:59 AM · Plasma
dhaumann added a comment to D24370: [KCM] Display scale factor as a percentage, not a decimal.

+1. This is also in line with typical zoom factors in other applications such as Okular, which also use percent values.

Oct 3 2019, 5:57 AM · Plasma

Oct 2 2019

dhaumann added a comment to D24354: Mustache/Handlebars: minor fixes.

Hm, would it make sense to change this? I.e. if the word itself has a word boundary, also use this?

Oct 2 2019, 10:37 AM · Frameworks, Kate
dhaumann added a comment to D24354: Mustache/Handlebars: minor fixes.

Would it also be an option to fix WordDetect? I always thought WordDetect ignores the string contents, it should only check on the boundaries left and right

Oct 2 2019, 9:47 AM · Frameworks, Kate
dhaumann added a comment to D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox.

Thanks Nate for the update, I think this is very transparent to users and makes using bad values by default a bit harder.

Oct 2 2019, 5:33 AM · Plasma

Oct 1 2019

dhaumann added a comment to D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox.

As far as I understand, the reasoning of @cullmann is that 0.1 cannot be accurately be represented by a computer. Following this discussion, the number 0.1 will turn into either 0.09999999999999999167332731531132594682276248931884765625 or 0.1000000000000000055511151231257827021181583404541015625.

Oct 1 2019, 8:52 PM · Plasma

Sep 30 2019

dhaumann committed R40:b25b6ce93afa: External Tools: Increase ui.rc version counter (authored by dhaumann).
External Tools: Increase ui.rc version counter
Sep 30 2019, 5:36 PM
dhaumann committed R40:2fa70b7fa2f6: External Tools: Fix translation domain (authored by dhaumann).
External Tools: Fix translation domain
Sep 30 2019, 5:36 PM

Sep 29 2019

dhaumann committed R40:c5b8abf0e3a5: Tab bar: use tab-close icon again (authored by dhaumann).
Tab bar: use tab-close icon again
Sep 29 2019, 1:28 PM
dhaumann committed R40:9d11544788ae: Merge branch 'hi-dpi-tabbar' into 'master' (authored by dhaumann).
Merge branch 'hi-dpi-tabbar' into 'master'
Sep 29 2019, 12:06 PM

Sep 28 2019

dhaumann added a comment to D24262: Modernize code: use range-based loops & algorithms in more places.

It's actually quite clear in my head, because I imagine the generated class. A captured variable in a lambda becomes a member variable. If it's a capture by value (which is what happens with [library]), it's a "plain value" member.
So

Sep 28 2019, 7:58 PM · Frameworks
dhaumann added inline comments to D24262: Modernize code: use range-based loops & algorithms in more places.
Sep 28 2019, 7:55 PM · Frameworks
dhaumann committed R40:75d1f59261d7: External tools: Skip unit tests if necessary (authored by dhaumann).
External tools: Skip unit tests if necessary
Sep 28 2019, 7:30 PM
dhaumann committed R40:1b48d07e2148: Tab bar: Fix close button in right-to-left layout (authored by dhaumann).
Tab bar: Fix close button in right-to-left layout
Sep 28 2019, 6:04 PM
dhaumann committed R40:77f8b4530c8d: Tab bar: Fix close button in right-to-left layout (authored by dhaumann).
Tab bar: Fix close button in right-to-left layout
Sep 28 2019, 5:48 PM
dhaumann added inline comments to D24262: Modernize code: use range-based loops & algorithms in more places.
Sep 28 2019, 6:19 AM · Frameworks
dhaumann added inline comments to D24261: Modernize code: use range-based for loop in more places.
Sep 28 2019, 6:11 AM · Frameworks

Sep 27 2019

dhaumann committed R40:ae3e2b3c5936: Enable -DQT_DISABLE_DEPRECATED_BEFORE=0x050d00 (authored by dhaumann).
Enable -DQT_DISABLE_DEPRECATED_BEFORE=0x050d00
Sep 27 2019, 1:03 PM
dhaumann committed R40:ea371461a755: Compile with -DQT_DISABLE_DEPRECATED_BEFORE=0x050d00 (authored by dhaumann).
Compile with -DQT_DISABLE_DEPRECATED_BEFORE=0x050d00
Sep 27 2019, 1:03 PM
dhaumann committed R40:63934fca756d: Disalow Qt's Q_FOREACH/foreach macros (authored by dhaumann).
Disalow Qt's Q_FOREACH/foreach macros
Sep 27 2019, 10:42 AM

Sep 26 2019

dhaumann accepted D24234: Fix minor typos.
Sep 26 2019, 6:55 AM
dhaumann accepted D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles.

Thanks

Sep 26 2019, 5:43 AM · Frameworks, Kate

Sep 25 2019

dhaumann added a comment to D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles.

I'd indeed prefer another/separate diff. :)

Sep 25 2019, 2:59 PM · Frameworks, Kate
dhaumann added inline comments to D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles.
Sep 25 2019, 8:47 AM · Frameworks, Kate
dhaumann added a comment to D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles.

There are also changes in other xml files. Are these intentional? E.g. the changes from WordDetect to RegExpr seem suspicious.

Sep 25 2019, 8:46 AM · Frameworks, Kate