dhaumann (Dominik Haumann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 20 2015, 7:20 AM (199 w, 6 d)
Availability
Available

Recent Activity

Yesterday

dhaumann added a comment to D18997: Add functions returning all definitions for a mimetype or file name.

Ping?

Sat, Feb 16, 8:18 PM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann added a comment to D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths.

This looks reasonable, but could we get some Qt/KDE style CamelCase enum values?

enum SaveResult {

    SAVE_FAILED = 0,
    SAVE_NO_PERMS,
    SAVE_SUCCESS
};
Sat, Feb 16, 8:10 PM · Frameworks, Kate
dhaumann added a comment to D17599: Confirm closing muliple tabs..

Ok, finally we all seem to agree on my concerns. Personally, I think we should reject this feature and close the associated bug as won't-fix with a nice explanation that we tried but it does not really work... Not all wishes from users make sense, we simply cannot please everyone.

Sat, Feb 16, 8:04 PM · Kate

Thu, Feb 14

dhaumann added inline comments to D18997: Add functions returning all definitions for a mimetype or file name.
Thu, Feb 14, 1:00 PM · Frameworks, Framework: Syntax Highlighting, Kate

Wed, Feb 13

dhaumann added a comment to D18982: prevent assertion in regex load.

I think that makes a lot of sense. Maybe we should even always print the warning, not only in debug mode? See comment below...

Wed, Feb 13, 3:24 PM · Frameworks, Kate

Mon, Feb 11

dhaumann committed R216:54ac6d34a339: AsciiDoc: Add folding for sections (authored by dhaumann).
AsciiDoc: Add folding for sections
Mon, Feb 11, 9:50 PM
dhaumann closed D18895: AsciiDoc: Add folding for sections.
Mon, Feb 11, 9:50 PM · Frameworks, Kate
dhaumann accepted D18895: AsciiDoc: Add folding for sections.

I think this change is ok. Although, adding many RegExprs is slow compared to other rules.

Mon, Feb 11, 7:00 AM · Frameworks, Kate
dhaumann accepted D18864: FlatBuffers schema syntax highlighting.
Mon, Feb 11, 6:16 AM · Frameworks, Kate

Sun, Feb 10

dhaumann updated subscribers of D18894: [RFC] General config interface.

This approach spreads they key "Word Wrap Column" across many files. You have to know the key and avoid typos. Currently we have this hard-coded and therefore statically checked by the compiler, which is very good.

Sun, Feb 10, 1:59 PM · Frameworks, Kate
dhaumann added inline comments to D18883: Add PDF thumbnailer.
Sun, Feb 10, 8:39 AM · Frameworks, Dolphin
dhaumann added a comment to D18891: Avoid leaking a QObject in ExternalExtractor.

ThT looks reasonable, if ExtractorPlugin even has QObject * parent = nullptr I'd even remove nullptr as well.

Sun, Feb 10, 8:30 AM · Baloo, Frameworks

Sat, Feb 9

dhaumann accepted D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e).

I think it's ok, although it is arguably whether this improves anything. Still, let's move on.

Sat, Feb 9, 9:13 PM · Frameworks, Kate

Fri, Feb 8

dhaumann accepted D18864: FlatBuffers schema syntax highlighting.

Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file for unit testing? It can be short, is not required to make sense, and best is also MIT licensed.

Fri, Feb 8, 10:31 PM · Frameworks, Kate
dhaumann added a comment to D18846: allow to compile without Q_FOREACH support.

Btw, could we add a cmake definition to disallow foreach?

Fri, Feb 8, 10:15 PM · Frameworks, Kate
dhaumann accepted D18846: allow to compile without Q_FOREACH support.
Fri, Feb 8, 12:15 PM · Frameworks, Kate

Wed, Feb 6

dhaumann added a comment to D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e).

I am with Kåre here: this change does not fix any issue nor does it improve the current state significantly. In fact, there is a risk of introducing a regression by removing the accept/reject calls.

Wed, Feb 6, 9:19 PM · Frameworks, Kate

Tue, Feb 5

dhaumann added a comment to D18117: DocManager: Don't show load trouble popup messages .

I get the following error when applying the patch:

Tue, Feb 5, 12:36 PM · Kate
dhaumann updated the summary of D18163: Set the color scheme to Printing for Print Preview.
Tue, Feb 5, 12:32 PM · Frameworks, Kate
dhaumann committed R39:574b08d08111: Add TODO KF6 note (authored by dhaumann).
Add TODO KF6 note
Tue, Feb 5, 12:31 PM
dhaumann committed R39:28e59740d070: Set the color scheme to Printing for Print Preview (authored by ahmadsamir).
Set the color scheme to Printing for Print Preview
Tue, Feb 5, 12:31 PM
dhaumann closed D18116: Add TODO KF6 note .
Tue, Feb 5, 12:31 PM · Frameworks, Kate
dhaumann closed D18163: Set the color scheme to Printing for Print Preview.
Tue, Feb 5, 12:31 PM · Frameworks, Kate
dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Merge branch 'master' into revive-externaltools-plugin
  • Improve messaging and toolview handling
  • Cleanup: Remove tool parameter from addToolStatus()
Tue, Feb 5, 8:49 AM · Kate

Mon, Feb 4

dhaumann added a comment to D18734: Update octave.xml to Octave 4.2.0.

...And there are also new Default Styles for kateversion="5.0", see: https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/

Mon, Feb 4, 9:51 PM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann added a comment to D18734: Update octave.xml to Octave 4.2.0.

Could you also switch to WordDetect for the trivial cases, and set kateversion="5.0" ?

Mon, Feb 4, 9:47 PM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann added a comment to D17971: Revive External Tools plugin.
  • cursor position: Ok I agree, indeed I was stumbling over this as well. So blindly set it to the previous position, and if possible keep the scroll position.
  • default vs not default: The problem with default tools is always that we have no idea what users will want to do. Adding e.g. git-cola (which imho makes sense) likely does not help 95% of the users. Especially others like qmlscene preview are even more special. I am not yet convinced to have all these as defaults in the list. I would rather want to add a "External Tools > Configure" entry to make configuration more accessible.
  • cowsay: I see. Still, I think in most cases you need escaping. I can have a look again into what KShell::splitArgs() supports...
  • KateExternalTools::ScriptsPath: Hm... that sounds like a nice try of adding something, along the lines of "QuickCoding" that never worked for users. As soon as it gets more complicated, noone except me (who write this) will understand anymore. ...or you need much more UI, which yet has to be invented.
  • I like the idea of "Show as popup" or "Display as inline note". I was misunderstanding this first, though: For "Display as inline note" I first thought of the new InlineNoteInterface, but I think you are talking about KTextEditor::Message.
  • Variables/Qt Creator: Because I think some are confusing. E.g. CurrentDocument:Column is less clear to me than CurrentDocument:Cursor:Column. Further, Qt Creator uses CurrentDocument::Row, where I prefer "Line", so it's CurrentDocument:Cursor:Line. For CurrentDate, I changed to Date, since it's shorter and another Date than "Current" does not make sense at all anyways (you would hard-code it then). Well... in the end, it probably does not matter much.
  • XPos, YPos: Yes, you could start a tool at a specific position of the screen, making it look as if you have a context menu on the cursor position. E.g. kdialog --geometry... (seems to not work, though). But I think it could be useful (Qt Creator has it, too)
Mon, Feb 4, 9:37 PM · Kate
dhaumann committed R40:c68eabbb48b7: Port trivial cases of QRegExp to QRegularExpression (authored by dhaumann).
Port trivial cases of QRegExp to QRegularExpression
Mon, Feb 4, 9:16 PM
dhaumann committed R40:4de6b812d23b: Projects plugin: Properly support UTF-8 encoded umlauts in context menu (authored by dhaumann).
Projects plugin: Properly support UTF-8 encoded umlauts in context menu
Mon, Feb 4, 8:56 PM
dhaumann accepted D18116: Add TODO KF6 note .
Mon, Feb 4, 8:33 PM · Frameworks, Kate
dhaumann updated the summary of D17971: Revive External Tools plugin.
Mon, Feb 4, 7:28 PM · Kate
dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Remove checkbox "[ ] Include output from stderr" in favour of always displaying it in the Status pane, if existing
  • Use QTextDocument as model to decouple ui from data
  • Macro expansion: fix global XPos and YPos
  • Write output and stderr to QTextDocuments directly
  • Add 'external-tool-test', testing all macros
Mon, Feb 4, 7:24 PM · Kate
dhaumann added inline comments to D18116: Add TODO KF6 note .
Mon, Feb 4, 5:45 PM · Frameworks, Kate
dhaumann added a comment to D18714: Add some Maxima constans and function.

In your branch, you should type: arc land
This will merge your branch to master and commit/push your changes, and close this revision. This only works, if you have commit access. If not, we'll take care of this for now.

Mon, Feb 4, 5:42 PM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Fix margin of config page
  • Merge branch 'master' into revive-externaltools-plugin
  • Save & load enums manually instead of casting to int. This is more flexible once we change them
  • Register PluginView in Plugin, so that the PluginView for a MainWindow can be found
  • Start working on the tool view
  • Escape hides & deletes the tool view
  • Use toolview to report a crash
  • Working dir: if empty, use the current document's path
  • Pass also exitCode and crashed-flag in signal toolFinished()
  • API to clear & delete toolview
  • Expand empty working directory to current document URL only when URL is valid
  • Show output in toolview for "Display in Pane"
  • Better toolview handling (not perfect, yet)
  • Use fixed font for displaying output and status text
  • Implement new macro expansion (similar to Qt Creator)
  • Remove support for old macros
Mon, Feb 4, 4:07 PM · Kate
dhaumann added a comment to D17971: Revive External Tools plugin.
  • Output "Replace Current Document": works fine. Idea: restore cursor position after operation.
    • Given the document usually changed afterwards, "restoring the cursor position" is pretty much undefined, and almost never correct...
  • Display in Pane: Working on it
  • Make tools available by default: I don't want to clutter the user with hundreds of tools. That's why I proposed the "Template". In general, I am not a big fan of adding everything "just because we can".
  • Copy existing tool: Noted, makes sense
  • Working directory if empty: fixed
  • The leading triple slsahes are not wanted, need to do more QUrl voodoo
  • Auto quoting: Currently I use KShell::splitArgs(m_tool->arguments) to get a list that I can pass to the QProcess. I assumed that this is correct in mooooost of the cases. Do we really want to have manual work here? Where is your bug? ;)
  • ideas for later: git, select a branch: I don't have plans to extend a general purpose tool (external tools) into something that needs a lot of special handling. If you have a general purpose solution, fine, otherwise: wish rejected.
Mon, Feb 4, 1:54 PM · Kate
dhaumann added a comment to D17971: Revive External Tools plugin.

The following list is my current proposal of variables. These variables already vary from Qt Creator. Not everything else matches anyways:

Mon, Feb 4, 1:43 PM · Kate

Sun, Feb 3

dhaumann accepted D18714: Add some Maxima constans and function.

Looks good to me, the only missing part is to increase thw "version" number each time a highlighting file is changed.

Sun, Feb 3, 9:34 PM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann committed R40:975e89b0833a: Set margins of Terminal and File System Browser config widgets to 0 (authored by dhaumann).
Set margins of Terminal and File System Browser config widgets to 0
Sun, Feb 3, 1:57 PM
dhaumann added a comment to D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files.

Related bug report: https://bugs.kde.org/show_bug.cgi?id=403215

Sun, Feb 3, 8:43 AM · Frameworks, Kate

Sat, Feb 2

dhaumann added a comment to D17932: Improvements to completion.

Well, giving it a try and merge should be postponed ubtil tomorrow: dfaure tags today, so we would then have 1 month of internal testing.

Sat, Feb 2, 3:50 PM · Frameworks, Kate, KTextEditor
dhaumann added a comment to D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection".

In general I am ok eith this. Although it's a tiny bit less transparent to the user.

Sat, Feb 2, 10:19 AM · Frameworks, Kate

Fri, Feb 1

dhaumann added a comment to D17971: Revive External Tools plugin.

Btw, for the presets in the file 'externaltools' I have the following suggestion: Add "Presets >" with submenus to the Add button. The Add button would the contain:

  • Add Tool...
  • Add Preset > ...
  • <separator>
  • Add Category
Fri, Feb 1, 9:25 PM · Kate
dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Add some predefined tools (currently only in the file externaltool, not yet in the UI)
  • Change Add Tool to Add Tool... to indicate a dialog opens
  • SaveMode::CurrentDocument: Only save if modified to avoid unnecessary recompiles
  • KateToolRunner: Use std::unique_ptr to express ownership and avoid memleaks
  • Support [x] Reload current document after execution
  • Remove ToolItem and use QStandardItem everywhere, since Drag & Drop otherwise messes up the type
Fri, Feb 1, 9:19 PM · Kate

Thu, Jan 31

dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Use qWarning() for exitCode!=0 and crashes (suboptimal)
  • Translate warnings for failed tool runs
  • Command line: help <tool> shows "Starts the external tool <tool>"
  • Add some tools
    • gitk
    • git-cola
    • git blame
    • Google Selected Text
    • Execute current file in Shell
Thu, Jan 31, 9:14 PM · Kate
dhaumann added a comment to D17971: Revive External Tools plugin.

The plugin is progressing nicely. In fact, it's almost done and just a matter of polishing. I think it starts to be ready for testing.

Thu, Jan 31, 7:49 PM · Kate
dhaumann updated the summary of D17971: Revive External Tools plugin.
Thu, Jan 31, 7:40 PM · Kate
dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Use EditingTransaction for grouping undo/redo events
  • Implement OutputMode::InsertInNewDocument
Thu, Jan 31, 7:39 PM · Kate
dhaumann updated the test plan for D17971: Revive External Tools plugin.
Thu, Jan 31, 7:30 PM · Kate
dhaumann updated the diff for D17971: Revive External Tools plugin.

Work on tool runner:

  • Also macro expand Executable and Input
  • Pass KTextEditir::View to ToolRunner, since the view is needed later
  • Adapt unit test
  • KateToolRunner: API documentation
  • Start implementing output handling
Thu, Jan 31, 7:19 PM · Kate
dhaumann accepted D18163: Set the color scheme to Printing for Print Preview.

Now this looks good to me.

Thu, Jan 31, 5:39 PM · Frameworks, Kate
dhaumann updated the diff for D17971: Revive External Tools plugin.

Config Dialog almost done:

  • Config widget: edit on double click
  • Config Widget: Allow drag & drop to reorder and recategorize
  • Config Widget: Remove up & down buttons, drag & drop does the same
  • Config Widget: Make "Add" a popup menu with "Add Tool" and "Add Category"
  • Support adding new categories
  • Make sure new tool have unique action collection name
  • Track itemChanged signal to enabled "Apply" button
  • Remove code duplication for editing a tool
Thu, Jan 31, 4:38 PM · Kate

Wed, Jan 30

dhaumann committed R216:ab0b36345229: AsciiDoc: Fix highlighting of include directive (authored by dhaumann).
AsciiDoc: Fix highlighting of include directive
Wed, Jan 30, 9:41 PM
dhaumann closed D18617: AsciiDoc: Fix highlighting of include directive.
Wed, Jan 30, 9:41 PM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann accepted D18617: AsciiDoc: Fix highlighting of include directive.

Looks good to me. Please increase the "version" number whenever you change an highlighting file.

Wed, Jan 30, 9:38 PM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann committed R39:2d895143129c: Update JavaScript library underscore.js to version 1.9.1 (authored by dhaumann).
Update JavaScript library underscore.js to version 1.9.1
Wed, Jan 30, 6:19 PM
dhaumann added a comment to D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option.

Fixed: 5a6449c3b3d9bbc2b1bc15a5d5b40d7228f3a406

Wed, Jan 30, 4:53 PM · Frameworks, Kate
dhaumann committed R39:5a6449c3b3d9: Fix bug 403422: Allow changing the marker size again (authored by dhaumann).
Fix bug 403422: Allow changing the marker size again
Wed, Jan 30, 4:23 PM
dhaumann added a comment to D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option.

Unfortunately, the change in the .ui file introduced bug https://bugs.kde.org/show_bug.cgi?id=403422

Wed, Jan 30, 4:11 PM · Frameworks, Kate
dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Remove Q_GADGET, not needed
  • Make KateExternalTool::save() const
  • Add operator== for KateExternalTool, used for unit test
  • Return const ref
  • Config Widget: Start porting to QStandardItemModel
  • Move externaltools.h/cpp to KateExternalToolsView.h/cpp
  • Move KateExternalToolsPluginView to kateexternaltoolsview.h/cpp
  • Cleanup includes
  • Config dialog: set buddies and remove QDialogButtonBox connections, done in C++
  • Menu Action: Fix categorization
  • Config Dialog: Always provide valid tool, simplifies pointer handling
  • Tools Menu: Show categorized actions first, then uncategorized
  • Simplify load & save of external tools
  • External Tool: Add output modes
  • External tool: load & save "Reload current document after execution"
  • Config Widget: Fix loading tools twice
  • Config Widget: Expand all, show category Uncategorized always first
Wed, Jan 30, 3:15 PM · Kate

Tue, Jan 29

dhaumann added a comment to D18516: Fix end of folding region in rules with lookAhead=true.

Ok I see: this kind of reverts Christophs changes in the lookahead case.

Tue, Jan 29, 3:35 AM · Frameworks, Kate

Mon, Jan 28

dhaumann committed R216:de5fc35624d2: Add AsciiDoc support (authored by dhaumann).
Add AsciiDoc support
Mon, Jan 28, 9:47 PM
dhaumann closed D18475: Add AsciiDoc support.
Mon, Jan 28, 9:47 PM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann accepted D18475: Add AsciiDoc support.
  1. I apply your patch: arc patch D18475
  2. Since there is a new syntax highlighting file, I do: touch data/syntax-data.qrc.in
  3. I switch to the build directory, type make -j4 install
  4. I run the tests, some fail, since the reference of your test file is missing
  5. In the build folder, I run: ./autotests/update-reference-data.sh
  6. Now git status tells me there are several untracked files:
    • autotests/folding/asciidoc.adoc.fold
    • autotests/html/asciidoc.adoc.html
    • autotests/reference/asciidoc.adoc.ref
  7. In the source folder, I git add all these files, then commit
  8. Finally, I call: arc diff to land your patch
Mon, Jan 28, 9:41 PM · Frameworks, Kate, Framework: Syntax Highlighting

Sun, Jan 27

dhaumann added a comment to D18475: Add AsciiDoc support.

Running the katesyntaxhighlighting indexer tells me:

Sun, Jan 27, 4:04 PM · Frameworks, Kate, Framework: Syntax Highlighting

Sat, Jan 26

dhaumann added a comment to D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files.

Can you add a unit tedt for this? I.e. an example file in autotest/input?

Sat, Jan 26, 11:31 AM · Frameworks, Kate
dhaumann added a comment to D18475: Add AsciiDoc support.

With respect to colors: it's more important to be consistent with other highlightings in kate that with AsciiDoctor. Indeed, it would be nice if you can avoid any hard coded color.

Sat, Jan 26, 11:27 AM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann added a comment to D18516: Fix end of folding region in rules with lookAhead=true.

Interesting idea.

Sat, Jan 26, 11:24 AM · Frameworks, Kate

Thu, Jan 24

dhaumann added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

I'm not against this change, but have the feeling another +2 from someone who know this stuff is a good idea.

Thu, Jan 24, 10:20 AM · Frameworks

Wed, Jan 23

dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Use translation domain kateexternaltoolsplugin
  • Add support for categories, config widget still missing
  • Refactor mimetype checking
Wed, Jan 23, 9:27 PM · Kate
dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Remove ExternalToolRunner, was already factored out
  • Create KateToolRunner on the heap to not block Kate
  • Run clang-format
  • Fix comment
  • Factor out KateExternalToolsConfigWidget into separate file
  • Rename externaltools -> m_externalToolsMenu and make it private
  • Use signal&slot to trigger reload of a menu
  • Delete messy extView() helper function, not needed anymore
  • Add API documentation and remove m_view variable
  • Cleanup includes
  • Delete support for separators. Support for categories will be added later
Wed, Jan 23, 8:41 PM · Kate

Tue, Jan 22

dhaumann added a comment to D18163: Set the color scheme to Printing for Print Preview.

Is KateRenderer::setPrinterFriendly() only called in print preview mode? I think not.

Tue, Jan 22, 11:13 PM · Frameworks, Kate

Mon, Jan 21

dhaumann added a comment to D18116: Add TODO KF6 note .

Just for info: If openingErrorMessage is indeed not set anymore, this is a behavior change, since KTextEditor::Document::openingErrorMessage() is public API. Looking at lxr.kde.org, it seems this is not used (but ->openingError() is used, see https://lxr.kde.org/source/kde/applications/kate/addons/filetree/katefiletreemodel.cpp#0554).

Mon, Jan 21, 10:11 PM · Frameworks, Kate
dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Factor out KateExternalToolsCommand into separate file
  • Revive KTextEditor::Command interface by moving tool execution to KateExternalToolsPlugin
  • Pass plugin pointer to actions, since the plugin will act as model
  • Plugin: save Tool pointers, since these stable pointers will be reused by the actions
  • KateExternalToolMenuAction: Use tools from plugin
  • Remove KateExternalToolAction in favor of simply using QAction with QAction::data()
  • Minor cleanups
Mon, Jan 21, 9:41 PM · Kate

Sun, Jan 20

dhaumann updated the diff for D17971: Revive External Tools plugin.
  • KateToolRunner: Support passing stdin to process
  • Add unit test that tests stdin input
Sun, Jan 20, 10:53 PM · Kate
dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Add support for working directory, if provided
  • Load & save arguments
  • ToolDialog: Fix tab order
  • Factor out KateMacroExpander
  • Make KateExternalTool copyable, behavior is now value semantics
  • Use factored out KateMacroExpander for macro expansion
  • Remove 'command' field in favor of 'input' for stdin
  • KateToolRunner now takes ownership of the passed KateExternalTool
Sun, Jan 20, 9:13 PM · Kate
dhaumann added inline comments to D18384: Allow creating directory named '~' and throw a warning before creating it..
Sun, Jan 20, 1:37 PM · Frameworks
dhaumann accepted D18385: Build without KAuth and D-Bus on Android.
Sun, Jan 20, 8:41 AM · Frameworks
dhaumann accepted D18386: Build without D-Bus on Android.
Sun, Jan 20, 8:37 AM · Frameworks
dhaumann accepted D18387: Build without D-Bus on Android.
Sun, Jan 20, 8:36 AM · Frameworks
dhaumann accepted D18388: Build without D-Bus on Android.

Lgtm.

Sun, Jan 20, 8:34 AM · Frameworks
dhaumann accepted D18389: Build without D-Bus on Android.

Looks good to me. Same here: do you get warnings about unused variables now?

Sun, Jan 20, 8:32 AM · Frameworks
dhaumann accepted D18390: Build without D-Bus on Android.

Looks good to me.

Sun, Jan 20, 8:28 AM · Frameworks
dhaumann added inline comments to D18384: Allow creating directory named '~' and throw a warning before creating it..
Sun, Jan 20, 8:24 AM · Frameworks

Sat, Jan 19

dhaumann added a comment to D17971: Revive External Tools plugin.

Long not in a working state, so no review required.

Sat, Jan 19, 10:56 PM · Kate
dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Factor out KateExternalTool into separate file
  • Add ExternalToolRunner unit test skel
  • Factor out KateToolRunner for better unit testing
  • Introduce enum class SaveMode
  • Move load/save code to KateExternalTool
  • Rename member variable config to m_config
  • Initialize member variables
  • Simplify serialization and deserialization
  • Rename acname to actionName
  • Adapt default tools to new config file format
  • Rename test to a more generic name
  • Preliminary test for loading & saving external tool data
  • Start implementing KateToolRunner
  • Test for /home in ls output
  • Add some FIXMEs for later
  • Add checkbox "[x] Include output from stderr and port to QRegularExpression
Sat, Jan 19, 10:55 PM · Kate

Jan 15 2019

dhaumann added a comment to D18164: Review KateGotoBar.

Indeed I misread the screenshot - sorry for that :-) In that case, I have no objections. @cullmann your take?

Jan 15 2019, 9:24 PM · Frameworks, Kate
dhaumann requested changes to D18163: Set the color scheme to Printing for Print Preview.

Looking at the printing pages, I can find the following, see screenshot. Please note the ComboBox where you can select a printing schema. In other words, this should not be hard-coded, I think it should be explicitly set somewhere to what's specified in this combobox. @ahmadsamir Can you have a look again?

Jan 15 2019, 8:05 PM · Frameworks, Kate
dhaumann added a comment to D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable.

@loh.tar Slightly related: You may want to also have a look at this: https://phabricator.kde.org/source/ktexteditor/browse/master/src/script/data/commands/utils.js$271
In short, there is a command line command (F7) called 'rewrap' that rewraps the selection in a "smart" way. My idea when writing this once was:

Jan 15 2019, 7:58 PM · Frameworks, Kate
dhaumann added a comment to D18164: Review KateGotoBar.

I like the idea to go to next modified line up / down. I am undecided about the goto line in clipboard, since I have the feeling it adds more clutter than it helps by default: I think <CTRL+G> <CTRL+V> <ENTER> is quite fast. In addition, this leads to having "Gehe zu" twice in the ui, which is a bit confusing imho. Other opinions?

Jan 15 2019, 6:31 PM · Frameworks, Kate
dhaumann added inline comments to D17599: Confirm closing muliple tabs..
Jan 15 2019, 6:17 PM · Kate
dhaumann committed R39:1e0ace28c795: ViewInternal: Fix 'Go to matching bracket' in override mode (authored by dhaumann).
ViewInternal: Fix 'Go to matching bracket' in override mode
Jan 15 2019, 5:32 PM
dhaumann closed D17852: ViewInternal: Fix 'Go to matching bracket' in override mode .

Closed, see commit 1e0ace28c795cbe5e88bc1f31ea37a250cd110b0

Jan 15 2019, 5:31 PM · Frameworks, Kate
dhaumann accepted D17852: ViewInternal: Fix 'Go to matching bracket' in override mode .

Good patch, and works for me.

Jan 15 2019, 5:27 PM · Frameworks, Kate

Jan 13 2019

dhaumann added a comment to T10319: Ideas for External Tools.

The example of the diff of two views is out of scope: On KTextEditor level, we don't even have a concept of having multiple views side by side, that is business of the host application. You will really only have the concept of one active view.

Jan 13 2019, 8:58 PM · Kate
dhaumann added a comment to D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.

Patch looks interesting, didn't know about http://doc.qt.io/qt-5/qlineedit.html#addAction eith TrailingPosition.

Jan 13 2019, 5:59 PM · Kate

Jan 12 2019

dhaumann added inline comments to D17599: Confirm closing muliple tabs..
Jan 12 2019, 7:08 PM · Kate
dhaumann added a comment to D17599: Confirm closing muliple tabs..

The thing is: if you have multiple windows, closing a window does NOT close the document. That's why windows or the tabs are not a good measure for this question. The currently proposed implementation only asks, if you'd really close documents which is the same as closing the application.

Jan 12 2019, 7:06 PM · Kate

Jan 11 2019

dhaumann accepted D18192: Remove unused forward declaration.
Jan 11 2019, 9:16 PM · Frameworks
dhaumann updated the diff for D17971: Revive External Tools plugin.

Work in progress:

  • Port UI to Qt Designer file
  • Rename 'tryexe' to 'executable'
  • Cleanups
  • Merge branch 'master' into revive-externaltools-plugin
  • Update Copyright
Jan 11 2019, 9:08 PM · Kate