dhaumann (Dominik Haumann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 20 2015, 7:20 AM (234 w, 5 d)
Availability
Available

Recent Activity

Sat, Oct 12

dhaumann added a comment to T9585: Publish Okteta in the Microsoft Store.

@kossebau Just tried Okteta on Windows that is available on https://binary-factory.kde.org/job/Okteta_Nightly_win64/ and it works really well, out of the box. I believe it really has a lot of value making Okteta more visible, especially since users on Windows would also use it on Linux.

Sat, Oct 12, 7:23 PM · Windows
dhaumann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

I'm all for it. This would unify how we can reformat any KDE module, which is very much desirable.

Sat, Oct 12, 7:30 AM · Build System, Frameworks
dhaumann accepted D24578: Meson: Add a comment section for comment/uncomment with Kate.

Please increase the version number and commit.

Sat, Oct 12, 7:12 AM · Frameworks, Kate
dhaumann accepted D24575: Updates from CMake 3.16.

Thanks for the quick update.

Sat, Oct 12, 7:10 AM

Thu, Oct 10

dhaumann moved T10319: Ideas for External Tools from Backlog to Done on the Kate board.

The External Tools plugin is done for now. I would like to wait a bit to get feedback, and over time we can certainly add more default tools, or even extend the plugin with additional functionality.

Thu, Oct 10, 8:38 AM · Kate
dhaumann moved T10281: Create an "Outline View" from Backlog to Done on the Kate board.

I believe work should be invested into the LSP client, since it provides an outline as well. Over time, the language servers will get better and better, so you'll get all this for free.

Thu, Oct 10, 8:37 AM · Kate
dhaumann moved T10249: Revive External Tools Plugin from In Progress to Done on the Kate board.
Thu, Oct 10, 8:34 AM · Kate

Tue, Oct 8

dhaumann added inline comments to D20532: Proof of Concept: Add double click actions to empty space in the folder view.
Tue, Oct 8, 6:10 AM · Dolphin

Mon, Oct 7

dhaumann committed R40:1e3ed83667b3: External Tools: Fix accelerators and label buddys (authored by dhaumann).
External Tools: Fix accelerators and label buddys
Mon, Oct 7, 8:59 PM
dhaumann committed R40:d10af90957bf: External Tools: Fix translation of empty name/category (authored by dhaumann).
External Tools: Fix translation of empty name/category
Mon, Oct 7, 8:59 PM
dhaumann added a comment to D24443: Add a plugin system.

I'd go for a QVector for now. Arguing with Qt6 doesn't sound convincing to me, since Qt6 will take another>=1 year(s). So why try this experiment in public API now? :)

Mon, Oct 7, 6:45 AM

Sun, Oct 6

dhaumann added a comment to T9584: Publish Kile in the Microsoft Store.

I've checked to today and it seems that a few small regressions have appeared over the last months in Kile for Windows - I will need to iron them out first over the next weeks.

Sun, Oct 6, 7:52 PM · Kile, Windows

Fri, Oct 4

dhaumann added inline comments to D24415: Add standard icons to support to all entries in QDialogButtonBox.
Fri, Oct 4, 9:49 PM · Frameworks
dhaumann accepted D24403: Small performance improvements suggested by clang-tidy.

I also think it's fine. A next patch could convert the QRegExp to a QRegularExpression.

Fri, Oct 4, 9:31 PM · Frameworks, Kate
dhaumann committed R40:6d62b347a284: External Tool Dialog: Forgot to also reset Name and Icon (authored by dhaumann).
External Tool Dialog: Forgot to also reset Name and Icon
Fri, Oct 4, 6:08 PM
dhaumann committed R40:9b151a96fb28: External Tools: Add "Defaults" button to tool dialog for factory tools (authored by dhaumann).
External Tools: Add "Defaults" button to tool dialog for factory tools
Fri, Oct 4, 5:53 PM
dhaumann committed R40:54e70216cfca: External Tools: User KUrlRequester instead of LineEdit + Button (authored by dhaumann).
External Tools: User KUrlRequester instead of LineEdit + Button
Fri, Oct 4, 5:16 PM
dhaumann accepted D24404: Small performance improvements suggested by clang-tidy.
Fri, Oct 4, 4:08 PM · Frameworks, Kate
dhaumann committed R40:53a8f89bfd66: External Tools: Translate name and category (authored by dhaumann).
External Tools: Translate name and category
Fri, Oct 4, 1:50 PM
dhaumann accepted D24354: Mustache/Handlebars: minor fixes.
Fri, Oct 4, 6:35 AM · Frameworks, Kate

Thu, Oct 3

dhaumann accepted D24399: Pass QDir by const & instead of copy.
Thu, Oct 3, 8:46 PM · Frameworks
dhaumann added a comment to D13541: Port solid from Qt5::Widgets to Qt5::Gui.

@graesslin pong? One year passed.

Thu, Oct 3, 7:28 PM · Frameworks
dhaumann added a comment to D24378: WordDetect rule: detect delimiters at the inner edge of the string.

I think it's fine as is. The docbook says:

Thu, Oct 3, 7:26 PM · Frameworks, Kate
dhaumann committed R39:eb4113d70e20: Variable expansion: Use std::function internally (authored by dhaumann).
Variable expansion: Use std::function internally
Thu, Oct 3, 5:28 PM
dhaumann committed R40:e6ce67e02d96: Projects Plugin: Support variables %{Project:Path} and %{Project:NativePath} (authored by dhaumann).
Projects Plugin: Support variables %{Project:Path} and %{Project:NativePath}
Thu, Oct 3, 4:52 PM
dhaumann added a comment to D24378: WordDetect rule: detect delimiters at the inner edge of the string.

This looks good to me and as mentioned in D24354 WordDetect is better than RegExpr.

Thu, Oct 3, 11:23 AM · Frameworks, Kate
dhaumann accepted D24326: Add syntax highlighting for RenPy (.rpy).
Thu, Oct 3, 6:07 AM · Frameworks, Kate
dhaumann added a comment to D24354: Mustache/Handlebars: minor fixes.

Thanks a lot!

Thu, Oct 3, 6:01 AM · Frameworks, Kate
dhaumann accepted D24371: [KCM] Make the warning message wider.

Makes a lot of sense and looks visually good in the screenshot. I'm taking the liberty to give a +2.

Thu, Oct 3, 5:59 AM · Plasma
dhaumann added a comment to D24370: [KCM] Display scale factor as a percentage, not a decimal.

+1. This is also in line with typical zoom factors in other applications such as Okular, which also use percent values.

Thu, Oct 3, 5:57 AM · Plasma

Wed, Oct 2

dhaumann added a comment to D24354: Mustache/Handlebars: minor fixes.

Hm, would it make sense to change this? I.e. if the word itself has a word boundary, also use this?

Wed, Oct 2, 10:37 AM · Frameworks, Kate
dhaumann added a comment to D24354: Mustache/Handlebars: minor fixes.

Would it also be an option to fix WordDetect? I always thought WordDetect ignores the string contents, it should only check on the boundaries left and right

Wed, Oct 2, 9:47 AM · Frameworks, Kate
dhaumann added a comment to D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox.

Thanks Nate for the update, I think this is very transparent to users and makes using bad values by default a bit hardet.

Wed, Oct 2, 5:33 AM · Plasma

Tue, Oct 1

dhaumann added a comment to D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox.

As far as I understand, the reasoning of @cullmann is that 0.1 cannot be accurately be represented by a computer. Following this discussion, the number 0.1 will turn into either 0.09999999999999999167332731531132594682276248931884765625 or 0.1000000000000000055511151231257827021181583404541015625.

Tue, Oct 1, 8:52 PM · Plasma

Mon, Sep 30

dhaumann committed R40:b25b6ce93afa: External Tools: Increase ui.rc version counter (authored by dhaumann).
External Tools: Increase ui.rc version counter
Mon, Sep 30, 5:36 PM
dhaumann committed R40:2fa70b7fa2f6: External Tools: Fix translation domain (authored by dhaumann).
External Tools: Fix translation domain
Mon, Sep 30, 5:36 PM

Sun, Sep 29

dhaumann committed R40:c5b8abf0e3a5: Tab bar: use tab-close icon again (authored by dhaumann).
Tab bar: use tab-close icon again
Sun, Sep 29, 1:28 PM
dhaumann committed R40:9d11544788ae: Merge branch 'hi-dpi-tabbar' into 'master' (authored by dhaumann).
Merge branch 'hi-dpi-tabbar' into 'master'
Sun, Sep 29, 12:06 PM

Sat, Sep 28

dhaumann added a comment to D24262: Modernize code: use range-based loops & algorithms in more places.

It's actually quite clear in my head, because I imagine the generated class. A captured variable in a lambda becomes a member variable. If it's a capture by value (which is what happens with [library]), it's a "plain value" member.
So

Sat, Sep 28, 7:58 PM · Frameworks
dhaumann added inline comments to D24262: Modernize code: use range-based loops & algorithms in more places.
Sat, Sep 28, 7:55 PM · Frameworks
dhaumann committed R40:75d1f59261d7: External tools: Skip unit tests if necessary (authored by dhaumann).
External tools: Skip unit tests if necessary
Sat, Sep 28, 7:30 PM
dhaumann committed R40:1b48d07e2148: Tab bar: Fix close button in right-to-left layout (authored by dhaumann).
Tab bar: Fix close button in right-to-left layout
Sat, Sep 28, 6:04 PM
dhaumann committed R40:77f8b4530c8d: Tab bar: Fix close button in right-to-left layout (authored by dhaumann).
Tab bar: Fix close button in right-to-left layout
Sat, Sep 28, 5:48 PM
dhaumann added inline comments to D24262: Modernize code: use range-based loops & algorithms in more places.
Sat, Sep 28, 6:19 AM · Frameworks
dhaumann added inline comments to D24261: Modernize code: use range-based for loop in more places.
Sat, Sep 28, 6:11 AM · Frameworks

Fri, Sep 27

dhaumann committed R40:ae3e2b3c5936: Enable -DQT_DISABLE_DEPRECATED_BEFORE=0x050d00 (authored by dhaumann).
Enable -DQT_DISABLE_DEPRECATED_BEFORE=0x050d00
Fri, Sep 27, 1:03 PM
dhaumann committed R40:ea371461a755: Compile with -DQT_DISABLE_DEPRECATED_BEFORE=0x050d00 (authored by dhaumann).
Compile with -DQT_DISABLE_DEPRECATED_BEFORE=0x050d00
Fri, Sep 27, 1:03 PM
dhaumann committed R40:63934fca756d: Disalow Qt's Q_FOREACH/foreach macros (authored by dhaumann).
Disalow Qt's Q_FOREACH/foreach macros
Fri, Sep 27, 10:42 AM

Thu, Sep 26

dhaumann accepted D24234: Fix minor typos.
Thu, Sep 26, 6:55 AM
dhaumann accepted D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles.

Thanks

Thu, Sep 26, 5:43 AM · Frameworks, Kate

Wed, Sep 25

dhaumann added a comment to D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles.

I'd indeed prefer another/separate diff. :)

Wed, Sep 25, 2:59 PM · Frameworks, Kate
dhaumann added inline comments to D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles.
Wed, Sep 25, 8:47 AM · Frameworks, Kate
dhaumann added a comment to D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles.

There are also changes in other xml files. Are these intentional? E.g. the changes from WordDetect to RegExpr seem suspicious.

Wed, Sep 25, 8:46 AM · Frameworks, Kate

Tue, Sep 24

dhaumann committed R40:aac1d4c4f8dc: Reduce usage of foreach in favor of range-based for loops (authored by dhaumann).
Reduce usage of foreach in favor of range-based for loops
Tue, Sep 24, 5:36 PM
dhaumann committed R40:0bbb048bd225: Port away from foreach in favor of range-based for loops (authored by dhaumann).
Port away from foreach in favor of range-based for loops
Tue, Sep 24, 5:28 PM
dhaumann committed R40:e5eb0d2280d9: Reduce usage of foreach in favor of range-based for loops (authored by dhaumann).
Reduce usage of foreach in favor of range-based for loops
Tue, Sep 24, 5:20 PM
dhaumann committed R40:970bf12c1c82: Reduce usage of foreach in favor of range-based for loops (authored by dhaumann).
Reduce usage of foreach in favor of range-based for loops
Tue, Sep 24, 5:20 PM
dhaumann committed R40:acef379aa89c: Remove more foreach in favor of range-based for loops (authored by dhaumann).
Remove more foreach in favor of range-based for loops
Tue, Sep 24, 5:05 PM
dhaumann committed R40:25b0a3fec0f2: Reduce usage of forach macro in favor of range-based for loops (authored by dhaumann).
Reduce usage of forach macro in favor of range-based for loops
Tue, Sep 24, 12:24 PM
dhaumann committed R40:f5792b9d5971: LSP Client config page: Use ui file (authored by dhaumann).
LSP Client config page: Use ui file
Tue, Sep 24, 11:55 AM
dhaumann committed R40:2f53a19b8815: Port away from DesktopIcon() and SmallIcon() (authored by dhaumann).
Port away from DesktopIcon() and SmallIcon()
Tue, Sep 24, 10:22 AM

Mon, Sep 23

dhaumann committed R40:98e80888aea8: External Tools: Extend output to include "Copy to Clipboard" (authored by dhaumann).
External Tools: Extend output to include "Copy to Clipboard"
Mon, Sep 23, 6:52 PM
dhaumann committed R40:4b04f93a0cb1: External Tools: Another missing i18n() call (authored by dhaumann).
External Tools: Another missing i18n() call
Mon, Sep 23, 6:41 PM
dhaumann committed R40:d6e59304ebbf: External tools: Also translate preset menu (authored by dhaumann).
External tools: Also translate preset menu
Mon, Sep 23, 5:59 PM
dhaumann committed R40:a36838699757: Properly translate the external tools menu + config widget (authored by dhaumann).
Properly translate the external tools menu + config widget
Mon, Sep 23, 5:56 PM
dhaumann closed D24166: Status bar mode menu: Reuse empty QIcon that is implicitly shared.
Mon, Sep 23, 5:39 PM · Frameworks, Kate
dhaumann committed R39:8cb82970b347: Status bar mode menu: Reuse empty QIcon that is implicitly shared (authored by dhaumann).
Status bar mode menu: Reuse empty QIcon that is implicitly shared
Mon, Sep 23, 5:39 PM
dhaumann requested review of D24166: Status bar mode menu: Reuse empty QIcon that is implicitly shared.
Mon, Sep 23, 5:22 PM · Frameworks, Kate
dhaumann committed R40:eaee9495ed38: Add Tools > External Tools > Configure... (authored by dhaumann).
Add Tools > External Tools > Configure...
Mon, Sep 23, 5:18 PM
dhaumann committed R40:9d4f0a461cba: Turn uint idInPlugin into a int (authored by dhaumann).
Turn uint idInPlugin into a int
Mon, Sep 23, 5:11 PM
dhaumann committed R39:f1ed78f55d64: Expose KTextEditor::MainWindow::showPluginConfigPage() (authored by dhaumann).
Expose KTextEditor::MainWindow::showPluginConfigPage()
Mon, Sep 23, 4:44 PM
dhaumann closed D24164: Expose KTextEditor::MainWindow::showPluginConfigPage().
Mon, Sep 23, 4:44 PM · Frameworks, Kate
dhaumann committed R40:bd0de77823da: Implement KTextEditor::MainWindow::showPluginConfigPage() (authored by dhaumann).
Implement KTextEditor::MainWindow::showPluginConfigPage()
Mon, Sep 23, 4:39 PM
dhaumann requested review of D24164: Expose KTextEditor::MainWindow::showPluginConfigPage().
Mon, Sep 23, 4:29 PM · Frameworks, Kate
dhaumann committed R39:53d3c5fdb2c0: Expose KTextEditor::MainWindow::showPluginConfigPage() (authored by dhaumann).
Expose KTextEditor::MainWindow::showPluginConfigPage()
Mon, Sep 23, 4:21 PM
dhaumann committed R40:6b967c8dcede: Delete external tools on shutdown (authored by dhaumann).
Delete external tools on shutdown
Mon, Sep 23, 4:19 PM
dhaumann committed R40:f807570b7e25: External Tools: Support adding actions to toolbar (authored by dhaumann).
External Tools: Support adding actions to toolbar
Mon, Sep 23, 1:59 PM
dhaumann committed R40:a4049d9eead7: External Tools: Ensure the command line command is unique (authored by dhaumann).
External Tools: Ensure the command line command is unique
Mon, Sep 23, 10:44 AM
dhaumann committed R40:c22a0e079664: Fix making the acionName unique. (authored by dhaumann).
Fix making the acionName unique.
Mon, Sep 23, 10:44 AM
dhaumann committed R40:4bca78d27fa5: External Tools: Use QRegularExpressionValidator for view command line name (authored by dhaumann).
External Tools: Use QRegularExpressionValidator for view command line name
Mon, Sep 23, 10:31 AM
dhaumann committed R40:bd8d3e61173a: External tools: Fix uniqueness of action names (authored by dhaumann).
External tools: Fix uniqueness of action names
Mon, Sep 23, 10:13 AM
dhaumann committed R40:56a010e23b04: External tools plugin: port away from SmallIcon(...) (authored by dhaumann).
External tools plugin: port away from SmallIcon(...)
Mon, Sep 23, 9:51 AM

Sep 16 2019

dhaumann added a comment to D23998: Fix HiDPI rendering issues with Dual Screen.

What happens if e.g. vi or another text editor is open? Do we send the cd... command then to the editor?

Sep 16 2019, 8:24 PM · Kate

Sep 15 2019

dhaumann added a comment to D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget.

@dfaure: D21197 can be closed / abandoned?

Sep 15 2019, 7:51 PM · Frameworks
dhaumann accepted D23966: [KTextEditor] Port away from deprecated QCoreApplication::hasPendingEvents().

Yes, forgot to accept, sorry.

Sep 15 2019, 7:34 PM
dhaumann committed R40:6aa27373800b: Categorize all external tools by default (authored by dhaumann).
Categorize all external tools by default
Sep 15 2019, 5:11 PM
dhaumann committed R40:e8abe44399ec: API docs: mention keyboard shortcut persistency for actionName (authored by dhaumann).
API docs: mention keyboard shortcut persistency for actionName
Sep 15 2019, 5:11 PM
dhaumann added a comment to D23966: [KTextEditor] Port away from deprecated QCoreApplication::hasPendingEvents().

Ok, let's try this.

Sep 15 2019, 4:51 PM
dhaumann accepted D23964: [KTextEditor] Port away from other deprecated methods in Qt 5.14.
Sep 15 2019, 4:50 PM
dhaumann accepted D23963: [KTextEditor] Port away from deprecated qBinaryFind.
Sep 15 2019, 4:49 PM · Frameworks, Kate
dhaumann accepted D23962: [KTextEditor] Port away from deprecated QFontMetrics::width.
Sep 15 2019, 4:47 PM
dhaumann committed R40:e0ce1bac6d01: Ignore .clangd folder from LSP servers (authored by dhaumann).
Ignore .clangd folder from LSP servers
Sep 15 2019, 4:46 PM
dhaumann committed R40:9fae1c23656b: Run clang-format on external tools plugin (authored by dhaumann).
Run clang-format on external tools plugin
Sep 15 2019, 4:46 PM
dhaumann committed R40:29983d9fee0f: Return "Uncategorized" category in case no category was specified (authored by dhaumann).
Return "Uncategorized" category in case no category was specified
Sep 15 2019, 4:46 PM
dhaumann committed R40:4e2f9cc438d5: Add "Add Tool from Defaults" for adding builtin external tools (authored by dhaumann).
Add "Add Tool from Defaults" for adding builtin external tools
Sep 15 2019, 4:46 PM
dhaumann committed R40:f9a63aea96fd: Factor out adding a tool to the tree view (authored by dhaumann).
Factor out adding a tool to the tree view
Sep 15 2019, 4:46 PM
dhaumann committed R40:29b15b55aa6f: Expose defaultTools() for later use (authored by dhaumann).
Expose defaultTools() for later use
Sep 15 2019, 4:46 PM
dhaumann committed R40:75f8415e401c: Make blankIcon() a free function (authored by dhaumann).
Make blankIcon() a free function
Sep 15 2019, 4:46 PM
dhaumann committed R40:0d1c47d198f6: External Tools: Read tools from defaultexternaltoolsrc on first start (authored by dhaumann).
External Tools: Read tools from defaultexternaltoolsrc on first start
Sep 15 2019, 4:46 PM

Sep 14 2019

dhaumann added inline comments to D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows.
Sep 14 2019, 3:30 PM · Frameworks, Kate