dhaumann (Dominik Haumann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 20 2015, 7:20 AM (156 w, 4 d)
Availability
Available

Recent Activity

Tue, Apr 17

dhaumann added a comment to D12271: Don't remove trailing whitespace from cursor line.

@sraizada I am just seeing that this is your first KDE patch, nice! I hope that you do not get discouraged by my comments, I am just trying to find good solutions that work for everyone, and in this case, the solution this patch proposed did not work out in the past...

Tue, Apr 17, 9:46 AM · Frameworks, Kate, KTextEditor
dhaumann added a comment to D12271: Don't remove trailing whitespace from cursor line.

The behavior that is proposed here was like Kate behaved before, and as result we got bug reports that not all trailing spaces were removed. So we removed this.

Tue, Apr 17, 9:44 AM · Frameworks, Kate, KTextEditor

Mon, Apr 16

dhaumann added a comment to D11945: Optimize AppArmor & SELinux highlighting and improve regex.

Out of curiosity: why are you putting multiple items in the same line on the keyword lists? This bloats up the diff and makes a real review so much harder... :/

Mon, Apr 16, 8:31 AM · Framework: Syntax Highlighting, Frameworks

Sun, Apr 15

dhaumann accepted D12224: Use Tree View as the default view mode in the Filesystem Browser plugin.

Ok, then thanks & please go ahead in master branch.

Sun, Apr 15, 4:26 PM · Kate
dhaumann added a comment to D12224: Use Tree View as the default view mode in the Filesystem Browser plugin.

I think this is nice, but is this patch a problem if you have new Kate with KTextEditor < 5.46?

Sun, Apr 15, 4:14 PM · Kate
dhaumann added a comment to D7175: Redesign CMake syntax.

Sure? It was reverted a month ago once. Was it applied again?

Sun, Apr 15, 4:07 PM · Frameworks
dhaumann added a comment to D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9.

@ngraham So what is the current state of a proper fix in KFontRequester?

Sun, Apr 15, 4:05 PM · Frameworks, Kate
dhaumann added a comment to D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9.

They all are closed as a general KFontChooser issue. Maybe we should even blog about this :p

Sun, Apr 15, 11:48 AM · Frameworks, Kate
dhaumann added a comment to D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9.

Btw there are bug reports for this. Could you link the Kate related ones, if existing?

Sun, Apr 15, 11:37 AM · Frameworks, Kate
dhaumann accepted D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9.

A simple fix for a severe issue - please commit!

Sun, Apr 15, 11:35 AM · Frameworks, Kate
dhaumann added a comment to D12215: Add a "Reload" menu item to KDirOperator's context menu.

I am ok with this: +1

Sun, Apr 15, 7:57 AM · Frameworks

Sat, Apr 14

dhaumann updated subscribers of D11785: Add kcolorschemechooser support and related setting menu entry.

Indeed, maybe this class should be part of the KConfigWidgets framework? See https://api.kde.org/frameworks/kconfigwidgets/html/annotated.html for current list of classes - it already contains the color scheme stuff and is a tier3 framework (so many dependencies allowed).

Sat, Apr 14, 12:57 AM · Kate
dhaumann added a comment to D11785: Add kcolorschemechooser support and related setting menu entry.

@cullmann This patch is unrelated to KTextEditor settings itself. It only adds an action that allows to change the KDE color scheme per application. The name "KateColorScheme..." is misleading here, since it has nothing to do with Kate color schemes...

Sat, Apr 14, 12:49 AM · Kate
dhaumann requested changes to D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).

Looks mostly good, but there are some minor issues we first need to address:

  • dsControlFlow and similar default styles were added with KDE Frameworks 5, so kateversion="5.0" is required in the header
  • WordDetect for things like "end if" is not sensitive to multiple spaces anymore. Are you sure this is correct? If not, please keep RegExpr.
Sat, Apr 14, 12:46 AM · Frameworks

Mon, Apr 2

dhaumann added a comment to D11818: Don't restart the blocking process on session restore.

Just as more background: no, you are definitely not expected to push to the branch. You only should push to the branch if the bug justifies a mostly untested patch (untested in the sense of that it's probably only you who did proper testing). That said, it usually is up to you to decide. Personally, I believe crashes and severe bug fixes should be backported, but given the risk of introducing regressions in stable versions, commits to the stable branch are often not necessary. It all boils down to risk, and the fact that you take responsibility for what you do :-)

Mon, Apr 2, 8:25 PM · Kate
dhaumann added a comment to D11838: Turn on line numbers by default.

As background: in KF5 world, the KTextEditor settings are shared among applications: enabling line numbers in Kate will enable line numbers in KDevelop, Kile, KWrite, ...

Mon, Apr 2, 8:19 PM · Frameworks, Kate

Sun, Apr 1

dhaumann updated subscribers of D11838: Turn on line numbers by default.

This looks good from my side.

Sun, Apr 1, 6:22 AM · Frameworks, Kate

Sat, Mar 31

dhaumann requested changes to D11838: Turn on line numbers by default.

Not yet good enough, let's have another revision.

Sat, Mar 31, 8:00 PM · Frameworks, Kate
dhaumann accepted D11818: Don't restart the blocking process on session restore.

Thanks for the additional info. Please add this comment to the commit log when you push, so that we have it in the history. Thanks!

Sat, Mar 31, 7:49 PM · Kate
dhaumann added a comment to D11818: Don't restart the blocking process on session restore.

Would it also be possible to call setRestartHint() directly, or why is the connect required?

Sat, Mar 31, 7:13 AM · Kate
dhaumann accepted D11780: Update kate manpage to 18.04.

Change is correct imo.

Sat, Mar 31, 7:04 AM · Kate
dhaumann accepted D11727: Update kwrite docbook to 18.04.

Makes sense, thanks.

Sat, Mar 31, 7:00 AM · Kate
dhaumann accepted D11603: Update katepart docbooks to 18.04.

Looks good to me. Thanks for this update!

Sat, Mar 31, 6:59 AM · Kate
dhaumann added a comment to D11610: clang-tidy: modernize-use-default-member-init run.

Btw, I messed up the dates. Tag is next Saturday after today...

Sat, Mar 31, 6:55 AM · Frameworks, Kate

Sat, Mar 24

dhaumann accepted D11610: clang-tidy: modernize-use-default-member-init run.

The patch looks good. Please commit this weekend, or wait until next Saturday's v5.45 branch.

Sat, Mar 24, 8:44 AM · Frameworks, Kate

Fri, Mar 23

dhaumann added a comment to D11610: clang-tidy: modernize-use-default-member-init run.

I like this a lot, but have not done a review yet. Will do later.

Fri, Mar 23, 8:31 PM · Frameworks, Kate

Wed, Mar 21

dhaumann accepted D11559: Fix default colour used by Swap monitor.

An obvious typo. Thanks for this fix! PS: A Screenshot would have been nice, though :-)

Wed, Mar 21, 9:25 PM · Plasma
dhaumann requested changes to D11543: Optimize many syntax highlighting files and fix the '/' char of SQL.

Cool! The patch already looks pretty good. Please address or comment on my questions.

Wed, Mar 21, 9:11 PM · Framework: Syntax Highlighting, Frameworks

Mar 20 2018

dhaumann committed R39:e75bde233b9f: Revert Fix: View jumps when Scroll past end of document is enabled (authored by dhaumann).
Revert Fix: View jumps when Scroll past end of document is enabled
Mar 20 2018, 6:52 PM
dhaumann accepted D11491: Don't calculate attribute() twice..

Looks good to me.

Mar 20 2018, 8:18 AM · Frameworks, Kate

Mar 13 2018

dhaumann committed R216:cec763566ca4: Optimize highlighting Bash, Cisco, Clipper, Coffee, Gap, Haml, Haskell (authored by dhaumann).
Optimize highlighting Bash, Cisco, Clipper, Coffee, Gap, Haml, Haskell
Mar 13 2018, 8:44 PM
dhaumann closed D11298: Optimize highlighting Bash, Cisco, Clipper, Coffee, Gap, Haml, Haskell.
Mar 13 2018, 8:44 PM · Frameworks
dhaumann added a comment to D10621: Highlighting Indexer: list of suggestions.

@jpoelen What would be interesting is to check which optimizations are really an improvement. Because we should either get a significant speed boost (e.g. RegExpr -> WordDetect), or at least reduce memory allocations (possibly StringDetect -> Detect2Chars and DetectChar).

Mar 13 2018, 8:43 PM · Framework: Syntax Highlighting, Frameworks
dhaumann requested review of D11298: Optimize highlighting Bash, Cisco, Clipper, Coffee, Gap, Haml, Haskell.
Mar 13 2018, 8:40 PM · Frameworks

Mar 10 2018

dhaumann added a comment to D10621: Highlighting Indexer: list of suggestions.

Just for info: https://kate-editor.org/2018/03/10/improving-syntax-highlighting-files/ tries to reach a broader audience for getting patches.

Mar 10 2018, 8:56 PM · Framework: Syntax Highlighting, Frameworks
dhaumann requested changes to D10621: Highlighting Indexer: list of suggestions.

Btw, current generated list finds 1658 issues: https://paste.kde.org/p7iareuxc

Mar 10 2018, 8:35 PM · Framework: Syntax Highlighting, Frameworks
dhaumann added a comment to D7175: Redesign CMake syntax.

Oh, and btw. sorry that this review took essentially 7 months. Sometimes we simply suck and things go badly wrong :-)

Mar 10 2018, 8:21 PM · Frameworks
dhaumann accepted D7175: Redesign CMake syntax.

So everyone seems to agree that in general it's a good idea.

Mar 10 2018, 8:20 PM · Frameworks
dhaumann added a comment to D10621: Highlighting Indexer: list of suggestions.

As quick comment: I like the idea of programmatically suggesting better usage of rules. I did not yet fine the time to look into this, so I do not know how much output this currently generates.

Mar 10 2018, 8:12 PM · Framework: Syntax Highlighting, Frameworks

Mar 3 2018

dhaumann committed R216:c53dfc5024d1: Add syntax highlighting for MIB files (authored by dhaumann).
Add syntax highlighting for MIB files
Mar 3 2018, 11:14 AM
dhaumann closed D10956: Add syntax highlighting for MIB files.
Mar 3 2018, 11:14 AM · Frameworks
dhaumann accepted D10956: Add syntax highlighting for MIB files.

Looks ok to me now.

Mar 3 2018, 11:13 AM · Frameworks
dhaumann added a comment to D10956: Add syntax highlighting for MIB files.

Calling make test creates the reference unit test data, this was missing. I did this now, adding:

new file:   autotests/folding/test.mib.fold
new file:   autotests/html/test.mib.html
new file:   autotests/reference/test.mib.ref
Mar 3 2018, 11:11 AM · Frameworks
dhaumann added a comment to D10956: Add syntax highlighting for MIB files.

Compiling results in:

Mar 3 2018, 11:08 AM · Frameworks

Feb 25 2018

dhaumann committed R39:1e178c9b157a: GIT_SILENT: another compile fix (authored by dhaumann).
GIT_SILENT: another compile fix
Feb 25 2018, 12:03 PM
dhaumann committed R39:8968e9122baa: GIT_SILENT: Try fix compile (authored by dhaumann).
GIT_SILENT: Try fix compile
Feb 25 2018, 11:54 AM
dhaumann committed R39:ac8f9f61a0d1: Iterate over initializer_lists to avoid mem allocs (authored by dhaumann).
Iterate over initializer_lists to avoid mem allocs
Feb 25 2018, 11:54 AM
dhaumann closed D9211: Iterate over initializer_lists to avoid mem allocs.

Committed with https://cgit.kde.org/ktexteditor.git/commit/?id=ac8f9f61a0d160a04fd46cb7f87b1509987892aa

Feb 25 2018, 11:42 AM · Frameworks, Kate
dhaumann added a comment to D9211: Iterate over initializer_lists to avoid mem allocs.

Mark comments as done.

Feb 25 2018, 11:40 AM · Frameworks, Kate
dhaumann committed R40:a59237913165: Projects plugin: fix git file listing for umlauts such as äöü (authored by dhaumann).
Projects plugin: fix git file listing for umlauts such as äöü
Feb 25 2018, 11:38 AM
dhaumann closed D10311: Projects plugin: fix git file listing for umlauts such as äöü.
Feb 25 2018, 11:38 AM · Kate
dhaumann added a comment to D10311: Projects plugin: fix git file listing for umlauts such as äöü.

Good point. Question is what git does in this case. We should be able to test this with a fat USB stick... Todo :)

Feb 25 2018, 10:31 AM · Kate
dhaumann added a comment to D10719: Highlighting for OpenSCAD.

Hm, did you update with arc diff, or did you do this differently?

Feb 25 2018, 10:26 AM · Frameworks
dhaumann added a comment to D10311: Projects plugin: fix git file listing for umlauts such as äöü.

Could be, but Windows XP is not supported anymore, so we do not care.

Feb 25 2018, 10:25 AM · Kate

Feb 24 2018

dhaumann updated the diff for D9211: Iterate over initializer_lists to avoid mem allocs.
  • Add and use contains()
  • Use QLaint1String
Feb 24 2018, 10:21 PM · Frameworks, Kate
dhaumann committed R216:4f7e020e332d: Basic support for PHP and Python fenced code blocks in Markdown (authored by dhaumann).
Basic support for PHP and Python fenced code blocks in Markdown
Feb 24 2018, 9:46 PM
dhaumann closed D7864: Basic support for PHP and Python fenced code blocks in Markdown.
Feb 24 2018, 9:46 PM · Frameworks
dhaumann added a comment to D7864: Basic support for PHP and Python fenced code blocks in Markdown.

@vkrause Do you already have something in mind, when you say this does not scale? ...

Feb 24 2018, 9:43 PM · Frameworks
dhaumann updated the diff for D10311: Projects plugin: fix git file listing for umlauts such as äöü.
  • Use QString::fromUtf8(ByteArray) for raw string interpretation
Feb 24 2018, 9:41 PM · Kate
dhaumann committed R216:933eecb13d9a: Support case-insensitive WordDetect (authored by dhaumann).
Support case-insensitive WordDetect
Feb 24 2018, 9:33 PM
dhaumann closed D10646: Support case-insensitive WordDetect.
Feb 24 2018, 9:33 PM · Frameworks
dhaumann added a comment to D10646: Support case-insensitive WordDetect.

Ok, good catch. Given the uninitialized variables in the other classes, this is good. Will integrate.

Feb 24 2018, 9:30 PM · Frameworks
dhaumann committed R216:6acf0aaf6389: Scheme highlighting: Remove hard-coded colors (authored by dhaumann).
Scheme highlighting: Remove hard-coded colors
Feb 24 2018, 9:23 PM
dhaumann committed R216:6132c15c0d44: Add syntax highlighting for SELinux CIL Policies & File Contexts (authored by dhaumann).
Add syntax highlighting for SELinux CIL Policies & File Contexts
Feb 24 2018, 9:17 PM
dhaumann closed D10174: Add syntax highlighting for SELinux CIL Policies & File Contexts.
Feb 24 2018, 9:17 PM · Framework: Syntax Highlighting, Frameworks
dhaumann accepted D10174: Add syntax highlighting for SELinux CIL Policies & File Contexts.

I'll remove the selColor attributes, since these will not work with dark color schemes.
Similar, I will remove all underline, italic, and bold attributes where not needed by default.

Feb 24 2018, 9:17 PM · Framework: Syntax Highlighting, Frameworks
dhaumann committed R216:1b02007242ec: Adding ctp file extension to the PHP syntax highlighting (authored by dhaumann).
Adding ctp file extension to the PHP syntax highlighting
Feb 24 2018, 9:04 PM
dhaumann closed D10595: Adding ctp file extension to the PHP syntax highlighting.
Feb 24 2018, 9:04 PM · Frameworks
dhaumann committed R216:f5a32272d26e: Yacc/Bison: Fix the $ symbol and update syntax for Bison (authored by nibags).
Yacc/Bison: Fix the $ symbol and update syntax for Bison
Feb 24 2018, 9:04 PM
dhaumann accepted D10595: Adding ctp file extension to the PHP syntax highlighting.

Sounds good to me.

Feb 24 2018, 9:03 PM · Frameworks
dhaumann closed D10783: Yacc/Bison: Fix the $ symbol and update syntax for Bison.

Done, see commit https://commits.kde.org/syntax-highlighting/f5a32272d26e3b46d4c4201a5d9531de8f23867a

Feb 24 2018, 9:02 PM · Framework: Syntax Highlighting, Frameworks
dhaumann accepted D10783: Yacc/Bison: Fix the $ symbol and update syntax for Bison.

Looks good to me, will integrate.

Feb 24 2018, 9:01 PM · Framework: Syntax Highlighting, Frameworks
dhaumann added a comment to D10719: Highlighting for OpenSCAD.

@julianstirling Can you profile the full xml file again? This patch does not contain the .xml file anymore, so in the current form I cannot commit this as is.

Feb 24 2018, 8:58 PM · Frameworks

Feb 21 2018

dhaumann requested changes to D10719: Highlighting for OpenSCAD.

Thanks for the contribution. Before we integrate this, would you agree to change the license to MIT? This license is preferred for new highlighting files.

Feb 21 2018, 9:40 PM · Frameworks

Feb 19 2018

dhaumann accepted D10646: Support case-insensitive WordDetect.

In general looks good, and it even revealed a bug as I understand.

Feb 19 2018, 7:40 AM · Frameworks

Feb 15 2018

dhaumann added a comment to D7087: Add "Copy Info" button to the About System KCM.

One small suggestion to improve the clipboard code.

Feb 15 2018, 9:21 PM · Plasma
dhaumann added a comment to D7087: Add "Copy Info" button to the About System KCM.

Thinking about it, what about this: The dialog already has all the QLabels. What you could do is something along the lines:

Feb 15 2018, 9:20 PM · Plasma
dhaumann committed R216:0f75a3659b3c: awk.xml: add gawk extension keywords (authored by dhaumann).
awk.xml: add gawk extension keywords
Feb 15 2018, 8:48 PM
dhaumann added a comment to D7087: Add "Copy Info" button to the About System KCM.

I can see the reason for English text only. Then again, I think that @rkflx has a very valid argument as well. I do not know any other place in KDE that intentionally uses non-translatable text. That's why I agree with @rkflx to better translate this.

Feb 15 2018, 8:41 PM · Plasma
dhaumann committed R39:6a3599b9e803: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text… (authored by dhaumann).
Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text…
Feb 15 2018, 8:35 PM
dhaumann closed D10509: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text Upppercase, Lowercase and Capitalize.
Feb 15 2018, 8:35 PM · Frameworks, Kate
dhaumann accepted D10509: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text Upppercase, Lowercase and Capitalize.

Yes, looks ok, will integrate.

Feb 15 2018, 8:33 PM · Frameworks, Kate

Feb 13 2018

dhaumann closed D10054: Fix: View jumps when Scroll past end of document is enabled.

Close as it should work now.

Feb 13 2018, 9:58 PM · Frameworks, Kate
dhaumann added a comment to D10054: Fix: View jumps when Scroll past end of document is enabled.

This is fixed, see commit https://phabricator.kde.org/R39:1a38adebb64e6e7d5acb756f68166d56d8ba0b72

Feb 13 2018, 9:58 PM · Frameworks, Kate
dhaumann committed R39:1a38adebb64e: GIT_SILENT: Try fix unit tests (authored by dhaumann).
GIT_SILENT: Try fix unit tests
Feb 13 2018, 9:35 PM
dhaumann added a comment to D10054: Fix: View jumps when Scroll past end of document is enabled.

Question is: what happens in the vi test? Did we really introduce a regression or is the test wrong?

Feb 13 2018, 12:07 PM · Frameworks, Kate

Feb 6 2018

dhaumann added a comment to D7864: Basic support for PHP and Python fenced code blocks in Markdown.

This fixes bug https://bugs.kde.org/show_bug.cgi?id=389307 at least partially. More languages such as Ruby etc can still be added.

Feb 6 2018, 7:06 AM · Frameworks

Feb 5 2018

dhaumann added a comment to D10311: Projects plugin: fix git file listing for umlauts such as äöü.

To be honest, I do not know. The risk of introducing a regression definitely exists. Also, I do not know whether this works on Windows. What do you suggest to test / do?

Feb 5 2018, 9:36 PM · Kate
dhaumann updated subscribers of D10311: Projects plugin: fix git file listing for umlauts such as äöü.
Feb 5 2018, 5:51 PM · Kate

Feb 4 2018

dhaumann requested changes to D7087: Add "Copy Info" button to the About System KCM.

Translation is not yet working correctly, see above comment.

Feb 4 2018, 10:40 PM · Plasma
dhaumann added a comment to D7087: Add "Copy Info" button to the About System KCM.

All the keys in collectedData are not properly translated. As such, creating a final string out of this is not translation friendly.

Feb 4 2018, 10:39 PM · Plasma
dhaumann updated the diff for D10311: Projects plugin: fix git file listing for umlauts such as äöü.
  • Use reference
Feb 4 2018, 9:56 PM · Kate
dhaumann updated subscribers of D10306: Tab switcher plugin: Escape hides switcher widget.

@kfunk Do you need such a patch in the KDevelop document switcher plugin as well? This code comes from your code after all...

Feb 4 2018, 9:35 PM · Kate
dhaumann committed R40:2641fc835e5f: Tab switcher plugin: Escape hides switcher widget (authored by dhaumann).
Tab switcher plugin: Escape hides switcher widget
Feb 4 2018, 9:33 PM
dhaumann closed D10306: Tab switcher plugin: Escape hides switcher widget.
Feb 4 2018, 9:33 PM · Kate
dhaumann added a reviewer for D10306: Tab switcher plugin: Escape hides switcher widget: cullmann.
Feb 4 2018, 8:17 PM · Kate
dhaumann added a reviewer for D10306: Tab switcher plugin: Escape hides switcher widget: ngraham.
Feb 4 2018, 8:14 PM · Kate
dhaumann committed R40:5e7e72e7ba11: Fixes sorting of items within Kate editor's session applet (authored by dhaumann).
Fixes sorting of items within Kate editor's session applet
Feb 4 2018, 6:54 PM
dhaumann closed D10208: Fixes sorting of items within Kate editor's session applet.
Feb 4 2018, 6:54 PM · Kate
dhaumann committed R216:b874bbe19165: Fix C# var regex (authored by dhaumann).
Fix C# var regex
Feb 4 2018, 6:29 PM