dhaumann (Dominik Haumann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 20 2015, 7:20 AM (209 w, 3 d)
Availability
Available

Recent Activity

Mon, Apr 22

dhaumann added a comment to D20697: Review IconBorder.

Well, issues that were already there before should not hinder this patch of course! If you think this is good enough, please go on.

Mon, Apr 22, 5:24 PM · Frameworks, Kate
dhaumann added a comment to D20169: Add profile support interface for TerminalInterface.

Please fix the API getters: in the KDE/Qt world, getters never start with 'get': just use availableProdiles() etc.

Mon, Apr 22, 7:23 AM · Frameworks
dhaumann added a comment to D20697: Review IconBorder.

Did you test that the annotation border still works? You can do so in KDevelop by invoking git blame.

Mon, Apr 22, 7:18 AM · Frameworks, Kate
dhaumann added a comment to D20264: Add test for "Auto Reload Document" option.

Yes, that's exactly what I meant. But if it's not stable, then it does not help. Maybe in that case keep it as is for now?

Mon, Apr 22, 7:13 AM · Frameworks, Kate

Sat, Apr 20

dhaumann accepted D20697: Review IconBorder.

I like the visual change, let's give it a try. Thanks!

Sat, Apr 20, 11:35 PM · Frameworks, Kate

Tue, Apr 16

dhaumann added a comment to D20606: Add action to toggle folding of child ranges.

I would prefer a context menu that has this as action. This is much better discoverable and also extensible with more folding actions.

Tue, Apr 16, 9:44 PM · Frameworks, Kate
dhaumann accepted D20565: Ensure not to fold the end marker.

Yes, I am in favor. thanks

Tue, Apr 16, 9:40 PM · Frameworks, Kate

Mon, Apr 15

dhaumann added a comment to D20534: avoid conflicting shortcuts for switching tabs.

lgtm

Mon, Apr 15, 6:02 PM · Frameworks, Kate

Fri, Apr 12

dhaumann added a comment to D20264: Add test for "Auto Reload Document" option.

I think KateViewInternal::updateView is called for cursor blinking for instance. May that be an issue?

Fri, Apr 12, 9:21 AM · Frameworks, Kate
dhaumann added a comment to D20467: Allow to close a document whose file was deleted on disk.

Hm, the correct fix is to implement this function for KWrite.

Fri, Apr 12, 9:13 AM · Frameworks, Kate
dhaumann accepted D20467: Allow to close a document whose file was deleted on disk.

Looks good to me.

Fri, Apr 12, 4:49 AM · Frameworks, Kate

Wed, Apr 10

dhaumann accepted D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown.

As I understand, one can still disable the indicator if not wanted, right?

Wed, Apr 10, 9:05 PM · Frameworks, Kate
dhaumann accepted D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator.

Let's give this a try.

Wed, Apr 10, 9:03 PM · Frameworks, Kate
dhaumann accepted D20425: KateIconBorder: Code cosmetic.
Wed, Apr 10, 8:55 PM · Frameworks, Kate, KTextEditor

Tue, Apr 9

dhaumann accepted D20394: With Qt >= 5.10.0 use QSortFilterProxyModel instead of KRecursiveFilterProxyModel.

Well, if that works, I don't see an issue with this.

Tue, Apr 9, 8:15 AM · Kate

Sun, Apr 7

dhaumann added a comment to D20343: fix handling of sub modules in git rely on ls-files --recurse-submodules, there since end of 2016.

Thanks for this fix, looks good to me. There is another place in KTextEditor git that uses the -z option to auto reload in case the file is in git. But i guess this does not need a change ?!

Sun, Apr 7, 5:37 PM · Kate

Sat, Apr 6

dhaumann accepted D19438: Add syntax definition for Elm language to syntax-highlighting.

It's also ok to generate the reference data om first commit. Often highlighting contributors do not have a compiling KSyntaxHighlighting git around, so this is a significant hurdle. I'd be fine we commit this as is and add the reference ourselves.

Sat, Apr 6, 7:30 AM · Frameworks, Kate
dhaumann accepted D20264: Add test for "Auto Reload Document" option.

There is a getter bool KateGlobal::self()->unitTestMode(). You could use this in DocumentPrivate to reduce the timer from 3000 to e.g. 50ms or so to reduce testing time.

Sat, Apr 6, 7:20 AM · Frameworks, Kate

Sun, Mar 31

dhaumann added a comment to D17443: Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match.

+1 for Christophs suggestion: Just remove F6 for now, this definitely will not hurt or introduce any shortcut conflict. In addition, I also agree with the changes in the replicode plugin (remove F8 + F9).

Sun, Mar 31, 6:33 PM · Kate
dhaumann added a comment to D19764: Fix Minimap with QtCurve style.

Thanks for the fix.

Sun, Mar 31, 8:07 AM · Frameworks, Kate

Mar 23 2019

dhaumann added a comment to D19876: Fix: apply correctly the text colors of the chosen scheme.

I think such a workaround is ok, but the real issue here is that KTextEditor does not fully use the KSyntaxHighlighting Theme colors. Instead, it still has its own configuration, such that hacks like this are introduced to somehow make it work. But it's just a matter of time until it breaks again.

Mar 23 2019, 9:23 PM · Frameworks, Kate
dhaumann accepted D19974: Add extensions to groovy highlighting.
Mar 23 2019, 9:19 PM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann added a comment to D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0).

Looks good to me. Anyone else?

Mar 23 2019, 4:12 PM · Frameworks, Kate
dhaumann added a comment to D19974: Add extensions to groovy highlighting.

You also have to increase the "version" from 5 to 6. Could you provide an updated patch?

Mar 23 2019, 7:08 AM · Frameworks, Framework: Syntax Highlighting, Kate

Mar 18 2019

dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Require KTextEditor 5.57 and adapt to KTextEditor interface changes
Mar 18 2019, 9:09 PM · Kate
dhaumann added a comment to D19795: Add Variable interface to KTextEditor::Editor.

It's committed now:

  • quoting is now not supported at all anymore
  • expandText() now returns void
Mar 18 2019, 8:59 PM · Frameworks, Kate
dhaumann committed R39:a4083c7cf0d6: Add Variable interface to KTextEditor::Editor (authored by dhaumann).
Add Variable interface to KTextEditor::Editor
Mar 18 2019, 8:58 PM
dhaumann closed D19795: Add Variable interface to KTextEditor::Editor.
Mar 18 2019, 8:58 PM · Frameworks, Kate
dhaumann updated the diff for D19795: Add Variable interface to KTextEditor::Editor.
  • Drop KWordMacroExpander in favor of own simple implementation (50 slocs)
Mar 18 2019, 8:53 PM · Frameworks, Kate

Mar 17 2019

dhaumann planned changes to D19795: Add Variable interface to KTextEditor::Editor.

Will do another change: since recursive expansion of macros is not supported by KMacroExpander (e.g. %{JS:if(true) %{Document:Selection}}), I'll provide an implementation that does not use KMacroExpander at all. Have that working already locally here. Will post an updated patch tomorrow.

Mar 17 2019, 10:30 PM · Frameworks, Kate
dhaumann updated the diff for D19795: Add Variable interface to KTextEditor::Editor.
  • Enum: Use NoQuoting and ShellQuoting
Mar 17 2019, 2:14 PM · Frameworks, Kate
dhaumann added a comment to D19795: Add Variable interface to KTextEditor::Editor.

Hmm. the Variable class and files is just an artifact now or?

Mar 17 2019, 12:48 PM · Frameworks, Kate
dhaumann added a comment to D19491: generic config interface.

Agreed, do you plan to migrate more config options now?

Mar 17 2019, 11:46 AM · Frameworks, Kate
dhaumann updated the diff for D19795: Add Variable interface to KTextEditor::Editor.
  • Support optional quoting, default is Never
Mar 17 2019, 11:45 AM · Frameworks, Kate
dhaumann added a comment to D19795: Add Variable interface to KTextEditor::Editor.

Unfortunately, I still see one issue: In the unit test, expanding the variable to "World" works, but expanding it to "Smart World" leads to single-quoted text "'Smart World'" because of the space. That of course makes sense, but is not always what you want.

Mar 17 2019, 10:14 AM · Frameworks, Kate
dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Use variables from KTextEditor Framework 5.57
Mar 17 2019, 9:58 AM · Kate
dhaumann updated the diff for D19795: Add Variable interface to KTextEditor::Editor.
  • Hide class Variable
Mar 17 2019, 9:27 AM · Frameworks, Kate
dhaumann accepted D19491: generic config interface.

Looks good to me.

Mar 17 2019, 8:21 AM · Frameworks, Kate

Mar 16 2019

dhaumann accepted D19798: Fix Words & Chars String on katestatusbar..
Mar 16 2019, 10:48 AM · Frameworks, Kate

Mar 15 2019

dhaumann added a comment to D19795: Add Variable interface to KTextEditor::Editor.

What I wonder is whether we really need the "Variable" class. Maybe it would be better to just have

  • registerExactMatch(QString name, QString description, function)
  • registerPrefixMatch(QString prefix, QString description, function)
Mar 15 2019, 9:02 PM · Frameworks, Kate
dhaumann requested review of D19795: Add Variable interface to KTextEditor::Editor.
Mar 15 2019, 9:00 PM · Frameworks, Kate

Mar 14 2019

dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Remove hard-coded variables in favor of registering variables
Mar 14 2019, 9:07 PM · Kate

Mar 12 2019

dhaumann added a comment to D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'.

This needs a more detailed review, and currently I find only very few time :( in general, I once tried to fix this bug, but couldn't find a fix. Now you found one - but given this is a very central place I think this needs to be thought through complete prior to committing.

Mar 12 2019, 9:22 PM · Frameworks, Kate
dhaumann updated subscribers of D19408: [RFC] Avoid deadlock in use of vi mode searchbar .

Hm, I currently cannot say anything to this patch. I wonder where the \r comes from. And also, I wonder whether this if now is ever true? ...but if it fixes the issue... @cullmann: objections to a blind commit?

Mar 12 2019, 9:14 PM · Frameworks, Kate

Mar 11 2019

dhaumann accepted D19681: IconBorder: Accept drag&drop events.

Looks ok to me.

Mar 11 2019, 8:44 PM · Frameworks, Kate

Mar 10 2019

dhaumann added a comment to D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt.

Just to be on the safe side: Does this also work, if you have two views visible showing the same document, and then the message appears? Does it also work, if you have two main windows showing the same document (View > New Window)?

Mar 10 2019, 9:20 PM · Frameworks, Kate
dhaumann added inline comments to D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering.
Mar 10 2019, 8:40 PM · Frameworks, Dolphin
dhaumann added inline comments to D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering.
Mar 10 2019, 7:39 PM · Frameworks, Dolphin
dhaumann accepted D19621: ViewPrivate: Make deselection by arrow keys more handy.

Ok with me.

Mar 10 2019, 6:52 PM · Frameworks, Kate
dhaumann added inline comments to D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt.
Mar 10 2019, 6:44 PM · Frameworks, Kate

Mar 9 2019

dhaumann added a comment to D19621: ViewPrivate: Make deselection by arrow keys more handy.

The unit test is good, but it does not yet test the right-to-left case (e.g. arabic text). Could you add one for this as well?

Mar 9 2019, 9:03 PM · Frameworks, Kate
dhaumann updated the summary of D19621: ViewPrivate: Make deselection by arrow keys more handy.
Mar 9 2019, 8:59 PM · Frameworks, Kate
dhaumann added a comment to D19621: ViewPrivate: Make deselection by arrow keys more handy.

Looks good, now just the autotest is missing :-)

Mar 9 2019, 10:43 AM · Frameworks, Kate
dhaumann added a comment to D19621: ViewPrivate: Make deselection by arrow keys more handy.

@brauch I think you misunderstood: Select a text in any Qt application (line edit, ...), and then see what happens if you <cursor left> or <cursor right> without holding shift down. This patch is a good one, we just need to sort out possible regressions, and that's it.

Mar 9 2019, 9:21 AM · Frameworks, Kate
dhaumann added a comment to D19621: ViewPrivate: Make deselection by arrow keys more handy.
  1. Please add a unit test (easy in this case)
  2. Please test with right to left text layout, and mixed text layout.
  3. Please keep the blinking cursor, this would be separate patch anyways.
  4. What happens if you have "persistent selection" enabled?
Mar 9 2019, 7:11 AM · Frameworks, Kate

Mar 8 2019

dhaumann updated the diff for D17971: Revive External Tools plugin.
  • Cleanup What's This tip in Tool Dialog
  • Add a ContextAction that attaches to QLineEdits. Unfortunately QTextEdit (Input) is not a QLineEdit, so we need additional hacks to make ContextAction also attachable to QTextEdit (with additional child widget that is added / removed on focus in / out)
Mar 8 2019, 9:41 PM · Kate

Mar 7 2019

dhaumann added a comment to D19532: Don't crash when no contexts are present.

As you wish.

Mar 7 2019, 1:32 PM · Frameworks, Kate
dhaumann added a comment to D19532: Don't crash when no contexts are present.

Could you change the unit test please to not mix with the other ones?

Mar 7 2019, 8:06 AM · Frameworks, Kate
dhaumann added a comment to D19532: Don't crash when no contexts are present.

Will this fix https://bugs.kde.org/show_bug.cgi?id=401480 ?

Mar 7 2019, 8:01 AM · Frameworks, Kate

Mar 6 2019

dhaumann added a comment to D19480: Quick Open should filter on file path.

@cullmann What's the reason for wanting an option? Is it too slow for big repos such as e.g. the linux kernel git?

Mar 6 2019, 4:06 PM · Kate

Mar 4 2019

dhaumann added a comment to D19491: generic config interface.

Currently, one cannot 'unset' a value, but I guess that is ok, since we did not have that before

Mar 4 2019, 9:37 PM · Frameworks, Kate
dhaumann added a comment to D19017: Make "Save Session" action ask for a name for anonymous sessions.

Could you explain how you now configure the default session or how new sessions look like?

Mar 4 2019, 7:35 AM · Kate

Mar 1 2019

dhaumann accepted D19453: Fix repository deletion warning.
Mar 1 2019, 9:38 PM · Frameworks, Kate
dhaumann added a comment to D19407: ModeBase::goToPos: Ensure jump target is valid.

It's FIXED-IN: 5.56...

Mar 1 2019, 6:54 PM · Frameworks, Kate
dhaumann added a comment to D19438: Add syntax definition for Elm language to syntax-highlighting.

Could you elaborate what Elm is used for?
Also, could you please provide a small test file (also MIT licensed) that we can use for unit testing?

Mar 1 2019, 6:50 PM · Frameworks, Kate

Feb 28 2019

dhaumann added a comment to D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713.

That is a good observation: @cullmann Could you give this partial revert a try?

Feb 28 2019, 9:02 PM · Frameworks, Kate
dhaumann accepted D12336: Replace several Q_ASSERTs with proper checks.

I am very much in favour of this change.

Feb 28 2019, 8:58 PM · Baloo, Frameworks
dhaumann accepted D19416: Restore the search wrapped message to its former type and position..

@neundorf With this we are back to where we came from. Interesting to see how history repeats, and repeats, and repeats... Accepting this change means a wont-fix to your wish to move it to the center.

Feb 28 2019, 8:48 PM · Frameworks, Kate, KTextEditor
dhaumann added a comment to D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713.

We trade one bug for another. Which one is worse?

Feb 28 2019, 8:42 PM · Frameworks, Kate

Feb 25 2019

dhaumann added a comment to D19263: Add more highlighting for nested languages in markdown..

Good idea, thanks.

Feb 25 2019, 7:47 PM · Frameworks, Kate
dhaumann accepted D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713.

Please add the comment as suggested by Thomas.

Feb 25 2019, 10:57 AM · Frameworks, Kate

Feb 24 2019

dhaumann added a comment to D19263: Add more highlighting for nested languages in markdown..

Hi Jos, could you please check again the output of the highlighting indexer?

Feb 24 2019, 6:59 PM · Frameworks, Kate
dhaumann committed R216:df18fada76b2: Install DefinitionDownloader header (authored by dhaumann).
Install DefinitionDownloader header
Feb 24 2019, 6:57 PM
dhaumann closed D19215: Install DefinitionDownloader header.
Feb 24 2019, 6:57 PM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann committed R216:41f4e86ee522: Add unit test for definitionsForFileName() and definitionsForMimeType() (authored by dhaumann).
Add unit test for definitionsForFileName() and definitionsForMimeType()
Feb 24 2019, 6:53 PM
dhaumann closed D19286: Add unit test for definitionsForFileName() and definitionsForMimeType().
Feb 24 2019, 6:53 PM · Frameworks, Kate
dhaumann added a comment to D19215: Install DefinitionDownloader header.

I also do not see an issue with this.

Feb 24 2019, 6:27 PM · Frameworks, Kate, Framework: Syntax Highlighting
dhaumann requested review of D19286: Add unit test for definitionsForFileName() and definitionsForMimeType().
Feb 24 2019, 6:20 PM · Frameworks, Kate
dhaumann added a comment to D19263: Add more highlighting for nested languages in markdown..

Well, if it's fixed by adding the missing reference update then please do so.

Feb 24 2019, 12:50 PM · Frameworks, Kate
dhaumann committed R39:b11afe5a1438: Do not print indent lines (authored by dhaumann).
Do not print indent lines
Feb 24 2019, 11:07 AM
dhaumann closed D19258: Do not print indent lines.
Feb 24 2019, 11:07 AM · Frameworks, Kate
dhaumann added a comment to D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H.

I think that may also fix the case example in https://bugs.kde.org/show_bug.cgi?id=398731

@dhaumann No comment to this? @cullmann May you?

Feb 24 2019, 7:45 AM · Frameworks, Kate
dhaumann accepted D19263: Add more highlighting for nested languages in markdown..
Feb 24 2019, 7:38 AM · Frameworks, Kate
dhaumann added a comment to D19263: Add more highlighting for nested languages in markdown..

Looks good to me, thanks.

Feb 24 2019, 7:37 AM · Frameworks, Kate

Feb 23 2019

dhaumann committed R39:7d9bc72a1bb1: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka… (authored by dhaumann).
KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka…
Feb 23 2019, 8:18 PM
dhaumann closed D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H.
Feb 23 2019, 8:18 PM · Frameworks, Kate
dhaumann accepted D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H.
Feb 23 2019, 8:16 PM · Frameworks, Kate
dhaumann added a comment to D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H.

Looks good to me - thanks.

Feb 23 2019, 8:16 PM · Frameworks, Kate
dhaumann added a comment to D19263: Add more highlighting for nested languages in markdown..

Could you extend autotests/input/test.markdown ?
Then call ./autotests/update-reference-data.sh in the build folder to copy the changes into the src folder, and update this patch.

Feb 23 2019, 8:07 PM · Frameworks, Kate
dhaumann accepted D19197: [File Tree] Add "Open Containing Folder" menu entry.

Good patch, please commit.

Feb 23 2019, 5:20 PM · Kate
dhaumann added a comment to D19254: [RFC] KateRenderer: Show tabs and space characters the smart way.

I think this, since it removes visual clutter. I think this should be configurable...

Feb 23 2019, 5:15 PM · Frameworks, Kate
dhaumann requested review of D19258: Do not print indent lines.
Feb 23 2019, 5:08 PM · Frameworks, Kate
dhaumann accepted D19249: Improve highlighting of TypeScript (and React) and add more tests for PHP.
Feb 23 2019, 1:59 PM · Frameworks, Kate
dhaumann added a comment to D19200: Return sorted definitions for file names and mime types.

Cool, thanks! ...which now leads us to the point where the only missing part is a unit test for the two new public functions :-)

Feb 23 2019, 8:21 AM · Frameworks, Framework: Syntax Highlighting, Kate

Feb 21 2019

dhaumann added inline comments to D19200: Return sorted definitions for file names and mime types.
Feb 21 2019, 10:32 PM · Frameworks, Framework: Syntax Highlighting, Kate

Feb 19 2019

dhaumann added a reviewer for D19168: Fix crash in Dolphin when dropping trashed file in trash: dfaure.
Feb 19 2019, 9:10 PM · Frameworks
dhaumann added a reviewer for D19170: Fix crash while moving files: dfaure.
Feb 19 2019, 9:09 PM · Frameworks
dhaumann added inline comments to D19170: Fix crash while moving files.
Feb 19 2019, 8:54 PM · Frameworks
dhaumann added a comment to D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline.

Btw, searching in lxr.kde.org for FontUnderline reveals some more hits: https://lxr.kde.org/ident?_i=FontUnderline&_remember=1

Feb 19 2019, 8:40 PM · Frameworks, Kate
dhaumann added a comment to D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline.

This patch looks good to me, even though I cannot reproduce the issue following the steps in https://bugs.kde.org/show_bug.cgi?id=399278.

Feb 19 2019, 8:39 PM · Frameworks, Kate