dhaumann (Dominik Haumann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 20 2015, 7:20 AM (182 w, 3 d)
Availability
Available

Recent Activity

Yesterday

dhaumann added a comment to D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.

Hi Gregor, I just did a post-review again, and noticed several issues I think we should address. I have a patch ready for most of the stuff, but did not yet post it on Phabricator, since I indeed use KTextEditor::Document as member pointer in the FileListItem, and its constructor now reads the icon etc from the document, which destroys the tsttestapp demo. So the comments are just here to make you aware of the issues. We can have the real discussion when I post the patch.

Wed, Oct 17, 9:00 PM · Kate
dhaumann accepted D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.

Feel free to push this for 5.52 (you'd have to adapt the @since 5.53 again).

Wed, Oct 17, 6:31 PM · Frameworks, Kate
dhaumann added a comment to D16259: Open document before using it's checksum to load metainfos.

@slenz Thanks for this nice patch, please keep it coming :-)

Wed, Oct 17, 5:55 PM · Kate
dhaumann added a comment to D16204: Quick Open: Remove file:/// prefix.

Do you have to rebase your patch now that the other patch is in?

Wed, Oct 17, 11:27 AM · Kate

Mon, Oct 15

dhaumann added inline comments to D15804: Fix Duplicates on Quick Open File.
Mon, Oct 15, 7:34 PM · Kate
dhaumann accepted D16215: Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp.

The title "Cleanup" is a bit too generic imho. Better eould be something along the lines "Ceanup: Merge main() into unit test tsttestapp.cpp" along with a detailed description :) Maybe something for future commits? Good enough this time, but for commits in KDE Frameworks this would not be good enough, since "Cleanup" would then end up in David's changelog, which is too generic (cleanup of what?).

Mon, Oct 15, 7:32 PM · Kate
dhaumann accepted D16214: New Tabswitcher: Fix cut-off path strings.

I would prefer that the contents of main.cpp goes to tstestapp.cpp, since this would allow to have multiple tests over time. But this can be done in a separate patch, please push.

Mon, Oct 15, 1:05 AM · Kate
dhaumann updated subscribers of D16204: Quick Open: Remove file:/// prefix.

@tcanabrava Does this clash with your patch in D15804 ?

Mon, Oct 15, 12:56 AM · Kate
dhaumann accepted D16209: tabswitchertest: use QFETCH.

Looks good, please push.

Mon, Oct 15, 12:51 AM · Kate

Sat, Oct 13

dhaumann added a comment to D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.

Yes, please push. In a separate patch, could you possibly look at KateTabSwitcherTest::testLongestCommonPrefix() again? It looks as if you could use QFETCH along eith a function KateTabSwitcherTest::testLongestCommonPrefix_data()? QFETCH is typically used when testing a data set.

Sat, Oct 13, 4:40 PM · Kate

Wed, Oct 10

dhaumann added a comment to D13541: Port solid from Qt5::Widgets to Qt5::Gui.

@graesslin ping

Wed, Oct 10, 7:56 PM · Frameworks

Tue, Oct 9

dhaumann added a comment to D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.

I like it, definitely an improvement.

Tue, Oct 9, 1:49 AM · Kate

Fri, Oct 5

dhaumann added a comment to D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.

If Christoph accepts, I am fine with this.

Fri, Oct 5, 11:32 PM · Frameworks, Kate
dhaumann added a comment to D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.

Hm, given the size of the patch, and given it introduces new public API we cannot easily change, I think a silent +1 since noone reacts is not good enough.

Fri, Oct 5, 11:31 PM · Frameworks, Kate

Wed, Oct 3

dhaumann added a comment to D15909: Fix compile failure on Windows targets.

Btw, can you commit yourself, or shall we push this? If so, can someone take care of this, since I am not available for the next 10 days.

Wed, Oct 3, 7:14 AM · Frameworks
dhaumann accepted D15909: Fix compile failure on Windows targets.

Lgtm.

Wed, Oct 3, 7:12 AM · Frameworks
dhaumann added a comment to D15194: Draw a line separating PlasmaComponents tab bar from its content area.

Hm, two separator lines, even touching each other sounds like a hack. Is there no better way?

Wed, Oct 3, 7:09 AM · Frameworks

Mon, Oct 1

dhaumann added a comment to D15292: Use lambdas instead of QSignalMapper.

Commit e261f1ff048815656aedcaef0e55b28863440639

Mon, Oct 1, 8:43 PM · Kate

Sun, Sep 30

dhaumann added a comment to T9771: Main context can be #poped.

Fixed, see 9e039a669f8f34591c12e433cba1c97a11645c5d

Sun, Sep 30, 10:13 AM · Framework: Syntax Highlighting
dhaumann moved T9771: Main context can be #poped from Backlog to Done on the Framework: Syntax Highlighting board.
Sun, Sep 30, 10:12 AM · Framework: Syntax Highlighting
dhaumann triaged T9775: Integrate Fortran Free/Fixed as Low priority.
Sun, Sep 30, 10:11 AM · Framework: Syntax Highlighting
dhaumann committed R216:aedf21f9b42e: Fortran: Highlight alerts in comments (authored by dhaumann).
Fortran: Highlight alerts in comments
Sun, Sep 30, 7:36 AM

Sat, Sep 29

dhaumann moved T3780: Add definition lookup by mimetype to Repository from Backlog to Done on the Framework: Syntax Highlighting board.
Sat, Sep 29, 3:02 PM · Framework: Syntax Highlighting
dhaumann moved T4521: Fix the Praat highlighting regression from Backlog to Done on the Framework: Syntax Highlighting board.
Sat, Sep 29, 3:02 PM · Framework: Syntax Highlighting
dhaumann moved T7320: C++/C/C# syntax highlighting uses dsSpecialString for normal "String Char"s? from Backlog to Done on the Framework: Syntax Highlighting board.
Sat, Sep 29, 3:02 PM · Framework: Syntax Highlighting
dhaumann moved T9455: MIT relicensing from Backlog to Done on the Framework: Syntax Highlighting board.
Sat, Sep 29, 3:01 PM · Framework: Syntax Highlighting
dhaumann moved T9539: Optimize syntax highlighting framework from Backlog to Done on the Framework: Syntax Highlighting board.
Sat, Sep 29, 3:01 PM · Framework: Syntax Highlighting
dhaumann closed T3780: Add definition lookup by mimetype to Repository as Resolved.

We have Repository::definitionForMimetype() since KF 5.50:
https://api.kde.org/frameworks/syntax-highlighting/html/classKSyntaxHighlighting_1_1Repository.html#ad439853d5314ccaac1b8d6cc465efd05

Sat, Sep 29, 3:01 PM · Framework: Syntax Highlighting
dhaumann accepted D15525: Fix rendering Aztec codes with an aspect ratio != 1.
Sat, Sep 29, 8:53 AM · Frameworks
dhaumann added a comment to T9539: Optimize syntax highlighting framework.

Is this task done?

Sat, Sep 29, 7:59 AM · Framework: Syntax Highlighting
dhaumann triaged T9771: Main context can be #poped as High priority.
Sat, Sep 29, 7:58 AM · Framework: Syntax Highlighting

Fri, Sep 28

dhaumann added a comment to D15804: Fix Duplicates on Quick Open File.

Indeed I just ported a QStandardItemModel to a QAbstractItemModel. The speed gain was huge since many QString -> QVariant conversions are not needed anymore. Do you see this in perf as well?

Fri, Sep 28, 8:49 PM · Kate

Wed, Sep 26

dhaumann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

@cullmann Can you make a decision? I trust it will be a good one ;)

Wed, Sep 26, 8:28 PM · Frameworks, Kate
dhaumann accepted D15771: Logcat & SELinux: improvements for the new Solarized schemes.
Wed, Sep 26, 8:27 PM · Frameworks, Kate
dhaumann added a comment to D15780: YAML: add literal & folded block styles.

I cannot really say much about it, since I never use YAML. Still, if the unit test works, then I am fine with this.

Wed, Sep 26, 8:22 PM · Frameworks, Kate

Tue, Sep 18

dhaumann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

@cullmann If the other solution is easier to maintain then I am fine with this. Still, I would like to avoid that includedDefinitions() for sass returns css just because of keywords. In fact, that was my main motivation for this solution.

Tue, Sep 18, 10:06 PM · Frameworks, Kate

Sep 16 2018

dhaumann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

Yes, and calling loadKeywords would only do work the first time.

Sep 16 2018, 9:27 PM · Frameworks, Kate
dhaumann committed R216:b1da54ab91e3: Fix: Email highlighting for unclosed parenthesis in Subject header (authored by dhaumann).
Fix: Email highlighting for unclosed parenthesis in Subject header
Sep 16 2018, 6:48 PM
dhaumann closed D15556: Fix: Email highlighting for unclosed parenthesis in Subject header.
Sep 16 2018, 6:48 PM · Frameworks, Kate
dhaumann requested review of D15556: Fix: Email highlighting for unclosed parenthesis in Subject header.
Sep 16 2018, 6:05 PM · Frameworks, Kate
dhaumann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

To be clear, currently we have two states:

  • load metadata only
  • lazy load full file
Sep 16 2018, 8:43 AM · Frameworks, Kate
dhaumann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

This was also my interpretation: only include the Definitions that use itemDatas / colors.

Sep 16 2018, 8:36 AM · Frameworks, Kate

Sep 15 2018

dhaumann accepted D13880: [KMoreTools] Reduce menu hierarchy.
Sep 15 2018, 8:42 PM · Frameworks
dhaumann added a comment to D9987: Lessen log spam by not checking for existence of file with empty name.

FYI: This now landed with 88be459559448d9d30b33f33b3ffd31fc41327c7 (cf. https://commits.kde.org/kinit/88be459559448d9d30b33f33b3ffd31fc41327c7)

Sep 15 2018, 8:39 PM · Frameworks
dhaumann committed R303:88be45955944: Lessen log spam by not checking for existence of file with empty name (authored by rkflx).
Lessen log spam by not checking for existence of file with empty name
Sep 15 2018, 8:37 PM
dhaumann added a comment to T9577: Publish Kate in the Microsoft Store.

Btw, a sophisticated list of features is available on https://kate-editor.org/about-kate/

Sep 15 2018, 8:20 PM · KDE Promo, Kate, Windows
dhaumann added a comment to D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.

I commented on some things - I did not try this, though.

Sep 15 2018, 8:17 PM · Frameworks, Kate

Sep 13 2018

dhaumann added inline comments to D13880: [KMoreTools] Reduce menu hierarchy.
Sep 13 2018, 8:31 PM · Frameworks
dhaumann added a comment to D13880: [KMoreTools] Reduce menu hierarchy.

Almost good enough, can you remove the forward declaration again? Just another one-line change. I then don't have any objections anymore.

Sep 13 2018, 8:30 PM · Frameworks
dhaumann committed R39:6a35a902c969: Paint code folding marker only for multiline code folding regions (authored by dhaumann).
Paint code folding marker only for multiline code folding regions
Sep 13 2018, 7:08 PM
dhaumann closed D15485: Paint code folding marker only for multiline code folding regions.
Sep 13 2018, 7:08 PM · Frameworks, Kate
dhaumann updated the diff for D15485: Paint code folding marker only for multiline code folding regions.

Correct patch as discussed

Sep 13 2018, 7:01 PM · Frameworks, Kate
dhaumann added a comment to D15485: Paint code folding marker only for multiline code folding regions.

Btw, this is a regression from the switch to the KSyntaxHighlighting framework. Maybe there is a better fix?

Sep 13 2018, 6:39 PM · Frameworks, Kate
dhaumann updated the summary of D15485: Paint code folding marker only for multiline code folding regions.
Sep 13 2018, 6:37 PM · Frameworks, Kate
dhaumann requested review of D15485: Paint code folding marker only for multiline code folding regions.
Sep 13 2018, 6:33 PM · Frameworks, Kate

Sep 11 2018

dhaumann added a comment to D15380: Add reset font size shortcut.

Ctrl+shift+0 is much better than the +r variants. +r typically is used for reloading/refreshing. If we cannot find a better solution, then having no default shortcut would also be an option.

Sep 11 2018, 8:45 PM · Documentation, Konsole

Sep 10 2018

dhaumann added a reviewer for D15407: Fix OCS provider URL in about dialog: alexanderschmidt.
Sep 10 2018, 5:37 PM · Frameworks
dhaumann accepted D15390: Bash: fix parameter & brace expansion.

+1, thanks.

Sep 10 2018, 5:59 AM · Frameworks, Kate

Sep 9 2018

dhaumann added a comment to D15383: Add editorconfig.

I think the idea in general is good. +1 from my side, things can still be improved later if it turns out that it does not work.

Sep 9 2018, 10:43 PM · Konsole
dhaumann added a comment to D15380: Add reset font size shortcut.

To me, Ctral+0 would be the correct choice. So +1 from my side.

Sep 9 2018, 10:38 PM · Documentation, Konsole
dhaumann committed R39:af5ebba716f5: Scripting: isCode() returns false for dsAlert text (authored by dhaumann).
Scripting: isCode() returns false for dsAlert text
Sep 9 2018, 10:37 AM
dhaumann closed D15370: Scripting: isCode() returns false for dsAlert text.
Sep 9 2018, 10:37 AM · Frameworks, Kate
dhaumann requested review of D15370: Scripting: isCode() returns false for dsAlert text.
Sep 9 2018, 10:11 AM · Frameworks, Kate
dhaumann committed R216:58ce23f7fdb9: Unit test: Check all shipped themes for completeness (authored by dhaumann).
Unit test: Check all shipped themes for completeness
Sep 9 2018, 7:23 AM
dhaumann closed D15358: Unit test: Check all shipped themes for completeness.
Sep 9 2018, 7:23 AM · Frameworks, Kate
dhaumann added a comment to D15340: Add Solarized Light and Dark themes.

Sure, please use kdesrc-build as described here:
https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source

Sep 9 2018, 7:00 AM · Framework: Syntax Highlighting, Frameworks, Kate

Sep 8 2018

dhaumann added a comment to D15340: Add Solarized Light and Dark themes.

Btw, we forgot to add the themes to the Qt resource file, see also D15358

Sep 8 2018, 8:16 PM · Framework: Syntax Highlighting, Frameworks, Kate
dhaumann updated the diff for D15358: Unit test: Check all shipped themes for completeness.
  • Merge branch 'master' into check-themes
  • Include Solarized color themes
Sep 8 2018, 8:11 PM · Frameworks, Kate
dhaumann added a comment to D15340: Add Solarized Light and Dark themes.

See D15358 :-)

Sep 8 2018, 8:08 PM · Framework: Syntax Highlighting, Frameworks, Kate
dhaumann added a comment to D15358: Unit test: Check all shipped themes for completeness.

Example output:

Sep 8 2018, 8:08 PM · Frameworks, Kate
dhaumann requested review of D15358: Unit test: Check all shipped themes for completeness.
Sep 8 2018, 8:06 PM · Frameworks, Kate
dhaumann accepted D15340: Add Solarized Light and Dark themes.

Looks good to me.

Sep 8 2018, 6:46 AM · Framework: Syntax Highlighting, Frameworks, Kate

Sep 7 2018

dhaumann accepted D15337: Fix Solarized Light and Dark color schemes.

Looks good to me. Can you commit yourself?

Sep 7 2018, 9:41 PM · KTextEditor, Frameworks, Kate
dhaumann added a comment to D15337: Fix Solarized Light and Dark color schemes.

Solarized dark still only has 28 colors, right? Can you add the missing ones?

Sep 7 2018, 9:06 PM · KTextEditor, Frameworks, Kate
dhaumann added inline comments to D15337: Fix Solarized Light and Dark color schemes.
Sep 7 2018, 8:05 PM · KTextEditor, Frameworks, Kate
dhaumann added a comment to D15337: Fix Solarized Light and Dark color schemes.

Thanks for working on this. Looks good to me - just a minor question about the section for Solarized light.

Sep 7 2018, 7:08 PM · KTextEditor, Frameworks, Kate

Sep 5 2018

dhaumann updated subscribers of D7010: KSqueezedTextLabel: call updateGeometry() when text changes.

@dfaure: writing "Henrik" when he already unsubscribeb will never reach him. Ping @rkflx

Sep 5 2018, 6:53 PM · Frameworks

Sep 4 2018

dhaumann accepted D15274: Don't require Qt5::XmlPatterns.

Is this due to drop of own hl implementation? In any case, lgtm.

Sep 4 2018, 5:26 PM · Frameworks, Kate

Sep 3 2018

dhaumann added inline comments to R216:376311622d37: forbid sub-rules.
Sep 3 2018, 7:18 AM
dhaumann added a comment to T9539: Optimize syntax highlighting framework.

Btw, did you try using QRegExp just for testing the speed difference? If the behavior is the same, we could even consider using that as long as it still exists...

Sep 3 2018, 6:58 AM · Framework: Syntax Highlighting

Sep 2 2018

dhaumann added a comment to D15211: ::match and ::doMatch => const.

@cullmann Can you update the docbook in kate.git/doc/ so that the documentation about writing syntax highlighting files keeps up to date also for the dynamic changes?

Sep 2 2018, 9:14 AM · Frameworks, Kate

Aug 30 2018

dhaumann added a comment to D15157: [KMountPoint] Remove AIX support.

BTW: did you grep for other locations in kio for "_AIX"? Might make sense.

Aug 30 2018, 8:35 PM · Frameworks
dhaumann accepted D15157: [KMountPoint] Remove AIX support.

I guess this makes sense. One could add a #error in case of someone trying to build on aix, but it's probably overkill.

Aug 30 2018, 8:34 PM · Frameworks
dhaumann accepted D15158: [KMountPoint] Remove Windows CE support.

Makes sense

Aug 30 2018, 8:31 PM · Frameworks

Aug 28 2018

dhaumann accepted D15134: decrease StateData space by more than 50% and half the number of needed mallocs.

Lgtm.

Aug 28 2018, 9:57 PM · Frameworks, Kate
dhaumann added a comment to D15129: improve performance of Rule::isWordDelimiter and KeywordListRule::doMatch.

Very nice.

Aug 28 2018, 9:52 PM · Frameworks, Kate

Aug 27 2018

dhaumann added a comment to D14855: Add applet with screen layouts and presentation mode.

@broulik Could we clarify the copyright?

Aug 27 2018, 12:05 PM · Plasma

Aug 26 2018

dhaumann updated subscribers of D15081: replace own wildcard matcher with QRegularExpression combining all wildcards.

Do you need the public methods in Definition outside of KSyntaxHighlighting?

Aug 26 2018, 12:21 AM · Frameworks, Kate
dhaumann added a comment to D9987: Lessen log spam by not checking for existence of file with empty name.

@rkflx can you please reopen so we can accept this?

Aug 26 2018, 12:09 AM · Frameworks

Aug 25 2018

dhaumann added a comment to D15081: replace own wildcard matcher with QRegularExpression combining all wildcards.

The old wildcard matcher existed for performance reasons. Did you check?

Aug 25 2018, 3:44 PM · Frameworks, Kate
dhaumann updated subscribers of D9987: Lessen log spam by not checking for existence of file with empty name.

@rkflx I think this patch is definitely good enough to not let it go.

Aug 25 2018, 1:19 PM · Frameworks
dhaumann added a comment to D6695: Fix text labels in sidebar occasionally rendering cut off.

Was this resolved, or did you give up?

Aug 25 2018, 6:12 AM · Okular

Aug 24 2018

dhaumann closed D14978: Add unit test that checks Format data.
Aug 24 2018, 6:45 AM · Frameworks, Kate
dhaumann committed R216:e4d317da92a1: Add unit test that checks Format data (authored by dhaumann).
Add unit test that checks Format data
Aug 24 2018, 6:45 AM
dhaumann updated the diff for D14978: Add unit test that checks Format data.
  • Verify Definition::formats() contain all formats from 1...N
Aug 24 2018, 6:00 AM · Frameworks, Kate

Aug 22 2018

dhaumann added a comment to D14978: Add unit test that checks Format data.

True, agreed. And it was an ugly workaround in the first place.

Aug 22 2018, 7:06 PM · Frameworks, Kate
dhaumann accepted D15002: Allow to install syntax files instead of having them in a resource.
Aug 22 2018, 7:05 PM · Frameworks, Kate
dhaumann added a comment to D15002: Allow to install syntax files instead of having them in a resource.

BTW, slightly related as idea: I think it would be nice to add a function Definition Downloader::setDownloadLocation() or similar that allows to have a custom download location. This would match nicely with Repository::addCustomSearchPath().

Aug 22 2018, 4:01 PM · Frameworks, Kate
dhaumann added a comment to D15002: Allow to install syntax files instead of having them in a resource.

I am fine with this change. I want a review from Volker, through .

Aug 22 2018, 3:57 PM · Frameworks, Kate

Aug 21 2018

dhaumann added a comment to D14978: Add unit test that checks Format data.

The problem likely was that Alerts.xml does not have the indentationBasedFolding attribute set. But it's needed in e.g. Python.

Aug 21 2018, 7:26 PM · Frameworks, Kate