dhaumann (Dominik Haumann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 20 2015, 7:20 AM (173 w, 3 d)
Availability
Available

Recent Activity

Yesterday

dhaumann committed R216:d26db324e4a9: Relicense Dockerfile to MIT license (authored by dhaumann).
Relicense Dockerfile to MIT license
Thu, Aug 16, 9:18 PM
dhaumann moved T3974: API in Definition for comments from Backlog to Done on the Framework: Syntax Highlighting board.
Thu, Aug 16, 7:06 PM · Framework: Syntax Highlighting
dhaumann added a comment to D14826: inline note interface wip #2.

I think one more iteration, and this can be merged. Can you look into this again?

Thu, Aug 16, 3:57 PM · Frameworks, Kate
dhaumann committed R39:190a5a845eab: Show text preview only if main window is active (authored by dhaumann).
Show text preview only if main window is active
Thu, Aug 16, 8:38 AM

Wed, Aug 15

dhaumann committed R39:9c035669190b: Fix crash when hiding the TextPreview widget (authored by dhaumann).
Fix crash when hiding the TextPreview widget
Wed, Aug 15, 9:51 PM
dhaumann added a comment to D14826: inline note interface wip #2.

I think this goes into the right direction :-)

Wed, Aug 15, 7:34 PM · Frameworks, Kate
dhaumann added a comment to D14856: Search: Add workaround for missing icons in Gnome icon-theme.

True... Is this a performance issue? ;)

Wed, Aug 15, 6:05 PM · Frameworks, Kate
dhaumann committed R39:36f03120889b: Improve vim color theme (authored by dhaumann).
Improve vim color theme
Wed, Aug 15, 9:38 AM
dhaumann added inline comments to D14856: Search: Add workaround for missing icons in Gnome icon-theme.
Wed, Aug 15, 8:57 AM · Frameworks, Kate
dhaumann accepted D14856: Search: Add workaround for missing icons in Gnome icon-theme.

Albeit a bi hacky, if that helps Kate users on Gnome, I am fine with this.

Wed, Aug 15, 8:53 AM · Frameworks, Kate
dhaumann added a comment to D12587: Indentation script for R.

@devillemereuil That is good to hear. If you can, feel free to paste a MIT-licensed snippet of R-code with a function, a loop, a if-condition etc. Maybe we find the time to turn this into a unit test. The code does not need to run, it just needs to be syntactically correct.

Wed, Aug 15, 8:50 AM · Frameworks, Kate
dhaumann added a comment to D11838: Turn on line numbers by default.

@mludwig @cullmann Sorry, what I wrote is not correct, since this change is in Kate, not KTextEditor. Sorry for the noise... :)

Wed, Aug 15, 8:09 AM · Frameworks, Kate
dhaumann added a comment to D11838: Turn on line numbers by default.

Just to make everyone aware of what this implies:

  1. Every application now has a separate KTextEditor configuration
  2. Every application now has line numbers on by default (that includes Kile)
Wed, Aug 15, 8:07 AM · Frameworks, Kate

Tue, Aug 14

dhaumann accepted D7087: Add "Copy Info" button to the About System KCM.

Ok from my side, although it still *feels* a bit messy :-)

Tue, Aug 14, 8:10 PM · Plasma
dhaumann abandoned D6473: Crash when replacing new lines with spaces.

Fixed in D14847 in a different way.

Tue, Aug 14, 4:26 PM · Kate, Frameworks
dhaumann commandeered D6473: Crash when replacing new lines with spaces.

Reassign

Tue, Aug 14, 4:26 PM · Kate, Frameworks
dhaumann closed D14847: Fix crash when replacing \n around empty lines.
Tue, Aug 14, 4:25 PM · Frameworks, Kate
dhaumann committed R39:c90064799dfb: Fix crash when replacing \n around empty lines (authored by dhaumann).
Fix crash when replacing \n around empty lines
Tue, Aug 14, 4:25 PM
dhaumann updated the diff for D14847: Fix crash when replacing \n around empty lines.
  • Optimize by checking isEmpty()
Tue, Aug 14, 4:24 PM · Frameworks, Kate
dhaumann requested review of D14847: Fix crash when replacing \n around empty lines.
Tue, Aug 14, 4:20 PM · Frameworks, Kate
dhaumann accepted D8964: Fix two bugs in KMessageWidget.

I just tested again with KWrite - I think it behaves good there.

Tue, Aug 14, 3:00 PM · Frameworks
dhaumann added a comment to D6473: Crash when replacing new lines with spaces.

Hm, can you send a patch that fixes this? :-)

Tue, Aug 14, 2:41 PM · Kate, Frameworks
dhaumann committed R216:9e9b48775cf3: Relicense Powershell to MIT license (authored by dhaumann).
Relicense Powershell to MIT license
Tue, Aug 14, 2:39 PM
dhaumann requested changes to D6473: Crash when replacing new lines with spaces.

I was just about to merge this patch. But the crash still happens for me also with this patch - so it's still not fixed.

Tue, Aug 14, 1:54 PM · Kate, Frameworks
dhaumann accepted D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle).

I guess ok - if issues arise, we have to fix them :-)

Tue, Aug 14, 1:32 PM · Kate, Frameworks
dhaumann accepted D7245: Improve reStructuredText highlighting.

Sorry for the delay. Shall we take care of this?

Tue, Aug 14, 1:31 PM · Frameworks
dhaumann committed R40:f84f71a5cb1d: Improve highlighting screenshots (authored by dhaumann).
Improve highlighting screenshots
Tue, Aug 14, 1:25 PM
dhaumann committed R40:c07523227d1c: Downloading syntax highlighting was removed in KTextEditor 5.50 (authored by dhaumann).
Downloading syntax highlighting was removed in KTextEditor 5.50
Tue, Aug 14, 12:50 PM
dhaumann accepted D14828: remove highlighting download dialog.

Looks good. But along with this change, please change the docbook in kate.git:

Tue, Aug 14, 12:43 PM · Frameworks, Kate
dhaumann committed R216:857a277110d5: Relicense modelines.xml to MIT license (authored by dhaumann).
Relicense modelines.xml to MIT license
Tue, Aug 14, 12:15 PM
dhaumann closed D14824: Relicense modelines.xml to MIT license.
Tue, Aug 14, 12:15 PM · Frameworks, Kate
dhaumann added a comment to D14824: Relicense modelines.xml to MIT license.

Thanks, Martin just change the kateversion number, which was changed again later by us again. So I will proceed now. Thanks.

Tue, Aug 14, 12:15 PM · Frameworks, Kate
dhaumann committed R216:01e401b0203e: Relicense QML highlighting to MIT license (authored by dhaumann).
Relicense QML highlighting to MIT license
Tue, Aug 14, 12:10 PM
dhaumann added a comment to D14824: Relicense modelines.xml to MIT license.

For those who are curious: This change is required since modelines.xml is a file that is included in many other xml files via IncludeRules. Given our policy of new highlighting files should be MIT licensed, this also applies to included definitions. That's why this relicensing is being done for this file. Your support is very much appreciated here.

Tue, Aug 14, 11:54 AM · Frameworks, Kate
dhaumann requested review of D14824: Relicense modelines.xml to MIT license.
Tue, Aug 14, 10:13 AM · Frameworks, Kate
dhaumann committed R216:09ea082abdb0: Definition: Improve API documentation (authored by dhaumann).
Definition: Improve API documentation
Tue, Aug 14, 9:07 AM

Mon, Aug 13

dhaumann committed R216:581e41dfd3ac: Add QVector<QPair<QChar, QString>> Definition::characterEncodings() const (authored by dhaumann).
Add QVector<QPair<QChar, QString>> Definition::characterEncodings() const
Mon, Aug 13, 8:35 PM
dhaumann closed D14808: Add QVector<QPair<QChar, QString>> Definition::characterEncodings() const.
Mon, Aug 13, 8:35 PM · Frameworks, Kate
dhaumann requested review of D14808: Add QVector<QPair<QChar, QString>> Definition::characterEncodings() const.
Mon, Aug 13, 8:32 PM · Frameworks, Kate
dhaumann committed R39:518231a471da: Fix signed vs unsigned conversion warning (authored by dhaumann).
Fix signed vs unsigned conversion warning
Mon, Aug 13, 7:30 PM
dhaumann added a comment to D11838: Turn on line numbers by default.

We now have application-local settings. What now? Are we closer to solving this? ...I guess not: Either it's on for all applications or off for all applications. The user still needs to set this up. @cullmann and @ngraham Any comments? ;)

Mon, Aug 13, 7:27 PM · Frameworks, Kate
dhaumann committed R216:e2304bb5bab4: GIT_SILENT: fix typo (authored by dhaumann).
GIT_SILENT: fix typo
Mon, Aug 13, 7:14 PM
dhaumann committed R216:de651c8cb6b3: Add bool Definition::foldingEnabled() const (authored by dhaumann).
Add bool Definition::foldingEnabled() const
Mon, Aug 13, 7:11 PM
dhaumann closed D14799: Add bool Definition::foldingEnabled() const.
Mon, Aug 13, 7:11 PM · Frameworks, Kate
dhaumann added a comment to D14803: Use non-deprecated version of KRun::runUrl() in modified-on-disk dialog.

...which raises the question of the minimum required Frameworks version needed by the KDE Application release.

Mon, Aug 13, 6:56 PM · Kate
dhaumann accepted D7033: Port ki18n from QtScript to QtQml.

I guess it's better to accept this now than later to have a longer testing period at Akademy and until the frameworks release.

Mon, Aug 13, 4:56 PM · Frameworks
dhaumann updated the diff for D14799: Add bool Definition::foldingEnabled() const.
  • Add another test, now all code paths are tested
Mon, Aug 13, 4:47 PM · Frameworks, Kate
dhaumann requested review of D14799: Add bool Definition::foldingEnabled() const.
Mon, Aug 13, 4:42 PM · Frameworks, Kate
dhaumann added a comment to D13880: [KMoreTools] Reduce menu hierarchy.

Ok - then with minor changes, let's move this forward. Who is going to do the work? :-)

Mon, Aug 13, 2:16 PM · Frameworks
dhaumann updated the diff for D9247: Extend Scripting API to allow executing commands.
  • Apply proposed fixes
  • Merge branch 'master' into CommandScript
Mon, Aug 13, 10:15 AM · Frameworks, Kate
dhaumann added a comment to D12131: Use file mode in Preview add-on.

@kossebau Akademy is in full swing, and we try to get the review requests down. Could you move this forward? Would be really nice :-)

Mon, Aug 13, 9:57 AM · Kate
dhaumann added a comment to D13880: [KMoreTools] Reduce menu hierarchy.

What is the current state of this? The new private functions should move to the pimpl class behind the d-pointer.

Mon, Aug 13, 9:55 AM · Frameworks
dhaumann committed R216:42259b660801: GIT_SILENT: Add note about KF6 cleanup (authored by dhaumann).
GIT_SILENT: Add note about KF6 cleanup
Mon, Aug 13, 9:53 AM
dhaumann committed R39:9b0d8dce4977: Printing: Respect footer font, fix footer vertical position, make header/footer… (authored by dhaumann).
Printing: Respect footer font, fix footer vertical position, make header/footer…
Mon, Aug 13, 9:46 AM
dhaumann closed D4619: Printing: Respect footer font, fix footer vertical position, make header/footer separator line visually lighter.
Mon, Aug 13, 9:46 AM · Kate, Frameworks
dhaumann accepted D4619: Printing: Respect footer font, fix footer vertical position, make header/footer separator line visually lighter.

Tested again, certainly an improvement. If we find more issues, we can still improve.

Mon, Aug 13, 9:46 AM · Kate, Frameworks
dhaumann added a comment to D14593: Update Logtalk language syntax support.

Thanks goes to do - and sorry for the delay on our side.

Mon, Aug 13, 9:16 AM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann committed R216:2ce2523452eb: Update Logtalk language syntax support (authored by dhaumann).
Update Logtalk language syntax support
Mon, Aug 13, 9:15 AM
dhaumann closed D14593: Update Logtalk language syntax support.
Mon, Aug 13, 9:15 AM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann accepted D11543: Optimize many syntax highlighting files and fix the '/' char of SQL.

Thanks, changes look, please commit (after running make test) :-)

Mon, Aug 13, 9:10 AM · Kate, Framework: Syntax Highlighting, Frameworks
dhaumann accepted D14593: Update Logtalk language syntax support.

Shall we integrate this, or can you commit yourself?

Mon, Aug 13, 9:06 AM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann added a comment to D14593: Update Logtalk language syntax support.

Ok, perfect, thanks! I think "Apache License 2.0" is fine as well. It's just important that we do know the license, because otherwise it's a mess over time.

Mon, Aug 13, 8:54 AM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann added a comment to D14593: Update Logtalk language syntax support.

Just curious: The test file looks good to me, but it looks to me that it also contains some redundancy: Think of it as follows: We use this for unit testing. As such, the best case is that a test file tests all the corner cases, but ideally only once. If a test fails, then we get a diff with the changed highlighting information. And if the file is 400 lines of code, checking for regressions is much more work compared to if the file only contains e.g. 50 lines. So: would it be possible to strip it down a bit? And also: Is this file freely usable, e.g. licensed under MIT? Would be nice to add a license comment in the first line.

Mon, Aug 13, 8:37 AM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann added a comment to D14758: use view lines for wheel scrolling, not real lines.

@ngraham If you blog about it, feel free to explicitly mention that this is hopefuly very useful for the LaTeX community using Kile.

Mon, Aug 13, 8:26 AM · Frameworks, Kate
dhaumann accepted D14758: use view lines for wheel scrolling, not real lines.

For me this works. It would be nice to get more feedback, but to be honest, I think we only get this feedback by integrating this patch and let the users test it. It's certainly not broken and fixes a usability issue we've had for a log time.

Mon, Aug 13, 8:23 AM · Frameworks, Kate
dhaumann added a comment to D14274: Modelines: add byte-order-mark & small fixes.

Sidenote: Looking into the code in KTextEditor, there is:

Mon, Aug 13, 6:32 AM · Frameworks, Kate
dhaumann committed R40:938ed4958403: Improve wording for indenter attribute (authored by dhaumann).
Improve wording for indenter attribute
Mon, Aug 13, 6:24 AM
dhaumann committed R40:8dba96723008: Adapt highlighting Meta DTD for XML completion plugin (authored by dhaumann).
Adapt highlighting Meta DTD for XML completion plugin
Mon, Aug 13, 6:24 AM
dhaumann committed R216:2d8e0fc3bf6a: C# highlighting: Prefer C-Style indenter (authored by dhaumann).
C# highlighting: Prefer C-Style indenter
Mon, Aug 13, 6:20 AM
dhaumann added a comment to D14761: quickopen: optimize: remove model from SortFilter proxy model during populate.

Nice patch. Please add a comment:
// Temporarily remove source model to avoid triggering unnecessary internal updates all the time

Mon, Aug 13, 5:39 AM · Kate

Sun, Aug 12

dhaumann committed R40:ecf70743f4e7: indentation moved as "indenter" to the language element already years ago (authored by dhaumann).
indentation moved as "indenter" to the language element already years ago
Sun, Aug 12, 10:24 PM
dhaumann committed R216:0ee6e99f3db3: Cleanup: indentation was moved from general to language section (authored by dhaumann).
Cleanup: indentation was moved from general to language section
Sun, Aug 12, 10:15 PM
dhaumann committed R39:055aab328515: Remove unused commentRegion code (authored by dhaumann).
Remove unused commentRegion code
Sun, Aug 12, 9:37 PM
dhaumann committed R39:e026d05a62a0: Use KSyntaxHighlighting::CommentPosition instead of KateHighlighting::CSLPos (authored by dhaumann).
Use KSyntaxHighlighting::CommentPosition instead of KateHighlighting::CSLPos
Sun, Aug 12, 9:37 PM
dhaumann committed R39:bc20703f8a95: Read comment markers from KSyntaxHighlighting (authored by dhaumann).
Read comment markers from KSyntaxHighlighting
Sun, Aug 12, 9:29 PM
dhaumann added a comment to D14763: Definition: Expose command markers.

@vkrause We simply decided to commit this now. But a review from your side is still appreciated ;)

Sun, Aug 12, 9:28 PM · Frameworks, Kate
dhaumann committed R216:7a8843f171e8: Definition: Expose command markers (authored by dhaumann).
Definition: Expose command markers
Sun, Aug 12, 9:27 PM
dhaumann closed D14763: Definition: Expose command markers.
Sun, Aug 12, 9:27 PM · Frameworks, Kate
dhaumann accepted D14773: completion widget: fix minimum header section size.
Sun, Aug 12, 5:21 PM · Frameworks, Kate
Restricted Application added a project to D4716: Add some more directives to MIPS assembler highlighting: Kate.

Could you provide a test snippet now? I will integrate this then.

Sun, Aug 12, 5:20 PM · Kate, Frameworks
dhaumann added a reviewer for D14236: Add some improvements to kate-syntax-highlighter for use in scripting: vkrause.
Sun, Aug 12, 4:25 PM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann updated subscribers of D14758: use view lines for wheel scrolling, not real lines.

Not yet thoroughly reviewed, but some thoughts:

  • There is a bug report for this: https://bugs.kde.org/show_bug.cgi?id=256561 Could you verify that the issues in the bug report are addressed by this patch? See also the comments by @ngraham in this bug report.
  • could you add: BUG: 256561
  • Since the commit logs now always appear in the KF5 changelog, maybe the subject could read: Fix: Scroll view lines instead of not real lines for wheel and touchpad scrolling
Sun, Aug 12, 1:49 PM · Frameworks, Kate
dhaumann requested review of D14763: Definition: Expose command markers.
Sun, Aug 12, 11:46 AM · Frameworks, Kate
dhaumann committed R39:eeace043635c: Use isWordWrapDelimiter() from KSyntaxHighlighting (authored by dhaumann).
Use isWordWrapDelimiter() from KSyntaxHighlighting
Sun, Aug 12, 9:06 AM
dhaumann committed R216:b422c7e3732a: Add bool Definition::isWordWrapDelimiter(QChar) (authored by dhaumann).
Add bool Definition::isWordWrapDelimiter(QChar)
Sun, Aug 12, 9:05 AM
dhaumann closed D14759: Add bool Definition::isWordWrapDelimiter(QChar).
Sun, Aug 12, 9:05 AM · Frameworks, Kate
dhaumann updated the diff for D14759: Add bool Definition::isWordWrapDelimiter(QChar).
  • Compile ;)
Sun, Aug 12, 9:01 AM · Frameworks, Kate
dhaumann requested review of D14759: Add bool Definition::isWordWrapDelimiter(QChar).
Sun, Aug 12, 8:49 AM · Frameworks, Kate

Sat, Aug 11

dhaumann committed R39:0854b2cb1714: Rename isDelimiter() to isWordDelimiter() (authored by dhaumann).
Rename isDelimiter() to isWordDelimiter()
Sat, Aug 11, 9:35 PM
dhaumann committed R216:65492dd0e13f: Definition: Rename isDelimiter() to isWordDelimiter() (authored by dhaumann).
Definition: Rename isDelimiter() to isWordDelimiter()
Sat, Aug 11, 9:34 PM
dhaumann committed R216:eef5bce7080f: Make Definition::isDelimiter() also work for invalid definitions (authored by dhaumann).
Make Definition::isDelimiter() also work for invalid definitions
Sat, Aug 11, 7:58 PM
dhaumann closed D14744: Make Definition::isDelimiter() also work for invalid definitions.
Sat, Aug 11, 7:58 PM · Frameworks, Kate
dhaumann updated the diff for D14744: Make Definition::isDelimiter() also work for invalid definitions.
  • Add support for getters of invalid Definitions
Sat, Aug 11, 7:51 PM · Frameworks, Kate
dhaumann requested review of D14744: Make Definition::isDelimiter() also work for invalid definitions.
Sat, Aug 11, 1:16 PM · Frameworks, Kate
dhaumann committed R216:6fa03b31edd5: Fix typos in API documentation (authored by dhaumann).
Fix typos in API documentation
Sat, Aug 11, 11:55 AM
dhaumann committed R39:1cd983153527: Use KSyntaxHighlighting::Definition::isDelimiter() (authored by dhaumann).
Use KSyntaxHighlighting::Definition::isDelimiter()
Sat, Aug 11, 11:52 AM
dhaumann committed R216:196ddc151b85: Definition: Expose bool isDelimiter() const (authored by dhaumann).
Definition: Expose bool isDelimiter() const
Sat, Aug 11, 11:51 AM
dhaumann closed D14741: Definition: Expose bool isDelimiter() const.
Sat, Aug 11, 11:51 AM · Frameworks, Kate
dhaumann requested review of D14741: Definition: Expose bool isDelimiter() const.
Sat, Aug 11, 10:18 AM · Frameworks, Kate

Fri, Aug 10

dhaumann committed R216:e23573cc90f3: Sort returned formats in Definition::formats() by id (authored by dhaumann).
Sort returned formats in Definition::formats() by id
Fri, Aug 10, 2:48 PM