dhaumann (Dominik Haumann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 20 2015, 7:20 AM (190 w, 6 d)
Availability
Available

Recent Activity

Yesterday

dhaumann committed R39:efa926274947: KTextEditor::Message: Review documentation (authored by dhaumann).
KTextEditor::Message: Review documentation
Sun, Dec 16, 7:07 PM
dhaumann requested review of D17631: class Message: Use inclass member initialization.
Sun, Dec 16, 6:55 PM · Frameworks, Kate
dhaumann closed D17624: KTextEditor::Message: Review documentation.
Sun, Dec 16, 6:53 PM · Frameworks, Kate
dhaumann added a comment to D17624: KTextEditor::Message: Review documentation.

I integrated this now, see a16d082370a44fcbae3a204bfede1db6e6dffe86 - the change also includes the rename of autoHide to autoHideDelay. The function names cannot be changed of course, since it's public API.

Sun, Dec 16, 6:46 PM · Frameworks, Kate
dhaumann added a comment to D17624: KTextEditor::Message: Review documentation.

Now you are mixing documentation changes with code changes. I would have preferred to have different review requests, especially since the documentation part was already reviewed. Further, I would prefer autoHideDelay instead of just delay. If we use "delay" only, then the question immediately arises "the delay of what"? With this in mind, the naming of "autoHide" as better, since at least the context was clear. I will take care of the documentation now, but will not take care of the renaming for the reason given.

Sun, Dec 16, 5:37 PM · Frameworks, Kate
dhaumann accepted D17624: KTextEditor::Message: Review documentation.

Looks almost good, except for "optional" and a missing "be". Could you update again?

Sun, Dec 16, 1:51 PM · Frameworks, Kate
dhaumann accepted D16980: Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed.

I am not 100% convinced of this feature, but my attitude is: let's try this, and if someone complains, we can still change it. So I am fine with the change.

Sun, Dec 16, 1:44 PM · Dolphin

Sat, Dec 15

dhaumann added inline comments to D17596: [KDirOperator] Allow renaming files from the context menu.
Sat, Dec 15, 5:00 PM · Frameworks
dhaumann requested changes to D17599: Confirm closing if multiple tabs are open..

What happens, if you have multiple mainwindows? Do you get the message multiple times then? Please try with View > New Window.

Sat, Dec 15, 12:28 PM · Kate
dhaumann added inline comments to D17595: Upstream Dolphin's file rename dialog.
Sat, Dec 15, 9:00 AM · Frameworks
dhaumann added a comment to D17596: [KDirOperator] Allow renaming files from the context menu.

Not sure about binary compatibility...

Sat, Dec 15, 8:54 AM · Frameworks

Wed, Dec 12

dhaumann added a comment to D17530: improve highlighting of complex numbers.

Well, if it's copy & pasted, it must be correct ;)

Wed, Dec 12, 9:48 PM · Frameworks, Kate
dhaumann accepted D17530: improve highlighting of complex numbers.

Reviewing correct context popping is always not so easy - I trust this part is correct?! ;)

Wed, Dec 12, 1:26 PM · Frameworks, Kate
dhaumann accepted D17430: highlight token strings and delimited strings.
Wed, Dec 12, 12:14 AM · Frameworks, Kate
dhaumann accepted D17460: fixups for `extern` and `pragma`.

Thanks, good patch again.

Wed, Dec 12, 12:13 AM · Frameworks, Kate
dhaumann added a comment to D17503: [kateproject] Gracefully exit when analyzer is not finished.

Not an issue but for the future: your initial summary for the review request is non-existent :) could you in future elaborate? E.g.: did you observe memleaks? Did it crash? Does perf or valgrind proof this? Etc... :)

Wed, Dec 12, 12:10 AM · Kate
dhaumann added a comment to D5656: Adds method to force the reloading of a document.

Do we really need this? Or is this a reject?

Wed, Dec 12, 12:07 AM · Kate, Frameworks
dhaumann accepted D17504: [kateproject tool] Fine tune cppcheck.

Ok with me as well.

Wed, Dec 12, 12:05 AM · Kate
dhaumann accepted D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View.

Looks good.

Wed, Dec 12, 12:04 AM · Frameworks, Kate
dhaumann accepted D17457: use STL were no implicit sharing is required.

Looks still good to me.

Wed, Dec 12, 12:00 AM · Frameworks, Kate

Tue, Dec 11

dhaumann accepted D17495: [KMessageBox] Fix minimum dialog size when details are requested.
Tue, Dec 11, 7:23 AM · Frameworks

Mon, Dec 10

dhaumann added a comment to D17460: fixups for `extern` and `pragma`.

Could you also extend the unit test in autotest/input/highlight.d?

Mon, Dec 10, 7:34 PM · Frameworks, Kate
dhaumann added a comment to D17441: tune editing actions for large number of small edits.

I guess it's ok to have this in. But please use this version at your daily work ;) I think we don't have many testers...

Mon, Dec 10, 6:48 PM · Frameworks, Kate
dhaumann accepted D17457: use STL were no implicit sharing is required.

Looks good, please commit. With these kind of changes, we soon support up to 2^64 lines in a document? ;)

Mon, Dec 10, 6:38 PM · Frameworks, Kate

Sun, Dec 9

dhaumann added inline comments to D17441: tune editing actions for large number of small edits.
Sun, Dec 9, 8:09 AM · Frameworks, Kate
dhaumann added a comment to D17432: WIP: Add Analyzer Tool "Cppcheck (for C)".

I dislike the fact that we have two times almost the same thing. Then again I can see that if C++ is set explicitly, the cppcheck plugin will be unusable for C. Then again, cppcheck contains 'cpp' in its name. So should we care about C at all here? If the answer is 'no', I would prefer to simply add the command line option and be done with it :-) or add an option in the Projects config page.

Sun, Dec 9, 7:48 AM · Kate

Sat, Dec 8

dhaumann added a comment to D17441: tune editing actions for large number of small edits.

Hm indeed. I remember when the patch was added that added the editing positions. At that time I was not convinced about this, and now even performance problems show up.

Sat, Dec 8, 9:43 PM · Frameworks, Kate
dhaumann added a comment to D17441: tune editing actions for large number of small edits.

Just curious: Do the editing positions really show up in perf?

Sat, Dec 8, 9:37 PM · Frameworks, Kate
dhaumann added a comment to D9175: Migrate some more QRegExps to QRegularExpression.

Curent state: This patch is only almost good to go in... :-P

Sat, Dec 8, 5:24 PM · Frameworks, Kate
dhaumann updated the diff for D17436: BrightScript: Remove unused keyword list 'end'.
  • increase version number only by one :-)
Sat, Dec 8, 5:18 PM · Frameworks, Kate
dhaumann requested review of D17436: BrightScript: Remove unused keyword list 'end'.
Sat, Dec 8, 5:16 PM · Frameworks, Kate
dhaumann added inline comments to D17295: BrightScript: Add function/sub folding.
Sat, Dec 8, 5:12 PM · Frameworks, Kate
dhaumann closed D17413: stay in context Linkage2/Pragma2 until closing paren.
Sat, Dec 8, 5:09 PM · Frameworks, Kate
dhaumann committed R216:66367f8e6366: stay in context Linkage2/Pragma2 until closing paren (authored by dhaumann).
stay in context Linkage2/Pragma2 until closing paren
Sat, Dec 8, 5:09 PM
dhaumann added a comment to D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.

Maybe file_save_alternatives or as Gregor once suggested file_save_variants. Or file_save_extended.

Sat, Dec 8, 4:45 PM · Frameworks, Kate
dhaumann added a comment to D17241: WIP:Disable highlighting for lines longer than 1024 characters..

Is it correct that highlighting in the document (i.e. KSyntaxHighlighting) still takes place for the entire line, and this change simply only changes the fact that KateRenderer stops using the highlighting info after 100000 columns?

Sat, Dec 8, 4:39 PM · Frameworks, Kate
dhaumann updated subscribers of D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.

@cullmann You did not seem to have strong objections to this. Can you comment on this here again?

Sat, Dec 8, 4:31 PM · Frameworks, Kate
dhaumann accepted D17314: Projects Plugin: Add ShellCheck analyzer.

Looks good to me, but please consider using i18np to enable correct plural translations.

Sat, Dec 8, 4:29 PM · Kate
dhaumann accepted D16926: Review user interaction in session management.

I agree this should go in (possibly with minor improvements I added as comments): The patch is already big enough, so I'd rather prefer continuation work on followup patches.

Sat, Dec 8, 4:09 PM · Kate
dhaumann added a comment to D17128: DocumentPrivate: Remove comment mark when joining lines.

As background: inserting the '*' automatically is done by the indenter in cstyle.js. Theorwtically, we could even add a joinLines function to the indenters as well and call it if it exists, and if not use the default implementation. Just an idea... Usually, the motivation for moving something into an indenter boils down to whether a specific behavior is related only to a specific programming language, i.e. when a general purpose solution cannot be done.

Sat, Dec 8, 7:55 AM · Frameworks, Kate, KTextEditor

Fri, Dec 7

dhaumann accepted D17418: SearchView: Harmonize text in searchPlaceCombo.

Yes, looks good to me, thanks! These little things do mske a difference :)

Fri, Dec 7, 9:41 PM · Kate
dhaumann accepted D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style.

I think is an improvement - sorry for the delay :( will integrate tomorrow.

Fri, Dec 7, 9:36 PM · Frameworks, Kate
dhaumann accepted D17413: stay in context Linkage2/Pragma2 until closing paren.

I guess this is fine. Could you use your real name please?

Fri, Dec 7, 9:31 PM · Frameworks, Kate

Wed, Dec 5

dhaumann added a comment to D17318: Code Analysis: Show list of file extensions on which the tool runs on.

I think this is fine. A minor comment from my side would be: I am not sure adding these kind of labels are alwas a good solution. I can see that it's useful to know which files are affected. Then again, once you know this, the label is just visual noise.

Wed, Dec 5, 2:23 PM · Kate

Mon, Dec 3

dhaumann added a comment to D17137: KTextEditor: File menu: Put Save, Print and Export in submenus.

Hm, is this really a good idea? Right now, the File menu is rather flat, which is a good thing imo. Do we really want to move Save operations into a "Save Variants" sub menu?

Mon, Dec 3, 9:46 PM · Frameworks, Kate
dhaumann added inline comments to D17308: Make CTags/Projects context menu more accessible.
Mon, Dec 3, 9:43 PM · Kate
dhaumann added a comment to D17314: Projects Plugin: Add ShellCheck analyzer.

I think Kevin's suggestion is a good one. One more iteration?

Mon, Dec 3, 9:38 PM · Kate

Mon, Nov 26

dhaumann added a comment to D17084: Prolog & Lua: fix shebang.

Btw, I think in this case the fix is correct.

Mon, Nov 26, 9:58 PM · Frameworks, Kate
dhaumann added a comment to D16830: Add file related actions to Tabbar context menu and File menu: Rename, Delete, Compare (new), and some more.

In general I have no objections to this patch. I'd welcone another review, though.

Mon, Nov 26, 9:52 PM · Kate

Wed, Nov 21

dhaumann added inline comments to D17083: Fix hidden languages in the mode menu.
Wed, Nov 21, 7:57 PM · Frameworks, Kate

Tue, Nov 20

dhaumann accepted D16641: Enable three more plugins by default.

I would have preferred to only have one #indef WIN32. Preprocess statements should be reduced to the minimum, imho.

Tue, Nov 20, 9:26 PM · Kate
dhaumann added inline comments to D16830: Add file related actions to Tabbar context menu and File menu: Rename, Delete, Compare (new), and some more.
Tue, Nov 20, 9:08 PM · Kate

Mon, Nov 19

dhaumann added a comment to D16980: Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed.

Hm, isn't it that in all 4 cases Ctrl+L focuses the line edit and selects all? /Independent/ on the context? That's what you just wrote, right? :-)

Mon, Nov 19, 5:29 PM · Dolphin

Sun, Nov 18

dhaumann added a comment to D16980: Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed.

I kind of am with @elvisangelaccio here and would argue that the file dialog is inconsistent :-)

Sun, Nov 18, 8:07 PM · Dolphin
dhaumann added a comment to D16980: Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed.

I am not voting against this feature, but I use CTRL+L also in browsers. There, CTRL+L does two things:

Sun, Nov 18, 4:17 PM · Dolphin

Nov 12 2018

dhaumann added a comment to D16830: Add file related actions to Tabbar context menu and File menu: Rename, Delete, Compare (new), and some more.

Unfortunately, someone started with v2 only many years ago, and other reused this license simply due to copy & paste. Nowadays, we have a hard time getting rid of v2 only. Please use v2+.

Nov 12 2018, 9:38 PM · Kate

Nov 9 2018

dhaumann added a comment to D16677: Add BrightScript syntax.

Unless you have a KDE commit account you can not commit yourself. Unfortunately we cannot see on Phabricator whether you have one or not. We can integrate this patch and then it will be in the next KDE Frameworks release, i.e. early next month.

Nov 9 2018, 7:31 AM · Frameworks, Kate

Nov 4 2018

dhaumann added a comment to D16641: Enable three more plugins by default.

I am with Kare here: I think we should care to not enable plugins by default that are known to be problematic on windows.
Can you #ifdef this or at least add a runtime check depending on the OS?

Nov 4 2018, 6:04 PM · Kate
dhaumann accepted D16650: Terminal Tool View: enable AutoSync by default.

Has already 2x +1 --> Let's try this.

Nov 4 2018, 5:51 PM · Kate
dhaumann added a comment to D16647: Make plugin titles and descriptions consistent in casing and wording.

Good idea to unify this. Can we have one more iteration? :)

Nov 4 2018, 5:50 PM · Kate
dhaumann accepted D16637: Quick Open: Restrict file column size to take up at most half of the view.
Nov 4 2018, 5:43 PM · Kate
dhaumann updated subscribers of D16370: KTextEditor : syntax definition priority UI usability.
Nov 4 2018, 5:37 PM · Frameworks, Kate, KTextEditor

Oct 28 2018

dhaumann added a comment to D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights.

As I see we have the following situation

  • the current implementation does work reasonably well
  • just because we cannot match a theme 100% does not imply that we have to adapt our implementation (there will always be a color in theme xy that does not properly exist in KTextEditor)
  • KTextEditor does not use color themes from KSyntaxHighlighting yet, so the transition is not complete
Oct 28 2018, 2:53 PM · Kate, Frameworks

Oct 26 2018

dhaumann requested changes to D16415: Creating new syntax highlighting file for Job Control Language (JCL).

Please add a small test file and explain what this highlighting language is used for :)

Oct 26 2018, 5:55 AM · Frameworks, Kate
dhaumann requested changes to D16416: z/OS CLIST file syntax highlighting.

Could you explain what CLIST is used for? Please add a small test file that is also MIT licensed.

Oct 26 2018, 5:49 AM · Frameworks, Kate

Oct 22 2018

dhaumann accepted D16376: [tabswitcher] Fix beginRemoveRows call.

Thanks!

Oct 22 2018, 8:33 PM · Kate

Oct 21 2018

dhaumann added a comment to D16341: Minor cleanups of TabSwitcher plugin.

@gregormi In my ~/kde/kf5/src/kdesrc-buildrc file I have the line:

Oct 21 2018, 6:35 PM · Kate
dhaumann committed R40:8dbcfc6c3133: Minor cleanups of TabSwitcher plugin (authored by dhaumann).
Minor cleanups of TabSwitcher plugin
Oct 21 2018, 6:19 PM
dhaumann closed D16341: Minor cleanups of TabSwitcher plugin.
Oct 21 2018, 6:19 PM · Kate
dhaumann added inline comments to D16341: Minor cleanups of TabSwitcher plugin.
Oct 21 2018, 3:43 PM · Kate
dhaumann added a comment to D16018: Fix align of doxygen comments in templates.

Yes, in KDE Frameworks, there is only a master branch.

Oct 21 2018, 3:41 PM · Frameworks, Kate

Oct 20 2018

dhaumann accepted D16018: Fix align of doxygen comments in templates.

Well, make test works for me, and if this fixes the issue for you, I'm fine with that.

Oct 20 2018, 8:07 PM · Frameworks, Kate
dhaumann added a comment to D14948: Port scriptabletags to QJSEngine.

Did you followup on this with @skelly ?

Oct 20 2018, 7:57 PM
dhaumann added a comment to D16341: Minor cleanups of TabSwitcher plugin.

In yet another patch, I would change the public members of FilenameListItem to getter functions. Then we are free to either cache the data, or only calculate all stuff on-the-fly from the KTextEditor::Document.

Oct 20 2018, 7:33 PM · Kate
dhaumann requested review of D16341: Minor cleanups of TabSwitcher plugin.
Oct 20 2018, 7:31 PM · Kate
dhaumann accepted D16338: Improve R documentation highlighting.

Looks good to me, please commit.

Oct 20 2018, 5:09 PM · Frameworks, Kate

Oct 18 2018

dhaumann added a comment to D16300: Remove double underscore (__) from header include guards.

Qt decided against #pragma once. I wouldn't want to use it in KDE unless it is decided on kde-frameworks-devel.

Oct 18 2018, 9:07 PM · Frameworks, Kate

Oct 17 2018

dhaumann added a comment to D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.

Hi Gregor, I just did a post-review again, and noticed several issues I think we should address. I have a patch ready for most of the stuff, but did not yet post it on Phabricator, since I indeed use KTextEditor::Document as member pointer in the FileListItem, and its constructor now reads the icon etc from the document, which destroys the tsttestapp demo. So the comments are just here to make you aware of the issues. We can have the real discussion when I post the patch.

Oct 17 2018, 9:00 PM · Kate
dhaumann accepted D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.

Feel free to push this for 5.52 (you'd have to adapt the @since 5.53 again).

Oct 17 2018, 6:31 PM · Frameworks, Kate
dhaumann added a comment to D16259: Open document before using it's checksum to load metainfos.

@slenz Thanks for this nice patch, please keep it coming :-)

Oct 17 2018, 5:55 PM · Kate
dhaumann added a comment to D16204: Quick Open: Remove "file:///" prefix from file paths.

Do you have to rebase your patch now that the other patch is in?

Oct 17 2018, 11:27 AM · Kate

Oct 15 2018

dhaumann added inline comments to D15804: Fix Duplicates on Quick Open File.
Oct 15 2018, 7:34 PM · Kate
dhaumann accepted D16215: Cleanup: Merge all code from main.cpp into unit test tstestapp.cpp.

The title "Cleanup" is a bit too generic imho. Better eould be something along the lines "Ceanup: Merge main() into unit test tsttestapp.cpp" along with a detailed description :) Maybe something for future commits? Good enough this time, but for commits in KDE Frameworks this would not be good enough, since "Cleanup" would then end up in David's changelog, which is too generic (cleanup of what?).

Oct 15 2018, 7:32 PM · Kate
dhaumann accepted D16214: New Tabswitcher: Fix cut-off path strings.

I would prefer that the contents of main.cpp goes to tstestapp.cpp, since this would allow to have multiple tests over time. But this can be done in a separate patch, please push.

Oct 15 2018, 1:05 AM · Kate
dhaumann updated subscribers of D16204: Quick Open: Remove "file:///" prefix from file paths.

@tcanabrava Does this clash with your patch in D15804 ?

Oct 15 2018, 12:56 AM · Kate
dhaumann accepted D16209: tabswitchertest: use QFETCH.

Looks good, please push.

Oct 15 2018, 12:51 AM · Kate

Oct 13 2018

dhaumann added a comment to D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.

Yes, please push. In a separate patch, could you possibly look at KateTabSwitcherTest::testLongestCommonPrefix() again? It looks as if you could use QFETCH along eith a function KateTabSwitcherTest::testLongestCommonPrefix_data()? QFETCH is typically used when testing a data set.

Oct 13 2018, 4:40 PM · Kate

Oct 10 2018

dhaumann added a comment to D13541: Port solid from Qt5::Widgets to Qt5::Gui.

@graesslin ping

Oct 10 2018, 7:56 PM · Frameworks

Oct 9 2018

dhaumann added a comment to D16054: Show partial path in Tabswitcher Ctrl+Tab list to distinguish equally named files.

I like it, definitely an improvement.

Oct 9 2018, 1:49 AM · Kate

Oct 5 2018

dhaumann added a comment to D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.

If Christoph accepts, I am fine with this.

Oct 5 2018, 11:32 PM · Frameworks, Kate
dhaumann added a comment to D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer.

Hm, given the size of the patch, and given it introduces new public API we cannot easily change, I think a silent +1 since noone reacts is not good enough.

Oct 5 2018, 11:31 PM · Frameworks, Kate

Oct 3 2018

dhaumann added a comment to D15909: Fix compile failure on Windows targets.

Btw, can you commit yourself, or shall we push this? If so, can someone take care of this, since I am not available for the next 10 days.

Oct 3 2018, 7:14 AM · Frameworks
dhaumann accepted D15909: Fix compile failure on Windows targets.

Lgtm.

Oct 3 2018, 7:12 AM · Frameworks
dhaumann added a comment to D15194: Draw a line separating PlasmaComponents tab bar from its content area.

Hm, two separator lines, even touching each other sounds like a hack. Is there no better way?

Oct 3 2018, 7:09 AM · Frameworks

Oct 1 2018

dhaumann added a comment to D15292: Use lambdas instead of QSignalMapper.

Commit e261f1ff048815656aedcaef0e55b28863440639

Oct 1 2018, 8:43 PM · Kate

Sep 30 2018

dhaumann added a comment to T9771: Main context can be #poped.

Fixed, see 9e039a669f8f34591c12e433cba1c97a11645c5d

Sep 30 2018, 10:13 AM · Framework: Syntax Highlighting
dhaumann moved T9771: Main context can be #poped from Backlog to Done on the Framework: Syntax Highlighting board.
Sep 30 2018, 10:12 AM · Framework: Syntax Highlighting
dhaumann triaged T9775: Integrate Fortran Free/Fixed as Low priority.
Sep 30 2018, 10:11 AM · Framework: Syntax Highlighting
dhaumann committed R216:aedf21f9b42e: Fortran: Highlight alerts in comments (authored by dhaumann).
Fortran: Highlight alerts in comments
Sep 30 2018, 7:36 AM

Sep 29 2018

dhaumann moved T3780: Add definition lookup by mimetype to Repository from Backlog to Done on the Framework: Syntax Highlighting board.
Sep 29 2018, 3:02 PM · Framework: Syntax Highlighting