dhaumann (Dominik Haumann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 20 2015, 7:20 AM (226 w, 3 d)
Availability
Available

Recent Activity

Yesterday

dhaumann committed R39:a6a77cc6ef3f: Add .clangd to .gitignore list (authored by dhaumann).
Add .clangd to .gitignore list
Wed, Aug 21, 7:53 PM
dhaumann updated the diff for D9175: Migrate some more QRegExps to QRegularExpression.
  • Rebase from 2016 to year 2019.
Wed, Aug 21, 7:42 PM · Frameworks, Kate
dhaumann committed R40:0caacad3a118: External Tools: Fix CMakeLists.txt files (authored by dhaumann).
External Tools: Fix CMakeLists.txt files
Wed, Aug 21, 6:28 PM
dhaumann committed R40:eb7556ba6d6c: Merge branch 'master' into revive-externaltools-plugin (authored by dhaumann).
Merge branch 'master' into revive-externaltools-plugin
Wed, Aug 21, 6:28 PM
dhaumann accepted D23312: JSP: support of <script> and <style> ; use IncludeRule ##Java.

Nice simplification.

Wed, Aug 21, 3:44 PM · Frameworks, Kate

Tue, Aug 20

dhaumann accepted D23272: JavaScript: remove unnecessary "Conditional Expression" context.

Looks very reasonable to me, thanks.

Tue, Aug 20, 7:14 AM · Frameworks, Kate
dhaumann accepted D23278: LESS: import CSS keywords, new highlighting and some improvements.

Btw, do all highlighting files using the include statement in lists use kateversion="5.53"? If not, we should fix it. In fact, we should extend our highlightingindexer to check this...

Tue, Aug 20, 7:08 AM · Frameworks, Kate

Mon, Aug 19

dhaumann accepted D23245: New syntax: SASS. Some fixes for CSS and SCSS.

Thanks for working on this.

Mon, Aug 19, 10:34 AM · Frameworks, Kate

Sat, Aug 17

dhaumann added a comment to D19620: Use a searchbar similar to the one in okular.
In D19620#512883, @GB_2 wrote:

Don't use the unicode ellipsis. We use three dots everywhere.

Sat, Aug 17, 6:47 AM · Frameworks
dhaumann accepted D23208: Use CMake find_dependency in CMake config file instead of find_package.
Sat, Aug 17, 6:30 AM · Frameworks, Framework: Syntax Highlighting, Kate
dhaumann accepted D23203: Use CMake find_dependency instead of find_package in CMake config file template..
Sat, Aug 17, 6:30 AM · Frameworks, Kate, KTextEditor

Wed, Aug 14

dhaumann added a comment to D23134: fix additionalDeliminator attribute.

Could you add a unit test for this?

  • add the dummy xml similar to the one in the bug report. This can be done by using the additional search folder in the Repository.
  • add a test highlighting like done with the others
Wed, Aug 14, 9:27 AM · Frameworks, Kate
dhaumann accepted D23135: Gettext: fix "previous untranslated string" and other improvements/fixes.

Thanks. Removing hardcoded colors would also be nice :-)

Wed, Aug 14, 9:24 AM · Frameworks, Kate
dhaumann added a comment to D14632: keyword rule: Spport for keywords inclusion from another language/file.

What just came to my mind is that this patch also has an issue: If you include a keyword list of a.xml in b.xml, and a.xml uses different word delimiters for the keyword list, then the keywords in b.xml will not be highlighted/detected correctly.

Wed, Aug 14, 8:09 AM · Frameworks, Kate

Sun, Aug 11

dhaumann added a comment to D23061: Possiblity to change Definition data after loading.

Imho the API is currently not clear enough, see comment below. Can we somehow resolve this?

Sun, Aug 11, 7:05 AM · Frameworks, Kate, Framework: Syntax Highlighting

Sat, Aug 10

dhaumann accepted D23034: implicit fallthough if there is fallthoughContext.

I think this is much better. For KF6, we can remove it in the xml files as well or so...

Sat, Aug 10, 5:42 AM · Frameworks, Kate

Fri, Aug 9

dhaumann added a comment to D23050: Highlight documentation: add include keywords.

Thanks!

Fri, Aug 9, 8:33 PM · Documentation, Kate
dhaumann requested changes to D23034: implicit fallthough if there is fallthoughContext.

I like this change a lot, but there is a huge (theoretical) backwards compatibility issue with this.

Fri, Aug 9, 7:33 AM · Frameworks, Kate
dhaumann added a comment to D23035: Simplify ctors with default member initializer.

Did you make these changes manually, or use clang-tidy for it?
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-default-member-init.html

Fri, Aug 9, 7:22 AM · Kate

Wed, Aug 7

dhaumann accepted D23009: LSP plugin: Use language id instead of highlighting mode for server identification.

That makes a lot of sense and is likely more robust for now.

Wed, Aug 7, 8:20 PM · Kate
dhaumann retitled D23009: LSP plugin: Use language id instead of highlighting mode for server identification from use language id instead of highlighting mode for server identification to LSP plugin: Use language id instead of highlighting mode for server identification.
Wed, Aug 7, 8:18 PM · Kate
dhaumann updated the summary of D23009: LSP plugin: Use language id instead of highlighting mode for server identification.
Wed, Aug 7, 8:18 PM · Kate

Tue, Aug 6

dhaumann added a comment to D22963: support Rust LSP server auto-detect some useful root path based on location of Cargo.toml.

I posted https://www.reddit.com/r/rust/comments/cmvy9b/help_needed_kate_rust_lsp_support/? - maybe we get more feedback this way.

Tue, Aug 6, 8:47 PM · Kate

Wed, Jul 31

dhaumann accepted D22848: Rust: add missing keywords and minor improvements.

I trust this is a good improvement.

Wed, Jul 31, 4:11 PM · Frameworks, Kate

Sun, Jul 28

dhaumann added a comment to D22715: Save and load page margins.

I think adding the printer name makes sense. We could go the full road, see: https://stackoverflow.com/a/14979437/2224190

Sun, Jul 28, 12:57 AM · Frameworks, Kate

Fri, Jul 26

dhaumann added a comment to D22715: Save and load page margins.

Btw, I recently wrote a mail to John Layt with the following content. The linked bug may be closed with this change:

Fri, Jul 26, 4:37 PM · Frameworks, Kate
dhaumann added a comment to D22715: Save and load page margins.

Since the former patch was originally from me: I agree to accept it, but it has it's drawbacks: if you have multiple printers, having different margins is not possible, since this is not saved per printer.

Fri, Jul 26, 4:30 PM · Frameworks, Kate
dhaumann added inline comments to D22479: Prompt user to save or discard changes.
Fri, Jul 26, 4:28 PM · Kate

Jul 21 2019

dhaumann requested changes to D22199: New plugin to open the selected file path.

The KTextEditor::Command implementation is wrong, see my other comments. Please fix this first :-)

Jul 21 2019, 7:09 PM · Documentation, Kate
dhaumann accepted D22595: implement text hint interface for automatic hover.

KDevelop does the same: they always return an empty QString to cancel the texthint stuff and then show their own just like you do now.

Jul 21 2019, 10:22 AM · Kate

Jul 18 2019

dhaumann accepted D13867: [KMessageWidget] Pass widget to standardIcon().

The commit log says "Breeze now knows it's a KMessageWidget". Ok. And now? The commit log lacks what issue this patch fixes...

Jul 18 2019, 9:18 PM · Frameworks

Jul 17 2019

dhaumann accepted D22515: Add support for additional QML keywords not part of JavaScript.

Please commit.

Jul 17 2019, 8:09 PM · Frameworks, Kate

Jul 14 2019

dhaumann committed R40:c0fdfbc42fcf: LCPClientView: Fix assert with Qt::UniqueConnection (authored by dhaumann).
LCPClientView: Fix assert with Qt::UniqueConnection
Jul 14 2019, 11:02 AM

Jul 9 2019

dhaumann committed R216:61f3846b0fe4: Update cmake highlighting (authored by dhaumann).
Update cmake highlighting
Jul 9 2019, 8:25 PM
dhaumann closed D22340: Update cmake highlighting.
Jul 9 2019, 8:25 PM · Frameworks, Kate
dhaumann accepted D22340: Update cmake highlighting.
Jul 9 2019, 8:24 PM · Frameworks, Kate
dhaumann retitled D22340: Update cmake highlighting from cmake: bring some missed features to Update cmake highlighting.
Jul 9 2019, 8:21 PM · Frameworks, Kate

Jul 8 2019

dhaumann added a comment to D22315: Add setting to enable/disable text drag-and-drop (on by default).

Good, I expected nothing less ;)

Jul 8 2019, 2:46 PM · Frameworks, Kate
dhaumann added inline comments to D22315: Add setting to enable/disable text drag-and-drop (on by default).
Jul 8 2019, 6:58 AM · Frameworks, Kate
dhaumann added a comment to D22315: Add setting to enable/disable text drag-and-drop (on by default).

When you do UI changes, please always add a screenshot. In this case of the changed config page :)

Jul 8 2019, 6:57 AM · Frameworks, Kate

Jul 5 2019

dhaumann added inline comments to D22276: Add an action to insert a non-indented newline.
Jul 5 2019, 7:45 AM · Frameworks, Kate

Jul 4 2019

dhaumann added inline comments to D21713: Fortran: implement free & fixed formats.
Jul 4 2019, 10:10 AM · Frameworks, Kate
dhaumann added inline comments to D21713: Fortran: implement free & fixed formats.
Jul 4 2019, 5:11 AM · Frameworks, Kate

Jul 2 2019

dhaumann added inline comments to D22199: New plugin to open the selected file path.
Jul 2 2019, 10:59 AM · Documentation, Kate

Jun 30 2019

dhaumann added a comment to D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.

Minor/general comment: given this is a KDE Frameworks change, could you improve the summary of the commit message for this and future commits? Here it just says bug, ccbug, fixedin. Imho a commit log should be self-explaining and self-contained: what is broken exactly, why is it broken, why is the suggested fix correct, what testing did you do, what possible risks does the change have?

Jun 30 2019, 10:07 PM · Frameworks
dhaumann committed R39:44f04981779a: Fix compiler warning about unused variable (authored by dhaumann).
Fix compiler warning about unused variable
Jun 30 2019, 3:00 PM

Jun 29 2019

dhaumann committed R39:6bbbe6aa51c0: Fix empty pages in print preview and lines printed twice (authored by hoffmannrobert).
Fix empty pages in print preview and lines printed twice
Jun 29 2019, 8:50 PM
dhaumann closed D21563: Fix empty pages in print preview and lines printed twice.

Fixed for KF 5.60 with commit 6bbbe6aa51c0a293a58dbca6223e37a73ce32122, thanks for the patch - keep it coming!

Jun 29 2019, 8:29 PM · Frameworks, Kate
dhaumann accepted D21563: Fix empty pages in print preview and lines printed twice.

I just tested kwrite from master with Qt 5.12.0, and printing was completely broken. It even printed on Letter even though I specified A4 paper. A Qt update to Qt 5.12.3 fixed this - good so far.

Jun 29 2019, 8:18 PM · Frameworks, Kate

Jun 28 2019

dhaumann added a comment to D21563: Fix empty pages in print preview and lines printed twice.

I will test tomorrow ;)

Jun 28 2019, 9:23 PM · Frameworks, Kate

Jun 24 2019

dhaumann committed R39:cf85a33e1ff0: Add default variables for variables interface (authored by dhaumann).
Add default variables for variables interface
Jun 24 2019, 7:46 PM
dhaumann closed D21861: Add default variables for variables interface.
Jun 24 2019, 7:46 PM · Frameworks, Kate

Jun 23 2019

dhaumann added a comment to D21563: Fix empty pages in print preview and lines printed twice.

Many years ago I also stumbled over this bug, and I know for sure it never was fixed. If this fix really works then this would be really great! That said I have not yet tried the patch but am positive to get this in soon!

Jun 23 2019, 8:54 PM · Frameworks, Kate
dhaumann accepted D21940: Make automatic spellcheck work after reloading a document.

Looks good to me now :)

Jun 23 2019, 12:37 PM · Frameworks, Kate
dhaumann committed R40:c6d5f54abfcd: Change CurrentDocument: to Document: (authored by dhaumann).
Change CurrentDocument: to Document:
Jun 23 2019, 10:08 AM
dhaumann committed R40:440f4f75f929: Use variables shipped by default from KTextEditor (authored by dhaumann).
Use variables shipped by default from KTextEditor
Jun 23 2019, 10:08 AM
dhaumann committed R40:7e07651af341: Merge branch 'master' into revive-externaltools-plugin (authored by dhaumann).
Merge branch 'master' into revive-externaltools-plugin
Jun 23 2019, 10:08 AM

Jun 22 2019

dhaumann added inline comments to D21940: Make automatic spellcheck work after reloading a document.
Jun 22 2019, 8:28 PM · Frameworks, Kate
dhaumann updated the test plan for D21861: Add default variables for variables interface.
Jun 22 2019, 8:18 PM · Frameworks, Kate
dhaumann updated the diff for D21861: Add default variables for variables interface.
  • Drop 'Current' prefix and improve documentation
Jun 22 2019, 8:17 PM · Frameworks, Kate
dhaumann added a comment to D21907: Show feedback inline when creating new files or folders.

So it boils down to "let's try this and improve later if necessary" - well then :)

Jun 22 2019, 7:03 PM · Frameworks
dhaumann added a comment to D21861: Add default variables for variables interface.

I'd like to drop the " Current" prefix in all the variables. It just makes the names longer and I don't see any value for users. Comments?

Jun 22 2019, 5:48 PM · Frameworks, Kate
dhaumann updated the diff for D21861: Add default variables for variables interface.
  • Implement JS:<code> variable expansion, e.g. %{JS:3+%{JS:2+1}} --> 6
  • Variable expansion: Add unit tests
Jun 22 2019, 5:40 PM · Frameworks, Kate
dhaumann added a comment to D21907: Show feedback inline when creating new files or folders.

These two points were not discussed anymore:

Jun 22 2019, 1:23 PM · Frameworks

Jun 21 2019

dhaumann accepted D21960: AppArmor: update syntax.

Lgtm.

Jun 21 2019, 1:17 PM · Frameworks, Kate
dhaumann added inline comments to D21940: Make automatic spellcheck work after reloading a document.
Jun 21 2019, 1:13 PM · Frameworks, Kate
dhaumann requested changes to D21940: Make automatic spellcheck work after reloading a document.

You don't need the extra function. Could you update the patch?

Jun 21 2019, 6:10 AM · Frameworks, Kate

Jun 19 2019

dhaumann added a comment to D21907: Show feedback inline when creating new files or folders.

Have not looked at the patch, just the gif: I am rather sceptical if instant feedback is a good idea here. First, having an empty line edit will happen a lot, usually without the user wanting to press OK. That means the user will already get feedback in the middle of the workflow even though he did not yet have the intention to click OK yet.
The same may hold true for the other cases. Too much on-the-fly feedback may be annoying and stress the user unnecessarily.

Jun 19 2019, 9:09 PM · Frameworks

Jun 16 2019

dhaumann added a comment to D21861: Add default variables for variables interface.

Btw, if there is a better place for initialization, I'd happily move the code to some other place.

Jun 16 2019, 8:10 PM · Frameworks, Kate
dhaumann requested review of D21861: Add default variables for variables interface.
Jun 16 2019, 8:10 PM · Frameworks, Kate

Jun 15 2019

dhaumann accepted D17241: WIP:Disable highlighting after 512 characters on a line..

+1

Jun 15 2019, 9:27 PM · Frameworks, Kate

Jun 12 2019

dhaumann added a comment to T11064: Improve the UI for the "make the editor follow the system color scheme" feature.

I second Christoph's comment.

Jun 12 2019, 8:50 AM · VDG, KTextEditor, Kate

Jun 11 2019

dhaumann added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

Could this be pushed even further by using QVarLengthArray?

Jun 11 2019, 9:14 AM · Frameworks, Kate

Jun 10 2019

dhaumann reopened D17971: Revive External Tools plugin.

It's not closed, it just lives in the kate/revive-externaltools-plugin branch.

Jun 10 2019, 2:16 PM · Kate
dhaumann committed R40:d4ca2d3404d4: Require KTextEditor 5.57 and adapt to KTextEditor interface changes (authored by dhaumann).
Require KTextEditor 5.57 and adapt to KTextEditor interface changes
Jun 10 2019, 2:09 PM
dhaumann committed R40:281daaf4583a: Use variables from KTextEditor Framework 5.57 (authored by dhaumann).
Use variables from KTextEditor Framework 5.57
Jun 10 2019, 2:09 PM
dhaumann committed R40:09606d769fed: Remove hard-coded variables in favor of registering variables (authored by dhaumann).
Remove hard-coded variables in favor of registering variables
Jun 10 2019, 2:09 PM
dhaumann committed R40:63a5e3c7864b: Add a ContextAction that attaches to QLineEdits (authored by dhaumann).
Add a ContextAction that attaches to QLineEdits
Jun 10 2019, 2:09 PM
dhaumann committed R40:95eb464df343: Cleanup What's This tip in Tool Dialog (authored by dhaumann).
Cleanup What's This tip in Tool Dialog
Jun 10 2019, 2:09 PM
dhaumann committed R40:013a72352c1f: Cleanup: Remove tool parameter from addToolStatus() (authored by dhaumann).
Cleanup: Remove tool parameter from addToolStatus()
Jun 10 2019, 2:09 PM
dhaumann committed R40:5501abca9df1: Add 'external-tool-test', testing all macros (authored by dhaumann).
Add 'external-tool-test', testing all macros
Jun 10 2019, 2:09 PM
dhaumann committed R40:477e0f07a0eb: Improve messaging and toolview handling (authored by dhaumann).
Improve messaging and toolview handling
Jun 10 2019, 2:09 PM
dhaumann committed R40:77f87c85eed8: Write output and stderr to QTextDocuments directly (authored by dhaumann).
Write output and stderr to QTextDocuments directly
Jun 10 2019, 2:09 PM
dhaumann committed R40:8966e278f537: Macro expansion: fix global XPos and YPos (authored by dhaumann).
Macro expansion: fix global XPos and YPos
Jun 10 2019, 2:09 PM
dhaumann committed R40:8c4b1a5e04a1: Use QTextDocument as model to decouple ui from data (authored by dhaumann).
Use QTextDocument as model to decouple ui from data
Jun 10 2019, 2:09 PM
dhaumann committed R40:290534b2d898: Remove support for old macros (authored by dhaumann).
Remove support for old macros
Jun 10 2019, 2:09 PM
dhaumann committed R40:200b818de3a7: Remove checkbox "[ ] Include output from stderr" in favour of always displaying… (authored by dhaumann).
Remove checkbox "[ ] Include output from stderr" in favour of always displaying…
Jun 10 2019, 2:09 PM
dhaumann committed R40:b1798f24a276: Use fixed font for displaying output and status text (authored by dhaumann).
Use fixed font for displaying output and status text
Jun 10 2019, 2:09 PM
dhaumann committed R40:3fb57896c72d: Implement new macro expansion (similar to Qt Creator) (authored by dhaumann).
Implement new macro expansion (similar to Qt Creator)
Jun 10 2019, 2:09 PM
dhaumann committed R40:abd13f3cf8ef: Better toolview handling (not perfect, yet) (authored by dhaumann).
Better toolview handling (not perfect, yet)
Jun 10 2019, 2:09 PM
dhaumann committed R40:74f5de554520: Show output in toolview for "Display in Pane" (authored by dhaumann).
Show output in toolview for "Display in Pane"
Jun 10 2019, 2:09 PM
dhaumann committed R40:3fc0000d2e62: Expand empty working directory to current document URL only when URL is valid (authored by dhaumann).
Expand empty working directory to current document URL only when URL is valid
Jun 10 2019, 2:09 PM
dhaumann committed R40:fe250c0b9afa: Pass also exitCode and crashed-flag in signal toolFinished() (authored by dhaumann).
Pass also exitCode and crashed-flag in signal toolFinished()
Jun 10 2019, 2:09 PM
dhaumann committed R40:e74cb47abe35: API to clear & delete toolview (authored by dhaumann).
API to clear & delete toolview
Jun 10 2019, 2:09 PM
dhaumann committed R40:03b54edee577: Working dir: if empty, use the current document's path (authored by dhaumann).
Working dir: if empty, use the current document's path
Jun 10 2019, 2:09 PM
dhaumann committed R40:4e3eca46955b: Use toolview to report a crash (authored by dhaumann).
Use toolview to report a crash
Jun 10 2019, 2:09 PM
dhaumann committed R40:b540439e4057: Start working on the tool view (authored by dhaumann).
Start working on the tool view
Jun 10 2019, 2:09 PM
dhaumann committed R40:942dcc1feb0b: Escape hides & deletes the tool view (authored by dhaumann).
Escape hides & deletes the tool view
Jun 10 2019, 2:09 PM
dhaumann committed R40:06b539bb0f65: Register PluginView in Plugin, so that the PluginView for a MainWindow can be… (authored by dhaumann).
Register PluginView in Plugin, so that the PluginView for a MainWindow can be…
Jun 10 2019, 2:09 PM
dhaumann committed R40:2c970af97554: Save & load enums manually instead of casting to int. This is more flexible… (authored by dhaumann).
Save & load enums manually instead of casting to int. This is more flexible…
Jun 10 2019, 2:09 PM