arojas (Antonio Rojas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 17 2016, 5:38 PM (187 w, 5 d)
Availability
Available

Recent Activity

Yesterday

arojas committed R237:68c1cfd0d8dc: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615 (authored by arojas).
Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615
Tue, Jan 21, 8:29 PM
arojas closed D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615.
Tue, Jan 21, 8:29 PM · Frameworks
arojas requested review of D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615.
Tue, Jan 21, 7:25 PM · Frameworks

Sat, Jan 18

arojas accepted D26750: CMake: Bump min TpQt version to 0.9.8 and use its targets.

Works for me. You should probably ping the CI people about the dependency change before committing.

Sat, Jan 18, 12:46 PM · KDE Telepathy

Thu, Jan 9

arojas added a comment to D26190: Fix man page formatting.

The localized man pages are still broken in 19.12.1 - what does it need to happen for them to pick up the change?

Thu, Jan 9, 6:35 PM · Documentation, Okular

Tue, Jan 7

arojas committed R34:d6c6368c411d: Merge remote-tracking branch 'origin/release/19.12' (authored by arojas).
Merge remote-tracking branch 'origin/release/19.12'
Tue, Jan 7, 9:18 PM
arojas committed R34:51e0d9122cf2: Fix build with gpsd 3.20 (authored by arojas).
Fix build with gpsd 3.20
Tue, Jan 7, 9:15 PM
arojas closed D26486: Fix build with gpsd 3.20.
Tue, Jan 7, 9:15 PM · KDE Edu, Marble
arojas updated the diff for D26486: Fix build with gpsd 3.20.

Remove unnecessary check

Tue, Jan 7, 7:39 PM · KDE Edu, Marble
arojas requested review of D26486: Fix build with gpsd 3.20.
Tue, Jan 7, 9:22 AM · KDE Edu, Marble

Mon, Jan 6

arojas committed R120:6b0f4fa07071: Merge branch 'Plasma/5.17' (authored by arojas).
Merge branch 'Plasma/5.17'
Mon, Jan 6, 7:37 PM
arojas committed R120:0c4974d68804: Fix build with gpsd 3.20 (authored by arojas).
Fix build with gpsd 3.20
Mon, Jan 6, 7:36 PM
arojas closed D26474: Fix build with gpsd 3.20.
Mon, Jan 6, 7:36 PM · Plasma
arojas requested review of D26474: Fix build with gpsd 3.20.
Mon, Jan 6, 7:23 PM · Plasma
arojas committed R471:13a427b2e335: Don't hardcode the QML install dir (authored by arojas).
Don't hardcode the QML install dir
Mon, Jan 6, 12:13 PM
arojas committed R471:f91f51bd3cdf: Don't hardcode the QML install dir (authored by arojas).
Don't hardcode the QML install dir
Mon, Jan 6, 12:13 PM
arojas closed D26455: Don't hardcode the QML install dir.
Mon, Jan 6, 12:13 PM
arojas requested review of D26455: Don't hardcode the QML install dir.
Mon, Jan 6, 10:04 AM

Sun, Jan 5

l10n daemon script <scripty@kde.org> committed R275:14e22c33143b: Fix build of python bindings for kcolumnheadersmodel (authored by arojas).
Fix build of python bindings for kcolumnheadersmodel
Sun, Jan 5, 5:20 PM
arojas closed D26431: Fix build of python bindings for kcolumnheadersmodel.
Sun, Jan 5, 12:35 PM · Frameworks
arojas committed R275:89e24bd88ea7: Fix build of python bindings for kcolumnheadersmodel (authored by arojas).
Fix build of python bindings for kcolumnheadersmodel
Sun, Jan 5, 12:35 PM
arojas requested review of D26431: Fix build of python bindings for kcolumnheadersmodel.
Sun, Jan 5, 12:00 PM · Frameworks
l10n daemon script <scripty@kde.org> committed R237:e1a900fb631c: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009 (authored by arojas).
Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009
Sun, Jan 5, 10:35 AM
arojas committed R237:ae93e9da13fa: Merge branch 'master' of git://anongit.kde.org/kconfig (authored by arojas).
Merge branch 'master' of git://anongit.kde.org/kconfig
Sun, Jan 5, 10:27 AM
arojas committed R237:171a2c26d280: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009 (authored by arojas).
Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009
Sun, Jan 5, 10:27 AM
arojas closed D26430: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009.
Sun, Jan 5, 10:27 AM · Frameworks
arojas requested review of D26430: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009.
Sun, Jan 5, 9:50 AM · Frameworks

Sat, Jan 4

arojas added a comment to D25833: Expose getter to KConfigWatcher's config.

This breaks compilation of python bindings:

Sat, Jan 4, 6:53 PM · Frameworks

Tue, Dec 24

arojas added a comment to D26190: Fix man page formatting.

You should have commited this to the stable branch and then merged to master.

I'll cherry-pick -x to stable now, it's worse, but relatively acceptable

Tue, Dec 24, 10:15 AM · Documentation, Okular

Dec 23 2019

arojas committed R223:9ac31982c5ca: Fix man page formatting (authored by arojas).
Fix man page formatting
Dec 23 2019, 5:32 PM
arojas closed D26190: Fix man page formatting.
Dec 23 2019, 5:32 PM · Documentation, Okular
arojas added a comment to D26190: Fix man page formatting.

Uhm, but it shouldn't be an issue, really. As a workaround this is fine, but maybe an XSLT issue? Why was this seen only on Arch?

Dec 23 2019, 2:55 PM · Documentation, Okular
arojas requested review of D26190: Fix man page formatting.
Dec 23 2019, 2:40 PM · Documentation, Okular

Dec 21 2019

arojas committed R482:72651c36d900: Fix build with Qt 5.14 (authored by arojas).
Fix build with Qt 5.14
Dec 21 2019, 1:49 PM
arojas closed D26144: Fix build with Qt 5.14.
Dec 21 2019, 1:49 PM
arojas committed R482:cff33fbc9c7c: Fix build with opencv 4.2 (authored by arojas).
Fix build with opencv 4.2
Dec 21 2019, 1:47 PM
arojas closed D26143: Fix build with opencv 4.2.
Dec 21 2019, 1:47 PM
arojas updated the test plan for D26143: Fix build with opencv 4.2.
Dec 21 2019, 1:28 PM
arojas added a comment to D26143: Fix build with opencv 4.2.

Tested with 3.4.9, builds fine.

Dec 21 2019, 1:28 PM
arojas updated the diff for D26144: Fix build with Qt 5.14.

Just this patch was enough for me to fix the ibuild (not sure why), but I've made the same change everywhere else for consistency.

Dec 21 2019, 1:25 PM
arojas requested review of D26144: Fix build with Qt 5.14.
Dec 21 2019, 1:09 PM
arojas requested review of D26143: Fix build with opencv 4.2.
Dec 21 2019, 12:46 PM

Dec 15 2019

arojas committed R240:7c84be59f686: Support PyQt5 compiled with SIP 5 (authored by arojas).
Support PyQt5 compiled with SIP 5
Dec 15 2019, 10:03 AM
arojas closed D25972: Support PyQt5 compiled with SIP 5.
Dec 15 2019, 10:03 AM · Build System, Frameworks

Dec 14 2019

arojas updated the diff for D25972: Support PyQt5 compiled with SIP 5.

Use HINTS

Dec 14 2019, 11:01 PM · Build System, Frameworks
arojas committed R331:d72f33a14c22: Port pykig to python 3 (authored by arojas).
Port pykig to python 3
Dec 14 2019, 6:49 PM
arojas closed D25982: Port pykig to python 3.
Dec 14 2019, 6:49 PM · KDE Edu
arojas added inline comments to D25982: Port pykig to python 3.
Dec 14 2019, 12:12 PM · KDE Edu
arojas updated the diff for D25982: Port pykig to python 3.

Update shebang, fix typo

Dec 14 2019, 12:12 PM · KDE Edu
arojas requested review of D25982: Port pykig to python 3.
Dec 14 2019, 10:31 AM · KDE Edu

Dec 13 2019

arojas requested review of D25972: Support PyQt5 compiled with SIP 5.
Dec 13 2019, 10:27 PM · Build System, Frameworks

Dec 9 2019

arojas committed R318:8ffc72e87f4c: Merge branch 'release/19.12' (authored by arojas).
Merge branch 'release/19.12'
Dec 9 2019, 10:23 PM
arojas committed R318:faa37a6138fc: Fix build with Qt 5.14 RC (authored by arojas).
Fix build with Qt 5.14 RC
Dec 9 2019, 10:23 PM
arojas committed R318:588965feccdc: Merge branch 'release/19.12' of git://anongit.kde.org/dolphin into release/19.12 (authored by arojas).
Merge branch 'release/19.12' of git://anongit.kde.org/dolphin into release/19.12
Dec 9 2019, 10:23 PM
arojas closed D25783: Fix build with Qt 5.14 RC.
Dec 9 2019, 10:23 PM · Dolphin

Dec 6 2019

arojas committed R158:ff3d72760b76: Merge branch 'release/19.12' (authored by arojas).
Merge branch 'release/19.12'
Dec 6 2019, 2:44 PM
arojas committed R158:699bba9e555a: Fix build with Qt 5.14 RC (authored by arojas).
Fix build with Qt 5.14 RC
Dec 6 2019, 2:44 PM
arojas closed D25784: Fix build with Qt 5.14 RC.
Dec 6 2019, 2:44 PM
arojas added a comment to D25783: Fix build with Qt 5.14 RC.

see https://bugs.kde.org/show_bug.cgi?id=414492 user already created patch.

Dec 6 2019, 2:28 PM · Dolphin
arojas requested review of D25784: Fix build with Qt 5.14 RC.
Dec 6 2019, 2:10 PM
arojas requested review of D25783: Fix build with Qt 5.14 RC.
Dec 6 2019, 2:04 PM · Dolphin

Nov 19 2019

arojas added inline comments to D25411: Search for KF5I18n and KF5DocTools.
Nov 19 2019, 9:53 PM · Kate

Nov 18 2019

arojas committed R141:fbe5097f4a79: Fix build with telepathy-qt 0.9.8 (authored by arojas).
Fix build with telepathy-qt 0.9.8
Nov 18 2019, 9:15 PM
arojas committed R141:f08680c41fa3: Fix build with telepathy-qt 0.9.8 (authored by arojas).
Fix build with telepathy-qt 0.9.8
Nov 18 2019, 9:14 PM
arojas closed D25370: Fix build with telepathy-qt 0.9.8.
Nov 18 2019, 9:14 PM
arojas committed R144:70564e30def5: Fix build with telepathy-qt 0.9.8 (authored by arojas).
Fix build with telepathy-qt 0.9.8
Nov 18 2019, 9:10 PM
arojas closed D25372: Fix build with telepathy-qt 0.9.8.
Nov 18 2019, 9:10 PM
arojas requested review of D25372: Fix build with telepathy-qt 0.9.8.
Nov 18 2019, 5:24 PM
arojas requested review of D25370: Fix build with telepathy-qt 0.9.8.
Nov 18 2019, 5:08 PM

Nov 14 2019

arojas committed R145:86da8b0f7f2f: Merge branch 'release/19.12' (authored by arojas).
Merge branch 'release/19.12'
Nov 14 2019, 7:37 PM
arojas closed D25269: Fix build with telepathy-qt 0.9.8.
Nov 14 2019, 7:36 PM
arojas committed R145:f030b527c4d3: Fix build with telepathy-qt 0.9.8 (authored by arojas).
Fix build with telepathy-qt 0.9.8
Nov 14 2019, 7:36 PM
arojas added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

The pkgconfig file disagrees:
it contains libsuffix=-2_4 and later Libs: -L${libdir} -lIlmImf${libsuffix}
For me, that library name is correct

Nov 14 2019, 5:30 PM · Build System, Frameworks
arojas added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

I don't see how that commit is related.
openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so

This is expected afaics.

Nov 14 2019, 5:23 PM · Build System, Frameworks
arojas added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

This is a bug in openexr. It does actually try to install the unsuffixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in https://github.com/openexr/openexr/commit/4e54bde78f65c0fef8a9f794aaacea07813fba09

Nov 14 2019, 4:53 PM · Build System, Frameworks

Nov 12 2019

arojas added a comment to D25269: Fix build with telepathy-qt 0.9.8.

What about pushing this as-is for 19.12 and bumping the dependency and using the new target on master (19.12 is already branched)

Nov 12 2019, 10:25 AM
arojas added a comment to D25269: Fix build with telepathy-qt 0.9.8.

That would require bumping the telepathy-qt dependency, no? I think we're past the dependency freeze for 19.12

Nov 12 2019, 9:30 AM
arojas requested review of D25269: Fix build with telepathy-qt 0.9.8.
Nov 12 2019, 8:43 AM

Nov 7 2019

arojas committed R482:76ff65aec63b: Properly initialize ExceptionInfo in libMagick (authored by arojas).
Properly initialize ExceptionInfo in libMagick
Nov 7 2019, 8:26 AM
arojas closed D25181: Properly initialize ExceptionInfo in libMagick.
Nov 7 2019, 8:26 AM

Nov 6 2019

arojas requested review of D25181: Properly initialize ExceptionInfo in libMagick.
Nov 6 2019, 10:39 PM

Nov 5 2019

arojas abandoned D25159: Fix linking to libssh 0.9.1.
Nov 5 2019, 5:59 PM · Frameworks, Dolphin
arojas updated the test plan for D25159: Fix linking to libssh 0.9.1.
Nov 5 2019, 3:43 PM · Frameworks, Dolphin
arojas requested review of D25159: Fix linking to libssh 0.9.1.
Nov 5 2019, 3:33 PM · Frameworks, Dolphin

Oct 26 2019

arojas committed R55:75b2595d5c11: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Oct 26 2019, 4:41 PM
arojas committed R55:13b8d731d501: Fix sagemath backend when there is no sage-env (authored by arojas).
Fix sagemath backend when there is no sage-env
Oct 26 2019, 4:40 PM
arojas closed D24955: Fix sagemath backend when there is no sage-env.
Oct 26 2019, 4:40 PM · KDE Edu
arojas added a comment to D24955: Fix sagemath backend when there is no sage-env.

If there is no sage-env and Sage expects it then it will throw errors itself - I don't think it's Cantor's job to detect whether the Sage install is broken. Also note that some distros (eg. gentoo) have been patching sage to run without sage-env for a while, so a simple version check wouldn't be reliable.

Oct 26 2019, 4:35 PM · KDE Edu
arojas requested review of D24955: Fix sagemath backend when there is no sage-env.
Oct 26 2019, 6:51 AM · KDE Edu

Oct 24 2019

arojas closed D24915: Fix Cantor version check for linking with poppler.
Oct 24 2019, 4:04 PM · KDE Edu
arojas committed R262:21b7f075cfdd: Fix Cantor version check for linking with poppler (authored by arojas).
Fix Cantor version check for linking with poppler
Oct 24 2019, 4:04 PM
arojas requested review of D24915: Fix Cantor version check for linking with poppler.
Oct 24 2019, 11:39 AM · KDE Edu

Oct 11 2019

arojas closed D24554: Don't build static library when BUILD_TESTING=OFF.
Oct 11 2019, 1:21 PM · Frameworks
arojas committed R245:f436762fb366: Don't build static library when BUILD_TESTING=OFF (authored by arojas).
Don't build static library when BUILD_TESTING=OFF
Oct 11 2019, 1:21 PM
arojas requested review of D24554: Don't build static library when BUILD_TESTING=OFF.
Oct 11 2019, 6:35 AM · Frameworks

Sep 22 2019

arojas committed R239:ec475441f61e: Support NetworkManager 1.20 and do actually compile the NM backend (authored by arojas).
Support NetworkManager 1.20 and do actually compile the NM backend
Sep 22 2019, 2:28 PM
arojas closed D24020: Support NetworkManager 1.20 and do actually compile the NM backend.
Sep 22 2019, 2:28 PM · Frameworks

Sep 21 2019

arojas added a reviewer for D24020: Support NetworkManager 1.20 and do actually compile the NM backend: Frameworks.
Sep 21 2019, 11:13 AM · Frameworks

Sep 19 2019

arojas abandoned D24096: Restore appstream integration in kicker.
Sep 19 2019, 6:03 PM · Plasma
arojas updated the summary of D24096: Restore appstream integration in kicker.
Sep 19 2019, 5:53 PM · Plasma