arojas (Antonio Rojas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 17 2016, 5:38 PM (205 w, 5 d)
Availability
Available

Recent Activity

Thu, May 14

arojas committed R99:4d3eaca93da0: Merge branch 'Plasma/5.19' (authored by arojas).
Merge branch 'Plasma/5.19'
Thu, May 14, 2:29 PM
arojas committed R99:d608a414e411: Remove kiconthemes dependency (authored by arojas).
Remove kiconthemes dependency
Thu, May 14, 2:28 PM
arojas closed D29756: Remove kiconthemes dependency.
Thu, May 14, 2:28 PM · Plasma
arojas added a reviewer for D29756: Remove kiconthemes dependency: gikari.
Thu, May 14, 2:23 PM · Plasma
arojas requested review of D29756: Remove kiconthemes dependency.
Thu, May 14, 2:22 PM · Plasma

Fri, May 8

arojas requested review of D29482: Add support for openbabel 3.
Fri, May 8, 9:05 PM · KDE Edu
arojas updated the diff for D29482: Add support for openbabel 3.

Removed boost dependency, no longer needed in 3.1.1. Unfortunately we can't bump the min version since they forgot to bump the version before release.

Fri, May 8, 9:04 PM · KDE Edu

Wed, May 6

arojas planned changes to D29482: Add support for openbabel 3.

Upstream is working on fixing the remaining cmake issues and they will release a 3.1.1 that will allow to simplify the patch

Wed, May 6, 5:02 PM · KDE Edu
arojas requested review of D29482: Add support for openbabel 3.
Wed, May 6, 1:51 PM · KDE Edu

Apr 26 2020

arojas added a comment to D28604: rename ktp_integration target so it comply to the name in dbus service file.

Ping, this is causing noticeable delays on Plasma startup after updating ktp to 20.04, see https://bugs.kde.org/show_bug.cgi?id=420549

Apr 26 2020, 12:01 PM · KDE Telepathy
arojas added reviewers for D28604: rename ktp_integration target so it comply to the name in dbus service file: akulichalexandr, nicolasfella.
Apr 26 2020, 12:00 PM · KDE Telepathy

Apr 13 2020

arojas added a comment to D28789: Fix crash due to changes in KBookmarkMenu.

Can you push this to 20.04 too please?

Apr 13 2020, 4:15 PM

Apr 6 2020

arojas committed R40:6c41a5b2b94c: Revert premature porting (authored by apol).
Revert premature porting
Apr 6 2020, 9:20 PM
arojas added a reverting change for R260:b1ae993cac2d: Port deprecated signal: R260:80ba1c83d19e: Revert "Port deprecated signal".
Apr 6 2020, 9:13 PM
arojas committed R260:80ba1c83d19e: Revert "Port deprecated signal" (authored by apol).
Revert "Port deprecated signal"
Apr 6 2020, 9:13 PM
arojas committed R36:918cb63a5bce: Revert "Make it compile against last qt5.15 without deprecated method" (authored by apol).
Revert "Make it compile against last qt5.15 without deprecated method"
Apr 6 2020, 9:06 PM
arojas added a reverting change for R36:9c901d16ae43: Make it compile against last qt5.15 without deprecated method: R36:918cb63a5bce: Revert "Make it compile against last qt5.15 without deprecated method".
Apr 6 2020, 9:06 PM

Mar 25 2020

arojas committed R387:106bfba03782: Fix DESTDIR usage (authored by arojas).
Fix DESTDIR usage
Mar 25 2020, 6:40 PM
arojas closed D27330: Fix DESTDIR usage.
Mar 25 2020, 6:40 PM

Mar 23 2020

arojas added a comment to D28227: Use same logic for "no extension" case with Duplicate feature.

Is there a reason to include the path in the translated string? Not including it would reduce the risk of translations breaking the feature (as it happens currently with Spanish in the extension case)

Mar 23 2020, 8:01 PM · Dolphin

Mar 21 2020

arojas added a comment to D28182: Fix compilation with Qt 5.15.

This fixes the build for me (but this was fixed by Montel already by removing this code path)

Mar 21 2020, 11:45 AM · KDE PIM
arojas committed R34:4e727daf0fd6: Fix build with Qt 5.15 (authored by arojas).
Fix build with Qt 5.15
Mar 21 2020, 11:01 AM
arojas closed D28171: Fix build with Qt 5.15.
Mar 21 2020, 11:01 AM · KDE Edu, Marble
arojas committed R158:83db3b00bbda: Merge branch 'release/20.04' (authored by arojas).
Merge branch 'release/20.04'
Mar 21 2020, 7:35 AM
arojas committed R158:e95533c7d058: Fix build with Qt 5.15 (authored by arojas).
Fix build with Qt 5.15
Mar 21 2020, 7:35 AM
arojas closed D28173: Fix build with Qt 5.15.
Mar 21 2020, 7:34 AM
arojas committed R146:a285d814263e: Merge branch 'release/20.04' (authored by arojas).
Merge branch 'release/20.04'
Mar 21 2020, 1:12 AM
arojas committed R146:f834977a2bff: Fix build with Qt 5.15 (authored by arojas).
Fix build with Qt 5.15
Mar 21 2020, 1:10 AM
arojas closed D28174: Fix build with Qt 5.15.
Mar 21 2020, 1:10 AM
arojas committed R454:bda30db1df73: Merge branch 'release/20.04' (authored by arojas).
Merge branch 'release/20.04'
Mar 21 2020, 1:10 AM
arojas committed R454:5ae21332fa61: Fix build with Qt 5.15 (authored by arojas).
Fix build with Qt 5.15
Mar 21 2020, 1:09 AM
arojas closed D28175: Fix build with Qt 5.15.
Mar 21 2020, 1:09 AM
arojas requested review of D28175: Fix build with Qt 5.15.
Mar 21 2020, 12:43 AM
arojas requested review of D28174: Fix build with Qt 5.15.
Mar 21 2020, 12:37 AM
arojas requested review of D28173: Fix build with Qt 5.15.
Mar 21 2020, 12:35 AM

Mar 20 2020

arojas requested review of D28171: Fix build with Qt 5.15.
Mar 20 2020, 8:30 PM · KDE Edu, Marble

Feb 17 2020

arojas added a comment to D27454: Unbreak the Accounts KCM.

Thanks, I confirm that all accounts are displayed now and they can be deleted. The list of enabled services still can't be configured though, the "Apply" button is never enabled.

Feb 17 2020, 12:25 PM · Plasma

Feb 11 2020

arojas requested review of D27330: Fix DESTDIR usage.
Feb 11 2020, 6:46 PM
arojas added a comment to D27236: Fix retrieving Twitter conversations.

No problem :)

Feb 11 2020, 10:15 AM

Feb 8 2020

arojas requested review of D27236: Fix retrieving Twitter conversations.
Feb 8 2020, 11:16 AM

Feb 6 2020

arojas committed R186:073d93b6036f: Link to the original post for retweets (authored by arojas).
Link to the original post for retweets
Feb 6 2020, 7:06 AM
arojas closed D27175: Link to the original post for retweets.
Feb 6 2020, 7:06 AM

Feb 5 2020

arojas requested review of D27175: Link to the original post for retweets.
Feb 5 2020, 6:38 PM

Jan 21 2020

arojas committed R237:68c1cfd0d8dc: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615 (authored by arojas).
Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615
Jan 21 2020, 8:29 PM
arojas closed D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615.
Jan 21 2020, 8:29 PM · Frameworks
arojas requested review of D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615.
Jan 21 2020, 7:25 PM · Frameworks

Jan 18 2020

arojas accepted D26750: CMake: Bump min TpQt version to 0.9.8 and use its targets.

Works for me. You should probably ping the CI people about the dependency change before committing.

Jan 18 2020, 12:46 PM · KDE Telepathy

Jan 9 2020

arojas added a comment to D26190: Fix man page formatting.

The localized man pages are still broken in 19.12.1 - what does it need to happen for them to pick up the change?

Jan 9 2020, 6:35 PM · Documentation, Okular

Jan 7 2020

arojas committed R34:d6c6368c411d: Merge remote-tracking branch 'origin/release/19.12' (authored by arojas).
Merge remote-tracking branch 'origin/release/19.12'
Jan 7 2020, 9:18 PM
arojas committed R34:51e0d9122cf2: Fix build with gpsd 3.20 (authored by arojas).
Fix build with gpsd 3.20
Jan 7 2020, 9:15 PM
arojas closed D26486: Fix build with gpsd 3.20.
Jan 7 2020, 9:15 PM · KDE Edu, Marble
arojas updated the diff for D26486: Fix build with gpsd 3.20.

Remove unnecessary check

Jan 7 2020, 7:39 PM · KDE Edu, Marble
arojas requested review of D26486: Fix build with gpsd 3.20.
Jan 7 2020, 9:22 AM · KDE Edu, Marble

Jan 6 2020

arojas committed R120:6b0f4fa07071: Merge branch 'Plasma/5.17' (authored by arojas).
Merge branch 'Plasma/5.17'
Jan 6 2020, 7:37 PM
arojas committed R120:0c4974d68804: Fix build with gpsd 3.20 (authored by arojas).
Fix build with gpsd 3.20
Jan 6 2020, 7:36 PM
arojas closed D26474: Fix build with gpsd 3.20.
Jan 6 2020, 7:36 PM · Plasma
arojas requested review of D26474: Fix build with gpsd 3.20.
Jan 6 2020, 7:23 PM · Plasma
arojas committed R471:13a427b2e335: Don't hardcode the QML install dir (authored by arojas).
Don't hardcode the QML install dir
Jan 6 2020, 12:13 PM
arojas committed R471:f91f51bd3cdf: Don't hardcode the QML install dir (authored by arojas).
Don't hardcode the QML install dir
Jan 6 2020, 12:13 PM
arojas closed D26455: Don't hardcode the QML install dir.
Jan 6 2020, 12:13 PM
arojas requested review of D26455: Don't hardcode the QML install dir.
Jan 6 2020, 10:04 AM

Jan 5 2020

l10n daemon script <scripty@kde.org> committed R275:14e22c33143b: Fix build of python bindings for kcolumnheadersmodel (authored by arojas).
Fix build of python bindings for kcolumnheadersmodel
Jan 5 2020, 5:20 PM
arojas closed D26431: Fix build of python bindings for kcolumnheadersmodel.
Jan 5 2020, 12:35 PM · Frameworks
arojas committed R275:89e24bd88ea7: Fix build of python bindings for kcolumnheadersmodel (authored by arojas).
Fix build of python bindings for kcolumnheadersmodel
Jan 5 2020, 12:35 PM
arojas requested review of D26431: Fix build of python bindings for kcolumnheadersmodel.
Jan 5 2020, 12:00 PM · Frameworks
l10n daemon script <scripty@kde.org> committed R237:e1a900fb631c: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009 (authored by arojas).
Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009
Jan 5 2020, 10:35 AM
arojas committed R237:ae93e9da13fa: Merge branch 'master' of git://anongit.kde.org/kconfig (authored by arojas).
Merge branch 'master' of git://anongit.kde.org/kconfig
Jan 5 2020, 10:27 AM
arojas committed R237:171a2c26d280: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009 (authored by arojas).
Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009
Jan 5 2020, 10:27 AM
arojas closed D26430: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009.
Jan 5 2020, 10:27 AM · Frameworks
arojas requested review of D26430: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009.
Jan 5 2020, 9:50 AM · Frameworks

Jan 4 2020

arojas added a comment to D25833: Expose getter to KConfigWatcher's config.

This breaks compilation of python bindings:

Jan 4 2020, 6:53 PM · Frameworks

Dec 24 2019

arojas added a comment to D26190: Fix man page formatting.

You should have commited this to the stable branch and then merged to master.

I'll cherry-pick -x to stable now, it's worse, but relatively acceptable

Dec 24 2019, 10:15 AM · Documentation, Okular

Dec 23 2019

arojas committed R223:9ac31982c5ca: Fix man page formatting (authored by arojas).
Fix man page formatting
Dec 23 2019, 5:32 PM
arojas closed D26190: Fix man page formatting.
Dec 23 2019, 5:32 PM · Documentation, Okular
arojas added a comment to D26190: Fix man page formatting.

Uhm, but it shouldn't be an issue, really. As a workaround this is fine, but maybe an XSLT issue? Why was this seen only on Arch?

Dec 23 2019, 2:55 PM · Documentation, Okular
arojas requested review of D26190: Fix man page formatting.
Dec 23 2019, 2:40 PM · Documentation, Okular

Dec 21 2019

arojas committed R482:72651c36d900: Fix build with Qt 5.14 (authored by arojas).
Fix build with Qt 5.14
Dec 21 2019, 1:49 PM
arojas closed D26144: Fix build with Qt 5.14.
Dec 21 2019, 1:49 PM
arojas committed R482:cff33fbc9c7c: Fix build with opencv 4.2 (authored by arojas).
Fix build with opencv 4.2
Dec 21 2019, 1:47 PM
arojas closed D26143: Fix build with opencv 4.2.
Dec 21 2019, 1:47 PM
arojas updated the test plan for D26143: Fix build with opencv 4.2.
Dec 21 2019, 1:28 PM
arojas added a comment to D26143: Fix build with opencv 4.2.

Tested with 3.4.9, builds fine.

Dec 21 2019, 1:28 PM
arojas updated the diff for D26144: Fix build with Qt 5.14.

Just this patch was enough for me to fix the ibuild (not sure why), but I've made the same change everywhere else for consistency.

Dec 21 2019, 1:25 PM
arojas requested review of D26144: Fix build with Qt 5.14.
Dec 21 2019, 1:09 PM
arojas requested review of D26143: Fix build with opencv 4.2.
Dec 21 2019, 12:46 PM

Dec 15 2019

arojas committed R240:7c84be59f686: Support PyQt5 compiled with SIP 5 (authored by arojas).
Support PyQt5 compiled with SIP 5
Dec 15 2019, 10:03 AM
arojas closed D25972: Support PyQt5 compiled with SIP 5.
Dec 15 2019, 10:03 AM · Build System, Frameworks

Dec 14 2019

arojas updated the diff for D25972: Support PyQt5 compiled with SIP 5.

Use HINTS

Dec 14 2019, 11:01 PM · Build System, Frameworks
arojas committed R331:d72f33a14c22: Port pykig to python 3 (authored by arojas).
Port pykig to python 3
Dec 14 2019, 6:49 PM
arojas closed D25982: Port pykig to python 3.
Dec 14 2019, 6:49 PM · KDE Edu
arojas added inline comments to D25982: Port pykig to python 3.
Dec 14 2019, 12:12 PM · KDE Edu
arojas updated the diff for D25982: Port pykig to python 3.

Update shebang, fix typo

Dec 14 2019, 12:12 PM · KDE Edu
arojas requested review of D25982: Port pykig to python 3.
Dec 14 2019, 10:31 AM · KDE Edu

Dec 13 2019

arojas requested review of D25972: Support PyQt5 compiled with SIP 5.
Dec 13 2019, 10:27 PM · Build System, Frameworks

Dec 9 2019

arojas committed R318:8ffc72e87f4c: Merge branch 'release/19.12' (authored by arojas).
Merge branch 'release/19.12'
Dec 9 2019, 10:23 PM
arojas committed R318:faa37a6138fc: Fix build with Qt 5.14 RC (authored by arojas).
Fix build with Qt 5.14 RC
Dec 9 2019, 10:23 PM
arojas committed R318:588965feccdc: Merge branch 'release/19.12' of git://anongit.kde.org/dolphin into release/19.12 (authored by arojas).
Merge branch 'release/19.12' of git://anongit.kde.org/dolphin into release/19.12
Dec 9 2019, 10:23 PM
arojas closed D25783: Fix build with Qt 5.14 RC.
Dec 9 2019, 10:23 PM · Dolphin

Dec 6 2019

arojas committed R158:ff3d72760b76: Merge branch 'release/19.12' (authored by arojas).
Merge branch 'release/19.12'
Dec 6 2019, 2:44 PM
arojas committed R158:699bba9e555a: Fix build with Qt 5.14 RC (authored by arojas).
Fix build with Qt 5.14 RC
Dec 6 2019, 2:44 PM