arojas (Antonio Rojas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 17 2016, 5:38 PM (160 w, 3 d)
Availability
Available

Recent Activity

Sun, Jul 7

arojas committed R273:071048e32a89: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h (authored by arojas).
Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h
Sun, Jul 7, 11:32 PM
arojas closed D22314: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h.
Sun, Jul 7, 11:32 PM · Frameworks
arojas requested review of D22314: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h.
Sun, Jul 7, 9:30 PM · Frameworks

May 30 2019

arojas added a comment to D21489: Add a case for mkinitcpio (Arch Linux) in helper.cpp - plymouthhelper.

Just a FYI, Arch is going switch away from mkinitcpio https://lists.archlinux.org/pipermail/arch-dev-public/2019-May/029570.html (Not saying this wouldn't be useful for the time being)

May 30 2019, 6:21 AM · Plasma

May 22 2019

arojas accepted D21318: improve wording of description of libvlc dependency.
May 22 2019, 12:02 PM

May 17 2019

arojas committed R106:908bc6df6494: Merge branch 'Plasma/5.16' (authored by arojas).
Merge branch 'Plasma/5.16'
May 17 2019, 5:08 PM
arojas committed R106:ce0dd71daa86: Move knsrc files to the new location (authored by arojas).
Move knsrc files to the new location
May 17 2019, 5:08 PM
arojas closed D21257: Move knsrc files to the new location.
May 17 2019, 5:08 PM · Plasma
arojas committed R123:5f6772ec2281: Merge branch 'Plasma/5.16' (authored by arojas).
Merge branch 'Plasma/5.16'
May 17 2019, 5:06 PM
arojas committed R123:d9eb33df36b0: Move knsrc files to the new location (authored by arojas).
Move knsrc files to the new location
May 17 2019, 5:06 PM
arojas closed D21259: Move knsrc files to the new location.
May 17 2019, 5:06 PM · Plasma
arojas committed R114:71d52f284e0f: Merge branch 'Plasma/5.16' (authored by arojas).
Merge branch 'Plasma/5.16'
May 17 2019, 5:02 PM
arojas committed R114:268ed1db19d5: Move knsrc files to the new location (authored by arojas).
Move knsrc files to the new location
May 17 2019, 5:02 PM
arojas closed D21256: Move knsrc files to the new location.
May 17 2019, 5:02 PM · Plasma
arojas committed R99:db1e2a9a6a6e: Merge branch 'Plasma/5.16' (authored by arojas).
Merge branch 'Plasma/5.16'
May 17 2019, 5:00 PM
arojas committed R99:041a9b08d5f4: Move knsrc files to the new location (authored by arojas).
Move knsrc files to the new location
May 17 2019, 5:00 PM
arojas closed D21255: Move knsrc files to the new location.
May 17 2019, 5:00 PM · Plasma
arojas committed R108:f59f8ffcf7b0: Merge branch 'Plasma/5.16' (authored by arojas).
Merge branch 'Plasma/5.16'
May 17 2019, 4:57 PM
arojas committed R108:94d2fea23a31: Move knsrc files to the new location (authored by arojas).
Move knsrc files to the new location
May 17 2019, 4:57 PM
arojas closed D21254: Move knsrc files to the new location.
May 17 2019, 4:57 PM · KWin
arojas requested review of D21259: Move knsrc files to the new location.
May 17 2019, 4:55 PM · Plasma
arojas requested review of D21257: Move knsrc files to the new location.
May 17 2019, 4:52 PM · Plasma
arojas requested review of D21256: Move knsrc files to the new location.
May 17 2019, 4:48 PM · Plasma
arojas requested review of D21255: Move knsrc files to the new location.
May 17 2019, 4:43 PM · Plasma
arojas requested review of D21254: Move knsrc files to the new location.
May 17 2019, 4:38 PM · KWin
arojas abandoned D21246: Search also legacy location for knsrc files.

OK I see in https://phabricator.kde.org/D19340 this is intentional

May 17 2019, 6:33 AM · Plasma

May 16 2019

arojas updated the diff for D21246: Search also legacy location for knsrc files.

Actually remove the conditional since 5.16 depends on KF 5.58

May 16 2019, 9:03 PM · Plasma
arojas requested review of D21246: Search also legacy location for knsrc files.
May 16 2019, 8:49 PM · Plasma

May 12 2019

arojas committed R283:34501bceed1d: Don't hardcode dbus policy install dir (authored by arojas).
Don't hardcode dbus policy install dir
May 12 2019, 10:54 PM
arojas closed D18222: Don't hardcode dbus policy install dir.
May 12 2019, 10:54 PM · Frameworks
arojas committed R16:8238c94447d0: Don't hardcode dbus policy install dir (authored by arojas).
Don't hardcode dbus policy install dir
May 12 2019, 8:34 PM
arojas closed D21162: Don't hardcode dbus policy install dir.
May 12 2019, 8:34 PM
arojas updated the summary of D18222: Don't hardcode dbus policy install dir.
May 12 2019, 5:53 PM · Frameworks
arojas updated the diff for D18222: Don't hardcode dbus policy install dir.

Use non-deprecated variable

May 12 2019, 5:51 PM · Frameworks
arojas updated the test plan for D21162: Don't hardcode dbus policy install dir.
May 12 2019, 5:47 PM
arojas updated the diff for D21162: Don't hardcode dbus policy install dir.

Use non-deprecated variable

May 12 2019, 5:47 PM
arojas requested review of D21162: Don't hardcode dbus policy install dir.
May 12 2019, 5:39 PM

Apr 28 2019

arojas committed R336:24c24f50fe7e: Merge branch 'Applications/19.04' (authored by arojas).
Merge branch 'Applications/19.04'
Apr 28 2019, 9:31 PM
arojas committed R336:a3f82fca1163: Make QML compilation optional (authored by arojas).
Make QML compilation optional
Apr 28 2019, 9:31 PM
arojas closed D20861: Make QML compilation optional.
Apr 28 2019, 9:31 PM · KDE Edu

Apr 27 2019

arojas requested review of D20861: Make QML compilation optional.
Apr 27 2019, 9:53 AM · KDE Edu

Apr 22 2019

arojas added a comment to D20611: Compatibility with black-hole-solver 0.20.0..

Can you push this to 19.04 please? So we don't have to carry a patch for 4 months.

Apr 22 2019, 10:02 PM

Apr 9 2019

arojas accepted D20408: Partially revert "Require CMake 3.4 and use the OpenSSL imported libs".

This fixes build with -DQCA_INSTALL_IN_QT_PREFIX=ON

Apr 9 2019, 2:09 PM

Apr 4 2019

arojas added a comment to D20239: Fix plugins/qpa build with Qt 5.13.
In D20239#443172, @apol wrote:

We will also somehow have to notify distros that kwin needs to be recompiled when they switch Qt versions there. @jriddell maybe it can be part of the release notes somehow?

Apr 4 2019, 6:29 AM · KWin

Mar 17 2019

arojas added a comment to D19821: Fix breeze dialog background with Qt 5.12.2.

Apparently tooltips need a fix too https://bbs.archlinux.org/viewtopic.php?pid=1837417#p1837417

Mar 17 2019, 2:29 PM · Frameworks

Mar 12 2019

arojas added a comment to D19699: [DataModel] Add nullptr check.

There's D19698 already

Mar 12 2019, 7:56 AM · Frameworks

Mar 11 2019

arojas added a comment to D19418: Make it compiles without deprecated method.

This is making Plasma crash, see https://bugs.kde.org/show_bug.cgi?id=405351

Mar 11 2019, 5:11 PM · Frameworks

Mar 8 2019

arojas committed R994:58beeb4837da: Remove unused dependencies (authored by arojas).
Remove unused dependencies
Mar 8 2019, 2:37 PM
arojas closed D19607: Remove unused dependencies.
Mar 8 2019, 2:37 PM · Plasma
arojas requested review of D19607: Remove unused dependencies.
Mar 8 2019, 9:18 AM · Plasma

Mar 5 2019

arojas added a comment to D19549: Fix build with julia 1.1.

Pushed

Mar 5 2019, 11:09 PM · KDE Edu
arojas committed R55:499b9d90337e: Fix build with julia 1.1 (authored by arojas).
Fix build with julia 1.1
Mar 5 2019, 11:08 PM
arojas updated subscribers of D19549: Fix build with julia 1.1.

The last 18.12 release tarballs are done already, so unless you think this is worth a respin there's no point to merge it. (cc @cfeck )

Mar 5 2019, 9:57 PM · KDE Edu
arojas committed R55:00d5e5375df1: Fix build with julia 1.1 (authored by arojas).
Fix build with julia 1.1
Mar 5 2019, 9:46 PM
arojas closed D19549: Fix build with julia 1.1.
Mar 5 2019, 9:46 PM · KDE Edu
arojas added a comment to D19549: Fix build with julia 1.1.

A question, @arojas, how you found this problem, on build step? I have read 1.1 release news, but as I see, julia team hasen't mention, that C-API for exception changed.

Mar 5 2019, 9:29 PM · KDE Edu
arojas updated the diff for D19549: Fix build with julia 1.1.

Fix exception display

Mar 5 2019, 9:28 PM · KDE Edu
arojas requested review of D19549: Fix build with julia 1.1.
Mar 5 2019, 6:43 PM · KDE Edu

Feb 20 2019

arojas committed R89:37ec4c73df4b: Merge branch 'Applications/18.12' (authored by arojas).
Merge branch 'Applications/18.12'
Feb 20 2019, 7:23 AM
arojas committed R89:0e21571f1629: Fix building with akonadi search support (authored by arojas).
Fix building with akonadi search support
Feb 20 2019, 7:23 AM
arojas closed D19172: Fix building with akonadi search support.
Feb 20 2019, 7:23 AM · KDE PIM

Feb 19 2019

arojas requested review of D19172: Fix building with akonadi search support.
Feb 19 2019, 9:18 PM · KDE PIM
arojas committed R344:78d79d316f3c: Merge branch 'Applications/18.12' (authored by arojas).
Merge branch 'Applications/18.12'
Feb 19 2019, 8:20 AM
arojas committed R344:849e8dca4021: Fix displaying covers from cover.jpg files (authored by arojas).
Fix displaying covers from cover.jpg files
Feb 19 2019, 8:17 AM
arojas closed D18885: Fix displaying covers from cover.jpg files.
Feb 19 2019, 8:17 AM

Feb 9 2019

arojas requested review of D18885: Fix displaying covers from cover.jpg files.
Feb 9 2019, 8:29 PM

Feb 2 2019

arojas added a comment to D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.

You also need to change '-Xclang -add-plugin -Xclang clang-lazy' to '-Xclang -add-plugin -Xclang clazy' for the plugin to actually be used.

Feb 2 2019, 6:33 PM · Build System, Frameworks

Jan 13 2019

arojas requested review of D18222: Don't hardcode dbus policy install dir.
Jan 13 2019, 9:46 AM · Frameworks

Dec 10 2018

arojas committed R487:eef6dae58a19: Fix PulseAudio support with Qt 5.12 (authored by arojas).
Fix PulseAudio support with Qt 5.12
Dec 10 2018, 8:10 PM
arojas closed D17486: Fix PulseAudio support with Qt 5.12.
Dec 10 2018, 8:10 PM
arojas committed R345:21c7f15a14d1: Merge branch 'Applications/18.12' (authored by arojas).
Merge branch 'Applications/18.12'
Dec 10 2018, 8:08 PM
arojas closed D17489: Fix PulseAudio support with Qt 5.12.
Dec 10 2018, 8:08 PM
arojas committed R345:be9fce820cbe: Fix PulseAudio support with Qt 5.12 (authored by arojas).
Fix PulseAudio support with Qt 5.12
Dec 10 2018, 8:08 PM
arojas added a comment to D17486: Fix PulseAudio support with Qt 5.12.

Only master ot 4.10 too?

Dec 10 2018, 6:11 PM
arojas requested review of D17489: Fix PulseAudio support with Qt 5.12.
Dec 10 2018, 4:42 PM
arojas requested review of D17486: Fix PulseAudio support with Qt 5.12.
Dec 10 2018, 4:30 PM

Nov 28 2018

arojas abandoned D12761: Allow building kio-nfs against standalone libtirpc.
Nov 28 2018, 7:43 AM · Frameworks, Dolphin
arojas added a comment to D12761: Allow building kio-nfs against standalone libtirpc.

@asturmlechner can you post that in a new review request? I'll abandon this one.

Nov 28 2018, 7:07 AM · Frameworks, Dolphin

Nov 2 2018

arojas committed R8:f099b8e143bb: Fix build with poppler 0.71 (authored by arojas).
Fix build with poppler 0.71
Nov 2 2018, 8:27 PM
arojas committed R8:45559a470604: Fix build with poppler<0.64, take 2 (authored by arojas).
Fix build with poppler<0.64, take 2
Nov 2 2018, 8:27 PM
arojas committed R8:82d68cebf870: GBool -> bool (authored by aacid).
GBool -> bool
Nov 2 2018, 8:27 PM
arojas committed R8:fa4c2961b828: Mark the functions as override (authored by aacid).
Mark the functions as override
Nov 2 2018, 8:27 PM
arojas committed R8:fb6bbaf64c60: Fix build with poppler 0.71 (authored by arojas).
Fix build with poppler 0.71
Nov 2 2018, 8:27 PM
arojas closed D16607: Fix build with poppler 0.71.
Nov 2 2018, 8:27 PM · Calligra: 3.0
arojas requested review of D16607: Fix build with poppler 0.71.
Nov 2 2018, 8:46 AM · Calligra: 3.0

Oct 27 2018

arojas committed R8:eb1cfd31fc14: Fix build with poppler<0.64, take 2 (authored by arojas).
Fix build with poppler<0.64, take 2
Oct 27 2018, 11:18 AM
arojas closed D16455: Fix build with poppler<0.64, take 2.
Oct 27 2018, 11:18 AM · Calligra: 3.0
arojas requested review of D16455: Fix build with poppler<0.64, take 2.
Oct 27 2018, 9:27 AM · Calligra: 3.0
arojas committed R115:b9058eb01fed: Merge branch 'Plasma/5.14' (authored by arojas).
Merge branch 'Plasma/5.14'
Oct 27 2018, 7:50 AM
arojas closed D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3.
Oct 27 2018, 7:49 AM · Plasma
arojas committed R115:c255ac792a0d: Fix connecting to PulseAudio with Qt 5.12 beta 3 (authored by arojas).
Fix connecting to PulseAudio with Qt 5.12 beta 3
Oct 27 2018, 7:49 AM

Oct 26 2018

arojas added a comment to D16406: Fix build with poppler<0.64.

When you say "But this one needs to be fixed in the 3.1 branch too" you mean D16406 (i.e. this very same patch) or the compilation error because of the overrides?

Oct 26 2018, 10:38 PM · Calligra: 3.0
arojas committed R8:3760bb301245: Fix build with poppler<0.64 (authored by arojas).
Fix build with poppler<0.64
Oct 26 2018, 10:37 PM
arojas committed R8:9038af136ba6: Merge branch 'master' of git://anongit.kde.org/calligra (authored by arojas).
Merge branch 'master' of git://anongit.kde.org/calligra
Oct 26 2018, 10:36 PM
arojas committed R8:3e832a0950ea: Fix build with poppler<0.64 (authored by arojas).
Fix build with poppler<0.64
Oct 26 2018, 10:36 PM
arojas closed D16406: Fix build with poppler<0.64.
Oct 26 2018, 10:36 PM · Calligra: 3.0
arojas added a comment to D16406: Fix build with poppler<0.64.

Indeed git master doesn't build with 0.55:

Oct 26 2018, 10:25 PM · Calligra: 3.0
arojas updated the summary of D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3.
Oct 26 2018, 9:15 PM · Plasma
arojas requested review of D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3.
Oct 26 2018, 9:15 PM · Plasma
arojas updated the diff for D16406: Fix build with poppler<0.64.

Invert conditional

Oct 26 2018, 7:20 PM · Calligra: 3.0