arojas (Antonio Rojas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 17 2016, 5:38 PM (144 w, 3 d)
Availability
Available

Recent Activity

Sun, Mar 17

arojas added a comment to D19821: Fix breeze dialog background with Qt 5.12.2.

Apparently tooltips need a fix too https://bbs.archlinux.org/viewtopic.php?pid=1837417#p1837417

Sun, Mar 17, 2:29 PM · Frameworks

Tue, Mar 12

arojas added a comment to D19699: [DataModel] Add nullptr check.

There's D19698 already

Tue, Mar 12, 7:56 AM · Frameworks

Mon, Mar 11

arojas added a comment to D19418: Make it compiles without deprecated method.

This is making Plasma crash, see https://bugs.kde.org/show_bug.cgi?id=405351

Mon, Mar 11, 5:11 PM · Frameworks

Fri, Mar 8

arojas committed R994:58beeb4837da: Remove unused dependencies (authored by arojas).
Remove unused dependencies
Fri, Mar 8, 2:37 PM
arojas closed D19607: Remove unused dependencies.
Fri, Mar 8, 2:37 PM · Plasma
arojas requested review of D19607: Remove unused dependencies.
Fri, Mar 8, 9:18 AM · Plasma

Tue, Mar 5

arojas added a comment to D19549: Fix build with julia 1.1.

Pushed

Tue, Mar 5, 11:09 PM · KDE Edu
arojas committed R55:499b9d90337e: Fix build with julia 1.1 (authored by arojas).
Fix build with julia 1.1
Tue, Mar 5, 11:08 PM
arojas updated subscribers of D19549: Fix build with julia 1.1.

The last 18.12 release tarballs are done already, so unless you think this is worth a respin there's no point to merge it. (cc @cfeck )

Tue, Mar 5, 9:57 PM · KDE Edu
arojas committed R55:00d5e5375df1: Fix build with julia 1.1 (authored by arojas).
Fix build with julia 1.1
Tue, Mar 5, 9:46 PM
arojas closed D19549: Fix build with julia 1.1.
Tue, Mar 5, 9:46 PM · KDE Edu
arojas added a comment to D19549: Fix build with julia 1.1.

A question, @arojas, how you found this problem, on build step? I have read 1.1 release news, but as I see, julia team hasen't mention, that C-API for exception changed.

Tue, Mar 5, 9:29 PM · KDE Edu
arojas updated the diff for D19549: Fix build with julia 1.1.

Fix exception display

Tue, Mar 5, 9:28 PM · KDE Edu
arojas requested review of D19549: Fix build with julia 1.1.
Tue, Mar 5, 6:43 PM · KDE Edu

Feb 20 2019

arojas committed R89:37ec4c73df4b: Merge branch 'Applications/18.12' (authored by arojas).
Merge branch 'Applications/18.12'
Feb 20 2019, 7:23 AM
arojas committed R89:0e21571f1629: Fix building with akonadi search support (authored by arojas).
Fix building with akonadi search support
Feb 20 2019, 7:23 AM
arojas closed D19172: Fix building with akonadi search support.
Feb 20 2019, 7:23 AM · KDE PIM

Feb 19 2019

arojas requested review of D19172: Fix building with akonadi search support.
Feb 19 2019, 9:18 PM · KDE PIM
arojas committed R344:78d79d316f3c: Merge branch 'Applications/18.12' (authored by arojas).
Merge branch 'Applications/18.12'
Feb 19 2019, 8:20 AM
arojas committed R344:849e8dca4021: Fix displaying covers from cover.jpg files (authored by arojas).
Fix displaying covers from cover.jpg files
Feb 19 2019, 8:17 AM
arojas closed D18885: Fix displaying covers from cover.jpg files.
Feb 19 2019, 8:17 AM

Feb 9 2019

arojas requested review of D18885: Fix displaying covers from cover.jpg files.
Feb 9 2019, 8:29 PM

Feb 2 2019

arojas added a comment to D18680: Fix ENABLE_CLAZY option with clazy >= 1.5.

You also need to change '-Xclang -add-plugin -Xclang clang-lazy' to '-Xclang -add-plugin -Xclang clazy' for the plugin to actually be used.

Feb 2 2019, 6:33 PM · Build System, Frameworks

Jan 13 2019

arojas requested review of D18222: Install dbus configuration files under DATADIR by default.
Jan 13 2019, 9:46 AM · Frameworks

Dec 10 2018

arojas committed R487:eef6dae58a19: Fix PulseAudio support with Qt 5.12 (authored by arojas).
Fix PulseAudio support with Qt 5.12
Dec 10 2018, 8:10 PM
arojas closed D17486: Fix PulseAudio support with Qt 5.12.
Dec 10 2018, 8:10 PM
arojas committed R345:21c7f15a14d1: Merge branch 'Applications/18.12' (authored by arojas).
Merge branch 'Applications/18.12'
Dec 10 2018, 8:08 PM
arojas closed D17489: Fix PulseAudio support with Qt 5.12.
Dec 10 2018, 8:08 PM
arojas committed R345:be9fce820cbe: Fix PulseAudio support with Qt 5.12 (authored by arojas).
Fix PulseAudio support with Qt 5.12
Dec 10 2018, 8:08 PM
arojas added a comment to D17486: Fix PulseAudio support with Qt 5.12.

Only master ot 4.10 too?

Dec 10 2018, 6:11 PM
arojas requested review of D17489: Fix PulseAudio support with Qt 5.12.
Dec 10 2018, 4:42 PM
arojas requested review of D17486: Fix PulseAudio support with Qt 5.12.
Dec 10 2018, 4:30 PM

Nov 28 2018

arojas abandoned D12761: Allow building kio-nfs against standalone libtirpc.
Nov 28 2018, 7:43 AM · Frameworks, Dolphin
arojas added a comment to D12761: Allow building kio-nfs against standalone libtirpc.

@asturmlechner can you post that in a new review request? I'll abandon this one.

Nov 28 2018, 7:07 AM · Frameworks, Dolphin

Nov 2 2018

arojas committed R8:f099b8e143bb: Fix build with poppler 0.71 (authored by arojas).
Fix build with poppler 0.71
Nov 2 2018, 8:27 PM
arojas committed R8:45559a470604: Fix build with poppler<0.64, take 2 (authored by arojas).
Fix build with poppler<0.64, take 2
Nov 2 2018, 8:27 PM
arojas committed R8:82d68cebf870: GBool -> bool (authored by aacid).
GBool -> bool
Nov 2 2018, 8:27 PM
arojas committed R8:fa4c2961b828: Mark the functions as override (authored by aacid).
Mark the functions as override
Nov 2 2018, 8:27 PM
arojas committed R8:fb6bbaf64c60: Fix build with poppler 0.71 (authored by arojas).
Fix build with poppler 0.71
Nov 2 2018, 8:27 PM
arojas closed D16607: Fix build with poppler 0.71.
Nov 2 2018, 8:27 PM · Calligra: 3.0
arojas requested review of D16607: Fix build with poppler 0.71.
Nov 2 2018, 8:46 AM · Calligra: 3.0

Oct 27 2018

arojas committed R8:eb1cfd31fc14: Fix build with poppler<0.64, take 2 (authored by arojas).
Fix build with poppler<0.64, take 2
Oct 27 2018, 11:18 AM
arojas closed D16455: Fix build with poppler<0.64, take 2.
Oct 27 2018, 11:18 AM · Calligra: 3.0
arojas requested review of D16455: Fix build with poppler<0.64, take 2.
Oct 27 2018, 9:27 AM · Calligra: 3.0
arojas committed R115:b9058eb01fed: Merge branch 'Plasma/5.14' (authored by arojas).
Merge branch 'Plasma/5.14'
Oct 27 2018, 7:50 AM
arojas closed D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3.
Oct 27 2018, 7:49 AM · Plasma
arojas committed R115:c255ac792a0d: Fix connecting to PulseAudio with Qt 5.12 beta 3 (authored by arojas).
Fix connecting to PulseAudio with Qt 5.12 beta 3
Oct 27 2018, 7:49 AM

Oct 26 2018

arojas added a comment to D16406: Fix build with poppler<0.64.

When you say "But this one needs to be fixed in the 3.1 branch too" you mean D16406 (i.e. this very same patch) or the compilation error because of the overrides?

Oct 26 2018, 10:38 PM · Calligra: 3.0
arojas committed R8:3760bb301245: Fix build with poppler<0.64 (authored by arojas).
Fix build with poppler<0.64
Oct 26 2018, 10:37 PM
arojas committed R8:9038af136ba6: Merge branch 'master' of git://anongit.kde.org/calligra (authored by arojas).
Merge branch 'master' of git://anongit.kde.org/calligra
Oct 26 2018, 10:36 PM
arojas committed R8:3e832a0950ea: Fix build with poppler<0.64 (authored by arojas).
Fix build with poppler<0.64
Oct 26 2018, 10:36 PM
arojas closed D16406: Fix build with poppler<0.64.
Oct 26 2018, 10:36 PM · Calligra: 3.0
arojas added a comment to D16406: Fix build with poppler<0.64.

Indeed git master doesn't build with 0.55:

Oct 26 2018, 10:25 PM · Calligra: 3.0
arojas updated the summary of D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3.
Oct 26 2018, 9:15 PM · Plasma
arojas requested review of D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3.
Oct 26 2018, 9:15 PM · Plasma
arojas updated the diff for D16406: Fix build with poppler<0.64.

Invert conditional

Oct 26 2018, 7:20 PM · Calligra: 3.0
arojas added a comment to D16406: Fix build with poppler<0.64.

I don't mind either way. In the future this could be changed to VERSION_GREATER_EQUAL when this can depend on cmake 3.7

Oct 26 2018, 8:09 AM · Calligra: 3.0

Oct 25 2018

arojas updated the diff for D16406: Fix build with poppler<0.64.

Check for poppler version at cmake time

Oct 25 2018, 6:50 AM · Calligra: 3.0

Oct 24 2018

arojas requested review of D16406: Fix build with poppler<0.64.
Oct 24 2018, 4:49 PM · Calligra: 3.0
arojas committed R407:3feffd64a7b5: Comment out phonon dependency (authored by arojas).
Comment out phonon dependency
Oct 24 2018, 6:42 AM
arojas committed R407:325a90b70ad1: Merge branch 'master' of git://anongit.kde.org/kolf (authored by arojas).
Merge branch 'master' of git://anongit.kde.org/kolf
Oct 24 2018, 6:42 AM
arojas closed D16074: Comment out phonon dependency until sound is reenabled.
Oct 24 2018, 6:42 AM
arojas committed R407:aaf6f5f33d6a: Merge branch 'Applications/18.08' (authored by arojas).
Merge branch 'Applications/18.08'
Oct 24 2018, 6:42 AM
arojas committed R8:a615718222f8: Fix build with poppler>=0.69 (authored by arojas).
Fix build with poppler>=0.69
Oct 24 2018, 6:32 AM
arojas committed R8:56bd4bab320b: Fix build with poppler>=0.69 (authored by arojas).
Fix build with poppler>=0.69
Oct 24 2018, 6:28 AM
arojas closed D16388: Fix build with poppler 0.69.
Oct 24 2018, 6:28 AM · Calligra: 3.0

Oct 23 2018

arojas requested review of D16388: Fix build with poppler 0.69.
Oct 23 2018, 3:04 PM · Calligra: 3.0

Oct 15 2018

arojas committed R120:9fca6f1fb8aa: Merge branch 'Plasma/5.14' (authored by arojas).
Merge branch 'Plasma/5.14'
Oct 15 2018, 6:15 PM
arojas committed R120:81a0fe6db9ac: Fix build with gpsd 3.18 (authored by arojas).
Fix build with gpsd 3.18
Oct 15 2018, 6:15 PM
arojas closed D16081: Fix build with gpsd 3.18.
Oct 15 2018, 6:15 PM · Plasma

Oct 9 2018

arojas requested review of D16081: Fix build with gpsd 3.18.
Oct 9 2018, 4:26 PM · Plasma
arojas committed R55:a8b397aa18da: Disable --simple-prompt Sage parameter for now (authored by arojas).
Disable --simple-prompt Sage parameter for now
Oct 9 2018, 4:02 PM
arojas committed R55:ee1793fa4681: Disable --simple-prompt Sage parameter for now (authored by arojas).
Disable --simple-prompt Sage parameter for now
Oct 9 2018, 4:02 PM
arojas closed D16052: Disable --simple-promt Sage parameter for now.
Oct 9 2018, 4:02 PM · KDE Edu
arojas requested review of D16074: Comment out phonon dependency until sound is reenabled.
Oct 9 2018, 3:12 PM

Oct 8 2018

arojas updated the summary of D16052: Disable --simple-promt Sage parameter for now.
Oct 8 2018, 8:58 PM · KDE Edu
arojas requested review of D16052: Disable --simple-promt Sage parameter for now.
Oct 8 2018, 8:58 PM · KDE Edu

Sep 30 2018

arojas committed R240:05bd97492704: Compile python bindings with the same sip flags used by PyQt (authored by arojas).
Compile python bindings with the same sip flags used by PyQt
Sep 30 2018, 8:47 PM
arojas closed D15091: Compile python bindings with the same sip flags used by PyQt.
Sep 30 2018, 8:47 PM · Build System, Frameworks
arojas abandoned D15852: Fix doc dir in launcher script.

Already fixed another way

Sep 30 2018, 1:10 PM
arojas updated the diff for D15852: Fix doc dir in launcher script.

Use DOC_INSTALL_DIR

Sep 30 2018, 10:08 AM
arojas requested review of D15852: Fix doc dir in launcher script.
Sep 30 2018, 9:40 AM

Sep 21 2018

arojas updated the diff for D15091: Compile python bindings with the same sip flags used by PyQt.

Rebase

Sep 21 2018, 10:35 PM · Build System, Frameworks

Sep 16 2018

arojas committed R425:4d1d989114a0: Fix crash when moving pawn two squares (authored by arojas).
Fix crash when moving pawn two squares
Sep 16 2018, 8:09 PM
arojas closed D15555: Fix crash when moving pawn two squares.
Sep 16 2018, 8:09 PM
arojas requested review of D15555: Fix crash when moving pawn two squares.
Sep 16 2018, 4:17 PM

Sep 12 2018

arojas added a comment to D15148: Fix build with libraw 0.19.

Looks like this was already pushed @ 3b7d0f2cbf66b06e12c57be26b262b71d8030d1a

Sep 12 2018, 5:38 PM · Krita

Sep 8 2018

arojas committed R333:7fe3cd3c6654: Mark phonon as required (authored by arojas).
Mark phonon as required
Sep 8 2018, 10:11 AM
arojas closed D15345: Mark phonon as required.
Sep 8 2018, 10:11 AM · KDE Edu
arojas requested review of D15345: Mark phonon as required.
Sep 8 2018, 10:00 AM · KDE Edu

Sep 7 2018

arojas committed R342:f8fd331b3a0f: Merge branch 'Applications/18.08' (authored by arojas).
Merge branch 'Applications/18.08'
Sep 7 2018, 8:06 PM
arojas committed R342:9aa606bbc4c9: Use the right version of kcmshell (authored by arojas).
Use the right version of kcmshell
Sep 7 2018, 8:06 PM
arojas closed D15336: Use the right version of kcmshell.
Sep 7 2018, 8:06 PM
arojas requested review of D15336: Use the right version of kcmshell.
Sep 7 2018, 5:07 PM

Aug 31 2018

arojas committed R377:ce3d1dc2d1e4: Clarify soversion (authored by arojas).
Clarify soversion
Aug 31 2018, 6:13 PM
arojas closed D15149: Clarify soversion.
Aug 31 2018, 6:13 PM
arojas accepted D14915: Bindings: Check if bindings can be generated for a specific python version.
Aug 31 2018, 1:10 PM · Build System, Frameworks
arojas accepted D14914: Bindings: Use python version matching the found clang python module.
Aug 31 2018, 1:09 PM · Build System, Frameworks
arojas accepted D14912: Bindings: Make generator forward compatible with Python 3.
Aug 31 2018, 1:08 PM · Build System, Frameworks
arojas added a comment to D15149: Clarify soversion.

Adding release managers, not sure who else can review this

Aug 31 2018, 8:20 AM