arojas (Antonio Rojas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 17 2016, 5:38 PM (177 w, 6 d)
Availability
Available

Recent Activity

Today

arojas committed R145:86da8b0f7f2f: Merge branch 'release/19.12' (authored by arojas).
Merge branch 'release/19.12'
Thu, Nov 14, 7:37 PM
arojas closed D25269: Fix build with telepathy-qt 0.9.8.
Thu, Nov 14, 7:36 PM
arojas committed R145:f030b527c4d3: Fix build with telepathy-qt 0.9.8 (authored by arojas).
Fix build with telepathy-qt 0.9.8
Thu, Nov 14, 7:36 PM
arojas added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

The pkgconfig file disagrees:
it contains libsuffix=-2_4 and later Libs: -L${libdir} -lIlmImf${libsuffix}
For me, that library name is correct

Thu, Nov 14, 5:30 PM · Build System, Frameworks
arojas added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

I don't see how that commit is related.
openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so

This is expected afaics.

Thu, Nov 14, 5:23 PM · Build System, Frameworks
arojas added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

This is a bug in openexr. It does actually try to install the unprefixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in https://github.com/openexr/openexr/commit/4e54bde78f65c0fef8a9f794aaacea07813fba09

Thu, Nov 14, 4:53 PM · Build System, Frameworks

Tue, Nov 12

arojas added a comment to D25269: Fix build with telepathy-qt 0.9.8.

What about pushing this as-is for 19.12 and bumping the dependency and using the new target on master (19.12 is already branched)

Tue, Nov 12, 10:25 AM
arojas added a comment to D25269: Fix build with telepathy-qt 0.9.8.

That would require bumping the telepathy-qt dependency, no? I think we're past the dependency freeze for 19.12

Tue, Nov 12, 9:30 AM
arojas requested review of D25269: Fix build with telepathy-qt 0.9.8.
Tue, Nov 12, 8:43 AM

Thu, Nov 7

arojas committed R482:76ff65aec63b: Properly initialize ExceptionInfo in libMagick (authored by arojas).
Properly initialize ExceptionInfo in libMagick
Thu, Nov 7, 8:26 AM
arojas closed D25181: Properly initialize ExceptionInfo in libMagick.
Thu, Nov 7, 8:26 AM

Wed, Nov 6

arojas requested review of D25181: Properly initialize ExceptionInfo in libMagick.
Wed, Nov 6, 10:39 PM

Tue, Nov 5

arojas abandoned D25159: Fix linking to libssh 0.9.1.
Tue, Nov 5, 5:59 PM · Frameworks, Dolphin
arojas updated the test plan for D25159: Fix linking to libssh 0.9.1.
Tue, Nov 5, 3:43 PM · Frameworks, Dolphin
arojas requested review of D25159: Fix linking to libssh 0.9.1.
Tue, Nov 5, 3:33 PM · Frameworks, Dolphin

Sat, Oct 26

arojas committed R55:75b2595d5c11: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Sat, Oct 26, 4:41 PM
arojas committed R55:13b8d731d501: Fix sagemath backend when there is no sage-env (authored by arojas).
Fix sagemath backend when there is no sage-env
Sat, Oct 26, 4:40 PM
arojas closed D24955: Fix sagemath backend when there is no sage-env.
Sat, Oct 26, 4:40 PM · KDE Edu
arojas added a comment to D24955: Fix sagemath backend when there is no sage-env.

If there is no sage-env and Sage expects it then it will throw errors itself - I don't think it's Cantor's job to detect whether the Sage install is broken. Also note that some distros (eg. gentoo) have been patching sage to run without sage-env for a while, so a simple version check wouldn't be reliable.

Sat, Oct 26, 4:35 PM · KDE Edu
arojas requested review of D24955: Fix sagemath backend when there is no sage-env.
Sat, Oct 26, 6:51 AM · KDE Edu

Thu, Oct 24

arojas closed D24915: Fix Cantor version check for linking with poppler.
Thu, Oct 24, 4:04 PM · KDE Edu
arojas committed R262:21b7f075cfdd: Fix Cantor version check for linking with poppler (authored by arojas).
Fix Cantor version check for linking with poppler
Thu, Oct 24, 4:04 PM
arojas requested review of D24915: Fix Cantor version check for linking with poppler.
Thu, Oct 24, 11:39 AM · KDE Edu

Oct 11 2019

arojas closed D24554: Don't build static library when BUILD_TESTING=OFF.
Oct 11 2019, 1:21 PM · Frameworks
arojas committed R245:f436762fb366: Don't build static library when BUILD_TESTING=OFF (authored by arojas).
Don't build static library when BUILD_TESTING=OFF
Oct 11 2019, 1:21 PM
arojas requested review of D24554: Don't build static library when BUILD_TESTING=OFF.
Oct 11 2019, 6:35 AM · Frameworks

Sep 22 2019

arojas committed R239:ec475441f61e: Support NetworkManager 1.20 and do actually compile the NM backend (authored by arojas).
Support NetworkManager 1.20 and do actually compile the NM backend
Sep 22 2019, 2:28 PM
arojas closed D24020: Support NetworkManager 1.20 and do actually compile the NM backend.
Sep 22 2019, 2:28 PM · Frameworks

Sep 21 2019

arojas added a reviewer for D24020: Support NetworkManager 1.20 and do actually compile the NM backend: Frameworks.
Sep 21 2019, 11:13 AM · Frameworks

Sep 19 2019

arojas abandoned D24096: Restore appstream integration in kicker.
Sep 19 2019, 6:03 PM · Plasma
arojas updated the summary of D24096: Restore appstream integration in kicker.
Sep 19 2019, 5:53 PM · Plasma
arojas requested review of D24096: Restore appstream integration in kicker.
Sep 19 2019, 5:53 PM · Plasma

Sep 17 2019

arojas updated the diff for D24020: Support NetworkManager 1.20 and do actually compile the NM backend.
Sep 17 2019, 9:45 AM · Frameworks
arojas added a comment to D24020: Support NetworkManager 1.20 and do actually compile the NM backend.

Indeed, after removing the NM_0_7 check this doesn't even compile...

Sep 17 2019, 9:44 AM · Frameworks
arojas added a comment to D24020: Support NetworkManager 1.20 and do actually compile the NM backend.

Actually I don't think this ever worked - the NM include is guarded by an if(NM_0_7), and this is not defined anywhere

Sep 17 2019, 9:26 AM · Frameworks
arojas requested review of D24020: Support NetworkManager 1.20 and do actually compile the NM backend.
Sep 17 2019, 9:16 AM · Frameworks

Sep 14 2019

arojas added a comment to D23946: Remove dependency on kdesignerplugin.

Does that really justify a hard dependency? It would make more sense for the dependency to be moved to the projects that do use the macro. extra-cmake-modules ships macros that call sip or doxygen and it doesn't hard depend on them.

Sep 14 2019, 5:28 PM · Frameworks
arojas requested review of D23946: Remove dependency on kdesignerplugin.
Sep 14 2019, 5:12 PM · Frameworks

Sep 10 2019

arojas added a comment to D23815: [KConfig] port away from deprecated methods in Qt 5.14.

Why you don't add add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x060000) in cmake toplevel ?
or 5.14 value ? so we can be sure that it builds without deprecated method until it.

(I prefere QT_DISABLE_DEPRECATED_BEFORE=0x060000 so we can fix it each time that we increase qt and not just waiting that we port to qt6) :)

Sep 10 2019, 9:42 AM · Frameworks

Sep 1 2019

arojas committed R665:aa695797407a: Reorder cmake macro imports (authored by arojas).
Reorder cmake macro imports
Sep 1 2019, 8:53 AM
arojas closed D23612: Reorder cmake macro imports.
Sep 1 2019, 8:53 AM
arojas committed R864:c4df3a0f5246: Reorder cmake macro imports (authored by arojas).
Reorder cmake macro imports
Sep 1 2019, 8:52 AM
arojas closed D23613: Reorder cmake macro imports.
Sep 1 2019, 8:52 AM · KDE PIM
arojas committed R250:475447d4e847: Reorder cmake macro imports (authored by arojas).
Reorder cmake macro imports
Sep 1 2019, 8:51 AM
arojas closed D23614: Reorder cmake macro imports.
Sep 1 2019, 8:51 AM · KDE PIM

Aug 31 2019

arojas requested review of D23614: Reorder cmake macro imports.
Aug 31 2019, 6:27 PM · KDE PIM
arojas requested review of D23613: Reorder cmake macro imports.
Aug 31 2019, 6:25 PM · KDE PIM
arojas requested review of D23612: Reorder cmake macro imports.
Aug 31 2019, 6:24 PM

Aug 29 2019

arojas accepted D15956: Port jabber protocol to recent Linphone libraries.

Taking the liberty to approve this since it seems nobody is maintaining kopete nowadays and we've been shipping a similar patch on Arch for years without issues.

Aug 29 2019, 8:34 AM · Kopete
arojas committed R434:2d13d38a138d: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 29 2019, 8:30 AM
arojas committed R434:16ecb62296a9: Fix build with glibc 2.28 (authored by arojas).
Fix build with glibc 2.28
Aug 29 2019, 8:30 AM
arojas closed D14900: Fix build with glibc 2.28.
Aug 29 2019, 8:30 AM · Kopete

Aug 28 2019

arojas committed R240:c806bd48a29f: Keep 'lib' as default LIBDIR on Arch Linux based systems (authored by arojas).
Keep 'lib' as default LIBDIR on Arch Linux based systems
Aug 28 2019, 5:45 AM
arojas closed D23497: Keep 'lib' as default libdir on Arch Linux based systems.
Aug 28 2019, 5:45 AM · Build System, Frameworks
arojas closed D23503: Reorder cmake macro includes.
Aug 28 2019, 5:43 AM
arojas committed R487:76d2c56e9c71: Reorder cmake macro includes (authored by arojas).
Reorder cmake macro includes
Aug 28 2019, 5:43 AM

Aug 27 2019

arojas requested review of D23503: Reorder cmake macro includes.
Aug 27 2019, 6:12 PM
arojas committed R293:33e042970075: Fix section hierachy in distributing.md (authored by arojas).
Fix section hierachy in distributing.md
Aug 27 2019, 4:53 PM
arojas closed D23483: Fix section hierachy in distributing.md.
Aug 27 2019, 4:53 PM · Baloo, Frameworks
arojas requested review of D23497: Keep 'lib' as default libdir on Arch Linux based systems.
Aug 27 2019, 3:12 PM · Build System, Frameworks
arojas requested review of D23483: Fix section hierachy in distributing.md.
Aug 27 2019, 10:26 AM · Baloo, Frameworks

Aug 25 2019

arojas committed R92:08a69e916101: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 3:12 PM
arojas committed R92:bd37dbbe7aa0: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 3:12 PM
arojas committed R93:2ea99391517c: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 3:11 PM
arojas committed R93:6692be8b3bbb: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 3:10 PM
arojas committed R94:9e45fd57cca6: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 3:09 PM
arojas committed R94:32fbf815dc0c: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 3:09 PM
arojas committed R91:cf3cea5ef79b: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 3:08 PM
arojas committed R91:4fb2ba28a59a: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 3:07 PM
arojas committed R88:dd18af5f54f5: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 3:06 PM
arojas committed R88:4069caacd877: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 3:06 PM
arojas committed R78:6857b7a7a71c: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 3:04 PM
arojas committed R78:7f8cbd10f92d: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 3:04 PM
arojas committed R76:1618a1979da2: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 3:03 PM
arojas committed R76:db66e1d94599: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 3:02 PM
arojas committed R75:24a4230e09b6: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 3:01 PM
arojas committed R75:a8ebd6fc52d5: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 3:00 PM
arojas committed R82:1cede2a35919: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 2:59 PM
arojas committed R82:10f7be0bb46a: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 2:59 PM
arojas committed R77:68c7a64d36bf: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 2:57 PM
arojas committed R77:d75e1db71fb3: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 2:57 PM
arojas committed R90:bda73532fed1: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 2:56 PM
arojas committed R90:a9604b32439b: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 2:55 PM
arojas committed R95:35fd1c35dafd: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 2:54 PM
arojas committed R95:1b44ee798997: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 2:54 PM
arojas committed R89:f79aee2d1a1a: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 2:52 PM
arojas committed R89:30a7254e8fd7: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 2:52 PM
arojas committed R490:833e1373f6a8: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 2:50 PM
arojas committed R490:ba0c76c8d556: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 2:49 PM
arojas committed R79:fc38dbc17cab: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 2:47 PM
arojas committed R79:f04527f66d9f: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 2:46 PM
arojas committed R170:a5ef121b9bc2: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 2:43 PM
arojas committed R170:e24f589bd52c: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 2:42 PM
arojas committed R461:36b97f57fed7: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 2:41 PM
arojas committed R461:99f5e2940c0a: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 2:40 PM
arojas committed R174:a7fb292f01d6: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 2:38 PM
arojas committed R174:2dd0d671001a: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 2:34 PM
arojas closed D23423: Include KDE* cmake macros before any others.
Aug 25 2019, 2:34 PM · KDE PIM
arojas committed R459:16e55492ead7: Merge branch 'Applications/19.08' (authored by arojas).
Merge branch 'Applications/19.08'
Aug 25 2019, 2:33 PM
arojas committed R459:c8b837fc1b1f: Include KDE* cmake macros before any others (authored by arojas).
Include KDE* cmake macros before any others
Aug 25 2019, 2:32 PM