arojas (Antonio Rojas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 17 2016, 5:38 PM (118 w, 2 d)
Availability
Available

Recent Activity

Fri, Sep 21

arojas updated the diff for D15091: Compile python bindings with the same sip flags used by PyQt.

Rebase

Fri, Sep 21, 10:35 PM · Build System, Frameworks

Sun, Sep 16

arojas committed R425:4d1d989114a0: Fix crash when moving pawn two squares (authored by arojas).
Fix crash when moving pawn two squares
Sun, Sep 16, 8:09 PM
arojas closed D15555: Fix crash when moving pawn two squares.
Sun, Sep 16, 8:09 PM
arojas requested review of D15555: Fix crash when moving pawn two squares.
Sun, Sep 16, 4:17 PM

Wed, Sep 12

arojas added a comment to D15148: Fix build with libraw 0.19.

Looks like this was already pushed @ 3b7d0f2cbf66b06e12c57be26b262b71d8030d1a

Wed, Sep 12, 5:38 PM · Krita

Sat, Sep 8

arojas committed R333:7fe3cd3c6654: Mark phonon as required (authored by arojas).
Mark phonon as required
Sat, Sep 8, 10:11 AM
arojas closed D15345: Mark phonon as required.
Sat, Sep 8, 10:11 AM · KDE Edu
arojas requested review of D15345: Mark phonon as required.
Sat, Sep 8, 10:00 AM · KDE Edu

Fri, Sep 7

arojas committed R342:f8fd331b3a0f: Merge branch 'Applications/18.08' (authored by arojas).
Merge branch 'Applications/18.08'
Fri, Sep 7, 8:06 PM
arojas committed R342:9aa606bbc4c9: Use the right version of kcmshell (authored by arojas).
Use the right version of kcmshell
Fri, Sep 7, 8:06 PM
arojas closed D15336: Use the right version of kcmshell.
Fri, Sep 7, 8:06 PM
arojas requested review of D15336: Use the right version of kcmshell.
Fri, Sep 7, 5:07 PM

Fri, Aug 31

arojas committed R377:ce3d1dc2d1e4: Clarify soversion (authored by arojas).
Clarify soversion
Fri, Aug 31, 6:13 PM
arojas closed D15149: Clarify soversion.
Fri, Aug 31, 6:13 PM
arojas accepted D14915: Bindings: Check if bindings can be generated for a specific python version.
Fri, Aug 31, 1:10 PM · Build System, Frameworks
arojas accepted D14914: Bindings: Use python version matching the found clang python module.
Fri, Aug 31, 1:09 PM · Build System, Frameworks
arojas accepted D14912: Bindings: Make generator forward compatible with Python 3.
Fri, Aug 31, 1:08 PM · Build System, Frameworks
arojas added a comment to D15149: Clarify soversion.

Adding release managers, not sure who else can review this

Fri, Aug 31, 8:20 AM
arojas added reviewers for D15149: Clarify soversion: aacid, cfeck.
Fri, Aug 31, 8:20 AM
arojas committed R377:f40ebe30dca1: Fix build with libraw 0.19 (authored by arojas).
Fix build with libraw 0.19
Fri, Aug 31, 7:23 AM
arojas closed D15132: Fix build with libraw 0.19.
Fri, Aug 31, 7:23 AM

Wed, Aug 29

arojas abandoned D15133: Drop functionality that depends on libraw features removed in 0.19.

Alright. IMO it's cleaner to just drop API that is eventually no longer going to work (deprecated != not working), but in practice it won't make any difference since nothing uses this code.

Wed, Aug 29, 5:04 PM
arojas requested review of D15149: Clarify soversion.
Wed, Aug 29, 5:00 PM
arojas updated the diff for D15132: Fix build with libraw 0.19.

Minor doc fix

Wed, Aug 29, 4:49 PM
arojas updated the diff for D15132: Fix build with libraw 0.19.

Add deprecation markers, update DecodingQuality enum

Wed, Aug 29, 4:48 PM
arojas added a comment to D15148: Fix build with libraw 0.19.

Does krita use the ifdef'd code at all? If not, it may be simpler to just remove it completely.

Wed, Aug 29, 4:03 PM · Krita

Tue, Aug 28

arojas updated the summary of D15132: Fix build with libraw 0.19.
Tue, Aug 28, 9:38 PM
arojas requested review of D15133: Drop functionality that depends on libraw features removed in 0.19.
Tue, Aug 28, 9:37 PM
arojas requested review of D15132: Fix build with libraw 0.19.
Tue, Aug 28, 9:30 PM
arojas updated the diff for D15091: Compile python bindings with the same sip flags used by PyQt.
Tue, Aug 28, 4:58 PM · Build System, Frameworks
arojas planned changes to D15091: Compile python bindings with the same sip flags used by PyQt.
Tue, Aug 28, 1:55 PM · Build System, Frameworks
arojas committed R123:1421359002d6: Sync MAX_UID with upstream (authored by arojas).
Sync MAX_UID with upstream
Tue, Aug 28, 9:15 AM
arojas closed D13911: Sync MAX_UID with upstream.
Tue, Aug 28, 9:15 AM · Plasma
arojas added a comment to D13911: Sync MAX_UID with upstream.

Ping

Tue, Aug 28, 8:45 AM · Plasma
arojas added a comment to D15091: Compile python bindings with the same sip flags used by PyQt.

I was asking mostly because that's what pyqt upstream strongly suggested (to use all sip_flags) when I asked them.

Tue, Aug 28, 8:39 AM · Build System, Frameworks

Mon, Aug 27

arojas added a comment to D15091: Compile python bindings with the same sip flags used by PyQt.

Why are you simply not using all PYQT_CONFIGURATION["sip_flags"]?

Mon, Aug 27, 9:54 PM · Build System, Frameworks

Sun, Aug 26

arojas added inline comments to D15091: Compile python bindings with the same sip flags used by PyQt.
Sun, Aug 26, 8:05 PM · Build System, Frameworks
arojas updated the diff for D15091: Compile python bindings with the same sip flags used by PyQt.

Use a regex to account for the case where -n an its arg are not space-separated

Sun, Aug 26, 8:04 PM · Build System, Frameworks
arojas requested review of D15091: Compile python bindings with the same sip flags used by PyQt.
Sun, Aug 26, 7:00 PM · Build System, Frameworks
arojas added a comment to D14912: Bindings: Make generator forward compatible with Python 3.

Thats on Arch?

Sun, Aug 26, 6:59 PM · Build System, Frameworks
arojas added a comment to D14912: Bindings: Make generator forward compatible with Python 3.

With this + D14914 + D14915 I can successfully compile bindings without having any python2 package installed.

Sun, Aug 26, 5:34 PM · Build System, Frameworks
arojas added a comment to D14915: Bindings: Check if bindings can be generated for a specific python version.

sip.h is python version agnostic, and in fact we install it under /usr/include. Would it be possible to also check this path?

Sun, Aug 26, 8:51 AM · Build System, Frameworks

Aug 25 2018

arojas added a comment to D14912: Bindings: Make generator forward compatible with Python 3.

Python3 still can't be used after this change: python2 is explicitely required at FindPythonModuleGeneration.cmake:177 (and all subsequent calls to sip_generator.py are done with ${GPB_PYTHON2_COMMAND}). This can be adjusted in another review though.

Aug 25 2018, 7:49 AM · Build System, Frameworks

Aug 21 2018

arojas committed R55:7020a7461515: Fix build with julia 1.0 (authored by arojas).
Fix build with julia 1.0
Aug 21 2018, 6:35 PM
arojas committed R55:0ef1e0944e83: Fix build with julia 1.0 (authored by arojas).
Fix build with julia 1.0
Aug 21 2018, 6:35 PM
arojas closed D14962: Fix build with julia 1.0.
Aug 21 2018, 6:35 PM · Cantor, KDE Edu
arojas updated the diff for D14962: Fix build with julia 1.0.

Escape semicolon

Aug 21 2018, 6:09 PM · Cantor, KDE Edu
arojas added a comment to D14962: Fix build with julia 1.0.

Hi, @arojas
First, Thanks!
Second, I couldn't found julia 1.0.0. As I see, there are problems with JULIA_LIBDL_COMMAND: cmake drop ; symbol (I don't see the symbol in message output).
I add escaping for this symbol (\) and all start works fine.
Do you haven't problem with version 1.0.0?

Aug 21 2018, 6:07 PM · Cantor, KDE Edu
arojas updated the diff for D14962: Fix build with julia 1.0.

Use correct version

Aug 21 2018, 6:43 AM · Cantor, KDE Edu
arojas updated the diff for D14962: Fix build with julia 1.0.

Fix indentation

Aug 21 2018, 6:42 AM · Cantor, KDE Edu
arojas updated the diff for D14962: Fix build with julia 1.0.

Use QT_VERSION_CHECK macro

Aug 21 2018, 6:40 AM · Cantor, KDE Edu

Aug 20 2018

arojas requested review of D14962: Fix build with julia 1.0.
Aug 20 2018, 11:11 PM · Cantor, KDE Edu
arojas added a comment to D14945: Fix sagemath backend with sagemath 8.3.

Thanks @arojas, do you know if this change break the compatibility with previous versions of Sage?

Aug 20 2018, 12:00 PM · Cantor, KDE Edu
arojas committed R55:bd9a2d12b3f0: Fix sagemath backend with sagemath 8.3 (authored by arojas).
Fix sagemath backend with sagemath 8.3
Aug 20 2018, 11:27 AM
arojas committed R55:18f4feb25158: Fix sagemath backend with sagemath 8.3 (authored by arojas).
Fix sagemath backend with sagemath 8.3
Aug 20 2018, 11:24 AM
arojas closed D14945: Fix sagemath backend with sagemath 8.3.
Aug 20 2018, 11:24 AM · Cantor, KDE Edu
arojas requested review of D14945: Fix sagemath backend with sagemath 8.3.
Aug 20 2018, 10:12 AM · Cantor, KDE Edu
arojas committed R55:7bd5486bdb6f: Support julia>=0.7 (authored by arojas).
Support julia>=0.7
Aug 20 2018, 9:58 AM
arojas committed R55:78bfe202c6cd: Support julia>=0.7 (authored by arojas).
Support julia>=0.7
Aug 20 2018, 9:58 AM
arojas closed D14935: Support julia>=0.7.
Aug 20 2018, 9:58 AM · Cantor, KDE Edu

Aug 19 2018

arojas requested review of D14935: Support julia>=0.7.
Aug 19 2018, 10:19 PM · Cantor, KDE Edu

Aug 18 2018

arojas added a comment to D14912: Bindings: Make generator forward compatible with Python 3.

This adds a new build time dependency to all frameworks which support bindings. Any chance to simply port it to python 3 instead?

Aug 18 2018, 7:34 AM · Build System, Frameworks

Aug 17 2018

arojas requested review of D14900: Fix build with glibc 2.28.
Aug 17 2018, 12:05 PM · Kopete
arojas added a comment to D12761: Allow building kio-nfs against standalone libtirpc.

ping, is this ready to merge?

Aug 17 2018, 10:38 AM

Jul 21 2018

arojas committed R824:0a0a70f460e4: Merge branch 'Applications/18.08' (authored by arojas).
Merge branch 'Applications/18.08'
Jul 21 2018, 8:35 AM
arojas committed R824:34d7fd40552f: Honor BUILD_TESTING (authored by arojas).
Honor BUILD_TESTING
Jul 21 2018, 8:34 AM
arojas closed D14259: Honor BUILD_TESTING.
Jul 21 2018, 8:34 AM · Baloo
arojas requested review of D14259: Honor BUILD_TESTING.
Jul 21 2018, 8:27 AM · Baloo
arojas accepted D14258: Fix unnecessary soversion change.

Thanks

Jul 21 2018, 8:24 AM · Baloo
arojas committed R333:4483b876135f: Drop unused kemoticons dependency (authored by arojas).
Drop unused kemoticons dependency
Jul 21 2018, 7:57 AM
arojas closed D14255: Drop unused kemoticons dependency.
Jul 21 2018, 7:57 AM · KDE Edu

Jul 20 2018

arojas requested review of D14255: Drop unused kemoticons dependency.
Jul 20 2018, 10:55 PM · KDE Edu

Jul 19 2018

arojas committed R308:a3847124d53f: Honor BUILD_TESTING (authored by arojas).
Honor BUILD_TESTING
Jul 19 2018, 6:58 AM
arojas closed D13990: Honor BUILD_TESTING.
Jul 19 2018, 6:58 AM · Frameworks

Jul 18 2018

arojas committed R37:858f19a85bb2: Always use the same sipname as PyQt (authored by arojas).
Always use the same sipname as PyQt
Jul 18 2018, 1:57 PM
arojas closed D14182: Always use the same sipname as PyQt.
Jul 18 2018, 1:57 PM · Krita

Jul 17 2018

arojas updated the diff for D14182: Always use the same sipname as PyQt.

Fix build with older sip

Jul 17 2018, 9:59 PM · Krita
arojas added a comment to D14182: Always use the same sipname as PyQt.

I just tested on Neon Dev with PyQt 5.11 and python plugins build and work fine

Jul 17 2018, 7:52 PM · Krita
arojas added a comment to D14182: Always use the same sipname as PyQt.

Hm, I'm afraid it doesn't work for me on Neon 18.04:

Jul 17 2018, 2:49 PM · Krita
arojas updated the diff for D14182: Always use the same sipname as PyQt.

Remove space after '-n', apparently sip doesn't like it

Jul 17 2018, 12:37 PM · Krita
arojas added a comment to D14061: Fix loading PyKrita with PyQt 5.11.

New patch at https://phabricator.kde.org/D14182

Jul 17 2018, 11:06 AM · Krita
arojas requested review of D14182: Always use the same sipname as PyQt.
Jul 17 2018, 11:03 AM · Krita
arojas added a comment to D14061: Fix loading PyKrita with PyQt 5.11.

Argh... I guess the only thing I can do now is add a manual override cmake flag.

Jul 17 2018, 9:18 AM · Krita
arojas added a comment to D14061: Fix loading PyKrita with PyQt 5.11.

No idea about this error (the location of the QtCore/QtCoremod.sip hasn't changed in 5.11 so it should be found as before, and in any case it should be unrelated to this patch).

Jul 17 2018, 9:07 AM · Krita

Jul 15 2018

arojas committed R239:3ab2e2f5592d: Fix qtplugins in KStandardDirs (authored by arojas).
Fix qtplugins in KStandardDirs
Jul 15 2018, 10:26 AM
arojas closed D14124: Fix qtplugins in KStandardDirs.
Jul 15 2018, 10:26 AM · Frameworks
arojas requested review of D14124: Fix qtplugins in KStandardDirs.
Jul 15 2018, 8:02 AM · Frameworks

Jul 14 2018

arojas added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

This has been approved for two weeks and fixes a major issue... could the fix be pushed and then keep working on the auto test later? It already missed 5.48

Jul 14 2018, 10:53 AM · Frameworks

Jul 13 2018

arojas added a comment to D14061: Fix loading PyKrita with PyQt 5.11.

8ee0958ae632e49773b79f837daaf40305777d06 is still wrong: ${PYQT5_VERSION} is the alphanumeric version string, it can't be compared with 5.11.0. Either

Jul 13 2018, 9:35 AM · Krita
arojas added a comment to D14061: Fix loading PyKrita with PyQt 5.11.

We are comparing string-formatted versions, so you should use STRGREATER, not VERSION_GREATER. Otherwise this will give unexpected results: on my system the if() evalulates to false even though I have PyQt 5.11, and in the appimage it seems to evaluate to TRUE with PyQt 5.9.

Jul 13 2018, 9:22 AM · Krita
arojas added a comment to D14061: Fix loading PyKrita with PyQt 5.11.

Oh, STRGREATER_EQUAL requires cmake 3.7. If can be safely changed to STRGREATER, since PYQt 5.11.0 was withdrawn upstream so no distro shound be using it.

Jul 13 2018, 8:07 AM · Krita

Jul 12 2018

arojas committed R37:a9be187ab3ff: Fix loading PyKrita with PyQt 5.11 (authored by arojas).
Fix loading PyKrita with PyQt 5.11
Jul 12 2018, 1:33 PM
arojas committed R37:1df7bb73ff49: Fix loading PyKrita with PyQt 5.11 (authored by arojas).
Fix loading PyKrita with PyQt 5.11
Jul 12 2018, 1:32 PM
arojas closed D14061: Fix loading PyKrita with PyQt 5.11.
Jul 12 2018, 1:32 PM · Krita
arojas added a comment to D14061: Fix loading PyKrita with PyQt 5.11.

I do, just let me know what's the preferred merge workflow: push to 4.1 then merge to master or push to master and cherry-pick in 4.1?

Jul 12 2018, 8:57 AM · Krita

Jul 11 2018

arojas requested review of D14061: Fix loading PyKrita with PyQt 5.11.
Jul 11 2018, 10:20 PM · Krita
arojas added a comment to D13967: Remove FileItemActionPlugin.

Thanks! The purpose part is already released, so I guess the second case will only be relevant for people who self-compile KDE Connect with an older Purpose version.

Jul 11 2018, 1:55 PM · KDE Connect
arojas added a comment to D13967: Remove FileItemActionPlugin.

Sure it will, at least in all packaging systems I know of. The issue here is the time between one update and the other one, when there would be two plugins (if purpose is updated first) or none (if kdeconnect is updated first). I'd suggest to bump KF5_MIN_VERSION to 5.48 to at least prevent the latter.

Jul 11 2018, 1:42 PM · KDE Connect

Jul 10 2018

arojas committed R169:7dd3aa0b2a4b: Honor BUILD_TESTING (authored by arojas).
Honor BUILD_TESTING
Jul 10 2018, 5:00 PM
arojas closed D13981: Honor BUILD_TESTING.
Jul 10 2018, 5:00 PM · Kirigami