sars (Kåre Särs)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 3 2015, 8:56 AM (228 w, 6 d)
Availability
Available

Recent Activity

Jul 17 2019

sars committed R39:2d941799251c: Minimap: Do not grab the left-mmouse-button-click on up/down buttons (authored by sars).
Minimap: Do not grab the left-mmouse-button-click on up/down buttons
Jul 17 2019, 4:40 PM
sars closed D22511: Minimap: Do not grab left mouse click over up/down arrows.
Jul 17 2019, 4:40 PM · Frameworks, Kate
sars requested review of D22511: Minimap: Do not grab left mouse click over up/down arrows.
Jul 17 2019, 3:12 PM · Frameworks, Kate

Jul 15 2019

sars accepted D22059: Enlarge the find and replace add-on combo boxes.

@ngraham Unfortunately there is no way with UI files to dynamically modify the layout depending on the size of the container, so munging the layout in C++ is the best way I know so far :)

Jul 15 2019, 7:54 AM · VDG, Kate

Jul 10 2019

sars added a comment to D22059: Enlarge the find and replace add-on combo boxes.

Sorry for the late review.

Jul 10 2019, 8:55 PM · VDG, Kate

Jun 26 2019

sars added a comment to R40:bfdd0006d19f: S&R: Only add maximum 70 characters context before & after match..

Imagine you have a "minimized" javascript or XML file. You basically have the whole file on one line. This can be thousands of characters on a line. If you now search for a fairly common word in the minimized code, you would duplicate the huge line as many times as you get matches.

Jun 26 2019, 9:21 AM

Jun 24 2019

sars added a comment to D22059: Enlarge the find and replace add-on combo boxes.

What if we put the search combo on one row and the search and next buttons on the next row together with the search places combo.
Then the next row would be the replace combo with the replace buttons and tool buttons on the next?

Jun 24 2019, 8:05 PM · VDG, Kate

Jun 20 2019

sars added a comment to D21940: Make automatic spellcheck work after reloading a document.

LGTM

Jun 20 2019, 8:09 PM · Frameworks, Kate

Jun 18 2019

sars added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

I think a partially highlighted line is better than a totally non-highlighted one. And I think that the user is more likely to instinctively guess correctly why the end of the line is not highlighted than if the line is not highlighted at all.

Jun 18 2019, 10:20 AM · Frameworks, Kate

Jun 15 2019

sars added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

I tried the patch and it improved the performance really much! :) I was able to edit a line that contained over a million characters!

Jun 15 2019, 6:59 PM · Frameworks, Kate

May 13 2019

sars closed D21040: Update according to review request..

The change was submitted in the original pull request

May 13 2019, 6:44 PM · Kate
sars committed R40:cd5477a7ec82: Rudimentary xml/html parser for symbolviewer plugin (authored by Andreas Hohenegger <hohenegger@gmail.com>).
Rudimentary xml/html parser for symbolviewer plugin
May 13 2019, 6:40 PM
sars closed D21024: Rudimentary xml/html parser for symbolviewer plugin.
May 13 2019, 6:40 PM · Kate
sars accepted D21024: Rudimentary xml/html parser for symbolviewer plugin.
May 13 2019, 6:29 PM · Kate
sars added a comment to D16336: BuildView: Add config page with some options.

Sorry for late answer...

May 13 2019, 2:51 PM · Kate

May 6 2019

sars accepted D21040: Update according to review request..

I guess there was some kind of arcanist mistake when this became a separate review request and not an update to D21024 (Rudimentary xml/html parser for symbolviewer plugin)

May 6 2019, 6:47 AM · Kate

May 5 2019

sars requested changes to D21024: Rudimentary xml/html parser for symbolviewer plugin.

Good addition :)

May 5 2019, 7:58 AM · Kate

May 3 2019

sars added a comment to D20974: Clear konsole command-line before send cd command.

This is not an issue on Windows (yet?) as the whole konsole plugin is disabled on Windows.

May 3 2019, 7:16 AM · Kate

Apr 29 2019

sars accepted D20841: Extract HideRectItem class.
Apr 29 2019, 12:33 PM
sars added a comment to D20841: Extract HideRectItem class.

That particular class is yours :)

Apr 29 2019, 12:21 PM
sars added a comment to D20841: Extract HideRectItem class.

My name does not need to be in there since I have not touched that file yet ;)

Apr 29 2019, 12:10 PM

Apr 28 2019

sars accepted D20806: Add HiDPI support.

I do not have strong opinion about the with of the line, it just hit me that it might become a bit narrow...

Apr 28 2019, 7:36 PM
sars accepted D20821: Add HiDPI support.

So to get nice icons on buttons we need to "setAttribute(Qt::AA_UseHighDpiPixmaps);", but that blurs the previews -> devicePixelRatioF() for preview images.

Apr 28 2019, 7:22 PM
sars accepted D20841: Extract HideRectItem class.

Please fix the copyright owner and date of the files before committing.

Apr 28 2019, 6:36 PM

Apr 25 2019

sars added a comment to D20821: Add HiDPI support.

Same ignorant question here as for libksane... Why do we need the HighDpiPixmaps in skanlite? The images get the dpi settings from the scanner setting...

Apr 25 2019, 7:11 PM
sars added a comment to D20806: Add HiDPI support.

Now I must show my ignorance... why do we need this devicePixelRatio in ksanevewer/selectionitem?

Apr 25 2019, 6:51 PM

Apr 1 2019

sars added a comment to D16336: BuildView: Add config page with some options.

Sorry, I thought i had answered, but I had forgotten to do it.

Apr 1 2019, 7:37 AM · Kate

Mar 30 2019

sars added a comment to D19764: Fix Minimap with QtCurve style.

Yes I also have a memory that there was a bug report about it, but I can't find it now....

Mar 30 2019, 9:28 AM · Frameworks, Kate
sars committed R39:2b53012b3b50: Fix Minimap with QtCurve style (authored by sars).
Fix Minimap with QtCurve style
Mar 30 2019, 9:27 AM
sars closed D19764: Fix Minimap with QtCurve style.
Mar 30 2019, 9:27 AM · Frameworks, Kate

Mar 29 2019

sars added reviewers for D19764: Fix Minimap with QtCurve style: dhaumann, cullmann.
Mar 29 2019, 8:29 PM · Frameworks, Kate

Mar 18 2019

sars committed R40:dbdd1b903fb5: S&R: Revert probable branch merging mistake. (authored by sars).
S&R: Revert probable branch merging mistake.
Mar 18 2019, 12:21 PM
sars committed R40:0c40869b1697: S&R: Revert probable branch merging mistake. (authored by sars).
S&R: Revert probable branch merging mistake.
Mar 18 2019, 12:19 PM

Mar 14 2019

sars requested review of D19764: Fix Minimap with QtCurve style.
Mar 14 2019, 5:00 PM · Frameworks, Kate

Mar 4 2019

sars added a comment to D16336: BuildView: Add config page with some options.

This differential does three things

Mar 4 2019, 8:14 PM · Kate

Mar 3 2019

sars committed R483:10f5565d3c55: Bump required LibKSane version and Skanlite version. (authored by sars).
Bump required LibKSane version and Skanlite version.
Mar 3 2019, 10:08 AM
sars committed R483:baa5968b00ee: Use nullptr in stead of 0 (authored by sars).
Use nullptr in stead of 0
Mar 3 2019, 10:08 AM
sars committed R382:c1a7781b6888: Fix zooming in/out with a touchpad (authored by sars).
Fix zooming in/out with a touchpad
Mar 3 2019, 9:50 AM
sars committed R382:c18d052974af: Bump version (authored by sars).
Bump version
Mar 3 2019, 9:50 AM

Mar 2 2019

sars added a comment to D18001: Display resulting image while scanning in a tab of libksane's KSaneWidget.

This is a good improvement idea for libksane. :)

Mar 2 2019, 1:54 PM

Feb 20 2019

sars accepted D18966: Postpone device settings change if scanning is in progress.

Kåre, could you comment my reply?: https://phabricator.kde.org/D18966#411134

Feb 20 2019, 12:59 PM

Feb 12 2019

sars added a comment to D18966: Postpone device settings change if scanning is in progress.

The idea is sane :)

Feb 12 2019, 6:38 PM
sars accepted D17510: Postponed settings change if scanning is in progress.

Can you also return false in setOptVal() in case the scanning is ongoing? (and the corresponding note in the doxygen comments)

Feb 12 2019, 7:34 AM

Feb 11 2019

sars added a comment to D17510: Postponed settings change if scanning is in progress.

The idea is good. Could we have setOptVals() return -1 and setOptVal() false if the scanning is ongoing and the delayed setting of the value implemented in Skanlite?

Feb 11 2019, 3:36 PM
sars accepted D17955: Skanlite may create missing output directories automtically (with user's permission).

OK this can go in.

Feb 11 2019, 10:11 AM

Feb 10 2019

sars added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

Just these minor adjustments and we are there.

Feb 10 2019, 9:45 AM

Feb 6 2019

sars added inline comments to D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e).
Feb 6 2019, 9:12 PM · Frameworks, Kate

Feb 4 2019

sars committed R40:809cb487530e: S&R: Use canonical path while searching in files, like Kate's openUrl() (authored by sars).
S&R: Use canonical path while searching in files, like Kate's openUrl()
Feb 4 2019, 11:03 AM

Jan 29 2019

sars added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

Sorry, busy month... new project at work and got a new computer to configure....

Jan 29 2019, 5:33 PM

Jan 22 2019

sars added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

I think the selection if we save through the PNG 16bit/color or QImage version should be done in Skanlite.cpp not in savePng().

Jan 22 2019, 7:25 AM
sars accepted D18446: Add static version of toQImageSilent().

Please commit!

Jan 22 2019, 6:32 AM

Jan 16 2019

sars added a comment to T10317: Search&Replace plugin improvements.
Jan 16 2019, 9:45 AM · Kate

Jan 15 2019

sars added a comment to T10317: Search&Replace plugin improvements.
  1. Yes the "more option" button is a bit far away. At some point it actually was at the right of all the options. That is a real possibility
Jan 15 2019, 8:31 PM · Kate
sars added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

Sorry for the late response. A lot of real life activities....

Jan 15 2019, 8:00 PM

Jan 13 2019

sars added a comment to D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.

My personal taste would be to only have a small tool-tip saying: See the "Add.." context menu entry for regular expression help.

Jan 13 2019, 4:44 PM · Kate
sars added a comment to T10317: Search&Replace plugin improvements.
  1. These buttons are different than the other buttons in that they modify the UI of the toolview but not the search. So mixing them is maybe not the best? One could think about moving them to the right side of the other buttons and have some type of separator between...
Jan 13 2019, 11:09 AM · Kate
sars added a comment to D17443: Kate: Keyboard shortcuts F6/Shift+F6 for Next/Previous Match.

I would be OK with the addition of F6 and Shift+F6 to the Search plugin, but I think it would be good to have a plan for all the shortcuts and update all at once....

Jan 13 2019, 10:51 AM · Kate
sars accepted D17308: Make CTags/Projects context menu more accessible.

I'm not entirely sure removing the feature of having the lookup word in the menu is an improvement, but I just noticed that the feature is broken and only works when a word is selected.

Jan 13 2019, 10:38 AM · Kate

Jan 9 2019

sars accepted D17955: Skanlite may create missing output directories automtically (with user's permission).

I'm OK with this repaint() and if you want I'm also OK with having the processEvents() until we move the actual saving to a separate thread.

Jan 9 2019, 7:00 AM

Jan 8 2019

sars added a comment to D18083: Search plugin: Add helpful buttons (mainly) for the Regular Expressions switch.

I really like the idea! :)

Jan 8 2019, 10:44 AM · Kate
sars added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

But this all is to just re-paint one time before we freeze for the time it takes to save of the file? Would it be better in the long run to think about moving the saving to a thread?

Jan 8 2019, 10:11 AM

Jan 7 2019

sars added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

I'm OK with parent->repaint()

Jan 7 2019, 1:18 PM
sars added a comment to D18001: Display resulting image while scanning in a tab of libksane's KSaneWidget.

I have not had the time to review this properly sorry :(

Jan 7 2019, 10:30 AM
sars added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

Besides the processEvents() I'm OK with this! :)

Jan 7 2019, 8:25 AM

Jan 4 2019

sars added a comment to D17956: DocumentPrivate: Fix broken doc links in qCWarning.

Adding as a warning message in the view could be another review and needs comments from others first

Jan 4 2019, 7:14 AM · Frameworks, Kate
sars accepted D17956: DocumentPrivate: Fix broken doc links in qCWarning.
Jan 4 2019, 7:10 AM · Frameworks, Kate
sars added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

Hmm... this is only done for local paths. If we only support this feature for local paths it would be much simpler to just use QDir::mkpath(), but it would be nice if it worked for remote folders too...

Jan 4 2019, 7:05 AM

Jan 3 2019

sars added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

@dhaumann OK the limit is too low for Kile that is clear. Visual Studio Code is limiting the highlighting on a line to 10000 characters.

Jan 3 2019, 7:44 AM · Frameworks, Kate

Dec 31 2018

sars added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

The new limit is now limiting the number of characters highlighted on a line. It is only the rest of the line that is not highlighted. This is IMO nicer as you don't see the non-highlighted part at the beginning of the line. The highlighting makes it a bit slower, so I decreased the limit to 512.

Dec 31 2018, 6:39 PM · Frameworks, Kate
sars updated the test plan for D17241: WIP:Disable highlighting after 512 characters on a line..
Dec 31 2018, 6:26 PM · Frameworks, Kate
sars updated the diff for D17241: WIP:Disable highlighting after 512 characters on a line..

Disable highlighting after [limit] characters on a line in stead of the whole line.

Dec 31 2018, 6:22 PM · Frameworks, Kate

Dec 28 2018

sars committed R40:739a730f528c: S&R: Replace matches in chunks also in files. (authored by sars).
S&R: Replace matches in chunks also in files.
Dec 28 2018, 7:06 PM

Dec 23 2018

sars added a comment to D17729: KateStatusBar: Reformatted by astyle command to follow coding style.

I think this is fine, but let Christoph and Dominik decide if we want style fixing commits.

Dec 23 2018, 8:24 AM · Frameworks, Kate

Dec 20 2018

sars added inline comments to D17693: Add option to treat some chars also as "auto bracket" only when we have a selection.
Dec 20 2018, 8:07 AM · Frameworks, Kate

Dec 19 2018

sars added a comment to D17599: Confirm closing muliple tabs..

@shubham I'm wondering about the original issue that you try to fix with this review request. Why do we need a dialog that warns that there are multiple documents open in Kate when we close it?

Dec 19 2018, 12:11 PM · Kate
sars added a comment to D17599: Confirm closing muliple tabs..

Sorry Christmastime is a bit busy...

Dec 19 2018, 10:59 AM · Kate

Dec 16 2018

sars committed R40:33b3e153575f: BuildView: Search item with needed data when navigate in error list (authored by loh.tar).
BuildView: Search item with needed data when navigate in error list
Dec 16 2018, 5:01 PM
sars closed D17602: BuildView: Search item with needed data when navigate in error list.
Dec 16 2018, 5:01 PM · Kate
sars accepted D17602: BuildView: Search item with needed data when navigate in error list.
Dec 16 2018, 4:58 PM · Kate

Dec 15 2018

sars added a comment to D17602: BuildView: Search item with needed data when navigate in error list.

Changing the next/previous slots to go to the items with line numbers would be a good change.

Dec 15 2018, 8:37 PM · Kate
sars added a comment to D17602: BuildView: Search item with needed data when navigate in error list.

I'm not sure why you have to move the setFocus() call to the beginning of the function... your comment says something about selection...

Dec 15 2018, 8:23 PM · Kate
sars added a comment to D16336: BuildView: Add config page with some options.

I think one magic build name is not the best way to enable auto-hiding.

Dec 15 2018, 7:06 PM · Kate

Dec 10 2018

sars committed R40:66a84c9e0f94: Fix include (authored by sars).
Fix include
Dec 10 2018, 12:04 PM
sars added a comment to D16336: BuildView: Add config page with some options.

Sorry, I was a bit busy when this review came and then I forgot about it :(

Dec 10 2018, 7:00 AM · Kate

Dec 9 2018

sars committed R40:cec90e834e6d: SearchView: Harmonize text in searchPlaceCombo (authored by loh.tar).
SearchView: Harmonize text in searchPlaceCombo
Dec 9 2018, 9:25 AM
sars closed D17418: SearchView: Harmonize text in searchPlaceCombo.
Dec 9 2018, 9:25 AM · Kate

Dec 8 2018

sars added a comment to D17432: WIP: Add Analyzer Tool "Cppcheck (for C)".

Wouldn't it be better to make it possible to configure the current CppCheck in stead of adding a new one?

Dec 8 2018, 9:16 PM · Kate
sars added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

@zetazeta I'm not sure the highlighting length limit is worth an option as the editing of the document is not effected. I it is just a bit inconvenient that the highlighting disappears...

Dec 8 2018, 8:59 PM · Frameworks, Kate
sars added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

@dhaumann: You are right, the highlighting of the document still takes place and it is only KateRenderer that stops using the highlighting info for all lines longer than 1024 characters. All shorter lines are highlighted.

Dec 8 2018, 8:53 PM · Frameworks, Kate
sars updated the diff for D17241: WIP:Disable highlighting after 512 characters on a line..
  • Use a bit different config key to force a value reset for the limit.
  • Fix reading the config value.
  • Update the line-highlight disabled info message and position.
Dec 8 2018, 8:24 PM · Frameworks, Kate

Dec 7 2018

sars accepted D17186: Fix Windows CI build issues caused by startPreviewScan slot.

There is not much else we can do than just have a dummy like this, with the current state of the twain wrapper.

Dec 7 2018, 7:54 AM
sars added a comment to D17186: Fix Windows CI build issues caused by startPreviewScan slot.

Sorry! This problem has totally passed me by before this... I'll have a look.

Dec 7 2018, 7:50 AM

Dec 6 2018

sars committed R40:bfdd0006d19f: S&R: Only add maximum 70 characters context before & after match. (authored by sars).
S&R: Only add maximum 70 characters context before & after match.
Dec 6 2018, 3:53 PM
sars added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

The highlighting limit is now returned in a function in KateRenderer as it is used also in katedocument.cpp for the warning/information message.

Dec 6 2018, 1:55 PM · Frameworks, Kate
sars updated the diff for D17241: WIP:Disable highlighting after 512 characters on a line..

Add a message to inform about why the lines are not highlighted.
Add a note about disabled highlighting to the wrapped lines warning.
Increase the default line length limit to 100 000 characters per line.

Dec 6 2018, 1:44 PM · Frameworks, Kate
sars committed R39:cb63ec1ee30a: Only cal updateView() in visibleRange() when endPos() is invalid. (authored by sars).
Only cal updateView() in visibleRange() when endPos() is invalid.
Dec 6 2018, 1:17 PM
sars closed D17243: Only cal updateView() in visibleRange() when endPos() is invalid..
Dec 6 2018, 1:17 PM · Kate, Frameworks
sars added a comment to D16838: S&R: Disable highlighting while replacing.

Now I committed to master. Should I back-ported it to 18.12?

Dec 6 2018, 1:11 PM · Kate
sars committed R40:638cb985cd9e: S&R: Make one transaction for the whole replace to speed up things (authored by sars).
S&R: Make one transaction for the whole replace to speed up things
Dec 6 2018, 1:09 PM
sars closed D16838: S&R: Disable highlighting while replacing.
Dec 6 2018, 1:09 PM · Kate