sars (Kåre Särs)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 3 2015, 8:56 AM (183 w, 6 d)
Availability
Available

Recent Activity

Yesterday

sars committed R40:66a84c9e0f94: Fix include (authored by sars).
Fix include
Mon, Dec 10, 12:04 PM
sars added a comment to D16336: BuildView: Avoid to show ToolView when build is invoked.

Sorry, I was a bit busy when this review came and then I forgot about it :(

Mon, Dec 10, 7:00 AM · Kate

Sun, Dec 9

sars committed R40:cec90e834e6d: SearchView: Harmonize text in searchPlaceCombo (authored by loh.tar).
SearchView: Harmonize text in searchPlaceCombo
Sun, Dec 9, 9:25 AM
sars closed D17418: SearchView: Harmonize text in searchPlaceCombo.
Sun, Dec 9, 9:25 AM · Kate

Sat, Dec 8

sars added a comment to D17432: WIP: Add Analyzer Tool "Cppcheck (for C)".

Wouldn't it be better to make it possible to configure the current CppCheck in stead of adding a new one?

Sat, Dec 8, 9:16 PM · Kate
sars added a comment to D17241: WIP:Disable highlighting for lines longer than 1024 characters..

@zetazeta I'm not sure the highlighting length limit is worth an option as the editing of the document is not effected. I it is just a bit inconvenient that the highlighting disappears...

Sat, Dec 8, 8:59 PM · Frameworks, Kate
sars added a comment to D17241: WIP:Disable highlighting for lines longer than 1024 characters..

@dhaumann: You are right, the highlighting of the document still takes place and it is only KateRenderer that stops using the highlighting info for all lines longer than 1024 characters. All shorter lines are highlighted.

Sat, Dec 8, 8:53 PM · Frameworks, Kate
sars updated the diff for D17241: WIP:Disable highlighting for lines longer than 1024 characters..
  • Use a bit different config key to force a value reset for the limit.
  • Fix reading the config value.
  • Update the line-highlight disabled info message and position.
Sat, Dec 8, 8:24 PM · Frameworks, Kate

Fri, Dec 7

sars accepted D17186: Fix Windows CI build issues caused by startPreviewScan slot.

There is not much else we can do than just have a dummy like this, with the current state of the twain wrapper.

Fri, Dec 7, 7:54 AM
sars added a comment to D17186: Fix Windows CI build issues caused by startPreviewScan slot.

Sorry! This problem has totally passed me by before this... I'll have a look.

Fri, Dec 7, 7:50 AM

Thu, Dec 6

sars committed R40:bfdd0006d19f: S&R: Only add maximum 70 characters context before & after match. (authored by sars).
S&R: Only add maximum 70 characters context before & after match.
Thu, Dec 6, 3:53 PM
sars added a comment to D17241: WIP:Disable highlighting for lines longer than 1024 characters..

The highlighting limit is now returned in a function in KateRenderer as it is used also in katedocument.cpp for the warning/information message.

Thu, Dec 6, 1:55 PM · Frameworks, Kate
sars updated the diff for D17241: WIP:Disable highlighting for lines longer than 1024 characters..

Add a message to inform about why the lines are not highlighted.
Add a note about disabled highlighting to the wrapped lines warning.
Increase the default line length limit to 100 000 characters per line.

Thu, Dec 6, 1:44 PM · Frameworks, Kate
sars committed R39:cb63ec1ee30a: Only cal updateView() in visibleRange() when endPos() is invalid. (authored by sars).
Only cal updateView() in visibleRange() when endPos() is invalid.
Thu, Dec 6, 1:17 PM
sars closed D17243: Only cal updateView() in visibleRange() when endPos() is invalid..
Thu, Dec 6, 1:17 PM · Kate, Frameworks
sars added a comment to D16838: S&R: Disable highlighting while replacing.

Now I committed to master. Should I back-ported it to 18.12?

Thu, Dec 6, 1:11 PM · Kate
sars committed R40:638cb985cd9e: S&R: Make one transaction for the whole replace to speed up things (authored by sars).
S&R: Make one transaction for the whole replace to speed up things
Thu, Dec 6, 1:09 PM
sars closed D16838: S&R: Disable highlighting while replacing.
Thu, Dec 6, 1:09 PM · Kate
sars added a comment to D16838: S&R: Disable highlighting while replacing.

I guess there are no objections to commit this :)

Thu, Dec 6, 7:04 AM · Kate
sars updated the test plan for D16838: S&R: Disable highlighting while replacing.
Thu, Dec 6, 7:04 AM · Kate
sars added a comment to D17243: Only cal updateView() in visibleRange() when endPos() is invalid..

OK, I have used this patch actively for a week now, and I have not noticed any regression... ;)

Thu, Dec 6, 6:45 AM · Kate, Frameworks
sars updated the diff for D17243: Only cal updateView() in visibleRange() when endPos() is invalid..

Remove unneeded temporary

Thu, Dec 6, 6:39 AM · Kate, Frameworks

Tue, Dec 4

sars retitled D17241: WIP:Disable highlighting for lines longer than 1024 characters. from Disable highlighting for lines longer than 1024 characters. to WIP:Disable highlighting for lines longer than 1024 characters..
Tue, Dec 4, 11:30 AM · Frameworks, Kate
sars added a comment to D17241: WIP:Disable highlighting for lines longer than 1024 characters..

I agree, we need to do something about the line length limit (that only wraps the lines at the limit when opening the file).

Tue, Dec 4, 11:30 AM · Frameworks, Kate

Mon, Dec 3

sars accepted D17339: BuildView: Fix broken load of project plugin targets.

It is maybe not optimal to "hide" a bug fix among a bunch of code cosmetics, but the fix is good :)

Mon, Dec 3, 7:47 PM · Kate
sars committed R40:53dd31b494bb: SearchView: Fix missing signal/slot connection to project plugin (authored by loh.tar).
SearchView: Fix missing signal/slot connection to project plugin
Mon, Dec 3, 7:12 AM
sars closed D17296: SearchView: Fix missing signal/slot connection to project plugin.
Mon, Dec 3, 7:12 AM · Kate
sars committed R40:2667d1b4bb23: BuildView: Improve user information when build fails (authored by loh.tar).
BuildView: Improve user information when build fails
Mon, Dec 3, 7:06 AM
sars closed D17297: BuildView: Improve user information when build fails.
Mon, Dec 3, 7:06 AM · Kate

Sun, Dec 2

sars added a comment to D17308: Make CTags/Projects context menu more accessible.

What if you have Project, CTags and the new Zeal plugins active? You need to differentiate them somehow.

Sun, Dec 2, 7:36 PM · Kate
sars added a comment to D17297: BuildView: Improve user information when build fails.

Let's take that one :)

Sun, Dec 2, 7:05 PM · Kate
sars accepted D17297: BuildView: Improve user information when build fails.

I think the text could be "Cannot run command: %1\nWork path %2 does not exist."

Sun, Dec 2, 3:18 PM · Kate
sars accepted D17296: SearchView: Fix missing signal/slot connection to project plugin.

I think this is a fix to the bug 347311

Sun, Dec 2, 2:42 PM · Kate

Sat, Dec 1

sars updated the diff for D17241: WIP:Disable highlighting for lines longer than 1024 characters..

(Remove the unrelated change in src/view/kateview.cpp)

Sat, Dec 1, 5:41 PM · Frameworks, Kate
sars updated the diff for D17241: WIP:Disable highlighting for lines longer than 1024 characters..

Also disable highlighting in selections for lines that are longe than 1024

Sat, Dec 1, 5:23 PM · Frameworks, Kate

Thu, Nov 29

sars added a comment to D17243: Only cal updateView() in visibleRange() when endPos() is invalid..

Note: this is especially bad when the "on the fly spellchecking" is enabled as visibleRange() is used to "optimize" and only highlight what is currently visible. It is called multiple times.

Thu, Nov 29, 8:44 PM · Kate, Frameworks
sars updated the diff for D16838: S&R: Disable highlighting while replacing.

Use EditingTransaction in stead of just disabling highlighting

Thu, Nov 29, 8:38 PM · Kate
sars added a comment to D17241: WIP:Disable highlighting for lines longer than 1024 characters..

If we get it working properly we could make the limit much higher. I tried with 30000 characters and it still worked very good. (except when selecting the line)

Thu, Nov 29, 8:29 PM · Frameworks, Kate
sars requested review of D17243: Only cal updateView() in visibleRange() when endPos() is invalid..
Thu, Nov 29, 8:26 PM · Kate, Frameworks
sars updated the summary of D17241: WIP:Disable highlighting for lines longer than 1024 characters..
Thu, Nov 29, 8:06 PM · Frameworks, Kate
sars requested review of D17241: WIP:Disable highlighting for lines longer than 1024 characters..
Thu, Nov 29, 7:56 PM · Frameworks, Kate
sars added a comment to D16838: S&R: Disable highlighting while replacing.

I tried it and it improves two things first the multiple replace is much faster and second you get the whole replace operation in one undo. I'll do an update when I have cleaned up the experiments a bit :)

Thu, Nov 29, 3:53 AM · Kate

Mon, Nov 12

sars requested review of D16838: S&R: Disable highlighting while replacing.
Mon, Nov 12, 3:43 PM · Kate

Nov 11 2018

sars committed R40:e783f8b87b02: S&R: Add match marks only at the end of searching/replacing. (authored by sars).
S&R: Add match marks only at the end of searching/replacing.
Nov 11 2018, 8:32 AM
sars committed R40:342baeb69825: S&R: Add match marks only at the end of searching/replacing. (authored by sars).
S&R: Add match marks only at the end of searching/replacing.
Nov 11 2018, 8:31 AM

Nov 10 2018

sars accepted D16813: D-Bus global hotkey for scanner preview.

The new connections are better because you get an error just for these problems. Explicitly failing is better than silently doing so on run-time.

Nov 10 2018, 10:51 PM
sars committed R40:db6b3ea9fa30: S&R: Only highlight checked matches (authored by sars).
S&R: Only highlight checked matches
Nov 10 2018, 10:12 PM
sars committed R40:9405751e3766: S&R: Only highlight checked matches (authored by sars).
S&R: Only highlight checked matches
Nov 10 2018, 10:06 PM
sars accepted D16795: Export preview slot.

Adding a function is not breaking backwards compatibility. You can still use Skanlite compiled against an older version with this new version.

Nov 10 2018, 7:46 PM

Nov 9 2018

sars accepted D16779: kate-ctags plugin: support KDevelop (WIP).

I'm a bit confused... I thought KDevelop had much more advanced plugins/features for this? What does KDevelop need this old plugin for? Non-C/C++ languages or what?

Nov 9 2018, 10:15 PM · KDevelop, KTextEditor, Kate

Nov 4 2018

sars added a comment to D16668: Remove document preview plugin: current technology harms workflow.

I would like to give a -1 for removing the plugin I think that the feature is really something that has potential to be great!

Nov 4 2018, 8:03 PM · Kate
sars committed R40:8fa283046254: S&R: Add replace hints to the replace combo-box. (authored by sars).
S&R: Add replace hints to the replace combo-box.
Nov 4 2018, 4:59 PM

Nov 3 2018

sars committed R40:6c7f4a5982f5: S&R: Update the result summary also with 0 matches. (authored by sars).
S&R: Update the result summary also with 0 matches.
Nov 3 2018, 9:15 PM
sars committed R40:a65a63b54743: S&R: Rework the replacing code and add \L & \U support (authored by sars).
S&R: Rework the replacing code and add \L & \U support
Nov 3 2018, 9:15 PM
sars committed R40:bc400164adf4: S&R: Add match-endLine & endColumn to enable easier handling of ranges (authored by sars).
S&R: Add match-endLine & endColumn to enable easier handling of ranges
Nov 3 2018, 9:15 PM
sars committed R40:240f663f800d: Remove duplicate highlighting of matches in itemSelected() (authored by sars).
Remove duplicate highlighting of matches in itemSelected()
Nov 3 2018, 9:15 PM
sars added a comment to D16650: Terminal Tool View: enable AutoSync by default.

+1

Nov 3 2018, 9:09 PM · Kate
sars added a comment to D16652: Terminal plugin: add default shortcut F4 for Toggle Focus.

+1

Nov 3 2018, 9:06 PM · Kate
sars added a comment to D16641: Enable three more plugins by default.

Hmm... File Browser works badly on Windows and Terminal Tool View not at all.

Nov 3 2018, 8:40 PM · Kate

Sep 14 2018

sars added a comment to D14938: Force ki18n to build with the libintl.so path.

If I understand the comments correct it assumes that if we use a libc that already has what we need, we don't need to use a separate library for it.

Sep 14 2018, 10:23 AM · Craft

Sep 5 2018

sars accepted D15267: Reduce differences between KSaneScanThread and KSanePreviewThread.

Looks good to me...

Sep 5 2018, 6:09 AM

Aug 30 2018

sars accepted D15172: Extract KSanePreviewImageBuilder::renewImage().

Please commit!

Aug 30 2018, 6:39 PM
sars accepted D15168: Show tool buttons for zoom actions in ShowImageDialog.

Looks good.

Aug 30 2018, 6:04 PM
sars accepted D15166: Extract ShowImageDialog.

I was going to ask what the reason was for having a separate dialog, but your next review explains it.

Aug 30 2018, 6:03 PM

Aug 25 2018

sars committed R382:ef39d6cfd6c9: Fix setting gamma-tables that are not symmetrical (items / range) (authored by sars).
Fix setting gamma-tables that are not symmetrical (items / range)
Aug 25 2018, 11:22 AM

Aug 22 2018

sars accepted D14993: Extract KSanePreviewImageBuilder from KSanePreviewThread.

I like it :) Please commit!

Aug 22 2018, 7:13 PM
sars added a comment to D14993: Extract KSanePreviewImageBuilder from KSanePreviewThread.

I like the direction!

Aug 22 2018, 12:13 PM

Aug 15 2018

sars committed R40:a47e8f706377: S&R: Use same workaround icon for advanced-search as built-in search (authored by sars).
S&R: Use same workaround icon for advanced-search as built-in search
Aug 15 2018, 9:31 AM
sars committed R40:213846cbcdaf: S&R: Use workaround icon that does not clash with next/previous (authored by sars).
S&R: Use workaround icon that does not clash with next/previous
Aug 15 2018, 9:31 AM
sars closed D14856: Search: Add workaround for missing icons in Gnome icon-theme.
Aug 15 2018, 9:26 AM · Frameworks, Kate
sars committed R39:e63efbdb8e4c: Search: Add workaround for missing icons in Gnome icon-theme (authored by sars).
Search: Add workaround for missing icons in Gnome icon-theme
Aug 15 2018, 9:26 AM
sars updated the diff for D14856: Search: Add workaround for missing icons in Gnome icon-theme.

use fromTheme("foo", fromTheme("fall-back"));

Aug 15 2018, 9:15 AM · Frameworks, Kate
sars added a reviewer for D14856: Search: Add workaround for missing icons in Gnome icon-theme: Kate.
Aug 15 2018, 8:47 AM · Frameworks, Kate
sars updated the test plan for D14856: Search: Add workaround for missing icons in Gnome icon-theme.
Aug 15 2018, 8:47 AM · Frameworks, Kate
sars requested review of D14856: Search: Add workaround for missing icons in Gnome icon-theme.
Aug 15 2018, 8:43 AM · Frameworks, Kate

Aug 14 2018

sars committed R40:ada3f3239df3: S&R: Add comment for the Gnome-Icon-Workaround (authored by sars).
S&R: Add comment for the Gnome-Icon-Workaround
Aug 14 2018, 1:31 PM
sars committed R40:a5280fb3ec01: S&R: Add backup icons for users using Gnome (without Breeze/Oxygen) (authored by sars).
S&R: Add backup icons for users using Gnome (without Breeze/Oxygen)
Aug 14 2018, 1:12 PM
sars committed R40:7546a76dd583: SymbolsView: Move copyright email line to highlight the original author (authored by sars).
SymbolsView: Move copyright email line to highlight the original author
Aug 14 2018, 10:16 AM
sars closed D14803: Use non-deprecated version of KRun::runUrl() in modified-on-disk dialog.
Aug 14 2018, 10:00 AM · Kate
sars committed R40:538564e67a8e: Use non-deprecated version of KRun::runUrl() in modified-on-disk dialog (authored by sars).
Use non-deprecated version of KRun::runUrl() in modified-on-disk dialog
Aug 14 2018, 10:00 AM

Aug 13 2018

sars requested review of D14803: Use non-deprecated version of KRun::runUrl() in modified-on-disk dialog.
Aug 13 2018, 6:28 PM · Kate
sars committed R40:42539be5f235: SymbolView: Fix item selection when a node is collapsed/expanded (authored by sars).
SymbolView: Fix item selection when a node is collapsed/expanded
Aug 13 2018, 12:21 PM

Aug 12 2018

sars added a comment to D14659: SymbolView: Save view settings individual for each parser.

Sorry to hear that you are not interested any more :(

Aug 12 2018, 12:55 PM · Kate

Aug 11 2018

sars committed R40:3e6261a10bdd: SymbolView: Add expand and parameter options to popup menu (authored by loh.tar).
SymbolView: Add expand and parameter options to popup menu
Aug 11 2018, 1:27 PM
sars closed D14620: SymbolView: Add expand and parameter options to popup menu.
Aug 11 2018, 1:27 PM · Kate
sars accepted D14620: SymbolView: Add expand and parameter options to popup menu.
Aug 11 2018, 1:21 PM · Kate
sars added a comment to D14497: SymbolView: Add a plain-text-parser.

OK, Cool :)

Aug 11 2018, 12:52 PM · Kate
sars added a comment to D14659: SymbolView: Save view settings individual for each parser.

It would add a some code complexity, but I'm not sure it adds so much value that it would be worth it.... If you want the tree-mode for one file type, the probability is quite high that you want it for the other types too. I don̈́'t remember any bug report that would request that feature... Are you asking for it? ;)

Aug 11 2018, 12:51 PM · Kate

Aug 10 2018

sars requested changes to D14620: SymbolView: Add expand and parameter options to popup menu.

I was just about to commit this change when I noticed that:

Aug 10 2018, 5:17 AM · Kate

Aug 7 2018

sars added a comment to D14658: SymbolView: Avoid unneeded ask for document type.

Adding a member-variable to avoid one getter cal is just adding complexity and saves you almost nothing.

Aug 7 2018, 7:01 AM · Kate
sars accepted D14620: SymbolView: Add expand and parameter options to popup menu.

But now I'm curious which part of my text was so persuasive.

Aug 7 2018, 6:53 AM · Kate

Aug 6 2018

sars added a comment to D14620: SymbolView: Add expand and parameter options to popup menu.

Except for the actionTriggered() function I'm ready to accept this patch.

Aug 6 2018, 10:29 AM · Kate
sars committed R40:13e7510eefe2: SymbolView: Improve "Not Supported" message (authored by loh.tar).
SymbolView: Improve "Not Supported" message
Aug 6 2018, 9:54 AM
sars closed D14518: SymbolView: Improve "Not Supported" message.
Aug 6 2018, 9:54 AM · Kate

Aug 5 2018

sars added a comment to D14620: SymbolView: Add expand and parameter options to popup menu.

Do you miss the update in D14518 too?

The changes in the settings page is permanent, while the changes in the popup-menu is temporary -> I don't want to get rid of the settings page.

As said, it can/will be saved automatic. Then it is permanent and that page useless.

Aug 5 2018, 9:11 PM · Kate
sars added a comment to D14518: SymbolView: Improve "Not Supported" message.

Otherwise I'm ready to commit.

Aug 5 2018, 8:58 PM · Kate
sars committed R40:04f7e67cd6cc: SymbolView Fix: Save&Restore sort order in parseSymbols() (authored by loh.tar).
SymbolView Fix: Save&Restore sort order in parseSymbols()
Aug 5 2018, 9:48 AM
sars closed D14515: SymbolView Fix: Save&Restore sort order in parseSymbols().
Aug 5 2018, 9:48 AM · Kate
sars accepted D14515: SymbolView Fix: Save&Restore sort order in parseSymbols().

I had missed this one....

Aug 5 2018, 9:45 AM · Kate
sars added a comment to D14620: SymbolView: Add expand and parameter options to popup menu.

I think it is ok to add these to the popup.

Aug 5 2018, 9:39 AM · Kate