sars (Kåre Särs)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 3 2015, 8:56 AM (242 w, 4 d)
Availability
Available

Recent Activity

Tue, Jan 21

sars committed R40:8991d6186425: build plugin: Fix detecting current make directory (authored by sars).
build plugin: Fix detecting current make directory
Tue, Jan 21, 6:57 PM

Thu, Jan 16

sars committed R382:bdabe32a36cd: Try to fix compilation on FreeBSD (authored by sars).
Try to fix compilation on FreeBSD
Thu, Jan 16, 8:45 PM

Mon, Jan 13

sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

Thank you both for the reviews :)

Mon, Jan 13, 6:47 PM
sars committed R382:7f983585f062: Add scan-area sliders and predefined page sizes combobox (authored by sars).
Add scan-area sliders and predefined page sizes combobox
Mon, Jan 13, 6:44 PM
sars closed D26351: Add scan-area sliders and predefined page sizes combobox.
Mon, Jan 13, 6:44 PM
sars added a comment to D26620: Do not assume that list of documents is non-empty.

But I'm fine without the changes also :)

Mon, Jan 13, 11:14 AM · Kate
sars accepted D26620: Do not assume that list of documents is non-empty.
Mon, Jan 13, 11:13 AM · Kate

Thu, Jan 9

sars updated the diff for D26351: Add scan-area sliders and predefined page sizes combobox.
  • Fix inch as display unit: 1 inch = 25.4 mm (it was not cm->inch)
Thu, Jan 9, 4:13 PM
sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

Everything is big in America :)

Thu, Jan 9, 10:29 AM
sars added a comment to F7872152: LOCALE-en_US.png.

Everything is big in America ;) (Legal should be 8.5 X 14 inch)

Thu, Jan 9, 10:27 AM
sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

@antonarnold I'm not exactly sure what is wrong in those ;)

Thu, Jan 9, 7:49 AM

Wed, Jan 8

sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

@antonarnold Good bug catch! All the scan sources I have here, have the same size so I did never reach that code path...

Wed, Jan 8, 6:07 PM
sars updated the diff for D26351: Add scan-area sliders and predefined page sizes combobox.
  • Set the page size to "Custom" when the source size changes.
Wed, Jan 8, 5:57 PM

Fri, Jan 3

sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

Ah OK :). The spinbox+slider is a reused widget that is used for all numeric properties in libksane :)

Fri, Jan 3, 7:24 AM

Thu, Jan 2

sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

The sliders provide the size of the scanned area in numeric form and there is the possibility to fine-tune the scan area without having to bee too steady on the hand when doing the selection. So I do see a value in having the sliders in some form...

Thu, Jan 2, 7:34 PM
sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

I'm not 100% happy with having the size sliders there directly after the color options.

Thu, Jan 2, 7:18 PM
sars updated the test plan for D26351: Add scan-area sliders and predefined page sizes combobox.
Thu, Jan 2, 7:07 PM

Wed, Jan 1

sars requested review of D26351: Add scan-area sliders and predefined page sizes combobox.
Wed, Jan 1, 7:08 PM

Dec 27 2019

sars committed R39:92e5b0b9aac0: Avoid unwanted horizontal scrolling (authored by sars).
Avoid unwanted horizontal scrolling
Dec 27 2019, 10:25 AM
sars closed D26071: Avoid unwanted horizontal scrolling.
Dec 27 2019, 10:25 AM · Frameworks, Kate

Dec 26 2019

sars added reviewers for D26071: Avoid unwanted horizontal scrolling: Kate, dhaumann, cullmann.
Dec 26 2019, 10:08 AM · Frameworks, Kate

Dec 17 2019

sars requested review of D26071: Avoid unwanted horizontal scrolling.
Dec 17 2019, 5:06 PM · Frameworks, Kate

Dec 11 2019

sars committed R382:3130174cae4e: Fix color-options layout & KSaneOptCombo::setValue() (authored by antonarnold).
Fix color-options layout & KSaneOptCombo::setValue()
Dec 11 2019, 9:46 PM
sars committed R382:992fd7c77d75: Fix color-options layout & KSaneOptCombo::setValue() (authored by antonarnold).
Fix color-options layout & KSaneOptCombo::setValue()
Dec 11 2019, 9:45 PM
sars closed D25588: Fix color-options layout & KSaneOptCombo::setValue().
Dec 11 2019, 9:45 PM
sars added a comment to D25588: Fix color-options layout & KSaneOptCombo::setValue().

Do you want to send a new version or should I Just remove the separator removal and use "... = QLocale::toFloat(tmp);" and commit in your name?

Dec 11 2019, 8:39 PM

Dec 10 2019

sars accepted D25052: Optimize support of scanners with different image sources or duplex unit.

Thanks for these fixes :)

Dec 10 2019, 10:04 AM

Dec 7 2019

sars added a comment to D25599: Fix plugin-metadata translations on windows.

Yes it works :)

Dec 7 2019, 8:55 AM · Frameworks, Windows

Dec 5 2019

sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

I have been a bit reluctant to add the predefined page sizes, but maybe it is time to rethink it...

Dec 5 2019, 8:09 PM

Dec 4 2019

sars added a comment to D25599: Fix plugin-metadata translations on windows.

I would agree that a UNIX/POSIX env var is not the most logical thing to use on Windows, but how do we ensure that we are in sync with ki18n? The usage of QLocale in ki18n looks like it is just adding extra languages to a list of languages, not actually using QLocale to determine what catalog to load. At least LANGUAGE overrides any QLocale settings. Should ki18n not be moved to using QLocale and setDefault()?

Dec 4 2019, 12:45 PM · Frameworks, Windows
sars added a comment to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.

I was actually wondering why the F4 shortcut was put to Focus/Defocus Terminal and not to the "Show Terminal" action. The later action works the same as Dolphin (except that the focus to the terminal got broken at some point this fall or summer).

Dec 4 2019, 12:26 PM · Goal: Consistency, Dolphin, Kate
sars added a comment to D25599: Fix plugin-metadata translations on windows.

So the conclusion is that we are not using setDefault() yet and ki18n & gettext uses the LANGUAGE env so the logical thing, for now, is to also use LANGUAGE env here in KCoreAddons for the plugin metadata translations?

Dec 4 2019, 8:24 AM · Frameworks, Windows

Dec 3 2019

sars added inline comments to D25052: Optimize support of scanners with different image sources or duplex unit.
Dec 3 2019, 6:35 PM

Dec 1 2019

sars added a comment to D25599: Fix plugin-metadata translations on windows.

ki18n does not seem to use QLocale to get the language for translation, but uses LANGUAGE env. Also gettext uses the env variable.

Dec 1 2019, 7:19 PM · Frameworks, Windows
sars added reviewers for D25599: Fix plugin-metadata translations on windows: aacid, vonreth.
Dec 1 2019, 7:44 AM · Frameworks, Windows

Nov 29 2019

sars added a comment to D25588: Fix color-options layout & KSaneOptCombo::setValue().

BTW should this also be done to to other options setting numbers?

Nov 29 2019, 11:02 AM
sars accepted D25588: Fix color-options layout & KSaneOptCombo::setValue().
Nov 29 2019, 11:00 AM
sars updated the summary of D25588: Fix color-options layout & KSaneOptCombo::setValue().
Nov 29 2019, 11:00 AM

Nov 28 2019

sars requested review of D25599: Fix plugin-metadata translations on windows.
Nov 28 2019, 5:36 PM · Frameworks, Windows

Nov 24 2019

sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

Scratch that 19.12 comment, the 19.12 feature freeze was already the 14th... The bug fixes can go in as they are bug fixes ;) so no hurry.

Nov 24 2019, 4:59 PM
sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

That is absolutely fine!

Nov 24 2019, 4:56 PM

Nov 17 2019

sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

I hope I did not scare you off with my comments. These fixes are really welcome!

Nov 17 2019, 9:25 AM

Oct 30 2019

sars added inline comments to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.
Oct 30 2019, 9:24 PM

Oct 29 2019

sars added a comment to D25052: Optimize support of scanners with different image sources or duplex unit.

Isn't the change in setOptVals() the only change needed for fixing the scan option order problem?

Oct 29 2019, 7:14 PM
sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

Generally good changes :)

Oct 29 2019, 6:28 PM

Oct 27 2019

sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

Hmm yes, that order in which we restore the saved options could have a priority order. We could just check if the map contains scan source and execute that first. Then check for mode and resolution and then after that the rest.

Oct 27 2019, 5:08 PM

Oct 25 2019

sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

Thanks for your review request! :)

Oct 25 2019, 8:00 PM

Jul 17 2019

sars committed R39:2d941799251c: Minimap: Do not grab the left-mmouse-button-click on up/down buttons (authored by sars).
Minimap: Do not grab the left-mmouse-button-click on up/down buttons
Jul 17 2019, 4:40 PM
sars closed D22511: Minimap: Do not grab left mouse click over up/down arrows.
Jul 17 2019, 4:40 PM · Frameworks, Kate
sars requested review of D22511: Minimap: Do not grab left mouse click over up/down arrows.
Jul 17 2019, 3:12 PM · Frameworks, Kate

Jul 15 2019

sars accepted D22059: Enlarge the find and replace add-on combo boxes.

@ngraham Unfortunately there is no way with UI files to dynamically modify the layout depending on the size of the container, so munging the layout in C++ is the best way I know so far :)

Jul 15 2019, 7:54 AM · VDG, Kate

Jul 10 2019

sars added a comment to D22059: Enlarge the find and replace add-on combo boxes.

Sorry for the late review.

Jul 10 2019, 8:55 PM · VDG, Kate

Jun 26 2019

sars added a comment to R40:bfdd0006d19f: S&R: Only add maximum 70 characters context before & after match..

Imagine you have a "minimized" javascript or XML file. You basically have the whole file on one line. This can be thousands of characters on a line. If you now search for a fairly common word in the minimized code, you would duplicate the huge line as many times as you get matches.

Jun 26 2019, 9:21 AM

Jun 24 2019

sars added a comment to D22059: Enlarge the find and replace add-on combo boxes.

What if we put the search combo on one row and the search and next buttons on the next row together with the search places combo.
Then the next row would be the replace combo with the replace buttons and tool buttons on the next?

Jun 24 2019, 8:05 PM · VDG, Kate

Jun 20 2019

sars added a comment to D21940: Make automatic spellcheck work after reloading a document.

LGTM

Jun 20 2019, 8:09 PM · Frameworks, Kate

Jun 18 2019

sars added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

I think a partially highlighted line is better than a totally non-highlighted one. And I think that the user is more likely to instinctively guess correctly why the end of the line is not highlighted than if the line is not highlighted at all.

Jun 18 2019, 10:20 AM · Frameworks, Kate

Jun 15 2019

sars added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

I tried the patch and it improved the performance really much! :) I was able to edit a line that contained over a million characters!

Jun 15 2019, 6:59 PM · Frameworks, Kate

May 13 2019

sars closed D21040: Update according to review request..

The change was submitted in the original pull request

May 13 2019, 6:44 PM · Kate
sars committed R40:cd5477a7ec82: Rudimentary xml/html parser for symbolviewer plugin (authored by Andreas Hohenegger <hohenegger@gmail.com>).
Rudimentary xml/html parser for symbolviewer plugin
May 13 2019, 6:40 PM
sars closed D21024: Rudimentary xml/html parser for symbolviewer plugin.
May 13 2019, 6:40 PM · Kate
sars accepted D21024: Rudimentary xml/html parser for symbolviewer plugin.
May 13 2019, 6:29 PM · Kate
sars added a comment to D16336: BuildView: Add config page with some options.

Sorry for late answer...

May 13 2019, 2:51 PM · Kate

May 6 2019

sars accepted D21040: Update according to review request..

I guess there was some kind of arcanist mistake when this became a separate review request and not an update to D21024 (Rudimentary xml/html parser for symbolviewer plugin)

May 6 2019, 6:47 AM · Kate

May 5 2019

sars requested changes to D21024: Rudimentary xml/html parser for symbolviewer plugin.

Good addition :)

May 5 2019, 7:58 AM · Kate

May 3 2019

sars added a comment to D20974: Clear konsole command-line before send cd command.

This is not an issue on Windows (yet?) as the whole konsole plugin is disabled on Windows.

May 3 2019, 7:16 AM · Kate

Apr 29 2019

sars accepted D20841: Extract HideRectItem class.
Apr 29 2019, 12:33 PM
sars added a comment to D20841: Extract HideRectItem class.

That particular class is yours :)

Apr 29 2019, 12:21 PM
sars added a comment to D20841: Extract HideRectItem class.

My name does not need to be in there since I have not touched that file yet ;)

Apr 29 2019, 12:10 PM

Apr 28 2019

sars accepted D20806: Add HiDPI support.

I do not have strong opinion about the with of the line, it just hit me that it might become a bit narrow...

Apr 28 2019, 7:36 PM
sars accepted D20821: Add HiDPI support.

So to get nice icons on buttons we need to "setAttribute(Qt::AA_UseHighDpiPixmaps);", but that blurs the previews -> devicePixelRatioF() for preview images.

Apr 28 2019, 7:22 PM
sars accepted D20841: Extract HideRectItem class.

Please fix the copyright owner and date of the files before committing.

Apr 28 2019, 6:36 PM

Apr 25 2019

sars added a comment to D20821: Add HiDPI support.

Same ignorant question here as for libksane... Why do we need the HighDpiPixmaps in skanlite? The images get the dpi settings from the scanner setting...

Apr 25 2019, 7:11 PM
sars added a comment to D20806: Add HiDPI support.

Now I must show my ignorance... why do we need this devicePixelRatio in ksanevewer/selectionitem?

Apr 25 2019, 6:51 PM

Apr 1 2019

sars added a comment to D16336: BuildView: Add config page with some options.

Sorry, I thought i had answered, but I had forgotten to do it.

Apr 1 2019, 7:37 AM · Kate

Mar 30 2019

sars added a comment to D19764: Fix Minimap with QtCurve style.

Yes I also have a memory that there was a bug report about it, but I can't find it now....

Mar 30 2019, 9:28 AM · Frameworks, Kate
sars committed R39:2b53012b3b50: Fix Minimap with QtCurve style (authored by sars).
Fix Minimap with QtCurve style
Mar 30 2019, 9:27 AM
sars closed D19764: Fix Minimap with QtCurve style.
Mar 30 2019, 9:27 AM · Frameworks, Kate

Mar 29 2019

sars added reviewers for D19764: Fix Minimap with QtCurve style: dhaumann, cullmann.
Mar 29 2019, 8:29 PM · Frameworks, Kate

Mar 18 2019

sars committed R40:dbdd1b903fb5: S&R: Revert probable branch merging mistake. (authored by sars).
S&R: Revert probable branch merging mistake.
Mar 18 2019, 12:21 PM
sars committed R40:0c40869b1697: S&R: Revert probable branch merging mistake. (authored by sars).
S&R: Revert probable branch merging mistake.
Mar 18 2019, 12:19 PM

Mar 14 2019

sars requested review of D19764: Fix Minimap with QtCurve style.
Mar 14 2019, 5:00 PM · Frameworks, Kate

Mar 4 2019

sars added a comment to D16336: BuildView: Add config page with some options.

This differential does three things

Mar 4 2019, 8:14 PM · Kate

Mar 3 2019

sars committed R483:10f5565d3c55: Bump required LibKSane version and Skanlite version. (authored by sars).
Bump required LibKSane version and Skanlite version.
Mar 3 2019, 10:08 AM
sars committed R483:baa5968b00ee: Use nullptr in stead of 0 (authored by sars).
Use nullptr in stead of 0
Mar 3 2019, 10:08 AM
sars committed R382:c1a7781b6888: Fix zooming in/out with a touchpad (authored by sars).
Fix zooming in/out with a touchpad
Mar 3 2019, 9:50 AM
sars committed R382:c18d052974af: Bump version (authored by sars).
Bump version
Mar 3 2019, 9:50 AM

Mar 2 2019

sars added a comment to D18001: Display resulting image while scanning in a tab of libksane's KSaneWidget.

This is a good improvement idea for libksane. :)

Mar 2 2019, 1:54 PM

Feb 20 2019

sars accepted D18966: Postpone device settings change if scanning is in progress.

Kåre, could you comment my reply?: https://phabricator.kde.org/D18966#411134

Feb 20 2019, 12:59 PM

Feb 12 2019

sars added a comment to D18966: Postpone device settings change if scanning is in progress.

The idea is sane :)

Feb 12 2019, 6:38 PM
sars accepted D17510: Postponed settings change if scanning is in progress.

Can you also return false in setOptVal() in case the scanning is ongoing? (and the corresponding note in the doxygen comments)

Feb 12 2019, 7:34 AM

Feb 11 2019

sars added a comment to D17510: Postponed settings change if scanning is in progress.

The idea is good. Could we have setOptVals() return -1 and setOptVal() false if the scanning is ongoing and the delayed setting of the value implemented in Skanlite?

Feb 11 2019, 3:36 PM
sars accepted D17955: Skanlite may create missing output directories automtically (with user's permission).

OK this can go in.

Feb 11 2019, 10:11 AM

Feb 10 2019

sars added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

Just these minor adjustments and we are there.

Feb 10 2019, 9:45 AM

Feb 6 2019

sars added inline comments to D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e).
Feb 6 2019, 9:12 PM · Frameworks, Kate

Feb 4 2019

sars committed R40:809cb487530e: S&R: Use canonical path while searching in files, like Kate's openUrl() (authored by sars).
S&R: Use canonical path while searching in files, like Kate's openUrl()
Feb 4 2019, 11:03 AM

Jan 29 2019

sars added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

Sorry, busy month... new project at work and got a new computer to configure....

Jan 29 2019, 5:33 PM

Jan 22 2019

sars added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

I think the selection if we save through the PNG 16bit/color or QImage version should be done in Skanlite.cpp not in savePng().

Jan 22 2019, 7:25 AM
sars accepted D18446: Add static version of toQImageSilent().

Please commit!

Jan 22 2019, 6:32 AM

Jan 16 2019

sars added a comment to T10317: Search&Replace plugin improvements.
Jan 16 2019, 9:45 AM · Kate

Jan 15 2019

sars added a comment to T10317: Search&Replace plugin improvements.
  1. Yes the "more option" button is a bit far away. At some point it actually was at the right of all the options. That is a real possibility
Jan 15 2019, 8:31 PM · Kate