- User Since
- Jun 3 2015, 8:56 AM (183 w, 6 d)
Sorry, I was a bit busy when this review came and then I forgot about it :(
Sun, Dec 9
Sat, Dec 8
Wouldn't it be better to make it possible to configure the current CppCheck in stead of adding a new one?
@zetazeta I'm not sure the highlighting length limit is worth an option as the editing of the document is not effected. I it is just a bit inconvenient that the highlighting disappears...
@dhaumann: You are right, the highlighting of the document still takes place and it is only KateRenderer that stops using the highlighting info for all lines longer than 1024 characters. All shorter lines are highlighted.
- Use a bit different config key to force a value reset for the limit.
- Fix reading the config value.
- Update the line-highlight disabled info message and position.
Fri, Dec 7
There is not much else we can do than just have a dummy like this, with the current state of the twain wrapper.
Sorry! This problem has totally passed me by before this... I'll have a look.
Thu, Dec 6
The highlighting limit is now returned in a function in KateRenderer as it is used also in katedocument.cpp for the warning/information message.
Add a message to inform about why the lines are not highlighted.
Add a note about disabled highlighting to the wrapped lines warning.
Increase the default line length limit to 100 000 characters per line.
Now I committed to master. Should I back-ported it to 18.12?
I guess there are no objections to commit this :)
OK, I have used this patch actively for a week now, and I have not noticed any regression... ;)
Remove unneeded temporary
Tue, Dec 4
I agree, we need to do something about the line length limit (that only wraps the lines at the limit when opening the file).
Mon, Dec 3
It is maybe not optimal to "hide" a bug fix among a bunch of code cosmetics, but the fix is good :)
Sun, Dec 2
What if you have Project, CTags and the new Zeal plugins active? You need to differentiate them somehow.
Let's take that one :)
I think the text could be "Cannot run command: %1\nWork path %2 does not exist."
I think this is a fix to the bug 347311
Sat, Dec 1
(Remove the unrelated change in src/view/kateview.cpp)
Also disable highlighting in selections for lines that are longe than 1024
Thu, Nov 29
Note: this is especially bad when the "on the fly spellchecking" is enabled as visibleRange() is used to "optimize" and only highlight what is currently visible. It is called multiple times.
Use EditingTransaction in stead of just disabling highlighting
If we get it working properly we could make the limit much higher. I tried with 30000 characters and it still worked very good. (except when selecting the line)
I tried it and it improves two things first the multiple replace is much faster and second you get the whole replace operation in one undo. I'll do an update when I have cleaned up the experiments a bit :)
Mon, Nov 12
Nov 11 2018
Nov 10 2018
The new connections are better because you get an error just for these problems. Explicitly failing is better than silently doing so on run-time.
Adding a function is not breaking backwards compatibility. You can still use Skanlite compiled against an older version with this new version.
Nov 9 2018
I'm a bit confused... I thought KDevelop had much more advanced plugins/features for this? What does KDevelop need this old plugin for? Non-C/C++ languages or what?
Nov 4 2018
I would like to give a -1 for removing the plugin I think that the feature is really something that has potential to be great!
Nov 3 2018
Hmm... File Browser works badly on Windows and Terminal Tool View not at all.
Sep 14 2018
If I understand the comments correct it assumes that if we use a libc that already has what we need, we don't need to use a separate library for it.
Sep 5 2018
Looks good to me...
Aug 30 2018
I was going to ask what the reason was for having a separate dialog, but your next review explains it.
Aug 25 2018
Aug 22 2018
I like it :) Please commit!
I like the direction!
Aug 15 2018
use fromTheme("foo", fromTheme("fall-back"));
Aug 14 2018
Aug 13 2018
Aug 12 2018
Sorry to hear that you are not interested any more :(
Aug 11 2018
OK, Cool :)
It would add a some code complexity, but I'm not sure it adds so much value that it would be worth it.... If you want the tree-mode for one file type, the probability is quite high that you want it for the other types too. I don̈́'t remember any bug report that would request that feature... Are you asking for it? ;)
Aug 10 2018
I was just about to commit this change when I noticed that:
Aug 7 2018
Adding a member-variable to avoid one getter cal is just adding complexity and saves you almost nothing.
But now I'm curious which part of my text was so persuasive.
Aug 6 2018
Except for the actionTriggered() function I'm ready to accept this patch.
Aug 5 2018
Otherwise I'm ready to commit.
I had missed this one....
I think it is ok to add these to the popup.