- User Since
- Jun 3 2015, 8:56 AM (242 w, 4 d)
Tue, Jan 21
Thu, Jan 16
Mon, Jan 13
Thank you both for the reviews :)
But I'm fine without the changes also :)
Thu, Jan 9
- Fix inch as display unit: 1 inch = 25.4 mm (it was not cm->inch)
Everything is big in America :)
Everything is big in America ;) (Legal should be 8.5 X 14 inch)
@antonarnold I'm not exactly sure what is wrong in those ;)
Wed, Jan 8
@antonarnold Good bug catch! All the scan sources I have here, have the same size so I did never reach that code path...
- Set the page size to "Custom" when the source size changes.
Fri, Jan 3
Ah OK :). The spinbox+slider is a reused widget that is used for all numeric properties in libksane :)
Thu, Jan 2
The sliders provide the size of the scanned area in numeric form and there is the possibility to fine-tune the scan area without having to bee too steady on the hand when doing the selection. So I do see a value in having the sliders in some form...
I'm not 100% happy with having the size sliders there directly after the color options.
Wed, Jan 1
Dec 27 2019
Dec 26 2019
Dec 17 2019
Dec 11 2019
Do you want to send a new version or should I Just remove the separator removal and use "... = QLocale::toFloat(tmp);" and commit in your name?
Dec 10 2019
Thanks for these fixes :)
Dec 7 2019
Yes it works :)
Dec 5 2019
I have been a bit reluctant to add the predefined page sizes, but maybe it is time to rethink it...
Dec 4 2019
I would agree that a UNIX/POSIX env var is not the most logical thing to use on Windows, but how do we ensure that we are in sync with ki18n? The usage of QLocale in ki18n looks like it is just adding extra languages to a list of languages, not actually using QLocale to determine what catalog to load. At least LANGUAGE overrides any QLocale settings. Should ki18n not be moved to using QLocale and setDefault()?
I was actually wondering why the F4 shortcut was put to Focus/Defocus Terminal and not to the "Show Terminal" action. The later action works the same as Dolphin (except that the focus to the terminal got broken at some point this fall or summer).
So the conclusion is that we are not using setDefault() yet and ki18n & gettext uses the LANGUAGE env so the logical thing, for now, is to also use LANGUAGE env here in KCoreAddons for the plugin metadata translations?
Dec 3 2019
Dec 1 2019
ki18n does not seem to use QLocale to get the language for translation, but uses LANGUAGE env. Also gettext uses the env variable.
Nov 29 2019
BTW should this also be done to to other options setting numbers?
Nov 28 2019
Nov 24 2019
Scratch that 19.12 comment, the 19.12 feature freeze was already the 14th... The bug fixes can go in as they are bug fixes ;) so no hurry.
That is absolutely fine!
Nov 17 2019
I hope I did not scare you off with my comments. These fixes are really welcome!
Oct 30 2019
Oct 29 2019
Isn't the change in setOptVals() the only change needed for fixing the scan option order problem?
Generally good changes :)
Oct 27 2019
Hmm yes, that order in which we restore the saved options could have a priority order. We could just check if the map contains scan source and execute that first. Then check for mode and resolution and then after that the rest.
Oct 25 2019
Thanks for your review request! :)
Jul 17 2019
Jul 15 2019
@ngraham Unfortunately there is no way with UI files to dynamically modify the layout depending on the size of the container, so munging the layout in C++ is the best way I know so far :)
Jul 10 2019
Sorry for the late review.
Jun 26 2019
Jun 24 2019
What if we put the search combo on one row and the search and next buttons on the next row together with the search places combo.
Then the next row would be the replace combo with the replace buttons and tool buttons on the next?
Jun 20 2019
Jun 18 2019
I think a partially highlighted line is better than a totally non-highlighted one. And I think that the user is more likely to instinctively guess correctly why the end of the line is not highlighted than if the line is not highlighted at all.
Jun 15 2019
I tried the patch and it improved the performance really much! :) I was able to edit a line that contained over a million characters!
May 13 2019
The change was submitted in the original pull request
Sorry for late answer...
May 6 2019
I guess there was some kind of arcanist mistake when this became a separate review request and not an update to D21024 (Rudimentary xml/html parser for symbolviewer plugin)
May 5 2019
Good addition :)
May 3 2019
This is not an issue on Windows (yet?) as the whole konsole plugin is disabled on Windows.
Apr 29 2019
That particular class is yours :)
My name does not need to be in there since I have not touched that file yet ;)
Apr 28 2019
I do not have strong opinion about the with of the line, it just hit me that it might become a bit narrow...
So to get nice icons on buttons we need to "setAttribute(Qt::AA_UseHighDpiPixmaps);", but that blurs the previews -> devicePixelRatioF() for preview images.
Please fix the copyright owner and date of the files before committing.
Apr 25 2019
Same ignorant question here as for libksane... Why do we need the HighDpiPixmaps in skanlite? The images get the dpi settings from the scanner setting...
Now I must show my ignorance... why do we need this devicePixelRatio in ksanevewer/selectionitem?
Apr 1 2019
Sorry, I thought i had answered, but I had forgotten to do it.
Mar 30 2019
Yes I also have a memory that there was a bug report about it, but I can't find it now....
Mar 29 2019
Mar 18 2019
Mar 14 2019
Mar 4 2019
This differential does three things
Mar 3 2019
Mar 2 2019
This is a good improvement idea for libksane. :)
Feb 20 2019
Feb 12 2019
The idea is sane :)
Can you also return false in setOptVal() in case the scanning is ongoing? (and the corresponding note in the doxygen comments)
Feb 11 2019
The idea is good. Could we have setOptVals() return -1 and setOptVal() false if the scanning is ongoing and the delayed setting of the value implemented in Skanlite?
OK this can go in.
Feb 10 2019
Just these minor adjustments and we are there.
Feb 6 2019
Feb 4 2019
Jan 29 2019
Sorry, busy month... new project at work and got a new computer to configure....
Jan 22 2019
I think the selection if we save through the PNG 16bit/color or QImage version should be done in Skanlite.cpp not in savePng().