sars (Kåre Särs)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 3 2015, 8:56 AM (277 w, 2 d)
Availability
Available

Recent Activity

May 25 2020

sars committed R40:d29db43e4e5a: [gdbplugin] Port QRegExp to QRegular Expression (authored by jbatrina).
[gdbplugin] Port QRegExp to QRegular Expression
May 25 2020, 12:51 PM
sars committed R40:1a5ab0fbe598: [gdbplugin] Added tooltips to localsview (authored by jbatrina).
[gdbplugin] Added tooltips to localsview
May 25 2020, 6:35 AM
sars committed R40:088a2fe71e82: BP: remove unneeded debug printout (authored by sars).
BP: remove unneeded debug printout
May 25 2020, 6:35 AM
sars committed R40:0ca2d40f2d48: Remove margins around the icons to make the logo more visible at < 48px (authored by sars).
Remove margins around the icons to make the logo more visible at < 48px
May 25 2020, 6:35 AM
sars committed R40:8255175ce760: BP: Fix CTags process starting: Enable index paths with spaces (authored by sars).
BP: Fix CTags process starting: Enable index paths with spaces
May 25 2020, 6:35 AM

May 15 2020

sars committed R40:ed360a907313: Remove margins around the icons to make the logo more visible at < 48px (authored by sars).
Remove margins around the icons to make the logo more visible at < 48px
May 15 2020, 10:22 AM

May 14 2020

sars committed R40:087bd9de916b: Add support for parsing column output from gcc and clang (authored by sars).
Add support for parsing column output from gcc and clang
May 14 2020, 5:41 PM
sars committed R40:ef15473fa77a: Add optional file search directory to the build plugin (authored by sars).
Add optional file search directory to the build plugin
May 14 2020, 5:41 PM

May 12 2020

sars accepted D29680: Fix modified line marker in kate minimap.

Thanks for the patch! I had not noticed the problem before :)

May 12 2020, 3:43 PM · Frameworks, Kate

May 11 2020

sars committed R40:6619b7003bde: Remove margins around the icons to make the logo visible on small sizes (authored by sars).
Remove margins around the icons to make the logo visible on small sizes
May 11 2020, 6:12 PM
sars committed R40:0a6bb0f9bf78: S&R: Add a context menu for copying search results (authored by sars).
S&R: Add a context menu for copying search results
May 11 2020, 4:33 PM
sars committed R40:2f4f7db7fcc0: S&R: Add possibility to copy of the visible search results (authored by sars).
S&R: Add possibility to copy of the visible search results
May 11 2020, 4:33 PM
sars committed R40:893bb799505e: Move KateSearchCommand to a separate file (authored by sars).
Move KateSearchCommand to a separate file
May 11 2020, 4:33 PM

May 8 2020

sars committed R40:94b5d277cb35: Merge branch 'Fix-starting-LSP-on-Windows' (authored by sars).
Merge branch 'Fix-starting-LSP-on-Windows'
May 8 2020, 12:44 PM
sars committed R40:2b2aea6c1ece: Properly port away from deprecated QProcess::start() (authored by sars).
Properly port away from deprecated QProcess::start()
May 8 2020, 10:32 AM
sars committed R40:2467f6181d92: Properly port away from deprecated QProcess::start() (authored by sars).
Properly port away from deprecated QProcess::start()
May 8 2020, 10:17 AM
sars committed R40:52c8285bc300: Replace QUrl::path() with toLocalPath() for proper paths for the server (authored by sars).
Replace QUrl::path() with toLocalPath() for proper paths for the server
May 8 2020, 9:48 AM

May 7 2020

sars committed R40:1e9aebf9544c: Build plugin: Do not open files that do not exist. (authored by sars).
Build plugin: Do not open files that do not exist.
May 7 2020, 5:36 AM

May 6 2020

sars committed R40:041e8c89e3aa: BP: Add caseFixed() function to fix path casing on Windows (authored by sars).
BP: Add caseFixed() function to fix path casing on Windows
May 6 2020, 7:35 PM
sars committed R40:69c962f208ce: Fix crash if search command is used while searching (authored by sars).
Fix crash if search command is used while searching
May 6 2020, 7:35 PM

May 5 2020

sars added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

I'm starting to think that we need an option for enabling/disabling this change/feature. I would not want to have the extra space between the lines, but at the same time I can see that actually not seeing the whole character is not an acceptable situation...

May 5 2020, 5:29 AM · Frameworks, Kate

May 4 2020

sars committed R483:21e47d0859b2: Add Ctrl-Q for quitting Skanlite and update copyright statement (authored by sars).
Add Ctrl-Q for quitting Skanlite and update copyright statement
May 4 2020, 5:25 PM
sars committed R382:9c4d8e926861: Assign shortcut keys to Preview and Scan (authored by fakefred).
Assign shortcut keys to Preview and Scan
May 4 2020, 5:16 PM
sars closed D29400: Assign shortcut keys to Preview and Scan.
May 4 2020, 5:16 PM
sars accepted D29400: Assign shortcut keys to Preview and Scan.

I would like to use "this" as parent for the QShortcuts in stead of the parent of KSaneWidget that actually might be nullptr.

May 4 2020, 10:00 AM

May 3 2020

sars added a comment to D28717: Reassign Alt+S to Scan.

It seems it could be quite hard to get this to work with only the QPushButton, so your idea with a separate QShortcut is a good workaround.

May 3 2020, 7:46 PM
sars added a comment to D28717: Reassign Alt+S to Scan.

This seems to be the reason...
https://mail.kde.org/pipermail/plasma-devel/2016-May/052732.html

May 3 2020, 7:37 PM
sars committed R382:6de2958aa669: Re-enable canceling of ADF, or multi selection scans with scanCancel() (authored by sars).
Re-enable canceling of ADF, or multi selection scans with scanCancel()
May 3 2020, 7:34 PM
sars committed R483:bd0dcceba6e2: Add progress-bar with kB saved + disable the KSaneWidget while saving. (authored by sars).
Add progress-bar with kB saved + disable the KSaneWidget while saving.
May 3 2020, 6:55 PM
sars committed R483:e3594cbce387: If the save-folder does not exist open the SaveLocation dialog (authored by sars).
If the save-folder does not exist open the SaveLocation dialog
May 3 2020, 6:55 PM
sars committed R483:823abcd26e0d: Fix saving remote save folder (authored by sars).
Fix saving remote save folder
May 3 2020, 9:39 AM
sars added a comment to D28672: Remove unnecessary overwrite prompt.

@ltoscano Yes sure, I have not made a release in over two years :( so waiting a bit more should not be a problem ;)

May 3 2020, 9:09 AM

May 2 2020

sars committed R40:54b730ac6c28: Fix crash if search command is used while searching (authored by sars).
Fix crash if search command is used while searching
May 2 2020, 6:28 AM
sars committed R40:d755cb65f146: Allow pgrep command to work as grep if no project is loaded (authored by sars).
Allow pgrep command to work as grep if no project is loaded
May 2 2020, 5:56 AM
sars added a comment to D28672: Remove unnecessary overwrite prompt.

Also @sars, I notice that Skanlite hasn't gotten a release in a while. I wonder if it would be beneficial to move it to the release service so that it can share the same release schedule as most KDE apps and automatically get three major releases per year, with three minor releases per major one. What do you think?

May 2 2020, 5:39 AM

Apr 27 2020

sars added a comment to D28717: Reassign Alt+S to Scan.

That should work, but I can confirm that it does not work in libksane at the moment.

Apr 27 2020, 6:01 AM
sars accepted D28672: Remove unnecessary overwrite prompt.
Apr 27 2020, 5:13 AM

Apr 26 2020

sars added a comment to D28717: Reassign Alt+S to Scan.

Yes please add that to libksane :)

Apr 26 2020, 12:09 PM
sars accepted D28672: Remove unnecessary overwrite prompt.

Sorry for the faaaar to late response...

Apr 26 2020, 11:57 AM

Apr 13 2020

sars added a comment to D28717: Reassign Alt+S to Scan.

I would like to eventually have the "ctrl-..." along sides the auto generated shortcuts. This is basically a workaround to gett a shortcut (hopefully "Alt-s") for the scan button in stead of no shortcut at the moment.

Apr 13 2020, 8:56 AM

Apr 12 2020

sars added a comment to D28717: Reassign Alt+S to Scan.

I'm not a big fan of the assigning of shortcuts with &, because it becomes a big hassle to keep track of what has been set where and translations makes things even more complicated...

Apr 12 2020, 9:23 AM

Mar 1 2020

sars added a comment to T12744: Consider increasing the default fixed width font size by 1 (9 -> 10).

Both Konsole and Kate, take the default font from the global fixed with font settings. Once you change the setting in the application, it no-longer follows the global setting. I have also noticed that the default font settings seem to be a bit distro specific.

Mar 1 2020, 7:46 PM · Konsole, Kate, VDG

Feb 19 2020

sars accepted D27410: Port away from deprecated API.
Feb 19 2020, 9:39 AM
sars accepted D27409: Port away from deprecated API.
Feb 19 2020, 9:39 AM

Feb 16 2020

sars committed R40:4f1a80ba82a7: Add option to showModOnDiskPrompt() to ignore include non edited. (authored by sars).
Add option to showModOnDiskPrompt() to ignore include non edited.
Feb 16 2020, 6:25 PM

Feb 14 2020

sars committed R40:2e3774ad7008: Add option to showModOnDiskPrompt() to ignore include non edited. (authored by sars).
Add option to showModOnDiskPrompt() to ignore include non edited.
Feb 14 2020, 4:00 AM

Feb 2 2020

sars committed R40:45ff8c289bba: Fix usage of QtSingleApplication on Windows and Apple (authored by sars).
Fix usage of QtSingleApplication on Windows and Apple
Feb 2 2020, 8:32 AM

Jan 21 2020

sars committed R40:8991d6186425: build plugin: Fix detecting current make directory (authored by sars).
build plugin: Fix detecting current make directory
Jan 21 2020, 6:57 PM

Jan 16 2020

sars committed R382:bdabe32a36cd: Try to fix compilation on FreeBSD (authored by sars).
Try to fix compilation on FreeBSD
Jan 16 2020, 8:45 PM

Jan 13 2020

sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

Thank you both for the reviews :)

Jan 13 2020, 6:47 PM
sars committed R382:7f983585f062: Add scan-area sliders and predefined page sizes combobox (authored by sars).
Add scan-area sliders and predefined page sizes combobox
Jan 13 2020, 6:44 PM
sars closed D26351: Add scan-area sliders and predefined page sizes combobox.
Jan 13 2020, 6:44 PM
sars added a comment to D26620: Do not assume that list of documents is non-empty.

But I'm fine without the changes also :)

Jan 13 2020, 11:14 AM · Kate
sars accepted D26620: Do not assume that list of documents is non-empty.
Jan 13 2020, 11:13 AM · Kate

Jan 9 2020

sars updated the diff for D26351: Add scan-area sliders and predefined page sizes combobox.
  • Fix inch as display unit: 1 inch = 25.4 mm (it was not cm->inch)
Jan 9 2020, 4:13 PM
sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

Everything is big in America :)

Jan 9 2020, 10:29 AM
sars added a comment to F7872152: LOCALE-en_US.png.

Everything is big in America ;) (Legal should be 8.5 X 14 inch)

Jan 9 2020, 10:27 AM
sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

@antonarnold I'm not exactly sure what is wrong in those ;)

Jan 9 2020, 7:49 AM

Jan 8 2020

sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

@antonarnold Good bug catch! All the scan sources I have here, have the same size so I did never reach that code path...

Jan 8 2020, 6:07 PM
sars updated the diff for D26351: Add scan-area sliders and predefined page sizes combobox.
  • Set the page size to "Custom" when the source size changes.
Jan 8 2020, 5:57 PM

Jan 3 2020

sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

Ah OK :). The spinbox+slider is a reused widget that is used for all numeric properties in libksane :)

Jan 3 2020, 7:24 AM

Jan 2 2020

sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

The sliders provide the size of the scanned area in numeric form and there is the possibility to fine-tune the scan area without having to be too steady on the hand when doing the selection. So I do see a value in having the sliders in some form...

Jan 2 2020, 7:34 PM
sars added a comment to D26351: Add scan-area sliders and predefined page sizes combobox.

I'm not 100% happy with having the size sliders there directly after the color options.

Jan 2 2020, 7:18 PM
sars updated the test plan for D26351: Add scan-area sliders and predefined page sizes combobox.
Jan 2 2020, 7:07 PM

Jan 1 2020

sars requested review of D26351: Add scan-area sliders and predefined page sizes combobox.
Jan 1 2020, 7:08 PM

Dec 27 2019

sars committed R39:92e5b0b9aac0: Avoid unwanted horizontal scrolling (authored by sars).
Avoid unwanted horizontal scrolling
Dec 27 2019, 10:25 AM
sars closed D26071: Avoid unwanted horizontal scrolling.
Dec 27 2019, 10:25 AM · Frameworks, Kate

Dec 26 2019

sars added reviewers for D26071: Avoid unwanted horizontal scrolling: Kate, dhaumann, cullmann.
Dec 26 2019, 10:08 AM · Frameworks, Kate

Dec 17 2019

sars requested review of D26071: Avoid unwanted horizontal scrolling.
Dec 17 2019, 5:06 PM · Frameworks, Kate

Dec 11 2019

sars committed R382:3130174cae4e: Fix color-options layout & KSaneOptCombo::setValue() (authored by antonarnold).
Fix color-options layout & KSaneOptCombo::setValue()
Dec 11 2019, 9:46 PM
sars committed R382:992fd7c77d75: Fix color-options layout & KSaneOptCombo::setValue() (authored by antonarnold).
Fix color-options layout & KSaneOptCombo::setValue()
Dec 11 2019, 9:45 PM
sars closed D25588: Fix color-options layout & KSaneOptCombo::setValue().
Dec 11 2019, 9:45 PM
sars added a comment to D25588: Fix color-options layout & KSaneOptCombo::setValue().

Do you want to send a new version or should I Just remove the separator removal and use "... = QLocale::toFloat(tmp);" and commit in your name?

Dec 11 2019, 8:39 PM

Dec 10 2019

sars accepted D25052: Optimize support of scanners with different image sources or duplex unit.

Thanks for these fixes :)

Dec 10 2019, 10:04 AM

Dec 7 2019

sars added a comment to D25599: Fix plugin-metadata translations on windows.

Yes it works :)

Dec 7 2019, 8:55 AM · Frameworks, Windows

Dec 5 2019

sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

I have been a bit reluctant to add the predefined page sizes, but maybe it is time to rethink it...

Dec 5 2019, 8:09 PM

Dec 4 2019

sars added a comment to D25599: Fix plugin-metadata translations on windows.

I would agree that a UNIX/POSIX env var is not the most logical thing to use on Windows, but how do we ensure that we are in sync with ki18n? The usage of QLocale in ki18n looks like it is just adding extra languages to a list of languages, not actually using QLocale to determine what catalog to load. At least LANGUAGE overrides any QLocale settings. Should ki18n not be moved to using QLocale and setDefault()?

Dec 4 2019, 12:45 PM · Frameworks, Windows
sars added a comment to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.

I was actually wondering why the F4 shortcut was put to Focus/Defocus Terminal and not to the "Show Terminal" action. The later action works the same as Dolphin (except that the focus to the terminal got broken at some point this fall or summer).

Dec 4 2019, 12:26 PM · Goal: Consistency, Dolphin, Kate
sars added a comment to D25599: Fix plugin-metadata translations on windows.

So the conclusion is that we are not using setDefault() yet and ki18n & gettext uses the LANGUAGE env so the logical thing, for now, is to also use LANGUAGE env here in KCoreAddons for the plugin metadata translations?

Dec 4 2019, 8:24 AM · Frameworks, Windows

Dec 3 2019

sars added inline comments to D25052: Optimize support of scanners with different image sources or duplex unit.
Dec 3 2019, 6:35 PM

Dec 1 2019

sars added a comment to D25599: Fix plugin-metadata translations on windows.

ki18n does not seem to use QLocale to get the language for translation, but uses LANGUAGE env. Also gettext uses the env variable.

Dec 1 2019, 7:19 PM · Frameworks, Windows
sars added reviewers for D25599: Fix plugin-metadata translations on windows: aacid, vonreth.
Dec 1 2019, 7:44 AM · Frameworks, Windows

Nov 29 2019

sars added a comment to D25588: Fix color-options layout & KSaneOptCombo::setValue().

BTW should this also be done to to other options setting numbers?

Nov 29 2019, 11:02 AM
sars accepted D25588: Fix color-options layout & KSaneOptCombo::setValue().
Nov 29 2019, 11:00 AM
sars updated the summary of D25588: Fix color-options layout & KSaneOptCombo::setValue().
Nov 29 2019, 11:00 AM

Nov 28 2019

sars requested review of D25599: Fix plugin-metadata translations on windows.
Nov 28 2019, 5:36 PM · Frameworks, Windows

Nov 24 2019

sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

Scratch that 19.12 comment, the 19.12 feature freeze was already the 14th... The bug fixes can go in as they are bug fixes ;) so no hurry.

Nov 24 2019, 4:59 PM
sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

That is absolutely fine!

Nov 24 2019, 4:56 PM

Nov 17 2019

sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

I hope I did not scare you off with my comments. These fixes are really welcome!

Nov 17 2019, 9:25 AM

Oct 30 2019

sars added inline comments to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.
Oct 30 2019, 9:24 PM

Oct 29 2019

sars added a comment to D25052: Optimize support of scanners with different image sources or duplex unit.

Isn't the change in setOptVals() the only change needed for fixing the scan option order problem?

Oct 29 2019, 7:14 PM
sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

Generally good changes :)

Oct 29 2019, 6:28 PM

Oct 27 2019

sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

Hmm yes, that order in which we restore the saved options could have a priority order. We could just check if the map contains scan source and execute that first. Then check for mode and resolution and then after that the rest.

Oct 27 2019, 5:08 PM

Oct 25 2019

sars added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

Thanks for your review request! :)

Oct 25 2019, 8:00 PM

Jul 17 2019

sars committed R39:2d941799251c: Minimap: Do not grab the left-mmouse-button-click on up/down buttons (authored by sars).
Minimap: Do not grab the left-mmouse-button-click on up/down buttons
Jul 17 2019, 4:40 PM
sars closed D22511: Minimap: Do not grab left mouse click over up/down arrows.
Jul 17 2019, 4:40 PM · Frameworks, Kate
sars requested review of D22511: Minimap: Do not grab left mouse click over up/down arrows.
Jul 17 2019, 3:12 PM · Frameworks, Kate

Jul 15 2019

sars accepted D22059: Enlarge the find and replace add-on combo boxes.

@ngraham Unfortunately there is no way with UI files to dynamically modify the layout depending on the size of the container, so munging the layout in C++ is the best way I know so far :)

Jul 15 2019, 7:54 AM · VDG, Kate

Jul 10 2019

sars added a comment to D22059: Enlarge the find and replace add-on combo boxes.

Sorry for the late review.

Jul 10 2019, 8:55 PM · VDG, Kate

Jun 26 2019

sars added a comment to R40:bfdd0006d19f: S&R: Only add maximum 70 characters context before & after match..

Imagine you have a "minimized" javascript or XML file. You basically have the whole file on one line. This can be thousands of characters on a line. If you now search for a fairly common word in the minimized code, you would duplicate the huge line as many times as you get matches.

Jun 26 2019, 9:21 AM