Open/close and focus/defocus terminal using the same shortcuts as Dolphin

Authored by ngraham on Dec 7 2019, 10:38 PM.



Users have complained that Kate's terminal doesn't use the same shortcut as Dolphin to
open and close. This patch makes it do so, using the same shortcuts that dolphin uses
to both open/close and also focus/de-focus:

F4: Open/close
Ctrl+Shift+F4: Focus/de-focus (also open if currently closed)

BUG: 414587
FIXED-IN: 20.04.0
Closes T12318

Test Plan

Hit F4 twice -> terminal opens and closes
Hit Ctrl+Shift+F4 twice -> terminal focuses and de-focuses

Diff Detail

R40 Kate
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Dec 7 2019, 10:38 PM
Restricted Application added a project: Kate. · View Herald TranscriptDec 7 2019, 10:38 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 7 2019, 10:38 PM
ngraham edited the summary of this revision. (Show Details)Dec 7 2019, 10:38 PM
cullmann accepted this revision.Dec 8 2019, 2:50 PM
cullmann added a subscriber: cullmann.

Seems to be a reasonable idea for me.

This revision is now accepted and ready to land.Dec 8 2019, 2:50 PM
This revision was automatically updated to reflect the committed changes.

Doesn't this patch imply we have the same action twice now? Once provided by Konsole, and once by katemdi via View > Tool Views > Show Terminal?

The generic stuff will still be there, yes.
But I don't think this hurts

Note: This will also create yet another conflict with KDevelop's (relatively important) "Jump to Next Outputmark" feature.

CC'ing KDevelop mailing list.

PS: I won't have time to look at this issue myself.

kfunk added a comment.Dec 9 2019, 9:18 AM

Ah, sorry, never mind.

This plugin isn't normally loaded in KDevelop, so it should not be an issue... D'oh.