- User Since
- Aug 15 2018, 7:18 AM (57 w, 4 d)
Fri, Sep 20
Address David's comment, remove one entry from the map
Thu, Sep 19
Wed, Sep 18
Tue, Sep 17
Mon, Sep 16
So the SDDM patch has been merged, but I don't know when the next SDDM release will be. I would keep this on hold until this happens, just to be safe... does that make sense?
What I'm seeing in the screenshot is that the two form layouts aren't aligned. Can you interlink them with twinFormLayouts?
In general I would also like to see this happen, but it would be nice to preserve theming capabilities or at least making QML styles easier.
Yo @cblack I think you can land this.
+1 for redesigning the page a bit. What I really dislike about it right now is that there is no hover effect for the icons.
Wed, Sep 11
Tue, Sep 10
Mon, Sep 9
Tried it out, I like the way it looks.
Yikes, we need to fix that.
Thu, Sep 5
Phab hasn't picked up on the commit: https://cgit.kde.org/kirigami.git/commit/?id=9af92cc8b750b59629eeb3446108b2f8086629f7
Wed, Sep 4
I would also think a bit more about using Kirigami.SearchField -> it's not used in Kickoff and it's not properly themable (the same way PlasmaComponents.TextField is).
What I'm seeing is that this could result in poor visibility of action buttons.
Tue, Sep 3
This is pretty great, the old version was buggy. One question: can we enforce a minimum width on the whole window?
Mon, Sep 2
Sun, Sep 1
+1, looks good, thanks for centering the clapper as well
Sat, Aug 31
- remove "in the root directory"
Fri, Aug 30
Rebase on master
Rebase on master
Rebase on master (hopefully)
Sun, Aug 25
I was okay with the degradation as well, but if users are saying they want to have the same value as in other DEs/OSs, health seems like a good compromise. It's commonly used to describe the state of SSDs I think so it should be familiar to people.
FWIW I didn't know what "smart" or "zero-cornered" actually meant before seeing this patch. These new strings seem more user-friendly to me.
Aug 23 2019
add qDebug info in auth helper
also apply the check for the auth helper
D23274 makes this unnecessary.
I forgot I was using the La Capitaine icon theme so the above doesn't apply in the sense of now working well with defaults. Seems OK with Breeze.
Tested on 5.16 so disregard the other changes:
Aug 22 2019
Aug 21 2019
Can you add some before & after screenshots (or vids) for VDG ?
Aug 20 2019
I don't know if there would be some use in keeping sessionsModel.canStartNewSession && sessionsModel.canSwitchUser around, but the button should always be visible (when technically possible I guess).
What if someone else is logged in, they locked their screen and I want to switch the session?
LGTM in use. The only thing I'd ask you to do is add font.pointSize: config.fontSize to both of the QQC2.Labels you were working on. SDDM defaults to 9pt font sizes; we need to override that so it's 10pt (same as the Plasma default).
+1, same reasoning as in D23270#514978.
Both changes make sense to me.
Aug 19 2019
Aug 18 2019
Aug 12 2019
I believe I've just recently had some noticeable image quality loss after doing a save in Gwenview; the fact that it would happen was unbeknownst to me.
Aug 10 2019
Aug 9 2019
Aug 7 2019
also show debug output if scaling DPI is not found
Aug 2 2019
If it would be draining to do now, we can leave that menu at QQC1 and add a note pointing to a bug report?
Aug 1 2019
I check up on Full Design to track precise wear, and the Capacity is also pretty standard info and useful.
I think what Capacity means is how worn out your battery has become. Yours can still take the full charge so it's at 100% (jealous).
use 2px instead of 1px of padding
2px looks better to me as well, let's add 1px more to the margin in Discover then?
@ngraham I forgot about RTL, my bad.
watch out for RTL
Looks OK, along with these two inline comments I'd also add some reasoning for the change to the commit message.
The effect doesn't always work for me.
+1 regarding the Cursor Theme and Plasma Theme, but it doesn't make sense to me that Splash Screen will be in Appearance, while Login Screen (SDDM) will be in Startup and Shutdown.