filipf (Filip Fila)
Design

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 15 2018, 7:18 AM (74 w, 5 d)
Availability
Available

Recent Activity

Sat, Jan 18

filipf requested changes to D26739: [applets/Task Manager] Refine tooltip highlight effect.

I think what Noah means is that the media controls row should perfectly touch the left, right and bottom border. The margins in this patch are too big so they effectively create another frame in a frame.

Sat, Jan 18, 11:08 AM · Plasma
filipf added a comment to D26739: [applets/Task Manager] Refine tooltip highlight effect.

Not a fan of the inner frame. We should avoid making frames within frames. I don't think it really needs changing, except that the sides cover the blue border frame.

Sat, Jan 18, 3:08 AM · Plasma

Fri, Jan 17

filipf added a comment to D18006: Include only the largest size for the "Next" wallpaper.

The whole point was to save some space on the user's machine. However trading space savings for load time maybe isn't the best trade-off? 18 MB isn't really all that much of a savings.

Should we shelve this idea?

Fri, Jan 17, 10:15 AM · Plasma

Mon, Jan 13

filipf updated the summary of D26646: [Applet Configuration] Work around bad kerning in sidebar labels.
Mon, Jan 13, 11:59 PM · Plasma
filipf updated the diff for D26646: [Applet Configuration] Work around bad kerning in sidebar labels.
  • make it work with multi line strings
  • restore side margins
Mon, Jan 13, 11:48 PM · Plasma
filipf added a comment to D26646: [Applet Configuration] Work around bad kerning in sidebar labels.

Oops, looks like it breaks those smallSpacing margins as well:

Mon, Jan 13, 11:45 PM · Plasma
filipf added reviewers for D26646: [Applet Configuration] Work around bad kerning in sidebar labels: Plasma, ngraham.
Mon, Jan 13, 11:37 PM · Plasma
filipf requested review of D26646: [Applet Configuration] Work around bad kerning in sidebar labels.
Mon, Jan 13, 11:36 PM · Plasma
filipf updated the diff for D26636: [Widget Explorer] Work around bad kerning.

don't repeat the same code twice

Mon, Jan 13, 9:21 PM · Plasma
filipf updated the diff for D26636: [Widget Explorer] Work around bad kerning.

remove added whitespace

Mon, Jan 13, 9:21 PM · Plasma
filipf added reviewers for D26636: [Widget Explorer] Work around bad kerning: Plasma, ngraham.
Mon, Jan 13, 6:17 PM · Plasma
filipf requested review of D26636: [Widget Explorer] Work around bad kerning.
Mon, Jan 13, 6:17 PM · Plasma

Wed, Jan 8

filipf added a comment to D26531: [Wallpaper] Show author as subtitle in configuration.

Good idea +1. I think an author's name is enough here since information is displayed in a similar way that songs info is ie. it should be obvious to everyone the second line lists the author.

Wed, Jan 8, 10:41 PM · Plasma

Sat, Jan 4

alexde awarded T10470: Improve the visuals of tray popups a Love token.
Sat, Jan 4, 12:36 PM · VDG

Thu, Jan 2

filipf committed R112:33f31fb79ff2: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes (authored by filipf).
[ResultDelegate] Fix bad text legiblity with certain 3rd party themes
Thu, Jan 2, 11:21 AM
filipf closed D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes.
Thu, Jan 2, 11:21 AM · Plasma

Mon, Dec 30

filipf added inline comments to D26271: [Applet]Update layout based on T10470.
Mon, Dec 30, 10:16 PM · Plasma

Wed, Dec 25

filipf renamed T12420: Things that could be redesigned or tweaked from Things that could to redesign or tweaks to Things that could be redesigned or tweaked.
Wed, Dec 25, 6:31 PM · VDG

Mon, Dec 23

filipf updated the test plan for D25584: [TabBar] Remove frame.
Mon, Dec 23, 9:44 AM · Plasma
filipf updated the diff for D25584: [TabBar] Remove frame.

clean up

Mon, Dec 23, 9:42 AM · Plasma
filipf updated the diff for D25584: [TabBar] Remove frame.

remove tabbar frame

Mon, Dec 23, 9:42 AM · Plasma
filipf added a comment to D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes.

@broulik?

Mon, Dec 23, 9:39 AM · Plasma
filipf abandoned D25973: Make the theme info QuickWidget transparent.

Going to have to be a no from me since the lack of font anti-aliasing looks pretty bad with darker color schemes. Not sure if it's worth it to report the bug to Qt.

Mon, Dec 23, 9:38 AM · Plasma

Sat, Dec 21

filipf added a comment to D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar.
In D21978#581032, @GB_2 wrote:

Can you please try to further investigate this?

Sat, Dec 21, 4:58 PM · Plasma

Dec 20 2019

KonqiDragon awarded T10470: Improve the visuals of tray popups a Love token.
Dec 20 2019, 9:06 PM · VDG

Dec 15 2019

filipf committed R119:bfdd9c9b03b5: [KCMs/Color] Remove unused import (authored by filipf).
[KCMs/Color] Remove unused import
Dec 15 2019, 9:16 PM
filipf committed R119:3245c6bc9b77: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the… (authored by filipf).
[Plasma Style KCM] Add a color-wheel sign denoting the theme supports the…
Dec 15 2019, 9:12 PM
filipf closed D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme.
Dec 15 2019, 9:12 PM · Plasma

Dec 14 2019

filipf added a comment to D25584: [TabBar] Remove frame.

Ping, anyone know if we can just delete this Rectangle I called "frame"?

Dec 14 2019, 9:56 PM · Plasma
filipf abandoned D23876: [applets/kickoff] Tweak padding for lists.

Don't want to go through with this anymore because I've had a look at other views and they always sharply cut off content vertically. For example:

Dec 14 2019, 9:54 PM · Plasma
filipf committed R123:0a4cd168545e: Merge branch 'Plasma/5.17' (authored by filipf).
Merge branch 'Plasma/5.17'
Dec 14 2019, 9:50 PM
filipf committed R123:7e13183d044b: Use text color for "No preview image" text (authored by filipf).
Use text color for "No preview image" text
Dec 14 2019, 9:48 PM
filipf closed D25971: Use text color for "No preview image" text.
Dec 14 2019, 9:48 PM · Plasma
filipf updated the test plan for D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme.
Dec 14 2019, 6:17 PM · Plasma
filipf updated the diff for D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme.
  • Use grid delegate subtitle to state "Follows color scheme"
  • Consequently remove the icon tooltip that said the same
Dec 14 2019, 6:16 PM · Plasma
filipf added a comment to D25999: Add optional subtitle to grid delegate.

^ No, it seems to be GridDelegate actually.

Dec 14 2019, 6:09 PM · Frameworks
filipf added a comment to D25999: Add optional subtitle to grid delegate.

It does, because we can't know in advance whether or not any delegates will set a subtitle. Actually... can we know this?

Dec 14 2019, 6:08 PM · Frameworks
filipf added a comment to D25999: Add optional subtitle to grid delegate.

Thanks, I'll tweak my patch to use this.

Dec 14 2019, 5:52 PM · Frameworks
filipf added a dependency for D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme: D25999: Add optional subtitle to grid delegate.
Dec 14 2019, 5:50 PM · Plasma
filipf added a dependent revision for D25999: Add optional subtitle to grid delegate: D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme.
Dec 14 2019, 5:50 PM · Frameworks
filipf added a comment to D25973: Make the theme info QuickWidget transparent.

There might be an unfortunate side effect: https://forum.qt.io/topic/57634/qt-wa_alwaysstackontop-influences-font-rendering-in-qml/5

Dec 14 2019, 8:06 AM · Plasma

Dec 13 2019

filipf updated the diff for D25973: Make the theme info QuickWidget transparent.
  • downgrade Rectangle to Item since we don't need anything fancy anymore (good tip @ngraham)
Dec 13 2019, 11:18 PM · Plasma
filipf updated the diff for D25973: Make the theme info QuickWidget transparent.
  • remove old hack comment
Dec 13 2019, 10:54 PM · Plasma
filipf added reviewers for D25973: Make the theme info QuickWidget transparent: Plasma, davidedmundson.
Dec 13 2019, 10:53 PM · Plasma
filipf requested review of D25973: Make the theme info QuickWidget transparent.
Dec 13 2019, 10:52 PM · Plasma
filipf retitled D25971: Use text color for "No preview image" text from Use text color for "No preview image text" to Use text color for "No preview image" text.
Dec 13 2019, 10:20 PM · Plasma
filipf added reviewers for D25971: Use text color for "No preview image" text: Plasma, VDG.
Dec 13 2019, 10:19 PM · Plasma
filipf requested review of D25971: Use text color for "No preview image" text.
Dec 13 2019, 10:18 PM · Plasma
filipf accepted D25920: [KCMs/Night Color] Make activation criteria and times more obvious.

Looks good. I just realized that maybe the message at the top could be an info inline message, but I see how that could be too much.

Dec 13 2019, 7:34 PM · Plasma
filipf accepted D25927: [PC3] Complete plasma progress bar animation.
Dec 13 2019, 11:26 AM · Frameworks
filipf accepted D25926: [PC3] Only show progress bar indicator when the ends won't overlap.
Dec 13 2019, 11:23 AM · Frameworks
filipf added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

This fixed the button label, but the menu itself is unsuable due to a black text on dark background: https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21

Dec 13 2019, 9:58 AM · Frameworks
filipf added a reverting change for R120:5c8ce892e394: [sddm-theme] Start moving from QQC1 to QQC2: R120:86570a22dfc7: Revert "[sddm-theme] Start moving from QQC1 to QQC2".
Dec 13 2019, 9:52 AM
filipf committed R120:86570a22dfc7: Revert "[sddm-theme] Start moving from QQC1 to QQC2" (authored by filipf).
Revert "[sddm-theme] Start moving from QQC1 to QQC2"
Dec 13 2019, 9:52 AM
filipf added a reverting change for R120:d46b0186655c: Revert "Revert "[sddm-theme] Fix initial focus after SDDM QQC2 Port"": R120:3b8c0f0ababd: Revert "Revert "Revert "[sddm-theme] Fix initial focus after SDDM QQC2 Port""".
Dec 13 2019, 9:42 AM
filipf committed R120:3b8c0f0ababd: Revert "Revert "Revert "[sddm-theme] Fix initial focus after SDDM QQC2 Port""" (authored by filipf).
Revert "Revert "Revert "[sddm-theme] Fix initial focus after SDDM QQC2 Port"""
Dec 13 2019, 9:42 AM

Dec 11 2019

filipf added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

Let's track the arrow issue in: https://bugs.kde.org/show_bug.cgi?id=415049

Dec 11 2019, 12:56 PM · Frameworks
filipf committed R242:e4e1613b0fe7: [PC3 ToolButton] Have the label take into account complementary color schemes (authored by filipf).
[PC3 ToolButton] Have the label take into account complementary color schemes
Dec 11 2019, 12:50 PM
filipf closed D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.
Dec 11 2019, 12:50 PM · Frameworks
filipf updated the test plan for D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.
Dec 11 2019, 12:48 PM · Frameworks
filipf added a comment to T10611: Set options for GTK apps in the respective KCMs.

Still works for Adwaita:

Dec 11 2019, 9:25 AM · Plasma: KCM Redesign

Dec 9 2019

filipf added a comment to D25814: [KColorScheme] Add SeparatorColor.

FWIW, Adwaita Dark uses dark separators, but GNOME doesn't use nearly as many icons as we do.

To me, this image really shows how good the dark separators look. I don't think the fact that our UIs are more icon-heavy is a significant factor here. Unlike GNOME, we tend to use ToolButtons, which have no outline until hovered over. So in fact there are probably fewer lines with the separator color in our Toolbutton-heavy UIs compared to GNOME.

Dec 9 2019, 10:15 PM · Frameworks
filipf accepted D25822: Add manual test for changing colorscope in components.

Thanks again :)

Dec 9 2019, 8:34 PM · Frameworks
filipf added a comment to D25822: Add manual test for changing colorscope in components.

Nice. Does this fix or obsolete D25699?

Dec 9 2019, 7:50 PM · Frameworks
filipf added a comment to D25822: Add manual test for changing colorscope in components.

Thanks! It will be easier to test now.

Dec 9 2019, 7:49 PM · Frameworks
filipf updated subscribers of D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

Yeah, PC2 ToolButton has this so it loads the arrow: https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ToolButtonStyle.qml#L110

Dec 9 2019, 1:06 PM · Frameworks
filipf added a comment to D25820: SimpleScreenRecorder icon added.

I agree, I think brighter and slightly less saturated colors would look nice.

Dec 9 2019, 4:37 AM · Frameworks, Breeze
filipf added a comment to D25814: [KColorScheme] Add SeparatorColor.

I think this is useful. Every once in a while we get opinionated people who think light separators are awful in the Breeze Dark scheme (I would hate dark ones on the other hand) or even some ricer people who want to turn off separators (which they could do now by matching it with window color I guess).

Dec 9 2019, 4:34 AM · Frameworks
filipf awarded D25814: [KColorScheme] Add SeparatorColor a The World Burns token.
Dec 9 2019, 4:26 AM · Frameworks

Dec 8 2019

filipf added a comment to T12029: Plasma 5.18 Contest for wallpapers, promotional video, UI mockups, etc .

This is the wallpaper in question:

Dec 8 2019, 7:51 PM · KDE Promo

Dec 7 2019

filipf added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

The check for the prefix was added in bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc, while the control.flat one got added much earlier.

The labels are visible again with just the control.flat condition, but the prefix one might be needed as well for non-breeze themes.

There's a part missing though, the triangle (visible on https://openqa.opensuse.org/tests/1105226#step/start_wayland_plasma5/21) is gone. That seems to be a feature lost with PC3 :-(

Dec 7 2019, 10:33 PM · Frameworks
filipf updated the summary of D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.
Dec 7 2019, 9:49 PM · Frameworks

Dec 6 2019

filipf added a comment to D25340: Added background colors to active and inactive icon view.

This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which isn't in git master. Do I actually need that commit for this patch to work?

Dec 6 2019, 8:53 PM · Frameworks
filipf added a comment to D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme.

Yeah, that might not be a bad idea. Our GridDelegates do not support more than 1 line of text right now if I'm not mistaken though.

Dec 6 2019, 7:02 PM · Plasma
filipf added reviewers for D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme: Plasma, VDG.
Dec 6 2019, 3:13 PM · Plasma
filipf requested review of D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme.
Dec 6 2019, 3:13 PM · Plasma
filipf added inline comments to D25778: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2.
Dec 6 2019, 10:44 AM · Plasma

Dec 5 2019

filipf accepted D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default.

+1 from me as well for the reasons listed in the commit message

Dec 5 2019, 7:48 PM · Plasma
filipf committed R124:3095645414d9: Merge branch 'Plasma/5.17' (authored by filipf).
Merge branch 'Plasma/5.17'
Dec 5 2019, 5:04 PM
filipf committed R124:64fb5eb98eb8: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs (authored by filipf).
[Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs
Dec 5 2019, 5:04 PM
filipf closed D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.
Dec 5 2019, 5:04 PM · Plasma
filipf committed R119:7c11cb4685be: [Kickoff] Fix default avatar offset (authored by filipf).
[Kickoff] Fix default avatar offset
Dec 5 2019, 11:05 AM

Dec 4 2019

filipf added a comment to D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.

But that style of line / divider was going to be after the toolbars too, like kirigami apps, so removing it just would make that inconsistent later on. The divider needs to be inside the application itself to make this possible, instead of in the titlebar.

If it's possible, fixing the color scheme and making it configurable should probably be the way to go.

Dec 4 2019, 10:29 PM · Plasma
filipf added a comment to D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.

5.17 I say

Dec 4 2019, 8:44 PM · Plasma
filipf committed R112:ca27d4688a90: Merge branch 'Plasma/5.17' (authored by filipf).
Merge branch 'Plasma/5.17'
Dec 4 2019, 7:54 PM
filipf committed R112:4550095c4771: [Applet] Replace missing icon (authored by filipf).
[Applet] Replace missing icon
Dec 4 2019, 7:53 PM
filipf updated the diff for D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.

add space before final )

Dec 4 2019, 5:44 PM · Plasma
filipf updated the diff for D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.

define condition without creating a variable

Dec 4 2019, 5:41 PM · Plasma
filipf added a comment to D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.

So with the patch is it drawn when it is ticked in window decoration?

Dec 4 2019, 1:32 PM · Plasma
filipf added a comment to D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.

Is that configurable (Window decorations -> ^ Draw separator between titlebar and a window ?

Dec 4 2019, 1:26 PM · Plasma
filipf updated the summary of D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.
Dec 4 2019, 12:17 PM · Plasma
filipf updated the diff for D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.

don't break the sidebar

Dec 4 2019, 12:14 PM · Plasma
filipf added a comment to D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.

So we also fix this by setting:

Dec 4 2019, 11:04 AM · Plasma
filipf planned changes to D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.

I just realized this kills the sidebar when there's more than 1 kcm under a category :(

Dec 4 2019, 10:42 AM · Plasma
filipf added a comment to D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.

But... the "Before" image looks better. :/

Having the titlebar blend with the window kind of requires that nothing wants to be touching the titlebar, or else it just looks bad IMO. Personally my preference is to restore consistency by moving in the opposite direction by always showing a separator between what I'm calling the window's "tools area" (which consists of its titlebar + menubar if visible + toolbar if visible). That's what T10201 is all about and I had thought we had some agreement on that. If we land this patch, then there's no separator below the Tools Area for these windows, going against the goal of T10201.

Dec 4 2019, 10:35 AM · Plasma
filipf added reviewers for D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window: Plasma, VDG.
Dec 4 2019, 2:29 AM · Plasma
filipf requested review of D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window.
Dec 4 2019, 2:28 AM · Plasma
filipf updated the summary of D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.
Dec 4 2019, 12:47 AM · Plasma
filipf added a reviewer for D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs: Plasma.
Dec 4 2019, 12:34 AM · Plasma
filipf requested review of D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs.
Dec 4 2019, 12:33 AM · Plasma