filipf (Filip Fila)
Design

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Aug 15 2018, 7:18 AM (31 w, 2 d)
Availability
Available

Recent Activity

Yesterday

filipf added a comment to D12055: Remove border around menubars.

I don't see this border at all in the current version of Breeze GTK with Firefox.

Fri, Mar 22, 8:14 PM · Plasma
filipf added a comment to D12055: Remove border around menubars.

These borders are still pretty bad looking, I think we should go through with this.

Fri, Mar 22, 6:16 PM · Plasma
filipf added a comment to D19694: [RFC] Reduce sidebar icon size/increase list information density.

Ever since increasing the list item size to accommodate 32px icons, System Settings' sidebar has felt somehow wrong to me

Fri, Mar 22, 5:52 PM · Plasma
filipf accepted D19752: [Splash KCM] Use InlineMessage for testing error.

Visually I don't think there's anything to object to, and this is a useful message to have. The wording seems fine. Someone should also confirm that the code is sane.

Fri, Mar 22, 5:49 PM · Plasma
filipf updated the diff for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

make the "Folders" string translatable

Fri, Mar 22, 12:57 PM · Plasma
filipf added a comment to D18809: Image Wallpaper Slideshow - display the list of images that will be shown.

File /wallpapers/image/imagepackage/contents/ui/config.qml
Word "Folders" without translation

Kirigami.Heading {
    text: "Folders"
    level: 2
}
Fri, Mar 22, 12:55 PM · Plasma

Thu, Mar 21

filipf added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

This is a good feature. I'd definitely add an option so it can be turned on/off regardless of how well we fix up the icon. Sometimes you need to dummy-proof installs so all that matters is that it can be configured; by default it could be turned on IMO.

Thu, Mar 21, 2:39 PM · Plasma
filipf committed R114:f2647deeeac7: [comic] Modernize configuration windows (authored by filipf).
[comic] Modernize configuration windows
Thu, Mar 21, 2:30 PM
filipf closed D19802: [comic] Modernize configuration windows.
Thu, Mar 21, 2:30 PM · Plasma
filipf updated the test plan for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.
Thu, Mar 21, 2:06 PM · Plasma
filipf added a comment to D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

I've done a lot of clean up because: (1) some code is not needed for the FormLayout; (2) things worked the same without some code; (3) ported the combobox to QQC2 because the main layout is also using QQC2 comboboxes and everything still fits with normal scaling.

Thu, Mar 21, 1:59 PM · Plasma
filipf updated the test plan for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.
Thu, Mar 21, 1:56 PM · Plasma
filipf updated the diff for D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins.

remove line: twinFormLayouts: stack.item && stack.item.formLayout ? [stack.item.formLayout] : []

Thu, Mar 21, 1:52 PM · Plasma
filipf updated the diff for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

port everything

Thu, Mar 21, 1:46 PM · Plasma
filipf added a comment to D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins.

Second line results in a stack not defined error.

Thu, Mar 21, 1:11 PM · Plasma
filipf added a reviewer for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts: mart.
Thu, Mar 21, 12:19 AM · Plasma
filipf added reviewers for D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins: mart, Plasma, ngraham.
Thu, Mar 21, 12:18 AM · Plasma
filipf updated the test plan for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.
Thu, Mar 21, 12:16 AM · Plasma
filipf added a comment to D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.
In D19873#434949, @mart wrote:

So,
FormLayout has api to align two or more of them with each other, which is the list property FormLayout.twinFormLayouts

I wonder if there is a way to make the parent and child formlayouts visible ot each other to use such property.

the parent is in plasma-desktop/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml, loading the individual wallpapers config in the stackview at line 162.

so, we could try something like:
the wallpaper configs will expose a formLayout property.
the main formLayout has something like
twinFormLayouts: stack.item && stack.item.formLayout ? [stack.item.formLayout] : []

then the parent layout may be i guess injected at instantiation as a property of the wallpaper plugin, so the child formlayout can set twinformlayouts as well

this is all untested, so is a bit of R&D project, but if you would like to give a try it may be finally the properfix(tm)

Thu, Mar 21, 12:14 AM · Plasma
filipf added a dependency for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts: D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins.
Thu, Mar 21, 12:11 AM · Plasma
filipf added a dependent revision for D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins: D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.
Thu, Mar 21, 12:11 AM · Plasma
filipf retitled D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts from [image-wallpaper] Fix horizontal alignment of the "Positioning:" row to [image-wallpaper] WIP: Port to Kirigami.FormLayout and use twinFormLayouts.
Thu, Mar 21, 12:10 AM · Plasma
filipf updated the diff for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

Initial implementation of twinFormLayouts

Thu, Mar 21, 12:09 AM · Plasma
filipf requested review of D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins.
Thu, Mar 21, 12:08 AM · Plasma

Wed, Mar 20

filipf added a comment to D19802: [comic] Modernize configuration windows.

The title labels appear to be very far from the content. Is that just the size on the images or does it actually look very far when the config screen is full size?

Wed, Mar 20, 8:51 PM · Plasma
filipf updated the diff for D19802: [comic] Modernize configuration windows.

Change strings according to Nate's suggestions

Wed, Mar 20, 8:41 PM · Plasma
filipf accepted D19469: [sddm-theme] Update login screen preview image.

Beautiful.

Wed, Mar 20, 5:14 PM · Plasma

Tue, Mar 19

filipf added a comment to D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

It seems it was changed in this commit to explicitly use Kirigami units: 98d9f681a37e2ac2feb6bf5cb5e8a54f4c7e874e
Was the Color wallpaper forgotten or did this reason not apply to it? Should we revert it?

Tue, Mar 19, 5:26 PM · Plasma
filipf added a comment to D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

Mhm if I change it to use units like Color instead of Kirigami units it seems aligned properly:

Tue, Mar 19, 5:12 PM · Plasma
filipf updated subscribers of D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

@mart would you happen to know how to trick one FormLayout into thinking its content is as wide as another FormLayout's content?

Tue, Mar 19, 3:47 PM · Plasma
filipf added a comment to D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

I just have to figure out how trick the image wallpaper's FormLayout into thinking its form is as wide as the main one's.

That's why. :) They come from different sources, so the plugin's formLayout doesn't have access to the width data for the chooser's formLayout. However if you can figure out how to make this work, I think that would definitely be the ideal solution because then it wouldn't need any hacks.

Tue, Mar 19, 3:14 PM · Plasma
filipf added a comment to D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

This is just theoretical, but what are the obstacles with adding this whole row to the actual FormLayout file and just setting visible: when_image_wallpaper_is_used ?

Because the wallpaper chooser is plugin-based, and the image wallpaper is just one plugin out of many. In principle a wallpaper plugin could have whatever UI it wants, and its configuration UI has to live in a different place. It's just a visual trick that they look integrated together in the page.

Tue, Mar 19, 2:54 PM · Plasma
filipf added a comment to D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

This is just theoretical, but what are the obstacles with adding this whole row to the actual FormLayout file and just setting visible: when_image_wallpaper_is_used ?

Tue, Mar 19, 8:28 AM · Plasma
filipf added a comment to D19874: [Kickoff] Reduce the margins of KickoffItem.

I actually like the right margin because it contributes to visual hierarchy when headings are present:

Tue, Mar 19, 8:03 AM · Plasma
filipf committed R131:484ff7c7c3d3: [plasma-workspace-wallpapers] Add the Elarun wallpaper (authored by filipf).
[plasma-workspace-wallpapers] Add the Elarun wallpaper
Tue, Mar 19, 7:46 AM
filipf closed D19872: [plasma-workspace-wallpapers] Add the Elarun wallpaper.
Tue, Mar 19, 7:46 AM · Plasma

Mon, Mar 18

filipf added a comment to D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.

I think I'm still off by a pixel, will test better tomorrow.

Mon, Mar 18, 11:49 PM · Plasma
filipf updated the test plan for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.
Mon, Mar 18, 11:40 PM · Plasma
filipf added reviewers for D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts: Plasma, ngraham.
Mon, Mar 18, 11:40 PM · Plasma
filipf requested review of D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts.
Mon, Mar 18, 11:39 PM · Plasma
filipf abandoned D18934: [Notifications] Port the close ToolButton to RoundButton.

Abandoning due to the impending overhaul of notifications.

Mon, Mar 18, 10:58 PM · Plasma
filipf added a reviewer for D19872: [plasma-workspace-wallpapers] Add the Elarun wallpaper: rooty.
Mon, Mar 18, 10:56 PM · Plasma
filipf added reviewers for D19872: [plasma-workspace-wallpapers] Add the Elarun wallpaper: ngraham, VDG.
Mon, Mar 18, 10:47 PM · Plasma
filipf requested review of D19872: [plasma-workspace-wallpapers] Add the Elarun wallpaper.
Mon, Mar 18, 10:46 PM · Plasma
filipf updated the diff for D18934: [Notifications] Port the close ToolButton to RoundButton.

rebase

Mon, Mar 18, 8:17 PM · Plasma
filipf updated the diff for D18934: [Notifications] Port the close ToolButton to RoundButton.

fix dumb value

Mon, Mar 18, 7:59 PM · Plasma
filipf added a reviewer for D18934: [Notifications] Port the close ToolButton to RoundButton: broulik.
Mon, Mar 18, 7:55 PM · Plasma
filipf updated the test plan for D18934: [Notifications] Port the close ToolButton to RoundButton.
Mon, Mar 18, 7:54 PM · Plasma
filipf added a comment to D18934: [Notifications] Port the close ToolButton to RoundButton.

Alright so I'd like to give RoundButton another chance. Its advantage is that the frame is considerably smaller.

Mon, Mar 18, 7:52 PM · Plasma
filipf updated the diff for D18934: [Notifications] Port the close ToolButton to RoundButton.

Try using RoundButton

Mon, Mar 18, 7:49 PM · Plasma
filipf added inline comments to D19802: [comic] Modernize configuration windows.
Mon, Mar 18, 7:20 PM · Plasma
filipf updated the test plan for D19802: [comic] Modernize configuration windows.
Mon, Mar 18, 7:18 PM · Plasma
filipf updated the diff for D19802: [comic] Modernize configuration windows.

avoid using headings, fix spinbox strings

Mon, Mar 18, 7:17 PM · Plasma

Sun, Mar 17

filipf added a comment to D19838: [powerdevil] Touch up messages/prompts.

Looks good. I'd avoid using pronouns, I think it would sound better and whose else's is the battery if not yours?

Sun, Mar 17, 6:06 PM · Plasma
filipf added a comment to D19044: [InlineMessage] Do not draw shadows around the message.
In D19044#432878, @mart wrote:
In D19044#432853, @mart wrote:

uuh, no, this duplicates more, i meant moving things from the control to the template

But I moved most of things from src/controls/InlineMessage.qml to src/controls/templates/InlineMessage.qml?

i was put off by phabricator being stupid and telling src/controls/templates/InlineMessage.qml (173 lines)
Copied to src/styles/Material/InlineMessage.qml

however yeah, it seems alright, sorry, go for it =)

Sun, Mar 17, 5:20 PM · Kirigami
filipf committed R169:56ca5702d8a6: [InlineMessage] Do not draw shadows around the message (authored by filipf).
[InlineMessage] Do not draw shadows around the message
Sun, Mar 17, 5:19 PM
filipf closed D19044: [InlineMessage] Do not draw shadows around the message.
Sun, Mar 17, 5:19 PM · Kirigami
filipf added a comment to D19044: [InlineMessage] Do not draw shadows around the message.
In D19044#432853, @mart wrote:

uuh, no, this duplicates more, i meant moving things from the control to the template

Sun, Mar 17, 4:44 PM · Kirigami

Sat, Mar 16

filipf accepted D17469: Give applications-games and input-gaming more contrast with Breeze Dark.
Sat, Mar 16, 6:53 PM · Frameworks
filipf added a comment to D19802: [comic] Modernize configuration windows.

Definitely some silly mistakes in there, thanks for showing me how to do it right!

Sat, Mar 16, 5:15 PM · Plasma
filipf added a comment to D19797: [fifteen-puzzle] Modernize settings window.

+1 for porting to Kirigami.Formlayout, but I'm not sure that the new layout is an improvement. Something about it just doesn't feel quite right to me.

This might be a case where we could benefit from using actual headers ("Numbers" and "Pieces"), maybe?

Sat, Mar 16, 5:06 PM · Plasma
filipf retitled D19797: [fifteen-puzzle] Modernize settings window from [fifteen-puzzle Modernize settings window to [fifteen-puzzle] Modernize settings window.
Sat, Mar 16, 5:03 PM · Plasma
filipf retitled D19797: [fifteen-puzzle] Modernize settings window from [fifteen-clock] Modernize settings window to [fifteen-puzzle Modernize settings window.
Sat, Mar 16, 5:03 PM · Plasma
filipf accepted D19631: [sddm-theme/lock screen] Overhaul font sizes.
Sat, Mar 16, 3:24 PM · Plasma
filipf updated the diff for D19802: [comic] Modernize configuration windows.

1 strips per comic -> 1 strip per comic

Sat, Mar 16, 10:31 AM · Plasma
filipf updated the diff for D19802: [comic] Modernize configuration windows.

when value for minutes is 1 use "min" instead of "mins", when value for days is 1 use "day"
instead of "days"

Sat, Mar 16, 10:28 AM · Plasma
filipf updated the test plan for D19802: [comic] Modernize configuration windows.
Sat, Mar 16, 10:21 AM · Plasma
filipf added reviewers for D19802: [comic] Modernize configuration windows: rooty, ngraham, VDG, Plasma.
Sat, Mar 16, 10:21 AM · Plasma
filipf requested review of D19802: [comic] Modernize configuration windows.
Sat, Mar 16, 10:14 AM · Plasma

Fri, Mar 15

filipf updated the diff for D19797: [fifteen-puzzle] Modernize settings window.

forgot anchors again

Fri, Mar 15, 11:29 PM · Plasma
filipf committed R114:fb4fcae3f94e: [color-picker] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf).
[color-picker] Port configuration window to QQC2 and Kirigami.FormLayout
Fri, Mar 15, 11:06 PM
filipf closed D19789: [color-picker] Port configuration window to QQC2 and Kirigami.FormLayout.
Fri, Mar 15, 11:06 PM · Plasma
filipf added reviewers for D19797: [fifteen-puzzle] Modernize settings window: Plasma, VDG, ngraham.
Fri, Mar 15, 11:04 PM · Plasma
filipf requested review of D19797: [fifteen-puzzle] Modernize settings window.
Fri, Mar 15, 11:02 PM · Plasma
filipf updated the diff for D19789: [color-picker] Port configuration window to QQC2 and Kirigami.FormLayout.

forgot to add anchors

Fri, Mar 15, 4:28 PM · Plasma
filipf added reviewers for D19789: [color-picker] Port configuration window to QQC2 and Kirigami.FormLayout: Plasma, VDG, ngraham.
Fri, Mar 15, 4:21 PM · Plasma
filipf requested review of D19789: [color-picker] Port configuration window to QQC2 and Kirigami.FormLayout.
Fri, Mar 15, 4:20 PM · Plasma
filipf accepted D19631: [sddm-theme/lock screen] Overhaul font sizes.

If we're not going to be able to change SDDM's default font, this is the second best solution.

Fri, Mar 15, 12:15 AM · Plasma
filipf added a comment to D19687: Allow single images to be excluded from the slideshow.

The checkboxes are right where they're supposed to be, as for their visibility: maybe it would be useful if we had a variable that would allow us to add a background behind a checkbox.

Fri, Mar 15, 12:13 AM · Plasma

Thu, Mar 14

filipf updated the task description for T10586: Modernize plasmoid configuration settings.
Thu, Mar 14, 10:58 PM · VDG
filipf updated the task description for T10586: Modernize plasmoid configuration settings.
Thu, Mar 14, 10:09 PM · VDG
filipf added a task to D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout: T10586: Modernize plasmoid configuration settings.
Thu, Mar 14, 10:09 PM · Plasma
filipf added a revision to T10586: Modernize plasmoid configuration settings: D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout.
Thu, Mar 14, 10:09 PM · VDG
filipf added a revision to T10586: Modernize plasmoid configuration settings: D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout.
Thu, Mar 14, 10:08 PM · VDG
filipf added a task to D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout: T10586: Modernize plasmoid configuration settings.
Thu, Mar 14, 10:08 PM · Plasma
filipf committed R114:e32e12df50d3: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf).
[fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout
Thu, Mar 14, 10:08 PM
filipf closed D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout.
Thu, Mar 14, 10:08 PM · Plasma
filipf committed R120:cef563e560ac: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf).
[lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout
Thu, Mar 14, 10:06 PM
filipf closed D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout.
Thu, Mar 14, 10:06 PM · Plasma
filipf added a comment to D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout.

We'll need a bug report on this slider issue if we're gonna work around it, at a minimum.

Thu, Mar 14, 4:08 PM · Plasma
filipf updated the diff for D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout.

link the bug report for qqc2 slider

Thu, Mar 14, 4:07 PM · Plasma
filipf added a comment to D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout.

^ Ignore that, I was working on an older template.

Thu, Mar 14, 7:11 AM · Plasma
filipf updated the diff for D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout.

actually fix the "sleep" string

Thu, Mar 14, 7:10 AM · Plasma
filipf added a comment to D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout.

Unless I'm doing something wrong, QQC2 Slider seems broken when minimumValue aka from is 1:

Thu, Mar 14, 7:07 AM · Plasma
filipf planned changes to D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout.

Unforunately I'm getting bad stepSize behavior with the QQC2.Slider. It's reproducible even when keeping the original code and only porting the slider to QQC2 (that entails "from", "to", and removing "tickmarks"). If we can't get it to work we probably still need to document the issue better.

Thu, Mar 14, 5:50 AM · Plasma
filipf added reviewers for D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout: Plasma, VDG, ngraham.
Thu, Mar 14, 5:47 AM · Plasma
filipf requested review of D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout.
Thu, Mar 14, 5:45 AM · Plasma
filipf added a comment to D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout.

Forgot about that :)

Thu, Mar 14, 5:41 AM · Plasma
filipf updated the diff for D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout.

suspend -> sleep

Thu, Mar 14, 5:40 AM · Plasma
filipf added reviewers for D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout: Plasma, VDG, ngraham.
Thu, Mar 14, 5:09 AM · Plasma