filipf (Filip Fila)
Design

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 15 2018, 7:18 AM (40 w, 5 d)
Availability
Available

Recent Activity

Fri, May 24

filipf added a comment to D21378: Make Breeze Light/Dark use more system colors.

So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a good solution, +1 for the idea.

I gave it a quick spin with Breeze Dark however and it's just not picking up some color schemes. It remains stuck on the colors of some previous scheme that worked. This seems to be random and may be a bug originating elsewhere so I'm hitting accept.

After changing the system colorscheme, did you try restarting plasmashell or switching to a different desktop theme and switching back? I'll admit, it's a bit janky, but it should work if you do that. It definitely seems like a bug that originates from elsewhere.

Fri, May 24, 8:31 PM · Frameworks
filipf accepted D21378: Make Breeze Light/Dark use more system colors.

So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a good solution, +1 for the idea.

Fri, May 24, 6:50 PM · Frameworks
filipf committed R169:80abbd88b0eb: [FormLayout] Use even top and bottom spacing for separator (authored by filipf).
[FormLayout] Use even top and bottom spacing for separator
Fri, May 24, 3:43 PM
filipf closed D20585: [FormLayout] Use even top and bottom spacing for separator.
Fri, May 24, 3:43 PM · Kirigami

Tue, May 21

filipf added a comment to D20585: [FormLayout] Use even top and bottom spacing for separator.
In D20585#465924, @mart wrote:

I don't like adding a new property to separator for doing duck typing...

even is really ugly and errorprone as well, but i would prefer
Layout.topMargin: item.toString().indexOf("Separator")===0 ? Kirigami.Units.smallSpacing : 0

with a comment:
// FIXME: use item instanceof Kirigami.Separator when we can depend from Qt 5.11

Tue, May 21, 9:34 PM · Kirigami
filipf updated the diff for D20585: [FormLayout] Use even top and bottom spacing for separator.

minor fix

Tue, May 21, 9:32 PM · Kirigami
filipf updated the diff for D20585: [FormLayout] Use even top and bottom spacing for separator.

use mart's solution

Tue, May 21, 9:28 PM · Kirigami
filipf added a comment to D20972: [sidebar] Make search field not glued to the separator.

When anchors.margins is removed we see that the ToolButton still has 1px of its own margin around it

From what? Should they be there?

Tue, May 21, 9:19 PM · Plasma
filipf committed R120:a4bcb11bc2f1: Merge remote-tracking branch 'origin/Plasma/5.16' (authored by filipf).
Merge remote-tracking branch 'origin/Plasma/5.16'
Tue, May 21, 6:24 PM
filipf committed R120:e31d37ac721f: update (authored by filipf).
update
Tue, May 21, 6:22 PM
filipf committed R120:51c40e4f3b3d: [sddm-theme] Revert bad hack for spacing in action buttons and use a proper… (authored by filipf).
[sddm-theme] Revert bad hack for spacing in action buttons and use a proper…
Tue, May 21, 6:22 PM
filipf closed D21322: [sddm-theme] Revert bad hack for spacing in action buttons and use a proper solution.
Tue, May 21, 6:22 PM · Plasma
filipf committed R120:3a6c1f8a1806: [sddm-theme] Revert bad hack for spacing in action buttons and use a proper… (authored by filipf).
[sddm-theme] Revert bad hack for spacing in action buttons and use a proper…
Tue, May 21, 6:22 PM
filipf abandoned D21321: [sddm-theme] Revert bad hack for spacing in action buttons and use a proper solution.
Tue, May 21, 6:20 PM · Plasma
filipf retitled D21322: [sddm-theme] Revert bad hack for spacing in action buttons and use a proper solution from update to [sddm-theme] Revert bad hack for spacing in action buttons and use a proper solution.
Tue, May 21, 6:20 PM · Plasma
filipf updated the diff for D21322: [sddm-theme] Revert bad hack for spacing in action buttons and use a proper solution.

fix

Tue, May 21, 6:19 PM · Plasma
filipf requested review of D21322: [sddm-theme] Revert bad hack for spacing in action buttons and use a proper solution.
Tue, May 21, 6:19 PM · Plasma
filipf requested review of D21321: [sddm-theme] Revert bad hack for spacing in action buttons and use a proper solution.
Tue, May 21, 6:15 PM · Plasma
filipf added a comment to D21279: [sddm-theme] Add spacing between action buttons' labels.

This is an ugly hack.

ActionItems ultimately end up in
SessionManagementScreen.qml:113

Row {
id: actionItemsLayout
}

A Row has a spacing property.

Tue, May 21, 6:03 PM · Plasma
filipf committed R120:557271a94f1e: Merge remote-tracking branch 'origin/Plasma/5.16' (authored by filipf).
Merge remote-tracking branch 'origin/Plasma/5.16'
Tue, May 21, 5:17 PM
filipf committed R120:c92a33c20c53: [sddm-theme] Add spacing between action buttons' labels (authored by filipf).
[sddm-theme] Add spacing between action buttons' labels
Tue, May 21, 5:16 PM
filipf closed D21279: [sddm-theme] Add spacing between action buttons' labels.
Tue, May 21, 5:16 PM · Plasma
filipf added a comment to T8755: Use colors from the system colorscheme for the Task Manager's accent color in Breeze Light/Dark desktop themes.

It would be really cool if we could have some icon that would signalize that a particular desktop theme is color-scheme aware.

Tue, May 21, 12:39 AM · VDG, Plasma, Breeze

Mon, May 20

filipf added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

Can you use the NegativeText color from the colorscheme instead of a custom danger color?

Mon, May 20, 11:52 PM · Dolphin

Sun, May 19

filipf added a comment to D19631: [sddm-theme/lock screen] Overhaul font sizes.

! In D19631#467167, @filipf wrote:

Why does it look different than Neon?

Seems neon have a settings tweak to force more font Noto (especially for sddm).

Cherry picking that...

Sun, May 19, 5:21 PM · Plasma
filipf added a comment to D19631: [sddm-theme/lock screen] Overhaul font sizes.

Not looking good.

Sun, May 19, 5:01 PM · Plasma

Sat, May 18

filipf updated the diff for D21279: [sddm-theme] Add spacing between action buttons' labels.

height=width

Sat, May 18, 11:11 PM · Plasma
filipf updated the summary of D21279: [sddm-theme] Add spacing between action buttons' labels.
Sat, May 18, 10:47 PM · Plasma
filipf added reviewers for D21279: [sddm-theme] Add spacing between action buttons' labels: VDG, Plasma, ngraham.
Sat, May 18, 10:47 PM · Plasma
filipf updated the test plan for D21279: [sddm-theme] Add spacing between action buttons' labels.
Sat, May 18, 10:46 PM · Plasma
filipf requested review of D21279: [sddm-theme] Add spacing between action buttons' labels.
Sat, May 18, 10:45 PM · Plasma

Fri, May 17

filipf accepted D21253: Enable and disable UI controls properly based on sharing status.
Fri, May 17, 6:28 PM
filipf accepted D21252: Tweak UI strings to be a bit clearer.
Fri, May 17, 5:59 PM

Wed, May 15

filipf added a comment to D21234: Use a more conventional sidebar header apparance in desktop view.

+1 from a visual POV

Wed, May 15, 8:45 PM · Plasma
filipf committed R114:13e07f69884f: remove QQC1 now that the bug has been fixed (authored by filipf).
remove QQC1 now that the bug has been fixed
Wed, May 15, 7:55 PM
filipf committed R858:6d0289d7b284: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1 (authored by filipf).
[QQC2 Slider Style] Fix wrong handle positioning when initial value is 1
Wed, May 15, 4:34 PM
filipf closed D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1.
Wed, May 15, 4:34 PM · Plasma
filipf added a comment to D21027: [Notes] Fix icons being almost invisible with light backgrounds.

I tried to set icon.width and icon.height but it doesn't do anything.

In desktop style that should work since D20418

Wed, May 15, 4:32 PM · Plasma
filipf added a comment to D21229: Use view background color for sidebar to match other sidebars.

You were too quick for me but just wanted to say: nice!

Wed, May 15, 4:31 PM · Plasma

Tue, May 14

filipf committed R114:781e66cb2d05: [dict] Modernize configuration window (authored by filipf).
[dict] Modernize configuration window
Tue, May 14, 4:41 PM
filipf closed D20797: [dict] Modernize configuration window.
Tue, May 14, 4:41 PM · Plasma

Sat, May 11

filipf added inline comments to D21027: [Notes] Fix icons being almost invisible with light backgrounds.
Sat, May 11, 4:43 PM · Plasma
filipf committed R120:eaa5f94c0584: [Lock, login & logout screen] Add visual feedback to action buttons when pressed (authored by filipf).
[Lock, login & logout screen] Add visual feedback to action buttons when pressed
Sat, May 11, 4:15 PM
filipf closed D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed.
Sat, May 11, 4:15 PM · Plasma
filipf updated the test plan for D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed.
Sat, May 11, 4:15 PM · Plasma
filipf updated the diff for D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed.
  • change easing type from InOutQuad to InOutQuart to improve behavior when clicked fast
  • shorten the animation for the same reason
Sat, May 11, 4:14 PM · Plasma

Thu, May 9

filipf added a comment to T10875: Plasma 5.16 Release: Wallpaper competition.

Here would be some pieces of advice that I could offer:

  • It's encouraged to emulate the pastel geometric style of prior wallpapers; try to avoid unmodified photographs
  • Avoid large areas of super bright colors, as these can be visually overwhelming and look uncomfortable when closing or minimizing windows
  • Consider how lots of desktop icons would appear when placed on top of your wallpaper. To ensure that their labels remain readable, try to avoid very visually noisy or busy elements, particularly on the left side
  • Don't add text or logos on top of your wallpaper; however the Plasma logo is permissible if it is integrated as a key design element
Thu, May 9, 10:19 PM · KDE Promo
filipf updated the diff for D20797: [dict] Modernize configuration window.
  • use Kirigami.Theme for color, remove syspal
  • replace ListView Item with Control and have it be the delegate
  • replace Text with Label and have it be ListView's contentItem
Thu, May 9, 7:11 PM · Plasma
filipf added inline comments to D20797: [dict] Modernize configuration window.
Thu, May 9, 7:11 PM · Plasma
filipf updated the test plan for D20797: [dict] Modernize configuration window.
Thu, May 9, 7:11 PM · Plasma

Wed, May 8

filipf committed R954:794e1589322d: Add my (Filip Fila) blog to Planet KDE (authored by filipf).
Add my (Filip Fila) blog to Planet KDE
Wed, May 8, 11:18 PM
filipf accepted D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI.

Everything looks good to me now!

Wed, May 8, 9:04 PM · Plasma
filipf updated the diff for D21027: [Notes] Fix icons being almost invisible with light backgrounds.
  • add space after comment slashes
  • add punctuation in the comments for the added function
Wed, May 8, 8:55 PM · Plasma
filipf added a comment to D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI.

Hmm I can't set the number of columns anymore when in vertical position.

Wed, May 8, 8:48 PM · Plasma
filipf accepted D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI.
Wed, May 8, 8:43 PM · Plasma
filipf added inline comments to D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI.
Wed, May 8, 8:29 PM · Plasma
filipf updated the diff for D21027: [Notes] Fix icons being almost invisible with light backgrounds.

remove some hack I was working on for scrollbar color

Wed, May 8, 8:16 PM · Plasma
filipf updated the diff for D21027: [Notes] Fix icons being almost invisible with light backgrounds.

write a function for text and icon colors so as to not duplicate code everywhere

Wed, May 8, 8:15 PM · Plasma
filipf added a comment to D21026: Fix ToolButton remaining in a pressed state after press.

@mart does this look good to you? As you're the author I wouldn't want to merge without your approval.

Wed, May 8, 8:06 PM · Plasma
filipf added a comment to D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed.

Here's what I'm trying to avoid:

Wed, May 8, 8:03 PM · Plasma
filipf added a comment to D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1.

So I looked up Google's documentation and it turns out sliders do have to be mirrored:
https://material.io/design/usability/bidirectionality.html#mirroring-elements
https://material.io/design/components/sliders.html#usage

Wed, May 8, 7:57 PM · Plasma
filipf updated the diff for D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1.

fix handle behavior for right to left layouts

Wed, May 8, 11:02 AM · Plasma
filipf added a comment to D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1.

Hm, right, seems the slider behaves incorrectly without this patch, too :/ Still I think visualPosition is what we want to be using

Wed, May 8, 9:45 AM · Plasma
filipf added a comment to D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1.

-1
This breaks the slider in right-to-left mode. Run qmlscene -reverse to see

Wed, May 8, 9:20 AM · Plasma

Tue, May 7

filipf added a comment to T10875: Plasma 5.16 Release: Wallpaper competition.

I'm noticing that a lot of entries have the KDE logo or the Plasma name or version number embedded in it. I feel like this is kind of tacky and not really appropriate given that our prior wallpapers didn't do this, but we didn't make a rule prohibiting it. I'm tempted to recommend that we retroactively do so and ask the people who have submitted such wallpapers to remove those elements. Thoughts?

Tue, May 7, 11:04 PM · KDE Promo
filipf updated the test plan for D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1.
Tue, May 7, 10:50 PM · Plasma
filipf added reviewers for D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1: mart, Plasma, ngraham.
Tue, May 7, 10:37 PM · Plasma
filipf requested review of D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1.
Tue, May 7, 10:34 PM · Plasma
filipf accepted D21056: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and modernize UI.
Tue, May 7, 10:14 PM · Plasma
filipf updated the task description for T10586: Modernize widget configuration settings.
Tue, May 7, 8:57 PM · VDG
filipf added a comment to D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed.

I'm going to look into the different easing curves a bit more because I sometimes see the semi-scaled circle if clicking too fast.

Tue, May 7, 7:28 PM · Plasma
filipf updated the diff for D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed.
  • remove ID
  • height = width
  • use and animate scale instead of height & width
Tue, May 7, 7:25 PM · Plasma
filipf committed R114:13609c5ae7b9: [potd] Modernize configuration settings (authored by filipf).
[potd] Modernize configuration settings
Tue, May 7, 7:23 PM
filipf closed D20969: [potd] Modernize configuration settings.
Tue, May 7, 7:22 PM · Plasma
filipf added reviewers for D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed: VDG, Plasma, ngraham.
Tue, May 7, 8:36 AM · Plasma
filipf requested review of D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed.
Tue, May 7, 8:35 AM · Plasma

Mon, May 6

filipf added inline comments to D21056: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and modernize UI.
Mon, May 6, 10:16 PM · Plasma
filipf updated the diff for D20908: RFC: Redesign QML applet configuration windows.

Kirigami.Theme.viewBackgroundColor is deprecated so set the colorSet to Theme.View instead

Mon, May 6, 7:43 PM · Plasma
filipf added a comment to D21030: [WidgetExplorer] Fix blurry previews.

Looks like you cherry-picked the commit onto each branch, is that right? In general it's preferred to land the commit onto the oldest branch and then merge forward. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

I can help with this in the future. It can be tricky.

Mon, May 6, 5:55 PM · Plasma
filipf committed R119:5519a0a5bff8: [WidgetExplorer] Fix blurry previews (authored by filipf).
[WidgetExplorer] Fix blurry previews
Mon, May 6, 3:22 PM
filipf committed R119:75fa5132f78b: [WidgetExplorer] Fix blurry previews (authored by filipf).
[WidgetExplorer] Fix blurry previews
Mon, May 6, 3:18 PM
filipf committed R119:29f0bea89889: [WidgetExplorer] Fix blurry previews (authored by filipf).
[WidgetExplorer] Fix blurry previews
Mon, May 6, 3:17 PM
filipf closed D21030: [WidgetExplorer] Fix blurry previews.
Mon, May 6, 3:17 PM · Plasma
filipf added a comment to D21030: [WidgetExplorer] Fix blurry previews.

Nice! Stable branch please.

Mon, May 6, 1:44 PM · Plasma

Sun, May 5

filipf updated the test plan for D21030: [WidgetExplorer] Fix blurry previews.
Sun, May 5, 9:05 PM · Plasma
filipf updated the diff for D21030: [WidgetExplorer] Fix blurry previews.

use Math.floor instead of Math.round

Sun, May 5, 9:05 PM · Plasma
filipf added a comment to D20969: [potd] Modernize configuration settings.

Few changes needed to the Description before landing:

  • Is the NOTE still accurate? I don't see that behavior anymore.
  • Also we're no longer porting to QQC2
Sun, May 5, 8:40 PM · Plasma
filipf updated the summary of D20969: [potd] Modernize configuration settings.
Sun, May 5, 8:39 PM · Plasma
filipf updated the summary of D21027: [Notes] Fix icons being almost invisible with light backgrounds.
Sun, May 5, 7:00 PM · Plasma
filipf planned changes to D21027: [Notes] Fix icons being almost invisible with light backgrounds.

Gotcha. At least use a function instead of duplicating the same code in each button.

Sun, May 5, 6:58 PM · Plasma
filipf accepted D20976: Respect the user-configured mimetype when dragging an image from the main window.
Sun, May 5, 6:40 PM · Spectacle
filipf added a comment to D20976: Respect the user-configured mimetype when dragging an image from the main window.

I think the user expectation is that whatever format has been selected in the settings window is the format that the image will be saved in no matter what method is used to get it out of Spectacle. At least, that was my expectation after I set the format to JPEG and was confused by the fact that using the DnD feature produces PNG images instead.

The fact that dragging the image from the app's main window always produced a PNG seems like it was a bug rather than an intentional feature. If you want an image in a lossless format, you stick with the default PNG format. A person who deliberately changes that to JPEG is signaling that they want their images to always be JPEGs.

We can see what VDG thinks. It would be nice to get a decision today though since tomorrow is the 19.04.1 tagging date.

Sun, May 5, 6:31 PM · Spectacle
filipf updated the summary of D21030: [WidgetExplorer] Fix blurry previews.
Sun, May 5, 11:48 AM · Plasma
filipf added reviewers for D21030: [WidgetExplorer] Fix blurry previews: Plasma, VDG, ngraham.
Sun, May 5, 11:35 AM · Plasma
filipf requested review of D21030: [WidgetExplorer] Fix blurry previews.
Sun, May 5, 11:34 AM · Plasma
filipf updated subscribers of D21027: [Notes] Fix icons being almost invisible with light backgrounds.

I get what you're saying but that's just how the applet is designed. It's preconfigured SVG backgrounds (you can find them in /usr/share/plasma/desktoptheme/default/widgets/notes.svgz). I'm not really introducing any hardcoding that isn't already there. See the hardcoding of text color:

Sun, May 5, 7:35 AM · Plasma

Sat, May 4

filipf updated the diff for D21027: [Notes] Fix icons being almost invisible with light backgrounds.

move accessibleName back into ToolButton, but still refer to the Tooltip's text

Sat, May 4, 9:43 PM · Plasma
filipf updated the diff for D21027: [Notes] Fix icons being almost invisible with light backgrounds.

move accessibleName into tooltip and refer to the tooltip's text

Sat, May 4, 9:36 PM · Plasma
filipf added a comment to D21027: [Notes] Fix icons being almost invisible with light backgrounds.

Plasma has this "ColorScope" thing. Does this work as a solution? Will fix the frame

Sat, May 4, 9:12 PM · Plasma
filipf updated the test plan for D21027: [Notes] Fix icons being almost invisible with light backgrounds.
Sat, May 4, 9:04 PM · Plasma