filipf (Filip Fila)
Design

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 15 2018, 7:18 AM (65 w, 1 d)
Availability
Available

Recent Activity

Mon, Nov 11

filipf abandoned D25222: [Lock Screen] Fix album art binding loop.

continued in D25252

Mon, Nov 11, 2:53 PM · Plasma
filipf added a comment to D25252: Fix binding loop in lockscreen media controls.

I'm not seeing any binding loop warnings when testing this fwiw.

Mon, Nov 11, 2:53 PM · Plasma

Sat, Nov 9

filipf added a comment to D25222: [Lock Screen] Fix album art binding loop.

Yeah you guys are right. I tested this further and still got some binding loop errors with paintedWidth/Height.

Sat, Nov 9, 5:41 PM · Plasma

Fri, Nov 8

filipf updated the test plan for D25222: [Lock Screen] Fix album art binding loop.
Fri, Nov 8, 6:41 PM · Plasma
filipf requested review of D25222: [Lock Screen] Fix album art binding loop.
Fri, Nov 8, 6:40 PM · Plasma
filipf added a comment to D25024: Use the same avatar size in lock, login and logout screens.

friendly ping

Fri, Nov 8, 5:02 PM · Plasma
filipf added inline comments to D24720: [applets/systemtray] Rewrite popups with layouts.
Fri, Nov 8, 12:16 PM · Plasma
filipf added inline comments to D24720: [applets/systemtray] Rewrite popups with layouts.
Fri, Nov 8, 10:29 AM · Plasma

Thu, Nov 7

filipf added a comment to D25015: Update breeze theme shadows.

Before:

Thu, Nov 7, 7:40 AM · Frameworks
filipf added a comment to D25015: Update breeze theme shadows.

There's definitely a difference, whereas the shadows are now rough and dark this is subtler.

Thu, Nov 7, 7:37 AM · Frameworks

Wed, Nov 6

filipf added a comment to D25015: Update breeze theme shadows.

I'd prefer the shadows to have equal strength all around, I couldn't get used to weaker shadows in the corners.

Wed, Nov 6, 8:10 PM · Frameworks

Tue, Nov 5

filipf committed R124:f5c741afdf9b: Merge branch 'Plasma/5.17' (authored by filipf).
Merge branch 'Plasma/5.17'
Tue, Nov 5, 10:56 AM
filipf committed R124:efb35162be7f: [Icon View] Don't use dialog-warning emblem on icon when KCM requires… (authored by filipf).
[Icon View] Don't use dialog-warning emblem on icon when KCM requires…
Tue, Nov 5, 10:54 AM
filipf closed D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication.
Tue, Nov 5, 10:54 AM · Plasma
filipf updated the summary of D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication.
Tue, Nov 5, 10:54 AM · Plasma
filipf added a comment to D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication.

I think so. This is a bugfix.

Tue, Nov 5, 12:24 AM · Plasma

Mon, Nov 4

filipf added a comment to D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication.

Would this be an acceptable change for the 5.17 branch?

Mon, Nov 4, 11:46 PM · Plasma
filipf added a comment to D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication.

Might also be worth mentioning this now makes it consistent with sidebar view, which doesn't use this emblem.

Mon, Nov 4, 11:42 PM · Plasma
filipf added reviewers for D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication: VDG, ngraham.
Mon, Nov 4, 11:34 PM · Plasma
filipf requested review of D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication.
Mon, Nov 4, 11:33 PM · Plasma
ognarb awarded T10470: Improve the visuals of tray popups a Love token.
Mon, Nov 4, 2:50 PM · VDG
pedrogomes1698 awarded T10470: Improve the visuals of tray popups a Love token.
Mon, Nov 4, 2:08 PM · VDG
PopeRigby awarded T10470: Improve the visuals of tray popups a Love token.
Mon, Nov 4, 5:34 AM · VDG

Sun, Nov 3

filipf added a comment to D24720: [applets/systemtray] Rewrite popups with layouts.

Hi :)
Please tag me in case you need any RTL help.
Yes, headers are aligned based on direction before, which was bad. It's almost better to align them to the other side even if they're not translated. You never know.
And good that you spotted the issue with QML's Layouts regarding RTL:)

As a user, I'm happy to see more work being done to refactor the code and make it easier! <3

Sun, Nov 3, 4:14 PM · Plasma
filipf committed R120:5b3f5bd9c32e: [applets/systemtray] Rewrite popups with layouts (authored by filipf).
[applets/systemtray] Rewrite popups with layouts
Sun, Nov 3, 4:12 PM
filipf closed D24720: [applets/systemtray] Rewrite popups with layouts.
Sun, Nov 3, 4:12 PM · Plasma
GB_2 awarded T10470: Improve the visuals of tray popups a Love token.
Sun, Nov 3, 1:02 PM · VDG

Sat, Nov 2

filipf added a comment to D24720: [applets/systemtray] Rewrite popups with layouts.

It it just awaiting review from a Plasma person?

Sat, Nov 2, 7:06 PM · Plasma
filipf added a comment to D25043: [ResultDelegate] Use theme.disabledColor.

I don't think worsening text legibilty with some themes is a good feature for an LTS release.

Sat, Nov 2, 7:05 PM · Plasma

Tue, Oct 29

filipf added a comment to D25043: [ResultDelegate] Use theme.disabledColor.

Not a fan of this for 2 reasons:

  • we have no control over color schemes; they might have dumb values for this color; in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme:
  • it's not consistent with how this effect is achieved elsewhere in Plasmashell (where the opacity is 0.6 and not 0.5 or 0.3, so it seems that was wrong here).

    I'd just raise the opacity values instead.

Wait, this is the Breeze Dark colorscheme with the Breeze desktop theme? The desktop theme that gets its colors from the system colorscheme? If so, something is seriously wrong here.

Tue, Oct 29, 11:00 PM · Plasma
filipf added a comment to D25043: [ResultDelegate] Use theme.disabledColor.

@kbroulik we should try to wait if there is an ongoing discussion.

I have the latest package installed in KDE Neon Dev Unstable, does it need to be compiled instead for some very recent change?

Yes, there's a partner patch adding a disabledText role to Plasma theme to bring it in line with kirigami.
I think Neon builds once every night? If you don't have it your console will be spewing errors saying "no such role"

Tue, Oct 29, 2:46 PM · Plasma
filipf added a comment to D25043: [ResultDelegate] Use theme.disabledColor.
in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme:

Make sure your plasma-framework is up to date

Tue, Oct 29, 1:36 PM · Plasma
filipf added a comment to D25043: [ResultDelegate] Use theme.disabledColor.

Not a fan of this for 2 reasons:

  • we have no control over color schemes; they might have dumb values for this color; in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme:

Tue, Oct 29, 1:21 PM · Plasma
filipf committed R120:c26786f9a954: Merge branch 'Plasma/5.17' (authored by filipf).
Merge branch 'Plasma/5.17'
Tue, Oct 29, 6:26 AM
filipf committed R120:d029fb058cff: [Lock Screen] Don't use black shadows with black text (authored by filipf).
[Lock Screen] Don't use black shadows with black text
Tue, Oct 29, 6:25 AM
filipf closed D24997: [Lock & Login Screens] Don't use a black shadow with black text.
Tue, Oct 29, 6:25 AM · Plasma

Mon, Oct 28

filipf updated subscribers of D25024: Use the same avatar size in lock, login and logout screens.

@davidedmundson I believe you wrote the code for the the avatar size in the lock and login screens (property real faceSize: Math.min(width, height - usernameDelegate.height - units.smallSpacing).

Mon, Oct 28, 11:06 PM · Plasma
filipf accepted D25006: Make sure -dpi value is valid.

Tested the patch and it no longer accepts strings or values under 24.

Mon, Oct 28, 11:01 PM · Plasma
filipf added a task to D25024: Use the same avatar size in lock, login and logout screens: T11093: Improve Consistency across the Board.
Mon, Oct 28, 10:20 PM · Plasma
filipf added a revision to T11093: Improve Consistency across the Board: D25024: Use the same avatar size in lock, login and logout screens.
Mon, Oct 28, 10:20 PM · Goal: Consistency, Goal Setting 2019
filipf added reviewers for D25024: Use the same avatar size in lock, login and logout screens: Plasma, VDG.
Mon, Oct 28, 10:19 PM · Plasma
filipf requested review of D25024: Use the same avatar size in lock, login and logout screens.
Mon, Oct 28, 10:17 PM · Plasma
filipf triaged T11930: Rethink Lock, Login and Logout Screen's Color Modularity as Normal priority.
Mon, Oct 28, 9:49 PM · Plasma, VDG
filipf added a comment to D25015: Update breeze theme shadows.

Testing it. Usability wise the strength is perfectly fine; the shadows still do their job.

Mon, Oct 28, 9:11 PM · Frameworks
filipf added a comment to D24997: [Lock & Login Screens] Don't use a black shadow with black text.

Yeah there is a conceptual issue here we need to look into solving. IMO we should just always have white UI elements and the background dimmed.

Mon, Oct 28, 2:21 PM · Plasma
filipf added a comment to D24997: [Lock & Login Screens] Don't use a black shadow with black text.

Admittedly this doesn't look super fortuate either when the wallpaper is darker:

Mon, Oct 28, 12:23 PM · Plasma
filipf updated the test plan for D24997: [Lock & Login Screens] Don't use a black shadow with black text.
Mon, Oct 28, 8:07 AM · Plasma
filipf updated the diff for D24997: [Lock & Login Screens] Don't use a black shadow with black text.

also apply the same fix to the login screen

Mon, Oct 28, 8:06 AM · Plasma
filipf updated the test plan for D24997: [Lock & Login Screens] Don't use a black shadow with black text.
Mon, Oct 28, 7:54 AM · Plasma
filipf added inline comments to D24997: [Lock & Login Screens] Don't use a black shadow with black text.
Mon, Oct 28, 7:54 AM · Plasma
filipf updated the test plan for D24997: [Lock & Login Screens] Don't use a black shadow with black text.
Mon, Oct 28, 7:52 AM · Plasma
filipf added reviewers for D24997: [Lock & Login Screens] Don't use a black shadow with black text: Plasma, VDG, ngraham.
Mon, Oct 28, 7:46 AM · Plasma
filipf requested review of D24997: [Lock & Login Screens] Don't use a black shadow with black text.
Mon, Oct 28, 7:45 AM · Plasma

Sun, Oct 27

filipf added a comment to T11925: Breeze Desktop Theme Transparency.

maybe we should consider doing the same here and make the opacity and blur settings global such that they affect both apps and Plasma equally.

Sun, Oct 27, 8:59 PM · VDG
filipf added a comment to T11925: Breeze Desktop Theme Transparency.

I'd go with 80% opacity. That's not the trendy value, lower opacity values are. Text will be legible but the aesthetics are improved.

Sun, Oct 27, 8:30 PM · VDG
filipf updated subscribers of T11925: Breeze Desktop Theme Transparency.
Sun, Oct 27, 8:25 PM · VDG

Thu, Oct 24

filipf added a comment to T10495: wallpaper cache.

Update: I did an amazing rewrite of wallpaper that cleaned a lot up, but this task still arguably remains.

Thu, Oct 24, 8:25 PM · Plasma
filipf committed R124:1f929dda539c: Merge branch 'Plasma/5.17' (authored by filipf).
Merge branch 'Plasma/5.17'
Thu, Oct 24, 8:18 PM
filipf closed D24901: [sidebar] Add a hover effect to intro page icons.
Thu, Oct 24, 8:17 PM · Plasma
filipf committed R124:a306b76cb853: [sidebar] Add a hover effect to intro page icons (authored by filipf).
[sidebar] Add a hover effect to intro page icons
Thu, Oct 24, 8:17 PM

Wed, Oct 23

filipf added a comment to D24901: [sidebar] Add a hover effect to intro page icons.

Is it possible to make a smooth effect animation? Like in sidebar.

Wed, Oct 23, 11:21 PM · Plasma
filipf added a comment to D24901: [sidebar] Add a hover effect to intro page icons.

5.17

Wed, Oct 23, 10:18 PM · Plasma
filipf updated the summary of D24901: [sidebar] Add a hover effect to intro page icons.
Wed, Oct 23, 10:17 PM · Plasma
filipf awarded D24893: [Lock Screen] Add option to hide clock when idle a The World Burns token.
Wed, Oct 23, 9:29 PM · Plasma
filipf updated the summary of D24901: [sidebar] Add a hover effect to intro page icons.
Wed, Oct 23, 9:18 PM · Plasma
filipf updated the diff for D24901: [sidebar] Add a hover effect to intro page icons.

also make the effect appear on activeFocus (tabbing)

Wed, Oct 23, 9:18 PM · Plasma
filipf added reviewers for D24901: [sidebar] Add a hover effect to intro page icons: Plasma, VDG, ngraham.
Wed, Oct 23, 9:13 PM · Plasma
filipf requested review of D24901: [sidebar] Add a hover effect to intro page icons.
Wed, Oct 23, 9:12 PM · Plasma

Mon, Oct 21

filipf accepted D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong.

Makes sense. It's unrelated to this patch but what's up with the double message ("No space on device left" and "not enough free disk space") here?

Mon, Oct 21, 9:59 PM · Plasma
filipf accepted D24844: [Applet] Remove hamburger button and menu.
Mon, Oct 21, 9:57 PM · Plasma
filipf added a comment to D24720: [applets/systemtray] Rewrite popups with layouts.

Everything should work fine now hopefully.

Mon, Oct 21, 8:36 PM · Plasma
filipf updated the diff for D24720: [applets/systemtray] Rewrite popups with layouts.
  • pin button now appears in the "Status and Notifications" popup again
  • simpler code for checking layout mirroring
Mon, Oct 21, 8:35 PM · Plasma
filipf added a comment to D24720: [applets/systemtray] Rewrite popups with layouts.

Based on a search of some examples of RTL UI settings I'm going to say headings also go on the right side, so it seems they were actually not correctly placed before.

Mon, Oct 21, 7:30 PM · Plasma
filipf added a comment to D24720: [applets/systemtray] Rewrite popups with layouts.

The latest version already works with RTL without the fillWidth code being needed. So as far as I can tell the diff you posted only effectively removes the margins from headings. But I think we should keep them, i.e., align those headings with the container (@GB_2 already mentioned this : D24720#548745)

Mon, Oct 21, 7:15 PM · Plasma
filipf updated the summary of D24720: [applets/systemtray] Rewrite popups with layouts.
Mon, Oct 21, 7:50 AM · Plasma
filipf updated the test plan for D24720: [applets/systemtray] Rewrite popups with layouts.
Mon, Oct 21, 7:50 AM · Plasma
filipf updated the diff for D24720: [applets/systemtray] Rewrite popups with layouts.

restore original margin between sidebar and container

Mon, Oct 21, 7:49 AM · Plasma
filipf added a parent task for T10470: Improve the visuals of tray popups: T10891: Breeze theme evolution.
Mon, Oct 21, 7:39 AM · VDG
filipf added a subtask for T10891: Breeze theme evolution: T10470: Improve the visuals of tray popups.
Mon, Oct 21, 7:39 AM · Plasma, VDG, Breeze

Sun, Oct 20

filipf abandoned D24009: RFC: Make Breeze Dark darker.

Gonna leave all color scheme updates to @ndavis and @cblack who have been working on a new palette for Breeze etc.

Sun, Oct 20, 6:06 PM · Plasma
filipf committed R119:cd448b071760: Merge branch 'Plasma/5.17' (authored by filipf).
Merge branch 'Plasma/5.17'
Sun, Oct 20, 6:03 PM
filipf committed R119:6b4295b313af: [applets/taskmanager] Revert "forceStripes" checkbox string change (authored by filipf).
[applets/taskmanager] Revert "forceStripes" checkbox string change
Sun, Oct 20, 6:02 PM
filipf closed D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change.
Sun, Oct 20, 6:02 PM · Plasma
filipf added a comment to D24720: [applets/systemtray] Rewrite popups with layouts.

Seems like the RTL problem may be that your RowLayouts that are within the parent ColumnLayout don't have Layout.fillWidth: true set. Does the problem go away if you set that?

Sun, Oct 20, 10:03 AM · Plasma

Thu, Oct 17

filipf awarded D24744: Remove unneeded options in GTK KCM a Yellow Medal token.
Thu, Oct 17, 8:26 PM · VDG, Plasma
filipf added a comment to D24744: Remove unneeded options in GTK KCM.

So much nicer, awesome work. +1 for the visuals of the rehauled kcm.

Thu, Oct 17, 8:26 PM · VDG, Plasma
filipf added a comment to D24720: [applets/systemtray] Rewrite popups with layouts.

Nice, this feels indistinguishible from the current one, which is a good sign. I see what you mean about the Headings in RTL. Does the Kirigami version work properly? If so, I wonder if it might be worth it to just use that instead given that the future of PlasmaComponents is on shaky ground (T11558: kill plasma components in favour of qqc2-desktop-style)

Thu, Oct 17, 8:05 PM · Plasma
filipf updated the diff for D24720: [applets/systemtray] Rewrite popups with layouts.

make all this work right with RTL layouts

Thu, Oct 17, 8:03 PM · Plasma
filipf added a comment to D24720: [applets/systemtray] Rewrite popups with layouts.

Agreed, let's not change the padding.

Thu, Oct 17, 5:59 PM · Plasma
filipf updated the test plan for D24720: [applets/systemtray] Rewrite popups with layouts.
Thu, Oct 17, 5:56 PM · Plasma
filipf updated the diff for D24720: [applets/systemtray] Rewrite popups with layouts.

don't alter padding

Thu, Oct 17, 5:53 PM · Plasma
GB_2 awarded D21813: RFC: Consider adding more padding to the desktop theme a Love token.
Thu, Oct 17, 8:28 AM · Frameworks
filipf added a comment to D24720: [applets/systemtray] Rewrite popups with layouts.

The paddings issue is actually the same as with notifications (D21813). We can tweak it here and then alter it for all desktop themes, some of which already add extra padding on their own. This means we're messing with their looks.

Thu, Oct 17, 12:05 AM · Plasma
filipf added a comment to D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change.

Do we have a green light for 5.17.1? How do I tag the translators?

Thu, Oct 17, 12:01 AM · Plasma
filipf abandoned D24567: WIP: Implement sidebar mode for system tray plasmoid popups.

Yeah, can't get this to work properly anyway.

Thu, Oct 17, 12:00 AM · Plasma

Wed, Oct 16

filipf updated the diff for D24720: [applets/systemtray] Rewrite popups with layouts.

remove useless leftover stuff from WIP versions

Wed, Oct 16, 11:57 PM · Plasma
filipf added inline comments to D24720: [applets/systemtray] Rewrite popups with layouts.
Wed, Oct 16, 11:54 PM · Plasma
filipf added reviewers for D24720: [applets/systemtray] Rewrite popups with layouts: Plasma, VDG.
Wed, Oct 16, 11:53 PM · Plasma
filipf requested review of D24720: [applets/systemtray] Rewrite popups with layouts.
Wed, Oct 16, 11:52 PM · Plasma

Oct 14 2019

filipf committed R120:b38de7908171: [applets/systemtray] Kirigamify units (authored by filipf).
[applets/systemtray] Kirigamify units
Oct 14 2019, 1:04 PM