filipf (Filip Fila)
Design

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 15 2018, 7:18 AM (109 w, 4 d)
Availability
Available

Recent Activity

Jun 24 2020

filipf abandoned D29741: [Logout] Port to QQC2 and PC3.

https://invent.kde.org/plasma/plasma-workspace/commit/21bdc2a89d123932af2a1b04bd8e98ff868bf3eb

Jun 24 2020, 9:33 PM · Plasma

May 22 2020

filipf added a comment to D28154: Add users KCM.

Now that D29394 has landed, you can add those images here!

May 22 2020, 7:21 PM · Plasma

May 20 2020

filipf added a comment to D29263: Position OSD a bit farther down.

I'm a bit confused. Aren't we changing the size for third party global themes as well? Do all global themes set their size?

May 20 2020, 7:02 AM · KWin

May 17 2020

filipf accepted D29802: Require out-of-source builds.
May 17 2020, 2:17 PM · Frameworks

May 15 2020

filipf abandoned D29765: Add a blurless SDDM theme.

Yeah on second thought this is ugly from a maintenance POV. We'd need a GUI sheet that exposes theme.conf and then blur would be one option.

May 15 2020, 6:27 PM · Plasma
filipf added a comment to D29765: Add a blurless SDDM theme.

Can we perhaps add infrastructure so that a theme can provide options?
For instance, the look and feel package can add options to the lock screen KCM which we use for e.g. "always show clock" and "show media controls".
I'm not keen on duplicating the entire theme for a single option.

May 15 2020, 7:44 AM · Plasma

May 14 2020

filipf added reviewers for D29765: Add a blurless SDDM theme: VDG, Plasma.
May 14 2020, 10:11 PM · Plasma
filipf requested review of D29765: Add a blurless SDDM theme.
May 14 2020, 10:09 PM · Plasma
filipf added a comment to D29740: [PC3 Button] Don't remain in a pressed state after press.

The more I think about this the more it feels like a workaround. Presuming QQC2's behavior of leaving a pressed button focused after press is correct, perhaps we are at fault for providing the same svg for focus-background and pressed.

May 14 2020, 6:56 PM · Frameworks
filipf added a reviewer for D29741: [Logout] Port to QQC2 and PC3: Plasma.
May 14 2020, 10:42 AM · Plasma
filipf added a dependent revision for D29740: [PC3 Button] Don't remain in a pressed state after press: D29741: [Logout] Port to QQC2 and PC3.
May 14 2020, 10:41 AM · Frameworks
filipf added a dependency for D29741: [Logout] Port to QQC2 and PC3: D29740: [PC3 Button] Don't remain in a pressed state after press.
May 14 2020, 10:41 AM · Plasma
filipf requested review of D29741: [Logout] Port to QQC2 and PC3.
May 14 2020, 10:41 AM · Plasma
filipf added reviewers for D29740: [PC3 Button] Don't remain in a pressed state after press: davidedmundson, mart, Plasma.
May 14 2020, 10:33 AM · Frameworks
filipf requested review of D29740: [PC3 Button] Don't remain in a pressed state after press.
May 14 2020, 10:30 AM · Frameworks

May 13 2020

filipf committed R120:cd46f752362f: Merge branch 'Plasma/5.18' (authored by filipf).
Merge branch 'Plasma/5.18'
May 13 2020, 4:10 PM
filipf committed R120:68601675d13b: [sddm-theme] Prevent the logo from leaking in after a fadeout (authored by filipf).
[sddm-theme] Prevent the logo from leaking in after a fadeout
May 13 2020, 4:09 PM
filipf closed D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout.
May 13 2020, 4:09 PM · Plasma
filipf committed R128:13e73011b1ac: Add photographic user avatars (authored by filipf).
Add photographic user avatars
May 13 2020, 4:02 PM
filipf closed T9910: Revisit user avatar gallery images as Resolved by committing R128:13e73011b1ac: Add photographic user avatars.
May 13 2020, 4:02 PM · VDG
filipf closed D29394: Add photographic user avatars.
May 13 2020, 4:02 PM · Plasma
filipf updated the diff for D29394: Add photographic user avatars.

don't delete user_manager.kdev4

May 13 2020, 2:32 PM · Plasma
filipf updated the diff for D29394: Add photographic user avatars.

Make as REUSE compliant as possible

May 13 2020, 2:31 PM · Plasma
filipf added a comment to D29394: Add photographic user avatars.

The .license files could live in another folder. Maybe src/pics_sources?

May 13 2020, 2:08 PM · Plasma
filipf added a comment to D29394: Add photographic user avatars.

Looks good for licence freedom

Could you make the licence info in format specified at https://reuse.software/tutorial/ ? It's what we want to use from now on in KDE.

So add cat.jpg.license files with SPDX header lines saying CC0 and add /LICENSES/CC0-1.0.txt

May 13 2020, 1:53 PM · Plasma
filipf updated the test plan for D29394: Add photographic user avatars.
May 13 2020, 1:17 PM · Plasma
filipf updated the diff for D29394: Add photographic user avatars.

rework licensing stucture due to a flaw in user_manager (it shows every single file in the avatar gallery and the .license files break it)

May 13 2020, 1:12 PM · Plasma

May 12 2020

filipf updated the summary of D29394: Add photographic user avatars.
May 12 2020, 9:08 PM · Plasma
filipf updated the diff for D29394: Add photographic user avatars.

Use this format https://reuse.software/tutorial/ making a LICENCE/ directory with the licence text in it and cat.jpg.license with the SPDX header

May 12 2020, 9:03 PM · Plasma
filipf updated the diff for D29394: Add photographic user avatars.

actually remove Chip and Gecko(due to rename)

May 12 2020, 7:58 PM · Plasma
filipf updated the diff for D29394: Add photographic user avatars.
  • rename Gecko to Chameleon because that wasn't a gecko
  • remove Chip
  • add Air Balloon, Dog, Fish, Owl, Pencils, Sushi
  • WIP: licence files
May 12 2020, 7:55 PM · Plasma
filipf accepted D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage.

Works well and looks good.

May 12 2020, 7:14 PM · Plasma
filipf accepted D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage.
May 12 2020, 7:05 PM · Plasma
filipf added a comment to D29394: Add photographic user avatars.

Some pictures I didn't include in case people like them:


May 12 2020, 2:13 PM · Plasma
filipf updated the diff for D29394: Add photographic user avatars.
  • Remove all Unsplash and Pexels licensed photos to avoid complications.
  • Use CC0 pictures from Pexels instead
  • Licence files to be added
May 12 2020, 2:08 PM · Plasma
filipf added a comment to D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout.

Is this okay now @mart and okay to land on 5.18?

May 12 2020, 10:12 AM · Plasma

May 7 2020

filipf added a comment to D29394: Add photographic user avatars.

IANAL but the Pexels and Unsplash licence look the same to me: free to distribute, free to modify, no attribution needed, but don't use it to make a Pexels/Unsplash clone. Someone once noted that neither exists in some FOSS licence database. I'll just ask everyone to do CC0 but we'll still credit them. Thanks @ognarb and @jriddell.

May 7 2020, 6:21 PM · Plasma
filipf added a comment to D29501: Use left-aligned thickened panel with IOTM populated with some apps by default.

If user data would show low vertical panel usage, what are we really fixing and for who? Extrapolating from that and presuming that a fair share of them are content with the current default, why do we go against that? And if it's just a matter of not touching defaults, can you guarantee users are going to be equally content with a left panel as a default?

May 7 2020, 2:08 PM · Plasma
filipf added a comment to D29394: Add photographic user avatars.

After additional consideration, I'm not too happy with the car avatar but I did find this:

May 7 2020, 11:04 AM · Plasma
filipf added a comment to D29501: Use left-aligned thickened panel with IOTM populated with some apps by default.

I'd also be interested if KDE Promo has any insights here. It doesn't seem (?) like we advertise it too much, but I know reviews often praise Plasma for its familiarity for Windows users. Given our major competitor does the opposite and that the majority of our new users are going to be Windows converts (and keeping in mind that the less technologically able people tend to not like unfamiliarity), it seems like a good market share to grab. Changing the layout could mean a boost for other competitors such as Zorin. Thoughts?

May 7 2020, 7:52 AM · Plasma
filipf requested changes to D29501: Use left-aligned thickened panel with IOTM populated with some apps by default.

This is a major identity change better suited for Plasma 6. We've never had a vertical panel and are moreover defined by offering a layout familiar to Windows users.

May 7 2020, 6:08 AM · Plasma

May 5 2020

filipf accepted D29448: Add "Volna" wallpaper.
May 5 2020, 4:32 PM · Plasma
filipf requested changes to D29448: Add "Volna" wallpaper.

We only use the biggest size in this repo.

May 5 2020, 4:12 PM · Plasma

May 4 2020

filipf committed R119:52d3389f7495: [Wallpaper Configuration] Reword inline message concerning widget locking (authored by filipf).
[Wallpaper Configuration] Reword inline message concerning widget locking
May 4 2020, 11:25 PM
filipf closed D29366: [Wallpaper Configuration] Reword inline message concerning widget locking.
May 4 2020, 11:25 PM · Plasma
filipf added a comment to D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout.

Should I also land this for 5.18 (do I have to create a bug report first)?

May 4 2020, 11:23 PM · Plasma
filipf updated the summary of D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout.
May 4 2020, 11:22 PM · Plasma
filipf updated the diff for D29394: Add photographic user avatars.

Drop:

  • Air Balloon
  • Gamepad
May 4 2020, 10:42 PM · Plasma
filipf added a comment to D29394: Add photographic user avatars.

Great, that works. I suppose there's no point in fixing that bug since this KCM is being re-done anyway in D28154. Once this lands, @cblack can grab these and add them to that patch.

May 4 2020, 3:49 PM · Plasma
filipf updated the summary of D29366: [Wallpaper Configuration] Reword inline message concerning widget locking.
May 4 2020, 3:42 PM · Plasma
filipf updated the diff for D29366: [Wallpaper Configuration] Reword inline message concerning widget locking.

restore the inline message but change its text to note that layout changes have been restricted by the sysadmin

May 4 2020, 3:40 PM · Plasma
filipf updated the diff for D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout.

Replace PropertyAnimation with NumberAnimation

May 4 2020, 3:37 PM · Plasma
filipf added a comment to D29394: Add photographic user avatars.

Photo using the Unsplash license can't be included in our repositories. The license is not considered open-source :( We should contact the artists if they are willing to license their photographies under a creative commons license (not the noncommercial and the no edit one)

May 4 2020, 11:14 AM · Plasma
filipf updated the diff for D29394: Add photographic user avatars.

probably don't want to include the .directory file

May 4 2020, 6:53 AM · Plasma
filipf updated the diff for D29394: Add photographic user avatars.

Better file naming

May 4 2020, 6:52 AM · Plasma
filipf added a comment to D29394: Add photographic user avatars.

Alright, I believe the issue is with the fact that the avatar gallery is coded to always look for avatars in the system /usr/share dir as opposed to adjusting to testing conditions and using the local /usr/share dir.

May 4 2020, 6:49 AM · Plasma

May 3 2020

filipf added a comment to D29394: Add photographic user avatars.

The permissions are wrong if we do sudo make install (the photos folder ends up being root owned). But it doesn't show up with make install either. Will investigate more in the morning.

May 3 2020, 11:51 PM · Plasma
filipf added a comment to T9910: Revisit user avatar gallery images.

I've proposed some avatars in D29394.

May 3 2020, 11:01 PM · VDG
filipf added a revision to T9910: Revisit user avatar gallery images: D29394: Add photographic user avatars.
May 3 2020, 10:59 PM · VDG
filipf added a task to D29394: Add photographic user avatars: T9910: Revisit user avatar gallery images.
May 3 2020, 10:59 PM · Plasma
filipf added a comment to D29394: Add photographic user avatars.

Basketball: https://www.pexels.com/photo/basketball-net-2169302/ (Pexels licence)
Brushes: https://www.pexels.com/photo/abstract-art-artist-artistic-262034/ (CC0 licence)
Car: https://www.pexels.com/photo/action-asphalt-auto-racing-automobile-274974 (CC0 licence)
Cocktail: https://www.pexels.com/photo/sea-sky-beach-holiday-68672/ (CC0)
HotAirBalloon: https://www.pexels.com/photo/hot-air-balloon-on-mid-air-above-rock-formation-2893960/ (Pexels licence)
Joystick: https://www.pexels.com/photo/game-controller-159204/ (CC0 licence)
Keyboard: https://unsplash.com/photos/WzKPT0IuUrU (Unsplash licence)
Leopard: https://unsplash.com/photos/wYy3rvvgjAU (Unsplash licence)
Parrot: https://unsplash.com/photos/V9VDd-2s3aE (Unsplash licence)
RubikCube: https://unsplash.com/photos/liMvhbUq4Xg (Unsplash licence)
Sunflower: https://unsplash.com/photos/XtXdHH-Ib7c (Unsplash licence)
Shuttle: https://www.pexels.com/photo/flight-sky-earth-space-2159/ (CC0 licence)

May 3 2020, 10:59 PM · Plasma
filipf requested review of D29394: Add photographic user avatars.
May 3 2020, 10:58 PM · Plasma
filipf added a comment to D22700: Sync scaling DPI from Plasma to SDDM.

When I press the synchronize button, it looks like the -dpi 144 (scale x1.5) option makes the UI elements huge (feel like x2 scale or more):

May 3 2020, 5:30 PM · Plasma
l10n daemon script <scripty@kde.org> committed R242:29404ef10bd0: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme (authored by filipf).
[Plasmoid Heading] Draw the heading only when there is an SVG in the theme
May 3 2020, 5:07 PM
filipf committed R120:3f06349549c1: [System Tray] Always draw the highlight behind the icon (authored by filipf).
[System Tray] Always draw the highlight behind the icon
May 3 2020, 4:32 PM
filipf closed D29380: [System Tray] Always draw the highlight behind the icon.
May 3 2020, 4:32 PM · Plasma
filipf committed R242:1b1018e68703: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme (authored by filipf).
[Plasmoid Heading] Draw the heading only when there is an SVG in the theme
May 3 2020, 4:25 PM
filipf closed D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme.
May 3 2020, 4:25 PM · Frameworks
filipf updated the diff for D29380: [System Tray] Always draw the highlight behind the icon.

move the code change to CurrentItemHighlight.qml

May 3 2020, 12:59 PM · Plasma
filipf added reviewers for D29380: [System Tray] Always draw the highlight behind the icon: kmaterka, Plasma.
May 3 2020, 10:14 AM · Plasma
filipf requested review of D29380: [System Tray] Always draw the highlight behind the icon.
May 3 2020, 10:12 AM · Plasma
filipf added a comment to D27688: Set minimum window size.

Ah, I didn't realize that Kamoso had moved to invent. You need to change the remote to point to the new gitlab URL: git remote set-url origin git@invent.kde.org:kde/kamoso.git

Then arc land should work as normal.

May 3 2020, 9:00 AM
filipf committed R474:e924691dd15b: Set minimum window size (authored by filipf).
Set minimum window size
May 3 2020, 8:59 AM
filipf closed D27688: Set minimum window size.
May 3 2020, 8:59 AM
filipf added a comment to D29366: [Wallpaper Configuration] Reword inline message concerning widget locking.

Ok, so the message can indeed still be turned on.

May 3 2020, 7:32 AM · Plasma

May 2 2020

filipf added a comment to D29366: [Wallpaper Configuration] Reword inline message concerning widget locking.

Technically it still does exist, it's just hidden. If a person does enable this, perhaps the message is still nice to have? Or maybe we should not show it because the expectation would be that your admin/technically competent grandson has enabled it for your own good and this shouldn't be highlighted?

May 2 2020, 10:16 PM · Plasma
filipf requested review of D29366: [Wallpaper Configuration] Reword inline message concerning widget locking.
May 2 2020, 8:12 PM · Plasma
filipf added a comment to T13075: Move all things in Plasma to PC3, and then to QQC2.

Generally I think we can all agree on doing away with QQC1 and PC2, however...

May 2 2020, 7:17 PM · Goal: Consistency, VDG, Plasma
filipf added a comment to D27688: Set minimum window size.

I can't land this at all, do I have to clone from Invent?

May 2 2020, 8:17 AM

May 1 2020

filipf added reviewers for D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme: VDG, Plasma.
May 1 2020, 9:50 PM · Frameworks
filipf requested review of D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme.
May 1 2020, 9:49 PM · Frameworks
filipf added a comment to D29111: [applet] Port to Kirigami.PlaceholderMessage.

Yeah we shouldn't be mixing Kirigami with Plasma.

May 1 2020, 9:14 PM · Plasma
filipf updated the summary of D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout.
May 1 2020, 8:49 PM · Plasma
filipf updated the diff for D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout.

Ditch OpacityAnimator and use PropertyAnimation

May 1 2020, 8:48 PM · Plasma
filipf added a comment to D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout.

This kills the animation though... I found this comment in other code:
"//OpacityAnimator when starting from 0 is buggy (it shows one frame with opacity 1)"

May 1 2020, 8:43 PM · Plasma
filipf added reviewers for D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout: ngraham, cblack, Plasma.
May 1 2020, 8:30 PM · Plasma
filipf requested review of D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout.
May 1 2020, 8:29 PM · Plasma
filipf accepted D29341: [kcm/kwinrules] Improve export buttons.

Looks good and improves usability.

May 1 2020, 7:47 PM · KWin
filipf added a comment to D29333: Don't show an empty error dialog when canceling the sync password prompt.

Yeah, this is also an issue when clicking cancel on a password prompt in sddm-kcm's GHNS and when clicking Reset in the Advanced tab. And when canceling theme deletion an empty inline message pops up :/

May 1 2020, 5:40 PM · Plasma
filipf added a comment to D29307: Implement smallFont in Kirigami plugin.

How does this relate to D14562

May 1 2020, 7:52 AM · Plasma
filipf accepted D29296: [KCMs/Notifications] Port placeholder message to Kirigami.PlaceholderMessage.
May 1 2020, 7:21 AM · Plasma

Apr 30 2020

filipf abandoned D26636: [Widget Explorer] Work around bad kerning.

Should be fixed upstream https://bugreports.qt.io/browse/QTBUG-49646

Apr 30 2020, 8:52 PM · Plasma
filipf abandoned D26646: [Applet Configuration] Work around bad kerning in sidebar labels.

Should be fixed upstream https://bugreports.qt.io/browse/QTBUG-49646

Apr 30 2020, 8:51 PM · Plasma

Apr 28 2020

filipf added a comment to D29264: New tabs for Breeze.

I think we still want to have the edges rounded if it's possible?

Apr 28 2020, 7:10 PM · VDG, Breeze, Plasma
filipf added a comment to D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly.

LGTM

Apr 28 2020, 11:12 AM · Frameworks
filipf updated subscribers of T12724: Default Wallpapers.

It's a river structurally, but the colors are completely random. That's not case with Ice Cold, Volna, or Ken's older work like Canopee for instance. Just not my cup of tea and I don't see it as continuation of what we've had.

Apr 28 2020, 8:45 AM · VDG

Apr 26 2020

filipf added a comment to T12724: Default Wallpapers.

+1 to flow light
@filipf and @GB_2, would you be fine with flow light, or do you strongly prefer Vera?

Apr 26 2020, 5:34 AM · VDG

Apr 22 2020

filipf added a comment to T12724: Default Wallpapers.

I'd go with Vera for 5.19 and Altai for 5.20. Fits seasonal patterns for release periods for the northern hemisphere while being subversive for the southern one.

Apr 22 2020, 1:03 PM · VDG

Apr 20 2020

filipf added a comment to T13008: Figure out a good UI for the "show which settings have been changed" feature.

I think the discussion should ideally start from data on users and the settings they change the most. If the data would show visual changes dominating (which I suspect to be true), indicators won't serve much of a purpose because it tends to be pretty obvious when non-default visual settings are used. The settings are also the easiest to find, I would say.

Apr 20 2020, 9:02 PM · Plasma, VDG

Apr 19 2020

filipf added a dependency for D25728: [Applet Configuration] Don't draw a separator between the titlebar and window: D27669: [kstyle] Tools area.
Apr 19 2020, 7:09 PM · Plasma