- User Since
- Aug 15 2018, 7:18 AM (74 w, 5 d)
Sat, Jan 18
I think what Noah means is that the media controls row should perfectly touch the left, right and bottom border. The margins in this patch are too big so they effectively create another frame in a frame.
Fri, Jan 17
Mon, Jan 13
- make it work with multi line strings
- restore side margins
Oops, looks like it breaks those smallSpacing margins as well:
don't repeat the same code twice
remove added whitespace
Wed, Jan 8
Good idea +1. I think an author's name is enough here since information is displayed in a similar way that songs info is ie. it should be obvious to everyone the second line lists the author.
Sat, Jan 4
Thu, Jan 2
Mon, Dec 30
Wed, Dec 25
Mon, Dec 23
remove tabbar frame
Going to have to be a no from me since the lack of font anti-aliasing looks pretty bad with darker color schemes. Not sure if it's worth it to report the bug to Qt.
Sat, Dec 21
Dec 20 2019
Dec 15 2019
Dec 14 2019
Ping, anyone know if we can just delete this Rectangle I called "frame"?
Don't want to go through with this anymore because I've had a look at other views and they always sharply cut off content vertically. For example:
- Use grid delegate subtitle to state "Follows color scheme"
- Consequently remove the icon tooltip that said the same
^ No, it seems to be GridDelegate actually.
Thanks, I'll tweak my patch to use this.
There might be an unfortunate side effect: https://forum.qt.io/topic/57634/qt-wa_alwaysstackontop-influences-font-rendering-in-qml/5
Dec 13 2019
- downgrade Rectangle to Item since we don't need anything fancy anymore (good tip @ngraham)
- remove old hack comment
Looks good. I just realized that maybe the message at the top could be an info inline message, but I see how that could be too much.
Dec 11 2019
Let's track the arrow issue in: https://bugs.kde.org/show_bug.cgi?id=415049
Still works for Adwaita:
Dec 9 2019
Thanks again :)
Thanks! It will be easier to test now.
Yeah, PC2 ToolButton has this so it loads the arrow: https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ToolButtonStyle.qml#L110
I agree, I think brighter and slightly less saturated colors would look nice.
I think this is useful. Every once in a while we get opinionated people who think light separators are awful in the Breeze Dark scheme (I would hate dark ones on the other hand) or even some ricer people who want to turn off separators (which they could do now by matching it with window color I guess).
Dec 8 2019
This is the wallpaper in question:
Dec 7 2019
Dec 6 2019
Yeah, that might not be a bad idea. Our GridDelegates do not support more than 1 line of text right now if I'm not mistaken though.
Dec 5 2019
+1 from me as well for the reasons listed in the commit message
Dec 4 2019
add space before final )
define condition without creating a variable
don't break the sidebar
So we also fix this by setting:
I just realized this kills the sidebar when there's more than 1 kcm under a category :(