filipf (Filip Fila)
Design

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 15 2018, 7:18 AM (57 w, 4 d)
Availability
Available

Recent Activity

Fri, Sep 20

filipf updated the diff for D23378: Check if sddm user exists.

Address David's comment, remove one entry from the map

Fri, Sep 20, 3:10 PM · Plasma

Thu, Sep 19

filipf added a comment to D23378: Check if sddm user exists.

How about refactoring this "does SDDM user exist?" check into a function so we don't have to write virtually the same code three times?

Thu, Sep 19, 6:27 PM · Plasma

Wed, Sep 18

filipf added a comment to T10243: Some KDE applications could use better icons.

Yeah, an app's icon is a part of its branding. It should look distinctive, not generic. Ideally it communicates both its purpose ("I'm a text editor!") as well as its identity ("I'm Kate!"). I think the problem with some of these icons is that they only do the former, not the latter. I don't think there is a conflict here, though!

Wed, Sep 18, 6:59 PM · KDE Applications, VDG

Tue, Sep 17

filipf added a comment to T9578: Publish Okular in the Microsoft Store.
In T9578#201151, @aacid wrote:

Adding VDG for comment.

Tue, Sep 17, 11:09 PM · Okular, Windows

Mon, Sep 16

filipf added reviewers for D24009: RFC: Make Breeze Dark darker: cblack, ndavis, VDG, ngraham, Plasma.
Mon, Sep 16, 9:55 PM · Plasma
filipf requested review of D24009: RFC: Make Breeze Dark darker.
Mon, Sep 16, 9:54 PM · Plasma
filipf added a comment to D23257: Allow for easier syncing of Plasma font.

So the SDDM patch has been merged, but I don't know when the next SDDM release will be. I would keep this on hold until this happens, just to be safe... does that make sense?

Mon, Sep 16, 9:00 PM · Plasma
filipf added a comment to D23798: Polish Displays KCM UI.

What I'm seeing in the screenshot is that the two form layouts aren't aligned. Can you interlink them with twinFormLayouts?

Mon, Sep 16, 8:41 PM · Plasma
filipf added a comment to T11558: kill plasma components in favour of QtQuickControls2 + kirigami.

In general I would also like to see this happen, but it would be nice to preserve theming capabilities or at least making QML styles easier.

Mon, Sep 16, 8:29 PM · Plasma, KF6
filipf added a comment to D21815: [sddm-theme] Start moving from QQC1 to QQC2.

Yo @cblack I think you can land this.

Mon, Sep 16, 8:26 PM · Plasma
filipf added a comment to D23984: Redesign intro page.

+1 for redesigning the page a bit. What I really dislike about it right now is that there is no hover effect for the icons.

Mon, Sep 16, 11:53 AM · VDG, Plasma

Wed, Sep 11

filipf planned changes to D23876: [applets/kickoff] Tweak padding for lists.

Better, but now the padding is inconsistent between the sides and bottom:

Wed, Sep 11, 10:19 PM · Plasma
filipf added reviewers for D23876: [applets/kickoff] Tweak padding for lists: VDG, Plasma, ngraham.
Wed, Sep 11, 2:42 PM · Plasma
filipf requested review of D23876: [applets/kickoff] Tweak padding for lists.
Wed, Sep 11, 2:41 PM · Plasma

Tue, Sep 10

filipf updated subscribers of T11579: Unify navigation through sidebar categories/views.
Tue, Sep 10, 11:00 AM · Consistency, KDE Human Interface Guidelines, VDG

Mon, Sep 9

filipf accepted D23803: [Folder View] Add subtle shadows to icons.

Tried it out, I like the way it looks.

Mon, Sep 9, 5:02 PM · Plasma
filipf added a comment to D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays.

Yikes, we need to fix that.

Mon, Sep 9, 4:18 PM · Plasma
filipf added a comment to D23798: Polish Displays KCM UI.

What are "Values of an output"? I don't understand what these 2 settings do.

Mon, Sep 9, 3:42 PM · Plasma

Thu, Sep 5

filipf committed R169:9af92cc8b750: [Separator] Match Breeze borders' color (authored by filipf).
[Separator] Match Breeze borders' color
Thu, Sep 5, 9:39 PM
filipf closed D22106: [Separator] Match Breeze borders' color.

Phab hasn't picked up on the commit: https://cgit.kde.org/kirigami.git/commit/?id=9af92cc8b750b59629eeb3446108b2f8086629f7

Thu, Sep 5, 9:23 PM · Kirigami

Wed, Sep 4

filipf added a comment to D23651: WIP: Add support for a theming in Kicker Dashboard.

I would also think a bit more about using Kirigami.SearchField -> it's not used in Kickoff and it's not properly themable (the same way PlasmaComponents.TextField is).

Wed, Sep 4, 11:22 AM · Plasma
filipf added a comment to D23651: WIP: Add support for a theming in Kicker Dashboard.

What I'm seeing is that this could result in poor visibility of action buttons.

Wed, Sep 4, 11:18 AM · Plasma

Tue, Sep 3

filipf added a comment to D23712: [Cuttlefish] Overhaul program, use Kirigami.

This is pretty great, the old version was buggy. One question: can we enforce a minimum width on the whole window?

Tue, Sep 3, 10:44 PM · Plasma

Mon, Sep 2

filipf committed R123:4b2171bb3db3: Add a warning message about needing globally installed theme files (authored by filipf).
Add a warning message about needing globally installed theme files
Mon, Sep 2, 9:55 PM
filipf closed D23308: Add a warning message about needing globally installed theme files.
Mon, Sep 2, 9:55 PM · Plasma

Sun, Sep 1

filipf added a comment to D23627: Make notification icons use outline style.

+1, looks good, thanks for centering the clapper as well

Sun, Sep 1, 10:53 AM · Frameworks

Sat, Aug 31

filipf updated the diff for D23308: Add a warning message about needing globally installed theme files.
  • remove "in the root directory"
Sat, Aug 31, 10:45 PM · Plasma
filipf added inline comments to D23308: Add a warning message about needing globally installed theme files.
Sat, Aug 31, 10:02 AM · Plasma
filipf added inline comments to D23308: Add a warning message about needing globally installed theme files.
Sat, Aug 31, 9:57 AM · Plasma

Fri, Aug 30

filipf updated the diff for D23378: Check if sddm user exists.

Rebase on master

Fri, Aug 30, 2:25 PM · Plasma
filipf updated the diff for D23257: Allow for easier syncing of Plasma font.

Rebase on master

Fri, Aug 30, 2:24 PM · Plasma
filipf updated the diff for D23308: Add a warning message about needing globally installed theme files.

Rebase on master (hopefully)

Fri, Aug 30, 2:22 PM · Plasma
filipf committed R123:245b2a8a55af: Remove leftover mentions of "AdvanceConfig" (authored by filipf).
Remove leftover mentions of "AdvanceConfig"
Fri, Aug 30, 2:18 PM
filipf committed R123:798ef2ac8246: Rename "AdvanceConfig" to "AdvancedConfig" (authored by filipf).
Rename "AdvanceConfig" to "AdvancedConfig"
Fri, Aug 30, 2:14 PM

Sun, Aug 25

filipf accepted D23449: Capacity degradation -> Battery health.

I was okay with the degradation as well, but if users are saying they want to have the same value as in other DEs/OSs, health seems like a good compromise. It's commonly used to describe the state of SSDs I think so it should be familiar to people.

Sun, Aug 25, 7:43 PM · Plasma
filipf accepted D23415: Improve comprehensibility and consistency of window placement mode names.

FWIW I didn't know what "smart" or "zero-cornered" actually meant before seeing this patch. These new strings seem more user-friendly to me.

Sun, Aug 25, 7:39 PM · Documentation, KWin

Aug 23 2019

filipf accepted D23379: Improve charge capacity/level strings.
Aug 23 2019, 3:35 PM · Plasma
filipf updated the diff for D23378: Check if sddm user exists.

add qDebug info in auth helper

Aug 23 2019, 3:26 PM · Plasma
filipf updated the diff for D23378: Check if sddm user exists.

also apply the check for the auth helper

Aug 23 2019, 3:17 PM · Plasma
filipf added reviewers for D23378: Check if sddm user exists: Plasma, davidedmundson, ngraham, VDG.
Aug 23 2019, 3:01 PM · Plasma
filipf requested review of D23378: Check if sddm user exists.
Aug 23 2019, 2:59 PM · Plasma
filipf added a comment to D20972: [sidebar] Make search field not glued to the separator.

D23274 makes this unnecessary.

Aug 23 2019, 11:58 AM · Plasma
filipf resigned from D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon and improve presentation.

I forgot I was using the La Capitaine icon theme so the above doesn't apply in the sense of now working well with defaults. Seems OK with Breeze.

Aug 23 2019, 7:23 AM · Plasma
filipf requested changes to D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon and improve presentation.

Tested on 5.16 so disregard the other changes:

Aug 23 2019, 7:17 AM · Plasma

Aug 22 2019

filipf updated the task description for T11093: Improve Consistency across the Board.
Aug 22 2019, 9:28 PM · Consistency, Goal Setting 2019
filipf added a comment to T7246: User Manager.
In T7246#196142, @GB_2 wrote:

@nicolasfella any progress in this? can you please do it in-place in a branch like @davidedmundson said?

Aug 22 2019, 3:48 PM · Plasma: KCM Redesign

Aug 21 2019

filipf accepted D21815: [sddm-theme] Start moving from QQC1 to QQC2.
Aug 21 2019, 10:51 PM · Plasma
filipf added a comment to D23322: Add new touch-friendly drag handlers.

Can you add some before & after screenshots (or vids) for VDG ?

Aug 21 2019, 4:29 PM · Spectacle

Aug 20 2019

filipf accepted D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.

I don't know if there would be some use in keeping sessionsModel.canStartNewSession && sessionsModel.canSwitchUser around, but the button should always be visible (when technically possible I guess).

Aug 20 2019, 9:42 PM · Plasma
filipf added a comment to D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.

What if someone else is logged in, they locked their screen and I want to switch the session?

Or are you thinking with a multi-user system where user A logs in and locks the screen, and then user B wants to log in? Hmm.

Aug 20 2019, 9:06 PM · Plasma
filipf added a comment to D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown.

What if someone else is logged in, they locked their screen and I want to switch the session?

Aug 20 2019, 8:51 PM · Plasma
filipf added reviewers for D23308: Add a warning message about needing globally installed theme files: Plasma, davidedmundson, VDG, ngraham.
Aug 20 2019, 8:38 PM · Plasma
filipf requested review of D23308: Add a warning message about needing globally installed theme files.
Aug 20 2019, 8:37 PM · Plasma
filipf added a comment to D23286: Prevent dragging SimpleKCM contents outside view.

+1 visually

Aug 20 2019, 8:54 AM · Frameworks
filipf added a comment to D21815: [sddm-theme] Start moving from QQC1 to QQC2.

LGTM in use. The only thing I'd ask you to do is add font.pointSize: config.fontSize to both of the QQC2.Labels you were working on. SDDM defaults to 9pt font sizes; we need to override that so it's 10pt (same as the Plasma default).

Aug 20 2019, 8:38 AM · Plasma
filipf accepted D23271: [Battery Monitor] Call battery capacity "Capacity degradation" for better clarity.

+1, same reasoning as in D23270#514978.

Aug 20 2019, 8:23 AM · Plasma
filipf accepted D23270: [Energy] Put battery capacity info in battery section and call it "Capacity degradation".

Both changes make sense to me.

Aug 20 2019, 8:22 AM · Plasma
filipf accepted D23285: Prevent dragging QQC2 ComboBox contents outside menu.
Aug 20 2019, 8:16 AM · Plasma

Aug 19 2019

filipf added a comment to D23257: Allow for easier syncing of Plasma font.

Does anything bad happen if the users uses this with a version of SDDM that doesn't support it yet, or does the new item in the config file just get ignored?

Aug 19 2019, 8:00 PM · Plasma
filipf updated the test plan for D23257: Allow for easier syncing of Plasma font.
Aug 19 2019, 12:48 PM · Plasma
filipf added a comment to D23257: Allow for easier syncing of Plasma font.

Either SDDM code should deserialize the font (so that the italics and sizes and such work)

Aug 19 2019, 10:17 AM · Plasma
filipf added reviewers for D23257: Allow for easier syncing of Plasma font: ngraham, Plasma, davidedmundson.
Aug 19 2019, 8:40 AM · Plasma
filipf requested review of D23257: Allow for easier syncing of Plasma font.
Aug 19 2019, 8:38 AM · Plasma

Aug 18 2019

filipf accepted D23237: Do not display vendor, Product and capacity in network plasmoid.
Aug 18 2019, 8:25 PM · Plasma

Aug 12 2019

filipf added a comment to D23106: Allow the user to select the JPEG save/compression quality.

I believe I've just recently had some noticeable image quality loss after doing a save in Gwenview; the fact that it would happen was unbeknownst to me.

Aug 12 2019, 8:48 PM · Gwenview
filipf added a comment to D23075: Change default Dolphin toolbar layout.
In D23075#510697, @GB_2 wrote:


This is my final proposal with a category structure.

Aug 12 2019, 11:25 AM · VDG, Dolphin

Aug 10 2019

filipf committed R123:c1c4e03b0003: Minor code improvements (authored by filipf).
Minor code improvements
Aug 10 2019, 7:45 PM
filipf closed D22981: Minor code improvements.
Aug 10 2019, 7:45 PM · Plasma
filipf committed R120:770f620a2126: Merge branch 'Plasma/5.16' (authored by filipf).
Merge branch 'Plasma/5.16'
Aug 10 2019, 7:45 PM
filipf committed R120:953f72e42f6c: [lockscreen] Fit album art to defined geometry (authored by filipf).
[lockscreen] Fit album art to defined geometry
Aug 10 2019, 7:43 PM
filipf closed D23063: [lockscreen] Fit album art to defined geometry.
Aug 10 2019, 7:43 PM · Plasma

Aug 9 2019

filipf added reviewers for D23063: [lockscreen] Fit album art to defined geometry: Plasma, VDG, ngraham.
Aug 9 2019, 11:09 PM · Plasma
filipf requested review of D23063: [lockscreen] Fit album art to defined geometry.
Aug 9 2019, 11:08 PM · Plasma

Aug 7 2019

filipf updated the diff for D22981: Minor code improvements.

also show debug output if scaling DPI is not found

Aug 7 2019, 2:17 AM · Plasma
filipf added reviewers for D22981: Minor code improvements: davidedmundson, ngraham, Plasma.
Aug 7 2019, 1:23 AM · Plasma
filipf requested review of D22981: Minor code improvements.
Aug 7 2019, 1:21 AM · Plasma

Aug 2 2019

filipf committed R120:cd027ce844ed: [applets/notifications] Try to not have the notification count numbers overflow… (authored by filipf).
[applets/notifications] Try to not have the notification count numbers overflow…
Aug 2 2019, 3:30 PM
filipf closed D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon.
Aug 2 2019, 3:30 PM · Plasma
filipf added a comment to D22896: Port System Settings sidebar to QQC2.

If it would be draining to do now, we can leave that menu at QQC1 and add a note pointing to a bug report?

Aug 2 2019, 3:22 PM · Plasma
filipf accepted D22830: [kcmkwin/kwineffects] Rework the Effects KCM.

Nice work.

Aug 2 2019, 8:54 AM · VDG, KWin

Aug 1 2019

filipf accepted D22886: [kcmkwin/kwindecoration] Slightly improve tab bar's integration with frame.
Aug 1 2019, 10:40 PM · KWin
filipf committed R119:5c0ec75f7ce1: [kcms/nightcolor] Minor UI tweaks to the KCM (authored by filipf).
[kcms/nightcolor] Minor UI tweaks to the KCM
Aug 1 2019, 10:08 PM
filipf closed D22863: [kcms/nightcolor] Minor UI tweaks to the KCM.
Aug 1 2019, 10:08 PM · Plasma
filipf added a comment to D22882: [Energy] Improve signal-to-noise ratio of battery information.

I check up on Full Design to track precise wear, and the Capacity is also pretty standard info and useful.

Aug 1 2019, 9:27 PM · Plasma
filipf added a comment to D22882: [Energy] Improve signal-to-noise ratio of battery information.

I think what Capacity means is how worn out your battery has become. Yours can still take the full charge so it's at 100% (jealous).

Aug 1 2019, 9:25 PM · Plasma
filipf updated the test plan for D20972: [sidebar] Make search field not glued to the separator.
Aug 1 2019, 8:46 PM · Plasma
filipf updated the diff for D20972: [sidebar] Make search field not glued to the separator.

use 2px instead of 1px of padding

Aug 1 2019, 8:45 PM · Plasma
filipf added a comment to D20972: [sidebar] Make search field not glued to the separator.

2px looks better to me as well, let's add 1px more to the margin in Discover then?

Aug 1 2019, 8:43 PM · Plasma
filipf added a comment to D20972: [sidebar] Make search field not glued to the separator.

@ngraham I forgot about RTL, my bad.

Aug 1 2019, 8:42 PM · Plasma
filipf updated the test plan for D20972: [sidebar] Make search field not glued to the separator.
Aug 1 2019, 8:40 PM · Plasma
filipf updated the diff for D20972: [sidebar] Make search field not glued to the separator.

watch out for RTL

Aug 1 2019, 8:38 PM · Plasma
filipf accepted D22871: Use better Workspace Behavior KCM title and icon.

Looks OK, along with these two inline comments I'd also add some reasoning for the change to the commit message.

Aug 1 2019, 8:04 PM · Documentation, Plasma
filipf added a comment to D19947: systray: show a small animation on the icons when activated.

The effect doesn't always work for me.

Aug 1 2019, 8:00 PM · Plasma
filipf updated the diff for D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon.

better code

Aug 1 2019, 6:32 PM · Plasma
filipf accepted D18419: Move KCMs in "Workspace Theme" to more appropriate locations.

+1 regarding the Cursor Theme and Plasma Theme, but it doesn't make sense to me that Splash Screen will be in Appearance, while Login Screen (SDDM) will be in Startup and Shutdown.

I guess we have a small conflict then when something is both purely appearance-based, but also fits into multiple categories. The Splash Screen, Plymouth, and the SDDM KCMs all fit the bill. My gut tells me that you're right and all three should live in Startup and Shutdown just based on frequency of use.

Aug 1 2019, 5:33 PM · Plasma
filipf added a comment to D18419: Move KCMs in "Workspace Theme" to more appropriate locations.

+1 regarding the Cursor Theme and Plasma Theme, but it doesn't make sense to me that Splash Screen will be in Appearance, while Login Screen (SDDM) will be in Startup and Shutdown.

Aug 1 2019, 4:56 PM · Plasma
filipf updated the test plan for D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon.
Aug 1 2019, 4:22 PM · Plasma
filipf updated the test plan for D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon.
Aug 1 2019, 4:20 PM · Plasma
filipf added reviewers for D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon: broulik, Plasma, VDG.
Aug 1 2019, 4:18 PM · Plasma
filipf requested review of D22878: [applets/notifications] Try to not have the notification count numbers overflow the icon.
Aug 1 2019, 4:17 PM · Plasma