- User Since
- Aug 15 2018, 7:18 AM (65 w, 1 d)
Mon, Nov 11
continued in D25252
I'm not seeing any binding loop warnings when testing this fwiw.
Sat, Nov 9
Yeah you guys are right. I tested this further and still got some binding loop errors with paintedWidth/Height.
Fri, Nov 8
Thu, Nov 7
There's definitely a difference, whereas the shadows are now rough and dark this is subtler.
Wed, Nov 6
I'd prefer the shadows to have equal strength all around, I couldn't get used to weaker shadows in the corners.
Tue, Nov 5
Mon, Nov 4
Would this be an acceptable change for the 5.17 branch?
Might also be worth mentioning this now makes it consistent with sidebar view, which doesn't use this emblem.
Sun, Nov 3
Sat, Nov 2
I don't think worsening text legibilty with some themes is a good feature for an LTS release.
Tue, Oct 29
Not a fan of this for 2 reasons:
- we have no control over color schemes; they might have dumb values for this color; in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme:
Mon, Oct 28
@davidedmundson I believe you wrote the code for the the avatar size in the lock and login screens (property real faceSize: Math.min(width, height - usernameDelegate.height - units.smallSpacing).
Tested the patch and it no longer accepts strings or values under 24.
Testing it. Usability wise the strength is perfectly fine; the shadows still do their job.
Yeah there is a conceptual issue here we need to look into solving. IMO we should just always have white UI elements and the background dimmed.
Admittedly this doesn't look super fortuate either when the wallpaper is darker:
also apply the same fix to the login screen
Sun, Oct 27
I'd go with 80% opacity. That's not the trendy value, lower opacity values are. Text will be legible but the aesthetics are improved.
Thu, Oct 24
Wed, Oct 23
also make the effect appear on activeFocus (tabbing)
Mon, Oct 21
Makes sense. It's unrelated to this patch but what's up with the double message ("No space on device left" and "not enough free disk space") here?
Everything should work fine now hopefully.
- pin button now appears in the "Status and Notifications" popup again
- simpler code for checking layout mirroring
Based on a search of some examples of RTL UI settings I'm going to say headings also go on the right side, so it seems they were actually not correctly placed before.
The latest version already works with RTL without the fillWidth code being needed. So as far as I can tell the diff you posted only effectively removes the margins from headings. But I think we should keep them, i.e., align those headings with the container (@GB_2 already mentioned this : D24720#548745)
restore original margin between sidebar and container
Sun, Oct 20
Thu, Oct 17
So much nicer, awesome work. +1 for the visuals of the rehauled kcm.
make all this work right with RTL layouts
Agreed, let's not change the padding.
don't alter padding
The paddings issue is actually the same as with notifications (D21813). We can tweak it here and then alter it for all desktop themes, some of which already add extra padding on their own. This means we're messing with their looks.
Do we have a green light for 5.17.1? How do I tag the translators?
Yeah, can't get this to work properly anyway.
Wed, Oct 16
remove useless leftover stuff from WIP versions