This adds a search bar to search for schemes in the list as well as a filter to show only light or dark themes using a heuristic on the theme's window color.
- Group Reviewers
- R119:a1fbeb96dc6c: [Colors KCM] Add search and filter
Should the filter be cleared when you install a new theme to avoid it being hidden by a filter?
An alternative would be
which is a lot more obvious than a tiny filter icon. Your decision, also whether it should highlight when filtered or not (it does not in Widget Explorer where I took this from)
I would prefer this, but with the filter being a real combobox. In other words, I'd like the following changes:
- Button should not be flat; should draw the button border (we only put flat buttons in toolbars)
- The button should have a downward-pointing arrow to indicate that it's a combobox
- The pop-up doesn't need radio buttons bu the menu items
If I could change the left padding of the ComboBox button I would have done that and placed an icon ontop. However, since it's all painted as a monolith by KQuickStyleItem I cannot.
It doesn't follow the padding properties because it's all derived from the QStyle, and changing that opens a can of worm imho.
The selectedSchemeIndex stuff doesn't take into account the filtering, so the highlight is wrong when filtering and also when marking a theme for deletion the index changes to the next one but might end up applying a currently invisible theme..