Differential D28985

[Kickoff] Disable tabBar's mouseArea when searching
ClosedPublic
Actions

Authored by trmdi on Apr 19 2020, 4:12 PM.

Details

Reviewers
hein
ngraham
davidedmundson
Group Reviewers
Plasma
Commits
R119:020c67fc8ba3: [Kickoff] Disable tabBar's mouseArea when searching
Summary

When the root is in the "Search" state, we can safely disable it.

BUG: 401861

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trmdi created this revision.Apr 19 2020, 4:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 19 2020, 4:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
trmdi requested review of this revision.Apr 19 2020, 4:12 PM
trmdi edited the summary of this revision. (Show Details)Apr 19 2020, 4:18 PM
GB_2 awarded a token.Apr 19 2020, 4:40 PM
dginovker added a subscriber: dginovker.Apr 19 2020, 4:47 PM

Hi - I'm the original bug reporter, hopefully I'm allowed to comment here. The patch provided works, tested on 2 machines running Manjaro KDE :)

bugseforuns added a subscriber: bugseforuns.Apr 19 2020, 6:48 PM

Patch also working on Neon unstable edition. :)

ngraham accepted this revision.Apr 19 2020, 8:18 PM
ngraham added a subscriber: ngraham.

Excellent!

Please land on the Plasma/5.18 branch and then merge to master. Let me know if you need a hand with that.

This revision is now accepted and ready to land.Apr 19 2020, 8:18 PM
davidedmundson requested changes to this revision.Apr 19 2020, 9:03 PM
davidedmundson added a subscriber: davidedmundson.

I don't understand.

Why is the search page a special case that should affect the tab bar behaviour?

This revision now requires changes to proceed.Apr 19 2020, 9:03 PM
davidedmundson resigned from this revision.Apr 19 2020, 9:25 PM

Ah, I see.

name: "Search"
      PropertyChanges {
          target: tabBar
          opacity: 0
      }

It's opacity zero, but technically still visible, still enabled and with the same valid size. That sounds super weird :/
But it means our mousearea is active and now I understand why you're saying it shouldn't be. Gotcha (in future longer commit messages can help make reviewing a bit faster)

Surely then it'd still be active in the tabfocus chain too? And our property change should update enabled on tabbar too?

davidedmundson accepted this revision.Apr 19 2020, 9:25 PM
This revision is now accepted and ready to land.Apr 19 2020, 9:25 PM
trmdi added a comment.Apr 20 2020, 2:10 PM
In D28985#652097, @ngraham wrote:

Excellent!

Please land on the Plasma/5.18 branch and then merge to master. Let me know if you need a hand with that.

Yes, please. I don't know how to do that.

ngraham added a comment.Apr 20 2020, 2:15 PM

Actually not that I think about it, I'd teach you how, but since we're moving to GitLab in a few weeks, it would be a useless skill so I'll just do it now. :)

Closed by commit R119:020c67fc8ba3: [Kickoff] Disable tabBar's mouseArea when searching (authored by trmdi, committed by ngraham). · Explain WhyApr 20 2020, 2:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 80650

View Options

applets/kickoff/package/contents/ui/FullRepresentation.qml

Loading...