- User Since
- Apr 9 2019, 9:23 AM (14 w, 4 d)
Thu, Jul 18
Tue, Jul 16
How about only making security update notifications persistent? There is no real harm in missing non-security updates in my opinion.
Sat, Jul 13
+1 for the idea. Dolphin is often used to differentiate between drives so having the format option right there would be kool.
Should it open the KDE Partition Manager?
Looks great overall!
I just want to nitpick that the top-right search bar doesn't align with the sidebar. Adding the class "mr-3" to the form and setting the .form-control width to 255px seems to have aligned them for me but that is maybe not the right solution.
Tue, Jul 9
Use classes "list-unstyled m-0 p-0"
Mon, Jul 8
I think the dropdown menu for the language selection might be too hard to spot if an unknown language is displayed.
Add RSS feed with recent blog posts and change wording to "Community blog posts"
Thu, Jul 4
Wed, Jul 3
Change "News from KDE contributors" to "News from contributors"
Change wording like @skadinna suggested - this time for real
Oops, I'll try that again.
Change wording like @skadinna suggested
Tue, Jul 2
I don't have commit access. Would one of you land it for me please?
Sun, Jun 30
Change "timeoutInS" to "timeoutInSeconds" and add const
I thought non-integer values could not be entered because typing a dot is not possible for me. Comma works though.
Do not use ceil until the first integer was reached
This way when a non-integer value like 4,5 seconds is entered
it won't show 5 seconds in the title for the first .5 seconds of
I also made the math more easily understandable by extracting
calculations into separate lines.
I would agree with that but the UI only allows for integer values as a timeout right now.
Sat, Jun 29
There are two different scenarios for sidebars explained in T11093: Consistency. Just to be clear: This task is only about the second one right? I would tend to think these can be viewed as separate issues for now (roughly quoting @niccolove):
Use i18ncp and have "second/s" instead of an "s"
Tue, Jun 25
Make seconds localized
I actually tried to research if "s" is an international
symbol and it seemed to me like it was
but I trust your call on this.
What do you say it is down to one line now! Your latest changes really helped there.
I would have created this diff sooner but it's way too hot in my room and I had to rebuild all dependencies because I switched to developing in a virtual machine. So I was delaying this but seeing that it won't be cooler anytime soon I took this burden on me. :P
Rebase to master
Thanks for fixing this!
I would have hoped for an apology at this point but it seems like you didn't mind belittling me. Instead you go right ahead and write another passive aggressive comment belittling me again. I try to argue about the subject matter and you ignore my arguments.
You seem to have some misconceptions about tor and onion services and the properties you get with each of them. I would be glad to clear them up.
If you would be able to identify any misconceptions on my part I'd hope you would have already pointed them out to me. Actually it is obvious to me that you don't understand the subject matter at all. I already had some of the evidence for this written out but then I noticed that it is mostly off topic and there is no point arguing with someone who ignores arguments.
Mon, Jun 24
So I'll first address the personal attacks by @lavender and then go back to subject.
Sun, Jun 23
Remove trailing whitespaces
This does sound like it could be a good solution. I am not quite sure if I am picturing this correctly.
I don't have commit access. Can you land the patch for me, per favore? :)
Thu, Jun 20
I don't think Konqi should be called a banker when wearing a suit. It doesn't fit the collaborative non-profit nature of KDE. I think Boss Konqi is alright. Business Konqi can work too.
Excuse me for not making these small changes and sentence restructuring sooner. Re-reading my help messages brought different details to my attention.
Start help message for "Show hidden places" with "This"
Unify sentence structure and add requested space
Sentences should start with "This does/is/etc." for
better intelligibility if possible instead of using
the imperative or omitting the subject.
Jun 15 2019
This would allow KDE sites to be reached without reaching the tor network.
But for now I'll wait until D21638: Display delay in the taskmanager has landed and I'll rebase to master then.
Jun 14 2019
The following text has become longer than I intended to. I will put it somewhere else if it is seen as off-topic. I have been thinking about this for a while and I want to get it out there because I think it might be a solution to multiple problems.
Jun 13 2019
I think merging would be a good idea.
I agree that the indicator doesn't need to be prominent. Because of the notification history it won't be lost if one misses it anyway. I am content with the way it is.
Jun 8 2019
Is there something special about it?
Not really. It is a desktop computer with seven year old hardware. It is not even that slow and granted that the bug doesn't happen in a virtual machine on this machine it doesn't seem to have anything to do with speed anyway. It has Kubuntu 18.04 installed though so maybe some interaction between the taskmanager or panels and the up to date spectacle leads to the needed delay.
I don't see a bug report for it so it might really just be a local issue.
And for me it hides itself in time as it should
This diff successfully fixes the indefinite hiding of the main window for me but now there is not enough time for the main window to hide in the task bar so the task bar always contains spectacle.
Jun 7 2019
I like that idea! Maybe you can do a patch for that? :)
That's what I've been trying the last hour :D But I am quite new to Qt and kinda failing miserably so far. I'll keep trying.
I have never done a review before and I feel like I am going a bit over the top with the testing here. But it's too late now. :)
Jun 2 2019
May 31 2019
May 29 2019
Ellipsis seems to be the best option then. Thanks for convincing me!
May 28 2019
The "Indeterminate" state is most often represented by a square. Maybe we should do the same? That being said I didn't find a location where this state is actually used.
I felt like the check mark might be a bit small so I made a bigger version as a test. I think I like it better this way but yours looks good already.
May 27 2019
I was already thinking about working on explicitly setting or not setting this flag at the right places. In particular I was thinking about dynamically changing this flag depending on the page in the system settings one is currently viewing so users don't get frustrated when no help is available for the current one.
Though concerning Dolphin the only windows that use "What's This?" seem to be Settings/Configure Shortcuts... and Help/Report Bug... and those aren't specific to Dolphin.
Change "all its contents" to "most of its contents"
Patch looks almost ready now.
May 20 2019
Rebased to current master
Applied all the requested changes
May 14 2019
Apr 14 2019
Fix typos: informations -> information