- User Since
- Apr 9 2019, 9:23 AM (23 w, 3 d)
Thu, Sep 12
Some of the VDG people seem to be in favour of approach 1/1b and I think it definitely can work. But so far I still think having 2 as the basis is the best way forward. Here is a mockup that expands on 2 and @fabianr's comment.
Sat, Sep 7
Oh okay. I understand. I only referred to the arrow removing step then.
Thanks for the analysis :) I still think we should get the change in with the current KToolBarPopupAction functionality (like Nate suggest), and then work on refining the user experience. But feel free to pinch in on the user experience part.
This is such a big discussion already. Which suggestion of Nate do you refer to specifically? I thought the current approach that shows indicators was denied.
Mon, Sep 2
Current (?) one for comparison (from Kubuntu 18.04 since the one from Neon Unstable crashes for me)
I feel like there was a lot of thought put into the current design of the dashboard and the search field in particular:
- It does fit the style of having different logical parts of the dashboard purely divided by white space (and not by borders, lines).
- It makes very clear that typing will trigger the search while in your screenshot it looks like the search field doesn't have focus and typing might not trigger the search.
- In addition the size of the elements of the dashboard should loosely correspond to their importance. The search is arguably the most important feature of the dashboard. The way you changed it it seems a bit too minor to me.
I agree that the search as it currently is is inconsistent with how we display search fields anywhere else but it does fit with the rest of the dashboard. The overall style of the dashboard is pretty unique imo (for better or worse).
Mon, Aug 26
Yes, that would be alright imo. That's actually mostly what I meant when I said
Sun, Aug 25
@Leon0402 and I were just discussing this change in the VDG chat room so I'll write down some opinions I got.
Overall I think it is very helpful and elegant to teach the shortcuts within that combobox. We need to make sure though that the area description + default shortcut fits into a row in most locales.
If the user has changed the shortcuts to something that doesn't fit into the combobox I would favour simply not displaying the shortcut because in this case the benefit of teaching the user a shortcut is hardly there anymore. Making the dropdown wider is the other option but I'd imagine that might look kinda bad. This needs testing.
Aug 18 2019
I think it is fine having two actions that both open the Search/Findbar. The new 'toggle-search' would replace 'open-search' in the Toolbar and 'open-search' would still be associated with Ctrl+F.
This is similar to having two actions for typing a new location:
Making the names of the two actions more distinct might be enough to keep the users from getting super confused.
Aug 12 2019
Aug 10 2019
There wasn't much discussion about using the view mode button in the VDG:
Jul 28 2019
I kept the names lowercase because after trying both I liked them lowercase better. The visible difference between lowercase separator/spacer and title case actions makes the list a tiny bit more neat imo. I don't mind changing the names to title case though. Judge for yourself:
Rename to "expanding spacer", Cast to QToolBar instead
Jul 22 2019
You all are too kind!
Jul 21 2019
Use insertWidget(before, spacer) instead of addWidget(spacer)
Jul 18 2019
Jul 16 2019
How about only making security update notifications persistent? There is no real harm in missing non-security updates in my opinion.
Jul 13 2019
+1 for the idea. Dolphin is often used to differentiate between drives so having the format option right there would be kool.
Should it open the KDE Partition Manager?
Looks great overall!
I just want to nitpick that the top-right search bar doesn't align with the sidebar. Adding the class "mr-3" to the form and setting the .form-control width to 255px seems to have aligned them for me but that is maybe not the right solution.
Jul 9 2019
Use classes "list-unstyled m-0 p-0"
Jul 8 2019
I think the dropdown menu for the language selection might be too hard to spot if an unknown language is displayed.
Add RSS feed with recent blog posts and change wording to "Community blog posts"
Jul 4 2019
Jul 3 2019
Change "News from KDE contributors" to "News from contributors"
Change wording like @skadinna suggested - this time for real
Oops, I'll try that again.
Change wording like @skadinna suggested
Jul 2 2019
I don't have commit access. Would one of you land it for me please?
Jun 30 2019
Change "timeoutInS" to "timeoutInSeconds" and add const
I thought non-integer values could not be entered because entering a dot there is not possible for me. Comma works though.
Do not use ceil until the first integer was reached
This way when a non-integer value like 4,5 seconds is entered
it won't show 5 seconds in the title for the first .5 seconds of
I also made the math more easily understandable by extracting
calculations into separate lines.
I would agree with that but the UI only allows for integer values as a timeout right now.
Jun 29 2019
There are two different scenarios for sidebars explained in T11093: Improve Consistency across the Board. Just to be clear: This task is only about the second one, right? I would tend to think these can be viewed as separate issues for now (roughly quoting @niccolove):
Use i18ncp and have "second/s" instead of an "s"
Jun 25 2019
Make seconds localized
I actually tried to research if "s" is an international
symbol beforehand and it seemed to me like it was
but I trust your call on this.
What do you say it is down to one line now! Your latest changes really helped there.
I would have created this diff sooner but it's way too hot in my room and I had to rebuild all dependencies because I switched to developing in a virtual machine. So I was delaying this but seeing that it won't be cooler anytime soon I took this burden on me. :P
Rebase to master
Thanks for fixing this!
Jun 23 2019
Remove trailing whitespaces
This does sound like it could be a good solution. I am not quite sure if I am picturing this correctly.
I don't have commit access. Can you land the patch for me, per favore? :)
Jun 20 2019
I don't think Konqi should be called a banker when wearing a suit. It doesn't fit the collaborative non-profit nature of KDE. I think Boss Konqi is alright. Business Konqi can work too.
Excuse me for not making these small changes and sentence restructuring sooner. Re-reading my help messages now brought different details to my attention.
Start help message for "Show hidden places" with "This"
Unify sentence structure and add requested space
Sentences should start with "This does/is/etc." for
better intelligibility if possible instead of using
the imperative or omitting the subject.
Jun 15 2019
But for now I'll wait until D21638: Display delay in the taskmanager has landed and I'll rebase to master then.
Jun 14 2019
The following text has become longer than I intended to. I will put it somewhere else if it is seen as off-topic. I have been thinking about this for a while and I want to get it out there because I think it might be a solution to multiple problems.
Jun 13 2019
I think merging would be a good idea.
I agree that the indicator doesn't need to be prominent. Because of the notification history it won't be lost if one misses it anyway. I am content with the way it is.
Jun 8 2019
Is there something special about it?
Not really. It is a desktop computer with seven year old hardware. It is not even that slow and granted that the bug doesn't happen in a virtual machine on this machine it doesn't seem to have anything to do with speed anyway. It has Kubuntu 18.04 installed though so maybe some interaction between the taskmanager or panels and the up to date spectacle leads to the needed delay.
I don't see a bug report for it so it might really just be a local issue.
And for me it hides itself in time as it should
This diff successfully fixes the indefinite hiding of the main window for me but now there is not enough time for the main window to hide in the task bar so the task bar always contains spectacle.
Jun 7 2019
I like that idea! Maybe you can do a patch for that? :)
That's what I've been trying the last hour :D But I am quite new to Qt and kinda failing miserably so far. I'll keep trying.
I have never done a review before and I feel like I am going a bit over the top with the testing here. But it's too late now. :)
Jun 2 2019
May 31 2019
May 29 2019
Ellipsis seems to be the best option then. Thanks for convincing me!
May 28 2019
The "Indeterminate" state is most often represented by a square. Maybe we should do the same? That being said I didn't find a location where this state is actually used.
I felt like the check mark might be a bit small so I made a bigger version as a test. I think I like it better this way but yours looks good already.
May 27 2019
I was already thinking about working on explicitly setting or not setting this flag at the right places. In particular I was thinking about dynamically changing this flag depending on the page in the system settings one is currently viewing so users don't get frustrated when no help is available for the current one.
Though concerning Dolphin the only windows that use "What's This?" seem to be Settings/Configure Shortcuts... and Help/Report Bug... and those aren't specific to Dolphin.
Change "all its contents" to "most of its contents"
Patch looks almost ready now.
May 20 2019
Rebased to current master
Applied all the requested changes
May 14 2019
Apr 14 2019
Fix typos: informations -> information