Set options for GTK apps in the respective KCMs
Open, Needs TriagePublic

Description

Currently you can set options for Qt apps and GTK apps separately, but it would make much more sense to set the options for GTK apps in the respective KCMs too, instead of separately in the GTK KCM.

Here are the individual work items for this task:

GB_2 created this task.Mar 13 2019, 3:32 PM
This comment was removed by ngraham.
cblack added a subscriber: cblack.Aug 24 2019, 10:47 PM
GB_2 assigned this task to gikari.Sep 27 2019, 4:22 PM
GB_2 updated the task description. (Show Details)Oct 10 2019, 7:18 PM
GB_2 updated the task description. (Show Details)Oct 10 2019, 7:21 PM
gikari updated the task description. (Show Details)Oct 17 2019, 8:25 PM
GB_2 updated the task description. (Show Details)Thu, Nov 14, 6:15 AM
ngraham updated the task description. (Show Details)Thu, Nov 14, 7:30 PM
ngraham updated the task description. (Show Details)
ngraham updated the task description. (Show Details)Sun, Nov 17, 11:47 PM
zzag added a subscriber: zzag.Mon, Nov 18, 10:47 AM

Window decorations (fixes https://bugs.kde.org/show_bug.cgi?id=414113)

Not all decoration themes draw circles around decoration buttons, so that's probably CANTFIX. On the other hand, we could synchronize kwin's decoration button layout with the gtk-decoration-layout property.

In T10611#208756, @zzag wrote:

Window decorations (fixes https://bugs.kde.org/show_bug.cgi?id=414113)

Not all decoration themes draw circles around decoration buttons, so that's probably CANTFIX.

Could we sync that setting for those themes that do have this option?

In T10611#208756, @zzag wrote:

Window decorations (fixes https://bugs.kde.org/show_bug.cgi?id=414113)

Not all decoration themes draw circles around decoration buttons, so that's probably CANTFIX. On the other hand, we could synchronize kwin's decoration button layout with the gtk-decoration-layout property.

Some clever colour exporting would actually make respecting circle setting possible for Breeze GTK.

zzag added a comment.Mon, Nov 18, 10:44 PM

Could we sync that setting for those themes that do have this option?

Yes, you could do that. But keep in mind that you would have to hard code the list of those themes. KWin has no idea whether the decoration theme draws a circle around the close button.

gikari updated the task description. (Show Details)Mon, Dec 2, 11:28 PM
gikari updated the task description. (Show Details)Tue, Dec 3, 8:33 AM
GB_2 updated the task description. (Show Details)EditedSun, Dec 8, 2:09 PM

We could also set the "Prefer dark theme" preference depending on your color scheme (like the filter combobox added in D18646).

ndavis added a subscriber: ndavis.Sun, Dec 8, 2:14 PM
In T10611#213118, @GB_2 wrote:

We could also set the "Prefer dark theme" preference depending on your color scheme (like the filter combobox added in D18646).

TBH, I can't tell if that setting actually does anything on Plasma.

GB_2 added a comment.Sun, Dec 8, 2:31 PM

TBH, I can't tell if that setting actually does anything on Plasma.

If you set a theme like Adwaita (if you're on neon you need to install gnome-themes-extra and set the GTK3 theme to Adwaita) that has a light and dark variant then it uses the dark one (see https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-application-prefer-dark-theme).

That's true; the colors KCM does actually identify dark-ish themes as being dark themes, so we could in fact set that checkbox according to your color scheme.

gikari added a comment.Sun, Dec 8, 6:11 PM

We have breeze and breeze-dark, adwaita and adwaita-dark in GTK Themes as options.

How are they supposed to work with this prefer dark theme option?

cblack added a comment.Sun, Dec 8, 6:21 PM
In T10611#213129, @GB_2 wrote:

TBH, I can't tell if that setting actually does anything on Plasma.

If you set a theme like Adwaita (if you're on neon you need to install gnome-themes-extra and set the GTK3 theme to Adwaita) that has a light and dark variant then it uses the dark one (see https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-application-prefer-dark-theme).

This appears to be indicative of a bug with the GTK KCM. Adwaita and Adwaita-dark always exist in GTK; the above themes package only installs a dummy theme. GTK will always use an internal copy of Adwaita/Adwaita dark if the theme is set to adwaita/adwaita-dark, regardless of the contents of the Adwaita in /usr/share/themes

ngraham updated the task description. (Show Details)Tue, Dec 10, 10:24 AM
gikari added a comment.EditedWed, Dec 11, 9:11 AM

I have tested prefer-dark-theme checkbox with Breeze and Adwaita themes.

Color scheme: Breeze Light

ThemeCheckbox stateTheme colors
BreezeYesLight
BreezeNoLight
Breeze-darkYesLight
Breeze-darkNoLight
AdwaitaYesLight Dark
AdwaitaNoLight
Adwaita-darkYesDark
Adwaita-darkNoDark

It seems like Breeze always grabs its colors from Colors KCM , while Adwaita colors depend only on Theme Name. Looks like this checkbox doesn't do anything.

Edit: It appears, that I've tested this with Lutris, that overrides the dark theme preference setting.

filipf added a subscriber: filipf.EditedWed, Dec 11, 9:25 AM

Still works for Adwaita:

EDIT: Arc as well.