Give all OverlaySheets consistent headers
ClosedPublic
Actions

Authored by ngraham on May 13 2020, 1:19 PM.

Details

Reviewers

apol
leinir

Group Reviewers

Discover Software Store
VDG

Commits

R134:fb1880d436a8: Give all OverlaySheets consistent headers

Summary

OverlaySheet has a header: property typically used to give the sheet a title. This patch
used it to give all of Discover's OverlaySheets appropriate titles. The review sheet's
top layout is slightly adjusted to make this look good.

Test Plan

Diff Detail

Repository

R134 Discover Software Store

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham created this revision.May 13 2020, 1:19 PM

Restricted Application added a project: Plasma. · View Herald TranscriptMay 13 2020, 1:19 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ngraham requested review of this revision.May 13 2020, 1:19 PM

Harbormaster completed remote builds in B26836: Diff 82734.May 13 2020, 1:19 PM

We are in string freeze right now, aren't we?

discover/qml/ApplicationPage.qml
282 ↗	(On Diff #82734)	I guess this was for testing?

+1 for the change btw, thanks!

String freeze is tomorrow.

discover/qml/ApplicationPage.qml
282 ↗	(On Diff #82734)	Yes, to work around ODRS flakiness. :(

Remove testing thingy that snuck in

Harbormaster completed remote builds in B26837: Diff 82735.May 13 2020, 1:40 PM

apol accepted this revision.May 13 2020, 1:43 PM

This revision is now accepted and ready to land.May 13 2020, 1:43 PM

Yay consistency! Good idea (and timely ;) )

Closed by commit R134:fb1880d436a8: Give all OverlaySheets consistent headers (authored by ngraham). · Explain WhyMay 13 2020, 1:44 PM

This revision was automatically updated to reflect the committed changes.

GB_2 added a subscriber: GB_2.May 13 2020, 1:57 PM

GB_2 added inline comments.

discover/qml/UpdatesPage.qml
39	"Update Issue"

ngraham marked an inline comment as done.May 13 2020, 1:58 PM

ngraham added inline comments.

discover/qml/UpdatesPage.qml
39	Oops, thanks. Fixed in 11cf0dc694f92551f75617b664cd3e7e49e98df8.

Revision Contents
Changeset List

			Path	Packages
M			discover/qml/AddonsView.qml (7 lines)
M			discover/qml/DiscoverWindow.qml (9 lines)
M			discover/qml/ReviewsPage.qml (37 lines)
M			discover/qml/SourcesPage.qml (9 lines)
M			discover/qml/UpdatesPage.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82734	a4403f6		May 13 2020, 1:19 PM	★	★
Diff 2	82735	a4403f6	Remove testing thingy that snuck in	May 13 2020, 1:40 PM	★	★
Diff 3	82736	a4403f6	R134:fb1880d436a875a00a8b62e9408bb26a7ffedd20	May 13 2020, 1:39 PM	★	★