- User Since
- Jul 30 2016, 1:03 AM (82 w, 21 h)
Mon, Feb 12
Thu, Feb 1
Wed, Jan 31
I do have commit access.
Tue, Jan 30
No one approved it so I never merged it in time for the Plasma 5.12 beta. So I guess it'll have to wait for 5.12 to be released before I merge it into the master branch?
Jan 19 2018
Jan 10 2018
Is the onVolumeChange call delayed? I'm not sure if it's fired when we set it, or PulseAudio gets back to us.
Yes I do. Sorry I didn't get to push it yesterday. Thanks for approving the change!
Jan 9 2018
one channel is 0%, second is 100% and merged volume now shows 100%
Jan 6 2018
Support touchpad "mousewheel" which is pixel perfect based off plasma-pa's code.
Jan 4 2018
Oh I see, "Commandeer revision" is in the "Add action..." dropdown, not the sidebar.
What are wallpaper plugins?
Jan 3 2018
Would making these 2 new categories ("Plasma 5 Clocks" and "Plasma 5 Menus") subcategory to "Plasma 5 Widgets" work? What I mean is, would it list the menus and clocks in Plasma's "Download New Plasma Widgets" installer?
I don't think I can attach a new diff to your differential, so here's a link to it:
Jan 2 2018
So you removed 2 units from the overall cell height, but only 1 unit from the frameloader height. This means you removed 1 unit from the "leftover" padding at the bottom of the frameloader, and are overlapping the cell below by another 1 unit.
Dec 5 2017
Nov 7 2017
Nov 5 2017
Quick note since I just notice you suggested a lowercase i in ?linkid=3, should I change it to lowercase or stick with camelcase?
Nov 3 2017
Good idea. This will future proof us in case we ever want ?linkName=tiledmenu-v18-kde5.9.plasmoid or something as well.
Oct 26 2017
Another note: plasmoidviewer is unaffected by this patch. Meaning
Oct 23 2017
No prob, thanks for accepting it (including the mockup stuff). It'll make it easier to test if I see anything else. 🙂
Oct 16 2017
Oct 14 2017
Aug 28 2017
Aug 24 2017
@broulik oh awesome. Uhg, not sure why I didn't see that function.
Aug 23 2017
Aug 16 2017
Neat. I gave it a test.
Jul 19 2017
Jul 11 2017
Oh awesome. Just found out about this. So this would be added in Frameworks 5.37 then?
Jun 26 2017
Jump by 2px. Jump by __ clicks. Make sure thickness is even. Hide thickness in button after 1 second.
Great idea about using a timer in the binding. I can probably keep the onThicknessChanged binding since it does change size when moved from left/right to top/bottom.
Jun 22 2017
Jun 21 2017
+semicolon and specify it's scrollArea.ready
So before my commit, it was only needing to do:
qml: cellHeight iconHeight 108 qml: cellWidth iconWidth 92 qml: cellHeight iconHeight 108
Jun 20 2017
@hein Good catch with the && isRootView. It's just optimization since the extraSpace for the popup is 0 right? Now that I think on it, not sure why I made the variables into properties. Probably for logging onVarChanged when debugging it. Would this be more efficient?
Jun 15 2017
Jun 12 2017
Semicolons... (I should install a linter)
We don't really need to wait for folderViewLayer.ready before setting the bottom/right anchors anymore.
Don't add extra spacing if we're not a containment (the desktop).
Remove comment that's no longer applicable.
What behaviour should the folder widget use:
Remove check for if we're already overflowing, using rtl layout, or if it's "arrange in columns/rows", since the ScrollView shouldn't be covered by panels.
Oh now I remember why I used scrollView.viewport. We don't want to count the scrollbars as "extra" space. Notice in this screenshot it would perfectly fit another row, but the scrollbar made the area shorter.
So removing the following two conditionals fixes it. I'm not sure why they are there. Right now it only stops at the panels if we're already overflowing.
in rightMargin: (folderViewLayer.view.overflowing || folderViewLayer.view.flow == GridView.FlowLeftToRight || folderViewLayer.view.layoutDirection == Qt.RightToLeft)
in bottomMargin: (folderViewLayer.view.overflowing || folderViewLayer.view.flow == GridView.FlowTopToBottom)
Cleaner logic in calcExtraSpacing().
Jun 5 2017
I tried commenting again today and it worked.
Hmm, just of this after reading a comment on reddit. Latte-Dock uses another process, would this cause keyboard shortcuts to not work for it? I'm not sure if it has a different app name.
Jun 1 2017
I should also note that the list of 151 comments isn't related to the product, since the product https://store.kde.org/p/1153173 only has ~5 comments.
May 25 2017
Apply to icons-dark too.
Is there a "daytime" setting or is it hardcoded to be 100% blue? Redshift Control for example:
May 13 2017
Since people still can't install the moved widgets via GHNS, I'm moving my Tiled Menu widget back to the category "Plasma Widgets". Please don't move it back unless it can be installed with GHNS in the Plasma 5.8 LTS.
May 6 2017
May 3 2017
Hmmm, this seems better than my solution since mine stays in the boosted state (slide.maxValue=150%) after the volume when back below 100%.
May 2 2017
I see you saw the /r/linux thread:
May 1 2017
Apr 27 2017
Apr 26 2017
Apr 24 2017
Doesn't this change make those widget uninstallable with GHNS with the current, and more importantly, older versions of plasma?
Apr 8 2017
Should I go ahead and commit this?
Apr 3 2017
I've seen that, but that is unrelated to this change, so please move it into separate review.
Mar 25 2017
And yes I know KDE Neon is Qt 5.7.1 at the moment, I meant to ask wither it's part of the standard install of Qt.