Zren (Chris Holland)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2016, 1:03 AM (98 w, 6 d)
Availability
Available

Recent Activity

Tue, Jun 19

Zren added a comment to D13596: Fix there being more security updates than total updates in notifier.

Thanks @apol for merging it. Thanks @ngraham for testing it and the link and @davidedmundson for explaining how bugfixes are merged.

Tue, Jun 19, 9:22 PM · Plasma
Zren committed R134:9577e7d1d333: Fix there being more security updates than total updates in notifier (authored by Zren).
Fix there being more security updates than total updates in notifier
Tue, Jun 19, 9:09 PM
Zren closed D13596: Fix there being more security updates than total updates in notifier.
Tue, Jun 19, 9:09 PM · Plasma
Zren requested review of D13596: Fix there being more security updates than total updates in notifier.
Tue, Jun 19, 12:26 AM · Plasma

Wed, Jun 13

Zren added inline comments to D13508: Swap Trash for Delete action when only one is enabled and the Shift modifier is pressed.
Wed, Jun 13, 4:18 PM · Plasma

Wed, Jun 6

Zren added a comment to D13390: Fonts KCM: Fix text readability regression.

Would the TextField.readOnly property be useful here?

Wed, Jun 6, 11:48 PM · Plasma

Mon, May 28

Zren abandoned D13162: [TaskManager] Press and Hold for 800ms to trigger a drag.

No prob.

Mon, May 28, 1:38 PM · Plasma

Sun, May 27

Zren requested review of D13162: [TaskManager] Press and Hold for 800ms to trigger a drag.
Sun, May 27, 6:55 PM · Plasma

Fri, May 25

Zren added a comment to T8707: Window borders.

That would complicate shadow rendering code too much.

Fri, May 25, 5:49 PM · VDG
Zren added a comment to T8707: Window borders.

Would it be possible to draw rounded corners with the compositor as a Desktop Effect? All we need to do is translate a the shadow pixels ontop of the the client rect. Maybe making a few pixels semi transparent.

Fri, May 25, 4:49 PM · VDG

May 14 2018

Zren committed R114:b0fc4805e961: [QuickShare] Respect units.iconSizeHints.panel for panel icon (authored by Zren).
[QuickShare] Respect units.iconSizeHints.panel for panel icon
May 14 2018, 7:32 PM
Zren closed D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon.
May 14 2018, 7:32 PM · Plasma
Zren updated the diff for D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon.

Remove unrelated brace formatting.

May 14 2018, 1:30 PM · Plasma
Zren requested review of D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon.
May 14 2018, 1:14 AM · Plasma

May 13 2018

Zren committed R108:184b490c78a3: Update knsrc to use kpackagetool5 commands (authored by Zren).
Update knsrc to use kpackagetool5 commands
May 13 2018, 11:11 PM
Zren closed D12249: Update knsrc to use kpackagetool5 commands.
May 13 2018, 11:11 PM · KWin

May 11 2018

Zren added a comment to D12249: Update knsrc to use kpackagetool5 commands.

I guess apol's +1 = patch accepted? I'll merge it then.

May 11 2018, 6:37 PM · KWin

May 10 2018

Zren updated the diff for D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.

Use connect(m_newStuffDialog.data(), ...) to support gcc 4.8.
Add license headers.

May 10 2018, 3:56 PM · Plasma

May 2 2018

Zren added a comment to D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.
In D12040#257170, @mart wrote:

so, if the qpointer is used in a connect, it needs to have .data() to work on gcc 4.8.
if accessed normally, it doesn't need it

May 2 2018, 1:26 PM · Plasma

Apr 25 2018

Zren added a comment to D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.

I use gcc --version 5.4.0, so I've no idea. I assume that is a QPointer feature though? We can always check the other DownloadDialog initializations:

Apr 25 2018, 2:51 AM · Plasma

Apr 24 2018

Zren updated the diff for D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.

Remove .data() since it seems to work without it.

Apr 24 2018, 11:56 PM · Plasma

Apr 16 2018

Zren requested review of D12249: Update knsrc to use kpackagetool5 commands.

Yeah, I can't figure out how to get it to recognize kwineffect.desktop, I'll submit another diff if I figure it out.

Apr 16 2018, 7:05 PM · KWin
Zren added a comment to D12249: Update knsrc to use kpackagetool5 commands.

Doesn't work...

Apr 16 2018, 4:31 PM · KWin
Zren planned changes to D12249: Update knsrc to use kpackagetool5 commands.
Apr 16 2018, 4:00 PM · KWin
Zren requested review of D12249: Update knsrc to use kpackagetool5 commands.
Apr 16 2018, 4:00 PM · KWin
Zren added a comment to D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog.

Why not save the room on the right of the KCM and instead blur the actual image in the list? Move the controls closer to that list item? The arrangement looks off the way it shows in the screenshots.

Apr 16 2018, 2:50 PM · Plasma
Zren added inline comments to D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.
Apr 16 2018, 12:24 PM · Plasma
Zren retitled D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog from [WIP] Add wallpaperplugin.knsrc + QML function to open GHNS dialog to Add wallpaperplugin.knsrc + QML function to open GHNS dialog.
Apr 16 2018, 4:41 AM · Plasma
Zren added a comment to D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog.

I'm still unsure how to update the dropdown after you download a new plugin.

Apr 16 2018, 4:40 AM · Plasma
Zren updated the diff for D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.

Move open GHNS window function from Wallpaper.Image to ShellPrivate.WallpaperPlugin

Apr 16 2018, 4:39 AM · Plasma
Zren updated the diff for D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog.

Change from Wallpaper.Image to the ShellPrivate.WallpaperPlugin

Apr 16 2018, 4:22 AM · Plasma

Apr 14 2018

Zren added a comment to D12206: Don't show top "Open With" app for folders; only for files.

So you're proposing that folders show the Open With... entry, but omit the recently added additional entry that shows the first app?

Apr 14 2018, 8:35 PM · Frameworks
Zren added a comment to D12206: Don't show top "Open With" app for folders; only for files.
  • Open with "Sublime Text" / "Atom"
  • Open with "K4DirStat"
  • Open with "Clementine"
Apr 14 2018, 8:21 PM · Frameworks

Apr 10 2018

Zren added a comment to D12078: Use template text when naming the generated clip.
rather on the refactoring_timeline
Apr 10 2018, 8:17 AM

Apr 9 2018

Zren updated the summary of D12078: Use template text when naming the generated clip.
Apr 9 2018, 11:44 PM
Zren requested review of D12078: Use template text when naming the generated clip.
Apr 9 2018, 11:40 PM
Zren added a comment to D12057: Scale TitleTemplateDialog preview with the window.

Thanks for accepting it! I think I'll try having it preview a the text next. Need to replace the %s in the preview with the QTextEdit text.

Apr 9 2018, 9:47 PM
Zren committed R158:dbd5a248df17: Scale TitleTemplateDialog preview with the window (authored by Zren).
Scale TitleTemplateDialog preview with the window
Apr 9 2018, 9:39 PM
Zren closed D12057: Scale TitleTemplateDialog preview with the window.
Apr 9 2018, 9:39 PM
Zren requested review of D12057: Scale TitleTemplateDialog preview with the window.
Apr 9 2018, 2:14 AM

Apr 8 2018

Zren updated the diff for D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog.

Remove commented code.
Add " New " to button label.

Apr 8 2018, 10:02 PM · Plasma
Zren added inline comments to D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog.
Apr 8 2018, 3:43 PM · Plasma
Zren updated the summary of D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.
Apr 8 2018, 6:41 AM · Plasma
Zren requested review of D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog.
Apr 8 2018, 6:39 AM · Plasma
Zren requested review of D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.
Apr 8 2018, 6:31 AM · Plasma

Apr 6 2018

Zren committed R119:85416dd8ef30: Fix typo in the kcm_desktoptheme edit theme tooltip (authored by Zren).
Fix typo in the kcm_desktoptheme edit theme tooltip
Apr 6 2018, 3:57 PM
Zren closed D11970: Fix typo in the kcm_desktoptheme edit theme tooltip.
Apr 6 2018, 3:57 PM · Plasma
Zren added a comment to D11375: Don't block evaluating DBus scripts if widgets are locked..

Um, if (immutability() != Plasma::Types::SystemImmutable) { return; } was pushed.

Apr 6 2018, 2:44 PM · Plasma

Apr 5 2018

Zren abandoned D2314: Context Menu to Mute, Set Default Sink/Source, Active Port.

Yep, D4751 was used instead.

Apr 5 2018, 8:08 PM · Plasma
Zren abandoned D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths.
Apr 5 2018, 8:05 PM · Plasma
Zren added a reviewer for D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it: Breeze.

Forgot to add reviewers.

Apr 5 2018, 8:03 PM · Frameworks
Zren requested review of D11970: Fix typo in the kcm_desktoptheme edit theme tooltip.
Apr 5 2018, 7:55 PM · Plasma

Mar 24 2018

Zren added a comment to R242:bb0185ab1c3c: Templates: drop unused X-Plasma-Requires-* entries from applet metadata.

I noticed you pruned kdeplasma-addons as well. Figured I'd list the other repos/widgets that still have these keys:

Mar 24 2018, 6:44 PM

Mar 9 2018

Zren added inline comments to D11166: Simplify display when there's only a single input device and a single output device.
Mar 9 2018, 5:52 AM · Plasma
Zren added a comment to D11166: Simplify display when there's only a single input device and a single output device.

I remember having trouble binding to stuff in the ___Representation in the main.qml too, but don't remember the specifics. Why not just define it in the ColumnLayout { id: devicesView } since it's not really needed elsewhere. onlyOne: devicesView.simpleMode, visible: !devicesView.simpleMode.

Mar 9 2018, 4:42 AM · Plasma
Zren added a comment to D11166: Simplify display when there's only a single input device and a single output device.

Hmmm. So if there was 2 sinks (eg: 3.5mm jack + HDMI) and 1 mic (3.5mm jack) it'd show the sink header, but not the source header? Labelling all 3 as a sink?

Mar 9 2018, 4:07 AM · Plasma

Mar 6 2018

Zren added a comment to D10925: Wrap at end of selector instead of in the middle.

Didn't test it, just double checked the whitespace.

Why not?

Mar 6 2018, 9:04 PM · Plasma
Zren added a comment to D11082: [WIP] Display all StreamRestore entries in it's own config Tab.

You forgot to add StreamRestoreTab.qml to review.

Mar 6 2018, 6:03 PM · Plasma
Zren updated the diff for D11082: [WIP] Display all StreamRestore entries in it's own config Tab.

Forgot to add StreamRestoreTab.qml

Mar 6 2018, 6:01 PM · Plasma
Zren requested review of D11082: [WIP] Display all StreamRestore entries in it's own config Tab.
Mar 6 2018, 7:24 AM · Plasma

Mar 5 2018

Zren added a comment to D11059: Add convenience method to get a persistent model index from TasksModel.

Typo. You only have 1 "s" in persistent there.

Mar 5 2018, 2:47 PM · Plasma

Feb 28 2018

Zren requested review of D10925: Wrap at end of selector instead of in the middle.
Feb 28 2018, 6:54 PM · Plasma

Feb 12 2018

Zren requested review of D10453: Show space left bar for folderw which are mount points instead of "X items".
Feb 12 2018, 6:21 AM

Feb 1 2018

Zren committed R118:37792755e48a: [plasmoidviewer] Load translations from KPackage files if bundled (authored by Zren).
[plasmoidviewer] Load translations from KPackage files if bundled
Feb 1 2018, 12:38 AM
Zren closed D10219: Load translations from KPackage files if bundled.
Feb 1 2018, 12:38 AM · Plasma

Jan 31 2018

Zren committed R119:586797610e08: [Panel Config] Scrolling over size button increments size by 2 and shows… (authored by Zren).
[Panel Config] Scrolling over size button increments size by 2 and shows…
Jan 31 2018, 8:11 AM
Zren closed D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness.
Jan 31 2018, 8:11 AM · Plasma
Zren added a comment to D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness.

I do have commit access.

Jan 31 2018, 12:12 AM · Plasma

Jan 30 2018

Zren added a comment to D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness.

No one approved it so I never merged it in time for the Plasma 5.12 beta. So I guess it'll have to wait for 5.12 to be released before I merge it into the master branch?

Jan 30 2018, 4:09 AM · Plasma

Jan 19 2018

Zren committed R225:91ade6a846cd: Mention 2 fingers to scroll in mousepad_info (authored by Zren).
Mention 2 fingers to scroll in mousepad_info
Jan 19 2018, 6:07 AM
Zren closed D9977: Mention 2 fingers to scroll in mousepad_info.
Jan 19 2018, 6:07 AM

Jan 10 2018

Zren added a comment to D4140: Rework playing of volume feedback.

Is the onVolumeChange call delayed? I'm not sure if it's fired when we set it, or PulseAudio gets back to us.

Jan 10 2018, 6:01 PM · Plasma
Zren added a comment to D9726: Change device "master volume" to be the max of all channels instead of the avg.

Yes I do. Sorry I didn't get to push it yesterday. Thanks for approving the change!

Jan 10 2018, 5:15 PM · Plasma
Zren committed R115:27aa584f7ae9: Make device "master volume" the max of all channels instead of the avg (authored by Zren).
Make device "master volume" the max of all channels instead of the avg
Jan 10 2018, 5:07 PM
Zren closed D9726: Change device "master volume" to be the max of all channels instead of the avg.
Jan 10 2018, 5:06 PM · Plasma

Jan 9 2018

Zren added a comment to D9726: Change device "master volume" to be the max of all channels instead of the avg.

one channel is 0%, second is 100% and merged volume now shows 100%

Jan 9 2018, 3:51 AM · Plasma

Jan 6 2018

Zren updated the diff for D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness.

Support touchpad "mousewheel" which is pixel perfect based off plasma-pa's code.

Jan 6 2018, 5:03 AM · Plasma
Zren committed R119:5ae880f84626: Slightly reduce vertical gutter width. (authored by Zren).
Slightly reduce vertical gutter width.
Jan 6 2018, 1:24 AM
Zren closed D9201: Slightly reduce vertical gutter width..
Jan 6 2018, 1:24 AM · Plasma

Jan 4 2018

Zren updated the diff for D9201: Slightly reduce vertical gutter width..
Jan 4 2018, 11:23 PM · Plasma
Zren commandeered D9201: Slightly reduce vertical gutter width..

Oh I see, "Commandeer revision" is in the "Add action..." dropdown, not the sidebar.

Jan 4 2018, 11:17 PM · Plasma
Zren added a comment to T5932: Add 2 KNS Categories when Searching+Downloading New Plasma Widgets.

What are wallpaper plugins?

Jan 4 2018, 1:13 AM · KDE Store

Jan 3 2018

Zren added a comment to T5932: Add 2 KNS Categories when Searching+Downloading New Plasma Widgets.

Would making these 2 new categories ("Plasma 5 Clocks" and "Plasma 5 Menus") subcategory to "Plasma 5 Widgets" work? What I mean is, would it list the menus and clocks in Plasma's "Download New Plasma Widgets" installer?

Jan 3 2018, 8:04 PM · KDE Store
Zren added inline comments to D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness.
Jan 3 2018, 6:09 PM · Plasma
Zren added a comment to D9201: Slightly reduce vertical gutter width..

I don't think I can attach a new diff to your differential, so here's a link to it:

Jan 3 2018, 4:54 PM · Plasma

Jan 2 2018

Zren added a comment to D9201: Slightly reduce vertical gutter width..

So you removed 2 units from the overall cell height, but only 1 unit from the frameloader height. This means you removed 1 unit from the "leftover" padding at the bottom of the frameloader, and are overlapping the cell below by another 1 unit.

Jan 2 2018, 11:07 PM · Plasma

Dec 5 2017

Zren added a comment to D9201: Slightly reduce vertical gutter width..

Before patch:

Dec 5 2017, 7:02 PM · Plasma

Nov 7 2017

Zren committed R252:35656828f12c: Support downloading the 2nd or 3rd download link from a KNS product (authored by Zren).
Support downloading the 2nd or 3rd download link from a KNS product
Nov 7 2017, 2:12 AM
Zren closed D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.
Nov 7 2017, 2:12 AM · Frameworks

Nov 5 2017

Zren added a comment to D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.

Quick note since I just notice you suggested a lowercase i in ?linkid=3, should I change it to lowercase or stick with camelcase?

Nov 5 2017, 6:55 PM · Frameworks

Nov 3 2017

Zren added a comment to D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.

Good idea. This will future proof us in case we ever want ?linkName=tiledmenu-v18-kde5.9.plasmoid or something as well.

Nov 3 2017, 3:29 PM · Frameworks
Zren updated the diff for D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.
Nov 3 2017, 3:28 PM · Frameworks
Zren added a reviewer for D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies: apol.
Nov 3 2017, 6:05 AM · Frameworks
Zren updated the test plan for D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.
Nov 3 2017, 6:00 AM · Frameworks
Zren updated the test plan for D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.
Nov 3 2017, 5:56 AM · Frameworks
Zren created D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.
Nov 3 2017, 5:54 AM · Frameworks

Oct 26 2017

Zren added a comment to D5209: Load translations from KPackage files if bundled.

Another note: plasmoidviewer is unaffected by this patch. Meaning

Oct 26 2017, 2:49 AM · Frameworks, Plasma
Zren added a comment to D5209: Load translations from KPackage files if bundled.

This worked

Oct 26 2017, 2:34 AM · Frameworks, Plasma

Oct 23 2017

Zren added a comment to D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments.

No prob, thanks for accepting it (including the mockup stuff). It'll make it easier to test if I see anything else. 🙂

Oct 23 2017, 10:49 PM · Plasma
Zren committed R845:0ad9e0a1fdc2: Fix ActionItem Label width, minimumWidth=300, DPI scaled minimum size (authored by Zren).
Fix ActionItem Label width, minimumWidth=300, DPI scaled minimum size
Oct 23 2017, 10:36 PM