Zren (Chris Holland)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2016, 1:03 AM (133 w, 5 d)
Availability
Available

Recent Activity

Tue, Feb 19

Zren requested review of D19176: [weather] envcan: Fix typo in lowercase icon lookup string.
Tue, Feb 19, 11:43 PM · Plasma
Zren requested review of D19174: [weather] envcan: Document urls for example data + list all warnings.
Tue, Feb 19, 11:29 PM · Plasma
Zren added a comment to T10402: The Desktop Toolbox.

without needing to right-click

Tue, Feb 19, 6:18 PM · Plasma, VDG

Fri, Feb 15

Zren closed D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2.

Shoot, I accidentally forgot the Phab Rev link in the commit message (though I remembered the bugzilla tags). I've setup a .git/hook/prepare-commit-msg -like thing for Sublime Text to prevent this happening in the future.

Fri, Feb 15, 2:02 PM · Plasma
Zren committed R120:8f1a7ae6cd1d: Merge branch 'Plasma/5.15' (authored by Zren).
Merge branch 'Plasma/5.15'
Fri, Feb 15, 12:18 AM
Zren committed R120:006c4f5f9ee8: [Digital Clock] Fix 24h tri-state button broken in port to QQC2 (authored by Zren).
[Digital Clock] Fix 24h tri-state button broken in port to QQC2
Fri, Feb 15, 12:12 AM

Thu, Feb 14

Zren requested review of D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2.
Thu, Feb 14, 8:38 PM · Plasma

Tue, Feb 12

Zren added a comment to D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*.

we no longer have to install the widget to .../share/plasma/plasmoids/

No experience here, but do we not still need to install the QML extension plugins to have the applet working? Or is there some mechanism to load them also from the build dir now?

Tue, Feb 12, 6:34 PM · Plasma
Zren requested review of D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*.
Tue, Feb 12, 2:57 PM · Plasma
Zren committed R114:d41d5bde6577: Merge branch 'Plasma/5.15' (authored by Zren).
Merge branch 'Plasma/5.15'
Tue, Feb 12, 3:22 AM
Zren committed R114:6f849fdc8752: Merge branch 'Plasma/5.14' into Plasma/5.15 (authored by Zren).
Merge branch 'Plasma/5.14' into Plasma/5.15
Tue, Feb 12, 3:11 AM
Zren committed R114:fba8a13fee6b: [weather] Center align the warning heading (authored by Zren).
[weather] Center align the warning heading
Tue, Feb 12, 3:10 AM
Zren committed R114:8f185abab358: Merge branch 'Plasma/5.14' into Plasma/5.15 (authored by Zren).
Merge branch 'Plasma/5.14' into Plasma/5.15
Tue, Feb 12, 2:56 AM
Zren committed R114:5d6ae3ee7c6a: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by Zren).
Merge branch 'Plasma/5.12' into Plasma/5.14
Tue, Feb 12, 2:48 AM
Zren committed R114:46204a5e2a84: [weather] Fix weather Notices tab not showing (authored by Zren).
[weather] Fix weather Notices tab not showing
Tue, Feb 12, 2:00 AM
Zren closed D18936: [weather] Fix weather Notices tab not showing.
Tue, Feb 12, 2:00 AM · Plasma
Zren added a comment to D18936: [weather] Fix weather Notices tab not showing.

Ah, NoticesView.qml in Plasma 5.12 was slightly different.

Tue, Feb 12, 1:10 AM · Plasma
Zren added a comment to D18936: [weather] Fix weather Notices tab not showing.

Note: Env Canada lists all their Warnings + Watches for all of Canada at https://weather.gc.ca/warnings/index_e.html should anyone need to test in the future.

Tue, Feb 12, 12:31 AM · Plasma

Mon, Feb 11

Zren updated the diff for D18936: [weather] Fix weather Notices tab not showing.

Add Layout.alignment: Qt.AlignHCenter to the PlasmaExtras.Heading

Mon, Feb 11, 10:53 PM · Plasma
Zren added a comment to D18936: [weather] Fix weather Notices tab not showing.

I just noticed that the "Warnings Issued" text is left aligned. Might as well center align it while we're at it.

Mon, Feb 11, 10:46 PM · Plasma
Zren requested review of D18936: [weather] Fix weather Notices tab not showing.
Mon, Feb 11, 10:37 PM · Plasma

Sat, Feb 9

Zren added a comment to T10464: Move "KWin Switching Layouts" designed for KWin 4.x to it's own category.

Can we also make KWin smarter and try to fall back to the default theme (which may also be broken, sure, but because of distro not GHNS)?

Sat, Feb 9, 7:23 PM · KDE Store
Zren created T10464: Move "KWin Switching Layouts" designed for KWin 4.x to it's own category.
Sat, Feb 9, 6:28 PM · KDE Store

Tue, Feb 5

Zren added inline comments to D18696: Update `libdbusmenuqt` and the AppMenu plugin.
Tue, Feb 5, 5:08 AM · Plasma

Jan 18 2019

Zren committed R114:80bd32b12a01: Consistent arrow key handling in the Informative Alt+Tab skin (authored by Zren).
Consistent arrow key handling in the Informative Alt+Tab skin
Jan 18 2019, 6:02 PM
Zren closed D16093: Consistent arrow key handling in the Informative Alt+Tab skin.
Jan 18 2019, 6:02 PM · Plasma
Zren added a comment to D16093: Consistent arrow key handling in the Informative Alt+Tab skin.

I forgot to merge this after david's patch was merged. I just tested this in the Neon Beta ISO to confirm the fix still works.

Jan 18 2019, 5:46 PM · Plasma
Zren updated the test plan for D16093: Consistent arrow key handling in the Informative Alt+Tab skin.
Jan 18 2019, 5:38 PM · Plasma

Jan 14 2019

Zren added a comment to D18019: [Digital Clock] Add ability to set a custom date format string.

There was a few +1s, but I wasn't exactly sure who specifically "approves" this for a merge to plasma-workspace or digital-clock specifically. My bad, I shouldn't of left this feature to the last minute and felt rushed to get it in. I'll try to avoid the time before the betas when submitting in the future.

Jan 14 2019, 9:34 PM · Plasma
Zren committed R120:235fa8107dab: [Digital Clock] Add ability to set a custom date format string (authored by Zren).
[Digital Clock] Add ability to set a custom date format string
Jan 14 2019, 3:24 AM
Zren closed D18019: [Digital Clock] Add ability to set a custom date format string.
Jan 14 2019, 3:24 AM · Plasma

Jan 12 2019

Zren added a comment to D18019: [Digital Clock] Add ability to set a custom date format string.

Looking at the alternative patch, I've renamed the config key variable to customDateFormat. Most of the differences stem from not using a "variant" data type for DigitalClock.qml's dateFormat variable. The string formatDate(datetime date, variant format) (qt doc link) accepts a variant type.

Jan 12 2019, 3:36 PM · Plasma
Zren updated the diff for D18019: [Digital Clock] Add ability to set a custom date format string.
  • Rename config key from dateFormatStr and config TextField dateFormatTextField to customDateFormat.
  • Remove the "Color Format Documentation" link.
Jan 12 2019, 2:46 PM · Plasma

Jan 10 2019

Zren requested review of D18168: [WIP] [Digital Clock] Embed date formatting variable documentation.
Jan 10 2019, 8:13 PM · Plasma
Zren updated the diff for D18019: [Digital Clock] Add ability to set a custom date format string.

Translate the "Time Format Documentation" link.
Add a link to QML's Text RichText docs under the "Color Format Documentation" label (translated).
Place the 2 links below the text field.

Jan 10 2019, 8:24 AM · Plasma
Zren added a comment to D18019: [Digital Clock] Add ability to set a custom date format string.

The "show date" / "show seconds" toggles only affect the current widget instance as well. It would be nice if plasma had a plasmoid.globalConfiguration.dateFormatStr API which all widget instances (on all panels/screens) were bound to, so the user only had to configure it once for all screens. Though a person might have a clock on a vertical panel on one screen, and a thin horizontal panel on the other that might require a different configuration. That's an edge case example though.

Jan 10 2019, 8:11 AM · Plasma

Jan 8 2019

Zren added a comment to D18019: [Digital Clock] Add ability to set a custom date format string.

Shouldn't the documentation explain that apostrophes need to be used or is the fact that they need to be used unusual and specific to this clock widget?

Jan 8 2019, 3:41 PM · Plasma
Zren added a comment to D18019: [Digital Clock] Add ability to set a custom date format string.

I'm leaning towards no, but a second link to text formatting documentation might be a good idea.

Jan 8 2019, 5:49 AM · Plasma
Zren added inline comments to D18019: [Digital Clock] Add ability to set a custom date format string.
Jan 8 2019, 4:33 AM · Plasma
Zren added a comment to D18018: [Digital Clock] Add ability to change first day of week.

Is there a use case for having it configurable inside the plasmoid separately from configuring it system wide?

Jan 8 2019, 1:00 AM · Plasma

Jan 6 2019

Zren updated the summary of D18019: [Digital Clock] Add ability to set a custom date format string.
Jan 6 2019, 6:33 PM · Plasma
Zren requested review of D18019: [Digital Clock] Add ability to set a custom date format string.
Jan 6 2019, 6:23 PM · Plasma
Zren requested review of D18018: [Digital Clock] Add ability to change first day of week.
Jan 6 2019, 5:10 PM · Plasma

Jan 3 2019

Zren committed R242:e5949866bb8f: [Calendar] Expose firstDayOfWeek in MonthView (authored by Zren).
[Calendar] Expose firstDayOfWeek in MonthView
Jan 3 2019, 10:04 PM
Zren closed D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale.
Jan 3 2019, 10:04 PM · Frameworks

Jan 2 2019

Zren added a comment to D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config.

That still requires the user to drag a button, which isn't exactly obvious or a normal behaviour, just to discover what it is. It doesn't look like a desktop widget, not that the user would recognize it as one, as KDE by default does not display any desktop widgets the user can compare it with.

Jan 2 2019, 9:30 PM · VDG, Plasma
Zren requested review of D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config.
Jan 2 2019, 4:04 PM · VDG, Plasma

Nov 28 2018

Zren added inline comments to D8388: Do not hardcode unhovered windows brightness on present windows effect.
Nov 28 2018, 4:43 AM · KWin

Nov 22 2018

Zren added a comment to T10066: Put product name in comment email subject.

Just got an owner email with the project name! Thanks ronald.

Nov 22 2018, 7:49 AM · KDE Store

Nov 16 2018

Zren created T10066: Put product name in comment email subject.
Nov 16 2018, 8:39 PM · KDE Store
Zren created T10061: Do not send 2 emails to product owner when a user replies to his comment.
Nov 16 2018, 7:48 PM · KDE Store

Nov 8 2018

Zren abandoned D15720: [TabBox] Fix Arrow Key / Keyboard Events in QML Alt+Tab Skins.
Nov 8 2018, 1:38 PM · KWin

Nov 6 2018

Zren added a comment to D16693: [TabBox] Fix Arrow Key / Keyboard Events in QML Alt+Tab Skins.

Oh awesome. This code seems much easier to read than D15720.

Nov 6 2018, 8:25 PM · KWin

Nov 5 2018

Zren added a comment to D15888: new icons (Breeze style).

We're currently trying to draw the C++ Breeze/forks window decorations in T9899 (and https://bugs.kde.org/show_bug.cgi?id=399757), which would make these SVGs obsolete. However we can merge these in the short term until that code is ready.

Nov 5 2018, 1:54 AM · Plasma

Oct 30 2018

Zren committed R118:ff41e62200af: Merge branch 'Plasma/5.14' (authored by Zren).
Merge branch 'Plasma/5.14'
Oct 30 2018, 6:33 PM
Zren committed R118:76f9fe649b1f: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by Zren).
Merge branch 'Plasma/5.12' into Plasma/5.14
Oct 30 2018, 6:27 PM
Zren committed R118:47e4fa8e5366: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app (authored by Zren).
[cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app
Oct 30 2018, 6:24 PM
Zren closed D16521: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app.
Oct 30 2018, 6:24 PM · Plasma

Oct 29 2018

Zren requested review of D16521: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app.
Oct 29 2018, 11:57 PM · Plasma
Zren added a comment to D16516: [cuttlefish] Auto-focus on search textfield when app opens.

So adding this shooooould work... but doesn't.

Oct 29 2018, 11:42 PM · Plasma
Zren added a comment to D16516: [cuttlefish] Auto-focus on search textfield when app opens.

YES

Oct 29 2018, 9:36 PM · Plasma
Zren closed D16516: [cuttlefish] Auto-focus on search textfield when app opens.
Oct 29 2018, 4:17 PM · Plasma
Zren committed R118:542388f984cf: [cuttlefish] Auto-focus on search textfield when app opens (authored by Zren).
[cuttlefish] Auto-focus on search textfield when app opens
Oct 29 2018, 4:17 PM
Zren requested review of D16516: [cuttlefish] Auto-focus on search textfield when app opens.
Oct 29 2018, 4:07 PM · Plasma

Oct 24 2018

Zren committed R884:bb680e8dbfc2: Update libdbusmenuqt folder (authored by Zren).
Update libdbusmenuqt folder
Oct 24 2018, 7:51 PM
Zren committed R884:942169541d33: Hide Buttons With Empty Text (Gtk Separators) (authored by Zren).
Hide Buttons With Empty Text (Gtk Separators)
Oct 24 2018, 7:51 PM
Zren closed D16327: Update libdbusmenuqt folder.
Oct 24 2018, 7:51 PM · Plasma
Zren closed D16394: Hide Buttons With Empty Text (Gtk Separators).
Oct 24 2018, 7:51 PM · Plasma
Zren added a comment to D16327: Update libdbusmenuqt folder.

For now, I'm going to merge this so I can keep the widget in sync with the global menu widget. We can revisit linking to a shared library later on.

Oct 24 2018, 5:33 PM · Plasma

Oct 23 2018

Zren requested review of D16394: Hide Buttons With Empty Text (Gtk Separators).
Oct 23 2018, 11:20 PM · Plasma

Oct 20 2018

Zren added a comment to D16327: Update libdbusmenuqt folder.

KNotifications provides an example of linking to dbusmenu-qt5:
https://github.com/KDE/knotifications/blob/master/src/CMakeLists.txt#L46-L49

Oct 20 2018, 5:05 PM · Plasma
Zren added a comment to D16327: Update libdbusmenuqt folder.

Yeah, I'm not 100% sure why the Active Window Control widget needs it. I assume it should be dynamically linking to the /usr/lib/x86_64-linux-gnu/libdbusmenu-qt.so.2, but I wanted to update all the common code first before making major refactoring.

Oct 20 2018, 8:11 AM · Plasma

Oct 19 2018

Zren requested review of D16329: Add a ReadMe with install from Git instructions and bugzilla links.
Oct 19 2018, 10:35 PM · Plasma
Zren requested review of D16328: Saner config defaults.
Oct 19 2018, 9:12 PM · Plasma
Zren requested review of D16327: Update libdbusmenuqt folder.
Oct 19 2018, 8:37 PM · Plasma
Zren added a comment to T9878: Default application starter menu is missing a11y Labels.
  • Application Launcher (Kickoff) is the KDE default menu with the tabbed interface.
  • Application Menu (Kicker) is the Windows 95 styled menu.
  • Application Dashboard (KickerDash) reuses the Kicker source code, but uses DashboardRepresentation.qml as the entry point instead of main.qml. KickerDash's metadata.desktop file is in the kdeplasma-addons repo. Effectively, everything is in the plasma-desktop repo though as that one .desktop file is the only thing outside it.
Oct 19 2018, 12:46 AM · Plasma Accessibility

Oct 10 2018

Zren added a comment to D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.

Sorry, just merged both to master. Thanks davidedmundson for the patches that updated the ComboBox.

Oct 10 2018, 12:23 AM · Plasma
Zren committed R119:347f43c42b70: Add "Get Wallpaper Plugins..." button to Config Desktop dialog (authored by Zren).
Add "Get Wallpaper Plugins..." button to Config Desktop dialog
Oct 10 2018, 12:17 AM
Zren closed D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog.
Oct 10 2018, 12:17 AM · Plasma
Zren committed R120:5e1b650859fe: Add wallpaperplugin.knsrc + QML function to open GHNS dialog (authored by Zren).
Add wallpaperplugin.knsrc + QML function to open GHNS dialog
Oct 10 2018, 12:06 AM
Zren closed D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.
Oct 10 2018, 12:06 AM · Plasma

Oct 8 2018

Zren updated subscribers of D15720: [TabBox] Fix Arrow Key / Keyboard Events in QML Alt+Tab Skins.

I need to try patching plasma-framework's dialog.cpp and see if that introduces issues. Right now it's mainItem->setParentItem(contentItem());, and I need to test if mainItem->setParent(contentItem()); breaks anything. I haven't patched C++ in frameworks before so I'll need to figure that out.

Oct 8 2018, 7:07 PM · KWin

Oct 5 2018

Zren updated the diff for D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.
  • Got rid of the signal+slot that emits KNewStuff changes since wallpaperComboBox is automagically updated.
  • Reordered the command arguments so the variable is last in wallpaperplugin.knsrc.
  • Put the plasmoids.knsrc and wallpaperplugin.knsrc filepaths on separate lines in the CMakeList.txt
Oct 5 2018, 9:50 PM · Plasma
Zren added a comment to D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.

Finally got around to updating this patch and formally testing with kdesrc-build (sort of) in Neon Unstable which has Frameworks 5.51.

Oct 5 2018, 9:02 PM · Plasma

Sep 30 2018

Zren added inline comments to D15862: option to specify icons spacing for systray.
Sep 30 2018, 6:07 PM · Plasma
Zren added inline comments to D15862: option to specify icons spacing for systray.
Sep 30 2018, 6:05 PM · Plasma

Sep 24 2018

Zren added a comment to D15720: [TabBox] Fix Arrow Key / Keyboard Events in QML Alt+Tab Skins.

I confirmed that contentItem()->childItems() did indeed send it to mainItem. It also sends it to the FrameSvgItem too. It no longer sends it to the mysterious ColorScope.

Sep 24 2018, 6:10 AM · KWin
Zren requested review of D15720: [TabBox] Fix Arrow Key / Keyboard Events in QML Alt+Tab Skins.
Sep 24 2018, 4:29 AM · KWin

Sep 9 2018

Zren added a comment to D15373: [effects] Fix type of X-KWin-Video-Url.

I noticed this in https://phabricator.kde.org/D12249#247452, but didn't realize that it was missing the code for loading the effects in the KCM like D15372 adds. Nice work on D15372!

Sep 9 2018, 5:10 PM · KWin

Sep 6 2018

Zren requested review of D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale.
Sep 6 2018, 10:47 PM · Frameworks
Zren added a comment to D15309: [Calendar] Wrap day name index around.

Nice thinking on using repeater.count instead of the hardcoded 7!

Sep 6 2018, 10:23 PM · Frameworks

Aug 31 2018

Zren added a comment to D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.

The KPackage patch will end up in... Frameworks 5.51?
And the Plasma 5.14.0 release is set to depend on Frameworks... 5.45 (according to plasma-workspace's CMakeList.txt).
So we'll need to wait for the 5.14 tag to appear (Oct 4th), but to be safe, wait for the 5.14 release on Oct 9th.
Frameworks 5.51 is released Oct 13th, so it'll be easier to test after that (though I'll try to build kpackage with the patch and test it in a sec).
Alright, I'll set a reminder on Oct 17 (just after 5.14.1) to merge my 2 patches.

Aug 31 2018, 12:06 AM · Plasma

Aug 30 2018

Zren added a dependency for D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog: D15177: Emit signals when a package is installed/uninstalled.
Aug 30 2018, 11:43 PM · Plasma
Zren added a dependent revision for D15177: Emit signals when a package is installed/uninstalled: D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog.
Aug 30 2018, 11:43 PM · Frameworks

Jul 19 2018

Zren added a comment to D14234: [Folder View] Improve file name text rendering.

I tested the x: -main.x % 1 code.

Jul 19 2018, 6:09 PM · Plasma

Jul 14 2018

Zren added a comment to D14105: Use a broom-style icon for clearing clipboard and notification history.

Should the context menu also use this icon?

Jul 14 2018, 1:28 AM · Plasma

Jun 19 2018

Zren added a comment to D13596: Fix there being more security updates than total updates in notifier.

Thanks @apol for merging it. Thanks @ngraham for testing it and the link and @davidedmundson for explaining how bugfixes are merged.

Jun 19 2018, 9:22 PM · Plasma
Zren committed R134:9577e7d1d333: Fix there being more security updates than total updates in notifier (authored by Zren).
Fix there being more security updates than total updates in notifier
Jun 19 2018, 9:09 PM
Zren closed D13596: Fix there being more security updates than total updates in notifier.
Jun 19 2018, 9:09 PM · Plasma
Zren requested review of D13596: Fix there being more security updates than total updates in notifier.
Jun 19 2018, 12:26 AM · Plasma