Zren (Chris Holland)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 30 2016, 1:03 AM (71 w, 3 d)
Availability
Available

Recent Activity

Tue, Dec 5

Zren added a comment to D9201: Slightly reduce vertical gutter width..

Before patch:

Tue, Dec 5, 7:02 PM · Plasma

Nov 7 2017

Zren committed R252:35656828f12c: Support downloading the 2nd or 3rd download link from a KNS product (authored by Zren).
Support downloading the 2nd or 3rd download link from a KNS product
Nov 7 2017, 2:12 AM
Zren closed D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.
Nov 7 2017, 2:12 AM · Frameworks

Nov 5 2017

Zren added a comment to D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.

Quick note since I just notice you suggested a lowercase i in ?linkid=3, should I change it to lowercase or stick with camelcase?

Nov 5 2017, 6:55 PM · Frameworks

Nov 3 2017

Zren added a comment to D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.

Good idea. This will future proof us in case we ever want ?linkName=tiledmenu-v18-kde5.9.plasmoid or something as well.

Nov 3 2017, 3:29 PM · Frameworks
Zren updated the diff for D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.
Nov 3 2017, 3:28 PM · Frameworks
Zren added a reviewer for D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies: apol.
Nov 3 2017, 6:05 AM · Frameworks
Zren updated the test plan for D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.
Nov 3 2017, 6:00 AM · Frameworks
Zren updated the test plan for D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.
Nov 3 2017, 5:56 AM · Frameworks
Zren created D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies.
Nov 3 2017, 5:54 AM · Frameworks

Oct 26 2017

Zren added a comment to D5209: Load translations from KPackage files if bundled.

Another note: plasmoidviewer is unaffected by this patch. Meaning

Oct 26 2017, 2:49 AM · Frameworks, Plasma
Zren added a comment to D5209: Load translations from KPackage files if bundled.

This worked

Oct 26 2017, 2:34 AM · Frameworks, Plasma

Oct 23 2017

Zren added a comment to D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments.

No prob, thanks for accepting it (including the mockup stuff). It'll make it easier to test if I see anything else. 🙂

Oct 23 2017, 10:49 PM · Plasma
Zren committed R845:0ad9e0a1fdc2: Fix ActionItem Label width, minimumWidth=300, DPI scaled minimum size (authored by Zren).
Fix ActionItem Label width, minimumWidth=300, DPI scaled minimum size
Oct 23 2017, 10:36 PM
Zren closed D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments.
Oct 23 2017, 10:36 PM · Plasma

Oct 16 2017

Zren updated the summary of D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments.
Oct 16 2017, 4:18 AM · Plasma
Zren created D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments.
Oct 16 2017, 12:59 AM · Plasma

Oct 14 2017

Zren added a comment to T7200: Reduce tray clock size and/or make it configurable.

https://phabricator.kde.org/D6764

Oct 14 2017, 11:21 PM · Plasma, VDG

Aug 28 2017

Zren updated the diff for D7498: Add option to group hidden files and folders at the end.
Aug 28 2017, 12:28 AM

Aug 24 2017

Zren added a comment to D7498: Add option to group hidden files and folders at the end.

@broulik oh awesome. Uhg, not sure why I didn't see that function.

Aug 24 2017, 5:04 PM

Aug 23 2017

Zren created D7498: Add option to group hidden files and folders at the end.
Aug 23 2017, 10:56 PM

Aug 16 2017

Zren added a comment to D7355: Properly change buttons hit area to enforce Fitts law when windows are quick-tiled and or vertically/horizontally maximiezed. At the same time, do not draw the window round corners..

Neat. I gave it a test.

Aug 16 2017, 9:49 PM · Plasma

Jul 19 2017

Zren added inline comments to D6764: Use a smaller font size for digital clock plasmoid.
Jul 19 2017, 6:14 PM · Plasma

Jul 11 2017

Zren added a comment to D5209: Load translations from KPackage files if bundled.

Oh awesome. Just found out about this. So this would be added in Frameworks 5.37 then?

Jul 11 2017, 12:50 PM · Frameworks, Plasma

Jun 26 2017

Zren updated the diff for D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness.

Jump by 2px. Jump by __ clicks. Make sure thickness is even. Hide thickness in button after 1 second.

Jun 26 2017, 4:25 PM · Plasma
Zren added a comment to D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness.

Great idea about using a timer in the binding. I can probably keep the onThicknessChanged binding since it does change size when moved from left/right to top/bottom.

Jun 26 2017, 4:18 PM · Plasma
Zren created D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness.
Jun 26 2017, 1:17 PM · Plasma

Jun 22 2017

Zren committed R119:33793e9e2f56: [FolderView] Don't calculate extra spacing when we don't need to. (authored by Zren).
[FolderView] Don't calculate extra spacing when we don't need to.
Jun 22 2017, 12:02 AM
Zren closed D6322: [FolderView] Don't calculate extra spacing when we don't need to. by committing R119:33793e9e2f56: [FolderView] Don't calculate extra spacing when we don't need to..
Jun 22 2017, 12:02 AM · Plasma

Jun 21 2017

Zren updated the diff for D6322: [FolderView] Don't calculate extra spacing when we don't need to..

+semicolon and specify it's scrollArea.ready

Jun 21 2017, 8:07 PM · Plasma
Zren added inline comments to D6322: [FolderView] Don't calculate extra spacing when we don't need to..
Jun 21 2017, 8:04 PM · Plasma
Zren added inline comments to D6322: [FolderView] Don't calculate extra spacing when we don't need to..
Jun 21 2017, 7:37 PM · Plasma
Zren created D6322: [FolderView] Don't calculate extra spacing when we don't need to..
Jun 21 2017, 6:56 PM · Plasma
Zren added a comment to D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.

So before my commit, it was only needing to do:

qml: cellHeight iconHeight 108
qml: cellWidth iconWidth 92
qml: cellHeight iconHeight 108
Jun 21 2017, 6:34 PM · Plasma

Jun 20 2017

Zren added a comment to D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.

@hein Good catch with the && isRootView. It's just optimization since the extraSpace for the popup is 0 right? Now that I think on it, not sure why I made the variables into properties. Probably for logging onVarChanged when debugging it. Would this be more efficient?

Jun 20 2017, 9:59 PM · Plasma

Jun 15 2017

Zren committed R119:20ba491cb6bd: [Folder View] Pad cellWidth/cellHeight with the extra space (authored by Zren).
[Folder View] Pad cellWidth/cellHeight with the extra space
Jun 15 2017, 7:20 PM
Zren closed D6188: [Desktop] Pad cellWidth/cellHeight with the extra space by committing R119:20ba491cb6bd: [Folder View] Pad cellWidth/cellHeight with the extra space.
Jun 15 2017, 7:19 PM · Plasma

Jun 12 2017

Zren updated the diff for D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.

Semicolons... (I should install a linter)

Jun 12 2017, 9:17 PM · Plasma
Zren updated the diff for D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.

We don't really need to wait for folderViewLayer.ready before setting the bottom/right anchors anymore.
Don't add extra spacing if we're not a containment (the desktop).
Remove comment that's no longer applicable.

Jun 12 2017, 9:14 PM · Plasma
Zren added a comment to D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.

What behaviour should the folder widget use:

Jun 12 2017, 8:53 PM · Plasma
Zren added inline comments to D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.
Jun 12 2017, 8:29 PM · Plasma
Zren added a comment to D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.
In D6188#115982, @hein wrote:

You didn't change the comment above the code you modified. Did you test that this is no longer an issue? If not, the comment needs adjusting.

Jun 12 2017, 8:28 PM · Plasma
Zren created D6201: [Desktop] Avoid binding loop on label.width by anchoring left/right to the frame.
Jun 12 2017, 8:04 PM · Plasma
Zren updated the diff for D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.

+readonly. +semicolons.
Remove check for if we're already overflowing, using rtl layout, or if it's "arrange in columns/rows", since the ScrollView shouldn't be covered by panels.

Jun 12 2017, 6:11 PM · Plasma
Zren added a comment to D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.

Oh now I remember why I used scrollView.viewport. We don't want to count the scrollbars as "extra" space. Notice in this screenshot it would perfectly fit another row, but the scrollbar made the area shorter.

Jun 12 2017, 5:20 PM · Plasma
Zren added a comment to D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.

So removing the following two conditionals fixes it. I'm not sure why they are there. Right now it only stops at the panels if we're already overflowing.
in rightMargin: (folderViewLayer.view.overflowing || folderViewLayer.view.flow == GridView.FlowLeftToRight || folderViewLayer.view.layoutDirection == Qt.RightToLeft)
in bottomMargin: (folderViewLayer.view.overflowing || folderViewLayer.view.flow == GridView.FlowTopToBottom)

Jun 12 2017, 5:14 PM · Plasma
Zren added a comment to D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.

About panels covering the contents, perhaps you want to take into account plasmoid.availableScreenRect but root already has a margin based on this, so maybe just use the ScrollView's size instead of viewport.

Jun 12 2017, 5:01 PM · Plasma
Zren updated the diff for D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.

Cleaner logic in calcExtraSpacing().

Jun 12 2017, 2:50 AM · Plasma
Zren created D6188: [Desktop] Pad cellWidth/cellHeight with the extra space.
Jun 12 2017, 2:45 AM · Plasma

Jun 5 2017

Zren closed T6245: Cannot Reply to Comments as Resolved.

I tried commenting again today and it worked.

Jun 5 2017, 10:18 PM · KDE Store
Zren added a comment to D6095: [MPRIS Data Engine] Only register global shortcuts when loaded in plasmashell.

Hmm, just of this after reading a comment on reddit. Latte-Dock uses another process, would this cause keyboard shortcuts to not work for it? I'm not sure if it has a different app name.

Jun 5 2017, 1:14 AM · Plasma

Jun 1 2017

Zren added a comment to T6245: Cannot Reply to Comments.

I should also note that the list of 151 comments isn't related to the product, since the product https://store.kde.org/p/1153173 only has ~5 comments.

Jun 1 2017, 5:35 PM · KDE Store
Zren created T6245: Cannot Reply to Comments.
Jun 1 2017, 5:34 PM · KDE Store

May 25 2017

Zren updated the diff for D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it.

Apply to icons-dark too.

May 25 2017, 2:01 PM · Frameworks
Zren created D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it.
May 25 2017, 1:56 PM · Frameworks
Zren added a comment to D5932: KCM for controlling Night Color.

Is there a "daytime" setting or is it hardcoded to be 100% blue? Redshift Control for example:

May 25 2017, 12:12 PM · Plasma

May 13 2017

Zren added a comment to T5932: Add 2 KNS Categories when Searching+Downloading New Plasma Widgets.

Since people still can't install the moved widgets via GHNS, I'm moving my Tiled Menu widget back to the category "Plasma Widgets". Please don't move it back unless it can be installed with GHNS in the Plasma 5.8 LTS.

May 13 2017, 3:41 AM · KDE Store

May 6 2017

Zren added inline comments to D5729: #379003: Fix National Geographic POTD provider.
May 6 2017, 11:24 PM · Plasma
Zren removed a watcher for KNewStuff: Zren.
May 6 2017, 2:04 PM
Zren removed a watcher for KDE Store: Zren.
May 6 2017, 2:04 PM
Zren removed a watcher for Plasma: Zren.
May 6 2017, 2:03 PM

May 3 2017

Zren added a comment to D5695: Applet: Automatically raise maximum volume when over defined maximum volume.

Hmmm, this seems better than my solution since mine stays in the boosted state (slide.maxValue=150%) after the volume when back below 100%.

May 3 2017, 1:31 PM · Plasma

May 2 2017

Zren added a comment to D5684: Move all streams when changing default device.

I see you saw the /r/linux thread:
https://www.reddit.com/r/linux/comments/68jy8l/kde_users_how_do_you_switch_between_two_audio/

May 2 2017, 8:09 PM · Plasma

May 1 2017

Zren added a watcher for Plasma: Zren.
May 1 2017, 4:32 AM

Apr 27 2017

Zren removed a watcher for Plasma: Zren.
Apr 27 2017, 2:25 PM

Apr 26 2017

Zren added a watcher for KNewStuff: Zren.
Apr 26 2017, 5:01 PM

Apr 24 2017

Zren added a watcher for Plasma: Zren.
Apr 24 2017, 7:19 PM
Zren added a watcher for KDE Store: Zren.
Apr 24 2017, 7:17 PM
Zren added a comment to T5932: Add 2 KNS Categories when Searching+Downloading New Plasma Widgets.

Doesn't this change make those widget uninstallable with GHNS with the current, and more importantly, older versions of plasma?

Apr 24 2017, 7:04 PM · KDE Store

Apr 8 2017

Zren committed R115:d2323d77ec0e: Add license header to SmallToolButton.qml (authored by Zren).
Add license header to SmallToolButton.qml
Apr 8 2017, 9:21 PM
Zren committed R115:2ac365e96b70: Change the volume icon/mute button into a ToolButton (authored by Zren).
Change the volume icon/mute button into a ToolButton
Apr 8 2017, 9:12 PM
Zren closed D5144: Change the volume icon/mute button into a ToolButton by committing R115:2ac365e96b70: Change the volume icon/mute button into a ToolButton.
Apr 8 2017, 9:12 PM · Plasma
Zren added a comment to D5144: Change the volume icon/mute button into a ToolButton.

Should I go ahead and commit this?

Apr 8 2017, 2:31 AM · Plasma

Apr 3 2017

Zren updated the diff for D5144: Change the volume icon/mute button into a ToolButton.
Apr 3 2017, 5:31 PM · Plasma
Zren added a comment to D5144: Change the volume icon/mute button into a ToolButton.

I've seen that, but that is unrelated to this change, so please move it into separate review.

Apr 3 2017, 5:26 PM · Plasma

Mar 25 2017

Zren added a comment to D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths.

And yes I know KDE Neon is Qt 5.7.1 at the moment, I meant to ask wither it's part of the standard install of Qt.

Mar 25 2017, 5:12 PM · Plasma
Zren added a comment to D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths.

Oh neat! Hmm experimental Qt 5.8 library is fine, but would it be installed by default on say KDE Neon or would it need a package to be manually installed?

Mar 25 2017, 5:11 PM · Plasma

Mar 24 2017

Zren added a comment to D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths.

Thought you might want that, but wasn't sure how to expose QStandardPaths to QML. Got an example handy? All I can find is:

Mar 24 2017, 10:57 PM · Plasma
Zren created D5170: Provide other functions to localized ~/Videos, ~/Music, etc with QStandardPaths.
Mar 24 2017, 10:18 PM · Plasma

Mar 23 2017

Zren added a comment to D5144: Change the volume icon/mute button into a ToolButton.

Before tackling the implicitWidth/height stuff, I noticed that my microphone's Heading label was getting moved on the first click. Adding height: contextMenuButton.height fixes it but that doesn't feel right.

Mar 23 2017, 5:59 PM · Plasma
Zren updated the diff for D5144: Change the volume icon/mute button into a ToolButton.

Create a reusuble SmallToolButton class.
Add smallSpacing around the mute button.
Remove spacing between the two rows to counter the increase in height.

Mar 23 2017, 5:07 PM · Plasma
Zren added a comment to D5144: Change the volume icon/mute button into a ToolButton.

Another thing we could do to keep things small vertically is set spacing: 0 in the ColumnLayout { id: column }.

Mar 23 2017, 3:52 PM · Plasma
Zren added a comment to D5144: Change the volume icon/mute button into a ToolButton.

Ah, ignore the visible: false in that, was testing which variables ToolButton uses (iconSource. iconName).

Mar 23 2017, 3:43 PM · Plasma
Zren added a comment to D5144: Change the volume icon/mute button into a ToolButton.

Yeah, it's probably dpi scaling.

Mar 23 2017, 3:40 PM · Plasma
Zren added a comment to T5412: Improve Plasma PA usability.

I made D5144 which turns the volume icon/mute button into a ToolButton.

Mar 23 2017, 2:13 AM · VDG, Plasma
Zren created D5144: Change the volume icon/mute button into a ToolButton.
Mar 23 2017, 2:12 AM · Plasma
Zren added a comment to T5412: Improve Plasma PA usability.

Breeze's 16px small microphone-sensitivity-[low/medium/high] icons do not follow the color scheme. The 16px -muted, which is a softlink to the mic-off.svg icon is okay. This is because the style="color:#4d4d4d;..." which overrides the fill:currentColor. We'll need to remove those from

Mar 23 2017, 1:59 AM · VDG, Plasma
Zren added a comment to D5086: Applet: Add Raise maximum volume action to context menu.

Looks good.

Mar 23 2017, 1:10 AM · Plasma

Mar 9 2017

Zren committed R115:4d4867b89996: Fix context menu button's icon size when on default DPI (authored by Zren).
Fix context menu button's icon size when on default DPI
Mar 9 2017, 3:27 AM
Zren closed D4845: Fix context menu button's icon size when on default DPI by committing R115:4d4867b89996: Fix context menu button's icon size when on default DPI.
Mar 9 2017, 3:27 AM · Plasma

Mar 6 2017

Zren added a comment to D4845: Fix context menu button's icon size when on default DPI.

Ah, the contextMenu.show(x, y) changed to contextMenu.show().
I've got to comment out roundToIconSize: false in the mute "button" to test now since that probably requires a new version of frameworks.

Mar 6 2017, 2:04 AM · Plasma
Zren updated the diff for D4845: Fix context menu button's icon size when on default DPI.

Fix merge conflict based on removal of x/y parameters in contextmenu.show()
Change height from slider.height to units.iconSizes.small

Mar 6 2017, 2:03 AM · Plasma

Mar 1 2017

Zren added a comment to D4845: Fix context menu button's icon size when on default DPI.

@davidedmundson: Yes. I usually test in plasmoidviewer since it's the same (except for emoji rendering).

Mar 1 2017, 4:31 PM · Plasma

Feb 28 2017

Zren added a comment to D4845: Fix context menu button's icon size when on default DPI.

That's a good idea @broulik .

Feb 28 2017, 7:46 PM · Plasma
Zren updated the diff for D4845: Fix context menu button's icon size when on default DPI.

Remove || !parent.flat

Feb 28 2017, 6:26 PM · Plasma
Zren added inline comments to D4845: Fix context menu button's icon size when on default DPI.
Feb 28 2017, 6:00 PM · Plasma
Zren added inline comments to D4845: Fix context menu button's icon size when on default DPI.
Feb 28 2017, 5:54 PM · Plasma
Zren updated the summary of D4845: Fix context menu button's icon size when on default DPI.
Feb 28 2017, 5:43 PM · Plasma
Zren created D4845: Fix context menu button's icon size when on default DPI.
Feb 28 2017, 5:41 PM · Plasma

Feb 27 2017

Zren added a comment to D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port.

Oh crap. I just realized the stringlist => string error caused the svg not to load at all. Which means it wouldn't detect the margins from the svg. Essentially causing it to not add any "padding". If I copy "use anchors instead of fillHeight …" which is the only other new commit, it's still too small.

Feb 27 2017, 9:34 PM · Plasma