- User Since
- Apr 15 2019, 12:43 PM (58 w, 3 d)
Wed, May 20
Wed, May 13
Sat, May 2
I'd rather not lose our Plasma theming, but apparently it might be possible to conditionally load either a Plasma or QtQuick style from the same component set.
Apr 27 2020
I personally like the changes made, based on the screenshots, though TBH the buttons should probably be 1px higher or something... they seem a little too short to me.
Apr 20 2020
Apr 15 2020
Any update on the status of this?
Apr 12 2020
Random thought about the View Button for a potential future patch if necessary: Couldn't the single view button just not be click-dragged from the single view button to the view mode in the resulting menu that the user wants in order to keep the same amount of clicks as having them separated?
Apr 9 2020
Small idea for how I think implementing panel customisation in standard Global Edit Mode could go:
- Keep it as it is, but...
- No matter if Panel's Edit Mode popup is visible or not still have the whole panel Plasmoids movement addition that currently entering Panel Edit Mode gives you be accessible by simply editing Global Edit Mode and then only cease once Global Edit Mode is exited, rather than relying on the visibility of the Panel Edit Mode popup to do so (in other words make the state of the panel when the Panel Edit Mode popup is visible be the state the panels are always in when in Global Edit Mode, sans the Panel Edit Mode popup itself)
- Also keep the current toolbox on the right visible (when in G.E.M.) to enter the 'Advanced Panel Edit Mode' popup of that respective panel, just like how it's currently implemented
Apr 2 2020
How about instead of a blue dot there's instead an option in the SySe hamburger button menu to use search to filter out any settings pages where settings haven't been changed, meaning that only settings with changes made to them are then listed in the search results?
Mar 31 2020
IMHO this is wholly pointless a change, currently. Most people won't care about if they've made changes or not in SySe from the defaults, and quite frankly seeing that indicator on the sidebar would potentially even deter user customisation if not utterly confuse people. If it was an optional setting in settings to show these changed settings indicators on the sidebar (such as a checkbox item in the SySe menu) that you could turn off by default, I wouldn't mind this at all.
Mar 27 2020
I know I'm late in saying this but BTW elementary OS uses circles on checkboxes IIRC.
In my honest opinion, it'd probably be good to also get rid of Breeze Light in a separate patch because as I see it right now Breeze will make Breeze Light redundant by default post-this-patch since they'll both be Breeze Light in a sense. It just seems redundant to me to be honest having Breeze Light next to Breeze... Light... by default.
Mar 25 2020
Mar 21 2020
I'm not really sure about having that icon, that's shown as 'Home' icon in the demo video, on the left of the URL when it's inside the toolbar, but otherwise this looks great visually on first impressions.
Mar 20 2020
For the lack of text on Full Name, is there any chance some hint text could appear in the full name text box when the textbox value is empty saying something along the lines of "Full Name" or something?
While we're at it, it'd be good to finally have one text size for the panel overall. That includes the font size for Digital Clock (all modes), Task Manager, etc. (only the parts of those applets that have text on the panel itself)
Mar 19 2020
Mar 14 2020
Not gonna lie I prefer the last picture over the second last, but these dialog designs definitely look great.
Mar 8 2020
One more diff tweak to make it normal-er.
Rebased on master
Mar 5 2020
Some more things that may or may not have already been mentioned, given that some of us are considering the idea of moving the hotcorner to the bottom since it'd get in the way of the panel up top:
- Bottom-right hotcorner: Gets in the way of scrollbars...? (also mouse resting area)
- Bottom-left hotcorner: Gets in the way of Show Desktop (and the Panel Toolbox in Global Edit Mode)
- Bottom-center hotcorner: You'd, er, have to implement that first.
Mar 4 2020
There is currently an issue that might make this change cumbersome, unless it was fixed very recently as part of the patch work for this, being that preferred://browser causes duplicated entries for stuff like Vivaldi, etc (they'll be separate from the preferred:// pins meaning the preferred:// item basically acts as a quick launcher which is far from what is intended). Similar problem with preferred://filemanager. I would've used those instead of hard pins to vivaldi.desktop and org.kde.dolphin.desktop by default in Feren OS if it wasn't for that aforementioned issue being there.
Mar 1 2020
The main point of this patch is the spacing increase between tray icons that this hitbox size increase gives, which makes the tray look less cramped as a result.
Feb 29 2020
Went to check on different DPIs again to be sure it's fine and it definitely looks fine to me, scaling up the hitbox padding additions (and therefore the icon spacing) in sync with the DPI scaling very nicely, so that shouldn't be an issue.
Feb 18 2020
Moved baseSize declaration and changed it to a standard variable
You gotta love arc/git sometimes...
Hopefully fixed the diff again
Updated diff to be in line with parent patch
Tidied up code a bit and introduced new baseSize variable - Slightly increase system tray icon hitboxes in Non Tablet Mode Plasma
Feb 17 2020
...and now the split is complete.
Got rid of unnecessary rounding of smallSpacing at the end of the Tablet Mode padding addition
Make the click areas of system tray icons larger in Kirigami Tablet Mode
The initial patch of the three, now I've thought up a suitable way of doing this, has been made:
Actually, on second thought, @ngraham I'm not even sure if step 2 would even be worth it on its own, if possible.
Alright, I'll start splitting the patches up now. Marking this one as Abandoned.
@ngraham How would I split it into two patches? Both patches would edit the exact same line.
Had to lower the cmake version requirement to be able to compile this, but this works just fine, and it's definitely something that'd be nice to have. I can't see any regressions nor leaks, either on this current patch version.
Tweaked an added comment
Changed method used for increasing spacing between tray icons to something that increases hitbox sizes as well
Feb 16 2020
One more patch update to keep the change consistent with the rest of the code
Fair point, just checked that now and they're indeed the same. Got confused with 0.65 as 0.65 looks different to 0.5.
Went to 0.5, because 0.6 indeed looks just like 0.5 in execution
Changed value to Math.round(units.smallSpacing * 0.7)
Nevermind, then, I guess something changed between now and Plasma 5.18.1 master code meaning that no longer works, back to the old method...
Managed to come to a good compromise, however now I've hit a bit of a roadblock.
After a bit more digging around the code, I found another alternative way to do this which also fixes a bug I just noticed with this patch (there's clicking deadzones in-between the tray icons), however the method for doing it causes this spacing:
VS same but with / 2:
Which one would people prefer?
Would people prefer that above design to 2px? (actual Units.smallSpacing according to the HIG - https://hig.kde.org/layout/units.html) ^ (above message)
Here's it with / 2 added to the spacing value:
Changed spacing to units.smallSpacing
Patch update coming in a bit.