Differential D26053

Add icons to Konsole URL/mail context menu item
ClosedPublic
Actions

Authored by GB_2 on Dec 16 2019, 4:26 PM.

Details

Reviewers
ndavis
ngraham
Group Reviewers
Konsole
VDG
Commits
R319:37f2923b0b87: Add icons to Konsole URL/mail context menu item
Summary

URL:


Mail:

Test Plan

Open the context menu for an URL/mail address in Konsole.

Diff Detail

Repository
R319 Konsole
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19942
Build 19960: arc lint + arc unit
GB_2 created this revision.Dec 16 2019, 4:26 PM
Restricted Application added a project: Konsole. · View Herald TranscriptDec 16 2019, 4:26 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
GB_2 requested review of this revision.Dec 16 2019, 4:26 PM
GB_2 added a comment.EditedDec 16 2019, 4:28 PM

I added -url and -mail after edit-copy so it is possible to create specific icons later if wanted.

ndavis accepted this revision.Dec 16 2019, 4:57 PM
ndavis added a subscriber: ndavis.

+1

This revision is now accepted and ready to land.Dec 16 2019, 4:57 PM
ngraham accepted this revision.Dec 16 2019, 11:33 PM
ngraham added a subscriber: ngraham.

LGTM as well. Note that Konsole is on invent now.

GB_2 added a comment.Dec 17 2019, 8:40 AM
In D26053#579047, @ngraham wrote:

LGTM as well. Note that Konsole is on invent now.

Ok, I assume I can still land this here?

ngraham added a comment.Dec 17 2019, 2:06 PM

Yeah that's fine.

GB_2 added a comment.Dec 17 2019, 4:34 PM
This comment was removed by GB_2.
GB_2 closed this revision.Dec 17 2019, 4:37 PM

Revision Contents
Changeset List

PathPackages
Msrc/Filter.cpp (4 lines)

Diff 71682

View Options

src/Filter.cpp

Loading...