with the Plasma style buttons which have an icon look wrong. The icon size is too big and in consecuence the whole button is drawn way too big.
With this patch the icon is set to a standard size and drawn in the button layout, in a way it looks consistent with other button with no icons.
example:
Before path:
With patch:
BUG: 399952
FIXED-IN: 5.62
| No Linters Available |
| No Unit Test Coverage |
| Buildable 15749 | |
| Build 15767: arc lint + arc unit |
LGTM, just fix the whitespace issue
| src/declarativeimports/plasmacomponents3/Button.qml | ||
|---|---|---|
| 68 | unnecessary whitespace change | |
Same problem as the toolbutton one, button icons need to scale unless icon size fixed from client side
| src/declarativeimports/plasmacomponents3/Button.qml | ||
|---|---|---|
| 51 | no anchors and no enclosing Item. This was ok as it was, including fillwidth/fillheight (perhaps) | |
suggested changes. use preferred width and height when the icon group height and width props are set