gikari (Mikhail Zolotukhin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
May 12 2018, 10:11 AM (92 w, 2 d)
Availability
Available

Recent Activity

Today

gikari updated the diff for D27380: [GTK Config] Write Font without style name.

Use big helper function for constructing font style. Please test, many fonts may break and not work.

Mon, Feb 17, 7:43 PM · Plasma
gikari added a comment to D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them.

Since we plan to move more GTK related code to kde-gtk-config repo (specifically coloration of GTK apps from krdb), isn't it more reasonable to put this module in kde-gtk-config repo?

Mon, Feb 17, 7:32 PM · Plasma

Yesterday

gikari awarded D27438: Increase System Tray Plasmoid spacing value slightly a Yellow Medal token.
Sun, Feb 16, 5:51 PM · Plasma

Fri, Feb 14

gikari added a comment to D27380: [GTK Config] Write Font without style name.

Take this code

Fri, Feb 14, 8:44 AM · Plasma

Thu, Feb 13

gikari added a comment to D27380: [GTK Config] Write Font without style name.

So maybe that's something we can fix in the Fonts KCM? Or Is it caused by the Qt bug ultimately causing https://bugs.kde.org/show_bug.cgi?id=378523?

Thu, Feb 13, 10:06 PM · Plasma
gikari added a comment to D27380: [GTK Config] Write Font without style name.

Is the problem that the style name is already localized by the time we get it from the Fonts KCM?

Thu, Feb 13, 9:51 PM · Plasma
gikari updated the summary of D27380: [GTK Config] Write Font without style name.
Thu, Feb 13, 7:20 PM · Plasma
gikari requested review of D27380: [GTK Config] Write Font without style name.
Thu, Feb 13, 7:19 PM · Plasma

Wed, Feb 12

gikari committed R99:ddc9187adbc5: Provide better name for GTK Settings Sync service (authored by gikari).
Provide better name for GTK Settings Sync service
Wed, Feb 12, 7:40 PM
gikari closed D27093: Provide better name for GTK Settings Sync service.
Wed, Feb 12, 7:40 PM · Plasma
gikari abandoned D27090: Replace config.h with target_compile_definitions.

Fair point.

Wed, Feb 12, 7:00 PM · Plasma
gikari updated the diff for D27093: Provide better name for GTK Settings Sync service.

Remove "Appearance" part, since settings applied by kded module is not only about appearance (e.g. scrollbar behavior)

Wed, Feb 12, 6:53 PM · Plasma
gikari updated the diff for D27093: Provide better name for GTK Settings Sync service.

Capitalize GNOME and remove KDE/Qt part

Wed, Feb 12, 6:50 PM · Plasma

Tue, Feb 4

gikari committed R99:d892dc2b44ae: Upgrade theme to Breeze GTK on startup (authored by gikari).
Upgrade theme to Breeze GTK on startup
Tue, Feb 4, 5:40 PM
gikari committed R99:f4313eb66dfb: Merge branch 'Plasma/5.18' (authored by gikari).
Merge branch 'Plasma/5.18'
Tue, Feb 4, 5:40 PM
gikari closed D26891: Upgrade theme to Breeze GTK on startup.
Tue, Feb 4, 5:40 PM · Plasma

Sun, Feb 2

gikari updated the diff for D26891: Upgrade theme to Breeze GTK on startup.

Rename files to provide ground for more kconf scripts in the future

Sun, Feb 2, 11:34 PM · Plasma
gikari updated the test plan for D27107: Remove redundant reparse configuration call.
Sun, Feb 2, 8:12 PM · Plasma
gikari updated the diff for D27107: Remove redundant reparse configuration call.

Rollback the reparsings that are actually needed

Sun, Feb 2, 8:11 PM · Plasma
gikari added a comment to D27107: Remove redundant reparse configuration call.

You need to be careful here.

Some of this code is re-evaluated on receipt of other direct DBus signals. Not from kconfigwatcher.

In those cases, you will have to reparse.

Sun, Feb 2, 7:53 PM · Plasma
gikari requested review of D27107: Remove redundant reparse configuration call.
Sun, Feb 2, 7:28 PM · Plasma
gikari requested review of D27100: Parameterise GTK config editing.
Sun, Feb 2, 1:45 PM · Plasma

Sat, Feb 1

gikari updated the summary of D27093: Provide better name for GTK Settings Sync service.
Sat, Feb 1, 8:34 PM · Plasma
gikari added a reviewer for D27093: Provide better name for GTK Settings Sync service: VDG.
Sat, Feb 1, 8:32 PM · Plasma
gikari requested review of D27093: Provide better name for GTK Settings Sync service.
Sat, Feb 1, 8:32 PM · Plasma
gikari requested review of D27090: Replace config.h with target_compile_definitions.
Sat, Feb 1, 5:16 PM · Plasma
gikari added a comment to D26891: Upgrade theme to Breeze GTK on startup.

The differences between gtkrc and gtkrc-2.0 at least is that the first one was used for GTK1 and the second for GTK2.

Sat, Feb 1, 4:32 PM · Plasma

Fri, Jan 31

gikari updated the diff for D26891: Upgrade theme to Breeze GTK on startup.

Rebase on master

Fri, Jan 31, 8:50 PM · Plasma

Mon, Jan 27

gikari accepted D26947: Drop kconf_update module, handled by kde-gtk-config now.
Mon, Jan 27, 4:20 PM · Plasma
gikari added a comment to D26891: Upgrade theme to Breeze GTK on startup.

Tested, confirmed to work.

I wonder what's up with the gtkrc files everywhere:

~/.config/gtkrc-2.0
~/.config/gtkrc
~/.gtkrc-2.0
./.config/gtk-3.0

It seems like the first two are created by krdb, does it read both still?

Mon, Jan 27, 3:21 PM · Plasma
gikari added a comment to D26891: Upgrade theme to Breeze GTK on startup.

@meven wrote:

What if users have a different default theme set on first launch? I would suggest to read the current theme instead of hardcoding Breeze.

Mon, Jan 27, 2:52 PM · Plasma

Sun, Jan 26

gikari committed R99:7864ddd557a6: Merge branch 'Plasma/5.18' (authored by gikari).
Merge branch 'Plasma/5.18'
Sun, Jan 26, 7:24 PM
gikari added a comment to D26928: Correctly process font, that has multiple words in family name.

Can't style names have a space too?

Sun, Jan 26, 4:32 PM · Plasma
gikari closed D26928: Correctly process font, that has multiple words in family name.
Sun, Jan 26, 4:18 PM · Plasma
gikari committed R99:8bf4efd76430: Correctly process font, that has multiple words in family name (authored by gikari).
Correctly process font, that has multiple words in family name
Sun, Jan 26, 4:18 PM
gikari requested review of D26928: Correctly process font, that has multiple words in family name.
Sun, Jan 26, 3:24 PM · Plasma
gikari updated the test plan for D26891: Upgrade theme to Breeze GTK on startup.
Sun, Jan 26, 11:20 AM · Plasma
gikari updated the diff for D26891: Upgrade theme to Breeze GTK on startup.

Remove redundant theme update on startup

Sun, Jan 26, 11:17 AM · Plasma
gikari added inline comments to D26891: Upgrade theme to Breeze GTK on startup.
Sun, Jan 26, 11:16 AM · Plasma
gikari updated the test plan for D26891: Upgrade theme to Breeze GTK on startup.
Sun, Jan 26, 10:29 AM · Plasma
gikari updated the diff for D26891: Upgrade theme to Breeze GTK on startup.

Provide kconf_script to upgrade themes from old ones. It is mostly the same as the one in breeze-gtk repo, but better.

Sun, Jan 26, 10:26 AM · Plasma

Sat, Jan 25

gikari added a comment to D26891: Upgrade theme to Breeze GTK on startup.

@fvogt Do I understand correctly, that kconf_update script also run on Plasma update, if I add a new Id to one of .upd file (or add one with new Id)? For example from 5.17 to 5.18?

Sat, Jan 25, 11:09 PM · Plasma
gikari added inline comments to D26891: Upgrade theme to Breeze GTK on startup.
Sat, Jan 25, 5:24 PM · Plasma

Fri, Jan 24

gikari added a comment to D26891: Upgrade theme to Breeze GTK on startup.

It should only do the migration once, like the kconf_update script.

Fri, Jan 24, 1:59 PM · Plasma
gikari added a comment to D26891: Upgrade theme to Breeze GTK on startup.

If this is adjusted to include the migration code for older breeze-like GTK themes from https://cgit.kde.org/breeze-gtk.git/tree/kconf_update/main.cpp?id=b00e12ff39264fd8c2fb8af4168e998726766dfa, it should be possible to drop the kconf_update script there.
It might even cause conflicts otherwise.

Fri, Jan 24, 1:07 PM · Plasma
gikari added a comment to D26892: Switch to the old-style button text for the KNSQuick buttons.

This also should be changed in GTK Subpage in Application Style KCM (D26717)

Fri, Jan 24, 10:50 AM · Plasma
gikari added inline comments to D26891: Upgrade theme to Breeze GTK on startup.
Fri, Jan 24, 10:43 AM · Plasma
gikari requested review of D26891: Upgrade theme to Breeze GTK on startup.
Fri, Jan 24, 10:05 AM · Plasma

Thu, Jan 23

gikari committed R119:b61c2096e33b: Merge branch 'Plasma/5.18' (authored by gikari).
Merge branch 'Plasma/5.18'
Thu, Jan 23, 9:12 PM
gikari committed R119:51e6e92468f9: Remove misleading comment about the setting, that does not exist anymore (authored by gikari).
Remove misleading comment about the setting, that does not exist anymore
Thu, Jan 23, 9:11 PM
gikari closed D26885: Remove misleading comment about the setting, that does not exist anymore.
Thu, Jan 23, 9:11 PM · Plasma
gikari requested review of D26885: Remove misleading comment about the setting, that does not exist anymore.
Thu, Jan 23, 9:07 PM · Plasma
gikari accepted D26825: Bind gtk-enable-animations setting to global animation speed slider.
Thu, Jan 23, 10:26 AM · Plasma
gikari added a comment to D26825: Bind gtk-enable-animations setting to global animation speed slider.

Some typos, without them everything is OK.

Thu, Jan 23, 10:20 AM · Plasma

Wed, Jan 22

gikari committed R119:a2ab65ce5b21: Merge branch 'Plasma/5.18' (authored by gikari).
Merge branch 'Plasma/5.18'
Wed, Jan 22, 6:42 PM
gikari committed R119:74f7e06445ff: [App Style KCM] Hide preview buttons, if previewers are not found (authored by gikari).
[App Style KCM] Hide preview buttons, if previewers are not found
Wed, Jan 22, 6:30 PM
gikari closed D26770: [App Style KCM] Hide preview buttons, if previewers are not found.
Wed, Jan 22, 6:30 PM · Plasma
gikari added a comment to D26825: Bind gtk-enable-animations setting to global animation speed slider.

Also i found out, that gtk apps on start throw this error:

(org.gnome.Nautilus:4278): Gdk-WARNING **: 21:08:58.246: Cannot transform xsetting gtk-enable-animations of type gchararray to type gboolean

This is because of xsettingd config. You need to add Gtk/EnableAnimations to exceptions in QStringList nonStringProperties var in replaceValueInXSettingsdContents method, but it's only a hotfix. It is better to do some parameterezing with QVariants or C++ templates for ConfigEditor functions.

Wed, Jan 22, 6:24 PM · Plasma
gikari requested changes to D26825: Bind gtk-enable-animations setting to global animation speed slider.

Seems like dconf does not convert string to boolean.

(process:24285): GLib-GIO-CRITICAL **: 17:51:47.492: g_settings_set_value: key 'enable-animations' in 'org.gnome.desktop.interface' expects type 'b', but a GVariant of type 's' was given
Wed, Jan 22, 3:13 PM · Plasma
gikari added inline comments to D26825: Bind gtk-enable-animations setting to global animation speed slider.
Wed, Jan 22, 1:23 PM · Plasma
gikari added inline comments to D26825: Bind gtk-enable-animations setting to global animation speed slider.
Wed, Jan 22, 10:24 AM · Plasma

Mon, Jan 20

gikari committed R119:df7cd5b67604: Merge branch 'Plasma/5.18' (authored by gikari).
Merge branch 'Plasma/5.18'
Mon, Jan 20, 6:04 PM
gikari committed R119:8f7bbaa9d73c: [App Style KCM] Use QtQuick NewStuff dialogs (authored by gikari).
[App Style KCM] Use QtQuick NewStuff dialogs
Mon, Jan 20, 5:57 PM
gikari committed R119:6eaff2074093: [App Style KCM] Use QtQuick NewStuff dialogs (authored by gikari).
[App Style KCM] Use QtQuick NewStuff dialogs
Mon, Jan 20, 5:15 PM
gikari closed D26717: [App Style KCM] Use QtQuick NewStuff dialogs.
Mon, Jan 20, 5:15 PM · Plasma
gikari added a comment to D26777: [App Style KCM] Port away from QDBusInterface.
In D26777#597167, @apol wrote:

Why don't you just export the interface you are using through qdbusxml2cpp and viceversa? This way you don't need to have the glue code.

Mon, Jan 20, 10:18 AM · Plasma

Sun, Jan 19

gikari requested review of D26777: [App Style KCM] Port away from QDBusInterface.
Sun, Jan 19, 11:07 PM · Plasma
gikari updated the test plan for D26770: [App Style KCM] Hide preview buttons, if previewers are not found.
Sun, Jan 19, 5:17 PM · Plasma
gikari requested review of D26770: [App Style KCM] Hide preview buttons, if previewers are not found.
Sun, Jan 19, 5:15 PM · Plasma

Jan 17 2020

gikari updated the summary of D26717: [App Style KCM] Use QtQuick NewStuff dialogs.
Jan 17 2020, 11:19 AM · Plasma
gikari updated the diff for D26717: [App Style KCM] Use QtQuick NewStuff dialogs.

Port dialogs to QtQuick

Jan 17 2020, 11:18 AM · Plasma

Jan 16 2020

gikari planned changes to D26717: [App Style KCM] Use QtQuick NewStuff dialogs.

Ok, then.

Jan 16 2020, 8:55 PM · Plasma
gikari added a comment to D26717: [App Style KCM] Use QtQuick NewStuff dialogs.

Even better would be if we can use the new QML dialogs too. See D26544

Jan 16 2020, 8:52 PM · Plasma
gikari requested review of D26717: [App Style KCM] Use QtQuick NewStuff dialogs.
Jan 16 2020, 8:45 PM · Plasma

Jan 15 2020

gikari added a comment to T10611: Set options for GTK apps in the respective KCMs.

window decoration button orders

Jan 15 2020, 3:49 PM · Plasma: KCM Redesign
gikari committed R99:c21f1e7d25a7: Remove GTK KCM (authored by gikari).
Remove GTK KCM
Jan 15 2020, 3:34 PM
gikari added inline comments to D26583: [Application Style] Add GTK Application Style Page.
Jan 15 2020, 3:24 PM · Plasma
gikari committed R119:268c5ced8ec2: [Application Style] Add GTK Application Style Page (authored by gikari).
[Application Style] Add GTK Application Style Page
Jan 15 2020, 3:13 PM
gikari closed D26583: [Application Style] Add GTK Application Style Page.
Jan 15 2020, 3:13 PM · Plasma

Jan 14 2020

gikari updated the diff for D26583: [Application Style] Add GTK Application Style Page.

Return accidentally removed empty lines in kcmstyle.h

Jan 14 2020, 3:20 PM · Plasma
gikari updated the diff for D26583: [Application Style] Add GTK Application Style Page.

Remove columnCount method and fix rowCount method

Jan 14 2020, 3:13 PM · Plasma
gikari added inline comments to D26583: [Application Style] Add GTK Application Style Page.
Jan 14 2020, 3:07 PM · Plasma
gikari updated the diff for D26583: [Application Style] Add GTK Application Style Page.

Remove Q_SLOT keyword from load and add override to destructor

Jan 14 2020, 12:56 PM · Plasma

Jan 13 2020

gikari updated the diff for D26583: [Application Style] Add GTK Application Style Page.

Replace themeUpdate redundant signal with direct load call.

Jan 13 2020, 3:40 PM · Plasma
gikari updated the diff for D26583: [Application Style] Add GTK Application Style Page.

Undo previous hasty decision

Jan 13 2020, 3:28 PM · Plasma
gikari added a revision to T10611: Set options for GTK apps in the respective KCMs: D26593: Remove GTK KCM.
Jan 13 2020, 2:42 PM · Plasma: KCM Redesign
gikari added a task to D26593: Remove GTK KCM: T10611: Set options for GTK apps in the respective KCMs.
Jan 13 2020, 2:42 PM · Plasma
gikari updated the diff for D26583: [Application Style] Add GTK Application Style Page.

Replace include gtkpage with forward declaration

Jan 13 2020, 11:40 AM · Plasma

Jan 11 2020

gikari updated the diff for D26583: [Application Style] Add GTK Application Style Page.

Remove unnessary include and containsTheme function

Jan 11 2020, 10:59 PM · Plasma
gikari added a dependency for D26593: Remove GTK KCM: D26583: [Application Style] Add GTK Application Style Page.
Jan 11 2020, 10:29 PM · Plasma
gikari added a dependent revision for D26583: [Application Style] Add GTK Application Style Page: D26593: Remove GTK KCM.
Jan 11 2020, 10:29 PM · Plasma
gikari requested review of D26593: Remove GTK KCM.
Jan 11 2020, 10:29 PM · Plasma
gikari committed R99:1ebf620d361f: Rewrite GTK KCM (authored by gikari).
Rewrite GTK KCM
Jan 11 2020, 9:27 PM
gikari closed D26261: Rewrite GTK KCM.
Jan 11 2020, 9:27 PM · Plasma
gikari added a reviewer for D26583: [Application Style] Add GTK Application Style Page: broulik.
Jan 11 2020, 5:15 PM · Plasma
gikari updated the diff for D26583: [Application Style] Add GTK Application Style Page.

Do not init GtkPage*, if the kded module is not loaded

Jan 11 2020, 1:48 PM · Plasma
gikari updated the task description for T10611: Set options for GTK apps in the respective KCMs.
Jan 11 2020, 1:39 PM · Plasma: KCM Redesign
gikari added a reviewer for D26583: [Application Style] Add GTK Application Style Page: VDG.
Jan 11 2020, 1:38 PM · Plasma
gikari added a dependent revision for D26261: Rewrite GTK KCM: D26583: [Application Style] Add GTK Application Style Page.
Jan 11 2020, 1:34 PM · Plasma
gikari requested review of D26583: [Application Style] Add GTK Application Style Page.
Jan 11 2020, 1:34 PM · Plasma