gikari (Mikhail Zolotukhin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 12 2018, 10:11 AM (112 w, 1 d)
Availability
Available

Recent Activity

Mon, Jun 8

gikari committed R99:e2d4d1a48441: Merge branch 'Plasma/5.19' (authored by gikari).
Merge branch 'Plasma/5.19'
Mon, Jun 8, 6:13 PM
gikari committed R99:172607d8361f: Merge branch 'Plasma/5.19' (authored by gikari).
Merge branch 'Plasma/5.19'
Mon, Jun 8, 6:11 PM
gikari committed R99:4fe8217fc417: Fix incorrect palette name (authored by gikari).
Fix incorrect palette name
Mon, Jun 8, 6:08 PM

Jun 2 2020

gikari committed R99:e9372b83df13: Create README for the project (authored by gikari).
Create README for the project
Jun 2 2020, 9:35 AM

Jun 1 2020

gikari committed R108:7226e75bc8a8: Notify about decoration theme change (authored by gikari).
Notify about decoration theme change
Jun 1 2020, 2:19 AM

May 31 2020

gikari abandoned D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface).

See D29749

May 31 2020, 8:09 PM · Plasma
gikari abandoned D29749: [GTK Integration] Deprecate GTK2 (Hide GUI).

OK, let's wait a bit more until GIMP transitions. Still I would like to combine the GTK2 and GTK3 themes selection into one combobox or a list.

May 31 2020, 8:09 PM · Plasma
gikari abandoned D29509: Notify about decoration theme change.

Moved here: https://invent.kde.org/plasma/kwin/-/merge_requests/39

May 31 2020, 7:57 PM · KWin
gikari abandoned D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.

Moved here: https://invent.kde.org/plasma/kde-gtk-config/-/merge_requests/2

May 31 2020, 7:15 PM · Plasma

May 22 2020

gikari abandoned D26777: [App Style KCM] Port away from QDBusInterface.

I have a better idea of how to get rid of the dbus calls entirely in the future.

May 22 2020, 6:03 PM · Plasma

May 14 2020

gikari added a comment to D29749: [GTK Integration] Deprecate GTK2 (Hide GUI).
  1. There's still GIMP (and IIRC Audacity) when it comes to major GTK2 apps. I'm not saying don't do this, but maybe it's a bit premature?
May 14 2020, 2:50 PM · Plasma
gikari accepted D29756: Remove kiconthemes dependency.
May 14 2020, 2:26 PM · Plasma
gikari added reviewers for D29749: [GTK Integration] Deprecate GTK2 (Hide GUI): cblack, Plasma, VDG.
May 14 2020, 1:42 PM · Plasma
gikari added reviewers for D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface): cblack, Plasma.
May 14 2020, 1:42 PM · Plasma
gikari updated the test plan for D29749: [GTK Integration] Deprecate GTK2 (Hide GUI).
May 14 2020, 1:40 PM · Plasma
gikari added a dependency for D29749: [GTK Integration] Deprecate GTK2 (Hide GUI): D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface).
May 14 2020, 1:39 PM · Plasma
gikari added a dependent revision for D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface): D29749: [GTK Integration] Deprecate GTK2 (Hide GUI).
May 14 2020, 1:39 PM · Plasma
gikari updated the summary of D29749: [GTK Integration] Deprecate GTK2 (Hide GUI).
May 14 2020, 1:39 PM · Plasma
gikari updated the test plan for D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface).
May 14 2020, 1:38 PM · Plasma
gikari requested review of D29749: [GTK Integration] Deprecate GTK2 (Hide GUI).
May 14 2020, 1:38 PM · Plasma
gikari requested review of D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface).
May 14 2020, 1:32 PM · Plasma

May 9 2020

gikari added a comment to D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.

Just a question, SierraBreezeEnhanced has a feature called "Unison hovering". Does this support it?

May 9 2020, 1:05 PM · Plasma
gikari added a comment to D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.

Just a question, SierraBreezeEnhanced has a feature called "Unison hovering". Does this support it?

May 9 2020, 12:56 PM · Plasma
gikari updated the summary of D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
May 9 2020, 12:50 PM · Plasma
gikari updated the diff for D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
  • Add support for aurorae themes
  • Plastic does not work, but in that case decoration buttons in GTK apps are Breeze
May 9 2020, 12:49 PM · Plasma

May 8 2020

gikari added a comment to D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.

While this is neat, I'm fairly sure that creating the CSS for this in a manner that works across themes is going to be hard if not impossible.

May 8 2020, 5:25 PM · Plasma
gikari updated the summary of D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
May 8 2020, 5:04 PM · Plasma
gikari updated the diff for D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.

Export buttons with fixed geometry (Now all buttons are exported with the same size)

May 8 2020, 5:03 PM · Plasma
gikari updated the summary of D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
May 8 2020, 2:08 PM · Plasma
gikari updated the diff for D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.

Support the maximize button in the checked state

May 8 2020, 2:08 PM · Plasma

May 7 2020

gikari updated the summary of D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
May 7 2020, 2:46 PM · Plasma
gikari updated the test plan for D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
May 7 2020, 2:46 PM · Plasma
gikari added a dependent revision for D29509: Notify about decoration theme change: D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
May 7 2020, 2:39 PM · KWin
gikari added a dependency for D28623: [WIP] Sync titlebar button appearance with GTK CSD apps: D29509: Notify about decoration theme change.
May 7 2020, 2:39 PM · Plasma
gikari requested review of D29509: Notify about decoration theme change.
May 7 2020, 2:39 PM · KWin
gikari updated the summary of D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
May 7 2020, 2:30 PM · Plasma
gikari updated the diff for D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
  • Render buttons to SVGs
May 7 2020, 2:27 PM · Plasma

May 6 2020

gikari updated the diff for D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
  • Make buttons work with Breeze theme by respecting pallete.
May 6 2020, 9:44 PM · Plasma
gikari updated the diff for D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
  • Use unique_ptr for buttons
  • Propagate events to buttons
May 6 2020, 7:13 PM · Plasma
gikari added a comment to D29466: [applets/appmenu] Add search to global application menu.

Is it possible to integrate the search into the help menu, if it exists already or create an entry for it. Much like macOS does.

May 6 2020, 6:47 PM · Plasma
gikari updated the test plan for D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
May 6 2020, 5:41 PM · Plasma
gikari updated the diff for D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
  • Export decorations as png images
May 6 2020, 5:39 PM · Plasma

Apr 25 2020

gikari committed R119:fd6f3bacc91e: [GTK Subpage] Hide Breeze Dark for GTK3 (authored by gikari).
[GTK Subpage] Hide Breeze Dark for GTK3
Apr 25 2020, 2:51 PM
gikari closed D29176: [GTK Subpage] Hide Breeze Dark for GTK3.
Apr 25 2020, 2:51 PM · Plasma
gikari added a reviewer for D29176: [GTK Subpage] Hide Breeze Dark for GTK3: cblack.
Apr 25 2020, 11:56 AM · Plasma
gikari requested review of D29176: [GTK Subpage] Hide Breeze Dark for GTK3.
Apr 25 2020, 11:55 AM · Plasma

Apr 14 2020

gikari committed R99:a5d4ddb3b1a2: [GTK Config] Apply color scheme to GTK3 applications (authored by gikari).
[GTK Config] Apply color scheme to GTK3 applications
Apr 14 2020, 11:12 PM
gikari closed D28072: [GTK Config] Apply color scheme to GTK3 applications.
Apr 14 2020, 11:12 PM · Plasma
gikari committed R119:23aeddc99ad6: [KRDB] Remove GTK3 color export (authored by gikari).
[KRDB] Remove GTK3 color export
Apr 14 2020, 11:12 PM
gikari closed D28070: [KRDB] Remove GTK3 color export.
Apr 14 2020, 11:12 PM · Plasma
gikari added a comment to D28072: [GTK Config] Apply color scheme to GTK3 applications.

So, is it ok to land? If so, approve please.

Apr 14 2020, 7:04 PM · Plasma

Apr 11 2020

gikari resigned from D28658: [krdb] Drop GTK2 colour exporting.

No objections from me.

Apr 11 2020, 9:56 AM · Plasma

Apr 7 2020

gikari added a comment to D28658: [krdb] Drop GTK2 colour exporting.

We also need to remove the remaining GTK stuff from here once D28070 and D28072 are landed. Does anyone else wants to test the later?

Apr 7 2020, 9:15 PM · Plasma
gikari added a comment to D28072: [GTK Config] Apply color scheme to GTK3 applications.

Hm, this is bizarre. I've tested once again and now the bug I mentioned before is gone.

Apr 7 2020, 3:25 PM · Plasma
gikari added a comment to D28072: [GTK Config] Apply color scheme to GTK3 applications.

I also noticed a dynamic recoloration bug: it doesn't work if the app is launched with the color scheme, that it was using in the previous launch. To make it work I have to change color scheme and relaunch the app. The app therefore changes its color scheme to a new one and it is now reacting to color scheme change properly (i.e. changes it without restart).

Apr 7 2020, 3:04 PM · Plasma
gikari added a comment to D28072: [GTK Config] Apply color scheme to GTK3 applications.

Still doesn't work for me:

gnome-chess --gtk-module /home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so
Gtk-Message: 08:49:51.962: Failed to load module "colorreload-gtk-module"
Apr 7 2020, 2:59 PM · Plasma

Apr 6 2020

gikari updated the diff for D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
  • Add missed Licence header
  • Remove unnecessary CMake commands
Apr 6 2020, 2:34 PM · Plasma
gikari updated the summary of D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
Apr 6 2020, 2:14 PM · Plasma
gikari requested review of D28623: [WIP] Sync titlebar button appearance with GTK CSD apps.
Apr 6 2020, 2:13 PM · Plasma

Apr 4 2020

gikari updated the diff for D28072: [GTK Config] Apply color scheme to GTK3 applications.
  • Rebase on master
Apr 4 2020, 8:32 AM · Plasma

Apr 3 2020

gikari added a comment to D28072: [GTK Config] Apply color scheme to GTK3 applications.

@ngraham Did you manage to load the recoloration module into the GTK app by one or another way?

Apr 3 2020, 5:36 PM · Plasma

Apr 2 2020

gikari committed R99:0580098ab4cd: [GTK Config] Parameterise GTK config editing (authored by gikari).
[GTK Config] Parameterise GTK config editing
Apr 2 2020, 4:19 PM
gikari closed D27100: [GTK Config] Parameterise GTK config editing.
Apr 2 2020, 4:19 PM · Plasma

Apr 1 2020

gikari updated the diff for D27100: [GTK Config] Parameterise GTK config editing.
  • Remove explicit QVariant wrappers
Apr 1 2020, 8:23 PM · Plasma
gikari added a comment to D27100: [GTK Config] Parameterise GTK config editing.

Ping

Apr 1 2020, 7:58 PM · Plasma
gikari awarded D27669: [kstyle] Tools area a Yellow Medal token.
Apr 1 2020, 4:39 PM · Plasma

Mar 31 2020

gikari added a comment to D28072: [GTK Config] Apply color scheme to GTK3 applications.

Same error about not being able to find the module. Sorry for not being clear.

Mar 31 2020, 10:31 AM · Plasma

Mar 30 2020

gikari added a comment to D28072: [GTK Config] Apply color scheme to GTK3 applications.

The path would be /home/nate/kde/usr/lib64/gtk-3.0/ on my system, but nonetheless there is no effect. :(

Mar 30 2020, 8:29 PM · Plasma
gikari added a comment to D28072: [GTK Config] Apply color scheme to GTK3 applications.

Hmm, when following those instructions, I get the following console error:

Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module"

And the color scheme doesn't change. The colorreload-gtk3-module target did get built, and it installed a shared library to /home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so

Mar 30 2020, 7:43 PM · Plasma
gikari added a comment to D28072: [GTK Config] Apply color scheme to GTK3 applications.

GTK™ isn't too fond of trying to load stuff from outside the standard directories.

Mar 30 2020, 3:00 PM · Plasma

Mar 29 2020

gikari requested changes to D28360: cmake: make xsettingsd check an option.
Mar 29 2020, 11:07 PM · Plasma
gikari updated the diff for D28072: [GTK Config] Apply color scheme to GTK3 applications.
  • Rebase on master
  • Add recoloration module check
Mar 29 2020, 10:54 PM · Plasma
gikari updated the test plan for D28072: [GTK Config] Apply color scheme to GTK3 applications.
Mar 29 2020, 10:26 PM · Plasma
gikari accepted D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them.
Mar 29 2020, 10:17 PM · Plasma
gikari added a comment to D28360: cmake: make xsettingsd check an option.
Edit: and yes, I agree CMake has awful flaws here when it comes to our needs to properly communicate dependencies to fellow developers & packagers. I am trying to give you best practices done so far elsewhere in KDE software to deal with this, to ensure consistent patterns in the approach to the same problem :)
Mar 29 2020, 10:09 PM · Plasma
gikari added a comment to D28086: Improve CMake handling of GNOME libraries.

Everything is fine on CI.

Mar 29 2020, 4:50 PM · Plasma

Mar 28 2020

gikari added a comment to D28360: cmake: make xsettingsd check an option.

Edit: The proposed solution to make it simply required only forces packagers to add that and all what it pulls in as build-time dependency to their package creation, even if not needed for the package creation itself at all, which is not something packagers like (wastes resources on package build servers).

Mar 28 2020, 10:29 AM · Plasma

Mar 27 2020

gikari added a comment to D28360: cmake: make xsettingsd check an option.

But the option is enabled by default and needs to be explicitly disabled. This seems to be an overengineered solution. It basically says, that XSettingsd is an optional dependency, which already is.

But it make the packager aware, that this dependency exists, instead of at runtime, the end user wondering, why his/her Plasma desktop behaves differently from others.

Anecdote: obs-studio checks for pulseaudio at compile time, but fails silently(!) when it can't find it, leading users to wonder, why they can't record audio.

Mar 27 2020, 8:16 PM · Plasma
gikari added a comment to D28360: cmake: make xsettingsd check an option.

But the option is enabled by default and needs to be explicitly disabled. This seems to be an overengineered solution. It basically says, that XSettingsd is an optional dependency, which already is.

Mar 27 2020, 7:45 PM · Plasma
gikari added a comment to D28360: cmake: make xsettingsd check an option.

I would like to have this in 5.18

Mar 27 2020, 7:01 PM · Plasma
gikari added a comment to D28360: cmake: make xsettingsd check an option.

Why just not make xsettingsd required?

Mar 27 2020, 6:49 PM · Plasma
gikari added inline comments to D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them.
Mar 27 2020, 5:11 PM · Plasma
gikari accepted D28086: Improve CMake handling of GNOME libraries.

Ok, let's keep our eyes on CI now. Everything should be fine, since the dependencies didn't change.

Mar 27 2020, 11:59 AM · Plasma

Mar 23 2020

gikari added inline comments to D28086: Improve CMake handling of GNOME libraries.
Mar 23 2020, 11:03 PM · Plasma
gikari requested changes to D28086: Improve CMake handling of GNOME libraries.
Mar 23 2020, 10:57 PM · Plasma
gikari added a comment to D28086: Improve CMake handling of GNOME libraries.

See https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/49 for possible resolution

Mar 23 2020, 11:08 AM · Plasma
gikari reopened D28086: Improve CMake handling of GNOME libraries.
Mar 23 2020, 10:50 AM · Plasma

Mar 21 2020

gikari added a comment to D28086: Improve CMake handling of GNOME libraries.

This has been reverted. @cblack, please take a look at what has happened. Seems like CI is missing some dependency.

Mar 21 2020, 11:30 AM · Plasma
gikari committed R99:73d26edeba0e: Revert "Improve CMake handling of GNOME libraries" (authored by gikari).
Revert "Improve CMake handling of GNOME libraries"
Mar 21 2020, 9:01 AM
gikari added a reverting change for R99:db87b4d270a1: Improve CMake handling of GNOME libraries: R99:73d26edeba0e: Revert "Improve CMake handling of GNOME libraries".
Mar 21 2020, 9:01 AM

Mar 20 2020

gikari awarded T12839: Fix sizing of first-party plasmoids in the panel a Like token.
Mar 20 2020, 10:53 PM · Plasma, VDG, Goal: Consistency

Mar 18 2020

gikari updated the diff for D27100: [GTK Config] Parameterise GTK config editing.

Rebase on master

Mar 18 2020, 12:41 PM · Plasma

Mar 17 2020

gikari added inline comments to D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them.
Mar 17 2020, 9:57 PM · Plasma
gikari retitled D28072: [GTK Config] Apply color scheme to GTK3 applications from [WIP][GTK Config] Apply color scheme to GTK3 applications to [GTK Config] Apply color scheme to GTK3 applications.
Mar 17 2020, 7:16 PM · Plasma
gikari removed a dependent revision for D27956: [Various KCMs] Notify about changes in GTK related settings: D28072: [GTK Config] Apply color scheme to GTK3 applications.
Mar 17 2020, 7:15 PM · Plasma
gikari removed a dependent revision for D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them: D28072: [GTK Config] Apply color scheme to GTK3 applications.
Mar 17 2020, 7:15 PM · Plasma
gikari removed a dependent revision for D27957: [GTK Config] Port all settings to KConfigWatcher: D28072: [GTK Config] Apply color scheme to GTK3 applications.
Mar 17 2020, 7:15 PM · Plasma
gikari removed dependencies for D28072: [GTK Config] Apply color scheme to GTK3 applications: D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them, D27956: [Various KCMs] Notify about changes in GTK related settings, D27957: [GTK Config] Port all settings to KConfigWatcher.
Mar 17 2020, 7:15 PM · Plasma
gikari updated the test plan for D28072: [GTK Config] Apply color scheme to GTK3 applications.
Mar 17 2020, 7:14 PM · Plasma
gikari updated the diff for D28072: [GTK Config] Apply color scheme to GTK3 applications.
  • Remove the recolor module. It is D28076 now
Mar 17 2020, 7:01 PM · Plasma